Re: Review Board 1.7.1 released

2012-12-21 Thread pfee
Hi Stephen and Christian,

Excellent - thanks for your work.

I tried this out on F18 beta, yum install worked without issue.  I then 
issued "rb-site install /var/www/reviewboard".

I had adjusted unix permissions so that rb-site could create 
/var/www/reviewboard.
I had setup mysql authorisation, such that the mysql user had all 
privileges within the "reviewboard" database.

However I get a couple of popup dialogs:
1) Unable to execute the manager command
evolve: No module named docutils.core

2) Unable to execute the manager command
registerscmtools: No module named docutils.core

Probably more importantly, I get this error on the console
django.db.utils.DatabaseError: (1146, "Table 'reviewboard.auth_user' 
doesn't exist")

It looks as though rb-site is connecting to mysql, but is not creating any 
tables.

Is "yum install ReviewBoard", followed by "rb-site install" the correct 
procedure?  Is there a Django step such as "manage.py syncdb" require in 
between?  I'm not sure if this is a Fedora packaging issue or a general 
reviewboard problem.

Thanks,
Paul

On Wednesday, 19 December 2012 20:25:15 UTC, Christian Hammond wrote:
>
> Congrats Stephen! Excellent work as always. I know that was a particularly 
> hairy one. 
>
> Btw, I just put out a Djblets 1.7.8 to fix a JavaScript issue that was 
> introduced, which I'll be announcing shortly. 
>
> Happy holidays! 
>
> Christian 
>
>
> On Dec 19, 2012, at 11:21 AM, Stephen Gallagher 
> > 
> wrote: 
>
> > On Wed 19 Dec 2012 05:04:39 AM EST, Christian Hammond wrote: 
> >> Hi everyone, 
> >> 
> >> To those of you who upgraded to 1.7.0 and hit some upgrade problems, 
> >> I'd like to apologize and also thank you for your reports. We've fixed 
> >> up a number of these issues for those who haven't upgraded yet, and 
> >> rolled it into 1.7.1. 
> >> 
> >> There's also a new checkbox when configuring GitHub repositories for 
> >> automatically associating your SSH key as a deploy key on GitHub. 
> >> 
> >> http://www.reviewboard.org/news/2012/12/19/review-board-1-7-1-released/ 
> >> 
> > 
> > 
> > It's been a long road (and many thanks for your help, Christian!) but we 
> finally have Review Board 1.7.1 in Fedora! 
> > 
> > 
> https://admin.fedoraproject.org/updates/ReviewBoard-1.7.1-1.fc18,python-djblets-0.7.7-1.fc18,python-django-pipeline-1.2.17-1.fc18
>  
> > 
> > For now, we're only supporting Fedora 18 and later. Some of the 
> dependencies, notably Node.js for the less.js compressor currently aren't 
> available on Fedora 17. I'm going to look into that (and support on EPEL 6) 
> in the new year. 
> > 
> > Happy Holidays, folks! 
> > 
> > -- 
> > Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/ 
> > Happy user? Let us know at http://www.reviewboard.org/users/ 
> > -~--~~~~--~~--~--~--- 
> > To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.com  
> > For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en 
> > 
> > 
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Review Board 1.7.1 released

2012-12-21 Thread pfee
Hi Stephen,

Installing python-docutils got past those popup errors, only to reveal 
similar errors about the lack of "markdown".

Installing python-markdown fixed this second set of popup errors. rb-site 
now proceeds to create the DB tables and then runs successfully to 
completion.

Hence that's two dependencies you need, python-docutils and python-markdown.

Thanks for your help,
Paul

On Friday, 21 December 2012 12:49:11 UTC, Stephen Gallagher wrote:
>
> On 12/21/2012 06:18 AM, pfee wrote: 
> > Hi Stephen and Christian, 
> > 
> > Excellent - thanks for your work. 
> > 
> > I tried this out on F18 beta, yum install worked without issue.  I then 
> > issued "rb-site install /var/www/reviewboard". 
> > 
> > I had adjusted unix permissions so that rb-site could create 
> > /var/www/reviewboard. 
> > I had setup mysql authorisation, such that the mysql user had all 
> > privileges within the "reviewboard" database. 
> > 
> > However I get a couple of popup dialogs: 
> > 1) Unable to execute the manager command 
> > evolve: No module named docutils.core 
> > 
> > 2) Unable to execute the manager command 
> > registerscmtools: No module named docutils.core 
> > 
>
> This one is a packaging issue. I forgot to add a dependency on 
> python-docutils. I'll fix that up in the next version. In the meantime, 
> if you 'yum install python-docutils' you should be able to get past this. 
>
>
>
>
> > Probably more importantly, I get this error on the console 
> > django.db.utils.DatabaseError: (1146, "Table 'reviewboard.auth_user' 
> > doesn't exist") 
> > 
> > It looks as though rb-site is connecting to mysql, but is not creating 
> > any tables. 
> > 
> > Is "yum install ReviewBoard", followed by "rb-site install" the correct 
> > procedure?  Is there a Django step such as "manage.py syncdb" require in 
> > between?  I'm not sure if this is a Fedora packaging issue or a general 
> > reviewboard problem. 
> > 
>
> Can you try with python-docutils installed first? It may be that it just 
> didn't complete the site-installation and thus didn't get to the part 
> where it created the database. 
>
>
> > Thanks, 
> > Paul 
> > 
> > On Wednesday, 19 December 2012 20:25:15 UTC, Christian Hammond wrote: 
> > 
> > Congrats Stephen! Excellent work as always. I know that was a 
> > particularly hairy one. 
> > 
> > Btw, I just put out a Djblets 1.7.8 to fix a JavaScript issue that 
> > was introduced, which I'll be announcing shortly. 
> > 
> > Happy holidays! 
> > 
> > Christian 
> > 
> > 
> > On Dec 19, 2012, at 11:21 AM, Stephen Gallagher 
> > > wrote: 
> > 
> >  > On Wed 19 Dec 2012 05:04:39 AM EST, Christian Hammond wrote: 
> >  >> Hi everyone, 
> >  >> 
> >  >> To those of you who upgraded to 1.7.0 and hit some upgrade 
> > problems, 
> >  >> I'd like to apologize and also thank you for your reports. We've 
> > fixed 
> >  >> up a number of these issues for those who haven't upgraded yet, 
> and 
> >  >> rolled it into 1.7.1. 
> >  >> 
> >  >> There's also a new checkbox when configuring GitHub repositories 
> > for 
> >  >> automatically associating your SSH key as a deploy key on 
> GitHub. 
> >  >> 
> >  >> 
> > 
> http://www.reviewboard.org/news/2012/12/19/review-board-1-7-1-released/ 
> > <
> http://www.reviewboard.org/news/2012/12/19/review-board-1-7-1-released/> 
> > 
> >  >> 
> >  > 
> >  > 
> >  > It's been a long road (and many thanks for your help, Christian!) 
> > but we finally have Review Board 1.7.1 in Fedora! 
> >  > 
> >  > 
> > 
> https://admin.fedoraproject.org/updates/ReviewBoard-1.7.1-1.fc18,python-djblets-0.7.7-1.fc18,python-django-pipeline-1.2.17-1.fc18
>  
> > <
> https://admin.fedoraproject.org/updates/ReviewBoard-1.7.1-1.fc18,python-djblets-0.7.7-1.fc18,python-django-pipeline-1.2.17-1.fc18>
>  
>
> > 
> >  > 
> >  > For now, we're only supporting Fedora 18 and later. Some of the 
> > dependencies, notably Node.js for the less.js compressor currently 
> > aren't available on Fedora 17. I'm going to look 

Re: Review Board 1.7.1 released

2012-12-21 Thread pfee
Hi Christian,

I think my next issue is with ReviewBoard rather than Fedora.

The Apache configuration generated by rb-site includes this line:
Options -Indexes FollowSymLinks

This mixes options starting with +/- with those without a prefix.  The 
documentation for httpd 2.2 warns this can lead to unexpected results 
(https://httpd.apache.org/docs/2.2/mod/core.html#options).  However httpd 
2.4 is stricter, causing the server to abort 
(https://httpd.apache.org/docs/2.4/mod/core.html#options).

Fedora 18 uses Apache httpd 2.4.3, hence the httpd config generated by 
rb-site will not work.  I adjusted the line as follows, though I'm not sure 
if that's appropriate.
Options -Indexes +FollowSymLinks

Thanks,
Paul

On Friday, 21 December 2012 13:14:48 UTC, pfee wrote:
>
> Hi Stephen,
>
> Installing python-docutils got past those popup errors, only to reveal 
> similar errors about the lack of "markdown".
>
> Installing python-markdown fixed this second set of popup errors. rb-site 
> now proceeds to create the DB tables and then runs successfully to 
> completion.
>
> Hence that's two dependencies you need, python-docutils and 
> python-markdown.
>
> Thanks for your help,
> Paul
>
> On Friday, 21 December 2012 12:49:11 UTC, Stephen Gallagher wrote:
>>
>> On 12/21/2012 06:18 AM, pfee wrote: 
>> > Hi Stephen and Christian, 
>> > 
>> > Excellent - thanks for your work. 
>> > 
>> > I tried this out on F18 beta, yum install worked without issue.  I then 
>> > issued "rb-site install /var/www/reviewboard". 
>> > 
>> > I had adjusted unix permissions so that rb-site could create 
>> > /var/www/reviewboard. 
>> > I had setup mysql authorisation, such that the mysql user had all 
>> > privileges within the "reviewboard" database. 
>> > 
>> > However I get a couple of popup dialogs: 
>> > 1) Unable to execute the manager command 
>> > evolve: No module named docutils.core 
>> > 
>> > 2) Unable to execute the manager command 
>> > registerscmtools: No module named docutils.core 
>> > 
>>
>> This one is a packaging issue. I forgot to add a dependency on 
>> python-docutils. I'll fix that up in the next version. In the meantime, 
>> if you 'yum install python-docutils' you should be able to get past this. 
>>
>>
>>
>>
>> > Probably more importantly, I get this error on the console 
>> > django.db.utils.DatabaseError: (1146, "Table 'reviewboard.auth_user' 
>> > doesn't exist") 
>> > 
>> > It looks as though rb-site is connecting to mysql, but is not creating 
>> > any tables. 
>> > 
>> > Is "yum install ReviewBoard", followed by "rb-site install" the correct 
>> > procedure?  Is there a Django step such as "manage.py syncdb" require 
>> in 
>> > between?  I'm not sure if this is a Fedora packaging issue or a general 
>> > reviewboard problem. 
>> > 
>>
>> Can you try with python-docutils installed first? It may be that it just 
>> didn't complete the site-installation and thus didn't get to the part 
>> where it created the database. 
>>
>>
>> > Thanks, 
>> > Paul 
>> > 
>> > On Wednesday, 19 December 2012 20:25:15 UTC, Christian Hammond wrote: 
>> > 
>> > Congrats Stephen! Excellent work as always. I know that was a 
>> > particularly hairy one. 
>> > 
>> > Btw, I just put out a Djblets 1.7.8 to fix a JavaScript issue that 
>> > was introduced, which I'll be announcing shortly. 
>> > 
>> > Happy holidays! 
>> > 
>> > Christian 
>> > 
>> > 
>> > On Dec 19, 2012, at 11:21 AM, Stephen Gallagher 
>> > > wrote: 
>> > 
>> >  > On Wed 19 Dec 2012 05:04:39 AM EST, Christian Hammond wrote: 
>> >  >> Hi everyone, 
>> >  >> 
>> >  >> To those of you who upgraded to 1.7.0 and hit some upgrade 
>> > problems, 
>> >  >> I'd like to apologize and also thank you for your reports. 
>> We've 
>> > fixed 
>> >  >> up a number of these issues for those who haven't upgraded yet, 
>> and 
>> >  >> rolled it into 1.7.1. 
>> >  >> 
>> >  >> There's also a new checkbox when configuring GitHub 
>> repositories 
>> > for 
>> >  >&g

Testing 1.7.1 on Fedora 18

2013-01-03 Thread pfee
Hi Stephen,

After running rb-site install and visiting the website, I get errors about a 
couple of directories not being writeable.  The web page helpfully suggests a 
couple of "chmod -R" commands.  However on Fedora the SELinux profile for the 
httpd process prevents writing regardless of unix permissions.  I'm not sure if 
there's anything Fedora can do to make that easier for users, perhaps it's just 
something to document.  The SELinux Troubleshooter correctly indicates how to 
workaround this issue.

Hi Christian,

With my test site up and running, I had a brief look around.  Here are a few 
issues I noticed on the admin pages:

On the Admin dashboard, System Information section on left hand side
1) Both "Review Emails" and "Email TLS Authentication" are hyperlinks to the 
same page.  Should they be different links or would one link would be 
sufficient?
2) "Indexed Search" links to "/admin/settings/general", which is the same as 
the "General" link at the system settings section.  Perhaps this is influence 
by my install not having PyLucene.  Should "Indexed Search" link to a different 
page?

3) General Settings admin page mentions "PyLucene (with JCC) is required to 
enable search. See the documentation for instructions.".  The documentation 
link points to 
http://www.reviewboard.org/docs/manual/dev/admin/sites/enabling-search/ however 
that serves up a 404 Not Found page.
4) Review Board Activity: Clicking on the four toggle buttons (Reviews, 
Comments, Review Requests, Changes) affects how much data is plotted.  The 
graph goes from four datasets down to one.  Deactivating the last toggle greys 
out the last button, but doesn't remove the last dataset from the graph (tested 
on Firefox 17, Fedora 17).

Hope that feedback's useful,
Paul




>
> From: Christian Hammond 
>To: "reviewboard@googlegroups.com"  
>Cc: "reviewboard@googlegroups.com" ; pfee 
>; "chip...@chipx86.com"  
>Sent: Friday, 21 December 2012, 21:24
>Subject: Re: Review Board 1.7.1 released
> 
>
>Hmm, first time anybody has reported this, and that line has been there for 
>years. I'll make sure to fix it, but it'll only affect new installs.
>
>
>Christian
>
>
>On Dec 21, 2012, at 5:37, pfee  wrote:
>
>
>Hi Christian,
>>
>>I think my next issue is with ReviewBoard rather than Fedora.
>>
>>The Apache configuration generated by rb-site includes this line:
>>Options -Indexes FollowSymLinks
>>
>>This mixes options starting with +/- with those without a prefix.  The 
>>documentation for httpd 2.2 warns this can lead to unexpected results 
>>(https://httpd.apache.org/docs/2.2/mod/core.html#options).  However httpd 2.4 
>>is stricter, causing the server to abort 
>>(https://httpd.apache.org/docs/2.4/mod/core.html#options).
>>
>>Fedora 18 uses Apache httpd 2.4.3, hence the httpd config generated by 
>>rb-site will not work.  I adjusted the line as follows, though I'm not sure 
>>if that's appropriate.
>>Options -Indexes +FollowSymLinks
>>
>>Thanks,
>>Paul
>>
>>On Friday, 21 December 2012 13:14:48 UTC, pfee  wrote:
>>Hi Stephen,
>>>
>>>Installing python-docutils got past those popup errors, only to reveal 
>>>similar errors about the lack of "markdown".
>>>
>>>Installing python-markdown fixed this second set of popup errors. rb-site 
>>>now proceeds to create the DB tables and then runs successfully to 
>>>completion.
>>>
>>>Hence that's two dependencies you need, python-docutils and python-markdown.
>>>
>>>Thanks for your help,
>>>Paul
>>>
>>>On Friday, 21 December 2012 12:49:11 UTC, Stephen Gallagher  wrote:
>>>On 12/21/2012 06:18 AM, pfee wrote: 
>>>>> Hi Stephen and Christian, 
>>>>> 
>>>>> Excellent - thanks for your work. 
>>>>> 
>>>>> I tried this out on F18 beta, yum install worked without issue.  I then 
>>>>> issued "rb-site install /var/www/reviewboard". 
>>>>> 
>>>>> I had adjusted unix permissions so that rb-site could create 
>>>>> /var/www/reviewboard. 
>>>>> I had setup mysql authorisation, such that the mysql user had all 
>>>>> privileges within the "reviewboard" database. 
>>>>> 
>>>>> However I get a couple of popup dialogs: 
>>>>> 1) Unable to execute the manager command 
>>>>> evolve: No module named docutils.core 
>>>>> 
>>>>

Re: Testing 1.7.1 on Fedora 18

2013-01-04 Thread pfee
Bug created as requested: 
http://code.google.com/p/reviewboard/issues/detail?id=2846


Thanks,
Paul




>
> From: Christian Hammond 
>To: p...@talk21.com 
>Cc: "reviewboard@googlegroups.com" ; Stephen 
>Gallagher  
>Sent: Friday, 4 January 2013, 0:27
>Subject: Re: Testing 1.7.1 on Fedora 18
> 
>
>Hi,
>
>
>
>
>On Thu, Jan 3, 2013 at 8:47 AM,  wrote:
>
>Hi Stephen,
>>
>>
>>After running rb-site install and visiting the website, I get errors about a 
>>couple of directories not being writeable.  The web page helpfully suggests a 
>>couple of "chmod -R" commands.  However on Fedora the SELinux profile for the 
>>httpd process prevents writing regardless of unix permissions.  I'm not sure 
>>if there's anything Fedora can do to make that easier for users, perhaps it's 
>>just something to document.  The SELinux Troubleshooter correctly indicates 
>>how to workaround this issue.
>>
>>
>>Hi Christian,
>>
>>With my test site up and running, I had a brief look around.  Here are a few 
>>issues I noticed on the admin pages:
>>
>>
>>On the Admin dashboard, System Information section on left hand side
>>1) Both "Review Emails" and "Email TLS Authentication" are hyperlinks to the 
>>same page.  Should they be different links or would one link would be 
>>sufficient?
>
>
>Yeah, they're just all quick ways of jumping to the setting for the page. The 
>sidebar is meant to be a quick at-a-glance of certain setting values, and 
>clicking on them takes you to the page containing that setting. There's going 
>to be some overlap.
>
>
> 
>2) "Indexed Search" links to "/admin/settings/general", which is the same as 
>the "General" link at the system settings section.  Perhaps this is influence 
>by my install not having PyLucene.  Should "Indexed Search" link to a 
>different page?
>>
>
>
>Nope, same as above.
>
>
> 
>3) General Settings admin page mentions "PyLucene (with JCC) is required to 
>enable search. See the documentation for instructions.".  The documentation 
>link points to 
>http://www.reviewboard.org/docs/manual/dev/admin/sites/enabling-search/ 
>however that serves up a 404 Not Found page.
>
>
>I'll make sure to fix the link for the next release.
>
>
> 
>4) Review Board Activity: Clicking on the four toggle buttons (Reviews, 
>Comments, Review Requests, Changes) affects how much data is plotted.  The 
>graph goes from four datasets down to one.  Deactivating the last toggle greys 
>out the last button, but doesn't remove the last dataset from the graph 
>(tested on Firefox 17, Fedora 17).
>
>
>Would you mind filing a bug on this one? I'll see what we can do about it. 
>Hoping to get some unit tests in place for these widgets in time.
>
>
>Thanks!
>
>
>Christian
>
>
>-- 
>Christian Hammond - chip...@chipx86.com
>Review Board - http://www.reviewboard.org
>VMware, Inc. - http://www.vmware.com
>
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Testing 1.7.1 on Fedora 18

2013-01-04 Thread pfee
Hi Stephen,

The following AVC denied errors occur:

1) named_connect to port 11211 (memcached)
type=AVC msg=audit(1357289094.993:338): avc:  denied  { name_connect } for  
pid=1668 comm="httpd" dest=11211 scontext=system_u:system_r:httpd_t:s0 
tcontext=system_u:object_r:memcache_port_t:s0 tclass=tcp_socket

Reviewboard 1.7.1 by default uses memcached, it seems like the SELinux profile 
for httpd doesn't allow TCP connections to port 11211.  This failure does not 
prevent reviewboard from working, but is likely to affect performance.  Should 
the profile shipped with Fedora be extended to allow these connections by 
default?


[Unix permissions]
Reviewboard initially detects that write permission is not available and 
returns a web page instructing the user to grant write permission with these 
commands:
$ sudo chown -R apache "/var/www/reviewboard/data"
$ sudo chown -R apache "/var/www/reviewboard/htdocs/media/ext"


Once the permissions are changed, SELinux still prevents write access.


2) write to ext directory
type=AVC msg=audit(1357289565.991:401): avc:  denied  { write } for  pid=1665 
comm="httpd" name="ext" dev="dm-1" ino=1896 
scontext=system_u:system_r:httpd_t:s0 
tcontext=unconfined_u:object_r:httpd_sys_content_t:s0 tclass=dir


SELinux context is currently:

$ ls -ldZ /var/www/reviewboard/htdocs/media/ext/
drwxrwxr-x. apache pafee unconfined_u:object_r:httpd_sys_content_t:s0 
/var/www/reviewboard/htdocs/media/ext/


Suggestion from SELinux Trouble shooter fixed this issue:
$ sudo restorecon -v /var/www/reviewboard/htdocs/media/ext
$ ls -ldZ /var/www/reviewboard/htdocs/media/ext/
drwxrwxr-x. apache pafee unconfined_u:object_r:httpd_sys_rw_content_t:s0 
/var/www/reviewboard/htdocs/media/ext/


I agree it would be difficult for Fedora to predict where a reviewboard site 
would be placed.  Would it be possible for "rb-site install" to set the SELinux 
security contexts of the files it creates?

Thanks,
Paul




>
> From: Stephen Gallagher 
>To: p...@talk21.com 
>Cc: "chip...@chipx86.com" ; Christian Hammond 
>; "reviewboard@googlegroups.com" 
> 
>Sent: Thursday, 3 January 2013, 18:25
>Subject: Re: Testing 1.7.1 on Fedora 18
> 
>On Thu 03 Jan 2013 11:47:06 AM EST, p...@talk21.com wrote:
>> Hi Stephen,
>> 
>> After running rb-site install and visiting the website, I get errors
>> about a couple of directories not being writeable.  The web page
>> helpfully suggests a couple of "chmod -R" commands.  However on Fedora
>> the SELinux profile for the httpd process prevents writing regardless
>> of unix permissions.  I'm not sure if there's anything Fedora can do
>> to make that easier for users, perhaps it's just something to
>> document.  The SELinux Troubleshooter correctly indicates how to
>> workaround this issue.
>> 
>
>
>We can't really make this easier because we don't have advance knowledge of 
>where you're installing the Review Board site. I *think* what you need to do 
>is set the following SELinux contexts (with 'chcon -t  file' or 
>'chcon -R -r  directory'):
>
>1) apache-wsgi.conf needs to be httpd_config_t
>2) $SITE_DIR/htdocs and $SITE_DIR/data (if using an SQLITE DB) need to be 
>httpd_sys_content_t
>
>What else did the Troubleshooter say? I'm naming those from memory.
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Testing 1.7.1 on Fedora 18

2013-01-04 Thread pfee
Hi Stephen,

Another SELinux error I missed:


3) write to data directory
Occurs when user tries to login.
type=AVC msg=audit(1357290519.860:433): avc:  denied  { write } for  pid=1666 
comm="httpd" name="data" dev="dm-1" ino=1884 
scontext=system_u:system_r:httpd_t:s0 
tcontext=unconfined_u:object_r:httpd_sys_content_t:s0 tclass=dir


As with the ext directory, this was fixed using the suggestion from SELinux 
trouble shooter:

$ ls -ldZ /var/www/reviewboard/data
drwxrwxr-x. apache pafee unconfined_u:object_r:httpd_sys_content_t:s0 
/var/www/reviewboard/data
$ sudo restorecon -v /var/www/reviewboard/data/
restorecon reset /var/www/reviewboard/data context 
unconfined_u:object_r:httpd_sys_content_t:s0->unconfined_u:object_r:httpd_sys_rw_content_t:s0
$ ls -ldZ /var/www/reviewboard/data
drwxrwxr-x. apache pafee unconfined_u:object_r:httpd_sys_rw_content_t:s0 
/var/www/reviewboard/data


Fixing the two write denials allows reviewboard to function normally.

Regarding memcached, in addition to the SELinux named_connect restriction, the 
memcached package is not installed.  It's not a mandatory dependency of 
reviewboard, however the rb-site script does configure it by default.  Should 
memcached be required by the F18 reviewboard package?

A couple of commands allowed reviewboard to make use of memcached.  This was 
verified by seeing the server cache stats present on the admin dashboard.

$ sudo yum install memcached
$ sudo systemctl start memcached.service


Thanks,
Paul




>
> From: "p...@talk21.com" 
>To: Stephen Gallagher  
>Cc: "chip...@chipx86.com" ; Christian Hammond 
>; "reviewboard@googlegroups.com" 
> 
>Sent: Friday, 4 January 2013, 9:07
>Subject: Re: Testing 1.7.1 on Fedora 18
> 
>
>Hi Stephen,
>
>The following AVC denied errors occur:
>
>1) named_connect to port 11211 (memcached)
>type=AVC msg=audit(1357289094.993:338): avc:  denied  { name_connect } for  
>pid=1668 comm="httpd" dest=11211 scontext=system_u:system_r:httpd_t:s0 
>tcontext=system_u:object_r:memcache_port_t:s0 tclass=tcp_socket
>
>Reviewboard 1.7.1 by default uses memcached, it seems like the SELinux profile 
>for httpd doesn't allow TCP connections to port 11211.  This failure does not 
>prevent reviewboard from working, but is likely to affect performance.  Should 
>the profile shipped with Fedora be extended to allow these connections by 
>default?
>
>
>
>[Unix permissions]
>Reviewboard initially detects that write permission is not available and 
>returns a web page instructing the user to grant write permission with these 
>commands:
>$ sudo chown -R apache "/var/www/reviewboard/data"
>$ sudo chown -R apache "/var/www/reviewboard/htdocs/media/ext"
>
>
>
>Once the permissions are changed, SELinux still prevents write access.
>
>
>
>2) write to ext directory
>type=AVC msg=audit(1357289565.991:401): avc:  denied  { write } for  pid=1665 
>comm="httpd" name="ext" dev="dm-1" ino=1896 
>scontext=system_u:system_r:httpd_t:s0 
>tcontext=unconfined_u:object_r:httpd_sys_content_t:s0 tclass=dir
>
>
>
>SELinux context is currently:
>
>$ ls -ldZ /var/www/reviewboard/htdocs/media/ext/
>drwxrwxr-x. apache pafee unconfined_u:object_r:httpd_sys_content_t:s0 
>/var/www/reviewboard/htdocs/media/ext/
>
>
>
>Suggestion from SELinux Trouble shooter fixed this issue:
>$ sudo restorecon -v /var/www/reviewboard/htdocs/media/ext
>$ ls -ldZ /var/www/reviewboard/htdocs/media/ext/
>drwxrwxr-x. apache pafee unconfined_u:object_r:httpd_sys_rw_content_t:s0 
>/var/www/reviewboard/htdocs/media/ext/
>
>
>
>I agree it would be difficult for Fedora to predict where a reviewboard site 
>would be placed.  Would it be possible for "rb-site install" to set the 
>SELinux security contexts of the files it creates?
>
>
>Thanks,
>Paul
>
>
>
>
>>
>> From: Stephen Gallagher 
>>To: p...@talk21.com 
>>Cc: "chip...@chipx86.com" ; Christian Hammond 
>>; "reviewboard@googlegroups.com" 
>> 
>>Sent: Thursday, 3 January 2013, 18:25
>>Subject: Re: Testing 1.7.1 on Fedora 18
>> 
>>On Thu 03 Jan 2013 11:47:06 AM EST, p...@talk21.com wrote:
>>> Hi Stephen,
>>> 
>>> After running rb-site install and visiting the website, I get errors
>>> about a couple of directories not being writeable. 
 The web page
>>> helpfully suggests a couple of "chmod -R" commands.  However on Fedora
>>> the SELinux profile for the httpd process prevents writing regardless
>>> of unix permissions.  I'm not sure if there's anything Fedora can do
>>> to make that easier for users, perhaps it's just something to
>>> document.  The SELinux Troubleshooter correctly indicates how to
>>> workaround this issue.
>>> 
>>
>>
>>We can't really make this easier because we don't have advance knowledge of 
>>where you're installing the Review Board site. I *think* what you need to do 
>>is set the following SELinux contexts (with 'chcon -t  file' or 
>>'chcon -R -r  directory'):
>>
>>1) apache-wsgi.conf needs to be httpd_config_t
>>2) $SITE_DIR/htdocs and $SITE_D

Re: Testing 1.7.1 on Fedora 18

2013-01-08 Thread pfee
Hi Stephen,

Bug raised as requested.  I didn't see a place to set the CC field on the 
google/reviewboard bug tracker, so here's the URL so you can "star" it and get 
yourself CCed.

http://code.google.com/p/reviewboard/issues/detail?id=2850

Thanks,
Paul





>
> From: Stephen Gallagher 
>To: p...@talk21.com 
>Cc: "chip...@chipx86.com" ; Christian Hammond 
>; "reviewboard@googlegroups.com" 
> 
>Sent: Monday, 7 January 2013, 19:55
>Subject: Re: Testing 1.7.1 on Fedora 18
> 
>On 01/04/2013 04:07 AM, p...@talk21.com wrote:
>> Hi Stephen,
>>
>> The following AVC denied errors occur:
>>
>> 1) named_connect to port 11211 (memcached)
>> type=AVC msg=audit(1357289094.993:338): avc:  denied  { name_connect }
>> for  pid=1668 comm="httpd" dest=11211
>> scontext=system_u:system_r:httpd_t:s0
>> tcontext=system_u:object_r:memcache_port_t:s0 tclass=tcp_socket
>>
>> Reviewboard 1.7.1 by default uses memcached, it seems like the SELinux
>> profile for httpd doesn't allow TCP connections to port 11211.  This
>> failure does not prevent reviewboard from working, but is likely to
>> affect performance.  Should the profile shipped with Fedora be extended
>> to allow these connections by default?
>>
>
>It's a boolean in the shipped configuration:
>
>setsebool -P httpd_can_network_memcache 1
>
>
>> [Unix permissions]
>> Reviewboard initially detects that write permission is not available and
>> returns a web page instructing the user to grant write permission with
>> these commands:
>> $ sudo chown -R apache "/var/www/reviewboard/data"
>> $ sudo chown -R apache "/var/www/reviewboard/htdocs/media/ext"
>>
>> Once the permissions are changed, SELinux still prevents write access.
>>
>
>The individual permissions have nothing to do with SELinux. As I said in 
>my other email, you need to make sure these files have the right context 
>set (or install the site into /var/www/html, but I don't recommend that).
>
>
>> 2) write to ext directory
>> type=AVC msg=audit(1357289565.991:401): avc:  denied  { write } for
>> pid=1665 comm="httpd" name="ext" dev="dm-1" ino=1896
>> scontext=system_u:system_r:httpd_t:s0
>> tcontext=unconfined_u:object_r:httpd_sys_content_t:s0 tclass=dir
>>
>> SELinux context is currently:
>> $ ls -ldZ /var/www/reviewboard/htdocs/media/ext/
>> drwxrwxr-x. apache pafee unconfined_u:object_r:httpd_sys_content_t:s0
>> /var/www/reviewboard/htdocs/media/ext/
>>
>> Suggestion from SELinux Trouble shooter fixed this issue:
>> $ sudo restorecon -v /var/www/reviewboard/htdocs/media/ext
>> $ ls -ldZ /var/www/reviewboard/htdocs/media/ext/
>> drwxrwxr-x. apache pafee unconfined_u:object_r:httpd_sys_rw_content_t:s0
>> /var/www/reviewboard/htdocs/media/ext/
>>
>> I agree it would be difficult for Fedora to predict where a reviewboard
>> site would be placed.  Would it be possible for "rb-site install" to set
>> the SELinux security contexts of the files it creates?
>>
>
>I know this is possible from the libsemanage-python package. We could 
>probably rig something up, but it's not going to be a trivial patch. 
>Could you open a bug on the Review Board tracker about this and make 
>sure I'm CCed on it, please? Christian, I'll look into this one since I 
>have a (limited) SELinux background.
>
>It would certainly be nice to have Review Board properly protected by 
>SELinux.
>
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Testing 1.7.1 on Fedora 18

2013-01-16 Thread pfee
Hi Stephen,

Thanks for working on the reviewboard 1.7 packages for Fedora 18.


Do you have plans for building a reviewboard 1.7 package for the EPEL repo?  
Currently EPEL contains reviewboard 1.6.15.

http://koji.fedoraproject.org/koji/packageinfo?packageID=9694
http://dl.fedoraproject.org/pub/epel/6/x86_64/repoview/ReviewBoard.html

It's great to trial the latest and greatest on Fedora, but I'd like to use RHEL 
in production.

Thanks,
Paul




>
> From: "p...@talk21.com" 
>To: Stephen Gallagher  
>Cc: "chip...@chipx86.com" ; Christian Hammond 
>; "reviewboard@googlegroups.com" 
> 
>Sent: Tuesday, 8 January 2013, 12:42
>Subject: Re: Testing 1.7.1 on Fedora 18
> 
>
>Hi Stephen,
>
>Bug raised as requested.  I didn't see a place to set the CC field on the 
>google/reviewboard bug tracker, so here's the URL so you can "star" it and get 
>yourself CCed.
>
>http://code.google.com/p/reviewboard/issues/detail?id=2850
>
>Thanks,
>Paul
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Review Board 1.7.2 is released

2013-01-18 Thread pfee
Thanks Stephen,

I upgraded from 1.7.1 to 1.7.2, no issues.  Bodhi karma dispensed.

On Thursday, 17 January 2013 14:57:29 UTC, Stephen Gallagher wrote:
>
> On 01/17/2013 01:58 AM, Christian Hammond wrote: 
> > Hi everyone, 
> > 
> > Review Board 1.7.2 is out. Lots of bug fixes and a few new features. See 
> > the news post and release notes for more info. 
> > 
> > http://www.reviewboard.org/news/2013/01/16/review-board-1-7-2-released/ 
> > 
> > We'll have a new RBTools out pretty soon with some nice improvements as 
> > well. 
>
>
> Fedora packages are now available for testing: 
> https://admin.fedoraproject.org/updates/ReviewBoard-1.7.2-1.fc18 
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: Ask for working example of apache-wsgi.conf for Apache 2.4

2013-01-23 Thread pfee
I had some trouble with ReviewBoard 1.7.1 and the httpd config it generated.

Fedora 18 ships with Apache httpd 2.4, I had to adjust the following line:
Options -Indexes FollowSymLinks

Fixed line:
Options -Indexes +FollowSymLinks

This has been fixed in ReviewBoard 1.7.2, 
http://www.reviewboard.org/docs/releasenotes/dev/reviewboard/1.7.2/
"Fixed default Apache configuration files to be explicit in enabling 
FollowSymLinks"

Hope that helps,
Paul

On Tuesday, 22 January 2013 09:23:15 UTC, Tao Zhou wrote:
>
> When installing Review Board using command rb-site install 
> reviews.example.com,
> The generated apache-wsgi.conf is for Apache 2.2, not for Apache 2.4,
> Does anyone tried to make Review board working for Apache 2.4, and could 
> kindly provide an example config?
>
> Thanks!
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en




Re: ReviewBoard 1.7.6 for EPEL 6

2013-04-15 Thread pfee
Fantastic!

Many thanks for all your efforts.




>
> From: Christian Hammond 
>To: "reviewboard@googlegroups.com"  
>Cc: "reviewboard@googlegroups.com" ; pfee 
> 
>Sent: Monday, 15 April 2013, 0:02
>Subject: Re: ReviewBoard 1.7.6 for EPEL 6
> 
>
>Congrats! I know that was hard fought.
>
>Christian
>
>
>On Apr 14, 2013, at 15:06, Stephen Gallagher  wrote:
>
>> After much blood, sweat and tears, I have finally managed to land
>> ReviewBoard 1.7.6 in the EPEL 6 add-on repository for Red Hat Enterprise
>> Linux 6 (and its clones). The update should filter out to the
>> [epel-testing] mirrors in the next 24-48 hours. Please test carefully
>> and provide feedback if anything is amiss.
>> 
>> Note: this is a major version upgrade. Please, PLEASE back up your
>> database before upgrading to these packages.
>> 
>> 
>> https://admin.fedoraproject.org/updates/ReviewBoard-1.7.6-4.el6.3,python-django-evolution-0.6.9-1.el6.1,python-slimit-0.7.4-3.el6,nodejs-less-1.3.3-3.el6,python-djblets-0.7.11-2.el6,python-django-pipeline-1.2.24-2.el6
>> 
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>> 
>> 
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: ReviewBoard 1.7.6 for EPEL 6

2013-04-19 Thread pfee





>
> From: Alfred von Campe 
>To: reviewboard@googlegroups.com 
>Cc: pfee  
>Sent: Thursday, 18 April 2013, 23:42
>Subject: Re: ReviewBoard 1.7.6 for EPEL 6
> 
>
>Thanks for making this available.  It can't wait to try it out, but
>I've waited 4 days, and I still don't see the new version:
>
>Can you verify that it made it to the mirrors?
>
>Alfred
>
>
>
It's currently in epel-testing.  Can you install it with:

# yum --enablerepo=epel-testing install ReviewBoard

If you find it works without issue, give the package some karma (via link 
below), that'll speed up its journey into the stable epel repo.

https://admin.fedoraproject.org/updates/ReviewBoard-1.7.6-4.el6.3,python-django-evolution-0.6.9-1.el6.1,python-slimit-0.7.4-3.el6,nodejs-less-1.3.3-3.el6,python-djblets-0.7.11-2.el6,python-django-pipeline-1.2.24-2.el6

Thanks,
Paul

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee
Hi Christian, Stephen,

While testing Stephen's Fedora packages, on a F18 machine I upgraded from 
1.7.7.1 to 1.7.9.  Following the upgrade, I expected visiting the site's 
/dashboard URL would have told me to run "rb-site upgrade".  Instead I got 
a 500 "Something broke..." message.

Despite not being prompted, I ran "rb-site upgrade /var/www/reviewboard" 
anyway.  The site came back to life and started working again as expected, 
however someone upgrading for the first time would not know to do this.

The output of "rb-site upgrade" is below, are the "unapplied evolutions" 
message a cause for concern?
=
# rb-site upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
Upgrading Review Board from 1.7.7.1 to 1.7.9
There are unapplied evolutions for accounts.
There are unapplied evolutions for hostingsvcs.
There are unapplied evolutions for reviews.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Evolution successful.
---  ---

Resetting in-database caches.

Upgrade complete!


Thanks,
Paul

On Tuesday, 4 June 2013 05:50:46 UTC+1, Christian Hammond wrote:
>
> Hi Angus,
>
> Looks like there's a small issue in the dependency rule that breaks 
> easy_install's resolution for the version.
>
> Packagers, I'm going to be deploying a quick hotfix update to this, but 
> without a version number bump. It's nothing but a package metadata change. 
> Since you control your own metadata, this shouldn't affect you.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>  
> On Jun 3, 2013, at 9:48 PM, Angus Ku > 
> wrote:
>
> Hi Christian,
>
> There is no Djblets-0.7.15-py2.7.egg folder in my 
> "/usr/local/lib/python2.7/dist-packages" directory.
> So, I tried to run "easy_install -U Djblets" manually and Djblets 0.7.15 
> can be downloaded.
> After that, I use "easy_install -U ReviewBoard" to upgrade to 1.7.9 and 
> then the issue is gone.
>
> So, I wonder that does "easy_install -U ReviewBoard" lack for checking the 
> dependency of Djblets?
>
> BTW, thanks a lot for you help!  ^.^
>
>
>
> Christian Hammond於 2013年6月4日星期二UTC+8下午12時16分28秒寫道:
>>
>> Hi Angus,
>>
>> You're definitely running an old version of Djblets. That would explain 
>> it, though I can't explain why you would be on that version.
>>
>> Is there a Djblets-0.7.15-py2.7.egg directory alongside the 0.7.12 
>> directory by any chance?
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>  
>> On Jun 3, 2013, at 9:14 PM, Angus Ku  wrote:
>>
>> Hi Christian,
>>
>> Here is the result,
>>
>> import djbPython 2.7.3 (default, Aug  1 2012, 05:14:39)
>> [GCC 4.6.3] on linux2
>> Type "help", "copyright", "credits" or "license" for more information.
>> (InteractiveConsole)
>> le>>> import djblets
>> >>> djblets.__file__
>>
>> '/usr/local/lib/python2.7/dist-packages/Djblets-0.7.12-py2.7.egg/djblets/__init__.pyc'
>>
>> Our repository is using Subversion.
>>
>> Thanks!
>>
>> Christian Hammond於 2013年6月4日星期二UTC+8上午11時55分13秒寫道:
>>>
>>> Hi Angus,
>>>
>>> The "evolution is required" message is normal, and just part of our 
>>> standard database migration work that rb-site does on your behalf.
>>>
>>> Can you verify for me what version of Djblets is installed? You can do:
>>>
>>> rb-site manage /path/to/site shell
>>> >>> import djblets
>>> >>> djblets.__file__
>>>
>>> I want to rule out an older version of Djblets being used. The log you 
>>> pasted shows that our logger is never even being used, which should not be 
>>> possible unless something else being executed went out of its way to 
>>> override it.
>>>
>>> Can you also tell me what type of repository you're working with?
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chi...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>  
>>> On Jun 3, 2013, at 8:44 PM, Angus Ku  wrote:
>>>
>>> Hi Christian,
>>>
>>> Thanks for your reply.
>>> I just follow the standard installation guide from the website to setup 
>>> my server using Apache and mod_wsgi.
>>> I don't do any custom modifications for all ReviewBoard files and 
>>> settings.
>>> But, I think i got a message " an evolution is required" when I run 
>>> "rb-site upgrade" from 1.7.7.1 to 1.7.9. Any actions should I take?
>>>
>>> BTW, currently, I downgrade my ReviewBoard from 1.7.9 to 1.7.7.1, and 
>>> the view diff page works again. 
>>>
>>>
>>>
>>> Christian Hammond於 2013年6月4日星期二UTC+8上午11時15分09秒寫道:

Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee
Hi Christian,

Using Firefox/Firebug, I see that the icon above the "My Account, Admin, 
Log Off" menu is server from an external site:

http://www.gravatar.com/avatar/0657fda85d3463a3e0784bc6f2e14b69?s=32

Is there a reason why this isn't bundled with ReviewBoard?  Someone using 
ReviewBoard from a network isolated from the public Internet would not be 
able to access this image.

Thanks,
Paul

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee
Thanks for the explanation.  I wasn't aware of gravatar, hence I can view 
this as a feature not a bug :)

On Tuesday, 4 June 2013 10:51:00 UTC+1, Christian Hammond wrote:
>
> Hi Paul,
>
> We've had gravatar support ever since 1.7 came out.
>
> Gravatar.com is pretty much the de-facto standard avatar provider out 
> there, which lots of services and even developer tools integrate with. 
> We're optimizing for the 99% case where you at least have a proxy server 
> set up to reach the outside world.
>
> Worst thing that happens otherwise is that you get a blank image. Oh well.
>
> We may provide a way of customizing this in Review Board Enterprise, since 
> larger companies often have their own in-house employee photos/avatars 
> stored somewhere.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>  
> On Jun 4, 2013, at 2:10 AM, pfee > wrote:
>
> Hi Christian,
>
> Using Firefox/Firebug, I see that the icon above the "My Account, Admin, 
> Log Off" menu is server from an external site:
>
> http://www.gravatar.com/avatar/0657fda85d3463a3e0784bc6f2e14b69?s=32
>
> Is there a reason why this isn't bundled with ReviewBoard?  Someone using 
> ReviewBoard from a network isolated from the public Internet would not be 
> able to access this image.
>
> Thanks,
> Paul
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Reviewboard operation during VCS failures.

2008-10-01 Thread pfee

Hello all,

I'd like to query at what times the reviewboard server interacts with
the version control system.

I've been using reviewboard, but recently our VCS system was offline
for a while.  This affected the operation of reviewboard.  I think
improvements could be made in this area.

I found that the dashboard functioned as normal, but I was unable to
progress to view a review.

In the event of a VCS failure, reviewboard server should be able to:
1) Show the dashboard (currently works)
2) Show the top level review page (doesn't work)
3) Show the diffs - I'm assuming here that they're stored within
reviewboard (doesn't work)

I also assume that reviewboard doesn't store the entire contents of
the files for review, hence I would not expect the expanded entire
file view to work during a VCS failure.

Perhaps reviewboard could be configurable so that it could store the
entire file contents.  This would further isolate it from the VCS
making it more fault tolerant.  However the cost would be increased
storage requirements.  I doubt if this should be the default setting,
but it could be an option.  This enhancement would be a lower priority
than the other suggestions here.

Eliminating unnecessary VCS access will make reviewboard work better
during failure conditions and should also give speed ups even under
normal operation.

I'm posting here first rather than raising a bug.  If these ideas seem
worthwhile, I'll raise a bug/feature request.

Thanks,
Paul
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Reviewboard and Konqueror issues

2010-02-10 Thread pfee
Hi,

I remember a while back (may be a year ago) having to use Firefox
because Konqueror didn't work correctly.  However a few KDE releases
later I tried again and was pleased to see that Konqueror had started
working as required.

Unfortunately I didn't take note of which particular version of
Konqueror made the difference, but I can say I'm using Konqueror 4.3.5
on Fedora 12 and it works for me.

Thanks,
Paul

On Feb 10, 7:10 pm, David Trowbridge  wrote:
> It sounds like various AJAX calls aren't working. A JavaScript  
> debugger (like firebug) would hel figure out what's wrong but I don't  
> know if konquerer has such a thing.
>
> -David
>
> On Feb 9, 2010, at 5:07 AM, "daniel.j.la...@googlemail.com" 
> 
>  > wrote:
> > All,
>
> > I have encouraged people within my software group to start using
> > review-board and so far the response has been very positive.  However
> > as with any large software and firmware team people have their
> > favourite tools.
> > One of these tools happens to be KDE Konqueror in some cases.  The
> > problem is that when users create a review request it all starts up ok
> > but the following occurs:
> > 1. Clicking on all text entry areas (Description / Testing Done /
> > Summary) etc does not result in an OK Cancel button appearing.
> > 2. Clicking on view diff results in the first file in the diff request
> > showing - however the subsequent parts of the diff just show the
> > loading icon (swirling dots) and nothing happens
>
> > I would be interested in hearing peoples thoughts on how I can debug
> > this and what further information you would like before I try to raise
> > a bug report - or maybe other people have some helpful options I can
> > enable on Konqueror to get this to work.
>
> > Cheers
> > Dan
>
> > --
> > Want to help the Review Board project? Donate today 
> > athttp://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to 
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group 
> > athttp://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Reviewboard and Konqueror issues

2010-02-11 Thread pfee
Konqueror still uses KHTML (from which Webkit was forked).  However
there is ongoing talk of switching to WebKit and there are some
examples that illustrate the use of WebKit in KDE already, e.g. rekonq

So don't expect Konqueror to behave like Safari or Google Chrome just
yet.

On Feb 11, 1:26 am, Christian Hammond  wrote:
> Thanks for these data points.
>
> Dan, if you could find out the versions of Konqueror and Review Board
> used, it would help. I spent some time a while back trying to make it
> work with Konqueror, but I will say that we don't officially support
> it. We would prefer to work without loss of functionality, however,
> even if it's not perfect.
>
> I thought Konqueror used WebKit these days, in which case we should
> just work fine, as we support WebKit for Safari and Google Chrome.
>
> Christian
>
>
>
> On Wednesday, February 10, 2010, pfee  wrote:
> > Hi,
>
> > I remember a while back (may be a year ago) having to use Firefox
> > because Konqueror didn't work correctly.  However a few KDE releases
> > later I tried again and was pleased to see that Konqueror had started
> > working as required.
>
> > Unfortunately I didn't take note of which particular version of
> > Konqueror made the difference, but I can say I'm using Konqueror 4.3.5
> > on Fedora 12 and it works for me.
>
> > Thanks,
> > Paul
>
> > On Feb 10, 7:10 pm, David Trowbridge  wrote:
> >> It sounds like various AJAX calls aren't working. A JavaScript
> >> debugger (like firebug) would hel figure out what's wrong but I don't
> >> know if konquerer has such a thing.
>
> >> -David
>
> >> On Feb 9, 2010, at 5:07 AM, "daniel.j.la...@googlemail.com" 
> >> 
> >>  > wrote:
> >> > All,
>
> >> > I have encouraged people within my software group to start using
> >> > review-board and so far the response has been very positive.  However
> >> > as with any large software and firmware team people have their
> >> > favourite tools.
> >> > One of these tools happens to be KDE Konqueror in some cases.  The
> >> > problem is that when users create a review request it all starts up ok
> >> > but the following occurs:
> >> > 1. Clicking on all text entry areas (Description / Testing Done /
> >> > Summary) etc does not result in an OK Cancel button appearing.
> >> > 2. Clicking on view diff results in the first file in the diff request
> >> > showing - however the subsequent parts of the diff just show the
> >> > loading icon (swirling dots) and nothing happens
>
> >> > I would be interested in hearing peoples thoughts on how I can debug
> >> > this and what further information you would like before I try to raise
> >> > a bug report - or maybe other people have some helpful options I can
> >> > enable on Konqueror to get this to work.
>
> >> > Cheers
> >> > Dan
>
> >> > --
> >> > Want to help the Review Board project? Donate today 
> >> > athttp://www.reviewboard.org/donate/
> >> > Happy user? Let us know athttp://www.reviewboard.org/users/
> >> > -~--~~~~--~~--~--~---
> >> > To unsubscribe from this group, send email to 
> >> > reviewboard+unsubscr...@googlegroups.com
> >> > For more options, visit this group 
> >> > athttp://groups.google.com/group/reviewboard?hl=en
>
> > --
> > Want to help the Review Board project? Donate today 
> > athttp://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to 
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group 
> > athttp://groups.google.com/group/reviewboard?hl=en
>
> --
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en