[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 14: > > Regarding 1st review, > Yes, It's date time stamp prefix that i have removed before asserting the > value to void flaky behavior of test: > > 2024-07-15 12:49:27 [Exception] type= in FetchResults. > [Errno 4] Interrupted system call > 2024-07-15 12:49:27 [Warning] Cancelling Query > 2024-07-15 12:49:27 [Warning] close session RPC failed: 'shell_exceptions.QueryCancelledByShellException'> > > [20:] will ignore first 20 characters for 2024-07-15 12:49:27 part before > asserting with expected string Ack. It'd be more readable to define 20 as a constant variable like TS_LEN. > Regarding 2nd review: > We now explicitly added keyword keyword [Cancelled] with timestamp (initial > ask of this improvement Jira) and the test was used to check no cancel > keyword should be there. > > Scan Progress:[] 0% > Query Progress:[] 0% > ^C Cancelling Query > Opened TCP connection to localhost:21050 > 2024-07-15 12:51:43 [Cancelled] > [localhost:21050] default> > Instead of silently removing that test, we can replace it with assert "[Cancelled]" not in result.stderr -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 14 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 15 Jul 2024 09:39:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 14: > Patch Set 14: > > (2 comments) > Regarding 1st review, Yes, It's date time stamp prefix that i have removed before asserting the value to void flaky behavior of test: 2024-07-15 12:49:27 [Exception] type= in FetchResults. [Errno 4] Interrupted system call 2024-07-15 12:49:27 [Warning] Cancelling Query 2024-07-15 12:49:27 [Warning] close session RPC failed: [20:] will ignore first 20 characters for 2024-07-15 12:49:27 part before asserting with expected string > Regarding 2nd review: We now explicitly added keyword keyword [Cancelled] with timestamp (initial ask of this improvement Jira) and the test was used to check no cancel keyword should be there. Scan Progress:[] 0% Query Progress:[] 0% ^C Cancelling Query Opened TCP connection to localhost:21050 2024-07-15 12:51:43 [Cancelled] [localhost:21050] default> -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 14 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 15 Jul 2024 07:28:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/21426/14/tests/custom_cluster/test_hs2_fault_injection.py File tests/custom_cluster/test_hs2_fault_injection.py: http://gerrit.cloudera.org:8080/#/c/21426/14/tests/custom_cluster/test_hs2_fault_injection.py@184 PS14, Line 184: 20 To make the code more readable, can we make this a constant variable? Is it the length of a prefix string? http://gerrit.cloudera.org:8080/#/c/21426/12/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/21426/12/tests/shell/test_shell_interactive.py@340 PS12, Line 340: assert impalad.wait_for_num_in_flight_queries(0) How does the new format impact this? -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 14 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 15 Jul 2024 06:19:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16509/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 14 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Sun, 14 Jul 2024 12:51:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16508/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 13 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Sun, 14 Jul 2024 12:38:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 14: (2 comments) > Uploaded patch set 14. last build was failed while asserting test based on CLI output of impala-shell. I have verified last build jenkins logs and fixed all the test that were failing due to new logging format implemented in this jira http://gerrit.cloudera.org:8080/#/c/21426/13/tests/custom_cluster/test_hs2_fault_injection.py File tests/custom_cluster/test_hs2_fault_injection.py: http://gerrit.cloudera.org:8080/#/c/21426/13/tests/custom_cluster/test_hs2_fault_injection.py@225 PS13, Line 225: > flake8: E501 line too long (93 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/21426/13/tests/custom_cluster/test_hs2_fault_injection.py@237 PS13, Line 237: > flake8: E501 line too long (93 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 14 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Sun, 14 Jul 2024 12:29:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This change will print timestamp of an exception or warning occurred during execution of a query via impala-shell. Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 --- M shell/impala_client.py M shell/impala_shell.py M tests/custom_cluster/test_hs2_fault_injection.py M tests/custom_cluster/test_shell_jwt_auth.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py 6 files changed, 88 insertions(+), 72 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21426/14 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 14 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This change will print timestamp of an exception or warning occurred during execution of a query via impala-shell. Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 --- M shell/impala_client.py M shell/impala_shell.py M tests/custom_cluster/test_hs2_fault_injection.py M tests/custom_cluster/test_shell_jwt_auth.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py 6 files changed, 86 insertions(+), 72 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21426/13 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 13 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/21426/13/tests/custom_cluster/test_hs2_fault_injection.py File tests/custom_cluster/test_hs2_fault_injection.py: http://gerrit.cloudera.org:8080/#/c/21426/13/tests/custom_cluster/test_hs2_fault_injection.py@225 PS13, Line 225: n flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21426/13/tests/custom_cluster/test_hs2_fault_injection.py@237 PS13, Line 237: n flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 13 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Sun, 14 Jul 2024 12:15:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 12: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10742/ -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 12 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Thu, 20 Jun 2024 11:56:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 11: Code-Review+2 LGTM. Carry +1 from Csaba. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 11 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Thu, 20 Jun 2024 06:44:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 12 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Thu, 20 Jun 2024 06:44:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 12: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10742/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 12 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Thu, 20 Jun 2024 06:44:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 11: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16401/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 11 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Wed, 19 Jun 2024 20:02:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This change will print timestamp of an exception or warning occurred during execution of a query via impala-shell. Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 --- M shell/impala_client.py M shell/impala_shell.py 2 files changed, 42 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21426/11 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 11 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors
..
Patch Set 9:
There are still some places that we need the timestamp. Can we add them as well?
$ git grep -n 'Caught exception' shell
shell/impala_client.py:795:print('Caught exception {0}, type={1} when
listing query options. {2}'
shell/impala_client.py:800:print('Caught exception {0}, type={1} when
listing query options. {2}'
shell/impala_client.py:1180: print('Caught exception {0}, type={1} in
{2}. {3}, retry after {4} secs'
shell/impala_client.py:1184: print('Caught exception {0}, type={1} in
{2}. {3}'
shell/impala_client.py:1190:print('Caught exception {0}, type={1} in
{2}. {3}'
--
To view, visit http://gerrit.cloudera.org:8080/21426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944
Gerrit-Change-Number: 21426
Gerrit-PatchSet: 9
Gerrit-Owner: Saurabh Katiyal
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Saurabh Katiyal
Gerrit-Comment-Date: Wed, 19 Jun 2024 04:19:55 +
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has posted comments on this change. (
http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors
..
Patch Set 9:
> Patch Set 9: Code-Review+1
>
> (2 comments)
It is made more generic that why i avoided to put warning in the name
For example ,
If in future we want to add additional information in log we can use like below:
log_timestamp("Info", "some information we want to add with timestamp")
Impala shell stdout would be like :
++
2024-06-18 22:12:44 [Info] some information we want to add with timestamp
++
--
To view, visit http://gerrit.cloudera.org:8080/21426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944
Gerrit-Change-Number: 21426
Gerrit-PatchSet: 9
Gerrit-Owner: Saurabh Katiyal
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Saurabh Katiyal
Gerrit-Comment-Date: Tue, 18 Jun 2024 14:04:44 +
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 9: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21426/9/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/9/shell/impala_client.py@1612 PS9, Line 1612: def log_exception_with_timestamp(e, type="Exception", msg=""): Could be simply log_exception http://gerrit.cloudera.org:8080/#/c/21426/9/shell/impala_client.py@1619 PS9, Line 1619: def log_timestamp(type="Exception", msg=""): If I didn't miss something this is only used with "WARNING" - maybe it could be log_warning? -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 9 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Tue, 18 Jun 2024 10:08:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has posted comments on this change. (
http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors
..
Patch Set 9:
(11 comments)
> Patch Set 6:
>
> (1 comment)
Done,
Now we have timestamps similar to log lines :
[localhost:21050] default> select * from test where code = sleep ( 1);
Steet(ans00. TransportExceotion's in pinoTmoala
2024-06-17 22:41:44 [Exception] type= in PingImpalaHS2Service. TSocket read o bytes
2024-06-17 22:41:44 [Exception] type= in CloseSession.
[Errno 32] Broken pipe
2024-06-17 22:41:44 [Warning] close session RPC failed: ‹class 'socket.error'>
[Errno 32] Broken pipe
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1615
PS4, Line 1615: i
> flake8: E231 missing whitespace after ','
Done
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1615
PS4, Line 1615: print("%s [%s] %s" % (time.strftime("%Y-%m-%d %H:%M:%S",
time.localtime()), type, msg),
> flake8: E302 expected 2 blank lines, found 1
Done
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1620
PS4, Line 1620: # method log_timestamp prints timestamp with custom message
> flake8: E302 expected 2 blank lines, found 1
Done
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1622
PS4, Line 1622:
> flake8: W292 no newline at end of file
Done
http://gerrit.cloudera.org:8080/#/c/21426/6/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/21426/6/shell/impala_client.py@1623
PS6, Line 1623:
> Can we put the timestamp at the beginning? So the format is more like a log
Done
http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1615
PS8, Line 1615: ,
> flake8: E231 missing whitespace after ','
Done
http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1616
PS8, Line 1616: ,
> flake8: E203 whitespace before ','
Done
http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1621
PS8, Line 1621: ,
> flake8: E231 missing whitespace after ','
Done
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1461
PS4, Line 1461:
> flake8: E231 missing whitespace after ','
Done
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1473
PS4, Line 1473: d
> flake8: E231 missing whitespace after ','
Done
http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1505
PS4, Line 1505:
> flake8: E231 missing whitespace after ','
Done
--
To view, visit http://gerrit.cloudera.org:8080/21426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944
Gerrit-Change-Number: 21426
Gerrit-PatchSet: 9
Gerrit-Owner: Saurabh Katiyal
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Saurabh Katiyal
Gerrit-Comment-Date: Tue, 18 Jun 2024 07:33:22 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16376/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 9 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 17 Jun 2024 18:36:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16375/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 8 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 17 Jun 2024 18:30:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This change will print timestamp of an exception or warning occurred during execution of a query via impala-shell. Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 --- M shell/impala_client.py M shell/impala_shell.py 2 files changed, 30 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21426/9 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 9 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This change will print timestamp of an exception or warning occurred during execution of a query via impala-shell. Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 --- M shell/impala_client.py M shell/impala_shell.py 2 files changed, 30 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21426/8 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 8 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1615 PS8, Line 1615: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1616 PS8, Line 1616: flake8: E203 whitespace before ',' http://gerrit.cloudera.org:8080/#/c/21426/8/shell/impala_client.py@1621 PS8, Line 1621: , flake8: E231 missing whitespace after ',' -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 8 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 17 Jun 2024 18:06:38 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21426/6/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/21426/6/shell/impala_client.py@1623
PS6, Line 1623: print(msg + " at: %s" % (time.strftime("%Y-%m-%d %H:%M:%S",
time.localtime())),
Can we put the timestamp at the beginning? So the format is more like a log and
we can wrap the code of
log_timestamp("Warning")
print("Warning: close session RPC failed: {0}, {1}".format(str(e),
type(e)))
into
log_timestamp("Warning: close session RPC failed: {0}, {1}".format(str(e),
type(e)))
--
To view, visit http://gerrit.cloudera.org:8080/21426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944
Gerrit-Change-Number: 21426
Gerrit-PatchSet: 6
Gerrit-Owner: Saurabh Katiyal
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Reviewer: Saurabh Katiyal
Gerrit-Comment-Date: Mon, 17 Jun 2024 11:25:27 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16365/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 6 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 17 Jun 2024 08:07:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16364/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 17 Jun 2024 07:50:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This change will print timestamp of an exception or warning occurred during execution of a query via impala-shell. Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 --- M shell/impala_client.py M shell/impala_shell.py 2 files changed, 27 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21426/6 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 6 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This change will print timestamp of an exception or warning occurred during execution of a query via impala-shell. Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 --- M shell/impala_client.py M shell/impala_shell.py 2 files changed, 25 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21426/4 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1615 PS4, Line 1615: def log_exception_with_timestamp(e,msg="Exception"): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1615 PS4, Line 1615: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1620 PS4, Line 1620: def log_timestamp(msg="Exception"): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_client.py@1622 PS4, Line 1622: flake8: W292 no newline at end of file http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1461 PS4, Line 1461: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1473 PS4, Line 1473: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/21426/4/shell/impala_shell.py@1505 PS4, Line 1505: , flake8: E231 missing whitespace after ',' -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Katiyal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Saurabh Katiyal Gerrit-Comment-Date: Mon, 17 Jun 2024 07:26:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py@1464
PS1, Line 1464: (time.strftime("%Y-%m-%d %H:%M:%S", time.localtime())
It would be nice to move some of this to utility functions to make the code
less noisy. One idea is to create function like nowstr() that gets the
localtime and does the formatting. A function log_error(msg, ex) could be also
created to avoid all boilerplate code, so it could be called like
log_error("Exception", ex)
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py@1496
PS1, Line 1496: print ("Exception at: %s" % (time.strftime("%Y-%m-%d
%H:%M:%S", time.localtime(
file=sys.stderr is missing for some reason
--
To view, visit http://gerrit.cloudera.org:8080/21426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944
Gerrit-Change-Number: 21426
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Katiyal
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Wed, 22 May 2024 13:13:49 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/21426/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21426/1//COMMIT_MSG@9
PS1, Line 9: This change will print timestamp of exception occurring during
executing a query
nit: we prefer 72 characters as the max width in commit message
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_client.py@763
PS1, Line 763: print("Warning: close session RPC failed: {0},
{1}".format(str(e), type(e)))
This also needs a timestamp.
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_client.py@1154
PS1, Line 1154: print('Caught exception {0}, type={1} in {2}. {3}'
Let's also add timestamps in this method.
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_client.py@1606
PS1, Line 1606: print('Caught exception {0}, type={1}'.format(str(e),
type(e)), file=sys.stderr)
This also needs a timestamp.
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py@1109
PS1, Line 1109: print("%s: %s, %s" %
: (self.ERROR_CONNECTING_MESSAGE, type(e).__name__, e),
file=sys.stderr)
Please also add timestamp for this. We've seen errors like
Error connecting: DisconnectedException, Error communicating with impalad:
TSocket read 0 bytes
It'd be nice to see when the connection fails.
http://gerrit.cloudera.org:8080/#/c/21426/1/shell/impala_shell.py@1460
PS1, Line 1460:
nit: redudant space
--
To view, visit http://gerrit.cloudera.org:8080/21426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944
Gerrit-Change-Number: 21426
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Katiyal
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Wed, 22 May 2024 02:39:16 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors
Saurabh Katiyal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21426 Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This change will print timestamp of exception occurring during executing a query similar to Query submitted timestamp. Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 --- M shell/impala_shell.py 1 file changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/21426/1 -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Katiyal
