[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#2). Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests .. WIP: use C++ ExternalMiniCluster for Java and Python tests Maintaining Kudu clients across various languages has been an ongoing maintenance burden. Even when the client is just a thin wrapper around another client (e.g. Kudu Python bindings), a great deal of work goes into client testability. In practice, this has meant a bespoke mini cluster implementation for each language. On the surface this doesn't seem that bad; we just need to spawn some masters and tservers, right? Well, the work quickly adds up: o While the C++ mini cluster is heavily used and has seen many improvements, the Java mini cluster has not received the same kind of love, and is less robust as a result. KUDU-1976 is a great example of this deficiency. o With the inclusion of authz came the addition of a "mini KDC", a special daemon for Kerberized mini clusters. It was originally implemented in C++ and ported to Java, but has yet to be ported to the Python client; this is one of the obstacles towards porting full authz support to Python. o Dan has been prototyping Hive Metastore and Sentry integration for Kudu, the testing of which will require "mini HMS" and possibly "mini Sentry" testing implementations in C++, Java, and eventually, Python. In sum, good support for non-C++ mini clusters is an ongoing commitment and requires a great deal of work. This work hasn't always been forthcoming, and the non-C++ clusters are deficient as a result. But it doesn't have to be this way! Here's a thought: what if we reused the C++ mini cluster for tests written in these other languages? We could write a "proxy" application whose job it is to manage the C++ mini cluster and expose a rudimentary API that's easily programmable from Java and Python. This patch attempts to do just that. It adds a "run_cluster" mode to the Kudu CLI. When invoked, it spawns an ExternalMiniCluster and provides a simple, machine-readable shell over stdin/stdout. The shell responds to commands by manipulating the cluster and its daemons, and kills them when the shell client disconnects. As a proof of concept, the patch also replaces the bespoke Java mini cluster with callouts to the new shell. I should add that I like the idea of shipping "run_cluster" into production as part of the CLI, as it helps realize the vision of a single Kudu artifact that can provide Kudu testability for any integrating product. WIP because, well, it should be pretty obvious. I was able to get through a full run of "mvn verify" locally, so I have confidence that this can work. But I'd like to solicit feedback on the general approach before spending more time applying spit and polish. Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 --- M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java D java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java D java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java D java/kudu-client/src/test/resources/flags M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala M src/kudu/security/test/mini_kdc.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/tool_action.h A src/kudu/tools/tool_action_test.cc M src/kudu/tools/tool_main.cc 15 files changed, 532 insertions(+), 1,211 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/7853/2 -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add metrics for tablet state and tablet copy
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7540 to look at the new patch set (#6). Change subject: Add metrics for tablet state and tablet copy .. Add metrics for tablet state and tablet copy This patch adds a metric to each tablet that records its state, e.g. RUNNING or TOMBSTONED. Metrics systems will need to aggregate the state strings to give server-level statistics on tablet state. This patch also adds metrics for tablet copy operations. Namely, - Bytes fetched by tablet copy clients - Bytes sent by tablet copy source sessions - Number of active tablet copy clients - Number of open table copy source sessions Typo fix: tablet_copy_dowload_file_inject_latency_ms gained its missing 'n' in "download". It's a hidden flag that should only be used in tests, so it shouldn't cause anyone's existing startup flagfiles to have a bad flag. Change-Id: I4c945826f5fdb181d40e004fc8ef00688f0dedb3 --- M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tserver/tablet_copy_client-test.cc M src/kudu/tserver/tablet_copy_client.cc M src/kudu/tserver/tablet_copy_client.h M src/kudu/tserver/tablet_copy_service.cc M src/kudu/tserver/tablet_copy_service.h M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/tserver/tablet_copy_source_session.cc M src/kudu/tserver/tablet_copy_source_session.h M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 17 files changed, 263 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/7540/6 -- To view, visit http://gerrit.cloudera.org:8080/7540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c945826f5fdb181d40e004fc8ef00688f0dedb3 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] [java] Reuse JVM across tests
Alexey Serbin has posted comments on this change. Change subject: [java] Reuse JVM across tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7825/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: Line 350: def clear(): Unit = { > Having cached connection that outlived the client was causing issues when w Interesting. Are those issues related only to the TLS certs or it's something else? As I understand, in the real-world scenarios, update on TLS certificates is supposed to be a very rare occasion: it might be expiration of the Kudu's IPKI certs (in 10 years after generation) or some case of re-generating those in case of security concerns. Anyway, I think clearing the cache might be good at least because not doing so might hide some issues with initial cache bootstrap for some corner cases. -- To view, visit http://gerrit.cloudera.org:8080/7825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e4c6d53054d5da4f2ecf9f4130a51df13d4fa6c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests
Todd Lipcon has posted comments on this change. Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG Commit Message: PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get through a : full run of "mvn verify" locally, so I have confidence that this can work. : But I'd like to solicit feedback on the general approach before spending : more time applying spit and polish. general approach seems reasonable to me. The only concern/question I have is about the formatting and compatibility requirements of the CLI requests/responses. Using something like protobuf or JSON would make it easier to ensure that the commands are extensible, potentially self-documenting, and machine parseable. On the other hand, protobuf at least would require more dependencies to be used in the embedding languages. Given we have protobuf to/from-JSON support, maybe we could use protobuf to "define" the API, but use JSON to serialize it? Then we don't need to worry about parsing and generation and random things like "what if the minicluster base dir path has a space in it", etc. -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] docs: add 1.5.0 release note for disk failures
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7856 Change subject: docs: add 1.5.0 release note for disk failures .. docs: add 1.5.0 release note for disk failures Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 --- M docs/release_notes.adoc 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/7856/1 -- To view, visit http://gerrit.cloudera.org:8080/7856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong
[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests
Alexey Serbin has posted comments on this change. Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests .. Patch Set 2: (1 comment) I think it's a great idea. What about more machine-oriented interface for the CLI tool? Do you expect it to be transformed into something JSON-like in the nearest future? Maybe, it's worth introducing running a proxy along with minicluster and providing something like REST interface instead of CLI for the tests? http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG Commit Message: PS2, Line 20: authz nit here and below: I think it should be 'authn' -- the kerberos-related activity is related to authentication, not authorization (and Sentry integration is supposed to take care of the fine-grained authorization in the future) -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests
Todd Lipcon has posted comments on this change. Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG Commit Message: PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get through a : full run of "mvn verify" locally, so I have confidence that this can work. : But I'd like to solicit feedback on the general approach before spending : more time applying spit and polish. > I went back and forth on this. I'm just worried that, as we add features, the parsing is going to get more complicated than just noun/verb. eg what if I want to run a kerberized minicluster, but with a custom realm, or with two KDCs set up for cross-realm trust in the future, etc? Maybe we could have the most simple "start a non-kerberized cluster with 3 servers" be done with interactive use, since a developer might want to use this for local playing around, but then make anything more complicated (eg custom flags, more exotic configs) require JSON? -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests
Adar Dembo has posted comments on this change. Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests .. Patch Set 2: (2 comments) > I think it's a great idea. What about more machine-oriented > interface for the CLI tool? Do you expect it to be transformed > into something JSON-like in the nearest future? See the comment Todd left; we're discussing just that. > Maybe, it's worth introducing running a proxy along with > minicluster and providing something like REST interface instead of > CLI for the tests? I didn't implement a TCP-based connection between the proxy and the tests exactly so that the entire "port already in use" class of issues can be avoided. When communication is over a TCP socket, we either need to use a well-known port, which is prone to conflicts, or an ephemeral port, whose number needs to be communicated back to the tests. If we've already got a channel for communicating the port number (probably stdout), we can use that channel for control too. I think a socket-based approach would make more sense if there were multiple consumers of a single mini cluster, but that's just not the case with our tests. http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG Commit Message: PS2, Line 20: authz > nit here and below: I think it should be 'authn' -- the kerberos-related ac You are right, my bad. PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get through a : full run of "mvn verify" locally, so I have confidence that this can work. : But I'd like to solicit feedback on the general approach before spending : more time applying spit and polish. > general approach seems reasonable to me. I went back and forth on this. JSON (or protobuf, or thrift, or or or...) would certainly make the RPC system far more robust and maintainable. But we'd lose the ability to actually use run_cluster interactively from the command line, because no one wants to write JSON or whatever by hand. Right now the noun/verb word-based RPC allows for interactivity and that's how I did much of the early testing. It's not robust, but it won't be broken by simple things like e.g. a minicluster dir with a space (it would be broken by unexpected newlines though). Do you think the pros of using a real serialization format outweigh the loss of interactivity? -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] docs: add 1.5.0 release note for disk failures
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7856 to look at the new patch set (#2). Change subject: docs: add 1.5.0 release note for disk failures .. docs: add 1.5.0 release note for disk failures Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 --- M docs/release_notes.adoc 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/7856/2 -- To view, visit http://gerrit.cloudera.org:8080/7856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: add 1.5.0 release note for disk failures
Andrew Wong has posted comments on this change. Change subject: docs: add 1.5.0 release note for disk failures .. Patch Set 2: Failed a handful of tests for some reason; rebased to see if that'll do the trick. -- To view, visit http://gerrit.cloudera.org:8080/7856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] WIP: use C++ ExternalMiniCluster for Java and Python tests
Alexey Serbin has posted comments on this change. Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG Commit Message: PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get through a : full run of "mvn verify" locally, so I have confidence that this can work. : But I'd like to solicit feedback on the general approach before spending : more time applying spit and polish. > I went back and forth on this. Would it be possible to use JSON format as an internal format of the tool, while translating the command-line arguments into a JSON document which would be consumed internally? Basically, it's about a shim layer which translates the command-line arguments into a JSON representation. Vice versa: it could be the same for the output. As for the output, there are libraries like libxo to handle that in a uniform way: https://github.com/Juniper/libxo -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] docs: add 1.5.0 release note for disk failures
Dan Burkert has posted comments on this change. Change subject: docs: add 1.5.0 release note for disk failures .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7856/2/docs/release_notes.adoc File docs/release_notes.adoc: Line 66: * Kudu 1.5 tablet servers are now optionally able to tolerate disk failures at Mention that this is an experimental feature. -- To view, visit http://gerrit.cloudera.org:8080/7856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-2089: Failed java tests can orphan test-tmp files
Todd Lipcon has posted comments on this change. Change subject: KUDU-2089: Failed java tests can orphan test-tmp files .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53c04987b6683dc959c319d384657c28b4671168 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-2089: Failed java tests can orphan test-tmp files
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2089: Failed java tests can orphan test-tmp files .. KUDU-2089: Failed java tests can orphan test-tmp files This changes the MiniKuduCluster code to add the paths to pathsToDelete before calling configureAndStartProcess. If configureAndStartProcess throws an exception, the test-tmp files will be still deleted during shutdown. Change-Id: I53c04987b6683dc959c319d384657c28b4671168 Reviewed-on: http://gerrit.cloudera.org:8080/7719 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53c04987b6683dc959c319d384657c28b4671168 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1894 fixed deadlock in client.Connection
Todd Lipcon has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7765/2/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: PS2, Line 578: inflightMessages.put > Huh, that's interesting. Nothing specifically wrong with it that I can see. It just makes the locking a bit more complicated/harder to follow, so was hoping to find a workaround that would allow us to keep our simpler coarse grained locking. -- To view, visit http://gerrit.cloudera.org:8080/7765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a0edc3e3accbcff60f2cde641ee470312bbd27a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens
Dan Burkert has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 5: (1 comment) In terms of 1.5 we can include this if it's in shape to get committed in the next ~2 days. http://gerrit.cloudera.org:8080/#/c/7748/5/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: Line 390: void LookupTabletsByKeyOrNext(const KuduTable* table, > Sorry for the confusion. Yah I think it would be better to expose this as an additional parameter instead of a new method. The Java APIs for table locations are a bit of a mess, they've grown haphazardly as needed instead of well designed (much of it due to me). In terms of exposing the constants publicly in the MetaCache class, I think it's fine because these aren't externally visible APIs - they are internal to the client. -- To view, visit http://gerrit.cloudera.org:8080/7748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jun He Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] docs: add 1.5.0 release note for disk failures
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7856 to look at the new patch set (#3). Change subject: docs: add 1.5.0 release note for disk failures .. docs: add 1.5.0 release note for disk failures Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 --- M docs/release_notes.adoc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/7856/3 -- To view, visit http://gerrit.cloudera.org:8080/7856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: add 1.5.0 release note for disk failures
Andrew Wong has posted comments on this change. Change subject: docs: add 1.5.0 release note for disk failures .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7856/2/docs/release_notes.adoc File docs/release_notes.adoc: Line 66: * Kudu 1.5 tablet servers are now optionally able to tolerate disk failures at > Mention that this is an experimental feature. Done -- To view, visit http://gerrit.cloudera.org:8080/7856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-2083. Decrement running maintenance ops on failed prepare
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7610 to look at the new patch set (#3). Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. KUDU-2083. Decrement running maintenance ops on failed prepare There is currently a bug where we don't decrement the number of running ops when an op->Prepare() fails. Although rare, when this bug is hit, it will decrease the number of simultaneous mm ops that can run until none can, causing the tserver to run OOM. Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 --- M src/kudu/util/maintenance_manager.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/7610/3 -- To view, visit http://gerrit.cloudera.org:8080/7610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: add 1.5.0 release note for disk failures
Dan Burkert has posted comments on this change. Change subject: docs: add 1.5.0 release note for disk failures .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-2083. Decrement running maintenance ops on failed prepare
Todd Lipcon has posted comments on this change. Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] docs: add 1.5.0 release note for disk failures
Dan Burkert has submitted this change and it was merged. Change subject: docs: add 1.5.0 release note for disk failures .. docs: add 1.5.0 release note for disk failures Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Reviewed-on: http://gerrit.cloudera.org:8080/7856 Reviewed-by: Dan Burkert Tested-by: Dan Burkert --- M docs/release_notes.adoc 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Dan Burkert: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/7856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ad45527dc32a4946c817ddbef2149433f3b5b89 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Refactor HybridClock and add a local clock mode
Todd Lipcon has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: I ended up pulling some of this idea into de8b92eb6469f843d43c432678e52732a861014b though it seems this patch does a bit more than the simple refactoring there. Additionally in the above patch I only enabled the "system unsynchronized time" on OSX -- To view, visit http://gerrit.cloudera.org:8080/5982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78d616f64558f4b9a95535ebc8702f75a37dad39 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] docs: Add release note for tombstoned voting
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7858 to review the following change. Change subject: docs: Add release note for tombstoned voting .. docs: Add release note for tombstoned voting Change-Id: I14d06ac34ee43cd5592a5fd77074224997812b4e --- M docs/release_notes.adoc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7858/1 -- To view, visit http://gerrit.cloudera.org:8080/7858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I14d06ac34ee43cd5592a5fd77074224997812b4e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Dan Burkert
[kudu-CR] KUDU-2083. Decrement running maintenance ops on failed prepare
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. KUDU-2083. Decrement running maintenance ops on failed prepare There is currently a bug where we don't decrement the number of running ops when an op->Prepare() fails. Although rare, when this bug is hit, it will decrease the number of simultaneous mm ops that can run until none can, causing the tserver to run OOM. Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 Reviewed-on: http://gerrit.cloudera.org:8080/7610 Reviewed-by: Todd Lipcon Tested-by: Kudu Jenkins --- M src/kudu/util/maintenance_manager.cc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: Add release note for tombstoned voting
Mike Percy has posted comments on this change. Change subject: docs: Add release note for tombstoned voting .. Patch Set 1: Verified+1 docs change is unrelated to ITClient test failure -- To view, visit http://gerrit.cloudera.org:8080/7858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14d06ac34ee43cd5592a5fd77074224997812b4e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] release notes: document disk-group-sizing flag
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7860 Change subject: release notes: document disk-group-sizing flag .. release notes: document disk-group-sizing flag Change-Id: I0664c132711ea55a6eedea9bc795ab52d8ecc2f6 --- M docs/release_notes.adoc 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/7860/1 -- To view, visit http://gerrit.cloudera.org:8080/7860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0664c132711ea55a6eedea9bc795ab52d8ecc2f6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong
[kudu-CR] KUDU-1894 fixed deadlock in client.Connection
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1894 fixed deadlock in client.Connection .. KUDU-1894 fixed deadlock in client.Connection Due to the reverse order of acquiring of the Connection.lock and some lower-level Netty locks, Connection.enqueueMesage() could deadlock if a ChannelDisconnected/ChannelClosed event arrived in the middle. The idea is to not hold the Connection.lock while invoking the Connection.sendCallToWire() method and, overall, avoid doing any calls to Netty while holding that lock. To test the changes, I ran the ITClient test via dist-test apllying Todd's WIP patch on top: https://gerrit.cloudera.org/#/c/7579/ The test passed 3572 out of 3572 times: http://dist-test.cloudera.org/job?job_id=aserbin.1503526685.24101 http://dist-test.cloudera.org/job?job_id=aserbin.1503527340.4787 http://dist-test.cloudera.org/job?job_id=aserbin.1503527848.6921 Change-Id: I1a0edc3e3accbcff60f2cde641ee470312bbd27a Reviewed-on: http://gerrit.cloudera.org:8080/7765 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert Reviewed-by: Jean-Daniel Cryans --- M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java 1 file changed, 54 insertions(+), 21 deletions(-) Approvals: Dan Burkert: Looks good to me, but someone else must approve Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a0edc3e3accbcff60f2cde641ee470312bbd27a Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1894 fixed deadlock in client.Connection
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a0edc3e3accbcff60f2cde641ee470312bbd27a Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] docs: add 1.5.0 release note for tablet copying and flushing improvements
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/7862 Change subject: docs: add 1.5.0 release note for tablet copying and flushing improvements .. docs: add 1.5.0 release note for tablet copying and flushing improvements Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be --- M docs/release_notes.adoc 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/7862/1 -- To view, visit http://gerrit.cloudera.org:8080/7862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao
[kudu-CR] release notes: document disk-group-sizing flag
Adar Dembo has submitted this change and it was merged. Change subject: release notes: document disk-group-sizing flag .. release notes: document disk-group-sizing flag Change-Id: I0664c132711ea55a6eedea9bc795ab52d8ecc2f6 Reviewed-on: http://gerrit.cloudera.org:8080/7860 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M docs/release_notes.adoc 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0664c132711ea55a6eedea9bc795ab52d8ecc2f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] release notes: document disk-group-sizing flag
Adar Dembo has posted comments on this change. Change subject: release notes: document disk-group-sizing flag .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0664c132711ea55a6eedea9bc795ab52d8ecc2f6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] docs: add 1.5.0 release note for tablet copying and flushing improvements
Adar Dembo has posted comments on this change. Change subject: docs: add 1.5.0 release note for tablet copying and flushing improvements .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7862/1/docs/release_notes.adoc File docs/release_notes.adoc: Line 80: * Kudu 1.5 batches data blocks disk synchronization when using log block manager. How about: "Kudu 1.5's log block manager now performs disk synchronization in batches. This optimization can significantly reduce the time taken to copy tablet data from one server to another; in one case tablet copy time was reduced by 35%. It also improves the general performance of flushes and compactions." -- To view, visit http://gerrit.cloudera.org:8080/7862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] docs: add 1.5.0 release note for tablet copying and flushing improvements
Hao Hao has posted comments on this change. Change subject: docs: add 1.5.0 release note for tablet copying and flushing improvements .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7862/1/docs/release_notes.adoc File docs/release_notes.adoc: Line 80: * Kudu 1.5 batches data blocks disk synchronization when using log block manager. > How about: Done -- To view, visit http://gerrit.cloudera.org:8080/7862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] docs: add 1.5.0 release note for tablet copying and flushing improvements
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7862 to look at the new patch set (#2). Change subject: docs: add 1.5.0 release note for tablet copying and flushing improvements .. docs: add 1.5.0 release note for tablet copying and flushing improvements Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be --- M docs/release_notes.adoc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/7862/2 -- To view, visit http://gerrit.cloudera.org:8080/7862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2113 SEGV because of consensus conflict and missing tablet server
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7864 Change subject: KUDU-2113 SEGV because of consensus conflict and missing tablet server .. KUDU-2113 SEGV because of consensus conflict and missing tablet server Sometimes the master doesn't report all tablet servers. This can happen, for example, when the master is starting. When this happened and there was also a consensus conflict, it caused a SEGV. This fixes the SEGV and contains a regression test. Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 3 files changed, 45 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/7864/1 -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley
[kudu-CR] KUDU-2113 SEGV because of consensus conflict and missing tablet server
Will Berkeley has uploaded a new patch set (#2). Change subject: KUDU-2113 SEGV because of consensus conflict and missing tablet server .. KUDU-2113 SEGV because of consensus conflict and missing tablet server Sometimes the master doesn't report all tablet servers. This can happen, for example, when the master is starting. When this happened and there was also a consensus conflict, it caused a SEGV. This fixes the SEGV and contains a regression test. Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 3 files changed, 46 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/7864/2 -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] docs: add 1.5.0 release note for tablet copying and flushing improvements
Dan Burkert has posted comments on this change. Change subject: docs: add 1.5.0 release note for tablet copying and flushing improvements .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] docs: add 1.5.0 release note for tablet copying and flushing improvements
Dan Burkert has submitted this change and it was merged. Change subject: docs: add 1.5.0 release note for tablet copying and flushing improvements .. docs: add 1.5.0 release note for tablet copying and flushing improvements Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be Reviewed-on: http://gerrit.cloudera.org:8080/7862 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert --- M docs/release_notes.adoc 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf254bfcad27b66e8fa515be92285c876332a0be Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7865 to review the following change. Change subject: [release notes] add new kudu tool features and metrics improvements .. [release notes] add new kudu tool features and metrics improvements Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 --- M docs/release_notes.adoc 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7865/1 -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Will Berkeley
[kudu-CR] docs: Add release note for tombstoned voting
Dan Burkert has posted comments on this change. Change subject: docs: Add release note for tombstoned voting .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14d06ac34ee43cd5592a5fd77074224997812b4e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] docs: Add release note for tombstoned voting
Dan Burkert has submitted this change and it was merged. Change subject: docs: Add release note for tombstoned voting .. docs: Add release note for tombstoned voting Change-Id: I14d06ac34ee43cd5592a5fd77074224997812b4e Reviewed-on: http://gerrit.cloudera.org:8080/7858 Tested-by: Mike Percy Reviewed-by: Dan Burkert --- M docs/release_notes.adoc 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Mike Percy: Verified -- To view, visit http://gerrit.cloudera.org:8080/7858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14d06ac34ee43cd5592a5fd77074224997812b4e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Dan Burkert has uploaded a new patch set (#2). Change subject: [release notes] add new kudu tool features and metrics improvements .. [release notes] add new kudu tool features and metrics improvements Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 --- M docs/release_notes.adoc 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7865/2 -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Adar Dembo has posted comments on this change. Change subject: [release notes] add new kudu tool features and metrics improvements .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7865/2/docs/release_notes.adoc File docs/release_notes.adoc: PS2, Line 83: kudu Surround in backticks. PS2, Line 105: Previously, the : metric counted only the base data and REDO deltas; it now counts all deltas. Maybe "Previously, the metric included only REDO deltas; it now includes all deltas." That doesn't give you the sum total of what the metric includes (i.e. the base data) but it does a clearer job of explaining the transition from REDO to REDO+UNDO. -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7865 to look at the new patch set (#3). Change subject: [release notes] add new kudu tool features and metrics improvements .. [release notes] add new kudu tool features and metrics improvements Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 --- M docs/release_notes.adoc 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7865/3 -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Dan Burkert has posted comments on this change. Change subject: [release notes] add new kudu tool features and metrics improvements .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7865/2/docs/release_notes.adoc File docs/release_notes.adoc: PS2, Line 83: kudu > Surround in backticks. Done PS2, Line 105: Previously, the : metric counted only the base data and REDO deltas; it now counts all deltas. > Maybe "Previously, the metric included only REDO deltas; it now includes al Done -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
[kudu-CR] KUDU-2113 SEGV because of consensus conflict and missing tablet server
Adar Dembo has posted comments on this change. Change subject: KUDU-2113 SEGV because of consensus conflict and missing tablet server .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7864/2//COMMIT_MSG Commit Message: PS2, Line 7: SEGV Nit: pedantry, but "SEGV" isn't really a thing. It's either a "segmentation fault" or "segfault" (a specific kind of illegal memory access) or a "SIGSEGV" (the signal delivered to the process by the kernel due to a segfault, which causes it to terminate abnormally). http://gerrit.cloudera.org:8080/#/c/7864/2/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: PS2, Line 293: FRIEND_TEST(KsckTest, TestMismatchedAssignments); : FRIEND_TEST(KsckTest, TestConsensusConflictExtraPeer); : FRIEND_TEST(KsckTest, TestConsensusConflictMissingPeer); : FRIEND_TEST(KsckTest, TestConsensusConflictDifferentLeader); : FRIEND_TEST(KsckTest, TestMasterNotReportingTabletServerWithConsensusConflict); Nit: mind sorting this list alphabetically? -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Adar Dembo has posted comments on this change. Change subject: [release notes] add new kudu tool features and metrics improvements .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Dan Burkert has submitted this change and it was merged. Change subject: [release notes] add new kudu tool features and metrics improvements .. [release notes] add new kudu tool features and metrics improvements Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Reviewed-on: http://gerrit.cloudera.org:8080/7865 Reviewed-by: Adar Dembo Reviewed-by: Will Berkeley Tested-by: Dan Burkert --- M docs/release_notes.adoc 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Dan Burkert: Verified Adar Dembo: Looks good to me, approved Will Berkeley: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Dan Burkert has posted comments on this change. Change subject: [release notes] add new kudu tool features and metrics improvements .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] [release notes] add new kudu tool features and metrics improvements
Will Berkeley has posted comments on this change. Change subject: [release notes] add new kudu tool features and metrics improvements .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9514999a913c52fdfc9ed3cf6a85da50b190c68 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] [iwyu] fix on
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7867 Change subject: [iwyu] fix on .. [iwyu] fix on Fixed the issue where IWYU suggested to include the internal GCC header : added additional mapping file which declares the header as a private one, suggesting to include one of the public header files of the standard C++ library files which include the private header file itself and has other references in the context. Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 --- M build-support/iwyu/iwyu-filter.awk A build-support/iwyu/mappings/libstdcpp.imp M src/kudu/cfile/index_btree.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/schema.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/log_reader.cc M src/kudu/consensus/log_util.cc M src/kudu/experiments/merge-test.cc M src/kudu/gutil/strings/split.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/internal_mini_cluster.cc M src/kudu/integration-tests/log_verifier.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master-test.cc M src/kudu/security/token-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset_tree-test.cc M src/kudu/tablet/rowset_tree.cc M src/kudu/tablet/tablet-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/scanners-test.cc M src/kudu/util/env-test.cc M src/kudu/util/maintenance_manager.cc M src/kudu/util/make_shared.h M src/kudu/util/mt-threadlocal-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/threadpool-test.cc 39 files changed, 17 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/7867/1 -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin
[kudu-CR] consensus peers: don't log tablet copy attempts that were throttled
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7868 to review the following change. Change subject: consensus_peers: don't log tablet copy attempts that were throttled .. consensus_peers: don't log tablet copy attempts that were throttled When a tserver with ~6k tablets was killed in a 9 node cluster, another node started logging ~800 lines of throttled tablet copy messages per second. This isn't useful and fills up disks. Change-Id: Ib1c7717847c73870110376d0e7052f0118cb0200 --- M src/kudu/consensus/consensus_peers.cc 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7868/1 -- To view, visit http://gerrit.cloudera.org:8080/7868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1c7717847c73870110376d0e7052f0118cb0200 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Mike Percy
[kudu-CR] [iwyu] fix on
Alexey Serbin has uploaded a new patch set (#2). Change subject: [iwyu] fix on .. [iwyu] fix on Fixed the issue where IWYU suggested to include the internal GCC header : added additional mapping file which declares the header as a private one, suggesting to include one of the public header files of the standard C++ library files which include the private header file itself and has other references in the context. Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 --- M build-support/iwyu/iwyu-filter.awk A build-support/iwyu/mappings/libstdcpp.imp M src/kudu/cfile/index_btree.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/schema.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/log_reader.cc M src/kudu/consensus/log_util.cc M src/kudu/experiments/merge-test.cc M src/kudu/gutil/strings/split.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/internal_mini_cluster.cc M src/kudu/integration-tests/log_verifier.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master-test.cc M src/kudu/security/token-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset_tree-test.cc M src/kudu/tablet/rowset_tree.cc M src/kudu/tablet/tablet-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/scanners-test.cc M src/kudu/util/env-test.cc M src/kudu/util/maintenance_manager.cc M src/kudu/util/make_shared.h M src/kudu/util/mt-threadlocal-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/threadpool-test.cc 39 files changed, 33 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/7867/2 -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [iwyu] fix on
Adar Dembo has posted comments on this change. Change subject: [iwyu] fix on .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: Line 32: # Usage: Any particular reason to explain all this now that there's iwyu.sh? We could just ask people to run that, no? http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: Shouldn't this new file be referenced in iwyu.sh? PS2, Line 18: { include: ["", private, "", public ] }, : { include: ["", private, "", public ] }, : { include: ["", private, "", public ] }, : { include: ["", private, "", public ] } Why all four recommendations? Why not just one, like ? -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [iwyu] fix on
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7867 to look at the new patch set (#3). Change subject: [iwyu] fix on .. [iwyu] fix on Fixed the issue where IWYU suggested to include the internal GCC header : added additional mapping file which declares the header as a private one, suggesting to include one of the public header files of the standard C++ library files which include the private header file itself and has other references in the context. Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 --- M build-support/iwyu/iwyu-filter.awk M build-support/iwyu/iwyu.sh A build-support/iwyu/mappings/libstdcpp.imp M src/kudu/cfile/index_btree.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/schema.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/log_reader.cc M src/kudu/consensus/log_util.cc M src/kudu/experiments/merge-test.cc M src/kudu/gutil/strings/split.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/internal_mini_cluster.cc M src/kudu/integration-tests/log_verifier.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master-test.cc M src/kudu/security/token-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset_tree-test.cc M src/kudu/tablet/rowset_tree.cc M src/kudu/tablet/tablet-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/scanners-test.cc M src/kudu/util/env-test.cc M src/kudu/util/maintenance_manager.cc M src/kudu/util/make_shared.h M src/kudu/util/mt-threadlocal-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/threadpool-test.cc 40 files changed, 35 insertions(+), 41 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/7867/3 -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [iwyu] fix on
Alexey Serbin has posted comments on this change. Change subject: [iwyu] fix on .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: Line 32: # Usage: > Any particular reason to explain all this now that there's iwyu.sh? We coul The sequence described in this file is for the full IWYU run. Yes, it might be achieved via iwyu.sh as well, but iwyu.sh cannot invoke the tool in parallel, making it very slow (about 3 times slower than regular 'make -j1' run). I'm thinking to preserve this way of running full/non-incremental IWYU coverage. http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: > Shouldn't this new file be referenced in iwyu.sh? yes -- it seems I missed that (i.e. I missed that change in this changelist), my bad -- will fix it. PS2, Line 18: { include: ["", private, "", public ] }, : { include: ["", private, "", public ] }, : { include: ["", private, "", public ] }, : { include: ["", private, "", public ] } > Why all four recommendations? Why not just one, like ? It might happen that the file already includes at least one of the rest: , , . If so, then the would be included transitively, and there is no need to include . As I understand, the idea is that IWYU recommends to include the very first of the listed alternatives (i.e. ) if nothing else is included yet. If other alternative mapping is already applied, then IWYU would happily accept that. -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] Update version to 1.6.0-SNAPSHOT
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7869 to review the following change. Change subject: Update version to 1.6.0-SNAPSHOT .. Update version to 1.6.0-SNAPSHOT Change-Id: I961d9804b34ecdc09884273dbcc62d0de1809d8d --- M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M python/setup.py M version.txt 9 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7869/1 -- To view, visit http://gerrit.cloudera.org:8080/7869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I961d9804b34ecdc09884273dbcc62d0de1809d8d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo
[kudu-CR] Update version to 1.6.0-SNAPSHOT
Adar Dembo has posted comments on this change. Change subject: Update version to 1.6.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I961d9804b34ecdc09884273dbcc62d0de1809d8d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [iwyu] fix on
Alexey Serbin has posted comments on this change. Change subject: [iwyu] fix on .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7867/3/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: Line 53: #include "kudu/util/status.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7867/3/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: Line 57: #include "kudu/util/monotime.h" > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
[kudu-CR] [iwyu] fix on
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7867 to look at the new patch set (#4). Change subject: [iwyu] fix on .. [iwyu] fix on Fixed the issue where IWYU suggested to include the internal GCC header : added additional mapping file which declares the header as a private one, suggesting to include one of the public header files of the standard C++ library files which include the private header file itself and has other references in the context. Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 --- M build-support/iwyu/iwyu-filter.awk M build-support/iwyu/iwyu.sh A build-support/iwyu/mappings/libstdcpp.imp M src/kudu/cfile/index_btree.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/schema.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/log_reader.cc M src/kudu/consensus/log_util.cc M src/kudu/experiments/merge-test.cc M src/kudu/gutil/strings/split.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/internal_mini_cluster.cc M src/kudu/integration-tests/log_verifier.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master-test.cc M src/kudu/security/token-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset_tree-test.cc M src/kudu/tablet/rowset_tree.cc M src/kudu/tablet/tablet-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/scanners-test.cc M src/kudu/util/env-test.cc M src/kudu/util/maintenance_manager.cc M src/kudu/util/make_shared.h M src/kudu/util/mt-threadlocal-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/threadpool-test.cc 40 files changed, 37 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/7867/4 -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] [iwyu] fix on
Adar Dembo has posted comments on this change. Change subject: [iwyu] fix on .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: Line 32: # Usage: > The sequence described in this file is for the full IWYU run. Yes, it migh Okay. http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: PS2, Line 18: { include: ["", private, "", public ] }, : { include: ["", private, "", public ] }, : { include: ["", private, "", public ] }, : { include: ["", private, "", public ] } > It might happen that the file already includes at least one of the rest: would also work (via basic_string.h). Or / (via stl_tree.h). Or / (via stl_construct.h): adar@adar-ThinkPad-T540p:/usr/include/c++/5$ grep -RI ext/alloc_traits.h bits/basic_string.h:#include bits/forward_list.h:#include bits/stl_tree.h:#include bits/stl_construct.h:#include ext/debug_allocator.h:#include unordered_set:#include unordered_map:#include debug/safe_container.h:#include adar@adar-ThinkPad-T540p:/usr/include/c++/5$ grep -RI basic_string.h string:#include adar@adar-ThinkPad-T540p:/usr/include/c++/5$ grep -RI stl_tree.h ext/rb_tree:#include map:#include set:#include adar@adar-ThinkPad-T540p:/usr/include/c++/5$ grep -RI stl_construct.h bits/stl_tempbuf.h:#include ext/slist:#include ext/rope:#include deque:#include memory:#include vector:#include -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
[kudu-CR] Update version to 1.6.0-SNAPSHOT
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7869 to look at the new patch set (#2). Change subject: Update version to 1.6.0-SNAPSHOT .. Update version to 1.6.0-SNAPSHOT Change-Id: I961d9804b34ecdc09884273dbcc62d0de1809d8d --- M java/gradle.properties M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M python/setup.py M version.txt 11 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/7869/2 -- To view, visit http://gerrit.cloudera.org:8080/7869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I961d9804b34ecdc09884273dbcc62d0de1809d8d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [iwyu] fix on
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7867 to look at the new patch set (#5). Change subject: [iwyu] fix on .. [iwyu] fix on Fixed the issue where IWYU suggested to include the internal GCC header : added additional mapping file which declares the header as a private one, suggesting to include one of the public header files of the standard C++ library files. Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 --- M build-support/iwyu/iwyu-filter.awk M build-support/iwyu/iwyu.sh A build-support/iwyu/mappings/libstdcpp.imp M src/kudu/cfile/index_btree.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/schema.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/log_reader.cc M src/kudu/consensus/log_util.cc M src/kudu/experiments/merge-test.cc M src/kudu/gutil/strings/split.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/internal_mini_cluster.cc M src/kudu/integration-tests/log_verifier.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master-test.cc M src/kudu/security/token-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset_tree-test.cc M src/kudu/tablet/rowset_tree.cc M src/kudu/tablet/tablet-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/scanners-test.cc M src/kudu/util/env-test.cc M src/kudu/util/maintenance_manager.cc M src/kudu/util/make_shared.h M src/kudu/util/mt-threadlocal-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/threadpool-test.cc 40 files changed, 44 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/7867/5 -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] [iwyu] fix on
Alexey Serbin has posted comments on this change. Change subject: [iwyu] fix on .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: PS2, Line 18: { include: ["", private, "", public ] }, : { include: ["", private, "", public ] }, : { include: ["", private, "", public ] }, : { include: ["", private, "", public ] } > Makes sense. In gcc 5.4 would also work (via basic_string.h). Or < Thank you for digging out those. I also looked at those for my gcc 5.4.0 at my osx laptop and added header as well. Now we should assume the list is more accurate than the original one. -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
[kudu-CR] [iwyu] fix on
Adar Dembo has posted comments on this change. Change subject: [iwyu] fix on .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
[kudu-CR] Update version to 1.6.0-SNAPSHOT
Adar Dembo has posted comments on this change. Change subject: Update version to 1.6.0-SNAPSHOT .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I961d9804b34ecdc09884273dbcc62d0de1809d8d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Update version to 1.6.0-SNAPSHOT
Dan Burkert has submitted this change and it was merged. Change subject: Update version to 1.6.0-SNAPSHOT .. Update version to 1.6.0-SNAPSHOT Change-Id: I961d9804b34ecdc09884273dbcc62d0de1809d8d Reviewed-on: http://gerrit.cloudera.org:8080/7869 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M java/gradle.properties M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M python/setup.py M version.txt 11 files changed, 11 insertions(+), 11 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961d9804b34ecdc09884273dbcc62d0de1809d8d Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [iwyu] fix on
Alexey Serbin has submitted this change and it was merged. Change subject: [iwyu] fix on .. [iwyu] fix on Fixed the issue where IWYU suggested to include the internal GCC header : added additional mapping file which declares the header as a private one, suggesting to include one of the public header files of the standard C++ library files. Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Reviewed-on: http://gerrit.cloudera.org:8080/7867 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M build-support/iwyu/iwyu-filter.awk M build-support/iwyu/iwyu.sh A build-support/iwyu/mappings/libstdcpp.imp M src/kudu/cfile/index_btree.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/schema.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/log_reader.cc M src/kudu/consensus/log_util.cc M src/kudu/experiments/merge-test.cc M src/kudu/gutil/strings/split.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/internal_mini_cluster.cc M src/kudu/integration-tests/log_verifier.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master-test.cc M src/kudu/security/token-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/lock_manager-test.cc M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset_tree-test.cc M src/kudu/tablet/rowset_tree.cc M src/kudu/tablet/tablet-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/scanners-test.cc M src/kudu/util/env-test.cc M src/kudu/util/maintenance_manager.cc M src/kudu/util/make_shared.h M src/kudu/util/mt-threadlocal-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/threadpool-test.cc 40 files changed, 44 insertions(+), 43 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] consensus peers: don't log tablet copy attempts that were throttled
Adar Dembo has posted comments on this change. Change subject: consensus_peers: don't log tablet copy attempts that were throttled .. Patch Set 1: Verified+1 Filed KUDU-2118 for the precommit failure, which I believe is unrelated to my patch. -- To view, visit http://gerrit.cloudera.org:8080/7868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c7717847c73870110376d0e7052f0118cb0200 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] consensus peers: don't log tablet copy attempts that were throttled
Hao Hao has posted comments on this change. Change subject: consensus_peers: don't log tablet copy attempts that were throttled .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c7717847c73870110376d0e7052f0118cb0200 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Will Berkeley has posted comments on this change. Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7864/2//COMMIT_MSG Commit Message: PS2, Line 7: SEGV > Nit: pedantry, but "SEGV" isn't really a thing. It's either a "segmentation Done http://gerrit.cloudera.org:8080/#/c/7864/2/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: PS2, Line 293: FRIEND_TEST(KsckTest, TestMismatchedAssignments); : FRIEND_TEST(KsckTest, TestConsensusConflictExtraPeer); : FRIEND_TEST(KsckTest, TestConsensusConflictMissingPeer); : FRIEND_TEST(KsckTest, TestConsensusConflictDifferentLeader); : FRIEND_TEST(KsckTest, TestMasterNotReportingTabletServerWithConsensusConflict); > Nit: mind sorting this list alphabetically? Done -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7864 to look at the new patch set (#3). Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. KUDU-2113 Segfault because of consensus conflict and missing tablet server Sometimes the master doesn't report all tablet servers. This can happen, for example, when the master is starting. When this happened and there was also a consensus conflict, it caused a segfault. This fixes the segfault and contains a regression test. Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h 3 files changed, 48 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/7864/3 -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Add release note for CSV/Avro/Parquet import/export
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7852 to look at the new patch set (#3). Change subject: [docs] Add release note for CSV/Avro/Parquet import/export .. [docs] Add release note for CSV/Avro/Parquet import/export Release notes for: 5d53a3b7146c6bcf330ddae0 Change-Id: I5e8b6099e34b017fd552e19c4116eddd1b3a55f6 --- M docs/release_notes.adoc 1 file changed, 8 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/7852/3 -- To view, visit http://gerrit.cloudera.org:8080/7852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e8b6099e34b017fd552e19c4116eddd1b3a55f6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Add release note for CSV/Avro/Parquet import/export
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7852 to look at the new patch set (#4). Change subject: [docs] Add release note for CSV/Avro/Parquet import/export .. [docs] Add release note for CSV/Avro/Parquet import/export Release notes for: 5d53a3b7146c6bcf330ddae0 Change-Id: I5e8b6099e34b017fd552e19c4116eddd1b3a55f6 --- M docs/release_notes.adoc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/7852/4 -- To view, visit http://gerrit.cloudera.org:8080/7852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e8b6099e34b017fd552e19c4116eddd1b3a55f6 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2113 Segfault because of consensus conflict and missing tablet server
Adar Dembo has posted comments on this change. Change subject: KUDU-2113 Segfault because of consensus conflict and missing tablet server .. Patch Set 3: Code-Review+2 Test failure looks unrelated but potentially real. Could you investigate and file a JIRA if it looks legit? -- To view, visit http://gerrit.cloudera.org:8080/7864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No