[kudu-CR] [webui] fixed build and corrected a typo
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. Patch Set 1: Verified-1 Actually, we shouldn't commit this without the pragma keep, otherwise future patches in the area will fail in a similar way. -- To view, visit http://gerrit.cloudera.org:8080/11973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24 Gerrit-Change-Number: 11973 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 21 Nov 2018 05:52:40 + Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Andrew Wong has removed a vote on this change. Change subject: [webui] fixed build and corrected a typo .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24 Gerrit-Change-Number: 11973 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [webui] fixed build and corrected a typo
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. Patch Set 1: Verified+1 Code-Review+2 Yeah, not sure why IWYU is complaining. Perhaps we need to add pragma keep here. There was also a flaky test. -- To view, visit http://gerrit.cloudera.org:8080/11973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24 Gerrit-Change-Number: 11973 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 21 Nov 2018 05:30:02 + Gerrit-HasComments: No
[kudu-CR] build: don't instantiate const objects with no user-defined constructor
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11971 ) Change subject: build: don't instantiate const objects with no user-defined constructor .. build: don't instantiate const objects with no user-defined constructor It seems that some compilers disallow instantiating const objects that don't provide a user-provided constructor. This would surface as the following error. error: default initialization of an object of const type 'const ClusterInfo' requires a user-provided default constructor Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Reviewed-on: http://gerrit.cloudera.org:8080/11971 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/tools/rebalance_algo-test.cc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [webui] fixed build and corrected a typo
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 ) Change subject: [webui] fixed build and corrected a typo .. Patch Set 1: Code-Review+2 I removed those because IWYU told me to. -.- -- To view, visit http://gerrit.cloudera.org:8080/11973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24 Gerrit-Change-Number: 11973 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 21 Nov 2018 04:40:02 + Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11973 Change subject: [webui] fixed build and corrected a typo .. [webui] fixed build and corrected a typo Fixed build for TCMALLOC-enabled environments. Fixed a typo in 'Memory usage by subsystem' WebUI page. This is a follow-up to 7437626f42b30811720d59e792bc905662efd2b3. Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24 --- M src/kudu/server/default_path_handlers.cc 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11973/1 -- To view, visit http://gerrit.cloudera.org:8080/11973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24 Gerrit-Change-Number: 11973 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] build: don't instantiate const objects with no user-defined constructor
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11971 ) Change subject: build: don't instantiate const objects with no user-defined constructor .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc File src/kudu/tools/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc@294 PS1, Line 294: const ClusterInf > Actually thinking about this more, I was curious why this was the case and Yep, that looked suspicious since at line 304 there is similar construct and it worked. Thank you for looking at it again. -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 03:56:00 + Gerrit-HasComments: Yes
[kudu-CR] [webui] drop 'Last status' column for tombstoned tablets
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11972 Change subject: [webui] drop 'Last status' column for tombstoned tablets .. [webui] drop 'Last status' column for tombstoned tablets This is a follow-up to 9a01205ce10b468698c76aedbf51016a90045620. Change-Id: I5c21b9fbf7c6992c8cb29d9cc2d4c11623fa --- M www/tablets.mustache 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/11972/1 -- To view, visit http://gerrit.cloudera.org:8080/11972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5c21b9fbf7c6992c8cb29d9cc2d4c11623fa Gerrit-Change-Number: 11972 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] build: don't use constexpr lambdas
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11970 ) Change subject: build: don't use constexpr lambdas .. build: don't use constexpr lambdas We use constexpr lambdas, and some compilers are fine with it. Officially, they aren't supported until C++17, so this patch replaces such instances with const lambdas. This would yield a build failure in some environments. See https://en.cppreference.com/w/cpp/language/lambda for more details about constexpr lambdas in C++17. Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Reviewed-on: http://gerrit.cloudera.org:8080/11970 Reviewed-by: Adar Dembo Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins --- M src/kudu/tablet/compaction_policy.cc M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tserver/tablet_server-test.cc 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11968 ) Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. [webui] Fancy table for /mem-trackers and sortable tables This fancifies the table of trackers on /mem-trackers in the style of 6ae9ecbe2595090c78e7afd271aae9d04dd4d0b5. It also adds the ability to sort some tables by some numeric columns. Namely: - the /mem-trackers trackers table is sortable by current consumption and peak consumption - the /tablets page tablets tables are sortable by on-disk size - the /maintenance-manager "non-running op" table is sortable by RAM anchored, logs retained, and perf. I tested this change out manually, verifying that ascending and descending sort looked good. Unfortunately, the bootstrap table library doesn't seem to use a stable sort. Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Reviewed-on: http://gerrit.cloudera.org:8080/11968 Reviewed-by: Adar Dembo Reviewed-by: Andrew Wong Tested-by: Kudu Jenkins --- M src/kudu/server/default_path_handlers.cc M src/kudu/server/webserver.cc A www/kudu.js M www/maintenance-manager.mustache M www/tablets.mustache 5 files changed, 90 insertions(+), 13 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Will Berkeley
[kudu-CR] build: explicitly declare decimal Set/Get<>s
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11969 ) Change subject: build: explicitly declare decimal Set/Get<>s .. build: explicitly declare decimal Set/Get<>s Some compilers aren't clever enough to pick up on implicit instantiation of templates based on usage in a given compilation unit, and instead we need to explicitly instantiate them. This surfaced as the following build error: Undefined symbols for architecture x86_64: "kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)15>::cpp_type const&, bool)", referenced from: kudu::client::IntKeysTestSetup >::GenerateSplitRows(kudu::client::KuduSchema const&) const in all_types-itest.cc.o kudu::client::IntKeysTestSetup >::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in all_types-itest.cc.o "kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)16>::cpp_type const&, bool)", referenced from: kudu::client::IntKeysTestSetup >::GenerateSplitRows(kudu::client::KuduSchema const&) const in all_types-itest.cc.o kudu::client::IntKeysTestSetup >::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in all_types-itest.cc.o "kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)17>::cpp_type const&, bool)", referenced from: kudu::client::IntKeysTestSetup >::GenerateSplitRows(kudu::client::KuduSchema const&) const in all_types-itest.cc.o kudu::client::IntKeysTestSetup >::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in all_types-itest.cc.o "kudu::Status kudu::client::KuduScanBatch::RowPtr::Get >(int, kudu::TypeTraits<(kudu::DataType)15>::cpp_type*) const", referenced from: kudu::client::IntKeysTestSetup >::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in all_types-itest.cc.o "kudu::Status kudu::client::KuduScanBatch::RowPtr::Get >(int, kudu::TypeTraits<(kudu::DataType)16>::cpp_type*) const", referenced from: kudu::client::IntKeysTestSetup >::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in all_types-itest.cc.o "kudu::Status kudu::client::KuduScanBatch::RowPtr::Get >(int, kudu::TypeTraits<(kudu::DataType)17>::cpp_type*) const", referenced from: kudu::client::IntKeysTestSetup >::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in all_types-itest.cc.o Change-Id: If280f69b5736737a55862486c98f434cfb8e8072 Reviewed-on: http://gerrit.cloudera.org:8080/11969 Reviewed-by: Adar Dembo Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins --- M src/kudu/client/scan_batch.cc M src/kudu/common/partial_row.cc 2 files changed, 40 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If280f69b5736737a55862486c98f434cfb8e8072 Gerrit-Change-Number: 11969 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11968 ) Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 21 Nov 2018 01:18:34 + Gerrit-HasComments: No
[kudu-CR] build: don't instantiate const objects with no user-defined constructor
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11971 to look at the new patch set (#3). Change subject: build: don't instantiate const objects with no user-defined constructor .. build: don't instantiate const objects with no user-defined constructor It seems that some compilers disallow instantiating const objects that don't provide a user-provided constructor. This would surface as the following error. error: default initialization of an object of const type 'const ClusterInfo' requires a user-provided default constructor Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 --- M src/kudu/tools/rebalance_algo-test.cc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/11971/3 -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] build: don't use constexpr lambdas
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/11970 )
Change subject: build: don't use constexpr lambdas
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc
File src/kudu/tools/rebalance_algo-test.cc:
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc@239
PS1, Line 239: cons
> nit: formatting
Done
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc@239
PS1, Line 239: const TableReplicaMove&
rhs) {
> Nit: indentation
Done
--
To view, visit http://gerrit.cloudera.org:8080/11970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208
Gerrit-Change-Number: 11970
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Nov 2018 01:01:49 +
Gerrit-HasComments: Yes
[kudu-CR] build: don't instantiate const objects with no user-defined constructor
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11971 ) Change subject: build: don't instantiate const objects with no user-defined constructor .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:07:19 + Gerrit-HasComments: No
[kudu-CR] build: explicitly declare decimal Set/Get<>s
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11969 ) Change subject: build: explicitly declare decimal Set/Get<>s .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If280f69b5736737a55862486c98f434cfb8e8072 Gerrit-Change-Number: 11969 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:05:21 + Gerrit-HasComments: No
[kudu-CR] build: don't use constexpr lambdas
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11970 ) Change subject: build: don't use constexpr lambdas .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:03:30 + Gerrit-HasComments: No
[kudu-CR] build: don't instantiate const objects with no user-defined constructor
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11971 ) Change subject: build: don't instantiate const objects with no user-defined constructor .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc File src/kudu/tools/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc@294 PS1, Line 294: ClusterInfo info > I'm curious whether the following (more idiomatic) would help here: It doesn't; that's actually the first thing I tried :/ http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc@324 PS1, Line 324: ClusterInfo info; > ditto Ack -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:03:03 + Gerrit-HasComments: Yes
[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11968 ) Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js File www/kudu.js: http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@41 PS1, Line 41: case 'B': break; > Well, frankly, it's because I copied the body of the switch statement from >From HumanReadableNumBytes::ToDouble: case 'Y': d *= 1024.0; // That's a yotta bytes! It's not _that_ bad... -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 21 Nov 2018 01:02:03 + Gerrit-HasComments: Yes
[kudu-CR] build: don't use constexpr lambdas
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11970 ) Change subject: build: don't use constexpr lambdas .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:02:22 + Gerrit-HasComments: No
[kudu-CR] build: don't instantiate const objects with no user-defined constructor
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11971 ) Change subject: build: don't instantiate const objects with no user-defined constructor .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11971/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11971/1//COMMIT_MSG@7 PS1, Line 7: object > It's not a class member though; it's just a local instantiation. Done -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:02:01 + Gerrit-HasComments: Yes
[kudu-CR] build: don't instantiate const objects with no user-defined constructor
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/11971 )
Change subject: build: don't instantiate const objects with no user-defined
constructor
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc
File src/kudu/tools/rebalance_algo-test.cc:
http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc@294
PS1, Line 294: ClusterInfo info
I'm curious whether the following (more idiomatic) would help here:
const Cluster info = {};
http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc@324
PS1, Line 324: ClusterInfo info;
ditto
--
To view, visit http://gerrit.cloudera.org:8080/11971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7
Gerrit-Change-Number: 11971
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Nov 2018 01:01:48 +
Gerrit-HasComments: Yes
[kudu-CR] build: don't use constexpr lambdas
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11970 to look at the new patch set (#2). Change subject: build: don't use constexpr lambdas .. build: don't use constexpr lambdas We use constexpr lambdas, and some compilers are fine with it. Officially, they aren't supported until C++17, so this patch replaces such instances with const lambdas. This would yield a build failure in some environments. See https://en.cppreference.com/w/cpp/language/lambda for more details about constexpr lambdas in C++17. Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 --- M src/kudu/tablet/compaction_policy.cc M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tserver/tablet_server-test.cc 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11970/2 -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] build: explicitly declare decimal Set/Get<>s
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11969 ) Change subject: build: explicitly declare decimal Set/Get<>s .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If280f69b5736737a55862486c98f434cfb8e8072 Gerrit-Change-Number: 11969 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 00:58:41 + Gerrit-HasComments: No
[kudu-CR] build: don't use constexpr lambdas
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/11970 )
Change subject: build: don't use constexpr lambdas
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc
File src/kudu/tools/rebalance_algo-test.cc:
http://gerrit.cloudera.org:8080/#/c/11970/1/src/kudu/tools/rebalance_algo-test.cc@239
PS1, Line 239: const
TableReplicaMove& rhs) {
Nit: indentation
--
To view, visit http://gerrit.cloudera.org:8080/11970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208
Gerrit-Change-Number: 11970
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Nov 2018 00:58:08 +
Gerrit-HasComments: Yes
[kudu-CR] build: don't instantiate const member with no user-defined constructor
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11971 ) Change subject: build: don't instantiate const member with no user-defined constructor .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11971/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11971/1//COMMIT_MSG@7 PS1, Line 7: member It's not a class member though; it's just a local instantiation. -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 00:57:49 + Gerrit-HasComments: Yes
[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11968 to look at the new patch set (#3). Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. [webui] Fancy table for /mem-trackers and sortable tables This fancifies the table of trackers on /mem-trackers in the style of 6ae9ecbe2595090c78e7afd271aae9d04dd4d0b5. It also adds the ability to sort some tables by some numeric columns. Namely: - the /mem-trackers trackers table is sortable by current consumption and peak consumption - the /tablets page tablets tables are sortable by on-disk size - the /maintenance-manager "non-running op" table is sortable by RAM anchored, logs retained, and perf. I tested this change out manually, verifying that ascending and descending sort looked good. Unfortunately, the bootstrap table library doesn't seem to use a stable sort. Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 --- M src/kudu/server/default_path_handlers.cc M src/kudu/server/webserver.cc A www/kudu.js M www/maintenance-manager.mustache M www/tablets.mustache 5 files changed, 90 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/11968/3 -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Will Berkeley
[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11968 to look at the new patch set (#2). Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. [webui] Fancy table for /mem-trackers and sortable tables This fancifies the table of trackers on /mem-trackers in the style of 6ae9ecbe2595090c78e7afd271aae9d04dd4d0b5. It also adds the ability to sort some tables by some numeric columns. Namely: - the /mem-trackers trackers table is sortable by current consumption and peak consumption - the /tablets page tablets tables are sortable by on-disk size - the /maintenance-manager "non-running op" table is sortable by RAM anchored, logs retained, and perf. I tested this change out manually, verifying that ascending and descending sort looked good. Unfortunately, the bootstrap table library doesn't seem to use a stable sort. Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 --- M src/kudu/server/default_path_handlers.cc M src/kudu/server/webserver.cc A www/kudu.js M www/maintenance-manager.mustache M www/tablets.mustache 5 files changed, 90 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/11968/2 -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Will Berkeley
[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11968 ) Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js File www/kudu.js: http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@18 PS1, Line 18: // Converts a human-readable bytes value like '1.23B' or '985.32M' to a number : // of bytes. The suffix must be present: '1.23' is not valid but '1.23B' is. > Seems like we could relax the suffix restriction if we parsed the last byte Yeah, but I think it's not necessary and it makes the code more complicated. There's also the technical point that 1.23 != 1.23B, just like 1 != 1 foot. Also, this function is meant to invert HumanReadableNumBytes::ToString, which always includes the suffix. http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@41 PS1, Line 41: case 'k': val *= 1024.0; > Curious why we do special treatment for lower-case k but not for any of the Well, frankly, it's because I copied the body of the switch statement from HumanReadableBytes::ToDouble (except for a really terrible joke comment good riddance) and it handles 'K' and 'k'. HumanReadableNumBytes::ToString emits only 'K' so I can remove handling for 'k'. http://gerrit.cloudera.org:8080/#/c/11968/1/www/maintenance-manager.mustache File www/maintenance-manager.mustache: http://gerrit.cloudera.org:8080/#/c/11968/1/www/maintenance-manager.mustache@66 PS1, Line 66: Ram > Nit: isn't 'RAM' a more precise term though? Whoops. Messed up when I rewrote it. -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 21 Nov 2018 00:54:47 + Gerrit-HasComments: Yes
[kudu-CR] build: explicitly declare decimal Set/Get<>s
Hello Alexey Serbin, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11969 to review the following change. Change subject: build: explicitly declare decimal Set/Get<>s .. build: explicitly declare decimal Set/Get<>s Some compilers aren't clever enough to pick up on implicit instantiation of templates based on usage in a given compilation unit, and instead we need to explicitly instantiate them. This surfaced as the following build error: Undefined symbols for architecture x86_64: "kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)15>::cpp_type const&, bool)", referenced from: kudu::client::IntKeysTestSetup >::GenerateSplitRows(kudu::client::KuduSchema const&) const in all_types-itest.cc.o kudu::client::IntKeysTestSetup >::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in all_types-itest.cc.o "kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)16>::cpp_type const&, bool)", referenced from: kudu::client::IntKeysTestSetup >::GenerateSplitRows(kudu::client::KuduSchema const&) const in all_types-itest.cc.o kudu::client::IntKeysTestSetup >::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in all_types-itest.cc.o "kudu::Status kudu::KuduPartialRow::Set >(int, kudu::TypeTraits<(kudu::DataType)17>::cpp_type const&, bool)", referenced from: kudu::client::IntKeysTestSetup >::GenerateSplitRows(kudu::client::KuduSchema const&) const in all_types-itest.cc.o kudu::client::IntKeysTestSetup >::GenerateRowKey(kudu::client::KuduInsert*, int, int) const in all_types-itest.cc.o "kudu::Status kudu::client::KuduScanBatch::RowPtr::Get >(int, kudu::TypeTraits<(kudu::DataType)15>::cpp_type*) const", referenced from: kudu::client::IntKeysTestSetup >::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in all_types-itest.cc.o "kudu::Status kudu::client::KuduScanBatch::RowPtr::Get >(int, kudu::TypeTraits<(kudu::DataType)16>::cpp_type*) const", referenced from: kudu::client::IntKeysTestSetup >::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in all_types-itest.cc.o "kudu::Status kudu::client::KuduScanBatch::RowPtr::Get >(int, kudu::TypeTraits<(kudu::DataType)17>::cpp_type*) const", referenced from: kudu::client::IntKeysTestSetup >::VerifyRowKey(kudu::client::KuduScanBatch::RowPtr const&, int, int) const in all_types-itest.cc.o Change-Id: If280f69b5736737a55862486c98f434cfb8e8072 --- M src/kudu/client/scan_batch.cc M src/kudu/common/partial_row.cc 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/11969/1 -- To view, visit http://gerrit.cloudera.org:8080/11969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If280f69b5736737a55862486c98f434cfb8e8072 Gerrit-Change-Number: 11969 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin
[kudu-CR] build: don't use constexpr lambdas
Hello Alexey Serbin, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11970 to review the following change. Change subject: build: don't use constexpr lambdas .. build: don't use constexpr lambdas We use constexpr lambdas, and some compilers are fine with it. Officially, they aren't supported until C++17, so this patch replaces such instances with const lambdas. This would yield a build failure in some environments. See https://en.cppreference.com/w/cpp/language/lambda for more details about constexpr lambdas in C++17. Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 --- M src/kudu/tablet/compaction_policy.cc M src/kudu/tools/rebalance_algo-test.cc M src/kudu/tserver/tablet_server-test.cc 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11970/1 -- To view, visit http://gerrit.cloudera.org:8080/11970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9d1bdb84d9e6ee5c6a4a920d46f5daee68975208 Gerrit-Change-Number: 11970 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin
[kudu-CR] build: don't instantiate const member with no user-defined constructor
Hello Alexey Serbin, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11971 to review the following change. Change subject: build: don't instantiate const member with no user-defined constructor .. build: don't instantiate const member with no user-defined constructor It seems that some compilers disallow instantiating const objects that don't provide a user-provided constructor. This would surface as the following error. error: default initialization of an object of const type 'const ClusterInfo' requires a user-provided default constructor Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 --- M src/kudu/tools/rebalance_algo-test.cc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/11971/1 -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin
[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11968 ) Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js File www/kudu.js: http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@18 PS1, Line 18: // Converts a human-readable bytes value like '1.23B' or '985.32M' to a number : // of bytes. The suffix must be present: '1.23' is not valid but '1.23B' is. Seems like we could relax the suffix restriction if we parsed the last byte of the string first. If it's a letter, we parse the remaining string into a float and transform the value based on the unit (erroring if it's a letter we don't recognize). If it's a digit, we parse the entire string as a float and don't transform it. http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@41 PS1, Line 41: case 'k': val *= 1024.0; Curious why we do special treatment for lower-case k but not for any of the other units? http://gerrit.cloudera.org:8080/#/c/11968/1/www/maintenance-manager.mustache File www/maintenance-manager.mustache: http://gerrit.cloudera.org:8080/#/c/11968/1/www/maintenance-manager.mustache@66 PS1, Line 66: Ram Nit: isn't 'RAM' a more precise term though? -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Comment-Date: Wed, 21 Nov 2018 00:21:47 + Gerrit-HasComments: Yes
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Will Berkeley
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Patch Set 3: Verified+1 Unrelated flakes in: ConcurrentRebalancersTest.TwoConcurrentRebalancers/1 ToolTest.TestLoadgenDatabaseName -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Nov 2018 23:59:39 + Gerrit-HasComments: No
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. [docs] note on unavailable tservers during rebalancing Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Reviewed-on: http://gerrit.cloudera.org:8080/11966 Reviewed-by: Will Berkeley Tested-by: Alexey Serbin --- M docs/administration.adoc 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Will Berkeley: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Will Berkeley
[kudu-CR](gh-pages) [blog] Call for Posts
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 ) Change subject: [blog] Call for Posts .. Patch Set 2: Code-Review+2 On second review, I think my prior feedback was excessively nitpicky, to feel free to submit as-is (although I'd advocate for the Oxford comma :D) -- To view, visit http://gerrit.cloudera.org:8080/11941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8 Gerrit-Change-Number: 11941 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 20 Nov 2018 23:52:15 + Gerrit-HasComments: No
[kudu-CR] [docs] Contributing to blog
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11940 ) Change subject: [docs] Contributing to blog .. Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc File docs/contributing.adoc: http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@461 PS1, Line 461: How about adding a couple additional small sections here about inviting people to post and also that the developers are willing to do the formatting for people if they want to submit via gdoc? Maybe something like: === Writing a post on the Kudu blog If you are using or integrating with Kudu, consider doing a write-up about your use case and your integration with Kudu and submitting it to be posted as an article on the Kudu blog. People in the community love to read about how Kudu is being used around the world. Consider checking with the project developers on the Kudu Slack instance or on [d...@kudu.apache.org](mailto:d...@kudu.apache.org) if you have any questions about the content or the topic of a 2potential Kudu blog post. === Submitting a blog post in Google Doc format If you don't have the time to learn Markdown or to submit a Gerrit change request, but you would still like to submit a post for the Kudu blog, feel free to write your post in Google Docs format and share the draft with us publicly on [d...@kudu.apache.org](mailto:d...@kudu.apache.org) -- we'll be happy to review it and post it to the blog for you once it's ready to go. If you would like to submit the post directly to Gerrit for review in Markdown format (the developers will appreciate it if you do), please read below. http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@462 PS1, Line 462: Write s/Write/How to format a Kudu blog post/ http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@465 PS1, Line 465: Markdwon Markdown http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@465 PS1, Line 465: compiled s/compiled/automatically rendered/ http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@465 PS1, Line 465: it s/it/Markdown or Jekyll/ http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@466 PS1, Line 466: - nit: s/-// http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@491 PS1, Line 491: Below this header goes the actual blog post The actual text of the blog post goes under this header http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@491 PS1, Line 491: which which is a short excerpt that http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@491 PS1, Line 491: lead "lead" http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@492 PS1, Line 492: separtated nit: separated http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@495 PS1, Line 495: Verify How to check the rendering of a blog post http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@497 PS1, Line 497: it's time to verify there is a command you can run to make sure that http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@499 PS1, Line 499: a s/a // http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@507 PS1, Line 507: teh the http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@515 PS1, Line 515: Submit How to submit a blog post http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@529 PS1, Line 529: it it, http://gerrit.cloudera.org:8080/#/c/11940/1/docs/contributing.adoc@529 PS1, Line 529: verify the post see that the post renders well -- To view, visit http://gerrit.cloudera.org:8080/11940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd8ccae4b15b1ad8b679e0d2d8eabdf5fb5e3a09 Gerrit-Change-Number: 11940 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 20 Nov 2018 23:14:39 + Gerrit-HasComments: Yes
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Nov 2018 23:12:27 + Gerrit-HasComments: No
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Patch Set 2: -Verified (4 comments) http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc@1241 PS2, Line 1241: one or more > Just say "a" instead. Done http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc@1241 PS2, Line 1241: s > Remove plural. Done http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc@1241 PS2, Line 1241: become > becomes Done http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc@1242 PS2, Line 1242: as soon : as it spots at one unavailable tablet servers in the cluster > Remove. Done -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Nov 2018 23:08:05 + Gerrit-HasComments: Yes
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Hello Will Berkeley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11966 to look at the new patch set (#3). Change subject: [docs] note on unavailable tservers during rebalancing .. [docs] note on unavailable tservers during rebalancing Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 --- M docs/administration.adoc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/11966/3 -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Will Berkeley
[kudu-CR](gh-pages) [blog] Call for Posts
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11941 ) Change subject: [blog] Call for Posts .. Patch Set 2: (2 comments) looks great, some minor suggestions http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md File _posts/2018-11-16-call-for-posts.md: http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md@9 PS2, Line 9: testing nit: testing, http://gerrit.cloudera.org:8080/#/c/11941/2/_posts/2018-11-16-call-for-posts.md@14 PS2, Line 14: showcase your project tell the world about how you are using Kudu in your project -- To view, visit http://gerrit.cloudera.org:8080/11941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Icd801585b1be525c635b9def937f9dd0d28fdec8 Gerrit-Change-Number: 11941 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 20 Nov 2018 23:00:46 + Gerrit-HasComments: Yes
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc@1241 PS2, Line 1241: one or more Just say "a" instead. http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc@1241 PS2, Line 1241: become becomes http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc@1241 PS2, Line 1241: s Remove plural. http://gerrit.cloudera.org:8080/#/c/11966/2/docs/administration.adoc@1242 PS2, Line 1242: as soon : as it spots at one unavailable tablet servers in the cluster Remove. -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Nov 2018 23:00:33 + Gerrit-HasComments: Yes
[kudu-CR] [webui] Fancy table for /mem-trackers and sortable tables
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11968 Change subject: [webui] Fancy table for /mem-trackers and sortable tables .. [webui] Fancy table for /mem-trackers and sortable tables This fancifies the table of trackers on /mem-trackers in the style of 6ae9ecbe2595090c78e7afd271aae9d04dd4d0b5. It also adds the ability to sort some tables by some numeric columns. Namely: - the /mem-trackers trackers table is sortable by current consumption and peak consumption - the /tablets page tablets tables are sortable by on-disk size - the /maintenance-manager "non-running op" table is sortable by RAM anchored, logs retained, and perf. I tested this change out manually, verifying that ascending and descending sort looked good. Unfortunately, the bootstrap table library doesn't seem to use a stable sort. Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 --- M src/kudu/server/default_path_handlers.cc M src/kudu/server/webserver.cc A www/kudu.js M www/maintenance-manager.mustache M www/tablets.mustache 5 files changed, 91 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/11968/1 -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Will Berkeley
[kudu-CR] [docs] add Hive Metastore integration
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 22:48:36 + Gerrit-HasComments: No
[kudu-CR] [docs] add Hive Metastore integration
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11798/4/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/11798/4/docs/hive_metastore.adoc@128 PS4, Line 128: Failure to do so may result in metadata inconsistencies between : Kudu and the HMS, such as existing Kudu tables not being present in the HMS and : thus not being discoverable by external HMS-aware components (e.g. Sentry). : Moreover, the existing Impala tables will have outdated metadata in their HMS : entries and may be rendered unusable when Hive Metastore integration is enabled : in Kudu. > Reword: Done -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 22:48:16 + Gerrit-HasComments: Yes
[kudu-CR] [docs] add Hive Metastore integration
Hao Hao has uploaded a new patch set (#5) to the change originally created by Dan Burkert. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. [docs] add Hive Metastore integration Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 --- A docs/hive_metastore.adoc 1 file changed, 160 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/11798/5 -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] add Hive Metastore integration
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11798/4/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/11798/4/docs/hive_metastore.adoc@128 PS4, Line 128: Failure to do so may result in metadata inconsistencies between : Kudu and the HMS. Such as the existing Kudu tables are not present in the HMS and : thus cannot be discovered by any external HMS-aware components (e.g Sentry). : Moreover, the existing Impala tables have outdated metadata in the HMS entries : which is no longer compatible with Impala when the Hive Metastore integration is : enabled. Reword: Failure to do so may result in metadata inconsistencies between Kudu and the HMS, such as existing Kudu tables not being present in the HMS and thus not being discoverable by external HMS-aware components (e.g. Sentry). Moreover, the existing Impala tables will have outdated metadata in their HMS entries and may be rendered unusable when Hive Metastore integration is enabled in Kudu. -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 22:36:33 + Gerrit-HasComments: Yes
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11966 ) Change subject: [docs] note on unavailable tservers during rebalancing .. Patch Set 2: Verified+1 Unrelated flakes in: ConcurrentRebalancersTest.TwoConcurrentRebalancers/1 ToolTest.TestListTables -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Nov 2018 22:39:17 + Gerrit-HasComments: No
[kudu-CR] [docs] add Hive Metastore integration
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@124 PS2, Line 124: When enabling the Hive Metastore integration on a Kudu cluster with existing > OK, you should probably mention this in this section. You don't have to go Done -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 22:27:54 + Gerrit-HasComments: Yes
[kudu-CR] [docs] add Hive Metastore integration
Hao Hao has uploaded a new patch set (#4) to the change originally created by Dan Burkert. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. [docs] add Hive Metastore integration Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 --- A docs/hive_metastore.adoc 1 file changed, 160 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/11798/4 -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11966 to look at the new patch set (#2). Change subject: [docs] note on unavailable tservers during rebalancing .. [docs] note on unavailable tservers during rebalancing Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 --- M docs/administration.adoc 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/11966/2 -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] note on unavailable tservers during rebalancing
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11966 Change subject: [docs] note on unavailable tservers during rebalancing .. [docs] note on unavailable tservers during rebalancing Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 --- M docs/administration.adoc 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/11966/1 -- To view, visit http://gerrit.cloudera.org:8080/11966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifa7a7590a90cee2e2d1399655621ec3618e51b25 Gerrit-Change-Number: 11966 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [docs] add Hive Metastore integration
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@124 PS2, Line 124: When enabling the Hive Metastore integration on a Kudu cluster with existing > If not, the master(s) and tservers(s) can behave normally except, OK, you should probably mention this in this section. You don't have to go into great detail, but it'd be worth warning the admin that if they don't go through this migration, some issues can crop up. -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 21:52:09 + Gerrit-HasComments: Yes
[kudu-CR] De-flake sentry tests
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:
http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.cc@495
PS1, Line 495: case BindMode::UNIQUE_LOOPBACK: {
> Now that this method is free of the mini cluster framework, we should reass
This function should be usable by the mini cluster as well. And it is more
nature and easier for the caller to maintain the index. Thus, I think option 2
makes most sense. I will update the patch to reflect it.
--
To view, visit http://gerrit.cloudera.org:8080/11961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b
Gerrit-Change-Number: 11961
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 20 Nov 2018 21:41:45 +
Gerrit-HasComments: Yes
[kudu-CR] [location awareness] Register client with location when connect to cluster
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/11923 )
Change subject: [location_awareness] Register client with location when connect
to cluster
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/master-test.cc@1626
PS6, Line 1626: TestConnectToMasterRegisterLocation
It would be nice to have a scenario to verify how the system behaves in case if
the location-assignment command returns an error.
http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:
http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/master_service.cc@536
PS6, Line 536: resp->set_client_location(location);
generic/paranoid nit: if GetClientLocation() didn't return Status::OK(), I
think we should not try to set the location field in the response. I think
that's one of the best practices if you think of the GetClientLocation() as a
black box and don't have an assurance that the 'location' out argument is not
touched in case of non-OK return code from the function.
http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/ts_descriptor.cc
File src/kudu/master/ts_descriptor.cc:
http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/ts_descriptor.cc@410
PS6, Line 410: if (!location_mapping_cmd.empty()) {
style code/readability nit: prefer the 'return early' style here, i.e.
if (location_mapping_cmd.empty()) {
return Status::OK();
}
// Continue with the logic specific to the process of running the location
command
...
You can get more details about this at:
https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
http://gerrit.cloudera.org:8080/#/c/11923/6/src/kudu/master/ts_descriptor.cc@415
PS6, Line 415: if (s.ok()) {
: *location = std::move(location_temp);
: } else {
: KLOG_EVERY_N_SECS(ERROR, 60) << Substitute(
: "Unable to assign location to client: $0",
: registration.rpc_addresses(0).host());
: return s;
: }
the same style nit: prefer the 'return early' style
--
To view, visit http://gerrit.cloudera.org:8080/11923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0efb327293d86168a30b05305f69d011ad15587a
Gerrit-Change-Number: 11923
Gerrit-PatchSet: 6
Gerrit-Owner: Fengling Wang
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Fengling Wang
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Tue, 20 Nov 2018 21:19:00 +
Gerrit-HasComments: Yes
[kudu-CR] [docs] add Hive Metastore integration
Hao Hao has uploaded a new patch set (#3) to the change originally created by Dan Burkert. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. [docs] add Hive Metastore integration Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 --- A docs/hive_metastore.adoc 1 file changed, 155 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/11798/3 -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] add Hive Metastore integration
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@46 PS2, Line 46: table identifier names > Nit: "table name identifiers" to match the other usages in this doc. Done http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@67 PS2, Line 67: the Hive database and table : name of Kudu tables > Should this be rewritten as "the database and table names of Kudu tables"? Done http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@107 PS2, Line 107: * Add the `kudu-hive.jar` to the HMS classpath. Using HIVE_AUX_JARS_PATH is > Is this enough context for an admin to understand what needs to be done? I I believe so. If they are not very familiar with HMS/Hive, a google search will show example like this: https://mapr.com/support/s/article/How-to-add-auxiliary-JARs-into-Hive?language=en_US http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@107 PS2, Line 107: Using HIVE_AUX_JARS_PATH is : the most common and straightforward > This reads like it's missing a noun at the end. Common and straightforward Done http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@122 PS2, Line 122: ## Upgrading Existing Tables > I imagine this section may change depending on what the verdict is on exter Yeah, I will add a todo here. http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@124 PS2, Line 124: When enabling the Hive Metastore integration on a Kudu cluster with existing > What happens if you don't run this process? If not, the master(s) and tservers(s) can behave normally except, 1. the existing kudu tables will not be reflected in the HMS and thus may not be protected by Sentry integration. 2. Drop or rename existing kudu tables can fail if modify_external_catalogs flag is set to true. 3. the legacy Impala tables contains outdated metadata in the HMS entries and may not work with the current Impala Integration. 4. whenever administrators runs the 'kudu hms check' tool, it will alarm metadata inconsistencies between Kudu and the HMS. Though table names that only differ by case will prevent the master(s) to start. -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 20:24:36 + Gerrit-HasComments: Yes
[kudu-CR] De-flake sentry tests
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/11961 )
Change subject: De-flake sentry tests
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.h
File src/kudu/util/test_util.h:
http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.h@51
PS1, Line 51: // BindMode lets you specify the socket binding mode for RPC
and/or HTTP server.
Nit: reformat to bring this stuff closer to GetBindIpForDaemon, which is where
it is principally used.
http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:
http://gerrit.cloudera.org:8080/#/c/11961/1/src/kudu/util/test_util.cc@495
PS1, Line 495: case BindMode::UNIQUE_LOOPBACK: {
Now that this method is free of the mini cluster framework, we should reassess
whether it makes sense to keep this complicated DaemonType/index logic.
As I see it, in a standalone test where we want to start one external server
(such as Sentry), there are a few simpler options:
1. Don't use an index at all, since we're only starting one server.
2. Let the test maintain the index to daemon mapping and simplify this to take
just a single index argument.
3. Let GetBindIpForDaemon maintain the index as a static counter.
Options 2 and 3 may also be usable by the mini cluster. So, what do you think
makes the most sense?
--
To view, visit http://gerrit.cloudera.org:8080/11961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b
Gerrit-Change-Number: 11961
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 20 Nov 2018 19:52:42 +
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11963 ) Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. [docs] Add note that it is safe to stop and restart the rebalancer Change-Id: I14745e1b31565f31ff8ff7c7d465eee38f2a22bc Reviewed-on: http://gerrit.cloudera.org:8080/11963 Reviewed-by: Alexey Serbin Reviewed-by: Mitch Barnett Tested-by: Will Berkeley --- M docs/administration.adoc 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Mitch Barnett: Looks good to me, but someone else must approve Will Berkeley: Verified -- To view, visit http://gerrit.cloudera.org:8080/11963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I14745e1b31565f31ff8ff7c7d465eee38f2a22bc Gerrit-Change-Number: 11963 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Will Berkeley
[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11963 ) Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. Patch Set 1: Verified+1 Doc-only change so giving Jenkins the patch off. -- To view, visit http://gerrit.cloudera.org:8080/11963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14745e1b31565f31ff8ff7c7d465eee38f2a22bc Gerrit-Change-Number: 11963 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Nov 2018 19:18:27 + Gerrit-HasComments: No
[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11963 ) Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.cloudera.org:8080/11963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I14745e1b31565f31ff8ff7c7d465eee38f2a22bc Gerrit-Change-Number: 11963 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mitch Barnett
[kudu-CR] [sentry] add mini Sentry to the external mini cluster
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11956 to look at the new patch set (#5). Change subject: [sentry] add mini Sentry to the external mini cluster .. [sentry] add mini Sentry to the external mini cluster This commit enables external mini cluster to be able to start with both mini sentry and mini hms. A major challenge is the circular dependency between the HMS and Sentry in terms of configuring each with the other's address, including port which is currently discovered by polling lsof. To work around it, we can do: * Start the Sentry service. Find out which port it's on. * Start the HMS, configured to talk to Sentry's port. Find out which port it's on. * Restart the Sentry service on the same port, reconfigured to talk to the HMS's port. However, there could be a race condition that another program binds to the same port in step 3. One option is to use SO_REUSEPORT socket option, which permits multiple sockets to be bound to an identical socket address. Though both Sentry and HMS are written in Java, and only JDK9 (and above) supports this socket option[1]. Methods such as Java reflection can be used to invoke private methods to set up this option, but is hacky. This patch extends the UNIQUE_LOOPBACK usage in mini cluster, so that external servers such as Sentry can pick up a unique bind address, knowing that in doing so there'll never be any danger of a port collision. [1]: https://docs.oracle.com/javase/9/docs/api/java/net/StandardSocketOptions.html#SO_REUSEADDR Change-Id: I7f02e6085bd239570d10ec629f48856d37ed6e59 --- M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h M src/kudu/integration-tests/CMakeLists.txt A src/kudu/integration-tests/master_sentry-itest.cc M src/kudu/mini-cluster/CMakeLists.txt M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h M src/kudu/mini-cluster/mini_cluster.cc M src/kudu/mini-cluster/mini_cluster.h M src/kudu/security/test/mini_kdc.cc M src/kudu/sentry/mini_sentry.cc M src/kudu/sentry/mini_sentry.h M src/kudu/sentry/sentry-test-base.h M src/kudu/util/test_util.cc M src/kudu/util/test_util.h 15 files changed, 488 insertions(+), 65 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/11956/5 -- To view, visit http://gerrit.cloudera.org:8080/11956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7f02e6085bd239570d10ec629f48856d37ed6e59 Gerrit-Change-Number: 11956 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] De-flake sentry tests
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 ) Change subject: De-flake sentry tests .. Patch Set 1: Verified+1 Unrelated flaky ConcurrentRebalancersTest. -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 19:12:03 + Gerrit-HasComments: No
[kudu-CR] De-flake sentry tests
Hao Hao has removed a vote on this change. Change subject: De-flake sentry tests .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Id112634ad5e6f0e2c48b7e0e89389faff4f5656b Gerrit-Change-Number: 11961 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11963 ) Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14745e1b31565f31ff8ff7c7d465eee38f2a22bc Gerrit-Change-Number: 11963 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Comment-Date: Tue, 20 Nov 2018 18:52:23 + Gerrit-HasComments: No
[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11963 ) Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14745e1b31565f31ff8ff7c7d465eee38f2a22bc Gerrit-Change-Number: 11963 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Comment-Date: Tue, 20 Nov 2018 18:51:03 + Gerrit-HasComments: No
[kudu-CR] [docs] Add note that it is safe to stop and restart the rebalancer
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11963 Change subject: [docs] Add note that it is safe to stop and restart the rebalancer .. [docs] Add note that it is safe to stop and restart the rebalancer Change-Id: I14745e1b31565f31ff8ff7c7d465eee38f2a22bc --- M docs/administration.adoc 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/11963/1 -- To view, visit http://gerrit.cloudera.org:8080/11963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I14745e1b31565f31ff8ff7c7d465eee38f2a22bc Gerrit-Change-Number: 11963 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley
[kudu-CR] [util] more information on fault injection
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11960 ) Change subject: [util] more information on fault injection .. [util] more information on fault injection Log more information on injected fault: name of the process and PID. That helps to parse concatenated logs: e.g., that useful in parsing logs from scenarios run via dist-test. Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61 Reviewed-on: http://gerrit.cloudera.org:8080/11960 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley --- M src/kudu/util/fault_injection.cc 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Will Berkeley: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61 Gerrit-Change-Number: 11960 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/11869 )
Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to
consider merging small DRSs
..
Patch Set 5: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc
File src/kudu/tablet/compaction_policy-test.cc:
http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc@321
PS4, Line 321: if doing so
: // doesn't actually reduce the number of rowsets
> An original test, TestBudgetedSelection, tests the case of a small number o
SGTM
http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc@381
PS4, Line 381: if (divisor > 2) {
: ASSERT_EQ(rowsets.size(), picked.size());
> Yeah, what I was trying to say in my previous comment was that the existing
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/11869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b421c6ed77d28ebab9b91a4d6fcb1e825997e6c
Gerrit-Change-Number: 11869
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Tue, 20 Nov 2018 16:58:41 +
Gerrit-HasComments: Yes
[kudu-CR] [tools] Don't count tombstoned replicas in `kudu remote replica check`
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11962 ) Change subject: [tools] Don't count tombstoned replicas in `kudu remote_replica check` .. [tools] Don't count tombstoned replicas in `kudu remote_replica check` Counting them as not running made the tool pretty useless on any realistic cluster, where it's expected to have some tombstones. For example, it wasn't possible to use this tool to tell when all the tablet replicas on a tablet server had finished bootstrapping. I tested this against a server that previously failed the check because it had about 6000/1 replicas tombstoned in STOPPED and INITIALIZED states. It now passes the check. Change-Id: Ibbdde768cce5f1d27064b7276944a585b41a2f03 Reviewed-on: http://gerrit.cloudera.org:8080/11962 Reviewed-by: Andrew Wong Tested-by: Kudu Jenkins Reviewed-by: Attila Bukor --- M src/kudu/tablet/metadata.proto M src/kudu/tools/tool_action_remote_replica.cc 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibbdde768cce5f1d27064b7276944a585b41a2f03 Gerrit-Change-Number: 11962 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11958 ) Change subject: [tools] ksck: Add information about replica counts to plain ksck output .. [tools] ksck: Add information about replica counts to plain ksck output This adds some information about replica counts on tablet servers to the output of ksck when ksck is in PLAIN_* mode (i.e. not JSON output). It outputs a 5-number summary of the distribution of replicas and lists any outliers: Tablet Replica Count Summary Statistic| Replica Count +--- Minimum| 1646 First Quartile | 3672 Median | 4075 Third Quartile | 4242 Maximum| 4600 Tablet Replica Count Outliers Type | UUID | Host | Replica Count ---+--++--- Small | cc32936bc8594948a04fd4240da36aed | vc1304.halxg.cloudera.com:7050 | 1646 In PLAIN_FULL mode it additionally outputs the replica count for every tablet server: Tablet Replica Count by Tablet Server UUID | Host | Replica Count --++--- 09d6bf7a02124145b43f43cb7a667b3d | vc1314.halxg.cloudera.com:7050 | 100 23d473f441674d43807fd9e631862bfd | vc1308.halxg.cloudera.com:7050 | 100 2fb5cdac22b0418bb2df456906e42eb4 | vc1306.halxg.cloudera.com:7050 | 101 70f7ee61ead54b1885d819f354eb3405 | vc1316.halxg.cloudera.com:7050 | 95 72fcec63e96f4248ae39d114eb3cd7c9 | vc1318.halxg.cloudera.com:7050 | 94 86708813b37a44bd8e92c711211c8685 | vc1310.halxg.cloudera.com:7050 | 96 a662440710624c02bd5612df32cb0235 | vc1302.halxg.cloudera.com:7050 | 101 c9633273962a4521a32d5e177a118a84 | vc1312.halxg.cloudera.com:7050 | 101 cc32936bc8594948a04fd4240da36aed | vc1304.halxg.cloudera.com:7050 | 76 I also tested it against an empty cluster. There's no unit tests added, just because our current testing setup for ksck makes it really painful to add one for this, and it seemed easy enough to check out manually. Probably, a follow up should straighten out ksck-test to make testing ksck changes easier. Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Reviewed-on: http://gerrit.cloudera.org:8080/11958 Reviewed-by: Andrew Wong Tested-by: Kudu Jenkins --- M src/kudu/tools/ksck_results.cc M src/kudu/tools/ksck_results.h 2 files changed, 131 insertions(+), 0 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Gerrit-Change-Number: 11958 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] Don't count tombstoned replicas in `kudu remote replica check`
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11962 ) Change subject: [tools] Don't count tombstoned replicas in `kudu remote_replica check` .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbdde768cce5f1d27064b7276944a585b41a2f03 Gerrit-Change-Number: 11962 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 09:39:31 + Gerrit-HasComments: No
[kudu-CR] [tools] Don't count tombstoned replicas in `kudu remote replica check`
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11962 ) Change subject: [tools] Don't count tombstoned replicas in `kudu remote_replica check` .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbdde768cce5f1d27064b7276944a585b41a2f03 Gerrit-Change-Number: 11962 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Nov 2018 08:56:09 + Gerrit-HasComments: No
[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11958 ) Change subject: [tools] ksck: Add information about replica counts to plain ksck output .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Gerrit-Change-Number: 11958 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Nov 2018 08:52:17 + Gerrit-HasComments: No
[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output
Hello Fengling Wang, Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11958 to look at the new patch set (#4). Change subject: [tools] ksck: Add information about replica counts to plain ksck output .. [tools] ksck: Add information about replica counts to plain ksck output This adds some information about replica counts on tablet servers to the output of ksck when ksck is in PLAIN_* mode (i.e. not JSON output). It outputs a 5-number summary of the distribution of replicas and lists any outliers: Tablet Replica Count Summary Statistic| Replica Count +--- Minimum| 1646 First Quartile | 3672 Median | 4075 Third Quartile | 4242 Maximum| 4600 Tablet Replica Count Outliers Type | UUID | Host | Replica Count ---+--++--- Small | cc32936bc8594948a04fd4240da36aed | vc1304.halxg.cloudera.com:7050 | 1646 In PLAIN_FULL mode it additionally outputs the replica count for every tablet server: Tablet Replica Count by Tablet Server UUID | Host | Replica Count --++--- 09d6bf7a02124145b43f43cb7a667b3d | vc1314.halxg.cloudera.com:7050 | 100 23d473f441674d43807fd9e631862bfd | vc1308.halxg.cloudera.com:7050 | 100 2fb5cdac22b0418bb2df456906e42eb4 | vc1306.halxg.cloudera.com:7050 | 101 70f7ee61ead54b1885d819f354eb3405 | vc1316.halxg.cloudera.com:7050 | 95 72fcec63e96f4248ae39d114eb3cd7c9 | vc1318.halxg.cloudera.com:7050 | 94 86708813b37a44bd8e92c711211c8685 | vc1310.halxg.cloudera.com:7050 | 96 a662440710624c02bd5612df32cb0235 | vc1302.halxg.cloudera.com:7050 | 101 c9633273962a4521a32d5e177a118a84 | vc1312.halxg.cloudera.com:7050 | 101 cc32936bc8594948a04fd4240da36aed | vc1304.halxg.cloudera.com:7050 | 76 I also tested it against an empty cluster. There's no unit tests added, just because our current testing setup for ksck makes it really painful to add one for this, and it seemed easy enough to check out manually. Probably, a follow up should straighten out ksck-test to make testing ksck changes easier. Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 --- M src/kudu/tools/ksck_results.cc M src/kudu/tools/ksck_results.h 2 files changed, 131 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/11958/4 -- To view, visit http://gerrit.cloudera.org:8080/11958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Gerrit-Change-Number: 11958 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] ksck: Add information about replica counts to plain ksck output
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11958 ) Change subject: [tools] ksck: Add information about replica counts to plain ksck output .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11958/3/src/kudu/tools/ksck_results.h File src/kudu/tools/ksck_results.h: http://gerrit.cloudera.org:8080/#/c/11958/3/src/kudu/tools/ksck_results.h@358 PS3, Line 358: in the latter (default) : // case, only a quartile summary of the counts will be printed. > nit: maybe generalize this to just mention that it prints a summary of the Done -- To view, visit http://gerrit.cloudera.org:8080/11958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Gerrit-Change-Number: 11958 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 20 Nov 2018 08:50:45 + Gerrit-HasComments: Yes
[kudu-CR] [tools] Don't count tombstoned replicas in `kudu remote replica check`
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11962 Change subject: [tools] Don't count tombstoned replicas in `kudu remote_replica check` .. [tools] Don't count tombstoned replicas in `kudu remote_replica check` Counting them as not running made the tool pretty useless on any realistic cluster, where it's expected to have some tombstones. For example, it wasn't possible to use this tool to tell when all the tablet replicas on a tablet server had finished bootstrapping. I tested this against a server that previously failed the check because it had about 6000/1 replicas tombstoned in STOPPED and INITIALIZED states. It now passes the check. Change-Id: Ibbdde768cce5f1d27064b7276944a585b41a2f03 --- M src/kudu/tablet/metadata.proto M src/kudu/tools/tool_action_remote_replica.cc 2 files changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/11962/1 -- To view, visit http://gerrit.cloudera.org:8080/11962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibbdde768cce5f1d27064b7276944a585b41a2f03 Gerrit-Change-Number: 11962 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley
