Re: Review Request 39147: Fix dead link to Committer Checklist on the Committers doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39147/#review102009
---


Patch looks great!

Reviews applied: [39147]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 10:31 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39147/
> ---
> 
> (Updated Oct. 8, 2015, 10:31 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced "https://community.apache.org/committer-candidate-checklist"; with 
> "/documentation/latest/committer-candidate-checklist"
> 
> 
> Diffs
> -
> 
>   docs/committers.md a44333e652ccfde57f97b5b9ede2765a26a4abb3 
> 
> Diff: https://reviews.apache.org/r/39147/diff/
> 
> 
> Testing
> ---
> 
> Check that link was correct via: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38746/#review102006
---



include/mesos/mesos.proto (line 1119)


What's the reasoning behind this order?



src/slave/slave.cpp (line 4509)


Should we say Executor preempted here?

And also I wonder if we should stick with the Qos correction terminology 
here, e.g: Container preempted by QoS correction?


- Timothy Chen


On Oct. 9, 2015, 1:28 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38746/
> ---
> 
> (Updated Oct. 9, 2015, 1:28 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2035
> https://issues.apache.org/jira/browse/MESOS-2035
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added TaskStatus::Reason to containerizer Termination message.
> 
> The following doc summarized the problem and proposed a solution:
> https://docs.google.com/document/d/1klGDAu5yBVf-CGWLqvELLIfxLfRaisGkhi6Gn7952-4/edit?usp=sharing
> 
> 
> Diffs
> -
> 
>   include/mesos/containerizer/containerizer.proto 
> f16ccc89f83da28c413ccfa0687a06b7515a605c 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   include/mesos/slave/isolator.proto 9d38a25470a79af1eda9122c037c82b8cbbad6ed 
>   src/common/protobuf_utils.hpp 8793851fb927ab1326da6b6a424b3c6a75eb5001 
>   src/common/protobuf_utils.cpp c1e8e011e6d0b8e1cd8a836e3168685ec401b21b 
>   src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
>   src/slave/containerizer/external_containerizer.cpp 
> 211649201777f0d2ce802a865090129eacdd53be 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 89c86beb9227eb8a6e70a413e7b3934add652981 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> c324c79f8d598095d07fbcb26e806a0978c2a520 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 4c1419290645ad4c44360a81618a6cea7ad190df 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
>   src/tests/containerizer.cpp 1f743155526192569dd61a47ab67d8e58aab205a 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 8771ef661039310d79845513ea4602e15b2ad13d 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 5bc7d408bda0c249e1b66747d8bd87e688362e6c 
>   src/tests/slave_recovery_tests.cpp fd285fbba0ec08fe2afbdd8da0b0b451126da0eb 
>   src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb 
> 
> Diff: https://reviews.apache.org/r/38746/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> tested with Docker as well.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 29551: Added "tests" target for make.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review102004
---


Patch looks great!

Reviews applied: [39138, 29550, 29551]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 8:21 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> ---
> 
> (Updated Oct. 8, 2015, 8:21 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2273
> https://issues.apache.org/jira/browse/MESOS-2273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586 
>   Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4 
>   docs/submitting-a-patch.md 78ffcfbe74c78abf3cd9d77234f9b61dd29f2ca4 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
> 
> Diff: https://reviews.apache.org/r/29551/diff/
> 
> 
> Testing
> ---
> 
> Ran 'make tests'.
> 
> For added test, ran "make clean; make; make tests" followed by "make check" 
> and verified that no additional target are build in the "make check" step.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 39154: Log IP addresses together with failure messages.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39154/#review102003
---


BTW, please add your shepherd into pepole field.

- Klaus Ma


On Oct. 9, 2015, 1:42 a.m., Brice Arnould wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39154/
> ---
> 
> (Updated Oct. 9, 2015, 1:42 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1661
> https://issues.apache.org/jira/browse/MESOS-1661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log IP addresses together with failure messages.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
> 
> Diff: https://reviews.apache.org/r/39154/diff/
> 
> 
> Testing
> ---
> 
> Ran "make check"
> 
> 
> Thanks,
> 
> Brice Arnould
> 
>

Re: Review Request 39154: Log IP addresses together with failure messages.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39154/#review102002
---



3rdparty/libprocess/src/poll_socket.cpp (line 31)


Would help me to understand why `anonymous` is necessary here?



3rdparty/libprocess/src/poll_socket.cpp (line 32)


Personally, `stringify_` maybe better.



3rdparty/libprocess/src/poll_socket.cpp (line 113)


`Socket` has the following API, is it OK to use to get address?

  Try address() const
  {
return impl->address();
  }



3rdparty/libprocess/src/poll_socket.cpp (line 167)


s/.//



3rdparty/libprocess/src/poll_socket.cpp (line 178)


s/failed/ failed/



3rdparty/libprocess/src/poll_socket.cpp (line 206)


s/failed/ failed/



3rdparty/libprocess/src/poll_socket.cpp (line 218)


Can we pass `this` as parameter? So all info are there in 
`socket_send_data`; I'd like to leave this to your shepherd.


- Klaus Ma


On Oct. 9, 2015, 1:42 a.m., Brice Arnould wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39154/
> ---
> 
> (Updated Oct. 9, 2015, 1:42 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1661
> https://issues.apache.org/jira/browse/MESOS-1661
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log IP addresses together with failure messages.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
> 
> Diff: https://reviews.apache.org/r/39154/diff/
> 
> 
> Testing
> ---
> 
> Ran "make check"
> 
> 
> Thanks,
> 
> Brice Arnould
> 
>

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/#review102000
---


Patch looks great!

Reviews applied: [38705, 38883]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 6:28 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38883/
> ---
> 
> (Updated Oct. 8, 2015, 6:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38883/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38746/#review101996
---


Thanks for doing this, Jie! I have one nit and one question about 
`Isolator::prepare` failure messages below.


src/slave/containerizer/mesos/containerizer.cpp (lines 1107 - 1113)


I am slightly confused here. If one or more `Isolator::prepare` calls 
returned a failure, where are we accumulating the failure messages?



src/slave/slave.hpp (line 303)


s/routine/routines/


- Kapil Arya


On Oct. 8, 2015, 9:28 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38746/
> ---
> 
> (Updated Oct. 8, 2015, 9:28 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2035
> https://issues.apache.org/jira/browse/MESOS-2035
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added TaskStatus::Reason to containerizer Termination message.
> 
> The following doc summarized the problem and proposed a solution:
> https://docs.google.com/document/d/1klGDAu5yBVf-CGWLqvELLIfxLfRaisGkhi6Gn7952-4/edit?usp=sharing
> 
> 
> Diffs
> -
> 
>   include/mesos/containerizer/containerizer.proto 
> f16ccc89f83da28c413ccfa0687a06b7515a605c 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   include/mesos/slave/isolator.proto 9d38a25470a79af1eda9122c037c82b8cbbad6ed 
>   src/common/protobuf_utils.hpp 8793851fb927ab1326da6b6a424b3c6a75eb5001 
>   src/common/protobuf_utils.cpp c1e8e011e6d0b8e1cd8a836e3168685ec401b21b 
>   src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
>   src/slave/containerizer/external_containerizer.cpp 
> 211649201777f0d2ce802a865090129eacdd53be 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 
> 89c86beb9227eb8a6e70a413e7b3934add652981 
>   src/slave/containerizer/isolators/posix/disk.cpp 
> c324c79f8d598095d07fbcb26e806a0978c2a520 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 4c1419290645ad4c44360a81618a6cea7ad190df 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
>   src/tests/containerizer.cpp 1f743155526192569dd61a47ab67d8e58aab205a 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 8771ef661039310d79845513ea4602e15b2ad13d 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 5bc7d408bda0c249e1b66747d8bd87e688362e6c 
>   src/tests/slave_recovery_tests.cpp fd285fbba0ec08fe2afbdd8da0b0b451126da0eb 
>   src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb 
> 
> Diff: https://reviews.apache.org/r/38746/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> tested with Docker as well.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 39100: Changed Credential validation

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39100/#review101997
---


Patch looks great!

Reviews applied: [39135, 39100]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 6:26 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39100/
> ---
> 
> (Updated Oct. 8, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should validate credentials before anything else in HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b9f9ed 
> 
> Diff: https://reviews.apache.org/r/39100/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Review Request 39154: Log IP addresses together with failure messages.

[Brice Arnould]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39154/
---

Review request for mesos.


Bugs: MESOS-1661
https://issues.apache.org/jira/browse/MESOS-1661


Repository: mesos


Description
---

Log IP addresses together with failure messages.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp 
28ed102972a9d8f88048aea4046ed837b6a25b35 

Diff: https://reviews.apache.org/r/39154/diff/


Testing
---

Ran "make check"


Thanks,

Brice Arnould

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38746/
---

(Updated Oct. 9, 2015, 1:28 a.m.)


Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone.


Bugs: MESOS-2035
https://issues.apache.org/jira/browse/MESOS-2035


Repository: mesos


Description
---

Added TaskStatus::Reason to containerizer Termination message.

The following doc summarized the problem and proposed a solution:
https://docs.google.com/document/d/1klGDAu5yBVf-CGWLqvELLIfxLfRaisGkhi6Gn7952-4/edit?usp=sharing


Diffs
-

  include/mesos/containerizer/containerizer.proto 
f16ccc89f83da28c413ccfa0687a06b7515a605c 
  include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
  include/mesos/slave/isolator.proto 9d38a25470a79af1eda9122c037c82b8cbbad6ed 
  src/common/protobuf_utils.hpp 8793851fb927ab1326da6b6a424b3c6a75eb5001 
  src/common/protobuf_utils.cpp c1e8e011e6d0b8e1cd8a836e3168685ec401b21b 
  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
  src/slave/containerizer/external_containerizer.cpp 
211649201777f0d2ce802a865090129eacdd53be 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
89c86beb9227eb8a6e70a413e7b3934add652981 
  src/slave/containerizer/isolators/posix/disk.cpp 
c324c79f8d598095d07fbcb26e806a0978c2a520 
  src/slave/containerizer/mesos/containerizer.hpp 
4c1419290645ad4c44360a81618a6cea7ad190df 
  src/slave/containerizer/mesos/containerizer.cpp 
b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
  src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
  src/tests/containerizer.cpp 1f743155526192569dd61a47ab67d8e58aab205a 
  src/tests/containerizer/docker_containerizer_tests.cpp 
8771ef661039310d79845513ea4602e15b2ad13d 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
5bc7d408bda0c249e1b66747d8bd87e688362e6c 
  src/tests/slave_recovery_tests.cpp fd285fbba0ec08fe2afbdd8da0b0b451126da0eb 
  src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb 

Diff: https://reviews.apache.org/r/38746/diff/


Testing (updated)
---

sudo make check

tested with Docker as well.


Thanks,

Jie Yu

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38746/
---

(Updated Oct. 9, 2015, 1:27 a.m.)


Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone.


Bugs: MESOS-2035
https://issues.apache.org/jira/browse/MESOS-2035


Repository: mesos


Description (updated)
---

Added TaskStatus::Reason to containerizer Termination message.

The following doc summarized the problem and proposed a solution:
https://docs.google.com/document/d/1klGDAu5yBVf-CGWLqvELLIfxLfRaisGkhi6Gn7952-4/edit?usp=sharing


Diffs
-

  include/mesos/containerizer/containerizer.proto 
f16ccc89f83da28c413ccfa0687a06b7515a605c 
  include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
  include/mesos/slave/isolator.proto 9d38a25470a79af1eda9122c037c82b8cbbad6ed 
  src/common/protobuf_utils.hpp 8793851fb927ab1326da6b6a424b3c6a75eb5001 
  src/common/protobuf_utils.cpp c1e8e011e6d0b8e1cd8a836e3168685ec401b21b 
  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
  src/slave/containerizer/external_containerizer.cpp 
211649201777f0d2ce802a865090129eacdd53be 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
89c86beb9227eb8a6e70a413e7b3934add652981 
  src/slave/containerizer/isolators/posix/disk.cpp 
c324c79f8d598095d07fbcb26e806a0978c2a520 
  src/slave/containerizer/mesos/containerizer.hpp 
4c1419290645ad4c44360a81618a6cea7ad190df 
  src/slave/containerizer/mesos/containerizer.cpp 
b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
  src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
  src/tests/containerizer.cpp 1f743155526192569dd61a47ab67d8e58aab205a 
  src/tests/containerizer/docker_containerizer_tests.cpp 
8771ef661039310d79845513ea4602e15b2ad13d 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
5bc7d408bda0c249e1b66747d8bd87e688362e6c 
  src/tests/slave_recovery_tests.cpp fd285fbba0ec08fe2afbdd8da0b0b451126da0eb 
  src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb 

Diff: https://reviews.apache.org/r/38746/diff/


Testing
---

sudo make check

@tnachen, I need you to help test this patch with docker containerizer.


Thanks,

Jie Yu

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38746/
---

(Updated Oct. 9, 2015, 1:27 a.m.)


Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone.


Changes
---

Did a few changes according to this doc:
https://docs.google.com/document/d/1klGDAu5yBVf-CGWLqvELLIfxLfRaisGkhi6Gn7952-4/edit?usp=sharing


Bugs: MESOS-2035
https://issues.apache.org/jira/browse/MESOS-2035


Repository: mesos


Description
---

Added TaskStatus::Reason to containerizer Termination message.


Diffs (updated)
-

  include/mesos/containerizer/containerizer.proto 
f16ccc89f83da28c413ccfa0687a06b7515a605c 
  include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
  include/mesos/slave/isolator.proto 9d38a25470a79af1eda9122c037c82b8cbbad6ed 
  src/common/protobuf_utils.hpp 8793851fb927ab1326da6b6a424b3c6a75eb5001 
  src/common/protobuf_utils.cpp c1e8e011e6d0b8e1cd8a836e3168685ec401b21b 
  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
  src/slave/containerizer/external_containerizer.cpp 
211649201777f0d2ce802a865090129eacdd53be 
  src/slave/containerizer/isolators/cgroups/mem.cpp 
89c86beb9227eb8a6e70a413e7b3934add652981 
  src/slave/containerizer/isolators/posix/disk.cpp 
c324c79f8d598095d07fbcb26e806a0978c2a520 
  src/slave/containerizer/mesos/containerizer.hpp 
4c1419290645ad4c44360a81618a6cea7ad190df 
  src/slave/containerizer/mesos/containerizer.cpp 
b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
  src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
  src/tests/containerizer.cpp 1f743155526192569dd61a47ab67d8e58aab205a 
  src/tests/containerizer/docker_containerizer_tests.cpp 
8771ef661039310d79845513ea4602e15b2ad13d 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
5bc7d408bda0c249e1b66747d8bd87e688362e6c 
  src/tests/slave_recovery_tests.cpp fd285fbba0ec08fe2afbdd8da0b0b451126da0eb 
  src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb 

Diff: https://reviews.apache.org/r/38746/diff/


Testing
---

sudo make check

@tnachen, I need you to help test this patch with docker containerizer.


Thanks,

Jie Yu

Re: Review Request 38579: Refactored registry client

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
---

(Updated Oct. 9, 2015, 12:58 a.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

created more sub-patches.


Repository: mesos


Description
---

- Cleanup and broke big methods into smaller chunks.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38579/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

[Greg Mann]

> On Oct. 9, 2015, 12:46 a.m., Neil Conway wrote:
> > src/tests/containerizer/mesos_containerizer_tests.cpp, line 307
> > 
> >
> > Modifying the environment doesn't seem like a great thing for a test to 
> > be doing, since it might impact other tests -- we should at least reset 
> > LIBPROCESS_IP to its previous value at the end of the test. That still 
> > isn't great (e.g., if we want to run multiple tests concurrently in the 
> > same OS process), but I'm not sure there's a better way.

Good call, thanks Neil!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/#review101992
---


On Oct. 9, 2015, 12:57 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39152/
> ---
> 
> (Updated Oct. 9, 2015, 12:57 a.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-3553
> https://issues.apache.org/jira/browse/MESOS-3553
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If DNS is not available on the agent node and a task is launched which 
> explicitly specifies the executor's environment, LIBPROCESS_IP will not be 
> passed through and the default hostname lookup after spawning the executor 
> process will throw an error. This patch alters the agent to always pass 
> LIBPROCESS_IP, even when the executor environment is specified.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 25c87e9f948b7efe8b9a853c403bee69982d6c4c 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 5bc7d408bda0c249e1b66747d8bd87e688362e6c 
> 
> Diff: https://reviews.apache.org/r/39152/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39014: RegistryClient refactor: renamed ManifestResponse

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/
---

(Updated Oct. 9, 2015, 12:58 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased after reordering patches.


Repository: mesos


Description
---

RegistryClient refactor: renamed ManifestResponse as per review comments.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
fdb68b675582f603ffb3e96f31c1c9405e238567 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39014/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Review Request 39155: RegistryClient refactor: removed nested namespace references

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39155/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

RegistryClient refactor: removed nested namespace references


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 

Diff: https://reviews.apache.org/r/39155/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/
---

(Updated Oct. 9, 2015, 12:57 a.m.)


Review request for mesos and Kapil Arya.


Changes
---

Addressed comment.


Bugs: MESOS-3553
https://issues.apache.org/jira/browse/MESOS-3553


Repository: mesos


Description
---

If DNS is not available on the agent node and a task is launched which 
explicitly specifies the executor's environment, LIBPROCESS_IP will not be 
passed through and the default hostname lookup after spawning the executor 
process will throw an error. This patch alters the agent to always pass 
LIBPROCESS_IP, even when the executor environment is specified.


Diffs (updated)
-

  src/slave/containerizer/containerizer.cpp 
25c87e9f948b7efe8b9a853c403bee69982d6c4c 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
5bc7d408bda0c249e1b66747d8bd87e688362e6c 

Diff: https://reviews.apache.org/r/39152/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Review Request 39156: RegistryClient refactor: changed getManifest interface

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39156/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

RegistryClient refactor: changed getManifest interface


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
fdb68b675582f603ffb3e96f31c1c9405e238567 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39156/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/#review101992
---



src/tests/containerizer/mesos_containerizer_tests.cpp (line 307)


Modifying the environment doesn't seem like a great thing for a test to be 
doing, since it might impact other tests -- we should at least reset 
LIBPROCESS_IP to its previous value at the end of the test. That still isn't 
great (e.g., if we want to run multiple tests concurrently in the same OS 
process), but I'm not sure there's a better way.


- Neil Conway


On Oct. 9, 2015, 12:37 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39152/
> ---
> 
> (Updated Oct. 9, 2015, 12:37 a.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-3553
> https://issues.apache.org/jira/browse/MESOS-3553
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If DNS is not available on the agent node and a task is launched which 
> explicitly specifies the executor's environment, LIBPROCESS_IP will not be 
> passed through and the default hostname lookup after spawning the executor 
> process will throw an error. This patch alters the agent to always pass 
> LIBPROCESS_IP, even when the executor environment is specified.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 25c87e9f948b7efe8b9a853c403bee69982d6c4c 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 5bc7d408bda0c249e1b66747d8bd87e688362e6c 
> 
> Diff: https://reviews.apache.org/r/39152/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

[Kapil Arya]

> On Oct. 8, 2015, 5:24 p.m., James Peach wrote:
> > You should also rename ```benchmarks``` and ```ssl-client```.
> 
> Kapil Arya wrote:
> Good suggestion. But I think, it will be better to do that in a separate 
> RR (just to keep this RR chain strictly relevant for `make tests`).
> 
> James Peach wrote:
> It will take longer to file the tickets and reviews than to just make the 
> change now :)

I think it's not about longer or shorter. I am more concerned about this RR 
chain being a build-only change vs. something that touches other files, etc. :).


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39138/#review101957
---


On Oct. 8, 2015, 3:28 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39138/
> ---
> 
> (Updated Oct. 8, 2015, 3:28 p.m.)
> 
> 
> Review request for mesos, James Peach and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3584
> https://issues.apache.org/jira/browse/MESOS-3584
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
> 
> Diff: https://reviews.apache.org/r/39138/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39152/
---

Review request for mesos and Kapil Arya.


Bugs: MESOS-3553
https://issues.apache.org/jira/browse/MESOS-3553


Repository: mesos


Description
---

If DNS is not available on the agent node and a task is launched which 
explicitly specifies the executor's environment, LIBPROCESS_IP will not be 
passed through and the default hostname lookup after spawning the executor 
process will throw an error. This patch alters the agent to always pass 
LIBPROCESS_IP, even when the executor environment is specified.


Diffs
-

  src/slave/containerizer/containerizer.cpp 
25c87e9f948b7efe8b9a853c403bee69982d6c4c 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
5bc7d408bda0c249e1b66747d8bd87e688362e6c 

Diff: https://reviews.apache.org/r/39152/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/#review101988
---


Patch looks great!

Reviews applied: [39005, 39007]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 6:15 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39007/
> ---
> 
> (Updated Oct. 8, 2015, 6:15 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 28ed102972a9d8f88048aea4046ed837b6a25b35 
>   3rdparty/libprocess/src/process.cpp 
> d1c81f1d244f02bf42cab97198587ce1b8c7c407 
>   3rdparty/libprocess/src/profiler.cpp 
> 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
>   3rdparty/libprocess/src/subprocess.cpp 
> a457cbe35ad33531c49f74550cd570cf28758f5d 
> 
> Diff: https://reviews.apache.org/r/39007/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/
---

(Updated Oct. 8, 2015, 11:05 p.m.)


Review request for mesos, Anand Mazumdar, Ben Mahler, Jie Yu, Jojy Varghese, 
and Jiang Yan Xu.


Bugs: MESOS-3429
https://issues.apache.org/jira/browse/MESOS-3429


Repository: mesos


Description
---

Allow HTTP response codes to be checked with code.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
591c1a959057155e1bf0f5bd73352e78d1c15cb3 
  3rdparty/libprocess/src/decoder.hpp 53b8079968a0145651bad9d11aa4be2b504de57a 
  3rdparty/libprocess/src/http.cpp ebf76093d654397260fc8da84c4f2b0fd6541483 
  3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407 
  3rdparty/libprocess/src/tests/benchmarks.cpp 
bb9ced8933bf2bb97ae6b3cffdb5528676e53c11 
  3rdparty/libprocess/src/tests/http_tests.cpp 
38f3ad7e46f5b6ef4850cdf7fdcc115715e98472 
  3rdparty/libprocess/src/tests/process_tests.cpp 
ffd260a3fa2e49b3de183ba7b392b71afaaba2e5 

Diff: https://reviews.apache.org/r/38416/diff/


Testing
---

make


Thanks,

Timothy Chen

Re: Review Request 38779: Use new HTTP status code check in scheduler.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/
---

(Updated Oct. 8, 2015, 11:06 p.m.)


Review request for mesos, Anand Mazumdar and Ben Mahler.


Repository: mesos


Description
---

Use new HTTP status code check in scheduler.


Diffs (updated)
-

  src/scheduler/scheduler.cpp 56801ca6ffc9f9f0e4bd12dbf535e9c5251c2712 

Diff: https://reviews.apache.org/r/38779/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

[James Peach]

> On Oct. 8, 2015, 9:24 p.m., James Peach wrote:
> > You should also rename ```benchmarks``` and ```ssl-client```.
> 
> Kapil Arya wrote:
> Good suggestion. But I think, it will be better to do that in a separate 
> RR (just to keep this RR chain strictly relevant for `make tests`).

It will take longer to file the tickets and reviews than to just make the 
change now :)


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39138/#review101957
---


On Oct. 8, 2015, 7:28 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39138/
> ---
> 
> (Updated Oct. 8, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, James Peach and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3584
> https://issues.apache.org/jira/browse/MESOS-3584
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
> 
> Diff: https://reviews.apache.org/r/39138/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 39147: Fix dead link to Committer Checklist on the Committers doc.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39147/#review101975
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 8, 2015, 10:31 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39147/
> ---
> 
> (Updated Oct. 8, 2015, 10:31 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced "https://community.apache.org/committer-candidate-checklist"; with 
> "/documentation/latest/committer-candidate-checklist"
> 
> 
> Diffs
> -
> 
>   docs/committers.md a44333e652ccfde57f97b5b9ede2765a26a4abb3 
> 
> Diff: https://reviews.apache.org/r/39147/diff/
> 
> 
> Testing
> ---
> 
> Check that link was correct via: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38910: Added `-v` flag to `docker rm`.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38910/#review101972
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 7, 2015, 5:34 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38910/
> ---
> 
> (Updated Oct. 7, 2015, 5:34 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-2613
> https://issues.apache.org/jira/browse/MESOS-2613
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `-v` flag to `docker rm`.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
> 
> Diff: https://reviews.apache.org/r/38910/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> DockerContainerizerTest.ROOT_DOCKER_Launch_Executor fails on my Ubuntu 14.04 
> VM, but this is a known issue: MESOS-3123
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 39147: Fix dead link to Committer Checklist on the Committers doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39147/
---

Review request for mesos, Adam B, Artem Harutyunyan, and Timothy Chen.


Repository: mesos


Description
---

Replaced "https://community.apache.org/committer-candidate-checklist"; with 
"/documentation/latest/committer-candidate-checklist"


Diffs
-

  docs/committers.md a44333e652ccfde57f97b5b9ede2765a26a4abb3 

Diff: https://reviews.apache.org/r/39147/diff/


Testing
---

Check that link was correct via: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Joseph Wu

Re: Review Request 39141: Store: minor style changes

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39141/#review101971
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 8, 2015, 9:51 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39141/
> ---
> 
> (Updated Oct. 8, 2015, 9:51 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Store: minor style changes
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/store.cpp 
> cbb67686d45513f0395a0cf1bc5c43cb4935adae 
> 
> Diff: https://reviews.apache.org/r/39141/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39060: Create master detector per url & not per framework

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39060/#review101970
---


Patch looks great!

Reviews applied: [39060]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 5:05 p.m., Mandeep Chadha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39060/
> ---
> 
> (Updated Oct. 8, 2015, 5:05 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3595
> https://issues.apache.org/jira/browse/MESOS-3595
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the number of framework created exceeds the lib process
> threads then during master failover the zookeeper updates can
> cause deadlock.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
> 
> Diff: https://reviews.apache.org/r/39060/diff/
> 
> 
> Testing
> ---
> 
> make check successful 
> Created 100 framework instances on a 24 CPU machine. Master failover detected 
> by the framework process and continue to work as expected.
> 
> 
> Thanks,
> 
> Mandeep Chadha
> 
>

Re: Review Request 39141: Store: minor style changes

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39141/#review101964
---

Ship it!


Ship It!

- Anand Mazumdar


On Oct. 8, 2015, 9:51 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39141/
> ---
> 
> (Updated Oct. 8, 2015, 9:51 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Store: minor style changes
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/store.cpp 
> cbb67686d45513f0395a0cf1bc5c43cb4935adae 
> 
> Diff: https://reviews.apache.org/r/39141/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39141: Store: minor style changes

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39141/
---

(Updated Oct. 8, 2015, 9:51 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

reverted back emplace_back. There is a ton of information of why emplace_back 
is preferred([1], [2]) but we might need a general agreement on the adopting 
the usage.

1] http://www.gahcep.com/cpp-internals-stl-vector-part-2/
2] 
http://stackoverflow.com/questions/26860749/efficiency-of-c11-push-back-with-stdmove-versus-emplace-back-for-already


Repository: mesos


Description
---

Store: minor style changes


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/store.cpp 
cbb67686d45513f0395a0cf1bc5c43cb4935adae 

Diff: https://reviews.apache.org/r/39141/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

[Kapil Arya]

> On Oct. 8, 2015, 5:24 p.m., James Peach wrote:
> > You should also rename ```benchmarks``` and ```ssl-client```.

Good suggestion. But I think, it will be better to do that in a separate RR 
(just to keep this RR chain strictly relevant for `make tests`).


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39138/#review101957
---


On Oct. 8, 2015, 3:28 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39138/
> ---
> 
> (Updated Oct. 8, 2015, 3:28 p.m.)
> 
> 
> Review request for mesos, James Peach and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3584
> https://issues.apache.org/jira/browse/MESOS-3584
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
> 
> Diff: https://reviews.apache.org/r/39138/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39138/#review101957
---


You should also rename ```benchmarks``` and ```ssl-client```.

- James Peach


On Oct. 8, 2015, 7:28 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39138/
> ---
> 
> (Updated Oct. 8, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, James Peach and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3584
> https://issues.apache.org/jira/browse/MESOS-3584
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
> 
> Diff: https://reviews.apache.org/r/39138/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review101956
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 54)


We have to support CentOS 5 which has glibc 2.5 FWICT.


- Ben Mahler


On Oct. 8, 2015, 2:29 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> ---
> 
> (Updated Oct. 8, 2015, 2:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a thread-safe wrapper around strerror_r which has semantics similar 
> to strerror. We plan to use this at call sites currently relying on strerror.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39141: Store: minor style changes

[Jojy Varghese]

> On Oct. 8, 2015, 7:40 p.m., Anand Mazumdar wrote:
> > src/slave/containerizer/provisioner/docker/store.cpp, line 202
> > 
> >
> > In this particular case, `push_back` would also do a `std::move` for a 
> > temporary object and I wonder why do we even need `emplace_back` here ?
> > 
> > I even don't know if an overload like `emplace_back(T&& value)` even 
> > existed and how does it compile even ?
> > 
> > http://en.cppreference.com/w/cpp/container/vector/emplace_back

post c++11, emplace_back is the preferred way to insert into containers, 
especially when dealing with temporaries. The only reason to use push_back is 
if you want to support pre-c++11 compilers.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39141/#review101951
---


On Oct. 8, 2015, 7:30 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39141/
> ---
> 
> (Updated Oct. 8, 2015, 7:30 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Store: minor style changes
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/store.cpp 
> cbb67686d45513f0395a0cf1bc5c43cb4935adae 
> 
> Diff: https://reviews.apache.org/r/39141/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 29551: Added "tests" target for make.

[Kapil Arya]

> On Oct. 8, 2015, 4:15 p.m., Neil Conway wrote:
> > Can you update the docs to mention this? Maybe just submitting-a-patch.

Done! :-)


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review101953
---


On Oct. 8, 2015, 4:21 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> ---
> 
> (Updated Oct. 8, 2015, 4:21 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2273
> https://issues.apache.org/jira/browse/MESOS-2273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586 
>   Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4 
>   docs/submitting-a-patch.md 78ffcfbe74c78abf3cd9d77234f9b61dd29f2ca4 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
> 
> Diff: https://reviews.apache.org/r/29551/diff/
> 
> 
> Testing
> ---
> 
> Ran 'make tests'.
> 
> For added test, ran "make clean; make; make tests" followed by "make check" 
> and verified that no additional target are build in the "make check" step.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 29551: Added "tests" target for make.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/
---

(Updated Oct. 8, 2015, 4:21 p.m.)


Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and 
Timothy St. Clair.


Changes
---

Updated submitting-a-patch.md file as well.


Bugs: MESOS-2273
https://issues.apache.org/jira/browse/MESOS-2273


Repository: mesos


Description
---

'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.


Diffs (updated)
-

  3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586 
  Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4 
  docs/submitting-a-patch.md 78ffcfbe74c78abf3cd9d77234f9b61dd29f2ca4 
  src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 

Diff: https://reviews.apache.org/r/29551/diff/


Testing
---

Ran 'make tests'.

For added test, ran "make clean; make; make tests" followed by "make check" and 
verified that no additional target are build in the "make check" step.


Thanks,

Kapil Arya

Re: Review Request 29551: Added "tests" target for make.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review101953
---


Can you update the docs to mention this? Maybe just submitting-a-patch.

- Neil Conway


On Oct. 8, 2015, 7:29 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> ---
> 
> (Updated Oct. 8, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2273
> https://issues.apache.org/jira/browse/MESOS-2273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586 
>   Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
> 
> Diff: https://reviews.apache.org/r/29551/diff/
> 
> 
> Testing
> ---
> 
> Ran 'make tests'.
> 
> For added test, ran "make clean; make; make tests" followed by "make check" 
> and verified that no additional target are build in the "make check" step.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 39141: Store: minor style changes

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39141/#review101951
---



src/slave/containerizer/provisioner/docker/store.cpp (line 202)


In this particular case, `push_back` would also do a `std::move` for a 
temporary object and I wonder why do we even need `emplace_back` here ?

I even don't know if an overload like `emplace_back(T&& value)` even 
existed and how does it compile even ?

http://en.cppreference.com/w/cpp/container/vector/emplace_back


- Anand Mazumdar


On Oct. 8, 2015, 7:30 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39141/
> ---
> 
> (Updated Oct. 8, 2015, 7:30 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Store: minor style changes
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/store.cpp 
> cbb67686d45513f0395a0cf1bc5c43cb4935adae 
> 
> Diff: https://reviews.apache.org/r/39141/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 37024: Exposes mesos version information in components.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101841
---

Ship it!


Thanks for your patience! Committing this shortly.


src/version/version.cpp (line 61)


Let's do a s/add_version/branch/ here just to be a bit simpler


- Ben Mahler


On Oct. 8, 2015, 7:01 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> ---
> 
> (Updated Oct. 8, 2015, 7:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint exposes Apache Mesos build informations and version 
> information.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
>   src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
>   src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
>   src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae 
>   src/version/version.hpp PRE-CREATION 
>   src/version/version.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37024/diff/
> 
> 
> Testing
> ---
> 
> Manual test result:
> 
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> {
>   "version": "0.26.0",
>   "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
>   "git_branch": "refs/heads/MESOS-1841",
>   "build_user": "haosdent",
>   "build_time": 1444185166,
>   "build_date": "2015-10-07 10:32:46"
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 39141: Store: minor style changes

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39141/
---

Review request for mesos and Timothy Chen.


Repository: mesos


Description
---

Store: minor style changes


Diffs
-

  src/slave/containerizer/provisioner/docker/store.cpp 
cbb67686d45513f0395a0cf1bc5c43cb4935adae 

Diff: https://reviews.apache.org/r/39141/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 29551: Added "tests" target for make.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/
---

(Updated Oct. 8, 2015, 3:29 p.m.)


Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and 
Timothy St. Clair.


Bugs: MESOS-2273
https://issues.apache.org/jira/browse/MESOS-2273


Repository: mesos


Description
---

'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.


Diffs (updated)
-

  3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586 
  Makefile.am cb289b4f21516c3027429d8f8ba72d799f975bd4 
  src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 

Diff: https://reviews.apache.org/r/29551/diff/


Testing
---

Ran 'make tests'.

For added test, ran "make clean; make; make tests" followed by "make check" and 
verified that no additional target are build in the "make check" step.


Thanks,

Kapil Arya

Re: Review Request 29550: Libprocess: Added "tests" target for make.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/
---

(Updated Oct. 8, 2015, 3:29 p.m.)


Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and 
Timothy St. Clair.


Bugs: MESOS-2273
https://issues.apache.org/jira/browse/MESOS-2273


Repository: mesos


Description
---

'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
e64e3d9e958fab3c7c25fad17dcc2b279d255500 
  3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 

Diff: https://reviews.apache.org/r/29550/diff/


Testing
---

Ran make tests.

For added test, ran "make clean; make; make tests" followed by "make check" and 
verified that no additional target are build in the "make check" step.


Thanks,

Kapil Arya

Review Request 39138: Renamed libprocess tests to libprocess-tests.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39138/
---

Review request for mesos, James Peach and Joris Van Remoortere.


Bugs: MESOS-3584
https://issues.apache.org/jira/browse/MESOS-3584


Repository: mesos


Description
---

See summary


Diffs
-

  3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 

Diff: https://reviews.apache.org/r/39138/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 39137: Local puller: fixed minor style issues.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39137/#review101948
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 8, 2015, 6:43 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39137/
> ---
> 
> (Updated Oct. 8, 2015, 6:43 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Local puller: fixed minor style issues.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 4a0b7d11f013941084571f2d89d835a4668a3d8b 
> 
> Diff: https://reviews.apache.org/r/39137/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39136: Fixed log message when untarring local image

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39136/#review101947
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 8, 2015, 6:43 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39136/
> ---
> 
> (Updated Oct. 8, 2015, 6:43 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed log message when untarring local image
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 
> 4a0b7d11f013941084571f2d89d835a4668a3d8b 
> 
> Diff: https://reviews.apache.org/r/39136/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Review Request 39136: Fixed log message when untarring local image

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39136/
---

Review request for mesos and Timothy Chen.


Repository: mesos


Description
---

Fixed log message when untarring local image


Diffs
-

  src/slave/containerizer/provisioner/docker/local_puller.cpp 
4a0b7d11f013941084571f2d89d835a4668a3d8b 

Diff: https://reviews.apache.org/r/39136/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Review Request 39137: Local puller: fixed minor style issues.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39137/
---

Review request for mesos and Timothy Chen.


Repository: mesos


Description
---

Local puller: fixed minor style issues.


Diffs
-

  src/slave/containerizer/provisioner/docker/local_puller.cpp 
4a0b7d11f013941084571f2d89d835a4668a3d8b 

Diff: https://reviews.apache.org/r/39137/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Artem Harutyunyan]

> On Oct. 3, 2015, 7:46 a.m., haosdent huang wrote:
> > IMHO, we keep both apply-reviews.py and apply-reviews.sh and call 
> > apply-reviews.sh in apply-reviews.py looks strange. It would be better we 
> > add this function to apply-review.sh. Or create apply-reviews.py and 
> > deprecated apply-reviews.sh

Please take a look at the followup review (https://reviews.apache.org/r/38883/).


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review101405
---


On Oct. 8, 2015, 11:26 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> ---
> 
> (Updated Oct. 8, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

[Jie Yu]

> On Oct. 6, 2015, 12:39 p.m., Bernd Mathiske wrote:
> > Ship It!
> 
> Ben Mahler wrote:
> I don't think we should introduce this into stout in its current form. I 
> realize you're planning to use this for authentication stuff, but looking at 
> this on its own, it seems like a confusing abstraction. Why would we couple 
> the notion of a Tree with the semantics around properties and property 
> inheritance?
> 
> Till Toenshoff wrote:
> This code is being used in libprocess. So the options are libprocess or 
> stout for introducing it. I believe it would be a better fit for stout than 
> for libprocess as it is a data structure implementation that has no threading 
> or process specifics. Given that it already is in a reusable state, I think 
> that we should go as proposed by this RR.
> 
> Bernd Mathiske wrote:
> @bmahler, what would you rather have us do? This structure is quite close 
> to Boost's PropertyTree 
> (http://www.boost.org/doc/libs/1_59_0/doc/html/property_tree.html), and we 
> would have loved to use that one. But it does not feature inheritance, which 
> seems a natural, essential thing to have in at least some trees.
> 
> Ben Mahler wrote:
> Hm... the "inheritance" stuff that you guys need seems to just be a walk 
> of the tree from the root to the leaf you're interested in, collecting 
> properties of nodes along the way. Any reason you can't layer that 
> functionality on top or, even better, on the side via a free standing 
> function so that you don't need to introduce a new data structure?

+1 if we can compose/inherit from boost property tree rather than implementing 
our own.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37996/#review101639
---


On Oct. 7, 2015, 9:54 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37996/
> ---
> 
> (Updated Oct. 7, 2015, 9:54 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduces the `InheritanceTree` class which allows to create a tree where 
> nodes can be tag with some property. This property is then inherited by 
> children nodes.
> 
> Two behaviors are implemented, overriding, i.e. Adding a property to the 
> child node of another node with a property already will result in the 
> ancestor property being lost. The second behavior, accumulating, takes a 
> function and accumulates
> properties of all ancestors.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 94292f8a46ec31bbaf6e52f48109322bbe123f70 
>   3rdparty/libprocess/3rdparty/stout/tests/inheritancetree_tests.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37996/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/
---

(Updated Oct. 8, 2015, 11:28 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
and Vinod Kone.


Changes
---

Rebased; Added long option names.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38883/diff/


Testing
---

Tested the script with python 2.7.


Thanks,

Artem Harutyunyan

Review Request 39135: Fixed teardown test

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39135/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

This teardown endpoint test needs valid credentials to really test a missing 
'frameworkID' request.
Note: this change is also needed as dependant patch fixes how we validate 
credentials in master endpoints.


Diffs
-

  src/tests/teardown_tests.cpp 2eeead7 

Diff: https://reviews.apache.org/r/39135/diff/


Testing
---

make check


Thanks,

Isabel Jimenez

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Artem Harutyunyan]

> On Oct. 1, 2015, 6:12 a.m., Guangya Liu wrote:
> > support/apply-reviews.py, line 2
> > 
> >
> > The import should be in alpha order
> 
> Artem Harutyunyan wrote:
> I am happy to fix this, but could you please justify your reasoning?
> 
> Guangya Liu wrote:
> Please check 
> https://github.com/apache/mesos/blob/master/support/post-reviews.py#L25-#L30 
> 
> Also I see that most of the import or include are using alpha order in 
> mesos.

Great! I fixed the order. Thanks for pointing this out!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review101225
---


On Oct. 8, 2015, 11:26 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> ---
> 
> (Updated Oct. 8, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/
---

(Updated Oct. 8, 2015, 11:26 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38705/diff/


Testing
---

Tested the script with python 2.7.


Thanks,

Artem Harutyunyan

Re: Review Request 39100: Changed Credential validation

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39100/
---

(Updated Oct. 8, 2015, 6:26 p.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-3560
https://issues.apache.org/jira/browse/MESOS-3560


Repository: mesos


Description
---

We should validate credentials before anything else in HTTP endpoints.


Diffs
-

  src/master/http.cpp 4b9f9ed 

Diff: https://reviews.apache.org/r/39100/diff/


Testing
---

make check


Thanks,

Isabel Jimenez

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/
---

(Updated Oct. 8, 2015, 6:15 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Updated includes.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
  3rdparty/libprocess/src/poll_socket.cpp 
28ed102972a9d8f88048aea4046ed837b6a25b35 
  3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407 
  3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
  3rdparty/libprocess/src/subprocess.cpp 
a457cbe35ad33531c49f74550cd570cf28758f5d 

Diff: https://reviews.apache.org/r/39007/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/
---

(Updated Oct. 8, 2015, 6:15 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Updated includes.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
  src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/linux/routing/link/internal.hpp 015c0ef5be516d7786c96a96437cced1ae8487fa 
  src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/mesos/containerizer.cpp 
b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
  src/slave/containerizer/mesos/launch.cpp 
09d4d8f4d6837e93a82deef76ca07e2167d6a405 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
  src/tests/containerizer/memory_test_helper.cpp 
8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
  src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 

Diff: https://reviews.apache.org/r/39008/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39102: Added documentation for JSON resources.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review101934
---


Patch looks great!

Reviews applied: [39102]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 3:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> ---
> 
> (Updated Oct. 8, 2015, 3:32 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for JSON resources.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e 
> 
> Diff: https://reviews.apache.org/r/39102/diff/
> 
> 
> Testing
> ---
> 
> Viewed the relevant documentation sections ('Attributes and Resources' & 
> 'Configuration') using the mesos-website-container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39060: Create master detector per url & not per framework

[Mandeep Chadha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39060/
---

(Updated Oct. 8, 2015, 5:05 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-3595
https://issues.apache.org/jira/browse/MESOS-3595


Repository: mesos


Description
---

If the number of framework created exceeds the lib process
threads then during master failover the zookeeper updates can
cause deadlock.


Diffs (updated)
-

  src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 

Diff: https://reviews.apache.org/r/39060/diff/


Testing
---

make check successful 
Created 100 framework instances on a 24 CPU machine. Master failover detected 
by the framework process and continue to work as expected.


Thanks,

Mandeep Chadha

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39006/#review101924
---


Patch looks great!

Reviews applied: [39005, 39006]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 2:36 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39006/
> ---
> 
> (Updated Oct. 8, 2015, 2:36 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> 12ba1ca861114e60f8276c0ee91c543abcfc2519 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> d1e2df6151149e03ffb4a76e2c24ff78b891e016 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 7eb51e8771e95f57548fc35753e75c6d56cd97cd 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
> e740d5bc0f0cc5cf8e99b2064c1e39c08282da67 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39006/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39102: Added documentation for JSON resources.

[Greg Mann]

> On Oct. 8, 2015, 6 a.m., Guangya Liu wrote:
> > docs/attributes-resources.md, line 104
> > 
> >
> > Can we use a real json string which can map to above resources?

Yea we can; I was worried about the readability of this section with the full 
JSON string, but it's probably better to have an accurate string even if it 
doesn't look quite as good.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review101873
---


On Oct. 8, 2015, 3:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> ---
> 
> (Updated Oct. 8, 2015, 3:32 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for JSON resources.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e 
> 
> Diff: https://reviews.apache.org/r/39102/diff/
> 
> 
> Testing
> ---
> 
> Viewed the relevant documentation sections ('Attributes and Resources' & 
> 'Configuration') using the mesos-website-container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39102: Added documentation for JSON resources.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/
---

(Updated Oct. 8, 2015, 3:32 p.m.)


Review request for mesos, Adam B and Neil Conway.


Changes
---

Addressed comment.


Bugs: MESOS-2467
https://issues.apache.org/jira/browse/MESOS-2467


Repository: mesos


Description
---

Added documentation for JSON resources.


Diffs (updated)
-

  docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
  docs/configuration.md 2ab476a2d2c43e309b570d73ecac80e27b296e7e 

Diff: https://reviews.apache.org/r/39102/diff/


Testing
---

Viewed the relevant documentation sections ('Attributes and Resources' & 
'Configuration') using the mesos-website-container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/
---

(Updated Oct. 8, 2015, 2:39 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Adjusted for rename `stringError` -> `os::strerror` in RR-39005.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
  src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/linux/routing/link/internal.hpp 015c0ef5be516d7786c96a96437cced1ae8487fa 
  src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/mesos/containerizer.cpp 
b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
  src/slave/containerizer/mesos/launch.cpp 
09d4d8f4d6837e93a82deef76ca07e2167d6a405 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
  src/tests/containerizer/memory_test_helper.cpp 
8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
  src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 

Diff: https://reviews.apache.org/r/39008/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/
---

(Updated Oct. 8, 2015, 2:38 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Adjusted for rename `stringError` -> `os::strerror` in RR-39005.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
  3rdparty/libprocess/src/poll_socket.cpp 
28ed102972a9d8f88048aea4046ed837b6a25b35 
  3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407 
  3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
  3rdparty/libprocess/src/subprocess.cpp 
a457cbe35ad33531c49f74550cd570cf28758f5d 

Diff: https://reviews.apache.org/r/39007/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39088: Made shell test locale-independent.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39088/#review101910
---


Patch looks great!

Reviews applied: [39088]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 1:27 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39088/
> ---
> 
> (Updated Oct. 8, 2015, 1:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3517
> https://issues.apache.org/jira/browse/MESOS-3517
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test environment does not enforce that we run with a defined locale,
> so instead enforce it for our particular use case (here: potentially
> localized error messages from shell).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39088/diff/
> 
> 
> Testing
> ---
> 
> With German locale installed:
> 
> % LANG=de_DE.UTF-8 make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39006/
---

(Updated Oct. 8, 2015, 2:36 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Adjusted for rename `stringError` -> `os::strerror` in RR-39005.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
12ba1ca861114e60f8276c0ee91c543abcfc2519 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
d1e2df6151149e03ffb4a76e2c24ff78b891e016 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
7eb51e8771e95f57548fc35753e75c6d56cd97cd 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
e740d5bc0f0cc5cf8e99b2064c1e39c08282da67 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 

Diff: https://reviews.apache.org/r/39006/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/
---

(Updated Oct. 8, 2015, 2:31 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Adjusted for rename `stringError` -> `os::strerror` in RR-39007.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
  src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/linux/routing/link/internal.hpp 015c0ef5be516d7786c96a96437cced1ae8487fa 
  src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
  src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/mesos/containerizer.cpp 
b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
  src/slave/containerizer/mesos/launch.cpp 
09d4d8f4d6837e93a82deef76ca07e2167d6a405 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
  src/tests/containerizer/memory_test_helper.cpp 
8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
  src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 

Diff: https://reviews.apache.org/r/39008/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Benjamin Bannier]

> On Oct. 7, 2015, 4:27 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 28
> > 
> >
> > Suggestion: "In contast to strerror(), this function is thread-safe."

Documentation updated.


> On Oct. 7, 2015, 4:27 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 38
> > 
> >
> > If you wanted to be really devensive, not trusting strerror_r() on all 
> > unforeseeable platforms for all eternity, we could cut the loop at a max 
> > size.
> > 
> > But then maybe we could just use a larger buffer to begin with and be 
> > done?
> > 
> > Or, try 34 first and then something large like 1024, and that's it.

I changed the implementation to a fixed-size buffer.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review101779
---


On Oct. 8, 2015, 2:29 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> ---
> 
> (Updated Oct. 8, 2015, 2:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a thread-safe wrapper around strerror_r which has semantics similar 
> to strerror. We plan to use this at call sites currently relying on strerror.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Benjamin Bannier]

> On Oct. 6, 2015, 5:09 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp, line 37
> > 
> >
> > When strerror_r() returns EINVAL, you return an empty string?
> 
> Cong Wang wrote:
> Also, you should force the XSI-compliant one rather than the GNU one 
> which returns a pointer.

> When strerror_r() returns EINVAL, you return an empty string?

No, the here implementation might return something along the lines of `Unknown 
error: 12345` or whatever the `strerror_r` implementation in the active locale 
puts into the buffer, provided it fits into the buffer (if not: the error 
message gets truncated). IEEE-1003.1 `strerror` might set `errno` in case of 
errors and reserves no special return value.

> Also, you should force the XSI-compliant one rather than the GNU one which 
> returns a pointer.

I believe forcing glibc to use the XSI-compliant `strerror_r` isn't something 
we should try in a header-only implementation since it would require locally 
(re)defining some values via the preprocessor before include `stdio.h`; in a 
header we have zero control how the user includes our header.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review101665
---


On Oct. 8, 2015, 2:29 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> ---
> 
> (Updated Oct. 8, 2015, 2:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a thread-safe wrapper around strerror_r which has semantics similar 
> to strerror. We plan to use this at call sites currently relying on strerror.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/
---

(Updated Oct. 8, 2015, 2:29 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Provided an implementation that can work with both a XSI and GLIBC flavor of 
strerror_r.

Use a different implementation strategy now where the buffer isn't dynamically 
grown but instead a "large enough" buffer is used. Also rename the function to 
os::strerror and put it in an independent header so it can be included by very 
basic infrastructure headers like `stout/error.hpp`.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

This adds a thread-safe wrapper around strerror_r which has semantics similar 
to strerror. We plan to use this at call sites currently relying on strerror.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 

Diff: https://reviews.apache.org/r/39005/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39088: Made shell test locale-independent.

[Benjamin Bannier]

> On Oct. 8, 2015, 9:52 a.m., Jan Schlicht wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 961
> > 
> >
> > s/LANG/LC_ALL
> > 
> > At https://help.ubuntu.com/community/Locale it is stated that using 
> > `LANG` provides a default value if LC_* has not been set. Some 
> > distributions (e.g. Fedora) set LC_* explicitly. We have to use LC_ALL to 
> > make sure that it really is overwritten.

Good catch, fixed now.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39088/#review101883
---


On Oct. 8, 2015, 1:27 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39088/
> ---
> 
> (Updated Oct. 8, 2015, 1:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3517
> https://issues.apache.org/jira/browse/MESOS-3517
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test environment does not enforce that we run with a defined locale,
> so instead enforce it for our particular use case (here: potentially
> localized error messages from shell).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39088/diff/
> 
> 
> Testing
> ---
> 
> With German locale installed:
> 
> % LANG=de_DE.UTF-8 make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39088: Made shell test locale-independent.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39088/
---

(Updated Oct. 8, 2015, 1:27 p.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff.


Changes
---

Make sure we overwrite set and unset flavors of LC_*


Bugs: MESOS-3517
https://issues.apache.org/jira/browse/MESOS-3517


Repository: mesos


Description
---

The test environment does not enforce that we run with a defined locale,
so instead enforce it for our particular use case (here: potentially
localized error messages from shell).


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 

Diff: https://reviews.apache.org/r/39088/diff/


Testing
---

With German locale installed:

% LANG=de_DE.UTF-8 make check


Thanks,

Benjamin Bannier

Re: Review Request 39087: Added support for non-ascii chars to apply-review.sh.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39087/#review101901
---

Ship it!


Ship It!

- Jan Schlicht


On Oct. 7, 2015, 4:54 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39087/
> ---
> 
> (Updated Oct. 7, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-3268
> https://issues.apache.org/jira/browse/MESOS-3268
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for non-ascii chars to apply-review.sh.
> 
> 
> Diffs
> -
> 
>   support/jsonurl.py f6b54d8f8b0402f703d5758704a3f783dd9b3ef9 
> 
> Diff: https://reviews.apache.org/r/39087/diff/
> 
> 
> Testing
> ---
> 
> Tested this on OS X.
> 
> Without this patch:
> 
> ```
> $ ./support/apply-review.sh -n -r 39086
> 2015-10-07 16:41:06 URL:https://reviews.apache.org/r/39086/diff/raw/ 
> [5430/5430] -> "39086.patch" [1]
> Traceback (most recent call last):
>   File "./support/jsonurl.py", line 25, in 
> print data
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 
> 4: ordinal not in range(128)
> Successfully applied: Fixed typos in comments and docs.
> 
> Fixed typos in comments and docs.
> 
> 
> Review: https://reviews.apache.org/r/39086
> fatal: empty ident name (for ) not allowed
> Failed to commit patch
> $
> ```
> 
> With this patch:
> 
> ```
> $ ./support/apply-review.sh -n -r 39086
> 2015-10-07 16:42:09 URL:https://reviews.apache.org/r/39086/diff/raw/ 
> [5430/5430] -> "39086.patch" [1]
> Successfully applied: Fixed typos in comments and docs.
> 
> Fixed typos in comments and docs.
> 
> 
> Review: https://reviews.apache.org/r/39086
> Checking 2 files using filter 
> --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
> Total errors found: 0
> [fix_3268 d51d32a] Fixed typos in comments and docs.
>  Author: Gastón Kleiman 
>  6 files changed, 12 insertions(+), 12 deletions(-)
> $
> ```
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 37999: Implemented http::AuthenticatorManager

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/#review101816
---


Partial, entirely incomplete but maybe helpful review :)


3rdparty/libprocess/include/process/http.hpp (line 493)


THe RFCs always use `WWW-Authenticate`, shouldn't we as well here and 
everywhere else?



3rdparty/libprocess/src/process.cpp (line 2611)


s/Tecnically/technically/
s/principa/principal/



3rdparty/libprocess/src/process.cpp (lines 2643 - 2647)


This still makes me think we should fix the flaky fetcher tests before 
anything else. Lets put some combined efforts into that please.


- Till Toenshoff


On Sept. 30, 2015, 8:20 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37999/
> ---
> 
> (Updated Sept. 30, 2015, 8:20 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduces the authenticator manager, which is a class which handles the 
> actual authentication procedure during the execution of 
> `ProcessManager::handle()` and it also takes care of the life cycle of 
> instances of http::Authenticator.
> 
> No tests are added at this point since no public API is generated, the goal 
> of this patch is to implement the manager and verify nothing breaks 
> afterwards. Authenticator manager tests proper come in a latter patch.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
>   3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/event.hpp 
> 16ddbd77afa6efdf6bad201aa497ee102aa863ae 
>   3rdparty/libprocess/include/process/http.hpp 
> ba3f0bc7df33795e332c374fbad04106b9d56416 
>   3rdparty/libprocess/src/process.cpp 
> d1c81f1d244f02bf42cab97198587ce1b8c7c407 
> 
> Diff: https://reviews.apache.org/r/37999/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Benjamin Bannier]

> On Oct. 7, 2015, 9:18 p.m., Ben Mahler wrote:
> > src/tests/script.cpp, line 101
> > 
> >
> > malloc is not async-signal-safe, and may be used by the string 
> > implementation, and so we must not use os::strerror (assuming we rename it) 
> > after a fork! Please do an audit of this diff.
> 
> Bernd Mathiske wrote:
> Yikes. Good catch. I glossed over the fork. My bad.

Good catch, I have filed MESOS-3607. I suggest this to be fixed separately 
since more than a few of the functions in that fork/exec bracket are not 
async-safe right now (strerror was not safe either).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/#review101811
---


On Oct. 6, 2015, 3:08 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39008/
> ---
> 
> (Updated Oct. 6, 2015, 3:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
>   src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/linux/routing/link/internal.hpp 
> 015c0ef5be516d7786c96a96437cced1ae8487fa 
>   src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
>   src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
>   src/slave/containerizer/mesos/launch.cpp 
> 09d4d8f4d6837e93a82deef76ca07e2167d6a405 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
>   src/tests/containerizer/memory_test_helper.cpp 
> 8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
>   src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 
> 
> Diff: https://reviews.apache.org/r/39008/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Bernd Mathiske]

> On Oct. 7, 2015, 2:18 p.m., Ben Mahler wrote:
> > src/tests/script.cpp, line 101
> > 
> >
> > malloc is not async-signal-safe, and may be used by the string 
> > implementation, and so we must not use os::strerror (assuming we rename it) 
> > after a fork! Please do an audit of this diff.

Yikes. Good catch. I glossed over the fork. My bad.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/#review101811
---


On Oct. 6, 2015, 8:08 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39008/
> ---
> 
> (Updated Oct. 6, 2015, 8:08 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
>   src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/linux/routing/link/internal.hpp 
> 015c0ef5be516d7786c96a96437cced1ae8487fa 
>   src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
>   src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
>   src/slave/containerizer/mesos/launch.cpp 
> 09d4d8f4d6837e93a82deef76ca07e2167d6a405 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
>   src/tests/containerizer/memory_test_helper.cpp 
> 8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
>   src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 
> 
> Diff: https://reviews.apache.org/r/39008/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39088: Made shell test locale-independent.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39088/#review101883
---

Ship it!



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 961)


s/LANG/LC_ALL

At https://help.ubuntu.com/community/Locale it is stated that using `LANG` 
provides a default value if LC_* has not been set. Some distributions (e.g. 
Fedora) set LC_* explicitly. We have to use LC_ALL to make sure that it really 
is overwritten.


- Jan Schlicht


On Oct. 7, 2015, 5:24 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39088/
> ---
> 
> (Updated Oct. 7, 2015, 5:24 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3517
> https://issues.apache.org/jira/browse/MESOS-3517
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test environment does not enforce that we run with a defined locale,
> so instead enforce it for our particular use case (here: potentially
> localized error messages from shell).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39088/diff/
> 
> 
> Testing
> ---
> 
> With German locale installed:
> 
> % LANG=de_DE.UTF-8 make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Bernd Mathiske]

Good call. Let’s change it!

> On Oct 7, 2015, at 11:14 PM, Benjamin Mahler  
> wrote:
> 
> Seems like os::strerror() would be more consistent with our other posix api 
> wrappers.
> 
> On Wed, Oct 7, 2015 at 9:27 AM, Bernd Mathiske  > wrote:
> This is an automatically generated e-mail. To reply, visit: 
> https://reviews.apache.org/r/39005/ 
> 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
>  
> (Diff revision 1)
> 27
>  * @note This function is thread-safe.
> Suggestion: "In contast to strerror(), this function is thread-safe."
> 
> 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
>  
> (Diff revision 1)
> 37
> buffer.resize(buffer.size() * 2, '\0');
> If you wanted to be really devensive, not trusting strerror_r() on all 
> unforeseeable platforms for all eternity, we could cut the loop at a max size.
> But then maybe we could just use a larger buffer to begin with and be done?
> Or, try 34 first and then something large like 1024, and that's it.
> 
> - Bernd Mathiske
> 
> 
> On October 6th, 2015, 8:07 a.m. PDT, Benjamin Bannier wrote:
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> By Benjamin Bannier.
> Updated Oct. 6, 2015, 8:07 a.m.
> 
> Bugs: MESOS-3551 
> Repository: mesos
> Description
> 
> This adds a thread-safe wrapper around strerror_r which has semantics similar 
> to strerror. We plan to use this at call sites currently relying on strerror.
> Testing
> 
> make check
> Diffs
> 
> 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> (12ba1ca861114e60f8276c0ee91c543abcfc2519)
> 3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 
> (9e7605c53e6636e7fea32e4f69fbaff9100a979f)
> View Diff 



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: Review Request 37024: Exposes mesos version information in components.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101881
---


Patch looks great!

Reviews applied: [37024]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 7:01 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> ---
> 
> (Updated Oct. 8, 2015, 7:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint exposes Apache Mesos build informations and version 
> information.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
>   src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
>   src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
>   src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae 
>   src/version/version.hpp PRE-CREATION 
>   src/version/version.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37024/diff/
> 
> 
> Testing
> ---
> 
> Manual test result:
> 
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> {
>   "version": "0.26.0",
>   "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
>   "git_branch": "refs/heads/MESOS-1841",
>   "build_user": "haosdent",
>   "build_time": 1444185166,
>   "build_date": "2015-10-07 10:32:46"
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37024: Exposes mesos version information in components.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
---

(Updated Oct. 8, 2015, 7:01 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebase


Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841


Repository: mesos


Description
---

Add an endpoint exposes Apache Mesos build informations and version information.


Diffs (updated)
-

  src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
  src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
  src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
  src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
  src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
  src/slave/main.cpp 854ade491c2bad0bb041cd94968215f9fd8fa4ae 
  src/version/version.hpp PRE-CREATION 
  src/version/version.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37024/diff/


Testing
---

Manual test result:

```
$ curl http://localhost:5050/version 2>/dev/null|jq .
{
  "version": "0.26.0",
  "git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
  "git_branch": "refs/heads/MESOS-1841",
  "build_user": "haosdent",
  "build_time": 1444185166,
  "build_date": "2015-10-07 10:32:46"
}
```


Thanks,

haosdent huang

Re: Review Request 39037: Allow description empty in help information.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39037/
---

(Updated Oct. 8, 2015, 6:59 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Update according @bmahler and @gyliu reviews.


Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104


Repository: mesos


Description
---

Allow description empty in help information.


Diffs (updated)
-

  3rdparty/libprocess/include/process/help.hpp 
e7dc670648e8abd2fef7be79835f0b71e3e91258 
  3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7 

Diff: https://reviews.apache.org/r/39037/diff/


Testing
---


Thanks,

haosdent huang