Re: Review Request 40431: Move RoleInfo message out of allocator.proto

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---

(Updated Nov. 24, 2015, 7:25 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944


Repository: mesos


Description
---

Move RoleInfo message out of allocator.proto


Diffs (updated)
-

  include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
  include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c 
  include/mesos/role/role.hpp PRE-CREATION 
  include/mesos/role/role.proto PRE-CREATION 
  src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
  src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
  src/master/allocator/mesos/allocator.hpp 
97ee80726ad155917811265a983258b0165d3451 
  src/master/allocator/mesos/hierarchical.hpp 
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 
  src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
  src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 
  src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
  src/tests/hierarchical_allocator_tests.cpp 
a45b3dd0a8237fdd080536cb9ab600e71ad939d3 

Diff: https://reviews.apache.org/r/40431/diff/


Testing
---

1. Make Check successfully;

2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


Thanks,

Yong Qiao Wang

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
---

(Updated Nov. 24, 2015, 3:24 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
Remoortere.


Changes
---

Keep the compatibility of unset RevocableInfo::type & RevocableInfo::USAGE_SLACK


Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888


Repository: mesos


Description
---

MESOS-3888: We need to distinguish revocable resource for usage slack and 
allocation slack.


Diffs (updated)
-

  include/mesos/mesos.proto 0b8289f 
  include/mesos/v1/mesos.proto c98f2a4 
  src/common/resources.cpp b4abf54 
  src/tests/resources_tests.cpp dbd39cd 
  src/v1/resources.cpp 8488c31 

Diff: https://reviews.apache.org/r/40375/diff/


Testing
---

make && make check


Thanks,

Klaus Ma

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---

(Updated Nov. 24, 2015, 7:12 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944


Repository: mesos


Description
---

Move RoleInfo message out of allocator.proto


Diffs (updated)
-

  include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
  include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c 
  include/mesos/role/role.hpp PRE-CREATION 
  include/mesos/role/role.proto PRE-CREATION 
  src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
  src/master/allocator/mesos/allocator.hpp 
97ee80726ad155917811265a983258b0165d3451 
  src/master/allocator/mesos/hierarchical.hpp 
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 
  src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
  src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 
  src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
  src/tests/hierarchical_allocator_tests.cpp 
a45b3dd0a8237fdd080536cb9ab600e71ad939d3 

Diff: https://reviews.apache.org/r/40431/diff/


Testing
---

1. Make Check successfully;

2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


Thanks,

Yong Qiao Wang

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

[Gilbert Song]

> On Nov. 23, 2015, 4:30 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 
> > 705
> > 
> >
> > We need to do a check so that fs_layers size == history size first 
> > right?

Correct. This is checked by validate() inside spec::parse already, so no need 
to check again.


> On Nov. 23, 2015, 4:30 p.m., Timothy Chen wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 740
> > 
> >
> > What's changed in this JSON? Why do we need to change it?

Three reasons to change it:
1. JSON format is incorrect. There should not be `\"` outside of id/parent pair 
like \"{ id:... parent:... }\", which also causes a protobuf::parse error.
2. Triple `\\"` is not necessary. Only one backslash is needed.
3. Alignment, more clear.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/#review107685
---


On Nov. 23, 2015, 10:52 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39712/
> ---
> 
> (Updated Nov. 23, 2015, 10:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3994
> https://issues.apache.org/jira/browse/MESOS-3994
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor registry client/puller to avoid JSON and struct.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> 22873276a04941c52e4df41750174c86515f1951 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 99a421b21cce8311b729689c4c4099206e85dc1f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 94b7539b1e1d3b83f0c608d2ac3af9aebbd8b2e6 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 88b914d3d4a56a51750a75c0988547e2a3e94f56 
> 
> Diff: https://reviews.apache.org/r/39712/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review107727
---


Patch looks great!

Reviews applied: [40339, 40524, 40529, 40532]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 5:44 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40532/
> ---
> 
> (Updated Nov. 24, 2015, 5:44 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
> and Klaus Ma.
> 
> 
> Bugs: MESOS-3890
> https://issues.apache.org/jira/browse/MESOS-3890
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added notion of evictable task to RunTaskMessage.
> 
> 
> Diffs
> -
> 
>   src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a 
> 
> Diff: https://reviews.apache.org/r/40532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/
---

(Updated Nov. 23, 2015, 10:52 p.m.)


Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.


Bugs: MESOS-3994
https://issues.apache.org/jira/browse/MESOS-3994


Repository: mesos


Description
---

Refactor registry client/puller to avoid JSON and struct.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
22873276a04941c52e4df41750174c86515f1951 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
99a421b21cce8311b729689c4c4099206e85dc1f 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
94b7539b1e1d3b83f0c608d2ac3af9aebbd8b2e6 
  src/tests/containerizer/provisioner_docker_tests.cpp 
88b914d3d4a56a51750a75c0988547e2a3e94f56 

Diff: https://reviews.apache.org/r/39712/diff/


Testing
---

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---

(Updated Nov. 24, 2015, 6:41 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791


Repository: mesos


Description
---

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Diffs
-

  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 

Diff: https://reviews.apache.org/r/40424/diff/


Testing
---

Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}

$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!


Thanks,

Yong Qiao Wang

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/#review107719
---


Bad patch!

Reviews applied: [40431]

Failed command: ./support/apply-review.sh -n -r 40431

Error:
 2015-11-24 05:53:22 URL:https://reviews.apache.org/r/40431/diff/raw/ 
[11466/11466] -> "40431.patch" [1]
error: patch failed: include/mesos/master/allocator.hpp:100
error: include/mesos/master/allocator.hpp: patch does not apply
error: patch failed: src/master/allocator/mesos/allocator.hpp:57
error: src/master/allocator/mesos/allocator.hpp: patch does not apply
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:93
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
error: patch failed: src/tests/allocator.hpp:345
error: src/tests/allocator.hpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 24, 2015, 5:17 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40424/
> ---
> 
> (Updated Nov. 24, 2015, 5:17 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3791
> https://issues.apache.org/jira/browse/MESOS-3791
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this ticket, we will enhance the existing
> HTTP endpoint to query roles as outlined in
> the dynamic role design Doc.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
> 
> Diff: https://reviews.apache.org/r/40424/diff/
> 
> 
> Testing
> ---
> 
> Test results:
> $ curl http://127.0.0.1:5050/roles
> {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> $ curl http://127.0.0.1:5050/roles?roleName=aa
> {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> 
> $ curl http://127.0.0.1:5050/roles?roleName=dd
> The specified role [dd] does not exist!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107718
---

Ship it!


Ship It!

- Greg Mann


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
---

(Updated 十一月 24, 2015, 5:44 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Summary (updated)
-

Added notion of evictable task to RunTaskMessage.


Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890


Repository: mesos


Description
---

Added notion of evictable task to RunTaskMessage.


Diffs
-

  src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a 

Diff: https://reviews.apache.org/r/40532/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40532: WIP: Added notion of evictable task to RunTaskMessage.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
---

(Updated 十一月 24, 2015, 5:44 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890


Repository: mesos


Description
---

Added notion of evictable task to RunTaskMessage.


Diffs (updated)
-

  src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a 

Diff: https://reviews.apache.org/r/40532/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40524: Enabled resources.cpp and resources.hpp use std::string

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/
---

(Updated 十一月 24, 2015, 5:42 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Summary (updated)
-

Enabled resources.cpp and resources.hpp use std::string


Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955


Repository: mesos


Description
---

Enabled resources.cpp and resources.hpp use std::string


Diffs (updated)
-

  include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d 
  include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c 
  src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
  src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 

Diff: https://reviews.apache.org/r/40524/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40529: Added helper function to get stateless resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
---

(Updated 十一月 24, 2015, 5:42 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Summary (updated)
-

Added helper function to get stateless resources.


Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955


Repository: mesos


Description
---

Added helper function to get stateless resources.


Diffs (updated)
-

  include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d 
  include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c 
  src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
  src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 
  src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 

Diff: https://reviews.apache.org/r/40529/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/
---

(Updated 十一月 24, 2015, 5:40 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Summary (updated)
-

Added a flag to master to enable oversubscription for reservations.


Bugs: MESOS-3887
https://issues.apache.org/jira/browse/MESOS-3887


Repository: mesos


Description
---

Added a flag to master to enable optimistic offers.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
  src/master/allocator/mesos/allocator.hpp 
97ee80726ad155917811265a983258b0165d3451 
  src/master/allocator/mesos/hierarchical.hpp 
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 
  src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
  src/master/flags.cpp 2d58fcd56317897786a8b832c4ccf7f3d7b566e5 
  src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 
  src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
  src/tests/hierarchical_allocator_tests.cpp 
a45b3dd0a8237fdd080536cb9ab600e71ad939d3 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_quota_tests.cpp 330e591f81c7ece7f401042ad159bd6b55881a84 
  src/tests/reservation_endpoints_tests.cpp 
f4e332327049944000baccd3e607201240a8c5f4 
  src/tests/reservation_tests.cpp 1d0a65d5b4c2cb03e49f302176084ef5d602569f 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 

Diff: https://reviews.apache.org/r/40339/diff/


Testing
---

Ubuntu 14.04
make
make check


Thanks,

Guangya Liu

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

> On Nov. 24, 2015, 4:19 a.m., Anand Mazumdar wrote:
> > I am assuming this review is still being constantly worked on. Can you 
> > update the summary of this review to be a work in progress [WIP] ?

Thanks for your reminder, I have updated the summary.


- Yong Qiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/#review107709
---


On Nov. 24, 2015, 5:17 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40424/
> ---
> 
> (Updated Nov. 24, 2015, 5:17 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3791
> https://issues.apache.org/jira/browse/MESOS-3791
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this ticket, we will enhance the existing
> HTTP endpoint to query roles as outlined in
> the dynamic role design Doc.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
> 
> Diff: https://reviews.apache.org/r/40424/diff/
> 
> 
> Testing
> ---
> 
> Test results:
> $ curl http://127.0.0.1:5050/roles
> {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> $ curl http://127.0.0.1:5050/roles?roleName=aa
> {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> 
> $ curl http://127.0.0.1:5050/roles?roleName=dd
> The specified role [dd] does not exist!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---

(Updated Nov. 24, 2015, 5:17 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Summary (updated)
-

[WIP] ]Enhance the existing HTTP endpoint /roles


Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791


Repository: mesos


Description
---

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Diffs
-

  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 

Diff: https://reviews.apache.org/r/40424/diff/


Testing
---

Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}

$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!


Thanks,

Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---

(Updated Nov. 24, 2015, 5:13 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791


Repository: mesos


Description
---

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Diffs
-

  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 

Diff: https://reviews.apache.org/r/40424/diff/


Testing
---

Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}

$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!


Thanks,

Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/#review107709
---


I am assuming this review is still being constantly worked on. Can you update 
the summary of this review to be a work in progress [WIP] ?

- Anand Mazumdar


On Nov. 24, 2015, 2:37 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40424/
> ---
> 
> (Updated Nov. 24, 2015, 2:37 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3791
> https://issues.apache.org/jira/browse/MESOS-3791
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this ticket, we will enhance the existing
> HTTP endpoint to query roles as outlined in
> the dynamic role design Doc.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
> 
> Diff: https://reviews.apache.org/r/40424/diff/
> 
> 
> Testing
> ---
> 
> Test results:
> $ curl http://127.0.0.1:5050/roles
> {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> $ curl http://127.0.0.1:5050/roles?roleName=aa
> {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> 
> $ curl http://127.0.0.1:5050/roles?roleName=dd
> The specified role [dd] does not exist!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/#review107707
---


Patch looks great!

Reviews applied: [40424]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 2:37 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40424/
> ---
> 
> (Updated Nov. 24, 2015, 2:37 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3791
> https://issues.apache.org/jira/browse/MESOS-3791
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this ticket, we will enhance the existing
> HTTP endpoint to query roles as outlined in
> the dynamic role design Doc.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
> 
> Diff: https://reviews.apache.org/r/40424/diff/
> 
> 
> Testing
> ---
> 
> Test results:
> $ curl http://127.0.0.1:5050/roles
> {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> $ curl http://127.0.0.1:5050/roles?roleName=aa
> {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> 
> $ curl http://127.0.0.1:5050/roles?roleName=dd
> The specified role [dd] does not exist!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---

(Updated Nov. 24, 2015, 2:36 a.m.)


Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.


Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791


Repository: mesos


Description
---

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Diffs (updated)
-

  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 

Diff: https://reviews.apache.org/r/40424/diff/


Testing
---

Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}

$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!


Thanks,

Yong Qiao Wang

Re: Review Request 38989: Update docker-containerizer.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/#review107702
---


Bad patch!

Reviews applied: [38989]

Failed command: ./support/apply-review.sh -n -r 38989

Error:
 2015-11-24 02:02:06 URL:https://reviews.apache.org/r/38989/diff/raw/ 
[4199/4199] -> "38989.patch" [1]
error: patch failed: docs/docker-containerizer.md:14
error: docs/docker-containerizer.md: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 5, 2015, 7:50 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38989/
> ---
> 
> (Updated Oct. 5, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docker-containerizer.md.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/38989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40618: Include the header for boost::hash_combine explicitly

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40618/#review107699
---


Patch looks great!

Reviews applied: [40618]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 10:42 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40618/
> ---
> 
> (Updated Nov. 23, 2015, 10:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently boost/functional/hash.hpp is included implicitly, we should include 
> it explicitly.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> bffdc3829208496ef14fecca497af73d4399867b 
> 
> Diff: https://reviews.apache.org/r/40618/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 31125: MESOS-2357 - Improve docker ps output parsing

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31125/#review107698
---


I don't think this patch is being worked on, closing for now.

- Timothy Chen


On Feb. 25, 2015, 6:45 a.m., Henning Schmiedehausen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31125/
> ---
> 
> (Updated Feb. 25, 2015, 6:45 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2357
> https://issues.apache.org/jira/browse/MESOS-2357
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Parse the docker ps format correctly (identify the columns by the
> header names), then find the NAMES column for the container names and
> parse container names out.
> 
> This ensures that, when docker adds more columns to the ps output,
> the parsing will not break.
> 
> Also issue the --no-trunc command line option to have the output
> columns not truncated by docker.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 94f16e701f89367b599f0bd8f44c2f1de21a8e20 
> 
> Diff: https://reviews.apache.org/r/31125/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Henning Schmiedehausen
> 
>

Re: Review Request 38989: Update docker-containerizer.md.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/#review107697
---


Can you rebase your patch?

- Timothy Chen


On Oct. 5, 2015, 7:50 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38989/
> ---
> 
> (Updated Oct. 5, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docker-containerizer.md.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/38989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38989: Update docker-containerizer.md.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/#review107696
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 5, 2015, 7:50 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38989/
> ---
> 
> (Updated Oct. 5, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docker-containerizer.md.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/38989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38338/#review107695
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 3, 2015, 3:55 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38338/
> ---
> 
> (Updated Oct. 3, 2015, 3:55 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3392
> https://issues.apache.org/jira/browse/MESOS-3392
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced option for Docker cli volume plugin.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
> 
> Diff: https://reviews.apache.org/r/38338/diff/
> 
> 
> Testing
> ---
> 
> # When use volume-driver
> ```
> I1003 23:49:41.986047 11268 docker.cpp:571] Running docker -H 
> unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
> MESOS_CONTAINER_NAME=mesos-docker-test -v src:target:rw -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_D3Fxye:/mnt/mesos/sandbox 
> --volume-driver=flocker --net host --entrypoint /bin/sh --name 
> mesos-docker-test busybox -c sleep 120
> ```
> Could see `-v src:target`
> 
> # When don't use volume-driver
> ```
> 1003 23:53:48.028715 12125 docker.cpp:571] Running docker -H 
> unix:///var/run/docker.sock run -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
> MESOS_CONTAINER_NAME=mesos-docker-test -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw -v 
> /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt:/mnt/mesos/sandbox --net 
> host --entrypoint /bin/sh --name mesos-docker-test busybox -c sleep 120
> ```
> Could see `-v /tmp/DockerTest_ROOT_DOCKER_volume_driver_jmtVzt/src:target:rw`
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37703: Add docker exec command.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107694
---



src/tests/containerizer/docker_tests.cpp (line 298)


This test failed for me since at the time docker->exec is called the 
container isn't running yet.

Please abstract out the exists() method (probably in 
tests/containerizer/docker_test_helper.hpp) in  containerizer_docker_tests so 
you can use it here that you wait until the container is running before you run 
docker exec.


- Timothy Chen


On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> ---
> 
> (Updated Oct. 3, 2015, 9:09 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add docker exec command.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
>   src/tests/containerizer/docker_tests.cpp 
> babc7d8da4ed9d13b14bd69decd7f27fc7dfde89 
> 
> Diff: https://reviews.apache.org/r/37703/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

[haosdent huang]

> On Nov. 24, 2015, 12:23 a.m., Guangya Liu wrote:
> > Suggest change the description to "Added missing DiscoveryInfo.Visibility 
> > field to v1/mesos.proto."

thx, added.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40602/#review107681
---


On Nov. 24, 2015, 1:20 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40602/
> ---
> 
> (Updated Nov. 24, 2015, 1:20 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Neil Conway, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3989
> https://issues.apache.org/jira/browse/MESOS-3989
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added missing DiscoveryInfo.Visibility field to v1/mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 
> 
> Diff: https://reviews.apache.org/r/40602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40602/
---

(Updated Nov. 24, 2015, 1:20 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, Neil Conway, and Till 
Toenshoff.


Bugs: MESOS-3989
https://issues.apache.org/jira/browse/MESOS-3989


Repository: mesos


Description (updated)
---

Added missing DiscoveryInfo.Visibility field to v1/mesos.proto.


Diffs
-

  include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 

Diff: https://reviews.apache.org/r/40602/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107692
---



src/master/allocator/mesos/hierarchical.cpp (line 416)


There might be new host added when recovery, so what about renaming 
"reregistered" to "added"?

s/reregistered/added?



src/master/allocator/mesos/hierarchical.cpp (line 993)


Shall we unify the tone in log files? What about s/Pausing/Paused



src/master/allocator/mesos/hierarchical.cpp (line 1003)


s/Resuming/Resumed


- Guangya Liu


On 十一月 23, 2015, 11:35 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated 十一月 23, 2015, 11:35 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
>   src/master/allocator/mesos/hierarchical.cpp 
> aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 37541: Add trace event API

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37541/#review107680
---



src/linux/perf.hpp (line 95)


s/inline//



src/linux/perf.hpp (line 100)


s/inline//



src/linux/perf.hpp (line 102)


if you use stout's hashmap, you can do

`!fields.contains(key)`



src/linux/perf.hpp (lines 108 - 110)


why are these public?



src/linux/perf.hpp (line 114)


use stout's hashmap. it's an unordered map.



src/linux/perf.hpp (line 163)


const std::string& ?



src/linux/perf.hpp (line 165)


const Duration& ?



src/linux/perf.hpp (line 196)


s/subSys/subsystem/



src/linux/perf.hpp (line 199)


s/,/;/
s/TraceEvent's/TraceEvents/



src/linux/perf.hpp (lines 206 - 207)


s/,/;/
s/TraceEvent's/TraceEvents/



src/linux/perf.hpp (line 213)


kill extra new line.



src/linux/perf.hpp (lines 216 - 217)


don't think you need this.



src/linux/perf.hpp (lines 229 - 231)


these should be const?



src/linux/perf.cpp (line 575)


const string&



src/linux/perf.cpp (line 577)


const Duration&



src/linux/perf.cpp (line 590)


const string&



src/linux/perf.cpp (lines 920 - 931)


pull this above schedEvents to #910.



src/linux/perf.cpp (line 939)


hmm. what happens if another `parse` call comes in while the previous one 
is in progress?



src/linux/perf.cpp (line 951)


what if the user discards this future?



src/linux/perf.cpp (line 974)


s/ehdr/header/

or

s/ehdr/eventHeader/



src/linux/perf.cpp (lines 974 - 1029)


this could use some comments.



src/linux/perf.cpp (line 1056)


const string&



src/linux/perf.cpp (lines 1085 - 1086)


indent by 2 spaces.



src/linux/perf.cpp (line 1098)


s/subSys/subsystem/



src/linux/perf.cpp (lines 1125 - 1128)


this could use some comments.



src/linux/perf.cpp (lines 1144 - 1164)


can you add some new lines to separate blocks here. it is too dense.



src/linux/perf.cpp (lines 1209 - 1213)


why do you need to manually do this?



src/tests/containerizer/cgroups_tests.cpp (line 1093)


kill this.



src/tests/containerizer/cgroups_tests.cpp (lines 1101 - 1102)


`EXPECT_SOME(event.get("common_pid"));` ?



src/tests/containerizer/cgroups_tests.cpp (line 1105)


no need for this?



src/tests/containerizer/perf_tests.cpp (lines 205 - 206)


ditto.


- Vinod Kone


On Sept. 30, 2015, 12:14 a.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37541/
> ---
> 
> (Updated Sept. 30, 2015, 12:14 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2769
> https://issues.apache.org/jira/browse/MESOS-2769
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Based on the PerfEvent API's, add API for Linux kernel trace events, 
> especially the schedule trace events.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 
>   src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a 
>   src/tests/containerizer/cgroups_te

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/#review107690
---


Patch looks great!

Reviews applied: [40497, 40506, 39415, 39416, 39417]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 10:33 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39417/
> ---
> 
> (Updated Nov. 23, 2015, 10:33 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When --egress_unique_flow_per_container is enabled, we need to install a flow 
> classifier (fq_codel) qdisc on egress side. This flag specifies where to 
> install it in the hierarchy. By default, we install it at root. But, for 
> example, if you have already installed HTB qdisc at root, you may want this 
> to be installed in other place than root, specify an HTB class ID as its 
> parent here.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 126f4aa8e3de2a2346336991c9b9a2ea61a8cd0a 
>   src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
>   src/linux/routing/handle.hpp 6deff85b52daa6b8771f127fea0d661cb5cd5e6a 
>   src/linux/routing/handle.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> 0865a71b1d79adcf62ca0f12d7ea0a23ebd0e786 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 09f819685a96cb4785423a5b2303d147719e273e 
>   src/slave/flags.hpp 0858bdfa93f0c82c9654f9a11d1a251df2d41c36 
>   src/slave/flags.cpp 6e8872e435c9a5d895539e3cd47b41f66bc4eb89 
> 
> Diff: https://reviews.apache.org/r/39417/diff/
> 
> 
> Testing
> ---
> 
> Manual tests, with and without a pre-installed HTB qdisc and classes.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Guangya Liu]

> On 十一月 23, 2015, 5:54 p.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 191-193
> > 
> >
> > Is there a ticket for this? I think we'll want to do this for the MVP.
> > Thoughts?
> 
> Alexander Rukletsov wrote:
> I am a bit reluctant to expose these constants as master flags, because 
> they are rather implementation specific. It would be nice to combine all 
> allocator flags into one `JSON`? file, similar to how we do it for modules. 
> This requires some work, hence I put a TODO without a ticket and am not 
> convinced it's mandatory in the MVP.

There are some discussions planning to put all flags to a configuraiton file: 
http://search-hadoop.com/m/0Vlr6jduNa1HKP7v1/configuration+files&subj=Configuration+file+


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107607
---


On 十一月 23, 2015, 11:35 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated 十一月 23, 2015, 11:35 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
>   src/master/allocator/mesos/hierarchical.cpp 
> aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40497: Add hex number support to numify()

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40497/#review107683
---



3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp (line 25)


s/10/10u?



3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp (line 39)


s/16/16u


- Guangya Liu


On 十一月 23, 2015, 10:32 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40497/
> ---
> 
> (Updated 十一月 23, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Ian Downes.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> numify() in libprocess uses boost lexical_cast() to cast numbers, but it can 
> not cast a hex number. This patch adds hex support to numify().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 5a0ffc38d4194b9f9c53dc1cf0c90ca7bbae2afd 
>   3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
> 440181c25d9d132f48c7a4888dc1dbb0157dc6c8 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 14fb644b38a5cbb8cde74aab39e84305f6ab7041 
>   3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40497/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/#review107685
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 598)


fix the typo (ono -> on)



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 600)


We need to do a check so that fs_layers size == history size first right?



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 195)


let's call it layerId instead of just id



src/tests/containerizer/provisioner_docker_tests.cpp (line 740)


What's changed in this JSON? Why do we need to change it?


- Timothy Chen


On Nov. 23, 2015, 10:16 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39712/
> ---
> 
> (Updated Nov. 23, 2015, 10:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3994
> https://issues.apache.org/jira/browse/MESOS-3994
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor registry client/puller to avoid JSON and struct.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> 3fd84e380f9393a6d46544fb7fc7d24bcb6256ac 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> b17b1b6d9e053af8c80217ea322e99ccab957df1 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7fca99a3b118b0ac06566455ef003daeef7d8157 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9ff27083be91985484960a0d48d909b5594937db 
> 
> Diff: https://reviews.apache.org/r/39712/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 37703: Add docker exec command.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107682
---

Ship it!


Ship It!

- Timothy Chen


On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> ---
> 
> (Updated Oct. 3, 2015, 9:09 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3291
> https://issues.apache.org/jira/browse/MESOS-3291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add docker exec command.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
>   src/tests/containerizer/docker_tests.cpp 
> babc7d8da4ed9d13b14bd69decd7f27fc7dfde89 
> 
> Diff: https://reviews.apache.org/r/37703/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40602/#review107681
---

Ship it!


Suggest change the description to "Added missing DiscoveryInfo.Visibility field 
to v1/mesos.proto."

- Guangya Liu


On 十一月 23, 2015, 4:18 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40602/
> ---
> 
> (Updated 十一月 23, 2015, 4:18 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Neil Conway, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3989
> https://issues.apache.org/jira/browse/MESOS-3989
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 
> 
> Diff: https://reviews.apache.org/r/40602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Guangya Liu]

> On 十一月 23, 2015, 2:40 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 171
> > 
> >
> > What about rename it to recoverQuota()?
> 
> Joris Van Remoortere wrote:
> We want to have just a single recover function, just like other modules 
> in the master.
> The fact that only quota is currently recovered in the hierarchical 
> allocator is a detail, not a constraint. Does this make more sense?
> 
> Alexander Rukletsov wrote:
> It's true that now we recover only quota, but I would prefer to keep 
> `recover()` general. Other allocators (or we in the future) may use it for 
> something different.

Fair enough. I also consider the recover case, it is useful to recover a 
specified number of slave hosts for allocator before allocating resources.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107539
---


On 十一月 23, 2015, 11:35 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated 十一月 23, 2015, 11:35 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
>   src/master/allocator/mesos/hierarchical.cpp 
> aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Guangya Liu]

> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 541
> > 
> >
> > Can you please add some comments here to clarify why need this?
> 
> Guangya Liu wrote:
> Another point is that can we set this as a helper function in 
> resources.cpp?
> 
> Neil Conway wrote:
> I considered making removeDisks() a helper method in 
> resources.cpp/resources.hpp, but I opted against it because resources.hpp is 
> a quasi-public header (so changing it later has backward compat concerns), 
> and it wasn't clear to me that this functionality will be useful for other 
> callers.
> 
> Guangya Liu wrote:
> I think adding a new function will not cause backward compat issues, 
> comments?
> 
> Neil Conway wrote:
> Adding a new function will not, but if we want to change the function 
> later, it might. For example, we should rename `flatten()` because it is a 
> not a well-chosen name, but it won't be trivial to do so because the 
> resources API is semi-public.

Yes, changing names in resources.cpp/hpp will cause backward compat issues, for 
this patch, can we just move removeDisks() to resources.cpp/hpp without 
changing any existing function names?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107531
---


On 十一月 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated 十一月 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

[Anand Mazumdar]

> On Nov. 23, 2015, 11:38 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 3040
> > 
> >
> > backticks for `statusUpdate()` ?

There are multiple occurences in the present file that don't use backticks for 
statusUpdate. Hence, did not do it.

https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1311
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1835
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L3080


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40563/#review107673
---


On Nov. 21, 2015, 1:45 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40563/
> ---
> 
> (Updated Nov. 21, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3476
> https://issues.apache.org/jira/browse/MESOS-3476
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds the ability for the agent to handle status updates from HTTP 
> based executors. Previously, the existing `statusUpdate` method used to 
> handle status updates sent from slave with `pid == UPID()`, sent from other 
> executors/on behalf of other executors with `pid == Some()`. This change 
> modifies the argument to be `Option`. This ensures that `pid == None()` 
> when set, the ACK is correctly routed to the corresponding HTTP based 
> executor.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ce48a0584ab18a8d95dd02619f62df18b2276639 
>   src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40563/diff/
> 
> 
> Testing
> ---
> 
> make check + would add tests once the https://reviews.apache.org/r/39297/ 
> chain is reviewed.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/#review107674
---


Patch looks great!

Reviews applied: [39712]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 10:16 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39712/
> ---
> 
> (Updated Nov. 23, 2015, 10:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3994
> https://issues.apache.org/jira/browse/MESOS-3994
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor registry client/puller to avoid JSON and struct.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> 3fd84e380f9393a6d46544fb7fc7d24bcb6256ac 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> b17b1b6d9e053af8c80217ea322e99ccab957df1 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7fca99a3b118b0ac06566455ef003daeef7d8157 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9ff27083be91985484960a0d48d909b5594937db 
> 
> Diff: https://reviews.apache.org/r/39712/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40563/#review107673
---

Ship it!



src/slave/slave.cpp (line 3039)


backticks for `statusUpdate()` ?


- Vinod Kone


On Nov. 21, 2015, 1:45 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40563/
> ---
> 
> (Updated Nov. 21, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3476
> https://issues.apache.org/jira/browse/MESOS-3476
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds the ability for the agent to handle status updates from HTTP 
> based executors. Previously, the existing `statusUpdate` method used to 
> handle status updates sent from slave with `pid == UPID()`, sent from other 
> executors/on behalf of other executors with `pid == Some()`. This change 
> modifies the argument to be `Option`. This ensures that `pid == None()` 
> when set, the ACK is correctly routed to the corresponding HTTP based 
> executor.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ce48a0584ab18a8d95dd02619f62df18b2276639 
>   src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40563/diff/
> 
> 
> Testing
> ---
> 
> make check + would add tests once the https://reviews.apache.org/r/39297/ 
> chain is reviewed.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/
---

(Updated Nov. 23, 2015, 11:35 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Qian Zhang.


Bugs: MESOS-3981
https://issues.apache.org/jira/browse/MESOS-3981


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 

Diff: https://reviews.apache.org/r/40332/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40586: Corrected typos and formatting issues.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/
---

(Updated Nov. 23, 2015, 11:33 p.m.)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-

Corrected typos and formatting issues.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/quota/quota.hpp 2f8c31f3b90f966a84a6b67029080e7edddef24c 
  src/master/allocator/mesos/hierarchical.hpp 
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 

Diff: https://reviews.apache.org/r/40586/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Alexander Rukletsov]

> On Nov. 23, 2015, 2:40 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 171
> > 
> >
> > What about rename it to recoverQuota()?
> 
> Joris Van Remoortere wrote:
> We want to have just a single recover function, just like other modules 
> in the master.
> The fact that only quota is currently recovered in the hierarchical 
> allocator is a detail, not a constraint. Does this make more sense?

It's true that now we recover only quota, but I would prefer to keep 
`recover()` general. Other allocators (or we in the future) may use it for 
something different.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107539
---


On Nov. 23, 2015, 4:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated Nov. 23, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> c65fe35198b846da2dc959dd467a21ff6edd30a9 
>   src/master/allocator/mesos/hierarchical.cpp 
> 2765526047767cbd19d13c11ecfa6e90c505b3a7 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Alexander Rukletsov]

> On Nov. 23, 2015, 5:54 p.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 177-178
> > 
> >
> > This first invariant is something we push on the user of the allocator 
> > API (i.e. don't call `addSlave()` until after `recover()` is called).
> > The second is an internal invariant we maintain between `initialize()` 
> > and `recover()`.
> > Can we clarify this with a comment, maybe even split them out in 
> > separate code blocks?
> > 
> > I know this seems picky, but we try not to use `CHECK`s for external 
> > invariants (like L177). We happen to do so currently in the allocator 
> > because it is so tightly integrated with the master. Ideally we can remove 
> > these external ones once we refactor; however, we would want to keep the 
> > internal one.
> > Does this make sense?

That's a good remark and it does make sense in general. However in this case, 
both are checks are API-related. The second one (L178) ensures a client does 
not call `setQuota()` until after `recover()` is called. Actually, similar is 
with `CHECK(initialized)`: we ensure `initialize()` is called before all other 
functions.


> On Nov. 23, 2015, 5:54 p.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 191-193
> > 
> >
> > Is there a ticket for this? I think we'll want to do this for the MVP.
> > Thoughts?

I am a bit reluctant to expose these constants as master flags, because they 
are rather implementation specific. It would be nice to combine all allocator 
flags into one `JSON`? file, similar to how we do it for modules. This requires 
some work, hence I put a TODO without a ticket and am not convinced it's 
mandatory in the MVP.


> On Nov. 23, 2015, 5:54 p.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 413-418
> > 
> >
> > Rather than doing the math here  (which I believe we're missing 
> > corresponding entries for in `removeSlave()`?) why not test whether 
> > `slaves.size() >= expectedAgentCount()` ?
> > 
> > I think it is more clear, and less error prone.
> > 
> > Let's log when this condition is met?

Let me address your concerns one by one : )

1. I don't think we need corresponding entries in `removeSlave()` because we do 
not track what agents reregistered, but rather a total number. If an agent 
reregistered and then got lost, this should not influence the allocation pause.
2. For the reason described in 1., `slaves.size() >= expectedAgentCount()` 
seems not a good fit, because it counts removed agents in.
3. Logging is a good idea.


> On Nov. 23, 2015, 5:54 p.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 988-997
> > 
> >
> > Let's most definitely log this :-)
> > It should happen rarely, so it's not a big deal to log.
> > Considering the conversations we had with other developers, this is 
> > definitely something they will want to know when debugging ;-)

Could not agree more!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107607
---


On Nov. 23, 2015, 4:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated Nov. 23, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> c65fe35198b846da2dc959dd467a21ff6edd30a9 
>   src/master/allocator/mesos/hierarchical.cpp 
> 2765526047767cbd19d13c11ecfa6e90c505b3a7 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 40618: Include the header for boost::hash_combine explicitly

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40618/
---

Review request for mesos, Bruno Mahé and Vinod Kone.


Repository: mesos


Description
---

Currently boost/functional/hash.hpp is included implicitly, we should include 
it explicitly.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
bffdc3829208496ef14fecca497af73d4399867b 

Diff: https://reviews.apache.org/r/40618/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Alexander Rukletsov]

> On Nov. 23, 2015, 9:22 a.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 192
> > 
> >
> > I think what we want to use should be master's flag: 
> > `slave_reregister_timeout`, so can we just pass it into allocator when 
> > master initializes allocator rather than defining a separate const here?

Not necessarily. For example, this value may be greater than 
`slave_reregister_timeout` with the idea that for an operator may add some 
agents instead of lost ones. It can also be smaller, which means we start 
allocation without waiting for agents to reregister.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107568
---


On Nov. 23, 2015, 4:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated Nov. 23, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> c65fe35198b846da2dc959dd467a21ff6edd30a9 
>   src/master/allocator/mesos/hierarchical.cpp 
> 2765526047767cbd19d13c11ecfa6e90c505b3a7 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107664
---


Patch looks great!

Reviews applied: [39320]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 23, 2015, 5:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Alexander Rukletsov]

> On Nov. 23, 2015, 2:07 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 193
> > 
> >
> > Can we add some comments for why using 0.8 as default?

They should be exposed as parameters.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107535
---


On Nov. 23, 2015, 4:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated Nov. 23, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> c65fe35198b846da2dc959dd467a21ff6edd30a9 
>   src/master/allocator/mesos/hierarchical.cpp 
> 2765526047767cbd19d13c11ecfa6e90c505b3a7 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/
---

(Updated Nov. 23, 2015, 10:33 p.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
---

Address review comments and rebase


Repository: mesos


Description
---

When --egress_unique_flow_per_container is enabled, we need to install a flow 
classifier (fq_codel) qdisc on egress side. This flag specifies where to 
install it in the hierarchy. By default, we install it at root. But, for 
example, if you have already installed HTB qdisc at root, you may want this to 
be installed in other place than root, specify an HTB class ID as its parent 
here.


Diffs (updated)
-

  docs/configuration.md 126f4aa8e3de2a2346336991c9b9a2ea61a8cd0a 
  src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
  src/linux/routing/handle.hpp 6deff85b52daa6b8771f127fea0d661cb5cd5e6a 
  src/linux/routing/handle.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
0865a71b1d79adcf62ca0f12d7ea0a23ebd0e786 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
09f819685a96cb4785423a5b2303d147719e273e 
  src/slave/flags.hpp 0858bdfa93f0c82c9654f9a11d1a251df2d41c36 
  src/slave/flags.cpp 6e8872e435c9a5d895539e3cd47b41f66bc4eb89 

Diff: https://reviews.apache.org/r/39417/diff/


Testing
---

Manual tests, with and without a pre-installed HTB qdisc and classes.


Thanks,

Cong Wang

Re: Review Request 40506: Add stdout/tests/numify_tests.cpp into Makefile.am

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40506/
---

(Updated Nov. 23, 2015, 10:32 p.m.)


Review request for mesos, Ben Mahler and Ian Downes.


Changes
---

Rebase


Repository: mesos


Description
---

Add stdout/tests/numify_tests.cpp into Makefile.am


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
0adbe539afaf683e4a85582463a2930049a63998 

Diff: https://reviews.apache.org/r/40506/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 40497: Add hex number support to numify()

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40497/
---

(Updated Nov. 23, 2015, 10:32 p.m.)


Review request for mesos, Ben Mahler and Ian Downes.


Changes
---

Address review comments


Repository: mesos


Description
---

numify() in libprocess uses boost lexical_cast() to cast numbers, but it can 
not cast a hex number. This patch adds hex support to numify().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
5a0ffc38d4194b9f9c53dc1cf0c90ca7bbae2afd 
  3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
440181c25d9d132f48c7a4888dc1dbb0157dc6c8 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
14fb644b38a5cbb8cde74aab39e84305f6ab7041 
  3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40497/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/
---

(Updated Nov. 23, 2015, 2:16 p.m.)


Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.


Summary (updated)
-

Refactor registry client/puller to avoid JSON and struct.


Bugs: MESOS-3994
https://issues.apache.org/jira/browse/MESOS-3994


Repository: mesos


Description (updated)
---

Refactor registry client/puller to avoid JSON and struct.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
3fd84e380f9393a6d46544fb7fc7d24bcb6256ac 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
b17b1b6d9e053af8c80217ea322e99ccab957df1 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
7fca99a3b118b0ac06566455ef003daeef7d8157 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9ff27083be91985484960a0d48d909b5594937db 

Diff: https://reviews.apache.org/r/39712/diff/


Testing
---

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 40115: Windows: [2/2] Changed gc.cpp to compile on Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/
---

(Updated Nov. 23, 2015, 10:15 p.m.)


Review request for mesos and Alex Clemmer.


Repository: mesos


Description (updated)
---

Windows: [2/2] updated gc.cpp to compile on Windows.


Diffs (updated)
-

  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
  src/slave/gc.cpp 6042277f893a54ada612b2080d35061236f4176a 

Diff: https://reviews.apache.org/r/40115/diff/


Testing
---


Thanks,

Daniel Pravat

Re: Review Request 37853: Overlay filesystem provisioning backend

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review107653
---



src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 33)


Nit: We usually put the NOTE: beginning of the comment.



src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 34)


single images doesn't make much sense to me, I assume you're saying 
OverlayBackend doesn't support images with a single layer?



src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 36)


What's N.B.?
To me this is not really a desirable condition for users that has to prep 
all images to have sandbox_directory created. Can we at least add a TODO to say 
we want to create it here or somewhere upstream?



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 97)


Should we do this check in create?



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 100)


We use camel case.



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 117)


Let's use layers instead of image here.



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 122)


single quotes around the rootfs variable.



src/tests/containerizer/provisioner_backend_tests.cpp (line 55)


We need to run this in a system where Overlay fs is enabled right?
Can we add a check and disable in environment or in the test class?


- Timothy Chen


On Oct. 28, 2015, 3:58 a.m., Mei Wan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> ---
> 
> (Updated Oct. 28, 2015, 3:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the overlay filesystem backend by layering the images as a 
> read-only filesystem.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6c7519b 
>   src/Makefile.am d6eb302 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> ---
> 
> I haven't done any official testing. When I was working off Ian's branch, I 
> tested it manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>

Re: Review Request 36620: Added Non-Freezeer Task Killer.

[Timothy Chen]

> On Sept. 1, 2015, 2:52 p.m., Mesos ReviewBot wrote:
> > Patch looks great!
> > 
> > Reviews applied: [36612, 36620]
> > 
> > All tests passed.
> 
> Timothy Chen wrote:
> Jie does this look good to you?
> 
> Jie Yu wrote:
> Should we close this given https://reviews.apache.org/r/37967/?

Looks like we can do that. I'll close this.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review97288
---


On Sept. 1, 2015, 2:12 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> ---
> 
> (Updated Sept. 1, 2015, 2:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
> https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> + manual tests
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/#review107609
---


Patch looks great!

Reviews applied: [40586, 40551, 40332, 39450]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 5:24 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39450/
> ---
> 
> (Updated Nov. 23, 2015, 5:24 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3984
> https://issues.apache.org/jira/browse/MESOS-3984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 740cfa801ee90417c038308192d1f4f2416f8315 
> 
> Diff: https://reviews.apache.org/r/39450/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39449: Documented order of includes.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39449/#review107645
---

Ship it!


Ship It!

- Michael Park


On Nov. 20, 2015, 11:17 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39449/
> ---
> 
> (Updated Nov. 20, 2015, 11:17 a.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Michael Park.
> 
> 
> Bugs: MESOS-2275
> https://issues.apache.org/jira/browse/MESOS-2275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented order of includes.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/39449/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review107640
---

Ship it!



src/tests/master_quota_tests.cpp (line 115)


Can we use `process::ID::generate()` here?


- Joris Van Remoortere


On Nov. 20, 2015, 8:48 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 20, 2015, 8:48 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40610: Changed getBlob invocation to use defer mechanism.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40610/#review107639
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 23, 2015, 8:18 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40610/
> ---
> 
> (Updated Nov. 23, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos, Michael Park and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed possible dangling pointer in getBlob continuation.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> f488640d631cf06b71c614dc1828c71dc43be9aa 
> 
> Diff: https://reviews.apache.org/r/40610/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40610: Changed getBlob invocation to use defer mechanism.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40610/#review107638
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 754)


Agrh, missed this during the review :(


- Timothy Chen


On Nov. 23, 2015, 8:18 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40610/
> ---
> 
> (Updated Nov. 23, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos, Michael Park and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed possible dangling pointer in getBlob continuation.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> f488640d631cf06b71c614dc1828c71dc43be9aa 
> 
> Diff: https://reviews.apache.org/r/40610/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107637
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 40610: Changed getBlob invocation to use defer mechanism.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40610/
---

Review request for mesos, Michael Park and Timothy Chen.


Repository: mesos


Description
---

Fixed possible dangling pointer in getBlob continuation.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
f488640d631cf06b71c614dc1828c71dc43be9aa 

Diff: https://reviews.apache.org/r/40610/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 40512: Libprocess Reinitialization: Add a test-only method to reinitialize libprocess.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40512/
---

(Updated Nov. 23, 2015, 12:14 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Rebase.


Bugs: MESOS-3820
https://issues.apache.org/jira/browse/MESOS-3820


Repository: mesos


Description
---

This builds upon earlier changes to complete `process::finalize`.  Tests which 
need to reconfigure libprocess, such as some SSL-related tests, can use 
`process::reinitialize` to do so.  

This method may also be useful for providing additional isolation between tests.


Diffs (updated)
-

  3rdparty/libprocess/src/openssl.cpp 523b9740a45bdae3fa9a1a1423108e6815fbf872 
  3rdparty/libprocess/src/process.cpp 0fa15dd3d3c83c98411760738b0541248d548ee6 

Diff: https://reviews.apache.org/r/40512/diff/


Testing
---

Defined `process::reinitialize` in several tests, such as `HTTPTest`, 
`MetricsTest`, and `ReapTest` can called `process::reinitialize` before and 
after tests.  Confirmed that this did not have side effects on other tests (See 
https://reviews.apache.org/r/40453/ ).


Thanks,

Joseph Wu

Re: Review Request 40264: Libprocess Reinitialization: Implement Clock::finalize for cleaning up timers

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40264/
---

(Updated Nov. 23, 2015, 11:57 a.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Add more comments to document the assumptions of `Clock::finalize`.


Bugs: MESOS-3882
https://issues.apache.org/jira/browse/MESOS-3882


Repository: mesos


Description
---

Timers may deference `process_manager`, either directly or via the associated 
lambda, after `process_manager` has been freed in `process::finalize`.  
Cleaning up the `Clock` appropriately in `process::finalize` prevents that race.


Diffs (updated)
-

  3rdparty/libprocess/include/process/clock.hpp 
2e526f810e2702b57ea172835ab99e4ee8537252 
  3rdparty/libprocess/src/clock.cpp 7665d120b3897a76ce018bed0c3d039eabca521f 
  3rdparty/libprocess/src/process.cpp 0fa15dd3d3c83c98411760738b0541248d548ee6 

Diff: https://reviews.apache.org/r/40264/diff/


Testing
---

`make check` (--enable-libevent --enable-ssl)


Thanks,

Joseph Wu

Re: Review Request 39387: Make health check run outside for docker container task.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/#review107635
---



src/docker/executor.cpp (line 324)


I don't see you handling the else case here?


- Timothy Chen


On Nov. 23, 2015, 5:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39387/
> ---
> 
> (Updated Nov. 23, 2015, 5:07 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3599
> https://issues.apache.org/jira/browse/MESOS-3599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make health check run outside for docker container task.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0b8289fd405bdd3a25ea49151abc4a2ccf486f26 
>   include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 
>   src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2 
> 
> Diff: https://reviews.apache.org/r/39387/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39949/#review107634
---

Ship it!


I'll add a comment as to why we use atomic before committing.

- Joris Van Remoortere


On Nov. 20, 2015, 7:16 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39949/
> ---
> 
> (Updated Nov. 20, 2015, 7:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3864
> https://issues.apache.org/jira/browse/MESOS-3864
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Renamed `initialized` to `initialize_started`.
> * Renamed `initializing` to `initialize_complete`.
> * Removed the (2) condition, described below: 
> 
> The initialization synchronization logic contains three conditions, which 
> check:
> 1) Was `initialize` called and is it done?
> 2) Was `initialize` called and is it not done?
> 3) Are you the first to call `initialize`?
> 
> Condition (3) uses `compare_exchange_strong` between `initialized` and 
> `false`.  This returns `true` (and sets `initialized` to true) iff the caller 
> is the first to reach that expression.
> 
> The second simultaneous caller of `initialize` will either satisify condition 
> (2) or (3) and then wait on `initializing`.  For the second caller, (2) and 
> (3) are identical because `compare_exchange_strong` between `true` and 
> `false` will always return false, thereby putting the second caller into the 
> waiting loop.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 8fa0594b671969c2713d1b361f2dbbb07d25b3a8 
> 
> Diff: https://reviews.apache.org/r/39949/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Replaced `process::initialize();` in `3rdparty/libprocess/src/tests/main.cpp` 
> with:
> ```
> 
>   const size_t numThreads = 50;
> 
>   std::thread* runningThreads[numThreads];
> 
>   // Create additional threads.
>   for (size_t i = 0; i < numThreads; i++) {
> runningThreads[i] = new std::thread([]() {
>   process::initialize();
> });
>   }
> 
>   for (size_t i = 0; i < numThreads; i++) {
> runningThreads[i]->join();
> delete runningThreads[i];
>   }
> ```
> (Also added `#include ` to the header).
> 
> Rebuilt `libprocess-tests` with the modification and ran it a few times.
> `3rdparty/libprocess/libprocess-tests`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 40264: Libprocess Reinitialization: Implement Clock::finalize for cleaning up timers

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40264/#review107632
---

Ship it!



3rdparty/libprocess/include/process/clock.hpp (lines 53 - 54)


Let's clarify why it is ok not to execute them: that processes should have 
been properly finalized before the clock is finalized.



3rdparty/libprocess/src/clock.cpp (line 141)


Let's add a comment that `tick` must remain robust to arbitrary 
invocations, as per offline discussion.


- Joris Van Remoortere


On Nov. 20, 2015, 7:17 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40264/
> ---
> 
> (Updated Nov. 20, 2015, 7:17 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3882
> https://issues.apache.org/jira/browse/MESOS-3882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Timers may deference `process_manager`, either directly or via the associated 
> lambda, after `process_manager` has been freed in `process::finalize`.  
> Cleaning up the `Clock` appropriately in `process::finalize` prevents that 
> race.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/clock.hpp 
> 1107a329caf77f15901d87808eee72818601510c 
>   3rdparty/libprocess/src/clock.cpp 58060985bf8ab8a1bbd78b687b4c96836e13b86a 
>   3rdparty/libprocess/src/process.cpp 
> 8fa0594b671969c2713d1b361f2dbbb07d25b3a8 
> 
> Diff: https://reviews.apache.org/r/40264/diff/
> 
> 
> Testing
> ---
> 
> `make check` (--enable-libevent --enable-ssl)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39948/#review107633
---

Ship it!


Ship It!

- Joris Van Remoortere


On Nov. 20, 2015, 7:16 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39948/
> ---
> 
> (Updated Nov. 20, 2015, 7:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van 
> Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3864
> https://issues.apache.org/jira/browse/MESOS-3864
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These are remnants of commented-out code, dating back to when libprocess was 
> originally open-sourced.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 8fa0594b671969c2713d1b361f2dbbb07d25b3a8 
> 
> Diff: https://reviews.apache.org/r/39948/diff/
> 
> 
> Testing
> ---
> 
> None.  Comment change only.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39387: Make health check run outside for docker container task.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/#review107630
---


Patch looks great!

Reviews applied: [39387]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 5:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39387/
> ---
> 
> (Updated Nov. 23, 2015, 5:07 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3599
> https://issues.apache.org/jira/browse/MESOS-3599
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make health check run outside for docker container task.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0b8289fd405bdd3a25ea49151abc4a2ccf486f26 
>   include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 
>   src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2 
> 
> Diff: https://reviews.apache.org/r/39387/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107625
---


An alternative would be to pause and advance the clock by the 
allocation_interval. Do you think that would be worth doing instead?

- Neil Conway


On Nov. 23, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 23, 2015, 5:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Joris Van Remoortere]

> On Nov. 23, 2015, 2:40 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 171
> > 
> >
> > What about rename it to recoverQuota()?

We want to have just a single recover function, just like other modules in the 
master.
The fact that only quota is currently recovered in the hierarchical allocator 
is a detail, not a constraint. Does this make more sense?


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107539
---


On Nov. 23, 2015, 4:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated Nov. 23, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> c65fe35198b846da2dc959dd467a21ff6edd30a9 
>   src/master/allocator/mesos/hierarchical.cpp 
> 2765526047767cbd19d13c11ecfa6e90c505b3a7 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40114/#review107619
---

Ship it!


Looks good, couple minor comments. Can you please also add the following people 
to the review: `hartem` (Artem, Mesos-core dev manager), `jvanremoortere` 
(Mesos committer), `kaysoky` (Mesos core team member), `mcypark` (Mesos 
committer, with fancy SFINAE knowledge).


3rdparty/libprocess/include/process/future.hpp (line 355)


Please add TODO here for me also.



3rdparty/libprocess/include/process/future.hpp (line 187)


Oh, I see, we are expecting to update this in February. Can you add a 
`TODO(hausdorff)` to tell me to update this in February? Also can you please 
mention this issue is tracked in issue MESOS-3993?



3rdparty/libprocess/include/process/future.hpp (line 237)


Sorry, one more thing. How about something like "Platform-dependent 
template in this macro are equivalent to:"

This just makes it very clear what the relationship of the commented-out 
template is. Otherwise people might think that the template was commented out 
and is just dead code. (We wouldn't want someone to do a style-pass and delete 
it accidentally!)


- Alex Clemmer


On Nov. 21, 2015, 1:47 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40114/
> ---
> 
> (Updated Nov. 21, 2015, 1:47 a.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Windows & Posix defines for several parameter list used in future.hpp. 
> Provided a new parameter list for VC2015.
> Move the existing parameter list into posix.hpp. 
> 
> The change has been due to: 
> 
>1. VS 2015 won't support C++14 result_of SFINAE until Update 2,  so
>   result_of must be replaced with decltype(invoke).
>2. VS 2015 won't support C++14 std::function SFINAE until Update 2, so
>   converting _Deferred to std::function must be done by explicitly
>   calling _Deferred's conversion function.
>3. The Standard (C++11 through 17) does not require bind's function call
>   operator to SFINAE, and VS 2015's doesn't.  is_bind_expression can be
>   used to manually reroute bind expressions to the 1-arg overload, where
>   (conveniently) the argument will be ignored if necessary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 3916150691e9a0880b8b826734fa74bd33d18cfd 
>   3rdparty/libprocess/include/process/posix/future.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/future.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40114/diff/
> 
> 
> Testing
> ---
> 
> OSX make check, Windows 10 make, Ubuntu 15.1 make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40602/#review107620
---


Patch looks great!

Reviews applied: [40602]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 4:18 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40602/
> ---
> 
> (Updated Nov. 23, 2015, 4:18 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Neil Conway, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3989
> https://issues.apache.org/jira/browse/MESOS-3989
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 
> 
> Diff: https://reviews.apache.org/r/40602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107607
---



src/master/allocator/mesos/hierarchical.hpp (line 196)


s/Methods/Functions/Helpers/
Methods is more of a java-ism :-)



src/master/allocator/mesos/hierarchical.cpp (lines 177 - 178)


This first invariant is something we push on the user of the allocator API 
(i.e. don't call `addSlave()` until after `recover()` is called).
The second is an internal invariant we maintain between `initialize()` and 
`recover()`.
Can we clarify this with a comment, maybe even split them out in separate 
code blocks?

I know this seems picky, but we try not to use `CHECK`s for external 
invariants (like L177). We happen to do so currently in the allocator because 
it is so tightly integrated with the master. Ideally we can remove these 
external ones once we refactor; however, we would want to keep the internal one.
Does this make sense?



src/master/allocator/mesos/hierarchical.cpp (line 184)


new line.



src/master/allocator/mesos/hierarchical.cpp (line 187)


s/after/after a/



src/master/allocator/mesos/hierarchical.cpp (lines 191 - 193)


Is there a ticket for this? I think we'll want to do this for the MVP.
Thoughts?



src/master/allocator/mesos/hierarchical.cpp (line 198)


s/Record a/Record the/



src/master/allocator/mesos/hierarchical.cpp (lines 199 - 200)


Let's drop the `this`, and rename the parameter with a `_`.



src/master/allocator/mesos/hierarchical.cpp (line 412)


Should we `CHECK(!paused || expectedAgentCount.isSome());` above this?



src/master/allocator/mesos/hierarchical.cpp (lines 413 - 418)


Rather than doing the math here  (which I believe we're missing 
corresponding entries for in `removeSlave()`?) why not test whether 
`slaves.size() >= expectedAgentCount()` ?

I think it is more clear, and less error prone.

Let's log when this condition is met?



src/master/allocator/mesos/hierarchical.cpp (lines 988 - 997)


Let's most definitely log this :-)
It should happen rarely, so it's not a big deal to log.
Considering the conversations we had with other developers, this is 
definitely something they will want to know when debugging ;-)



src/master/allocator/mesos/hierarchical.cpp (lines 994 - 997)


Does it make sense to `CHECK(paused)` here?
If not, why not? I think making these semantics as clear as possible is 
crucial for such a high impact change.



src/master/allocator/mesos/hierarchical.cpp (lines 1009 - 1010)


Let's log that we are skipping allocation due to a paused allocator.
Same for the keyed version of this function below.


- Joris Van Remoortere


On Nov. 23, 2015, 4:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> ---
> 
> (Updated Nov. 23, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
> https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> c65fe35198b846da2dc959dd467a21ff6edd30a9 
>   src/master/allocator/mesos/hierarchical.cpp 
> 2765526047767cbd19d13c11ecfa6e90c505b3a7 
> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/
---

(Updated Nov. 23, 2015, 5:52 p.m.)


Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till Toenshoff.


Changes
---

Extended the comment.


Bugs: MESOS-3732
https://issues.apache.org/jira/browse/MESOS-3732


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/fault_tolerance_tests.cpp 3bbd6cbf6b101415c90991c48f00f33a5aff5590 

Diff: https://reviews.apache.org/r/39320/diff/


Testing
---

make check

The run time for the `FaultToleranceTest.FrameworkReregister` test has reduced 
from more than `1s` to less than `100ms`.
Before:
```
[ RUN  ] FaultToleranceTest.FrameworkReregister
[   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
```
After:
```
[ RUN  ] FaultToleranceTest.FrameworkReregister
[   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
```


Thanks,

Alexander Rukletsov

Re: Review Request 40586: Corrected typos and a formatting issue.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/
---

(Updated Nov. 23, 2015, 5:38 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Corrected one more typo.


Summary (updated)
-

Corrected typos and a formatting issue.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9 
  src/master/allocator/mesos/hierarchical.hpp 
c65fe35198b846da2dc959dd467a21ff6edd30a9 

Diff: https://reviews.apache.org/r/40586/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39400: Quota: Implemented quota API.

[Alexander Rukletsov]

> On Nov. 23, 2015, 8:07 a.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 391
> > 
> >
> > For this newly added member `quotaRoleSorter`, I think we also need to 
> > initialize it in the constructor like what we did for `roleSorter`.
> > ```
> > HierarchicalAllocatorProcess(
> >   const std::function& _roleSorterFactory,
> >   const std::function& _frameworkSorterFactory)
> > : ProcessBase(process::ID::generate("hierarchical-allocator")),
> >   initialized(false),
> >   metrics(*this),
> >   roleSorterFactory(_roleSorterFactory),
> >   frameworkSorterFactory(_frameworkSorterFactory),
> >   roleSorter(NULL) {}<--- we initialized roleSorter here.
> > ```

Let's fix it in https://reviews.apache.org/r/40586/


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review107563
---


On Nov. 11, 2015, 10:29 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> ---
> 
> (Updated Nov. 11, 2015, 10:29 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cd0d3e0bd234fcf4db9af2e376ea311937204f75 
>   src/master/allocator/mesos/hierarchical.cpp 
> 14fef63714721fcda7cea3c28704766efda6d007 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/
---

(Updated Nov. 23, 2015, 5:24 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Variable names and comments.


Bugs: MESOS-3984
https://issues.apache.org/jira/browse/MESOS-3984


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
740cfa801ee90417c038308192d1f4f2416f8315 

Diff: https://reviews.apache.org/r/39450/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39946/
---

(Updated Nov. 23, 2015, 5:10 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Rebase.


Bugs: MESOS-3827
https://issues.apache.org/jira/browse/MESOS-3827


Repository: mesos


Description
---

As discussed in MESOS-3827, this can improve compilation time of classes that
use GMock. On my system, this improves the compilation time of the unit tests by
about 8%.

Note that we can't use this technique with TestAllocator, because it is
templatized.


Diffs (updated)
-

  src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
  src/tests/containerizer/launcher.hpp 09c4ba29d6240a3fbc132d82733d7df7b28e00a1 
  src/tests/containerizer/launcher.cpp PRE-CREATION 
  src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
  src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10 

Diff: https://reviews.apache.org/r/39946/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Neil Conway]

> On Nov. 18, 2015, 10:36 p.m., Greg Mann wrote:
> > src/tests/persistent_volume_endpoints_tests.cpp, lines 498-500
> > 
> >
> > Is this behavior significant enough to create a JIRA to evaulate and 
> > possibly change it?

Created MESOS-3961.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107080
---


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Neil Conway]

> On Nov. 23, 2015, 1:35 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 541
> > 
> >
> > Can you please add some comments here to clarify why need this?
> 
> Guangya Liu wrote:
> Another point is that can we set this as a helper function in 
> resources.cpp?
> 
> Neil Conway wrote:
> I considered making removeDisks() a helper method in 
> resources.cpp/resources.hpp, but I opted against it because resources.hpp is 
> a quasi-public header (so changing it later has backward compat concerns), 
> and it wasn't clear to me that this functionality will be useful for other 
> callers.
> 
> Guangya Liu wrote:
> I think adding a new function will not cause backward compat issues, 
> comments?

Adding a new function will not, but if we want to change the function later, it 
might. For example, we should rename `flatten()` because it is a not a 
well-chosen name, but it won't be trivial to do so because the resources API is 
semi-public.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107531
---


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39387: Make health check run outside for docker container task.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/
---

(Updated Nov. 23, 2015, 5:07 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Switch to use option to specify running command outside container.


Bugs: MESOS-3599
https://issues.apache.org/jira/browse/MESOS-3599


Repository: mesos


Description
---

Make health check run outside for docker container task.


Diffs (updated)
-

  include/mesos/mesos.proto 0b8289fd405bdd3a25ea49151abc4a2ccf486f26 
  include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 
  src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2 

Diff: https://reviews.apache.org/r/39387/diff/


Testing
---

make -j8 check


Thanks,

haosdent huang

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 23, 2015, 5:06 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Remove tabs from docs.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
  src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
  src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
  src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
  src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40602/
---

(Updated Nov. 23, 2015, 4:18 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Neil Conway, and Till 
Toenshoff.


Bugs: MESOS-3989
https://issues.apache.org/jira/browse/MESOS-3989


Repository: mesos


Description
---

Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.


Diffs
-

  include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 

Diff: https://reviews.apache.org/r/40602/diff/


Testing
---


Thanks,

haosdent huang

Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40602/
---

Review request for mesos, Adam B and Neil Conway.


Repository: mesos


Description
---

Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.


Diffs
-

  include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 

Diff: https://reviews.apache.org/r/40602/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/
---

(Updated Nov. 23, 2015, 4:11 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-3984
https://issues.apache.org/jira/browse/MESOS-3984


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
740cfa801ee90417c038308192d1f4f2416f8315 

Diff: https://reviews.apache.org/r/39450/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/
---

(Updated Nov. 23, 2015, 4:11 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Qian Zhang.


Changes
---

Rebased.


Bugs: MESOS-3981
https://issues.apache.org/jira/browse/MESOS-3981


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
c65fe35198b846da2dc959dd467a21ff6edd30a9 
  src/master/allocator/mesos/hierarchical.cpp 
2765526047767cbd19d13c11ecfa6e90c505b3a7 

Diff: https://reviews.apache.org/r/40332/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40224/#review107604
---


I think keep the sync of these files when flags add or delete Protobuf fields a 
bit hard. Is it possible to change flags stringify protobuf objects as json 
string


src/master/http.cpp (line 331)


Seems miss credentials, whitelist



src/master/http.cpp (line 625)


Seems slave also have similar things? Do we need also update http.cpp in 
slave?


- haosdent huang


On Nov. 23, 2015, 5:56 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40224/
> ---
> 
> (Updated Nov. 23, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-3792
> https://issues.apache.org/jira/browse/MESOS-3792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix wrong flags infos in /state and /flags. We should convert protobuf type 
> flag to JSON object explicitly instead of relying on stringify
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
> 
> Diff: https://reviews.apache.org/r/40224/diff/
> 
> 
> Testing
> ---
> 
> make & make check
> 
> ./mesos-master.sh --work_dir=/tmp/mesos --acls='{"register_frameworks": 
> [{"principals": { "type": "ANY" },"roles": { "values": ["a"] }}],"run_tasks": 
> [{"principals": { "values": ["a", "b"] },"users": { "values": ["c"] 
> }}],"shutdown_frameworks": [{"principals": { "values": ["a", "b"] 
> },"framework_principals": { "values": ["c"] }}]}'
> 
> curl http://master:5050/state
> curl http://master:5050/flag
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

[Alexander Rukletsov]

> On Nov. 10, 2015, 4:03 p.m., Joerg Schad wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 1151
> > 
> >
> > Also the simple case of correct behavior with several frameworks in one 
> > role would be interesting.

DO you mean something like `MultipleFrameworksInRoleWithQuota`, L1370?


> On Nov. 10, 2015, 4:03 p.m., Joerg Schad wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 1174
> > 
> >
> > Does it make sense to refelect that in the role name?

Good idea!


> On Nov. 10, 2015, 4:03 p.m., Joerg Schad wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 1619
> > 
> >
> > This describes more the user story, should we maybe focus on what the 
> > test itself intends to test?

I'd say, the test intends to test exactly this user story : ). For me it's 
easier to understand the purpose of the test if I know the background or the 
issue. Because this test is not trivial, I would argue the user story helps.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/#review105885
---


On Nov. 23, 2015, 10:45 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39450/
> ---
> 
> (Updated Nov. 23, 2015, 10:45 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3984
> https://issues.apache.org/jira/browse/MESOS-3984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 740cfa801ee90417c038308192d1f4f2416f8315 
> 
> Diff: https://reviews.apache.org/r/39450/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40586: Corrected a typo and a formatting issue.

[Alexander Rukletsov]

> On Nov. 23, 2015, 4:35 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.hpp, lines 367-377
> > 
> >
> > Sorry, what is the update for this file?

removed extra blank line


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/#review107548
---


On Nov. 22, 2015, 11:59 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40586/
> ---
> 
> (Updated Nov. 22, 2015, 11:59 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9 
>   src/master/allocator/mesos/hierarchical.hpp 
> c65fe35198b846da2dc959dd467a21ff6edd30a9 
> 
> Diff: https://reviews.apache.org/r/40586/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/#review107595
---


Bad patch!

Reviews applied: [40424]

Failed command: ./support/apply-review.sh -n -r 40424

Error:
 2015-11-23 15:19:51 URL:https://reviews.apache.org/r/40424/diff/raw/ 
[1841/1841] -> "40424.patch" [1]
Successfully applied: Enhance the existing HTTP endpoint /roles

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Review: https://reviews.apache.org/r/40424
Checking 1 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
src/master/http.cpp:1350:  Redundant blank line at the start of a code block 
should be deleted.  [whitespace/blank_line] [2]
src/master/http.cpp:1369:  Lines should be <= 80 characters long  
[whitespace/line_length] [2]
Total errors found: 2
Failed to commit patch

- Mesos ReviewBot


On Nov. 23, 2015, 2:55 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40424/
> ---
> 
> (Updated Nov. 23, 2015, 2:55 p.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3791
> https://issues.apache.org/jira/browse/MESOS-3791
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this ticket, we will enhance the existing
> HTTP endpoint to query roles as outlined in
> the dynamic role design Doc.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
> 
> Diff: https://reviews.apache.org/r/40424/diff/
> 
> 
> Testing
> ---
> 
> Test results:
> $ curl http://127.0.0.1:5050/roles
> {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> $ curl http://127.0.0.1:5050/roles?roleName=aa
> {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> 
> $ curl http://127.0.0.1:5050/roles?roleName=dd
> The specified role [dd] does not exist!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39591/#review107592
---

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 18, 2015, 4:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39591/
> ---
> 
> (Updated Nov. 18, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adjusts license headers of C++ source and header files.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
> 064e84ee97ba8c875a740223bd0012b3a8293a31 
>   3rdparty/libprocess/3rdparty/stout/include/stout/attributes.hpp 
> 27087041d8255b96159bb10c184f00cf5bc9c34e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 
> 4893e7ba0b7d83fd3ba36bf18aa541c60293cc23 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp 
> b9a9c20125229c8150660e5969e136b07cecb169 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> e9cf85637157f98a0eac166096bb18fa5652c669 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 0d51c8d418acb49b52cebfb644ee0476d6ec4502 
>   3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 
> b550bfee696c85c0ade3feaf5d38e20eb4c1ce78 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> e58ee43623d72b52dd8682e3d976da74e8bec9e8 
>   3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 
> 5d0970fe9f712d7162eec522c83905292892c94d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> 1845b1ed8214c5d35697a812181f97f799484838 
>   3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
> 38dabd45aa1d7f02e9991ce4ae28b44cd39db87c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags.hpp 
> ab609a0d7922298eaf89648200fabd843f8201e0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/fetch.hpp 
> 3c320a319edce83af0287b0b014234f7e7ec6e0b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> a289f8303740394ec1a0900e643d33e3c18a831d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> 7cf4feff87dd08201a410596d2862383c29021af 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
> 25252015d04884dae7238129e2d7313a615967ca 
>   3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 
> d9d0fd4febd540252ae53fb4af7eb061983d0133 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> 642bd4ce640cfdbf3c122cec64d72c9434d89fa3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp 
> f766359fdd5a75e3a80d19be3e5c233e87357bde 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
> 85c773ac675c88b313dffda7a9c32bac42ebe62d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> 51ec75868e614042c339ab0eaa995c9996ddf124 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> 1839d28638cd82dae10ba9b0f99c1a97cf34f9c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
> d207dc5ad7558818da7fd0d04c6ef8df217b78c1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 6709f5e7f6233983f389203278a0e42694591230 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 9625894b69417faa796be5c4313b759cbcc1ce90 
>   3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp 
> 6cbb2ac50dd23d78465e8690112fc01114ada07b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp 
> 89340fd79167a311c698740454db19e83c286952 
>   3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 
> 60f0c8c67317872883857a1cd8f39d6d6a45d0c1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 9428717fac4655898d7768957f02937592e1a398 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
> 5748c9e6d39551eee287f3e9804505cb2fd3fdd0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 
> 52d1eea6d04092caa8eba39ad69c2a474f854a8d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/none.hpp 
> ce94fef4aeeb098668decc36606ee667915a15cd 
>   3rdparty/libprocess/3rdparty/stout/include/stout/nothing.hpp 
> 95b730c83ec357b33afae0d04182f7a72ffd28c4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
> ddd3dd9e015c583e04d72ac9a9b5a5ed6f1d49d5 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> db5e33220844d20ef08a7324f641eeb1ff6d2052 
>   3r

Re: Review Request 39590: Made license-headers doxygen-compatible.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/#review107591
---

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 23, 2015, 1:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39590/
> ---
> 
> (Updated Nov. 23, 2015, 1:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adjusts license headers of C++ source and header files, and 
> protobuf definitions.
> 
> Also, reflect the changed style in the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 678faebc548fa3a7ad60f72075d36b24af5ee744 
>   include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
>   include/mesos/authentication/authenticatee.hpp 
> 17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
>   include/mesos/authentication/authentication.hpp 
> 699aa886286bc7d9c05592e71232ab1c1084871f 
>   include/mesos/authentication/authentication.proto 
> a7db56d643aa01ca2e3cd3e4268bd75b54136727 
>   include/mesos/authentication/authenticator.hpp 
> aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/authorizer/authorizer.proto 
> 86bbb45f9d91b4098a262e3e50a793f3bb39497e 
>   include/mesos/containerizer/containerizer.hpp 
> 9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
>   include/mesos/containerizer/containerizer.proto 
> 7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
>   include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
>   include/mesos/executor/executor.hpp 
> 85f181c72cdb5e80d6c549a4d663d9bad261693a 
>   include/mesos/executor/executor.proto 
> a9243c7a10c32f104c12cbce835bc23a7c75a275 
>   include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
>   include/mesos/fetcher/fetcher.proto 
> 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
>   include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
>   include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
>   include/mesos/maintenance/maintenance.hpp 
> f676d01c2c81250b6e4740ab0934f966b50ed76d 
>   include/mesos/maintenance/maintenance.proto 
> aaca2513e2c30297bf624a831f5aa135f9f47e48 
>   include/mesos/master/allocator.hpp 08e42f31ff347fa12b492713511fbc9cd465ee73 
>   include/mesos/master/allocator.proto 
> 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
>   include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
>   include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
>   include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
>   include/mesos/module/authenticatee.hpp 
> aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
>   include/mesos/module/authenticator.hpp 
> b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
>   include/mesos/module/authorizer.hpp 
> 7d8fc2123ac4132a7a698c855db03433eb77cea6 
>   include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
>   include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
>   include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
>   include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
>   include/mesos/module/qos_controller.hpp 
> 462f07608fb2b580cee9548b5506e9896ee7077a 
>   include/mesos/module/resource_estimator.hpp 
> c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
>   include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/scheduler/scheduler.hpp 
> 30de72b1b535831e074cd132b61e74fec2f4890a 
>   include/mesos/scheduler/scheduler.proto 
> 417cfe6a9bca418b0ef77cb2268fafeb07867819 
>   include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
>   include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
>   include/mesos/slave/oversubscription.hpp 
> ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
>   include/mesos/slave/oversubscription.proto 
> 588316739018a4360d37d64e4bb1655c488b2456 
>   include/mesos/slave/qos_controller.hpp 
> 7e280ccabd153eb10ae72cc48078d660df9f2011 
>   include/mesos/slave/resource_estimator.hpp 
> 731ec3a470dcc8e90199e774d6fcd1d5635be296 
>   include/mesos/type_utils.hpp 1

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39592/#review107593
---

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 23, 2015, 1:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39592/
> ---
> 
> (Updated Nov. 23, 2015, 1:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adjusts license headers of C++ source and header files.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/examples/example.cpp 
> 22ae083d8b5bf59cf52e18405e005cfe94edb81d 
>   3rdparty/libprocess/include/process/address.hpp 
> 7b94979716fed0e2e93967335112835c4b6720a6 
>   3rdparty/libprocess/include/process/async.hpp 
> 676aa4c6849487b2d91b4a2ce458c719396f22f0 
>   3rdparty/libprocess/include/process/authenticator.hpp 
> 78410b42c9551392d4f04a80b6153378c4a26f3f 
>   3rdparty/libprocess/include/process/check.hpp 
> 4b43b704d6a87725bdde040cbc981dd2da1ad709 
>   3rdparty/libprocess/include/process/clock.hpp 
> 1107a329caf77f15901d87808eee72818601510c 
>   3rdparty/libprocess/include/process/collect.hpp 
> 2a8547b939dda08ce1debbf422654fa9f4593125 
>   3rdparty/libprocess/include/process/defer.hpp 
> c9caf58aab58c5ed8b5288a43405f88ba3b19c03 
>   3rdparty/libprocess/include/process/deferred.hpp 
> 00072e014159761c18aa7b21fa15dfdbb95f2271 
>   3rdparty/libprocess/include/process/delay.hpp 
> 65e316e12b96f96058292faa4fc7a7f34c5c1c73 
>   3rdparty/libprocess/include/process/dispatch.hpp 
> c5b8137586113016d702451260c18ff5cfa7c0a2 
>   3rdparty/libprocess/include/process/event.hpp 
> 7b0a8f211da87f996d6345496745c920abfe2f31 
>   3rdparty/libprocess/include/process/executor.hpp 
> 0693e4e362aafe208847651bcf83956c26643de7 
>   3rdparty/libprocess/include/process/filter.hpp 
> db0dfc7ae89245b748337c53e524f3cb352ed301 
>   3rdparty/libprocess/include/process/firewall.hpp 
> b5c7d9976b7a5cbf3cc621559dc361e15059ee67 
>   3rdparty/libprocess/include/process/future.hpp 
> 3916150691e9a0880b8b826734fa74bd33d18cfd 
>   3rdparty/libprocess/include/process/gc.hpp 
> 72fde54ce2f727c89ca49485a0dfee124cb6fc2f 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 575f1ecb3dfbfb7d8f011d408c1e24619406c2b0 
>   3rdparty/libprocess/include/process/gtest.hpp 
> 2ae2a5a16e61304c969c4802990b31beb3964f25 
>   3rdparty/libprocess/include/process/help.hpp 
> 2412db913207b8d6953297870e41a657c742b2a1 
>   3rdparty/libprocess/include/process/http.hpp 
> d718090fe041c23d0040da2eb54da9ecd4ee9151 
>   3rdparty/libprocess/include/process/id.hpp 
> a0bb5dbd93bc7e2f245e012032d54969eefd1d3e 
>   3rdparty/libprocess/include/process/io.hpp 
> 73bf30b97c342632e753658fb1f283aa362ce48b 
>   3rdparty/libprocess/include/process/latch.hpp 
> 8a9d12165ea7442ddc68d20d15c8458b388bb679 
>   3rdparty/libprocess/include/process/limiter.hpp 
> f2efe84212e3a98e5a29e2ec07adc73b5da1ad14 
>   3rdparty/libprocess/include/process/logging.hpp 
> 03fb1bd51e105d0070760af6232dab03e85127d2 
>   3rdparty/libprocess/include/process/message.hpp 
> e9c7e050a771ff88cbec49f5adb37c04138479be 
>   3rdparty/libprocess/include/process/metrics/counter.hpp 
> fd8be32dec79cb5ac372c80fcf4a581c8396c1b5 
>   3rdparty/libprocess/include/process/metrics/gauge.hpp 
> 13934b8c48012a4ef38ba587deb1bce058425ccc 
>   3rdparty/libprocess/include/process/metrics/metric.hpp 
> c5e61df09b06ff13695646eb97c69235a4fe8d56 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 
> f2e84d8e62df58812b660c858eb3b0366db4 
>   3rdparty/libprocess/include/process/metrics/timer.hpp 
> 08f16b89b436eda86418974c5ef16c6ad0e74a5d 
>   3rdparty/libprocess/include/process/mime.hpp 
> decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
>   3rdparty/libprocess/include/process/mutex.hpp 
> 46e25df66325b029cb3e9bbc5e94d66aa5bac4e8 
>   3rdparty/libprocess/include/process/network.hpp 
> 61bfa8243728dc19ab0e6fb43d33ca83fb3709c3 
>   3rdparty/libprocess/include/process/once.hpp 
> cbb18680037bac148d7e915081c484791bd6f892 
>   3rdparty/libprocess/include/process/owned.hpp 
> 1b41477d555ce567c58033f8993dc2ae0ac80a05 
>   3rdparty/libprocess/include/process/pid.hpp 
> e87cfcaf0f93cd9dd0ce7df7299a58fa58982fa7 
>   3rdparty/libprocess/include/process/process.hpp 
> 8b086f296c80a43be2edaf496a04dadf0c64251a 
>   3rdparty/libprocess/include/process/profiler.hpp 
> 4082b8ae579aa11c688da961e126a94d8f121762 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 91b51b0ffbdbe791183afacd3fd16238f3af135e 
>   3rdparty/libprocess/include/process/queue.hpp 
> 7e3538763659dd3ca6c8cd61d17abb3af32bb01b 
>  

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---

(Updated Nov. 23, 2015, 2:53 p.m.)


Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.


Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791


Repository: mesos


Description
---

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Diffs (updated)
-

  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 

Diff: https://reviews.apache.org/r/40424/diff/


Testing
---

Test results:
$ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


Thanks,

Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---

(Updated Nov. 23, 2015, 2:55 p.m.)


Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.


Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791


Repository: mesos


Description
---

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Diffs
-

  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 

Diff: https://reviews.apache.org/r/40424/diff/


Testing (updated)
---

Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}

$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!


Thanks,

Yong Qiao Wang

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107584
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 11:44 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39590: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Nov. 23, 2015, 1:05 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Rebased.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit adjusts license headers of C++ source and header files, and 
protobuf definitions.

Also, reflect the changed style in the C++ style guide.


Diffs (updated)
-

  docs/c++-style-guide.md 678faebc548fa3a7ad60f72075d36b24af5ee744 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authentication.proto 
a7db56d643aa01ca2e3cd3e4268bd75b54136727 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/containerizer/containerizer.proto 
7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/executor/executor.proto 
a9243c7a10c32f104c12cbce835bc23a7c75a275 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/maintenance/maintenance.proto 
aaca2513e2c30297bf624a831f5aa135f9f47e48 
  include/mesos/master/allocator.hpp 08e42f31ff347fa12b492713511fbc9cd465ee73 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9 
  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/oversubscription.proto 
588316739018a4360d37d64e4bb1655c488b2456 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/uri/fetcher.hpp 0d58231eaacac3502e4b02769522bcda441078f4 
  include/mesos/uri/uri.hpp f278480a24152272db5df09f4a7d952b0c6f38cf 
  include/mesos/uri/uri.proto eaa15447571ea164193ce0b15e0c1b36e50cc609 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/executor/executor.proto 
20c712c3f952d3299f2a7c23e185ed588ef13251