Review Request 43033: Cleaned up code style and fixed typos in comments.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43033/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Cleaned up code style and fixed typos in comments.


Diffs
-

  src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 
  src/tests/zookeeper_tests.cpp 0665d916760da7550dae9a85e797cee337a0490d 
  src/zookeeper/group.hpp db8a120e114bea0a22e25114f0795580576ffcca 
  src/zookeeper/group.cpp ded1458a52d899437b53650524501a3fc09600fe 
  src/zookeeper/zookeeper.hpp a29a0049568cc1963bf6727f20791ed467cb8403 

Diff: https://reviews.apache.org/r/43033/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review117153
---



Bad patch!

Reviews applied: [43033, 43034]

Failed command: ./support/apply-review.sh -n -r 43034

Error:
2016-01-31 20:35:12 URL:https://reviews.apache.org/r/43034/diff/raw/ 
[1097/1097] -> "43034.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.

Full log: https://builds.apache.org/job/mesos-reviewbot/11154/console

- Mesos ReviewBot


On Jan. 31, 2016, 8:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Jan. 31, 2016, 8:04 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review117158
---



Bad patch!

Reviews applied: [42781]

Failed command: ./support/apply-review.sh -n -r 42781

Error:
2016-01-31 21:55:19 URL:https://reviews.apache.org/r/42781/diff/raw/ 
[4862/4862] -> "42781.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp:36
error: src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp: patch does 
not apply
error: patch failed: 
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp:206
error: src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp: patch does 
not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11156/console

- Mesos ReviewBot


On Jan. 31, 2016, 8:09 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> ---
> 
> (Updated Jan. 31, 2016, 8:09 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a unit-test to test net_cls major handles set from command line.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 8d101df957fd36adac388310eddba2db1f98c029 
> 
> Diff: https://reviews.apache.org/r/42782/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42586: Defined the NetClsHandleMgr class.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
---

(Updated Jan. 31, 2016, 5:45 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description (updated)
---

This class will be responsible for keeping track of the free and allocated
net_cls handles.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42586/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117149
---


Fix it, then Ship it!





src/common/command_utils.cpp (line 188)


This is problematic to me because 'cmd' will go out of scope (after sha512 
returns). The captured reference here will become a dangling pointer.


- Jie Yu


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> ---
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
> https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp 
> e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> ---
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
---

(Updated Jan. 31, 2016, 8:04 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Avoid interaction between other tests.


Repository: mesos


Description
---

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs (updated)
-

  src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 

Diff: https://reviews.apache.org/r/43035/diff/


Testing
---

`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
--gtest_repeat=4000 --gtest_break_on_failure`

I also verified that if you remove the `delete` of the `GroupProcess`, the test 
fails because the `expired` callback is invoked (the `Clock::settle()` is 
necessary to ensure that this happens).


Thanks,

Neil Conway

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42588/
---

(Updated Jan. 31, 2016, 8:05 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

Added unit-test for `NetClsHandleMgr`.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
8d101df957fd36adac388310eddba2db1f98c029 

Diff: https://reviews.apache.org/r/42588/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 42986: Fixed webui task counts for STARTING/RUNNING tasks.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/
---

(Updated Jan. 31, 2016, 1:37 p.m.)


Review request for mesos, Ben Mahler and Joris Van Remoortere.


Changes
---

Added "Starting" to web-ui task count.


Summary (updated)
-

Fixed webui task counts for STARTING/RUNNING tasks.


Bugs: MESOS-4562
https://issues.apache.org/jira/browse/MESOS-4562


Repository: mesos


Description (updated)
---

The "Starting" and "Running" counts show the number of tasks in
"TASK_STARTING" and "TASK_RUNNING" state respectively.


Diffs (updated)
-

  src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1 
  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 
  src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3 

Diff: https://reviews.apache.org/r/42986/diff/


Testing
---

Launched 100 sleeps tasks and verified the status in webui.


Thanks,

Kapil Arya

Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
---

(Updated Jan. 31, 2016, 8:10 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description
---

The flag takes a uint16_t value that allows operators to specify a major handle
to be used with net_cls cgroup. The default value of this flag is
CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011.


Diffs
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 

Diff: https://reviews.apache.org/r/42781/diff/


Testing
---

Tested the flag by launching a mesos agent and checking that the slave takes 
the `--cgroups_net_cls_major_handles` flag.


Thanks,

Avinash sridharan

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43023/#review117157
---


Fix it, then Ship it!




+ resolution with neil's comments.


3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (line 152)


const?


- Joris Van Remoortere


On Jan. 31, 2016, 4:51 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43023/
> ---
> 
> (Updated Jan. 31, 2016, 4:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4566
> https://issues.apache.org/jira/browse/MESOS-4566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With this patch + https://reviews.apache.org/r/43024/, the number of calls to 
> `operator new` and `operator delete` were reduced by roughly 1/3.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp 
> addec8ec6504e2a8f5b838fce3ebd4db224ab022 
> 
> Diff: https://reviews.apache.org/r/43023/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

[Jie Yu]

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > 
> >
> > On ubuntu, we don't have sha512sum but shasum (and sha512).
> > 
> > Here is what I am thinking:
> > 1) we need to introduce another command util 'which' that searches PATH 
> > and returns the full path to the command (just shelling out to 'which' 
> > command).
> > 2) Then, we use 'which' to check for shasum, sha512sum, etc., and then 
> > use the one that's available.
> 
> haosdent huang wrote:
> which ubuntu version you use, I use ubuntu 14.04. Alos could found 
> `sha512sum` in `/usr/bin/sha512sum`.
> 
> Jojy Varghese wrote:
> I thought `which` will work only if the command is in the path.
> 
> Shuai Lin wrote:
> The command "which" is not avaiable in the `centos:7` image
> 
> ```sh
> $ docker run -it --rm centos:7 which ls
> exec: "which": executable file not found in $PATH
> Error response from daemon: Cannot start container 
> f13beade3abf9139ddad4ec9303a191a7e5a7cc28d011d378c31e59ecf360549: [8] System 
> error: exec: "which": executable file not found in $PATH
> ```
> 
> To get it one need to run "yum install which".
> 
> haosdent huang wrote:
> LoL, seems we should focus on `shasum` and `sha512sum ` command rather 
> than `which`.

OK, sounds good to me. (BTW, we can implement our own os::which which uses 
os::envirionment and os::exists).


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
---


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> ---
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
> https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp 
> e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> ---
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42986: Fixed webui task counts for STARTING/RUNNING tasks.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/
---

(Updated Jan. 31, 2016, 1:41 p.m.)


Review request for mesos, Ben Mahler and Joris Van Remoortere.


Changes
---

Changed "Staged" to "Staging".


Bugs: MESOS-4562
https://issues.apache.org/jira/browse/MESOS-4562


Repository: mesos


Description
---

The "Starting" and "Running" counts show the number of tasks in
"TASK_STARTING" and "TASK_RUNNING" state respectively.


Diffs (updated)
-

  src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1 
  src/webui/master/static/js/controllers.js 
36865f1cd6a4518ba30cd6e64d4d7347762066ec 
  src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3 

Diff: https://reviews.apache.org/r/42986/diff/


Testing
---

Launched 100 sleeps tasks and verified the status in webui.


Thanks,

Kapil Arya

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
---

(Updated Jan. 31, 2016, 8:09 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description
---

Added a unit-test to test net_cls major handles set from command line.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
8d101df957fd36adac388310eddba2db1f98c029 

Diff: https://reviews.apache.org/r/42782/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 43024: Avoid unnecessary string copies in `json` for protobuf messages.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43024/#review117159
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 31, 2016, 12:06 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43024/
> ---
> 
> (Updated Jan. 31, 2016, 12:06 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4566
> https://issues.apache.org/jira/browse/MESOS-4566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 6d7d033884cc6ed451e25bfc4638ac9186bbbcf5 
> 
> Diff: https://reviews.apache.org/r/43024/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117148
---



Patch looks great!

Reviews applied: [43032]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 31, 2016, 3:22 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated Jan. 31, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/docker_tests.cpp 
> f0ad20e5a8252ad761e8fa42724caed31b8fae9d 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117151
---



Patch looks great!

Reviews applied: [43014]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 31, 2016, 6:21 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> ---
> 
> (Updated Jan. 31, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
> https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp 
> e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> ---
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42588/
---

(Updated Jan. 31, 2016, 6:04 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

Added unit-test for `NetClsHandleMgr`.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
8d101df957fd36adac388310eddba2db1f98c029 

Diff: https://reviews.apache.org/r/42588/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 42543: Updated `json` to handle integral types comprehensively.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42543/#review117155
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 20, 2016, 5:04 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42543/
> ---
> 
> (Updated Jan. 20, 2016, 5:04 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4435
> https://issues.apache.org/jira/browse/MESOS-4435
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp 
> a87b9e2ade68eabd8560470b211a4703f3183d73 
> 
> Diff: https://reviews.apache.org/r/42543/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42546/
---

(Updated Jan. 31, 2016, 9:44 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4435
https://issues.apache.org/jira/browse/MESOS-4435


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/http.cpp 34a70ee50553492fc8c3947497ab5922f4379d72 

Diff: https://reviews.apache.org/r/42546/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42546/#review117156
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 31, 2016, 9:44 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42546/
> ---
> 
> (Updated Jan. 31, 2016, 9:44 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4435
> https://issues.apache.org/jira/browse/MESOS-4435
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 34a70ee50553492fc8c3947497ab5922f4379d72 
> 
> Diff: https://reviews.apache.org/r/42546/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42587/
---

(Updated Jan. 31, 2016, 5:56 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

Implemented the `NetClsHandleMgr` class.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42587/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/
---

(Updated Jan. 31, 2016, 6:21 p.m.)


Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.


Changes
---

Address @jieyu's comment.


Bugs: MESOS-4556
https://issues.apache.org/jira/browse/MESOS-4556


Repository: mesos


Description
---

Fix ShasumTest.SHA512SimpleFile failed on centos7.


Diffs (updated)
-

  src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
  src/tests/common/command_utils_tests.cpp 
e81c724fc28717f5cb1849d75a066b6da713cd44 

Diff: https://reviews.apache.org/r/43014/diff/


Testing
---

# check in CentOS 7.
sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"


Thanks,

haosdent huang

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42780/
---

(Updated Jan. 31, 2016, 8:07 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

Changed the NetClsIsolatorTest to check for net_cls handles.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
8d101df957fd36adac388310eddba2db1f98c029 

Diff: https://reviews.apache.org/r/42780/diff/


Testing
---

make and make check


Thanks,

Avinash sridharan

Re: Review Request 42586: Defined the NetClsHandleMgr class.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117171
---




src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 37 - 38)


Add a blank line here



src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 44)


s/issue/issues



src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (lines 88 - 89)


"A net_cls handle is composed of a 16-bit major and a 16-bit minor handle." 
This was already mentioned above for `NetClsHandle`


- Guangya Liu


On 一月 31, 2016, 5:45 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> ---
> 
> (Updated 一月 31, 2016, 5:45 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b4bc52114389d1c1efce2830f4292bd89bb0de7c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
> 
> Diff: https://reviews.apache.org/r/42586/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42586: Defined the NetClsHandleMgr class.

[Avinash sridharan]

> On Feb. 1, 2016, 1:46 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 44
> > 
> >
> > s/issue/issues

Thanks for catching this.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/#review117171
---


On Jan. 31, 2016, 5:45 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42586/
> ---
> 
> (Updated Jan. 31, 2016, 5:45 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This class will be responsible for keeping track of the free and allocated
> net_cls handles.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b4bc52114389d1c1efce2830f4292bd89bb0de7c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
> 
> Diff: https://reviews.apache.org/r/42586/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42993: [2 of 7] Support for multiple frameworks sharing the same resource.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42993/#review117177
---



It is better add some unit tests in `hierarchical_allocator_tests.cpp` to cover 
the update in allocator for shareable resources.

- Guangya Liu


On 一月 30, 2016, 12:26 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42993/
> ---
> 
> (Updated 一月 30, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The allocator tracks allocated shared resources separately from the
> remaining allocated resources so that multiple frameworks see the
> same view of the shared resource at any given time.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1a07d69016407e5aad2209586da37fecbcddb765 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 4669149b81de39b4bb921ef7cd6787aa583f6e40 
>   src/master/allocator/sorter/drf/sorter.cpp 
> db47d640e36c0302d7c6254a9c58caa878feac01 
>   src/master/allocator/sorter/sorter.hpp 
> a0a779b81f6d048271f15256b38ff907ae144b83 
>   src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 
> 
> Diff: https://reviews.apache.org/r/42993/diff/
> 
> 
> Testing
> ---
> 
> make check done.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Review Request 43039: Updated the release guide to include the link to the Apache repository.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43039/
---

Review request for mesos, Kapil Arya and Timothy Chen.


Repository: mesos


Description
---

See summary.


Diffs
-

  docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9 

Diff: https://reviews.apache.org/r/43039/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42516: Add support for user-defined networks.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review117168
---




src/docker/docker.cpp (lines 517 - 522)


The user network was introduced in docker 1.9, is it possible to add some 
error handlingn here to handle the case if end user is using docker version 
before 1.9?


- Guangya Liu


On 一月 27, 2016, 7:05 a.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated 一月 27, 2016, 7:05 a.m.)
> 
> 
> Review request for mesos and TimothyIL TimothyIL.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117166
---




src/docker/docker.cpp (lines 535 - 536)


one line



src/tests/containerizer/docker_tests.cpp (lines 105 - 106)


What about adding one more label without value but only key?


- Guangya Liu


On 一月 31, 2016, 3:22 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated 一月 31, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/docker_tests.cpp 
> f0ad20e5a8252ad761e8fa42724caed31b8fae9d 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 42516: Add support for user-defined networks.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review117169
---



BTW: I think that you meant to have tim Chen as shephard, his id is tnachen, 
you may want to update the shephard for this.

- Guangya Liu


On 一月 27, 2016, 7:05 a.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated 一月 27, 2016, 7:05 a.m.)
> 
> 
> Review request for mesos and TimothyIL TimothyIL.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 42586: Defined the NetClsHandleMgr class.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
---

(Updated Feb. 1, 2016, 2:20 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

This class will be responsible for keeping track of the free and allocated
net_cls handles.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42586/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review117165
---


Ship it!




Ship It!

- Till Toenshoff


On Jan. 25, 2016, 2:35 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> ---
> 
> (Updated Jan. 25, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
> https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> Also aline the name of the launch result to follow the canonical
> scheme.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42546/
---

(Updated Feb. 1, 2016, 4:07 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Rebased.


Bugs: MESOS-4435
https://issues.apache.org/jira/browse/MESOS-4435


Repository: mesos


Description (updated)
---

Updated `Master::Http::stateSummary` to use `jsonify`.


Diffs (updated)
-

  src/master/http.cpp 04225366b49bba917485c75830133bd9641ab594 

Diff: https://reviews.apache.org/r/42546/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 43039: Updated the release guide to include the link to the Apache repository.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43039/#review117182
---


Ship it!




Ship It!

- Kapil Arya


On Jan. 31, 2016, 10:57 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43039/
> ---
> 
> (Updated Jan. 31, 2016, 10:57 p.m.)
> 
> 
> Review request for mesos, Kapil Arya and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9 
> 
> Diff: https://reviews.apache.org/r/43039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43023: Avoid construction of temporary strings in `NumberWriter` for doubles.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43023/
---

(Updated Feb. 1, 2016, 5:14 a.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Changes
---

Addressed Neil and Joris' comments.


Bugs: MESOS-4566
https://issues.apache.org/jira/browse/MESOS-4566


Repository: mesos


Description (updated)
---

With this + https://reviews.apache.org/r/43024/, the number of calls to
`operator new` and `operator delete` were reduced by roughly 1/3.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp 
f9d72243bcd5ae951ae1837fef0842915ff1e896 

Diff: https://reviews.apache.org/r/43023/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 42992: [1 of 7] Support sharing of resources through reference counting of resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42992/#review117100
---




src/master/master.hpp (lines 127 - 138)


add some comments here;

if the shared resources is new added, then add it to totalResources; If the 
shared resources was already used in totalResources, just increase the 
reference by num consumers.



src/master/master.hpp (lines 163 - 176)


Ditto, add more comments here.



src/master/master.hpp (line 282)


Is it an old bug? I think that we should make sure that the task is in 
terminate state here?



src/master/master.hpp (line 1865)


Same question as above, is it a bug?



src/master/master.cpp (line 3700)


Even though this should never happen, we still should add more detailed 
info here, such as offer, shared resource info in the log message here.



src/master/master.cpp (line 3745)


remove the //



src/master/master.cpp (line 3764)


add some log here to tell how many resoruces are returning to allocator?



src/master/master.cpp (lines 5444 - 5445)


move this comments to 5452


- Guangya Liu


On 一月 30, 2016, 12:26 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42992/
> ---
> 
> (Updated 一月 30, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Added new Offer::Operation of SHARE and UNSHARE for resources.
> * Added ShareInfo within Resources protobuf to allow for sharing of resources
>   and keep track of consumers of such resources.
> * Allow DESTROY or UNSHARE for shared volumes only if reference count is 0.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/resources.hpp 6bfac2e7e8799e74d87c7570fc5eef320ba76eb1 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
>   include/mesos/v1/resources.hpp 5a88c0756db2ea8db0f5df7ea3019b511ea135af 
>   src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
>   src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1a07d69016407e5aad2209586da37fecbcddb765 
>   src/master/allocator/sorter/drf/sorter.cpp 
> db47d640e36c0302d7c6254a9c58caa878feac01 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
>   src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 
>   src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
>   src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07 
>   src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 
> 
> Diff: https://reviews.apache.org/r/42992/diff/
> 
> 
> Testing
> ---
> 
> make check done.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 42543: Updated `json` to handle integral types comprehensively.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42543/
---

(Updated Feb. 1, 2016, 4:06 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Fixed style issues.


Bugs: MESOS-4435
https://issues.apache.org/jira/browse/MESOS-4435


Repository: mesos


Description (updated)
---

Updated `json` to handle integral types comprehensively.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp 
addec8ec6504e2a8f5b838fce3ebd4db224ab022 

Diff: https://reviews.apache.org/r/42543/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

[Shuai Lin]

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > 
> >
> > On ubuntu, we don't have sha512sum but shasum (and sha512).
> > 
> > Here is what I am thinking:
> > 1) we need to introduce another command util 'which' that searches PATH 
> > and returns the full path to the command (just shelling out to 'which' 
> > command).
> > 2) Then, we use 'which' to check for shasum, sha512sum, etc., and then 
> > use the one that's available.
> 
> haosdent huang wrote:
> which ubuntu version you use, I use ubuntu 14.04. Alos could found 
> `sha512sum` in `/usr/bin/sha512sum`.
> 
> Jojy Varghese wrote:
> I thought `which` will work only if the command is in the path.

The command "which" is not avaiable in the `centos:7` image

```sh
$ docker run -it --rm centos:7 which ls
exec: "which": executable file not found in $PATH
Error response from daemon: Cannot start container 
f13beade3abf9139ddad4ec9303a191a7e5a7cc28d011d378c31e59ecf360549: [8] System 
error: exec: "which": executable file not found in $PATH
```

To get it one need to run "yum install which".


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
---


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> ---
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
> https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp 
> e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> ---
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43014: Fix ShasumTest.SHA512SimpleFile failed on centos7.

[haosdent huang]

> On Jan. 30, 2016, 5:11 p.m., Jie Yu wrote:
> > src/common/command_utils.cpp, line 172
> > 
> >
> > On ubuntu, we don't have sha512sum but shasum (and sha512).
> > 
> > Here is what I am thinking:
> > 1) we need to introduce another command util 'which' that searches PATH 
> > and returns the full path to the command (just shelling out to 'which' 
> > command).
> > 2) Then, we use 'which' to check for shasum, sha512sum, etc., and then 
> > use the one that's available.
> 
> haosdent huang wrote:
> which ubuntu version you use, I use ubuntu 14.04. Alos could found 
> `sha512sum` in `/usr/bin/sha512sum`.
> 
> Jojy Varghese wrote:
> I thought `which` will work only if the command is in the path.
> 
> Shuai Lin wrote:
> The command "which" is not avaiable in the `centos:7` image
> 
> ```sh
> $ docker run -it --rm centos:7 which ls
> exec: "which": executable file not found in $PATH
> Error response from daemon: Cannot start container 
> f13beade3abf9139ddad4ec9303a191a7e5a7cc28d011d378c31e59ecf360549: [8] System 
> error: exec: "which": executable file not found in $PATH
> ```
> 
> To get it one need to run "yum install which".

LoL, seems we should focus on `shasum` and `sha512sum ` command rather than 
`which`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43014/#review117112
---


On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43014/
> ---
> 
> (Updated Jan. 30, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone.
> 
> 
> Bugs: MESOS-4556
> https://issues.apache.org/jira/browse/MESOS-4556
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ShasumTest.SHA512SimpleFile failed on centos7.
> 
> 
> Diffs
> -
> 
>   src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 
>   src/tests/common/command_utils_tests.cpp 
> e81c724fc28717f5cb1849d75a066b6da713cd44 
> 
> Diff: https://reviews.apache.org/r/43014/diff/
> 
> 
> Testing
> ---
> 
> # check in CentOS 7.
> sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117147
---




src/docker/docker.cpp (line 533)


Do we need check docker version? Because I remember after 1.6.0, docker 
container starting support labels.



src/tests/containerizer/docker_tests.cpp (line 122)


Do you need verify this in inspect result?


- haosdent huang


On Jan. 31, 2016, 3:22 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated Jan. 31, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/docker_tests.cpp 
> f0ad20e5a8252ad761e8fa42724caed31b8fae9d 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 43032: Set Docker labels based on TaskInfo labels.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/
---

Review request for mesos and Guangya Liu.


Bugs: MESOS-4446
https://issues.apache.org/jira/browse/MESOS-4446


Repository: mesos


Description
---

Set Docker labels based on TaskInfo labels.


Diffs
-

  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
  src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
  src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
  src/tests/containerizer/docker_containerizer_tests.cpp 
645bdcf095145097d8b8c65d592c787417883145 
  src/tests/containerizer/docker_tests.cpp 
f0ad20e5a8252ad761e8fa42724caed31b8fae9d 
  src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
  src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 

Diff: https://reviews.apache.org/r/43032/diff/


Testing
---

The following test cases in docker_tests have been changed:
DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
docker run command through arguments.


Thanks,

Abhishek Dasgupta