Review Request 50738: Improved performance in addition and subtraction of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50738/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-5978
https://issues.apache.org/jira/browse/MESOS-5978


Repository: mesos


Description
---

Avoid multiple calls to addable and subtractable in the arithmetic
operations in Resources. While adding or subtracting two Resources
objects, check for addable() is done in Resources::add(), and check
for subtractable() is done in Resources::subtract(). Since the
Resource_ class is private and += and -= operators are only called
from within Resources::add() and Resources::subtract(); so we do not
need to call addable() or subtractable() again.

This improves the performance of += and -= operators by about 25%.


Diffs
-

  include/mesos/resources.hpp 829f39d7c1af3eb4e2efd97e01f87acf7c854bb4 
  include/mesos/v1/resources.hpp f3c5f315c3701e37aeb8fd468ee288829461338e 
  src/common/resources.cpp b5d20d699553cb5e0aae1718d8a5d73e9192f10a 
  src/v1/resources.cpp 71eedb29ccacfbd616f5088890d759ab669f8ce7 

Diff: https://reviews.apache.org/r/50738/diff/


Testing
---

Tests ok. Ran the benchmark for resources arithmetic and observed about 30% 
improvement in arithmetic operations for scalars.

HEAD


[==] Running 4 tests from 1 test case.
[--] Global test environment set-up.
[--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
Took 73155us to perform 5 'total += r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 78983us to perform 5 'total -= r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 294658us to perform 5 'total = total + r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 302820us to perform 5 'total = total - r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (752 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
Took 4.171325secs to perform 10 'total += r' operations on cpus(0, principal_0, 
{key_0: value_0}):1; gpus(...
Took 4.320892secs to perform 10 'total -= r' operations on cpus(0, principal_0, 
{key_0: value_0}):1; gpus(...
Took 4.239706secs to perform 10 'total = total + r' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
Took 4.413952secs to perform 10 'total = total - r' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17196 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
Took 475848us to perform 1000 'total += r' operations on ports(*):[1-2, 4-5, 
7-8, 10-11, 13-14, 16-17, 1...
Took 2270us to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 7-8, 
10-11, 13-14, 16-17, 1...
Took 562153us to perform 1000 'total = total + r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 2357us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (1044 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3
Took 60524us to perform 5 'total += r' operations on cpus(*):1; mem(*):128; 
disk(test)[persistentId:...
Took 64486us to perform 5 'total -= r' operations on cpus(*):1; mem(*):128; 
disk(test)[persistentId:...
Took 343349us to perform 5 'total = total + r' operations on cpus(*):1; 
mem(*):128; disk(test)[persistentId:...
Took 342624us to perform 5 'total = total - r' operations on cpus(*):1; 
mem(*):128; disk(test)[persistentId:...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3 (812 ms)
[--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test (19804 ms 
total)

[--] Global test environment tear-down
[==] 4 tests from 1 test case ran. (19820 ms total)
[  PASSED  ] 4 tests.

With this patch
===

[==] Running 4 tests from 1 test case.
[--] Global test environment set-up.
[--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
Took 53892us to perform 5 'total += r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 59655us to perform 5 'total -= r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 268692us to perform 5 'total = total + r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 266523us to perform 5 'total = total - r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (649 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Ari

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144591
---



Patch looks great!

Reviews applied: [50723]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 2, 2016, 9:45 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 2, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/#review144596
---



Patch looks great!

Reviews applied: [50570, 50609]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 2, 2016, 11:04 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50609/
> ---
> 
> (Updated Aug. 2, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Pierre Cheynier.
> 
> 
> Bugs: MESOS-5928
> https://issues.apache.org/jira/browse/MESOS-5928
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The recent removal of the agent's default `work_dir`
> requires us to check for the presence of the `--version`
> flag before we check for errors in flag loading; this
> patch makes that change, and also moves the
> corresponding code in the master for consistency.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
>   src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 
> 
> Diff: https://reviews.apache.org/r/50609/diff/
> 
> 
> Testing
> ---
> 
> Ran the mesos agent and master binaries with and without the '--version' flag 
> to verify correct behavior and return code.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50733/#review144604
---



Patch looks great!

Reviews applied: [49819, 49820, 49821, 49823, 49824, 49825, 49827, 50627, 
50642, 50643, 49817, 49828, 49849, 49850, 49851, 49852, 45573, 49853, 49854, 
49855, 50733]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 2:20 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50733/
> ---
> 
> (Updated Aug. 3, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5973
> https://issues.apache.org/jira/browse/MESOS-5973
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsCpushareIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
>   src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 
> 74982a610b6c0a74734165a0c6aa8c9f72f54deb 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
> 4f0a43b9d8b0d04a8e3e11b1a11688d4fa93 
>   src/tests/containerizer/isolator_tests.cpp 
> 488747347f71a6a1bb6bc01477143d077d4fd3eb 
> 
> Diff: https://reviews.apache.org/r/50733/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50513: Added missing process IDs in libprocess.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50513/#review144599
---




3rdparty/libprocess/include/process/collect.hpp (line 136)


We are already in `process::`, right?



3rdparty/libprocess/src/process.cpp (line 1179)


I'll move this change to https://reviews.apache.org/r/50637



3rdparty/libprocess/src/process.cpp (line 3347)


I'll move this change to https://reviews.apache.org/r/50637


- Alexander Rukletsov


On Aug. 2, 2016, 1:45 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50513/
> ---
> 
> (Updated Aug. 2, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After this change, all libprocess actors should have a distinguishable
> ID, making it possible to match the logging output or the output of
> the "__process__" enpoint to the source actor.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> 5a92b72eb7668494dc832ec446a41b3d673a20cc 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 78ff40ed64c4313dd9daddcf96e1447ad015c734 
>   3rdparty/libprocess/include/process/run.hpp 
> d141fb0f5f71e24d1652a11dbaa6d2b7c5b70f5f 
>   3rdparty/libprocess/src/authenticator.cpp 
> 55e8558a5272cb0447ad9268ad9c7f27e2f30385 
>   3rdparty/libprocess/src/process.cpp 
> 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/50513/diff/
> 
> 
> Testing
> ---
> 
> `make check` in OS X and various linux distribution.
> 
> I also looked at the output of the `__process__` endpoint. After this change, 
> some of the unidentifiable processes have a nicer id now. The goal of this 
> review chain is to give all processes there an identifiable ID.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50637: Added id to the libprocess Sequence constructor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50637/#review144606
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:42 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50637/
> ---
> 
> (Updated Aug. 2, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sequence IDs used to follow the following schema; "(1)", "(2)", etc.
> This made it very hard to match the output from logging or the
> "__processes__" endpoint to them.
> 
> This change makes it possible to give sequence processes a
> distinguishable ID.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/sequence.hpp 
> 78ccdb95422d0f7e12f1d66b4456c4f0014f4ffe 
> 
> Diff: https://reviews.apache.org/r/50637/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50513: Added missing process IDs in libprocess.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50513/#review144607
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:45 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50513/
> ---
> 
> (Updated Aug. 2, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After this change, all libprocess actors should have a distinguishable
> ID, making it possible to match the logging output or the output of
> the "__process__" enpoint to the source actor.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> 5a92b72eb7668494dc832ec446a41b3d673a20cc 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 78ff40ed64c4313dd9daddcf96e1447ad015c734 
>   3rdparty/libprocess/include/process/run.hpp 
> d141fb0f5f71e24d1652a11dbaa6d2b7c5b70f5f 
>   3rdparty/libprocess/src/authenticator.cpp 
> 55e8558a5272cb0447ad9268ad9c7f27e2f30385 
>   3rdparty/libprocess/src/process.cpp 
> 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/50513/diff/
> 
> 
> Testing
> ---
> 
> `make check` in OS X and various linux distribution.
> 
> I also looked at the output of the `__process__` endpoint. After this change, 
> some of the unidentifiable processes have a nicer id now. The goal of this 
> review chain is to give all processes there an identifiable ID.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50515: Added missing process IDs.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50515/#review144603
---


Fix it, then Ship it!




I'll fix the outstanding issues and will commit shortly.


src/slave/containerizer/mesos/containerizer.hpp (lines 303 - 304)


Fits one line.



src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (line 55)


oops?



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 154)


oops I did it again?


- Alexander Rukletsov


On Aug. 2, 2016, 1:47 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50515/
> ---
> 
> (Updated Aug. 2, 2016, 1:47 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After this change, all actors should have a distinguishable ID, making
> it possible to match the logging output or the output of the
> "__process__" enpoint to the source actor.
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp f4063d398838d99d8c055447cd411124cfb9985f 
>   src/exec/exec.cpp 90a16a90410027969adf93091bcce253a98d 
>   src/linux/cgroups.cpp 610857a436e07e0f2f4629d3a389e90fa31cc258 
>   src/linux/perf.cpp ea823b32edaa82a71cbfac9932aae543c0d7bef4 
>   src/linux/routing/link/link.cpp 96bd50e245ef7e29d4767ba0871e0ac4abad55a0 
>   src/slave/container_loggers/logrotate.cpp 
> b863d931b08992ea9e94a7e6837b44cfc94ae8f1 
>   src/slave/container_loggers/sandbox.cpp 
> 00272f82de9a6257d8654b36085b3427c18e81ec 
>   src/slave/containerizer/composing.cpp 
> 15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 3274e09f66b53cb67b6a20c88faa4c1e45569b22 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
> e8fe131e355796d450dd4d823a6be4e4e4ec4506 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> c304e2a896d1d8ae085914c0fd7e6326fd68ad2d 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
> 4f0a43b9d8b0d04a8e3e11b1a11688d4fa93 
>   src/slave/containerizer/mesos/isolators/cgroups/devices.cpp 
> 66db4fc7253094a2691ead3a5621f186b59c1f21 
>   src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
> af8d1654a47b3ce50878c69b6f9aad053d3055e6 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> 2665b022260b9228d4d34f030feb0d2f5de54bb3 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 1de38491a33e5782b20e5ee491412779d09ee391 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 5af0ae93526af41ec54263fd44b5c2b55a7011a4 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> d10c424b48cb2ff974c49f91dd75805859ec39ef 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ed7366aeeed6646b74f2087fd00449c70dd16e82 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 0809e8ec35232fbdafee171a7a960cbdec272134 
>   src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
> 51d15186bd5005e2e069d68907a9e3969eb65ebb 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> 0bee68bea363d53978d82db2f85ee16744580bc9 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> c7e8cf0ec3ff10e9d5ddd218b0e33ed1e8195b68 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 
> 4e0dcd11067e0b05338f7c61e11840b7004ecbc9 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 527c579bb80bb0a02ca4ff16d1b1d94823d0dea0 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> 21a86e3087bea46a2d2125e53292251243086554 
>   src/slave/containerizer/mesos/isolators/posix.hpp 
> e5cee9c6a77ade1a48b056c981ad23edee56969d 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 3dfe7ad4477dd1a6c8585bf761eaf435fd0cb366 
>   src/slave/containerizer/mesos/isolators/windows.hpp 
> aec331663a58b17fac0396e2d17df7a28e1ee164 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 19e55111edc0bf80a14fb7b2dade120b4432de53 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> c27b1b5ca05a5883831c86575ac129903e758598 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp 
> 54c005764c4aa84af2606b69e5f5f10db61fab80 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> af9544e2eaef754a7cf4cbb865c1e0a054f01d7f 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> b9f6d7a5d5ee341d7e3ac2663a8d2a5fc4746096 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> e3d8

Re: Review Request 50519: Made libprocess Actor IDs consistent.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50519/#review144608
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:50 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50519/
> ---
> 
> (Updated Aug. 2, 2016, 1:50 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enforced the following actor ID schema in libprocess:
> 
> - Actor IDs contain only lowercase characters, dashes or underscores.
> - The ID of an actor that is exposed to libprocess users, via a route/
>   associated to an endpoint uses dashes as word separator, e.g., `help`.
> - The ID of an actor internal to libprocess, with not associated
>   route/endpoint, must be enclosed in double quotes and use underscores
>   instead of dashes as word separator, e.g.,
>   `__authentication_router__`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/authenticator_manager.cpp 
> 7def832147df01ed51e642f8baf1216590745fdf 
>   3rdparty/libprocess/src/reap.cpp ac60c6d769076912293950432266c956d6c7e705 
> 
> Diff: https://reviews.apache.org/r/50519/diff/
> 
> 
> Testing
> ---
> 
> `make check` in OS X and various linux distribution, checked the output of 
> `__processes__`.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50639: Made all Actor IDs outside of libprocess follow the same schema.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50639/#review144609
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:54 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50639/
> ---
> 
> (Updated Aug. 2, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made all Actor IDs contain only lower case letters and dashes (not
> underscores).
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 236de252192c4875eb76bc91e9aea1df331bcad7 
>   src/authentication/cram_md5/authenticator.cpp 
> 4ec15680b236704c89c9c8b24758797ea6a3dd03 
>   src/executor/v0_v1executor.cpp cd1c59016590383b9b57f14da54165b75b441883 
> 
> Diff: https://reviews.apache.org/r/50639/diff/
> 
> 
> Testing
> ---
> 
> `make check` in OS X and various linux distribution, checked the output of 
> `__processes__`.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50563: Made HierarchicalAllocatorProcess specify a process ID.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50563/#review144611
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:55 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50563/
> ---
> 
> (Updated Aug. 2, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> I had to move the initialization of ProcessBase to the public
> HierarchicalAllocatorProcess constructor. The ID would otherwise get
> lost, leading to an undistinguishable ID.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> b72ba16277a3210e4d309b616d185a10e2029a66 
> 
> Diff: https://reviews.apache.org/r/50563/diff/
> 
> 
> Testing
> ---
> 
> `make check` in OS X and various linux distributions, checked the output of 
> `__processes__`.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50521: Added "zookeeper" prefix to ZK process IDs.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50521/#review144610
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:55 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50521/
> ---
> 
> (Updated Aug. 2, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added "zookeeper" prefix to ZK process IDs.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/contender.cpp 320658182c85d333539be3c20534ad889a2ce99e 
>   src/zookeeper/detector.cpp f1def68740e4941a5daa3a889bc14278d7ea7366 
>   src/zookeeper/group.cpp 7438eccf285ad2ab6462c0bb091966179d6906d5 
> 
> Diff: https://reviews.apache.org/r/50521/diff/
> 
> 
> Testing
> ---
> 
> `make check` in OS X and various linux distribution.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50738: Improved performance in addition and subtraction of resources.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50738/#review144612
---



Patch looks great!

Reviews applied: [50738]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 7:36 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50738/
> ---
> 
> (Updated Aug. 3, 2016, 7:36 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5978
> https://issues.apache.org/jira/browse/MESOS-5978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoid multiple calls to addable and subtractable in the arithmetic
> operations in Resources. While adding or subtracting two Resources
> objects, check for addable() is done in Resources::add(), and check
> for subtractable() is done in Resources::subtract(). Since the
> Resource_ class is private and += and -= operators are only called
> from within Resources::add() and Resources::subtract(); so we do not
> need to call addable() or subtractable() again.
> 
> This improves the performance of += and -= operators by about 25%.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 829f39d7c1af3eb4e2efd97e01f87acf7c854bb4 
>   include/mesos/v1/resources.hpp f3c5f315c3701e37aeb8fd468ee288829461338e 
>   src/common/resources.cpp b5d20d699553cb5e0aae1718d8a5d73e9192f10a 
>   src/v1/resources.cpp 71eedb29ccacfbd616f5088890d759ab669f8ce7 
> 
> Diff: https://reviews.apache.org/r/50738/diff/
> 
> 
> Testing
> ---
> 
> Tests ok. Ran the benchmark for resources arithmetic and observed about 30% 
> improvement in arithmetic operations for scalars.
> 
> HEAD
> 
> 
> [==] Running 4 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
> Took 73155us to perform 5 'total += r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 78983us to perform 5 'total -= r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 294658us to perform 5 'total = total + r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 302820us to perform 5 'total = total - r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (752 ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
> Took 4.171325secs to perform 10 'total += r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 4.320892secs to perform 10 'total -= r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 4.239706secs to perform 10 'total = total + r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 4.413952secs to perform 10 'total = total - r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17196 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> Took 475848us to perform 1000 'total += r' operations on ports(*):[1-2, 4-5, 
> 7-8, 10-11, 13-14, 16-17, 1...
> Took 2270us to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 
> 7-8, 10-11, 13-14, 16-17, 1...
> Took 562153us to perform 1000 'total = total + r' operations on 
> ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 2357us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (1044 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3
> Took 60524us to perform 5 'total += r' operations on cpus(*):1; 
> mem(*):128; disk(test)[persistentId:...
> Took 64486us to perform 5 'total -= r' operations on cpus(*):1; 
> mem(*):128; disk(test)[persistentId:...
> Took 343349us to perform 5 'total = total + r' operations on cpus(*):1; 
> mem(*):128; disk(test)[persistentId:...
> Took 342624us to perform 5 'total = total - r' operations on cpus(*):1; 
> mem(*):128; disk(test)[persistentId:...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3 (812 ms)
> [--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test (19804 
> ms total)
> 
> [--] Global test environment tear-down
> [==] 4 tests from 1 test case ran. (19820 ms total)
> [  PASSED  ] 4 tests.
> 
> With this patch
> ===
> 
> [==] Running 4 tes

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review144598
---




include/mesos/v1/mesos.proto (line 339)


Marathon does the following for health checks:

> A health check is considered passing ifits HTTP response code is between 
200 and 399, inclusive.

What do you think about adopting this as the default behaviour and later 
adding support for specifying healthy/unhealthy response code ranges?



src/health-check/health_checker.hpp (lines 283 - 284)


We should also document if libprocess validates the certificate or not.

If it does try to validate the certificate, then using `localhost` for the 
domain might be a problem.


- Gastón Kleiman


On Aug. 1, 2016, 1:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> ---
> 
> (Updated Aug. 1, 2016, 1:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
> Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported HTTP/HTTPS in health check.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 590e169108b2ce5881734ec7f4b01cef9937461a 
>   include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> ---
> 
> * Add unit test cases: HealthCheckTest.HealthyTaskViaHttp and 
> HealthCheckTest.HealthyTaskNotMatchHttpStatuses
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49360: Supported TCP check in health check.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49360/#review144613
---




src/health-check/health_checker.hpp (line 316)


s/health TCP check/TCP health check/



src/health-check/health_checker.hpp (line 322)


I'd change the message to: "Failed to resolve host name"



src/health-check/health_checker.cpp (lines 56 - 72)


This can be simplified if you used the "union trick" suggested by AlexR in 
https://reviews.apache.org/r/36816


- Gastón Kleiman


On Aug. 1, 2016, 1:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49360/
> ---
> 
> (Updated Aug. 1, 2016, 1:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
> Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3567
> https://issues.apache.org/jira/browse/MESOS-3567
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported TCP check in health check.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 590e169108b2ce5881734ec7f4b01cef9937461a 
>   include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 
> 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/49360/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 50748: Removed CgroupsMemIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50748/
---

Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5974
https://issues.apache.org/jira/browse/MESOS-5974


Repository: mesos


Description
---

Removed CgroupsMemIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 
b3ce6ed2505312bdd2d800164c2f57cd7625c9fa 
  src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
af8d1654a47b3ce50878c69b6f9aad053d3055e6 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50748/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50749/
---

Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5975
https://issues.apache.org/jira/browse/MESOS-5975


Repository: mesos


Description
---

Removed CgroupsDevicesIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/devices.hpp 
7ad96440b21a380c5d9af27b0168e9abf47769af 
  src/slave/containerizer/mesos/isolators/cgroups/devices.cpp 
66db4fc7253094a2691ead3a5621f186b59c1f21 

Diff: https://reviews.apache.org/r/50749/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
2665b022260b9228d4d34f030feb0d2f5de54bb3 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50751/
---

Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5977
https://issues.apache.org/jira/browse/MESOS-5977


Repository: mesos


Description
---

Removed CgroupsPerfEventIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
1de38491a33e5782b20e5ee491412779d09ee391 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
31f35385691681ef5da14be747edfb5f57c5d05a 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50751/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50751/#review144614
---



Bad patch!

Reviews applied: [50751, 50750, 50749, 50748, 50733, 49855, 49854, 49853, 
45573, 49852, 49851, 49850, 49849, 49828, 49817, 50643, 50642, 50627, 49827, 
49825, 49824, 49823, 49821, 49820, 49819]

Failed command: ./support/apply-review.sh -n -r 45573

Error:
2016-08-03 14:34:44 URL:https://reviews.apache.org/r/45573/diff/raw/ 
[11640/11640] -> "45573.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp:19
error: src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp: patch 
does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14615/console

- Mesos ReviewBot


On Aug. 3, 2016, 2:33 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50751/
> ---
> 
> (Updated Aug. 3, 2016, 2:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5977
> https://issues.apache.org/jira/browse/MESOS-5977
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsPerfEventIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 1de38491a33e5782b20e5ee491412779d09ee391 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
> 31f35385691681ef5da14be747edfb5f57c5d05a 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
>   src/tests/containerizer/isolator_tests.cpp 
> 488747347f71a6a1bb6bc01477143d077d4fd3eb 
> 
> Diff: https://reviews.apache.org/r/50751/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50749/
---

(Updated Aug. 3, 2016, 2:35 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5977
https://issues.apache.org/jira/browse/MESOS-5977


Repository: mesos


Description
---

Removed CgroupsDevicesIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/devices.hpp 
7ad96440b21a380c5d9af27b0168e9abf47769af 
  src/slave/containerizer/mesos/isolators/cgroups/devices.cpp 
66db4fc7253094a2691ead3a5621f186b59c1f21 

Diff: https://reviews.apache.org/r/50749/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50751/
---

(Updated Aug. 3, 2016, 2:36 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5975
https://issues.apache.org/jira/browse/MESOS-5975


Repository: mesos


Description
---

Removed CgroupsPerfEventIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
1de38491a33e5782b20e5ee491412779d09ee391 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
31f35385691681ef5da14be747edfb5f57c5d05a 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50751/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49736: Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49736/
---

(Updated Aug. 3, 2016, 9:21 a.m.)


Review request for mesos and Joseph Wu.


Changes
---

Associated a JIRA -- Joseph Wu.


Bugs: MESOS-5979
https://issues.apache.org/jira/browse/MESOS-5979


Repository: mesos


Description
---

Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.


Diffs
-

  3rdparty/CMakeLists.txt a7ae76a40fcf5c6d6c9dc86daaa7524c220980dd 

Diff: https://reviews.apache.org/r/49736/diff/


Testing
---

$ cmake ..
$ make -j
$ make -j check

Manually inspected: `3rdparty/elfio-3.1/src/elfio-3.1/elfio/elfio_note.hpp`
and saw that the patch is applied.


Thanks,

Kevin Klues

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/
---

(Updated Aug. 3, 2016, 4:40 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Changed libmesos from static library to a shared library.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/http-parser/CMakeLists.txt.template 
9a671973b754095e1de917f135a7deb978fb6eb6 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/master/cmake/MasterConfigure.cmake 
6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 

Diff: https://reviews.apache.org/r/49862/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake, line 51
> > 
> >
> > You're right to split this out, but just for my own education, was 
> > there a specific reason you did it?

The leveldb shared library will be used in this case.


> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > src/CMakeLists.txt, line 490
> > 
> >
> > Hmm, is this required? It should be `ON` by default for shared 
> > libraries, no?

the -fPIC is added and so this should not be required anymore. I think we 
should prefer to use this over -fPIC to be not compiler specific?


> On Aug. 2, 2016, 1:29 a.m., Alex Clemmer wrote:
> > src/slave/cmake/SlaveConfigure.cmake, line 70
> > 
> >
> > Hmm. Can you talk a bit about why we're adding this here? The agent 
> > doesn't depend on leveldb, right? Only the master does?
> > 
> > I'm just trying to think about how we actually want to add this. 
> > Historically there has been some ambition to write this in a way that we 
> > can get rid of libmesos and split it up into libagent and libmaster. If we 
> > maintain the agent dependencies as separated from the master dependencies, 
> > we will get some duplication in the shared dependencies, but it will also 
> > be easier (hopefully) to reason about what depends on what.
> > 
> > What do you think?

Refactoring is a good idea, I think we can come up with mesoscommon, 
mesosmaster and mesosagent as three different libraries. I prefer not to handle 
this right now.


- Srinivas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review144432
---


On Aug. 2, 2016, 3:35 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated Aug. 2, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 9a671973b754095e1de917f135a7deb978fb6eb6 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> b339239761a5de321d65b92376dae69c339bee5c 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated Aug. 3, 2016, 5:12 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49828/
---

(Updated Aug. 3, 2016, 5:13 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Added default methods implementations for `Subsystem` base class.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49828/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49849: Implemented `CpuSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49849/
---

(Updated Aug. 3, 2016, 5:14 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Implemented `CpuSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49849/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49850/
---

(Updated Aug. 3, 2016, 5:15 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Implemented `CpuacctSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49850/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49851: Implemented `MemorySubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/
---

(Updated Aug. 3, 2016, 5:16 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Implemented `MemorySubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49851/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49852: Implemented `NetClsSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49852/
---

(Updated Aug. 3, 2016, 5:17 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Implemented `NetClsSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/49852/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45573: Added `PerfEventHandleManager`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45573/
---

(Updated Aug. 3, 2016, 5:31 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Added `PerfEventHandleManager`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
4abde12af68a26b94b3706cdb38bf9890d811039 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
31f35385691681ef5da14be747edfb5f57c5d05a 

Diff: https://reviews.apache.org/r/45573/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49855/
---

(Updated Aug. 3, 2016, 5:31 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5652
https://issues.apache.org/jira/browse/MESOS-5652


Repository: mesos


Description
---

Enabled cgroups unified isolator in isolation.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 

Diff: https://reviews.apache.org/r/49855/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50748/
---

(Updated Aug. 3, 2016, 5:31 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5974
https://issues.apache.org/jira/browse/MESOS-5974


Repository: mesos


Description
---

Removed CgroupsMemIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 
b3ce6ed2505312bdd2d800164c2f57cd7625c9fa 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50748/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50733/
---

(Updated Aug. 3, 2016, 5:31 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5973
https://issues.apache.org/jira/browse/MESOS-5973


Repository: mesos


Description
---

Removed CgroupsCpushareIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 
74982a610b6c0a74734165a0c6aa8c9f72f54deb 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
221e814a448c4b5df9dab98de597451a24e2b89c 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50733/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49854: Implemented `DevicesSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49854/
---

(Updated Aug. 3, 2016, 5:31 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5651
https://issues.apache.org/jira/browse/MESOS-5651


Repository: mesos


Description
---

Implemented `DevicesSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49854/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49853/
---

(Updated Aug. 3, 2016, 5:31 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Implemented `PerfEventSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49853/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50749/
---

(Updated Aug. 3, 2016, 5:31 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5977
https://issues.apache.org/jira/browse/MESOS-5977


Repository: mesos


Description
---

Removed CgroupsDevicesIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/devices.hpp 
7ad96440b21a380c5d9af27b0168e9abf47769af 

Diff: https://reviews.apache.org/r/50749/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50751/
---

(Updated Aug. 3, 2016, 5:32 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5975
https://issues.apache.org/jira/browse/MESOS-5975


Repository: mesos


Description
---

Removed CgroupsPerfEventIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50751/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 3, 2016, 5:32 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50736: Added SSL support to libprocess HTTP request helpers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50736/
---

Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-5966
https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description
---

In order to test libprocess HTTP functionality with SSL
both enabled and disabled, the HTTP helper functions that
libprocess uses in tests must be parametrized by SSL
configuration.


Diffs
-

  3rdparty/libprocess/include/process/http.hpp 
404196bb198c1ff958b55d72fb29c5fe92dba429 
  3rdparty/libprocess/src/http.cpp 298bd460afdeccd18e201d8a505b961fd4cf3d3e 

Diff: https://reviews.apache.org/r/50736/diff/


Testing
---

Find testing information in the subsequent patch in this chain.


Thanks,

Greg Mann

Re: Review Request 49852: Implemented `NetClsSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49852/
---

(Updated Aug. 3, 2016, 5:30 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Implemented `NetClsSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49852/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50737/
---

Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.


Bugs: MESOS-5966
https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description
---

This patch parametrizes the HTTP tests in libprocess so
that they run with SSL both enabled and disabled.


Diffs
-

  3rdparty/libprocess/src/tests/http_tests.cpp 
8a0d61eb57f9ae972eedf3481f131844b283abc5 

Diff: https://reviews.apache.org/r/50737/diff/


Testing
---

Tested on OSX with `GTEST_REPEAT=100 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="*HTTPTest*" 3rdparty/libprocess/libprocess-tests`


Thanks,

Greg Mann

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50737/
---

(Updated Aug. 3, 2016, 5:37 p.m.)


Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.


Bugs: MESOS-5966
https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description (updated)
---

This patch parametrizes the HTTP tests in libprocess so
that they run with SSL both enabled and disabled when
the library has been compiled with SSL support.


Diffs
-

  3rdparty/libprocess/src/tests/http_tests.cpp 
8a0d61eb57f9ae972eedf3481f131844b283abc5 

Diff: https://reviews.apache.org/r/50737/diff/


Testing
---

Tested on OSX with `GTEST_REPEAT=100 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="*HTTPTest*" 3rdparty/libprocess/libprocess-tests`


Thanks,

Greg Mann

Re: Review Request 49851: Implemented `MemorySubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/
---

(Updated Aug. 3, 2016, 5:58 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Add process id.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Implemented `MemorySubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49851/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49852: Implemented `NetClsSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49852/
---

(Updated Aug. 3, 2016, 5:58 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Add process id.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Implemented `NetClsSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49852/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49849: Implemented `CpuSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49849/
---

(Updated Aug. 3, 2016, 5:57 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Add process id.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Implemented `CpuSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49849/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49850/
---

(Updated Aug. 3, 2016, 5:57 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Add process id.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Implemented `CpuacctSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49850/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49853/
---

(Updated Aug. 3, 2016, 5:59 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Implemented `PerfEventSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49853/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49854: Implemented `DevicesSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49854/
---

(Updated Aug. 3, 2016, 5:59 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Add process id.


Bugs: MESOS-5651
https://issues.apache.org/jira/browse/MESOS-5651


Repository: mesos


Description
---

Implemented `DevicesSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49854/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144633
---




src/master/master.cpp 


Seems like we should still be logging when we get a status update from an 
unknown framework.



src/master/master.cpp (line 5153)


`getFramework()` might return non-`nullptr` for a disconnected (but still 
registered) framework, so I think you should rephrase this.



src/master/master.cpp (line 5175)


Should we call such a status update "valid"? We didn't before, now we will. 
Not sure new behavior is wrong but seems worth discussing.



src/tests/master_tests.cpp (line 4665)


Should we also check that the task correctly transitions to a terminal 
state in the master?


- Neil Conway


On Aug. 2, 2016, 9:45 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 2, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49855/#review144638
---



Patch looks great!

Reviews applied: [49819, 49820, 49821, 49823, 49824, 49825, 49827, 50627, 
50642, 50643, 49817, 49828, 49849, 49850, 49851, 49852, 45573, 49853, 49854, 
49855]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 5:31 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49855/
> ---
> 
> (Updated Aug. 3, 2016, 5:31 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5652
> https://issues.apache.org/jira/browse/MESOS-5652
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled cgroups unified isolator in isolation.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
> 
> Diff: https://reviews.apache.org/r/49855/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50738: Improved performance in addition and subtraction of resources.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50738/#review144639
---


Ship it!




Ship It!

- Jiang Yan Xu


On Aug. 3, 2016, 12:36 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50738/
> ---
> 
> (Updated Aug. 3, 2016, 12:36 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5978
> https://issues.apache.org/jira/browse/MESOS-5978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoid multiple calls to addable and subtractable in the arithmetic
> operations in Resources. While adding or subtracting two Resources
> objects, check for addable() is done in Resources::add(), and check
> for subtractable() is done in Resources::subtract(). Since the
> Resource_ class is private and += and -= operators are only called
> from within Resources::add() and Resources::subtract(); so we do not
> need to call addable() or subtractable() again.
> 
> This improves the performance of += and -= operators by about 25%.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 829f39d7c1af3eb4e2efd97e01f87acf7c854bb4 
>   include/mesos/v1/resources.hpp f3c5f315c3701e37aeb8fd468ee288829461338e 
>   src/common/resources.cpp b5d20d699553cb5e0aae1718d8a5d73e9192f10a 
>   src/v1/resources.cpp 71eedb29ccacfbd616f5088890d759ab669f8ce7 
> 
> Diff: https://reviews.apache.org/r/50738/diff/
> 
> 
> Testing
> ---
> 
> Tests ok. Ran the benchmark for resources arithmetic and observed about 30% 
> improvement in arithmetic operations for scalars.
> 
> HEAD
> 
> 
> [==] Running 4 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
> Took 73155us to perform 5 'total += r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 78983us to perform 5 'total -= r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 294658us to perform 5 'total = total + r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 302820us to perform 5 'total = total - r' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (752 ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
> Took 4.171325secs to perform 10 'total += r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 4.320892secs to perform 10 'total -= r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 4.239706secs to perform 10 'total = total + r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> Took 4.413952secs to perform 10 'total = total - r' operations on cpus(0, 
> principal_0, {key_0: value_0}):1; gpus(...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17196 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> Took 475848us to perform 1000 'total += r' operations on ports(*):[1-2, 4-5, 
> 7-8, 10-11, 13-14, 16-17, 1...
> Took 2270us to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 
> 7-8, 10-11, 13-14, 16-17, 1...
> Took 562153us to perform 1000 'total = total + r' operations on 
> ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 2357us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (1044 
> ms)
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3
> Took 60524us to perform 5 'total += r' operations on cpus(*):1; 
> mem(*):128; disk(test)[persistentId:...
> Took 64486us to perform 5 'total -= r' operations on cpus(*):1; 
> mem(*):128; disk(test)[persistentId:...
> Took 343349us to perform 5 'total = total + r' operations on cpus(*):1; 
> mem(*):128; disk(test)[persistentId:...
> Took 342624us to perform 5 'total = total - r' operations on cpus(*):1; 
> mem(*):128; disk(test)[persistentId:...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3 (812 ms)
> [--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test (19804 
> ms total)
> 
> [--] Global test environment tear-down
> [==] 4 tests from 1 test case ran. (19820 ms total)
> [  PASSED  ] 4 tests.
> 
> With this patch
> ===
> 
> [==] Running 4 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test

Re: Review Request 49571: Added a benchmark test for allocations.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review144158
---




src/tests/hierarchical_allocator_tests.cpp (line 252)


I do not think we need 2 lines between functions embedded in a C++ class in 
header file. Based on remaining functions in this file and couple of header 
files, I think that is the pattern.


- Anindya Sinha


On July 30, 2016, 7:09 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> ---
> 
> (Updated July 30, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5771
> https://issues.apache.org/jira/browse/MESOS-5771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allocations test has the following configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
> resources; and offers from every other alternate slave contains
> a shared resource.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> e5576023e4aab930f0e2b1d82d8baa6569d852eb 
> 
> Diff: https://reviews.apache.org/r/49571/diff/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> Allocations benchmark test results
> ==
> Support of shared resources has a small impact on runtime performance in 
> allocations. Also, there is no visible impact in performance when shared 
> resources are added in the tests.
> 
> With the patch (and no shared resources)
> 
> round 0 allocate took 3.3096secs to make 2000 offers
> round 50 allocate took 3.302636secs to make 2000 offers
> round 100 allocate took 3.321002secs to make 2000 offers
> round 150 allocate took 3.305755secs to make 2000 offers
> round 199 allocate took 3.305825secs to make 2000 offers
> 
> With the patch (and shared resources on all agents)
> ---
> round 0 allocate took 3.361138secs to make 2000 offers
> round 50 allocate took 3.375249secs to make 2000 offers
> round 100 allocate took 3.36454secs to make 2000 offers
> round 150 allocate took 3.366206secs to make 2000 offers
> round 199 allocate took 3.365199secs to make 2000 offers
> 
> With the patch (and shared resources on alternate agents)
> -
> round 0 allocate took 3.335685secs to make 2000 offers
> round 50 allocate took 3.341063secs to make 2000 offers
> round 100 allocate took 3.341839secs to make 2000 offers
> round 150 allocate took 3.335622secs to make 2000 offers
> round 199 allocate took 3.337968secs to make 2000 offers
> 
> Based on HEAD, with all regular resources (no shared resources in HEAD 
> supported)
> -
> round 0 allocate took 3.00921secs to make 2000 offers
> round 50 allocate took 3.006498secs to make 2000 offers
> round 100 allocate took 3.004949secs to make 2000 offers
> round 150 allocate took 3.00702secs to make 2000 offers
> round 199 allocate took 3.00633secs to make 2000 offers
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Review Request 50739: Updated '--fetcher_cache_dir' help string.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50739/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Now that the fetcher binary fetches files as the
task's user, it is necessary for all such Unix users
to have access to the fetcher cache directory. This
patch updates the flag's help string to make note of
this.


Diffs
-

  docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
  src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 

Diff: https://reviews.apache.org/r/50739/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 45964: Add unit tests for sharing of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45964/
---

(Updated Aug. 3, 2016, 7 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Minor tweak in the tests for count().


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

Add unit tests for sharing of resources.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
cbed333f497016fe2811f755028796012b41db77 
  src/tests/master_validation_tests.cpp 
9eb82a569f7c48caa96d4d54a93b199ccac74385 
  src/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5 
  src/tests/persistent_volume_tests.cpp 
a6f97c4bb5fb29d610c01255036095e2b30c44c5 
  src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b 

Diff: https://reviews.apache.org/r/45964/diff/


Testing
---

Tests for shared resources added for allocator, resources and sorter.
Tests successful.


Thanks,

Anindya Sinha

Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50763/
---

Review request for mesos, Benjamin Mahler and Jie Yu.


Bugs: MESOS-5969
https://issues.apache.org/jira/browse/MESOS-5969


Repository: mesos


Description
---

Many places in the codebase assume that the mountinfo table is sorted
according to the order: 'parent mount point < child mount point'.

However, in some cases this may not be true if (for example), a parent
mount point (say '/') is remounted to add some extra flags to it.
When this happens, the remounted file system will appear in the
mountinfo table at the point where it was remounted.

We actually encountered this problem in the wild for the case of '/'
being remounted after '/run' was mounted -- causing problems in the
'NvidiaVolume' which assumes the 'parent < child' ordering.

This commit fixes this problem by building the list of MountInfoTable
entries in sorted order when 'read()' is called. An optional flag can
be used to disable sorting produce the the original ordering.


Diffs
-

  src/linux/fs.hpp ec3b5b8cd6926b1f69ad499de1c13b989766a84e 
  src/linux/fs.cpp f57db80ad0d7235d47910e05d663c77e233f8228 

Diff: https://reviews.apache.org/r/50763/diff/


Testing
---

GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests

Appeared to have one unrelated flaky test fail: 
`ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
Rerunning the tests a second time passed.


Thanks,

Kevin Klues

Review Request 50762: Updated 'NvidiaVolume' to not error out when binary is missing.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50762/
---

Review request for mesos, Benjamin Mahler and Jie Yu.


Bugs: MESOS-5982
https://issues.apache.org/jira/browse/MESOS-5982


Repository: mesos


Description
---

Previously, when building the volume, we would error out if a binary
we were trying to add was not found on the host filesystem. However,
these are not the semantics that we want. By design, we list all the
binaries the *may* exist on the filesystem that we want to put in the
volume, not all of the binaries that *must* exist. To this end, we
should simply skip any unfound binaries and move on to the next one
instead of erroring out.


Diffs
-

  src/slave/containerizer/mesos/isolators/gpu/volume.cpp 
478e106cdaa025af92117f14be91ec9e1c70425b 

Diff: https://reviews.apache.org/r/50762/diff/


Testing
---

GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests


Thanks,

Kevin Klues

Re: Review Request 49736: Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.

[Kevin Klues]

> On July 12, 2016, 4:40 p.m., Alex Clemmer wrote:
> > 3rdparty/CMakeLists.txt, line 141
> > 
> >
> > This probably won't work on Windows. You will notice that for (_e.g._) 
> > `HTTP_PARSER_PATCH_CMD`, we have something like this instead of `PATCH_CMD`:
> > 
> > ```
> >   set(HTTP_PARSER_PATCH_CMD ${PATCHEXE_LOCATION} --binary -p1 < 
> > ${MESOS_3RDPARTY_BIN}/http-parser-${HTTP_PARSER_VERSION}.patch)
> > ```
> > 
> > This is pretty unfortuante and as I look at this file, it seems like 
> > we're not patching a lot of the libraries. This is probably my doing. 
> > #clowntown I've filed an issue to make sure we follow up on this: MESOS-5835

There is actually a newer version of elfio that was just released which has my 
patches merged in. Instead of dealing with this, we should just upgrade to the 
newer elfio and avoid the patch altogether.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49736/#review141913
---


On Aug. 3, 2016, 4:21 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49736/
> ---
> 
> (Updated Aug. 3, 2016, 4:21 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5979
> https://issues.apache.org/jira/browse/MESOS-5979
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added PATCH_CMD in 3rdparty/CMakeLists.txt for ELFIO.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt a7ae76a40fcf5c6d6c9dc86daaa7524c220980dd 
> 
> Diff: https://reviews.apache.org/r/49736/diff/
> 
> 
> Testing
> ---
> 
> $ cmake ..
> $ make -j
> $ make -j check
> 
> Manually inspected: `3rdparty/elfio-3.1/src/elfio-3.1/elfio/elfio_note.hpp`
> and saw that the patch is applied.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144662
---




src/master/master.cpp (lines 5154 - 5156)


Maybe increment `metrics->invalid_status_updates` in the else case here?
And log here, as before?


- Adam B


On Aug. 2, 2016, 2:45 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 2, 2016, 2:45 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 50767: Updated logrotation module to use `os::pagesize()`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50767/
---

Review request for mesos, Benjamin Mahler and Joseph Wu.


Repository: mesos


Description
---

This allows for compilation on Windows.


Diffs
-

  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/container_loggers/logrotate.cpp 
a96cbf1850b484d0dfa2784eb158769512e1f178 

Diff: https://reviews.apache.org/r/50767/diff/


Testing
---

make check.


Thanks,

Joris Van Remoortere

Review Request 50766: Added flag in logrotate module to control number of libprocess threads.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50766/
---

Review request for mesos, Benjamin Mahler and Joseph Wu.


Bugs: MESOS-5983
https://issues.apache.org/jira/browse/MESOS-5983


Repository: mesos


Description
---

Defaults to 8 based on the safe default in libprocess itself.


Diffs
-

  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/lib_logrotate.cpp 
d53847bbca83367927725f06e8f962ce7011f468 

Diff: https://reviews.apache.org/r/50766/diff/


Testing
---

Make check.
Tried changing number of threads.


Thanks,

Joris Van Remoortere

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Anand Mazumdar]

> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote:
> > src/master/master.cpp, line 5142
> > 
> >
> > Seems like we should still be logging when we get a status update from 
> > an unknown framework.

+1, my bad.


> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote:
> > src/tests/master_tests.cpp, line 4665
> > 
> >
> > Should we also check that the task correctly transitions to a terminal 
> > state in the master?

I had punted on this for now and just ensuring if the resources have been 
correctly recovered. I left a TODO to address this for later.


> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote:
> > src/master/master.cpp, line 5163
> > 
> >
> > `getFramework()` might return non-`nullptr` for a disconnected (but 
> > still registered) framework, so I think you should rephrase this.

I had copied this comment over from similar pre-existing comments in this file. 
Would file a follow up JIRA issue to revisit some of them.


> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote:
> > src/master/master.cpp, line 5185
> > 
> >
> > Should we call such a status update "valid"? We didn't before, now we 
> > will. Not sure new behavior is wrong but seems worth discussing.

+1, Continuing this discussion on a follow up review comment from Adam.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144633
---


On Aug. 3, 2016, 8:44 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 3, 2016, 8:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/
---

(Updated Aug. 3, 2016, 8:44 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Neil and Adam.

Also, deferred the update of task status update in `forward()` instead of 
`updateTask()`. See comments for more details on why this is needed.


Bugs: MESOS-5930
https://issues.apache.org/jira/browse/MESOS-5930


Repository: mesos


Description
---

The master's status handler function used to ignore the status updates
from the agents for frameworks not yet re-connected with the master
upon a failover. This change modifies that logic to still update
the local state and not bail out early.


Diffs (updated)
-

  src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
  src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 

Diff: https://reviews.apache.org/r/50723/diff/


Testing
---

make check (gtest_repeat=100)


Thanks,

Anand Mazumdar

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Anand Mazumdar]

> On Aug. 3, 2016, 7:58 p.m., Adam B wrote:
> > src/master/master.cpp, lines 5164-5166
> > 
> >
> > Maybe increment `metrics->invalid_status_updates` in the else case here?
> > And log here, as before?

This was pointed out by Neil earlier too. Continuing the discussion here. 

To me, it looked like an oversight in the prior code to treat status updates 
from agents for frameworks that have not yet re-registered upon a master 
failover as invalid and increment the metric?


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144662
---


On Aug. 3, 2016, 8:44 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 3, 2016, 8:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Adam B]

> On Aug. 3, 2016, 12:58 p.m., Adam B wrote:
> > src/master/master.cpp, lines 5164-5166
> > 
> >
> > Maybe increment `metrics->invalid_status_updates` in the else case here?
> > And log here, as before?
> 
> Anand Mazumdar wrote:
> This was pointed out by Neil earlier too. Continuing the discussion here. 
> 
> To me, it looked like an oversight in the prior code to treat status 
> updates from agents for frameworks that have not yet re-registered upon a 
> master failover as invalid and increment the metric?

Ok, then maybe we need a new `metrics->dropped_status_updates`?


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144662
---


On Aug. 3, 2016, 1:44 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 3, 2016, 1:44 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50766: Added flag in logrotate module to control number of libprocess threads.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50766/#review144668
---




src/slave/container_loggers/lib_logrotate.hpp (lines 118 - 119)


`s/synchronous/asynchronous` ?

---

`s/should not/does not currently`

If someone wants to copy the code and write a derivative module (that, say, 
uses more threads), they might be tripped up by this wording.



src/slave/container_loggers/lib_logrotate.hpp (lines 139 - 147)


This could be a lambda.  (The `validateSize` function is not a lambda 
because it is called twice.)



src/slave/container_loggers/lib_logrotate.cpp (line 96)


I have a feeling this will emit a warning on some systems (signed/unsigned 
comparison), but I need to comfirm...


- Joseph Wu


On Aug. 3, 2016, 1:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50766/
> ---
> 
> (Updated Aug. 3, 2016, 1:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5983
> https://issues.apache.org/jira/browse/MESOS-5983
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Defaults to 8 based on the safe default in libprocess itself.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
>   src/slave/container_loggers/lib_logrotate.cpp 
> d53847bbca83367927725f06e8f962ce7011f468 
> 
> Diff: https://reviews.apache.org/r/50766/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> Tried changing number of threads.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50733/
---

(Updated Aug. 3, 2016, 2:18 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Modified "Depends On" field because that review (/r/50758) is 
private/unpublished.  Reviewbot was failing to fetch the patch. -- Joseph Wu.


Bugs: MESOS-5973
https://issues.apache.org/jira/browse/MESOS-5973


Repository: mesos


Description
---

Removed CgroupsCpushareIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 
74982a610b6c0a74734165a0c6aa8c9f72f54deb 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
221e814a448c4b5df9dab98de597451a24e2b89c 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50733/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50771: Added coverity build to build_docker.sh.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5984
https://issues.apache.org/jira/browse/MESOS-5984


Repository: mesos


Description
---

This review adds an coverity build option
to build_docker.sh in order to enable
regular coverity builds on the ASF infrastructure.


Diffs
-

  support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 

Diff: https://reviews.apache.org/r/50771/diff/


Testing
---

ran build with and without COVERITY_TOKEN.


Thanks,

Joerg Schad

Re: Review Request 50766: Added flag in logrotate module to control number of libprocess threads.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50766/
---

(Updated Aug. 3, 2016, 9:16 p.m.)


Review request for mesos, Benjamin Mahler and Joseph Wu.


Changes
---

Addressed Joseph's comments.


Bugs: MESOS-5983
https://issues.apache.org/jira/browse/MESOS-5983


Repository: mesos


Description
---

Defaults to 8 based on the safe default in libprocess itself.


Diffs (updated)
-

  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/lib_logrotate.cpp 
d53847bbca83367927725f06e8f962ce7011f468 

Diff: https://reviews.apache.org/r/50766/diff/


Testing
---

Make check.
Tried changing number of threads.


Thanks,

Joris Van Remoortere

Review Request 50769: Fixed a broken link to CNI repo.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50769/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5985
https://issues.apache.org/jira/browse/MESOS-5985


Repository: mesos


Description
---

Fixed a broken link to CNI repo.


Diffs
-

  docs/networking.md f6652f58b02edee08e0b2410c23b2beb4d25e83b 

Diff: https://reviews.apache.org/r/50769/diff/


Testing
---

Launched the mesos website and verified the link.


Thanks,

Avinash sridharan

Re: Review Request 50767: Updated logrotation module to use `os::pagesize()`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50767/#review144672
---


Fix it, then Ship it!




It doesn't compile on Windows just yet, but this does bring it a bit closer :)


src/slave/container_loggers/logrotate.hpp (line 21)


Remove this header.



src/slave/container_loggers/logrotate.cpp (line 17)


Remove this header.


- Joseph Wu


On Aug. 3, 2016, 1:43 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50767/
> ---
> 
> (Updated Aug. 3, 2016, 1:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows for compilation on Windows.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
>   src/slave/container_loggers/logrotate.hpp 
> 16d92322079a69d8e6bed7830623c62f345cd51c 
>   src/slave/container_loggers/logrotate.cpp 
> a96cbf1850b484d0dfa2784eb158769512e1f178 
> 
> Diff: https://reviews.apache.org/r/50767/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 50766: Added flag in logrotate module to control number of libprocess threads.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50766/#review144679
---


Ship it!




Ship It!

- Joseph Wu


On Aug. 3, 2016, 2:16 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50766/
> ---
> 
> (Updated Aug. 3, 2016, 2:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5983
> https://issues.apache.org/jira/browse/MESOS-5983
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Defaults to 8 based on the safe default in libprocess itself.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
>   src/slave/container_loggers/lib_logrotate.cpp 
> d53847bbca83367927725f06e8f962ce7011f468 
> 
> Diff: https://reviews.apache.org/r/50766/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> Tried changing number of threads.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 50762: Updated 'NvidiaVolume' to not error out when binary is missing.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50762/#review144680
---


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 3, 2016, 7:10 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50762/
> ---
> 
> (Updated Aug. 3, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5982
> https://issues.apache.org/jira/browse/MESOS-5982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, when building the volume, we would error out if a binary
> we were trying to add was not found on the host filesystem. However,
> these are not the semantics that we want. By design, we list all the
> binaries the *may* exist on the filesystem that we want to put in the
> volume, not all of the binaries that *must* exist. To this end, we
> should simply skip any unfound binaries and move on to the next one
> instead of erroring out.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/volume.cpp 
> 478e106cdaa025af92117f14be91ec9e1c70425b 
> 
> Diff: https://reviews.apache.org/r/50762/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> src/mesos-tests
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 50641: Fixed typo in comment.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50641/#review144682
---


Ship it!




Ship It!

- Anand Mazumdar


On July 31, 2016, 2:53 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50641/
> ---
> 
> (Updated July 31, 2016, 2:53 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typo in comment.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp e5de589a08d7b0815bfbd5e3ac1da81384410b57 
> 
> Diff: https://reviews.apache.org/r/50641/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 50640: Improved HTTP API docs.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50640/#review144683
---


Ship it!




LGTM

- Anand Mazumdar


On July 31, 2016, 2:53 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50640/
> ---
> 
> (Updated July 31, 2016, 2:53 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarify that HTTP APIs are now considered stable and give some
> background on how the old and new APIs compare.
> 
> 
> Diffs
> -
> 
>   docs/executor-http-api.md fb70f75c43c2751ff430a571ed8d4630d29a7ef8 
>   docs/scheduler-http-api.md 4be961214c63e4e3b25c5c350b2c4f0e66863817 
> 
> Diff: https://reviews.apache.org/r/50640/diff/
> 
> 
> Testing
> ---
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 50713: Documented behavior of content-type header in presence of errors.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50713/
---

(Updated Aug. 3, 2016, 10:12 p.m.)


Review request for mesos and Anand Mazumdar.


Changes
---

Removed dep on already committed reviews.


Bugs: MESOS-5853
https://issues.apache.org/jira/browse/MESOS-5853


Repository: mesos


Description
---

When an error response is generated for http v1 api, default
contentType is "text/plain; charset=utf-8". This has been
documented for the docs of http v1 api in this patch.


Diffs
-

  docs/executor-http-api.md fb70f75c43c2751ff430a571ed8d4630d29a7ef8 
  docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 
  docs/scheduler-http-api.md 4be961214c63e4e3b25c5c350b2c4f0e66863817 

Diff: https://reviews.apache.org/r/50713/diff/


Testing
---

Viewed with "rake dev".


Thanks,

Abhishek Dasgupta

Re: Review Request 50767: Updated logrotation module to use `os::pagesize()`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50767/
---

(Updated Aug. 3, 2016, 10:19 p.m.)


Review request for mesos, Benjamin Mahler and Joseph Wu.


Repository: mesos


Description (updated)
---

This gets us closer to compiling on Windows.


Diffs
-

  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/container_loggers/logrotate.cpp 
a96cbf1850b484d0dfa2784eb158769512e1f178 

Diff: https://reviews.apache.org/r/50767/diff/


Testing
---

make check.


Thanks,

Joris Van Remoortere

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144677
---


Fix it, then Ship it!





src/master/master.cpp (lines 5201 - 5203)


How about

// The task might not exist in master's memory (e.g., failed task 
validation).



src/master/master.cpp (lines 5206 - 5209)


I think this part of the comment is a bit confusing. I would just kill it. 
Keep the last sentence "Note that master..."



src/tests/master_tests.cpp (line 4795)


i.e.,



src/tests/master_tests.cpp (line 4824)


s/send a retry/retry/


- Vinod Kone


On Aug. 3, 2016, 8:44 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 3, 2016, 8:44 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/
---

(Updated Aug. 3, 2016, 11:14 p.m.)


Review request for mesos, Adam B, Neil Conway, and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-5930
https://issues.apache.org/jira/browse/MESOS-5930


Repository: mesos


Description
---

The master's status handler function used to ignore the status updates
from the agents for frameworks not yet re-connected with the master
upon a failover. This change modifies that logic to still update
the local state and not bail out early.


Diffs (updated)
-

  src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf 
  src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 

Diff: https://reviews.apache.org/r/50723/diff/


Testing
---

make check (gtest_repeat=100)


Thanks,

Anand Mazumdar

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Anand Mazumdar]

> On Aug. 3, 2016, 7:58 p.m., Adam B wrote:
> > src/master/master.cpp, lines 5164-5166
> > 
> >
> > Maybe increment `metrics->invalid_status_updates` in the else case here?
> > And log here, as before?
> 
> Anand Mazumdar wrote:
> This was pointed out by Neil earlier too. Continuing the discussion here. 
> 
> To me, it looked like an oversight in the prior code to treat status 
> updates from agents for frameworks that have not yet re-registered upon a 
> master failover as invalid and increment the metric?
> 
> Adam B wrote:
> Ok, then maybe we need a new `metrics->dropped_status_updates`?

hmm, looks like in `acknowledge()` we increment the metric when the agent is 
not connected. I would go ahead and increment the metric here too for 
consistency.
https://github.com/apache/mesos/blob/master/src/master/master.cpp#L4258


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144662
---


On Aug. 3, 2016, 8:44 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 3, 2016, 8:44 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 50774: Added `-Wsign-compare` to global compiler flags.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50774/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Michael 
Park.


Repository: mesos


Description
---

Mesos already builds with the `-Wall` and `-Werror` flags.
However, different compilers have different sets of checks for `-Wall`.

This change explicitly adds the `-Wsign-compare` warning flag that is
present in GCC's `-Wall`, but not in Clang.


Diffs
-

  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 

Diff: https://reviews.apache.org/r/50774/diff/


Testing
---

Introduced a signed-unsigned comparison on OSX and checked that the build warns 
(fails) due to the comparison.


Thanks,

Joseph Wu

Re: Review Request 50010: Added example framework for handling inverse offers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50010/
---

(Updated Aug. 3, 2016, 5:03 p.m.)


Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues.


Bugs: MESOS-5827
https://issues.apache.org/jira/browse/MESOS-5827


Repository: mesos


Description
---

This framework shows how one might handle inverse offers by launching
persistent sleep tasks and migrating them ahead of planned maintenance.


Diffs
-

  src/Makefile.am 9f2b0585fa901918431530b967b6bbb0f286c595 
  src/examples/inverse_offer_framework.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50010/diff/


Testing
---

make check

TODO: Add a helper binary for generating random maintenance schedules.


Thanks,

Joseph Wu

Review Request 50775: Fixed sign comparisons in logrotate module.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50775/
---

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/container_loggers/lib_logrotate.hpp 
6fe38d1f80c7e851e44d8481db7b1996773b026a 
  src/slave/container_loggers/logrotate.hpp 
f906a167f8897385af5f54e1e77cb790121a 

Diff: https://reviews.apache.org/r/50775/diff/


Testing
---

make check (GCC, CentOS 7)


Thanks,

Joseph Wu

Re: Review Request 50775: Fixed sign comparisons in logrotate module.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50775/#review144699
---


Ship it!




Ship It!

- Jie Yu


On Aug. 4, 2016, 12:05 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50775/
> ---
> 
> (Updated Aug. 4, 2016, 12:05 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 6fe38d1f80c7e851e44d8481db7b1996773b026a 
>   src/slave/container_loggers/logrotate.hpp 
> f906a167f8897385af5f54e1e77cb790121a 
> 
> Diff: https://reviews.apache.org/r/50775/diff/
> 
> 
> Testing
> ---
> 
> make check (GCC, CentOS 7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 49571: Added a benchmark test for allocations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review144702
---



Bad patch!

Reviews applied: [49571, 45967, 45966, 45964, 45963, 45962, 45961, 45960, 
50205, 48616, 45959]

Failed command: ./support/apply-review.sh -n -r 45962

Error:
2016-08-04 01:43:44 URL:https://reviews.apache.org/r/45962/diff/raw/ 
[21270/21270] -> "45962.patch" [1]
error: patch failed: src/Makefile.am:2254
error: src/Makefile.am: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14628/console

- Mesos ReviewBot


On July 30, 2016, 7:09 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> ---
> 
> (Updated July 30, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5771
> https://issues.apache.org/jira/browse/MESOS-5771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allocations test has the following configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
> resources; and offers from every other alternate slave contains
> a shared resource.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> e5576023e4aab930f0e2b1d82d8baa6569d852eb 
> 
> Diff: https://reviews.apache.org/r/49571/diff/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> Allocations benchmark test results
> ==
> Support of shared resources has a small impact on runtime performance in 
> allocations. Also, there is no visible impact in performance when shared 
> resources are added in the tests.
> 
> With the patch (and no shared resources)
> 
> round 0 allocate took 3.3096secs to make 2000 offers
> round 50 allocate took 3.302636secs to make 2000 offers
> round 100 allocate took 3.321002secs to make 2000 offers
> round 150 allocate took 3.305755secs to make 2000 offers
> round 199 allocate took 3.305825secs to make 2000 offers
> 
> With the patch (and shared resources on all agents)
> ---
> round 0 allocate took 3.361138secs to make 2000 offers
> round 50 allocate took 3.375249secs to make 2000 offers
> round 100 allocate took 3.36454secs to make 2000 offers
> round 150 allocate took 3.366206secs to make 2000 offers
> round 199 allocate took 3.365199secs to make 2000 offers
> 
> With the patch (and shared resources on alternate agents)
> -
> round 0 allocate took 3.335685secs to make 2000 offers
> round 50 allocate took 3.341063secs to make 2000 offers
> round 100 allocate took 3.341839secs to make 2000 offers
> round 150 allocate took 3.335622secs to make 2000 offers
> round 199 allocate took 3.337968secs to make 2000 offers
> 
> Based on HEAD, with all regular resources (no shared resources in HEAD 
> supported)
> -
> round 0 allocate took 3.00921secs to make 2000 offers
> round 50 allocate took 3.006498secs to make 2000 offers
> round 100 allocate took 3.004949secs to make 2000 offers
> round 150 allocate took 3.00702secs to make 2000 offers
> round 199 allocate took 3.00633secs to make 2000 offers
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 49851: Implemented `MemorySubsystem`.

[Qian Zhang]

> On July 27, 2016, 10:05 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494
> > 
> >
> > How do we recover this field `updatedLimit`? I mean during agent 
> > recovery, `updatedLimit` of each Info will be reset to `false`, right? But 
> > I think that is not correct.
> 
> haosdent huang wrote:
> I think this problem exists at `mem.cpp` as well, and update the limit 
> twice here does not bring problems here. So I drop this. Feel free to reopen 
> this if you think it would bring problems here.

Yes, it is also a bug in `mem.cpp` which uses `info->pid` to check if it is the 
first time to update the memory limit, but the value of `info->pid` will also 
be lost during agent recovery.

And I think updating the memory hard limit twice will bring some problems, as 
mentioned in this comments 
(https://github.com/apache/mesos/blob/1.0.0/src/slave/containerizer/mesos/isolators/cgroups/mem.cpp#L369:#L371),
 decreasing memory hard limit may induce an OOM.

I had a discussion with Jie on this issue, and his suggestion is that we should 
not use such kind of field (e.g., `pid` or `updatedLimit`) because they can not 
be recovered, instead, before updating the hard limit, we should check if its 
current value is still the initial value (should be -1? And it may be different 
in different Linux distributions, so you may need to double check it), if it 
is, then that means it is the first time to update the hard limit, then we can 
just update it, if it is not, then that means it is not the first time, then we 
can only increase it but not decrease it.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/#review143517
---


On Aug. 4, 2016, 1:58 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49851/
> ---
> 
> (Updated Aug. 4, 2016, 1:58 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5045
> https://issues.apache.org/jira/browse/MESOS-5045
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `MemorySubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> b191b2a52a9645fc902a35ed52909b2142f0b4c0 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50739: Updated '--fetcher_cache_dir' help string.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50739/#review144704
---



Bad patch!

Reviews applied: [50739, 50737, 50736, 40512, 40268, 40413, 40411, 40410, 
50621, 40266, 46146, 46094, 45999, 45996, 45995, 45991]

Failed command: ./support/apply-review.sh -n -r 50621

Error:
2016-08-04 02:30:03 URL:https://reviews.apache.org/r/50621/diff/raw/ 
[2739/2739] -> "50621.patch" [1]
error: patch failed: 3rdparty/libprocess/src/process.cpp:1230
error: 3rdparty/libprocess/src/process.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14629/console

- Mesos ReviewBot


On Aug. 3, 2016, 7:05 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50739/
> ---
> 
> (Updated Aug. 3, 2016, 7:05 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Now that the fetcher binary fetches files as the
> task's user, it is necessary for all such Unix users
> to have access to the fetcher cache directory. This
> patch updates the flag's help string to make note of
> this.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
>   src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 
> 
> Diff: https://reviews.apache.org/r/50739/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/#review144706
---




src/docker/docker.hpp (lines 73 - 75)


s/std::string/const std::string&



src/docker/docker.hpp (line 85)


new line for the brace



src/docker/docker.hpp (line 95)


new line for the brace



src/docker/docker.hpp (line 96)


Put include for vector to the top.

```
#include 
```


- Guangya Liu


On 八月 2, 2016, 2:19 p.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50128/
> ---
> 
> (Updated 八月 2, 2016, 2:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device'
> to handle data tranformation between 'Docker::Device' structure and
> string.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
> 
> Diff: https://reviews.apache.org/r/50128/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/#review144708
---



Can you please remove the review ID `50258, 50229` from the `Blocks` section?

- Guangya Liu


On 八月 2, 2016, 2:19 p.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50128/
> ---
> 
> (Updated 八月 2, 2016, 2:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device'
> to handle data tranformation between 'Docker::Device' structure and
> string.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
> 
> Diff: https://reviews.apache.org/r/50128/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50763/#review144713
---



Patch looks great!

Reviews applied: [50762, 50763]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 7:10 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50763/
> ---
> 
> (Updated Aug. 3, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5969
> https://issues.apache.org/jira/browse/MESOS-5969
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Many places in the codebase assume that the mountinfo table is sorted
> according to the order: 'parent mount point < child mount point'.
> 
> However, in some cases this may not be true if (for example), a parent
> mount point (say '/') is remounted to add some extra flags to it.
> When this happens, the remounted file system will appear in the
> mountinfo table at the point where it was remounted.
> 
> We actually encountered this problem in the wild for the case of '/'
> being remounted after '/run' was mounted -- causing problems in the
> 'NvidiaVolume' which assumes the 'parent < child' ordering.
> 
> This commit fixes this problem by building the list of MountInfoTable
> entries in sorted order when 'read()' is called. An optional flag can
> be used to disable sorting produce the the original ordering.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp ec3b5b8cd6926b1f69ad499de1c13b989766a84e 
>   src/linux/fs.cpp f57db80ad0d7235d47910e05d663c77e233f8228 
> 
> Diff: https://reviews.apache.org/r/50763/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> src/mesos-tests
> sudo src/mesos-tests
> 
> Appeared to have one unrelated flaky test fail: 
> `ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
> Rerunning the tests a second time passed.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 49862: Changed libmesos from static library to a shared library.

[Srinivas Brahmaroutu]

> On Aug. 2, 2016, 1:31 a.m., Alex Clemmer wrote:
> > src/slave/cmake/SlaveConfigure.cmake, line 70
> > 
> >
> > Oh. This is especially pertinent given that you seem to remove this 
> > line in #49874.

I cannot recollect that this is intentional. I fixed the issue.


- Srinivas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49862/#review144435
---


On Aug. 3, 2016, 4:40 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49862/
> ---
> 
> (Updated Aug. 3, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed libmesos from static library to a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/http-parser/CMakeLists.txt.template 
> 9a671973b754095e1de917f135a7deb978fb6eb6 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/master/cmake/MasterConfigure.cmake 
> 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 
>   src/slave/cmake/SlaveConfigure.cmake 
> b339239761a5de321d65b92376dae69c339bee5c 
> 
> Diff: https://reviews.apache.org/r/49862/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45960/
---

(Updated Aug. 4, 2016, 5:05 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added interfaces to handle and track shareable resources.


Diffs
-

  include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
  include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
  src/common/resources.cpp b1bd2784aefdebf91892638b40b215373b998574 
  src/v1/resources.cpp 6d4ec75fbb7edab013563142aaf13d5302cc50af 

Diff: https://reviews.apache.org/r/45960/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 50771: Added coverity build to build_docker.sh.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/#review144716
---



Patch looks great!

Reviews applied: [50771]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 9:24 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50771/
> ---
> 
> (Updated Aug. 3, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5984
> https://issues.apache.org/jira/browse/MESOS-5984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review adds an coverity build option
> to build_docker.sh in order to enable
> regular coverity builds on the ASF infrastructure.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 
> 
> Diff: https://reviews.apache.org/r/50771/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without COVERITY_TOKEN.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>