[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134559485 The test failure must be spurious; this is a scaladoc-only change, and compilation / style checks succeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134559021 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134559022 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41529/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134558965 [Test build #41529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41529/console) for PR 8308 at commit [`73ce4ac`](https://github.com/apache/spark/commit/73ce4ac19d011041f2188c11b84d2981ad326efd). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134530480 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134524278 [Test build #41529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41529/consoleFull) for PR 8308 at commit [`73ce4ac`](https://github.com/apache/spark/commit/73ce4ac19d011041f2188c11b84d2981ad326efd). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134523182 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134523157 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8308#discussion_r37745530 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -769,7 +790,9 @@ class DAGScheduler( } } - /** Called when stage's parents are available and we can now do its task. */ + /** + * Called when stage's parents are available and we can now do its task. --- End diff -- The changes here that just make scaladoc into a multiline comment don't do anything .. it's still valid on one line. I think the other changes look fine, and this is a no-op at best, but personally would not change these lines if there is no functional change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134172434 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41450/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134172233 **[Test build #41450 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41450/console)** for PR 8308 at commit [`f835ae8`](https://github.com/apache/spark/commit/f835ae81ac7fc7e67ae15d796efecddb1b0bb094) after a configured wait of `175m`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134172432 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134110172 [Test build #41450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41450/consoleFull) for PR 8308 at commit [`f835ae8`](https://github.com/apache/spark/commit/f835ae81ac7fc7e67ae15d796efecddb1b0bb094). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134108340 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-134108356 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133088404 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133088408 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41326/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133088399 [Test build #41326 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41326/console) for PR 8308 at commit [`100f9a7`](https://github.com/apache/spark/commit/100f9a7c69f664bd5cdeadd8c349e7eb55a951a4). * This patch **fails to build**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8308#discussion_r37556991 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1162,17 +1190,20 @@ class DAGScheduler( } case commitDenied: TaskCommitDenied => -// Do nothing here, left up to the TaskScheduler to decide how to handle denied commits +// Do nothing here, left up to the TaskScheduler implementation +// to decide how to handle denied commits case ExceptionFailure(className, description, stackTrace, fullStackTrace, metrics) => -// Do nothing here, left up to the TaskScheduler to decide how to handle user failures +// Do nothing here, left up to the TaskScheduler implementation +// to decide how to handle user failures --- End diff -- Oh right, because of the extra word. That's fine. PS You'll need to rebase this branch on master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user ehnalis commented on a diff in the pull request: https://github.com/apache/spark/pull/8308#discussion_r37556883 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1162,17 +1190,20 @@ class DAGScheduler( } case commitDenied: TaskCommitDenied => -// Do nothing here, left up to the TaskScheduler to decide how to handle denied commits +// Do nothing here, left up to the TaskScheduler implementation +// to decide how to handle denied commits case ExceptionFailure(className, description, stackTrace, fullStackTrace, metrics) => -// Do nothing here, left up to the TaskScheduler to decide how to handle user failures +// Do nothing here, left up to the TaskScheduler implementation +// to decide how to handle user failures --- End diff -- I guess it must have been going over 100 in length. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133084239 [Test build #41326 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41326/consoleFull) for PR 8308 at commit [`100f9a7`](https://github.com/apache/spark/commit/100f9a7c69f664bd5cdeadd8c349e7eb55a951a4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8308#discussion_r37556418
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -178,35 +185,41 @@ class DAGScheduler(
}
/**
- * Update metrics for in-progress tasks and let the master know that the
BlockManager is still
- * alive. Return true if the driver knows about the given block manager.
Otherwise, return false,
- * indicating that the block manager should re-register.
+ * Called by the TaskScheduler implementation when an executor fails.
*/
- def executorHeartbeatReceived(
- execId: String,
- taskMetrics: Array[(Long, Int, Int, TaskMetrics)], // (taskId,
stageId, stateAttempt, metrics)
- blockManagerId: BlockManagerId): Boolean = {
-listenerBus.post(SparkListenerExecutorMetricsUpdate(execId,
taskMetrics))
-blockManagerMaster.driverEndpoint.askWithRetry[Boolean](
- BlockManagerHeartbeat(blockManagerId), 600 seconds)
- }
-
- // Called by TaskScheduler when an executor fails.
def executorLost(execId: String): Unit = {
eventProcessLoop.post(ExecutorLost(execId))
}
- // Called by TaskScheduler when a host is added
+ /**
+ * Called by the TaskScheduler implementation when a host is added.
+ */
def executorAdded(execId: String, host: String): Unit = {
eventProcessLoop.post(ExecutorAdded(execId, host))
}
- // Called by TaskScheduler to cancel an entire TaskSet due to either
repeated failures or
- // cancellation of the job itself.
+ /**
+ * Called by the TaskSetManager to cancel an entire TaskSet due to either
+ * repeated failures or cancellation of the job itself.
+ */
def taskSetFailed(taskSet: TaskSet, reason: String): Unit = {
eventProcessLoop.post(TaskSetFailed(taskSet, reason))
}
+ /**
--- End diff --
This move might be reasonable but I don't know if it is worth the change of
merge conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8308#discussion_r37556365 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1162,17 +1190,20 @@ class DAGScheduler( } case commitDenied: TaskCommitDenied => -// Do nothing here, left up to the TaskScheduler to decide how to handle denied commits +// Do nothing here, left up to the TaskScheduler implementation +// to decide how to handle denied commits case ExceptionFailure(className, description, stackTrace, fullStackTrace, metrics) => -// Do nothing here, left up to the TaskScheduler to decide how to handle user failures +// Do nothing here, left up to the TaskScheduler implementation +// to decide how to handle user failures --- End diff -- Why was this changed? it's not a big deal, but it was OK on one line. Changes always have this small but non-zero chance of tangling up a merge later, so trivial changes are usually avoided --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133082325 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133082301 [Test build #41325 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41325/console) for PR 8308 at commit [`4911559`](https://github.com/apache/spark/commit/49115592f0938d36b25251e39cf150ebbfce64ea). * This patch **fails to build**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133082327 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41325/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8308#discussion_r37556264 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -716,11 +735,14 @@ class DAGScheduler( } } - /** Finds the earliest-created active job that needs the stage */ - // TODO: Probably should actually find among the active jobs that need this - // stage the one with the highest priority (highest-priority pool, earliest created). - // That should take care of at least part of the priority inversion problem with - // cross-job dependencies. + /** + * Finds the earliest-created active job that needs the stage. + * + * TODO: Probably should actually find among the active jobs that need this --- End diff -- I'm not sure all of this should be scaladoc. This looks like a private comment in the source code. Same for "Broken out for easier testing..." --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133081841 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133081814 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133081591 [Test build #41325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41325/consoleFull) for PR 8308 at commit [`4911559`](https://github.com/apache/spark/commit/49115592f0938d36b25251e39cf150ebbfce64ea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user ehnalis commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133081165 I went through it, also reorganized a method to the front and made method comments consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133080507 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-133080468 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132607672 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132607676 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41234/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132607463 [Test build #41234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41234/console) for PR 8308 at commit [`2a70faf`](https://github.com/apache/spark/commit/2a70fafa1acef35867e9545c5e95271550de68a2). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132559067 I think the additional changes I mentioned are worth fixing here since they're very much of the same form. If you have time to scan for similar problems in nearby source, that's fine, but fixing all the related issues in this file seems like a good logical change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user ehnalis commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-13238 Would you like if I go through all of them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132546896 [Test build #41234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41234/consoleFull) for PR 8308 at commit [`2a70faf`](https://github.com/apache/spark/commit/2a70fafa1acef35867e9545c5e95271550de68a2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132540152 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132540139 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132540092 Yeah, pretty trivial but true. Same for taskSetFailed I think. Also executorLost and executorAdded could probably refer to a "TaskScheduler _implementation_" to be more accurate. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132539949 ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8308#issuecomment-132538832 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Fixed a typo in DAGScheduler.
GitHub user ehnalis opened a pull request: https://github.com/apache/spark/pull/8308 Fixed a typo in DAGScheduler. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ehnalis/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8308.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8308 commit 2a70fafa1acef35867e9545c5e95271550de68a2 Author: ehnalis Date: 2015-08-19T10:46:24Z Fixed a typo in DAGScheduler. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
