[sage-devel] Re: 3.4.1 release tour updates
Hi Michael, On Fri, Apr 24, 2009 at 10:40 AM, mabshoff mabsh...@googlemail.com wrote: SNIP If you also used the author/reviewer system as I do in the release notes no confusion should arise and you mention all people getting credit on the ticket :) Thoughts? Holy bit bucket! What a simple, yet effective idea! OK, I've gone through the release tour at http://wiki.sagemath.org/sage-3.4.1 and have synced the credit there with the release notes for the alpha0 and the various rc's. As yet, there are still two tickets to summarize: namely #5230 and #5706, which are both related to 3-D graphics. The Australian mirror just recently has a local copy of the Sage 3.4.1 source distribution. I haven't yet compile that on my local machine, so it would be some time in the next 24 hours before I can finish off the release tour. Anyway, you might want to look at the credit for #5180. On the wiki page http://wiki.sagemath.org/sage-3.4.1 for the release tour of Sage 3.4.1, David Loeffler has put down Georg S. Weber, Chris Kurth and himself as contributors of code for that ticket. The patch 5180-arithgroups.patch on that ticket certainly has Chris Kurth as an author. So at the moment, after David's edit the credit for #5180 goes like this: David Loeffler, Georg S. Weber, Chris Kurth. This is inconsistent with the release note for 3.4.1.rc0, in which only David Loeffler is listed as the code contributor, with Georg Weber as reviewer. -- Regards Minh Van Nguyen --~--~-~--~~~---~--~~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~--~~~~--~~--~--~---
[sage-devel] Re: 3.4.1 release tour updates
On Apr 24, 11:01 pm, Minh Nguyen nguyenmi...@gmail.com wrote: Hi Michael, Hi Minh, for the release tour of Sage 3.4.1, David Loeffler has put down Georg S. Weber, Chris Kurth and himself as contributors of code for that ticket. The patch 5180-arithgroups.patch on that ticket certainly has Chris Kurth as an author. So at the moment, after David's edit the credit for #5180 goes like this: David Loeffler, Georg S. Weber, Chris Kurth. This is inconsistent with the release note for 3.4.1.rc0, in which only David Loeffler is listed as the code contributor, with Georg Weber as reviewer. Well, Georg says: For the record: I do not count the last patch as worth mentioning in any release notes, especially all credit for the code should go to Dave. (Errors in the additional patch are completely mine, of course!) Cheers, gsw I do not see any mention where David suggests that Georg should share authorship credit. Re the missing Chris Kurth authoership credit - I changed it in my current version, but that has not been posted. -- Regards Minh Van Nguyen Cheers, Michael --~--~-~--~~~---~--~~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~--~~~~--~~--~--~---
[sage-devel] Re: 3.4.1 release tour updates
On Sat, Apr 25, 2009 at 6:10 AM, mabshoff mabsh...@googlemail.com wrote: On Apr 24, 11:01 pm, Minh Nguyen nguyenmi...@gmail.com wrote: Hi Michael, Hi Minh, for the release tour of Sage 3.4.1, David Loeffler has put down Georg S. Weber, Chris Kurth and himself as contributors of code for that ticket. The patch 5180-arithgroups.patch on that ticket certainly has Chris Kurth as an author. So at the moment, after David's edit the credit for #5180 goes like this: David Loeffler, Georg S. Weber, Chris Kurth. This is inconsistent with the release note for 3.4.1.rc0, in which only David Loeffler is listed as the code contributor, with Georg Weber as reviewer. Well, Georg says: For the record: I do not count the last patch as worth mentioning in any release notes, especially all credit for the code should go to Dave. (Errors in the additional patch are completely mine, of course!) Cheers, gsw I do not see any mention where David suggests that Georg should share authorship credit. Re the missing Chris Kurth authoership credit - I changed it in my current version, but that has not been posted. OK, on the release tour for 3.4.1, I've changed the code credit for #5180 to David Loeffler and Chris Kurth. -- Regards Minh Van Nguyen --~--~-~--~~~---~--~~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~--~~~~--~~--~--~---
[sage-devel] Re: 3.4.1 release tour updates
On Apr 22, 11:40 pm, Minh Nguyen nguyenmi...@gmail.com wrote: Hi Michael, Hi Minh, My policy thus far is to list the author(s) of the patch(es). The case you mentioned above was a result of me misreading ticket #5146. This is because for the patch variety_patch.3.patch, I saw the description Updated with some of Martin's comments so I assumed that Martin had some direct input. I tried to be generous in attributing credit. Well, if someone posts a 3 kb reviewer patch for a 250kb patch (#5180 for example) I tend to give a person reviewer credit. In fact, anything marked as reviewer patch should not get author credit. Often enough someone fixes a tiny issue in a patch and just posts the changed original patch of the author - this happens quite often when people use queues. I would prefer if the notes I post for each alpha and rc would match the credit mentioned in the release tour. That way it is easy enough for someone to complain if they shouldn't or didn't get credit and the two different documents would be in sync, i.e. you see on list when I fix things and you should let me know if anyone complained about the release tour. Because I took a look at the changes by David Loeffler I gave Chris Kurth partial author credit for #5180. If you also used the author/reviewer system as I do in the release notes no confusion should arise and you mention all people getting credit on the ticket :) Thoughts? -- Regards Minh Van Nguyen Cheers, Michael --~--~-~--~~~---~--~~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~--~~~~--~~--~--~---
[sage-devel] Re: 3.4.1 release tour updates
Hi Michael, On Wed, Apr 22, 2009 at 5:09 PM, mabshoff mabsh...@googlemail.com wrote: Hi folks, it would be good if you contributed a feature to Sage 3.4.1 to check the release tour at http://wiki.sagemath.org/sage-3.4.1 and edit what is there already in case it can be improved or add something in case it is missing. Minh: You seem to list both author[s] and reviewer[s] for credit, but it seems better to either only list the author or make clear who author [s] and reviewer[s] were. I see that Martin Albrecht already changed that for one ticket and I think he is correct. My policy thus far is to list the author(s) of the patch(es). The case you mentioned above was a result of me misreading ticket #5146. This is because for the patch variety_patch.3.patch, I saw the description Updated with some of Martin's comments so I assumed that Martin had some direct input. I tried to be generous in attributing credit. -- Regards Minh Van Nguyen --~--~-~--~~~---~--~~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~--~~~~--~~--~--~---
[sage-devel] Re: 3.4.1 release tour updates
Hi folks, On Wed, Apr 22, 2009 at 5:09 PM, mabshoff mabsh...@googlemail.com wrote: Hi folks, it would be good if you contributed a feature to Sage 3.4.1 to check the release tour at http://wiki.sagemath.org/sage-3.4.1 and edit what is there already in case it can be improved or add something in case it is missing. Can someone please help me showcase the features of #5450? In particular, it would be good to have some images of 3-D plots that the ticket is meant to fix/add/feature. My net connection is pretty poor so I can't directly download Sage 3.4.1 or upgrade to it. For most features, I would just use sage.math. Doing a 3-D plot would give me a jmol object saved under the directory $HOME/.sage, but I can't figure out how to view 3-D plots using sage.math. -- Regards Minh Van Nguyen --~--~-~--~~~---~--~~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~--~~~~--~~--~--~---
[sage-devel] Re: 3.4.1 release tour updates
Minh Nguyen wrote: Hi folks, On Wed, Apr 22, 2009 at 5:09 PM, mabshoff mabsh...@googlemail.com wrote: Hi folks, it would be good if you contributed a feature to Sage 3.4.1 to check the release tour at http://wiki.sagemath.org/sage-3.4.1 and edit what is there already in case it can be improved or add something in case it is missing. Can someone please help me showcase the features of #5450? In particular, it would be good to have some images of 3-D plots that the ticket is meant to fix/add/feature. My net connection is pretty poor so I can't directly download Sage 3.4.1 or upgrade to it. For most features, I would just use sage.math. Doing a 3-D plot would give me a jmol object saved under the directory $HOME/.sage, but I can't figure out how to view 3-D plots using sage.math. I think of that patch as more of a bugfix than a new feature, so i didn't think it was necessary to mention in the release notes. However, it should make the plotting quite a bit faster (you can plot lots of points in not very much time, but it's harder to plot lots of spheres). Maybe one of the best applications would be a 3d vector field, where you want to plot lots and lots of vectors very quickly. So maybe the plot_vector_field3d function would provide a good example (see http://trac.sagemath.org/sage_trac/ticket/2646). I've posted a picture there. Basically, that command (the last function defined in the comments on the ticket) should provide a lot more responsive picture than before, because it now plots line3d objects instead of full arrow objects. I've published an example here: http://sagenb.org/home/pub/474/ You can get the picture by clicking on the Get Image link next to the 3d plot after adjusting the angle to whatever you want. For what it's worth, that plot_vector_field3d at #2646 just needs some documentation, and then I think it's ready to go into Sage too. Jason -- Jason Grout --~--~-~--~~~---~--~~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~--~~~~--~~--~--~---
