[jira] [Comment Edited] (JAMES-3446) Outlook Mobile App Imap request error
[ https://issues.apache.org/jira/browse/JAMES-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235232#comment-17235232 ] seungmin edited comment on JAMES-3446 at 11/19/20, 7:51 AM: org.apache.james.imap.decode.DecodingException: Invalid character: ' !image-2020-11-19-16-51-07-279.png! caused ssl? I found the reason, but I don't know the reason. was (Author: eltlwjs3): org.apache.james.imap.decode.DecodingException: Invalid character: ' !image-2020-11-19-16-50-36-384.png! caused ssl? I found the reason, but I don't know the reason. > Outlook Mobile App Imap request error > -- > > Key: JAMES-3446 > URL: https://issues.apache.org/jira/browse/JAMES-3446 > Project: James Server > Issue Type: Bug >Affects Versions: 3.0-beta4 >Reporter: seungmin >Priority: Major > Fix For: 3.0.0 > > Attachments: 20201117.cap, 20201117.cap, Capture d’écran de > 2020-11-17 09-57-45.png, image-2020-11-14-16-17-51-011.png, > image-2020-11-16-10-31-15-497.png, image-2020-11-16-14-23-24-498.png, > image-2020-11-16-14-25-06-005.png, image-2020-11-16-16-30-07-096.png, > image-2020-11-16-16-33-36-050.png, image-2020-11-16-16-33-37-781.png, > image-2020-11-16-16-58-33-360.png, image-2020-11-16-17-22-57-210.png, > image-2020-11-17-00-26-57-359.png, image-2020-11-17-00-27-10-493.png, > image-2020-11-17-00-27-58-590.png, image-2020-11-17-00-29-16-919.png, > image-2020-11-17-00-30-23-988.png, image-2020-11-17-00-31-42-025.png, > image-2020-11-18-16-09-15-340.png, image-2020-11-18-16-57-57-404.png, > image-2020-11-18-16-58-07-743.png, image-2020-11-18-18-08-55-845.png, > image-2020-11-19-16-51-07-279.png > > > !image-2020-11-14-16-17-51-011.png! > > - only outlook mobile app > Error while processing imap request > cosumeWord source same master james source > but gmail app, samsung mail app no problem > > "only" outlook mobile issue -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-3446) Outlook Mobile App Imap request error
[ https://issues.apache.org/jira/browse/JAMES-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235232#comment-17235232 ] seungmin commented on JAMES-3446: - org.apache.james.imap.decode.DecodingException: Invalid character: ' !image-2020-11-19-16-50-36-384.png! caused ssl? I found the reason, but I don't know the reason. > Outlook Mobile App Imap request error > -- > > Key: JAMES-3446 > URL: https://issues.apache.org/jira/browse/JAMES-3446 > Project: James Server > Issue Type: Bug >Affects Versions: 3.0-beta4 >Reporter: seungmin >Priority: Major > Fix For: 3.0.0 > > Attachments: 20201117.cap, 20201117.cap, Capture d’écran de > 2020-11-17 09-57-45.png, image-2020-11-14-16-17-51-011.png, > image-2020-11-16-10-31-15-497.png, image-2020-11-16-14-23-24-498.png, > image-2020-11-16-14-25-06-005.png, image-2020-11-16-16-30-07-096.png, > image-2020-11-16-16-33-36-050.png, image-2020-11-16-16-33-37-781.png, > image-2020-11-16-16-58-33-360.png, image-2020-11-16-17-22-57-210.png, > image-2020-11-17-00-26-57-359.png, image-2020-11-17-00-27-10-493.png, > image-2020-11-17-00-27-58-590.png, image-2020-11-17-00-29-16-919.png, > image-2020-11-17-00-30-23-988.png, image-2020-11-17-00-31-42-025.png, > image-2020-11-18-16-09-15-340.png, image-2020-11-18-16-57-57-404.png, > image-2020-11-18-16-58-07-743.png, image-2020-11-18-18-08-55-845.png > > > !image-2020-11-14-16-17-51-011.png! > > - only outlook mobile app > Error while processing imap request > cosumeWord source same master james source > but gmail app, samsung mail app no problem > > "only" outlook mobile issue -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235229#comment-17235229
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-730193158
>Can you have a look? Is that an auto generated file? Can we ignore it?
I'll look into this a quick run of mvn validate didn't fail but running the
`docker run` based compilation from the readme did fail.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235146#comment-17235146
]
ASF GitHub Bot commented on JAMES-2124:
---
chibenwa commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-730106818
Compiling locally:
```
[ERROR] Failed to execute goal
com.github.ekryd.sortpom:sortpom-maven-plugin:2.12.0:verify
(strict-pom-ordering) on project apache-james-mpt-app: The file
/home/benwa/Documents/apache/james-project/mpt/app/dependency-reduced-pom.xml
is not sorted -> [Help 1]
```
Can you have a look? Is that an auto generated file? Can we ignore it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235145#comment-17235145
]
ASF GitHub Bot commented on JAMES-2124:
---
chibenwa commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-730104626
```
The fastest way to test this is to use
mvn package -DskipTests //will fail if a pom contains violations
//or
mvn package -DskipTests -PsortPom // will rewrite all the poms which contain
violations
```
This fit the
https://github.com/apache/james-project/blob/master/src/site/xdoc/contribute.xml
https://github.com/apache/james-project/blob/master/docs/modules/community/pages/contributing.adoc
content.
Can you add that there?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235142#comment-17235142
]
ASF GitHub Bot commented on JAMES-2124:
---
chibenwa commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526568200
##
File path: mailbox/api/pom.xml
##
@@ -45,10 +49,6 @@
james-server-task-memory
test
-
-${james.groupId}
-apache-mime4j-dom
Review comment:
> Probably we should rename mime4j's group id now
:+1:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234974#comment-17234974
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-729919156
I added 4 commits to address the comments and improve the PR a bit
- 073b33c drops the incorrect blank line in server/pom.xml
- bcd0a26 switches to using explicit groupIds for apache-mime4j dependencies
- 7a062c3 reverts incorrectly changed empty tags
- defb95b switches pom validation and sorting from compile to earlier
validate phase, meaning the build will fail even earlier and running `mvn
validate -PsortPom` lets developpers fix poms in a few seconds instead of a
several minutes compilation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234973#comment-17234973
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526376965
##
File path: mailbox/api/pom.xml
##
@@ -45,10 +49,6 @@
james-server-task-memory
test
-
-${james.groupId}
-apache-mime4j-dom
Review comment:
I have added a commit which explicitely drops the `${james.groupId}` for
all the `apache-mime4j-xxx` artifacts
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234868#comment-17234868
]
ASF GitHub Bot commented on JAMES-2124:
---
rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526299932
##
File path: mailbox/api/pom.xml
##
@@ -45,10 +49,6 @@
james-server-task-memory
test
-
-${james.groupId}
-apache-mime4j-dom
Review comment:
I guess it's historical. Probably we should rename mime4j's group id
now, but it's not a trivial change :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234818#comment-17234818
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526244131
##
File path: mailbox/api/pom.xml
##
@@ -45,10 +49,6 @@
james-server-task-memory
test
-
-${james.groupId}
-apache-mime4j-dom
Review comment:
I will make the change.
However I would like to point out
https://maven.apache.org/guides/mini/guide-naming-conventions.html
> groupId uniquely identifies your project across all projects. [...] That
is, if the current project is a multiple module project, it should append a new
identifier to the parent's groupId.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234789#comment-17234789
]
ASF GitHub Bot commented on JAMES-2124:
---
rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526228136
##
File path:
server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##
@@ -17,19 +17,17 @@
specific language governing permissions and limitations
under the License.
-->
-http://maven.apache.org/POM/4.0.0;
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
Review comment:
no problem as far as it is not mandatory
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234785#comment-17234785
]
ASF GitHub Bot commented on JAMES-2124:
---
rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526227740
##
File path: mailbox/api/pom.xml
##
@@ -45,10 +49,6 @@
james-server-task-memory
test
-
-${james.groupId}
-apache-mime4j-dom
Review comment:
mime4j is a project of org.apache.james. But it's not in the same
repository and has not the same versioning than James.
That's why I think here we should explicit "org.apache.james".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234729#comment-17234729
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526187087
##
File path: server/pom.xml
##
@@ -70,9 +70,9 @@
dns-service/dnsservice-library
dns-service/dnsservice-test
-mailet/integration-testing
-
mailet/dkim
+
Review comment:
fixedup
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234728#comment-17234728
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526185588
##
File path: server/queue/queue-activemq/pom.xml
##
@@ -35,9 +35,11 @@
+
Review comment:
exactly this is one of the few cases where dependency declaration order
is important more information at
https://github.com/Ekryd/sortpom/wiki/Parameters-that-can-affect-your-build
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234727#comment-17234727
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526184899
##
File path: mailbox/api/pom.xml
##
@@ -45,10 +49,6 @@
james-server-task-memory
test
-
-${james.groupId}
-apache-mime4j-dom
Review comment:
I don't understand : how can it not be internal if it is under our
groupId ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234726#comment-17234726
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526184190
##
File path:
server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##
@@ -17,19 +17,17 @@
specific language governing permissions and limitations
under the License.
-->
-http://maven.apache.org/POM/4.0.0;
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
Review comment:
it's not mandatory but because whitespace is considered non-significant
in the XML specification parsers don't keep position information in many cases
this is one of them. Since
- there were few pom affected by the whitespace removal
- this will prevent spurious modifications that humans will have to think
about
- the namespace declaration on the project tag are more or less noise to
humans
I added the few normalizations to the PR
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234713#comment-17234713
]
ASF GitHub Bot commented on JAMES-2124:
---
chibenwa commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526171502
##
File path: server/queue/queue-activemq/pom.xml
##
@@ -35,9 +35,11 @@
+
Review comment:
Prevent a reordering causing netty override to be lost i guess
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234698#comment-17234698
]
ASF GitHub Bot commented on JAMES-2124:
---
rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526153685
##
File path:
server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##
@@ -17,19 +17,17 @@
specific language governing permissions and limitations
under the License.
-->
-http://maven.apache.org/POM/4.0.0;
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
Review comment:
is this white space change mandatory?
##
File path: server/queue/queue-activemq/pom.xml
##
@@ -35,9 +35,11 @@
+
Review comment:
why?
##
File path: server/pom.xml
##
@@ -70,9 +70,9 @@
dns-service/dnsservice-library
dns-service/dnsservice-test
-mailet/integration-testing
-
mailet/dkim
+
Review comment:
this blank line does not make sense now
##
File path: mailbox/api/pom.xml
##
@@ -45,10 +49,6 @@
james-server-task-memory
test
-
-${james.groupId}
-apache-mime4j-dom
Review comment:
this one is trickier because it's not really an internal POM. Maybe we
should replace ${james.groupId} by org.apache.james here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2124) Sanitize all POM
[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234618#comment-17234618
]
ASF GitHub Bot commented on JAMES-2124:
---
jeantil opened a new pull request #263:
URL: https://github.com/apache/james-project/pull/263
This PR adds systematic enforcement of the ordering of pom dependencies and
modules. The sorting engine when rewriting a pom also enforces top level tag
ordering and tag ordering within the parent tag as they appear in the maven
project descriptor (pom xsd).
After applying this PR
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
>
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
>Affects Versions: master
>Reporter: Benoit Tellier
>Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Comment Edited] (JAMES-3451) james 3.5.0 OutOfMemoryError
[ https://issues.apache.org/jira/browse/JAMES-3451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234458#comment-17234458 ] owenzhu edited comment on JAMES-3451 at 11/18/20, 10:24 AM: [~btellier] I did not test for other databases. I didn't change the other code except for the configuration file. was (Author: owenzhu): I did not test for other databases. I didn't change the other code except for the configuration file. > james 3.5.0 OutOfMemoryError > > > Key: JAMES-3451 > URL: https://issues.apache.org/jira/browse/JAMES-3451 > Project: James Server > Issue Type: Bug > Components: mailbox >Affects Versions: 3.5.0 > Environment: aliyun linux & mysql 8 & jpa-guice >Reporter: owenzhu >Priority: Major > Attachments: bigobject.png, thread.png > > > database: mysql8 > platform: aliyun linux > jvm params: -Xms128m -Xmx2560m > When I run the James for a long time, the james server used more and more > heap memory, eventually it runs out of memory and refuse to receive email. > only restart the james will work. > java.lang.OutOfMemoryError: Java heap spacejava.lang.OutOfMemoryError: Java > heap space at com.mysql.jdbc.MysqlIO.nextRowFast(MysqlIO.java:2173) at > com.mysql.jdbc.MysqlIO.nextRow(MysqlIO.java:1992) at > com.mysql.jdbc.MysqlIO.readSingleRowSet(MysqlIO.java:3413) at > com.mysql.jdbc.MysqlIO.getResultSet(MysqlIO.java:471) at > com.mysql.jdbc.MysqlIO.readResultsForQueryOrUpdate(MysqlIO.java:3115) at > com.mysql.jdbc.MysqlIO.readAllResults(MysqlIO.java:2344) at > com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2739) at > com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2486) at > com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1858) > at com.mysql.jdbc.PreparedStatement.executeQuery(PreparedStatement.java:1966) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:302) > at > org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator$LoggingConnection$LoggingPreparedStatement.executeQuery(LoggingConnectionDecorator.java:1169) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:300) > at > org.apache.openjpa.jdbc.kernel.JDBCStoreManager$CancelPreparedStatement.executeQuery(JDBCStoreManager.java:1866) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:290) > at org.apache.openjpa.jdbc.sql.SelectImpl.executeQuery(SelectImpl.java:530) > at org.apache.openjpa.jdbc.sql.SelectImpl.execute(SelectImpl.java:455) at > org.apache.openjpa.jdbc.sql.SelectImpl.execute(SelectImpl.java:422) at > org.apache.openjpa.jdbc.sql.LogicalUnion$UnionSelect.execute(LogicalUnion.java:472) > at org.apache.openjpa.jdbc.sql.LogicalUnion.execute(LogicalUnion.java:254) > at org.apache.openjpa.jdbc.sql.LogicalUnion.execute(LogicalUnion.java:243) at > org.apache.openjpa.jdbc.kernel.SelectResultObjectProvider.open(SelectResultObjectProvider.java:95) > at > org.apache.openjpa.lib.rop.EagerResultList.(EagerResultList.java:36) at > org.apache.openjpa.kernel.QueryImpl.toResult(QueryImpl.java:1311) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:1062) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:912) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:843) at > org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:601) > at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:297) at > org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:314) at > org.apache.james.mailbox.jpa.mail.JPAMessageMapper.findMessagesInMailbox(JPAMessageMapper.java:421) > at > org.apache.james.mailbox.jpa.mail.JPAMessageMapper.findAsList(JPAMessageMapper.java:113) > I used jProfile to parse the dump file and found that many transactions were > waiting.See the attached screenshot for details. > In addition, I will find the following error in the log, I don't know whether > it is the cause of OOM, ApplicableFlags is null in debug : > 2020-11-17 21:41:00.390 [ERROR] [elastic-1226] > (o.a.j.i.p.base.SelectedMailboxImpl:367) - applicableFlags is null, > boxId=130656, mail=udysk@88mail.vip2020-11-17 21:41:00.390 [ERROR] > [elastic-1226] (o.a.j.i.p.base.SelectedMailboxImpl:367) - applicableFlags is > null, boxId=130656, mail=udysk@88mail.vip2020-11-17 21:41:00.391 [ERROR] > [elastic-1226] (o.a.j.m.e.delivery.InVmEventDelivery:71) - Error while > processing listenerjava.lang.RuntimeException: java.lang.NullPointerException > at > org.apache.james.mailbox.events.delivery.InVmEventDelivery.doDeliverToListener(InVmEventDelivery.java:86) > at >
[jira] [Commented] (JAMES-3451) james 3.5.0 OutOfMemoryError
[ https://issues.apache.org/jira/browse/JAMES-3451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234458#comment-17234458 ] owenzhu commented on JAMES-3451: I did not test for other databases. I didn't change the other code except for the configuration file. > james 3.5.0 OutOfMemoryError > > > Key: JAMES-3451 > URL: https://issues.apache.org/jira/browse/JAMES-3451 > Project: James Server > Issue Type: Bug > Components: mailbox >Affects Versions: 3.5.0 > Environment: aliyun linux & mysql 8 & jpa-guice >Reporter: owenzhu >Priority: Major > Attachments: bigobject.png, thread.png > > > database: mysql8 > platform: aliyun linux > jvm params: -Xms128m -Xmx2560m > When I run the James for a long time, the james server used more and more > heap memory, eventually it runs out of memory and refuse to receive email. > only restart the james will work. > java.lang.OutOfMemoryError: Java heap spacejava.lang.OutOfMemoryError: Java > heap space at com.mysql.jdbc.MysqlIO.nextRowFast(MysqlIO.java:2173) at > com.mysql.jdbc.MysqlIO.nextRow(MysqlIO.java:1992) at > com.mysql.jdbc.MysqlIO.readSingleRowSet(MysqlIO.java:3413) at > com.mysql.jdbc.MysqlIO.getResultSet(MysqlIO.java:471) at > com.mysql.jdbc.MysqlIO.readResultsForQueryOrUpdate(MysqlIO.java:3115) at > com.mysql.jdbc.MysqlIO.readAllResults(MysqlIO.java:2344) at > com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2739) at > com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2486) at > com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1858) > at com.mysql.jdbc.PreparedStatement.executeQuery(PreparedStatement.java:1966) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:302) > at > org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator$LoggingConnection$LoggingPreparedStatement.executeQuery(LoggingConnectionDecorator.java:1169) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:300) > at > org.apache.openjpa.jdbc.kernel.JDBCStoreManager$CancelPreparedStatement.executeQuery(JDBCStoreManager.java:1866) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:290) > at org.apache.openjpa.jdbc.sql.SelectImpl.executeQuery(SelectImpl.java:530) > at org.apache.openjpa.jdbc.sql.SelectImpl.execute(SelectImpl.java:455) at > org.apache.openjpa.jdbc.sql.SelectImpl.execute(SelectImpl.java:422) at > org.apache.openjpa.jdbc.sql.LogicalUnion$UnionSelect.execute(LogicalUnion.java:472) > at org.apache.openjpa.jdbc.sql.LogicalUnion.execute(LogicalUnion.java:254) > at org.apache.openjpa.jdbc.sql.LogicalUnion.execute(LogicalUnion.java:243) at > org.apache.openjpa.jdbc.kernel.SelectResultObjectProvider.open(SelectResultObjectProvider.java:95) > at > org.apache.openjpa.lib.rop.EagerResultList.(EagerResultList.java:36) at > org.apache.openjpa.kernel.QueryImpl.toResult(QueryImpl.java:1311) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:1062) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:912) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:843) at > org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:601) > at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:297) at > org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:314) at > org.apache.james.mailbox.jpa.mail.JPAMessageMapper.findMessagesInMailbox(JPAMessageMapper.java:421) > at > org.apache.james.mailbox.jpa.mail.JPAMessageMapper.findAsList(JPAMessageMapper.java:113) > I used jProfile to parse the dump file and found that many transactions were > waiting.See the attached screenshot for details. > In addition, I will find the following error in the log, I don't know whether > it is the cause of OOM, ApplicableFlags is null in debug : > 2020-11-17 21:41:00.390 [ERROR] [elastic-1226] > (o.a.j.i.p.base.SelectedMailboxImpl:367) - applicableFlags is null, > boxId=130656, mail=udysk@88mail.vip2020-11-17 21:41:00.390 [ERROR] > [elastic-1226] (o.a.j.i.p.base.SelectedMailboxImpl:367) - applicableFlags is > null, boxId=130656, mail=udysk@88mail.vip2020-11-17 21:41:00.391 [ERROR] > [elastic-1226] (o.a.j.m.e.delivery.InVmEventDelivery:71) - Error while > processing listenerjava.lang.RuntimeException: java.lang.NullPointerException > at > org.apache.james.mailbox.events.delivery.InVmEventDelivery.doDeliverToListener(InVmEventDelivery.java:86) > at > org.apache.james.mailbox.events.delivery.InVmEventDelivery.lambda$deliverByOption$1(InVmEventDelivery.java:69) > at > org.apache.james.mailbox.events.delivery.InVmEventDelivery$$Lambda$866/2127037983.run(Unknown > Source) at >
[jira] [Comment Edited] (JAMES-3450) Email/query reject Filter object with both FilterOperator and FilterCondition
[
https://issues.apache.org/jira/browse/JAMES-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234414#comment-17234414
]
Lan Khuat edited comment on JAMES-3450 at 11/18/20, 9:26 AM:
-
Description added.
was (Author: dlkhuat):
Descriptions added.
> Email/query reject Filter object with both FilterOperator and FilterCondition
> -
>
> Key: JAMES-3450
> URL: https://issues.apache.org/jira/browse/JAMES-3450
> Project: James Server
> Issue Type: Sub-task
>Reporter: Lan Khuat
>Priority: Major
>
> According to JMAP spec: [https://jmap.io/spec-core.html#changes] section 5.5,
> a filter object in Email/query can either be an array of FilterOperator or
> FilterCondition.
> Currently we are allowing the request to have properties from both types.
> This could lead to unexpected result when querying Email. For example:
>
> {code:java}
> {
> "using": [
> "urn:ietf:params:jmap:core",
> "urn:ietf:params:jmap:mail"],
> "methodCalls": [[
> "Email/query", {
> "accountId":
> "29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6",
> "filter": {
> "inMailbox": "1",
> "operator": "AND",
> "conditions": [
> { "hasKeyword": "custom" }, { "hasKeyword": "another_custom" }
> ]
> }
> }, "c1"]
> ]
> }
> {code}
> Email/query will ignore the _*inMailbox*_ condition in the request above.
> *DoD*
> Integration tests to show that Email/query only accept an array of
> FilterOperator or FilterCondition in their respective correct structure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-3450) Email/query reject Filter object with both FilterOperator and FilterCondition
[
https://issues.apache.org/jira/browse/JAMES-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234414#comment-17234414
]
Lan Khuat commented on JAMES-3450:
--
Descriptions added.
> Email/query reject Filter object with both FilterOperator and FilterCondition
> -
>
> Key: JAMES-3450
> URL: https://issues.apache.org/jira/browse/JAMES-3450
> Project: James Server
> Issue Type: Sub-task
>Reporter: Lan Khuat
>Priority: Major
>
> According to JMAP spec: [https://jmap.io/spec-core.html#changes] section 5.5,
> a filter object in Email/query can either be an array of FilterOperator or
> FilterCondition.
> Currently we are allowing the request to have properties from both types.
> This could lead to unexpected result when querying Email. For example:
>
> {code:java}
> {
> "using": [
> "urn:ietf:params:jmap:core",
> "urn:ietf:params:jmap:mail"],
> "methodCalls": [[
> "Email/query", {
> "accountId":
> "29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6",
> "filter": {
> "inMailbox": "1",
> "operator": "AND",
> "conditions": [
> { "hasKeyword": "custom" }, { "hasKeyword": "another_custom" }
> ]
> }
> }, "c1"]
> ]
> }
> {code}
> Email/query will ignore the _*inMailbox*_ condition in the request above.
> *DoD*
> Integration tests to show that Email/query only accept an array of
> FilterOperator or FilterCondition in their respective correct structure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Updated] (JAMES-3450) Email/query reject Filter object with both FilterOperator and FilterCondition
[
https://issues.apache.org/jira/browse/JAMES-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lan Khuat updated JAMES-3450:
-
Description:
According to JMAP spec: [https://jmap.io/spec-core.html#changes] section 5.5, a
filter object in Email/query can either be an array of FilterOperator or
FilterCondition.
Currently we are allowing the request to have properties from both types. This
could lead to unexpected result when querying Email. For example:
{code:java}
{
"using": [
"urn:ietf:params:jmap:core",
"urn:ietf:params:jmap:mail"],
"methodCalls": [[
"Email/query", {
"accountId":
"29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6",
"filter": {
"inMailbox": "1",
"operator": "AND",
"conditions": [
{ "hasKeyword": "custom" }, { "hasKeyword": "another_custom" }
]
}
}, "c1"]
]
}
{code}
Email/query will ignore the `inMailbox` condition in the request above.
*DoD*
Integration tests to show that Email/query only accept an array of
FilterOperator or FilterCondition in their respective correct structure.
> Email/query reject Filter object with both FilterOperator and FilterCondition
> -
>
> Key: JAMES-3450
> URL: https://issues.apache.org/jira/browse/JAMES-3450
> Project: James Server
> Issue Type: Sub-task
>Reporter: Lan Khuat
>Priority: Major
>
> According to JMAP spec: [https://jmap.io/spec-core.html#changes] section 5.5,
> a filter object in Email/query can either be an array of FilterOperator or
> FilterCondition.
> Currently we are allowing the request to have properties from both types.
> This could lead to unexpected result when querying Email. For example:
>
> {code:java}
> {
> "using": [
> "urn:ietf:params:jmap:core",
> "urn:ietf:params:jmap:mail"],
> "methodCalls": [[
> "Email/query", {
> "accountId":
> "29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6",
> "filter": {
> "inMailbox": "1",
> "operator": "AND",
> "conditions": [
> { "hasKeyword": "custom" }, { "hasKeyword": "another_custom" }
> ]
> }
> }, "c1"]
> ]
> }
> {code}
> Email/query will ignore the `inMailbox` condition in the request above.
>
> *DoD*
> Integration tests to show that Email/query only accept an array of
> FilterOperator or FilterCondition in their respective correct structure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Updated] (JAMES-3450) Email/query reject Filter object with both FilterOperator and FilterCondition
[
https://issues.apache.org/jira/browse/JAMES-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lan Khuat updated JAMES-3450:
-
Description:
According to JMAP spec: [https://jmap.io/spec-core.html#changes] section 5.5, a
filter object in Email/query can either be an array of FilterOperator or
FilterCondition.
Currently we are allowing the request to have properties from both types. This
could lead to unexpected result when querying Email. For example:
{code:java}
{
"using": [
"urn:ietf:params:jmap:core",
"urn:ietf:params:jmap:mail"],
"methodCalls": [[
"Email/query", {
"accountId":
"29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6",
"filter": {
"inMailbox": "1",
"operator": "AND",
"conditions": [
{ "hasKeyword": "custom" }, { "hasKeyword": "another_custom" }
]
}
}, "c1"]
]
}
{code}
Email/query will ignore the _*inMailbox*_ condition in the request above.
*DoD*
Integration tests to show that Email/query only accept an array of
FilterOperator or FilterCondition in their respective correct structure.
was:
According to JMAP spec: [https://jmap.io/spec-core.html#changes] section 5.5, a
filter object in Email/query can either be an array of FilterOperator or
FilterCondition.
Currently we are allowing the request to have properties from both types. This
could lead to unexpected result when querying Email. For example:
{code:java}
{
"using": [
"urn:ietf:params:jmap:core",
"urn:ietf:params:jmap:mail"],
"methodCalls": [[
"Email/query", {
"accountId":
"29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6",
"filter": {
"inMailbox": "1",
"operator": "AND",
"conditions": [
{ "hasKeyword": "custom" }, { "hasKeyword": "another_custom" }
]
}
}, "c1"]
]
}
{code}
Email/query will ignore the `inMailbox` condition in the request above.
*DoD*
Integration tests to show that Email/query only accept an array of
FilterOperator or FilterCondition in their respective correct structure.
> Email/query reject Filter object with both FilterOperator and FilterCondition
> -
>
> Key: JAMES-3450
> URL: https://issues.apache.org/jira/browse/JAMES-3450
> Project: James Server
> Issue Type: Sub-task
>Reporter: Lan Khuat
>Priority: Major
>
> According to JMAP spec: [https://jmap.io/spec-core.html#changes] section 5.5,
> a filter object in Email/query can either be an array of FilterOperator or
> FilterCondition.
> Currently we are allowing the request to have properties from both types.
> This could lead to unexpected result when querying Email. For example:
>
> {code:java}
> {
> "using": [
> "urn:ietf:params:jmap:core",
> "urn:ietf:params:jmap:mail"],
> "methodCalls": [[
> "Email/query", {
> "accountId":
> "29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6",
> "filter": {
> "inMailbox": "1",
> "operator": "AND",
> "conditions": [
> { "hasKeyword": "custom" }, { "hasKeyword": "another_custom" }
> ]
> }
> }, "c1"]
> ]
> }
> {code}
> Email/query will ignore the _*inMailbox*_ condition in the request above.
> *DoD*
> Integration tests to show that Email/query only accept an array of
> FilterOperator or FilterCondition in their respective correct structure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-3446) Outlook Mobile App Imap request error
[ https://issues.apache.org/jira/browse/JAMES-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234411#comment-17234411 ] Benoit Tellier commented on JAMES-3446: --- > password is the special character not recognized? Please refer to https://tools.ietf.org/html/rfc3501#section-4.3 : you likely need a quoted string as literals do not accept *... > Outlook Mobile App Imap request error > -- > > Key: JAMES-3446 > URL: https://issues.apache.org/jira/browse/JAMES-3446 > Project: James Server > Issue Type: Bug >Affects Versions: 3.0-beta4 >Reporter: seungmin >Priority: Major > Fix For: 3.0.0 > > Attachments: 20201117.cap, 20201117.cap, Capture d’écran de > 2020-11-17 09-57-45.png, image-2020-11-14-16-17-51-011.png, > image-2020-11-16-10-31-15-497.png, image-2020-11-16-14-23-24-498.png, > image-2020-11-16-14-25-06-005.png, image-2020-11-16-16-30-07-096.png, > image-2020-11-16-16-33-36-050.png, image-2020-11-16-16-33-37-781.png, > image-2020-11-16-16-58-33-360.png, image-2020-11-16-17-22-57-210.png, > image-2020-11-17-00-26-57-359.png, image-2020-11-17-00-27-10-493.png, > image-2020-11-17-00-27-58-590.png, image-2020-11-17-00-29-16-919.png, > image-2020-11-17-00-30-23-988.png, image-2020-11-17-00-31-42-025.png, > image-2020-11-18-16-09-15-340.png, image-2020-11-18-16-57-57-404.png, > image-2020-11-18-16-58-07-743.png, image-2020-11-18-18-08-55-845.png > > > !image-2020-11-14-16-17-51-011.png! > > - only outlook mobile app > Error while processing imap request > cosumeWord source same master james source > but gmail app, samsung mail app no problem > > "only" outlook mobile issue -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: apache/james on docker hub.
Le 18/11/2020 à 16:09, Jean Helou a écrit : > [...] >> I am not sure where other apache projects source the machines >> >> running the CI but at least https://github.com/apache/pulsar-helm-chart >>> seems to have access to some serious compute power... >> INFRA is by default not powerful (likely not enough). A way out is >> "donating computing power for dedicated project builds". >> >> Hence we would need some individual/organization donating computing >> power to the Apache foundation for Apache James usage. >> >> I like the idea, and I would be happy to defend the idea within >> Linagora, but I need a working build on Apache infra first. Likely it >> would be a few "dedicated servers", but it would also need internal >> validation. >> >> > I have asked a friend who may be able to help, I also found > https://www.scaleway.com/en/about-us/open-source-program/ which seems > promising. It starts by sending an email to opensource-prog...@scaleway.com > Scaleway is where I intend to run my SMTP relay (using my own compute > resources) once it is finished assembling, I started working on a helm > chart that's deployed on scaleway Kapsule. > Once it works reasonably well, I intend to contribute it back to > james/apache but that's gonna take a while Thanks for sharing! > > Jean > - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: apache/james on docker hub.
> > I like the idea, and I would be happy to defend the idea within >> Linagora, but I need a working build on Apache infra first. Likely it >> would be a few "dedicated servers", but it would also need internal >> validation. > > AWS also has this kind of program : https://aws.amazon.com/blogs/opensource/aws-promotional-credits-open-source-projects/ > Jean >
[jira] [Commented] (JAMES-3446) Outlook Mobile App Imap request error
[ https://issues.apache.org/jira/browse/JAMES-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234405#comment-17234405 ] seungmin commented on JAMES-3446: - !image-2020-11-18-18-08-55-845.png! Ignored Unknown Record Is there a possibility of this problem? > Outlook Mobile App Imap request error > -- > > Key: JAMES-3446 > URL: https://issues.apache.org/jira/browse/JAMES-3446 > Project: James Server > Issue Type: Bug >Affects Versions: 3.0-beta4 >Reporter: seungmin >Priority: Major > Fix For: 3.0.0 > > Attachments: 20201117.cap, 20201117.cap, Capture d’écran de > 2020-11-17 09-57-45.png, image-2020-11-14-16-17-51-011.png, > image-2020-11-16-10-31-15-497.png, image-2020-11-16-14-23-24-498.png, > image-2020-11-16-14-25-06-005.png, image-2020-11-16-16-30-07-096.png, > image-2020-11-16-16-33-36-050.png, image-2020-11-16-16-33-37-781.png, > image-2020-11-16-16-58-33-360.png, image-2020-11-16-17-22-57-210.png, > image-2020-11-17-00-26-57-359.png, image-2020-11-17-00-27-10-493.png, > image-2020-11-17-00-27-58-590.png, image-2020-11-17-00-29-16-919.png, > image-2020-11-17-00-30-23-988.png, image-2020-11-17-00-31-42-025.png, > image-2020-11-18-16-09-15-340.png, image-2020-11-18-16-57-57-404.png, > image-2020-11-18-16-58-07-743.png, image-2020-11-18-18-08-55-845.png > > > !image-2020-11-14-16-17-51-011.png! > > - only outlook mobile app > Error while processing imap request > cosumeWord source same master james source > but gmail app, samsung mail app no problem > > "only" outlook mobile issue -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: apache/james on docker hub.
> > I would love to see this happening but I fail at seeing progress on the > Apache level CI for several months already. thanks for clarifying the context :/ Correlating things together would likely lead to getting nothing done. Indeed > I am not sure where other apache projects source the machines > > running the CI but at least https://github.com/apache/pulsar-helm-chart > > seems to have access to some serious compute power... > > INFRA is by default not powerful (likely not enough). A way out is > "donating computing power for dedicated project builds". > > Hence we would need some individual/organization donating computing > power to the Apache foundation for Apache James usage. > > I like the idea, and I would be happy to defend the idea within > Linagora, but I need a working build on Apache infra first. Likely it > would be a few "dedicated servers", but it would also need internal > validation. > > I have asked a friend who may be able to help, I also found https://www.scaleway.com/en/about-us/open-source-program/ which seems promising. It starts by sending an email to opensource-prog...@scaleway.com Scaleway is where I intend to run my SMTP relay (using my own compute resources) once it is finished assembling, I started working on a helm chart that's deployed on scaleway Kapsule. Once it works reasonably well, I intend to contribute it back to james/apache but that's gonna take a while Jean
[jira] [Updated] (JAMES-3446) Outlook Mobile App Imap request error
[ https://issues.apache.org/jira/browse/JAMES-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] seungmin updated JAMES-3446: Attachment: image-2020-11-18-18-08-55-845.png > Outlook Mobile App Imap request error > -- > > Key: JAMES-3446 > URL: https://issues.apache.org/jira/browse/JAMES-3446 > Project: James Server > Issue Type: Bug >Affects Versions: 3.0-beta4 >Reporter: seungmin >Priority: Major > Fix For: 3.0.0 > > Attachments: 20201117.cap, 20201117.cap, Capture d’écran de > 2020-11-17 09-57-45.png, image-2020-11-14-16-17-51-011.png, > image-2020-11-16-10-31-15-497.png, image-2020-11-16-14-23-24-498.png, > image-2020-11-16-14-25-06-005.png, image-2020-11-16-16-30-07-096.png, > image-2020-11-16-16-33-36-050.png, image-2020-11-16-16-33-37-781.png, > image-2020-11-16-16-58-33-360.png, image-2020-11-16-17-22-57-210.png, > image-2020-11-17-00-26-57-359.png, image-2020-11-17-00-27-10-493.png, > image-2020-11-17-00-27-58-590.png, image-2020-11-17-00-29-16-919.png, > image-2020-11-17-00-30-23-988.png, image-2020-11-17-00-31-42-025.png, > image-2020-11-18-16-09-15-340.png, image-2020-11-18-16-57-57-404.png, > image-2020-11-18-16-58-07-743.png, image-2020-11-18-18-08-55-845.png > > > !image-2020-11-14-16-17-51-011.png! > > - only outlook mobile app > Error while processing imap request > cosumeWord source same master james source > but gmail app, samsung mail app no problem > > "only" outlook mobile issue -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-3451) james 3.5.0 OutOfMemoryError
[ https://issues.apache.org/jira/browse/JAMES-3451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234383#comment-17234383 ] Benoit Tellier commented on JAMES-3451: --- Does it happen only for mysql? Can you submit a patch for this? > james 3.5.0 OutOfMemoryError > > > Key: JAMES-3451 > URL: https://issues.apache.org/jira/browse/JAMES-3451 > Project: James Server > Issue Type: Bug > Components: mailbox >Affects Versions: 3.5.0 > Environment: aliyun linux & mysql 8 & jpa-guice >Reporter: owenzhu >Priority: Major > Attachments: bigobject.png, thread.png > > > database: mysql8 > platform: aliyun linux > jvm params: -Xms128m -Xmx2560m > When I run the James for a long time, the james server used more and more > heap memory, eventually it runs out of memory and refuse to receive email. > only restart the james will work. > java.lang.OutOfMemoryError: Java heap spacejava.lang.OutOfMemoryError: Java > heap space at com.mysql.jdbc.MysqlIO.nextRowFast(MysqlIO.java:2173) at > com.mysql.jdbc.MysqlIO.nextRow(MysqlIO.java:1992) at > com.mysql.jdbc.MysqlIO.readSingleRowSet(MysqlIO.java:3413) at > com.mysql.jdbc.MysqlIO.getResultSet(MysqlIO.java:471) at > com.mysql.jdbc.MysqlIO.readResultsForQueryOrUpdate(MysqlIO.java:3115) at > com.mysql.jdbc.MysqlIO.readAllResults(MysqlIO.java:2344) at > com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2739) at > com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2486) at > com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1858) > at com.mysql.jdbc.PreparedStatement.executeQuery(PreparedStatement.java:1966) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:302) > at > org.apache.openjpa.lib.jdbc.LoggingConnectionDecorator$LoggingConnection$LoggingPreparedStatement.executeQuery(LoggingConnectionDecorator.java:1169) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:300) > at > org.apache.openjpa.jdbc.kernel.JDBCStoreManager$CancelPreparedStatement.executeQuery(JDBCStoreManager.java:1866) > at > org.apache.openjpa.lib.jdbc.DelegatingPreparedStatement.executeQuery(DelegatingPreparedStatement.java:290) > at org.apache.openjpa.jdbc.sql.SelectImpl.executeQuery(SelectImpl.java:530) > at org.apache.openjpa.jdbc.sql.SelectImpl.execute(SelectImpl.java:455) at > org.apache.openjpa.jdbc.sql.SelectImpl.execute(SelectImpl.java:422) at > org.apache.openjpa.jdbc.sql.LogicalUnion$UnionSelect.execute(LogicalUnion.java:472) > at org.apache.openjpa.jdbc.sql.LogicalUnion.execute(LogicalUnion.java:254) > at org.apache.openjpa.jdbc.sql.LogicalUnion.execute(LogicalUnion.java:243) at > org.apache.openjpa.jdbc.kernel.SelectResultObjectProvider.open(SelectResultObjectProvider.java:95) > at > org.apache.openjpa.lib.rop.EagerResultList.(EagerResultList.java:36) at > org.apache.openjpa.kernel.QueryImpl.toResult(QueryImpl.java:1311) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:1062) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:912) at > org.apache.openjpa.kernel.QueryImpl.execute(QueryImpl.java:843) at > org.apache.openjpa.kernel.DelegatingQuery.execute(DelegatingQuery.java:601) > at org.apache.openjpa.persistence.QueryImpl.execute(QueryImpl.java:297) at > org.apache.openjpa.persistence.QueryImpl.getResultList(QueryImpl.java:314) at > org.apache.james.mailbox.jpa.mail.JPAMessageMapper.findMessagesInMailbox(JPAMessageMapper.java:421) > at > org.apache.james.mailbox.jpa.mail.JPAMessageMapper.findAsList(JPAMessageMapper.java:113) > I used jProfile to parse the dump file and found that many transactions were > waiting.See the attached screenshot for details. > In addition, I will find the following error in the log, I don't know whether > it is the cause of OOM, ApplicableFlags is null in debug : > 2020-11-17 21:41:00.390 [ERROR] [elastic-1226] > (o.a.j.i.p.base.SelectedMailboxImpl:367) - applicableFlags is null, > boxId=130656, mail=udysk@88mail.vip2020-11-17 21:41:00.390 [ERROR] > [elastic-1226] (o.a.j.i.p.base.SelectedMailboxImpl:367) - applicableFlags is > null, boxId=130656, mail=udysk@88mail.vip2020-11-17 21:41:00.391 [ERROR] > [elastic-1226] (o.a.j.m.e.delivery.InVmEventDelivery:71) - Error while > processing listenerjava.lang.RuntimeException: java.lang.NullPointerException > at > org.apache.james.mailbox.events.delivery.InVmEventDelivery.doDeliverToListener(InVmEventDelivery.java:86) > at > org.apache.james.mailbox.events.delivery.InVmEventDelivery.lambda$deliverByOption$1(InVmEventDelivery.java:69) > at > org.apache.james.mailbox.events.delivery.InVmEventDelivery$$Lambda$866/2127037983.run(Unknown > Source) at >
Re: apache/james on docker hub.
Le 18/11/2020 à 15:00, Jean Helou a écrit : >> I would like us to start as part as the release process to publish >> convenience binaries under apache name, just like some other Apache >> projects are doing: https://issues.apache.org/jira/browse/INFRA-19650 > > > This is a bit of a shameless suggestion but wouldn't it make sense to use > the opportunity to setup an automated public CI ? I would love to see this happening but I fail at seeing progress on the Apache level CI for several months already. Correlating things together would likely lead to getting nothing done. I am willing to add publishing docker images to the release process, but will not find the resources to make this automated public CI happen. Note that asking dockerhub access is not incompatible with CI work. > Something that > automatically publishes release versions from master, and builds PRs would > be nice. Something that automatically builds master branch and peoples PR should IMO have a higher priority. BTW given http://www.apache.org/legal/release-policy.html#approving-a-release a two stage process would likely be needed. > I am not sure where other apache projects source the machines > running the CI but at least https://github.com/apache/pulsar-helm-chart > seems to have access to some serious compute power... INFRA is by default not powerful (likely not enough). A way out is "donating computing power for dedicated project builds". Hence we would need some individual/organization donating computing power to the Apache foundation for Apache James usage. I like the idea, and I would be happy to defend the idea within Linagora, but I need a working build on Apache infra first. Likely it would be a few "dedicated servers", but it would also need internal validation. Benoit > with a bit of luck > that could also benefit from shared credentials to push apache docker > images without needing any single user to have specific rights> > jean > - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: apache/james on docker hub.
> I would like us to start as part as the release process to publish > convenience binaries under apache name, just like some other Apache > projects are doing: https://issues.apache.org/jira/browse/INFRA-19650 This is a bit of a shameless suggestion but wouldn't it make sense to use the opportunity to setup an automated public CI ? Something that automatically publishes release versions from master, and builds PRs would be nice. I am not sure where other apache projects source the machines running the CI but at least https://github.com/apache/pulsar-helm-chart seems to have access to some serious compute power...with a bit of luck that could also benefit from shared credentials to push apache docker images without needing any single user to have specific rights jean
