[jdk23] Integrated: 8333827: JDK 23 RDP1 L10n resource files update
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and > was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, > Chris Plummer, Alexey Semenyuk and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: a7964453 Author:Damon Nguyen URL: https://git.openjdk.org/jdk/commit/a7964453cf5203229d4a5b5231b7fc86da5d4af8 Stats: 237 lines in 38 files changed: 133 ins; 57 del; 47 mod 8333827: JDK 23 RDP1 L10n resource files update Reviewed-by: jlu, naoto Backport-of: c4702ca8c026e2d265aca0126fd3fb7bc5bb392a - PR: https://git.openjdk.org/jdk/pull/19713
[jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update
Hi all, This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, Chris Plummer, Alexey Semenyuk and Phil Race. Thanks! - Commit messages: - Backport c4702ca8c026e2d265aca0126fd3fb7bc5bb392a Changes: https://git.openjdk.org/jdk/pull/19713/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19713=00 Issue: https://bugs.openjdk.org/browse/JDK-8333827 Stats: 237 lines in 38 files changed: 133 ins; 57 del; 47 mod Patch: https://git.openjdk.org/jdk/pull/19713.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19713/head:pull/19713 PR: https://git.openjdk.org/jdk/pull/19713
Integrated: 8333827: JDK 23 RDP1 L10n resource files update
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ This pull request has now been integrated. Changeset: c4702ca8 Author:Damon Nguyen URL: https://git.openjdk.org/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a Stats: 237 lines in 38 files changed: 133 ins; 57 del; 47 mod 8333827: JDK 23 RDP1 L10n resource files update Reviewed-by: achung, jlu, naoto, joehw, prappo, cjplummer, asemenyuk, prr - PR: https://git.openjdk.org/jdk/pull/19609
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]
On Mon, 10 Jun 2024 23:11:04 GMT, Jonathan Gibbons wrote: >> @jonathan-gibbons I just realized that this change to the German file >> matches the file with the Japanese and Chinese localized files. By that I >> mean the "backwards" translations are also present for the Japanese and >> Chinese files. >> >> However, the previous versions of the Japanese and Chinese files don't have >> these bits translated. So in summary, I can revert the German file back to >> German but the Japanese and Chinese files will still be English for these >> parts because I wouldn't know what to revert them to in their local language. >> >> As a result, I actually think it might be better to change this German file >> as shown in the current version of the PR just to remain consistent with the >> other localized versions of this file. We can still bring this up to the go >> team as an issue, but I think this is the best solution now for this drop at >> least. > > No one else except people reading this PR will spot inconsistencies between > translations in different languages. So inconsistencies across languages will > not be obvious to end users. > > But anyone (end-user) using the tool in any one of these languages is likely > to spot inconsistencies in the translations for that one language. @jonathan-gibbons I have gone back and manually undid some of the English translations back to its former German word. Most occurrences of this are `` to ``, but some others were changed back as well. Could you re-review this? - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1637092298
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Undo translation for some words - Changes: - all: https://git.openjdk.org/jdk/pull/19609/files - new: https://git.openjdk.org/jdk/pull/19609/files/e9e0bcea..8c22d1db Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19609=03 - incr: https://webrevs.openjdk.org/?repo=jdk=19609=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert updated translation - Changes: - all: https://git.openjdk.org/jdk/pull/19609/files - new: https://git.openjdk.org/jdk/pull/19609/files/32d69e89..e9e0bcea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19609=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19609=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein wrote: >> "Ausgabefächer" is the best German translation here. > > The reason for going with "Bereich (area)" instead of "Fach (compartment)" is > that an area is more general compared to a compartment. At least in German: > every "Fach" is a "Bereich", but every "Bereich" is NOT a "Fach". Thanks for the input @sormuras! - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635369067
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 22:19:49 GMT, Chris Plummer wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove double quotes
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
> line 325:
>
>> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
>> 324: {"unknown", "unbekannt"},
>> 325: {"Unmonitoring", "Monitoring von {0} aufheben"},
>
> The English entry is:
>
> {"Unmonitoring", "Unmonitoring {0} "},
>
> But the German entry now says "Monitoring". I'm sure what the original
> "\u00DCberwachung" translates to, other than berwachung is monitoring. Now
> this resource is partly in English, and is the incorrect English.
I don't know German, but when plugging `"Monitoring von {0} aufheben"` into
google translate, I get `Unmonitoring` as well. Maybe `Monitoring` is a word
that could also be used in German? No clue. The translation tool decided to
make this change.
@sormuras do you have any input on this?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633925334
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Remove double quotes - Changes: - all: https://git.openjdk.org/jdk/pull/19609/files - new: https://git.openjdk.org/jdk/pull/19609/files/9125337b..32d69e89 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19609=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19609=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote: >> This is what I've determined as well. I planned to leave these untranslated >> to reduce noise between drops as well. > > While we do not translate Java keywords (when used as such, e.g. "`class` not > allowed here"), and option names (e.g. `--class-path`) we have typically > translated other text that is not mandated by the language or tools, (e.g. > `the name of this class`, ``, ``. > > This change seems to be going backwards. > > Whatever the policy we use for translating (or not translating) parts of a > message, we should be consistent across all tools and documents. @jonathan-gibbons I just realized that this change to the German file matches the file with the Japanese and Chinese localized files. By that I mean the "backwards" translations are also present for the Japanese and Chinese files. However, the previous versions of the Japanese and Chinese files don't have these bits translated. So in summary, I can revert the German file back to German but the Japanese and Chinese files will still be English for these parts because I wouldn't know what to revert them to in their local language. As a result, I actually think it might be better to change this German file as shown in the current version of the PR just to remain consistent with the other localized versions of this file. We can still bring this up to the go team as an issue, but I think this is the best solution now for this drop at least. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633859027
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: > Did not look at each for translation accuracy (did some for Japanese), but > looks good overall. It's great to see diffs in native languages, rather than > those cryptic `\u` notation! Justin's tool is responsible for this. Made the process quicker/simpler as well once everything was setup properly and working. - PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2159331304
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:20:52 GMT, Phil Race wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties > line 32: > >> 30: border.jobattributes=作业属性 >> 31: border.media=介质 >> 32: border.output=出纸 > > What triggered this ? Just someone noticing it and deciding there's a better > translation ? > What does it say ? In the past, it was brought up in review that some of the words were translated to localized words that didn't exactly mean what the original English word meant. I believe Weijun Wang caught some of these in Chinese files in the past. I'm assuming these are cases where the go team is improving the translation, but I also can't exactly tell. We do suggest changes to the go team, so maybe this is evidence of them improving their tool. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633801033
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote: >> This is what I've determined as well. I planned to leave these untranslated >> to reduce noise between drops as well. > > While we do not translate Java keywords (when used as such, e.g. "`class` not > allowed here"), and option names (e.g. `--class-path`) we have typically > translated other text that is not mandated by the language or tools, (e.g. > `the name of this class`, ``, ``. > > This change seems to be going backwards. > > Whatever the policy we use for translating (or not translating) parts of a > message, we should be consistent across all tools and documents. The go translation team dictates which of these segments within a file actually get updated. I can manually revert the segments if preferred, but these changes will continue appearing for future drops with the current system. I can potentially try to communicate to the other team to differentiate between keywords & option names versus some of these other words, but let me know how you'd like me to proceed with this. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633794362
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:20:26 GMT, Jonathan Gibbons wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties > line 409: > >> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl >> ein nicht bedingtes Muster als auch ein Standardlabel >> 408: >> 409: compiler.err.unconditional.pattern.and.both.boolean.values=Switch >> umfasst sowohl boolesche Werte als auch ein nicht bedingtes Muster > > Here and elsewhere in this file and other translations, I'm surprised > `switch` is not being translated, and is being capitalized. In the English > form, it is not being used as a keyword, although could maybe be seen as a > short form of `switch' statement, in which case `switch` should be treated as > a keyword and not translated or capitalized. Good catch. Seems to be across all files and I'm assuming it's for the reason you suggested. I'll bring this up to the go team. I have no way to fix this since I can't rely on google translate. This can be caught in a future update if the go team can successfully differentiate the difference between the word `switch` and a `switch keyword`. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633796771
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Sun, 9 Jun 2024 22:49:11 GMT, Justin Lu wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The translation tool adjusted some definitions, which causes some changes in
>> localized files where the source file had no changes. This causes some words
>> being reverted from localized languages to English, and some had its
>> definitions changed.
>>
>> Alternatively, the diffs are viewable here and was generated using John
>> Gibbon's diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties
> line 1:
>
>> 1: #
>
> It looks like these .properties files need to have their copyright years
> bumped. I believe since the original was not bumped, the translation tool did
> not reflect the correct year in the localized versions.
Right, the source file has the copyright year of 2019, and these translated
files reflect that, so I believe this is OK.
> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties
> line 66:
>
>> 64: label.size=大小():
>> 65: label.source=来源():
>> 66: label.outputbins=输出托盘()：
>
> Looks like the translation tool changed this from a colon (U+003A) to a full
> width colon (U+FF1A). There are l10n rules when it comes to punctuation, I am
> not sure if this is a result of that. It looks like the surrounding
> key/values are simply using (U+003A) colons. If we decide to revert this
> colon change, we need to also probably file a bug against the translation
> tool.
Right, I agree. I'm OK with either decision too, but I'm leaning towards
reverting this to standardize the colons since the rest are (U+003A). Maybe a
reviewer from desktop can chime in once this PR is undrafted.
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
> line 278:
>
>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements
>> "{0}" verweist auf das nicht deklarierte Element "{1}".
>> 277: UniqueNotationName = Deklaration für die Notation "{0}" ist
>> nicht eindeutig. Ein jeweiliger Name darf nicht in mehreren
>> Notationsdeklarationen deklariert werden.
>> 278: ENTITYFailedInitializeGrammar = ENTITYDatatype-Validator:
>> Nicht erfolgreich. Initialisierungsmethode muss mit einer gültigen
>> Grammatikreferenz aufgerufen werden. \t
>
> It looks like the _zh_CN_ file should also have the `\t` removed, but such
> changes are done by the translation tool. I think in this case, we should
> manually remove it, and then file a bug against the translation tool.
Yeah, I believe you're right. Noted as something else to file against the
translation tool.
> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties
> line 183:
>
>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach
>> Umschalt+Tab.\nVerwenden Sie "I" für automatischen Import, "V" zur
>> Variablenerstellung oder "M" zur Methodenerstellung.\nWeitere Informationen
>> finden Sie unter:\n/help shortcuts
>> 182:
>> 183: help.usage = Verwendung: jshell ... ...\nMögliche
>> Optionen:\n--class-pathGibt an, wo die Benutzerklassendateien
>> gespeichert sind\n--module-path Gibt an, wo die Anwendungsmodule
>> gespeichert sind\n--add-modules (,)*\n
>>Gibt aufzulösende Module oder alle Module im\n
>> Modulpfad an, wenn ALL-MODULE-PATHs lautet\n
>> --enable-native-access\n Ermöglicht Ausführung
>> eingeschränkter nativer Methoden durch Code\n--enable-preview Code
>> kann Vorschaufeatures in diesem Release nutzen\n--startup
>> Ersetzung der Startdefinitionen mit einer Ausführung\n--no-startup
>>Startdefinitionen werden nicht ausgeführt\n--feedback
>> Gibt den anfänglichen Feedbackmodus an. Der Modus kann\n
>>vordefiniert (Silent, Concise, Normal oder Verbose) oder\n
>>
vorab benutzerdefiniert sein\n-qStilles Feedback.
Identisch mit: --feedback concise\n-sÄußerst stilles
Feedback. Identisch mit: --feedback silent\n-v
Verbose-Feedback. Identisch mit: --feedback verbose\n-J
Übergibt an das Laufzeitsystem, hat aber keine Auswirkungen\n
auf die Ausführung von Code-Snippets. Um Kennzeichen
anzugeben,\ndie die Ausführung von Code-Snippets
beeinflussen, verwenden Sie\n-R. Verwenden
Sie alternativ dazu -J mit\n--execution
local.\n-R Übergibt nur dann an das
Laufzeitsystem, wenn\n
RFR: 8333827: JDK 23 RDP1 L10n resource files update
This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed. Alternatively, the diffs are viewable here and was generated using John Gibbon's diff tool for l10n: https://cr.openjdk.org/~dnguyen/output2/ - Commit messages: - Review comment edits - Initial localization changes Changes: https://git.openjdk.org/jdk/pull/19609/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19609=00 Issue: https://bugs.openjdk.org/browse/JDK-8333827 Stats: 239 lines in 39 files changed: 133 ins; 57 del; 49 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
[jdk20] Integrated: 8300719: JDK 20 RDP2 L10n resource files update
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote: > Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed This pull request has now been integrated. Changeset: a67b1e77 Author: Damon Nguyen Committer: Naoto Sato URL: https://git.openjdk.org/jdk20/commit/a67b1e77d9f5db36c6d15bac0423a31eb5ee Stats: 1023 lines in 82 files changed: 218 ins; 114 del; 691 mod 8300719: JDK 20 RDP2 L10n resource files update Reviewed-by: cjplummer, naoto, prr, joehw, asemenyuk, jlu, lancea, ihse, jjg, weijun - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v9]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Replace exception-type - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/35829a25..53a86ef2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=116=08 - incr: https://webrevs.openjdk.org/?repo=jdk20=116=07-08 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Wed, 25 Jan 2023 22:38:38 GMT, Jonathan Gibbons wrote: >> It's not a noun. It's an adjective that I had to synthesize for extra >> clarity and closeness to Java Language Specification (JLS). The English >> version of that entry is as follows: >> >> doclet.throwsInheritDocUnsupported=@inheritDoc is not supported for >> exception-type type parameters \ >> that are not declared by a method; document such exception types directly >> >> JLS _8.4.6. Method Throws_ defines BNF which conveniently labels elements, a >> list of which may appear in the `throws` clause, as `ExceptionType`. To make >> it more English-like and separate two otherwise consecutive occurrences of >> "type" in that sentence, I split the words with a hyphen and lower-cased >> them: exception-type. >> >> @jonathan-gibbons thoughts? > > While the text is technically correct, it may not be as clear as it could be > to all folk that will read this message for whom English is not their primary > language. > > I would suggest translating the phrase as if it were something like > > @inheritDoc is not supported for type parameters that are exception types and > not declared by a method > > > and secondarily, changing the English resource to something like that as well. Updated this line with `exception-type` translated. Hopefully this will be addressed in future drops with changes to the translation tool after some bug fixes. - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]
On Wed, 25 Jan 2023 08:17:26 GMT, danielpeintner wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change German help of jar command > > src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_de.properties line > 111: > >> 109: main.help.opt.main.update=\ -u, --update Ein vorhandenes >> JAR-Archiv aktualisieren >> 110: main.help.opt.main.extract=\ -x, --extract Benannte (oder >> alle) Dateien aus dem Archiv extrahieren >> 111: main.help.opt.main.describe-module=\ -d, --describe-module Gibt >> den Moduldeskriptor oder automatischen Modulnamen aus > > Just because I stumbled over this commit. I think the line should be > translated as follows: > > `Gibt die Modulbeschreibung oder den automatischen Modulnamen aus` Resolved - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v8]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Update German translation - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/9a5b45a2..35829a25 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=116=07 - incr: https://webrevs.openjdk.org/?repo=jdk20=116=06-07 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Wed, 25 Jan 2023 17:49:59 GMT, Weijun Wang wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert culture attribute
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties
> line 113:
>
>> 111:
>> doclet.inheritDocWithinInappropriateTag=\u4E0D\u80FD\u5728\u6B64\u6807\u8BB0\u4E2D\u4F7F\u7528
>> @inheritDoc
>> 112:
>> doclet.inheritDocNoDoc=\u88AB\u8986\u76D6\u7684\u65B9\u6CD5\u4E0D\u8BB0\u5F55\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>> {0}
>> 113:
>> doclet.throwsInheritDocUnsupported=\u4E0D\u662F\u7531\u65B9\u6CD5\u58F0\u660E\u7684
>> exception-type \u7C7B\u578B\u53C2\u6570\u4E0D\u652F\u6301
>> @inheritDoc\uFF1B\u76F4\u63A5\u8BB0\u5F55\u6B64\u7C7B\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>
> Should `exception-type` be translated?
The translation tool didn't seem to translate this. Either because it couldn't
or because it somehow missed it. I'm not sure which, but I'm open to replacing
this with a translation suggestion you have. Or I can leave it as is.
> src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties
> line 32:
>
>> 30:
>> err.bad.constant.pool=\u8BFB\u53D6{0}\u7684\u5E38\u91CF\u6C60\u65F6\u51FA\u9519:
>> {1}
>> 31: err.class.not.found=\u627E\u4E0D\u5230\u7C7B: {0}
>> 32:
>> err.crash=\u51FA\u73B0\u4E25\u91CD\u7684\u5185\u90E8\u9519\u8BEF\uFF1A{0}\n\u8BF7\u586B\u5199
>> Bug \u62A5\u544A\uFF0C\u5E76\u5305\u62EC\u4EE5\u4E0B\u4FE1\u606F\uFF1A\n{1}
>
> While personally I like to see Chinese-style punctuation marks (Ex: `：`) used
> in Chinese contexts instead of their English-style ones (Ex: `:`), it's only
> updated on this single line and all the others are still using the
> English-style.
>
> There should be a general rule on which style we should use throughout all
> display messages.
Updated the punctuation (colons and comma) to be more consistent throughout the
file.
-
PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v7]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert one more punctuation - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/4222df9a..9a5b45a2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=116=06 - incr: https://webrevs.openjdk.org/?repo=jdk20=116=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v6]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert translated punctuation - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/616b2502..4222df9a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=116=05 - incr: https://webrevs.openjdk.org/?repo=jdk20=116=04-05 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]
On Tue, 24 Jan 2023 23:16:02 GMT, Alexey Semenyuk wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change localization codes. Add CNY back > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_zh_CN.wxl > line 2: > >> 1: >> 2: > xmlns="http://schemas.microsoft.com/wix/2006/localization; Codepage="936"> > > Please revert the value of the Culture attribute. Resolved in recent commit - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]
On Tue, 24 Jan 2023 22:55:43 GMT, Alexey Semenyuk wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change German help of jar command > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl > line 2: > >> 1: >> 2: > xmlns="http://schemas.microsoft.com/wix/2006/localization; Codepage="1252"> > > Please revert the value of the `Culture` attribute. I resolved this for the German, Japanese, and Chinese files in the latest commit. > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_ja.wxl > line 2: > >> 1: >> 2: > xmlns="http://schemas.microsoft.com/wix/2006/localization; Codepage="932"> > > Please revert the value of the `Culture` attribute. Resolved in recent commit - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]
On Tue, 24 Jan 2023 23:02:58 GMT, Justin Lu wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change localization codes. Add CNY back > > src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_ja.properties > line 62: > >> 60: dedup-legal-notices.usage=\ --dedup-legal-notices >> [error-if-not-same-content]\n >> \u3059\u3079\u3066\u306E\u6CD5\u5F8B\u4E0A\u306E\u6CE8\u610F\u70B9\u306E\u91CD\u8907\u3092\u9664\u5916\u3057\u307E\u3059\u3002\n >> >> error-if-not-same-content\u304C\u6307\u5B9A\u3055\u308C\u3066\u3044\u308B\u5834\u5408\u3001\n >> >> \u540C\u3058\u30D5\u30A1\u30A4\u30EB\u540D\u306E2\u3064\u306E\u30D5\u30A1\u30A4\u30EB\u304C\u7570\u306A\u3063\u3066\u3044\u308B\u3068\n >> >> \u30A8\u30E9\u30FC\u306B\u306A\u308A\u307E\u3059\u3002 >> 61: >> 62: >> exclude-files.argument=\u9664\u5916\u3059\u308B\u30D5\u30A1\u30A4\u30EB\u306E >> > > It seems like the translation process added a space here, but it does not > appear in the original. This should be removed. Removed both instances of the extra trailing whitespace. > src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties > line 194: > >> 192: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 >> 193: >> 194: main.plugin.category=\u7C7B\u522B > > Same as above. Addressed as above - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert culture attribute - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/fc32c37f..616b2502 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=116=04 - incr: https://webrevs.openjdk.org/?repo=jdk20=116=03-04 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v4]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Remove trailing whitespace - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/40291c61..fc32c37f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=116=03 - incr: https://webrevs.openjdk.org/?repo=jdk20=116=02-03 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]
On Tue, 24 Jan 2023 22:49:20 GMT, Naoto Sato wrote: >> This change was made because it was compared to the original >> messages.properties. In that file, the respective line is given as >> `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with no trailing >> space. That's why in this file, to ensure consistency, the trailing space >> was stripped. >> >> I think either this space should be removed, or all 4 (en, ja, de, zh) >> should have the `\u0020` appended. I agree that since it is a prefix it >> would make sense for a space to be there, but there is no guarantee that >> what comes after, or even the code that loads the .properties file does not >> already handles that necessary space. >> >> Should the space remain removed like in the English source file and the >> other l10n files, or do you think all 4 should be changed to add `\u0020`? > > Confirmed that the message is for a label > (`sun.tools.jconsole.LabeledComponent`), followed by a Component, so no space > seems needed in each file. Sorry for the false alarm. Ok I left this change out of my most recent update just in case. I addressed all the other comments I believe. Thanks! - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]
On Tue, 24 Jan 2023 22:14:36 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change localization codes. Add CNY back > > src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.properties > line 63: > >> 61: # written authorization of the copyright holder. >> 62: >> 63: CNY=\uffe5 > > Do not remove this. Added back. Thanks for catching this! - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]
On Tue, 24 Jan 2023 22:12:02 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change German help of jar command > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties > line 38: > >> 36: resource.post-msi-script=Auszuf\u00FChrendes Skript nach dem Erstellen >> der MSI-Datei f\u00FCr das EXE-Installationsprogramm >> 37: resource.wxl-file=WiX-Lokalisierungsdatei >> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl > > Shouldn't this be `de`? Changed back similar to with zh_CN > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties > line 38: > >> 36: >> resource.post-msi-script=exe\u30A4\u30F3\u30B9\u30C8\u30FC\u30E9\u306Emsi\u30D5\u30A1\u30A4\u30EB\u304C\u4F5C\u6210\u3055\u308C\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8 >> 37: >> resource.wxl-file=WiX\u30ED\u30FC\u30AB\u30EA\u30BC\u30FC\u30B7\u30E7\u30F3\u30FB\u30D5\u30A1\u30A4\u30EB >> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl > > Shouldn't this be `ja`? Changed back similar to with zh_CN - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Change localization codes. Add CNY back - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/a2528015..40291c61 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=116=02 - incr: https://webrevs.openjdk.org/?repo=jdk20=116=01-02 Stats: 4 lines in 4 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]
On Tue, 24 Jan 2023 22:05:55 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change German help of jar command > > src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties > line 174: > >> 172: MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON=\u53D6\u6D88\u8BA2\u9605() >> 173: >> MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON_TOOLTIP=\u505C\u6B62\u76D1\u542C\u901A\u77E5 >> 174: >> MANAGE_HOTSPOT_MBEANS_IN_COLON_=\u7BA1\u7406\u4EE5\u4E0B\u4F4D\u7F6E\u7684 >> HotSpot MBean: > > This looks like a prefix, so instead of removing the space, it should be > replaced with `\u0020` like other locations. > Also, it seems that other l10n files (de, ja) do not seem to have spaces in > the first place. OK, I can make the manual edit for this > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties > line 38: > >> 36: resource.post-msi-script=\u5728\u4E3A exe >> \u5B89\u88C5\u7A0B\u5E8F\u521B\u5EFA msi >> \u6587\u4EF6\u4E4B\u540E\u8981\u8FD0\u884C\u7684\u811A\u672C >> 37: resource.wxl-file=WiX \u672C\u5730\u5316\u6587\u4EF6 >> 38: resource.wxl-file-name=MsiInstallerStrings_en.wxl > > Shouldn't this be `zh_CN`? The translation tool seems to use the English source file's file name here, so it's replaced. I will handle these 3 occurrences now. I thought I handled all occurrences of this, but these 3 slipped in - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Change German help of jar command - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/4ced04fb..a2528015 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=116=01 - incr: https://webrevs.openjdk.org/?repo=jdk20=116=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote: > Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed @magicus @LanceAndersen @jonathan-gibbons @pavelrappo @dougxc @lahodaj Could you review the changes from this localization drop for the areas you're familiar with? - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote: > Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed @prrace @wangweij @naotoj @JoeWang-Java @plummercj @alexeysemenyukoracle Could you review the changes from this localization drop? - PR: https://git.openjdk.org/jdk20/pull/116
[jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update
Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files. All tests passed - Commit messages: - Remove currency symbol entries - Remove whitespace using tool - Remove double quotes generated by translation tool - Revert translation's removal of text - Update files for localization Changes: https://git.openjdk.org/jdk20/pull/116/files Webrev: https://webrevs.openjdk.org/?repo=jdk20=116=00 Issue: https://bugs.openjdk.org/browse/JDK-8300719 Stats: 1030 lines in 81 files changed: 218 ins; 115 del; 697 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
[jdk20] Integrated: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed This pull request has now been integrated. Changeset: c997b5bf Author: Damon Nguyen Committer: Naoto Sato URL: https://git.openjdk.org/jdk20/commit/c997b5bffd0ebbd6d68332572639c8cea05ccdb1 Stats: 1128 lines in 99 files changed: 783 ins; 198 del; 147 mod 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 Reviewed-by: achung, naoto, joehw, cjplummer, almatvee - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v8]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Swingset newline - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/fe18e4ea..f058a1de Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=35=07 - incr: https://webrevs.openjdk.org/?repo=jdk20=35=06-07 Stats: 3 lines in 3 files changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
On Fri, 16 Dec 2022 17:26:18 GMT, Phil Race wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert old translation. Fix lang codes > > src/demo/share/jfc/SwingSet2/resources/swingset_zh_CN.properties line 430: > >> 428: >> ProgressBarDemo.accessible_text_area_name=\u52A0\u8F7D\u7684\u6587\u672C\u6B63\u5728\u9010\u6E10\u589E\u591A >> 429: >> 430: ProgressBarDemo.accessible_text_area_description=\u8FD9\u4E2A JTextArea >> \u7531\u6765\u81EA\u7F13\u51B2\u533A\u7684\u6587\u672C\u9010\u4E2A\u5B57\u7B26\u5730\u586B\u5145\uFF0C\u540C\u65F6\u7A97\u53E3\u5E95\u90E8\u7684\u8FDB\u5EA6\u680F\u5C06\u663E\u793A\u52A0\u8F7D\u7684\u8FDB\u5EA6 > > I was asked to review SwingSet2 changes but this isn't code. > But apparently I am not the right person to review this since I cannot > understand the changes (not a DE, CN, or JA language expert) nor the reason > for them. If this is a change to a unicode comma (as implied in an off-review > message), I have no idea why .. it seems to be just asking for trouble. Thanks. I removed the changes to swingset's translation to avoid causing any issues. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Fri, 16 Dec 2022 15:02:42 GMT, Weijun Wang wrote: >> I didn't do the translation myself so I'm not sure the best approach to >> resolve this. I can manually replace these translations with one or the >> other. However, it's determine which parts of the code translate to >> 被视为存在安全风险" or "存在安全风险". I converted the unicode you highlighted above to >> characters, and I see where each one is located. If I just replace all >> instances of "存在安全风险" and insert "被视为存在安全风险" in unicode in its place, will >> it be OK? > > Yes, you can replace all "存在安全风险" (that is not after ""被视为") to "被视为存在安全风险". > > There are also similar usages in > `src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java`. Hi @wangweij , I believe I fixed the occurrences of "存在安全风险" and replaced them with "被视为存在安全风险". This translation drop does not update `src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java`. So, this may be a separate request. If that file is selected for extraction in the next drop in January, then it could also be fixed then. Could you re-review the current changes for this drop? - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v7]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert swingset. Consistency in CN - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/62a19a83..fe18e4ea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=35=06 - incr: https://webrevs.openjdk.org/?repo=jdk20=35=05-06 Stats: 7 lines in 4 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
On Fri, 16 Dec 2022 09:46:14 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/sun/launcher/resources/launcher_de.properties
>> line 34:
>>
>>> 32: # Translators please note do not translate the options themselves
>>> 33: java.launcher.opt.footer = \-cp >> und ZIP-/JAR-Dateien>\n-classpath >> und ZIP-/JAR-Dateien>\n--class-path >> und ZIP-/JAR-Dateien>\n Eine durch {0} getrennte Liste mit
>>> Verzeichnissen, JAR-Archiven\n und ZIP-Archiven, in denen
>>> nach Klassendateien gesucht wird.\n-p \n--module-path
>>> ...\n Eine durch {0} getrennte Liste mit
>>> Verzeichnissen, von denen jedes Verzeichnis\n ein
>>> Verzeichnis mit Modulen ist.\n--upgrade-module-path ...\n
>>> Eine durch {0} getrennte Liste mit Verzeichnissen, von denen
>>> jedes Verzeichnis\n ein Verzeichnis mit Modulen ist, die
>>> upgradef\u00E4hige\n Module im Laufzeitimage ersetzen\n
>>> --add-modules [,...]\n Root-Module,
>>> die zus\u00E4tzlich zum anf\u00E
4nglichen Modul aufgel\u00F6st werden sollen.\n
kann auch wie folgt lauten: ALL-DEFAULT, ALL-SYSTEM,\n
ALL-MODULE-PATH.\n--enable-native-access [,...]\n
Module, die eingeschr\u00E4nkte native Vorg\u00E4nge
ausf\u00FChren d\u00FCrfen.\n kann auch
ALL-UNNAMED lauten.\n--list-modules\n Listet beobachtbare
Module auf und beendet den Vorgang\n-d \n--describe-module
\n Beschreibt ein Modul und beendet den Vorgang\n
--dry-run Erstellt eine VM und l\u00E4dt die Hauptklasse, f\u00FChrt aber
nicht die Hauptmethode aus.\n Die Option "--dry-run" kann
n\u00FCtzlich sein, um die\n Befehlszeilenoptionen, wie die
Modulsystemkonfiguration, zu validieren.\n--validate-modules\n
Validiert alle Module und beendet den Vorgang\n Die Option
"--va
lidate-modules" kann n\u00FCtzlich sein, um\n Konflikte und
andere Fehler mit Modulen auf dem Modulpfad zu ermitteln.\n
-D=\n Legt eine Systemeigenschaft fest\n
-verbose:[class|module|gc|jni]\n Aktiviert die Verbose-Ausgabe
f\u00FCr das angegebene Subsystem\n-version Gibt die Produktversion an
den Fehlerstream aus und beendet den Vorgang\n--version Gibt die
Produktversion an den Outputstream aus und beendet den Vorgang\n
-showversion Gibt die Produktversion an den Fehlerstream aus und setzt den
Vorgang fort\n--show-version\n Gibt die Produktversion an
den Outputstream aus und setzt den Vorgang fort\n--show-module-resolution\n
Zeigt die Modulaufl\u00F6sungsausgabe beim Start an\n-? -h
-help\n Gibt diese Hilfemeldung an den Fehlerstream aus\n
--helpGibt diese Hilfemeldung an den Outputstream aus\n-X
Gibt Hil
fe zu zus\u00E4tzlichen Optionen an den Fehlerstream aus\n--help-extra
Gibt Hilfe zu zus\u00E4tzlichen Optionen an den Outputstream aus\n
-ea[:...|:]\n
-enableassertions[:...|:]\n Aktiviert
Assertions mit angegebener Granularit\u00E4t\n
-da[:...|:]\n
-disableassertions[:...|:]\n
Deaktiviert Assertions mit angegebener Granularit\u00E4t\n-esa |
-enablesystemassertions\n Aktiviert System-Assertions\n
-dsa | -disablesystemassertions\n Deaktiviert
System-Assertions\n-agentlib:[=]\n
L\u00E4dt die native Agent Library . Beispiel: -agentlib:jdwp\n
siehe auch -agentlib:jdwp=help\n
-agentpath:[=]\n L\u00E4dt die native Agent
Library mit dem vollst\u00E4ndigen Pfadnamen\n
-javaagent:[=]
\n \
>>> 34: L\u00E4dt den Java-Programmiersprachen-Agent, siehe
>>> java.lang.instrument\n-splash:\n Zeigt den
>>> Startbildschirm mit einem angegebenen Bild an\n Skalierte
>>> HiDPI-Bilder werden automatisch unterst\u00FCtzt und verwendet,\n
>>>falls verf\u00FCgbar. Der nicht skalierte Bilddateiname (Beispiel:
>>> image.ext)\n muss immer als Argument an die Option
>>> "-splash" \u00FCbergeben werden.\n Das am besten geeignete
>>> angegebene skalierte Bild wird\n automatisch
>>> ausgew\u00E4hlt.\n Weitere Informationen finden Sie in der
>>> Dokumentation zur SplashScreen-API\n@argument files\n
>>> Eine oder mehrere Argumentdateien mit Optionen\n-disable-@files\n
>>>Verhindert die weitere Erweiterung von Argumentdateien\n
>>> --enable-preview\n L\u00E4sst zu, das Klassen von
>>> Vorschaufeatures dieses Release abh\u00E4ngig sind\nUm ein Argument
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v6]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Fix missing dash - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/29880af9..62a19a83 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=35=05 - incr: https://webrevs.openjdk.org/?repo=jdk20=35=04-05 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes Right, Naoto's comment is correct. This time, the source extraction used some older files. To resolve this for this drop, I went through the files and reverted any changes that would be deemed as regressions or outdated files. Any other updates missed in this drop will be handled in the close upcoming drop in January. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes @dfuch Could I get a review from you as well? I believe this translation covers some of the files for your team. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:30:52 GMT, Weijun Wang wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert double quote as well
>
> src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
> line 75:
>
>> 73: "\u5DF2\u751F\u6210 {0} \u4F4D{1}\u5BC6\u94A5"},
>> //-genseckey
>> 74: {"key.algorithm.weak", "%1$s \u4F7F\u7528\u7684 %2$s
>> \u7B97\u6CD5\u88AB\u89C6\u4E3A\u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
>> 75: {"key.size.weak", "%1$s \u4F7F\u7528\u7684 %2$s
>> \u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
>
> The exact same "is considered a security risk" is sometimes translated into
> "被视为存在安全风险" and sometimes "存在安全风险". Either is OK for me but please be
> consistent. This is also shown in 5 other places in the same file.
I didn't do the translation myself so I'm not sure the best approach to resolve
this. I can manually replace these translations with one or the other. However,
it's determine which parts of the code translate to 被视为存在安全风险" or "存在安全风险". I
converted the unicode you highlighted above to characters, and I see where each
one is located. If I just replace all instances of "存在安全风险" and insert
"被视为存在安全风险" in unicode in its place, will it be OK?
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 23:12:58 GMT, Alexander Matveev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed trailing whitespace
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties
> line 51:
>
>> 49: error.msi-product-version-build-out-of-range=Build-Teil der Version muss
>> im Bereich [0, 65535] liegen
>> 50: error.msi-product-version-minor-out-of-range=Nebenversion muss im
>> Bereich [0, 255] liegen
>> 51: error.version-swap=Versionsinformationen f\u00FCr {0} konnten nicht
>> aktualisiert werden
>
> Why this was removed?
This line was added back to all locales as it was a regression from the
translation process.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Fri, 16 Dec 2022 00:17:15 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl >> line 2: >> >>> 1: >>> 2: >> xmlns="http://schemas.microsoft.com/wix/2006/localization; Codepage="1252"> >> >> Why "de-de" was changed to "de"? > > Also not sure why this was changed in the translation. I'm reverting all > instances of these language codes. This has been reverted as it was a regression for all locales of MsiInstallerStrings.wxl - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert old translation. Fix lang codes - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/57c42206..29880af9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=35=04 - incr: https://webrevs.openjdk.org/?repo=jdk20=35=03-04 Stats: 18 lines in 9 files changed: 6 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Fri, 16 Dec 2022 01:02:03 GMT, Damon Nguyen wrote: >> Looks like translation is done on files before JDK-8293462 was integrated >> (before Sep 26). See >> [commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0ff9745751d8375#diff-8bfeb61c827c2bc073c65cbf4137dbf8f7baa5f4f88e5d59785e985d9510577c) >> when I changed these two strings. For now it is better to revert them to >> original English version or figure out why translation is old. > > I'll revert it, investigate the cause for the extraction issue in this drop, > and try to have it translated by the next drop then. The translated text here has been reverted to its original English. The same has been done for its locales. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Fri, 16 Dec 2022 00:51:55 GMT, Alexander Matveev
wrote:
>> I'm not sure for the decisions of change in punctuation and for the missing
>> {1} as I didn't do the translation myself. Would this be better to be
>> reverted?
>
> Looks like translation is done on files before JDK-8293462 was integrated
> (before Sep 26). See
> [commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0ff9745751d8375#diff-8bfeb61c827c2bc073c65cbf4137dbf8f7baa5f4f88e5d59785e985d9510577c)
> when I changed these two strings. For now it is better to revert them to
> original English version or figure out why translation is old.
I'll revert it, investigate the cause for the extraction issue in this drop,
and try to have it translated by the next drop then.
>> Also not sure as it is what I received from the latest translation drop. If
>> this is incorrect, I can manually correct this here and for the other
>> locales for this file.
>
> Yes it needs to be correct. It was changed to _ja, etc with
> [commit](https://github.com/openjdk/jdk20/commit/543163a03b5f1af7a7e7af317a26eb8c5aa81c38#diff-afb8ea68d8b3e9be4bba1c417c82d2162eea9333a3157f05ef57c026af94eb3b).
> Which was done on Aug 10, 2022, so it seems message drop is based on old
> code.
This drop had some issues with the extraction which will be resolved. Some of
the changes are correct while some seem to be old. It seems these jpackage
files were are older? I can revert these changes for jpackage then.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Thu, 15 Dec 2022 23:13:22 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties > line 37: > >> 35: >> resource.post-app-image-script=\u30A2\u30D7\u30EA\u30B1\u30FC\u30B7\u30E7\u30F3\u30FB\u30A4\u30E1\u30FC\u30B8\u3092\u79FB\u5165\u3057\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8 >> 36: >> resource.post-msi-script=exe\u30A4\u30F3\u30B9\u30C8\u30FC\u30E9\u306Emsi\u30D5\u30A1\u30A4\u30EB\u304C\u4F5C\u6210\u3055\u308C\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8 >> 37: resource.wxl-file-name=MsiInstallerStrings_en.wxl > > Why this was changed? Also not sure as it is what I received from the latest translation drop. If this is incorrect, I can manually correct this here and for the other locales for this file. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Thu, 15 Dec 2022 22:57:31 GMT, Alexander Matveev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix https and changed URL back
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties
> line 82:
>
>> 80:
>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in
>> app-image-Verzeichnis ({0})
>> 82: error.invalid-app-image=Fehler: app-image-Verzeichnis ({0}) wurde von
>> einer anderen jpackage-Version generiert, oder .jpackage.xml ist nicht
>> wohlgeformt
>
> error.invalid-app-image looks like old translation and missing "{1}". Also,
> why () is used instead of ""?
I'm not sure for the decisions of change in punctuation and for the missing {1}
as I didn't do the translation myself. Would this be better to be reverted?
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl
> line 2:
>
>> 1:
>> 2: > xmlns="http://schemas.microsoft.com/wix/2006/localization; Codepage="1252">
>
> Why "de-de" was changed to "de"?
Also not sure why this was changed in the translation. I'm reverting all
instances of these language codes.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert double quote as well - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/09140a05..57c42206 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=35=03 - incr: https://webrevs.openjdk.org/?repo=jdk20=35=02-03 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 18:52:45 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed trailing whitespace > > src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps_de.properties > line 134: > >> 132: public.api.replacement.column.header=Vorgeschlagene Ersetzung >> 133: artifact.not.found=nicht gefunden >> 134: >> jdeps.wiki.url=https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool > > This seems to change backward. `openjdk.java.net` has changed to > `openjdk.org` Same issues are observed in other locales. This and the https->http differences seem to also be a part of the extraction issue. The resource generation files show "http" and "java.net", but I see differently on my local repo that I used for the extraction. I will run a new extraction job on a fresh repo/branch to see if this issue is reproducible and narrow down the source of the extraction issue. As discussed with Naoto, these are small edits, and they have been addressed in the latest PR. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Fix https and changed URL back - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/54d2ec5f..09140a05 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=35=02 - incr: https://webrevs.openjdk.org/?repo=jdk20=35=01-02 Stats: 15 lines in 15 files changed: 0 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 02:23:34 GMT, Damon Nguyen wrote: >> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line >> 26: >> >>> 24: # >>> 25: >>> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >>> JMOD-Dateien auflisten >> >> `jlink.description` was added to `jmod.properties` in May 2022 (Which was >> before Alisen's drop for JDK19). Shouldn't this have been translated during >> the 19 drop in August, as opposed to showing up now? > > I see the date of [that PR](https://github.com/openjdk/jdk/pull/8772) as > well. Looks like it was integrated on May 19. > > I'm contacting Kate Gavin to determine why some translations seem to > sometimes be delayed. As you mentioned in the other comment, there are a few > instances where text was added between the last drop & this drop, but weren't > translated. > > And as you showed here, this should have been translated in the last drop > rather than this one, but showed up here. I need a response from Kate to > clarify when these translations are generated. I conversed with Kate and the problem seems to come from the extraction process. We went through the source files that were sent for translation as a zip, and some changes would be missing. We confirmed that everything in this zip was translated, so the issue was in the extraction to create the source files to send for translation. For example, the plugin.properties missing text didn't show in the source.zip but showed on my forked repo used in the extraction. I re-ran the extraction script but still did not see the new text in the generated zip. Kate thinks a similar issue occurred in the previous drop and this jmod.properties change wasn't captured in the extraction process. So now it is captured in this drop and translated here. It could be syncing or branch issues, but while working with Kate, I learned to better see what files are pulled from the extraction script. So for future drops, I can better check to make sure changes I expect to be translated will appear. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 01:13:32 GMT, Justin Lu wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties >> line 188: >> >>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 >>> 187: >>> 188: main.plugin.category=\u7C7B\u522B >> >> As Naoto pointed out, it looks like a trailing space was added by accident. >> This is also done in the ja version but for a different value. And no space >> was added for any value for the de version. It looks like the translation >> drop that Damon is receiving contains random changes. > > Additionally, there were changes made to plugins.properties in October that > were not translated in the translation drop In our discussion, Kate mentioned that some languages are double byte, so this extra space may be correct but she hasn't looked in detail yet. I looked through all of the changes and these two instances of trailing whitespaces were the only two. I removed the extra spaces to reduce the changes as it seems useless due to the previous version not having the whitespace. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Removed trailing whitespace - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/39511b7a..54d2ec5f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20=35=01 - incr: https://webrevs.openjdk.org/?repo=jdk20=35=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
On Thu, 15 Dec 2022 01:04:12 GMT, Justin Lu wrote: >> Open l10n drop >> All tests passed > > src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line > 26: > >> 24: # >> 25: >> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >> JMOD-Dateien auflisten > > `jlink.description` was added to `jmod.properties` in May 2022 (Which was > before Alisen's drop for JDK19). Shouldn't this have been translated during > the 19 drop in August, as opposed to showing up now? I see the date of [that PR](https://github.com/openjdk/jdk/pull/8772) as well. Looks like it was integrated on May 19. I'm contacting Kate Gavin to determine why some translations seem to sometimes be delayed. As you mentioned in the other comment, there are a few instances where text was added between the last drop & this drop, but weren't translated. And as you showed here, this should have been translated in the last drop rather than this one, but showed up here. I need a response from Kate to clarify when these translations are generated. - PR: https://git.openjdk.org/jdk20/pull/35
[jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10
Open l10n drop All tests passed - Commit messages: - open l10n drop Changes: https://git.openjdk.org/jdk20/pull/35/files Webrev: https://webrevs.openjdk.org/?repo=jdk20=35=00 Issue: https://bugs.openjdk.org/browse/JDK-8298133 Stats: 1177 lines in 110 files changed: 783 ins; 207 del; 187 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
