Re: problem with type validation

[Craig R. McClanahan]

On Wed, 26 Feb 2003 [EMAIL PROTECTED] wrote:

> Date: Wed, 26 Feb 2003 17:54:07 +1100
> From: [EMAIL PROTECTED]
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: problem with type validation
>
> Hello,
>
> It seems to us that there is a serious flaw in the struts validation - in
> the RequestUtil class, the BeanUtils.populate method is called. In our
> testing, this allows an erroneous value to be replaced with a default value
> - for example a form class which will set a Short, and the form value
> entered is text, this will result in a value of 0. This all happens when
> the form bean is populated, before the server side validate() is called, or
> anything else can be intercepted. No exception occurs, so no errors can be
> generated. I was wondering if there is any idea about using something other
> than populate() - or making sure that the BeanUtils Converters do not use
> the constructors which make them enter default values
>
> has anyone else had this problem, it seems to mean struts is only good for
> String inputs, otherwise any type conversion is not assured? Am I missing
> something, is there a parameter somewhere to tell struts to do typesafe
> conversions?
>

As a general rule, if you are using non-String fields in your form bean,
you are making a *huge* mistake.

Form bean fields that, when you display them on the page, are rendered as
text input fields should *always* be stored (in the form bean) as a
String.  When you get to your Action, after validations have been
completed (so you know that the String->Numeric conversion will succeed),
then you can use BeanUtils.copyProperties() to copy the properties from
the form bean to some appropriate value object, with automatic conversion.

As an extra added bonus, a user who types "1a3" instead of "123" into a
text field will get the behavior they expect from any self-respecting GUI
app -- the field will be redisplayed with exactly what they typed, so that
they can fix it.  Using a non-String field in your form bean makes that
basically impossible.

Form beans are part of the view tier in an MVC architecture, not part of
the model tier.  Trying to pretend otherwise just distorts the overall
design and causes you nothing but grief.

> Regards,
> Simon

Craig McClanahan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17418] New: - taglib/html/ErrorsTag

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17418

taglib/html/ErrorsTag

   Summary: taglib/html/ErrorsTag
   Product: Struts
   Version: 1.1 RC1
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hello

I think I find out bug... not e feature.
All tags (at least which I know) from struts are started and finished whithout
any line ends or etc.
ONLY html:error tag is executed in a such a way:
error.header + EOL + error + EOL + error.footer + EOL
Imagine I'm using javaScript and I want, that one variable will have value,
which comes from html:error tage.
var error = "
Mr. Peksys you'v got an error
";
won't work.

In my opinion EOL(to show them or not) must be configurable. From as far as I
know xml - it wouldn't be so hard to one attribute for a such a thing. And after
looking at your code - I think it won't be also to change it

P.S. Writing here because I notice, that you will releace 1.1 version. I checked
code on 1.1 candidat, but there was the same bug/feature. So I hope that with
next releace I dont have to change ErrorsTag class :

Kind regards,
Darius

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17419] New: - taglib/html/ErrorsTag

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17419

taglib/html/ErrorsTag

   Summary: taglib/html/ErrorsTag
   Product: Struts
   Version: 1.1 RC1
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hello

I think I find out bug... not e feature.
All tags (at least which I know) from struts are started and finished whithout
any line ends or etc.
ONLY html:error tag is executed in a such a way:
error.header + EOL + error + EOL + error.footer + EOL
Imagine I'm using javaScript and I want, that one variable will have value,
which comes from html:error tage.
var error = "
Mr. Peksys you'v got an error
";
won't work.

In my opinion EOL(to show them or not) must be configurable. From as far as I
know xml - it wouldn't be so hard to one attribute for a such a thing. And after
looking at your code - I think it won't be also to change it

P.S. Writing here because I notice, that you will releace 1.1 version. I checked
code on 1.1 candidat, but there was the same bug/feature. So I hope that with
next releace I dont have to change ErrorsTag class :

Kind regards,
Darius

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Q] FORM BEAN SCOPE

[Chetan Sahasrabudhe]

All you ppl who have developed struts, can you please help me in this 
problem.
I have asked this question on struts mailing list, but no one is giving 
me
answer to this.
 
I have session scope in both action mappingsI have attached my 
struts-config along with this mail.btw in my jsp i have form bean 
sayingJSP 1JSP 
2now, when 
I call jsp1 the bean is getting createdbut when I move to jsp 2 , again new 
bean is created. I know this coz I have written default constructor in
my FormBean class and printing a message in it by 
System.out.println()And thatz the problem 
area.ThanksChetan
RegardsChetan___|  
| The trouble with being punctual 
|  is that nobody's there to appreciate 
it.| | 
|___
 
<>

http://jakarta.apache.org/struts/dtds/struts-config_1_1.dtd";>







  

  
  

















  


  
  





  


  
  





  







  


  

  



  


  

  

  


  
  

  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [Q] FORM BEAN SCOPE

[James Mitchell]

I know its frustrating, but let's keep this 
on struts-users side where it belongs.
 
 
--James MitchellSoftware Engineer/Struts Evangelist

  
  -Original Message-From: Chetan Sahasrabudhe 
  [mailto:[EMAIL PROTECTED] Sent: Wednesday, February 26, 
  2003 5:13 AMTo: Struts Developers ListSubject: [Q] FORM 
  BEAN SCOPE
  All you ppl who have developed struts, can you please help me in this 
  problem.
  I have asked this question on struts mailing list, but no one is giving 
  me
  answer to this.
   
  I have session scope in both action mappingsI have attached my 
  struts-config along with this mail.btw in my jsp i have form bean 
  sayingJSP 1JSP 
  2now, 
  when I call jsp1 the bean is getting createdbut when I move to jsp 2 , 
  again new bean is created. I know this coz I have written default constructor 
  in
  my FormBean class and printing a message in it by 
  System.out.println()And thatz the problem 
  area.ThanksChetan
  RegardsChetan___|  
  | The trouble with being punctual 
  |  is that nobody's there to appreciate 
  it.| | 
  |___
   

DO NOT REPLY [Bug 17429] New: - getInputForward not working

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17429

getInputForward not working

   Summary: getInputForward not working
   Product: Struts
   Version: 1.1 RC1
  Platform: PC
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Standard Actions
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Sorry if I'm doing the wrong thing - but I've had problems with the new 
Struts1.1 RC1. When the ActionForm returns an error the input page is not 
returned. Also in the Action.execute(), I try to use mapping.getInputForward() 
a null is returned. If however I use new ActionForward(mapping.getInput()) 
there is no problem.

I did see a problem like this show up on a message board which said that it was 
now fixed http://www.mail-archive.com/struts-
[EMAIL PROTECTED]/msg12073.html

but in the latest source version it doesn't appear so.

Can you help

Cheers
David

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Q] FORM BEAN SCOPE

[Ted Husted]

I don't see an obvious error in your configuration. If the Release 
Candidate is ignoring scope, then this would be a problem, and you 
should file a bugzilla ticket. Ideally, you could include a Struts TestCase

http://strutstestcase.sourceforge.net/

demonstrating the problem.

There is another ticket in there regarding ActionForm lifecycle,

http://issues.apache.org/bugzilla/show_bug.cgi?id=17273

but that seems unrelated.

-Ted.

Chetan Sahasrabudhe wrote:
All you ppl who have developed struts, can you please help me in this 
problem.
I have asked this question on struts mailing list, but no one is giving me
answer to this.
 
I have session scope in both action mappings
I have attached my struts-config along with this mail.

btw in my jsp i have form bean saying

JSP 1

JSP 2

now, when I call jsp1 the bean is getting created
but when I move to jsp 2 , again new bean is created. I know this coz I 
have written default constructor in
my FormBean class and printing a message in it by System.out.println()

And thatz the problem area.

Thanks
Chetan
Regards
Chetan
___
| 
| The trouble with being punctual
|  is that nobody's there to appreciate it.
|
|
|___

 





http://jakarta.apache.org/struts/dtds/struts-config_1_1.dtd";>



  

  
  















  

  
  





  
  
  




   type="wigadmin.struts.action.OMInterfaceInfoAction"
   name="wigadminwizardform"
   input="ominterfaceinfo"
   validate="true">
  




   type="wigadmin.struts.action.TranslatorAction"
   name="wigadminwizardform"
   input="translator"
   validate="true">



  

  

  



  
  

  

  

  
  

  




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


--
Ted Husted,
Struts in Action 
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [Q] FORM BEAN SCOPE

[James Mitchell]

He resolved this on the users list.

It was his code removing the bean from session.



--
James Mitchell
Software Engineer/Struts Evangelist




> -Original Message-
> From: Ted Husted [mailto:[EMAIL PROTECTED] 
> Sent: Wednesday, February 26, 2003 8:12 AM
> To: Struts Developers List
> Subject: Re: [Q] FORM BEAN SCOPE
> 
> 
> I don't see an obvious error in your configuration. If the Release 
> Candidate is ignoring scope, then this would be a problem, and you 
> should file a bugzilla ticket. Ideally, you could include a 
> Struts TestCase
> 
> http://strutstestcase.sourceforge.net/
> 
> demonstrating the problem.
> 
> There is another ticket in there regarding ActionForm lifecycle,
> 
> http://issues.apache.org/bugzilla/show_bug.cgi?id=17273
> 
> but that seems unrelated.
> 
> -Ted.
> 
> Chetan Sahasrabudhe wrote:
> > All you ppl who have developed struts, can you please help 
> me in this 
> > problem.
> > I have asked this question on struts mailing list, but no 
> one is giving me
> > answer to this.
> >  
> > I have session scope in both action mappings
> > I have attached my struts-config along with this mail.
> > 
> > btw in my jsp i have form bean saying
> > 
> > JSP 1
> >  onsubmit="return
> > validateWIGAdminWizardForm(this);">
> > 
> > JSP 2
> > 
> > 
> > 
> > now, when I call jsp1 the bean is getting created
> > but when I move to jsp 2 , again new bean is created. I 
> know this coz I 
> > have written default constructor in
> > my FormBean class and printing a message in it by 
> System.out.println()
> > 
> > And thatz the problem area.
> > 
> > Thanks
> > Chetan
> > Regards
> > Chetan
> > ___
> > | 
> > | The trouble with being punctual
> > |  is that nobody's there to appreciate it.
> > |
> > |
> > |___
> > 
> >  
> > 
> > 
> > 
> --
> --
> > 
> > 
> > 
> >  >   "-//Apache Software Foundation//DTD Struts 
> Configuration 1.1//EN"
> >   
> "http://jakarta.apache.org/struts/dtds/struts-config_1_1.dtd";>
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> >   
> > 
> >   
> >   
> > 
> >  > 
> type="wigadmin.struts.forms.WIGAdminWizardForm">
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> >  type="java.util.Collection"/>
> > 
> > 
> > 
> >  type="java.lang.String"/>
> >  type="java.util.Collection"/>
> > 
> > 
> >   
> > 
> > 
> >   
> >   
> > 
> > 
> > 
> > 
> > 
> >   
> > 
> > 
> >   
> >   
> > 
> > 
> > 
> > 
> >  >type="wigadmin.struts.action.OMInterfaceInfoAction"
> >name="wigadminwizardform"
> >input="ominterfaceinfo"
> >validate="true">
> >   
> > 
> > 
> > 
> >  >type="wigadmin.struts.action.TranslatorAction"
> >name="wigadminwizardform"
> >input="translator"
> >validate="true">
> > 
> > 
> > 
> >   
> > 
> > 
> >   
> > 
> >   
> > 
> > 
> > 
> >   
> > 
> > 
> >   
> > 
> >parameter="wigadmin.struts.properties.ApplicationResources">
> > 
> >   
> > 
> > 
> >   
> >   
> >  >  value="/WEB-INF/validator-rules.xml,
> > /WEB-INF/validation.xml"/>
> >   
> > 
> > 
> > 
> > 
> > 
> --
> --
> > 
> > 
> -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> -- 
> Ted Husted,
> Struts in Action 
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: committers attention - just a few moments...

[Ted Husted]

Arron Bates wrote:
Too unstable for 1.1 so close to release, but too important to let it slip
for over a year for it to come out.
I agree that you should apply the patch if you are comfortable with it 
yourself, since working on Tomcat 4.1.18 is important to our community.

I also very sure that people who use the Nested taglib *do* consider it 
a favorite component, and that there will be *a lot* of traffic if it 
doesn't work properly =:>

Meanwhile, you're right in thinking that this is a case where it's 
better to float a proposal for patch first and commit it second.  On 
occaision, it's easier to ask for permission than forgiveness =:0)

But, I don't think it will be so long before Struts 1.2. In fact, as 
soon as 1.1 ships, I'd like to do just a few of the straggling things, 
like the resources migration, and get 1.2 out right away.

I'm also convinced that we need to give significant subsystems like 
Struts-EL, Nested, Struts-JSP (when it happens), Tiles, and the 
Validator, their own release cycles. So that Struts becomes more like 
the Commons and less like Turbine.

-T.

--
Ted Husted,
Struts in Action 
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17430] New: - bug in nested text

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17430

bug in nested text

   Summary: bug in nested text
   Product: Struts
   Version: 1.1 Beta 3
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hello,
we have got a problem with struts 1.1b3/nested taglibs.

The following code sample works :










This one as well :












So we don't understand why the following one doesn't :









We get this error message : Cannot find bean org.apache.struts.taglib.html.BEAN 
in any scope 

We guess it is because the method release() in TextTag set the name attribute 
to Constants.BEAN_KEY.
It should probably be set to null.

Can you help us, please ?

Thanks

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Design clarification for locale handling

[Kris Schneider]

As a reference, this is a follow-on to bug 17371
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17371). While I understand
David's rationale behind closing the bug, I really think the design is broken
(and apparently has been since 1.0). So, instead of just reopening the bug, I
thought it would be best to get some feedback from the development community.

With regard to locale, it seems like HtmlTag's responsibility should end at
rendering the  tag's "lang" attribute. As it currently stands, it will
also create a session and store a locale under Globals.LOCALE_KEY if its
"locale" property is set to "true". Which means it's perfeclty legal to have
configured , and then a JSP with <%@ page
session="false" %> and  and end up with having a
session created and a locale stored in it.

RequestProcessor.processLocale seems like the appropriate place to handle the
session creation and locale storage. Any other entity that needs a handle to the
locale can just call RequestUtils.retrieveUserLocale.

Are there other places in the framework besides RequestProcessor.processLocale
and HtmlTag.getCurrentLocale that also store the locale in the session?

Would appreciate any feedback you can provide. Thanks.

-- 
Kris Schneider 
D.O.Tech   

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Design clarification for locale handling

[David Graham]

I agree with you that the html tag should not be performing the logic it 
does now; however, we can't change behavior that people may be relying on.  
Keep in mind that your app is a special case where you're not using 
sessions.  If many other apps weren't using sessions we would have had many 
more bug reports before now.  So, you can subclass the html tag to change 
its behavior or simply not use it at all and render  yourself.

I'll open an enhancement request against 2.0 so we can consider this issue 
when backwards compatibility doesn't matter as much.

David

As a reference, this is a follow-on to bug 17371
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17371). While I 
understand
David's rationale behind closing the bug, I really think the design is 
broken
(and apparently has been since 1.0). So, instead of just reopening the bug, 
I
thought it would be best to get some feedback from the development 
community.

With regard to locale, it seems like HtmlTag's responsibility should end at
rendering the  tag's "lang" attribute. As it currently stands, it 
will
also create a session and store a locale under Globals.LOCALE_KEY if its
"locale" property is set to "true". Which means it's perfeclty legal to 
have
configured , and then a JSP with <%@ page
session="false" %> and  and end up with having a
session created and a locale stored in it.

RequestProcessor.processLocale seems like the appropriate place to handle 
the
session creation and locale storage. Any other entity that needs a handle 
to the
locale can just call RequestUtils.retrieveUserLocale.

Are there other places in the framework besides 
RequestProcessor.processLocale
and HtmlTag.getCurrentLocale that also store the locale in the session?

Would appreciate any feedback you can provide. Thanks.

--
Kris Schneider 
D.O.Tech   
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
Add photos to your e-mail with MSN 8. Get 2 months FREE*.  
http://join.msn.com/?page=features/featuredemail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17434] New: - tag should not create sessions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17434

 tag should not create sessions

   Summary:  tag should not create sessions
   Product: Struts
   Version: 1.1 RC1
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


Using the locale attribute on the html tag causes a session to be created and a 
locale object stored there.  The tag probably shouldn't be performing this logic 
as it has nothing to do with the view layer.  The tag's responsibility is to 
render the  element with an appropriate lang attribute.  We should 
consider changing this in a 2.0 timeframe.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17434] - tag should not create sessions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17434

 tag should not create sessions

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Target Milestone|--- |2.0 Family

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17430] - bug in nested text

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17430

bug in nested text





--- Additional Comments From [EMAIL PROTECTED]  2003-02-26 14:46 ---
I believe this error has been fixed but not committed to the 1.1 codebase yet.  
I think we can expect many bug reports like this if we don't commit the nested 
tag fix for 1.1.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17418] - should not render newlines

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17418

 should not render newlines

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Minor   |Enhancement
Summary|taglib/html/ErrorsTag   | should not
   ||render newlines
   Target Milestone|--- |1.2 Family



--- Additional Comments From [EMAIL PROTECTED]  2003-02-26 14:58 ---
There's no technical reason that the tag should render newlines but this is not 
a bug.  We'll consider this enhancement for 1.2.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Design clarification for locale handling

[Kris Schneider]

As you say, most apps are probably using sessions. In fact, unless an app is
explicitly configured with , Struts will always
create a session on its behalf. So my guess would be that the apps that use
 are just doing a redundant storage of the locale. In
other words, RequestProcessor.processLocale has already placed the locale in the
session, HtmlTag.getCurrentLocale retrieves it and then stores it again. I'm not
sure backwards compatibility would really be impacted.

Quoting David Graham <[EMAIL PROTECTED]>:

> I agree with you that the html tag should not be performing the logic it 
> does now; however, we can't change behavior that people may be relying on. 
> 
> Keep in mind that your app is a special case where you're not using 
> sessions.  If many other apps weren't using sessions we would have had many
> 
> more bug reports before now.  So, you can subclass the html tag to change 
> its behavior or simply not use it at all and render  yourself.
> 
> I'll open an enhancement request against 2.0 so we can consider this issue 
> when backwards compatibility doesn't matter as much.
> 
> David
> 
> >
> >As a reference, this is a follow-on to bug 17371
> >(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17371). While I 
> >understand
> >David's rationale behind closing the bug, I really think the design is 
> >broken
> >(and apparently has been since 1.0). So, instead of just reopening the bug,
> 
> >I
> >thought it would be best to get some feedback from the development 
> >community.
> >
> >With regard to locale, it seems like HtmlTag's responsibility should end
> at
> >rendering the  tag's "lang" attribute. As it currently stands, it 
> >will
> >also create a session and store a locale under Globals.LOCALE_KEY if its
> >"locale" property is set to "true". Which means it's perfeclty legal to 
> >have
> >configured , and then a JSP with <%@ page
> >session="false" %> and  and end up with having a
> >session created and a locale stored in it.
> >
> >RequestProcessor.processLocale seems like the appropriate place to handle 
> >the
> >session creation and locale storage. Any other entity that needs a handle 
> >to the
> >locale can just call RequestUtils.retrieveUserLocale.
> >
> >Are there other places in the framework besides 
> >RequestProcessor.processLocale
> >and HtmlTag.getCurrentLocale that also store the locale in the session?
> >
> >Would appreciate any feedback you can provide. Thanks.
> >
> >--
> >Kris Schneider 
> >D.O.Tech   
> >
> >-
> >To unsubscribe, e-mail: [EMAIL PROTECTED]
> >For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> _
> Add photos to your e-mail with MSN 8. Get 2 months FREE*.  
> http://join.msn.com/?page=features/featuredemail
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


-- 
Kris Schneider 
D.O.Tech   

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Design clarification for locale handling

[David Graham]

I'm not sure backwards compatibility would really be impacted.
Unless you can show that backwards compatibility *definitely* won't be 
impacted, we can't change the behavior.  Subclassing the tag for your 
specific use is what open source is all about.

David

_
Help STOP SPAM with the new MSN 8 and get 2 months FREE*  
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Problem with 2/26 nightly build?

[Wendy Smoak]

I wanted to try out David Karr's fix for the  tag, but
there's something wrong with the 2/26 nightly build... the .zip file is only
466k.

-- 
Wendy Smoak
Applications Systems Analyst, Sr.
Arizona State University PA Information Resources Management

Re: problem with type validation

[Mohan Kishore]

Theres an 'major' open bug regarding failure of 'required' Integer fields. I
think this discussion kind of closes it... 

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17156

regards,
Mohan.

--- "Craig R. McClanahan" <[EMAIL PROTECTED]> wrote:
> 
> 
> On Wed, 26 Feb 2003 [EMAIL PROTECTED] wrote:
> 
> > Date: Wed, 26 Feb 2003 17:54:07 +1100
> > From: [EMAIL PROTECTED]
> > Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> > To: [EMAIL PROTECTED]
> > Subject: problem with type validation
> >
> > Hello,
> >
> > It seems to us that there is a serious flaw in the struts validation - in
> > the RequestUtil class, the BeanUtils.populate method is called. In our
> > testing, this allows an erroneous value to be replaced with a default value
> > - for example a form class which will set a Short, and the form value
> > entered is text, this will result in a value of 0. This all happens when
> > the form bean is populated, before the server side validate() is called, or
> > anything else can be intercepted. No exception occurs, so no errors can be
> > generated. I was wondering if there is any idea about using something other
> > than populate() - or making sure that the BeanUtils Converters do not use
> > the constructors which make them enter default values
> >
> > has anyone else had this problem, it seems to mean struts is only good for
> > String inputs, otherwise any type conversion is not assured? Am I missing
> > something, is there a parameter somewhere to tell struts to do typesafe
> > conversions?
> >
> 
> As a general rule, if you are using non-String fields in your form bean,
> you are making a *huge* mistake.
> 
> Form bean fields that, when you display them on the page, are rendered as
> text input fields should *always* be stored (in the form bean) as a
> String.  When you get to your Action, after validations have been
> completed (so you know that the String->Numeric conversion will succeed),
> then you can use BeanUtils.copyProperties() to copy the properties from
> the form bean to some appropriate value object, with automatic conversion.
> 
> As an extra added bonus, a user who types "1a3" instead of "123" into a
> text field will get the behavior they expect from any self-respecting GUI
> app -- the field will be redisplayed with exactly what they typed, so that
> they can fix it.  Using a non-String field in your form bean makes that
> basically impossible.
> 
> Form beans are part of the view tier in an MVC architecture, not part of
> the model tier.  Trying to pretend otherwise just distorts the overall
> design and causes you nothing but grief.
> 
> > Regards,
> > Simon
> 
> Craig McClanahan
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


__
Do you Yahoo!?
Yahoo! Tax Center - forms, calculators, tips, more
http://taxes.yahoo.com/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Test suites fail on localized computer

[Cedric Dumoulin]

 Hi all,

 Today I have run the test suite test.tomcat.41, but it fail on my 
computer:

   [junit] junit.framework.AssertionFailedError: expected:<1,234> but 
was:<1Â 234>
   [junit] at 
org.apache.struts.taglib.bean.TestWriteTag.formatAndTest(TestWriteTag.java:122)
   [junit] at 
org.apache.struts.taglib.bean.TestWriteTag.endWriteTagNameFormat(TestWriteTag.java:153)

 Checking the code, it appear that we compare a localized string 
returned by the server with a static string not localized ;-). This 
should work well when the server is US_en, but doesn't work with FR_fr, 
and other locales.
Note that the shown returned string (<1Â 234>) is not necessarily the 
real returned string, because the text file used to catch the output 
doesn't support well localization.

 There is other comparisons of this kind in the TestWriteTag file, and 
maybe in other files. I have try to run ant with other locale 
parameters, with no success: Tomcat is always launched with the locale 
of my computer, which I can't change.
 As a result, I can't run the test suites. Is there someone who have a 
simple solution, or should we change the TestWriteTag file (how?).

   cedric



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Test suites fail on localized computer

[James Mitchell]

LOLnow this is interesting, supposing I had picked a different
localewho knows how long this might have gone undetected.  

I just changed my regional settings to France and my tests failed as
well.  I already see the problem and will commit the fix tonight.  I
forced the locale for the MessageTag tests, but forgot to do the same
for WriteTag.


--
James Mitchell
Software Engineer/Struts Evangelist




> -Original Message-
> From: Cedric Dumoulin [mailto:[EMAIL PROTECTED] 
> Sent: mercredi 26 février 2003 11:09
> To: Struts Developers List
> Subject: Test suites fail on localized computer
> 
> 
> 
>   Hi all,
> 
>   Today I have run the test suite test.tomcat.41, but it fail on my 
> computer:
> 
> [junit] junit.framework.AssertionFailedError: 
> expected:<1,234> but 
> was:<1Â 234>
> [junit] at 
> org.apache.struts.taglib.bean.TestWriteTag.formatAndTest(TestW
> riteTag.java:122)
> [junit] at 
> org.apache.struts.taglib.bean.TestWriteTag.endWriteTagNameForm
> at(TestWriteTag.java:153)
>  
>   Checking the code, it appear that we compare a localized string 
> returned by the server with a static string not localized ;-). This 
> should work well when the server is US_en, but doesn't work 
> with FR_fr, 
> and other locales.
> Note that the shown returned string (<1Â 234>) is not necessarily the 
> real returned string, because the text file used to catch the output 
> doesn't support well localization.
> 
>   There is other comparisons of this kind in the TestWriteTag 
> file, and 
> maybe in other files. I have try to run ant with other locale 
> parameters, with no success: Tomcat is always launched with 
> the locale 
> of my computer, which I can't change.
>   As a result, I can't run the test suites. Is there someone 
> who have a 
> simple solution, or should we change the TestWriteTag file (how?).
> 
> cedric
> 
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17442] New: - struts1.1RC: StringIndexOutOfBoundsException

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17442

struts1.1RC: StringIndexOutOfBoundsException

   Summary: struts1.1RC: StringIndexOutOfBoundsException
   Product: Struts
   Version: 1.1 RC1
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Example
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Trying to run struts 1.1 release candidate. Tried struts-example that comes 
along with. The weblogic server is not able to deploy struts-example.war file.

   
   (WebAppServletCo
ntext.java:815)
at weblogic.servlet.internal.HttpServer.loadWebApp(HttpServer.java:428)
at weblogic.j2ee.WebAppComponent.deploy(WebAppComponent.java:74)
at weblogic.j2ee.Application.deploy(Application.java:260)
at weblogic.j2ee.J2EEService.deployApplication(J2EEService.java:185)
at weblogic.management.mbeans.custom.Application.setLocalDeployed(Applic
ation.java:362)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Test suites fail on localized computer

[James Mitchell]

If you just want a quick fix.  Drop the attached files on top of the
current ones.  Those will be what I commit tonight.

/src/test/org/apache/struts/taglib/bean/TestWriteTag.java
/web/test/test/org/apache/struts/taglib/bean/TestWriteTag.jsp

--
James Mitchell
Software Engineer/Struts Evangelist




> -Original Message-
> From: James Mitchell [mailto:[EMAIL PROTECTED] 
> Sent: mercredi 26 février 2003 11:38
> To: 'Struts Developers List'
> Subject: RE: Test suites fail on localized computer
> 
> 
> LOLnow this is interesting, supposing I had picked a different
> localewho knows how long this might have gone undetected.  
> 
> I just changed my regional settings to France and my tests failed as
> well.  I already see the problem and will commit the fix tonight.  I
> forced the locale for the MessageTag tests, but forgot to do the same
> for WriteTag.
> 
> 
> --
> James Mitchell
> Software Engineer/Struts Evangelist
> 
> 
> 
> 
> > -Original Message-
> > From: Cedric Dumoulin [mailto:[EMAIL PROTECTED] 
> > Sent: mercredi 26 février 2003 11:09
> > To: Struts Developers List
> > Subject: Test suites fail on localized computer
> > 
> > 
> > 
> >   Hi all,
> > 
> >   Today I have run the test suite test.tomcat.41, but it fail on my 
> > computer:
> > 
> > [junit] junit.framework.AssertionFailedError: 
> > expected:<1,234> but 
> > was:<1Â 234>
> > [junit] at 
> > org.apache.struts.taglib.bean.TestWriteTag.formatAndTest(TestW
> > riteTag.java:122)
> > [junit] at 
> > org.apache.struts.taglib.bean.TestWriteTag.endWriteTagNameForm
> > at(TestWriteTag.java:153)
> >  
> >   Checking the code, it appear that we compare a localized string 
> > returned by the server with a static string not localized ;-). This 
> > should work well when the server is US_en, but doesn't work 
> > with FR_fr, 
> > and other locales.
> > Note that the shown returned string (<1Â 234>) is not 
> necessarily the 
> > real returned string, because the text file used to catch 
> the output 
> > doesn't support well localization.
> > 
> >   There is other comparisons of this kind in the TestWriteTag 
> > file, and 
> > maybe in other files. I have try to run ant with other locale 
> > parameters, with no success: Tomcat is always launched with 
> > the locale 
> > of my computer, which I can't change.
> >   As a result, I can't run the test suites. Is there someone 
> > who have a 
> > simple solution, or should we change the TestWriteTag file (how?).
> > 
> > cedric
> > 
> > 
> > 
> > 
> -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> > 
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


TestWriteTag.java
Description: java/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Design clarification for locale handling

[Craig R. McClanahan]

On Wed, 26 Feb 2003, Kris Schneider wrote:

> Date: Wed, 26 Feb 2003 08:45:48 -0500
> From: Kris Schneider <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: Struts Developers List <[EMAIL PROTECTED]>
> Subject: Design clarification for locale handling
>
> As a reference, this is a follow-on to bug 17371
> (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17371). While I understand
> David's rationale behind closing the bug, I really think the design is broken
> (and apparently has been since 1.0). So, instead of just reopening the bug, I
> thought it would be best to get some feedback from the development community.
>

The HTML tag does its own locale-setting (and therefore session creation)
because some people still set their apps up to all URLs directly to JSP
pages (bypassing the controller servlet, so that the locale setup it does
is also skipped).  Removing this would break the localization behavior of
any app that depends on it.

Craig

> With regard to locale, it seems like HtmlTag's responsibility should end at
> rendering the  tag's "lang" attribute. As it currently stands, it will
> also create a session and store a locale under Globals.LOCALE_KEY if its
> "locale" property is set to "true". Which means it's perfeclty legal to have
> configured , and then a JSP with <%@ page
> session="false" %> and  and end up with having a
> session created and a locale stored in it.
>
> RequestProcessor.processLocale seems like the appropriate place to handle the
> session creation and locale storage. Any other entity that needs a handle to the
> locale can just call RequestUtils.retrieveUserLocale.
>
> Are there other places in the framework besides RequestProcessor.processLocale
> and HtmlTag.getCurrentLocale that also store the locale in the session?
>
> Would appreciate any feedback you can provide. Thanks.
>
> --
> Kris Schneider 
> D.O.Tech   
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Dependent Packages in Struts 1.1

[Craig R. McClanahan]

Missed an important one, and it's a problem child as well.

commons-logging -- The current release is 1.0.2, but we are compile-time
dependent on a bugfix in the HEAD branch.  This will need a release as
well.

Craig



On Tue, 25 Feb 2003, Craig R. McClanahan wrote:

> Date: Tue, 25 Feb 2003 09:59:43 -0800 (PST)
> From: Craig R. McClanahan <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: Dependent Packages in Struts 1.1
>
> As the topic comes up regularly, it strikes me that we haven't had any
> formal discussions or decisions on what versions of our dependent packages
> to include in Struts 1.1 final.  Most of them are probably
> non-controversial, but there are a couple of interesting cases.  Let's
> talk about the whole list on this mail thread.
>
> Martin, could you make sure that the release notes include the final
> version list we come up with?  Thanks in advance.
>
> commons-beanutils -- Version 1.6.1 was just posted, and contains a
> critical bugfix for BeanUtils.setProperty().
>
> commons-collections -- The framework's dependency on this library is
> pretty lightweight -- I suggest we go with the latest public release (2.1)
>
> commons-dbcp -- There have been some bugfixes since the original 1.0
> release; let's work on getting an update release of this out the door.
>
> commons-digester -- A bugfix release (1.4.1) is just in the final stages
> of being released.  That's the one we want.
>
> commons-fileupload -- Martin just published a beta of this.  By our
> standard rules, we'll need a final release before we can really use it.
>
> commons-lang -- We inherit dependencies on this one -- the latest public
> release (1.0.1) seems fine.
>
> commons-pool -- Same situation as commons-dbcp.
>
> commons-resources -- Since we decided to defer our conversion, I suggest
> we omit this library from Struts 1.1 final.  That avoids the hassles
> related to the fact that resources is still in the sandbox.
>
> commons-validator -- As far as I can tell, the current public release
> (1.0.1) is fine.  Are there any bugfixes we need to pick up in a 1.0.2?
>
> jakarta-oro -- The latest public release (2.0.7) is stable and seems to
> fit the bill.
>
> Everything else comes from within our own workspace, and I'm assuming
> we're going to use essentially the current HEAD branch plus critical bug
> fixes, and continue our plan to package struts-el in the "contrib"
> directory as we do today.
>
> Craig
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: DO NOT REPLY [Bug 17442] New: - struts1.1RC: StringIndexOutOfBoundsException

[James Mitchell]

Why are you logging a bug/defect

Have you posted this to struts-user yet?



--
James Mitchell
Software Engineer/Struts Evangelist




> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
> Sent: mercredi 26 février 2003 12:18
> To: [EMAIL PROTECTED]
> Subject: DO NOT REPLY [Bug 17442] New: - struts1.1RC: 
> StringIndexOutOfBoundsException
> 
> 
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> .
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
> INSERTED IN THE BUG DATABASE.
> 
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17442
> 
> struts1.1RC: StringIndexOutOfBoundsException
> 
>Summary: struts1.1RC: StringIndexOutOfBoundsException
>Product: Struts
>Version: 1.1 RC1
>   Platform: Other
> OS/Version: Other
> Status: NEW
>   Severity: Normal
>   Priority: Other
>  Component: Example
> AssignedTo: [EMAIL PROTECTED]
> ReportedBy: [EMAIL PROTECTED]
> 
> 
> Trying to run struts 1.1 release candidate. Tried 
> struts-example that comes 
> along with. The weblogic server is not able to deploy 
> struts-example.war file.
> 
> application struts
> -example: Could not load struts-example>
>
>  tting attribute Deployed on MBean 
> mydomain:Location=myserver,Name=struts-example
> ,Type=ApplicationConfig to value true. Method: public void 
> weblogic.management.m
> beans.custom.Application.setDeployed(boolean) throws 
> weblogic.management.Deploym
> entException,weblogic.management.UndeploymentException
> java.lang.StringIndexOutOfBoundsException: String index out 
> of range: -1
> at java.lang.String.substring(String.java:1480)
> at 
> weblogic.servlet.internal.WebAppHelper.resolveManifestName(WebAppHelp
> er.java:469)
> at 
> weblogic.servlet.internal.WebAppHelper.extractClassFiles(WebAppHelper
> .java:177)
> at 
> weblogic.servlet.internal.WebAppServletContext.extractClassFiles(WebA
> ppServletContext.java:3405)
> at 
> weblogic.servlet.internal.WebAppServletContext.setDocroot(WebAppServl
> etContext.java:3376)
> at 
> weblogic.servlet.internal.WebAppServletContext.init(WebAppServletCont
> ext.java:862)
> at 
> weblogic.servlet.internal.WebAppServletContext.(WebAppServletCo
> ntext.java:815)
> at 
> weblogic.servlet.internal.HttpServer.loadWebApp(HttpServer.java:428)
> at 
> weblogic.j2ee.WebAppComponent.deploy(WebAppComponent.java:74)
> at weblogic.j2ee.Application.deploy(Application.java:260)
> at 
> weblogic.j2ee.J2EEService.deployApplication(J2EEService.java:185)
> at 
> weblogic.management.mbeans.custom.Application.setLocalDeployed(Applic
> ation.java:362)
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Design clarification for locale handling

[David Graham]

The HTML tag does its own locale-setting (and therefore session creation)
because some people still set their apps up to all URLs directly to JSP
pages (bypassing the controller servlet, so that the locale setup it does
is also skipped).  Removing this would break the localization behavior of
any app that depends on it.
Thanks for the explanation.  I think this is a good reason to remove the 
functionality in 2.0.  IMHO, we shouldn't encourage direct jsp access.


Craig
David

_
Help STOP SPAM with the new MSN 8 and get 2 months FREE*  
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Design clarification for locale handling

[Kris Schneider]

David's already asked me to put up or shut up ;-), but for the record...

Even if no requests ever get processed by ActionServlet, having HtmlTag just use
RequestUtils.retrieveUserLocale will still do the right thing (i.e. return a
locale based on the Accept-Language header, or the default locale for the
server). I don't see how that would break localization behavior.

Quoting "Craig R. McClanahan" <[EMAIL PROTECTED]>:

> On Wed, 26 Feb 2003, Kris Schneider wrote:
> 
> > Date: Wed, 26 Feb 2003 08:45:48 -0500
> > From: Kris Schneider <[EMAIL PROTECTED]>
> > Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> > To: Struts Developers List <[EMAIL PROTECTED]>
> > Subject: Design clarification for locale handling
> >
> > As a reference, this is a follow-on to bug 17371
> > (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17371). While I
> understand
> > David's rationale behind closing the bug, I really think the design is
> broken
> > (and apparently has been since 1.0). So, instead of just reopening the bug,
> I
> > thought it would be best to get some feedback from the development
> community.
> >
> 
> The HTML tag does its own locale-setting (and therefore session creation)
> because some people still set their apps up to all URLs directly to JSP
> pages (bypassing the controller servlet, so that the locale setup it does
> is also skipped).  Removing this would break the localization behavior of
> any app that depends on it.
> 
> Craig
> 
> > With regard to locale, it seems like HtmlTag's responsibility should end
> at
> > rendering the  tag's "lang" attribute. As it currently stands, it
> will
> > also create a session and store a locale under Globals.LOCALE_KEY if its
> > "locale" property is set to "true". Which means it's perfeclty legal to
> have
> > configured , and then a JSP with <%@ page
> > session="false" %> and  and end up with having a
> > session created and a locale stored in it.
> >
> > RequestProcessor.processLocale seems like the appropriate place to handle
> the
> > session creation and locale storage. Any other entity that needs a handle
> to the
> > locale can just call RequestUtils.retrieveUserLocale.
> >
> > Are there other places in the framework besides
> RequestProcessor.processLocale
> > and HtmlTag.getCurrentLocale that also store the locale in the session?
> >
> > Would appreciate any feedback you can provide. Thanks.
> >
> > --
> > Kris Schneider 
> > D.O.Tech   
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


-- 
Kris Schneider 
D.O.Tech   

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Design clarification for locale handling

[David Graham]

Even if no requests ever get processed by ActionServlet, having HtmlTag 
just use
RequestUtils.retrieveUserLocale will still do the right thing (i.e. return 
a
locale based on the Accept-Language header, or the default locale for the
server). I don't see how that would break localization behavior.
Because it also creates a session and stores the Locale in there.  Apps may 
be relying on that object to be in the session by using the html tag.

David

_
Protect your PC - get McAfee.com VirusScan Online  
http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Design clarification for locale handling

[Mitchell Morris]

That still leaves a (potential) bug, in that a page with '<%@ page
session="false"%>' and '' will create a session. It
seems to me that HTML should respect the page and/or servlet configuration
with respect to session creation, and that checking is currently not being
done. If RequestProcessor isn't being invoked and that's allowed, then
perhaps RequestProcessor is the wrong place for the
session-creating-and-locale-setting logic ... would RequestUtils be a better
home?

i'm-often-wrong-though-ly y'rs,
+Mitchell

[snip]
> The HTML tag does its own locale-setting (and therefore
> session creation)
> because some people still set their apps up to all URLs
> directly to JSP
> pages (bypassing the controller servlet, so that the locale
> setup it does
> is also skipped).  Removing this would break the localization
> behavior of
> any app that depends on it.
>
> Craig



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Problem with 2/26 nightly build?

[Craig R. McClanahan]

Ah, the perils of nightly builds against the HEAD of every package ... The
JAR filename for commons-lang's nightly builds just changed.  I just
refired off the job to build the 0226 nightly build.  It should be done in
about half an hour.

Craig

On Wed, 26 Feb 2003, Wendy Smoak wrote:

> Date: Wed, 26 Feb 2003 08:19:05 -0700
> From: Wendy Smoak <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: Problem with 2/26 nightly build?
>
>
> I wanted to try out David Karr's fix for the  tag, but
> there's something wrong with the 2/26 nightly build... the .zip file is only
> 466k.
>
> --
> Wendy Smoak
> Applications Systems Analyst, Sr.
> Arizona State University PA Information Resources Management
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Design clarification for locale handling

[Kris Schneider]

Which is a potential backwards compatibility issue, not an issue with HtmlTag
being able to grab a locale and render its "lang" attribute. That seems like a
fairly weird use-case though.

Quoting David Graham <[EMAIL PROTECTED]>:

> >Even if no requests ever get processed by ActionServlet, having HtmlTag 
> >just use
> >RequestUtils.retrieveUserLocale will still do the right thing (i.e. return
> 
> >a
> >locale based on the Accept-Language header, or the default locale for the
> >server). I don't see how that would break localization behavior.
> 
> Because it also creates a session and stores the Locale in there.  Apps may
> 
> be relying on that object to be in the session by using the html tag.
> 
> David
> 
> _
> Protect your PC - get McAfee.com VirusScan Online  
> http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


-- 
Kris Schneider 
D.O.Tech   

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17419] - taglib/html/ErrorsTag

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17419

taglib/html/ErrorsTag

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-02-26 18:33 ---


*** This bug has been marked as a duplicate of 17418 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17418] - should not render newlines

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17418

 should not render newlines





--- Additional Comments From [EMAIL PROTECTED]  2003-02-26 18:33 ---
*** Bug 17419 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Design clarification for locale handling

[David Graham]

That's not a bug, it's a usage limitation.  An app that does not use 
sessions is considered a special case so we're not bending over backwards to 
support it.  We realize the tag shouldn't be creating sessions but can't 
change it because of backward compatibility problems.

David



From: "Mitchell Morris" <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: "'Struts Developers List'" <[EMAIL PROTECTED]>
Subject: RE: Design clarification for locale handling
Date: Wed, 26 Feb 2003 13:16:23 -0500
That still leaves a (potential) bug, in that a page with '<%@ page
session="false"%>' and '' will create a session. 
It
seems to me that HTML should respect the page and/or servlet configuration
with respect to session creation, and that checking is currently not being
done. If RequestProcessor isn't being invoked and that's allowed, then
perhaps RequestProcessor is the wrong place for the
session-creating-and-locale-setting logic ... would RequestUtils be a 
better
home?

i'm-often-wrong-though-ly y'rs,
+Mitchell
[snip]
> The HTML tag does its own locale-setting (and therefore
> session creation)
> because some people still set their apps up to all URLs
> directly to JSP
> pages (bypassing the controller servlet, so that the locale
> setup it does
> is also skipped).  Removing this would break the localization
> behavior of
> any app that depends on it.
>
> Craig


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
Add photos to your e-mail with MSN 8. Get 2 months FREE*.  
http://join.msn.com/?page=features/featuredemail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] Relative action URL's for FormTag

[Eddie Bush]

Erik,

If you could put your patch into Bugzilla (file it against the bug 
report, please - create a bug report for issues that don't have one yet) 
we'd much appreciate it.  By just sending it to the list, you risk it 
being lost -- and very likely missed or forgotten.  If it's in Bugzilla, 
whichever one of us gets to tackle that bug will have your patch right 
there for consideration.  If possible, always submit output from 'cvs 
diff -u' (looks like that's probably what you did - thanks!) and ... I 
suppose that's it.

http://issues.apache.org/bugzilla

Thanks for the effort!

Erik Tennant wrote:

I needed (for reasons beyond my control) to have  create an action="" with a relative 
URL. Searching the mailing list, I ran across others who were seeking similar functionality. I 
wrote up a simple addition to FormTag.java that allows an optional isRelative attribute inside the 
form tag.

Image tags have something functionally equivalent, so I'm guessing it may be functionality you are 
interested in.

If you need something else from me, let me know.

Thanks,

Erik

--
Eddie Bush




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17449] New: - Allow relative URL in action attribute of tag

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17449

Allow relative URL in action attribute of  tag

   Summary: Allow relative URL in action attribute of  tag
   Product: Struts
   Version: 1.1 RC1
  Platform: Other
OS/Version: All
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I needed (for reasons beyond my control) to have  create an 
action="" with a relative 
URL. Searching the mailing list, I ran across others who were seeking similar 
functionality. I 
wrote up a simple addition to FormTag.java that allows an optional isRelative 
attribute inside the 
form tag.

Image tags have something functionally equivalent, so I'm guessing it may be 
functionality you are 
interested in.

If you need something else from me, let me know.

Thanks,

Erik

This diff is against 1.1rc1


--- FormTag.java.rc12003-02-25 15:56:32.0 -0600
+++ FormTag.java.rc1.new2003-02-25 15:56:32.0 -0600
@@ -214,6 +214,12 @@
  */
 protected String beanType = null;
 
+/**
+ * Whether or not the action="" should be a relative URL. Default is
+ * false, to maintain backwards compatibility.
+ */
+protected String isRelative = null;
+
 // - Properties
 
 /**
@@ -488,6 +494,23 @@
 
 }
 
+/**
+ * Is the action="" relative? a value of "true" (case insensitive) 
indicates it is
+ *
+ * @param value
+ */
+public void setIsRelative (String value) {
+
+this.isRelative = value;
+
+}
+
+public String getIsRelative () {
+
+return isRelative;
+
+}
+
 // - Public Methods
 
 /**
@@ -509,7 +532,11 @@
  results.append(" method=\"");
  results.append(method == null ? "post" : method);
  results.append("\" action=\"");
- results.append(response.encodeURL(RequestUtils.getActionMappingURL
(action, pageContext)));
+if ("true".equalsIgnoreCase(isRelative ) ) {
+results.append(response.encodeURL(action));
+} else {
+results.append(response.encodeURL(RequestUtils.getActionMappingURL
(action, 
pageContext)));
+} 
  results.append("\"");
  if (styleClass != null) {
  results.append(" class=\"");
@@ -696,6 +723,7 @@
 styleId = null;
 target = null;
 type = null;
+isRelative = null;
 
 }
 
--- struts-html.tld.rc12003-02-25 15:56:32.0 -0600
+++ struts-html.tld.rc1.new2003-02-25 15:56:32.0 -0600
@@ -618,6 +618,11 @@
 true
 
 
+isRelative
+false
+true
+
+
 enctype
 false
 true

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] Relative action URL's for FormTag

[Erik Tennant]

ok, I entered it in as bug 17449.

Unfortunately the firewall at work keeps me from accessing the cvs repository, which 
is why I did a 
diff from rc1 instead of from cvs.  Maybe there is a cvs client that can operate 
through a http 
proxy- I will have to go look into that. Although I assume since rc1 was just released 
that the cvs 
head version is the same as rc1 at this point?

Thanks,

Erik


> - Message from [EMAIL PROTECTED] -
> Date: Wed, 26 Feb 2003 14:01:11 -0600
> From: Eddie Bush <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
>  Subject: Re: [PATCH] Relative action URL's for FormTag
>   To: Struts Developers List <[EMAIL PROTECTED]>
> 
> Erik,
> 
> If you could put your patch into Bugzilla (file it against the bug
> report, please - create a bug report for issues that don't have one yet)
> we'd much appreciate it.  By just sending it to the list, you risk it
> being lost -- and very likely missed or forgotten.  If it's in Bugzilla,
> whichever one of us gets to tackle that bug will have your patch right
> there for consideration.  If possible, always submit output from 'cvs
> diff -u' (looks like that's probably what you did - thanks!) and ... I
> suppose that's it.
> 
> http://issues.apache.org/bugzilla
> 
> Thanks for the effort!

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Problem with 2/26 nightly build?

[Craig R. McClanahan]

On Wed, 26 Feb 2003, Craig R. McClanahan wrote:

> Date: Wed, 26 Feb 2003 10:21:07 -0800 (PST)
> From: Craig R. McClanahan <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: Struts Developers List <[EMAIL PROTECTED]>
> Subject: Re: Problem with 2/26 nightly build?
>
> Ah, the perils of nightly builds against the HEAD of every package ... The
> JAR filename for commons-lang's nightly builds just changed.  I just
> refired off the job to build the 0226 nightly build.  It should be done in
> about half an hour.
>

Uploading of the revised 0226 nightly build files is now complete.

> Craig

Craig

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Design clarification for locale handling

[Craig R. McClanahan]

On Wed, 26 Feb 2003, David Graham wrote:

> Date: Wed, 26 Feb 2003 11:36:24 -0700
> From: David Graham <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: RE: Design clarification for locale handling
>
> That's not a bug, it's a usage limitation.  An app that does not use
> sessions is considered a special case so we're not bending over backwards to
> support it.  We realize the tag shouldn't be creating sessions but can't
> change it because of backward compatibility problems.
>

I wouldn't characterize it as a usage limitation ... I'd characterize it
as a lack of sufficient documentation that saying:

  

causes a session to be created.  If you don't want the session, don't say
locale="true".

> David
>

Craig

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Q: Running unit tests for Validator used with Struts

[otisg]

Hello,

It is almost impossible to get anyone
attention on struts-user.
I'm using Struts and Validator with it.
I wrote a custom Validator and want to write
a unit test for it.
My Validator has a method like this:

public static boolean validateStartLetter(
Object bean,
ValidatorAction validatorAction,
Field field,
ActionErrors errors,
HttpServletRequest request
)
{
String value =
ValidatorUtil.getValueAsString(bean,
field.getProperty());
if
((GenericValidator.isBlankOrNull(value)) ||
!Character.isLetter(value.charAt(0)))
{
errors.add(field.getKey(),
Resources.getActionError(request,
validatorAction, field));
}

return errors.isEmpty();
}

I am running JUnit from Ant to run my unit
test class.
Apparently this doesn't work because the
instance of ActionErrors passed to this
method is null, causing a NPE.

I wanted to check the unit tests for
Validator in Struts (FieldChecks) to see how
you wrote your unit tests, so that this NPE
is avoided, but I could not find any unit
tests for it.
Are there really no unit tests there?

Regardless, how would you go about running
unit tests for a custom validator from
something like Ant?

It seems to me that doing that may be
impossible, because there is no Struts
running to instantiate ActionErrors, there
is no HttpServletRequest, and so on.

Is there a way to do this?

Thanks,
Otis



Get your own "800" number
Voicemail, fax, email, and a lot more
http://www.ureach.com/reg/tag

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17430] - bug in nested text

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17430

bug in nested text

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-02-26 22:37 ---
I can't see the difference between the first example that works, and the last
one that doesn't, but anyways...

The reason why the second one works is that the bean is specified in the root
tag (in this case the  tag), where as the iterate tag, even though
name is supplied is still looking for that root tag for the name and not finding it.

There's numerous mails and docco about this if you want to look into it, but in
the latest fix for the tags, I've enabled being able to specify a name attribute
and pick up on that appropriate bean. It means that the nested tags can work
exactly like the originals they extend, or if no name is supplied, it'll look
into the nested reference and do the nesting thing from there.

Potentially it could confuse, but for some, this is obviously the expected behavior.

I'm setting this bug to fixed, once the new fix is in there (next day or so),
test again and continue the bug tracking from there.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/bean TestWriteTag.jsp

[jmitchell]

jmitchell2003/02/26 16:02:05

  Modified:src/test/org/apache/struts/taglib/bean TestWriteTag.java
   web/test/test/org/apache/struts/taglib/bean TestWriteTag.jsp
  Log:
  Fix tests where users locale is "fr".
  
  Revision  ChangesPath
  1.2   +36 -38
jakarta-struts/src/test/org/apache/struts/taglib/bean/TestWriteTag.java
  
  Index: TestWriteTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestWriteTag.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestWriteTag.java 22 Feb 2003 02:48:09 -  1.1
  +++ TestWriteTag.java 27 Feb 2003 00:02:04 -  1.2
  @@ -122,124 +122,122 @@
assertEquals(compare, output);
}
   
  +private void runMyTest(String whichTest, String locale){
  + pageContext.setAttribute(Globals.LOCALE_KEY, new Locale(locale, locale), 
PageContext.SESSION_SCOPE);
  + request.setAttribute("runTest", whichTest);
  +try {
  + 
pageContext.forward("/test/org/apache/struts/taglib/bean/TestWriteTag.jsp");
  + }
  + catch (Exception e) {
  + e.printStackTrace();
  + fail("There is a problem that is preventing the tests to 
continue!");
  + }
  +}
  +
// Name
  -public void testWriteTagName() throws IOException, ServletException{
  - request.setAttribute("runTest", "testWriteTagName");
  +public void testWriteTagName(){

pageContext.setAttribute(REQUEST_KEY,TEST_STRING_VAL,PageContext.REQUEST_SCOPE);
  - 
pageContext.forward("/test/org/apache/struts/taglib/bean/TestWriteTag.jsp");
  + runMyTest("testWriteTagName", "");
}
public void endWriteTagName(WebResponse response){
formatAndTest(TEST_STRING_VAL, response.getText());
}

// Property
  -public void testWriteTagNameProperty() throws IOException, ServletException{
  +public void testWriteTagNameProperty() {
SimpleBeanForTesting sbft = new SimpleBeanForTesting(TEST_STRING_VAL);
  - request.setAttribute("runTest", "testWriteTagNameProperty");
pageContext.setAttribute(REQUEST_KEY, sbft,PageContext.REQUEST_SCOPE);
  - 
pageContext.forward("/test/org/apache/struts/taglib/bean/TestWriteTag.jsp");
  + runMyTest("testWriteTagNameProperty", "");
}
public void endWriteTagNameProperty(WebResponse response){
formatAndTest(TEST_STRING_VAL, response.getText());
}

// Name and Format
  -public void testWriteTagNameFormat() throws IOException, ServletException{
  - request.setAttribute("runTest", "testWriteTagNameFormat");
  +public void testWriteTagNameFormat(){

pageContext.setAttribute(REQUEST_KEY,TEST_INTEGER_VAL,PageContext.REQUEST_SCOPE);
  - 
pageContext.forward("/test/org/apache/struts/taglib/bean/TestWriteTag.jsp");
  + runMyTest("testWriteTagNameFormat", "");
}
public void endWriteTagNameFormat(WebResponse response){
formatAndTest("1,234" , response.getText());
}

// Name, Format, and FormatKey (default bundle)
  -public void testWriteTagNameFormatKeyDefaultBundle() throws IOException, 
ServletException{
  - request.setAttribute("runTest", 
"testWriteTagNameFormatKeyDefaultBundle");
  +public void testWriteTagNameFormatKeyDefaultBundle(){

pageContext.setAttribute(REQUEST_KEY,TEST_INTEGER_VAL,PageContext.REQUEST_SCOPE);
  - 
pageContext.forward("/test/org/apache/struts/taglib/bean/TestWriteTag.jsp");
  + runMyTest("testWriteTagNameFormatKeyDefaultBundle", "");
}
public void endWriteTagNameFormatKeyDefaultBundle(WebResponse response){
formatAndTest("$1,234" , response.getText());
}

// Name, Format, and FormatKey (alternate bundle)
  -public void testWriteTagNameFormatKeyAlternateBundle() throws IOException, 
ServletException{
  - request.setAttribute("runTest", 
"testWriteTagNameFormatKeyAlternateBundle");
  +public void testWriteTagNameFormatKeyAlternateBundle(){

pageContext.setAttribute(REQUEST_KEY,TEST_INTEGER_VAL,PageContext.REQUEST_SCOPE);
  - 
pageContext.forward("/test/org/apache/struts/taglib/bean/TestWriteTag.jsp");
  + runMyTest("testWriteTagNameFormatKeyAlternateBundle", "");
}
public void endWriteTagNameFormatKeyAlternateBundle(WebResponse response){
formatAndTest("$1,234" , response.getText());
}

// Name, Format, and FormatKey (default bundle) (Double)
  -public void testWriteTagNameFormatKeyDefaultBundleDouble() throws IO

cvs commit: jakarta-struts build-tests.xml

[jmitchell]

jmitchell2003/02/26 16:03:22

  Modified:.build-tests.xml
  Log:
  Adding tests for html tags
  
  Revision  ChangesPath
  1.17  +7 -0  jakarta-struts/build-tests.xml
  
  Index: build-tests.xml
  ===
  RCS file: /home/cvs/jakarta-struts/build-tests.xml,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- build-tests.xml   22 Feb 2003 03:14:46 -  1.16
  +++ build-tests.xml   27 Feb 2003 00:03:21 -  1.17
  @@ -261,6 +261,13 @@
 
   
   
  +
  +
  +  
  +
  +  
  +
  +
   
   
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/src/test/org/apache/struts/taglib SimpleBeanForTesting.java

[jmitchell]

jmitchell2003/02/26 16:04:07

  Modified:src/test/org/apache/struts/taglib SimpleBeanForTesting.java
  Log:
  Adding a few more features.
  
  Revision  ChangesPath
  1.2   +11 -0 
jakarta-struts/src/test/org/apache/struts/taglib/SimpleBeanForTesting.java
  
  Index: SimpleBeanForTesting.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/SimpleBeanForTesting.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- SimpleBeanForTesting.java 22 Feb 2003 02:52:27 -  1.1
  +++ SimpleBeanForTesting.java 27 Feb 2003 00:04:07 -  1.2
  @@ -92,6 +92,17 @@
private Enumeration enumeration;
private Collection collection;
   
  + //Copied right from the FAQ
  + private String strAry[] =
  + { "String 0", "String 1", "String 2", "String 3", "String 4" };
  +
  +public String getStringIndexed(int index) { 
  + return (strAry[index]); 
  +}
  +public void setStringIndexed(int index, String value){ 
  + strAry[index] = value; 
  +}
  +
/**
 * Returns the lst.
 * @return List
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts build.xml

[jmitchell]

jmitchell2003/02/26 16:26:43

  Modified:.build.xml
  Log:
  I keep this below my projects.
  I'm tired of changing this everytime I refresh.hope noone cares.
  
  Revision  ChangesPath
  1.100 +1 -0  jakarta-struts/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-struts/build.xml,v
  retrieving revision 1.99
  retrieving revision 1.100
  diff -u -r1.99 -r1.100
  --- build.xml 19 Feb 2003 06:01:45 -  1.99
  +++ build.xml 27 Feb 2003 00:26:42 -  1.100
  @@ -95,6 +95,7 @@
   
   
   
  +
   
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] Relative action URL's for FormTag

[Eddie Bush]

Erik Tennant wrote:

ok, I entered it in as bug 17449.

Good job - thanks!

Unfortunately the firewall at work keeps me from accessing the cvs repository, which is why I did a 
diff from rc1 instead of from cvs.  Maybe there is a cvs client that can operate through a http 
proxy- I will have to go look into that. Although I assume since rc1 was just released that the cvs 
head version is the same as rc1 at this point?

Hrm ... yeah should be pretty close.  If not then CVS generally does a 
pretty good job of figuring out what needs done.  If it turns out to be 
a problem then whoever applies your patch will just "eye-ball" the patch 
and figure out what needs done.  That doesn't generally happen though. 
I wouldn't worry about it as close as we are to RC1.  Of course, if you 
find yourself able to do the diff against RC1 later on you can always 
post and update and just make note of what you're doing ... or leave it 
for the commiter handling the bug to figure out ;-)  Generally, most of 
us appreciate someone pointing us in the right direction though :-) 
Just put something like "Updated patch - please use this instead of 
attachment #".  That should suffice.

Thanks,

Erik

No, thank *you* ;-)

--
Eddie Bush




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/html - New directory

[jmitchell]

jmitchell2003/02/26 17:53:50

  jakarta-struts/src/test/org/apache/struts/taglib/html - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/html TestBaseTag.java TestButtonTag.java

[jmitchell]

jmitchell2003/02/26 17:59:17

  Added:   src/test/org/apache/struts/taglib/html TestBaseTag.java
TestButtonTag.java
  Log:
  Initial checkin.  Many more will follow.
  
  Revision  ChangesPath
  1.1  
jakarta-struts/src/test/org/apache/struts/taglib/html/TestBaseTag.java
  
  Index: TestBaseTag.java
  ===
  /*
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999-2001 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Struts", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   */
  package org.apache.struts.taglib.html;
  
  import java.io.IOException;
  import java.util.ArrayList;
  import java.util.HashMap;
  
  import javax.servlet.ServletException;
  import javax.servlet.jsp.JspException;
  import javax.servlet.jsp.PageContext;
  import junit.framework.Test;
  import junit.framework.TestSuite;
  import org.apache.cactus.JspTestCase;
  import org.apache.cactus.WebRequest;
  import org.apache.cactus.WebResponse;
  import org.apache.struts.util.LabelValueBean;
  
  /**
   * Suite of unit tests for the
   * org.apache.struts.taglib.bean.BaseTag class.
   *
   * @author James Mitchell
   */
  public class TestBaseTag extends JspTestCase {
  
  /**
   * Defines the testcase name for JUnit.
   *
   * @param theName the testcase's name.
   */
  public TestBaseTag(String theName) {
  super(theName);
  }
  
  /**
   * Start the tests.
   *
   * @param theArgs the arguments. Not used
   */
  public static void main(String[] theArgs) {
  junit.awtui.TestRunner.main(new String[] {TestBaseTag.class.getName()});
  }
  
  /**
   * @return a test suite (TestSuite) that includes all methods
   * starting with "test"
   */
  public static Test suite() {
  // All methods starting with "test" will be executed in the test suite.
  return new TestSuite(TestBaseTag.class);
  }
  
  private void runMyTest(String whichTest){
request.setAttribute("runTest", whichTest);
  try {

pageContext.forward("/test/org/apache/struts/taglib/html/TestBaseTag.jsp");
}
catch (Exception e) {
e.printStackTrace();
fail("There is a problem that is preventing the tests to 
continue!");
}
  }
  

cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/html TestButtonTag2.java TestButtonTag.java

[jmitchell]

jmitchell2003/02/26 18:17:50

  Modified:src/test/org/apache/struts/taglib/html TestButtonTag.java
  Added:   src/test/org/apache/struts/taglib/html TestButtonTag2.java
  Log:
  Oops.  Had to break this baby up so Tomcat 3.3 can handle the
  rather large amount of tags per page.
  
  Revision  ChangesPath
  1.2   +0 -55 
jakarta-struts/src/test/org/apache/struts/taglib/html/TestButtonTag.java
  
  Index: TestButtonTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/html/TestButtonTag.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestButtonTag.java27 Feb 2003 01:59:17 -  1.1
  +++ TestButtonTag.java27 Feb 2003 02:17:50 -  1.2
  @@ -109,14 +109,6 @@
fail("There is a problem that is preventing the tests to 
continue!");
}
   }
  -
  - private void formatAndTest(String compare, String output) {
  - //fix for introduced carriage return / line feeds
  - output = output.replaceAll("\r","");
  - output = output.replaceAll("\n","");
  - output = output.trim();
  - assertEquals(compare, output);
  - }
   
   /*
* Testing ButtonTag.
  @@ -202,52 +194,5 @@
   public void testButtonPropertyOnmouseup(){ 
runMyTest("testButtonPropertyOnmouseup", "");
}
  -
  -public void testButtonPropertyStyle(){ 
  - runMyTest("testButtonPropertyStyle", "");
  - }
  -
  -public void testButtonPropertyStyleClass(){ 
  - runMyTest("testButtonPropertyStyleClass", "");
  - }
  -
  -public void testButtonPropertyStyleId(){ 
  - runMyTest("testButtonPropertyStyleId", "");
  - }
  -
  -public void testButtonPropertyTabindex(){ 
  - runMyTest("testButtonPropertyTabindex", "");
  - }
  -
  -public void testButtonPropertyTitle(){ 
  - runMyTest("testButtonPropertyTitle", "");
  - }
  -
  -public void testButtonPropertyTitleKey(){ 
  - runMyTest("testButtonPropertyTitleKey", "");
  - }
  -
  -public void testButtonPropertyTitleKey_fr(){ 
  - runMyTest("testButtonPropertyTitleKey_fr", "fr");
  - }
  -
  -public void testButtonPropertyValue(){ 
  - runMyTest("testButtonPropertyValue", "");
  - }
  -
  -public void testButtonPropertyBodyContent(){ 
  - runMyTest("testButtonPropertyBodyContent", "");
  - }
  -
  -public void testButtonPropertyBodyContentMessageKey(){ 
  - runMyTest("testButtonPropertyBodyContentMessageKey", "");
  - }
  -
  -public void testButtonPropertyBodyContentMessageKey_fr(){ 
  - runMyTest("testButtonPropertyBodyContentMessageKey_fr", "fr");
  - }
  -
  -
  -
   
   }
  
  
  
  1.1  
jakarta-struts/src/test/org/apache/struts/taglib/html/TestButtonTag2.java
  
  Index: TestButtonTag2.java
  ===
  /*
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999-2001 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Struts", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIA

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html - New directory

[jmitchell]

jmitchell2003/02/26 18:18:17

  jakarta-struts/web/test/test/org/apache/struts/taglib/html - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestBaseTag.jsp TestButtonTag.jsp TestButtonTag2.jsp

[jmitchell]

jmitchell2003/02/26 18:18:45

  Added:   web/test/test/org/apache/struts/taglib/html TestBaseTag.jsp
TestButtonTag.jsp TestButtonTag2.jsp
  Log:
  Initial checkin.  Many more will follow.
  
  Revision  ChangesPath
  1.1  
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestBaseTag.jsp
  
  Index: TestBaseTag.jsp
  ===
  <%@ page contentType="text/html;charset=UTF-8" language="java" %>
  <[EMAIL PROTECTED] import="junit.framework.Assert"%>
  <%@ taglib uri="/WEB-INF/struts-logic.tld" prefix="logic" %>
  <%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" %>
  <%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>
  
  <%
  String server = request.getServerName();
  int port  = request.getServerPort();
  %>
  
  
  






  
  
  






  
  
  




http://www.my-server-name.com:<%=port%>/test/test/org/apache/struts/taglib/html/TestBaseTag.jsp">

  
  
  




http://www.my-server-name.com:<%=port%>/test/test/org/apache/struts/taglib/html/TestBaseTag.jsp"
 target="My-Other-Frame">

  
  
  
  <% 
  Assert.assertEquals(
pageContext.getAttribute("TEST_RESULTS").toString(), 
pageContext.getAttribute("EXPECTED_RESULTS").toString()
);
  %>
  
  
  1.1  
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestButtonTag.jsp
  
  Index: TestButtonTag.jsp
  ===
  <%@ page contentType="text/html;charset=UTF-8" language="java" %>
  <[EMAIL PROTECTED] import="junit.framework.Assert"%>
  <%@ taglib uri="/WEB-INF/struts-logic.tld" prefix="logic" %>
  <%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" %>
  <%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>
  
  






  
  
  






  
  
  






  
  
  






  
  
  






  
  
  






  
  
  






  
  
  






  
  
  






  
  
  







  
  
  






  
  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  






  
  
  
  
  <% 
  Assert.assertEquals(
pageContext.getAttribute("TEST_RESULTS").toString(), 
pageContext.getAttribute("EXPECTED_RESULTS").toString()
);
  %>
  
  
  1.1  
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestButtonTag2.jsp
  
  Index: TestButtonTag2.jsp
  ===
  <%@ page contentType="text/html;charset=UTF-8" language="java" %>
  <[EMAIL PROTECTED] import="junit.framework.Assert"%>
  <%@ taglib uri="/WEB-INF/struts-logic.tld" prefix="logic" %>
  <%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" %>
  <%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>
  
  
  






  
  
  






  
  
  






  
  
  






  
  
  


 

cvs commit: jakarta-struts/doc/userGuide struts-html.xml

[dgraham]

dgraham 2003/02/26 19:55:06

  Modified:doc/userGuide struts-html.xml
  Log:
  Added documentation to the html tag's locale attribute about creating sessions
  if needed.
  
  Revision  ChangesPath
  1.51  +5 -2  jakarta-struts/doc/userGuide/struts-html.xml
  
  Index: struts-html.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/struts-html.xml,v
  retrieving revision 1.50
  retrieving revision 1.51
  diff -u -r1.50 -r1.51
  --- struts-html.xml   4 Feb 2003 18:12:00 -   1.50
  +++ struts-html.xml   27 Feb 2003 03:55:06 -  1.51
  @@ -6,6 +6,7 @@
 Martin Cooper
 Mike Schachter
 James Turner
  +  David Graham
 The Struts Framework Project - HTML Tags
   
   
  @@ -2269,9 +2270,11 @@
   false
   true
   
  -  Set to true in order to record a Locale based on
  +  Set to true in order to store a Locale in the session 
based on
 the current request's Accept-Language header (if
  -  any) if none has currently been set.
  +  any) if none has currently been set.  This attribute will create a 
session
  +  if one does not already exist.  The lang attribute is rendered with 
the
  +  appropriate language code.
   
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/doc/userGuide building_controller.xml

[dgraham]

dgraham 2003/02/26 20:11:02

  Modified:doc/userGuide building_controller.xml
  Log:
  Updated to use processForwardConfig instead of deprecated processActionForward.
  
  Revision  ChangesPath
  1.56  +1 -1  jakarta-struts/doc/userGuide/building_controller.xml
  
  Index: building_controller.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/building_controller.xml,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- building_controller.xml   19 Jan 2003 00:40:41 -  1.55
  +++ building_controller.xml   27 Feb 2003 04:11:02 -  1.56
  @@ -309,7 +309,7 @@
   
   
   
  - processActionForward
  + processForwardConfig
   
   
   Finally, the process method of the RequestProcessor takes the 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/src/test/org/apache/struts/taglib/logic TestIterateTag.java

[jmitchell]

jmitchell2003/02/26 20:12:50

  Added:   src/test/org/apache/struts/taglib/logic TestIterateTag.java
  Log:
  Initial checkin.
  
  Revision  ChangesPath
  1.1  
jakarta-struts/src/test/org/apache/struts/taglib/logic/TestIterateTag.java
  
  Index: TestIterateTag.java
  ===
  /*
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999-2001 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Struts", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   */
  package org.apache.struts.taglib.logic;
  
  import java.io.IOException;
  import java.util.ArrayList;
  import java.util.HashMap;
  import java.util.StringTokenizer;
  
  import javax.servlet.ServletException;
  import javax.servlet.jsp.JspException;
  import javax.servlet.jsp.PageContext;
  import javax.servlet.jsp.tagext.BodyContent;
  
  import junit.framework.Test;
  import junit.framework.TestSuite;
  import org.apache.cactus.JspTestCase;
  import org.apache.cactus.WebRequest;
  import org.apache.cactus.WebResponse;
  import org.apache.struts.taglib.SimpleBeanForTesting;
  import org.apache.struts.taglib.bean.MessageTag;
  import org.apache.struts.util.LabelValueBean;
  
  
  /**
   * Suite of unit tests for the
   * org.apache.struts.taglib.logic.IterateTag class.
   *
   * @author James Mitchell
   */
  public class TestIterateTag extends JspTestCase {

private int iterations = 2;

  /**
   * Defines the testcase name for JUnit.
   *
   * @param theName the testcase's name.
   */
  public TestIterateTag(String theName) {
  super(theName);
  }
  
  /**
   * Start the tests.
   *
   * @param theArgs the arguments. Not used
   */
  public static void main(String[] theArgs) {
  junit.awtui.TestRunner.main(new String[] {TestIterateTag.class.getName()});
  }
  
  /**
   * @return a test suite (TestSuite) that includes all methods
   * starting with "test"
   */
  public static Test suite() {
  // All methods starting with "test" will be executed in the test suite.
  return new TestSuite(TestIterateTag.class);
  }
  
  
 /**
   * Testing IterateTag using name attribute in
   * the application scope.
   * 
 * Tests the equivalent of this tag in a jsp:
 *   
   * 
   */
  
// = Application
  public void testAp

cvs commit: jakarta-struts/doc/userGuide building_view.xml

[dgraham]

dgraham 2003/02/26 20:15:23

  Modified:doc/userGuide building_view.xml
  Log:
  Changed reference to perform method to execute.
  
  Revision  ChangesPath
  1.28  +1 -1  jakarta-struts/doc/userGuide/building_view.xml
  
  Index: building_view.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/building_view.xml,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- building_view.xml 19 Jan 2003 00:40:41 -  1.27
  +++ building_view.xml 27 Feb 2003 04:15:23 -  1.28
  @@ -446,7 +446,7 @@
   
   The validate method is called by the controller servlet after
   the  bean properties have been populated, but before the corresponding 
  -action class's perform method is invoked. 
  +action class's execute method is invoked. 
   The validate method has the following options:
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/doc/userGuide building_view.xml

[dgraham]

dgraham 2003/02/26 20:20:42

  Modified:doc/userGuide building_view.xml
  Log:
  Added note to validator section regarding the converNull servlet parameter
  and required validations of java.lang.Integer fields.
  
  Revision  ChangesPath
  1.29  +7 -0  jakarta-struts/doc/userGuide/building_view.xml
  
  Index: building_view.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/building_view.xml,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- building_view.xml 27 Feb 2003 04:15:23 -  1.28
  +++ building_view.xml 27 Feb 2003 04:20:42 -  1.29
  @@ -539,6 +539,13 @@
   
   
   
  +Note: If your required form property is one of the Java object 
representations of 
  +primitive types (ie. java.lang.Integer), you must set the ActionServlet's 
convertNull init.
  +parameter to true.  Failing to do this will result in the required validation 
not being performed
  +on that field because it will default to 0.
  +
  +
  +
   For more about the Struts Validator, see the 
   Developers Guide.
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17156] - Validate required fails for Integer form fields

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17156

Validate required fails for Integer form fields

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 04:23 ---
You must set the ActionServlet's converNull init. parameter to true so that 
Integer fields will default to null instead of 0.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Bug #17156 Validate Integer?

[David Graham]

Nice catch Ted!  It did validate properly once the convertNull parameter was 
set to true.  I've documented it in one place so far but am unsure of where 
else to put this note.

David



From: Ted Husted <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: Struts Developers List <[EMAIL PROTECTED]>
Subject: Re: Bug #17156 Validate Integer?
Date: Wed, 26 Feb 2003 00:45:58 -0500
Between 1.0 and 1.1 there's a switch that determines whether numerics like 
Integer go to 0 or to null. If you have the test setup, try it again with 
convertNull set to true as an ActionServlet parameter.

If it then works, we can just document the condition. Since numerics are 
not recommended for ActionForms, we don't need to solution to be 
particularly elegant =:0)

-Ted.

David Graham wrote:
That bug states that validate required does not work with an ActionForm 
property with type java.lang.Integer.  Indeed, I tested this with the 
struts-validator webapp's type form and required doesn't seem to run for 
that field when I changed it from String to Integer.  What does happen is 
that a "0" shows up in the text box while the other fields remain blank 
and their required error messages are displayed.

Is this simply a usage limitation of the validator?  One more reason to 
use Strings for all ActionForm properties?  I'm guessing that 0 shows up 
because that's the default value for an Integer object when it's created.  
I don't know enough about this to close the bug as INVALID or fix it.

Thoughts?

Thanks,
Dave




_
Help STOP SPAM with the new MSN 8 and get 2 months FREE*  
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--
Ted Husted,
Struts in Action 
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
Protect your PC - get McAfee.com VirusScan Online  
http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[patch] upload import statement cleanup

[Andrew Freeman]

I have removed the unused imports if anyone is interested.

HTH,
AndyIndex: org/apache/struts/webapp/upload/UploadAction.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/upload/org/apache/struts/webapp/upload/UploadAction.java,v
retrieving revision 1.7
diff -u -r1.7 UploadAction.java
--- org/apache/struts/webapp/upload/UploadAction.java   10 Dec 2002 06:03:21 - 
 1.7
+++ org/apache/struts/webapp/upload/UploadAction.java   27 Feb 2003 04:03:48 -
@@ -62,22 +62,21 @@
 package org.apache.struts.webapp.upload;
 
 
-import java.io.InputStream;
-import java.io.IOException;
-import java.io.OutputStream;
-import java.io.FileOutputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
 
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-import org.apache.struts.upload.FormFile;
 import org.apache.struts.action.Action;
 import org.apache.struts.action.ActionForm;
-import org.apache.struts.action.ActionMapping;
 import org.apache.struts.action.ActionForward;
-import org.apache.struts.action.ForwardingActionForward;
+import org.apache.struts.action.ActionMapping;
+import org.apache.struts.upload.FormFile;
 
 
 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[patch] validator import statement cleanup

[Andrew Freeman]

I reorganized the imports so they were alphabetical and added some blank
lines between top level packages.

HTH,
Andy
Index: org/apache/struts/webapp/validator/MultiRegistrationAction.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/validator/org/apache/struts/webapp/validator/MultiRegistrationAction.java,v
retrieving revision 1.4
diff -u -r1.4 MultiRegistrationAction.java
--- org/apache/struts/webapp/validator/MultiRegistrationAction.java 12 Nov 2002 
03:56:09 -  1.4
+++ org/apache/struts/webapp/validator/MultiRegistrationAction.java 27 Feb 2003 
04:04:21 -
@@ -56,9 +56,11 @@
 package org.apache.struts.webapp.validator;
 
 import java.util.Locale;
-import javax.servlet.http.HttpSession;
+
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.struts.action.Action;
Index: org/apache/struts/webapp/validator/RegistrationAction.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/validator/org/apache/struts/webapp/validator/RegistrationAction.java,v
retrieving revision 1.3
diff -u -r1.3 RegistrationAction.java
--- org/apache/struts/webapp/validator/RegistrationAction.java  9 Oct 2002 14:14:12 
-   1.3
+++ org/apache/struts/webapp/validator/RegistrationAction.java  27 Feb 2003 04:04:21 
-
@@ -56,9 +56,11 @@
 package org.apache.struts.webapp.validator;
 
 import java.util.Locale;
-import javax.servlet.http.HttpSession;
+
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.struts.action.Action;
Index: org/apache/struts/webapp/validator/RegistrationForm.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/validator/org/apache/struts/webapp/validator/RegistrationForm.java,v
retrieving revision 1.1
diff -u -r1.1 RegistrationForm.java
--- org/apache/struts/webapp/validator/RegistrationForm.java19 Mar 2002 03:33:58 
-  1.1
+++ org/apache/struts/webapp/validator/RegistrationForm.java27 Feb 2003 04:04:22 
-
@@ -56,7 +56,9 @@
 package org.apache.struts.webapp.validator;
 
 import java.io.Serializable;
+
 import javax.servlet.http.HttpServletRequest;
+
 import org.apache.struts.action.ActionMapping;
 import org.apache.struts.validator.ValidatorForm;
 
Index: org/apache/struts/webapp/validator/TypeAction.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/validator/org/apache/struts/webapp/validator/TypeAction.java,v
retrieving revision 1.3
diff -u -r1.3 TypeAction.java
--- org/apache/struts/webapp/validator/TypeAction.java  9 Oct 2002 14:14:12 -  
 1.3
+++ org/apache/struts/webapp/validator/TypeAction.java  27 Feb 2003 04:04:22 -
@@ -56,9 +56,11 @@
 package org.apache.struts.webapp.validator;
 
 import java.util.Locale;
-import javax.servlet.http.HttpSession;
+
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.struts.action.Action;
Index: org/apache/struts/webapp/validator/TypeForm.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/validator/org/apache/struts/webapp/validator/TypeForm.java,v
retrieving revision 1.4
diff -u -r1.4 TypeForm.java
--- org/apache/struts/webapp/validator/TypeForm.java11 Oct 2002 19:13:17 - 
 1.4
+++ org/apache/struts/webapp/validator/TypeForm.java27 Feb 2003 04:04:22 -
@@ -58,7 +58,9 @@
 import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.List;
+
 import javax.servlet.http.HttpServletRequest;
+
 import org.apache.struts.action.ActionMapping;
 import org.apache.struts.util.LabelValueBean;
 import org.apache.struts.validator.ValidatorForm;

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17442] - WebLogic StringIndexOutOfBoundsException loading example app

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17442

WebLogic StringIndexOutOfBoundsException loading example app

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|struts1.1RC:|WebLogic
   |StringIndexOutOfBoundsExcept|StringIndexOutOfBoundsExcept
   |ion |ion loading example app

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[patch] tiles-documentation import statement cleanup

[Andrew Freeman]

I have removed the unused imports if anyone is interested.

HTH,
AndyIndex: org/apache/struts/webapp/tiles/channel/SelectChannelAction.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/tiles-documentation/org/apache/struts/webapp/tiles/channel/SelectChannelAction.java,v
retrieving revision 1.1
diff -u -r1.1 SelectChannelAction.java
--- org/apache/struts/webapp/tiles/channel/SelectChannelAction.java 11 Jul 2002 
15:35:21 -  1.1
+++ org/apache/struts/webapp/tiles/channel/SelectChannelAction.java 27 Feb 2003 
04:03:12 -
@@ -61,22 +61,17 @@
 
 package org.apache.struts.webapp.tiles.channel;
 
-import org.apache.struts.taglib.tiles.ComponentConstants;
-
 import java.io.IOException;
-import java.util.Locale;
-import java.util.Vector;
-import javax.servlet.RequestDispatcher;
+
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpSession;
 import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+
 import org.apache.struts.action.Action;
 import org.apache.struts.action.ActionForm;
 import org.apache.struts.action.ActionForward;
 import org.apache.struts.action.ActionMapping;
-import org.apache.struts.action.ActionServlet;
-import org.apache.struts.util.MessageResources;
 
 public final class SelectChannelAction extends Action {
 
Index: org/apache/struts/webapp/tiles/dynPortal/PortalPrefsForm.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/tiles-documentation/org/apache/struts/webapp/tiles/dynPortal/PortalPrefsForm.java,v
retrieving revision 1.1
diff -u -r1.1 PortalPrefsForm.java
--- org/apache/struts/webapp/tiles/dynPortal/PortalPrefsForm.java   11 Jul 2002 
15:35:20 -  1.1
+++ org/apache/struts/webapp/tiles/dynPortal/PortalPrefsForm.java   27 Feb 2003 
04:03:12 -
@@ -61,8 +61,9 @@
 
 package org.apache.struts.webapp.tiles.dynPortal;
 
-import java.util.List;
 import java.util.ArrayList;
+import java.util.List;
+
 import org.apache.struts.action.ActionForm;
 
 
Index: org/apache/struts/webapp/tiles/dynPortal/PortalSettings.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/tiles-documentation/org/apache/struts/webapp/tiles/dynPortal/PortalSettings.java,v
retrieving revision 1.1
diff -u -r1.1 PortalSettings.java
--- org/apache/struts/webapp/tiles/dynPortal/PortalSettings.java11 Jul 2002 
15:35:20 -  1.1
+++ org/apache/struts/webapp/tiles/dynPortal/PortalSettings.java27 Feb 2003 
04:03:12 -
@@ -61,11 +61,9 @@
 
 package org.apache.struts.webapp.tiles.dynPortal;
 
-import java.util.List;
 import java.util.ArrayList;
 import java.util.Iterator;
-import java.util.Map;
-import java.util.HashMap;
+import java.util.List;
 
   /**
* Objects of this class hold portal settings for one user.
Index: org/apache/struts/webapp/tiles/invoice/EditInvoiceAction.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/tiles-documentation/org/apache/struts/webapp/tiles/invoice/EditInvoiceAction.java,v
retrieving revision 1.1
diff -u -r1.1 EditInvoiceAction.java
--- org/apache/struts/webapp/tiles/invoice/EditInvoiceAction.java   11 Jul 2002 
15:35:21 -  1.1
+++ org/apache/struts/webapp/tiles/invoice/EditInvoiceAction.java   27 Feb 2003 
04:03:12 -
@@ -62,20 +62,16 @@
 
 import java.io.IOException;
 import java.util.Locale;
-import java.util.Vector;
-import javax.servlet.RequestDispatcher;
+
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpSession;
 import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+
 import org.apache.struts.action.Action;
 import org.apache.struts.action.ActionForm;
 import org.apache.struts.action.ActionForward;
 import org.apache.struts.action.ActionMapping;
-import org.apache.struts.action.ActionServlet;
-import org.apache.struts.util.MessageResources;
-
-import org.apache.struts.util.RequestUtils;
 
 
 /**
Index: org/apache/struts/webapp/tiles/invoice/InvoiceForm.java
===
RCS file: 
/home/cvspublic/jakarta-struts/src/tiles-documentation/org/apache/struts/webapp/tiles/invoice/InvoiceForm.java,v
retrieving revision 1.1
diff -u -r1.1 InvoiceForm.java
--- org/apache/struts/webapp/tiles/invoice/InvoiceForm.java 11 Jul 2002 15:35:21 
-  1.1
+++ org/apache/struts/webapp/tiles/invoice/InvoiceForm.java 27 Feb 2003 04:03:13 
-
@@ -61,8 +61,6 @@
 
 package org.apache.struts.webapp.tiles.invoice;
 
-import java.util.Vector;
-import org.apache.struts.action.ActionErrors;
 import org.apache.struts.action.ActionForm;
 
 
Index: org/apache/struts/webapp/tiles/lang/SelectLocaleAction.java
=

DO NOT REPLY [Bug 17429] - getInputForward not working

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17429

getInputForward not working

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 04:40 ---
The struts-example app's LogonAction uses:


return mapping.getInputForward()


when your logon fails.  The example app works so this must be a configuration 
issue.  Please post further questions to the struts-user mailing list.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestButtonTag2.jsp

[jmitchell]

jmitchell2003/02/26 20:39:43

  Modified:src/test/org/apache/struts/taglib/html TestButtonTag2.java
   web/test/test/org/apache/struts/taglib/html
TestButtonTag2.jsp
  Log:
  Add tests for indexed buttons.
  
  Revision  ChangesPath
  1.2   +49 -0 
jakarta-struts/src/test/org/apache/struts/taglib/html/TestButtonTag2.java
  
  Index: TestButtonTag2.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/html/TestButtonTag2.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestButtonTag2.java   27 Feb 2003 02:17:50 -  1.1
  +++ TestButtonTag2.java   27 Feb 2003 04:39:43 -  1.2
  @@ -54,7 +54,10 @@
*/
   package org.apache.struts.taglib.html;
   
  +import java.util.ArrayList;
  +import java.util.HashMap;
   import java.util.Locale;
  +import java.util.StringTokenizer;
   
   import javax.servlet.jsp.PageContext;
   import junit.framework.Test;
  @@ -62,6 +65,7 @@
   
   import org.apache.cactus.JspTestCase;
   import org.apache.struts.Globals;
  +import org.apache.struts.taglib.SimpleBeanForTesting;
   
   /**
* Suite of unit tests for the
  @@ -158,6 +162,51 @@
runMyTest("testButtonPropertyBodyContentMessageKey_fr", "fr");
}
   
  +public void testButtonPropertyIndexedArray(){ 
  + ArrayList lst = new ArrayList();
  + lst.add("Test Message");
  + pageContext.setAttribute("lst", lst, PageContext.REQUEST_SCOPE);
  + runMyTest("testButtonPropertyIndexedArray", "");
  + }
  +
  +public void testButtonPropertyIndexedArrayProperty(){ 
  + SimpleBeanForTesting sbft = new SimpleBeanForTesting();
  + ArrayList lst = new ArrayList();
  + lst.add("Test Message");
  + sbft.setList(lst);
  + pageContext.setAttribute("lst", sbft, PageContext.REQUEST_SCOPE);
  + runMyTest("testButtonPropertyIndexedArrayProperty", "");
  + }
  +
  +public void testButtonPropertyIndexedMap(){ 
  + HashMap map = new HashMap();
  + map.put("tst1", "Test Message");
  + pageContext.setAttribute("lst", map, PageContext.REQUEST_SCOPE);
  + runMyTest("testButtonPropertyIndexedMap", "");
  + }
  +
  +public void testButtonPropertyIndexedMapProperty(){ 
  + SimpleBeanForTesting sbft = new SimpleBeanForTesting();
  + HashMap map = new HashMap();
  + map.put("tst1", "Test Message");
  + sbft.setMap(map);
  + pageContext.setAttribute("lst", sbft, PageContext.REQUEST_SCOPE);
  + runMyTest("testButtonPropertyIndexedMapProperty", "");
  + }
  +
  +public void testButtonPropertyIndexedEnumeration(){ 
  + StringTokenizer st = new StringTokenizer("Test Message");
  + pageContext.setAttribute("lst", st, PageContext.REQUEST_SCOPE);
  + runMyTest("testButtonPropertyIndexedEnumeration", "");
  + }
  +
  +public void testButtonPropertyIndexedEnumerationProperty(){ 
  + SimpleBeanForTesting sbft = new SimpleBeanForTesting();
  + StringTokenizer st = new StringTokenizer("Test Message");
  + sbft.setEnumeration(st);
  + pageContext.setAttribute("lst", sbft, PageContext.REQUEST_SCOPE);
  + runMyTest("testButtonPropertyIndexedEnumerationProperty", "");
  + }
   
   
   
  
  
  
  1.2   +83 -0 
jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestButtonTag2.jsp
  
  Index: TestButtonTag2.jsp
  ===
  RCS file: 
/home/cvs/jakarta-struts/web/test/test/org/apache/struts/taglib/html/TestButtonTag2.jsp,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TestButtonTag2.jsp27 Feb 2003 02:18:45 -  1.1
  +++ TestButtonTag2.jsp27 Feb 2003 04:39:43 -  1.2
  @@ -112,6 +112,89 @@
   
   
   
  +
  + 
  +   
  + 
  +   
  + 
  + 
  + 
  + 
  + 
  + 
  +
  +
  +
  + 
  +   
  + 
  +   
  + 
  + 
  + 
  + 
  + 
  + 
  +
  +
  +
  + 
  +   
  + 
  +   
  + 
  + 
  + 
  + 
  + 
  + 
  +
  +
  +
  + 
  +   
  + 
  +   
  + 
  + 
  + 
  + 
  + 
  + 
  +
  +
  +
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  +
  +
  +
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  + 
  +
  +
  +
   
   
   <% 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [patch] tiles-documentation import statement cleanup

[David Graham]

Patches should be posted to a bugzilla ticket.  Cleaning up imports is not 
high on my list of todos for getting 1.1 released.

David



From: "Andrew Freeman" <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: "Struts-Dev" <[EMAIL PROTECTED]>
Subject: [patch] tiles-documentation import statement cleanup
Date: Wed, 26 Feb 2003 23:32:20 -0500
I have removed the unused imports if anyone is interested.

HTH,
Andy
<< struts-tiles-documentation-imports.txt >>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
Protect your PC - get McAfee.com VirusScan Online  
http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17225] - Struts-config.xml parsing issue in JRun 3.0.2a

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17225

Struts-config.xml parsing issue in JRun 3.0.2a

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 04:52 ---
I'm closing this for now.  If it's not the parser issue, please ask for help on 
struts-user before reopening.  Unfortunately, it's difficult for some of us to 
test these non-free container specific issues.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17442] - WebLogic StringIndexOutOfBoundsException loading example app

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17442

WebLogic StringIndexOutOfBoundsException loading example app

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 04:59 ---
I don't see any Struts methods in the stack trace so I think it's a container 
issue.  Please ask for help on struts-user.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17328] - Unsafe initialization in PropertyMessageResources

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17328

Unsafe initialization in PropertyMessageResources

[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|1.1 Beta 3  |1.1 RC1

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17234] - language attr for html:form's and html:javascript's script elements

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17234

language attr for html:form's and html:javascript's script elements

[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|struts- |[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |
 Status|REOPENED|NEW

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17418] - should not render newlines

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17418

 should not render newlines

[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|struts- |[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 16743] - Allow RequestProcessor to access Token methods

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16743

Allow RequestProcessor to access Token methods

[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|struts- |[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |



--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 05:28 ---
Maybe we should move the token functionality to RequestUtils.  The action token 
methods would remain but simply call the appropriate RequestUtils method.  A 
specialized RequestProcessor could also call the RequestUtils methods.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [patch] tiles-documentation import statement cleanup

[Andrew Freeman]

Hi David,

The following links state that I can submit patches directly to the mailing
list as long as I prefix the patches with a [PATCH] prefix in the subject:

http://jakarta.apache.org/site/bugs.html

and

http://jakarta.apache.org/site/source.html

Does the Struts community have stricter guidelines?

thanks,
Andy


-Original Message-
From: David Graham [mailto:[EMAIL PROTECTED]
Sent: Wednesday, February 26, 2003 11:45 PM
To: [EMAIL PROTECTED]
Subject: Re: [patch] tiles-documentation import statement cleanup


Patches should be posted to a bugzilla ticket.  Cleaning up imports is not
high on my list of todos for getting 1.1 released.

David



>From: "Andrew Freeman" <[EMAIL PROTECTED]>
>Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
>To: "Struts-Dev" <[EMAIL PROTECTED]>
>Subject: [patch] tiles-documentation import statement cleanup
>Date: Wed, 26 Feb 2003 23:32:20 -0500
>
>I have removed the unused imports if anyone is interested.
>
>HTH,
>Andy
><< struts-tiles-documentation-imports.txt >>
>-
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]


_
Protect your PC - get McAfee.com VirusScan Online
http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 5896] - the Template:get Tag should add a default parameter

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5896

the Template:get Tag should add a default parameter

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|LATER   |



--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 05:39 ---
The template library is now officially deprecated in favor of Tiles so no new 
development will be done on it.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 5896] - the Template:get Tag should add a default parameter

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5896

the Template:get Tag should add a default parameter

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [patch] tiles-documentation import statement cleanup

[David Graham]

I know those pages say that but that's not how Struts patches work.  *All* 
Struts patches should be attached to a bugzilla report or they will get lost 
in the mail.  Imagine the nightmare it would be for committers to save all 
the patches locally and manage them without bugzilla!

David



From: "Andrew Freeman" <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: "Struts Developers List" <[EMAIL PROTECTED]>
Subject: RE: [patch] tiles-documentation import statement cleanup
Date: Thu, 27 Feb 2003 00:28:33 -0500
Hi David,

The following links state that I can submit patches directly to the mailing
list as long as I prefix the patches with a [PATCH] prefix in the subject:
http://jakarta.apache.org/site/bugs.html

and

http://jakarta.apache.org/site/source.html

Does the Struts community have stricter guidelines?

thanks,
Andy
-Original Message-
From: David Graham [mailto:[EMAIL PROTECTED]
Sent: Wednesday, February 26, 2003 11:45 PM
To: [EMAIL PROTECTED]
Subject: Re: [patch] tiles-documentation import statement cleanup
Patches should be posted to a bugzilla ticket.  Cleaning up imports is not
high on my list of todos for getting 1.1 released.
David



>From: "Andrew Freeman" <[EMAIL PROTECTED]>
>Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
>To: "Struts-Dev" <[EMAIL PROTECTED]>
>Subject: [patch] tiles-documentation import statement cleanup
>Date: Wed, 26 Feb 2003 23:32:20 -0500
>
>I have removed the unused imports if anyone is interested.
>
>HTH,
>Andy
><< struts-tiles-documentation-imports.txt >>
>-
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
_
Protect your PC - get McAfee.com VirusScan Online
http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
MSN 8 with e-mail virus protection service: 2 months FREE*  
http://join.msn.com/?page=features/virus

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [patch] tiles-documentation import statement cleanup

[Andrew Freeman]

NP.  I will create a bug report and attach the patches.

Again, HTH.
Andy

-Original Message-
From: David Graham [mailto:[EMAIL PROTECTED]
Sent: Thursday, February 27, 2003 12:46 AM
To: [EMAIL PROTECTED]
Subject: RE: [patch] tiles-documentation import statement cleanup


I know those pages say that but that's not how Struts patches work.  *All*
Struts patches should be attached to a bugzilla report or they will get lost
in the mail.  Imagine the nightmare it would be for committers to save all
the patches locally and manage them without bugzilla!

David



>From: "Andrew Freeman" <[EMAIL PROTECTED]>
>Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
>To: "Struts Developers List" <[EMAIL PROTECTED]>
>Subject: RE: [patch] tiles-documentation import statement cleanup
>Date: Thu, 27 Feb 2003 00:28:33 -0500
>
>Hi David,
>
>The following links state that I can submit patches directly to the mailing
>list as long as I prefix the patches with a [PATCH] prefix in the subject:
>
>http://jakarta.apache.org/site/bugs.html
>
>and
>
>http://jakarta.apache.org/site/source.html
>
>Does the Struts community have stricter guidelines?
>
>thanks,
>Andy
>
>
>-Original Message-
>From: David Graham [mailto:[EMAIL PROTECTED]
>Sent: Wednesday, February 26, 2003 11:45 PM
>To: [EMAIL PROTECTED]
>Subject: Re: [patch] tiles-documentation import statement cleanup
>
>
>Patches should be posted to a bugzilla ticket.  Cleaning up imports is not
>high on my list of todos for getting 1.1 released.
>
>David
>
>
>
> >From: "Andrew Freeman" <[EMAIL PROTECTED]>
> >Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
> >To: "Struts-Dev" <[EMAIL PROTECTED]>
> >Subject: [patch] tiles-documentation import statement cleanup
> >Date: Wed, 26 Feb 2003 23:32:20 -0500
> >
> >I have removed the unused imports if anyone is interested.
> >
> >HTH,
> >Andy
> ><< struts-tiles-documentation-imports.txt >>
> >-
> >To unsubscribe, e-mail: [EMAIL PROTECTED]
> >For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>_
>Protect your PC - get McAfee.com VirusScan Online
>http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963
>
>
>-
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>
>
>-
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]


_
MSN 8 with e-mail virus protection service: 2 months FREE*
http://join.msn.com/?page=features/virus


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 16792] - Migrate to commons-resources for message resources functionality

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16792

Migrate to commons-resources for message resources functionality





--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 06:01 ---
Created an attachment (id=5059)
o.a.s.u.MessageResources + friends -- unit tests

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Unit test for o.a.s.u.MessageResources + friends

[Steve Peterson]

Moments ago I uploaded a zip file containing unit tests for 
o.a.s.u.MessageResources and its three friends as an attachment to bug 
16792.  This is the first step in rewriting them to run on top of 
commons-resources.

http://issues.apache.org/bugzilla/show_bug.cgi?id=16792

I'd be particularly interested in your feedback on whether the quality of 
the unit tests is at the right level.

S



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17464] New: - [PATCH] test folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17464

[PATCH] test folder import statement cleanup

   Summary: [PATCH] test folder import statement cleanup
   Product: Struts
   Version: Nightly Build
  Platform: Other
   URL: http://http://
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Test
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I removed the unused imports if anyone is interested.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17465] New: - html:select el tag does not work for preset value

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17465

html:select el tag does not work for preset value

   Summary: html:select el tag does not work for preset value
   Product: Struts
   Version: 1.1 RC1
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Major
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


for the following usage;

<%@ taglib uri="http://jakarta.apache.org/struts/tags-html"; prefix="html" %>
...

  


work correctly to highlight the value in the list corresponding to "value=xxx"
being selected.

When the same code is changed to use

<%@ taglib uri="http://jakarta.apache.org/struts/tags-html-el"; prefix="html" %>

The list remains unselected.


The example use a scriptlet so the same code runs in both regular and el 
version of HTML tags for comparison.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17464] - [PATCH] test folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17464

[PATCH] test folder import statement cleanup





--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 06:09 ---
Created an attachment (id=5060)
test folder import cleanup

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17466] New: - [PATCH] share folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17466

[PATCH] share folder import statement cleanup

   Summary: [PATCH] share folder import statement cleanup
   Product: Struts
   Version: Nightly Build
  Platform: Other
   URL: http://http://
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Controller
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I removed the unused imports if anyone is interested.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17466] - [PATCH] share folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17466

[PATCH] share folder import statement cleanup





--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 06:11 ---
Created an attachment (id=5061)
share folder imports

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17467] New: - [PATCH] validator folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17467

[PATCH] validator folder import statement cleanup

   Summary: [PATCH] validator folder import statement cleanup
   Product: Struts
   Version: Nightly Build
  Platform: Other
   URL: http://http://
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Validator Framework
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I removed the unused imports if anyone is interested.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17467] - [PATCH] validator folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17467

[PATCH] validator folder import statement cleanup





--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 06:15 ---
Created an attachment (id=5062)
validator folder import cleanup

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17468] New: - [PATCH] tiles-documentation folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17468

[PATCH] tiles-documentation folder import statement cleanup

   Summary: [PATCH] tiles-documentation folder import statement
cleanup
   Product: Struts
   Version: Nightly Build
  Platform: Other
   URL: http://http://
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Tiles framework
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I cleaned up the imports if anyone is interested.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17468] - [PATCH] tiles-documentation folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17468

[PATCH] tiles-documentation folder import statement cleanup





--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 06:17 ---
Created an attachment (id=5063)
tiles-documentation folder import cleanup

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17469] New: - [PATCH] upload folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17469

[PATCH] upload folder import statement cleanup

   Summary: [PATCH] upload folder import statement cleanup
   Product: Struts
   Version: Nightly Build
  Platform: Other
   URL: http://http://
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: File Upload
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I cleaned up the imports if anyone is interested.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17464] - [PATCH] test folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17464

[PATCH] test folder import statement cleanup

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17466] - [PATCH] share folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17466

[PATCH] share folder import statement cleanup

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17469] - [PATCH] upload folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17469

[PATCH] upload folder import statement cleanup





--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 06:18 ---
Created an attachment (id=5064)
upload folder import cleanup

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17467] - [PATCH] validator folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17467

[PATCH] validator folder import statement cleanup

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17468] - [PATCH] tiles-documentation folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17468

[PATCH] tiles-documentation folder import statement cleanup

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17469] - [PATCH] upload folder import statement cleanup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17469

[PATCH] upload folder import statement cleanup

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17465] - html:select el tag does not work for preset value

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17465

html:select el tag does not work for preset value

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-02-27 06:22 ---
You can't use jsp expressions in the el library, just el statements.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]