date:20040225

1.2.0 uploaded (Re: 1.2.0 is tagged and frozen)

2004-02-25 Thread Martin Cooper

On Sun, 22 Feb 2004, Martin Cooper wrote:

> The release is built, but I have a couple of problems.
>
> 1) My ISP has gone flaky on me, and I haven't been able to upload it to
> minotaur. They claim the problems should be fixed tomorrow, so hopefully
> I'll be able to upload it then.

The release is now, finally, on minotaur. You can find it here:

http://www.apache.org/~martinc/struts/

Before I send out an announcement message, I would really appreciate it if
someone could verify the integrity of the files (e.g. by checking the sigs
against the files themselves), since I had so much trouble uploading them.

As a result of this debacle, I have a new-found intense dislike of my ISP
and a new-found respect for Linux. My ISP supports only Windows, and has
been unable to resolve my problems in uploading large files using Windows,
even though it is abundantly clear that the problem is on their end.

Eventually, I solved the problem by transferring the files to a separate
box that runs SuSE Linux (Thanks, Arron!), and uploading the files from
there using scp. My ISP does not support Linux at all, yet scp on Linux
recovered from the network stalls that caused Windows to lock up. So it
seems that networking is more reliable, with my ISP, using unsupported
operating systems than using supported operating systems...

--
Martin Cooper

>
> 2) Some of the exercise-taglibs tests are failing:
> 2a)  fails because it is trying to include welcome.html,
> but there is no such file.
> 2b)  fails because there are no images in the struts-examples
> web app at all.
> 2c)  fails with a lot of nulls in the test table.
>
> It looks like all of these are probably issues with the test app itself,
> rather than the tags, so I'm not overly concerned, and suspect we probably
> should go ahead with 1.2.0 anyway, especially since we're not claiming
> it's a final release.
>
> Once I get the build uploaded, I'll ask other folks to take it for a spin
> before sending out an announcement.
>
> Actually, with this new release strategy, where should the announcement
> message go, since it's not a Final release? The same lists, or a subset?
> Thoughts?
>
> --
> Martin Cooper
>
>
> On Sun, 22 Feb 2004, Martin Cooper wrote:
>
> > Please hold off on all checkins until the release is done.
> >
> > Thanks.
> >
> > --
> > Martin Cooper
> >
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: 1.2.0 uploaded (Re: 1.2.0 is tagged and frozen)

2004-02-25 Thread Matt Raible

The first thing I noticed is that struts-el is missing from the
download.  I used the one I had from a nightly build in December and it
didn't seem to cause conflicts.

I tried 1.2.0 in AppFuse and all tests pass!  Nice work gents.  I didn't
even have to modify any files - my last Struts update was December 2,
2003.

Matt

> -Original Message-
> From: Martin Cooper [mailto:[EMAIL PROTECTED] 
> Sent: Wednesday, February 25, 2004 1:39 AM
> To: Struts Developers List
> Subject: 1.2.0 uploaded (Re: 1.2.0 is tagged and frozen)
> 
> 
> On Sun, 22 Feb 2004, Martin Cooper wrote:
> 
> > The release is built, but I have a couple of problems.
> >
> > 1) My ISP has gone flaky on me, and I haven't been able to 
> upload it 
> > to minotaur. They claim the problems should be fixed tomorrow, so 
> > hopefully I'll be able to upload it then.
> 
> The release is now, finally, on minotaur. You can find it here:
> 
> http://www.apache.org/~martinc/struts/
> 
> Before I send out an announcement message, I would really 
> appreciate it if someone could verify the integrity of the 
> files (e.g. by checking the sigs against the files 
> themselves), since I had so much trouble uploading them.
> 
> 
> As a result of this debacle, I have a new-found intense 
> dislike of my ISP and a new-found respect for Linux. My ISP 
> supports only Windows, and has been unable to resolve my 
> problems in uploading large files using Windows, even though 
> it is abundantly clear that the problem is on their end.
> 
> Eventually, I solved the problem by transferring the files to 
> a separate box that runs SuSE Linux (Thanks, Arron!), and 
> uploading the files from there using scp. My ISP does not 
> support Linux at all, yet scp on Linux recovered from the 
> network stalls that caused Windows to lock up. So it seems 
> that networking is more reliable, with my ISP, using 
> unsupported operating systems than using supported operating 
> systems... 
> 
> --
> Martin Cooper
> 
> 
> >
> > 2) Some of the exercise-taglibs tests are failing:
> > 2a)  fails because it is trying to include 
> welcome.html, 
> > but there is no such file.
> > 2b)  fails because there are no images in the 
> > struts-examples web app at all.
> > 2c)  fails with a lot of nulls in the test table.
> >
> > It looks like all of these are probably issues with the test app 
> > itself, rather than the tags, so I'm not overly concerned, 
> and suspect 
> > we probably should go ahead with 1.2.0 anyway, especially 
> since we're 
> > not claiming it's a final release.
> >
> > Once I get the build uploaded, I'll ask other folks to take 
> it for a 
> > spin before sending out an announcement.
> >
> > Actually, with this new release strategy, where should the 
> > announcement message go, since it's not a Final release? The same 
> > lists, or a subset? Thoughts?
> >
> > --
> > Martin Cooper
> >
> >
> > On Sun, 22 Feb 2004, Martin Cooper wrote:
> >
> > > Please hold off on all checkins until the release is done.
> > >
> > > Thanks.
> > >
> > > --
> > > Martin Cooper
> > >
> > >
> > > 
> 
> > > -
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: 
> [EMAIL PROTECTED]
> > >
> > >
> >
> > 
> -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: 1.2.0 uploaded (Re: 1.2.0 is tagged and frozen) - watch out for ActionErrors -> ActionMessages in validation code

2004-02-25 Thread Roberto Tyley


I notice that the most recent version of your splendid two-fields
validator (looking in CVS at
http://cvs.sourceforge.net/viewcvs.py/*checkout*/struts/appfuse/src/web/
org/appfuse/webapp/util/ValidationUtil.java) still has the ActionErrors
class in it's method signature:

boolean validateTwoFields(Object bean, ValidatorAction va, Field field,
ActionErrors errors, HttpServletRequest request)

However, you can get some nasty silent errors from struts if you do
this, as the 'errors' variable won't be populated (it'll be null, due to
struts now expecting it to be the ActionMessages class), and when the
null pointer exception occurs in your method (when you attempt to report
a validation error), it will cause some difficult-to-diagnose errors
higher up the stack.

For a bit more insight into the nullness of the 'errors' variable, look
at the initValidator() method in the Resources class:

http://cvs.apache.org/viewcvs.cgi/jakarta-struts/src/share/org/apache/st
ruts/validator/Resources.java

The ActionErrors->ActionMessages change occurred somewhere around rev
1.22 of that class.

The updated version of your validateTwoFields method looks like this:

public static boolean validateTwoFields(
Object bean,
ValidatorAction va,
Field field,
ActionMessages errors,
HttpServletRequest request) {
String value1 = ValidatorUtils.getValueAsString(bean,
field.getProperty());
String sProperty2 = field.getVarValue("secondProperty");
String value2 = ValidatorUtils.getValueAsString(bean,
sProperty2);
try {
boolean equal = GenericValidator.isBlankOrNull(value1) ?
GenericValidator.isBlankOrNull(value2) : value1.equals(value2);

if (!equal) {
errors.add(field.getKey(),
Resources.getActionMessage(request, va, field));
return false;
}
} catch (Exception e) {
errors.add(field.getKey(),
Resources.getActionMessage(request, va, field));
return false;
}

return true;
}

(I also corrected a small bug at line 44 of the old method where
value1=null, value2='some text' would validate ok!).

Best regards,
Roberto




-Original Message-
From: Matt Raible [mailto:[EMAIL PROTECTED] 
Sent: 25 February 2004 09:15
To: 'Struts Developers List'
Subject: RE: 1.2.0 uploaded (Re: 1.2.0 is tagged and frozen)

The first thing I noticed is that struts-el is missing from the
download.  I used the one I had from a nightly build in December and it
didn't seem to cause conflicts.

I tried 1.2.0 in AppFuse and all tests pass!  Nice work gents.  I didn't
even have to modify any files - my last Struts update was December 2,
2003.

Matt



--- -
Visit our Internet site at http://www.reuters.com

Get closer to the financial markets with Reuters Messaging - for more
information and to register, visit http://www.reuters.com/messaging

Any views expressed in this message are those of  the  individual
sender,  except  where  the sender specifically states them to be
the views of Reuters Ltd.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27204] - HTTP 500 with not existing properties of a specific locale

2004-02-25 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27204

HTTP 500 with not existing properties of a specific locale

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-02-25 16:24 ---
?

This is not a question, this is a bug description and I delivered the solution 
with it. I don't understand your answer. If you didn't understand my 
description, please ask questions about it.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27228] New: - nested errors and messages does not have correct nesting for property

2004-02-25 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27228

nested errors and messages does not have correct nesting for property

   Summary: nested errors and messages does not have correct nesting
for property
   Product: Struts
   Version: 1.1 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Custom Tags
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When using nested:errors/nested:messages tags, NestedPropertyHelper does not 
calculate the nested property correctly.
 

 
 

 
The nested errors tag will look for errors that are keyed by "first" instead of 
by "names[0].first" so the property is not found and the error is not printed.  
The same problem exists for nested:messages.
 
Sorry, I keep reporting this bug, but it never shows up on my bugzilla screen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Bug in JavascriptValidatorTag

2004-02-25 Thread Ralph Schaer

Thanks for fixing that. But there is still a problem.
(Nightly Build 2004/02/25)
You can see the error in the struts-example web application.
There is a staticJavascript.jsp page with this content

<%@ page language="java" %>
<%-- set document type to Javascript (addresses a bug in Netscape 
according to a web resource --%>
<%@ page contentType="application/x-javascript" %>

<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>



and logon contains this line:

Now the problem is that the html:javascript tag also writes the  
tag into the output.