DO NOT REPLY [Bug 5684] - WEB-INF/lib jar file loading and operations problems.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5684

WEB-INF/lib jar file loading and operations problems.





--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 01:47 ---
For problem 1 and 2:
In tomcat 3.2.3, these problems did not exist.  You could delete, rename, and 
replace jars even while the context was running.  If you deleted a jar, tomcat 
would throw a:

2002-01-03 23:31:37 - Ctx( www.foodomain.com:/examples ): Exception in: R
( /examples + /servlet/HelloWorldExample + null) - 
java.lang.IllegalArgumentException: Repository 
D:\home\foodomain\www\examples\WEB-INF\lib\examplesdir2.jar doesn't exist!
 
After deleting a live jar (this is an extreme), a remove and add of the context 
will restore everything perfectly.  No need to shutdown tomcat/jvm.

To verify this, I reloaded tomcat 3.2.3 and re-tested everything.  It all 
worked like before.  The jvm is still the same at 1.3.1_01.  Can you folks look 
into it?  I really like 3.3 classloading scheme so I dont want to go back to 
3.2.

Any comments?
Thanks
Mike

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5684] - WEB-INF/lib jar file loading and operations problems.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5684

WEB-INF/lib jar file loading and operations problems.





--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 02:54 ---
One workaround is to use straight classes rather then jars (i.e. unpack your
jars in the classes directory).

As for the ZIP class problems, I've submitted this bug to Sun a number of times
and I was able to replicate it on Windows and Linux. But, they wouldn't buy it.
The following sample program illustrates the problem:

--
import java.io.*;
import java.net.*;
import java.util.*;

class ZipFileTest extends ClassLoader{

  public static void main(String argv[]){
LineNumberReader in=new LineNumberReader(new
InputStreamReader(System.in));

while(true){
  Properties p=new Properties();
  try{
// Get the resource using the first ClassLoader object (first
set)
ZipFileTest t=new ZipFileTest();
System.err.println("t="+t);

InputStream i=t.getResourceAsStream("/some/properties/file.props");
System.err.println("i="+i);
p.load(i);
p.save(System.out,"");

// Get rid of the objects
i=null; t=null; p=null;

// Wait for user input while replacing the jar
in.readLine();
  } catch(Throwable t){
System.out.println(t);
t.printStackTrace(System.out);
System.exit(1);
  }
}
  }
}
--

All you need to do is have a JAR file with a properties files inside it (make
sure you change the name). Run the  program and it will print out the properties
file. After that it'll wait for your input. At that point replace the JAR file
with another JAR file that contains the same properties file, but is otherwise
different. After the input is received, the program will fail while reading the
JAR file, given the JAR file is sufficiently different (i.e. at times there will
be no problems).

Bojan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5679] - Returned cookies still appear to be URL encoded

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5679

Returned cookies still appear to be URL encoded

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 03:14 ---


*** This bug has been marked as a duplicate of 4295 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4295] - Cookies not following RFC2109

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4295

Cookies not following RFC2109

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||tomcat-
   ||[EMAIL PROTECTED]
   Priority|Other   |Low

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: Why do I receive CVS-commit stuff?

[Michiel de Mare]

> On Thu, 3 Jan 2002, Roland wrote:
> 
> I'm afraid not.
> 
> The presumption here, as well as most other Jakarta projects, is that
> anyone subscribed to a DEVELOPER mailing list is interested 
> in seeing what
> is actually happening to the code, as well as the discussions 
> among the
> developers.  Therefore, the CVS commits (as well as changes to the
> Bugzilla bug reports) are automatically reflected to TOMCAT-DEV.
> 
> Craig

I think that presumption is incorrect. At least some people, like the
original poster and myself, are interested in the discussions about the
development of tomcat, but not in the lower-level cvs/bugzilla posts. I
don't terribly mind filtering out those posts, but I prefer the approach of
e.g. www.tigris.org , i.e. have separate dev and cvs mailinglists.

Michiel.


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[PATCH]: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties

[Adrian Almenar]

Just some enhancements for Spanish Language.

Cheers,

Adrian Almenar
Systems & Development Department
Conectium Limited



ApplicationResources_en.properties.patch
Description: Binary data

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5680] - Application Manager bug in org.apache.catalina.core.StandardHost.java

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5680

Application Manager bug in org.apache.catalina.core.StandardHost.java





--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 06:04 ---
I may be wrong, but I think that's what was being done in the past, but IMO it's
too dangerous to just delete the files, as the user could have modified some
webapp settings by editing some configuration file.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5368] - StandardContextValve changes session state from new to old too late for other Valves

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5368

StandardContextValve changes session state from new to old too late for other Valves





--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 06:39 ---
I've looked at the patch, but I'm not convinced that kind of extensive change is
needed here, since we should be able to call the session access() in the
StandardHostValve right after the context is mapped (and therfore before any
valve in the "context pipeline" is called). Or did I miss something ?

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5319] - AccessLogValve does not resolve hostname

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5319

AccessLogValve does not resolve hostname

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 07:29 ---
*** Bug 5601 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5601] - getRemoteHost returns ip address

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5601

getRemoteHost returns ip address

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 07:29 ---


*** This bug has been marked as a duplicate of 5319 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5535] - Some Browser cannot understand Path and Domain in Set-Cookie header

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5535

Some Browser cannot understand Path and Domain in Set-Cookie header

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement
   Priority|Other   |Medium
Version|4.0.1 Final |Nightly Build



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 07:35 ---
I personally don't recommend adding workarounds to try to support broken clients
and proprietary features. I'm downgrading the severity to "enhancement" since
the current behavior is already correct.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardContextValve.java StandardHostValve.java

[remm]

remm02/01/04 08:33:40

  Modified:catalina/src/share/org/apache/catalina/core
StandardContextValve.java StandardHostValve.java
  Log:
  - Fix for 5368: mark the session as accessed before going in the Context
pipeline (before, the session was marked as non-new only in the last useable
valve of the pipeline). This is not the proposed patch for this bug. Please confirm
it does fix the problem.
  
  Revision  ChangesPath
  1.15  +6 -17 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java
  
  Index: StandardContextValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- StandardContextValve.java 5 Oct 2001 22:03:53 -   1.14
  +++ StandardContextValve.java 4 Jan 2002 16:33:40 -   1.15
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
 1.14 2001/10/05 22:03:53 remm Exp $
  - * $Revision: 1.14 $
  - * $Date: 2001/10/05 22:03:53 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
 1.15 2002/01/04 16:33:40 remm Exp $
  + * $Revision: 1.15 $
  + * $Date: 2002/01/04 16:33:40 $
*
* 
*
  @@ -74,10 +74,9 @@
   import org.apache.naming.ContextBindings;
   import org.apache.naming.resources.DirContextURLStreamHandler;
   import org.apache.catalina.Container;
  -import org.apache.catalina.Manager;
  +import org.apache.catalina.Context;
   import org.apache.catalina.Request;
   import org.apache.catalina.Response;
  -import org.apache.catalina.Session;
   import org.apache.catalina.ValveContext;
   import org.apache.catalina.Wrapper;
   import org.apache.catalina.util.RequestUtil;
  @@ -93,7 +92,7 @@
* when processing HTTP requests.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.14 $ $Date: 2001/10/05 22:03:53 $
  + * @version $Revision: 1.15 $ $Date: 2002/01/04 16:33:40 $
*/
   
   final class StandardContextValve
  @@ -169,17 +168,7 @@
   return;
   }
   
  -// Update the session last access time for our session (if any)
  -StandardContext context = (StandardContext) getContainer();
  -String sessionId = hreq.getRequestedSessionId();
  -if (sessionId != null) {
  -Manager manager = context.getManager();
  -if (manager != null) {
  -Session session = manager.findSession(sessionId);
  -if ((session != null) && session.isValid())
  -session.access();
  -}
  -}
  +Context context = (Context) getContainer();
   
   // Select the Wrapper to be used for this Request
   Wrapper wrapper = null;
  
  
  
  1.6   +21 -5 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java
  
  Index: StandardHostValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- StandardHostValve.java22 Jul 2001 20:25:08 -  1.5
  +++ StandardHostValve.java4 Jan 2002 16:33:40 -   1.6
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
 1.5 2001/07/22 20:25:08 pier Exp $
  - * $Revision: 1.5 $
  - * $Date: 2001/07/22 20:25:08 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
 1.6 2002/01/04 16:33:40 remm Exp $
  + * $Revision: 1.6 $
  + * $Date: 2002/01/04 16:33:40 $
*
* 
*
  @@ -71,8 +71,10 @@
   import javax.servlet.http.HttpServletResponse;
   import org.apache.catalina.Container;
   import org.apache.catalina.Context;
  +import org.apache.catalina.Manager;
   import org.apache.catalina.Request;
   import org.apache.catalina.Response;
  +import org.apache.catalina.Session;
   import org.apache.catalina.ValveContext;
   import org.apache.catalina.util.StringManager;
   import org.apache.catalina.valves.ValveBase;
  @@ -86,7 +88,7 @@
* when processing HTTP requests.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.5 $ $Date: 2001/07/22 20:25:08 $
  + * @version $Revision: 1.6 $ $Date: 2002/01/04 16:33:40 $
*/
   
   final class StandardHostValve
  @@ -158,9 +160,23 @@
   return;
   }
   
  -// Ask this Context to process this request
  +  

DO NOT REPLY [Bug 5368] - StandardContextValve changes session state from new to old too late for other Valves

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5368

StandardContextValve changes session state from new to old too late for other Valves

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 08:34 ---
The nightly for 01/05 will contain the fix I was talking about.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: tomcat 4.0.2 and jakarta-tomcat-connectors

[costinm]

+1

I think we should tag the code with jk_1_4 ( considering the jk that was
included with 3.1 == jk1.1, etc ). It seems jk_1_4 will work
with 3.3, 4.0.x and 4.1 ( and the C code can be used for 3.2.x for bug
fixes ).

Regarding jk2, I'm still working, the current strugle is with the unix
domain sockets ( since JFC commited the jk implementation, and I promised
I'll do the java side ). I did some more changes in mod_jk(2) config, now
seting "JkWebapp" in a Location context works for virtual hosts and almost
everything else. I do plan few more config changes - automatically
restrict WEB-INF, etc, and I want to get at least basic info out of the
status worker. On the java side we have a first version, but I still have
to integrate it with either the interceptor/connector, or ( assuming
everything works as it seems ) in JkServlet ( using what I proposed last
year, i.e. web.xml/'standard' servlets + 'trusted apps' + a bit of magic).
Sorry it takes so long, but I have a lot of other work to do...

Costin


On Thu, 3 Jan 2002, Kevin Seguin wrote:

> there was a thread a couple weeks ago regarding what to do with j-t-c and
> tomcat 4.0.2.  i believe it was decided that the 4.0.2 release would contain
> the same jars from j-t-c (tomcat-ajp.jar, tomcat-util.jar) as 4.0.1 did.
>
> well, i just did some quick tests with the 4.0.2-b1 dist and the head of
> j-t-c, and all seemed to be in working order.
>
> so, i think it might be a good idea to try to release the latest stuff from
> j-t-c with 4.0.2 for a couple of reasons:
>
>   *) if we release and tag j-t-c along with jakarta-tomcat-4.0, i think
> it'll
>  be easier to do maintenance, fix bugs, etc..  i'm not only talking
> about
>  the java code in j-t-c, but also the c code.
>   *) there have been some bug fixes in j-t-c since 4.0.1 -- these may as
> well
>  be released :)
>
> thoughts?
>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

some mod_webapp changes

[Nick Wesselman]

hello all,

I don't know if this is really needed or appreciated, but for my own 
satisfaction I made some modifications to mod_webapp to make Tomcat only 
handle URIs mapped in web.xml, as the connector is intended to do. This 
way, Apache itself can serve all your static content. The hooks were 
pretty much all in there, I just needed to fiddle with things in a few 
places.

My work can be found here: http://www.you-phoria.com/mod_webapp/

It's hardly tested, but I figured I'd put it out there for people to 
bang on.

Enjoy,
HailHail


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: tomcat 4.0.2 and jakarta-tomcat-connectors

[Kevin Seguin]

> I think we should tag the code with jk_1_4 ( considering the 
> jk that was
> included with 3.1 == jk1.1, etc ). It seems jk_1_4 will work
> with 3.3, 4.0.x and 4.1 ( and the C code can be used for 3.2.x for bug
> fixes ).
> 

jk_1_4 is fine with me -- as long as it is tagged with something :)

> Regarding jk2, I'm still working, the current strugle is with the unix
> domain sockets ( since JFC commited the jk implementation, 
> and I promised
> I'll do the java side ). I did some more changes in mod_jk(2) 
> config, now
> seting "JkWebapp" in a Location context works for virtual 
> hosts and almost
> everything else. I do plan few more config changes - automatically
> restrict WEB-INF, etc, and I want to get at least basic info 
> out of the
> status worker. On the java side we have a first version, but 
> I still have
> to integrate it with either the interceptor/connector, or ( assuming
> everything works as it seems ) in JkServlet ( using what I 
> proposed last
> year, i.e. web.xml/'standard' servlets + 'trusted apps' + a 
> bit of magic).
> Sorry it takes so long, but I have a lot of other work to do...
> 

i was thinking that for tomcat 4.0.2, the old stuff, jk/native,
jk/java/org/apache/ajp, would be considered the 'stable' (althought still
beta quality) code, and the new jk2, o.a.jk would be considered still
'experimental'.  just a thought, though - i don't know that much about the
new code :)

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: some mod_webapp changes

[Martin van den Bemt]

Hi Nick,

I don't have anything in my web.xml, so I don't hope this is going to be the
default at some time (or should at least be configurable as it always was
with all the connectors).

Mvgr,
Martin


-Original Message-
From: Nick Wesselman [mailto:[EMAIL PROTECTED]]
Sent: Friday, January 04, 2002 17:50
To: [EMAIL PROTECTED]
Subject: some mod_webapp changes


hello all,

I don't know if this is really needed or appreciated, but for my own
satisfaction I made some modifications to mod_webapp to make Tomcat only
handle URIs mapped in web.xml, as the connector is intended to do. This
way, Apache itself can serve all your static content. The hooks were
pretty much all in there, I just needed to fiddle with things in a few
places.

My work can be found here: http://www.you-phoria.com/mod_webapp/

It's hardly tested, but I figured I'd put it out there for people to
bang on.

Enjoy,
HailHail


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: some mod_webapp changes

[Nick Wesselman]

by web.xml i mean the Tomcat servlet mappings you define in either your 
default web.xml or your app-specific one. so *.jsp, /servlet/*, etc

sorry for the confusion. and btw, i'm not an "official tomcat 
developer." just playing around.

Nick

Martin van den Bemt wrote:

>Hi Nick,
>
>I don't have anything in my web.xml, so I don't hope this is going to be the
>default at some time (or should at least be configurable as it always was
>with all the connectors).
>
>Mvgr,
>Martin
>
>
>-Original Message-
>From: Nick Wesselman [mailto:[EMAIL PROTECTED]]
>Sent: Friday, January 04, 2002 17:50
>To: [EMAIL PROTECTED]
>Subject: some mod_webapp changes
>
>
>hello all,
>
>I don't know if this is really needed or appreciated, but for my own
>satisfaction I made some modifications to mod_webapp to make Tomcat only
>handle URIs mapped in web.xml, as the connector is intended to do. This
>way, Apache itself can serve all your static content. The hooks were
>pretty much all in there, I just needed to fiddle with things in a few
>places.
>
>My work can be found here: http://www.you-phoria.com/mod_webapp/
>
>It's hardly tested, but I figured I'd put it out there for people to
>bang on.
>
>Enjoy,
>HailHail
>
>
>--
>To unsubscribe, e-mail:   
>For additional commands, e-mail: 
>
>
>
>--
>To unsubscribe, e-mail:   
>For additional commands, e-mail: 
>
>
>.
>




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5368] - StandardContextValve changes session state from new to old too late for other Valves

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5368

StandardContextValve changes session state from new to old too late for other Valves





--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 08:56 ---
Remy:

The fix that you checked in looks good to me.  We'll try it out and
let you know soon if the problem is fixed.

Thanks for getting this into 4.0.2 -- it's going to be a very nice
release!

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader WebappLoader.java

[remm]

remm02/01/04 09:09:09

  Modified:catalina/src/share/org/apache/catalina/loader
WebappLoader.java
  Log:
  - Make the notifier qn inner class, because of strange problems when using
JDK 1.4. The code is simpler that way, but I don't undestand the failure I got
(and why I don't get it with the inner class).
The stack trace was (against rev 1.21 of WebappLoader):
  WebappClassLoader:   Resource '/WEB-INF/classes/HelloWorldExample.class' was 
modified; Date is now: Fri Jan 04 17:48:04
  CET 2002 Was: Fri Jan 04 14:48:08 CET 2002
  java.lang.NoClassDefFoundError: org/apache/catalina/loader/WebappContextNotifier
  at 
org.apache.catalina.loader.WebappLoader.notifyContext(WebappLoader.java:792)
  at org.apache.catalina.loader.WebappLoader.run(WebappLoader.java:1286)
  at java.lang.Thread.run(Thread.java:539)
  
  Revision  ChangesPath
  1.22  +17 -36
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader/WebappLoader.java
  
  Index: WebappLoader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader/WebappLoader.java,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- WebappLoader.java 3 Jan 2002 16:31:06 -   1.21
  +++ WebappLoader.java 4 Jan 2002 17:09:08 -   1.22
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader/WebappLoader.java,v
 1.21 2002/01/03 16:31:06 remm Exp $
  - * $Revision: 1.21 $
  - * $Date: 2002/01/03 16:31:06 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader/WebappLoader.java,v
 1.22 2002/01/04 17:09:08 remm Exp $
  + * $Revision: 1.22 $
  + * $Date: 2002/01/04 17:09:08 $
*
* 
*
  @@ -115,7 +115,7 @@
*
* @author Craig R. McClanahan
* @author Remy Maucherat
  - * @version $Revision: 1.21 $ $Date: 2002/01/03 16:31:06 $
  + * @version $Revision: 1.22 $ $Date: 2002/01/04 17:09:08 $
*/
   
   public class WebappLoader
  @@ -788,8 +788,7 @@
*/
   private void notifyContext() {
   
  -WebappContextNotifier notifier =
  -new WebappContextNotifier((Context) container);
  +WebappContextNotifier notifier = new WebappContextNotifier();
   (new Thread(notifier)).start();
   
   }
  @@ -1294,47 +1293,29 @@
   }
   
   
  -}
  -
  -
  -//  Private Classes
  -
  -
  -/**
  - * Private thread class to notify our associated Context that we have
  - * recognized the need for a reload.
  - */
  -
  -final class WebappContextNotifier implements Runnable {
  +// -- WebappContextNotifier Inner Class
   
   
   /**
  - * The Context we will notify.
  + * Private thread class to notify our associated Context that we have
  + * recognized the need for a reload.
*/
  -private Context context = null;
  +protected class WebappContextNotifier implements Runnable {
   
   
  -/**
  - * Construct a new instance of this class.
  - *
  - * @param context The Context to be notified
  - */
  -public WebappContextNotifier(Context context) {
  +/**
  + * Perform the requested notification.
  + */
  +public void run() {
   
  -super();
  -this.context = context;
  -
  -}
  +((Context) container).reload();
   
  +}
   
  -/**
  - * Perform the requested notification.
  - */
  -public void run() {
  -
  -context.reload();
   
   }
   
   
   }
  +
  +
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: tomcat 4.0.2 and jakarta-tomcat-connectors

[costinm]

On Fri, 4 Jan 2002, Kevin Seguin wrote:

> i was thinking that for tomcat 4.0.2, the old stuff, jk/native,
> jk/java/org/apache/ajp, would be considered the 'stable' (althought still
> beta quality) code, and the new jk2, o.a.jk would be considered still
> 'experimental'.  just a thought, though - i don't know that much about the

That's what I was thinking too :-)

The new code is not ready, and even if it would be, it's important to get
the stable code tagged and released first.

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Fwd: Configuring Jaspers Compiler Options

[Mark Porter]

Hello All,

I posted this message to the 'user' list and didnt get much 'satisfaction'.
Can anyone here be of any help? Here is a copy of the exact error message:

Error: 500Location: /examples/jsp/num/numguess.jspInternal Servlet Error:
org.apache.jasper.JasperException: Unable to compile jsp->javac: invalid
flag: -encoding
use: jsp->javac [-g][-O][-debug][-depend][-nowarn][-verbose][-classpath
path][-nowrite][-d dir] file.java...

   at org.apache.tomcat.facade.JasperLiaison.javac(Unknown Source)
   at org.apache.tomcat.facade.JasperLiaison.processJspFile(Unknown
Source)
   at org.apache.tomcat.facade.JspInterceptor.requestMap(Unknown
Source)
   at org.apache.tomcat.core.ContextManager.processRequest(Unknown
Source)
   at org.apache.tomcat.core.ContextManager.internalService(Unknown
Source)
   at org.apache.tomcat.core.ContextManager.service(Unknown Source)
   at
org.apache.tomcat.modules.server.Http10Interceptor.processConnection(Unknown
Source)
   at org.apache.tomcat.util.net.TcpWorkerThread.runIt(Unknown Source)
   at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(Unknown
Source)
   at java.lang.Thread.run(Thread.java:484, Compiled Code)

Any help would be appreciated ... right now this problem is holding us back
from using Tomcat as out primary web container so I'd like to see this
resolved.

Thanks

Mark

 >From: <[EMAIL PROTECTED]>
>To: <[EMAIL PROTECTED]>
>Subject: Configuring Jaspers Compiler Options
>Date: Thu, 3 Jan 2002 21:15:53 -0500
>
>Hey Folks!
>
>Sorry if this is a repost ... sent it out earlier but still hasnt shown up 
>on the list.
>
>I'm setting up tomcat 3.2.3 on an Irix6.5 box (java sdk1.3.1) and am having 
>problems compiling any jsp code. Jasper fails with an Error 500 and the 
>requisite JSPException stack trace complaining that javac was passed in 
>invalid flag ( -encoding ). Is there any way to configure the options that 
>are passed to jasper? Why am I having this problem on Irix and not other 
>platforms in my shop (linux and HPUX). I'd appreciate any help if anyone 
>has seen this before!
>
>Thanks
>
>Mark
>
>



_
Send and receive Hotmail on your mobile device: http://mobile.msn.com


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: Configuring Jaspers Compiler Options

[Martin van den Bemt]

Using jikes compiler ? (read something about it not supporting -encoding
parameter anymore).

Mvgr,
Martin

-Original Message-
From: Mark Porter [mailto:[EMAIL PROTECTED]]
Sent: Friday, January 04, 2002 18:32
To: [EMAIL PROTECTED]
Subject: Fwd: Configuring Jaspers Compiler Options


Hello All,

I posted this message to the 'user' list and didnt get much 'satisfaction'.
Can anyone here be of any help? Here is a copy of the exact error message:

Error: 500Location: /examples/jsp/num/numguess.jspInternal Servlet Error:
org.apache.jasper.JasperException: Unable to compile jsp->javac: invalid
flag: -encoding
use: jsp->javac [-g][-O][-debug][-depend][-nowarn][-verbose][-classpath
path][-nowrite][-d dir] file.java...

   at org.apache.tomcat.facade.JasperLiaison.javac(Unknown Source)
   at org.apache.tomcat.facade.JasperLiaison.processJspFile(Unknown
Source)
   at org.apache.tomcat.facade.JspInterceptor.requestMap(Unknown
Source)
   at org.apache.tomcat.core.ContextManager.processRequest(Unknown
Source)
   at org.apache.tomcat.core.ContextManager.internalService(Unknown
Source)
   at org.apache.tomcat.core.ContextManager.service(Unknown Source)
   at
org.apache.tomcat.modules.server.Http10Interceptor.processConnection(Unknown
Source)
   at org.apache.tomcat.util.net.TcpWorkerThread.runIt(Unknown Source)
   at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(Unknown
Source)
   at java.lang.Thread.run(Thread.java:484, Compiled Code)

Any help would be appreciated ... right now this problem is holding us back
from using Tomcat as out primary web container so I'd like to see this
resolved.

Thanks

Mark

 >From: <[EMAIL PROTECTED]>
>To: <[EMAIL PROTECTED]>
>Subject: Configuring Jaspers Compiler Options
>Date: Thu, 3 Jan 2002 21:15:53 -0500
>
>Hey Folks!
>
>Sorry if this is a repost ... sent it out earlier but still hasnt shown up
>on the list.
>
>I'm setting up tomcat 3.2.3 on an Irix6.5 box (java sdk1.3.1) and am having
>problems compiling any jsp code. Jasper fails with an Error 500 and the
>requisite JSPException stack trace complaining that javac was passed in
>invalid flag ( -encoding ). Is there any way to configure the options that
>are passed to jasper? Why am I having this problem on Irix and not other
>platforms in my shop (linux and HPUX). I'd appreciate any help if anyone
>has seen this before!
>
>Thanks
>
>Mark
>
>



_
Send and receive Hotmail on your mobile device: http://mobile.msn.com


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: Configuring Jaspers Compiler Options

[Mark Porter]

No, unfortunatly thats not an option ...  besides, as of 1.15 jikes was 
still supporting the -encoding flag.

mdp

>From: "Martin van den Bemt" <[EMAIL PROTECTED]>
>Reply-To: "Tomcat Developers List" <[EMAIL PROTECTED]>
>To: "Tomcat Developers List" <[EMAIL PROTECTED]>
>Subject: RE: Configuring Jaspers Compiler Options
>Date: Fri, 4 Jan 2002 18:40:08 +0100
>
>Using jikes compiler ? (read something about it not supporting -encoding
>parameter anymore).
>
>Mvgr,
>Martin
>
>-Original Message-
>From: Mark Porter [mailto:[EMAIL PROTECTED]]
>Sent: Friday, January 04, 2002 18:32
>To: [EMAIL PROTECTED]
>Subject: Fwd: Configuring Jaspers Compiler Options
>
>
>Hello All,
>
>I posted this message to the 'user' list and didnt get much 'satisfaction'.
>Can anyone here be of any help? Here is a copy of the exact error message:
>
>Error: 500Location: /examples/jsp/num/numguess.jspInternal Servlet Error:
>org.apache.jasper.JasperException: Unable to compile jsp->javac: invalid
>flag: -encoding
>use: jsp->javac [-g][-O][-debug][-depend][-nowarn][-verbose][-classpath
>path][-nowrite][-d dir] file.java...
>
>   at org.apache.tomcat.facade.JasperLiaison.javac(Unknown Source)
>   at org.apache.tomcat.facade.JasperLiaison.processJspFile(Unknown
>Source)
>   at org.apache.tomcat.facade.JspInterceptor.requestMap(Unknown
>Source)
>   at org.apache.tomcat.core.ContextManager.processRequest(Unknown
>Source)
>   at org.apache.tomcat.core.ContextManager.internalService(Unknown
>Source)
>   at org.apache.tomcat.core.ContextManager.service(Unknown Source)
>   at
>org.apache.tomcat.modules.server.Http10Interceptor.processConnection(Unknown
>Source)
>   at org.apache.tomcat.util.net.TcpWorkerThread.runIt(Unknown Source)
>   at
>org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(Unknown
>Source)
>   at java.lang.Thread.run(Thread.java:484, Compiled Code)
>
>Any help would be appreciated ... right now this problem is holding us back
>from using Tomcat as out primary web container so I'd like to see this
>resolved.
>
>Thanks
>
>Mark
>
>  >From: <[EMAIL PROTECTED]>
> >To: <[EMAIL PROTECTED]>
> >Subject: Configuring Jaspers Compiler Options
> >Date: Thu, 3 Jan 2002 21:15:53 -0500
> >
> >Hey Folks!
> >
> >Sorry if this is a repost ... sent it out earlier but still hasnt shown 
>up
> >on the list.
> >
> >I'm setting up tomcat 3.2.3 on an Irix6.5 box (java sdk1.3.1) and am 
>having
> >problems compiling any jsp code. Jasper fails with an Error 500 and the
> >requisite JSPException stack trace complaining that javac was passed in
> >invalid flag ( -encoding ). Is there any way to configure the options 
>that
> >are passed to jasper? Why am I having this problem on Irix and not other
> >platforms in my shop (linux and HPUX). I'd appreciate any help if anyone
> >has seen this before!
> >
> >Thanks
> >
> >Mark
> >
> >
>
>
>
>_
>Send and receive Hotmail on your mobile device: http://mobile.msn.com
>
>
>--
>To unsubscribe, e-mail:   
>
>For additional commands, e-mail: 
>
>
>
>
>--
>To unsubscribe, e-mail:   
>
>For additional commands, e-mail: 
>
>



_
Join the world’s largest e-mail service with MSN Hotmail. 
http://www.hotmail.com


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5549] - Binary file upload through mod_webapp fails

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5549

Binary file upload through mod_webapp fails





--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 10:34 ---
The development source for mod_webapp is from the jakarta-tomcat-connectors
(j-t-c) CVS module (both the Java and C code lives there).  However, an older
version of the Java connector code also exists in the jakarta-tomcat-4.0
repository.  This older version is what ships with Tomcat 4.0.1.  Unless you
built Catalina from modified source, it's highly unlikely that you have patches
from j-t-c CVS (as they have not yet made it into Catalina CVS).

Please verify and mark this issue as a duplicate (again).

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5427] - File Uploads with MultipartRequest

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5427

File Uploads with MultipartRequest

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 10:35 ---


*** This bug has been marked as a duplicate of 3534 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 3534] - FileUpload doesn't work with Apache, mod_webapp and tomcat 4.0 RC1

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3534

FileUpload doesn't work with Apache, mod_webapp and tomcat 4.0 RC1

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 10:36 ---
*** Bug 5427 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Configuring Jaspers Compiler Options

[Bill Barker]

Tomcat 3.3 (which it seems is the version you are using) doesn't pass
the -encoding flag to Jikes (which is causing other headaches on the user
list :).

At the moment, there is no way to suppress the -encoding flag being passed
to javac.  The only work around at the moment is to use Jikes (or hack the
code).
- Original Message -
From: "Mark Porter" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, January 04, 2002 9:47 AM
Subject: RE: Configuring Jaspers Compiler Options


>
> No, unfortunatly thats not an option ...  besides, as of 1.15 jikes was
> still supporting the -encoding flag.
>
> mdp
>
> >From: "Martin van den Bemt" <[EMAIL PROTECTED]>
> >Reply-To: "Tomcat Developers List" <[EMAIL PROTECTED]>
> >To: "Tomcat Developers List" <[EMAIL PROTECTED]>
> >Subject: RE: Configuring Jaspers Compiler Options
> >Date: Fri, 4 Jan 2002 18:40:08 +0100
> >
> >Using jikes compiler ? (read something about it not supporting -encoding
> >parameter anymore).
> >
> >Mvgr,
> >Martin
> >
> >-Original Message-
> >From: Mark Porter [mailto:[EMAIL PROTECTED]]
> >Sent: Friday, January 04, 2002 18:32
> >To: [EMAIL PROTECTED]
> >Subject: Fwd: Configuring Jaspers Compiler Options
> >
> >
> >Hello All,
> >
> >I posted this message to the 'user' list and didnt get much
'satisfaction'.
> >Can anyone here be of any help? Here is a copy of the exact error
message:
> >
> >Error: 500Location: /examples/jsp/num/numguess.jspInternal Servlet Error:
> >org.apache.jasper.JasperException: Unable to compile jsp->javac: invalid
> >flag: -encoding
> >use: jsp->javac [-g][-O][-debug][-depend][-nowarn][-verbose][-classpath
> >path][-nowrite][-d dir] file.java...
> >
> > at org.apache.tomcat.facade.JasperLiaison.javac(Unknown Source)
> > at org.apache.tomcat.facade.JasperLiaison.processJspFile(Unknown
> >Source)
> > at org.apache.tomcat.facade.JspInterceptor.requestMap(Unknown
> >Source)
> > at org.apache.tomcat.core.ContextManager.processRequest(Unknown
> >Source)
> > at org.apache.tomcat.core.ContextManager.internalService(Unknown
> >Source)
> > at org.apache.tomcat.core.ContextManager.service(Unknown Source)
> > at
>
>org.apache.tomcat.modules.server.Http10Interceptor.processConnection(Unknow
n
> >Source)
> > at org.apache.tomcat.util.net.TcpWorkerThread.runIt(Unknown Source)
> > at
> >org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(Unknown
> >Source)
> > at java.lang.Thread.run(Thread.java:484, Compiled Code)
> >
> >Any help would be appreciated ... right now this problem is holding us
back
> >from using Tomcat as out primary web container so I'd like to see this
> >resolved.
> >
> >Thanks
> >
> >Mark
> >
> >  >From: <[EMAIL PROTECTED]>
> > >To: <[EMAIL PROTECTED]>
> > >Subject: Configuring Jaspers Compiler Options
> > >Date: Thu, 3 Jan 2002 21:15:53 -0500
> > >
> > >Hey Folks!
> > >
> > >Sorry if this is a repost ... sent it out earlier but still hasnt shown
> >up
> > >on the list.
> > >
> > >I'm setting up tomcat 3.2.3 on an Irix6.5 box (java sdk1.3.1) and am
> >having
> > >problems compiling any jsp code. Jasper fails with an Error 500 and the
> > >requisite JSPException stack trace complaining that javac was passed in
> > >invalid flag ( -encoding ). Is there any way to configure the options
> >that
> > >are passed to jasper? Why am I having this problem on Irix and not
other
> > >platforms in my shop (linux and HPUX). I'd appreciate any help if
anyone
> > >has seen this before!
> > >
> > >Thanks
> > >
> > >Mark
> > >
> > >
> >
> >
> >
> >_
> >Send and receive Hotmail on your mobile device: http://mobile.msn.com
> >
> >
> >--
> >To unsubscribe, e-mail:
> >
> >For additional commands, e-mail:
> >
> >
> >
> >
> >--
> >To unsubscribe, e-mail:
> >
> >For additional commands, e-mail:
> >
> >
>
>
>
> _
> Join the world’s largest e-mail service with MSN Hotmail.
> http://www.hotmail.com
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[Fwd: pages down]

[Ted Husted]

 Original Message 
Subject: pages down
Date: Fri, 04 Jan 2002 05:30:51 -0500
From: brian ally <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]

hi there,
i was just going over the app deployment docs and came to this page:
http://jakarta.apache.org/tomcat/tomcat-4.0-doc/appdev/sample/web/
the link for the JSP example returns the source, and the servlet returns 
not found.

regards,
/b

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Proposal for a new realm module for tomcat

[John Holman]

At 04:28 04/01/02, Tony Dahbura wrote:
>I would like to see about proposing the development of an additional realm
>module for tomcat.  I have begun some design on this and think it will 
>meet the
>needs of many folks out there utilizing LDAP.  I would like to propose a 
>native
>LDAP realm module that allows utlization of ldap features that may or may 
>not be
>possible through the JNDI layer.

As far as I can see, writing a "native LDAP realm module" - if by that you 
mean using the API provided by the Netscape directory SDK rather than Sun's 
JNDI API - would make little difference to the functionality possible. 
There may be performance benefits, though I have read conflicting reports 
on that.

>The items I am looking at designing into this module are:
>1-Connection pooling to support high performance access
>2-HA capabilities to support failover if a server goes away
>3-Authentication via the server rather than comparison of the passwords in
>digested forms (this option will also be supported)
>4-support for other realm group models (still checking into this).
>5-User location without DN identification (no need to be able to build the 
>DN to
>find the user)
>6-SSL support for communications

Some history ...

The current JNDIRealm implementation in Tomcat 4 is based on code I 
proposed back in April last year. I believe the existing implementation is 
sufficiently flexible to cover most ways of representing group information 
in the directory (item 4), and adding SSL support (item 6) should be 
trivial. However item 3 (authentication by binding to the directory as the 
user rather than by retrieving credentials and comparing them explicitly in 
the realm) and feature 5 (essentially, finding the user's DN by searching 
the directory on an arbitrary attribute) are not included. I think items 3 
and 5 are essential if the module is to be of much practical use.

In fact my original proposal did include much of the missing functionality 
(though not the performance and availability enhancements you mention). 
Craig made several significant improvements to the code before committing 
it, but also removed support for items 3 and 5. I subsequently proposed a 
patch restoring item 3, and planned to propose a second patch restoring 
item 5 if the first patch was accepted. Craig's response was that we should 
first get agreement on top-level goals, and proposed a functional 
specification for the JNDI Realm which is included in the Tomcat release 
documentation. This spec includes two "login modes" which cover item 3, but 
says little about the other items.

As far as I know there has been no discussion of the spec since then, and 
it still has proposed status. So perhaps the next step before enhancing the 
existing module would be for the group to reach agreement about the 
required features and produce a revised spec. I'm afraid I never got round 
to proposing changes to the spec myself but now the subject has come up 
again I will try to have a go at it. (I'll probably need to look at the 
format of the source document, which is in some dialect of xml).

However, I don't know what the position would be about a completely new module.

Cheers, John.



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Problem with JNDIRealm ...

[Shelly]

Tony,

I tried to use both connectionName="" and connectionPassword="" to
connect to LDAP, however the userPassword returns null (in this case, I
used enum as login attribute), authentication failed.

Regards,
Shelly

Tony Dahbura wrote:
> 
> Shelly:
> Let me help with number 3
> 
> The typical standard for anonymous binding is to specify a name and password of
> "" "" for both. I am not sure if JNDI will pass this ok-give it  a try.
> 
> 3. How to use an anonymous password for binding instead of using
> connectionName/connectionPassword?
> 
> Shelly wrote:
> 
> > Hello,
> >
> > I'm running Tomcat 4 on Unix and trying to use JNDIRealm for
> > authentication.
> > I use Netscape DAP server, and the hierarchy of entries in the directory
> > is
> >
> >  o=My Company
> > |
> > +---+---+
> > |   |   |
> > ou=People   ou=Groups  ...
> > |
> > +---+---+
> > |   |
> > ou=Employee...
> > |
> >   +-+-+
> >   | | |
> > enum=001 ... enum=111
> >
> > However, the login attribute is uid.
> >
> > When I do a search for a valid uid, it returns null.
> >
> > If I use DirContext.listBindings("") to get name-to-objects, no object
> > returns; (Please see code below).
> > If I use DirContext.listBindings("o=My Company") to get name-to-objects,
> > it returns (Name: ClassName: Object):
> > ou=Resources: com.sun.jndi.ldap.LdapCtx:
> > com.sun.jndi.ldap.LdapCtx@586fd3
> > ou=People: com.sun.jndi.ldap.LdapCtx: com.sun.jndi.ldap.LdapCtx@586jhk
> > ...
> >
> > Hash table en = new Hash table();
> > env.put(Context.INITIAL_CONTEXT_FACTORY, contextFactory);
> > if (connection Name != null)
> > env.put(Context.SECURITY_PRINCIPAL, connectionName);
> > if (connection Password != null)
> > env.put(Context.SECURITY_CREDENTIALS, connectionPassword);
> > if (connection URL != null)
> > env.put(Context.PROVIDER_URL, connectionURL);
> > context = new InitialDirContext(env);
> >
> > try {
> > // Get listing of context
> > Naming Enumeration bindings = context.listBindings("");
> > // Go through each item in list
> > while (bindings.hasMore()) {
> > Binding bd = (Binding)bindings.next();
> > log(bd.getName() + ": " + bd.getClassName() + ": " +
> > bd.getObject());
> > }
> > } catch (Naming Exception e) {
> > log("List Bindings failed: " + e);
> > }
> >
> > If I bind dn="", I got "HTTP Status 500 - Internal Server Error" message
> > when I access the secured page.
> >
> > I'm wondering if anyone knows the answers to any of the following
> > questions:
> >
> > 1. How to get a dn from uid when uid is not part of the dn?
> > 2. Does SHA digest been supported? When LDAP server use SHA digest for
> > userPassword, how do I encrypt SHA digest?
> > 3. How to use an anonymous password for binding instead of using
> > connectionName/connectionPassword?
> >
> > Thanks
> >
> > Shelly
> >
> > --
> > To unsubscribe, e-mail:   
> > For additional commands, e-mail: 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Problem with JNDIRealm ...

[Shelly]

Tony,

Thank you very much for your response. 

You mentioned that you are in the process of starting to code this JNDI
implementation, when you done, please let me know, as I'm interested in
trying to get JNDIRealm to work.

Does SHA digest will been supported in this implementation?


Thanks,
Shelly


Tony Dahbura wrote:
> 
> Shelly:
> I did not want to copy the whole list on your first question.  What you are
> trying to accomplish is a search to authenticate a user when the uid is not part
> of the dn.  I do not believe the JNDI implementation supports this now.
> 
> I am actually proposing to the group that we implement a full ldap realm module
> that does not run on top of JNDI but instead utilizes full ldap functionality to
> do things like you are trying to do.
> 
> I am in the process of starting to code this.  I will have a proposal out for
> the group in the next week.
> 
> Tony
> 
> Shelly wrote:
> 
> > Hello,
> >
> > I'm running Tomcat 4 on Unix and trying to use JNDIRealm for
> > authentication.
> > I use Netscape LDAP server, and the hierarchy of entries in the directory
> > is
> >
> >  o=My Company
> > |
> > +---+---+
> > |   |   |
> > ou=People   ou=Groups  ...
> > |
> > +---+---+
> > |   |
> > ou=Employee...
> > |
> >   +-+-+
> >   | | |
> > enum=001 ... enum=111
> >
> > However, the login attribute is uid.
> >
> > When I do a search for a valid uid, it returns null.
> >
> > If I use DirContext.listBindings("") to get name-to-objects, no object
> > returns; (Please see code below).
> > If I use DirContext.listBindings("o=My Company") to get name-to-objects,
> > it returns (Name: ClassName: Object):
> > ou=Resources: com.sun.jndi.ldap.LdapCtx:
> > com.sun.jndi.ldap.LdapCtx@586fd3
> > ou=People: com.sun.jndi.ldap.LdapCtx: com.sun.jndi.ldap.LdapCtx@586jhk
> > ...
> >
> > Hash table en = new Hash table();
> > env.put(Context.INITIAL_CONTEXT_FACTORY, contextFactory);
> > if (connection Name != null)
> > env.put(Context.SECURITY_PRINCIPAL, connectionName);
> > if (connection Password != null)
> > env.put(Context.SECURITY_CREDENTIALS, connectionPassword);
> > if (connection URL != null)
> > env.put(Context.PROVIDER_URL, connectionURL);
> > context = new InitialDirContext(env);
> >
> > try {
> > // Get listing of context
> > Naming Enumeration bindings = context.listBindings("");
> > // Go through each item in list
> > while (bindings.hasMore()) {
> > Binding bd = (Binding)bindings.next();
> > log(bd.getName() + ": " + bd.getClassName() + ": " +
> > bd.getObject());
> > }
> > } catch (Naming Exception e) {
> > log("List Bindings failed: " + e);
> > }
> >
> > If I bind dn="", I got "HTTP Status 500 - Internal Server Error" message
> > when I access the secured page.
> >
> > I'm wondering if anyone knows the answers to any of the following
> > questions:
> >
> > 1. How to get a dn from uid when uid is not part of the dn?
> > 2. Does SHA digest been supported? When DAP server use SHA digest for
> > userPassword, how do I encrypt SHA digest?
> > 3. How to use an anonymous password for binding instead of using
> > connectionName/connectionPassword?
> >
> > Thanks
> >
> > Shelly
> >
> > --
> > To unsubscribe, e-mail:   
> > For additional commands, e-mail: 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: tomcat 4.0.2 and jakarta-tomcat-connectors

[Daniel Rall]

Kevin Seguin <[EMAIL PROTECTED]> writes:

> there was a thread a couple weeks ago regarding what to do with j-t-c and
> tomcat 4.0.2.  i believe it was decided that the 4.0.2 release would contain
> the same jars from j-t-c (tomcat-ajp.jar, tomcat-util.jar) as 4.0.1 did.
>
> well, i just did some quick tests with the 4.0.2-b1 dist and the head of
> j-t-c, and all seemed to be in working order.
>
> so, i think it might be a good idea to try to release the latest stuff from
> j-t-c with 4.0.2 for a couple of reasons:
>
>   *) if we release and tag j-t-c along with jakarta-tomcat-4.0, i think
> it'll 
>  be easier to do maintenance, fix bugs, etc..  i'm not only talking
> about
>  the java code in j-t-c, but also the c code.
>   *) there have been some bug fixes in j-t-c since 4.0.1 -- these may as
> well
>  be released :)

The mod_webapp connector code is definitely in a freshening.  :)

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5368] - StandardContextValve changes session state from new to old too late for other Valves

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5368

StandardContextValve changes session state from new to old too late for other Valves

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 12:35 ---
Before your change, I wasn't aware of another method of getting operations added
to the beginning of Catalina's processing flow.  Calling the Session.access() in
the StandardHostValve right after the context is mapped satisfies this requirement.

I've re-built from today's source and verified this fix with my Valve
implementations.  Thanks Remy!

- Dan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: tomcat 4.0.2 and jakarta-tomcat-connectors

[Daniel Rall]

Daniel Rall <[EMAIL PROTECTED]> writes:

> The mod_webapp connector code is definitely in a freshening.  :)
^
 need of

Specifically, it would be great to get in Pier's fix to the file
upload problem (if not the rest of the changes as well).

Index: catalina/src/share/org/apache/catalina/connector/warp/WarpRequest.java 
=== 
RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/java/WarpRequest.java,v 
retrieving revision 1.9 
retrieving revision 1.10 
diff -u -r1.9 -r1.10 
--- catalina/src/share/org/apache/catalina/connector/warp/WarpRequest.java  2001/07/25 
22:32:05 1.9 
+++ catalina/src/share/org/apache/catalina/connector/warp/WarpRequest.java  2001/10/19 
+19:18:28 1.10 
@@ -139,7 +139,7 @@ 
 throw new IOException("Invalid WARP packet type for body"); 

 if (this.packet.pointermailto:[EMAIL PROTECTED]>
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler JspReader.java

[kinman]

kinman  02/01/04 13:29:52

  Modified:jasper/src/share/org/apache/jasper/compiler JspReader.java
  Log:
  - Removal of '\n' at eof is a spec no-no.
  
  Revision  ChangesPath
  1.8   +1 -7  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspReader.java
  
  Index: JspReader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspReader.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- JspReader.java12 Dec 2001 01:19:35 -  1.7
  +++ JspReader.java4 Jan 2002 21:29:52 -   1.8
  @@ -332,13 +332,7 @@
   */
   
   public boolean hasMoreInput() throws ParseException {
  - // An extra '\n' seems to be inserted when there is none at end of
  - // a file.  Not only is this useless, but it causes problems when
  - // none is expected (e.g. after response.sendRedirect() ).
  -
  - if (current.cursor >= current.stream.length ||
  - ((current.cursor == current.stream.length - 1) &&
  - (peekChar() == '\n'))) {
  + if (current.cursor >= current.stream.length) {
   if (singleFile) return false; 
while (popFile()) {
if (current.cursor < current.stream.length) return true;
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler JspReader.java

[kinman]

kinman  02/01/04 13:32:13

  Modified:jasper/src/share/org/apache/jasper/compiler Tag:
tomcat_40_branch JspReader.java
  Log:
  - Removal of '\n' at eof is a spec no-no.
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.6.2.2   +1 -8  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspReader.java
  
  Index: JspReader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspReader.java,v
  retrieving revision 1.6.2.1
  retrieving revision 1.6.2.2
  diff -u -r1.6.2.1 -r1.6.2.2
  --- JspReader.java12 Dec 2001 01:28:39 -  1.6.2.1
  +++ JspReader.java4 Jan 2002 21:32:13 -   1.6.2.2
  @@ -332,14 +332,7 @@
   */
   
   public boolean hasMoreInput() throws ParseException {
  -// An extra '\n' seems to be inserted when there is none at end of
  -// a file.  Not only is this useless, but it causes problems when
  -// none is expected (e.g. after response.sendRedirect() ).
  -
  -if (current.cursor >= current.stream.length ||
  -((current.cursor == current.stream.length - 1) &&
  -(peekChar() == '\n'))) {
  -
  +if (current.cursor >= current.stream.length) {
   if (singleFile) return false; 
while (popFile()) {
if (current.cursor < current.stream.length) return true;
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Proposal for a new realm module for tomcat

[Tony Dahbura]

John:
There are other issues with the JNDI implementation that we have run into with some
commercial high end load balancers.  It has to do with connection re-authentication
and sessions getting dropped on non used connections. I did some work on the actual
API for the Netscape LDAP implementation and we puti n handling of this situation
as well. It really from a programmer perspective looks the same but handles a lot
of low level details with regards to server connections that work better in a many
HA settings.

I would love to work with you on the proposal for this. As I have indicated I
started a wish list of things to code in this realm module you hit many of the
points of what I was looking at doing.  I agree for many folks the JNDI
implementation can suit much of their needs, I have just run across some folks that
wanted better support for more diverse network environments.

Let's flesh this out and see what comes from it.

Tony


John Holman wrote:

> At 04:28 04/01/02, Tony Dahbura wrote:
> >I would like to see about proposing the development of an additional realm
> >module for tomcat.  I have begun some design on this and think it will
> >meet the
> >needs of many folks out there utilizing LDAP.  I would like to propose a
> >native
> >LDAP realm module that allows utlization of ldap features that may or may
> >not be
> >possible through the JNDI layer.
>
> As far as I can see, writing a "native LDAP realm module" - if by that you
> mean using the API provided by the Netscape directory SDK rather than Sun's
> JNDI API - would make little difference to the functionality possible.
> There may be performance benefits, though I have read conflicting reports
> on that.
>
> >The items I am looking at designing into this module are:
> >1-Connection pooling to support high performance access
> >2-HA capabilities to support failover if a server goes away
> >3-Authentication via the server rather than comparison of the passwords in
> >digested forms (this option will also be supported)
> >4-support for other realm group models (still checking into this).
> >5-User location without DN identification (no need to be able to build the
> >DN to
> >find the user)
> >6-SSL support for communications
>
> Some history ...
>
> The current JNDIRealm implementation in Tomcat 4 is based on code I
> proposed back in April last year. I believe the existing implementation is
> sufficiently flexible to cover most ways of representing group information
> in the directory (item 4), and adding SSL support (item 6) should be
> trivial. However item 3 (authentication by binding to the directory as the
> user rather than by retrieving credentials and comparing them explicitly in
> the realm) and feature 5 (essentially, finding the user's DN by searching
> the directory on an arbitrary attribute) are not included. I think items 3
> and 5 are essential if the module is to be of much practical use.
>
> In fact my original proposal did include much of the missing functionality
> (though not the performance and availability enhancements you mention).
> Craig made several significant improvements to the code before committing
> it, but also removed support for items 3 and 5. I subsequently proposed a
> patch restoring item 3, and planned to propose a second patch restoring
> item 5 if the first patch was accepted. Craig's response was that we should
> first get agreement on top-level goals, and proposed a functional
> specification for the JNDI Realm which is included in the Tomcat release
> documentation. This spec includes two "login modes" which cover item 3, but
> says little about the other items.
>
> As far as I know there has been no discussion of the spec since then, and
> it still has proposed status. So perhaps the next step before enhancing the
> existing module would be for the group to reach agreement about the
> required features and produce a revised spec. I'm afraid I never got round
> to proposing changes to the spec myself but now the subject has come up
> again I will try to have a go at it. (I'll probably need to look at the
> format of the source document, which is in some dialect of xml).
>
> However, I don't know what the position would be about a completely new module.
>
> Cheers, John.
>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardContextValve.java StandardHostValve.java

[Daniel Rall]

Remy, I built today's HEAD and verified your fix (much cleaner than
what was previously proposed).

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5368

Please backport this bug fix to the 4.0.x branch.

 Thanks, Dan

[EMAIL PROTECTED] writes:

> remm02/01/04 08:33:40
>
>   Modified:catalina/src/share/org/apache/catalina/core
> StandardContextValve.java StandardHostValve.java
>   Log:
>   - Fix for 5368: mark the session as accessed before going in the Context
> pipeline (before, the session was marked as non-new only in the last useable
> valve of the pipeline). This is not the proposed patch for this bug. Please 
>confirm
> it does fix the problem.
>   
>   Revision  ChangesPath
>   1.15  +6 -17 
>jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java
>   
>   Index: StandardContextValve.java
>   ===
>   RCS file: 
>/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
>   retrieving revision 1.14
>   retrieving revision 1.15
>   diff -u -r1.14 -r1.15
>   --- StandardContextValve.java   5 Oct 2001 22:03:53 -   1.14
>   +++ StandardContextValve.java   4 Jan 2002 16:33:40 -   1.15
>   @@ -1,7 +1,7 @@
>/*
>   - * $Header: 
>/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
> 1.14 2001/10/05 22:03:53 remm Exp $
>   - * $Revision: 1.14 $
>   - * $Date: 2001/10/05 22:03:53 $
>   + * $Header: 
>/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
> 1.15 2002/01/04 16:33:40 remm Exp $
>   + * $Revision: 1.15 $
>   + * $Date: 2002/01/04 16:33:40 $
> *
> * 
> *
>   @@ -74,10 +74,9 @@
>import org.apache.naming.ContextBindings;
>import org.apache.naming.resources.DirContextURLStreamHandler;
>import org.apache.catalina.Container;
>   -import org.apache.catalina.Manager;
>   +import org.apache.catalina.Context;
>import org.apache.catalina.Request;
>import org.apache.catalina.Response;
>   -import org.apache.catalina.Session;
>import org.apache.catalina.ValveContext;
>import org.apache.catalina.Wrapper;
>import org.apache.catalina.util.RequestUtil;
>   @@ -93,7 +92,7 @@
> * when processing HTTP requests.
> *
> * @author Craig R. McClanahan
>   - * @version $Revision: 1.14 $ $Date: 2001/10/05 22:03:53 $
>   + * @version $Revision: 1.15 $ $Date: 2002/01/04 16:33:40 $
> */
>
>final class StandardContextValve
>   @@ -169,17 +168,7 @@
>return;
>}
>
>   -// Update the session last access time for our session (if any)
>   -StandardContext context = (StandardContext) getContainer();
>   -String sessionId = hreq.getRequestedSessionId();
>   -if (sessionId != null) {
>   -Manager manager = context.getManager();
>   -if (manager != null) {
>   -Session session = manager.findSession(sessionId);
>   -if ((session != null) && session.isValid())
>   -session.access();
>   -}
>   -}
>   +Context context = (Context) getContainer();
>
>// Select the Wrapper to be used for this Request
>Wrapper wrapper = null;
>   
>   
>   
>   1.6   +21 -5 
>jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java
>   
>   Index: StandardHostValve.java
>   ===
>   RCS file: 
>/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
>   retrieving revision 1.5
>   retrieving revision 1.6
>   diff -u -r1.5 -r1.6
>   --- StandardHostValve.java  22 Jul 2001 20:25:08 -  1.5
>   +++ StandardHostValve.java  4 Jan 2002 16:33:40 -   1.6
>   @@ -1,7 +1,7 @@
>/*
>   - * $Header: 
>/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
> 1.5 2001/07/22 20:25:08 pier Exp $
>   - * $Revision: 1.5 $
>   - * $Date: 2001/07/22 20:25:08 $
>   + * $Header: 
>/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
> 1.6 2002/01/04 16:33:40 remm Exp $
>   + * $Revision: 1.6 $
>   + * $Date: 2002/01/04 16:33:40 $
> *
> * 
> *
>   @@ -71,8 +71,10 @@
>import javax.servlet.http.HttpServletResponse;
>import org.apache.catalina.Container;
>import org.apache.catalina.Context;
>   +import org.apache.catalina.Manager;
>import org.apache.catalina.Request;
>import org.apache.catalina.Response;
>   +import org.apache.catalina.Session;
>import org.apache.cata

Re: tomcat 4.0.2 and jakarta-tomcat-connectors

[Remy Maucherat]

> +1
>
> I think we should tag the code with jk_1_4 ( considering the jk that was
> included with 3.1 == jk1.1, etc ). It seems jk_1_4 will work
> with 3.3, 4.0.x and 4.1 ( and the C code can be used for 3.2.x for bug
> fixes ).

+1.
When it's done and when you can confirm it's working, I think we can release
4.0.2 b2 (I have only a few patches to commit to the branch and it should be
ok).

Could we do the same for webapp ?

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardContextMapper.java

[remm]

remm02/01/04 15:14:53

  Modified:catalina/src/share/org/apache/catalina/core Tag:
tomcat_40_branch StandardContextMapper.java
  Log:
  - Port patch.
  - '/' is now handled as a special case, since otherwise it is exactly matched to
the default servlet, even if a '/*' mapping is defined.
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.6.2.1   +6 -5  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextMapper.java
  
  Index: StandardContextMapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextMapper.java,v
  retrieving revision 1.6
  retrieving revision 1.6.2.1
  diff -u -r1.6 -r1.6.2.1
  --- StandardContextMapper.java22 Jul 2001 20:25:08 -  1.6
  +++ StandardContextMapper.java4 Jan 2002 23:14:53 -   1.6.2.1
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextMapper.java,v
 1.6 2001/07/22 20:25:08 pier Exp $
  - * $Revision: 1.6 $
  - * $Date: 2001/07/22 20:25:08 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextMapper.java,v
 1.6.2.1 2002/01/04 23:14:53 remm Exp $
  + * $Revision: 1.6.2.1 $
  + * $Date: 2002/01/04 23:14:53 $
*
* 
*
  @@ -85,7 +85,7 @@
* StandardContext, because it relies on internal APIs.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.6 $ $Date: 2001/07/22 20:25:08 $
  + * @version $Revision: 1.6.2.1 $ $Date: 2002/01/04 23:14:53 $
*/
   
   public final class StandardContextMapper
  @@ -224,7 +224,8 @@
   if (wrapper == null) {
   if (debug >= 2)
   context.log("  Trying exact match");
  -name = context.findServletMapping(relativeURI);
  +if (!(relativeURI.equals("/")))
  +name = context.findServletMapping(relativeURI);
   if (name != null)
   wrapper = (Wrapper) context.findChild(name);
   if (wrapper != null) {
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardContextValve.java StandardHostValve.java

[remm]

remm02/01/04 15:19:00

  Modified:catalina/src/share/org/apache/catalina/core Tag:
tomcat_40_branch StandardContextValve.java
StandardHostValve.java
  Log:
  - Port patch.
- Fix for 5368: mark the session as accessed before going in the Context
  pipeline (before, the session was marked as non-new only in the last useable
  valve of the pipeline).
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.12.2.3  +6 -17 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java
  
  Index: StandardContextValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
  retrieving revision 1.12.2.2
  retrieving revision 1.12.2.3
  diff -u -r1.12.2.2 -r1.12.2.3
  --- StandardContextValve.java 5 Oct 2001 22:01:44 -   1.12.2.2
  +++ StandardContextValve.java 4 Jan 2002 23:19:00 -   1.12.2.3
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
 1.12.2.2 2001/10/05 22:01:44 remm Exp $
  - * $Revision: 1.12.2.2 $
  - * $Date: 2001/10/05 22:01:44 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
 1.12.2.3 2002/01/04 23:19:00 remm Exp $
  + * $Revision: 1.12.2.3 $
  + * $Date: 2002/01/04 23:19:00 $
*
* 
*
  @@ -74,10 +74,9 @@
   import org.apache.naming.ContextBindings;
   import org.apache.naming.resources.DirContextURLStreamHandler;
   import org.apache.catalina.Container;
  -import org.apache.catalina.Manager;
  +import org.apache.catalina.Context;
   import org.apache.catalina.Request;
   import org.apache.catalina.Response;
  -import org.apache.catalina.Session;
   import org.apache.catalina.ValveContext;
   import org.apache.catalina.Wrapper;
   import org.apache.catalina.util.RequestUtil;
  @@ -93,7 +92,7 @@
* when processing HTTP requests.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.12.2.2 $ $Date: 2001/10/05 22:01:44 $
  + * @version $Revision: 1.12.2.3 $ $Date: 2002/01/04 23:19:00 $
*/
   
   final class StandardContextValve
  @@ -169,17 +168,7 @@
   return;
   }
   
  -// Update the session last access time for our session (if any)
  -StandardContext context = (StandardContext) getContainer();
  -String sessionId = hreq.getRequestedSessionId();
  -if (sessionId != null) {
  -Manager manager = context.getManager();
  -if (manager != null) {
  -Session session = manager.findSession(sessionId);
  -if ((session != null) && session.isValid())
  -session.access();
  -}
  -}
  +Context context = (Context) getContainer();
   
   // Select the Wrapper to be used for this Request
   Wrapper wrapper = null;
  
  
  
  1.5.2.1   +21 -5 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java
  
  Index: StandardHostValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
  retrieving revision 1.5
  retrieving revision 1.5.2.1
  diff -u -r1.5 -r1.5.2.1
  --- StandardHostValve.java22 Jul 2001 20:25:08 -  1.5
  +++ StandardHostValve.java4 Jan 2002 23:19:00 -   1.5.2.1
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
 1.5 2001/07/22 20:25:08 pier Exp $
  - * $Revision: 1.5 $
  - * $Date: 2001/07/22 20:25:08 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
 1.5.2.1 2002/01/04 23:19:00 remm Exp $
  + * $Revision: 1.5.2.1 $
  + * $Date: 2002/01/04 23:19:00 $
*
* 
*
  @@ -71,8 +71,10 @@
   import javax.servlet.http.HttpServletResponse;
   import org.apache.catalina.Container;
   import org.apache.catalina.Context;
  +import org.apache.catalina.Manager;
   import org.apache.catalina.Request;
   import org.apache.catalina.Response;
  +import org.apache.catalina.Session;
   import org.apache.catalina.ValveContext;
   import org.apache.catalina.util.StringManager;
   import org.apache.catalina.valves.ValveBase;
  @@ -86,7 +88,7 @@
* when processing HTTP requests.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.5 $ $Date: 2001/07/22 20:25:08 $
  + * @version $Revision: 1.5.2.1 $ $Date: 2002/01/04 23:19:00 $
*/
   
   final class StandardHostValve

RE: tomcat 4.0.2 and jakarta-tomcat-connectors

[Kevin Seguin]

>
> > I think we should tag the code with jk_1_4 ( considering 
> the jk that was
> > included with 3.1 == jk1.1, etc ). It seems jk_1_4 will work
> > with 3.3, 4.0.x and 4.1 ( and the C code can be used for 
> 3.2.x for bug
> > fixes ).
> 
> +1.
> When it's done and when you can confirm it's working, I think 
> we can release
> 4.0.2 b2 (I have only a few patches to commit to the branch 
> and it should be
> ok).
> 

i believe the jk (not jk2) code, both native (jk/native) and java
(jk/java/org/apache/ajp), in j-t-c to be working and in a stable state.

> Could we do the same for webapp ?
> 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets LocalStrings.properties ManagerServlet.java

[craigmcc]

craigmcc02/01/04 16:15:36

  Modified:catalina/src/share/org/apache/catalina/servlets
LocalStrings.properties ManagerServlet.java
  Log:
  Update the manager servlet to support the (new-to-4.1-dev) option to
  deploy a context configuration file -- an XML file containing just the
   element and its nested elements from server.xml.  An example
  URL to install such an app would be:
  
http://localhost:8080/manager/install?config=file:///path/to/myconfig.xml
  
  Revision  ChangesPath
  1.10  +1 -0  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/LocalStrings.properties,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- LocalStrings.properties   15 Sep 2001 23:31:30 -  1.9
  +++ LocalStrings.properties   5 Jan 2002 00:15:36 -   1.10
  @@ -10,6 +10,7 @@
   invokerServlet.noWrapper=Container has not called setWrapper() for this servlet
   managerServlet.alreadyContext=FAIL - Application already exists at path {0}
   managerServlet.cannotInvoke=Cannot invoke manager servlet through invoker
  +managerServlet.configured=OK - Installed application from context file {0}
   managerServlet.exception=FAIL - Encountered exception {0}
   managerServlet.installed=OK - Installed application at context path {0}
   managerServlet.invalidPath=FAIL - Invalid context path {0} was specified
  
  
  
  1.11  +88 -32
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/ManagerServlet.java
  
  Index: ManagerServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/ManagerServlet.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- ManagerServlet.java   25 Oct 2001 00:23:03 -  1.10
  +++ ManagerServlet.java   5 Jan 2002 00:15:36 -   1.11
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/ManagerServlet.java,v
 1.10 2001/10/25 00:23:03 craigmcc Exp $
  - * $Revision: 1.10 $
  - * $Date: 2001/10/25 00:23:03 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/ManagerServlet.java,v
 1.11 2002/01/05 00:15:36 craigmcc Exp $
  + * $Revision: 1.11 $
  + * $Date: 2002/01/05 00:15:36 $
*
* 
*
  @@ -95,6 +95,16 @@
* The following actions and parameters (starting after the servlet path)
* are supported:
* 
  + * /install?config={config-url} - Install and start a new
  + * web application, based on the contents of the context configuration
  + * file found at the specified URL.  The docBase attribute
  + * of the context configuration file is used to locate the actual
  + * WAR or directory containing the application.
  + * /install?config={config-url}&war={war-url}/ - Install and start
  + * a new web application, based on the contents of the context
  + * configuration file found at {config-url}, overriding the
  + * docBase attribute with the contents of the web
  + * application archive found at {war-url}.
* /install?path=/xxx&war={war-url} - Install and start a new
* web application attached to context path /xxx, based
* on the contents of the web application archive found at the
  @@ -153,7 +163,7 @@
* 
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.10 $ $Date: 2001/10/25 00:23:03 $
  + * @version $Revision: 1.11 $ $Date: 2002/01/05 00:15:36 $
*/
   
   public class ManagerServlet
  @@ -263,6 +273,7 @@
   String command = request.getPathInfo();
   if (command == null)
   command = request.getServletPath();
  +String config = request.getParameter("config");
   String path = request.getParameter("path");
   String war = request.getParameter("war");
   
  @@ -274,7 +285,7 @@
   if (command == null) {
   writer.println(sm.getString("managerServlet.noCommand"));
   } else if (command.equals("/install")) {
  -install(writer, path, war);
  +install(writer, config, path, war);
   } else if (command.equals("/list")) {
   list(writer);
   } else if (command.equals("/reload")) {
  @@ -345,41 +356,86 @@
* web application archive.
*
* @param writer Writer to render results to
  + * @param config URL of the context configuration file to be installed
* @param path Context path of the application to be installed
* @param war URL of the web application archive to be installed
  

DO NOT REPLY [Bug 5220] - Problem with mod_webapp.so getting confused with tomcat restart

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5220

Problem with mod_webapp.so getting confused with tomcat restart





--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 16:34 ---
This also causes problems if, in general, apache is started before tomcat.
This makes webapp 
very cumbersome to use, especially on a production server
that can reboot unattended.  This 
needs to be fixed-- webapp should be able
to seamlessly handle both tomcat restarts and out-of-
order starts by auto-
deploying undeployed applications when they become available and 
reconnecting
if connections are dropped for any reason.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5220] - Problem with mod_webapp.so getting confused with tomcat restart

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5220

Problem with mod_webapp.so getting confused with tomcat restart

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Enhancement |Major

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[FAQ] jGuru FAQ Update

[Alex Chaffee]

jGuru maintains FAQs and Forums on Servlets, JSP, and Tomcat (as well as
many other Java topics).  Here is an automated update on recent postings to
Tomcat-related FAQs.  Please direct flames and feedback to [EMAIL PROTECTED] .

 - Alex


++ JavaServer Pages (JSP) FAQ: http://www.jguru.com/faq/JSP

Can I have Perl syntax regular expressions within my JSP pages?
http://www.jguru.com/misc/faqtrampoline.jsp?src=notify&EID=705125

Can I make use of scripting languages like Tcl, Perl, Python, Rexx, etc. within my JSP 
pages?
http://www.jguru.com/misc/faqtrampoline.jsp?src=notify&EID=705120

Is it true that servlet containers service each request by creating a new thread? If 
that is true, how does a container handle a sudden dramatic surge  in incoming 
requests without significant performance degradation?
http://www.jguru.com/misc/faqtrampoline.jsp?src=notify&EID=705119

Where can I find a JSP tag library for sending mail from JSP pages via the JavaMail 
API?
http://www.jguru.com/misc/faqtrampoline.jsp?src=notify&EID=705110

++ Tomcat FAQ: http://www.jguru.com/faq/Tomcat

Where should I copy the class file of applet in Tomcat? Where should I copy respective 
HTML file?
http://www.jguru.com/misc/faqtrampoline.jsp?src=notify&EID=705530


You can shut email notification off at the FAQ home
page(s) or:

  http://www.jguru.com/guru/notifyprefs.jsp



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4330] - ClassCastException with DocumentBuilderFactoryImpl

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4330

ClassCastException with DocumentBuilderFactoryImpl

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 18:26 ---
I routinely use j2sdk1.4.0 with tomcat and never run into this problem.  I am
closing this as WORKSFORME.  If you can attach a test case in the form of a .war
that I can drop into tomcat that shows this problem, please reopen this bug
again.  Thanks.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/depend DependClassLoader.java

[billbarker]

billbarker02/01/04 18:44:58

  Modified:src/share/org/apache/tomcat/util/depend
DependClassLoader.java
  Log:
  Add missing close statement on InputStream.
  
  Hopefully this will partially fix bug #5684 part 1.
  
  Reported by: Mike [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.15  +1 -0  
jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader.java
  
  Index: DependClassLoader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- DependClassLoader.java21 Oct 2001 15:47:27 -  1.14
  +++ DependClassLoader.java5 Jan 2002 02:44:58 -   1.15
  @@ -199,6 +199,7 @@
try {
data=readFully( is );
if( data.length==0 ) data=null;
  + is.close();
} catch(IOException ex ) {
if( debug > 0 ) ex.printStackTrace();
data=null;
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5684] - WEB-INF/lib jar file loading and operations problems.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5684

WEB-INF/lib jar file loading and operations problems.





--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 18:50 ---
There was a missing close statement in the app-ClassLoader.  I've added it in, 
so that the jar file shouldn't stay open.  This may fix part 1 (since 3.3 
typically does GC much less often then 3.2).

It is possible (if very unlikely) that being able to delete the jar file may 
help with 2.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat/src/native/mod_jk/iis jk_isapi_plugin.c

[larryi]

larryi  02/01/04 20:25:20

  Modified:src/native/mod_jk/iis jk_isapi_plugin.c
  Log:
  In HttpFilterProc, the '?' is searched for in an escaped URI.  In
  init_ws_service as part of HttpExtensionProc, the '?' is searched for
  in a URI that has been unescaped.  This isn't guaranteed to find the
  same '?'.  To avoid this, save the query string in it's own "tomcat"
  header and use that in init_ws_service instead of searching again.
  
  Added some logging if the worker and worker mount files are not found.
  
  Fix some tabs and a typo.
  
  Revision  ChangesPath
  1.11  +22 -29jakarta-tomcat/src/native/mod_jk/iis/jk_isapi_plugin.c
  
  Index: jk_isapi_plugin.c
  ===
  RCS file: /home/cvs/jakarta-tomcat/src/native/mod_jk/iis/jk_isapi_plugin.c,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- jk_isapi_plugin.c 8 Dec 2001 15:40:59 -   1.10
  +++ jk_isapi_plugin.c 5 Jan 2002 04:25:20 -   1.11
  @@ -57,7 +57,7 @@
* Description: ISAPI plugin for IIS/PWS   *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Author:  Ignacio J. Ortega <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.10 $   *
  + * Version: $Revision: 1.11 $   *
***/
   
   // This define is needed to include wincrypt,h, needed to get client certificates
  @@ -87,10 +87,12 @@
*
*/
   #define URI_HEADER_NAME ("TOMCATURI:")
  +#define QUERY_HEADER_NAME   ("TOMCATQUERY:")
   #define WORKER_HEADER_NAME  ("TOMCATWORKER:")
   #define CONTENT_LENGTH  ("CONTENT_LENGTH:")
   
   #define HTTP_URI_HEADER_NAME ("HTTP_TOMCATURI")
  +#define HTTP_QUERY_HEADER_NAME   ("HTTP_TOMCATQUERY")
   #define HTTP_WORKER_HEADER_NAME  ("HTTP_TOMCATWORKER")
   
   #define REGISTRY_LOCATION   ("Software\\Apache Software Foundation\\Jakarta 
Isapi Redirector\\1.0")
  @@ -545,8 +547,8 @@
  (SF_NOTIFY_PREPROC_HEADERS == dwNotificationType)) { 
   PHTTP_FILTER_PREPROC_HEADERS p = 
(PHTTP_FILTER_PREPROC_HEADERS)pvNotification;
   char uri[INTERNET_MAX_URL_LENGTH];
  - char snuri[INTERNET_MAX_URL_LENGTH]="/";
  - char Host[INTERNET_MAX_URL_LENGTH];
  +char snuri[INTERNET_MAX_URL_LENGTH]="/";
  +char Host[INTERNET_MAX_URL_LENGTH];
   
   char *query;
   DWORD sz = sizeof(uri);
  @@ -559,7 +561,8 @@
* Just in case somebody set these headers in the request!
*/
   p->SetHeader(pfc, URI_HEADER_NAME, NULL);
  - p->SetHeader(pfc, WORKER_HEADER_NAME, NULL);
  +p->SetHeader(pfc, QUERY_HEADER_NAME, NULL);
  +p->SetHeader(pfc, WORKER_HEADER_NAME, NULL);
   
   if(!p->GetHeader(pfc, "url", (LPVOID)uri, (LPDWORD)&sz)) {
   jk_log(logger, JK_LOG_ERROR, 
  @@ -572,13 +575,13 @@
   char *worker=0;
   query = strchr(uri, '?');
   if(query) {
  -*query = '\0';
  +*query++ = '\0';
   }
   
   rc = unescape_url(uri);
   if (rc == BAD_REQUEST) {
   jk_log(logger, JK_LOG_ERROR, 
  -   "HttpFilterProc [%s] contains on or more invalid escape 
sequences.\n", 
  +   "HttpFilterProc [%s] contains one or more invalid escape 
sequences.\n", 
  uri);
   write_error_response(pfc,"400 Bad Request",
   "Request contains invalid 
encoding");
  @@ -608,17 +611,6 @@
  uri);
   worker = map_uri_to_worker(uw_map, uri, logger);
   }
  -if(query) {
  -char *querytmp = uri + strlen(uri);
  -*querytmp++ = '?';
  -query++;
  -/* if uri was shortened, move the query characters */
  -if (querytmp != query) {
  -while (*query != '\0')
  -*querytmp++ = *query++;
  -*querytmp = '\0';
  -}
  -}
   
   if(worker) {
   /* This is a servlet, should redirect ... */
  @@ -627,7 +619,9 @@
  uri, worker);
   
   
  - if(!p->AddHeader(pfc, URI_HEADER_NAME, uri) || 
  +if(!p->AddHeader(pfc, URI_HEADER_NAME, uri) || 
  +   ( (query != NULL && strlen(query) > 0)
  +   ? !p->AddHeader(pfc, QUERY_HEADER_NAME, query) : FALSE ) 
|| 
  !p->AddHeader(pfc, WORKER_HEADER_NAME, worker) ||
  !p->SetHeader(pfc, "url", ex

cvs commit: jakarta-tomcat-connectors/jk/native/iis jk_isapi_plugin.c

[larryi]

larryi  02/01/04 20:26:32

  Modified:jk/native/iis jk_isapi_plugin.c
  Log:
  In HttpFilterProc, the '?' is searched for in an escaped URI.  In
  init_ws_service as part of HttpExtensionProc, the '?' is searched for
  in a URI that has been unescaped.  This isn't guaranteed to find the
  same '?'.  To avoid this, save the query string in it's own "tomcat"
  header and use that in init_ws_service instead of searching again.
  
  Added some logging if the worker and worker mount files are not found.
  
  Fix some tabs and a typo.
  
  Revision  ChangesPath
  1.13  +22 -29jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c
  
  Index: jk_isapi_plugin.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/iis/jk_isapi_plugin.c,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- jk_isapi_plugin.c 14 Dec 2001 01:29:26 -  1.12
  +++ jk_isapi_plugin.c 5 Jan 2002 04:26:32 -   1.13
  @@ -60,7 +60,7 @@
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Author:  Larry Isaacs <[EMAIL PROTECTED]>   *
* Author:  Ignacio J. Ortega <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.12 $   *
  + * Version: $Revision: 1.13 $   *
***/
   
   // This define is needed to include wincrypt,h, needed to get client certificates
  @@ -91,11 +91,13 @@
*
*/
   #define URI_HEADER_NAME ("TOMCATURI:")
  +#define QUERY_HEADER_NAME   ("TOMCATQUERY:")
   #define WORKER_HEADER_NAME  ("TOMCATWORKER:")
   #define TOMCAT_TRANSLATE_HEADER_NAME ("TOMCATTRANSLATE:")
   #define CONTENT_LENGTH  ("CONTENT_LENGTH:")
   
   #define HTTP_URI_HEADER_NAME ("HTTP_TOMCATURI")
  +#define HTTP_QUERY_HEADER_NAME   ("HTTP_TOMCATQUERY")
   #define HTTP_WORKER_HEADER_NAME  ("HTTP_TOMCATWORKER")
   
   #define REGISTRY_LOCATION   ("Software\\Apache Software Foundation\\Jakarta 
Isapi Redirector\\1.0")
  @@ -574,9 +576,9 @@
  (SF_NOTIFY_PREPROC_HEADERS == dwNotificationType)) { 
   PHTTP_FILTER_PREPROC_HEADERS p = 
(PHTTP_FILTER_PREPROC_HEADERS)pvNotification;
   char uri[INTERNET_MAX_URL_LENGTH]; 
  - char snuri[INTERNET_MAX_URL_LENGTH]="/";
  - char Host[INTERNET_MAX_URL_LENGTH];
  - char Translate[INTERNET_MAX_URL_LENGTH];
  +char snuri[INTERNET_MAX_URL_LENGTH]="/";
  +char Host[INTERNET_MAX_URL_LENGTH];
  +char Translate[INTERNET_MAX_URL_LENGTH];
   
   char *query;
   DWORD sz = sizeof(uri);
  @@ -591,6 +593,7 @@
* Just in case somebody set these headers in the request!
*/
   p->SetHeader(pfc, URI_HEADER_NAME, NULL);
  +p->SetHeader(pfc, QUERY_HEADER_NAME, NULL);
   p->SetHeader(pfc, WORKER_HEADER_NAME, NULL);
   p->SetHeader(pfc, TOMCAT_TRANSLATE_HEADER_NAME, NULL);
   
  @@ -605,13 +608,13 @@
   char *worker=0;
   query = strchr(uri, '?');
   if (query) {
  -*query = '\0';
  +*query++ = '\0';
   }
   
   rc = unescape_url(uri);
   if (rc == BAD_REQUEST) {
   jk_log(logger, JK_LOG_ERROR, 
  -   "HttpFilterProc [%s] contains on or more invalid escape 
sequences.\n", 
  +   "HttpFilterProc [%s] contains one or more invalid escape 
sequences.\n", 
  uri);
   write_error_response(pfc,"400 Bad Request",
   "Request contains invalid 
encoding");
  @@ -641,17 +644,6 @@
  uri);
   worker = map_uri_to_worker(uw_map, uri, logger);
   }
  -if(query) {
  -char *querytmp = uri + strlen(uri);
  -*querytmp++ = '?';
  -query++;
  -/* if uri was shortened, move the query characters */
  -if (querytmp != query) {
  -while (*query != '\0')
  -*querytmp++ = *query++;
  -*querytmp = '\0';
  -}
  -}
   
   if (worker) {
   /* This is a servlet, should redirect ... */
  @@ -660,7 +652,9 @@
  uri, worker);
   
   
  - if (!p->AddHeader(pfc, URI_HEADER_NAME, uri) || 
  +if(!p->AddHeader(pfc, URI_HEADER_NAME, uri) || 
  +   ( (query != NULL && strlen(query) > 0)
  +   ? !p->AddHeader(pfc, QUERY_HEADER_NAME, query) : FALSE ) 
|| 
  !p->AddHeader(pfc, WORKER_HEADER_N

Fw: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5390

[Bill Barker]

I was never really involved in the 3.2.x development, so I'm sending back to
the list to try and get ideas on how to get 3.3 to act more like 3.2.x in
the deprecated case.
- Original Message -
From: <[EMAIL PROTECTED]>
To: "Bill Barker" <[EMAIL PROTECTED]>
Sent: Friday, January 04, 2002 7:39 PM
Subject: Re: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5390


> Yea... sort of works but nothing like 3.2.3.  The classes that have been
> called previously are still alive but any uncalled classes in the jar are
> dead (404 error).  And a restart (remove, add) of the context will kill
off
> all the classes in the jar (404 error).  Still not a viable solution.
>
> Regards,
> Mike
>
>
> - Original Message -
> From: "Bill Barker" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Friday, January 04, 2002 3:11 PM
> Subject: Re: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5390
>
>
> The same hack is actually available (at least in theory, I've never tried
> it).  If you set fullReload="false" in the ReloadInterceptor element of
> server.xml, you are supposed to get the 3.2.x reload behavior.  The
default
> fullReload="true" is supposed to be cleaner (and is much if you only use
> classes) since it throws away the app-ClassLoader and re-loads everything
on
> a brand new one.  With the 3.2.x fullReload="false", classes that have
been
> loaded are just re-fetched from the ClassLoader (no jar reading involved).
>



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5390] - jsp-file and load-on-startup and init-param does not work.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5390

jsp-file and load-on-startup and init-param does not work.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-01-04 21:27 ---
The reporter has told me that this works now.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: tomcat 4.0.2 and jakarta-tomcat-connectors

[costinm]

There is a small (possible) bug I'm debugging, related with lb which in
some cases seem to fail to be 'sticky' ( it's not specific to jk1.4,
it has been around forever from what I can see ).

The fix should be small, I still have problems reproducing the bug
so I can test the fix. Don't wait for it - tag whenever you're ready,
it shouldn't be critical.

( BTW, I just got Unix sockets to work !!! Thanks Jean-frederic ! )

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: