Re: [U-Boot-Users] [Patch 1/1] Re-Submit: QE UEC: Add MII Commands
On Tue, 29 Jul 2008 11:10:09 -0400 richardretanubun [EMAIL PROTECTED] wrote: Patch originally submitted by David Saada http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/38946 Shamelessly copy-pasted below. Richard === the proper way to maintain correct attributions in this case is to replace all the above with a simple: From: David Saada [EMAIL PROTECTED] as the first line in the email body. git-am will now assign the correct author when applying it to the tree. Add MII commands to the UEC driver. Note that once a UEC device is selected, any device on its MDIO bus can be addressed. Signed-off-by: David Saada david.saada at ecitele.com please feel free to be a part of the community and add your Tested-by, Reviewed-by, Acked-by, and/or signoff. See linux-2.6/Documentation/SubmittingPatches for further details. Kim - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] fdt/fdt_fixup_ethernet
On Mon, 23 Jun 2008 16:00:28 +0200 Marc Leeman [EMAIL PROTECTED] wrote: Since I moved to FDT (from the previous OF implementation), I get the following behaviour. .. However, the MAC addresses that are passed to the kernel are a mix of the hardcoded defaults and the ones retrieved from the mac flash: you probably need to #define CONFIG_HAS_ETH0 (and 1) in your board's config file. Make sure your device tree has ethernet aliases, too (see existing dts alias entries in linux). Kim - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] Freescale MPC8349EMDS hang on boot
On Wed, 16 Jul 2008 15:28:21 -0700 Ira Snyder [EMAIL PROTECTED] wrote: During the development, I noticed that adding and removing certain pieces of debugging code (which did not change any program state) caused the board to hang on boot, like so: U-Boot 1.3.4-rc1-1-gb89881c-dirty (Jul 16 2008 - 14:54:56) MPC83XX Reset Status: External/Internal Soft, External/Internal Hard CPU: e300c1, MPC8349EA, Rev: 3.0 at 528 MHz, CSB: 264 MHz Board: Freescale MPC8349EMDS I2C: try reverting this commit: commit 1c3dd43338a077165e7e0309cb3994e65d2bdbf8 Author: Grant Likely [EMAIL PROTECTED] Date: Tue Nov 13 22:18:33 2007 -0700 powerpc: Backout relocation changes. Ugh. I *hate* to back this change out, but these compiler flags don't work for relocation on all versions of GCC. I've not been able to reproduce the environment in my setup (and hence, not been able to find a combination that *does* work), so I've got no choice but to go back to the old gcc flags and linker script. Signed-off-by: Grant Likely [EMAIL PROTECTED] Kim - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH v4] fdt: add crypto node handling for MPC8{3, 5}xxE processors
On Mon, 7 Jul 2008 13:46:04 -0500 Kim Phillips [EMAIL PROTECTED] wrote: On Sun, 06 Jul 2008 00:32:03 +0200 Wolfgang Denk [EMAIL PROTECTED] wrote: Dear Kim, in message [EMAIL PROTECTED] you wrote: Delete the crypto node if not on an E-processor. If on 8360 or 834x family, check rev and up-rev crypto node (to SEC rev. 2.4 property values) if on an 'EA' processor, e.g. MPC8349EA. Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- diff from v3: prepended Delete the to the patch commit message. mumble. Thanks gvb. Just for the record (note that I've been offline for the last ten days): I didn't apply this yet as I wait for v5 (see Kumar's comments). Hi WD, I addressed Kumar's comments in a separate patch (to go through the mpc85xx.git tree) here: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/42725 Andy, please apply. Kim Wolfgang, please apply v4 of the patch in this thread. Thanks, Kim - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] 83xx: mpc8315erdb: fix silly thinko in fdt_tsec1_fixup
On Thu, 10 Jul 2008 17:20:51 +0400 Anton Vorontsov [EMAIL PROTECTED] wrote: The thinko was quite silly indeed, I messed with !ptr. Normally this would trigger some fault, but in U-Boot NULL pointer is equal to phys 0, so the code was working still, just didn't actually test mpc8315erdb environment variable value. Heh. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- applied to u-boot-mpc83xx.git#next. Thanks Anton, Kim - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] 8xxx-fdt: set ns16550 clock from CFG_NS16550_CLK, not bi_busfreq
On Wed, 9 Jul 2008 14:43:46 -0400 Paul Gortmaker [EMAIL PROTECTED] wrote: Some boards that have external 16550 UARTs don't have a direct tie between bi_busfreq and the clock used for the UARTs. Boards that do have such a tie should set CFG_NS16550_CLK to be get_bus_freq(0) -- which most of them do already. Signed-off-by: Paul Gortmaker [EMAIL PROTECTED] Acked-by: Kim Phillips [EMAIL PROTECTED] Kim - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH v4] fdt: add crypto node handling for MPC8{3, 5}xxE processors
On Sun, 06 Jul 2008 00:32:03 +0200 Wolfgang Denk [EMAIL PROTECTED] wrote: Dear Kim, in message [EMAIL PROTECTED] you wrote: Delete the crypto node if not on an E-processor. If on 8360 or 834x family, check rev and up-rev crypto node (to SEC rev. 2.4 property values) if on an 'EA' processor, e.g. MPC8349EA. Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- diff from v3: prepended Delete the to the patch commit message. mumble. Thanks gvb. Just for the record (note that I've been offline for the last ten days): I didn't apply this yet as I wait for v5 (see Kumar's comments). Hi WD, I addressed Kumar's comments in a separate patch (to go through the mpc85xx.git tree) here: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/42725 Andy, please apply. Kim - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] Release status - things to be done
On Sun, 06 Jul 2008 01:05:40 +0200
Wolfgang Denk [EMAIL PROTECTED] wrote:
* We have incompatible definitions of the CPU_TYPE_ENTRY for MPC83xx
systems:
In include/asm-ppc/processor.h:
973 #define CPU_TYPE_ENTRY(n, v) \
974 { .name = #n, .soc_ver = SVR_##v, }
But in cpu/mpc83xx/cpu.c:
47 #define CPU_TYPE_ENTRY(x) {#x, SPR_##x}
This causes ``CPU_TYPE_ENTRY redefined'' warnings that need to get
fixed.
- for MPC83xx custodian
you have already pulled a fix for this (commit
4890246a2c5df90a74e2941e3673a49bbd36aee9).
3564 06/09 Kim Phillips [U-Boot-Users] [PATCH] fdt_support: add
crypto node handling for MPC8{3, 5}xxE processors
3621 06/10 Kumar Gala Re: [U-Boot-Users] [PATCH] fdt_support: add
crypto node handling for MPC8{3, 5}xxE processors
3630 06/10 Kim Phillips [PATCH v2] fdt: add crypto node handling for
MPC8{3,5}xxE processors
3631 06/10 Jerry Van BarenRe: [PATCH v2] fdt: add crypto node handling
for MPC8{3,5}xxE processors
3895 06/16 Kim Phillips [PATCH v3] fdt: add crypto node handling for
MPC8{3,5}xxE processors
3896 06/16 Kim Phillips [PATCH v4] fdt: add crypto node handling for
MPC8{3, 5}xxE processors
3925 06/17 Kumar Gala Re: [PATCH v4] fdt: add crypto node handling
for MPC8{3, 5}xxE processors
- asked submitter about state: resubmit cleaned up version?
I responded to your query in that thread; please go ahead and apply v4
as Kumar's comments are addressed in a separate (85xx) patch.
3935 06/17 Kim Phillips [U-Boot-Users] [PATCH 2/2] mpc83xx: move
CPU_TYPE_ENTRY over to processor.h
- for 83xx custodian
you have already pulled this (same commit as above).
Kim
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] Please pull u-boot-mpc83xx.git
WD/Detlev, please pull mostly MVBLM7 board fixes: The following changes since commit 914f58c5766860373a7d232e961cee5a4b54a55b: Wolfgang Denk (1): Merge branch 'master' of git://www.denx.de/git/u-boot-cfi-flash are available in the git repository at: git://git.denx.de/u-boot-mpc83xx.git Andre Schwarz (3): fix system config overwrite @ MPC834x and MPC8313 fix non-working mvBL-M7 update mvBL-M7 board config Kim Phillips (1): mpc83xx: move CPU_TYPE_ENTRY over to processor.h board/mvblm7/mvblm7.c |2 +- cpu/mpc83xx/cpu.c |1 - cpu/mpc83xx/cpu_init.c |5 + include/asm-ppc/processor.h |7 +++ include/configs/MVBLM7.h|5 +++-- 5 files changed, 16 insertions(+), 4 deletions(-) Thanks, Kim - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] TSEC/PHY @ MPC834x stopped working
On Wed, 02 Jul 2008 16:36:11 +0200 Andre Schwarz [EMAIL PROTECTED] wrote: Ben, thanks for your quick reply. Looks like you're right - nothing changed regarding network yet. Maybe it's a cpu specific problem. Kim ? Can you help here ? I know of nothing (barring this being the ETHADDR not specified problem) that could have caused this. Can you try using git-bisect? Kim - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] TSEC/PHY @ MPC834x stopped working
On Wed, 02 Jul 2008 18:01:01 +0200 Andre Schwarz [EMAIL PROTECTED] wrote: this is a fully configured board, i.e. serial# and ethaddr/eth1addr set up correctly. I'll give the bisect a try a soon as there'll be some time. just to clarify, are you using the mainline u-boot.git tree, or u-boot-mpc83xx.git? you should be using the latter until I ask WD to pull. Actually, if you can confirm it corrects your problem, I have no reason to delay it further (I was waiting for WD to get back from vacation). Kim - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] RRvision now uses the CFI driver so board/RRvision/flash.c gets deleted.
On Mon, 23 Jun 2008 17:28:25 +0200 Gary Jennejohn [EMAIL PROTECTED] wrote: Signed-off-by: Gary Jennejohn [EMAIL PROTECTED] --- board/RRvision/flash.c | 522 1 files changed, 0 insertions(+), 522 deletions(-) delete mode 100644 board/RRvision/flash.c merely deleting a file required to build a board unnecessarily breaks future git-bisect runs for it. Suggest removing flash-related stuff from your next poorly titled update patch and adding those changes to this one. Also please indicate any dependency chain via Subject: [PATCH x/n] subsystem: nomenclature so everybody knows where the dependencies are in your patchseries, and what subsystems are affected (mpc8xx in this case?). Thanks, Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] fix system config overwrite @ MPC834x and MPC8313
On Mon, 23 Jun 2008 11:40:56 +0200 Andre Schwarz [EMAIL PROTECTED] wrote: During 83xx setup the System I/O configuration register high gets overwritten with user defined value if CFG_SICRH is defined. Regarding to the MPC834x manual (Table 5-28 reve.1) bits 28+29 of SICRH must keep their reset value regardless of configuration. On my board (using RGMII) those bits are set after reset - yet it's unclear where they come from. The patch keeps both bits on MPC834x and MPC8313. Signed-off-by: Andre Schwarz [EMAIL PROTECTED] this has been applied after a slight rewrite to not cause the following: cpu_init.c: In function ‘cpu_init_f’: cpu_init.c:62: warning: unused variable ‘tmp_sicrh’ Thanks Andre, Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] fix non-working mvBL-M7
On Mon, 23 Jun 2008 13:25:34 +0200 Andre Schwarz [EMAIL PROTECTED] wrote: Hello Andre, diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h index 349ca14..8c0e8b6 100644 --- a/include/configs/MVBLM7.h +++ b/include/configs/MVBLM7.h @@ -27,7 +27,7 @@ #ifndef __CONFIG_H #define __CONFIG_H -#define MV_VERSION v1.0.1 +#define MV_VERSION v1.0.2 instead of incrementing this for each patch, can we just use U_BOOT_VERSION instead? #define CONFIG_HAS_ETH0 +#define CONFIG_ETHADDR b6:b4:45:eb:fb:c0 #define CONFIG_TSEC1_NAMETSEC0 #define CONFIG_FEC1_PHY_NORXERR #define CFG_TSEC1_OFFSET 0x24000 @@ -224,6 +225,7 @@ #define TSEC1_FLAGS (TSEC_GIGABIT|TSEC_REDUCED) #define CONFIG_HAS_ETH1 +#define CONFIG_ETH1ADDR b6:b4:45:eb:fb:c2 #define CONFIG_TSEC2_NAMETSEC1 I had removed this from your original board port because this goes against recommended practice; see: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/41178 +#define CONFIG_HIGH_BATS 1 this line applied. Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH 2/2] mpc83xx: move CPU_TYPE_ENTRY over to processor.h
to avoid this:
cpu.c:47:1: warning: CPU_TYPE_ENTRY redefined
In file included from cpu.c:33:
/home/kim/git/u-boot/include/asm/processor.h:982:1: warning: this is the
location of the previous definition
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
cpu/mpc83xx/cpu.c |1 -
include/asm-ppc/processor.h |7 +++
2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/cpu/mpc83xx/cpu.c b/cpu/mpc83xx/cpu.c
index 36de78d..cc03f8a 100644
--- a/cpu/mpc83xx/cpu.c
+++ b/cpu/mpc83xx/cpu.c
@@ -44,7 +44,6 @@ int checkcpu(void)
char buf[32];
int i;
-#define CPU_TYPE_ENTRY(x) {#x, SPR_##x}
const struct cpu_type {
char name[15];
u32 partid;
diff --git a/include/asm-ppc/processor.h b/include/asm-ppc/processor.h
index 4bfd9f9..cf44f4f 100644
--- a/include/asm-ppc/processor.h
+++ b/include/asm-ppc/processor.h
@@ -979,8 +979,15 @@ struct cpu_type {
struct cpu_type *identify_cpu(uint ver);
+#if defined(CONFIG_MPC85xx)
#define CPU_TYPE_ENTRY(n, v) \
{ .name = #n, .soc_ver = SVR_##v, }
+#else
+#if defined(CONFIG_MPC83XX)
+#define CPU_TYPE_ENTRY(x) {#x, SPR_##x}
+#endif
+#endif
+
#ifndef CONFIG_MACH_SPECIFIC
extern int _machine;
--
1.5.6.rc2.26.g8c37
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH 1/2] mpc85xx: use IS_E_PROCESSOR macro
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
as requested by galak.
cpu/mpc85xx/cpu.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpu/mpc85xx/cpu.c b/cpu/mpc85xx/cpu.c
index 2b7e753..a2b11cc 100644
--- a/cpu/mpc85xx/cpu.c
+++ b/cpu/mpc85xx/cpu.c
@@ -97,7 +97,7 @@ int checkcpu (void)
if (cpu) {
puts(cpu-name);
- if (svr 0x8)
+ if (IS_E_PROCESSOR(svr))
puts(E);
} else {
puts(Unknown);
--
1.5.6.rc2.26.g8c37
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH v3] fdt: add crypto node handling for MPC8{3, 5}xxE processors
crypto node if not on an E-processor. If on 8360 or 834x family,
check rev and up-rev crypto node (to SEC rev. 2.4 property values)
if on an 'EA' processor, e.g. MPC8349EA.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
fixed v2's off-by-one error when accumulating compatible entry offsets
that deleted the necessary '\0' sprintf adds between strings.
common/fdt_support.c| 87 +++
cpu/mpc83xx/fdt.c | 18 +
cpu/mpc85xx/fdt.c |5 ++
include/asm-ppc/processor.h |9
include/fdt_support.h |6 +++
include/mpc83xx.h |7 +++-
6 files changed, 131 insertions(+), 1 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index e58b294..13dab63 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -442,3 +442,90 @@ void fdt_fixup_dr_usb(void *blob, bd_t *bd)
prop, compat, fdt_strerror(err));
}
#endif /* CONFIG_HAS_FSL_DR_USB */
+
+#if defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx)
+/*
+ * update crypto node properties to a specified revision of the SEC
+ * called with sec_rev == 0 if not on an mpc8xxxE processor
+ */
+void fdt_fixup_crypto_node(void *blob, int sec_rev)
+{
+ const struct sec_rev_prop {
+ u32 sec_rev;
+ u32 num_channels;
+ u32 channel_fifo_len;
+ u32 exec_units_mask;
+ u32 descriptor_types_mask;
+ } sec_rev_prop_list [] = {
+ { 0x0200, 4, 24, 0x07e, 0x01010ebf }, /* SEC 2.0 */
+ { 0x0201, 4, 24, 0x0fe, 0x012b0ebf }, /* SEC 2.1 */
+ { 0x0202, 1, 24, 0x04c, 0x0122003f }, /* SEC 2.2 */
+ { 0x0204, 4, 24, 0x07e, 0x012b0ebf }, /* SEC 2.4 */
+ { 0x0300, 4, 24, 0x9fe, 0x03ab0ebf }, /* SEC 3.0 */
+ { 0x0303, 4, 24, 0x97c, 0x03ab0abf }, /* SEC 3.3 */
+ };
+ char compat_strlist[ARRAY_SIZE(sec_rev_prop_list) *
+ sizeof(fsl,secX.Y)];
+ int crypto_node, sec_idx, err;
+ char *p;
+ u32 val;
+
+ /* locate crypto node based on lowest common compatible */
+ crypto_node = fdt_node_offset_by_compatible(blob, -1, fsl,sec2.0);
+ if (crypto_node == -FDT_ERR_NOTFOUND)
+ return;
+
+ /* delete it if not on an E-processor */
+ if (crypto_node 0 !sec_rev) {
+ fdt_del_node(blob, crypto_node);
+ return;
+ }
+
+ /* else we got called for possible uprev */
+ for (sec_idx = 0; sec_idx ARRAY_SIZE(sec_rev_prop_list); sec_idx++)
+ if (sec_rev_prop_list[sec_idx].sec_rev == sec_rev)
+ break;
+
+ if (sec_idx == ARRAY_SIZE(sec_rev_prop_list)) {
+ puts(warning: unknown SEC revision number\n);
+ return;
+ }
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].num_channels);
+ err = fdt_setprop(blob, crypto_node, fsl,num-channels, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].descriptor_types_mask);
+ err = fdt_setprop(blob, crypto_node, fsl,descriptor-types-mask, val,
4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].exec_units_mask);
+ err = fdt_setprop(blob, crypto_node, fsl,exec-units-mask, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].channel_fifo_len);
+ err = fdt_setprop(blob, crypto_node, fsl,channel-fifo-len, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = 0;
+ while (sec_idx = 0) {
+ p = compat_strlist + val;
+ val += sprintf(p, fsl,sec%d.%d,
+ (sec_rev_prop_list[sec_idx].sec_rev 0xff00) 8,
+ sec_rev_prop_list[sec_idx].sec_rev 0x00ff) + 1;
+ sec_idx--;
+ }
+ err = fdt_setprop(blob, crypto_node, compatible, compat_strlist,
val);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+}
+#endif /* defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx) */
diff --git a/cpu/mpc83xx/fdt.c b/cpu/mpc83xx/fdt.c
index 02c4d05..267ae6a 100644
--- a/cpu/mpc83xx/fdt.c
+++ b/cpu/mpc83xx/fdt.c
@@ -26,6 +26,7 @@
#include common.h
#include libfdt.h
#include fdt_support.h
+#include asm/processor.h
extern void ft_qe_setup(void *blob);
@@ -33,6 +34,23 @@ DECLARE_GLOBAL_DATA_PTR;
void ft_cpu_setup(void *blob, bd_t *bd)
{
+ immap_t
[U-Boot-Users] [PATCH v4] fdt: add crypto node handling for MPC8{3, 5}xxE processors
Delete the crypto node if not on an E-processor. If on 8360 or 834x family,
check rev and up-rev crypto node (to SEC rev. 2.4 property values)
if on an 'EA' processor, e.g. MPC8349EA.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
diff from v3: prepended Delete the to the patch commit message.
mumble. Thanks gvb.
common/fdt_support.c| 87 +++
cpu/mpc83xx/fdt.c | 18 +
cpu/mpc85xx/fdt.c |5 ++
include/asm-ppc/processor.h |9
include/fdt_support.h |6 +++
include/mpc83xx.h |7 +++-
6 files changed, 131 insertions(+), 1 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index e58b294..13dab63 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -442,3 +442,90 @@ void fdt_fixup_dr_usb(void *blob, bd_t *bd)
prop, compat, fdt_strerror(err));
}
#endif /* CONFIG_HAS_FSL_DR_USB */
+
+#if defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx)
+/*
+ * update crypto node properties to a specified revision of the SEC
+ * called with sec_rev == 0 if not on an mpc8xxxE processor
+ */
+void fdt_fixup_crypto_node(void *blob, int sec_rev)
+{
+ const struct sec_rev_prop {
+ u32 sec_rev;
+ u32 num_channels;
+ u32 channel_fifo_len;
+ u32 exec_units_mask;
+ u32 descriptor_types_mask;
+ } sec_rev_prop_list [] = {
+ { 0x0200, 4, 24, 0x07e, 0x01010ebf }, /* SEC 2.0 */
+ { 0x0201, 4, 24, 0x0fe, 0x012b0ebf }, /* SEC 2.1 */
+ { 0x0202, 1, 24, 0x04c, 0x0122003f }, /* SEC 2.2 */
+ { 0x0204, 4, 24, 0x07e, 0x012b0ebf }, /* SEC 2.4 */
+ { 0x0300, 4, 24, 0x9fe, 0x03ab0ebf }, /* SEC 3.0 */
+ { 0x0303, 4, 24, 0x97c, 0x03ab0abf }, /* SEC 3.3 */
+ };
+ char compat_strlist[ARRAY_SIZE(sec_rev_prop_list) *
+ sizeof(fsl,secX.Y)];
+ int crypto_node, sec_idx, err;
+ char *p;
+ u32 val;
+
+ /* locate crypto node based on lowest common compatible */
+ crypto_node = fdt_node_offset_by_compatible(blob, -1, fsl,sec2.0);
+ if (crypto_node == -FDT_ERR_NOTFOUND)
+ return;
+
+ /* delete it if not on an E-processor */
+ if (crypto_node 0 !sec_rev) {
+ fdt_del_node(blob, crypto_node);
+ return;
+ }
+
+ /* else we got called for possible uprev */
+ for (sec_idx = 0; sec_idx ARRAY_SIZE(sec_rev_prop_list); sec_idx++)
+ if (sec_rev_prop_list[sec_idx].sec_rev == sec_rev)
+ break;
+
+ if (sec_idx == ARRAY_SIZE(sec_rev_prop_list)) {
+ puts(warning: unknown SEC revision number\n);
+ return;
+ }
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].num_channels);
+ err = fdt_setprop(blob, crypto_node, fsl,num-channels, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].descriptor_types_mask);
+ err = fdt_setprop(blob, crypto_node, fsl,descriptor-types-mask, val,
4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].exec_units_mask);
+ err = fdt_setprop(blob, crypto_node, fsl,exec-units-mask, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].channel_fifo_len);
+ err = fdt_setprop(blob, crypto_node, fsl,channel-fifo-len, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = 0;
+ while (sec_idx = 0) {
+ p = compat_strlist + val;
+ val += sprintf(p, fsl,sec%d.%d,
+ (sec_rev_prop_list[sec_idx].sec_rev 0xff00) 8,
+ sec_rev_prop_list[sec_idx].sec_rev 0x00ff) + 1;
+ sec_idx--;
+ }
+ err = fdt_setprop(blob, crypto_node, compatible, compat_strlist,
val);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+}
+#endif /* defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx) */
diff --git a/cpu/mpc83xx/fdt.c b/cpu/mpc83xx/fdt.c
index 02c4d05..267ae6a 100644
--- a/cpu/mpc83xx/fdt.c
+++ b/cpu/mpc83xx/fdt.c
@@ -26,6 +26,7 @@
#include common.h
#include libfdt.h
#include fdt_support.h
+#include asm/processor.h
extern void ft_qe_setup(void *blob);
@@ -33,6 +34,23 @@ DECLARE_GLOBAL_DATA_PTR;
void ft_cpu_setup(void *blob, bd_t *bd)
{
+ immap_t *immr = (immap_t *)CFG_IMMR
Re: [U-Boot-Users] [PATCH 1/8] New board SIMPC8313 support: MAINTAINERS, MAKEALL, Makefile
On Fri, 30 May 2008 11:07:38 -0700 (PDT) Ron Madrid [EMAIL PROTECTED] wrote: New board SIMPC8313 support: MAINTAINERS, MAKEALL, Makefile Signed-off-by: Ron Madrid --- MAINTAINERS |5 + MAKEALL |2 ++ Makefile| 18 ++ 3 files changed, 25 insertions(+), 0 deletions(-) I can't apply this: Applying New board SIMPC8313 support: MAINTAINERS, MAKEALL, Makefile .dotest/patch:15: trailing whitespace. fatal: corrupt patch at line 41 Patch failed at 0001. When you have resolved this problem run git-am --resolved. If you would prefer to skip this patch, instead run git-am --skip. ... $(obj)include/config.h ; \ + $(MKCONFIG) -a SIMPC8313 ppc mpc83xx simpc8313 sheldon; \ your mailer is obviously line-wrapping the patch. Please refer to linux-2.6/Documentation/email-clients.txt on how to fix this. Thank you, Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] 85xx: extended cpu identification
On Tue, 10 Jun 2008 08:23:46 -0500
Kumar Gala [EMAIL PROTECTED] wrote:
On Jun 10, 2008, at 12:57 AM, Kim Phillips wrote:
On Thu, 29 May 2008 03:20:08 -0500 (CDT)
Kumar Gala [EMAIL PROTECTED] wrote:
+struct cpu_type cpu_type_list [] = {
+ CPU_TYPE_ENTRY(8533, 8533, 0),
+ CPU_TYPE_ENTRY(8533, 8533_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8540, 8540, 0),
+ CPU_TYPE_ENTRY(8541, 8541, 0),
+ CPU_TYPE_ENTRY(8541, 8541_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8543, 8543, 0),
+ CPU_TYPE_ENTRY(8543, 8543_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8544, 8544, 0),
+ CPU_TYPE_ENTRY(8544, 8544_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8545, 8545, 0),
+ CPU_TYPE_ENTRY(8545, 8545_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8547, 8547_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8548, 8548, 0),
+ CPU_TYPE_ENTRY(8548, 8548_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8555, 8555, 0),
+ CPU_TYPE_ENTRY(8555, 8555_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8560, 8560, 0),
+ CPU_TYPE_ENTRY(8567, 8567, 0),
+ CPU_TYPE_ENTRY(8567, 8567_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8568, 8568, 0),
+ CPU_TYPE_ENTRY(8568, 8568_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8572, 8572, 0),
+ CPU_TYPE_ENTRY(8572, 8572_E, CPU_FTRS_HAS_CRYPTO),
this seems like overkill given all we have to do is check one bit (see
IS_E_PROCESSOR macro in handle crypto node patch I just sent out).
I don't trust our HW guys to keep w/that convention. Plus we can use
this mechanism for other things if need be.
they've been pretty good so far, and until the other thing comes
around, we can compact this table instead of expanding it - the 85xx_E
entries themselves are unnecessary.
Kim
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] 85xx: extended cpu identification
On Tue, 10 Jun 2008 10:10:02 -0500
Kumar Gala [EMAIL PROTECTED] wrote:
On Jun 10, 2008, at 8:48 AM, Kim Phillips wrote:
On Tue, 10 Jun 2008 08:23:46 -0500
Kumar Gala [EMAIL PROTECTED] wrote:
On Jun 10, 2008, at 12:57 AM, Kim Phillips wrote:
On Thu, 29 May 2008 03:20:08 -0500 (CDT)
Kumar Gala [EMAIL PROTECTED] wrote:
+struct cpu_type cpu_type_list [] = {
+CPU_TYPE_ENTRY(8533, 8533, 0),
+CPU_TYPE_ENTRY(8533, 8533_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8540, 8540, 0),
+CPU_TYPE_ENTRY(8541, 8541, 0),
+CPU_TYPE_ENTRY(8541, 8541_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8543, 8543, 0),
+CPU_TYPE_ENTRY(8543, 8543_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8544, 8544, 0),
+CPU_TYPE_ENTRY(8544, 8544_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8545, 8545, 0),
+CPU_TYPE_ENTRY(8545, 8545_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8547, 8547_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8548, 8548, 0),
+CPU_TYPE_ENTRY(8548, 8548_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8555, 8555, 0),
+CPU_TYPE_ENTRY(8555, 8555_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8560, 8560, 0),
+CPU_TYPE_ENTRY(8567, 8567, 0),
+CPU_TYPE_ENTRY(8567, 8567_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8568, 8568, 0),
+CPU_TYPE_ENTRY(8568, 8568_E, CPU_FTRS_HAS_CRYPTO),
+CPU_TYPE_ENTRY(8572, 8572, 0),
+CPU_TYPE_ENTRY(8572, 8572_E, CPU_FTRS_HAS_CRYPTO),
this seems like overkill given all we have to do is check one bit
(see
IS_E_PROCESSOR macro in handle crypto node patch I just sent out).
I don't trust our HW guys to keep w/that convention. Plus we can use
this mechanism for other things if need be.
they've been pretty good so far, and until the other thing comes
around, we can compact this table instead of expanding it - the 85xx_E
entries themselves are unnecessary.
I disagree and would prefer to keep it as I've done as it provides the
most flexibility.
it's easier to do a IS_E_PROCESSOR(get_svr()) from cpu/mpc85xx/fdt.c
instead of getting ver, calling cpu = identify_cpu(ver), and then
checking cpu-features every time. I don't know what other features
you have in mind (perhaps this patch should wait until then?), but
HAS_CRYPTO is either on or off, and the bit already exists in the h/w..
Kim
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH] fdt: unshadow global working fdt variable
differentiate with local variables of the same name by renaming the
global 'fdt' variable 'working_fdt'.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
applies to current u-boot-fdt.git.
common/cmd_fdt.c | 114 +++---
common/fdt_support.c |2 +-
include/libfdt_env.h |2 +-
lib_ppc/bootm.c |2 +-
4 files changed, 64 insertions(+), 56 deletions(-)
diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c
index 4285a96..5c3a0bb 100644
--- a/common/cmd_fdt.c
+++ b/common/cmd_fdt.c
@@ -62,7 +62,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
/*
* Set the address [and length] of the fdt.
*/
- fdt = (struct fdt_header *)simple_strtoul(argv[2], NULL, 16);
+ working_fdt = (struct fdt_header *)simple_strtoul(argv[2],
NULL, 16);
if (!fdt_valid()) {
return 1;
@@ -75,15 +75,15 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
* Optional new length
*/
len = simple_strtoul(argv[3], NULL, 16);
- if (len fdt_totalsize(fdt)) {
+ if (len fdt_totalsize(working_fdt)) {
printf (New length %d existing length %d,
ignoring.\n,
- len, fdt_totalsize(fdt));
+ len, fdt_totalsize(working_fdt));
} else {
/*
* Open in place with a new length.
*/
- err = fdt_open_into(fdt, fdt, len);
+ err = fdt_open_into(working_fdt, working_fdt,
len);
if (err != 0) {
printf (libfdt fdt_open_into(): %s\n,
fdt_strerror(err));
@@ -92,7 +92,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
}
/
-* Move the fdt
+* Move the working_fdt
/
} else if (strncmp(argv[1], mo, 2) == 0) {
struct fdt_header *newaddr;
@@ -107,7 +107,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
/*
* Set the address and length of the fdt.
*/
- fdt = (struct fdt_header *)simple_strtoul(argv[2], NULL, 16);
+ working_fdt = (struct fdt_header *)simple_strtoul(argv[2],
NULL, 16);
if (!fdt_valid()) {
return 1;
}
@@ -119,13 +119,13 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
* current length.
*/
if (argc = 4) {
- len = fdt_totalsize(fdt);
+ len = fdt_totalsize(working_fdt);
} else {
len = simple_strtoul(argv[4], NULL, 16);
- if (len fdt_totalsize(fdt)) {
+ if (len fdt_totalsize(working_fdt)) {
printf (New length 0x%X existing length
0x%X, aborting.\n,
- len, fdt_totalsize(fdt));
+ len, fdt_totalsize(working_fdt));
return 1;
}
}
@@ -133,13 +133,13 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
/*
* Copy to the new location.
*/
- err = fdt_open_into(fdt, newaddr, len);
+ err = fdt_open_into(working_fdt, newaddr, len);
if (err != 0) {
printf (libfdt fdt_open_into(): %s\n,
fdt_strerror(err));
return 1;
}
- fdt = newaddr;
+ working_fdt = newaddr;
/
* Make a new node
@@ -161,7 +161,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
pathp = argv[2];
nodep = argv[3];
- nodeoffset = fdt_path_offset (fdt, pathp);
+ nodeoffset = fdt_path_offset (working_fdt, pathp);
if (nodeoffset 0) {
/*
* Not found or something else bad happened.
@@ -170,7 +170,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv
[U-Boot-Users] Please pull mpc83xx.git
Wolfgang, please pull support for the MVBLM7 board and some local bus define refactoring: The following changes since commit 8155efbd7ae9c65564ca98affe94631d612ae088: Wolfgang Denk (1): Merge branch 'master' of ssh://mercury/home/wd/git/u-boot/master are available in the git repository at: git://git.denx.de/u-boot-mpc83xx.git Andre Schwarz (2): add MPC8343 based board mvBlueLYNX-M7 (doc+config) add MPC8343 based board mvBlueLYNX-M7 (board+make files) Anton Vorontsov (2): 83xx/85xx/86xx: factor out Freescale Localbus defines out of mpc83xx.h 83xx/85xx: further localbus cleanups Kim Phillips (1): mpc83xx: MVBLM7: minor build fixups Tor Krill (1): Add missing CSCONFIG_BANK_BIT_3 define to mpc83xx.h CREDITS|4 + MAINTAINERS|4 + MAKEALL|1 + Makefile |3 + board/mvblm7/Makefile | 48 board/mvblm7/config.mk | 25 ++ board/mvblm7/fpga.c| 188 board/mvblm7/fpga.h| 34 +++ board/mvblm7/mvblm7.c | 157 + board/mvblm7/mvblm7.h | 21 ++ board/mvblm7/mvblm7_autoscript | 37 +++ board/mvblm7/pci.c | 133 +++ doc/README.mvblm7 | 85 +++ include/asm-ppc/fsl_lbc.h | 264 ++ include/configs/MPC8315ERDB.h |2 +- include/configs/MPC8349EMDS.h |2 +- include/configs/MPC8349ITX.h |4 +- include/configs/MPC8360EMDS.h |2 +- include/configs/MPC8360ERDK.h |2 +- include/configs/MPC837XEMDS.h |2 +- include/configs/MVBLM7.h | 479 include/configs/TQM834x.h |2 +- include/mpc83xx.h | 235 +--- include/mpc85xx.h | 37 +--- include/mpc86xx.h |2 + 25 files changed, 1497 insertions(+), 276 deletions(-) create mode 100644 board/mvblm7/Makefile create mode 100644 board/mvblm7/config.mk create mode 100644 board/mvblm7/fpga.c create mode 100644 board/mvblm7/fpga.h create mode 100644 board/mvblm7/mvblm7.c create mode 100644 board/mvblm7/mvblm7.h create mode 100644 board/mvblm7/mvblm7_autoscript create mode 100644 board/mvblm7/pci.c create mode 100644 doc/README.mvblm7 create mode 100644 include/asm-ppc/fsl_lbc.h create mode 100644 include/configs/MVBLM7.h Thanks, Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH v2] fdt: add crypto node handling for MPC8{3, 5}xxE processors
crypto node if not on an E-processor. If on 8360 or 834x family,
check rev and up-rev crypto node (to SEC rev. 2.4 property values)
if on an 'EA' processor, e.g. MPC8349EA.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
change since v1: mpc85xx IS_E_PROCESSOR(svr) definition changed to (svr
0x8).
(I'm not sure, but I think this goes through WD directly)
common/fdt_support.c| 87 +++
cpu/mpc83xx/fdt.c | 18 +
cpu/mpc85xx/fdt.c |6 +++
include/asm-ppc/processor.h |9
include/fdt_support.h |6 +++
include/mpc83xx.h |7 +++-
6 files changed, 132 insertions(+), 1 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index 7507744..c5b4650 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -447,3 +447,90 @@ void fdt_fixup_dr_usb(void *blob, bd_t *bd)
prop, compat, fdt_strerror(err));
}
#endif /* CONFIG_HAS_FSL_DR_USB */
+
+#if defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx)
+/*
+ * update crypto node properties to a specified revision of the SEC
+ * called with sec_rev == 0 if not on an mpc8xxxE processor
+ */
+void fdt_fixup_crypto_node(void *blob, int sec_rev)
+{
+ const struct sec_rev_prop {
+ u32 sec_rev;
+ u32 num_channels;
+ u32 channel_fifo_len;
+ u32 exec_units_mask;
+ u32 descriptor_types_mask;
+ } sec_rev_prop_list [] = {
+ { 0x0200, 4, 24, 0x07e, 0x01010ebf }, /* SEC 2.0 */
+ { 0x0201, 4, 24, 0x0fe, 0x012b0ebf }, /* SEC 2.1 */
+ { 0x0202, 1, 24, 0x04c, 0x0122003f }, /* SEC 2.2 */
+ { 0x0204, 4, 24, 0x07e, 0x012b0ebf }, /* SEC 2.4 */
+ { 0x0300, 4, 24, 0x9fe, 0x03ab0ebf }, /* SEC 3.0 */
+ { 0x0303, 4, 24, 0x97c, 0x03ab0abf }, /* SEC 3.3 */
+ };
+ char compat_strlist[ARRAY_SIZE(sec_rev_prop_list) *
+ sizeof(fsl,secX.Y)];
+ int crypto_node, sec_idx, err;
+ char *p;
+ u32 val;
+
+ /* locate crypto node based on lowest common compatible */
+ crypto_node = fdt_node_offset_by_compatible(blob, -1, fsl,sec2.0);
+ if (crypto_node == -FDT_ERR_NOTFOUND)
+ return;
+
+ /* delete it if not on an E-processor */
+ if (crypto_node 0 !sec_rev) {
+ fdt_del_node(blob, crypto_node);
+ return;
+ }
+
+ /* else we got called for possible uprev */
+ for (sec_idx = 0; sec_idx ARRAY_SIZE(sec_rev_prop_list); sec_idx++)
+ if (sec_rev_prop_list[sec_idx].sec_rev == sec_rev)
+ break;
+
+ if (sec_idx == ARRAY_SIZE(sec_rev_prop_list)) {
+ puts(warning: unknown SEC revision number\n);
+ return;
+ }
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].num_channels);
+ err = fdt_setprop(blob, crypto_node, fsl,num-channels, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].descriptor_types_mask);
+ err = fdt_setprop(blob, crypto_node, fsl,descriptor-types-mask, val,
4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].exec_units_mask);
+ err = fdt_setprop(blob, crypto_node, fsl,exec-units-mask, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].channel_fifo_len);
+ err = fdt_setprop(blob, crypto_node, fsl,channel-fifo-len, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = 0;
+ while (sec_idx = 0) {
+ p = compat_strlist + val;
+ val += sprintf(p, fsl,sec%d.%d,
+ (sec_rev_prop_list[sec_idx].sec_rev 0xff00) 8,
+ sec_rev_prop_list[sec_idx].sec_rev 0x00ff);
+ sec_idx--;
+ }
+ err = fdt_setprop(blob, crypto_node, compatible, compat_strlist,
val);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+}
+#endif /* defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx) */
diff --git a/cpu/mpc83xx/fdt.c b/cpu/mpc83xx/fdt.c
index 02c4d05..267ae6a 100644
--- a/cpu/mpc83xx/fdt.c
+++ b/cpu/mpc83xx/fdt.c
@@ -26,6 +26,7 @@
#include common.h
#include libfdt.h
#include fdt_support.h
+#include asm/processor.h
extern void ft_qe_setup(void *blob);
@@ -33,6 +34,23 @@ DECLARE_GLOBAL_DATA_PTR;
void ft_cpu_setup(void *blob, bd_t *bd
Re: [U-Boot-Users] [PATCH] libfdt: Move the working_fdt pointer to cmd_fdt.c
On Tue, 10 Jun 2008 22:36:07 -0400 Jerry Van Baren [EMAIL PROTECTED] wrote: I've applied your patch fdt: unshadow global working fdt variable. As a feeble attempt to redeem myself, I added a patch to move working_fdt to cmd_fdt.c... it isn't used (any longer) in fdt_support.c. sounds good I started to hack bootm.c (if we moved the reference to working_fdt out of boot_relocate_fdt() or move that function, we could make working_fdt static), but it got too complex so I backed out of that change for now. :) I gave a shot at switching all MPC8[356]xx to MPC8[356]XX but the 100k limit, stepping into 51xx space, and probably horrible timing (due to the many unapplied patches out there) prevented me from doing so. thanks, Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH] fdt_support: add crypto node handling for MPC8{3, 5}xxE processors
crypto node if not on an E-processor. If on 8360 or 834x family,
check rev and up-rev crypto node (to SEC rev. 2.4) property values
if on an 'EA' processor, e.g. MPC8349EA.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
common/fdt_support.c| 87 +++
cpu/mpc83xx/fdt.c | 18 +
cpu/mpc85xx/fdt.c |6 +++
include/asm-ppc/processor.h |9
include/fdt_support.h |6 +++
include/mpc83xx.h |7 +++-
6 files changed, 132 insertions(+), 1 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index 7507744..c5b4650 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -447,3 +447,90 @@ void fdt_fixup_dr_usb(void *blob, bd_t *bd)
prop, compat, fdt_strerror(err));
}
#endif /* CONFIG_HAS_FSL_DR_USB */
+
+#if defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx)
+/*
+ * update crypto node properties to a specified revision of the SEC
+ * called with sec_rev == 0 if not on an mpc8xxxE processor
+ */
+void fdt_fixup_crypto_node(void *blob, int sec_rev)
+{
+ const struct sec_rev_prop {
+ u32 sec_rev;
+ u32 num_channels;
+ u32 channel_fifo_len;
+ u32 exec_units_mask;
+ u32 descriptor_types_mask;
+ } sec_rev_prop_list [] = {
+ { 0x0200, 4, 24, 0x07e, 0x01010ebf }, /* SEC 2.0 */
+ { 0x0201, 4, 24, 0x0fe, 0x012b0ebf }, /* SEC 2.1 */
+ { 0x0202, 1, 24, 0x04c, 0x0122003f }, /* SEC 2.2 */
+ { 0x0204, 4, 24, 0x07e, 0x012b0ebf }, /* SEC 2.4 */
+ { 0x0300, 4, 24, 0x9fe, 0x03ab0ebf }, /* SEC 3.0 */
+ { 0x0303, 4, 24, 0x97c, 0x03ab0abf }, /* SEC 3.3 */
+ };
+ char compat_strlist[ARRAY_SIZE(sec_rev_prop_list) *
+ sizeof(fsl,secX.Y)];
+ int crypto_node, sec_idx, err;
+ char *p;
+ u32 val;
+
+ /* locate crypto node based on lowest common compatible */
+ crypto_node = fdt_node_offset_by_compatible(blob, -1, fsl,sec2.0);
+ if (crypto_node == -FDT_ERR_NOTFOUND)
+ return;
+
+ /* delete it if not on an E-processor */
+ if (crypto_node 0 !sec_rev) {
+ fdt_del_node(blob, crypto_node);
+ return;
+ }
+
+ /* else we got called for possible uprev */
+ for (sec_idx = 0; sec_idx ARRAY_SIZE(sec_rev_prop_list); sec_idx++)
+ if (sec_rev_prop_list[sec_idx].sec_rev == sec_rev)
+ break;
+
+ if (sec_idx == ARRAY_SIZE(sec_rev_prop_list)) {
+ puts(warning: unknown SEC revision number\n);
+ return;
+ }
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].num_channels);
+ err = fdt_setprop(blob, crypto_node, fsl,num-channels, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].descriptor_types_mask);
+ err = fdt_setprop(blob, crypto_node, fsl,descriptor-types-mask, val,
4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].exec_units_mask);
+ err = fdt_setprop(blob, crypto_node, fsl,exec-units-mask, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = cpu_to_fdt32(sec_rev_prop_list[sec_idx].channel_fifo_len);
+ err = fdt_setprop(blob, crypto_node, fsl,channel-fifo-len, val, 4);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+
+ val = 0;
+ while (sec_idx = 0) {
+ p = compat_strlist + val;
+ val += sprintf(p, fsl,sec%d.%d,
+ (sec_rev_prop_list[sec_idx].sec_rev 0xff00) 8,
+ sec_rev_prop_list[sec_idx].sec_rev 0x00ff);
+ sec_idx--;
+ }
+ err = fdt_setprop(blob, crypto_node, compatible, compat_strlist,
val);
+ if (err 0)
+ printf(WARNING: could not set crypto property: %s\n,
+ fdt_strerror(err));
+}
+#endif /* defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx) */
diff --git a/cpu/mpc83xx/fdt.c b/cpu/mpc83xx/fdt.c
index 02c4d05..267ae6a 100644
--- a/cpu/mpc83xx/fdt.c
+++ b/cpu/mpc83xx/fdt.c
@@ -26,6 +26,7 @@
#include common.h
#include libfdt.h
#include fdt_support.h
+#include asm/processor.h
extern void ft_qe_setup(void *blob);
@@ -33,6 +34,23 @@ DECLARE_GLOBAL_DATA_PTR;
void ft_cpu_setup(void *blob, bd_t *bd)
{
+ immap_t *immr = (immap_t *)CFG_IMMR;
+ int spridr = immr-sysconf.spridr;
+
+ /*
+* delete crypto node if not on an E-processor
Re: [U-Boot-Users] [PATCH] 85xx: extended cpu identification
On Thu, 29 May 2008 03:20:08 -0500 (CDT)
Kumar Gala [EMAIL PROTECTED] wrote:
+struct cpu_type cpu_type_list [] = {
+ CPU_TYPE_ENTRY(8533, 8533, 0),
+ CPU_TYPE_ENTRY(8533, 8533_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8540, 8540, 0),
+ CPU_TYPE_ENTRY(8541, 8541, 0),
+ CPU_TYPE_ENTRY(8541, 8541_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8543, 8543, 0),
+ CPU_TYPE_ENTRY(8543, 8543_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8544, 8544, 0),
+ CPU_TYPE_ENTRY(8544, 8544_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8545, 8545, 0),
+ CPU_TYPE_ENTRY(8545, 8545_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8547, 8547_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8548, 8548, 0),
+ CPU_TYPE_ENTRY(8548, 8548_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8555, 8555, 0),
+ CPU_TYPE_ENTRY(8555, 8555_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8560, 8560, 0),
+ CPU_TYPE_ENTRY(8567, 8567, 0),
+ CPU_TYPE_ENTRY(8567, 8567_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8568, 8568, 0),
+ CPU_TYPE_ENTRY(8568, 8568_E, CPU_FTRS_HAS_CRYPTO),
+ CPU_TYPE_ENTRY(8572, 8572, 0),
+ CPU_TYPE_ENTRY(8572, 8572_E, CPU_FTRS_HAS_CRYPTO),
this seems like overkill given all we have to do is check one bit (see
IS_E_PROCESSOR macro in handle crypto node patch I just sent out).
Kim
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 2/2] Add board specific files for BUBBATWO
On Mon, 2 Jun 2008 15:16:02 +0200
Tor Krill [EMAIL PROTECTED] wrote:
+U_BOOT_CMD (bubbacmd, 3, 1, do_bubbacmd,
+ bubbacmd- Board specific commands for Bubba TWO\n,
+ spindown [dev] - spin down disk dev\n
+ bubbacmd spinup [dev] - spin up disk dev\n
+ bubbacmd button - read button status\n);
+#endif
I the spinup/spindown commands should be part of cmd_ide, no? Or
rather, should they be eliminated in favour of Das U-Boot way of only
powering up devices when accesses are requested? i.e, power up on a
disk read command and power down after it's done?
btw, this also prevents me from applying this board support patch
because of the sata_sil3114 driver dependency here.
+int getboardversion (void)
+{
+ volatile immap_t *im = (immap_t *) CFG_IMMR;
+ int rev = im-gpio[0].dat (HW_ID0 | HW_ID1 | HW_ID2);
looks like the and op is unnecessary here..plus we're not doing
volatile i/o accesses any more - use {in,out}_be32(), {set,clr}bits32()
etc., this occurs many other places in this patch..
+
+ rev =
+ ((rev HW_ID0) 3) | ((rev HW_ID1) 2) | ((rev HW_ID2)
+ 1);
+
+ return rev;
+}
return ((rev HW_ID0) 3) | ((rev HW_ID1) 2) |
((rev HW_ID2) 1);
+ulong board_flash_get_legacy (ulong base, int banknum, flash_info_t * info)
+{
+ if (banknum == 0) { /* non-CFI boot flash */
+ info-portwidth = FLASH_CFI_16BIT;
+ info-chipwidth = FLASH_CFI_BY16;
+ info-interface = FLASH_CFI_X16;
+ return 1;
+ } else {
+ return 0;
+ }
else is superfluous
+/* Lookup table for the different boardversions */
+static struct {
+ u32 memsize;
+ u32 config;
+} meminfo[] = {
+ /* 0 - revA prototypes */
+ {
+ memsize: 128, config:CFG_DDR_CONFIG_128},
+ /* 1 - revB */
+ {
+ memsize: 256, config:CFG_DDR_CONFIG_256},
+ /* 2 - empty */
+ {
+ memsize: 128, config:CFG_DDR_CONFIG_128},
+ /* 3 - empty */
+ {
+ memsize: 128, config:CFG_DDR_CONFIG_128},
+ /* 4 - empty */
+ {
+ memsize: 128, config:CFG_DDR_CONFIG_128},
+ /* 5 - empty */
+ {
+ memsize: 128, config:CFG_DDR_CONFIG_128},
+ /* 6 - empty */
+ {
+ memsize: 128, config:CFG_DDR_CONFIG_128},
+ /* 7 - empty */
+ {
+ memsize: 128, config:CFG_DDR_CONFIG_128}
+};
would something like this be neater:
{ 128, CFG_DDR_CONFIG_128 }, /* 7 - empty */
?
Kim
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] UEC Driver - 83xx RGMII half duplex BUG FIX - RFC
On Mon, 2 Jun 2008 16:03:56 -0700 Russell McGuire [EMAIL PROTECTED] wrote: To work around this we need to remove the clearing of the FDX bit while in RGMII, RTBI, TBI, or GMII modes. The only modes that can clear the FDX bit are MII or RMII. Since I am not the author of the drivers, would the team want me to submit my idea on how to fix this, or would the author like to quickly add in this check before clearing the bit? Or alternatively before calling the uec_set_mac_duplex function(). Though I am a fan of making all functions self protecting against bad code. Can you submit a patch for an on-list review? Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] MPC8315E-RDB kernel serial console baudrate
On Wed, 28 May 2008 21:33:33 +0200 Leon Woestenberg [EMAIL PROTECTED] wrote: I have tried to run the vanilla upstream 2.6.25.4 kernel on my .. U-Boot 1.3.0-rc2 (Nov 19 2007 - 16:37:36) MPC83XX CPU: e300c3, MPC8315E, Rev: 10 at 400 MHz, CSB: 133 MHz Board: Freescale MPC8315ERDB Rev 0.0 Is this u-boot too old, i.e. might there be a compatibility issue involved between u-boot / dtb / kernel? yes What would be the best approach from here? (I plan to measure the actual bitrate using a scope tomorrow). start by updating u-boot Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 2/2] add MPC8343 based board mvBlueLYNX-M7
On Tue, 27 May 2008 10:44:32 +0200 Andre Schwarz [EMAIL PROTECTED] wrote: Do you want me to re-send a complete set of patches for the M7-Board against the latest version ? I'd appreciate it since I seem to have lost the board config file. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH-v3] Big white-space cleanup.
On Wed, 21 May 2008 15:34:32 +0200 Wolfgang Denk [EMAIL PROTECTED] wrote: In message [EMAIL PROTECTED] you wrote: Unfortunately several wrong fixes or false positives still remains, but this patch definitely reduce the number of wrong indentations. Could you please point out the remaining problems? If I understand what's gone wrong I probably can fix my procedure and spin another patch? although the existing patch should definitely stay committed, here are a couple of examples of things I'd expect it to have fixed: board/freescale/mpc8349itx/mpc8349itx.c:120 board/freescale/mpc8349itx/mpc8349itx.c:275 board/freescale/mpc8349emds/pci.c:56 Also, although less authoritative (esp. for u-boot), linux-2.6/scripts/checkpatch.pl output is always interesting on these types of patches. I'll be sure to get some by hand - I understand these expressions sometimes get too unwieldly too fast. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH-v3] Big white-space cleanup.
On Wed, 21 May 2008 10:25:20 +0200 Wolfgang Denk [EMAIL PROTECTED] wrote: The whole code in the cpu/ixp/npe/ is going to be replaced soon by the new driver code that has gone into mainline Linux recently. Thak makes me think we should not spend too much effort on this. Basicly I see three options: 1) Be lazy and leave as is now 2) Go forward and clean up all white space issues in the /npe/ code 3) Revert the white-space cleanup patches as far as /npe/ code is affected. Short discussion on IRC showed preference for 1). If you agree, that's what we'll do. hmm, I can see reasons to leave npe alone wrt whitespace changes. this may not be the most efficient way of doing it (I don't see git-revert having a --path option), but this will do #3 above: git-format-patch --stdout --relative=cpu/ixp/npe HEAD^ | patch -d cpu/ixp/npe -R -p 1 ; git add cpu/ixp/npe; git commit --amend I'd add something like 'npe exempt' in the commit message. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH][resubmit] MPC85xx, MPC83xx: Add/Fix UPM configuration support
On Tue, 20 May 2008 10:32:24 +0300
David Saada [EMAIL PROTECTED] wrote:
Can we merge the register definition files and have a single upm_config
for mpc8[356]xx instead of duplicating it as being done here?
Not sure that I'm the right person for this job, as I don't have an 86xx
based board.
86xx can be tested by others; point here is to avoid code duplication.
Also, I'm not sure this would be a good idea: There are some
differences between the registers in these 3 families, and the header
file would look pretty ugly (many ifdefs). Even the UPM code won't be
the registers have a common base, and all the registers this patch uses
are the same on all of them. I don't see why they can't be unified
into a common include/asm-ppc/immap_8xxx.h file.
the same: for instance, the mpc85xx code scans the BR registers (which
are adjacent) to determine the UPM machine, while in the 83xx we need
to scan the lbus banks (and extract the BRs from there). This means
that we will also have many ifdefs there as well.
afaict, the code this patch introduces for 85xx is functionally
identical to that of 83xx:
* Program a UPM with the code supplied in the table.
*
* The 'dummy' variable is used to increment the MAD. 'dummy' is
@@ -133,7 +13,7 @@
*
* The value can be extracted from the base address bits of the
* Base Register (BR) associated with the specific UPM. To find
- * that BR, we need to scan all 8 BRs until we find the one that
+ * that BR, we need to scan all BRs until we find the one that
* has its MSEL bits matching the UPM we want. Once we know the
* right BR, we can extract the base address bits from it.
*
@@ -147,20 +27,20 @@
*/
void upmconfig (uint upm, uint *table, uint size)
{
- volatile immap_t *immap = (immap_t *) CFG_IMMR;
- volatile lbus83xx_t *lbus = immap-lbus;
+volatile ccsr_lbc_t *lbc = (void *)(CFG_MPC85xx_LBC_ADDR);
volatile uchar *dummy = NULL;
- const u32 msel = (upm + 4) BR_MSEL_SHIFT;/* What
the MSEL field in BRn should be */
- volatile u32 *mxmr = lbus-mamr + upm; /* Pointer to
mamr, mbmr, or mcmr */
+ const u32 msel = (upm + 4) BRx_MS_SHIFT; /* What the MSEL
field in BRn should be */
+ volatile uint *mxmr = lbc-mamr + upm; /* Pointer to mamr,
mbmr, or mcmr */
+ volatile uint *brx = lbc-br0; /* Pointer to BRx */
uint i;
/* Scan all the banks to determine the base address of the
device */ for (i = 0; i 8; i++) {
- if ((lbus-bank[i].br BR_MSEL) == msel) {
- dummy = (uchar *) (lbus-bank[i].br BR_BA);
+ if ((*brx BRx_MS_MSK) == msel) {
+ dummy = (uchar *) (*brx BRx_BA_MSK);
break;
}
+ brx += 2; /* Skip to next BRx */
}
if (!dummy) {
@@ -169,10 +49,10 @@
}
/* Set the OP field in the MxMR to write and the MAD field
to 00 */
- *mxmr = (*mxmr 0xCFC0) | 0x1000;
+ *mxmr = (*mxmr 0xCFC0) | MxMR_OP_WARR;
for (i = 0; i size; i++) {
- lbus-mdr = table[i];
+ lbc-mdr = table[i];
__asm__ __volatile__ (sync);
*dummy; /* Write the value to memory and
increment MAD */ __asm__ __volatile__ (sync);
btw, I don't see arch/powerpc/sysdev/fsl_lbc.c functionally differing
among the families either.
am I missing something?
David.
Kim
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Big white-space cleanup.
On Tue, 20 May 2008 16:50:44 +0200 Wolfgang Denk [EMAIL PROTECTED] wrote: This commit gets rid of a huge amount of silly white-space issues. Especially, all sequences of SPACEs followed by TAB characters get removed (unless they appear in print statements). Also remove all embedded vim: and vi: statements which hide indentation problems. Signed-off-by: Wolfgang Denk [EMAIL PROTECTED] --- Wolfgang, are you not working on your current head?: Applying Big white-space cleanup. error: patch failed: common/usb.c:892 error: common/usb.c: patch does not apply Patch failed at 0001. When you have resolved this problem run git-am --resolved. If you would prefer to skip this patch, instead run git-am --skip. plus, it looks like the patch is replacing tabs with spaces (see, e.g., pib_init() changes in board/freescale/mpc8349emds/pci.c). also, tools/easylogo/linux_logo.tga| Bin 19244 - 19663 bytes I don't think you meant to cleanup whitespace in binary files. :) Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH-v3] Big white-space cleanup.
On Wed, 21 May 2008 01:10:42 +0200
Wolfgang Denk [EMAIL PROTECTED] wrote:
The latest version of this patch is available for download here:
ftp://ftp.denx.de/pub/tmp/big-white-space-cleanup.patch-v.3.gz
I also checked in this patch in the master branch of the
u-boot-testing repository, so you can just pull from there for
easier testing.
minor nit in comparison, but:
Applying Big white-space cleanup.
.dotest/patch:20954: trailing whitespace.
{
.dotest/patch:20984: trailing whitespace.
.dotest/patch:21019: trailing whitespace.
ixQMgrAqmIfQueAccRegAddr[i] =
.dotest/patch:21152: trailing whitespace.
BOOL speed100,
.dotest/patch:21153: trailing whitespace.
BOOL fullDuplex,
it looks like it's in u-boot-testing that way, too - maybe you can
amend it? other than that things look clean(er):
Acked-by: Kim Phillips [EMAIL PROTECTED]
Kim
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH][resubmit] MPC85xx, MPC83xx: Add/Fix UPM configuration support
On Mon, 19 May 2008 19:05:04 +0300 David Saada [EMAIL PROTECTED] wrote: Add support for UPM configuration on the 85xx platform. In addition, on the MPC83xx, remove MPC834x precompiler condition, in order to support all MPC83xx processors. Signed-off-by: David Saada [EMAIL PROTECTED] cpu/mpc83xx/cpu.c |5 cpu/mpc85xx/cpu.c | 66 ++ include/mpc85xx.h |7 - 3 files changed, 72 insertions(+), 6 deletions(-) Can we merge the register definition files and have a single upm_config for mpc8[356]xx instead of duplicating it as being done here? Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] NAND read/write.jffs2 fix
On Tue, 13 May 2008 15:41:06 -0500
Scott Wood [EMAIL PROTECTED] wrote:
static int nand_dump(nand_info_t *nand, ulong off, int only_oob)
{
@@ -73,9 +74,9 @@ static int nand_dump(nand_info_t *nand, ulong off, int
only_oob)
while (i--) {
if (!only_oob) {
printf( \t%02x %02x %02x %02x %02x %02x %02x %02x
- %02x %02x %02x %02x %02x %02x %02x
%02x\n,
- p[0], p[1], p[2], p[3], p[4], p[5],
p[6], p[7],
- p[8], p[9], p[10], p[11], p[12], p[13],
p[14], p[15]);
+ %02x %02x %02x %02x %02x %02x %02x %02x\n,
+ p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7],
+ p[8], p[9], p[10], p[11], p[12], p[13], p[14],
p[15]);
Still exceeds 80 characters on the last line.
or use lib_generic/display_options.c:print_buffer()
Kim
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] build u-boot error: No rule to make target `.depend', needed by `_depend'.
On Thu, 15 May 2008 01:49:50 +0800 Steven Woody [EMAIL PROTECTED] wrote: Dear Denk, 1.2.0 is come frome eldk-4.1 iso file. Downloading independent u-boot seems require `git' tool which I get problem with because my office network gets many limits. Is there a http way to download u-boot? git clone http://git.denx.de/u-boot.git Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] MPC85xx: Change traps.c to not reference non-addressable memory
On Wed, 14 May 2008 13:10:04 -0500 [EMAIL PROTECTED] wrote: From: Becky Bruce [EMAIL PROTECTED] Currently, END_OF_RAM is used by the trap code to determine if we should attempt to access the stack pointer or not. However, on systems with a lot of RAM, only a subset of the RAM is guaranteed to be mapped in and accessible. Change END_OF_RAM to use get_effective_memsize() instead of using the raw ram size out of the bd. Signed-off-by: Becky Bruce [EMAIL PROTECTED] --- what, no love for 4xx, 83xx, and 74xx_7xx? can also be made a single patch for WD to apply directly. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] MPC85xx: Change traps.c to not reference non-addressable memory
On Wed, 14 May 2008 15:31:43 -0500 Becky Bruce [EMAIL PROTECTED] wrote: On May 14, 2008, at 1:57 PM, Kim Phillips wrote: On Wed, 14 May 2008 13:10:04 -0500 [EMAIL PROTECTED] wrote: From: Becky Bruce [EMAIL PROTECTED] Currently, END_OF_RAM is used by the trap code to determine if we should attempt to access the stack pointer or not. However, on systems with a lot of RAM, only a subset of the RAM is guaranteed to be mapped in and accessible. Change END_OF_RAM to use get_effective_memsize() instead of using the raw ram size out of the bd. Signed-off-by: Becky Bruce [EMAIL PROTECTED] --- what, no love for 4xx, 83xx, and 74xx_7xx? The other platforms currently set a hard limit that should still be valid - I just changed the ones that were reading memsize directly out of the bd. sure, 5xx, 82xx and 8xx are hardcoded, but 74xx_7xx (albeit only AMIGAONE), all 83xx, and all 4xx use the bd just like in your current patchseries. I'm just trying to maintain some level of consistency. can also be made a single patch for WD to apply directly. Sure, I just split it up in case there was some reason we shouldn't do it for one of them. ah, I thought you wanted individual maintainers to pick them up individually. Either way works, really. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] Proposal for u-boot-nand-flash custodian change
On Tue, 13 May 2008 09:25:22 -0600 Grant Likely [EMAIL PROTECTED] wrote: Therefore I officially propose Scott Wood as new u-boot-nand-flash custodian. I would really like to get some feedback on this. Any comments or other suggestions? Acked-by: Grant Likely [EMAIL PROTECTED] Acked-by: Kim Phillips [EMAIL PROTECTED] Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] Using uec.c and uec_phy.c
On Sat, 10 May 2008 04:24:08 -0700 (PDT) klibusel [EMAIL PROTECTED] wrote: Hi, I am using the polled uboot ethernet driver on MPC8360erdk. I have trouble sending and receiving ethernet packets. I have configured the interface as a generic MII and it detects the linking coming up. However when the QUICC engine reads TXBD and indicates TX is complete, nothing comes on the wire. This I confirmed using ethereal. Also on the RX side if connected to a PC I get RX error. I have made no changes to the orginial code. The interface is a BCM5481 on the board. Any pointer will be appreciated. you don't mention what version u-boot you're using; can you let us know if the problem exists on Wolfgang's top of git tree (currently v1.3.3-rc3-51-g65dcfa7)? Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 2/2] add MPC8343 based board mvBlueLYNX-M7
On Wed, 7 May 2008 10:36:56 -0500
Kim Phillips [EMAIL PROTECTED] wrote:
On Wed, 07 May 2008 12:01:48 +0200
André Schwarz [EMAIL PROTECTED] wrote:
I'll re-send the 23rd try after my vacation at end of may.
If the merge window will be closed at that date it's obviously bad luck.
I can make the changes, André, thanks!
hmm..made the below changes, but I don't know how to recover from:
fpga.c:55: error: ‘Altera_EP2C20_SIZE’ undeclared here (not in a function)
it seems this never built? also, we are missing a config file in the
latest submission. One more thing: please submit patches in an order
that will not break future builds during a git-bisect session, i.e.,
since I believe a single patch is less than the ML limit of 40KB, make
it a single patch, please.
Thanks,
Kim
diff --git a/board/mvblm7/Makefile b/board/mvblm7/Makefile
index 84cd14a..42e0243 100644
--- a/board/mvblm7/Makefile
+++ b/board/mvblm7/Makefile
@@ -24,8 +24,11 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(BOARD).a
-COBJS := $(BOARD).o pci.o fpga.o
+COBJS-y:= $(BOARD).o
+COBJS-$(CONFIG_PCI) += pci.o
+COBJS-$(CONFIG_FPGA) += fpga.o
+COBJS := $(COBJS-y)
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
SOBJS := $(addprefix $(obj),$(SOBJS))
diff --git a/board/mvblm7/fpga.c b/board/mvblm7/fpga.c
index 5eaa037..a60af01 100644
--- a/board/mvblm7/fpga.c
+++ b/board/mvblm7/fpga.c
@@ -32,8 +32,6 @@
#include fpga.h
#include mvblm7.h
-#ifdef CONFIG_FPGA
-
#ifdef FPGA_DEBUG
#define fpga_debug(fmt, args...) printf(%s: fmt, __func__, ##args)
#else
@@ -83,8 +81,8 @@ int fpga_config_fn(int assert, int flush, int cookie)
{
volatile immap_t *im = (volatile immap_t *)CFG_IMMR;
volatile gpio83xx_t *gpio = (volatile gpio83xx_t *)im-gpio[0];
-
u32 dvo = gpio-dat;
+
fpga_debug(SET config : %s\n, assert ? low : high);
if (assert)
dvo |= FPGA_CONFIG;
@@ -134,8 +132,8 @@ int fpga_clk_fn(int assert_clk, int flush, int cookie)
{
volatile immap_t *im = (volatile immap_t *)CFG_IMMR;
volatile gpio83xx_t *gpio = (volatile gpio83xx_t *)im-gpio[0];
-
u32 dvo = gpio-dat;
+
fpga_debug(CLOCK %s\n, assert_clk ? high : low);
if (assert_clk)
dvo |= FPGA_CCLK;
@@ -188,4 +186,3 @@ int fpga_wr_fn(void *buf, size_t len, int flush, int cookie)
return FPGA_SUCCESS;
}
-#endif
diff --git a/board/mvblm7/mvblm7.c b/board/mvblm7/mvblm7.c
index 8f8e299..7e9b71f 100644
--- a/board/mvblm7/mvblm7.c
+++ b/board/mvblm7/mvblm7.c
@@ -43,15 +43,14 @@ int fixed_sdram(void)
u32 ddr_size_log2;
msize = CFG_DDR_SIZE;
- for (ddr_size = msize 20, ddr_size_log2 = 0;
- (ddr_size 1);
- ddr_size = ddr_size1, ddr_size_log2++) {
+ for (ddr_size = msize 20, ddr_size_log2 = 0; ddr_size 1;
+ ddr_size = ddr_size 1, ddr_size_log2++)
if (ddr_size 1)
return -1;
- }
+
im-sysconf.ddrlaw[0].bar = ((CFG_DDR_SDRAM_BASE12) 0xf);
im-sysconf.ddrlaw[0].ar = LAWAR_EN | ((ddr_size_log2 - 1)
- LAWAR_SIZE);
+ LAWAR_SIZE);
im-ddr.csbnds[0].csbnds = CFG_DDR_CS0_BNDS;
im-ddr.cs_config[0] = CFG_DDR_CS0_CONFIG;
@@ -131,5 +130,4 @@ void ft_board_setup(void *blob, bd_t *bd)
ft_pci_setup(blob, bd);
#endif
}
-
#endif
diff --git a/board/mvblm7/pci.c b/board/mvblm7/pci.c
index b6453d0..72123c8 100644
--- a/board/mvblm7/pci.c
+++ b/board/mvblm7/pci.c
@@ -28,11 +28,14 @@
#include libfdt.h
#endif
#include pci.h
+#include fpga.h
#include mpc83xx.h
#include mvblm7.h
DECLARE_GLOBAL_DATA_PTR;
+extern int mvblm7_init_fpga(void);
+
/* System RAM mapped to PCI space */
#define CONFIG_PCI_SYS_MEM_BUS CFG_SDRAM_BASE
#define CONFIG_PCI_SYS_MEM_PHYSCFG_SDRAM_BASE
-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] Please pull u-boot-mpc83xx.git
Wolfgang Denk, please pull a system performance tweak: The following changes since commit 908261f3fdb418091d8c60bfbd7eb85e5869b579: Wolfgang Denk (1): Merge branch 'master' of git+ssh://10.10.0.7/home/wd/git/u-boot/master are available in the git repository at: git://git.denx.de/u-boot-mpc83xx.git master Lee Nipper (1): mpc83xx: system performance settings for MPC8349EMDS. include/configs/MPC8349EMDS.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) Thanks, Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 2/2] add MPC8343 based board mvBlueLYNX-M7
On Wed, 07 May 2008 12:01:48 +0200 André Schwarz [EMAIL PROTECTED] wrote: I'll re-send the 23rd try after my vacation at end of may. If the merge window will be closed at that date it's obviously bad luck. I can make the changes, André, thanks! Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] add config options for VSC8601 RGMII PHY - 2nd try
On Sun, 04 May 2008 12:19:32 +0200 André Schwarz [EMAIL PROTECTED] wrote: Thunderbird is configured according to to the kernel-doc page. Obviously there's something going wrong during copy+paste ... according to this: http://mbligh.org/linuxdocs/Email/Clients/Thunderbird you might be able to get away with mailing the patch as an attachment. Can you do this and try sending me the mvblm7 patch again? I'll tell you if it applies. Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] Adding a new board to the u-boot project
On Mon, 5 May 2008 11:56:57 -0700 Ronald Madrid [EMAIL PROTECTED] wrote: I'm developing a board based on the MPC8313 and want to have my code included in the u-boot project, but have a few questions. great! I have created in u-boot-1.3.2 my own folder in the board directory and all appropriate config files. I have also edited the Makefile on the top level. sounds good, you'll need to add a MAINTAINERS entry, a MAKEALL entry, and preferably add a doc/README.myboard file. Everything builds for my board's u-boot, but here are my questions. I have to create a new folder in the nand_spl/board folder as my board supports NAND flash. Is that ok? Also, to add NAND support I have to edit the cpu/mpc83xx/start.S yes file. Is this allowed? depends on the bits themselves; please send your patch for review on this list. After I get my code working is there a specific person that I forward the patches to? the 83xx specific bits (including the general board support bits) should probably go through me, and Stefan Roese can pick up your NAND-specific bits, unless Wolfgang beats us to it. Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH] mpc83xx: bump default loadaddr over fdtaddr, to 0x500000
this seems as a good compromise between human memory, typing, and last but not least, to accommodate for current and future kernel bloat. Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- include/configs/MPC8313ERDB.h |2 +- include/configs/MPC8315ERDB.h |2 +- include/configs/MPC8323ERDB.h |2 +- include/configs/MPC832XEMDS.h |2 +- include/configs/MPC8349EMDS.h |2 +- include/configs/MPC8349ITX.h |2 +- include/configs/MPC8360EMDS.h |2 +- include/configs/MPC837XEMDS.h |2 +- include/configs/MPC837XERDB.h |2 +- include/configs/sbc8349.h |2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/configs/MPC8313ERDB.h b/include/configs/MPC8313ERDB.h index 9576fa5..6eec240 100644 --- a/include/configs/MPC8313ERDB.h +++ b/include/configs/MPC8313ERDB.h @@ -543,7 +543,7 @@ #define CONFIG_UBOOTPATH u-boot.bin /* U-Boot image on TFTP server */ #define CONFIG_FDTFILE mpc8313erdb.dtb -#define CONFIG_LOADADDR20 /* default location for tftp and bootm */ +#define CONFIG_LOADADDR50 /* default location for tftp and bootm */ #define CONFIG_BOOTDELAY -1 /* -1 disables auto-boot */ #define CONFIG_BAUDRATE115200 diff --git a/include/configs/MPC8315ERDB.h b/include/configs/MPC8315ERDB.h index 432fb31..e0a887c 100644 --- a/include/configs/MPC8315ERDB.h +++ b/include/configs/MPC8315ERDB.h @@ -531,7 +531,7 @@ #define CONFIG_BAUDRATE 115200 -#define CONFIG_LOADADDR 20 /* default location for tftp and bootm */ +#define CONFIG_LOADADDR 50 /* default location for tftp and bootm */ #define CONFIG_BOOTDELAY 6 /* -1 disables auto-boot */ #undef CONFIG_BOOTARGS /* the boot command will set bootargs */ diff --git a/include/configs/MPC8323ERDB.h b/include/configs/MPC8323ERDB.h index 92d7aa4..32f57ac 100644 --- a/include/configs/MPC8323ERDB.h +++ b/include/configs/MPC8323ERDB.h @@ -568,7 +568,7 @@ #define CONFIG_UBOOTPATH u-boot.bin /* U-Boot image on TFTP server */ #define CONFIG_FDTFILE mpc832x_rdb.dtb -#define CONFIG_LOADADDR20 /* default location for tftp and bootm */ +#define CONFIG_LOADADDR50 /* default location for tftp and bootm */ #define CONFIG_BOOTDELAY -1 /* -1 disables auto-boot */ #define CONFIG_BAUDRATE115200 diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h index be2ab45..ddefa5e 100644 --- a/include/configs/MPC832XEMDS.h +++ b/include/configs/MPC832XEMDS.h @@ -572,7 +572,7 @@ #define CONFIG_BAUDRATE115200 -#define CONFIG_LOADADDR20 /* default location for tftp and bootm */ +#define CONFIG_LOADADDR50 /* default location for tftp and bootm */ #define CONFIG_BOOTDELAY 6 /* -1 disables auto-boot */ #undef CONFIG_BOOTARGS/* the boot command will set bootargs */ diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 07fefec..364ffac 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -709,7 +709,7 @@ #define CONFIG_GATEWAYIP 192.168.1.1 #define CONFIG_NETMASK 255.255.255.0 -#define CONFIG_LOADADDR20 /* default location for tftp and bootm */ +#define CONFIG_LOADADDR50 /* default location for tftp and bootm */ #define CONFIG_BOOTDELAY 6 /* -1 disables auto-boot */ #undef CONFIG_BOOTARGS/* the boot command will set bootargs */ diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h index 6b8b74d..be8850a 100644 --- a/include/configs/MPC8349ITX.h +++ b/include/configs/MPC8349ITX.h @@ -474,7 +474,7 @@ boards, we say we have two, but don't display a message if we find only one. */ #define CFG_PROMPT_HUSH_PS2 #define CFG_LOAD_ADDR 0x200 /* default load address */ -#define CONFIG_LOADADDR20 /* default location for tftp and bootm */ +#define CONFIG_LOADADDR50 /* default location for tftp and bootm */ #ifdef CONFIG_MPC8349ITX #define CFG_PROMPT MPC8349E-mITX/* Monitor Command Prompt */ diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h index 46451c4..983575e 100644 --- a/include/configs/MPC8360EMDS.h +++ b/include/configs/MPC8360EMDS.h @@ -605,7 +605,7 @@ #define CONFIG_BAUDRATE 115200 -#define CONFIG_LOADADDR 20 /* default location for tftp and bootm */ +#define CONFIG_LOADADDR 50 /* default location for tftp and bootm */ #define CONFIG_BOOTDELAY 6 /* -1 disables auto-boot */ #undef CONFIG_BOOTARGS /* the boot command will set bootargs */ diff --git a/include/configs/MPC837XEMDS.h b/include/configs/MPC837XEMDS.h index 7fc0f7e..e92493a 100644 --- a/include/configs/MPC837XEMDS.h +++ b/include/configs/MPC837XEMDS.h @@ -595,7 +595,7 @@ #define CONFIG_BAUDRATE 115200
Re: [U-Boot-Users] [PATCH] ppc: Revert patch 70431e8a that used _start instead of CFG_MONITOR_BASE
On Tue, 22 Apr 2008 07:49:57 +0200 Joakim Tjernlund [EMAIL PROTECTED] wrote: Currently WD's top of tree renders 83xx kaput. When I revert this revert plus Joakim's original 70431e8 commit, things are back to normal. I'm not going to pretend I know to fix it up correctly, so does anyone have a problem with me sending two revert patches until relocation is properly and comprehensively fixed? Strange, I got a 8321 and it worked for me. Maybe a toolchain issue? Perhaps I got something extra in my board port, dunno what though. I just reconfirmed it using WD's TOT w/gcc version 4.1.2 20070925 (Red Hat 4.1.2-27). Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] ppc: Revert patch 70431e8a that used _start instead of CFG_MONITOR_BASE
On Thu, 10 Apr 2008 19:45:02 -0500 Kim Phillips [EMAIL PROTECTED] wrote: On Wed, 9 Apr 2008 12:56:42 +0200 Stefan Roese [EMAIL PROTECTED] wrote: The patch 70431e8a7393b6b793f77957f95b999fc9a269b8 (Make MPC83xx one step closer to full relocation.) doesn't use CFG_MONITOR_BASE anymore. But on 4xx systems _start currently cannot be used for this calculation. So revert back to the original version for now. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Kim Phillips [EMAIL PROTECTED] hmm..I seem to have false-acked this due to a bug in a build script of mine. Currently WD's top of tree renders 83xx kaput. When I revert this revert plus Joakim's original 70431e8 commit, things are back to normal. I'm not going to pretend I know to fix it up correctly, so does anyone have a problem with me sending two revert patches until relocation is properly and comprehensively fixed? Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH] lib_ppc: Revert Make MPC83xx one step closer to full relocation.
This reverts commit 70431e8a7393b6b793f77957f95b999fc9a269b8 which has proven problematic getting right from the start at least on 83xx and 4xx. Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- cpu/mpc83xx/start.S | 11 --- lib_ppc/board.c |1 - 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/cpu/mpc83xx/start.S b/cpu/mpc83xx/start.S index fdf9d35..309eb30 100644 --- a/cpu/mpc83xx/start.S +++ b/cpu/mpc83xx/start.S @@ -172,11 +172,8 @@ boot_warm: /* time t 5 */ /* there and deflate the flash size back to minimal size */ /**/ bl map_flash_by_law1 - - GET_GOT /* initialize GOT access*/ - lwz r4, GOT(_start) - addi r4, r4, -EXC_OFF_SYS_RESET - + lis r4, (CFG_MONITOR_BASE)@h + ori r4, r4, (CFG_MONITOR_BASE)@l addi r5, r4, in_flash - _start + EXC_OFF_SYS_RESET mtlr r5 blr @@ -875,8 +872,8 @@ relocate_code: mr r10, r5 /* Save copy of Destination Address */ mr r3, r5 /* Destination Address */ - lwz r4, GOT(_start) - addir4, r4, -EXC_OFF_SYS_RESET + lis r4, [EMAIL PROTECTED] /* Source Address */ + ori r4, r4, [EMAIL PROTECTED] lwz r5, GOT(__init_end) sub r5, r5, r4 li r6, CFG_CACHELINE_SIZE /* Cache Line Size */ diff --git a/lib_ppc/board.c b/lib_ppc/board.c index b2bc4eb..1b8a872 100644 --- a/lib_ppc/board.c +++ b/lib_ppc/board.c @@ -124,7 +124,6 @@ DECLARE_GLOBAL_DATA_PTR; #define CFG_MEM_TOP_HIDE 0 #endif -extern ulong _start; extern ulong __init_end; extern ulong _end; ulong monitor_flash_len; -- 1.5.5 - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] fix system config overwrite @ MPC834x
On Fri, 18 Apr 2008 10:48:51 +0200 Andre Schwarz [EMAIL PROTECTED] wrote: Kim, doing a git-pull gives Already up-to-date. The patch is produced with git-diff --patch-with-stat cpu/mpc83xx/cpu_init.c using git-commit and git-format-patch is recommended, but that's probably not the problem here. Have you followed the instructions for Thunderbird in linux-2.6/Documentation/email-clients.txt? You can test by using git-am on patches you email yourself. Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] What methods of software authentication does U-Boot support?
On Fri, 18 Apr 2008 12:01:38 -0500 [EMAIL PROTECTED] wrote: Goal: U-Boot will run only software that has been authenticated to be from the system's producer. --- A Potential Authentication Method --- The producer of the system generates a cryptographic [private-key, public-key] pair, storing the public-key on the same media as U-Boot (i.e. NOR flash; perhaps as a read-only environment variable) on all systems and keeping the private-key hidden at a secure site. A hash of the software is generated, encrypted with the private key and shipped with the software. U-Boot reads the private-key encrypted hash and decodes it with its public-key. U-Boot loads the software and generates the hash. If both hashes match, the software is authenticated and U-Boot executes the authenticated software. --- Comment --- U-Boot obviously supports loading and verification of the generated hash, but I haven't been able to locate public-key cryptographic or other authentication support in U-Boot. Perhaps, it is available as a loadable (stand-alone) module? Any comments or suggestions? this patch taps into openssl: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/23977 or you might want to reuse some of linux' crypto library code. Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 1/2] add MPC8343 based board mvBlueLYNX-M7 aka mvblm7
On Fri, 11 Apr 2008 22:02:38 +0200
André Schwarz [EMAIL PROTECTED] wrote:
Kim,
please review this resubmitted patch with changes as you have requested :
- coding style issues
- Makefile
- Maintainer
- common mpc83xx PCI code
- added README.mvblm7
Hello André, thanks, looks generally good, but..
+fpga_debug(%s:%d: Initialize FPGA interface (relocation offset =
0x%.8lx)\n,
unfortunately, both messages are linewrapped:
Applying add MPC8343 based board mvBlueLYNX-M7 aka mvblm7
fatal: corrupt patch at line 8
Patch failed at 0001.
When you have resolved this problem run git-am --resolved.
If you would prefer to skip this patch, instead run git-am --skip.
Applying add MPC8343 based board mvBlueLYNX-M7 aka mvblm7
.dotest/patch:10: trailing whitespace.
setenv bootdtb bootm \${kernel_boot} \${mv_initrd_addr_ram}
fatal: corrupt patch at line 11
Patch failed at 0001.
When you have resolved this problem run git-am --resolved.
If you would prefer to skip this patch, instead run git-am --skip.
please reference linux-2.6/Documentation/email-clients.txt to help
resolve this.
Kim
-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] System hangs while starting: get clone of u-boot-at91.git - part 2 of 2
On Fri, 11 Apr 2008 16:20:00 -0500 [EMAIL PROTECTED] wrote: I did a clone of the same git repository without any problems earlier today, except it wouldn't build properly. Any suggestions about what is wrong with the clone attempt and what can be done to fix it? I'd have said use the git: protocol, but that doesn't seem to help either: Initialized empty Git repository in /home/kim/git/hmm.git/.git/ git.denx.de[0: 0.0.0.1]: errno=Success fatal: unable to connect a socket (Success) fetch-pack from 'git://git.denx.de/u-boot.git' failed. maybe this has something to do with denx.de's new git server. I'll fwd this to root. Kim p.s. I suspect if you update your git, it'll error out without hanging. - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] System hangs while starting: get clone of u-boot-at91.git - part 2 of 2
On Fri, 11 Apr 2008 23:40:37 +0200 Wolfgang Denk [EMAIL PROTECTED] wrote: ... or simply work, at least with git protocol. ok, it works when I s/git.denx.de/www.denx.de/, using the git protocol. This might have something to do with our firewall though. Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] Please pull u-boot-mpc83xx.git - small fixes
The following changes since commit 950a392464e616b4590bc4501be46e2d7d162dea: Wolfgang Denk (1): Revert merge of git://www.denx.de/git/u-boot-arm, commit 62479b18: are available in the git repository at: git://www.denx.de/git/u-boot-mpc83xx.git Dave Liu (2): mpc83xx: Fix the SATA clock setting of 837x targets mpc83xx: Fix the bug of serdes initialization Jean-Christophe PLAGNIOL-VILLARD (1): mpc837xerdb: Fix warning: implicit declaration of function 'fdt_fixup_dr_usb' Lee Nipper (1): mpc83xx: Update DIMM data bus width test to support 40-bit width board/freescale/mpc837xemds/mpc837xemds.c |2 +- board/freescale/mpc837xerdb/mpc837xerdb.c |2 +- cpu/mpc83xx/spd_sdram.c |4 ++-- include/configs/MPC837XEMDS.h |2 +- include/configs/MPC837XERDB.h |2 +- 5 files changed, 6 insertions(+), 6 deletions(-) Thanks, Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] ppc: Revert patch 70431e8a that used _start instead of CFG_MONITOR_BASE
On Wed, 9 Apr 2008 12:56:42 +0200 Stefan Roese [EMAIL PROTECTED] wrote: The patch 70431e8a7393b6b793f77957f95b999fc9a269b8 (Make MPC83xx one step closer to full relocation.) doesn't use CFG_MONITOR_BASE anymore. But on 4xx systems _start currently cannot be used for this calculation. So revert back to the original version for now. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Kim Phillips [EMAIL PROTECTED] Kim - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] mpc837xerdb: Fix warning: implicit declaration of function 'fdt_fixup_dr_usb'
On Wed, 2 Apr 2008 13:41:21 +0200 Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED] wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED] Acked-by: Kim Phillips [EMAIL PROTECTED] Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Add Vitesse 8601 support to TSEC driver
On Tue, 01 Apr 2008 15:33:10 +0200 Andre Schwarz [EMAIL PROTECTED] wrote: I would expect something like if ( priv-flags TSEC_REDUCED ) regs-ecntrl |= ECNTRL_RPM; yeah, that register should be r/o.. @Kim : Did you ever run a MPC834x with a RGMII PHY ? Is it known to work ? 834x? I haven't, but I also haven't a reason why it would not work :) Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] mpc83xx: Fix the bug of serdes initialization
On Mon, 31 Mar 2008 17:05:12 +0800 Dave Liu [EMAIL PROTECTED] wrote: Currently the serdes will not be initializated due to the partid's error. Signed-off-by: Dave Liu [EMAIL PROTECTED] --- board/freescale/mpc837xemds/mpc837xemds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by: Kim Phillips [EMAIL PROTECTED] Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Add Vitesse 8601 support to TSEC driver
On Mon, 31 Mar 2008 10:01:34 -0400
Ben Warren [EMAIL PROTECTED] wrote:
Tor Krill wrote:
Add phy_info for Vitesse VSC8601.
Add config option, CFG_VSC8601_SKEWFIX, to enable RGMII skew timing
compensation.
Signed-off-by: Tor Krill [EMAIL PROTECTED]
Acked-by: Ben Warren [EMAIL PROTECTED]
I don't have a Vitesse 8601, so technically I can't ack it, but I can:
Reviewed-by: Kim Phillips [EMAIL PROTECTED]
minor nit: it would be nice if the following:
+#ifdef CFG_VSC8601_SKEWFIX
+
{MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL},
+#endif
were made to have spaces after commas, and flow onto a separate
line so as to not be a 96 char line..
Kim
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 1/3] QE IO: Add initial data to pin configuration
On Mon, 31 Mar 2008 15:13:15 +0300
David Saada [EMAIL PROTECTED] wrote:
On the MPC83xx MPC85xx architectures that have QE, add initial data to
the pin configuration table (qe_iop_conf_tab).
This is relevant for GPIO pins defined as output. One can setup a value
of -1 to leave the value unchanged.
In addition, add I/O pin read write functions.
Signed-off-by: David Saada [EMAIL PROTECTED]
cpu/mpc83xx/cpu_init.c |7 ++---
where's the --- line?
cpu/mpc83xx/qe_io.c| 59
-
this patch is seriously line wrapped..and therefore unapplicable.
cpu/mpc85xx/cpu_init.c |7 ++---
cpu/mpc85xx/qe_io.c| 58
++--
include/ioports.h |8 ++
5 files changed, 118 insertions(+), 21 deletions(-)
--- a/include/ioports.h 2008-03-28 01:49:12.0 +0200
+++ b/include/ioports.h 2008-03-30 16:11:09.514274000 +0300
@@ -60,6 +60,14 @@ typedef struct {
int dir;
int open_drain;
int assign;
+ int data;
} qe_iop_conf_t;
#define QE_IOP_TAB_END (-1)
+
+void qe_config_iopin(u8 port, u8 pin, int dir, int open_drain, int
assign,
+ int data);
+void qe_read_iopin(u8 port, u8 pin, int *data);
+void qe_write_iopin(u8 port, u8 pin, int data);
+
+
--- a/cpu/mpc85xx/cpu_init.c 2008-03-28 01:49:12.0 +0200
+++ b/cpu/mpc85xx/cpu_init.c 2008-03-30 15:42:32.913152000 +0300
@@ -39,15 +39,13 @@ DECLARE_GLOBAL_DATA_PTR;
#ifdef CONFIG_QE
extern qe_iop_conf_t qe_iop_conf_tab[];
-extern void qe_config_iopin(u8 port, u8 pin, int dir,
- int open_drain, int assign);
extern void qe_init(uint qe_base);
extern void qe_reset(void);
static void config_qe_ioports(void)
{
u8 port, pin;
- int dir, open_drain, assign;
+ int dir, open_drain, assign, data;
int i;
for (i = 0; qe_iop_conf_tab[i].assign != QE_IOP_TAB_END; i++) {
@@ -56,7 +54,8 @@ static void config_qe_ioports(void)
dir = qe_iop_conf_tab[i].dir;
open_drain = qe_iop_conf_tab[i].open_drain;
assign = qe_iop_conf_tab[i].assign;
- qe_config_iopin(port, pin, dir, open_drain, assign);
+ data= qe_iop_conf_tab[i].data;
+ qe_config_iopin(port, pin, dir, open_drain, assign,
data);
}
}
#endif
--- a/cpu/mpc85xx/qe_io.c 2008-03-28 01:49:12.0 +0200
+++ b/cpu/mpc85xx/qe_io.c 2008-03-30 15:44:56.961332000 +0300
@@ -27,16 +27,30 @@
#if defined(CONFIG_QE)
#define NUM_OF_PINS 32
-void qe_config_iopin(u8 port, u8 pin, int dir, int open_drain, int
assign)
+void qe_config_iopin(u8 port, u8 pin, int dir, int open_drain, int
assign,
+ int data)
{
u32 pin_2bit_mask;
u32 pin_2bit_dir;
u32 pin_2bit_assign;
u32 pin_1bit_mask;
u32 tmp_val;
- volatile ccsr_gur_t *gur = (void *)(CFG_MPC85xx_GUTS_ADDR);
- volatile par_io_t *par_io = (volatile par_io_t *)
- (gur-qe_par_io);
+ ccsr_gur_t *gur = (void *)(CFG_MPC85xx_GUTS_ADDR);
+ par_io_t*par_io = (par_io_t *) (gur-qe_par_io);
+
+ /* Calculate pin location for 1bit mask */
+ pin_1bit_mask = (u32)(1 (NUM_OF_PINS - (pin+1)));
drop the innermost parens, add spaces around +. Is the cast really
needed?
+ /* Setup the data */
+ if ((data != -1) /* Don't leave unchanged */
+ (assign == 0) /* GPIO */
+ (dir 1)) {/* Has output */
alignment
+ tmp_val = in_be32(par_io[port].cpdat);
+ if (data)
+ out_be32(par_io[port].cpdat, pin_1bit_mask |
tmp_val);
+ else
+ out_be32(par_io[port].cpdat, ~pin_1bit_mask
tmp_val);
+ }
how about something like:
if (data)
tmp_val |= pin_1bit_mask;
else
tmp_val = ~pin_1bit_mask;
out_be32(.., tmp_val);
/* Caculate pin location and 2bit mask and dir */
pin_2bit_mask = (u32)(0x3
(NUM_OF_PINS-(pin%(NUM_OF_PINS/2)+1)*2));
@@ -55,9 +69,6 @@ void qe_config_iopin(u8 port, u8 pin, in
out_be32(par_io[port].cpdir1, pin_2bit_dir | tmp_val);
}
- /* Calculate pin location for 1bit mask */
- pin_1bit_mask = (u32)(1 (NUM_OF_PINS - (pin+1)));
-
/* Setup the open drain */
tmp_val = in_be32(par_io[port].cpodr);
if (open_drain)
@@ -82,4 +93,37 @@ void qe_config_iopin(u8 port, u8 pin, in
}
}
+void qe_read_iopin(u8 port, u8 pin, int *data)
+{
+ u32 pin_1bit_mask;
[U-Boot-Users] [PATCH 1/3] mpc83xx: unreinvent mem_clk
delete ddr_clk and use mem_clk instead. Rename other ddr_*_clk to
mem_*_clk for consistency's sake.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
cpu/mpc83xx/spd_sdram.c | 10 +-
cpu/mpc83xx/speed.c | 16
include/asm-ppc/global_data.h |3 +--
3 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/cpu/mpc83xx/spd_sdram.c b/cpu/mpc83xx/spd_sdram.c
index 0acca47..c9151d7 100644
--- a/cpu/mpc83xx/spd_sdram.c
+++ b/cpu/mpc83xx/spd_sdram.c
@@ -78,12 +78,12 @@ extern int dma_xfer(void *dest, uint count, void *src);
int
picos_to_clk(int picos)
{
- unsigned int ddr_bus_clk;
+ unsigned int mem_bus_clk;
int clks;
- ddr_bus_clk = gd-ddr_clk 1;
- clks = picos / (10 / (ddr_bus_clk / 1000));
- if (picos % (10 / (ddr_bus_clk / 1000)) != 0)
+ mem_bus_clk = gd-mem_clk 1;
+ clks = picos / (10 / (mem_bus_clk / 1000));
+ if (picos % (10 / (mem_bus_clk / 1000)) != 0)
clks++;
return clks;
@@ -313,7 +313,7 @@ long int spd_sdram()
debug(DDR:Module maximum data rate is: %dMhz\n, max_data_rate);
- ddrc_clk = gd-ddr_clk / 100;
+ ddrc_clk = gd-mem_clk / 100;
effective_data_rate = 0;
if (max_data_rate = 390 max_data_rate 460) { /* it is DDR 400 */
diff --git a/cpu/mpc83xx/speed.c b/cpu/mpc83xx/speed.c
index f598699..16145dd 100644
--- a/cpu/mpc83xx/speed.c
+++ b/cpu/mpc83xx/speed.c
@@ -122,9 +122,9 @@ int get_clocks(void)
u32 enc_clk;
u32 lbiu_clk;
u32 lclk_clk;
- u32 ddr_clk;
+ u32 mem_clk;
#if defined(CONFIG_MPC8360)
- u32 ddr_sec_clk;
+ u32 mem_sec_clk;
#endif
#if defined(CONFIG_MPC8360) || defined(CONFIG_MPC832X)
u32 qepmf;
@@ -400,11 +400,11 @@ int get_clocks(void)
return -12;
}
- ddr_clk = csb_clk *
+ mem_clk = csb_clk *
(1 + ((im-reset.rcwl HRCWL_DDRCM) HRCWL_DDRCM_SHIFT));
corepll = (im-reset.rcwl HRCWL_COREPLL) HRCWL_COREPLL_SHIFT;
#if defined(CONFIG_MPC8360)
- ddr_sec_clk = csb_clk * (1 +
+ mem_sec_clk = csb_clk * (1 +
((im-reset.rcwl HRCWL_LBIUCM) HRCWL_LBIUCM_SHIFT));
#endif
@@ -466,9 +466,9 @@ int get_clocks(void)
gd-enc_clk = enc_clk;
gd-lbiu_clk = lbiu_clk;
gd-lclk_clk = lclk_clk;
- gd-ddr_clk = ddr_clk;
+ gd-mem_clk = mem_clk;
#if defined(CONFIG_MPC8360)
- gd-ddr_sec_clk = ddr_sec_clk;
+ gd-mem_sec_clk = mem_sec_clk;
#endif
#if defined(CONFIG_MPC8360) || defined(CONFIG_MPC832X)
gd-qe_clk = qe_clk;
@@ -508,9 +508,9 @@ int do_clocks (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
#endif
printf( Local Bus Controller:%4d MHz\n, gd-lbiu_clk / 100);
printf( Local Bus: %4d MHz\n, gd-lclk_clk / 100);
- printf( DDR: %4d MHz\n, gd-ddr_clk / 100);
+ printf( DDR: %4d MHz\n, gd-mem_clk / 100);
#if defined(CONFIG_MPC8360)
- printf( DDR Secondary: %4d MHz\n, gd-ddr_sec_clk / 100);
+ printf( DDR Secondary: %4d MHz\n, gd-mem_sec_clk / 100);
#endif
printf( SEC: %4d MHz\n, gd-enc_clk / 100);
printf( I2C1:%4d MHz\n, gd-i2c1_clk / 100);
diff --git a/include/asm-ppc/global_data.h b/include/asm-ppc/global_data.h
index b43dba3..9ccf7d6 100644
--- a/include/asm-ppc/global_data.h
+++ b/include/asm-ppc/global_data.h
@@ -74,7 +74,6 @@ typedef struct global_data {
u32 enc_clk;
u32 lbiu_clk;
u32 lclk_clk;
- u32 ddr_clk;
u32 pci_clk;
#if defined(CONFIG_MPC837X)
u32 pciexp1_clk;
@@ -84,7 +83,7 @@ typedef struct global_data {
u32 sata_clk;
#endif
#if defined(CONFIG_MPC8360)
- u32 ddr_sec_clk;
+ u32 mem_sec_clk;
#endif /* CONFIG_MPC8360 */
#endif
#if defined(CONFIG_MPC83XX) || defined(CONFIG_MPC85xx) ||
defined(CONFIG_MPC86xx)
--
1.5.4.4.481.g5075
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH 2/3] mpc83xx: display ddr frequency in board_add_ram_info banner
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
cpu/mpc83xx/spd_sdram.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/cpu/mpc83xx/spd_sdram.c b/cpu/mpc83xx/spd_sdram.c
index c9151d7..97ac7bb 100644
--- a/cpu/mpc83xx/spd_sdram.c
+++ b/cpu/mpc83xx/spd_sdram.c
@@ -34,10 +34,13 @@
#include asm/mmu.h
#include spd_sdram.h
+DECLARE_GLOBAL_DATA_PTR;
+
void board_add_ram_info(int use_default)
{
volatile immap_t *immap = (immap_t *) CFG_IMMR;
volatile ddr83xx_t *ddr = immap-ddr;
+ char buf[32];
printf( (DDR%d, ((ddr-sdram_cfg SDRAM_CFG_SDRAM_TYPE_MASK)
SDRAM_CFG_SDRAM_TYPE_SHIFT) - 1);
@@ -48,9 +51,11 @@ void board_add_ram_info(int use_default)
puts(, 64-bit);
if (ddr-sdram_cfg SDRAM_CFG_ECC_EN)
- puts(, ECC on));
+ puts(, ECC on);
else
- puts(, ECC off));
+ puts(, ECC off);
+
+ printf(, %s MHz), strmhz(buf, gd-mem_clk));
#if defined(CFG_LB_SDRAM) defined(CFG_LBC_SDRAM_SIZE)
puts(\nSDRAM: );
@@ -60,8 +65,6 @@ void board_add_ram_info(int use_default)
#ifdef CONFIG_SPD_EEPROM
-DECLARE_GLOBAL_DATA_PTR;
-
#if defined(CONFIG_DDR_ECC) !defined(CONFIG_ECC_INIT_VIA_DDRC)
extern void dma_init(void);
extern uint dma_check(void);
--
1.5.4.4.481.g5075
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH 3/3] mpc83xx: cleanup System Part and Revision ID Register (SPRIDR) code
in the spirit of commit 1ced121600b2060ab2ff9f0fddd9421fd70a0dc6,
85xx's Update SVR numbers to expand support, simplify SPRIDR processing
and processor ID display. Add REVID_{MAJ,MIN}OR macros to make
REVID dependent code simpler. Also added PARTID_NO_E and IS_E_PROCESSOR
convenience macros.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
board/freescale/mpc8360emds/mpc8360emds.c | 11 +--
board/freescale/mpc837xerdb/mpc837xerdb.c | 15 +--
cpu/mpc83xx/cpu.c | 169 -
include/mpc83xx.h | 91 +---
4 files changed, 84 insertions(+), 202 deletions(-)
diff --git a/board/freescale/mpc8360emds/mpc8360emds.c
b/board/freescale/mpc8360emds/mpc8360emds.c
index d90cdb3..2119320 100644
--- a/board/freescale/mpc8360emds/mpc8360emds.c
+++ b/board/freescale/mpc8360emds/mpc8360emds.c
@@ -98,11 +98,8 @@ int board_early_init_f(void)
/* Enable flash write */
bcsr[0xa] = ~0x04;
- /* Disable G1TXCLK, G2TXCLK h/w buffers (rev.2 h/w bug workaround) */
- if (immr-sysconf.spridr == SPR_8360_REV20 ||
- immr-sysconf.spridr == SPR_8360E_REV20 ||
- immr-sysconf.spridr == SPR_8360_REV21 ||
- immr-sysconf.spridr == SPR_8360E_REV21)
+ /* Disable G1TXCLK, G2TXCLK h/w buffers (rev.2.x h/w bug workaround) */
+ if (REVID_MAJOR(immr-sysconf.spridr) == 2)
bcsr[0xe] = 0x30;
/* Enable second UART */
@@ -308,8 +305,8 @@ void ft_board_setup(void *blob, bd_t *bd)
* if on mpc8360ea rev. 2.1,
* change both ucc phy-connection-types from rgmii-id to rgmii-rxid
*/
- if (immr-sysconf.spridr == SPR_8360_REV21 ||
- immr-sysconf.spridr == SPR_8360E_REV21) {
+ if ((REVID_MAJOR(immr-sysconf.spridr) == 2)
+ (REVID_MINOR(immr-sysconf.spridr) == 1)) {
int nodeoffset;
const char *prop;
int path;
diff --git a/board/freescale/mpc837xerdb/mpc837xerdb.c
b/board/freescale/mpc837xerdb/mpc837xerdb.c
index 83fb60d..e054f4e 100644
--- a/board/freescale/mpc837xerdb/mpc837xerdb.c
+++ b/board/freescale/mpc837xerdb/mpc837xerdb.c
@@ -140,24 +140,21 @@ int board_early_init_f(void)
u32 spridr = in_be32(immr-sysconf.spridr);
/* we check only part num, and don't look for CPU revisions */
- switch (spridr 16) {
- case SPR_8379E_REV10 16:
- case SPR_8379_REV10 16:
+ switch (PARTID_NO_E(spridr)) {
+ case SPR_8377:
fsl_setup_serdes(CONFIG_FSL_SERDES1, FSL_SERDES_PROTO_SATA,
FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
- fsl_setup_serdes(CONFIG_FSL_SERDES2, FSL_SERDES_PROTO_SATA,
+ fsl_setup_serdes(CONFIG_FSL_SERDES2, FSL_SERDES_PROTO_PEX,
FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
break;
- case SPR_8378E_REV10 16:
- case SPR_8378_REV10 16:
+ case SPR_8378:
fsl_setup_serdes(CONFIG_FSL_SERDES1, FSL_SERDES_PROTO_PEX,
FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
break;
- case SPR_8377E_REV10 16:
- case SPR_8377_REV10 16:
+ case SPR_8379:
fsl_setup_serdes(CONFIG_FSL_SERDES1, FSL_SERDES_PROTO_SATA,
FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
- fsl_setup_serdes(CONFIG_FSL_SERDES2, FSL_SERDES_PROTO_PEX,
+ fsl_setup_serdes(CONFIG_FSL_SERDES2, FSL_SERDES_PROTO_SATA,
FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
break;
default:
diff --git a/cpu/mpc83xx/cpu.c b/cpu/mpc83xx/cpu.c
index bff3cef..c878268 100644
--- a/cpu/mpc83xx/cpu.c
+++ b/cpu/mpc83xx/cpu.c
@@ -35,6 +35,32 @@
DECLARE_GLOBAL_DATA_PTR;
+struct cpu_type {
+ char name[15];
+ u32 partid;
+};
+
+#define CPU_TYPE_ENTRY(x) {#x, SPR_##x}
+
+struct cpu_type cpu_type_list [] = {
+ CPU_TYPE_ENTRY(8311),
+ CPU_TYPE_ENTRY(8313),
+ CPU_TYPE_ENTRY(8314),
+ CPU_TYPE_ENTRY(8315),
+ CPU_TYPE_ENTRY(8321),
+ CPU_TYPE_ENTRY(8323),
+ CPU_TYPE_ENTRY(8343),
+ CPU_TYPE_ENTRY(8347_TBGA_),
+ CPU_TYPE_ENTRY(8347_PBGA_),
+ CPU_TYPE_ENTRY(8349),
+ CPU_TYPE_ENTRY(8358_TBGA_),
+ CPU_TYPE_ENTRY(8358_PBGA_),
+ CPU_TYPE_ENTRY(8360),
+ CPU_TYPE_ENTRY(8377),
+ CPU_TYPE_ENTRY(8378),
+ CPU_TYPE_ENTRY(8379),
+};
+
int checkcpu(void)
{
volatile immap_t *immr;
@@ -42,6 +68,7 @@ int checkcpu(void)
u32 pvr = get_pvr();
u32 spridr;
char buf[32];
+ int i;
immr = (immap_t *)CFG_IMMR;
@@ -69,130 +96,26 @@ int checkcpu(void)
}
spridr = immr-sysconf.spridr;
- switch(spridr) {
- case SPR_8349E_REV10:
- case SPR_8349E_REV11:
- case SPR_8349E_REV31:
- puts(MPC8349E
[U-Boot-Users] [PATCH] mpc83xx: enable the SATA interface on mpc8315 rdb and mpc837x rdb boards
Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- include/configs/MPC8315ERDB.h | 23 +++ include/configs/MPC837XERDB.h | 23 +++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/include/configs/MPC8315ERDB.h b/include/configs/MPC8315ERDB.h index af78726..432fb31 100644 --- a/include/configs/MPC8315ERDB.h +++ b/include/configs/MPC8315ERDB.h @@ -349,6 +349,29 @@ #define CONFIG_ETHPRIMEeTSEC1 /* + * SATA + */ +#define CONFIG_LIBATA +#define CONFIG_FSL_SATA + +#define CFG_SATA_MAX_DEVICE2 +#define CONFIG_SATA1 +#define CFG_SATA1_OFFSET 0x18000 +#define CFG_SATA1 (CFG_IMMR + CFG_SATA1_OFFSET) +#define CFG_SATA1_FLAGSFLAGS_DMA +#define CONFIG_SATA2 +#define CFG_SATA2_OFFSET 0x19000 +#define CFG_SATA2 (CFG_IMMR + CFG_SATA2_OFFSET) +#define CFG_SATA2_FLAGSFLAGS_DMA + +#ifdef CONFIG_FSL_SATA +#define CONFIG_LBA48 +#define CONFIG_CMD_SATA +#define CONFIG_DOS_PARTITION +#define CONFIG_CMD_EXT2 +#endif + +/* * Environment */ #ifndef CFG_RAMBOOT diff --git a/include/configs/MPC837XERDB.h b/include/configs/MPC837XERDB.h index 90812e9..eaac525 100644 --- a/include/configs/MPC837XERDB.h +++ b/include/configs/MPC837XERDB.h @@ -416,6 +416,29 @@ #endif /* + * SATA + */ +#define CONFIG_LIBATA +#define CONFIG_FSL_SATA + +#define CFG_SATA_MAX_DEVICE2 +#define CONFIG_SATA1 +#define CFG_SATA1_OFFSET 0x18000 +#define CFG_SATA1 (CFG_IMMR + CFG_SATA1_OFFSET) +#define CFG_SATA1_FLAGSFLAGS_DMA +#define CONFIG_SATA2 +#define CFG_SATA2_OFFSET 0x19000 +#define CFG_SATA2 (CFG_IMMR + CFG_SATA2_OFFSET) +#define CFG_SATA2_FLAGSFLAGS_DMA + +#ifdef CONFIG_FSL_SATA +#define CONFIG_LBA48 +#define CONFIG_CMD_SATA +#define CONFIG_DOS_PARTITION +#define CONFIG_CMD_EXT2 +#endif + +/* * Environment */ #ifndef CFG_RAMBOOT -- 1.5.5.rc0.16.g02b00 - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 3/3] mpc83xx: cleanup System Part and Revision ID Register (SPRIDR) code
On Fri, 28 Mar 2008 21:01:30 +0100 Joakim Tjernlund [EMAIL PROTECTED] wrote: BTW, what happened to relocation stuff Grant was doing? It is still disabled, I never had any problems so perhaps time to turn it on again? it might even make u-boot smaller once all the old manuel relocation code has been properly disabled. beats me. I'm all for it, but I think we're still supposed to support a wide range of toolchain versions (the reason Grant's stuff got reverted). Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Make MPC83xx one step closer to full relocation.
On Fri, 28 Mar 2008 15:41:25 +0100 Joakim Tjernlund [EMAIL PROTECTED] wrote: Remove a few absolute references to CFG_MONITOR_BASE for ppc/mpc83xx and use GOT relative reference. --- cpu/mpc83xx/start.S | 11 +++ lib_ppc/board.c |3 ++- 2 files changed, 9 insertions(+), 5 deletions(-) Joakim, this patch is missing your signoff, and doesn't apply cleanly (even adds whitespace). btw, shouldn't it fix up the other ppc start.S files? Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] Please pull u-boot-mpc83xx.git
Wolfgang D., please pull SATA configuration patches for 8315 and 837x boards, a cleanup of the 83xx SPRIDR code, and some 8323 rdb fixes: The following changes since commit 74d1e66d22dac91388bc538b2fe19f735edc5b82: Bartlomiej Sieka (1): Fix host tool build breakage, take two are available in the git repository at: git://www.denx.de/git/u-boot-mpc83xx.git master Dave Liu (2): mpc83xx: initialize serdes for MPC837xEMDS boards mpc83xx: enable the SATA interface on mpc837xemds board Kim Phillips (4): mpc83xx: enable the SATA interface on mpc8315 rdb and mpc837x rdb boards mpc83xx: unreinvent mem_clk mpc83xx: display ddr frequency in board_add_ram_info banner mpc83xx: cleanup System Part and Revision ID Register (SPRIDR) code Michael Barkowski (2): mpc8323erdb: define CONFIG_PCI_SKIP_HOST_BRIDGE mpc8323erdb: fix EEPROM page size and get MAC from EEPROM board/freescale/mpc8323erdb/mpc8323erdb.c | 34 ++ board/freescale/mpc8360emds/mpc8360emds.c | 11 +-- board/freescale/mpc837xemds/mpc837xemds.c | 30 + board/freescale/mpc837xerdb/mpc837xerdb.c | 15 +-- cpu/mpc83xx/cpu.c | 166 - cpu/mpc83xx/spd_sdram.c | 21 ++-- cpu/mpc83xx/speed.c | 16 ++-- include/asm-ppc/global_data.h |3 +- include/configs/MPC8315ERDB.h | 23 include/configs/MPC8323ERDB.h | 12 ++- include/configs/MPC837XEMDS.h | 28 + include/configs/MPC837XERDB.h | 23 include/mpc83xx.h | 91 +--- lib_ppc/board.c |2 +- 14 files changed, 250 insertions(+), 225 deletions(-) Thanks, Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Make MPC83xx one step closer to full relocation.
On Sat, 29 Mar 2008 00:47:01 +0100 Joakim Tjernlund [EMAIL PROTECTED] wrote: -Original Message- From: Kim Phillips [mailto:[EMAIL PROTECTED] Sent: den 29 mars 2008 00:33 To: Joakim Tjernlund Cc: u-boot-users@lists.sourceforge.net Subject: Re: [PATCH] Make MPC83xx one step closer to full relocation. On Fri, 28 Mar 2008 15:41:25 +0100 Joakim Tjernlund [EMAIL PROTECTED] wrote: Remove a few absolute references to CFG_MONITOR_BASE for ppc/mpc83xx and use GOT relative reference. --- cpu/mpc83xx/start.S | 11 +++ lib_ppc/board.c |3 ++- 2 files changed, 9 insertions(+), 5 deletions(-) Joakim, this patch is missing your signoff, and doesn't apply cleanly (even adds whitespace). It doesn't apply because you have been sitting on it for too long :) I sent long ago and you said would apply it in the next merge window, but seems to have forgotten about it. Sorry for the whitespace. I am still on the last u-boot release so I am afraid I can't do much about it ATM. I hope you can clean up the WS. Signed-off-by: Joakim Tjernlund [EMAIL PROTECTED] ok, I can add it now. Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] Please pull u-boot-mpc83xx.git
On Fri, 28 Mar 2008 18:49:59 -0500 Kim Phillips [EMAIL PROTECTED] wrote: Wolfgang D., please pull SATA configuration patches for 8315 and 837x boards, a cleanup of the 83xx SPRIDR code, and some 8323 rdb fixes: ok, I've pushed Joakim's relocation fixes patch. New summary looks like: Dave Liu (2): mpc83xx: initialize serdes for MPC837xEMDS boards mpc83xx: enable the SATA interface on mpc837xemds board Joakim Tjernlund (1): Make MPC83xx one step closer to full relocation. Kim Phillips (4): mpc83xx: enable the SATA interface on mpc8315 rdb and mpc837x rdb boards mpc83xx: unreinvent mem_clk mpc83xx: display ddr frequency in board_add_ram_info banner mpc83xx: cleanup System Part and Revision ID Register (SPRIDR) code Michael Barkowski (2): mpc8323erdb: define CONFIG_PCI_SKIP_HOST_BRIDGE mpc8323erdb: fix EEPROM page size and get MAC from EEPROM board/freescale/mpc8323erdb/mpc8323erdb.c | 34 ++ board/freescale/mpc8360emds/mpc8360emds.c | 11 +-- board/freescale/mpc837xemds/mpc837xemds.c | 30 + board/freescale/mpc837xerdb/mpc837xerdb.c | 15 +-- cpu/mpc83xx/cpu.c | 166 - cpu/mpc83xx/spd_sdram.c | 21 ++-- cpu/mpc83xx/speed.c | 16 ++-- cpu/mpc83xx/start.S | 11 ++- include/asm-ppc/global_data.h |3 +- include/configs/MPC8315ERDB.h | 23 include/configs/MPC8323ERDB.h | 12 ++- include/configs/MPC837XEMDS.h | 28 + include/configs/MPC837XERDB.h | 23 include/mpc83xx.h | 91 +--- lib_ppc/board.c |5 +- 15 files changed, 259 insertions(+), 230 deletions(-) Thanks, Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] board config u-boot
On Thu, 27 Mar 2008 18:28:57 +0100 karim sahli [EMAIL PROTECTED] wrote: hi! i want to add a new board config on my u-boot 1.2.0 how can i do? (my board is based on the kb9202 board) thank you see U-Boot Porting Guide in the README. (and upgrade from 1.2.0) Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 6/7] 83xx/fdt_support: let user specifiy FSL USB Dual-Role controller role
On Tue, 25 Mar 2008 19:06:34 +0300
Anton Vorontsov [EMAIL PROTECTED] wrote:
On Tue, Mar 25, 2008 at 10:42:11AM -0500, Kim Phillips wrote:
[...]
but the QE based 83xx SoCs don't use this fixup. So while
CONFIG_HAS_FSL_DR_USB gives you more control, I doubt saving 200 bytes
justifies the new config either. Either way really, but I tend to be
against any new CONFIG_s.
Hm... maybe then it's better to place fdt_fixup_usb_dr function
inside the fdt_support.h, marking it with static inline -- it's used
just once per board anyway..? Then neither space wasted nor the new
configs introduced.
I'd like to see that. Do you want to send a patch?
Sure, here it is.
- - - -
From: Anton Vorontsov [EMAIL PROTECTED]
Subject: mpc83xx/fdt_support: let user specifiy FSL USB Dual-Role controller
role
Linux understands host (default), peripheral and otg (broken).
Though, U-Boot doesn't restrict dr_mode variable to these values (think
of renames in future).
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
board/freescale/mpc837xerdb/mpc837xerdb.c |2 ++
include/fdt_support.h | 24
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/board/freescale/mpc837xerdb/mpc837xerdb.c
b/board/freescale/mpc837xerdb/mpc837xerdb.c
index d091538..70f52da 100644
--- a/board/freescale/mpc837xerdb/mpc837xerdb.c
+++ b/board/freescale/mpc837xerdb/mpc837xerdb.c
@@ -13,6 +13,7 @@
*/
#include common.h
+#include fdt_support.h
#include i2c.h
#include asm/io.h
#include asm/fsl_serdes.h
@@ -197,5 +198,6 @@ void ft_board_setup(void *blob, bd_t *bd)
ft_pci_setup(blob, bd);
#endif
ft_cpu_setup(blob, bd);
+ fdt_fixup_dr_usb(blob);
}
#endif /* CONFIG_OF_BOARD_SETUP */
diff --git a/include/fdt_support.h b/include/fdt_support.h
index 7836f28..933ef41 100644
--- a/include/fdt_support.h
+++ b/include/fdt_support.h
@@ -27,6 +27,7 @@
#ifdef CONFIG_OF_LIBFDT
#include fdt.h
+#include libfdt.h
int fdt_chosen(void *fdt, ulong initrd_start, ulong initrd_end, int force);
void do_fixup_by_path(void *fdt, const char *path, const char *prop,
@@ -64,5 +65,28 @@ void ft_cpu_setup(void *blob, bd_t *bd);
void ft_pci_setup(void *blob, bd_t *bd);
#endif
+static inline void fdt_fixup_dr_usb(void *fdt)
+{
+ char *mode;
+ const char *compat = fsl-usb2-dr;
+ const char *prop = dr_mode;
+ int node_offset;
+ int err;
+
+ mode = getenv(usb_dr_mode);
+ if (!mode)
+ return;
+
+ node_offset = fdt_node_offset_by_compatible(fdt, 0, compat);
+ if (node_offset 0)
+ printf(WARNING: could not find compatible node %s: %s.\n,
+ compat, fdt_strerror(node_offset));
+
+ err = fdt_setprop(fdt, node_offset, prop, mode, strlen(mode) + 1);
+ if (err 0)
+ printf(WARNING: could not set %s for %s: %s.\n,
+prop, compat, fdt_strerror(err));
+}
+
#endif /* ifdef CONFIG_OF_LIBFDT */
#endif /* ifndef __FDT_SUPPORT_H */
sigh yeah, that's too much code for a header file though.
I think your original patch was the more prudent approach, it follows
existing practice and it fits with the assumption that there'll be a
usb driver one day :). I'll put it in my queue and apply it unless
anyone has further comments.
Kim
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] DDR-II @ MPC8343A
On Tue, 25 Mar 2008 18:36:47 +0100 Andre Schwarz [EMAIL PROTECTED] wrote: All, has anyone set up the DDR-II controller on a Freescale MPC8343A without ? without what? As far as I can see there are only DDR-I boards from Freescale. The MDS can do ddr2: U-Boot 1.3.2-00097-gbc508d1 (Mar 25 2008 - 10:47:17) MPC83XX Reset Status: Software Hard, External/Internal Soft, External/Internal Hard CPU: e300c1, MPC8349E, Rev: 30 at 528 MHz, CSB: 264 MHz Board: Freescale MPC8349EMDS I2C: ready SPI: ready DRAM: 256 MB (DDR2, 64-bit, ECC on) ... Are there any patches not yet posted to handle this ? should work, only diff I see is that the 8343 is 32-bit only. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] DDR-II @ MPC8343A
On Tue, 25 Mar 2008 20:41:41 +0100 Andre Schwarz [EMAIL PROTECTED] wrote: Kim Phillips schrieb: On Tue, 25 Mar 2008 18:36:47 +0100 Andre Schwarz [EMAIL PROTECTED] wrote: As far as I can see there are only DDR-I boards from Freescale. The MDS can do ddr2: U-Boot 1.3.2-00097-gbc508d1 (Mar 25 2008 - 10:47:17) MPC83XX Reset Status: Software Hard, External/Internal Soft, External/Internal Hard CPU: e300c1, MPC8349E, Rev: 30 at 528 MHz, CSB: 264 MHz Board: Freescale MPC8349EMDS I2C: ready SPI: ready DRAM: 256 MB (DDR2, 64-bit, ECC on) ... Hmmm ... I get : U-Boot 1.3.2-00075-gc5f497a-dirty (Mar 25 2008 - 19:55:00) MPC83XX Reset Status: Check Stop, External/Internal Soft, External/Internal Hard CPU: e300c1, MPC8343, Rev: 31 at 399.999 MHz, CSB: 266 MHz Board: Matrix Vision mvBlueLYNX-M7 I2C: ready SPI: ready DRAM: cs0_bnds = 0x000f cs0_config = 0x80844102 DDR:bar=0x DDR:ar=0x801b 256 MB It's a 32-Bit DDR-II without ECC. 2 Chips are soldered to CS0, i.e. no EPROM present. Since I expect something like (DDR2, 32-Bit, ECC off) and nothing happens there is obviously something wrong with my memory setup. Is this reasonable ? sounds like memory isn't being configured correctly. Board specific? Or am I simply missing a board specific board_add_ram_info ? you can do that if you really, really, really want to see the (DDR2.. string, but it's optional. Am I assuming right that your info string (DDR2, 64-bit, ECC on) comes from spd_sdram ? yes. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] DDR-II @ MPC8343A
On Tue, 25 Mar 2008 21:25:45 +0100 Andre Schwarz [EMAIL PROTECTED] wrote: I've seen things like this in mpc8349emds code : #if (CFG_DDR_SIZE != 256) #warning Currenly any ddr size other than 256 is not supported #endif Is this reasonable ? Why ? that's in the fixed sdram init code, which could be considered reasonably unreasonable by some I suppose, since we can't guarantee the fixed settings will work with whatever memory you decide to use with it. It should work with the memory that comes with the board, though. btw, the spd code is being used by default on the 834x mds, not this fixed_sdram stuff - it's mostly there for board porting completeness. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] DDR-II @ MPC8343A
On Tue, 25 Mar 2008 21:54:53 +0100 Andre Schwarz [EMAIL PROTECTED] wrote: Kim Phillips schrieb: btw, the spd code is being used by default on the 834x mds, not this fixed_sdram stuff - it's mostly there for board porting completeness. But it is known to work, isn't it ? I haven't tested it recently. Patches welcome if it doesn't. Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 6/7] 83xx/fdt_support: let user specifiy FSL USB Dual-Role controller role
On Fri, 14 Mar 2008 23:20:18 +0300 Anton Vorontsov [EMAIL PROTECTED] wrote: Linux understands host (default), peripheral and otg (broken). Though, U-Boot doesn't restrict dr_mode variable to these values (think of renames in future). Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- board/freescale/mpc837xerdb/mpc837xerdb.c |1 + common/fdt_support.c | 25 + include/configs/MPC837XERDB.h |1 + include/fdt_support.h |6 ++ 4 files changed, 33 insertions(+), 0 deletions(-) applied, thanks. Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] Please pull u-boot-mpc83xx.git
Wolfgang, please pull support for uploading firmware for the Vitesse VSC7385 (an ethernet switch on some 83xx boards), support for serdes initialization, and misc fixes: The following changes since commit aa6f6d171a1f9f46ee4f03ad6acb97a6bfb71855: Wolfgang Denk (1): Coding Style cleanyp; update CHANGELOG are available in the git repository at: git://www.denx.de/git/u-boot-mpc83xx.git master Anton Vorontsov (18): 83xx: nand support for MPC837XRDB boards 83xx: split COBJS onto separate lines 83xx: serdes setup routines 83xx: initialize serdes for MPC837XRDB boards 83xx: define CONFIG_OF_STDOUT_VIA_ALIAS for the MPC837XERDB boards uec: add support for gbit mii status readings uec: add support for RGMII_RXID interface mode uec: add support for Broadcom BCM5481 Gigabit PHY mpc83xx: MPC8360E-RDK: use RGMII_RXID interface mode mpc83xx: MPC8360E-RDK: add support for NAND mpc83xx: MPC8360E-RDK: configure pario pins for AD7843 and FHCI mpc83xx: MPC8360E-RDK: rework ddr setup, enable ecc mpc83xx: MPC8360E-RDK: add dhcp command mpc83xx: MPC8360E-RDK: define CONFIG_OF_STDOUT_VIA_ALIAS mpc83xx: MPC8360E-RDK: use 33.3(3)MHz CLKIN/SYS_CLK mpc83xx: add fsl,soc and fsl,immr compatible fixups tsec: fix link detection for the RTL8211B PHY 83xx/fdt_support: let user specifiy FSL USB Dual-Role controller role Jerry Van Baren (1): Enable CONFIG_FLASH_SHOW_PROGRESS on the MPC8360EMDS. Joe D'Abbraccio (1): Modified the DDR SDRAM clock control register to delay MCK/MCK_B 3/4 clock Michael Barkowski (3): mpc8323erdb: use readable DDR config macros mpc8323erdb: Improve the system performance mpc8323erdb: remove RTC and add EEPROM Scott Wood (1): mpc83xx: Set PCI I/O bus-address base to zero. Timur Tabi (2): NET: Add Vitesse VSC7385 firmware uploading 83xx: Add Vitesse VSC7385 firmware uploading board/freescale/mpc8313erdb/mpc8313erdb.c | 21 board/freescale/mpc8349itx/mpc8349itx.c | 15 +++- board/freescale/mpc8360erdk/Makefile |4 +- board/freescale/mpc8360erdk/mpc8360erdk.c | 17 board/freescale/mpc8360erdk/nand.c| 72 ++ board/freescale/mpc837xerdb/mpc837xerdb.c | 65 - common/fdt_support.c | 25 + cpu/mpc83xx/Makefile | 15 +++- cpu/mpc83xx/cpu_init.c|6 + cpu/mpc83xx/fdt.c | 12 ++- cpu/mpc83xx/pci.c |2 - cpu/mpc83xx/qe_io.c |3 - cpu/mpc83xx/serdes.c | 145 + drivers/net/Makefile |1 + drivers/net/tsec.c|5 +- drivers/net/vsc7385.c | 101 drivers/qe/uec.c |1 + drivers/qe/uec.h |1 + drivers/qe/uec_phy.c | 69 -- drivers/qe/uec_phy.h |5 + include/asm-ppc/fsl_serdes.h | 21 include/configs/MPC8313ERDB.h | 88 -- include/configs/MPC8315ERDB.h |2 +- include/configs/MPC8323ERDB.h | 64 +++-- include/configs/MPC832XEMDS.h |2 +- include/configs/MPC8349ITX.h | 35 +-- include/configs/MPC8360EMDS.h |3 +- include/configs/MPC8360ERDK.h | 88 ++ include/configs/MPC837XEMDS.h |2 +- include/configs/MPC837XERDB.h | 113 +-- include/fdt_support.h |6 + include/mpc83xx.h |4 +- include/vsc7385.h | 13 +++ 33 files changed, 894 insertions(+), 132 deletions(-) create mode 100644 board/freescale/mpc8360erdk/nand.c create mode 100644 cpu/mpc83xx/serdes.c create mode 100644 drivers/net/vsc7385.c create mode 100644 include/asm-ppc/fsl_serdes.h create mode 100644 include/vsc7385.h Thanks, Kim - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 6/7] 83xx/fdt_support: let user specifiy FSL USB Dual-Role controller role
On Mon, 24 Mar 2008 17:44:19 +0300
Anton Vorontsov [EMAIL PROTECTED] wrote:
On Wed, Mar 19, 2008 at 08:35:58PM -0500, Kim Phillips wrote:
On Fri, 14 Mar 2008 23:20:18 +0300
Anton Vorontsov [EMAIL PROTECTED] wrote:
diff --git a/include/fdt_support.h b/include/fdt_support.h
index 7836f28..c10de8a 100644
--- a/include/fdt_support.h
+++ b/include/fdt_support.h
@@ -50,6 +50,12 @@ int fdt_find_and_setprop(void *fdt, const char *node,
const char *prop,
const void *val, int len, int create);
void fdt_fixup_qe_firmware(void *fdt);
+#ifdef CONFIG_HAS_FSL_DR_USB
+void fdt_fixup_dr_usb(void *blob, bd_t *bd);
+#else
+static inline void fdt_fixup_dr_usb(void *blob, bd_t *bd) {}
+#endif /* CONFIG_HAS_FSL_DR_USB */
+
this looks like a prime candidate for a weak function (which would also
eliminate the need for the new CONFIG_HAS_FSL_DR_USB introduced here).
Are you sure it's supposed to work like this?.. I don't see the linker
dropping unused weak symbols with the patch below.
with something like the following I get 24 bytes more text in
fdt_support.o, and 200 total bytes added 83xx-wide:
diff --git a/board/freescale/mpc837xerdb/mpc837xerdb.c
b/board/freescale/mpc837xerdb/mpc837xerdb.c
index a3b20b8..e8d130c 100644
--- a/board/freescale/mpc837xerdb/mpc837xerdb.c
+++ b/board/freescale/mpc837xerdb/mpc837xerdb.c
@@ -13,6 +13,7 @@
*/
#include common.h
+#include fdt_support.h
#include i2c.h
#include asm/io.h
#include spd_sdram.h
@@ -153,6 +154,7 @@ int misc_init_r(void)
}
#if defined(CONFIG_OF_BOARD_SETUP)
+extern void fdt_fixup_dr_usb(void *);
void ft_board_setup(void *blob, bd_t *bd)
{
@@ -160,5 +162,6 @@ void ft_board_setup(void *blob, bd_t *bd)
ft_pci_setup(blob, bd);
#endif
ft_cpu_setup(blob, bd);
+ fdt_fixup_dr_usb(blob);
}
#endif /* CONFIG_OF_BOARD_SETUP */
diff --git a/common/fdt_support.c b/common/fdt_support.c
index 69eb667..355b741 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -615,3 +615,10 @@ void fdt_fixup_ethernet(void *fdt, bd_t *bd)
}
}
#endif
+
+void __fdt_fixup_dr_usb(void *fdt)
+{
+ /* add your own */
+}
+void fdt_fixup_dr_usb(void *fdt) __attribute__((weak,
+ alias(__fdt_fixup_dr_usb)));
diff --git a/cpu/mpc83xx/fdt.c b/cpu/mpc83xx/fdt.c
index 6f55932..3224286 100644
--- a/cpu/mpc83xx/fdt.c
+++ b/cpu/mpc83xx/fdt.c
@@ -68,4 +68,27 @@ void ft_cpu_setup(void *blob, bd_t *bd)
fdt_fixup_memory(blob, (u64)bd-bi_memstart, (u64)bd-bi_memsize);
}
+
+void fdt_fixup_dr_usb(void *fdt)
+{
+ char *mode;
+ const char *compat = fsl-usb2-dr;
+ const char *prop = dr_mode;
+ int node_offset;
+ int err;
+
+ mode = getenv(usb_dr_mode);
+ if (!mode)
+ return;
+
+ node_offset = fdt_node_offset_by_compatible(fdt, 0, compat);
+ if (node_offset 0)
+ printf(WARNING: could not find compatible node %s: %s.\n,
+ compat, fdt_strerror(node_offset));
+
+ err = fdt_setprop(fdt, node_offset, prop, mode, strlen(mode) + 1);
+ if (err 0)
+ printf(WARNING: could not set %s for %s: %s.\n,
+ prop, compat, fdt_strerror(err));
+}
#endif /* CONFIG_OF_LIBFDT */
but the QE based 83xx SoCs don't use this fixup. So while
CONFIG_HAS_FSL_DR_USB gives you more control, I doubt saving 200 bytes
justifies the new config either. Either way really, but I tend to be
against any new CONFIG_s.
Kim
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 2/2] mpc83xx: MPC837XERDB: add support for PCI-Express
On Mon, 24 Mar 2008 21:42:37 +0300 Anton Vorontsov [EMAIL PROTECTED] wrote: +/* PCIE address map */ +#define CFG_PCIE1_BASE 0xA000 +#define CFG_PCIE1_MEM_BASE CFG_PCIE1_BASE +#define CFG_PCIE1_MEM_PHYS CFG_PCIE1_MEM_BASE +#define CFG_PCIE1_MEM_SIZE 0x1000 +#define CFG_PCIE1_CFG_BASE (CFG_PCIE1_MEM_BASE + CFG_PCIE1_MEM_SIZE) +#define CFG_PCIE1_CFG_SIZE 0x0100 I'm going to wait until I see how the kernel 83xx PCIE patches do before I apply this -- afaik, it's going to make the PCIE config mapping a 4K window (with translation being changed at run time) instead of a 16MB one. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 01/11] uec: add support for gbit mii status readings
On Mon, 24 Mar 2008 20:46:24 +0300 Anton Vorontsov [EMAIL PROTECTED] wrote: Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- drivers/qe/uec_phy.c | 28 +++- drivers/qe/uec_phy.h |5 + 2 files changed, 24 insertions(+), 9 deletions(-) applied 1-11. Thanks, Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 1/1] Modified the DDR SDRAM clock control register to delay MCK/MCK_B 3/4 clock
On Mon, 24 Mar 2008 13:00:59 -0400 Joe D'Abbraccio Joe.D'[EMAIL PROTECTED] wrote: From: Joe D'Abbraccio [EMAIL PROTECTED] With the original value of 1/2 clock cycle delay, the system ran relatively stable except when we run benchmarks that are intensive users of memory. When I run samba connected disk with a HDBENCH test, the system locks-up or reboots sporadically. Signed-off by: Joe D'Abbraccio Joe.D'[EMAIL PROTECTED] --- include/configs/MPC8349ITX.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) applied. Thanks, Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH v2 2/9] ATA: Add the libata support
On Thu, 20 Mar 2008 18:19:52 +0800 Dave Liu [EMAIL PROTECTED] wrote: diff --git a/drivers/block/libata.c b/drivers/block/libata.c new file mode 100644 index 000..aed5be3 --- /dev/null +++ b/drivers/block/libata.c @@ -0,0 +1,158 @@ +/* + * Copyright (C) 2008 Freescale Semiconductor, Inc. + * Dave Liu [EMAIL PROTECTED] + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + * + * with the reference to libata of kernel If you're going to copy code directly from the kernel, the kernel files' copyrights need to be copied here, too. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH v2 6/9] mpc83xx: serdes setup routines
On Thu, 20 Mar 2008 18:26:36 +0800 Dave Liu [EMAIL PROTECTED] wrote: From: Anton Vorontsov [EMAIL PROTECTED] This patch adds few routines to configure serdes on 837x targets. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- sounds like Anton is re-doing this patch. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 3/7] 83xx: serdes setup routines
On Tue, 18 Mar 2008 16:52:29 +0300 Anton Vorontsov [EMAIL PROTECTED] wrote: On Tue, Mar 18, 2008 at 11:28:20AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: On 23:19 Fri 14 Mar , Anton Vorontsov wrote: This patch adds few routines to configure serdes on 837x targets. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- cpu/mpc83xx/Makefile |1 + cpu/mpc83xx/serdes.c | 156 ++ include/asm-ppc/fsl_serdes.h | 25 +++ 3 files changed, 182 insertions(+), 0 deletions(-) create mode 100644 cpu/mpc83xx/serdes.c create mode 100644 include/asm-ppc/fsl_serdes.h diff --git a/cpu/mpc83xx/Makefile b/cpu/mpc83xx/Makefile index 7ad7e3e..6b6b027 100644 --- a/cpu/mpc83xx/Makefile +++ b/cpu/mpc83xx/Makefile @@ -39,6 +39,7 @@ COBJS-y += ecc.o COBJS-$(CONFIG_QE) += qe_io.o COBJS-$(CONFIG_83XX_GENERIC_PCI) += pci.o COBJS-$(CONFIG_OF_LIBFDT) += fdt.o +COBJS-$(CONFIG_FSL_SERDES) += serdes.o Please keep it sort Keeping cobjs in alphabetical order sounds weird to me, plus as far as I can see, current Makefile tried to keep things in this (sane) order: start.S COBJS += core (traps, cpu) COBJS += less important code (speed, sdram, ..) COBJS += auxiliary/not so important (pci, fdt, ) [Almost] the same order in which the code will be executed. Though, in this case I should place SERDES above FDT, near the PCI. Anyhow, firstly I'd like to know what Kim is thinking about all this? sorry, I was out for a while. I personally don't have a problem with COBJS not in alpha order. Alpha order is something Wolfgang has brought up in the past, seemingly more appropriately, i.e. for things like board names in the main Makefile and MAKEALL. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 1/7] 83xx: nand support for MPC837XRDB boards
On Tue, 18 Mar 2008 17:10:55 +0300 Anton Vorontsov [EMAIL PROTECTED] wrote: -/* VSC7385 Gigabit Switch support */ +/* + * VSC7385 Gigabit Switch support + */ +#define CFG_VSC7385_BASE 0xF000 What does this have to do with NAND? Nothing. I'm expanding VSC7385 comment to better separate it from the NAND code. Most lengthy parts of the RDB config are using /* * */ as a logical separator. So did I. that's fine, it just makes patch review easier and less susceptible to comments like this if you keep your patches on-subject. Also, this patch doesn't apply cleanly to the top of u-boot-mpc83xx.git, because of the VSC7385 patches I applied last week. Can you rebase your patches to the top of the mpc83xx git tree? I just updated it to Wolfgang's top-of-tree. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 6/7] 83xx/fdt_support: let user specifiy FSL USB Dual-Role controller role
On Fri, 14 Mar 2008 23:20:18 +0300
Anton Vorontsov [EMAIL PROTECTED] wrote:
diff --git a/include/fdt_support.h b/include/fdt_support.h
index 7836f28..c10de8a 100644
--- a/include/fdt_support.h
+++ b/include/fdt_support.h
@@ -50,6 +50,12 @@ int fdt_find_and_setprop(void *fdt, const char *node,
const char *prop,
const void *val, int len, int create);
void fdt_fixup_qe_firmware(void *fdt);
+#ifdef CONFIG_HAS_FSL_DR_USB
+void fdt_fixup_dr_usb(void *blob, bd_t *bd);
+#else
+static inline void fdt_fixup_dr_usb(void *blob, bd_t *bd) {}
+#endif /* CONFIG_HAS_FSL_DR_USB */
+
this looks like a prime candidate for a weak function (which would also
eliminate the need for the new CONFIG_HAS_FSL_DR_USB introduced here).
Kim
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 2/2] 83xx: Add Vitesse VSC7385 firmware uploading
On Fri, 8 Feb 2008 13:15:55 -0600 Timur Tabi [EMAIL PROTECTED] wrote: Update the MPC8349E-mITX, MPC8313E-RDB, and MPC837XE-RDB board files to upload the Vitesse VSC7385 firmware. Changed CONFIG_VSC7385 to CONFIG_VSC7385_ENET. Cleaned up the board header files to make selecting the VSC7385 easier to control. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- This patch is for U-Boot 1.3.3 board/freescale/mpc8313erdb/mpc8313erdb.c | 21 +++ board/freescale/mpc8349itx/mpc8349itx.c | 15 +- board/freescale/mpc837xerdb/mpc837xerdb.c | 27 +++-- include/configs/MPC8313ERDB.h | 88 +++-- include/configs/MPC8349ITX.h | 33 --- include/configs/MPC837XERDB.h | 83 +++- 6 files changed, 196 insertions(+), 71 deletions(-) applied. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 1/2] NET: Add Vitesse VSC7385 firmware uploading
On Mon, 18 Feb 2008 22:06:53 -0500 Ben Warren [EMAIL PROTECTED] wrote: Acked-by: Ben Warren [EMAIL PROTECTED] Kim - would you mind pulling this into your tree? Best to keep it with part 2. done. Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH] mpc83xx: make dtb basename file references equal those of linux
the dts file basenames were updated in linux - this helps avoid inadvertently loading any old dtbs laying around. Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- include/configs/MPC832XEMDS.h |2 +- include/configs/MPC8360EMDS.h |2 +- include/configs/MPC837XEMDS.h |2 +- include/configs/MPC837XERDB.h |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h index 702b073..f32c4f7 100644 --- a/include/configs/MPC832XEMDS.h +++ b/include/configs/MPC832XEMDS.h @@ -583,7 +583,7 @@ ramdiskaddr=100\0 \ ramdiskfile=ramfs.83xx\0 \ fdtaddr=40\0 \ - fdtfile=mpc832xemds.dtb\0 \ + fdtfile=mpc832x_mds.dtb\0 \ #define CONFIG_NFSBOOTCOMMAND \ diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h index eff9fba..c8dcbc6 100644 --- a/include/configs/MPC8360EMDS.h +++ b/include/configs/MPC8360EMDS.h @@ -615,7 +615,7 @@ ramdiskaddr=100\0 \ ramdiskfile=ramfs.83xx\0 \ fdtaddr=40\0 \ - fdtfile=mpc8360emds.dtb\0 \ + fdtfile=mpc836x_mds.dtb\0 \ #define CONFIG_NFSBOOTCOMMAND \ diff --git a/include/configs/MPC837XEMDS.h b/include/configs/MPC837XEMDS.h index ef2..5586533 100644 --- a/include/configs/MPC837XEMDS.h +++ b/include/configs/MPC837XEMDS.h @@ -578,7 +578,7 @@ ramdiskaddr=100\0 \ ramdiskfile=ramfs.83xx\0 \ fdtaddr=40\0 \ - fdtfile=mpc837xemds.dtb\0 \ + fdtfile=mpc8379_mds.dtb\0 \ #define CONFIG_NFSBOOTCOMMAND \ diff --git a/include/configs/MPC837XERDB.h b/include/configs/MPC837XERDB.h index 2da4f29..1964946 100644 --- a/include/configs/MPC837XERDB.h +++ b/include/configs/MPC837XERDB.h @@ -545,7 +545,7 @@ #define CONFIG_RAMDISKFILE rootfs.ext2.gz.uboot #define CONFIG_BOOTFILEuImage #define CONFIG_UBOOTPATH u-boot.bin /* U-Boot image on TFTP server */ -#define CONFIG_FDTFILE mpc837x_rdb.dtb +#define CONFIG_FDTFILE mpc8379_rdb.dtb #define CONFIG_LOADADDR20 /* default location for tftp and bootm */ #define CONFIG_BOOTDELAY -1 /* -1 disables auto-boot */ -- 1.5.4.3.450.gb92176 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Add flash programming counter]
On Fri, 07 Mar 2008 17:33:34 +0100 Wolfgang Denk [EMAIL PROTECTED] wrote: In message [EMAIL PROTECTED] you wrote: There is no way to add an end marker without using a new line (or use '\r' which is really unacceptable, and more justifiably so). Since we are settling in on having 50 (?probably want to use a #define) dots unless there are fewer than 50 units to be written, I suppose we can live without a end marker. Sigh, the end marker was the fun part. I thought it safe to assume a terminal is 80 characters wide..(80 - strlen(Writing to Flash) - strlen(done)) == 60? Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] please pull mpc83xx
Wolfgang, Please pull mpc83xx; it has a patch you missed that was posted here: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/37339 and the dtb rename patch I just posted: The following changes since commit bd4458cb47abecabd406b1210457be96c69fc49d: Dave Liu (1): 837xEMDS: Improve the system performance are available in the git repository at: git://www.denx.de/git/u-boot-mpc83xx.git Kim Phillips (2): net: uec_phy: actually increment the timeout counter mpc83xx: make dtb basename file references equal those of linux drivers/qe/uec_phy.c |3 ++- include/configs/MPC832XEMDS.h |2 +- include/configs/MPC8360EMDS.h |2 +- include/configs/MPC837XEMDS.h |2 +- include/configs/MPC837XERDB.h |2 +- 5 files changed, 6 insertions(+), 5 deletions(-) Thanks, Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] mpc83xx: make dtb basename file references equal those of linux
On Sat, 08 Mar 2008 02:03:02 +0100 Wolfgang Denk [EMAIL PROTECTED] wrote: In message [EMAIL PROTECTED] you wrote: but these are the filenames in linux' device tree directory - arch/powerpc/boot/dts, and I'm assuming people do something sane like dtc -I $file.dts -O $file.dtb. Argh... what a mess. indeed. are you suggesting we rename u-boot's config files too? Well, my personal preference is to have the official board name and the related file names match as closely as possible, probabl;y just using lowercase letters for the files. I don't think it's exactly intuitive to have a board named mpc832xemds and the related files use mpc832x_mds. That looks awfully broken to me. afaik, you can supposedly buy an mds board with an mpc8321, mpc8321e, mpc8323, or an mpc8323e (the trailing 'e' denotes whether the crypto engine has its fuse intact). It's just the mpc8323e that is (probably by far) the most common. At the momnt, the U-Boot code looks OK, so if you do it differently in Linux, you should fix it there. Just my $ 0.02 (well, I think I should say $ 0.03 given current exchange rates ;-). bah, what can you buy with a cent these days? ;) linux board support files are consistent /within/ linux, and u-boot board support files are intra-u-boot consistent; it's just this particular file (the device tree) needs to be inter-linux and u-boot consistent (for interoperability purposes). Since linux does currently host the device tree files, we should probably follow their naming scheme, unless you want to discuss hosting device tree files in u-boot ;). fyi, the board file was changed in the linux git tree commit be156bed9ebfe365c6d95f715eae3529cf694fcb Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] 837xEMDS: Improve the system performance
On Tue, 04 Mar 2008 17:17:27 +0100 Wolfgang Denk [EMAIL PROTECTED] wrote: In message [EMAIL PROTECTED] you wrote: 1. Make the CSB bus pipeline depth as 4, and enable the repeat mode; 2. Raise the eTSEC emergency priority; 3. Use the highest IP blocks clock. Signed-off-by: Dave Liu [EMAIL PROTECTED] Is this supposed to go into the 1.3.2 release? Directly or through Kim's 83xx custodian repo? Kim? Hi Wolfgang, I don't know what version Dave intended here either; if he wants it in 1.3.2 I'll apply and ask you to pull. Dave? Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH] Fix mpc8360emds board hang on second network operation
On Tue, 26 Feb 2008 21:32:30 -0500
Jerry Van Baren [EMAIL PROTECTED] wrote:
The changeset that causes my problems is ee62ed32
The original code calls init_phy(dev) followed by phy_change(dev) *once*
during PHY initialization. The part of changeset that appears to cause
my problems is calling phy_change(dev) every time uec_init() is called.
phy_change is there so that u-boot will renegotiate the link in case
its state has changed since the last networking command (this was the
original complaint that warranted the ee62ed32 patch, iirc).
On my mpc8360emds board, without this change the second command that does
a network operation hangs the board (requires a hard reset to recover).
Example failure sequence is two ping commands: the first works, the
second hangs the board.
This also speeds up the network initialization and doesn't cause a packet
error on the first TFTP packet.
Signed-off-by: Gerald Van Baren [EMAIL PROTECTED]
---
Kim:
Does this make any sense? Any thoughts why it isn't causing problems
for you? It makes all the difference in the world for me.
One other interesting sequence difference with patch ee62ed32 is that
the ethernet MAC address is set on every uec_init() call. The following
code was inside the if (uec-the_first_run == 0) conditional, now it
is outside the conditional and thus run on every uec_init() call.
Functionally, it doesn't seem to matter for me either way, but seems
unnecessary.
+ /* Set up the MAC address */
+ if (dev-enetaddr[0] 0x01) {
+ printf(%s: MacAddress is multcast address\n,
+__FUNCTION__);
+ return -1;
+ }
+ uec_set_mac_address(uec, dev-enetaddr);
this was done in order to be able to re-set eth[1]addr between
networking commands, and have the new eth[1]addr value actually
programmed on the interface.
I've tested 100BT, and experience the same as you. The reason u-boot
doesn't recover is that i is not incremented in genmii_update_link(),
but adding that doesn't resolve the problem. I believe the PHY status
is being incorrectly determined somehow - these PHYs are really
finicky :/.
Kim
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH] net: uec_phy: handle 88e1111 rev.B2 erratum 5.6
erratum 5.6 states the autoneg completion bit is functional only if the
autoneg bit is asserted.
This fixes any secondarily-issued networking commands on non-gigabit
links on the mpc8360 mds board.
Signed-off-by: Kim Phillips [EMAIL PROTECTED]
---
gvb, please test, and give us your blessings if this fixes your second
ping failing issue.
To go through biggerbadderben, for 1.3.2.
drivers/qe/uec_phy.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/qe/uec_phy.c b/drivers/qe/uec_phy.c
index c549b6b..cf9921b 100644
--- a/drivers/qe/uec_phy.c
+++ b/drivers/qe/uec_phy.c
@@ -574,6 +574,7 @@ void marvell_phy_interface_mode (struct eth_device *dev,
{
uec_private_t *uec = (uec_private_t *) dev-priv;
struct uec_mii_info *mii_info;
+ u16 status;
if (!uec-mii_info) {
printf (%s: the PHY not intialized\n, __FUNCTION__);
@@ -609,6 +610,13 @@ void marvell_phy_interface_mode (struct eth_device *dev,
phy_write (mii_info, 0x00, 0x8100);
udelay (100);
}
+
+ /* handle 88e rev.B2 erratum 5.6 */
+ if (mii_info-autoneg) {
+ status = phy_read (mii_info, PHY_BMCR);
+ phy_write (mii_info, PHY_BMCR, status | PHY_BMCR_AUTON);
+ }
+ /* now the B2 will correctly report autoneg completion status */
}
void change_phy_interface_mode (struct eth_device *dev, enet_interface_e mode)
--
1.5.4.23.gef5b9
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] Problems with new ethernet init on mpc8360
On Mon, 25 Feb 2008 22:55:37 -0500 Jerry Van Baren [EMAIL PROTECTED] wrote: Hi Kim, I have a mpc8360emds eval board. The ee62ed patch (below) speeds up the start up (good), but seems to cause the board to hang on the *second* ethernet operation. I can cause this by doing two pings in a row: the first ping initializes the network and completes successfully. The second ping hangs the board: it never completes. I cannot abort it with ^C. The only way out is to reset the board. The same thing happens with two back-to-back tftp operations or a ping followed by a tftp operation. If I back out the ee62ed patch (below), it fixes the problem. I tried backing out some simple portions of the patch (added delays back in) with no success. I've given up chasing this for tonight. Any inspiration you can generate would be appreciated, I'll chase it some more tomorrow. I verified rc2 on rev. 1.1 and 2.1 boards pings more than once. can you provide more details about which u-boot version, what board rev you're on, what kind of connection you're using, speed, etc.? Kim - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
