Change in vdsm[master]: Add a function wrapper to vdsm-tool for /etc/inid.d/function...
Mark Wu has posted comments on this change. Change subject: Add a function wrapper to vdsm-tool for /etc/inid.d/functions .. Patch Set 1: (2 inline comments) I can't see the motivation of this patch. Why do you expose all functions in /etc/init.d/functions? Is it useful for vdsm management? My understanding is that we should put vdsm-related management functions into vdsm-tool to make them exposed to administrator. If anybody can clarify the design purpose of vdsm-tool, it will be appreciated. Commit Message Line 7: Add a function wrapper to vdsm-tool for /etc/inid.d/functions typo here: inid.d -> init.d File vdsm-tool/function.py Line 19: New introduced file should be put in PEP8_WHITELIST -- To view, visit http://gerrit.ovirt.org/4419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9f9ba30515356b8bccfebdbab029c951ffa9b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: Shu Ming ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#806625: validate vdsmcert against cacert
Dan Kenigsberg has posted comments on this change. Change subject: BZ#806625: validate vdsmcert against cacert .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) File vdsm/vdsmd.init.in Line 246: ret=$(/usr/bin/openssl verify -CAfile $file /etc/pki/vdsm/certs/vdsmcert.pem) tabs? I do not see my former comments referred. -- To view, visit http://gerrit.ovirt.org/4345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66fa4b502f4d78dae362cbdcb76b964e360fd119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#806625: validate vdsmcert against cacert
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#806625: validate vdsmcert against cacert
..
Patch Set 1: (6 inline comments)
File vdsm/vdsmd.init.in
Line 289: else
ovirt-node won't take it because the libvirt upstart patch didn't work. There
is a race condition, where the ca cert is renamed and the daemon is started.
So, the scenario is, after the complete RHEV-H boot libvirt can be started
*manually* (because the ca cert have been renamed).
About:
> shouldn't it only run when isOvirt?
Ok, my bad. Done.
> Please put in a separate, well-named function.
Alright, done.
Line 292: PATH_CERT="/etc/pki/vdsm/certs"
Done
Line 295: for file in ${PATH_CERT}/*; do
Done
Line 297: if [ "${ret}" == "/etc/pki/vdsm/certs/vdsmcert.pem:
OK" ]; then
no, always return '0', even in error
Line 301: /bin/chown ${ID}:${ID} ${PATH_CERT}/cacert.pem
OK done, I never seen it happen in oVirt Node. But agreed, let's improve this
approach, thanks!
Line 304: /sbin/initctl start libvirtd 1> /dev/null
Done
--
To view, visit http://gerrit.ovirt.org/4345
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66fa4b502f4d78dae362cbdcb76b964e360fd119
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#806625: validate vdsmcert against cacert
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#806625: validate vdsmcert against cacert .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/4345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66fa4b502f4d78dae362cbdcb76b964e360fd119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix can't get ssl opt in vdsm sos plugin
Xu He Jie has posted comments on this change. Change subject: fix can't get ssl opt in vdsm sos plugin .. Patch Set 2: Verified (1 inline comment) File vdsm/sos/vdsmd.py.in Line 24: from vdsm.config import config When sos/vdsm.py has same name with /usr/lib/python2.7/site-packages/vdsm, It can not 'import vdsm' with right module. If you want to load right module, it will make the code complex. So I choice easy way, just rename this file to vdsmd.py. and the name 'vdsmd' looks rational. -- To view, visit http://gerrit.ovirt.org/4349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbbc9a10202f191d0754bfae5c3f876b6c53a560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Xu He Jie ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reraise errors from underlying c code in betterPopen
Wenchao Xia has posted comments on this change. Change subject: Reraise errors from underlying c code in betterPopen .. Patch Set 1: No score; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I063b75bd1587757dde9ab2c0180157a6c55e45ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get network address to showNetwork
Lei Li has posted comments on this change. Change subject: Get network address to showNetwork .. Patch Set 2: (1 inline comment) File vdsm/configNetwork.py Line 708: ipaddr = netdict['addr'] Yes, bridgeless networks may have ipaddress, but seems it's not supported by vdsm now. vdsm create bridgeless network through libvirt just with network name and its interface, so both libvirt and host did not have these info. Should we let it supported first? Or mark it as a TODO if there are other plans? -- To view, visit http://gerrit.ovirt.org/4326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I791adbb9321d097fb609f0328e25d6d4f1865696 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lei Li ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: remove skipLibvirt flag
Douglas Schilling Landgraf has posted comments on this change. Change subject: configNetwork: remove skipLibvirt flag .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/4342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie98ba38da64e34aedfd88b11880929ee4d99d0d6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configure.ac: add python-devel requirement
Douglas Schilling Landgraf has posted comments on this change. Change subject: configure.ac: add python-devel requirement .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/4420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c8195665f0453d3da54b3e18d22b6311c025bfc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configure.ac: add python-devel requirement
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: configure.ac: add python-devel requirement .. configure.ac: add python-devel requirement vdsm/betterPopen: requires python-devel package. Change-Id: I0c8195665f0453d3da54b3e18d22b6311c025bfc Signed-off-by: Douglas Schilling Landgraf --- M configure.ac 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/4420/1 -- To view, visit http://gerrit.ovirt.org/4420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0c8195665f0453d3da54b3e18d22b6311c025bfc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reraise errors from underlying c code in betterPopen
Wenchao Xia has posted comments on this change. Change subject: Reraise errors from underlying c code in betterPopen .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/4412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I063b75bd1587757dde9ab2c0180157a6c55e45ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reraise errors from underlying c code in betterPopen
Wenchao Xia has posted comments on this change. Change subject: Reraise errors from underlying c code in betterPopen .. Patch Set 1: forgot my comments, sorry. Got the answer from following patches. -- To view, visit http://gerrit.ovirt.org/4412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I063b75bd1587757dde9ab2c0180157a6c55e45ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tunnel errors from child to parent in betterPopen
Wenchao Xia has posted comments on this change. Change subject: Tunnel errors from child to parent in betterPopen .. Patch Set 1: (1 inline comment) reviewed, and have some technic questions that I did not catch up with the code. By the way, the codes needs lot knowledge to understand, maybe add a few more info in the commit messages such as "parent could get error info of child by calling betterOpen.stderr.read()", would make people knows how it works faster. File vdsm/betterPopen/createprocess.c Line 168: why errnofd[2] must be an array with size [2]? What different purpose are errnofd[0] and errnofd[1] used for? -- To view, visit http://gerrit.ovirt.org/4413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d4a132317e9cf0843671460a0876f615760731d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Support unicode args in betterPopen
Wenchao Xia has posted comments on this change. Change subject: Support unicode args in betterPopen .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dsaversion: renamed to dsaversion.in
Douglas Schilling Landgraf has posted comments on this change. Change subject: dsaversion: renamed to dsaversion.in .. Patch Set 1: (1 inline comment) File vdsm.spec.in Line 273: make Done -- To view, visit http://gerrit.ovirt.org/4284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b4a63a974bfc301f3294603d8fe91f534b74dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dsaversion: renamed to dsaversion.in
Douglas Schilling Landgraf has posted comments on this change. Change subject: dsaversion: renamed to dsaversion.in .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/4284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b4a63a974bfc301f3294603d8fe91f534b74dd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reraise errors from underlying c code in betterPopen
Wenchao Xia has posted comments on this change. Change subject: Reraise errors from underlying c code in betterPopen .. Patch Set 1: if the error is not raised, what would happen? -- To view, visit http://gerrit.ovirt.org/4412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I063b75bd1587757dde9ab2c0180157a6c55e45ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rest-api: Model volumes
Mark Wu has posted comments on this change. Change subject: rest-api: Model volumes .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) Sorry for not raising this problem earlier. I just notice this problem when I did some test yesterday. File vdsm/rest/Controller.py Line 362: role = Volume.ROLES.get(self.info['voltype'].lower(), None) According to the definition of createVolume: def create(self, size, volFormat, preallocate, diskType, desc, srcImgUUID, srcVolUUID): return self._irs.createVolume(self._sdUUID, self._spUUID, self._imgUUID, size, volFormat, preallocate, diskType, self._UUID, desc, srcImgUUID, srcVolUUID) I think the parameter 'diskType' is misused here. What the api expects is diskType: # Disk type UNKNOWN_DISK_TYPE = 0 SYSTEM_DISK_TYPE = 1 DATA_DISK_TYPE = 2 SHARED_DISK_TYPE = 3 SWAP_DISK_TYPE = 4 TEMP_DISK_TYPE = 5 , not the volume role, which is only used in copyImage() to create a template. In other cases, we needn't care about the volume role. vdsm can set it properly: new created volume except template is always leaf node. If another volume created based on it, its role will be changed to internal. And the role of template is shared, which is set on creation. That's my understanding. -- To view, visit http://gerrit.ovirt.org/3753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5a34e02c84c3668dff883b3a618d420edcf60be Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Mark Wu ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a function wrapper to vdsm-tool for /etc/inid.d/function...
Wenyi Gao has uploaded a new change for review. Change subject: Add a function wrapper to vdsm-tool for /etc/inid.d/functions .. Add a function wrapper to vdsm-tool for /etc/inid.d/functions Change-Id: I4b9f9ba30515356b8bccfebdbab029c951ffa9b0 Signed-off-by: Wenyi Gao --- M vdsm-tool/Makefile.am A vdsm-tool/function.py M vdsm.spec.in 3 files changed, 41 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/4419/1 -- To view, visit http://gerrit.ovirt.org/4419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4b9f9ba30515356b8bccfebdbab029c951ffa9b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make compression type configurable, support gzip and xz
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: it is better that do it at runtime. but how to do it at runtime? i.e. if user using rpm package. when they use rpm install it, how to check the system support which compress type? -- To view, visit http://gerrit.ovirt.org/4174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Xu He Jie ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make compression type configurable, support gzip and xz
Saggi Mizrahi has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: I would prefer that you didn't submit this Why do it at build time rather then runtime? -- To view, visit http://gerrit.ovirt.org/4174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Xu He Jie ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Support unicode args in betterPopen
Adam Litke has posted comments on this change. Change subject: Support unicode args in betterPopen .. Patch Set 1: Verified; Looks good to me, but someone else must approve Fixes the problem I was seeing with createStoragePool -- To view, visit http://gerrit.ovirt.org/4414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tunnel errors from child to parent in betterPopen
Saggi Mizrahi has abandoned this change. Change subject: Tunnel errors from child to parent in betterPopen .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/4410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I05d89d92728ffd34e2eff9fd8d63b1bce72d3f9d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Support unicode args in betterPopen
Saggi Mizrahi has uploaded a new change for review. Change subject: Support unicode args in betterPopen .. Support unicode args in betterPopen Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb Signed-off-by: Saggi Mizrahi --- M tests/betterPopenTests.py M vdsm/betterPopen/createprocess.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/4414/1 -- To view, visit http://gerrit.ovirt.org/4414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reraise errors from underlying c code in betterPopen
Saggi Mizrahi has uploaded a new change for review. Change subject: Reraise errors from underlying c code in betterPopen .. Reraise errors from underlying c code in betterPopen Change-Id: I063b75bd1587757dde9ab2c0180157a6c55e45ca Signed-off-by: Saggi Mizrahi --- M vdsm/betterPopen/__init__.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/4412/1 -- To view, visit http://gerrit.ovirt.org/4412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I063b75bd1587757dde9ab2c0180157a6c55e45ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tunnel errors from child to parent in betterPopen
Saggi Mizrahi has uploaded a new change for review. Change subject: Tunnel errors from child to parent in betterPopen .. Tunnel errors from child to parent in betterPopen Change-Id: I2d4a132317e9cf0843671460a0876f615760731d Signed-off-by: Saggi Mizrahi --- M tests/betterPopenTests.py M vdsm/betterPopen/createprocess.c 2 files changed, 68 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/4413/1 -- To view, visit http://gerrit.ovirt.org/4413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2d4a132317e9cf0843671460a0876f615760731d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tunnel errors from child to parent in betterPopen
Saggi Mizrahi has uploaded a new change for review. Change subject: Tunnel errors from child to parent in betterPopen .. Tunnel errors from child to parent in betterPopen Change-Id: I05d89d92728ffd34e2eff9fd8d63b1bce72d3f9d Signed-off-by: Saggi Mizrahi --- M tests/betterPopenTests.py M vdsm/betterPopen/__init__.py M vdsm/betterPopen/createprocess.c 3 files changed, 62 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/4410/1 -- To view, visit http://gerrit.ovirt.org/4410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I05d89d92728ffd34e2eff9fd8d63b1bce72d3f9d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rest-api: Add the basic server infrastructure
Dan Kenigsberg has submitted this change and it was merged. Change subject: rest-api: Add the basic server infrastructure .. rest-api: Add the basic server infrastructure Add a new API binding for a REST API based on CherryPy and the Cheetah templating framework. This patch introduces the basic infrastructure for the API as follows: vdsm/clientIF.py * Initialize the REST API along with the XMLRPC binding. * The rest server is started in its own thread. It will create more threads as needed. vdsm/rest/BindingREST.py * REST API initialization vdsm/rest/Controller.py * Main API logic controller * In this patch we introduce utilities and structure * Render the Root resource in the API vdsm/rest/Dispatcher.py * A custom cherrypy URI dispatcher that handles URIs with nested identifiers: http://:/api/storagedomains//images/ vdsm/rest/templates/api.xsd vdsm/rest/templates/rsdl.xml * Define the rest API schema and valid URIs * This API is compatible with ovirt-engine-sdk and ovirt-engine-cli vdsm/rest/templates/response.json.x vdsm/rest/templates/response.xml.x vdsm/rest/templates/root.json.x vdsm/rest/templates/root.xml.x * Cheetah template files to render responses in json and xml format * The API can accept requests in either json or xml API Implemented: /api : The Root of the API * Provides vdsm version information * Lists the available sub-collections Actions: None Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56 Signed-off-by: Adam Litke --- M Makefile.am M configure.ac A tests/rest_override/__init__.py M vdsm.spec.in M vdsm/BindingXMLRPC.py M vdsm/Makefile.am M vdsm/clientIF.py M vdsm/config.py.in A vdsm/rest/BindingREST.py A vdsm/rest/Controller.py A vdsm/rest/Dispatcher.py A vdsm/rest/Makefile.am A vdsm/rest/__init__.py A vdsm/rest/templates/Makefile.am A vdsm/rest/templates/api.xsd A vdsm/rest/templates/response.json.x A vdsm/rest/templates/response.xml.x A vdsm/rest/templates/root.json.x A vdsm/rest/templates/root.xml.x A vdsm/rest/templates/rsdl.xml 20 files changed, 1,126 insertions(+), 43 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rest-api: Add the basic server infrastructure
Dan Kenigsberg has posted comments on this change. Change subject: rest-api: Add the basic server infrastructure .. Patch Set 8: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...
Dan Kenigsberg has submitted this change and it was merged. Change subject: remove stale libvirtNet before creating a new net with same name .. remove stale libvirtNet before creating a new net with same name Vdsm is the owner of vdsm-bla networks. If for some reasons (such as vdsm being kill just after defining a libvirt network) we find a stale definition of the network, Vdsm should override it. v2: check if net is active/persistent before destroy/undefine to avoid silly libvirt exceptions. Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752 Signed-off-by: Dan Kenigsberg --- M vdsm/configNetwork.py 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Avi Tal: Verified Igor Lvovsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Avi Tal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...
Dan Kenigsberg has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Avi Tal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...
Igor Lvovsky has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Avi Tal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] List storage domains using monitoredDomains
Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] List storage domains using monitoredDomains .. [WIP] List storage domains using monitoredDomains To get the list of the storage domains that vdsm is going to release disconnecting from the pool (StoragePool.disconnect) we shouldn't rely on the master domain (getDomains), but we must use an in-memory list such as the monitoredDomains. Signed-off-by: Federico Simoncelli Change-Id: I952362c621c569e8a28e539e7aafb82fbb3e8bc7 --- M vdsm/storage/sp.py 1 file changed, 13 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/4404/1 -- To view, visit http://gerrit.ovirt.org/4404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I952362c621c569e8a28e539e7aafb82fbb3e8bc7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make compression type configurable, support gzip and xz
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: (1 inline comment) File configure.ac Line 42: AC_PATH_PROG([XZ], [xz]) or maybe, there is no need to configure the logrotate compress type. it can be decide by the spec.in file, and it still is xz compress type. -- To view, visit http://gerrit.ovirt.org/4174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Xu He Jie ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make compression type configurable, support gzip and xz
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: (1 inline comment) File configure.ac Line 42: AC_PATH_PROG([XZ], [xz]) yes, the logrotate compress type are same on build machine and the target machine by default. Actually, if distribution was compressed by gzip, and logrotate configure compress type xz with the '--with-xz', the target machine should support both gzip and xz.tha is not we want. So I think the logrotate compress type and distribution compress type should be configured same, and should be both configured by argument ike '--with-xz, --with-gzip' -- To view, visit http://gerrit.ovirt.org/4174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Xu He Jie ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make domainMonitor compliant to PEP8
Saggi Mizrahi has posted comments on this change. Change subject: Make domainMonitor compliant to PEP8 .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add the async kwarg to acquireHostId
Saggi Mizrahi has posted comments on this change. Change subject: Add the async kwarg to acquireHostId .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f8cf540f262a9c2da795a97acabc011b55e0dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...
Saggi Mizrahi has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Avi Tal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...
Avi Tal has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/4370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Avi Tal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...
Dan Kenigsberg has posted comments on this change.
Change subject: remove stale libvirtNet before creating a new net with same name
..
Patch Set 1: (2 inline comments)
File vdsm/configNetwork.py
Line 662: removeLibvirtNetwork(network, log=False)
I do not see a problem here. If we report that network as existing, we should
not allow creating it.
Line 676: logging.debug('failed to remove libvirt network ' +
netName,
Done
--
To view, visit http://gerrit.ovirt.org/4370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Avi Tal
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Igor Lvovsky
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing test package to vdsm
Saggi Mizrahi has posted comments on this change. Change subject: introducing test package to vdsm .. Patch Set 4: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/3923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Wenchao Xia ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing test package to vdsm
Saggi Mizrahi has posted comments on this change.
Change subject: introducing test package to vdsm
..
Patch Set 4: (7 inline comments)
This patch does too many things and is a bit confusing, please have every
change in it's own patch.
I still don't understand why you want to move the files around.
File tests/testrunner.py
Line 156: def search_files(path, suffix):
Remove this function, use glob
Line 186: print "running test suits %s..." % case_unit["name"]
stream.write
Line 220: parser.add_argument('--case', help='''specify a case or a
directory
This entire option is redundant, it's already built in, just add the ut folder
to nose's search path.
This will not solve the issue of being able to tab to autocomplete module names
Line 225: inputArgs = sys.argv[1:]
There is no need to eliminate the first arg
Line 226: args = parser.parse_args(inputArgs)
Pop your args from the agrv list so they don't confuse nose.
Line 240: print "hacking vdsm modles..."
stream.write
Line 244: def genCaseList(testConfig):
Again, this entire function is redundant, just add ./ut to nose's search path.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Shu Ming
Gerrit-Reviewer: Wenchao Xia
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add the async kwarg to acquireHostId
Federico Simoncelli has uploaded a new change for review. Change subject: Add the async kwarg to acquireHostId .. Add the async kwarg to acquireHostId Signed-off-by: Federico Simoncelli Change-Id: Ie1f8cf540f262a9c2da795a97acabc011b55e0dd --- M vdsm.spec.in M vdsm/storage/safelease.py M vdsm/storage/sd.py 3 files changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/4392/1 -- To view, visit http://gerrit.ovirt.org/4392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie1f8cf540f262a9c2da795a97acabc011b55e0dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...
Avi Tal has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 1: Fails -- To view, visit http://gerrit.ovirt.org/4370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Avi Tal Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Implement Popen without forking back to python
Federico Simoncelli has posted comments on this change.
Change subject: Implement Popen without forking back to python
..
Patch Set 14: (1 inline comment)
File vdsm.spec.in
Line 616: %{python_sitelib}/%{vdsm_name}/betterPopen/createprocess.so
The dynamic libs aren't python_sitelib material. They belong to the
python_sitearch path.
--
To view, visit http://gerrit.ovirt.org/3944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief4ae42eb57551d7f5893bf562da451a9c98f219
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Igor Lvovsky
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Wenchao Xia
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...
Igor Lvovsky has posted comments on this change.
Change subject: remove stale libvirtNet before creating a new net with same name
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
File vdsm/configNetwork.py
Line 662: removeLibvirtNetwork(network, log=False)
Dan, correct me if I am wrong, but
if you want to overwrite defined libvirt network here it maybe too late.
Look at _addNetworkValidation in addNetwork.
You have there:
if bridge in _netinfo.networks:
raise ConfigNetworkError(ne.ERR_USED_BRIDGE,
"Bridge already exists")
When _netinfo.networks you take from libvirt.
It means you will fail here before you reach createLibvirtNetwork().
Am I missing something?
Line 676: logging.debug('failed to remove libvirt network ' +
netName,
c'mon man, what about %s ?
--
To view, visit http://gerrit.ovirt.org/4370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Avi Tal
Gerrit-Reviewer: Igor Lvovsky
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#797526 Lazy evaluation for Drive.blockDev
Federico Simoncelli has posted comments on this change. Change subject: BZ#797526 Lazy evaluation for Drive.blockDev .. Patch Set 1: > that's all?! now vdsm can be restarted when there is no connection to storage > server? good! Yes because if you look at _recoverExistingVms in clientIF even if the VM are recovered right away, the statistics (preparePaths) are started only after being re-connected to the pool. The issue here was that the Drive objects were created right away (when it was impossible to check if the paths were block devices) but they were used only later on when statistics kicked in. Lazy evaluation solved this problem. I'll send another patch about the automatic re-connection issue that I discovered. > In some point in time we could re-obtain isBlock from libvirt, but this patch > is good news. I'm not sure if we want this. We use the blockDev boolean when we create the libvirt XML for the VM, if later on we read it from libvirt it would be like having two different paths for the same thing (use utils.isBlockDevice when the VM isn't started yet, and then read it from libvirt when the VM is running). -- To view, visit http://gerrit.ovirt.org/4339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93bc95650544372cec8883a8b7b568ecf419c129 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make compression type configurable, support gzip and xz
Xu He Jie has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) File configure.ac Line 42: AC_PATH_PROG([XZ], [xz]) for logrotate compress type, I think it should not only decided by check. This check only test the build machine, it not on target machine. It should support configure argument like '--with-xz, --with-gzip'. if user didn't specific which one want to use, then it can be decide by check. -- To view, visit http://gerrit.ovirt.org/4174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Xu He Jie ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: MOM Integration
Dan Kenigsberg has posted comments on this change. Change subject: MOM Integration .. Patch Set 7: How about moving MOM development to gerrit.ovirt.org? ;-) I think that mom should receive an API object (even API.Global()!) that it needs for its operation. Even passing BindingXMLRPC() object is more APIish than the internal clientIF object. -- To view, visit http://gerrit.ovirt.org/2367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Shu Ming ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt: Fix dev type identifier for balloon devices
Mark Wu has posted comments on this change.
Change subject: libvirt: Fix dev type identifier for balloon devices
..
Patch Set 1: No score
I still think it's not a problem. I don't understand why you thought
"dev['type'] == vm.BALLOON_DEVICES" could never be true. "dev['type']" comes
from the the vm's conf, I can give a following configuration for it like what I
mentioned in my last comment:
{'device': 'memballoon', 'type': 'balloon', 'model': 'virtio'}
,then it can hold true. 'type' is just used for vdsm internal, not used in any
interaction with libvirt. So that should be not a problem.
Let me leave it as "no score" to get more opinions from others.
--
To view, visit http://gerrit.ovirt.org/4319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3bf6a1ede1df335b9e4bcc9a7324db9284ca4c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Mark Wu
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove /rhel/data-center after vdsm uninstalled
Xu He Jie has posted comments on this change.
Change subject: remove /rhel/data-center after vdsm uninstalled
..
Patch Set 5: No score
Another method is just mkdir -p @VDSMREPO@{/,hsm-taks, mnt}, don't chown these
directory. VDSM will chwon these directory at runtime. But this method still
can not execute autobuild.sh as non-root. It because /rhev/data-center didn't
effect by perfix.
--
To view, visit http://gerrit.ovirt.org/4026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27a697a5aa7cc3ebade7937ea6f6a293d6778168
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Gal Hammer
Gerrit-Reviewer: Ryan Harper
Gerrit-Reviewer: Xu He Jie
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: balloon - Enable the virtio balloon
Mark Wu has posted comments on this change. Change subject: hook: balloon - Enable the virtio balloon .. Patch Set 1: No score (1 inline comment) I still think we need a flag for it and hope to get opinions from other guys. File vdsm_hooks/balloon/before_vm_start.py Line 10: I still think that we need a flag for it. If we don't want to bring impact to the existing VMs, we should have a switch to disable the hook. Let's say I have several VMs running on a host. After upgrading vdsm containing this hook, the underlying device address could change. Actually, I can't figure out what problems it will cause. But if we do have concern about it, then we should have option to avoid it. -- To view, visit http://gerrit.ovirt.org/4316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Mark Wu ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes
Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 11: (2 inline comments) File vdsm/storage/blockSD.py Line 161: if vImg not in res[vName]['imgs']: but if, indeed, the self-image should always come first, this code is overly complex and misleading! Do you confirm? We can decide whether to rewrite it now, tomorrow, or never, but we should first agree on what this function does. File vdsm/storage/fileSD.py Line 279: if len(tuple(vPath for vPath in volMetaPaths > have no list this is a generator expression and we need an iterable ok, I've missed that. > this code was extensively tested I prefer to do performance I hope that once you have a unit test for this function, you would feel more confidence to reimplement it. Please do not dismiss this out-of-hand. -- To view, visit http://gerrit.ovirt.org/3462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...
Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers .. Patch Set 3: (2 inline comments) File vdsm/libvirtvm.py Line 864: doc = xml.dom.minidom.Document() Done Line 866: ['index', 'model', 'master', 'address']) master may be necessary to be able to set a different startport then the default if we ever want to do that, address will get assigned automatically by libvirt the first time the vm is created, but AFAIK after the first time ovirt will store the given address and specify it the next time so that hardware does not move around when a vm gets re-created later. Note that specifying of either is optional, if you don't specify any of these they simply won't be used. -- To view, visit http://gerrit.ovirt.org/4095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4fd6bed73cfa67fd6b29d3c352aebc7c25cff5f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Hans De Goede Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Oved Ourfali ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes
Eduardo has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
..
Patch Set 11: (3 inline comments)
File vdsm/storage/blockSD.py
Line 161: if vImg not in res[vName]['imgs']:
> Why not put the self-image first for EVERYTHING, when initializing res[vName]
> above?
Because the 1st for loop is an artefact.
In fact the self image of each volume is inserted at the head of the images
list.
Since this code was extensively tested in practice, I prefer leaving it this
way.
File vdsm/storage/fileSD.py
Line 63: sdUUID = len(os.path.normpath(config.get('irs',
'repository')).split('/')) + sdUUIDPos
os path is required below in the new code.
Line 279: if len(tuple(vPath for vPath in volMetaPaths
I'm converting nothing. I have no list this is a generator expression and we
need an iterable. Creating a tuple is cheaper than create a list.
Since we are talking about a finite number of volumes, and is done once
probably is faster this way than loading an extra module.
Anyway since this code was extensively tested I prefer to do performance
optimizations later.
IMHO better candidates for optimizations are the deleteImage and merge flows.
--
To view, visit http://gerrit.ovirt.org/3462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Haim Ateya
Gerrit-Reviewer: Igor Lvovsky
Gerrit-Reviewer: Saggi Mizrahi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: MOM Integration
Mark Wu has posted comments on this change. Change subject: MOM Integration .. Patch Set 7: Hi Dan, Thanks a lot for the review. I am going to revise the patch as per your comments. And the unittest will be included in next version too. The only problem needing more discussions is that how mom interacts with vdsm. Currently, vdsm passes the vdsm internal instance of clientIF to mom to enable mom call vdsm API functions defined in API.py. Let's think MOM is kind of plugin for vdsm, then it would make sense that passing cif to mom. Without cif, mom would have to interact with vdsm via xmlrpc. In that case, mom works like a standalone application on system. So which idea do you like more? Any other suggestions? Thanks! -- To view, visit http://gerrit.ovirt.org/2367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Shu Ming ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make compression type configurable, support gzip and xz
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: sorry. a mistake. xz is Higher compression efficiency than gzip. vdsm-4.9.6.tar.xz is 455924 bytes vdsm-4.9.6.tar.gz is 671156 bytes -- To view, visit http://gerrit.ovirt.org/4174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Xu He Jie ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make compression type configurable, support gzip and xz
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: xz is Higher compression efficiency than gzip. vdsm-4.9.6.tar.gz is 455924 bytes vdsm-4.9.6.tar.xz is 671156 bytes -- To view, visit http://gerrit.ovirt.org/4174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Xu He Jie ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
