Change in vdsm[master]: vm: fix _devices access in _highWrite
Ayal Baron has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
..
Patch Set 3:
(2 comments)
File vdsm/vm.py
Line 2280: self.log.debug('new rtc offset %s', timeOffset)
Line 2281: with self._confLock:
Line 2282: self.conf['timeOffset'] = timeOffset
Line 2283:
Line 2284: def checkDrivesForExtension(self):
this isn't 'checking' this is actually extending
Line 2285: extend = []
Line 2286:
Line 2287: for drive in self._devices[DISK_DEVICES]:
Line 2288: if not drive.blockDev or drive.format != 'cow':
Line 2299: "capacity %s for volume %s on domain %s", alloc,
Line 2300: capacity, drive.domainID, drive.volumeID)
Line 2301: self.pause(pauseCode='EOTHER')
Line 2302:
Line 2303: for drive, capacity, alloc, physical in extend:
Sergey is correct, I don't deem it safe to extend any drive if VM has a device
with alloc > capacity
Line 2304: self.log.info('%s/%s apparent: %s capacity: %s, alloc:
%s, '
Line 2305: 'physical: %s', drive.domainID,
drive.volumeID,
Line 2306: drive.apparentsize, capacity, alloc,
physical)
Line 2307: self.extendDriveVolume(drive)
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sergey Gotliv
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get oop from object instance
Shu Ming has abandoned this change. Change subject: Get oop from object instance .. Abandoned See Mark's comment -- To view, visit http://gerrit.ovirt.org/8920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia6b86f2c5e382774003772837e32bd62f8ad29ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Zhou Zheng Sheng ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get oop from object instance
Zhou Zheng Sheng has posted comments on this change. Change subject: Get oop from object instance .. Patch Set 2: -Code-Review Looks like it should be abandoned according to Mark Wu's last comments. -- To view, visit http://gerrit.ovirt.org/8920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6b86f2c5e382774003772837e32bd62f8ad29ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate quemu-kvm coredumps using abrt
Dan Kenigsberg has posted comments on this change. Change subject: generate quemu-kvm coredumps using abrt .. Patch Set 1: (1 comment) Commit Message Line 3: AuthorDate: 2013-10-30 16:02:10 +0200 Line 4: Commit: Mooli Tayer Line 5: CommitDate: 2013-10-30 16:02:10 +0200 Line 6: Line 7: generate quemu-kvm coredumps using abrt I have a thing for spelling qemu correctly ;-) Line 8: Line 9: Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 -- To view, visit http://gerrit.ovirt.org/20751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Iscsi rescan cleanup
Dan Kenigsberg has submitted this change and it was merged. Change subject: iscsi: Iscsi rescan cleanup .. iscsi: Iscsi rescan cleanup * Remove forceIscsiScan(): iscsiadm already does that when refreshing sessions * Cleanup iscsi.rescan(): Replace complex logic with a simpler implementation since new iscsiadm takes care of all of this itself * Make iscsi.rescan() more testable * Test confusing timeout semantics of iscsi.rescan() Bug-Url: https://bugzilla.redhat.com/964595 Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Signed-off-by: Saggi Mizrahi Reviewed-on: http://gerrit.ovirt.org/19256 Reviewed-by: Yaniv Bronhaim Reviewed-by: Federico Simoncelli Reviewed-by: Dan Kenigsberg --- M tests/Makefile.am A tests/iscsiTests.py M vdsm.spec.in M vdsm/storage/iscsi.py M vdsm/storage/iscsiadm.py M vdsm/storage/multipath.py M vdsm/supervdsmServer 7 files changed, 111 insertions(+), 62 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Saggi Mizrahi: Verified Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Iscsi rescan cleanup
Dan Kenigsberg has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change netinfo gateway default value from 0.0.0.0 to ''
Dan Kenigsberg has posted comments on this change. Change subject: Change netinfo gateway default value from 0.0.0.0 to '' .. Patch Set 2: Code-Review-1 (2 comments) Commit Message Line 5: CommitDate: 2013-11-06 10:45:41 +0200 Line 6: Line 7: Change netinfo gateway default value from 0.0.0.0 to '' Line 8: Line 9: Previously, if a device does not have an ip addr, netmask and three tenses (previously, does, will) in one sentence is too much for me ;-) Line 10: gateway then netinfo will report the ipaddr as '', netmask as '' Line 11: and gateway as '0.0.0.0'. Line 12: Line 13: The change (From '0.0.0.0' to '') is important both for consistency File lib/vdsm/netinfo.py Line 339: return '' Line 340: return prefix2netmask(netmask) Line 341: Line 342: Line 343: def getgateway(dev): getRoutes() is a relatively-expensive function. This patch makes it run per network instead of once. I understand the stylistic superiority of your suggested getgateway(), but do not think it's worth O(n) executions of `ip route`. Please spin this re-factoring to its own patch, and keep this one focused on the changed value. Line 344: return getRoutes().get(dev, '') Line 345: Line 346: Line 347: def getIpInfo(dev): -- To view, visit http://gerrit.ovirt.org/20912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lior Vernia Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)
Dan Kenigsberg has posted comments on this change. Change subject: cleanup: Improve lib/vdsm imports (PEP328) .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)
Dan Kenigsberg has submitted this change and it was merged. Change subject: cleanup: Improve lib/vdsm imports (PEP328) .. cleanup: Improve lib/vdsm imports (PEP328) PEP328 ( http://www.python.org/dev/peps/pep-0328/ ) does away with the ambiguity of where the modules that are being imported reside making the codebase much more browsable. With a codebase of: package/ __init__.py subpackage1/ __init__.py moduleX.py moduleY.py subpackage2/ __init__.py moduleZ.py moduleA.py this (moduleY.py): import moduleX import moduleZ becomes from . import moduleX from ..subpackage2 import moduleZ Which makes it much more evident where things are and avoids possible shadowing of packages in site-packages. Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/20555 Reviewed-by: Yaniv Bronhaim Reviewed-by: Dan Kenigsberg --- M lib/vdsm/SecureXMLRPCServer.py M lib/vdsm/ipwrapper.py M lib/vdsm/libvirtconnection.py M lib/vdsm/netconfpersistence.py M lib/vdsm/netinfo.py M lib/vdsm/qemuImg.py M lib/vdsm/tool/dummybr.py M lib/vdsm/tool/libvirt_configure.py M lib/vdsm/tool/load_needed_modules.py.in M lib/vdsm/tool/nwfilter.py M lib/vdsm/tool/passwd.py M lib/vdsm/tool/restore_nets.py M lib/vdsm/tool/sanlock.py M lib/vdsm/tool/seboolsetup.py M lib/vdsm/tool/service.py M lib/vdsm/tool/transient.py M lib/vdsm/tool/validate_ovirt_certs.py.in M lib/vdsm/tool/vdsm-id.py M lib/vdsm/utils.py M lib/vdsm/vdscli.py.in 20 files changed, 57 insertions(+), 57 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fix ballooning rules for computing the minimum available memory
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix ballooning rules for computing the minimum available memory .. Fix ballooning rules for computing the minimum available memory Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Reviewed-on: http://gerrit.ovirt.org/20849/ Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025845 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/20906 Reviewed-by: Yaniv Bronhaim --- M vdsm/mom.d/02-balloon.policy 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Verified Yaniv Bronhaim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add ut to supervdsmServer zombie reaper
Itamar Heim has posted comments on this change. Change subject: Add ut to supervdsmServer zombie reaper .. Patch Set 3: ping? -- To view, visit http://gerrit.ovirt.org/9354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fb8f3dcd575266febe11967e3f8df7d3588acb8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get oop from object instance
Itamar Heim has posted comments on this change. Change subject: Get oop from object instance .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/8920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6b86f2c5e382774003772837e32bd62f8ad29ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add emulator pin support to create vm
Itamar Heim has posted comments on this change. Change subject: add emulator pin support to create vm .. Patch Set 12: ping? -- To view, visit http://gerrit.ovirt.org/8411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic616b825eca94682e1563ab51773d8a23351998d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Laszlo Hornyak Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add verb for vdsm to tuneCpu params
Itamar Heim has posted comments on this change. Change subject: add verb for vdsm to tuneCpu params .. Patch Set 8: ping? -- To view, visit http://gerrit.ovirt.org/7492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e02e09ef06ad6de45be75c3f2f913a3025750f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Laszlo Hornyak Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add xmlrpcTests for cpu pinning
Itamar Heim has posted comments on this change. Change subject: add xmlrpcTests for cpu pinning .. Patch Set 6: ping -- To view, visit http://gerrit.ovirt.org/8412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Laszlo Hornyak Gerrit-Reviewer: Noam Slomianko Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: avoid race between load dev rules and trigger the rule
Itamar Heim has posted comments on this change. Change subject: avoid race between load dev rules and trigger the rule .. Patch Set 5: ping? -- To view, visit http://gerrit.ovirt.org/6780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I718d62e67b0a228f2510233c5dd9d1d94c4a736c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Xu He Jie Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add build-dep packages so yum-builddep is effective
Itamar Heim has posted comments on this change. Change subject: Add build-dep packages so yum-builddep is effective .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/7955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b96b5b30a9efea06261f40d1f6df61754b8253 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Ryan Harper Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Encapsulate vdsm-unregister into vdsm-tool function
Itamar Heim has posted comments on this change. Change subject: Encapsulate vdsm-unregister into vdsm-tool function .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/4527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7348baeabbdcbb0c2da64170b6957430feaa1954 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: Wenyi Gao Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Sergey Gotliv has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
..
Patch Set 3:
(1 comment)
File vdsm/vm.py
Line 2297: self.log.error(
Line 2298: "Allocated size %s cannot be higher than the
disk "
Line 2299: "capacity %s for volume %s on domain %s", alloc,
Line 2300: capacity, drive.domainID, drive.volumeID)
Line 2301: self.pause(pauseCode='EOTHER')
It looks like you change original logic:
One of previous comments was that there is no need to extend drives if one of
them has alloc > capacity.
Line 2302:
Line 2303: for drive, capacity, alloc, physical in extend:
Line 2304: self.log.info('%s/%s apparent: %s capacity: %s, alloc:
%s, '
Line 2305: 'physical: %s', drive.domainID,
drive.volumeID,
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add createVm support of cputune
Itamar Heim has posted comments on this change. Change subject: add createVm support of cputune .. Patch Set 9: ping? -- To view, visit http://gerrit.ovirt.org/8445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Laszlo Hornyak Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Royce Lv Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4463/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5264/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5342/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Federico Simoncelli has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 3: (2 comments) Commit Message Line 3: AuthorDate: 2013-11-06 08:50:57 -0500 Line 4: Commit: Federico Simoncelli Line 5: CommitDate: 2013-11-06 12:46:50 -0500 Line 6: Line 7: vm: fix _devices access in _highWrite We probably need a new commit message. Line 8: Line 9: Main focus of this patch was to fix two attribute errors: Line 10: Line 11: - self._devices (in VmStatsThread._extendVmDrives) Line 14: It soon appeared clear that it would have been more logical to Line 15: move _extendVmDrives to the VM object in order to solve them all Line 16: at once. Line 17: Line 18: In this patch: Maybe we need to split all this. As far as I'm concerned I'd prefer to keep them all together. Line 19: - rename _extendVmDrives to checkDrivesForExtension and move it Line 20: to the Vm object Line 21: - remove (the now unused) InvalidAllocError Line 22: - move the "No VM drives were extended" logging message to the -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove onboot, delay from setupNetworks API
Assaf Muller has posted comments on this change. Change subject: Remove onboot, delay from setupNetworks API .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/20967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Federico Simoncelli has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
..
Patch Set 2:
(2 comments)
File vdsm/vm.py
Line 509: capacity, alloc, physical = self._vm._dom.blockInfo(
Line 510: drive.path, 0)
Line 511:
Line 512: if physical < alloc:
Line 513: raise InvalidAllocError('Implausible alloc %s >
physical %s '
This is actually possible. When we're hitting ENOSPC the allocated space is
slightly larger (which is actually the required space). E.g. as it just
happened to me, allocated 271187456 and physical 268435456 (256Mb) (I use
chunks of 128Mb vs 1G in order to better test the extensions).
Line 514: 'in volume %s.' %
Line 515: (alloc, physical, drive.path))
Line 516:
Line 517: if physical - alloc < drive.watermarkLimit:
Line 4294: if err.upper() == 'ENOSPC':
Line 4295: drives = [vmDrive for vmDrive in
self._devices[DISK_DEVICES]
Line 4296: if vmDrive.alias == blockDevAlias]
Line 4297: try:
Line 4298: if not self._extendVmDrives(drives):
Moving _extendVmDrives to the VM object.
Line 4299: self._log.info("No VM drives were extended")
Line 4300: except InvalidAllocError as e:
Line 4301: self._log.error("Error extending VM drives: %s", e)
Line 4302:
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Sergey Gotliv has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 2: Federico, 1. Please, add a bug url, without that fix my fix of highWrite is useless. 2. Can you just move _extendDrives to VM? Let's remember that unfortunately I left VDSM in a bad shape after my patch, so I want a quick fix here. -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Federico Simoncelli has posted comments on this change.
Change subject: vm: fix _devices access in _highWrite
..
Patch Set 2: Code-Review-1
(1 comment)
File vdsm/vm.py
Line 4294: if err.upper() == 'ENOSPC':
Line 4295: drives = [vmDrive for vmDrive in
self._devices[DISK_DEVICES]
Line 4296: if vmDrive.alias == blockDevAlias]
Line 4297: try:
Line 4298: if not self._extendVmDrives(drives):
Actually this is wrong, _extendVmDrives is part of the VmStatsThread object.
Line 4299: self._log.info("No VM drives were extended")
Line 4300: except InvalidAllocError as e:
Line 4301: self._log.error("Error extending VM drives: %s", e)
Line 4302:
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: pre-validate disks for snapshot
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: pre-validate disks for snapshot .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4461/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5262/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5340/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fb507c2f7268bb688af5fd187dcd033d0a068a2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 31: Verified+1 -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: allow live snapshot to any volume descendant
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: allow live snapshot to any volume descendant .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4462/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5263/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5341/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib50243c93665b9ab47ae70c779b7a1eb37c5e473 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: allow live snapshot to any volume descendant
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: allow live snapshot to any volume descendant
..
vm: allow live snapshot to any volume descendant
When a live snapshot fails qemu might not be using the newly-created
leaf and the volume cleanup is at management discrection (sometime too
risky or even impossible).
In this particular situation (active layer not being the volume leaf)
a subsequent live snapshot would have failed as the baseVolumeID was
not the expected one.
This patch relaxes the volumes checks allowing a live snapshot on the
volume leaf even when it's not the direct descendant of the current
active layer.
Similarly also the check in hotunplugDisk has been relaxed so that
it's now possible to hotunplug a disk with a failed live snapshot.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018867
Change-Id: Ib50243c93665b9ab47ae70c779b7a1eb37c5e473
Signed-off-by: Federico Simoncelli
---
M vdsm/vm.py
1 file changed, 31 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/20986/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index e716870..14e6a0c 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -3409,7 +3409,7 @@
diskParams['path'] = self.cif.prepareVolumePath(diskParams)
try:
-drive = self._findDriveByUUIDs(diskParams)
+drive = self._findDriveByImage(diskParams)
except LookupError:
self.log.error("Hotunplug disk failed - Disk not found: %s",
diskParams)
@@ -3535,19 +3535,25 @@
return device
raise LookupError("No such drive: '%s'" % name)
+def _findDriveByImage(self, drive):
+"""Find a drive given is domainID and imageID"""
+tgetDrv = (drive["domainID"], drive["imageID"])
+
+for device in self._devices[DISK_DEVICES][:]:
+if not hasattr(device, "domainID"):
+continue
+if (device.domainID, device.imageID) == tgetDrv:
+return device
+
+raise LookupError("No such drive: '%s'" % drive)
+
def _findDriveByUUIDs(self, drive):
"""Find a drive given its definition"""
if "domainID" in drive:
-tgetDrv = (drive["domainID"], drive["imageID"],
- drive["volumeID"])
-
-for device in self._devices[DISK_DEVICES][:]:
-if not hasattr(device, "domainID"):
-continue
-if (device.domainID, device.imageID,
-device.volumeID) == tgetDrv:
-return device
+device = self._findDriveByImage(drive)
+if device.volumeID == drive.get("volumeID", None):
+return device
elif "GUID" in drive:
for device in self._devices[DISK_DEVICES][:]:
@@ -3697,10 +3703,10 @@
continue # Next drive
try:
-vmDrive = self._findDriveByUUIDs(baseDrv)
+vmDrive = self._findDriveByImage(baseDrv)
except LookupError:
-# The volume we want to snapshot doesn't exist
-self.log.error("The base volume doesn't exist: %s", baseDrv)
+# The disk we want to snapshot doesn't exist
+self.log.error("The disk doesn't exist: %s", baseDrv)
return errCode['snapshotErr']
if vmDrive.hasVolumeLeases:
@@ -3711,6 +3717,18 @@
self.log.error("Disk %s is a transient disk", vmDrive.name)
return errCode['transientErr']
+volumeInfo = self.cif.irs.getVolumeInfo(
+tgetDrv['domainID'], vmDrive.poolID, tgetDrv['imageID'],
+tgetDrv['volumeID'])
+
+if volumeInfo.get("status", {}).get("code") != 0:
+self.log.error("Unable to get volume info for: %s", tgetDrv)
+return errCode["snapshotErr"]
+
+if volumeInfo["info"]["voltype"] != "LEAF":
+self.log.error("Volume %s is not a volume leaf", tgetDrv)
+return errCode["snapshotErr"]
+
vmDevName = vmDrive.name
newDrives[vmDevName] = tgetDrv.copy()
--
To view, visit http://gerrit.ovirt.org/20986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib50243c93665b9ab47ae70c779b7a1eb37c5e473
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fix ballooning rules for computing the minimum available memory
Martin Sivák has posted comments on this change. Change subject: Fix ballooning rules for computing the minimum available memory .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/20906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fix ballooning rules for computing the minimum available memory
Yaniv Bronhaim has posted comments on this change. Change subject: Fix ballooning rules for computing the minimum available memory .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 31: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4459/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5261/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5339/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: Improve lib/vdsm imports (PEP328) .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/767/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5328/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4460/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 14: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4458/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5338/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Dan Kenigsberg has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fix ballooning rules for computing the minimum available memory
Yaniv Bronhaim has posted comments on this change. Change subject: Fix ballooning rules for computing the minimum available memory .. Patch Set 1: (1 comment) Commit Message Line 6: Line 7: Fix ballooning rules for computing the minimum available memory Line 8: Line 9: Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025845 http://gerrit.ovirt.org/#/c/20849/ found it . please add the link -- To view, visit http://gerrit.ovirt.org/20906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fix ballooning rules for computing the minimum available memory
Yaniv Bronhaim has posted comments on this change. Change subject: Fix ballooning rules for computing the minimum available memory .. Patch Set 1: Code-Review-1 (1 comment) Commit Message Line 6: Line 7: Fix ballooning rules for computing the minimum available memory Line 8: Line 9: Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025845 please add link to the reviewed patch on master branch -- To view, visit http://gerrit.ovirt.org/20906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol
oVirt Jenkins CI Server has posted comments on this change. Change subject: Enhanced netinfo.getBootProtocol .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/769/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4457/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5259/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5337/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 11: Jenkins failure unrelated to patch's code. -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 14: Verified+1 Verification: Compared manually what the unified network persistence produces and what the upgrade produces for the following networking permutations: IP: none, dhcp, static Topology: nic or bond, vlan or non-vlan, bridged or non-bridged Total 24 combinations. I then used most of the functional tests to see what they produce and what the upgrade produces. -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4456/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5258/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5336/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 13:
(5 comments)
Commit Message
Line 6:
Line 7: Unified network persistence [4.2/4.*] - Upgrade updates running conf
Line 8:
Line 9: Run a VDSM upgrade that gathers net info and updates the running
Line 10: config of the unified network persistence.
Done
Line 11:
Line 12: To-Do:
Line 13: * Bonds that don't have a network over them are unnoticed
Line 14:
File lib/vdsm/tool/Makefile.am
Line 43:restore_nets.py \
Line 44:sanlock.py \
Line 45:seboolsetup.py \
Line 46:service.py \
Line 47:unifiedPersistence.py \
Done
Line 48:upgrade.py \
Line 49:vdsm-id.py \
Line 50:$(NULL)
Line 51:
File lib/vdsm/tool/unifiedPersistence.py
Line 41: except TypeError:
Line 42: return value
Line 43:
Line 44: def _getNetInfo(self):
Line 45: _netinfo = NetInfo()
Done
Line 46: networks = {}
Line 47: bondings = {}
Line 48: whitelist = ['bridged', 'mtu', 'qosInbound', 'qosOutbound']
Line 49: toCaps = ['stp']
Line 110: runningConfig.store()
Line 111:
Line 112:
Line 113: @expose('unifiedPersistence')
Line 114: def main():
Done
Line 115: unifiedPersistenceUpgrade = UnifiedPersistence()
Line 116: upgradeName = UnifiedPersistence.__name__
Line 117: upgrade = Upgrade(upgradeName)
Line 118:
Line 116: upgradeName = UnifiedPersistence.__name__
Line 117: upgrade = Upgrade(upgradeName)
Line 118:
Line 119: if upgrade.isNeeded() and unifiedPersistenceUpgrade.isNeeded():
Line 120: upgrade.log.debug("Running upgrade %s" % upgradeName)
Still under discussion in previous patch.
Line 121: unifiedPersistenceUpgrade.run()
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 30:
(3 comments)
File init/sysvinit/vdsmd.init.in
Line 208: reconfigure "$@"
Line 209: RETVAL=$?
Line 210: ;;
Line 211: *)
Line 212: echo "Usage: $0
{start|stop|status|restart|force-reload|try-restart|condrestart|reconfigure
[force]}"
right
Line 213: RETVAL=2
Line 214: esac
Line 215:
File vdsm.spec.in
Line 732: %{_bindir}/vdsm-tool service-stop supervdsmd >/dev/null 2>&1
Line 733: supervdsmd_start_required='yes'
Line 734: fi
Line 735:
Line 736: %{_bindir}/vdsm-tool configure --force >/dev/null 2>&1
dan commented before that we need to swallow stderr in spec operations. we
can't solve it
Line 737:
Line 738: if [ "${supervdsmd_start_required}" = 'yes' ]; then
Line 739: %{_bindir}/vdsm-tool service-start supervdsmd >/dev/null 2>&1
Line 740: fi
Line 733: supervdsmd_start_required='yes'
Line 734: fi
Line 735:
Line 736: %{_bindir}/vdsm-tool configure --force >/dev/null 2>&1
Line 737:
and.. only libvirt configure is relevant during upgrade. we don't want to force
sanlock restart
Line 738: if [ "${supervdsmd_start_required}" = 'yes' ]; then
Line 739: %{_bindir}/vdsm-tool service-start supervdsmd >/dev/null 2>&1
Line 740: fi
Line 741: if [ "${vdsmd_start_required}" = 'yes' ]; then
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol
Assaf Muller has posted comments on this change. Change subject: Enhanced netinfo.getBootProtocol .. Patch Set 11: Verified+1 Empty rebase. -- To view, visit http://gerrit.ovirt.org/18484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Alon Bar-Lev has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 30:
(2 comments)
File init/sysvinit/vdsmd.init.in
Line 208: reconfigure "$@"
Line 209: RETVAL=$?
Line 210: ;;
Line 211: *)
Line 212: echo "Usage: $0
{start|stop|status|restart|force-reload|try-restart|condrestart|reconfigure
[force]}"
this is not supported now, so reconfigure should not be exposed, it is backward
compatibility internal usage now.
Line 213: RETVAL=2
Line 214: esac
Line 215:
File vdsm.spec.in
Line 732: %{_bindir}/vdsm-tool service-stop supervdsmd >/dev/null 2>&1
Line 733: supervdsmd_start_required='yes'
Line 734: fi
Line 735:
Line 736: %{_bindir}/vdsm-tool configure --force >/dev/null 2>&1
this will not show errors if exist... how can we solve issues?
Line 737:
Line 738: if [ "${supervdsmd_start_required}" = 'yes' ]; then
Line 739: %{_bindir}/vdsm-tool service-start supervdsmd >/dev/null 2>&1
Line 740: fi
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 30:
(1 comment)
File vdsm.spec.in
Line 733: supervdsmd_start_required='yes'
Line 734: fi
Line 735:
Line 736: %{_bindir}/vdsm-tool configure --force >/dev/null 2>&1
Line 737:
oh.. this is wrong .. it shouldn't force to reconfigure if already configured..
it should force restarting of related services, but not if already configured
which both are swallowed in the --force flag.
Line 738: if [ "${supervdsmd_start_required}" = 'yes' ]; then
Line 739: %{_bindir}/vdsm-tool service-start supervdsmd >/dev/null 2>&1
Line 740: fi
Line 741: if [ "${vdsmd_start_required}" = 'yes' ]; then
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 30: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4455/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5257/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5335/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Update of vdsmd usage
Yaniv Bronhaim has abandoned this change. Change subject: Update of vdsmd usage .. Abandoned squashed to http://gerrit.ovirt.org/#/c/20100/27 -- To view, visit http://gerrit.ovirt.org/20677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id1f2700a4ac2f869ded61f1ba6b5e05b03216348 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Using new vdsm-tool configurer API on upgrade flow
Yaniv Bronhaim has abandoned this change. Change subject: Using new vdsm-tool configurer API on upgrade flow .. Abandoned squashed to http://gerrit.ovirt.org/#/c/20100/27 -- To view, visit http://gerrit.ovirt.org/20149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4a8c9c548b7a23588107b17351ab7f9ba3ae1d2b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 29: Thanks for the acks! squashing to this patch the following once, no reason to separate them -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for multiple iSCSI interfaces
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for multiple iSCSI interfaces .. Patch Set 1: No Builds Executed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4454/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5256/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5334/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/20981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ea11855623a9fa8398a1027b55ba7ac335998b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Goldstone Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Sandro Bonazzola has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 29: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)
Yaniv Bronhaim has posted comments on this change. Change subject: cleanup: Improve lib/vdsm imports (PEP328) .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Alon Bar-Lev has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 29: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 29: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4453/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5255/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5333/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 29: Verified+1 fedora 19 - checked rhel 6.4 - checked reverify me will be appreciated very much thanks -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Sergey Gotliv has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 2: Code-Review+1 Nice! -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4452/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5254/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5332/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Federico Simoncelli has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 2: (1 comment) File vdsm/vm.py Line 500: self._vm.pause(pauseCode='EOTHER') Line 501: Line 502: def _extendVmDrives(self, vmDrives): Line 503: extend = [] Line 504: Sorry, I tried, but I couldn't resist it :-) Line 505: for drive in vmDrives: Line 506: if not drive.blockDev or drive.format != 'cow': Line 507: continue Line 508: -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove onboot, delay from setupNetworks API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove onboot, delay from setupNetworks API .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/768/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4451/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5253/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5331/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove onboot, delay from setupNetworks API
Assaf Muller has uploaded a new change for review.
Change subject: Remove onboot, delay from setupNetworks API
..
Remove onboot, delay from setupNetworks API
The engine never sends those keys. If they are sent, however,
as part of a network those values are written as is to the ifcfg
files like other keys sent as part of a network. For example:
setupNetworks({'nonVM': {'bridged': False, 'nic': 'dummy0',
'onboot': 'no'}}, {}, {})
Will write 'ONBOOT=no' to ifcfg-dummy0, both before and after
this patch. The patch just removes all explicit references
to onboot and delay in the code and API documentation.
Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2
Signed-off-by: Assaf Muller
---
M vdsm/API.py
M vdsm/configNetwork.py
M vdsm_api/vdsmapi-schema.json
3 files changed, 2 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/20967/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 6b46db7..48eecc6 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1520,8 +1520,6 @@
'PREFIX': 'prefix',
'GATEWAY': 'gateway',
'BOOTPROTO': 'bootproto',
-'DELAY': 'delay',
-'ONBOOT': 'onboot',
'BONDING_OPTS': 'bondingOptions',
}
for k, v in options.items():
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 45b2893..0f3672a 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -523,8 +523,6 @@
ipv6gateway=""
ipv6autoconf="0|1"
dhcpv6="0|1"
-delay="..."
-onboot="yes"|"no"
(other options will be passed to the config file AS-IS)
-- OR --
remove=True (other attributes can't be specified)
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 72848f8..3a006e6 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -57,10 +57,6 @@
# @bootproto: #optional Interface autoconfiguration protocol (typically
# 'dhcp' or 'static')
#
-# @delay: #optional The time to wait before starting the interface
-#
-# @onboot: #optional Start the interface automatically during boot
-#
# @bondingOptions: #optional A string of space-separated =
pairs
#
# @qosInbound: #optional BandwidthParams for incoming traffic.
@@ -71,8 +67,7 @@
##
{'type': 'NetworkOptions',
'data': {'*ipaddr': 'str', '*netmask': 'str', '*gateway': 'str',
- '*bootproto': 'str', '*delay': 'uint', '*onboot': 'str',
- '*bondingOptions', 'str',
+ '*bootproto': 'str', '*bondingOptions', 'str',
'*qosInbound': 'BandwidthParams',
'*qosOutbound': 'BandwidthParams'}}
@@ -163,10 +158,6 @@
# @bootproto: #optional Interface autoconfiguration protocol (typically
'dhcp'
# or 'static')
#
-# @delay: #optional The time to wait before starting the network device
-#
-# @onboot:#optional Start the network device automatically during boot
-#
# @remove:#optional If True, remove existing network only
#
# @qosInbound:#optional BandwidthParams for incoming traffic.
@@ -178,7 +169,7 @@
{'type': 'SetupNetworkNetAttributes',
'data': {'*vlan': 'str', '*bonding': 'str', '*nic': ['str'], '*ipaddr': 'str',
'*netmask': 'str', '*gateway': 'str', '*bootproto': 'str',
- '*delay': 'uint', '*onboot': 'bool', '*remove': 'bool',
+ '*remove': 'bool',
'*qosInbound': 'BandwidthParams',
'*qosOutbound': 'BandwidthParams'}}
##
--
To view, visit http://gerrit.ovirt.org/20967
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Sergey Gotliv has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix _devices access in _highWrite .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4450/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5252/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5330/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix _devices access in _highWrite
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: fix _devices access in _highWrite
..
vm: fix _devices access in _highWrite
Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Signed-off-by: Federico Simoncelli
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/20966/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 796735f..91cc0e8 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -494,7 +494,7 @@
return
try:
-self._extendVmDrives(self._devices[DISK_DEVICES])
+self._extendVmDrives(self._vm._devices[DISK_DEVICES])
except InvalidAllocError as e:
self._log.error("Error extending VM drives: %s", e)
self._vm.pause(pauseCode='EOTHER')
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: refactor buildConfDevices and getConfDevices into sing...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: refactor buildConfDevices and getConfDevices into single function .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4449/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5329/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3a209967f97a55fe861c4446e8f93e1a1da08e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fix ballooning rules for computing the minimum available memory
Dan Kenigsberg has posted comments on this change. Change subject: Fix ballooning rules for computing the minimum available memory .. Patch Set 1: Code-Review+2 Doron, please ask for +1 permissions on infra@ovirt - everybody should be able to give it (and certainly you). -- To view, visit http://gerrit.ovirt.org/20906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie416db6580462bbd16e80bea0a4e339656eccb0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: Improve lib/vdsm imports (PEP328) .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4448/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5328/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/767/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change netinfo gateway default value from 0.0.0.0 to ''
Lior Vernia has posted comments on this change. Change subject: Change netinfo gateway default value from 0.0.0.0 to '' .. Patch Set 2: Code-Review+1 Looks safe on engine side. -- To view, visit http://gerrit.ovirt.org/20912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)
Antoni Segura Puimedon has posted comments on this change. Change subject: cleanup: Improve lib/vdsm imports (PEP328) .. Patch Set 5: Verified on el6. It didn't need the future statement (that was for python 2.5. Tried to get vdscaps, ran all the networking tests and ran some vdsm-tool commands. -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: Improve lib/vdsm imports (PEP328) .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/766/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4448/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5328/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)
Antoni Segura Puimedon has posted comments on this change. Change subject: cleanup: Improve lib/vdsm imports (PEP328) .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change netinfo gateway default value from 0.0.0.0 to ''
Antoni Segura Puimedon has posted comments on this change. Change subject: Change netinfo gateway default value from 0.0.0.0 to '' .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4447/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5249/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5327/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev Gerrit-Reviewer: Alex Lourie Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
Sergey Gotliv has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change netinfo gateway default value from 0.0.0.0 to ''
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change netinfo gateway default value from 0.0.0.0 to '' .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5326/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4445/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change netinfo gateway default value from 0.0.0.0 to ''
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change netinfo gateway default value from 0.0.0.0 to '' .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4441/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5326/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 3: Code-Review-1
(1 comment)
File lib/vdsm/tool/libvirt_configure.sh.in
Line 35: # update the libvirt configure file every time we change vdsm package
Line 36: # version. In fact the configure generated here is almost unrelated to
the
Line 37: # package version, so anything meaningful can be used here. Since a
hard
Line 38: # coded version string has been already used, for compatibility we will
Line 39: # continue to use this string.
please fix
Line 40: BY_VDSM_VERS="4.10.3"
Line 41:
Line 42: [ "${ENABLE_LIBVIRT_SANLOCK}" = "yes" ] || QLCONF="/dev/null"
Line 43:
--
To view, visit http://gerrit.ovirt.org/17058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev
Gerrit-Reviewer: Alex Lourie
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Peter V. Saveliev
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 27:
(1 comment)
File lib/vdsm/tool/libvirt_configure.sh.in
Line 103: # so continue to use system default init mechanism
Line 104: return 0
Line 105: fi
Line 106:
Line 107: "@CHKCONFIG_PATH@" libvirtd off
no its not. if you use --force flag it can be run even if configured.
Line 108:
Line 109: if ! diff -q "${packaged}" "${target}" >/dev/null 2>&1; then
Line 110: /bin/cp -p "${packaged}" "${target}" || return 1
Line 111: /sbin/initctl reload-configuration
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 28: -Verified Thanks. checking .. -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change netinfo gateway default value from 0.0.0.0 to ''
Assaf Muller has posted comments on this change. Change subject: Change netinfo gateway default value from 0.0.0.0 to '' .. Patch Set 2: Jenkins failures are unrelated to this patch. -- To view, visit http://gerrit.ovirt.org/20912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Sandro Bonazzola has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 28: Verified-1 vdsm-tool configure --force lead to vdsmd inactive dead for me. -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
Allon Mureinik has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Update of the guest memory stats schema
Martin Sivák has posted comments on this change. Change subject: Update of the guest memory stats schema .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6326ecac58e459cc73b87274cb18e8a3cf2ab41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el// : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5248/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5325/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Dan Kenigsberg has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 27:
(1 comment)
File lib/vdsm/tool/libvirt_configure.sh.in
Line 103: # so continue to use system default init mechanism
Line 104: return 0
Line 105: fi
Line 106:
Line 107: "@CHKCONFIG_PATH@" libvirtd off
If indeed this code now runs only when you must configure (check), then you can
keep the change.
Line 108:
Line 109: if ! diff -q "${packaged}" "${target}" >/dev/null 2>&1; then
Line 110: /bin/cp -p "${packaged}" "${target}" || return 1
Line 111: /sbin/initctl reload-configuration
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
Nir Soffer has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 3: Address allon comments -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 28: Verified+1 -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
Allon Mureinik has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 2: (2 comments) Commit Message Line 9: Commit 15c7f74365cb5 introduced a regression where multipath rescan is Line 10: never performed if a device is missing when scanning devices. This can Line 11: cause a host to become non-operational when extending a vg. Line 12: Line 13: The orignal code used a lambda to create an named function, to be used s/an/a/ Line 14: in map call later. lambdas have their use, but they are poor choice for Line 15: a named function. Due to lambda syntax limitations and pep8 indentation Line 16: police, it was hard to notice that the lambda returned a tuple and not a Line 17: boolean, creating list of non-empty tuples. Applying all() to such list Line 10: never performed if a device is missing when scanning devices. This can Line 11: cause a host to become non-operational when extending a vg. Line 12: Line 13: The orignal code used a lambda to create an named function, to be used Line 14: in map call later. lambdas have their use, but they are poor choice for I'd lose this sentance (labdas have their use, etc.) Line 15: a named function. Due to lambda syntax limitations and pep8 indentation Line 16: police, it was hard to notice that the lambda returned a tuple and not a Line 17: boolean, creating list of non-empty tuples. Applying all() to such list Line 18: returns always True. Finally this code path was not verified, probably -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: performs peer detach using host UUID if provided
Aravinda VK has posted comments on this change. Change subject: gluster: performs peer detach using host UUID if provided .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Update of the guest memory stats schema
oVirt Jenkins CI Server has posted comments on this change. Change subject: Update of the guest memory stats schema .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4443/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5247/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5324/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6326ecac58e459cc73b87274cb18e8a3cf2ab41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
Nir Soffer has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 2: Address Allon comments. -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
Nir Soffer has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 1: (5 comments) Commit Message Line 5: CommitDate: 2013-11-06 02:59:15 +0200 Line 6: Line 7: hsm: Rescan multipath if device is missing when scanning devices Line 8: Line 9: commit 15c7f74365cb5 introduced a regression where multipath rescan is Done Line 10: never performed if a device is found missing when scanning devices. This Line 11: can cause a host to become non-operational when extending a vg. Line 12: Line 13: This patch fix the regression and adds the missing unittests, hopefully Line 9: commit 15c7f74365cb5 introduced a regression where multipath rescan is Line 10: never performed if a device is found missing when scanning devices. This Line 11: can cause a host to become non-operational when extending a vg. Line 12: Line 13: This patch fix the regression and adds the missing unittests, hopefully Done Line 14: preventing the next regression in this hard to verify code. Line 15: Line 16: Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Line 11: can cause a host to become non-operational when extending a vg. Line 12: Line 13: This patch fix the regression and adds the missing unittests, hopefully Line 14: preventing the next regression in this hard to verify code. Line 15: Done Line 16: Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee File tests/hsmTests.py Line 28: Line 29: class StatelessHsm(hsm.HSM): Line 30: """ Line 31: HSM has too many dependencies to create an object for testing. This Line 32: subclass has no dependencies and is goog enough for testing methods that do Done Line 33: not use object state. Line 34: """ Line 35: def __init__(self): Line 36: pass Line 47: Line 48: class FakeMultipath(object): Line 49: Line 50: def __init__(self, pathes=()): Line 51: self.log = '' Done Line 52: self.pathes = set(pathes) Line 53: Line 54: def rescan(self): Line 55: self.log += 'rescan;' -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Update of the guest memory stats schema
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Update of the guest memory stats schema
..
Update of the guest memory stats schema
Newer guest agent versions are now additionally reporting swap stats. This
needs to be reflected in the schema.
Change-Id: Ic6326ecac58e459cc73b87274cb18e8a3cf2ab41
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025845
Signed-off-by: Vinzenz Feenstra
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 19 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/20959/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 72848f8..a6469fb 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -5265,27 +5265,37 @@
#
# Memory statistics as reported by the guest agent.
#
-# @mem_total: The total amount of memory available to the OS (in KiB)
+# @mem_total: The total amount of memory available to the OS
+# (in KiB)
#
-# @mem_unused: The amount of memory that is completely unused (in KiB)
+# @mem_unused: The amount of memory that is completely unused
+# (in KiB)
#
-# @mem_free:The amount of memory available for allocation in KiB (includes
-# easily reclaimable memory)
+# @mem_free:The amount of memory available for allocation in
+# KiB (includes easily reclaimable memory)
#
-# @swap_in: The number of memory pages swapped in since the last collection
+# @swap_in: The number of memory pages swapped in since the
+# last collection
#
-# @swap_out:The number of memory pages swapped out since the last
collection
+# @swap_out:The number of memory pages swapped out since the
+# last collection
#
-# @pageflt: The number of page faults since the last collection
+# @pageflt: The number of page faults since the last collection
#
-# @majflt: The number of major page faults since the last collection
+# @majflt: The number of major page faults since the last
+# collection
+#
+# @swap_total: #optionalThe total amount of swap space available to the OS
+# (in KiB)
+#
+# @swap_usage: #optionalThe amount of swap space used by the OS (in KiB)
#
# Since: 4.10.0
##
{'type': 'GuestMemoryStats',
'data': {'mem_total': 'str', 'mem_unused': 'str', 'mem_free': 'str',
'swap_in': 'uint', 'swap_out': 'uint', 'pageflt': 'uint',
- 'majflt': 'uint'}}
+ 'majflt': 'uint', '*swap_total': 'str', '*swap_usage': 'str'}}
##
# @BalloonInfo:
--
To view, visit http://gerrit.ovirt.org/20959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6326ecac58e459cc73b87274cb18e8a3cf2ab41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 5: Code-Review-1
(2 comments)
File lib/vdsm/vdscli.py.in
Line 34:
Line 35:
Line 36: class TransportWrapper:
Line 37: def __init__(self, transport):
Line 38: self._parse = transport.parse_response
_orig_parse_response would be a better name.
Line 39: transport.parse_response = lambda *args, **kwargs: {
Line 40: self.wrapping_func(args, kwargs)
Line 41: }
Line 42:
Line 39: transport.parse_response = lambda *args, **kwargs: {
Line 40: self.wrapping_func(args, kwargs)
Line 41: }
Line 42:
Line 43: def _wrap(self, func, args, kwargs):
Please have a specific "wrapped_parse_response" function. No need for this
general wrapper. It would save us the lambda and "wrapping_func".
Line 44: try:
Line 45: return func(*args, **kwargs)
Line 46: except ExpatError as e:
Line 47: sys.stderr.write('Parsing error was thrown during parsing '
--
To view, visit http://gerrit.ovirt.org/20627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4442/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5246/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5323/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 4:
(1 comment)
File lib/vdsm/vdscli.py.in
Line 57: except ExpatError as e:
Line 58: sys.stderr.write('Parsing error was thrown during parsing '
Line 59: 'response. Following arguments were
passed: ')
Line 60: for arg in enumerate(args):
Line 61: sys.stdout.write(arg[1])
but not better to see an attribute name next to its value as you proposed in
patchset 3?
Line 62: raise e
Line 63: return result
Line 64:
Line 65:
--
To view, visit http://gerrit.ovirt.org/20627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG
Nir Soffer has posted comments on this change. Change subject: Invalidate filters on HSMs before rescanning extended VG .. Patch Set 18: Code-Review+1 I'm not happy with the commit message, but hey, this is good enough, and everyone is waiting for this patch. Please merge it. -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Pavel Zhukov Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Tomáš Došek Gerrit-Reviewer: Yeela Kaplan Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...
Allon Mureinik has posted comments on this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Patch Set 1: (1 comment) Commit Message Line 11: can cause a host to become non-operational when extending a vg. Line 12: Line 13: This patch fix the regression and adds the missing unittests, hopefully Line 14: preventing the next regression in this hard to verify code. Line 15: Probably not a bad idea to add "Relates-To: https://bugzilla.redhat.com/show_bug.cgi?id=923773";, as this was the trigger for the original patch. Line 16: Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee -- To view, visit http://gerrit.ovirt.org/20942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
