Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
Yaniv Bronhaim has posted comments on this change.
Change subject: Peform related services restart after reconfiguring
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 748: %{_bindir}/vdsm-tool service-stop supervdsmd /dev/null 21
Line 749: supervdsmd_start_required='yes'
Line 750: fi
Line 751:
Line 752: %{_bindir}/vdsm-tool libvirt-configure /dev/null 21
what can we do on error? It will leave libvirtd down and we'll be able to read
about it in syslog and start it manually
Line 753:
Line 754: fi
Line 755: if [ ${supervdsmd_start_required} = 'yes' ]; then
Line 756: %{_bindir}/vdsm-tool service-start supervdsmd /dev/null 21
--
To view, visit http://gerrit.ovirt.org/21356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdc: Change error messages to info
Nir Soffer has posted comments on this change. Change subject: sdc: Change error messages to info .. Patch Set 1: (4 comments) Commit Message Line 10: logged as info: Line 11: 1._findDomain - looking for unfetched domain Line 12: 2._findUnfetchedDomain - looking for domain Line 13: Line 14: Also an error is raised in the process, now logged as info. We can see what was changed in the code. Can you explain why did make those changes? Line 15: Line 16: Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Line 17: Signed-off-by: Vered Volansky vvola...@redhat.com File vdsm/storage/sdc.py Line 133: def _findDomain(self, sdUUID): Line 134: try: Line 135: findMethod = self.knownSDs[sdUUID] Line 136: except KeyError: Line 137: self.log.info(looking for unfetched domain %s, sdUUID) Looks like debug message to me. Line 138: findMethod = self._findUnfetchedDomain Line 139: Line 140: try: Line 141: dom = findMethod(sdUUID) Line 139: Line 140: try: Line 141: dom = findMethod(sdUUID) Line 142: except se.StorageDomainDoesNotExist: Line 143: self.log.info(domain %s not found, sdUUID, exc_info=True) Is this a real error or normal condition? Line 144: raise Line 145: else: Line 146: return dom Line 147: Line 150: import glusterSD Line 151: import localFsSD Line 152: import nfsSD Line 153: Line 154: self.log.info(looking for domain %s, sdUUID) Looks like debug message to me. Line 155: Line 156: # The order is somewhat important, it's ordered Line 157: # by how quickly get can find the domain. For instance Line 158: # if an nfs mount is unavailable we will get stuck -- To view, visit http://gerrit.ovirt.org/21597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Nir Soffer has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap .. Patch Set 3: (1 comment) File vdsm/storage/hsm.py Line 376: def storageRefresh(): Line 377: try: Line 378: lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS) Line 379: finally: Line 380: readyCallback() I tried to implement this by checking hsm readiness in wrapIrsMethod. This breaks backward compatibiliity as engine does not handle well a situation where vdsm is not recovering (e.g. respond to getCapabilities), but irs is not ready yet (e.g. return recovery error when asked to connect to storage). This result in host becoming non-operational. I suggest to keep the current design so we have a patch that can be backported, and improving the design later. Line 381: Line 382: sdCache.refreshStorage() Line 383: Line 384: fileUtils.createdir(self.tasksDir) -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdc: Change error messages to info
Vered Volansky has posted comments on this change. Change subject: sdc: Change error messages to info .. Patch Set 1: This is going to be n'acked, just for due process - the bug url is actually https://bugzilla.redhat.com/show_bug.cgi?id=1031881 -- To view, visit http://gerrit.ovirt.org/21597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Nir Soffer has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
..
Patch Set 3:
(2 comments)
File vdsm/storage/hsm.py
Line 324: def __init__(self, readyCallback):
Line 325:
Line 326: The HSM Constructor
Line 327:
Line 328: :param readyCallback: Called when instance has finished its
deffered
Done
Line 329: initialization and is ready to answer
requests.
Line 330: :type readyCallback: function
Line 331:
Line 332: rm.ResourceManager.getInstance().registerNamespace(
Line 326: The HSM Constructor
Line 327:
Line 328: :param readyCallback: Called when instance has finished its
deffered
Line 329: initialization and is ready to answer
requests.
Line 330: :type readyCallback: function
Done
Line 331:
Line 332: rm.ResourceManager.getInstance().registerNamespace(
Line 333: STORAGE, rm.SimpleResourceFactory())
Line 334: self.storage_repository = config.get('irs', 'repository')
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdc: Change error messages to info
Eduardo has posted comments on this change. Change subject: sdc: Change error messages to info .. Patch Set 1: Code-Review-2 Already discussed. There is no spontaneous SD generation. Should not be unfetched domains, then if such thing exists, they should be reported as ERROR. An ERROR log is not a bug, is for help developers to understand degraded conditions or raise eyebrows. This log is no so frequent nor is the root cause of the issue here. Changing to info or debug is misleading and improve nothing. grep ERROR for opening bugs is a bad practice. The log dissapeared from 3.2. -- To view, visit http://gerrit.ovirt.org/21597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdc: Change error messages to info
Nir Soffer has posted comments on this change. Change subject: sdc: Change error messages to info .. Patch Set 1: And it should be Bug-Url and not Bug-url :-) -- To view, visit http://gerrit.ovirt.org/21597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: (1 comment) File lib/vdsm/ppc64HardwareInfo.py Line 15: # Line 16: # Refer to the README and COPYING files for full details of the license Line 17: # Line 18: Line 19: from vdsm import utils Yaniv, the last thing I want is third parties starting to use lib/vdsm, forcing us to maintain our imperfect APIs. My mantra is: keep private what you do not have to expose. Line 20: Line 21: import os Line 22: Line 23: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add host uuid in volume status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add host uuid in volume status .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4866/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5666/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5751/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9d92845ffce4ba5a2f9f0f2cca782ef18664bdf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Dan Kenigsberg has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 11: (1 comment) File lib/vdsm/constants.py.in Line 148: Line 149: EXT_CURL_IMG_WRAP = '@LIBEXECDIR@/curl-img-wrap' Line 150: Line 151: Line 152: class Architecture: The Architecture is produced by caps, and reported from there to Engine and vm.py. There is no need to expose it in the constants module. It would have been better if these constants where all tucked in their own module (e.g., EXT_DD defined in a dd.py wrapper module). Line 153: X86_64 = 'x86_64' -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add host uuid in volume status
Bala.FA has posted comments on this change. Change subject: gluster: add host uuid in volume status .. Patch Set 2: Dependent glusterfs patch is still under review at http://review.gluster.org/#/c/6267/. Wait it gets accepted and new glusterfs release is made. -- To view, visit http://gerrit.ovirt.org/21596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9d92845ffce4ba5a2f9f0f2cca782ef18664bdf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mastapatch
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: mastapatch
..
mastapatch
Change-Id: I8c53f64e2c1851adf5ed510728bf486340a34882
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/netinfo.py
2 files changed, 64 insertions(+), 34 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/21614/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 5b7a549..e27f189 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -70,6 +70,15 @@
TEAM = 'team'
VETH = 'veth'
+def fakeNicTypes(cls):
+return (cls.DUMMY, cls.VETH)
+
+def nicTypes(cls):
+return (cls.NIC, cls.DUMMY, cls.VETH)
+
+def types(cls):
+return [linkType for linkType in vars(cls) if not callable(linkType)]
+
@equals
class Link(object):
@@ -99,6 +108,17 @@
def __repr__(self):
return '%s: %s(%s) %s' % (self.index, self.name, self.type,
self.address)
+
+def __hash__(self):
+return hash((self.index, self.name))
+
+def __eq__(self, other):
+for key in vars(self):
+if callable(self.__dict__[key]):
+continue
+if self.__dict__[key] != getattr(other, key, None):
+return False
+return True
@staticmethod
def _parse(text):
@@ -203,7 +223,7 @@
Returns True iff vdsm config marks the DUMMY or VETH dev to be reported
as NIC.
-if self.isDUMMY() or self.isVETH():
+if self.type in LinkType.fakeNicTypes():
return anyFnmatch(self.name, self._fakeNics)
return False
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 1dc7455..bcca487 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -34,6 +34,7 @@
from .config import config
from . import constants
from .ipwrapper import getLink, getLinks
+from .ipwrapper import LinkType
from .ipwrapper import Route
from .ipwrapper import routeShowAllDefaultGateways
from . import libvirtconnection
@@ -67,41 +68,52 @@
OPERSTATE_UP = 'up'
+class DevicePool(object):
+_hiddenFilter = lambda x: not x.isHidden()
+
+def __init__(self, *linkTypes):
+self.devs = dict((linkType, set()) for linkType in linkTypes)
+
+def __iter__(self):
+return self.devs.__iter__()
+
+def __getitem__(self, key):
+return self.devs.__getitem__(key)
+
+def __setitem__(self, key, value):
+self.devs.__setitem__(key, value)
+
+def iterDevices(self, hidden=False):
+return self.iterLinkTypes(self.devs.keys(), hidden)
+
+def iterLinkTypes(self, linkTypes, hidden=False):
+for dev in chain(*(self.devs[linkType] for linkType in linkTypes)):
+if hidden or not dev.isHidden():
+yield dev
+
+
+devicePool = DevicePool(*LinkType.types())
+
+
def nics():
Returns a list of nics and fake nics devices available (not hidden) to
be used by vdsm.
-return [dev.name for dev in getLinks() if dev.isNICLike() and
-not dev.isHidden()]
+return [dev.name for dev in self.iterLinkTypes(LinkType.nicTypes())]
def bondings():
Returns list of available bonds managed by vdsm.
-
-hidden_bonds = config.get('vars', 'hidden_bonds').split(',')
-res = []
-try:
-for bond in open(BONDING_MASTERS).readline().split():
-if not anyFnmatch(bond, hidden_bonds):
-res.append(bond)
-except IOError as e:
-if e.errno == os.errno.ENOENT:
-return res
-else:
-raise
-
-return res
+return [dev.name for dev in devicePool.iterLinkTypes([LinkType.BOND])]
def vlans():
-return [link.name for link in getLinks() if link.isVLAN() and
-not link.isHidden()]
+return [dev.name for dev in devicePool.iterLinkTypes([LinkType.VLAN])]
def bridges():
-return [b.split('/')[-2] for b in iglob('/sys/class/net/*/bridge')
-if b.split('/')[-2] != DUMMY_BRIDGE]
+return [dev.name for dev in devicePool.iterLinkTypes([LinkType.BRIDGE])]
def networks():
@@ -222,10 +234,6 @@
def isvirtio(dev):
return 'virtio' in os.readlink('/sys/class/net/%s/device' % dev)
-
-
-def isbonding(dev):
-return os.path.exists('/sys/class/net/%s/bonding' % dev)
def operstate(dev):
@@ -542,12 +550,11 @@
except KeyError:
continue # Do not report missing libvirt networks.
-links = filter(lambda x: not x.isHidden(), getLinks())
-d['bridges'] = dict(_bridgeinfo(dev, gateways, ipv6routes) for dev
-in links if dev.isBRIDGE())
-d['nics'] = dict(_nicinfo(dev, paddr) for dev in links if dev.isNICLike())
-d['bondings'] = dict(_bondinfo(dev) for dev in links if dev.isBOND())
-d['vlans'] = dict(_vlaninfo(dev) for dev in links if
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netconf: Add limit to rollback for recursive configurator
..
netconf: Add limit to rollback for recursive configurator
If a configurator implemented the rollback operation via calling
setupNetworks, we would potentially end up recursing until it
succeeded (and we have no guarantee for success).
This patch adds a parameter to the configurator constructor and
the setupNetworks options that allows the configurator to pass
to setupNetworks inRollback=True when it uses it for rollback
purposes.
Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M vdsm/configNetwork.py
M vdsm/netconf/__init__.py
M vdsm/netconf/ifcfg.py
3 files changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/21615/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 2e29443..3afcb4e 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -537,6 +537,7 @@
force=0|1
connectivityCheck=0|1
connectivityTimeout=int
+inRollback=True|False
Notes:
When you edit a network that is attached to a bonding, it's not
@@ -560,7 +561,7 @@
hooks.before_network_setup()
logger.debug(Applying...)
-with Ifcfg() as configurator:
+with Ifcfg(options.get('inRollback', False)) as configurator:
libvirt_nets = netinfo.networks()
# Remove edited networks and networks with 'remove' attribute
for network, networkAttrs in networks.items():
diff --git a/vdsm/netconf/__init__.py b/vdsm/netconf/__init__.py
index 24cb929..50934a5 100644
--- a/vdsm/netconf/__init__.py
+++ b/vdsm/netconf/__init__.py
@@ -24,12 +24,15 @@
from sourceRoute import StaticSourceRoute
from vdsm import netinfo
from vdsm.config import config
+from vdsm.constants import EXT_VDSM_RESTORE_NET_CONFIG
from vdsm.netconfpersistence import RunningConfig
+from vdsm.utils import execCmd
class Configurator(object):
-def __init__(self, configApplier):
+def __init__(self, configApplier, inRollback=False):
self.configApplier = configApplier
+self._inRollback = inRollback
self._libvirtAdded = set()
self.unifiedPersistence = \
config.get('vars', 'persistence') == 'unified'
@@ -43,6 +46,13 @@
def __exit__(self, type, value, traceback):
if type is None:
self.commit()
+elif self._inRollback:
+# If we failed the rollback transaction, we try to apply the last
+# known good network configuration, i.e., last persistent.
+rc, _, err = execCmd(EXT_VDSM_RESTORE_NET_CONFIG, raw=True)
+if not rc:
+logging.error('Failed rollback transaction and restoration to '
+ 'last known good network. ERR=%s', err)
else:
self.rollback()
diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py
index 1ebd1f4..ac36786 100644
--- a/vdsm/netconf/ifcfg.py
+++ b/vdsm/netconf/ifcfg.py
@@ -44,8 +44,8 @@
class Ifcfg(Configurator):
# TODO: Do all the configApplier interaction from here.
-def __init__(self):
-super(Ifcfg, self).__init__(ConfigWriter())
+def __init__(self, inRollback=False):
+super(Ifcfg, self).__init__(ConfigWriter(), inRollback)
def begin(self):
if self.configApplier is None:
--
To view, visit http://gerrit.ovirt.org/21615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mastapatch
oVirt Jenkins CI Server has posted comments on this change. Change subject: mastapatch .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4867/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5667/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/874/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5752/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c53f64e2c1851adf5ed510728bf486340a34882 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4868/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5668/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/875/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5753/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mastapatch
Antoni Segura Puimedon has abandoned this change. Change subject: mastapatch .. Abandoned That was a draft that good pushed by bad gitting. -- To view, visit http://gerrit.ovirt.org/21614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8c53f64e2c1851adf5ed510728bf486340a34882 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4869/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5669/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/876/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5754/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
Dan Kenigsberg has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 1: Code-Review+1 Ack, but please verify that what's this rpm-build failure. -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Michal Skrivanek has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 33: (1 comment) File vdsm/vm.py Line 1780: while not check(): Line 1781: if time.time() - startTime self.timeout: Line 1782: return False Line 1783: time.sleep(seconds) Line 1784: seconds *= 2 the step can become too huge this way. I'd prefer waiting on lifecycle event from libvirt Line 1785: Line 1786: return check() Line 1787: Line 1788: # Callbacks for Callback Chain -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
..
Patch Set 4: Code-Review+1
(1 comment)
File lib/vdsm/tool/libvirt_configure.sh.in
Line 260: fi
Line 261:
Line 262: # Configure remote display port range
Line 263: set_if_default ${qconf} remote_display_port_min 5900
Line 264: set_if_default ${qconf} remote_display_port_max 6923
I'd mention it in the commit message
Line 265:
Line 266: # Configuring sanlock
Line 267: if [ ${ENABLE_LIBVIRT_SANLOCK} = yes ]; then
Line 268: set_if_default ${qconf} lock_manager \sanlock\
--
To view, visit http://gerrit.ovirt.org/17058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Alex Lourie alou...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Federico Simoncelli has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 4: Code-Review+1 Please update the commit message. -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
Yaniv Bronhaim has posted comments on this change.
Change subject: Keeping gluster modules when with_gluster set to 0
..
Patch Set 1: Verified-1
(1 comment)
File vdsm.spec.in
Line 1088: %{_datadir}/%{vdsm_name}/tests/glusterVolumeRemoveBricksStatus.xml
Line 1089: %{_datadir}/%{vdsm_name}/tests/glusterVolumeTasks.xml
Line 1090: %else
Line 1091: %exclude %{_datadir}/%{vdsm_name}/tests/gluster*
Line 1092: %endif
risky mistake.. don't know how it happened
Line 1093: %{_datadir}/%{vdsm_name}/tests/functional/*.py*
Line 1094: %{_datadir}/%{vdsm_name}/tests/functional/*.policy
Line 1095:
Line 1096: %files hook-openstacknet
--
To view, visit http://gerrit.ovirt.org/21577
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 4: Code-Review-1 If we have to mention remote_display_port_max=6923 in the commit message, SOMEONE has to give -1. -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: refactor buildConfDevices and getConfDevices into sing...
Federico Simoncelli has posted comments on this change. Change subject: vdsm: refactor buildConfDevices and getConfDevices into single function .. Patch Set 5: Code-Review+2 (1 comment) File vdsm/vm.py Line 1913: for drv in devices[DISK_DEVICES]: Line 1914: if isVdsmImage(drv): Line 1915: self._normalizeVdsmImg(drv) Line 1916: Line 1917: self.normalizeDrivesIndices(devices[DISK_DEVICES]) If I understand correctly this is here because it was called also in getConfDrives. Line 1918: Line 1919: # Preserve old behavior. Since libvirt add a memory balloon device Line 1920: # to all guests, we need to specifically request not to add it. Line 1921: self._normalizeBalloonDevice(devices[BALLOON_DEVICES]) -- To view, visit http://gerrit.ovirt.org/19348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3a209967f97a55fe861c4446e8f93e1a1da08e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
Dan Kenigsberg has posted comments on this change. Change subject: Peform related services restart after reconfiguring .. Patch Set 4: Code-Review+1 So sad. We may need to release an ovirt-3.3.1.1 for this. -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: (1 comment) File lib/vdsm/ppc64HardwareInfo.py Line 15: # Line 16: # Refer to the README and COPYING files for full details of the license Line 17: # Line 18: Line 19: from vdsm import utils third-party will use it if we'll make it a separate package, but locate it under /lib/vdsm doesn't mean we expose it. what's the different between this and netinfo.py ? Line 20: Line 21: import os Line 22: Line 23: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
Yaniv Bronhaim has posted comments on this change. Change subject: Peform related services restart after reconfiguring .. Patch Set 4: Agree.. that's the result of merging unfinished work that changes API or flows. I'll try to avoid it next time -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 5: Updated changelog -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4870/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5670/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5755/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
Yaniv Bronhaim has posted comments on this change. Change subject: Catch gluster import error in glusterVolume .. Patch Set 1: Verified+1 sorry for missing that :/ -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
Yaniv Bronhaim has uploaded a new change for review. Change subject: Catch gluster import error in glusterVolume .. Catch gluster import error in glusterVolume glusterSD is imported by hsm and imports glusterVolume. with_gluster=0 variable leaves gluster files but omit gluster directory. This leads to import error that must be treated. Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/storage/glusterVolume.py 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/21625/1 diff --git a/vdsm/storage/glusterVolume.py b/vdsm/storage/glusterVolume.py index 3368de3..647b1ec 100644 --- a/vdsm/storage/glusterVolume.py +++ b/vdsm/storage/glusterVolume.py @@ -2,7 +2,11 @@ import fileVolume from sdc import sdCache import supervdsm as svdsm -from gluster.exception import GlusterException +try: +from gluster.exception import GlusterException +_glusterEnabled = True +except ImportError: +_glusterEnabled = False class GlusterVolume(fileVolume.FileVolume): -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
oVirt Jenkins CI Server has posted comments on this change. Change subject: Catch gluster import error in glusterVolume .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4871/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5756/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
oVirt Jenkins CI Server has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/293/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Michal Skrivanek has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Michal Skrivanek has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 5: Verified+1 Verified by: Vinzenz Feenstra. just commit message changed -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
Yaniv Bronhaim has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
Yaniv Bronhaim has posted comments on this change. Change subject: Peform related services restart after reconfiguring .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
Yaniv Bronhaim has posted comments on this change. Change subject: Peform related services restart after reconfiguring .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Peform related services restart after reconfiguring .. Peform related services restart after reconfiguring Although we tried to avoid doing restart to external services as part of the pre-start of vdsm, the full implementation of vdsm-tool API that allows to check isconfigured before performing the configuration itself is missing in ovirt-3.3. Currently when running libvirt-configure we return 0 (SUCCESS) on both reconfigure and if libvirt conf is already configured with vdsm details. That's lead to a problem to decide when to stop the pre-start part and wait for manual restart, or continue as it is already working with the right configurations. To avoid more changes, we return the auto restart to allow easy start of vdsm without more specific tweaks. Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031592 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21356 Reviewed-by: Alon Bar-Lev alo...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M README M init/systemd/systemd-vdsmd.in M init/sysvinit/vdsmd.init.in M lib/vdsm/tool/libvirt_configure.sh.in M vdsm.spec.in 5 files changed, 8 insertions(+), 18 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified; Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
oVirt Jenkins CI Server has posted comments on this change. Change subject: Peform related services restart after reconfiguring .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/294/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
Dan Kenigsberg has posted comments on this change. Change subject: Catch gluster import error in glusterVolume .. Patch Set 1: Could you detail how this was verified, this time? Please install the rpm with_gluster=0 and see that non-gluster storage domains work. -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
Yaniv Bronhaim has posted comments on this change. Change subject: Catch gluster import error in glusterVolume .. Patch Set 1: Installed rpm after building it with %global with_gluster 0 started the service and ran vdsClient getVdsCaps . anything else? -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: Accents in the vm name break the migration
Federico Simoncelli has submitted this change and it was merged. Change subject: vdsm: Accents in the vm name break the migration .. vdsm: Accents in the vm name break the migration Added utf-8 encoding of the configuration xml on the destination to handle non-ascii characters. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002246 Change-Id: I9db5ea4f0745ef42633e3d265bcf40fb4733b2ce Signed-off-by: Martin Betak mbe...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19684 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21521 --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Betak: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9db5ea4f0745ef42633e3d265bcf40fb4733b2ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Ensure cancellation of migrations gets handled correctly
Federico Simoncelli has submitted this change and it was merged. Change subject: Ensure cancellation of migrations gets handled correctly .. Ensure cancellation of migrations gets handled correctly If the migration is cancelled before the source calls libvirt.migrateToURI2 we have to raise an libvirtError with the VIR_ERROR_OPERATION_ABORTED error code to ensure that _finishSuccessfully() does not get called and we're correctly reporting that the migration has been cancelled and that we're destroying the VM on the destination in the process, since we're bailing out. Additionally we'll do the check if the migration has been cancelled right after the semaphore has been accquired, to avoid doing things like calling the before_vm_migration_source hook and calling the destination vdsm to create the VM instance. Change-Id: Id271a41466bc355ca505f764206457af419f0edd Bug-Url: https://bugzilla.redhat.com/1023131 Signed-off-by: Martin Polednik mpole...@redhat.com Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21445 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21536 --- M vdsm/vm.py 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id271a41466bc355ca505f764206457af419f0edd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
Dan Kenigsberg has posted comments on this change. Change subject: Catch gluster import error in glusterVolume .. Patch Set 1: yes, please make sure that another storage type is usable. -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
Dan Kenigsberg has submitted this change and it was merged. Change subject: api: remove the uploadVolume command .. api: remove the uploadVolume command The uploadVolume command was never used by the engine and has been obsoleted with the introduction of the imageSharing module. Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21425 Reviewed-by: Sergey Gotliv sgot...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClient.py M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/sp.py M vdsm_api/vdsmapi-schema.json 6 files changed, 0 insertions(+), 141 deletions(-) Approvals: Federico Simoncelli: Verified Sergey Gotliv: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
Yaniv Bronhaim has posted comments on this change. Change subject: Catch gluster import error in glusterVolume .. Patch Set 1: for verification: I attached remote nfs storage to dc and started a vm -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
Dan Kenigsberg has posted comments on this change. Change subject: Catch gluster import error in glusterVolume .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Catch gluster import error in glusterVolume
Dan Kenigsberg has submitted this change and it was merged. Change subject: Catch gluster import error in glusterVolume .. Catch gluster import error in glusterVolume glusterSD is imported by hsm and imports glusterVolume. with_gluster=0 variable leaves gluster files but omit gluster directory. This leads to import error that must be treated. Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21625 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/glusterVolume.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6abf41add3b83336f2e90139bc6752f8e9446960 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added missing python modules to the configure.ac checks
Kiril Nesenko has posted comments on this change. Change subject: Added missing python modules to the configure.ac checks .. Patch Set 2: (1 comment) File configure.ac Line 183: AX_PYTHON_MODULE([ethtool], [fatal]) Line 184: AX_PYTHON_MODULE([libvirt], [fatal]) Line 185: AX_PYTHON_MODULE([netaddr], [fatal]) Line 186: AX_PYTHON_MODULE([pthreading], [fatal]) Line 187: AX_PYTHON_MODULE([pyinotify], [fatal]) how should I install it ? I can't find it in RPMs and not in pip-python Line 188: AX_PYTHON_MODULE([selinux], [fatal]) Line 189: Line 190: # External programs (sorted, please keep in order) Line 191: AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid]) -- To view, visit http://gerrit.ovirt.org/21317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385cca5c91a4d557c818f668d2ded14d8428ea79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
Assaf Muller has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 2: Code-Review-1 There's some sort of rebase issue? There is no 'EXT_VDSM_RESTORE_NET_CONFIG' in lib/vdsm/constants.py.in. Shouldn't this patch also implement the recursion stopping condition? -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
Yaniv Bronhaim has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 3: Verified+1 verified by running it, attaching nfs storage and starting a vm. -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Add check for python-dmidecode to configure.ac
Adam Litke has uploaded a new change for review. Change subject: build: Add check for python-dmidecode to configure.ac .. build: Add check for python-dmidecode to configure.ac python-dmidecode is required when building the vdsm rpm but it is not checked for like other python modules by configure. Make it consistent. Change-Id: I902eb87def175b6c185507a82174baf53d651f74 Signed-off-by: Adam Litke ali...@redhat.com --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/21642/1 diff --git a/configure.ac b/configure.ac index 4ba4a9e..b0d0d28 100644 --- a/configure.ac +++ b/configure.ac @@ -180,6 +180,7 @@ # Checking for python modules (sorted, please keep in order) AX_PYTHON_MODULE([argparse], [fatal]) AX_PYTHON_MODULE([cpopen], [fatal]) +AX_PYTHON_MODULE([dmidecode], [fatal]) AX_PYTHON_MODULE([ethtool], [fatal]) AX_PYTHON_MODULE([libvirt], [fatal]) AX_PYTHON_MODULE([netaddr], [fatal]) -- To view, visit http://gerrit.ovirt.org/21642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I902eb87def175b6c185507a82174baf53d651f74 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Add check for python-dmidecode to configure.ac
oVirt Jenkins CI Server has posted comments on this change. Change subject: build: Add check for python-dmidecode to configure.ac .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4872/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5757/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I902eb87def175b6c185507a82174baf53d651f74 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Add check for python-dmidecode to configure.ac
Antoni Segura Puimedon has posted comments on this change. Change subject: build: Add check for python-dmidecode to configure.ac .. Patch Set 1: Code-Review+1 Thanks for this! -- To view, visit http://gerrit.ovirt.org/21642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I902eb87def175b6c185507a82174baf53d651f74 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added missing python modules to the configure.ac checks
Antoni Segura Puimedon has posted comments on this change. Change subject: Added missing python modules to the configure.ac checks .. Patch Set 2: (1 comment) File configure.ac Line 183: AX_PYTHON_MODULE([ethtool], [fatal]) Line 184: AX_PYTHON_MODULE([libvirt], [fatal]) Line 185: AX_PYTHON_MODULE([netaddr], [fatal]) Line 186: AX_PYTHON_MODULE([pthreading], [fatal]) Line 187: AX_PYTHON_MODULE([pyinotify], [fatal]) In this directive what is checked is the python module name. The rhel-fedora package name is python-inotify. Line 188: AX_PYTHON_MODULE([selinux], [fatal]) Line 189: Line 190: # External programs (sorted, please keep in order) Line 191: AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid]) -- To view, visit http://gerrit.ovirt.org/21317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385cca5c91a4d557c818f668d2ded14d8428ea79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4873/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5673/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/877/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5758/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 3: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4873/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5673/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/877/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5760/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: turn spm status attributes private
Federico Simoncelli has posted comments on this change. Change subject: sp: turn spm status attributes private .. Patch Set 2: (1 comment) File vdsm/storage/sp.py Line 141: def getSpmStatus(self): Line 142: return self._spmRole, self._getSpmLver(), self._getSpmId() Line 143: Line 144: @unsecured Line 145: def isSpmRoleAcquired(self): I thought of using isSpmAcquired, but it sounded to me as if (with such name) it should return whether the SPM is acquired by *any* host in the cluster. What we return here is the current role of this host. Line 146: return self._spmRole == SPM_ACQUIRED Line 147: Line 148: @unsecured Line 149: def isSpmRoleFree(self): -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
Assaf Muller has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 4: With the current approach the before_setup_networks hook doesn't know if the current run is a rollback or not. Is that interesting? -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.
Eduardo has posted comments on this change. Change subject: getStorageDomainInfo: SP keys when disconnected. .. Patch Set 2: Verified+1 [root@camel-vdsb ~]# vdsClient -s 0 getStorageDomainInfo 0c3606f8-e509-4007-ae1e-aa023d7a0a94 uuid = 0c3606f8-e509-4007-ae1e-aa023d7a0a94 vguuid = lge2ds-GmcH-g3c6-sMP9-3c9q-7rf9-IIvd06 lver = 4 state = OK version = 3 role = Master pool = ['6e6a4fb2-3ec2-44f1-b07c-2d4f5acaee66'] spm_id = -1 type = ISCSI class = Data master_ver = 2 name = ddd -- To view, visit http://gerrit.ovirt.org/19555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4874/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5674/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/878/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5759/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Add check for python-dmidecode to configure.ac
Dan Kenigsberg has posted comments on this change. Change subject: build: Add check for python-dmidecode to configure.ac .. Patch Set 1: Code-Review-1 this has to be specific to x86, since ppc does not have it and does not need it. -- To view, visit http://gerrit.ovirt.org/21642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I902eb87def175b6c185507a82174baf53d651f74 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: notify on the first status check
Nir Soffer has uploaded a new change for review. Change subject: domainMonitor: notify on the first status check .. domainMonitor: notify on the first status check Domain monitor thread was not reporting when going from unknown state to known state. The thread would start with a bogus valid state, before checking the domain. If the first domain check found the domain as valid, no notification was emitted. If there were paused vms while connecting to the pool, they were not unpaused as they should. This patch initialize lastCheck to invalid value, marking the status as not checked yet. The monitor thread use this special value to detect the first sample, and emit the missing notification. To get the new event when monitor thread start, domain state change callbacks passed now to StoragePool.connect(), and registered with the domainMonitor before the monitor thread is started. Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Bug-Url: https://bugzilla.redhat.com/1003588 Signed-off-by: Nir Soffer nsof...@redhat.com --- M vdsm/storage/domainMonitor.py M vdsm/storage/hsm.py M vdsm/storage/sp.py 3 files changed, 16 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/21649/1 diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py index 4f4b823..8ccb88b 100644 --- a/vdsm/storage/domainMonitor.py +++ b/vdsm/storage/domainMonitor.py @@ -27,6 +27,8 @@ from vdsm.config import config from sdc import sdCache +NOT_CHECKED_YET = 0 + class DomainMonitorStatus(object): __slots__ = ( @@ -41,7 +43,7 @@ def clear(self): self.error = None -self.lastCheck = time() +self.lastCheck = NOT_CHECKED_YET self.valid = True self.readDelay = 0 self.diskUtilization = (None, None) @@ -236,10 +238,9 @@ self.nextStatus.lastCheck = time() self.nextStatus.valid = (self.nextStatus.error is None) -if self.status.valid != self.nextStatus.valid: +if self._statusDidChange(): self.log.debug(Domain %s changed its status to %s, self.sdUUID, Valid if self.nextStatus.valid else Invalid) - try: self.domainMonitor.onDomainStateChange.emit( self.sdUUID, self.nextStatus.valid) @@ -258,3 +259,7 @@ self.sdUUID, exc_info=True) self.status.update(self.nextStatus) + +def _statusDidChange(self): +return (self.status.lastCheck == NOT_CHECKED_YET or +self.status.valid != self.nextStatus.valid) diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 73f9f43..caa8b4c 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1058,12 +1058,10 @@ pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng) if not hostID or not scsiKey or not msdUUID or not masterVersion: hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams() -res = pool.connect(hostID, scsiKey, msdUUID, masterVersion) +res = pool.connect(hostID, scsiKey, msdUUID, masterVersion, + tuple(self.domainStateChangeCallbacks)) if res: self.pools[spUUID] = pool -for callback in self.domainStateChangeCallbacks: -self.pools[spUUID].domainMonitor.\ -onDomainStateChange.register(callback) return res @public diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 0e23e1d..0d78459 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -666,7 +666,7 @@ f.writelines(pers) @unsecured -def connect(self, hostID, scsiKey, msdUUID, masterVersion): +def connect(self, hostID, scsiKey, msdUUID, masterVersion, callbacks=()): Connect a Host to a specific storage pool. @@ -692,6 +692,11 @@ # Make sure SDCache doesn't have stale data (it can be in case of FC) sdCache.invalidateStorage() sdCache.refresh() +# Must register domain state change callbacks *before* rebuilding the +# pool, which starts domain monitor threads. Otherwise we will miss the +# first event from the monitor thread. +for cb in callbacks: +self.domainMonitor.onDomainStateChange.register(cb) # Rebuild whole Pool self.__rebuild(msdUUID=msdUUID, masterVersion=masterVersion) self.__createMailboxMonitor() -- To view, visit http://gerrit.ovirt.org/21649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: notify on the first status check
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: notify on the first status check .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4875/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5675/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5761/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 4: @Assaf: the setup_networks_hook has to be improved with receiving setupNetworks params in another patch, and as part of those params it will get the options['inRollback']. -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: pre-defined range for spice/vnc ports .. vdsm: pre-defined range for spice/vnc ports Libvirt's default port range 5900-65535 which is out of VDSM's documented range 5634 to 6166. But since the medieval time we already use libvirt's default. We'll define the new range as 5900-6923 (1024 ports) So: 1. Set some limited port range, that can be used in FW conf 2. Use start port 5900 as it is already used by customers 3. Use the endport as 6923 4. Change VDSM documentation according to new port range Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=983088 Signed-off-by: Peter V. Saveliev p...@redhat.com Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Reviewed-on: http://gerrit.ovirt.org/17058 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Tested-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/libvirt_configure.sh.in 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Michal Skrivanek: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
Dan Kenigsberg has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Keeping gluster modules when with_gluster set to 0 .. Keeping gluster modules when with_gluster set to 0 Currently the code imports and uses gluster modules. Setting with_gluster=0 brakes the code. With this patch with_gluster=0 will only drop the vdsm-gluster rpm creation. This patch was reviewed on - http://gerrit.ovirt.org/21477 http://gerrit.ovirt.org/#/c/21625/ (as a join of both patches) Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21577 --- M vdsm.spec.in M vdsm/storage/glusterVolume.py M vdsm/supervdsmServer 3 files changed, 14 insertions(+), 12 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
Yaniv Bronhaim has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Add limit to rollback for recursive configurator .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4874/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5674/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5759/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/879/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
oVirt Jenkins CI Server has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/296/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Introduce CallbackChain
Martin Betak has posted comments on this change. Change subject: utils: Introduce CallbackChain .. Patch Set 11: (1 comment) File tests/utilsTests.py Line 160: self.assertFalse(chain.callbacks) Line 161: chain.start() Line 162: chain.join() Line 163: # assert exception isn't thrown in start on empty chain Line 164: self.assertTrue(True) Done Line 165: Line 166: def testAllCallbacksAreInvokedIfTheyReturnFalse(self): Line 167: n = 10 Line 168: counter = [n] -- To view, visit http://gerrit.ovirt.org/19228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b35eeb3c7865945458801d13615c5dc92ebb5dd Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Introduce CallbackChain
Martin Betak has posted comments on this change. Change subject: utils: Introduce CallbackChain .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.ovirt.org/19228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b35eeb3c7865945458801d13615c5dc92ebb5dd Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
oVirt Jenkins CI Server has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/297/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 33: (1 comment) File vdsm/vm.py Line 1780: while not check(): Line 1781: if time.time() - startTime self.timeout: Line 1782: return False Line 1783: time.sleep(seconds) Line 1784: seconds *= 2 Done Line 1785: Line 1786: return check() Line 1787: Line 1788: # Callbacks for Callback Chain -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Introduce CallbackChain
Antoni Segura Puimedon has posted comments on this change. Change subject: utils: Introduce CallbackChain .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b35eeb3c7865945458801d13615c5dc92ebb5dd Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 34: Verified+1 -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Introduce CallbackChain
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Introduce CallbackChain .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4877/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5677/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5763/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b35eeb3c7865945458801d13615c5dc92ebb5dd Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 34: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4876/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5676/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5762/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: utils: Create AsyncProcessOperation
Dan Kenigsberg has posted comments on this change. Change subject: utils: Create AsyncProcessOperation .. Patch Set 1: Code-Review-1 should be taken in only with http://gerrit.ovirt.org/#/c/21136/ (and only after thel el6.5 release of iscsi-initiator). -- To view, visit http://gerrit.ovirt.org/21135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: gluster: correct parameter for creating hookpath in verb hoo...
Dan Kenigsberg has posted comments on this change. Change subject: gluster: correct parameter for creating hookpath in verb hookAdd. .. Patch Set 1: Code-Review-1 Commit message should have Bug-Url (not as you have spelled on the master branch). Other than that, ack for ovirt-3.3. -- To view, visit http://gerrit.ovirt.org/21538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR .. Patch Set 1: Code-Review-1 Please abandon from the ovirt-3.3 branch, or explain why we should keep it here. -- To view, visit http://gerrit.ovirt.org/20434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Yaniv Bronhaim has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap .. Patch Set 3: (1 comment) File vdsm/clientIF.py Line 109: self._prepareBindings() Line 110: Line 111: @property Line 112: def ready(self): Line 113: return (self.irs is None or self._irsReady) and not self._recovery if this is called before setting self.irs to anything it will raise AttributeError. just set self.irs to None to avoid it on __init__ (now its in _initIRS which can be too late) Line 114: Line 115: def contEIOVms(self, sdUUID, isDomainStateValid): Line 116: # This method is called everytime the onDomainStateChange Line 117: # event is emitted, this event is emitted even when a domain goes -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize netinfo.py:get()
Assaf Muller has uploaded a new change for review.
Change subject: Optimize netinfo.py:get()
..
Optimize netinfo.py:get()
Changed from 4 iterations of links to 1.
Change-Id: I70379b24084fa8bec88425de9eca106e2a6ae8f0
Signed-off-by: Assaf Muller amul...@redhat.com
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/netinfo.py
2 files changed, 24 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/21652/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index c50b376..beb211e 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -231,6 +231,12 @@
return [Link.fromText(line) for line in linksShowDetailed()]
+def getVisibleLinks():
+for link in getLinks():
+if not link.isHidden():
+yield link
+
+
def getLink(dev):
Returns the Link object for the specified dev.
return Link.fromText(linksShowDetailed(dev=dev)[0])
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 00640e2..77e2cc1 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -18,7 +18,7 @@
# Refer to the README and COPYING files for full details of the license
#
-from collections import namedtuple
+from collections import namedtuple, defaultdict
import errno
from glob import iglob
from itertools import chain
@@ -33,7 +33,7 @@
from .config import config
from . import constants
-from .ipwrapper import getLink, getLinks
+from .ipwrapper import getLink, getLinks, getVisibleLinks
from .ipwrapper import Route
from .ipwrapper import routeShowAllDefaultGateways
from . import libvirtconnection
@@ -493,7 +493,7 @@
info.update({'gateway': getgateway(gateways, bridge),
'ipv6gateway': ipv6routes.get(bridge, '::'),
'ports': ports(bridge), 'stp': bridge_stp_state(bridge)})
-return (bridge, info)
+return info
def _nicinfo(nic, paddr):
@@ -501,19 +501,19 @@
info.update({'hwaddr': gethwaddr(nic), 'speed': nicSpeed(nic)})
if paddr.get(nic):
info['permhwaddr'] = paddr[nic]
-return (nic, info)
+return info
def _bondinfo(bond):
info = _devinfo(bond)
info.update({'hwaddr': gethwaddr(bond), 'slaves': slaves(bond)})
-return (bond, info)
+return info
def _vlaninfo(vlan):
info = _devinfo(vlan)
info.update({'iface': getVlanDevice(vlan), 'vlanid': getVlanID(vlan)})
-return (vlan, info)
+return info
def _devinfo(dev):
@@ -526,7 +526,7 @@
def get():
-d = {'networks': {}}
+d = defaultdict(dict)
gateways = getRoutes()
ipv6routes = getIPv6Routes()
paddr = permAddr()
@@ -541,13 +541,17 @@
except KeyError:
continue # Do not report missing libvirt networks.
-links = filter(lambda x: not x.isHidden(), getLinks())
-d['bridges'] = dict(_bridgeinfo(dev.name, gateways, ipv6routes) for dev
-in links if dev.isBRIDGE())
-d['nics'] = dict(_nicinfo(dev.name, paddr) for dev in links
- if dev.isNICLike())
-d['bondings'] = dict(_bondinfo(dev.name) for dev in links if dev.isBOND())
-d['vlans'] = dict(_vlaninfo(dev.name) for dev in links if dev.isVLAN())
+for dev in getVisibleLinks():
+if dev.isBRIDGE():
+d['bridges'][dev.name] = \
+_bridgeinfo(dev.name, gateways, ipv6routes)
+if dev.isNICLike():
+d['nics'][dev.name] = _nicinfo(dev.name, paddr)
+if dev.isBOND():
+d['bondings'][dev.name] = _bondinfo(dev.name)
+if dev.isVLAN():
+d['vlans'][dev.name] = _vlaninfo(dev.name)
+
return d
--
To view, visit http://gerrit.ovirt.org/21652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70379b24084fa8bec88425de9eca106e2a6ae8f0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize netinfo.py:get()
Assaf Muller has posted comments on this change. Change subject: Optimize netinfo.py:get() .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70379b24084fa8bec88425de9eca106e2a6ae8f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize netinfo.py:get()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Optimize netinfo.py:get() .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4878/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/880/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5764/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70379b24084fa8bec88425de9eca106e2a6ae8f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Yaniv Bronhaim has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap .. Patch Set 3: (1 comment) File vdsm/storage/hsm.py Line 376: def storageRefresh(): Line 377: try: Line 378: lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS) Line 379: finally: Line 380: readyCallback() Ayal, Danekn, can you please explain why is it introduce dependency that have any relation to vm.py ? .. I don't understand that part Line 381: Line 382: sdCache.refreshStorage() Line 383: Line 384: fileUtils.createdir(self.tasksDir) -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: notify on the first status check
Federico Simoncelli has posted comments on this change. Change subject: domainMonitor: notify on the first status check .. Patch Set 1: Code-Review-1 (3 comments) File vdsm/storage/domainMonitor.py Line 26: import misc Line 27: from vdsm.config import config Line 28: from sdc import sdCache Line 29: Line 30: NOT_CHECKED_YET = 0 -1? Line 31: Line 32: Line 33: class DomainMonitorStatus(object): Line 34: __slots__ = ( File vdsm/storage/hsm.py Line 1056: return Line 1057: Line 1058: pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng) Line 1059: if not hostID or not scsiKey or not msdUUID or not masterVersion: Line 1060: hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams() Register your callbacks here if you can (before and outside the connect API). Line 1061: res = pool.connect(hostID, scsiKey, msdUUID, masterVersion, Line 1062: tuple(self.domainStateChangeCallbacks)) Line 1063: if res: Line 1064: self.pools[spUUID] = pool File vdsm/storage/sp.py Line 665: with open(self._poolFile, w) as f: Line 666: f.writelines(pers) Line 667: Line 668: @unsecured Line 669: def connect(self, hostID, scsiKey, msdUUID, masterVersion, callbacks=()): The callbacks for EIO should have never been part of this subsystem (storage). Even more they should not enter the API nor StoragePool. Line 670: Line 671: Connect a Host to a specific storage pool. Line 672: Line 673: Caller must acquire resource Storage.spUUID so that this method would -- To view, visit http://gerrit.ovirt.org/21649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize netinfo.py:get()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Optimize netinfo.py:get() .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5679/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/881/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5765/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70379b24084fa8bec88425de9eca106e2a6ae8f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix vm unpausing during recovery
Nir Soffer has posted comments on this change. Change subject: vm: Fix vm unpausing during recovery .. Patch Set 2: Changes: - Add the missing fix in vm.py, so vm are actually unpaused now - Address design issues raised by Federico -- To view, visit http://gerrit.ovirt.org/21649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix vm unpausing during recovery
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Fix vm unpausing during recovery .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4880/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5680/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5766/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix vm unpausing during recovery
Nir Soffer has posted comments on this change. Change subject: vm: Fix vm unpausing during recovery .. Patch Set 2: (1 comment) Commit Message Line 18: NOT_CHECKED_YET value. The monitor thread use this value to detect the Line 19: first sample, and emit the missing notification. Line 20: Line 21: - To get the new event when monitor thread starts, domain state change Line 22: are registered now *before* the monitor threads are started. Added callbacks are registered... Line 23: Line 24: - To get the vm unpause code to work in recovery mode, the Vm.sdIds is Line 25: initialized in Vm._run. This probably fixes other issues with Line 26: recovered vms. -- To view, visit http://gerrit.ovirt.org/21649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Optimize netinfo.py:get()
Antoni Segura Puimedon has posted comments on this change. Change subject: Optimize netinfo.py:get() .. Patch Set 2: Code-Review+1 That's almost exactly how I had it on my draft patch, so +1 from me ;-) (I finally didn't push it because it increased the line count and was trying to think of a way to simplify the loop without increasing the line count :P ) -- To view, visit http://gerrit.ovirt.org/21652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70379b24084fa8bec88425de9eca106e2a6ae8f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix vm unpausing during recovery
Nir Soffer has posted comments on this change. Change subject: vm: Fix vm unpausing during recovery .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move reconnection info check to StoragePool
Federico Simoncelli has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool .. Patch Set 3: Ayal, your comments are mostly correct, but sadly this patch is at the base of many other. The entire series is still under heavy development and I don't want to focus on fixing things that might be thrown away completely at the end. In my tests this is good enough (as my bigger concern atm is to decouple hsm and sp). Don't think I'm ignoring your comments, I'm just postponing them until I'll publish the draft. -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: add setMasterDomain to StoragePool
Federico Simoncelli has uploaded a new change for review. Change subject: sp: add setMasterDomain to StoragePool .. sp: add setMasterDomain to StoragePool It turns out that getMasterDomain is used mostly as a setter for the masterDomain attribute. This patch makes it explicit renaming the method to setMasterDomain. Change-Id: I99caffb6143d3a4fff16102c3b7c00616373e193 Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/sp.py 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/21659/1 diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index b9c9961..c62f093 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -715,7 +715,7 @@ def update(self, hostID, scsiKey, msdUUID, masterVersion): hostID, scsiKey, msdUUID, masterVersion = \ self.getPoolParams(hostID, scsiKey, msdUUID, masterVersion) -self.getMasterDomain(msdUUID, masterVersion) +self.setMasterDomain(msdUUID, masterVersion) @unsecured def stopMonitoringDomains(self): @@ -1255,8 +1255,7 @@ Rebuild storage pool. # master domain must be refreshed first -self.masterDomain = self.getMasterDomain(msdUUID=msdUUID, - masterVersion=masterVersion) +self.setMasterDomain(msdUUID, masterVersion) self.updateMonitoringThreads() fileUtils.createdir(self.poolPath) @@ -1505,7 +1504,7 @@ return self._metadata[key] @unsecured -def getMasterDomain(self, msdUUID, masterVersion): +def setMasterDomain(self, msdUUID, masterVersion): Get the (verified) master domain of this pool. @@ -1538,7 +1537,7 @@ self.log.debug(Master domain %s verified, version %s, msdUUID, masterVersion) -return domain +self.masterDomain = domain @unsecured def invalidateMetadata(self): -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I99caffb6143d3a4fff16102c3b7c00616373e193 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove unused recoveryMode from spmStart
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove unused recoveryMode from spmStart .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4882/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5682/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5768/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4be0a2aad270e87cf6a83f8b1fd36d928312104e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
