Change in vdsm[ovirt-3.4]: dmidecode: Handle missing values.
Hello Yaniv Bronhaim,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28541
to review the following change.
Change subject: dmidecode: Handle missing values.
..
dmidecode: Handle missing values.
Make all hwInfo fields in API optional, and change property retrieval so
it cannot fail, also, get rid of all keys that contain no actual
information.
The engine will assume that all the missing keys are not available and
report/display an according message (rather than sending 'Not
Specified')
Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1089393
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
Signed-off-by: Dima Kuznetsov dkuzn...@redhat.com
---
M vdsm/dmidecodeUtil.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/28541/1
diff --git a/vdsm/dmidecodeUtil.py b/vdsm/dmidecodeUtil.py
index eb8d834..7b74fa0 100644
--- a/vdsm/dmidecodeUtil.py
+++ b/vdsm/dmidecodeUtil.py
@@ -54,7 +54,9 @@
('system', 'Serial Number'),
('system', 'UUID'),
('system', 'Family')):
-sysStruct[(k1 + k2).replace(' ', '')] = dmiInfo[k1][k2]
+val = dmiInfo.get(k1, {}).get(k2, None)
+if val not in [None, 'Not Specified']:
+sysStruct[(k1 + k2).replace(' ', '')] = val
return sysStruct
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 3140378..fea8206 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -766,25 +766,25 @@
#
# Host hardware fields.
#
-# @systemManufacturer: Host manufacturer's name
+# @systemManufacturer: #optional Host manufacturer's name
#
-# @systemProductName: Host's hardware module
+# @systemProductName: #optional Host's hardware module
#
-# @systemSerialNumber: Hardware serial number
+# @systemSerialNumber: #optional Hardware serial number
#
-# @systemFamily:Processor type
+# @systemFamily:#optional Processor type
#
-# @systemUUID: Host's hardware UUID
+# @systemUUID: #optional Host's hardware UUID
#
-# @systemVersion: Host's hardware version
+# @systemVersion: #optional Host's hardware version
#
# Since: 4.10.3
##
{'type': 'HardwareInformation',
- 'data': {'systemManufacturer': 'str',
- 'systemProductName': 'str', 'systemVersion': 'str',
- 'systemSerialNumber': 'str', 'systemUUID': 'str',
- 'systemFamily': 'str'}}
+ 'data': {'*systemManufacturer': 'str',
+ '*systemProductName': 'str', '*systemVersion': 'str',
+ '*systemSerialNumber': 'str', '*systemUUID': 'str',
+ '*systemFamily': 'str'}}
##
# @SoftwarePackage:
--
To view, visit http://gerrit.ovirt.org/28541
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: GET requests - use Range header
Liron Ar has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28465/3/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 272: httplib.BAD_REQUEST, Line 273: range in an unsupported format) Line 274: Line 275: min = m.group(1) Line 276: if min != '0': You should also support right? (0 by default I think) not as -500 for example means the last 500 bytes. from the spec- http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.35 - The final 500 bytes (byte offsets 9500-, inclusive): bytes=-500 Line 277: raise self.RequestException( Line 278: httplib.BAD_REQUEST, Line 279: range first byte position other than 0 isn't Line 280: supported) -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Specify snapshot type
Allon Mureinik has posted comments on this change.
Change subject: virt: Specify snapshot type
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/28531/1//COMMIT_MSG
Commit Message:
Line 15: the wrong value to be returned. In turn, vdsm will extend the drive
Line 16: until it consumes the entire block storage domain. See bug 1091094
[1].
Line 17:
Line 18: [1] https://bugzilla.redhat.com/show_bug.cgi?id=1091094
Line 19:
The bug should be referenced with the standard footer, so the hooks can move it
from POST to MODIFIED to CLOSED as the release comes along
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1091094
Line 20: Change-Id: I940ef0fb702708bf2158739eeed7be43ccce78d6
http://gerrit.ovirt.org/#/c/28531/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3722: type=sourceType)
Line 3723: if sourceType == 'block':
Line 3724: args = {'dev': newPath, 'type': sourceType}
Line 3725: elif sourceType == 'file':
Line 3726: args = {'file': newPath, 'type': sourceType}
I wonder if it's worth the hassle to add type to args after the if-elif, as
it's always assigned with the sourceType, regardless of its value.
Line 3727: disk.appendChildWithArgs('source', **args)
Line 3728: return disk
Line 3729:
Line 3730: def _normSnapDriveParams(drive):
--
To view, visit http://gerrit.ovirt.org/28531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I940ef0fb702708bf2158739eeed7be43ccce78d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: dmidecode: Handle missing values.
Dima Kuznetsov has posted comments on this change. Change subject: dmidecode: Handle missing values. .. Patch Set 1: Verified+1 verified with engine built from ovirt-3.4 -- To view, visit http://gerrit.ovirt.org/28541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: ssl related code moved to single module
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: ssl related code moved to single module .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28506/3/lib/vdsm/SecureXMLRPCServer.py File lib/vdsm/SecureXMLRPCServer.py: Line 185: transport=vtransport) Line 186: print s.add(2, 3) Line 187: Line 188: if __name__ == '__main__': Line 189: import sys Wouldn't be better to have a unit test for it? Yep. Something that is run continuously would be much better. Line 190: if len(sys.argv) == 1: Line 191: __Test().client() Line 192: else: http://gerrit.ovirt.org/#/c/28506/3/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 23: Line 24: from betterAsyncore import \ Line 25: Dispatcher, \ Line 26: SSLDispatcher Line 27: from vdsm.sslutils import SSLContext The idea is to evolve dependencies. This phase we want to required both xml Yeah, but yajsonrpc itself could be spun off as an independent module. Line 28: Line 29: Line 30: _STATE_LEN = Waiting for message length Line 31: _STATE_MSG = Waiting for message -- To view, visit http://gerrit.ovirt.org/28506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If941d90edc08e37e6c0707f3f3bc30f517f9e8eb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: GET requests - use Range header
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8951/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9735/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1155/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9890/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: json over stomp available on the same socket
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: json over stomp available on the same socket .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8952/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9891/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc4eb04bf6115fafa4652453f26a771f389478a1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Json processing issues fixed
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Json processing issues fixed .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8953/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9737/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1156/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9892/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33094f3e761c616141f60c190f7deaec08fe1f08 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Moving xml rpc related modules in to rpc package
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Moving xml rpc related modules in to rpc package .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8954/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/705/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9893/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83246098e084fe15f45d7fe50df6e4ec33d2aaa1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: xmlrpc protocol detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: xmlrpc protocol detection .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8955/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/706/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9739/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1157/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9894/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72819cc0ab5bde0150456263ab7dd1a5e99abfeb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: GET requests - use Range header
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 5: Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8957/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9741/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1158/ : The patch does not pass the storage functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9896/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: GET requests - use Range header
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8958/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1159/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9897/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: ssl related code moved to single module
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: ssl related code moved to single module .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8956/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/707/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9740/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9895/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If941d90edc08e37e6c0707f3f3bc30f517f9e8eb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_func_tests: add test for reconfiguring broken bridged ne...
Antoni Segura Puimedon has posted comments on this change. Change subject: net_func_tests: add test for reconfiguring broken bridged network .. Patch Set 2: Verified+1 Passing the jenkins functional test is enough for me. -- To view, visit http://gerrit.ovirt.org/28529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e1895d0b6724870f38529a3c04224103d60828d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Kobi Ianko has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4492: return {'status': doneCode}
Line 4493:
Line 4494: def _reportError(self, key='Err', msg=None):
Line 4495:
Line 4496: Print an error and return an error status.
a more precise statement would be
Done
Line 4497: This method should be called in cases of exception.
Line 4498:
Line 4499: self.log.exception(Operation failed)
Line 4500: if msg is None:
Line 4497: This method should be called in cases of exception.
Line 4498:
Line 4499: self.log.exception(Operation failed)
Line 4500: if msg is None:
Line 4501: error = errCode[key]
by poet I meant the writer of the code, who decided Err is a proper val
since we need to protect the function, we do need a default value(maybe
'unexpected' will be good), or change a bit the function logic when no key was
provided(in that case what should happen when key is not provided).
what I'm wondering is that we already had calls to this function with no key in
the balloon method(there is a call: _reportError() ), did the code explode?
what an I missing here?
by explode, do you mean that the function return None(that is not good) but the
system will continue to run? or that it breaks the system?
Line 4502: else:
Line 4503: error = {'status': {'code': errCode[key]
Line 4504: ['status']['code'], 'message': msg}}
Line 4505: return error
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 25: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8959/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1458/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/695/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1160/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9898/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify condition
Dan Kenigsberg has posted comments on this change. Change subject: net models: simplify condition .. Patch Set 2: Verified+1 Code-Review+2 verified by running the functional tests on jenkins. -- To view, visit http://gerrit.ovirt.org/28496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie79511ddc2b9890e832175b046c1f32f609580ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify condition
Dan Kenigsberg has submitted this change and it was merged. Change subject: net models: simplify condition .. net models: simplify condition Bond.objectivize() is always called with a non-None bonding name. No need to complicate an internal condition to validate this. Change-Id: Ie79511ddc2b9890e832175b046c1f32f609580ec Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28496 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com --- M vdsm/network/models.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie79511ddc2b9890e832175b046c1f32f609580ec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify condition
oVirt Jenkins CI Server has posted comments on this change. Change subject: net models: simplify condition .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1408/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie79511ddc2b9890e832175b046c1f32f609580ec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify error condition
Antoni Segura Puimedon has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 2: Code-Review-1 Maybe a small change in the text message. -- To view, visit http://gerrit.ovirt.org/28497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove last dependency on ifcfg persistence
oVirt Jenkins CI Server has posted comments on this change. Change subject: net: remove last dependency on ifcfg persistence .. Patch Set 2: -Code-Review -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8960/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1459/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9744/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9899/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d682eaf93b488fac0391bf4b84394d73d7f485 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
Antoni Segura Puimedon has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Collect vm numa node runtime pin information
Francesco Romani has posted comments on this change.
Change subject: vm: Collect vm numa node runtime pin information
..
Patch Set 4:
(1 comment)
AFAIR stats are polled from engine every 15 (fifteen) seconds. And if this is
correct (a simple proof: the sample intervalsin the lib/vdsm/config.py* are all
multiple of 15), to poll the pin info every 2s will be just useless, because
values will get overwritten without engine knowing. This is what I'm concerned
about.
http://gerrit.ovirt.org/#/c/28134/4/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 173: ('vm_sample_vcpu_pin_interval', '2',
Line 174: 'How often should we sample each vcpu runtime pinning to '
Line 175: 'which physical cpu core.'),
Line 176:
Line 177: ('vm_sample_vcpu_pin_window', '2', None),
come to think of it - is there any need in a window here (and for balloon t
I agree we shouldn't need a window here (-surely not for balloon)
However, we cannot in the current form of AdvancedStatsFunction (see
vdsm/virt/sampling.py around line 305), because it expects a non-zero window.
I'll fix this in a future patch.
Line 178:
Line 179: ('trust_store_path', '@TRUSTSTORE@',
Line 180: 'Where the certificates and keys are situated.'),
Line 181:
--
To view, visit http://gerrit.ovirt.org/28134
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/25976/17/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 426: return 100 Line 427: progress = 100 - 100 * remaining / total if total else 0 Line 428: return progress if (progress 100) else 99 Line 429: Line 430: if step % self._MONITOR_INTERVAL == 0: 0 is still a documented value, but it is going to cause ZeroDivisionError i Right, but this code it is supposed to get called if self.enabled, which will ensure _MONITOR_INTERVAL is 0. What I mean here is to actually run the body only once every _MONITOR_INTERVAL secs, while 1 MONITOR_TICK is one second. Lastly, I haven't checked AdvancedStatsFunction. Will do ASAP. Line 431: (jobType, timeElapsed, _, Line 432: dataTotal, dataProcessed, dataRemaining, Line 433: memTotal, memProcessed, memRemaining, Line 434: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo() -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding API methods for blkio limits MOM integration
Gilad Chaplik has uploaded a new change for review.
Change subject: adding API methods for blkio limits MOM integration
..
adding API methods for blkio limits MOM integration
Adding API methods to vm.py to integrate with MOM's collectors and controllers:
setBlkioTuneMap(device, blkioTuneMap).
This method sets blkio keys values to the VM's device using the libvirt api.
Acceptable keys: 'total_bytes_sec', 'read_bytes_sec', 'write_bytes_sec',
'total_iops_sec', 'read_iops_sec', 'write_iops_sec'.
Acceptable value type for all keys: integer.
Change-Id: I43b25627e5365fdd1145a75e91fb5b7714e46aaf
Signed-off-by: Gilad Chaplik gchap...@redhat.com
---
M vdsm/API.py
M vdsm/virt/vm.py
M vdsm_api/vdsmapi-schema.json
3 files changed, 60 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/28547/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 14bb5b6..f11f151 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -719,6 +719,17 @@
return errCode['noVM']
return v.setCpuTunePeriod(period)
+def setDeviceBlkioTuneMap(self, dev, blkIoTuneMap):
+
+Sets a Blkio Tune parameter map per device.
+Acceptable keys: 'total_bytes_sec', 'read_bytes_sec',
'write_bytes_sec', 'total_iops_sec', 'read_iops_sec', 'write_iops_sec'.
+Acceptable value type for all keys: integer.
+
+v = self._cif.vmContainer.get(self._UUID)
+if not v:
+return errCode['noVM']
+return v.setDeviceBlkioTuneMap(dev, blkIoTuneMap)
+
def getDiskAlignment(self, drive):
if self._UUID != VM.BLANK_UUID:
return errCode['noimpl']
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 5bd2d01..79cbe5f 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4605,6 +4605,40 @@
return self._reportError(msg=e.message, entity='vcpu period')
return {'status': doneCode}
+def setBlkioTuneMap(self, dev, blkIoTuneMap):
+self._validateIoTuneParams(self, blkIoTuneMap)
+
+try:
+ self._dom.setBlockIoTune(dev, blkIoTuneMap,
libvirt.VIR_DOMAIN_AFFECT_CURRENT)
+except ValueError:
+return self._reportError(msg='a map is required for blkio tune')
+except libvirt.libvirtError as e:
+return self._reportError(msg=e.message)
+return {'status': doneCode}
+
+def _checkIoTuneInvalidParams(self, blkIoTuneMap):
+validKeys = set(('total_bytes_sec', 'read_bytes_sec',
+ 'write_bytes_sec', 'total_iops_sec',
+ 'write_iops_sec', 'read_iops_sec'))
+paramKeys = set(blkIoTuneMap)
+
+invalidParams = paramKeys - validKeys
+if invalidParams:
+invalidParamNames = ', '.join(invalidParams)
+raise ValueError('Parameter %s name(s) are invalid' %
+ invalidParamNames)
+
+def _validateIoTuneParams(self, blkIoTuneMap):
+self._checkIoTuneInvalidParams(blkIoTuneMap)
+self._checkIoTuneCategories(blkIoTuneMap)
+
+try:
+for key, value in blkIoTuneMap.iteritems():
+blkIoTuneMap[key] = int(value)
+except ValueError as e:
+e.message = 'Integer is required for parameter %s' % key
+raise
+
def _reportError(self, key='Err', msg=None):
Print an error and return an error status.
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 1fc1de8..77741d1 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -7344,6 +7344,21 @@
'returns': 'TasksStatus'}
##
+# @VM.setBlkioTuneMap:
+#
+# Sets the blkio tune parameters map of a device
+#
+# @period: a number representing the period to be set
+# Returns:
+# Status code
+#
+# Since: 4.15.0
+##
+{'command': {'class': 'VM', 'name': 'setBlkioTuneMap'},
+ 'data': {'device', 'total_bytes_sec': 'int', 'read_bytes_sec': 'int',
'write_bytes_sec': 'int', 'total_iops_sec': 'int', 'read_iops_sec': 'int',
'write_iops_sec': 'int'},
+ 'returns': 'TasksStatus'}
+
+##
# @VM.updateVmPolicy:
#
# Set VM SLA parameters
--
To view, visit http://gerrit.ovirt.org/28547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43b25627e5365fdd1145a75e91fb5b7714e46aaf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik gchap...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Filter internal data for getVMList API
Federico Simoncelli has posted comments on this change.
Change subject: virt: Filter internal data for getVMList API
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28532/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2534:
Line 2535: def status(self):
Line 2536: # used by API.Global.getVMList
Line 2537: self.conf['status'] = self.lastStatus
Line 2538: ret = deepcopy(self.conf)
The entire thing could probably be:
return dict((k, v) for k, v in a.iteritems() if not k.startswith(_))
Line 2539: # Filter out any internal keys
Line 2540: for k in ret.keys():
Line 2541: if k.startswith('_'):
Line 2542: del ret[k]
--
To view, visit http://gerrit.ovirt.org/28532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39ac6935e5b95912eed42f16871566722316515a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Lookup conf and device by path
Federico Simoncelli has posted comments on this change.
Change subject: virt: Lookup conf and device by path
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27951/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3167: return {'status': doneCode, 'vmList': self.status()}
Line 3168:
Line 3169: def _lookupDeviceByAlias(self, devType, alias):
Line 3170: for dev in self._devices[devType][:]:
Line 3171: try:
This belongs to another patch. How come we discovered this only now? Is it
related to any other change in your set?
Line 3172: if dev.alias == alias:
Line 3173: return dev
Line 3174: except AttributeError:
Line 3175: continue
--
To view, visit http://gerrit.ovirt.org/27951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f63715cd5142ffaf21ae9ba8d451175ae09be0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26768/5/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 214: self.log.debug(Updating stale PUUID LV tag from %s to %s for Line 215:volume %s, tagParent, metaParent, Line 216:child.volUUID) Line 217: child.setParentTag(metaParent) Line 218: self.recheckIfLeaf() I am not thrilled to have this in the loop. We probably want to check this only once and only if we changed at least one parent tag. Line 219: Line 220: if not force: Line 221: self.validateDelete() Line 222: -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8961/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1460/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9745/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/696/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1161/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9900/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8962/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9746/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/697/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1162/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9901/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8963/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9747/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/698/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9902/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 40: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8964/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9748/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/699/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9903/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 40 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding API methods for blkio limits MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: adding API methods for blkio limits MOM integration .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8965/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9749/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/700/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1163/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9904/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43b25627e5365fdd1145a75e91fb5b7714e46aaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding API methods for blkio limits MOM integration
Gilad Chaplik has posted comments on this change.
Change subject: adding API methods for blkio limits MOM integration
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/28547/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4604: except libvirt.libvirtError as e:
Line 4605: return self._reportError(msg=e.message, entity='vcpu
period')
Line 4606: return {'status': doneCode}
Line 4607:
Line 4608: def setBlkioTuneMap(self, dev, blkIoTuneMap):
missing validate device in vm
Line 4609: self._validateIoTuneParams(self, blkIoTuneMap)
Line 4610:
Line 4611: try:
Line 4612: self._dom.setBlockIoTune(dev, blkIoTuneMap,
libvirt.VIR_DOMAIN_AFFECT_CURRENT)
Line 4619: def _checkIoTuneInvalidParams(self, blkIoTuneMap):
Line 4620: validKeys = set(('total_bytes_sec', 'read_bytes_sec',
Line 4621: 'write_bytes_sec', 'total_iops_sec',
Line 4622: 'write_iops_sec', 'read_iops_sec'))
Line 4623: paramKeys = set(blkIoTuneMap)
clean WS next patchset
Line 4624:
Line 4625: invalidParams = paramKeys - validKeys
Line 4626: if invalidParams:
Line 4627: invalidParamNames = ', '.join(invalidParams)
--
To view, visit http://gerrit.ovirt.org/28547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43b25627e5365fdd1145a75e91fb5b7714e46aaf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
Dan Kenigsberg has posted comments on this change. Change subject: tests: fix wrong use of assertions .. Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py File tests/functional/storageTests.py: Line 542: try: Line 543: unexportNFS(export) Line 544: except TestRunnerError as e: Line 545: logging.warning(Failed to unexport NFS entry %s: %s, Line 546: export, e) Done with exception(), e is redundant in the except line. Line 547: else: Line 548: shutil.rmtree(export, ignore_errors=True) Line 549: Line 550: http://gerrit.ovirt.org/#/c/28124/4/tests/testrunner.py File tests/testrunner.py: Line 392: raise AssertionError(msg) Line 393: Line 394: Line 395: def runCommand(*args): Line 396: process = subprocess.Popen(args, stderr=subprocess.PIPE, it's a bad practice. what is the use of continuing it? execCmd surely has problems (the worst of them -- due to the misplaced AsyncProc -- is the different type of the return value, depending on the value of the sync arg). However, I trust execCmd. Until the recent cpu-hogging bug, we had a long period of quiet using it. I do not find it particularly heavy or hard to use. I think that we should not start a holy war about it in this patch, which has obviously-correct fixes of assertions. Line 397:stdout=subprocess.PIPE) Line 398: output, error = process.communicate() Line 399: if process.returncode != 0: Line 400: raise TestRunnerError(subprocess failed: returncode=%s: stderr=%r % -- To view, visit http://gerrit.ovirt.org/28124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Dan Kenigsberg has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4497: This method should be called in cases of exception.
Line 4498:
Line 4499: self.log.exception(Operation failed)
Line 4500: if msg is None:
Line 4501: error = errCode[key]
since we need to protect the function, we do need a default value(maybe 'un
By explode I mean raise an unexpected KeyError. That try out running
self._reportError(msg='an integer is required for target')
Please note that you have changed the default from a valid 'balloonErr' to an
invalid 'Err'.
Line 4502: else:
Line 4503: error = {'status': {'code': errCode[key]
Line 4504: ['status']['code'], 'message': msg}}
Line 4505: return error
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3: -Verified
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:
Line 31:
Line 32: memory = config.get('vars', 'fake_kvm_memory', None)
Line 33: arch = config.get('vars', 'fake_kvm_architecture')
Line 34:
Line 35: if memory is None:
How can memory be ever None? You define its default as '0' (and as such,
I've apparently misunderstood how our config works (missed set_defaults call)...
Line 36: if arch == 'x86_64':
Line 37: memory = '20480'
Line 38: if arch == 'ppc64':
Line 39: memory = '262144'
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Removal of not needed reactors
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Removal of not needed reactors .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28503/1/tests/jsonRpcTests.py File tests/jsonRpcTests.py: Line 41: JsonRpcRequest Line 42: Line 43: Line 44: CALL_TIMEOUT = 5 Line 45: id = '2c8134fd-7dd4-4cfc-b7f8-6b7549399cb6' Will change it to capital letters While you change it, is this CALL_ID? Can make this more clear. Line 46: Line 47: Line 48: class _EchoMessageHandler(object): Line 49: def handleMessage(self, msgCtx): -- To view, visit http://gerrit.ovirt.org/28503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2beed9ae4adac94312681f919f9b72a692617d43 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Moving xml rpc related modules in to rpc package
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Moving xml rpc related modules in to rpc package .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83246098e084fe15f45d7fe50df6e4ec33d2aaa1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Kobi Ianko has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4497: This method should be called in cases of exception.
Line 4498:
Line 4499: self.log.exception(Operation failed)
Line 4500: if msg is None:
Line 4501: error = errCode[key]
By explode I mean raise an unexpected KeyError. That try out running
Ok, got it.
Now, would you suggest I'll create a generic Err (maybe call it VmErr?) or pick
one (maybe 'unavail')? now that the function is in the class level
Line 4502: else:
Line 4503: error = {'status': {'code': errCode[key]
Line 4504: ['status']['code'], 'message': msg}}
Line 4505: return error
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
Alon Bar-Lev has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/28244/3/vdsm_reg/vdsm-upgrade File vdsm_reg/vdsm-upgrade: Line 42: # To get the messages async we should read stderr when triggering Line 43: # the upgrade since the tool uses subprocess.Popen() that waits Line 44: # the command terminates. Line 45: while True: Line 46: line = ' '.join(upgrade_tool.stdout.readline().strip(\n).split()[2:]) why do you split and select fields? I am not sure the format is guaranteed... just take the entire line and put it in. Line 47: if not line: Line 48: break Line 49: Line 50: msg = BSTRAP component=\'ovirt-node-upgrade\' \ Line 47: if not line: Line 48: break Line 49: Line 50: msg = BSTRAP component=\'ovirt-node-upgrade\' \ Line 51: status=\'OK\' message=\'%s\'/ % line you must escape line Line 52: Line 53: print(msg) Line 54: logging.debug(msg) Line 55: Line 52: Line 53: print(msg) Line 54: logging.debug(msg) Line 55: Line 56: error_upgrade = upgrade_tool.stdout.read().strip().split(\n)[-1] you should wait and examine the exit status. only per exit status you know if success or failure, never by parsing. Line 57: if not error_upgrade: Line 58: msg = BSTRAP component=\'ovirt-node-upgrade\' \ Line 59: status=\'OK\' message=\'Upgraded Succeeded\'/\n Line 60: msg += BSTRAP component='RHEV_INSTALL' status='OK'/ Line 64: status=\'OK\' message=\'Upgraded Failed\'/\n Line 65: msg += BSTRAP component=\'ovirt-node-upgrade\' \ Line 66: status=\'FAIL\' message=\'%s\'/\n % error_upgrade Line 67: msg += BSTRAP component='RHEV_INSTALL' status='FAIL'/ Line 68: rc = -1 there is no such thing as -1 exit code Line 69: Line 70: print(msg) Line 71: logging.debug(msg) Line 72: -- To view, visit http://gerrit.ovirt.org/28244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b997d70a440545497246d1a19d9671b054a56a5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Joey Boggs jbo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add isOvirtNode function.
Dan Kenigsberg has posted comments on this change.
Change subject: utils: add isOvirtNode function.
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28486/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1105: sys.exit(-3)
Line 1106:
Line 1107:
Line 1108: @memoized
Line 1109: def isOvirtNode():
please eliminate the same-named function from caps. Take care to fix all users
of caps.isOvirtNode to use this new implementation.
Line 1110: return (
Line : os.path.exists('/etc/rhev-hypervisor-release') or
Line 1112: glob.glob('/etc/ovirt-node-*-release')
Line 1113: )
--
To view, visit http://gerrit.ovirt.org/28486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82207f674f9d1854f9f0804de611073a794c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify error condition
Antoni Segura Puimedon has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 3: Code-Review+1 thanks for the change! -- To view, visit http://gerrit.ovirt.org/28497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify error condition
Dan Kenigsberg has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 3: Verified+1 Code-Review+2 Passes functional tests for BONDING_NAME=bond5 -- To view, visit http://gerrit.ovirt.org/28497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 27: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8969/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1464/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/701/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1164/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9908/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify error condition
Dan Kenigsberg has submitted this change and it was merged. Change subject: net models: simplify error condition .. net models: simplify error condition An attempt to add a bonding device with no nics ends with a different error, depending whether the bond is already define in the kernel or not. This surprising behaviour means that the functional test testFailWithBadParam fails if BONDING_NAME is removed from the kernel. This patch unifies the error code, returning ERR_BAD_PARAMS in both cases. Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28497 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com --- M vdsm/network/models.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Hacked InfiniBand speed.
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Hacked InfiniBand speed. .. Patch Set 5: Verified+1 (1 comment) Even with the different way of detecting InfiniBand devices (by checking their kernel driver name), the fake speed is correctly reported and unit tests and functional network tests pass. http://gerrit.ovirt.org/#/c/28502/5/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 282: https://bugzilla.redhat.com/show_bug.cgi?id=1101314 Line 283: Line 284: try: Line 285: return 1 if drv_name(nicName) == 'ib_ipoib' else 0 Line 286: except IOError: ENOTSUP = 95 for dummy* Line 287: return 0 Line 288: Line 289: Line 290: def nicSpeed(nicName): -- To view, visit http://gerrit.ovirt.org/28502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55089558d59d33da7f44a2f6d7059d291c064f8a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify error condition
oVirt Jenkins CI Server has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1409/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Hacked InfiniBand speed.
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Hacked InfiniBand speed. .. Patch Set 5: Thanks. Let's give Markus Stockhausen a couple of days to check this. -- To view, visit http://gerrit.ovirt.org/28502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55089558d59d33da7f44a2f6d7059d291c064f8a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2: raise ConfigNetworkError when dhcp fails and block...
Antoni Segura Puimedon has uploaded a new change for review. Change subject: iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set .. iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set It is important that a ConfigNetworkError exception is raised when doing the addressing synchronously, otherwise it fails silently. Change-Id: I6bbcd0ccee2371413e228c9709cc1df984329348 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com --- M vdsm/network/configurators/iproute2.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/28559/1 diff --git a/vdsm/network/configurators/iproute2.py b/vdsm/network/configurators/iproute2.py index 19ccdb5..0381d43 100644 --- a/vdsm/network/configurators/iproute2.py +++ b/vdsm/network/configurators/iproute2.py @@ -248,7 +248,9 @@ ipwrapper.linkSet(iface.name, ['up']) if iface.ipConfig.bootproto == 'dhcp': dhclient = DhcpClient(iface.name) -dhclient.start(iface.ipConfig.async) +rc = dhclient.start(iface.ipConfig.async) +if iface.ipConfig.async and rc: +raise ConfigNetworkError(ERR_FAILED_IFUP, 'dhclient failed') def ifdown(self, iface): ipwrapper.linkSet(iface.name, ['down']) -- To view, visit http://gerrit.ovirt.org/28559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6bbcd0ccee2371413e228c9709cc1df984329348 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Removal of not needed reactors
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Removal of not needed reactors .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8978/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9917/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2beed9ae4adac94312681f919f9b72a692617d43 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
Saggi Mizrahi has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 19: Code-Review+1 I'll +2 once Jenkins is configured properly since pushing this code in would break Jenkins for master. -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 7: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8980/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9764/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/702/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9919/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2: raise ConfigNetworkError when dhcp fails and block...
Antoni Segura Puimedon has posted comments on this change. Change subject: iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set .. Patch Set 2: Verified+1 rhel65_01 tests (bddd141) # NOSE_TESTMATCH=testHonorBlockingDhcp ./run_tests_local.sh functional/networkTests.py NetworkTest testHonorBlockingDhcp OK -- Ran 1 test in 61.383s OK rhel65_01 tests (bddd141) # -- To view, visit http://gerrit.ovirt.org/28559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bbcd0ccee2371413e228c9709cc1df984329348 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2: raise ConfigNetworkError when dhcp fails and block...
Ondřej Svoboda has posted comments on this change. Change subject: iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set .. Patch Set 2: Code-Review+1 Looks good :-) -- To view, visit http://gerrit.ovirt.org/28559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bbcd0ccee2371413e228c9709cc1df984329348 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_func_tests: add test for reconfiguring broken bridged ne...
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_func_tests: add test for reconfiguring broken bridged network .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8971/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1466/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9755/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9910/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e1895d0b6724870f38529a3c04224103d60828d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8983/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9767/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1167/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9922/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Filter internal data for getVMList API
Adam Litke has posted comments on this change. Change subject: virt: Filter internal data for getVMList API .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ac6935e5b95912eed42f16871566722316515a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Specify snapshot type
Adam Litke has posted comments on this change. Change subject: virt: Specify snapshot type .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I940ef0fb702708bf2158739eeed7be43ccce78d6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
Adam Litke has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Filter internal data for getVMList API
Federico Simoncelli has posted comments on this change. Change subject: virt: Filter internal data for getVMList API .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ac6935e5b95912eed42f16871566722316515a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Specify snapshot type
Federico Simoncelli has posted comments on this change. Change subject: virt: Specify snapshot type .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I940ef0fb702708bf2158739eeed7be43ccce78d6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Lookup conf and device by path
Federico Simoncelli has posted comments on this change.
Change subject: virt: Lookup conf and device by path
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/27951/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3164: return {'status': doneCode, 'vmList': self.status()}
Line 3165:
Line 3166: def _lookupDeviceByAlias(self, devType, alias):
Line 3167: for dev in self._devices[devType][:]:
Line 3168: try:
(...continuing) It probably belongs to the extension patch then.
Line 3169: if dev.alias == alias:
Line 3170: return dev
Line 3171: except AttributeError:
Line 3172: continue
--
To view, visit http://gerrit.ovirt.org/27951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f63715cd5142ffaf21ae9ba8d451175ae09be0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 6: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26768/6/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 203: # here and fix the LV tag since this is an SPM verb. Line 204: # Line 205: # File domains do not have this complexity because the metadata is Line 206: # stored in only one place and that metadata is updated by the HSM Line 207: # hpst when the live merge finishes. s/hpst/host/ Line 208: sync = False Line 209: for childID in self.getChildren(): Line 210: child = BlockVolume(self.repoPath, self.sdUUID, self.imgUUID, Line 211: childID) -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 41: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9001/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9785/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/718/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9940/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9002/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9786/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9941/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify why scsiKey parameter is not passed on
Yoav Kleinberger has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
Adam Litke has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 7: Verified+1 Fixed typo in comment as requested. -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Setting enum for isconfigured return value and change overri...
Dan Kenigsberg has posted comments on this change. Change subject: Setting enum for isconfigured return value and change override semantics .. Patch Set 3: Code-Review+2 Same as master, except for InvalidConfig and SANLOCK_USER that are missing on ovirt-3.4 (vimdiff of two changes). -- To view, visit http://gerrit.ovirt.org/28473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove last dependency on ifcfg persistence
Antoni Segura Puimedon has posted comments on this change. Change subject: net: remove last dependency on ifcfg persistence .. Patch Set 2: Verified+1 Passing the jenkins functional tests and passing rhel65_01 tests (bddd141) # NOSE_TESTMATCH=testReconfigureBrNetWithVanishedPort ./run_tests_local.sh functional/networkTests.py NetworkTest testReconfigureBrNetWithVanishedPortOK -- Ran 1 test in 1.879s OK rhel65_01 tests (bddd141) # with the iproute2 configurator is enough. The honor blocking dhcp fails with iproute2 but I don't think is related. -- To view, visit http://gerrit.ovirt.org/28530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d682eaf93b488fac0391bf4b84394d73d7f485 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Do not truncate InfiniBand HW addresses anymore
Ondřej Svoboda has uploaded a new change for review. Change subject: netlink: Do not truncate InfiniBand HW addresses anymore .. netlink: Do not truncate InfiniBand HW addresses anymore Change-Id: Ib53e6518d0f2f8ea573451d04ae8cb0464142a17 Signed-off-by: Ondřej Svoboda osvob...@redhat.com --- M lib/vdsm/netlink.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/28554/1 diff --git a/lib/vdsm/netlink.py b/lib/vdsm/netlink.py index f75ea9c..791ccb9 100644 --- a/lib/vdsm/netlink.py +++ b/lib/vdsm/netlink.py @@ -179,7 +179,8 @@ have a physical address. nl_addr = _rtnl_link_get_addr(link) if nl_addr: -address = (c_char * CHARBUFFSIZE)() +# InfiniBand HW address needs 59+1 bytes +address = (c_char * (CHARBUFFSIZE * 2))() return _nl_addr2str(nl_addr, address, sizeof(address)) else: return None -- To view, visit http://gerrit.ovirt.org/28554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib53e6518d0f2f8ea573451d04ae8cb0464142a17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Do not truncate InfiniBand HW addresses anymore
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: Do not truncate InfiniBand HW addresses anymore .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib53e6518d0f2f8ea573451d04ae8cb0464142a17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding API methods for blkio limits MOM integration
Gilad Chaplik has posted comments on this change. Change subject: adding API methods for blkio limits MOM integration .. Patch Set 1: Verified-1 don't review please -- To view, visit http://gerrit.ovirt.org/28547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43b25627e5365fdd1145a75e91fb5b7714e46aaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify error condition
oVirt Jenkins CI Server has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8966/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1461/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9905/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
oVirt Jenkins CI Server has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8967/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1462/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9751/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9906/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Do not truncate InfiniBand HW addresses anymore
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: Do not truncate InfiniBand HW addresses anymore .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8968/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1463/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9907/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib53e6518d0f2f8ea573451d04ae8cb0464142a17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Hacked InfiniBand speed.
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Hacked InfiniBand speed. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8970/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1465/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9909/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55089558d59d33da7f44a2f6d7059d291c064f8a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Hacked InfiniBand speed.
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Hacked InfiniBand speed. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8979/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1467/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9763/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9918/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55089558d59d33da7f44a2f6d7059d291c064f8a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2: raise ConfigNetworkError when dhcp fails and block...
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8987/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1469/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9926/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bbcd0ccee2371413e228c9709cc1df984329348 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: vsam-api removal
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: vsam-api removal .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8a6bc4a064952e1c3a14b27b8db6011767a9d80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Kobi Ianko has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28462/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4518: entity='vcpu period') Line 4519: except libvirt.libvirtError as e: Line 4520: return self._reportError(msg=e.message, entity='vcpu period') Line 4521: Line 4522: def _reportError(self, key='Err', msg=None, entity=None): can you elaborate, what exactly should be done with this function? Done Line 4523: self.log.error(Set new + entity + failed, exc_info=True) Line 4524: if msg is None: Line 4525: error = errCode[key] Line 4526: else: -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Martin Sivák has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 8: Code-Review+1 I think this is reasonable. The only thing I am not sure about is the actual default value - I am more inclined to unexpected error. Dan: What is the current semantic of those err codes with regards to other VDSM commands? -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: xmlrpc protocol detection
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: xmlrpc protocol detection .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72819cc0ab5bde0150456263ab7dd1a5e99abfeb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Removal of not needed reactors
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Removal of not needed reactors .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2beed9ae4adac94312681f919f9b72a692617d43 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9003/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9787/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1174/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9942/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Moving xml rpc related modules in to rpc package
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Moving xml rpc related modules in to rpc package .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83246098e084fe15f45d7fe50df6e4ec33d2aaa1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 7: Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/705/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1168/ : The patch does not pass the storage functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9923/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/707/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1170/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9925/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Kobi Ianko has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4497: This method should be called in cases of exception.
Line 4498:
Line 4499: self.log.exception(Operation failed)
Line 4500: if msg is None:
Line 4501: error = errCode[key]
unavail (or unexpected) might be a good candidate, but do not forget to fix
done
Line 4502: else:
Line 4503: error = {'status': {'code': errCode[key]
Line 4504: ['status']['code'], 'message': msg}}
Line 4505: return error
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
Adam Litke has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26768/5/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 214: self.log.debug(Updating stale PUUID LV tag from %s to %s for Line 215:volume %s, tagParent, metaParent, Line 216:child.volUUID) Line 217: child.setParentTag(metaParent) Line 218: self.recheckIfLeaf() I am not thrilled to have this in the loop. We probably want to check this No problem. That's an easy fix. Line 219: Line 220: if not force: Line 221: self.validateDelete() Line 222: -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Martin Sivák has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4497: This method should be called in cases of exception.
Line 4498:
Line 4499: self.log.exception(Operation failed)
Line 4500: if msg is None:
Line 4501: error = errCode[key]
Ok, got it.
unavail (or unexpected) might be a good candidate, but do not forget to fix
ballooning so it still uses the correct key everywhere
Line 4502: else:
Line 4503: error = {'status': {'code': errCode[key]
Line 4504: ['status']['code'], 'message': msg}}
Line 4505: return error
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Dan Kenigsberg has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 8: Code-Review-1
(1 comment)
The current semantics of the error code is a bit of a mess: most often, Engine
does not handle well a case where the same error is reported back by two
different verbs. That's another reason why I do not see the usefulness of a
default here.
http://gerrit.ovirt.org/#/c/28482/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4491: # persist the target value to make it consistent after
recovery
Line 4492: self.saveState()
Line 4493: return {'status': doneCode}
Line 4494:
Line 4495: def _reportError(self, key='unavail', msg=None):
'resource unavailable'? why is that a reasonable default? would you please drop
the default completely?
Line 4496:
Line 4497: Convert an exception to an error status.
Line 4498: This method should be called only within exception-handling
context.
Line 4499:
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8981/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9920/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Setting enum for isconfigured return value and change overri...
Yaniv Bronhaim has posted comments on this change. Change subject: Setting enum for isconfigured return value and change override semantics .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/28473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Check if mount specification is a symlink
Allon Mureinik has posted comments on this change. Change subject: mount: Check if mount specification is a symlink .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print
Dima Kuznetsov has posted comments on this change. Change subject: Remove redundant print .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6df376664ffcda66ea19f66e28edc0521566c091 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: vsam-api removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: vsam-api removal .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8973/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/708/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9912/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8a6bc4a064952e1c3a14b27b8db6011767a9d80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Final separation of IOProcess and RFH
Federico Simoncelli has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief85d2dca2d22058c4ed2504e49dc3dd62547532 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Json processing issues fixed
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Json processing issues fixed .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8974/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1165/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9913/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33094f3e761c616141f60c190f7deaec08fe1f08 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
