Change in vdsm[master]: vm: Collect vm numa node runtime pin information
Francesco Romani has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information .. Patch Set 6: Code-Review+1 looks good. -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Collect vm numa node runtime pin information
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Collect vm numa node runtime pin information .. vm: Collect vm numa node runtime pin information Get the information that vm numa node runtime pin on which host numa nodes. Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Bug-Url: https://bugzilla.redhat.com/1100202 Signed-off-by: Bruce Shi xiao-lei@hp.com Reviewed-on: http://gerrit.ovirt.org/28134 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm.install M lib/vdsm/config.py.in M tests/Makefile.am A tests/numaUtilsTests.py M vdsm.spec.in M vdsm/Makefile.am A vdsm/numaUtils.py M vdsm/rpc/vdsmapi-schema.json M vdsm/supervdsmServer M vdsm/virt/vm.py 10 files changed, 282 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Xiaolei Shi: Verified -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Collect vm numa node runtime pin information
Dan Kenigsberg has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Collect vm numa node runtime pin information
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1442/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: move getBalloonInfo in the stats thread
Hello Vinzenz Feenstra, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28686
to review the following change.
Change subject: vm: move getBalloonInfo in the stats thread
..
vm: move getBalloonInfo in the stats thread
To gather the ballon stats, we used to make a direct libvirt
call in the getStats() body. This is dangerous, because
getStats() should not contain costly calls, and should
just gather data.
This patch reimplements the balloon information getter as a
sampling function, and moves it into the VmStatsThread
to make things more robust.
As remainder to avoid to sneak costly calls in getStats,
this patch also adds a docstring in getStatsInternal.
This is a backport of the patch from master/3.5.0,
given the performance benefits also observed from
this patch.
Bug-Url: https://bugzilla.redhat.com/1102147
Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be
Signed-off-by: Francesco Romani from...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/27696
Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/config.py.in
M tests/vmTests.py
M vdsm/vm.py
3 files changed, 51 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/28686/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index a3be658..d130415 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -160,6 +160,10 @@
('vm_sample_net_window', '2', None),
+('vm_sample_balloon_interval', '15', None),
+
+('vm_sample_balloon_window', '2', None),
+
('trust_store_path', '@TRUSTSTORE@',
'Where the certificates and keys are situated.'),
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 0a3d440..bd5a904 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -706,7 +706,9 @@
# bz1073478 - main case
with FakeVM(self.VM_PARAMS, self.DEV_BALLOON) as fake:
self.assertEqual(fake._dom, None)
-res = fake.getStats()
+mock_stats_thread = vm.VmStatsThread(fake)
+res = {}
+mock_stats_thread._getBalloonStats(res)
self.assertIn('balloonInfo', res)
self.assertIn('balloon_cur', res['balloonInfo'])
@@ -714,6 +716,8 @@
# bz1073478 - extra case
with FakeVM(self.VM_PARAMS, self.DEV_BALLOON) as fake:
fake._dom = FakeDomain()
-res = fake.getStats()
+mock_stats_thread = vm.VmStatsThread(fake)
+res = {}
+mock_stats_thread._getBalloonStats(res)
self.assertIn('balloonInfo', res)
self.assertIn('balloon_cur', res['balloonInfo'])
diff --git a/vdsm/vm.py b/vdsm/vm.py
index a21d08b..ac6e14c 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -510,10 +510,16 @@
self._sampleNet,
config.getint('vars', 'vm_sample_net_interval'),
config.getint('vars', 'vm_sample_net_window')))
+self.sampleBalloon = (
+sampling.AdvancedStatsFunction(
+self._sampleBalloon,
+config.getint('vars', 'vm_sample_balloon_interval'),
+config.getint('vars', 'vm_sample_balloon_window')))
self.addStatsFunction(
self.highWrite, self.updateVolumes, self.sampleCpu,
-self.sampleDisk, self.sampleDiskLatency, self.sampleNet)
+self.sampleDisk, self.sampleDiskLatency, self.sampleNet,
+self.sampleBalloon)
def _highWrite(self):
if not self._vm.isDisksStatsCollectionEnabled():
@@ -564,6 +570,10 @@
netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
return netSamples
+def _sampleBalloon(self):
+infos = self._vm._dom.info()
+return infos[2]
+
def _diff(self, prev, curr, val):
return prev[val] - curr[val]
@@ -588,6 +598,26 @@
self._log.debug(CPU stats not available: %s, e)
stats['cpuUser'] = 0.0
stats['cpuSys'] = 0.0
+
+def _getBalloonStats(self, stats):
+max_mem = int(self._vm.conf.get('memSize')) * 1024
+
+sInfo, eInfo, sampleInterval = self.sampleBalloon.getStats()
+
+for dev in self._vm.conf['devices']:
+if dev['type'] == BALLOON_DEVICES and \
+dev['specParams']['model'] != 'none':
+balloon_target = dev.get('target', max_mem)
+break
+else:
+balloon_target = 0
+
+stats['balloonInfo'] = {
+'balloon_max': str(max_mem),
+'balloon_min': str(
+int(self._vm.conf.get('memGuaranteedSize', '0')) * 1024),
+'balloon_cur': str(sInfo) if sInfo is not None else '0',
+'balloon_target': balloon_target}
def _getNetworkStats(self, stats):
stats['network'] = {}
@@
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Martin Sivák has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 57: (3 comments) http://gerrit.ovirt.org/#/c/27258/57/tests/vmTests.py File tests/vmTests.py: Line 53: Line 54: def listAllNetworks(self, *args): Line 55: return [] Line 56: Line 57: def lookupByUUIDString(self, id): is this ever used? It seems to be used only outside tests. I removed it. Line 58: pass Line 59: Line 60: Line 61: class FakeDomain: http://gerrit.ovirt.org/#/c/27258/57/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 91: # The Metadata URI for VM tunables Line 92: METADATA_VM_TUNE_URI = 'http://ovirt.org/vm/tune/1.0' Line 93: Line 94: # A libvirt constant for undefined cpu quota Line 95: NO_CPU_QUOTA = 0 Does anybody need these values out of the vm module? If not, mark them as p The FakeDomain uses it in the mock method. Line 96: Line 97: # A libvirt constant for undefined cpu period Line 98: NO_CPU_PERIOD = 0 Line 99: Line 98: NO_CPU_PERIOD = 0 Line 99: Line 100: # CPU tune sampling window Line 101: # minimum supported value is 2 Line 102: CPU_TUNE_SAMPLING_WINDOW = 2 this constant can easily hide within the function that uses it. Done Line 103: Line 104: Line 105: def isVdsmImage(drive): Line 106: -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 57 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
Antoni Segura Puimedon has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
Dan Kenigsberg has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 7: Code-Review+2 Raising score. -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
Dan Kenigsberg has submitted this change and it was merged. Change subject: Report legacy bond devices instead of actually creating them .. Report legacy bond devices instead of actually creating them Engine = 3.2 expects to see bonding devices bond0-bond4 predefined on each host. Therefore, Vdsm creates them on boot, and never deletes them. This add cumbersome logic, which has lead to bugs. Instead, this patch simply reports the existence of the 5 expected bonds, instead of actually creating them. Note that bond0-bond4 were generated only on el6. Therefore this patch limits the reports to that operating system. Bug-Url: https://bugzilla.redhat.com/1064208 Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28455 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com --- M lib/vdsm/netinfo.py M lib/vdsm/tool/load_needed_modules.py.in M tests/functional/networkTests.py M vdsm/caps.py M vdsm/network/configurators/ifcfg.py M vdsm/network/configurators/iproute2.py 6 files changed, 43 insertions(+), 22 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: move getBalloonInfo in the stats thread
David Caro has posted comments on this change. Change subject: vm: move getBalloonInfo in the stats thread .. Patch Set 1: Rerun-Hooks: all -- To view, visit http://gerrit.ovirt.org/28686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Report current system values for bonding options
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: Report current system values for bonding options
..
netinfo: Report current system values for bonding options
Instead of reading bonding options from ifcfg files,
use /sys/class/net/BONDNAME/bonding to fetch live values.
Return only those that differ from defaults, introduced in b3f6e0.
The options are presented in two ways: as a legacy string of
opt=value pairs, separated by spaces, known from ifcfg files,
and as a dictionary with option names as keys and with arrays
of strings as values. The arrays can contain a single string
if an option is numerical or two strings if an option is symbolic
(name first, code second).
A bond info dictionary can look like this (abriged):
'bond4': {
'cfg': {'BONDING_OPTS': 'miimon=150 mode=3'},
'options': {'miimon': ['150'], 'mode': ['broadcast', '3']}
}
Functional network tests now check that bonding options were
applied.
Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Bug-Url: https://bugzilla.redhat.com/987813
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/24456
Reviewed-by: Dan Kenigsberg dan...@redhat.com
Tested-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
M tests/functional/utils.py
3 files changed, 31 insertions(+), 11 deletions(-)
Approvals:
Ondřej Svoboda: Verified
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 53
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
oVirt Jenkins CI Server has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1443/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: move getBalloonInfo in the stats thread
Dan Kenigsberg has posted comments on this change. Change subject: vm: move getBalloonInfo in the stats thread .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Report current system values for bonding options
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Report current system values for bonding options .. Patch Set 53: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1444/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 53 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
Martin Sivák has posted comments on this change.
Change subject: Adding updateVmPolicy api
..
Patch Set 44:
(7 comments)
I rebased the patches, all tests pass and we will reverify the functionality of
course.
http://gerrit.ovirt.org/#/c/27272/44/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 408: with RunningVm(self.vdsm, customization) as vm:
Line 409: self._waitForStartup(vm, VM_MINIMAL_UPTIME)
Line 410: status, msg, stats = self.vdsm.getVmStats(vm)
Line 411: self.assertEqual(status, SUCCESS, msg)
Line 412:
self.vdsm.updateVmPolicy('----',
better use customization[vmId] to avoid string duplication
Done
Line 413: '50')
Line 410: status, msg, stats = self.vdsm.getVmStats(vm)
Line 411: self.assertEqual(status, SUCCESS, msg)
Line 412:
self.vdsm.updateVmPolicy('----',
Line 413: '50')
Line 414: self.assertEqual(status, SUCCESS, msg)
is it possible to verify that the new policy is acted upon?
It is written to the metadata section as far as VDSM is concerned. We tested
the set/get logic, MoM will then use it so it will be verified there.
http://gerrit.ovirt.org/#/c/27272/44/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3526: params['vcpuLimit'] +
Line 3527: '/vcpulimit', 'ovirt',
Line 3528: METADATA_VM_TUNE_URI, 0)
Line 3529: except libvirt.libvirtError as e:
Line 3530: self.log.error(updateVmPolicy failed,
exc_info=True)
use exception() that does not need an explicit exc_info=True.
Done
Line 3531: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3532: return errCode['noVM']
Line 3533: else:
Line 3534: return {'status': {'code':
errCode['updateVmPolicyErr']
Line 3530: self.log.error(updateVmPolicy failed,
exc_info=True)
Line 3531: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3532: return errCode['noVM']
Line 3533: else:
Line 3534: return {'status': {'code':
errCode['updateVmPolicyErr']
how about using the reportError method which you introduced in a previous p
Done
Line 3535: ['status']['code'], 'message':
e.message}}
Line 3536: else:
Line 3537: del params['vcpuLimit']
Line 3538:
Line 3542: if params:
Line 3543: unknownParams = params.keys()
Line 3544: unknownParamsStr = , .join(unknownParams)
Line 3545: self.log.warn(updateVmPolicy got unknown parameters:
%s,
Line 3546: unknownParamsStr)
the intermediate variables are unhelpful imo. Placing
Done
Line 3547:
Line 3548: return {'status': doneCode}
Line 3549:
Line 3550: def _createTransientDisk(self, diskParams):
http://gerrit.ovirt.org/#/c/27272/44/vdsm_api/Bridge.py
File vdsm_api/Bridge.py:
Line 363: 'VM_hotUnplugNic': {'ret': 'vmList'},
Line 364: 'VM_mergeStatus': {'ret': 'mergeStatus'},
Line 365: 'VM_migrationCreate': {'ret': VM_migrationCreate_Ret},
Line 366: 'VM_setNumberOfCpus': {'ret': 'vmList'},
Line 367: 'VM_updateVmPolicy': {},
We do not need empty command_info. Please remove.
Done
Line 368: 'Volume_copy': {'ret': 'uuid'},
Line 369: 'Volume_create': {'ret': 'uuid'},
Line 370: 'Volume_delete': {'ret': 'uuid'},
Line 371: 'Volume_getInfo': {'ret': 'info'},
http://gerrit.ovirt.org/#/c/27272/44/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 7364: # @vmID:The UUID of the VM
Line 7365: #
Line 7366: # @vcpuLimit: vcpu limit to set - the value is a percentage
representation
Line 7367: # of the amount of cpu from the Host that the VM can
consume
Line 7368: #
Please align in line description of parameters.
Done
Line 7369: # Returns:
Line 7370: # The VM definition, as updated
Line 7371: #
Line 7372: # Since: 4.15.0
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 44
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 45: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9200/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1499/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/827/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10139/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5066/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1252/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3223/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9203/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1500/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9987/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10142/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5069/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3226/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 12: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9201/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9985/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10140/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5067/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1253/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3224/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9204/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1501/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9988/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10143/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5070/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3227/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Dan Kenigsberg has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 12: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28462/12/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4649:
Line 4650: def setCpuTuneQuota(self, quota):
Line 4651:
Line 4652: try:
Line 4653: quota = int(quota)
you seem to have ignored fromani's comments to patchset 11.
Line 4654: self._dom.setSchedulerParameters({'vcpu_quota': quota})
Line 4655: except ValueError:
Line 4656: return self._reportError(key='cpuTuneErr', msg=
Line 4657: 'an integer is required for
period')
--
To view, visit http://gerrit.ovirt.org/28462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 58: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9202/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10141/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5068/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3225/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 58 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: simplify string conversion methods
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: simplify string conversion methods
..
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27473/4/lib/vdsm/netlink/link.py
File lib/vdsm/netlink/link.py:
Line 51:
Line 52: def _link_info(cache, link):
Line 53: Returns a dictionary with the information of the link object.
Line 54: info = {}
Line 55: info['address'] = _nladdr_to_str(_rtnl_link_get_addr(link)),
This is wrong! the comma at the end makes it be a tuple!
Line 56: info['flags'] = _rtnl_link_get_flags(link)
Line 57: info['index'] = _rtnl_link_get_ifindex(link)
Line 58: info['mtu'] = _rtnl_link_get_mtu(link)
Line 59: info['name'] = _rtnl_link_get_name(link)
--
To view, visit http://gerrit.ovirt.org/27473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cdd56cd243095d75a37c66d79e13c2715642d97
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: simplify string conversion methods
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: simplify string conversion methods .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9205/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9989/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10144/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5071/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3228/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cdd56cd243095d75a37c66d79e13c2715642d97 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Small post-jsonrpc udpates
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Small post-jsonrpc udpates .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9206/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9990/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10145/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5072/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1254/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3229/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Martin Sivák has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 12: I didn't. The patch lost the review because of the rebase. I did not touch it at all. (But I will repost with fixes once the tests finish). -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Martin Sivák has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 11:
(4 comments)
http://gerrit.ovirt.org/#/c/28462/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4494:
Line 4495: def setCpuTuneQuota(self, quota):
Line 4496:
Line 4497: try:
Line 4498: quota = int(quota)
This looks useless: you can write
Done
Line 4499: self._dom.setSchedulerParameters({'vcpu_quota': quota})
Line 4500: except ValueError:
Line 4501: return self._reportError(key='cpuTuneErr', msg=
Line 4502: 'an integer is required for
period')
Line 4504: return self._reportError(key='cpuTuneErr', msg=e.message)
Line 4505: return {'status': doneCode}
Line 4506:
Line 4507: def setCpuTunePeriod(self, period):
Line 4508:
unnecessary whitespace (or missing docstring?)
Done
Line 4509: try:
Line 4510: period = int(period)
Line 4511: self._dom.setSchedulerParameters({'vcpu_period': period})
Line 4512: except ValueError:
Line 4506:
Line 4507: def setCpuTunePeriod(self, period):
Line 4508:
Line 4509: try:
Line 4510: period = int(period)
same as per line 4498
Done
Line 4511: self._dom.setSchedulerParameters({'vcpu_period': period})
Line 4512: except ValueError:
Line 4513: return self._reportError(key='cpuTuneErr', msg=
Line 4514: 'an integer is required for
period')
Line 4510: period = int(period)
Line 4511: self._dom.setSchedulerParameters({'vcpu_period': period})
Line 4512: except ValueError:
Line 4513: return self._reportError(key='cpuTuneErr', msg=
Line 4514: 'an integer is required for
period')
it is strange pep8 doesn't complain. However, I'd like to have
Done
Line 4515: except libvirt.libvirtError as e:
Line 4516: return self._reportError(key='cpuTuneErr', msg=e.message)
Line 4517: return {'status': doneCode}
Line 4518:
--
To view, visit http://gerrit.ovirt.org/28462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Francesco Romani has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 13: Code-Review-1
(2 comments)
-1 only for visibility
http://gerrit.ovirt.org/#/c/28462/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4653: except ValueError:
Line 4654: return self._reportError(key='cpuTuneErr', msg=
Line 4655: 'an integer is required for
period')
Line 4656: except libvirt.libvirtError as e:
Line 4657: return self._reportError(key='cpuTuneErr', msg=e.message)
self._reportException is probably better here
Line 4658: return {'status': doneCode}
Line 4659:
Line 4660: def setCpuTunePeriod(self, period):
Line 4661: try:
Line 4663: except ValueError:
Line 4664: return self._reportError(key='cpuTuneErr',
Line 4665: msg='an integer is required for
period')
Line 4666: except libvirt.libvirtError as e:
Line 4667: return self._reportError(key='cpuTuneErr', msg=e.message)
ditto
Line 4668: return {'status': doneCode}
Line 4669:
Line 4670: def _reportError(self, key, msg=None):
Line 4671:
--
To view, visit http://gerrit.ovirt.org/28462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9207/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1502/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9991/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10146/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5073/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3230/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Small post-jsonrpc udpates
Nir Soffer has posted comments on this change. Change subject: vdsm: Small post-jsonrpc udpates .. Patch Set 1: Code-Review-1 (12 comments) This is a bunch of unrelated changes that should be submitted in separate unrelated patches (don't make patches depened on each other). http://gerrit.ovirt.org/#/c/28688/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-06-13 11:11:13 +0200 Line 6: Line 7: vdsm: Small post-jsonrpc udpates Line 8: Line 9: Docstrings updated for MultiProtocolAcceptor and ConnectedTCPServer. Separate to improving documenation patch Line 10: Command line test for SecureXMLRPCServer made to be unit test. Line 11: SSlTests updated to use new sslutils module. Line 12: Line 13: Line 6: Line 7: vdsm: Small post-jsonrpc udpates Line 8: Line 9: Docstrings updated for MultiProtocolAcceptor and ConnectedTCPServer. Line 10: Command line test for SecureXMLRPCServer made to be unit test. Nice but I think that nobody uses this class except the ssl tests. Anyway, not related to first change, submit a separate patch. Line 11: SSlTests updated to use new sslutils module. Line 12: Line 13: Line 14: Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f Line 7: vdsm: Small post-jsonrpc udpates Line 8: Line 9: Docstrings updated for MultiProtocolAcceptor and ConnectedTCPServer. Line 10: Command line test for SecureXMLRPCServer made to be unit test. Line 11: SSlTests updated to use new sslutils module. Again, not related, sumbit in a separate patch. Line 12: Line 13: Line 14: Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f http://gerrit.ovirt.org/#/c/28688/1/lib/vdsm/SecureXMLRPCServer.py File lib/vdsm/SecureXMLRPCServer.py: Line 39 Line 40 Line 41 Line 42 Line 43 Do you do this in another module now? It is very hard to review such change in gerrit. Line 57 Line 58 Line 59 Line 60 Line 61 Removed due to interpreter complaining about multiple values for keyword a This is wrong. You must understand why it happens and not use voodoo programming. Line 37: Line 38: from sslutils import SSLServerSocket Line 39: from .utils import IPXMLRPCRequestHandler, SimpleIPXMLRPCServer Line 40: Line 41: SecureXMLRPCRequestHandler = IPXMLRPCRequestHandler Who uses this now? Line 42: Line 43: Line 44: class SecureXMLRPCServer(SimpleIPXMLRPCServer): Line 45: def __init__(self, addr, Line 40: Line 41: SecureXMLRPCRequestHandler = IPXMLRPCRequestHandler Line 42: Line 43: Line 44: class SecureXMLRPCServer(SimpleIPXMLRPCServer): Who uses this class now? Line 45: def __init__(self, addr, Line 46: requestHandler=IPXMLRPCRequestHandler, Line 47: logRequests=True, allow_none=False, encoding=None, Line 48: bind_and_activate=True, http://gerrit.ovirt.org/#/c/28688/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 30: from fnmatch import fnmatch Line 31: from SimpleXMLRPCServer import \ Line 32: SimpleXMLRPCRequestHandler, \ Line 33: SimpleXMLRPCServer, \ Line 34: SimpleXMLRPCDispatcher Don't use \ for line breaking, and don't import multyple names per line. The previous imports were just fine. Line 35: from Queue import Queue Line 36: from StringIO import StringIO Line 37: from weakref import proxy Line 38: import SocketServer Line 284: def __init__(self, requestHandler=IPXMLRPCRequestHandler, Line 285: logRequests=True, allow_none=False, encoding=None, Line 286: bind_and_activate=False): Line 287: ConnectedSimpleXmlRPCServer.__init__(self, requestHandler, Line 288: logRequests, allow_none, encoding) Please use optional calling style for optional args. Line 289: Line 290: Line 291: class SimpleIPXMLRPCServer(SimpleXMLRPCServer): Line 292: Line 300: SimpleXMLRPCServer.__init__(self, addr, requestHandler=requestHandler, Line 301: logRequests=logRequests, Line 302: allow_none=allow_none, Line 303: encoding=encoding, Line 304: bind_and_activate=bind_and_activate) This is used only by SecureXMLRPCServer - right? move it there, possibly into the class itself instead of adding a new class. Line 305: Line 306: Line 307: # Threaded version of SimpleXMLRPCServer Line 308: class SimpleThreadedXMLRPCServer(SocketServer.ThreadingMixIn, http://gerrit.ovirt.org/#/c/28688/1/tests/secureXmlRpcServerTests.py File tests/secureXmlRpcServerTests.py: Line 22: import ssl Line 23: Line 24: from vdsm.SecureXMLRPCServer import \ Line 25: SecureXMLRPCServer, \ Line 26: VerifyingSafeTransport There is no reason to use mulitple lines here. Line 27: from testrunner import VdsmTestCase as TestCaseBase Line 28: import jsonRpcHelper Line 29: Line 30: Line 74: def stop(self): Line 75:
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 46: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9208/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10147/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5074/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1255/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3231/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 46 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Kobi Ianko has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9209/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9993/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/831/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10148/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5075/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1256/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3232/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9211/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1504/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9995/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10150/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5077/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3234/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Bala.FA has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume.
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28581/5/vdsm/gluster/api.py
File vdsm/gluster/api.py:
Line 203:replicaCount=0, options=None):
Line 204: self.svdsmProxy.glusterVolumeRemoveBrickForce(volumeName,
brickList,
Line 205: replicaCount)
Line 206:
Line 207: def computeVolumeStats(self, data):
May be a private method by _computeVolumeStats()?
Line 208: total = (data.f_blocks - (data.f_bfree - data.f_bavail)) *
data.f_bsize
Line 209: free = data.f_bavail * data.f_bsize
Line 210: used = total - free
Line 211: return {'sizeTotal': str(total),
--
To view, visit http://gerrit.ovirt.org/28581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 59: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9210/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9994/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/832/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10149/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5076/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3233/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 59 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Darshan N has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume.
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28581/5/vdsm/gluster/api.py
File vdsm/gluster/api.py:
Line 203:replicaCount=0, options=None):
Line 204: self.svdsmProxy.glusterVolumeRemoveBrickForce(volumeName,
brickList,
Line 205: replicaCount)
Line 206:
Line 207: def computeVolumeStats(self, data):
May be a private method by _computeVolumeStats()?
Done
Line 208: total = (data.f_blocks - (data.f_bfree - data.f_bavail)) *
data.f_bsize
Line 209: free = data.f_bavail * data.f_bsize
Line 210: used = total - free
Line 211: return {'sizeTotal': str(total),
--
To view, visit http://gerrit.ovirt.org/28581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Darshan N has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/28581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 47: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9996/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/833/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10151/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5078/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1257/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3235/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 47 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit// : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10154/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5081/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3238/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Small post-jsonrpc udpates
Nir Soffer has posted comments on this change.
Change subject: vdsm: Small post-jsonrpc udpates
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/28688/1/lib/vdsm/SecureXMLRPCServer.py
File lib/vdsm/SecureXMLRPCServer.py:
Line 39
Line 40
Line 41
Line 42
Line 43
It was not moved anywhere. I checked and non of the M2C examples has it and
We must init M2Crypto.threading module. Of course it did not break when you
tested it, threading issues need lof of concurrency and iterations to show.
This should move to high level module, maybe in vdsm/vdsm - check if we are
using ssl, and init M2Crypto there. This should not be hidden in some low level
module. Also find the documentation of this method and add a comment why this
is required, so future developer do not remove it.
Line 40:
Line 41: SecureXMLRPCRequestHandler = IPXMLRPCRequestHandler
Line 42:
Line 43:
Line 44: class SecureXMLRPCServer(SimpleIPXMLRPCServer):
The class is used in kaxmlrpclib module.
It is not, that module import this module, but never uses this class :-)
$ git grep SecureXMLRPCServer
debian/vdsm-python.install:./usr/lib/python2.7/dist-packages/vdsm/SecureXMLRPCServer.py
lib/vdsm/Makefile.am: SecureXMLRPCServer.py \
lib/vdsm/SecureXMLRPCServer.py:SecureXMLRPCServer.py - simple XML RPC server
supporting SSL.
lib/vdsm/SecureXMLRPCServer.py:class SecureXMLRPCServer(IPXMLRPCServer):
lib/vdsm/SecureXMLRPCServer.py:
SecureXMLRPCServer):
lib/vdsm/SecureXMLRPCServer.py:server = SecureXMLRPCServer((self.host,
self.port),
lib/vdsm/vdscli.py.in:from . import SecureXMLRPCServer
lib/vdsm/vdscli.py.in:
TransportClass=SecureXMLRPCServer.VerifyingSafeTransport):
tests/sslTests.py:from vdsm import SecureXMLRPCServer
tests/sslTests.py:self.server = SecureXMLRPCServer.SSLServerSocket(
vdsm.spec.in:%{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py*
vdsm/kaxmlrpclib.py:from vdsm import SecureXMLRPCServer
vdsm/kaxmlrpclib.py:class
TcpkeepSafeTransport(SecureXMLRPCServer.VerifyingSafeTransport):
vdsm/kaxmlrpclib.py:class
TcpkeepHTTPSConnection(SecureXMLRPCServer.VerifyingHTTPSConnection):
vdsm/kaxmlrpclib.py:
SecureXMLRPCServer.VerifyingHTTPSConnection.__init__(
vdsm/kaxmlrpclib.py:
SecureXMLRPCServer.VerifyingHTTPSConnection.connect(self)
vdsm/kaxmlrpclib.py:class TcpkeepHTTPS(SecureXMLRPCServer.VerifyingHTTPS):
The only usage of this class was in the test that you just deleted bellow, and
in the test that you added.
Nobody use now lib/vdsm/SecureXMLRCPServer.SecureXMLRPCServer class - kill it
(in a separate patch)
Line 45: def __init__(self, addr,
Line 46: requestHandler=IPXMLRPCRequestHandler,
Line 47: logRequests=True, allow_none=False, encoding=None,
Line 48: bind_and_activate=True,
--
To view, visit http://gerrit.ovirt.org/28688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Martin Sivák has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/28462/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4653: except ValueError:
Line 4654: return self._reportError(key='cpuTuneErr', msg=
Line 4655: 'an integer is required for
period')
Line 4656: except libvirt.libvirtError as e:
Line 4657: return self._reportError(key='cpuTuneErr', msg=e.message)
self._reportException is probably better here
Done
Line 4658: return {'status': doneCode}
Line 4659:
Line 4660: def setCpuTunePeriod(self, period):
Line 4661: try:
Line 4663: except ValueError:
Line 4664: return self._reportError(key='cpuTuneErr',
Line 4665: msg='an integer is required for
period')
Line 4666: except libvirt.libvirtError as e:
Line 4667: return self._reportError(key='cpuTuneErr', msg=e.message)
ditto
Done
Line 4668: return {'status': doneCode}
Line 4669:
Line 4670: def _reportError(self, key, msg=None):
Line 4671:
--
To view, visit http://gerrit.ovirt.org/28462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 14: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9997/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10152/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5079/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1258/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3236/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
Martin Sivák has posted comments on this change.
Change subject: Adding updateVmPolicy api
..
Patch Set 47:
(1 comment)
http://gerrit.ovirt.org/#/c/27272/47/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 7472: # @period: a number representing the period to be set
Line 7473: # Returns:
Line 7474: # Status code
Line 7475: #
Line 7476: # Since: 4.15.0dge
As in patch set #45 we do not need those characters here. Please remove.
I hate it when a search dialog leaks to the underlying window.. fixed
Line 7477: ##
Line 7478: {'command': {'class': 'VM', 'name': 'setCpuTunePeriod'},
Line 7479: 'data': {'period': 'int'},
Line 7480: 'returns': 'TasksStatus'}
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 47
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: use 'localhost' explicitly in test
Dan Kenigsberg has posted comments on this change. Change subject: tests: use 'localhost' explicitly in test .. Patch Set 1: With http://gerrit.ovirt.org/28674 merged, I believe that this patch should be abandoned. -- To view, visit http://gerrit.ovirt.org/28107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 60: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9998/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/835/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10153/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5080/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3237/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 60 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 48: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9216/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/1/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/836/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10155/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5082/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1259/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3239/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 48 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _*info back together
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Move _*info back together
..
netinfo: Move _*info back together
Change-Id: I47700f8945b166ad706b2ccc9fd8f80641d3f89d
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M lib/vdsm/netinfo.py
1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/28699/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 2bfdb93..be6d8fb 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -560,24 +560,6 @@
return data
-def _bridgeinfo(link, gateways, ipv6routes, ipaddrs):
-info = _devinfo(link, ipaddrs)
-info.update({'gateway': getgateway(gateways, link.name),
- 'ipv6gateway': ipv6routes.get(link.name, '::'),
- 'ports': ports(link.name),
- 'stp': bridge_stp_state(link.name),
- 'opts': bridgeOpts(link.name)})
-return info
-
-
-def _nicinfo(link, paddr, ipaddrs):
-info = _devinfo(link, ipaddrs)
-info.update({'hwaddr': link.address, 'speed': nicSpeed(link.name)})
-if paddr.get(link.name):
-info['permhwaddr'] = paddr[link.name]
-return info
-
-
def _randomIfaceName():
MAX_LENGTH = 15
CHARS = string.ascii_lowercase + string.ascii_uppercase + string.digits
@@ -658,6 +640,24 @@
in sorted(opts.iteritems(
+def _bridgeinfo(link, gateways, ipv6routes, ipaddrs):
+info = _devinfo(link, ipaddrs)
+info.update({'gateway': getgateway(gateways, link.name),
+ 'ipv6gateway': ipv6routes.get(link.name, '::'),
+ 'ports': ports(link.name),
+ 'stp': bridge_stp_state(link.name),
+ 'opts': bridgeOpts(link.name)})
+return info
+
+
+def _nicinfo(link, paddr, ipaddrs):
+info = _devinfo(link, ipaddrs)
+info.update({'hwaddr': link.address, 'speed': nicSpeed(link.name)})
+if paddr.get(link.name):
+info['permhwaddr'] = paddr[link.name]
+return info
+
+
def _bondinfo(link, ipaddrs):
info = _devinfo(link, ipaddrs)
opts = getBondingOptions(link.name)
--
To view, visit http://gerrit.ovirt.org/28699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47700f8945b166ad706b2ccc9fd8f80641d3f89d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Move _devinfo out of _*info to avoid passing more
parameters
..
netinfo: Move _devinfo out of _*info to avoid passing more parameters
Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M lib/vdsm/netinfo.py
1 file changed, 21 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/28700/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index be6d8fb..87967b8 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -640,30 +640,25 @@
in sorted(opts.iteritems(
-def _bridgeinfo(link, gateways, ipv6routes, ipaddrs):
-info = _devinfo(link, ipaddrs)
-info.update({'gateway': getgateway(gateways, link.name),
- 'ipv6gateway': ipv6routes.get(link.name, '::'),
- 'ports': ports(link.name),
- 'stp': bridge_stp_state(link.name),
- 'opts': bridgeOpts(link.name)})
-return info
+def _bridgeinfo(link, gateways, ipv6routes):
+return {'gateway': getgateway(gateways, link.name),
+'ipv6gateway': ipv6routes.get(link.name, '::'),
+'ports': ports(link.name),
+'stp': bridge_stp_state(link.name),
+'opts': bridgeOpts(link.name)}
-def _nicinfo(link, paddr, ipaddrs):
-info = _devinfo(link, ipaddrs)
-info.update({'hwaddr': link.address, 'speed': nicSpeed(link.name)})
+def _nicinfo(link, paddr):
+info = {'hwaddr': link.address, 'speed': nicSpeed(link.name)}
if paddr.get(link.name):
info['permhwaddr'] = paddr[link.name]
return info
-def _bondinfo(link, ipaddrs):
-info = _devinfo(link, ipaddrs)
+def _bondinfo(link):
opts = getBondingOptions(link.name)
-
-info.update({'hwaddr': link.address, 'slaves': slaves(link.name),
- 'options': opts})
+info = {'hwaddr': link.address, 'slaves': slaves(link.name),
+'options': opts}
# Replace or empty legacy ifcfg options
if opts:
@@ -674,10 +669,8 @@
return info
-def _vlaninfo(link, ipaddrs):
-info = _devinfo(link, ipaddrs)
-info.update({'iface': link.device, 'vlanid': link.vlanid})
-return info
+def _vlaninfo(link):
+return {'iface': link.device, 'vlanid': link.vlanid}
def _devinfo(link, ipaddrs):
@@ -819,14 +812,17 @@
for dev in (link for link in getLinks() if not link.isHidden()):
if dev.isBRIDGE():
-d['bridges'][dev.name] = \
-_bridgeinfo(dev, gateways, ipv6routes, ipaddrs)
+info = d['bridges'][dev.name] = _bridgeinfo(dev, gateways,
+ipv6routes)
elif dev.isNICLike():
-d['nics'][dev.name] = _nicinfo(dev, paddr, ipaddrs)
+info = d['nics'][dev.name] = _nicinfo(dev, paddr)
elif dev.isBOND():
-d['bondings'][dev.name] = _bondinfo(dev, ipaddrs)
+info = d['bondings'][dev.name] = _bondinfo(dev)
elif dev.isVLAN():
-d['vlans'][dev.name] = _vlaninfo(dev, ipaddrs)
+info = d['vlans'][dev.name] = _vlaninfo(dev)
+else:
+continue
+info.update(_devinfo(link, ipaddrs))
_cfgBootprotoCompat(d)
--
To view, visit http://gerrit.ovirt.org/28700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Antoni Segura Puimedon has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume.
..
Patch Set 5:
(6 comments)
http://gerrit.ovirt.org/#/c/28581/5/vdsm/gluster/gfapi.py
File vdsm/gluster/gfapi.py:
Line 56: global _api
Line 57: if not _api:
Line 58: _api = ctypes.CDLL(find_library(gfapi),
Line 59:ctypes.RTLD_GLOBAL,
Line 60:use_errno=True)
I think _lib would be a better name for it. I would either:
* do what I wrote in the comments below, of just putting the ctypes at the end
of the file and not lazy (happening on module loading time).
* do as above, but lazily loading them into the module namespace.
Line 61: return
Line 62:
Line 63:
Line 64: def glfsInit(volumeId, host, port, protocol):
Line 63:
Line 64: def glfsInit(volumeId, host, port, protocol):
Line 65: _glfs_new = ctypes.CFUNCTYPE(
Line 66: ctypes.c_void_p, ctypes.c_char_p)(('glfs_new', _api))
Line 67: fs = _glfs_new(volumeId)
You'll be wrapping the C method on each volumeStatvfs. Please, consider moving
this definition to the module level.
Line 68:
Line 69: _glfs_set_volfile_server = ctypes.CFUNCTYPE(
Line 70: ctypes.c_int,
Line 71: ctypes.c_void_p,
Line 70: ctypes.c_int,
Line 71: ctypes.c_void_p,
Line 72: ctypes.c_char_p,
Line 73: ctypes.c_char_p,
Line 74: ctypes.c_int)(('glfs_set_volfile_server', _api))
You'll be wrapping the C method on each volumeStatvfs. Please, consider moving
this definition to the module level.
Line 75: rc = _glfs_set_volfile_server(fs,
Line 76: protocol,
Line 77: host,
Line 78: port)
Line 81: rc=rc, err=[setting volfile server failed]
Line 82: )
Line 83:
Line 84: _glfs_init = ctypes.CFUNCTYPE(
Line 85: ctypes.c_int, ctypes.c_void_p)(('glfs_init', _api))
You'll be wrapping the C method on each volumeStatvfs. Please, consider moving
this definition to the module level.
Line 86: rc = _glfs_init(fs)
Line 87: if rc == 0:
Line 88: return fs
Line 89: elif rc == 1:
Line 99:
Line 100:
Line 101: def glfsFini(fs, volumeId):
Line 102: _glfs_fini = ctypes.CFUNCTYPE(
Line 103: ctypes.c_int, ctypes.c_void_p)(('glfs_fini', _api))
You'll be wrapping the C method on each volumeStatvfs. Please, consider moving
this definition to the module level.
Line 104: rc = _glfs_fini(fs)
Line 105: if rc != 0:
Line 106: raise ge.GlfsFiniException(rc=rc)
Line 107:
Line 118: # Define return type and argtypes of glfs_statvfs
Line 119: _glfs_statvfs = ctypes.CFUNCTYPE(ctypes.c_int,
Line 120: ctypes.c_void_p,
Line 121: ctypes.c_char_p,
Line 122:
ctypes.c_void_p)(('glfs_statvfs', _api))
You'll be wrapping the C method on each volumeStatvfs. Please, consider moving
this definition to the module level.
Line 123:
Line 124: rc = _glfs_statvfs(fs, GLUSTER_VOL_PATH,
ctypes.byref(statvfsdata))
Line 125: if rc != 0:
Line 126: raise ge.GlfsStatvfsException(rc=rc)
--
To view, visit http://gerrit.ovirt.org/28581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Antoni Segura Puimedon has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 6: Code-Review-1 Please, see my comments to patchset 5. -- To view, visit http://gerrit.ovirt.org/28581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _*info back together
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Move _*info back together .. Patch Set 1: Code-Review+1 I was wondering who had separated them... -- To view, visit http://gerrit.ovirt.org/28699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47700f8945b166ad706b2ccc9fd8f80641d3f89d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 1: Nice refactoring. It looks better now ;-) -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 49: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1507/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10001/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/837/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10156/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5083/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1260/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3240/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 49 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9220/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1508/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10004/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10159/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5086/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3243/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28592/6/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 759: addrs[addr['label']].append(addr) Line 760: return addrs Line 761: Line 762: Line 763: def _libvirtNets2vdsm(nets, dhcp4, gateways=None, ipv6routes=None, please, make dhcp4=None and treat it like gatewas, ip routes, etc. If it is None, obtain it. (for the reason, check the usage of the method in vdsm/network/api.py Line 764: ipAddrs=None): Line 765: if gateways is None: Line 766: gateways = getRoutes() Line 767: if ipv6routes is None: -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Small post-jsonrpc udpates
Nir Soffer has posted comments on this change. Change subject: vdsm: Small post-jsonrpc udpates .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28688/1/lib/vdsm/SecureXMLRPCServer.py File lib/vdsm/SecureXMLRPCServer.py: Line 40: Line 41: SecureXMLRPCRequestHandler = IPXMLRPCRequestHandler Line 42: Line 43: Line 44: class SecureXMLRPCServer(SimpleIPXMLRPCServer): Please check the module as I specified above on line 112. Line 112 does: from vdsm import SecureXMLRPCServer What is SecureXMLRPCServer? Line 45: def __init__(self, addr, Line 46: requestHandler=IPXMLRPCRequestHandler, Line 47: logRequests=True, allow_none=False, encoding=None, Line 48: bind_and_activate=True, -- To view, visit http://gerrit.ovirt.org/28688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10002/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/838/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10157/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5084/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1261/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3241/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Small post-jsonrpc udpates
Nir Soffer has posted comments on this change. Change subject: vdsm: Small post-jsonrpc udpates .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28688/1/lib/vdsm/SecureXMLRPCServer.py File lib/vdsm/SecureXMLRPCServer.py: Line 40: Line 41: SecureXMLRPCRequestHandler = IPXMLRPCRequestHandler Line 42: Line 43: Line 44: class SecureXMLRPCServer(SimpleIPXMLRPCServer): You lost me. kaxmlrpclib import this *module*, but never access the SecureXMLRPCServer *class* which can be deleted. Line 45: def __init__(self, addr, Line 46: requestHandler=IPXMLRPCRequestHandler, Line 47: logRequests=True, allow_none=False, encoding=None, Line 48: bind_and_activate=True, -- To view, visit http://gerrit.ovirt.org/28688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _*info back together
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Move _*info back together .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9221/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1509/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10005/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10160/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5087/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3244/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47700f8945b166ad706b2ccc9fd8f80641d3f89d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 61: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9219/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10003/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/839/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10158/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5085/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3242/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 61 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Michal Skrivanek has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 5: Code-Review+1 announcement sent http://lists.ovirt.org/pipermail/devel/2014-June/007643.html also separately to QE group no objections till now, let's go ahead -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9222/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1510/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10006/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10161/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5088/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3245/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: add gateway reporting to all devices
Antoni Segura Puimedon has abandoned this change. Change subject: netinfo: add gateway reporting to all devices .. Abandoned gerrit is being funny. -- To view, visit http://gerrit.ovirt.org/28614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0f48ec26aa351c904dcc5d2073e40c002bd4f14e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: add gateway reporting to all devices
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netinfo: add gateway reporting to all devices
..
netinfo: add gateway reporting to all devices
by adding gateway reporting to all the devices we make it possible
to for a vdsm client to gather which is the gateway of the device
that is to be used for providing link to a bridged (VM) network.
Change-Id: I5dc4730214efa9eaba8425c3bf4842441b97084f
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/netinfo.py
M lib/vdsm/netlink/route.py
2 files changed, 48 insertions(+), 31 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/28704/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index e42e6f4..bcbfcab 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -48,6 +48,7 @@
from .utils import execCmd, memoized, CommandPath
from .netlink import link as nl_link
from .netlink import addr as nl_addr
+from .netlink import route as nl_route
NET_CONF_DIR = '/etc/sysconfig/network-scripts/'
@@ -511,8 +512,8 @@
return paddr
-def _getNetInfo(iface, dhcp4, bridged, gateways, ipv6routes, ipaddrs,
-qosInbound, qosOutbound):
+def _getNetInfo(iface, dhcp4, bridged, routes, ipaddrs, qosInbound,
+qosOutbound):
'''Returns a dictionary of properties about the network's interface status.
Raises a KeyError if the iface does not exist.'''
data = {}
@@ -530,10 +531,10 @@
data.update({'iface': iface, 'bridged': bridged,
'addr': ipv4addr, 'netmask': ipv4netmask,
'bootproto4': 'dhcp' if iface in dhcp4 else 'none',
- 'gateway': getgateway(gateways, iface),
'ipv4addrs': ipv4addrs,
'ipv6addrs': ipv6addrs,
- 'ipv6gateway': ipv6routes.get(iface, '::'),
+ 'gateway': _getGateway(routes, iface),
+ 'ipv6gateway': _getGateway(routes, iface, family=6),
'mtu': str(getMtu(iface))})
if qosInbound:
data['qosInbound'] = qosInbound
@@ -548,18 +549,16 @@
return data
-def _bridgeinfo(link, gateways, ipv6routes, ipaddrs):
-info = _devinfo(link, ipaddrs)
-info.update({'gateway': getgateway(gateways, link.name),
- 'ipv6gateway': ipv6routes.get(link.name, '::'),
- 'ports': ports(link.name),
+def _bridgeinfo(link, routes, ipaddrs):
+info = _devinfo(link, routes, ipaddrs)
+info.update({'ports': ports(link.name),
'stp': bridge_stp_state(link.name),
'opts': bridgeOpts(link.name)})
return info
-def _nicinfo(link, paddr, ipaddrs):
-info = _devinfo(link, ipaddrs)
+def _nicinfo(link, paddr, routes, ipaddrs):
+info = _devinfo(link, routes, ipaddrs)
info.update({'hwaddr': link.address, 'speed': nicSpeed(link.name)})
if paddr.get(link.name):
info['permhwaddr'] = paddr[link.name]
@@ -636,24 +635,26 @@
if val and val != defaults.get(opt)))
-def _bondinfo(link, ipaddrs):
-info = _devinfo(link, ipaddrs)
+def _bondinfo(link, routes, ipaddrs):
+info = _devinfo(link, routes, ipaddrs)
info.update({'hwaddr': link.address, 'slaves': slaves(link.name)})
return info
-def _vlaninfo(link, ipaddrs):
-info = _devinfo(link, ipaddrs)
+def _vlaninfo(link, routes, ipaddrs):
+info = _devinfo(link, routes, ipaddrs)
info.update({'iface': link.device, 'vlanid': link.vlanid})
return info
-def _devinfo(link, ipaddrs):
+def _devinfo(link, routes, ipaddrs):
ipv4addr, ipv4netmask, ipv4addrs, ipv6addrs = getIpInfo(link.name, ipaddrs)
return {'addr': ipv4addr,
'cfg': getIfaceCfg(link.name),
'ipv4addrs': ipv4addrs,
'ipv6addrs': ipv6addrs,
+'gateway': _getGateway(routes, link.name),
+'ipv6gateway': _getGateway(routes, link.name, family=6),
'mtu': str(link.mtu),
'netmask': ipv4netmask}
@@ -734,13 +735,30 @@
return addrs
-def _libvirtNets2vdsm(nets, gateways=None, ipv6routes=None,
- ipAddrs=None):
+def _getGateway(routes, dev, family=4):
+Returns the default gateway for a device and an address family
+try:
+gateway, = [r for r in routes[dev] if
+r['destination'] == 'none' and
+r['family'] == ('inet6' if family == 6 else 'inet') and
+r['scope'] == 'universe' and
+r['table'] == nl_route.MAIN_TABLE]
+except ValueError: # no default gateway for the device
+return '::' if family == 6 else ''
+return gateway['gateway']
+
+
+def _getRoutes():
+routes = defaultdict(list)
+for route in nl_route.iter_routes():
+routes[route['oif']].append(route)
+return routes
+
+
+def
Change in vdsm[master]: netlink: add route retrieval capability
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: add route retrieval capability .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9224/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/744/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10008/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10163/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5090/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3247/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d9eb4818d418ab5604a9530c26f93ef7e8e322 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Check storage functional tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Check storage functional tests .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9223/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10007/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/840/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10162/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5089/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1262/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3246/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica752d33e4b335c2e9da40fa117296220f8eef61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: add gateway reporting to all devices
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: add gateway reporting to all devices .. Patch Set 1: Verified+1 Ran the functional tests: rhel65_01 tests (b38ff07) # ./run_tests_local.sh -x functional/networkTests.py NetworkTest testAddDelBondedNetwork(kwargs=False) OK testAddDelBondedNetwork(kwargs=True)OK testAddDelNetwork(kwargs=False) OK testAddDelNetwork(kwargs=True) OK testAddNetworkBondWithManyVlans(kwargs=False) OK testAddNetworkBondWithManyVlans(kwargs=True)OK testAddNetworkManyVlans(kwargs=False) OK testAddNetworkManyVlans(kwargs=True)OK testAddNetworkVlan(kwargs=False)OK testAddNetworkVlan(kwargs=True) OK testAddNetworkVlanBond(kwargs=False)OK testAddNetworkVlanBond(kwargs=True) OK testAddVlanedBridgeless OK testAddVlanedBridgeless_oneCommand OK testAfterNetworkSetupHook OK testBeforeNetworkSetupHook OK testBondHwAddress(kwargs=False) OK testBondHwAddress(kwargs=True) OK testBrokenBridgelessNetReplacement OK testDelNetworkBondAccumulation OK testDelNetworkWithMTU(kwargs=False) OK testDelNetworkWithMTU(kwargs=True) OK testDelWithoutAdd(kwargs=False) OK testDelWithoutAdd(kwargs=True) OK testDhclientLeases(kwargs='default')OK testDhclientLeases(kwargs='local') OK testEditWithoutAdd(kwargs=False)OK testEditWithoutAdd(kwargs=True) OK testFailWithInvalidBondingName(kwargs=False)OK testFailWithInvalidBondingName(kwargs=True) OK testFailWithInvalidBridgeName OK testFailWithInvalidIpConfig OK testFailWithInvalidNic(kwargs=False)OK testFailWithInvalidNic(kwargs=True) OK testFailWithInvalidParams(kwargs=False) OK testFailWithInvalidParams(kwargs=True) OK testGetRouteDeviceToOK testHonorBlockingDhcp OK testIPv6ConfigNetwork OK testIpLinkWrapper OK testLowerMtuDoesNotOverride OK testNoBridgeLeftovers OK testQosNetwork OK testRedefineBondedNetworkIPsOK testRouteExists OK testRuleExists OK testSafeNetworkConfig(kwargs=False) OK testSafeNetworkConfig(kwargs=True) OK testSetupNetworksAddBadParams(bridged=False)OK testSetupNetworksAddBadParams(bridged=True) OK testSetupNetworksAddBondWithManyVlans(kwargs=False) OK testSetupNetworksAddBondWithManyVlans(kwargs=True) OK testSetupNetworksAddDelBondedNetwork(kwargs=False) OK testSetupNetworksAddDelBondedNetwork(kwargs=True) OK testSetupNetworksAddDelDhcp(kwargs=False) OK testSetupNetworksAddDelDhcp(kwargs=True)OK testSetupNetworksAddManyVlans(kwargs=False) OK testSetupNetworksAddManyVlans(kwargs=True) OK testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)OK testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)OK testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)OK testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)OK testSetupNetworksAddOverExistingBond(kwargs=False) OK testSetupNetworksAddOverExistingBond(kwargs=True) OK testSetupNetworksAddVlan(kwargs=False) OK
Change in vdsm[master]: netlink: add route retrieval capability
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: add route retrieval capability .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.ovirt.org/27317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d9eb4818d418ab5604a9530c26f93ef7e8e322 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: add route retrieval capability
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: add route retrieval capability .. Patch Set 8: verified with the tip of the branch. -- To view, visit http://gerrit.ovirt.org/27317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d9eb4818d418ab5604a9530c26f93ef7e8e322 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: move netlink into a lib vdsm subpackage
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: move netlink into a lib vdsm subpackage .. Patch Set 4: Verified+1 Verified with the tip of the branch -- To view, visit http://gerrit.ovirt.org/27472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b393588ccb3ac0c4529446c285570f49cdb1e28 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: add gateway reporting to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: add gateway reporting to all devices .. Patch Set 1: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9225/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1511/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10009/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10164/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5091/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3248/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dc4730214efa9eaba8425c3bf4842441b97084f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: simplify string conversion methods
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: simplify string conversion methods .. Patch Set 5: Verified+1 Verified with the tip of the branch -- To view, visit http://gerrit.ovirt.org/27473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cdd56cd243095d75a37c66d79e13c2715642d97 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _*info back together
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Move _*info back together .. Patch Set 1: Verified+1 No functional change. -- To view, visit http://gerrit.ovirt.org/28699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47700f8945b166ad706b2ccc9fd8f80641d3f89d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: Fix wrong usage of properties on old style class
Federico Simoncelli has posted comments on this change. Change subject: sd: Fix wrong usage of properties on old style class .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89aee24f1fc472bf6425e4194cea58c7f7b52dc8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 2: Backwards compatibility was borked, now it is hopefully fixed and working. -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: unify validateCreateVolumeParams
Federico Simoncelli has posted comments on this change. Change subject: sd: unify validateCreateVolumeParams .. Patch Set 7: The patch has been rebased. -- To view, visit http://gerrit.ovirt.org/28128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082dc8b382af4a163fd4d10c67e696b1072e6b71 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: extract the vm destroy in a method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: extract the vm destroy in a method .. Patch Set 3: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9226/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10010/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/841/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10165/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5092/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3249/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91de9dc310cd563396e0f646533ba986bcb7e35e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 18: clarified the units; Explained previously while I don't think the division by zero is a real problem (there is an check before this code which will ensure the divisor being 0) Checked AdvancedStats*. It is indeed quite similar to this use case, but still different enough to deserve some preparation work which I don't feel is useful for this patchset. I'm exploring a bit more generic concept in my upcoming threadpool patchset, we can port this code on top of that in a later patch. -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add direct import of advancedstats helpers
Francesco Romani has posted comments on this change. Change subject: vm: add direct import of advancedstats helpers .. Patch Set 4: Verified+1 trivial import juggling. Verified by unit and functional tests. -- To view, visit http://gerrit.ovirt.org/28480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 2: (2 comments) Just some comments. http://gerrit.ovirt.org/#/c/28700/2//COMMIT_MSG Commit Message: Line 6: Line 7: netinfo: Move _devinfo out of _*info to avoid passing more parameters Line 8: Line 9: API change: in _bondinfo, 'options' was changed to 'opts' Line 10: to mirror 'opts' in _bridgeinfo. Bonding options were not set in stone or used anyway, this unification should not hurt. Line 11: Line 12: Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 http://gerrit.ovirt.org/#/c/28700/2/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 775: if opts: Line 776: info['cfg']['BONDING_OPTS'] = ' '.join( Line 777: (opt + '=' + val[-1] for (opt, val) in sorted(opts.iteritems( Line 778: elif 'BONDING_OPTS' in info['cfg']: Line 779: info['cfg']['BONDING_OPTS'] = '' Original behaviour kept, even if it is questionable: we might as well delete the key. Line 780: Line 781: Line 782: def _cfgBootprotoCompat(netsAndDevices): Line 783: Set network 'cfg' 'BOOTPROTO' for backwards engine compatibility. -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/28592/6/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 759: addrs[addr['label']].append(addr) Line 760: return addrs Line 761: Line 762: Line 763: def _libvirtNets2vdsm(nets, dhcp4, gateways=None, ipv6routes=None, please, make dhcp4=None and treat it like gatewas, ip routes, etc. If it is Done Line 764: ipAddrs=None): Line 765: if gateways is None: Line 766: gateways = getRoutes() Line 767: if ipv6routes is None: -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1512/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10014/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10169/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5096/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3253/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Martin Sivák has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 15: Verified+1 Cosmetic changes only, the verification still stands valid (and it passes all tests). -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: abort and report error if domain destroy fails
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: abort and report error if domain destroy fails .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9227/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10011/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/842/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10166/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5093/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3250/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d5819321cd0cb28aa43678dc65ee83c215c2d7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9231/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1513/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10015/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10170/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5097/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3254/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: unify validateCreateVolumeParams
oVirt Jenkins CI Server has posted comments on this change. Change subject: sd: unify validateCreateVolumeParams .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9233/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10017/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10172/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5099/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1264/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3256/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082dc8b382af4a163fd4d10c67e696b1072e6b71 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: make preallocate optional in volume validation
oVirt Jenkins CI Server has posted comments on this change. Change subject: sd: make preallocate optional in volume validation .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9232/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10016/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10171/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5098/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1263/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3255/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide89098b404e992678441d4b6f996ff203e055f0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: Fix wrong usage of properties on old style class
Dan Kenigsberg has submitted this change and it was merged. Change subject: sd: Fix wrong usage of properties on old style class .. sd: Fix wrong usage of properties on old style class StorageDomain is an old style class but usess properties, which are supported *only* for new style classes. This is a nasty corner in Python where you can define @property on old style classes and they seems to work in some of the cases, and break in others. The current code happen to work because we never try to assign to the read only properties. The patch change StorageDomain to be a new style class, and fix the tests assuming an old style class. For more info see: https://docs.python.org/2.6/library/functions.html#property Change-Id: I89aee24f1fc472bf6425e4194cea58c7f7b52dc8 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28655 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M tests/getAllVolumesTests.py M vdsm/storage/sd.py 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89aee24f1fc472bf6425e4194cea58c7f7b52dc8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: narrow down try/except block in releaseVm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: narrow down try/except block in releaseVm .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9228/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10012/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/843/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10167/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5094/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3251/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c2b60d8f490f9559edad429baf3989e98d05cf6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: Fix wrong usage of properties on old style class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sd: Fix wrong usage of properties on old style class .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1445/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89aee24f1fc472bf6425e4194cea58c7f7b52dc8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: graphdev: rename a parameter for clarity
Francesco Romani has posted comments on this change.
Change subject: vm: graphdev: rename a parameter for clarity
..
Patch Set 3:
(1 comment)
And I actually discovered a bug! Thanks Toni! :)
http://gerrit.ovirt.org/#/c/28036/3/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 6262: ##
Line 6263: {'type': 'vmUpdateGraphicsDeviceParams',
Line 6264: 'data': {'graphicsType': 'VmGraphicsDeviceType', 'password': 'str',
Line 6265: 'ttl': 'int', 'existingConnAction':
'VmTicketConflictAction',
Line 6266: 'hookParams': 'StringMap'}}
I'm not sure about this. If I'm not mistaken, in the rest of the API, the h
Re-renamed to be conformant with setTicket
Line 6267:
Line 6268: ##
Line 6269: # @VM.updateDevice:
Line 6270: #
--
To view, visit http://gerrit.ovirt.org/28036
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3716b48a5fbe5beebb819754d0f500b097f04677
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve the logging when destroying domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: improve the logging when destroying domains .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9229/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10013/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10168/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5095/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3252/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib314ecd66bb7ccb95da96605d810041f767bc9e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 10: Reverted to using a string 'none' for bootproto4 because marshalling None was problematic. -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9240/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1514/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10024/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10179/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5106/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3263/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9234/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10018/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/845/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10173/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5100/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3257/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9241/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1515/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10025/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10180/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5107/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3264/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: persistentDict: Do not warn about missing checksum when meta...
oVirt Jenkins CI Server has posted comments on this change. Change subject: persistentDict: Do not warn about missing checksum when metadata is empty .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9242/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10026/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10181/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5108/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1265/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3265/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: persistentDict: Do not warn about missing checksum when meta...
Nir Soffer has posted comments on this change. Change subject: persistentDict: Do not warn about missing checksum when metadata is empty .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Small post-jsonrpc udpates
Nir Soffer has posted comments on this change. Change subject: vdsm: Small post-jsonrpc udpates .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28688/1/tests/secureXmlRpcServerTests.py File tests/secureXmlRpcServerTests.py: Line 74: def stop(self): Line 75: self.vtransport.close() Line 76: Line 77: Line 78: class XmlRpcServerTests(TestCaseBase): kaxmlrpclib module is using it. Now that we agree that this class is not used, why do we need to test it? Line 79: Line 80: def testServer(self): Line 81: server = Server() Line 82: client = Client() -- To view, visit http://gerrit.ovirt.org/28688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9235/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10019/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/846/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10174/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5101/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3258/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
