Change in vdsm[master]: json-rpc: fix the Host.getVMList return value
Omer Frenkel has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
Nir Soffer has uploaded a new change for review.
Change subject: virt: Allocate additonal space for cow internal data
..
virt: Allocate additonal space for cow internal data
In change I4098dfc07 (virt: Fix limit when calculating next volume size) we
fixed drive size limit so drive volume is limited by drive capacity. This
change introduced a regression where vm is paused when trying to fill up a
drive, and there is no way to resume it, since qemu cannot complete the write.
To allow a guest to use the entire drive capacity, we must allocate extra space
for cow internal data. Since it is tricky to compute the exact value, we use
the same estimate (1.1) used for converting raw volumes to cow and merging
volumes.
Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e
Signed-off-by: Nir Soffer
---
M tests/vmStorageTests.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 24 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/38178/1
diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py
index 14b748f..0e7a557 100644
--- a/tests/vmStorageTests.py
+++ b/tests/vmStorageTests.py
@@ -244,7 +244,7 @@
@expandPermutations
-class GetNextVolumeSizeTests(VdsmTestCase):
+class DriveVolumeSizeTests(VdsmTestCase):
CAPACITY = 8192 * constants.MEGAB
@@ -256,11 +256,18 @@
cursize / constants.MEGAB + drive.volExtensionChunk)
@permutations([[CAPACITY - 1], [CAPACITY], [CAPACITY + 1]])
-def test_capacity_limit(self, cursize):
+def test_next_size_limit(self, cursize):
conf = drive_config(format='cow')
drive = Drive({}, self.log, **conf)
self.assertEqual(drive.getNextVolumeSize(cursize, self.CAPACITY),
- self.CAPACITY / constants.MEGAB)
+ drive.getMaxVolumeSize(self.CAPACITY))
+
+def test_max_size(self):
+conf = drive_config(format='cow')
+drive = Drive({}, self.log, **conf)
+size = int(self.CAPACITY * drive.VOLWM_COW_OVERHEAD)
+self.assertEqual(drive.getMaxVolumeSize(self.CAPACITY),
+ size / constants.MEGAB + 1)
def drive_config(**kw):
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index d8a1def..e92de47 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -51,6 +51,9 @@
VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent')
VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during replication
+# Estimate of the additional space needed for qcow format internal data.
+VOLWM_COW_OVERHEAD = 1.1
+
def __init__(self, conf, log, **kwargs):
if not kwargs.get('serial'):
self.serial = kwargs.get('imageID'[-20:]) or ''
@@ -143,7 +146,17 @@
"""
curSizeMB = (curSize + constants.MEGAB - 1) / constants.MEGAB
nextSizeMB = curSizeMB + self.volExtensionChunk
-return min(nextSizeMB, capacity / constants.MEGAB)
+return min(nextSizeMB, self.getMaxVolumeSize(capacity))
+
+def getMaxVolumeSize(self, capacity):
+"""
+Returns the maximum volume size in megabytes. This value is larger than
+drive capacity since we must allocate extra space for cow internal
+data. The actual lv size may be larger due to rounding to next lvm
+extent.
+"""
+size = int(capacity * self.VOLWM_COW_OVERHEAD)
+return (size + constants.MEGAB - 1) / constants.MEGAB
@property
def chunked(self):
--
To view, visit https://gerrit.ovirt.org/38178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
Nir Soffer has uploaded a new change for review. Change subject: virt: Avoid pointless extension requests .. virt: Avoid pointless extension requests When a drive was extended up to the maximum volume size, the current extend logic is trying to extend the drive every 2 seconds. This results in fruitless extensions failing in lvextend because the requested size is equal to the current size. These extension requests may delay real requests, perform unneeded io, and fill up the log with bogus errors and warnings. Now we check if the drive was fully extended and do not try to extend it further. Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Signed-off-by: Nir Soffer --- M vdsm/virt/vm.py 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/38179/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index bdfb342..19e7455 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -1455,6 +1455,13 @@ self.pause(pauseCode='EOTHER') raise ImprobableResizeRequestError(msg) +maxPhysSize = drive.getMaxVolumeSize(capacity) * constants.MEGAB +if physical >= maxPhysSize: +# The volume was extended to the maximum size. physical may be +# larger than maximum volume size since it is rounded up to the +# next lvm extent. +return False + if physical - alloc < drive.watermarkLimit: return True return False -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Unify Drive size units
Nir Soffer has posted comments on this change. Change subject: virt: Unify Drive size units .. Patch Set 9: Code-Review-1 Should be rebased on https://gerrit.ovirt.org/38179 -- To view, visit https://gerrit.ovirt.org/37727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice01c9706fc27d4472c90e47bf7e808564ba0bfe Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Allocate additonal space for cow internal data .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2562/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16082/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15282/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16252/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1058/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Replacing xml.dom.minidom with lxml.etree module
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Replacing xml.dom.minidom with lxml.etree module .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/37736/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-11 14:29:23 +0200 Line 4: Commit: Genadi Chereshnya Line 5: CommitDate: 2015-02-18 09:55:11 +0200 Line 6: Line 7: netinfo: Replacing xml.dom.minidom with lxml.etree module lxml.etree -> cElementTree Line 8: Line 9: The change is done as etree is much faster than minidom Line 10: It requires lxml module to be installed Line 11: -- To view, visit https://gerrit.ovirt.org/37736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1a704cd53db56d64a3da6a056a322a6b35ee2bd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Genadi Chereshnya Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Avoid pointless extension requests .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2563/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16083/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15283/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16253/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1059/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Avoid pointless extension requests .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2564/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16084/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15284/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16254/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1060/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: fix the Host.getVMList return value
Francesco Romani has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: My claim[1] is that comment, as well as the one removed with this patch, was wrong and mislead the implementation into a significantly suboptimal one. +++ [1] Based on comparing JSON-RPC and XML-RPC and based on how vms monitoring code works (or should work) in Engine. That's why I asked Engine devs for review, to confirm or deny my finding. -- To view, visit https://gerrit.ovirt.org/38172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Allocate additonal space for cow internal data .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2565/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16085/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15285/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16255/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1061/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: fix the Host.getVMList return value
Francesco Romani has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: with this patch applied, I DO NOT see anymore the storm of Vm.getStats() after each Host.getVmList(), so it seems to work; but I also see Engine log filled with 2015-02-26 10:50:06,676 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.ListVDSCommand] (DefaultQuartzScheduler_Worker-28) [] Command 'ListVDSCommand(HostName = kenji, HostId = 9f569269-d267-4bf9-96c5-e1749b4c8dda, vds=Host[kenji,9f569269-d267-4bf9-96c5-e1749b4c8dda])' execution failed: java.util.LinkedHashMap cannot be cast to java.lang.String 2015-02-26 10:50:06,678 ERROR [org.ovirt.engine.core.utils.timer.SchedulerUtilQuartzImpl] (DefaultQuartzScheduler_Worker-28) [] Failed to invoke scheduled method vmsMonitoring: null 2015-02-26 10:50:09,690 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.ListVDSCommand] (DefaultQuartzScheduler_Worker-57) [] Failed in 'ListVDS' method, for vds: 'kenji'; host: '192.168.1.51': java.util.LinkedHashMap cannot be cast to java.lang.String -- To view, visit https://gerrit.ovirt.org/38172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Replacing xml.dom.minidom with cElementTree module
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Replacing xml.dom.minidom with cElementTree module .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16086/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15286/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16256/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2770/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1062/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1a704cd53db56d64a3da6a056a322a6b35ee2bd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Genadi Chereshnya Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build gluster packages only for rhel 7 and above
Yaniv Bronhaim has posted comments on this change. Change subject: Build gluster packages only for rhel 7 and above .. Patch Set 1: ping? -- To view, visit https://gerrit.ovirt.org/37646 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Cole Robinson Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Dan Kenigsberg has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38113/4/tests/samplingTests.py
File tests/samplingTests.py:
Line 23: import os
Line 24: import tempfile
Line 25: import random
Line 26: import shutil
Line 27: import threading
please try to keep in alphabetic order (I see that it's already broken, but no
need to break any further)
Line 28: import errno
Line 29:
Line 30: from vdsm import ipwrapper
Line 31: import virt.sampling as sampling
Line 154: with open(constants.P_VDSM_LIBVIRT_PASSWD) as passwd_file:
Line 155: return passwd_file.readline().rstrip("\n")
Line 156: except IOError as e:
Line 157: if e.errno == errno.ENOENT:
Line 158: return 'password'
There no real need to even attempt to read the password from file. it's useless
for this test. returning 'password' should be enough.
Line 159:
Line 160: @MonkeyPatch(libvirtconnection, '_read_password', _read_password)
Line 161: @ValidateRunningAsRoot
Line 162: def testHostSampleReportsNewInterface(self):
--
To view, visit https://gerrit.ovirt.org/38113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Madhu Pavan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
Nir Soffer has posted comments on this change. Change subject: virt: Allocate additonal space for cow internal data .. Patch Set 2: Verified+1 Verified on Fedora 21 and RHEL 7 together with https://gerrit.ovirt.org/38179 - Add thin 1G provisioned disk to vm - On the guest run: dd if=/dev/zero of=/dev/vdb bs=8M count=128 Works, extend disk to 1.12G - On the guest run: dd if=/dev/zero of=/dev/vdb bs=8M count=129 fails on the guest with "No space left on device" vm does not pause - Resize disk to 4G - On the guest run: dd if=/dev/zero of=/dev/vdb bs=8M count=512 Works, extend disk to 8.88G No pointless extension request seen. -- To view, visit https://gerrit.ovirt.org/38178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
Nir Soffer has posted comments on this change. Change subject: virt: Avoid pointless extension requests .. Patch Set 2: Verified+1 Verified on Fedora 21 and RHEL 7 together with https://gerrit.ovirt.org/38178 - Add thin 1G provisioned disk to vm - On the guest run: dd if=/dev/zero of=/dev/vdb bs=8M count=128 Works, extend disk to 1.12G - On the guest run: dd if=/dev/zero of=/dev/vdb bs=8M count=129 fails on the guest with "No space left on device" vm does not pause - Resize disk to 4G - On the guest run: dd if=/dev/zero of=/dev/vdb bs=8M count=512 Works, extend disk to 8.88G No pointless extension request seen. -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build gluster packages only for rhel 7 and above
Bala.FA has posted comments on this change. Change subject: Build gluster packages only for rhel 7 and above .. Patch Set 1: Thanks for pinging. As per discussion with blivet team, they agreed to backport to RHS based on RHEL-6 whereas it might not be available in EPEL or other place in upstream. Is it good idea to ship python-blivet separately in gluster/ovirt repository? -- To view, visit https://gerrit.ovirt.org/37646 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Cole Robinson Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
Francesco Romani has posted comments on this change. Change subject: virt: Avoid pointless extension requests .. Patch Set 2: Code-Review+1 seems fine to me. -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
Francesco Romani has posted comments on this change.
Change subject: virt: Allocate additonal space for cow internal data
..
Patch Set 2: Code-Review+1
(1 comment)
for some possibly irrational reasons 'getMaxVolumeSize' seems a bit misleading,
but I don't have any better suggestions.
There is also floats, which IIRC are usually avoided, but I don't mind.
Logic seems OK, and the above reasons are not good enough for me to delay my
+1, so here it comes.
https://gerrit.ovirt.org/#/c/38178/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 51: VOLWM_FREE_PCT = 100 - config.getint('irs',
'volume_utilization_percent')
Line 52: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during
replication
Line 53:
Line 54: # Estimate of the additional space needed for qcow format internal
data.
Line 55: VOLWM_COW_OVERHEAD = 1.1
does it make sense to avoid floats here? We usually try to avoid them. I
personally don't mind that much.
Line 56:
Line 57: def __init__(self, conf, log, **kwargs):
Line 58: if not kwargs.get('serial'):
Line 59: self.serial = kwargs.get('imageID'[-20:]) or ''
--
To view, visit https://gerrit.ovirt.org/38178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix LSM when using libvirt >= 1.2.8
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Fix LSM when using libvirt >= 1.2.8 .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/283/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4667/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/660/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/287/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/685/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/287/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/277/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6506/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/690/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eric Blake Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: moved metadatasize as an optional param for pv create in lvm...
Timothy Asir has uploaded a new change for review.
Change subject: moved metadatasize as an optional param for pv create in lvm
module
..
moved metadatasize as an optional param for pv create in lvm module
Specifying the metadata area using metadatasize is not a
mantatory its just an option to pvcreate command.
There are some situations like when a volume group contains
many physical volumes, having many redundant copies of
metadata (on every physical volume) is inefficient.
Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3
Signed-off-by: Timothy Asir
---
M vdsm/storage/lvm.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/38188/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index aa3c04b..2a85e39 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -692,7 +692,7 @@
return pv
-def _createpv(devices, metadataSize, options=tuple()):
+def _createpv(devices, metadataSize=0, options=tuple()):
"""
Size for pvcreate should be with units k|m|g
pvcreate on a dev that is already a PV but not in a VG returns rc = 0.
@@ -702,8 +702,9 @@
cmd = ["pvcreate"]
if options:
cmd.extend(options)
-cmd.extend(("--metadatasize", metadatasize, "--metadatacopies", "2",
-"--metadataignore", "y"))
+if metadataSize:
+cmd.extend(("--metadatasize", metadatasize, "--metadatacopies", "2",
+"--metadataignore", "y"))
cmd.extend(devices)
rc, out, err = _lvminfo.cmd(cmd, devices)
return rc, out, err
--
To view, visit https://gerrit.ovirt.org/38188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
Nir Soffer has posted comments on this change.
Change subject: virt: Allocate additonal space for cow internal data
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38178/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 51: VOLWM_FREE_PCT = 100 - config.getint('irs',
'volume_utilization_percent')
Line 52: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during
replication
Line 53:
Line 54: # Estimate of the additional space needed for qcow format internal
data.
Line 55: VOLWM_COW_OVERHEAD = 1.1
> does it make sense to avoid floats here? We usually try to avoid them. I pe
What wrong with floats? How do you suggest to avoid them for adding 10% to a
size?
This is the same logic as in vdsm/storage/image.py - look for "1.1" (I will
clean the mess later).
Line 56:
Line 57: def __init__(self, conf, log, **kwargs):
Line 58: if not kwargs.get('serial'):
Line 59: self.serial = kwargs.get('imageID'[-20:]) or ''
--
To view, visit https://gerrit.ovirt.org/38178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: moved metadatasize as an optional param for pv create in lvm...
oVirt Jenkins CI Server has posted comments on this change. Change subject: moved metadatasize as an optional param for pv create in lvm module .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16087/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15287/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16257/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1063/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: fix network service status checking
Dan Kenigsberg has posted comments on this change.
Change subject: init: fix network service status checking
..
Patch Set 1: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/38173/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-02-25 19:40:32 +0100
Line 6:
Line 7: init: fix network service status checking
Line 8:
Line 9: In init file, we check if network servuce is running by its status
servuce->service
Line 10: return code. Problem is, that this code is "always" 0, therefore we
never
Line 11: start network service when needed (for example, it's no autostarted
Line 12: on CentOS 6).
Line 13:
Line 7: init: fix network service status checking
Line 8:
Line 9: In init file, we check if network servuce is running by its status
Line 10: return code. Problem is, that this code is "always" 0, therefore we
never
Line 11: start network service when needed (for example, it's no autostarted
no -> not
Line 12: on CentOS 6).
Line 13:
Line 14: `service network status` returns lists of configured and active
devices,
Line 15: if the list of active devices (on the last row) does not contains all
Line 16: VDSM's ONBOOT=yes devices, it means, that network service did not start
Line 17: our devices and we should call service network start.
Line 18:
Line 19: Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67
Line 20: Bug-Url: https://bugzilla.redhat.com/1194553
there are strong doubts whether this solves the cited bug
https://gerrit.ovirt.org/#/c/38173/1/init/sysvinit/vdsmd.init.in
File init/sysvinit/vdsmd.init.in:
Line 106: for dev in $interfaces; do
Line 107: ifcfg="ifcfg-$dev"
Line 108: grep -q '# Generated by VDSM version' "$ifcfg" || continue
Line 109: grep -q 'ONBOOT=yes' "$ifcfg" || continue
Line 110: grep -q 'IPADDR=' "$ifcfg" || continue
I don't think you care to differentiate between static and dhcp interfaces here
- you want to start both kinds in this stage.
Line 111: static_devs="$static_devs $dev"
Line 112: done
Line 113: popd > /dev/null
Line 114:
Line 147: test_already_running && return 0
Line 148:
Line 149: shutdown_conflicting_srv "${CONFLICTING_SERVICES}" || return 1
Line 150: start_needed_srv "${NEEDED_SERVICES}" || return 1
Line 151: start_network || return 1
We should take network off the NEEDED_SERVICES list. We should also
start_network first, since it is known to be slow.
Line 152:
Line 153: # "service iscsid start" may not start becasue we configure
node.startup to
Line 154: # manual. See /etc/init.d/iscsid.
Line 155: service iscsid status >/dev/null 2>&1 || service iscsid
force-start \
--
To view, visit https://gerrit.ovirt.org/38173
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16088/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15288/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16258/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1064/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: models: move IpConfig's members to NetDevice
Ondřej Svoboda has posted comments on this change. Change subject: models: move IpConfig's members to NetDevice .. Patch Set 1: ifcfg configuration & EL6: passed all accessible network functional tests (and unit tests as well)! This does not confirm the correctness of individual patches below but is a good sign that no horrible breakage occured. Other configurators and systems to come, anyone is welcome ;-) -- To view, visit https://gerrit.ovirt.org/38103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ce76e1b9f32f1f35fe5927ed6b1215f911ff89 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16089/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15289/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16259/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1065/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build gluster packages only for rhel 7 and above
Yaniv Bronhaim has posted comments on this change. Change subject: Build gluster packages only for rhel 7 and above .. Patch Set 1: I don't think so, but can you raise that in mailing list? please cc Sandro who takes care of ovirt repositories. I don't see any python's specific libraries that we include in ovirt repo currently.. -- To view, visit https://gerrit.ovirt.org/37646 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Cole Robinson Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Allocate additonal space for cow internal data
..
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/38178/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 51: VOLWM_FREE_PCT = 100 - config.getint('irs',
'volume_utilization_percent')
Line 52: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during
replication
Line 53:
Line 54: # Estimate of the additional space needed for qcow format internal
data.
Line 55: VOLWM_COW_OVERHEAD = 1.1
> What wrong with floats? How do you suggest to avoid them for adding 10% to
Floats are non-exact by definition. They add a tinge of randomness to the code.
In many cases, (1100 * x / 1000) is safer than int(1.1*x). But in our heuristic
case, this issue is moot.
Line 56:
Line 57: def __init__(self, conf, log, **kwargs):
Line 58: if not kwargs.get('serial'):
Line 59: self.serial = kwargs.get('imageID'[-20:]) or ''
--
To view, visit https://gerrit.ovirt.org/38178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Allocate additonal space for cow internal data .. virt: Allocate additonal space for cow internal data In change I4098dfc07 (virt: Fix limit when calculating next volume size) we fixed drive size limit so drive volume is limited by drive capacity. This change introduced a regression where vm is paused when trying to fill up a drive, and there is no way to resume it, since qemu cannot complete the write. To allow a guest to use the entire drive capacity, we must allocate extra space for cow internal data. Since it is tricky to compute the exact value, we use the same estimate (1.1) used for converting raw volumes to cow and merging volumes. Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e Relates-To: https://bugzilla.redhat.com/1195768 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/38178 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M tests/vmStorageTests.py M vdsm/virt/vmdevices/storage.py 2 files changed, 24 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: Introduce EventFD support
Francesco Romani has posted comments on this change. Change subject: infra: Introduce EventFD support .. Patch Set 4: Code-Review-1 I'm with Federico. At least we need a comparison between these two changes, so we can make an informed decision. -- To view, visit https://gerrit.ovirt.org/37051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6035d4a8dc13ce11cf0425e4945bbf0c19bd92a7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Francesco Romani has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 8: Code-Review+1 Thanks for your changes and commitment to this fix. Looks good to me now. -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Francesco Romani has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 8: Code-Review-1 well, I spoke too early :) _read_password can be a module-private free function. Moreover, right now it lacks the 'self' argument (or @staticmethod, but no need for this) -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16090/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15290/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16260/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1066/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Dan Kenigsberg has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16091/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15291/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16261/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1067/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Allocate additonal space for cow internal data
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Allocate additonal space for cow internal data .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/687/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/284/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4668/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/661/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/288/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/288/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/278/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6507/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/691/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: Introduce EventFD support
Yaniv Bronhaim has posted comments on this change. Change subject: infra: Introduce EventFD support .. Patch Set 4: Federico, Francesco, I will try to explain why I think https://gerrit.ovirt.org/#/c/33687 can fit better than https://gerrit.ovirt.org/#/c/37051: 1. Its located under infra dir with docs - as sub utility for vdsm - we plan to have all new tools and functions under vdsm-infra rpm for arrangement and easier deployment, therefore we separate the directory as well as storage, virt, network and this patch keeps this concept. 2. class which exposes same api as described in evenfd manual page - comparing to isSet, wait, set which try to make it more event like and break the original use-cases. 3. no lock usage - the caller should protect context races - EventFD class introduces only one evetfd instance, when EventFile intoduces some kind of eventfd factory.. looks more intuitive from my prospective and easier to understand the usage what do you think? we already have bunch of patches based on it eventhough its not an excuse. but we need to decide.. -- To view, visit https://gerrit.ovirt.org/37051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6035d4a8dc13ce11cf0425e4945bbf0c19bd92a7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Change _AsyncoreEvent to use EventFD
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Change _AsyncoreEvent to use EventFD .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26f035e9a0587f5f407ad0efe9353c53b7674ffd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an autobackup param in changelv and set the default valu...
Timothy Asir has uploaded a new change for review.
Change subject: Add an autobackup param in changelv and set the default value
to false
..
Add an autobackup param in changelv and set the default value to false
Currently autobackup option is set to false is used forcely in
most of the lvm function in storage.lvm. This will not allow
any call to automatically back up metadata after a change.
This patch addes a parm to changelv and set the default value to
false. One can send true to change the option. However this change
should be done in manyplace of the storage.lvm module like
lvcreate, lvremove and so on.
Also currently most of the functions in lvm module accepts list
of params in a tuple format and have some mandatory options.
This will allow to break the lvm call if any thing called with
different option values in the tuple list which are now mandatory
to have some constant/'already defined' value.
ex:- changelv(vg, lvs, ('-autobackup', 'y'))
Change-Id: I8190878fe071fad46800e666795b94779d745abf
Signed-off-by: Timothy Asir
---
M vdsm/storage/lvm.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/38195/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 2a85e39..e9d2f10 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -783,7 +783,7 @@
"vgchange on vg(s) %s failed. %d %s %s" % (vgs, rc, out, err))
-def changelv(vg, lvs, attrs):
+def changelv(vg, lvs, attrs, autobackup=False):
"""
Change multiple attributes on multiple LVs.
@@ -802,7 +802,8 @@
# so we invalidate cache to reload these volumes on first occasion
lvnames = tuple("%s/%s" % (vg, lv) for lv in lvs)
cmd = ["lvchange"]
-cmd.extend(LVM_NOBACKUP)
+if not autobackup:
+cmd.extend(LVM_NOBACKUP)
if isinstance(attrs[0], str):
# ("--attribute", "value")
cmd.extend(attrs)
--
To view, visit https://gerrit.ovirt.org/38195
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8190878fe071fad46800e666795b94779d745abf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move AsyncoreEvent to betterAsyncore
Yaniv Bronhaim has posted comments on this change. Change subject: asyncore: Move AsyncoreEvent to betterAsyncore .. Patch Set 5: Code-Review+1 only moves the code to betterAsyncore. -- To view, visit https://gerrit.ovirt.org/37053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd3dc881091535328646ca1eeaac85f711885fc6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Adds autobackup param in changelv and set the default v...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Adds autobackup param in changelv and set the default value to false .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16092/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15292/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16262/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1068/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8190878fe071fad46800e666795b94779d745abf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
Martin Polednik has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 1: Code-Review-1 (3 comments) Minor questions, great effort. https://gerrit.ovirt.org/#/c/38077/1/vdsm/virt/vmdevices/hwtree.py File vdsm/virt/vmdevices/hwtree.py: Line 1: # Line 2: # Copyright 2014 Red Hat, Inc. Something I need to ask for my own patches: don't we want 2015 here? Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 40: (hwclass.RNG, core.Rng), Line 41: (hwclass.SMARTCARD, core.Smartcard), Line 42: (hwclass.TPM, core.Tpm)) Line 43: Line 44: I'm not sure about the name here, wouldn't something like init be nicer? hwtree.init actually tells me, that the tree is ready for use while hwtree.empty isn't something I'd understand. Line 45: def empty(): Line 46: return dict((dev, []) for dev, _ in _DEVICE_MAPPING) Line 47: Line 48: Line 48: Line 49: def build(dev_conf, vm_conf, log): Line 50: devices = empty() Line 51: Line 52: for devType, devClass in _DEVICE_MAPPING: Since this is new module, I'd go with dev_type and dev_class (possibly future patch). Line 53: for dev in dev_conf[devType]: Line 54: devices[devType].append(devClass(vm_conf, log, **dev)) Line 55: -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
Yaniv Bronhaim has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 5: Code-Review+1 it also adds add\remove_dispatcher which is used later on in the patches chain -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Francesco Romani has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 11: Code-Review-1
(2 comments)
Sorry, this is actually my fault.
https://gerrit.ovirt.org/#/c/38113/11/lib/vdsm/libvirtconnection.py
File lib/vdsm/libvirtconnection.py:
Line 76: __connections = {}
Line 77: __connectionLock = threading.Lock()
Line 78:
Line 79:
Line 80: def read_password():
no need to make this public, please see my other comments into samplingTests.py
Line 81: with open(constants.P_VDSM_LIBVIRT_PASSWD) as passwd_file:
Line 82: return passwd_file.readline().rstrip("\n")
Line 83:
Line 84:
https://gerrit.ovirt.org/#/c/38113/11/tests/samplingTests.py
File tests/samplingTests.py:
Line 145: s1 = sampling.InterfaceSample(lo)
Line 146: s1.operstate = 'x'
Line 147: self.assertEquals('operstate:x', s1.connlog_diff(s0))
Line 148:
Line 149: def read_password():
I'm deeply sorry that my probably confusing former comment mislead you. I meant
that _this_ method here can (and should) be a module-private free function, and
there is no need to change lib/vdsm/libvirtconnection.py
So, let's just move this tiny function out of InterfaceSampleTests class, and
have
def _read_password():
return 'password'
at module (being module samplingTests.py) level.
Line 150: return 'password'
Line 151:
Line 152: @MonkeyPatch(libvirtconnection, 'read_password', read_password)
Line 153: @ValidateRunningAsRoot
--
To view, visit https://gerrit.ovirt.org/38113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Madhu Pavan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Madhu Pavan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
Francesco Romani has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 1: (3 comments) thanks for the comments! https://gerrit.ovirt.org/#/c/38077/1/vdsm/virt/vmdevices/hwtree.py File vdsm/virt/vmdevices/hwtree.py: Line 1: # Line 2: # Copyright 2014 Red Hat, Inc. > Something I need to ask for my own patches: don't we want 2015 here? Yes, the problem is just I keep forgetting to follow my own advice. Will fix. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 40: (hwclass.RNG, core.Rng), Line 41: (hwclass.SMARTCARD, core.Smartcard), Line 42: (hwclass.TPM, core.Tpm)) Line 43: Line 44: > I'm not sure about the name here, wouldn't something like init be nicer? hw init is nicer and will change to use it. Thanks! Line 45: def empty(): Line 46: return dict((dev, []) for dev, _ in _DEVICE_MAPPING) Line 47: Line 48: Line 48: Line 49: def build(dev_conf, vm_conf, log): Line 50: devices = empty() Line 51: Line 52: for devType, devClass in _DEVICE_MAPPING: > Since this is new module, I'd go with dev_type and dev_class (possibly futu right, and no need to wait. Will fix (here and possibly everything else) Line 53: for dev in dev_conf[devType]: Line 54: devices[devType].append(devClass(vm_conf, log, **dev)) Line 55: -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: use monotonic timer instead of clock
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: use monotonic timer instead of clock .. Patch Set 5: Code-Review+1 I don't see any problem with that, only improvement. depending on elapsed_time guarantees that the time source is strictly linearly increasing unlike time.time which can be effected by system configurations (e.g. system time-of-day clock is changed). -- To view, visit https://gerrit.ovirt.org/37056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58fa9009c72422f28065282cdb3b5d20f010ec80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm:moved metadatasize as an optional param for pv create in...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm:moved metadatasize as an optional param for pv create in lvm module .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16093/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15293/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16263/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1069/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Francesco Romani has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 12: Code-Review+1 Yes, this is what I meant. Sorry again for the time waste. -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
Francesco Romani has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 2: fixes Martin's comment, take the chance to bootstrap tests. -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
Martin Polednik has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
Allon Mureinik has posted comments on this change. Change subject: virt: Avoid pointless extension requests .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix LSM when using libvirt >= 1.2.8
Hello Adam Litke, Dan Kenigsberg, Allon Mureinik, Eric Blake, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/38201
to review the following change.
Change subject: vm: Fix LSM when using libvirt >= 1.2.8
..
vm: Fix LSM when using libvirt >= 1.2.8
Libvirt 1.2.8 introduced a regression where disk type is converted from
"block" to "file" after blockRebase. This breaks our extend logic, leading
to unwanted extension of up to the disk virtual size, practically making
it preallocated. In 3.5, this used to extend the disk without limit
using all free space on the vg.
Libvirt 1.2.9 introduced a new VIR_DOMAIN_BLOCK_REBASE_COPY_DEV flag
for fixing this issue. This flag must be used when calling blockRebase
with block-based disk. This fix was backported to EL7.1 in
libvirt-1.2.8-16.el7_1.1 and libvirt-python-1.2.8-6.el7_1.1.
This patch uses VIR_DOMAIN_BLOCK_REBASE_COPY_DEV when available, fixing
this issue in EL7.1 and Fedora 21. Other platforms are not affected by
this issue because they are running older libvirt versions.
We assume that we are always working with local libvirt daemon, and
having the flag in the libvirt python bindings means that libvirt daemon
support the flag.
Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7
Bug-Url: https://bugzilla.redhat.com/1176673
Signed-off-by: Nir Soffer
Reviewed-on: https://gerrit.ovirt.org/38142
Reviewed-by: Eric Blake
Reviewed-by: Adam Litke
Reviewed-by: Francesco Romani
Reviewed-by: Allon Mureinik
Reviewed-by: Dan Kenigsberg
---
M vdsm/virt/vm.py
1 file changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/38201/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c892e66..16f8212 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4556,12 +4556,18 @@
try:
dstDiskCopy['path'] = self.cif.prepareVolumePath(dstDiskCopy)
+flags = (libvirt.VIR_DOMAIN_BLOCK_REBASE_COPY |
+ libvirt.VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT |
+ libvirt.VIR_DOMAIN_BLOCK_REBASE_SHALLOW)
+
+# Recent libvirt requires a flag for preserving the type of
+# block-based disk. See https://bugzilla.redhat.com/1176673.
+if srcDrive.blockDev:
+flags |= getattr(libvirt, "VIR_DOMAIN_BLOCK_REBASE_COPY_DEV",
+ 0)
try:
-self._dom.blockRebase(srcDrive.name, dstDiskCopy['path'], 0, (
-libvirt.VIR_DOMAIN_BLOCK_REBASE_COPY |
-libvirt.VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT |
-libvirt.VIR_DOMAIN_BLOCK_REBASE_SHALLOW
-))
+self._dom.blockRebase(srcDrive.name, dstDiskCopy['path'], 0,
+ flags)
except Exception:
self.log.error("Unable to start the replication for %s to %s",
srcDrive.name, dstDiskCopy, exc_info=True)
--
To view, visit https://gerrit.ovirt.org/38201
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eric Blake
Gerrit-Reviewer: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix LSM when using libvirt >= 1.2.8
Allon Mureinik has posted comments on this change. Change subject: vm: Fix LSM when using libvirt >= 1.2.8 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eric Blake Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix LSM when using libvirt >= 1.2.8
Nir Soffer has posted comments on this change. Change subject: vm: Fix LSM when using libvirt >= 1.2.8 .. Patch Set 2: Verified+1 Verified on: Fedora 21: - lsm with block cow disk (issue fixed) RHEL 6.6/7.0: - lsm with block cow disk (sanity, no regression) RHEL 7.1: - lsm with block disks (issue fixed) Test was done by applying this patch manually on the installed vdsm and intalling libvirt scratch build. -- To view, visit https://gerrit.ovirt.org/38201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eric Blake Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Nir Soffer has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix LSM when using libvirt >= 1.2.8
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: Fix LSM when using libvirt >= 1.2.8 .. vm: Fix LSM when using libvirt >= 1.2.8 Libvirt 1.2.8 introduced a regression where disk type is converted from "block" to "file" after blockRebase. This breaks our extend logic, leading to unwanted extension of up to the disk virtual size, practically making it preallocated. In 3.5, this used to extend the disk without limit using all free space on the vg. Libvirt 1.2.9 introduced a new VIR_DOMAIN_BLOCK_REBASE_COPY_DEV flag for fixing this issue. This flag must be used when calling blockRebase with block-based disk. This fix was backported to EL7.1 in libvirt-1.2.8-16.el7_1.1 and libvirt-python-1.2.8-6.el7_1.1. This patch uses VIR_DOMAIN_BLOCK_REBASE_COPY_DEV when available, fixing this issue in EL7.1 and Fedora 21. Other platforms are not affected by this issue because they are running older libvirt versions. We assume that we are always working with local libvirt daemon, and having the flag in the libvirt python bindings means that libvirt daemon support the flag. Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Bug-Url: https://bugzilla.redhat.com/1196049 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/38142 Reviewed-by: Eric Blake Reviewed-by: Adam Litke Reviewed-by: Francesco Romani Reviewed-by: Allon Mureinik Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/38201 Reviewed-by: Yaniv Bronhaim --- M vdsm/virt/vm.py 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eric Blake Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix LSM when using libvirt >= 1.2.8
Yaniv Bronhaim has posted comments on this change. Change subject: vm: Fix LSM when using libvirt >= 1.2.8 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eric Blake Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: InterfaceSampleTests are failing with IOError .. tests: InterfaceSampleTests are failing with IOError Both testHostSampleHandlesDisappearingVlanInterfaces and testHostSampleReportsNewInterface are failing due to IOError. Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195594 Signed-off-by: Madhu Pavan Kothapally Reviewed-on: https://gerrit.ovirt.org/38113 Reviewed-by: Francesco Romani Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg --- M tests/samplingTests.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Madhu Pavan: Verified -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
Dan Kenigsberg has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix LSM when using libvirt >= 1.2.8
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Fix LSM when using libvirt >= 1.2.8 .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/164/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/167/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/166/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eric Blake Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/688/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/285/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4669/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/662/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/289/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/687/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/289/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/279/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6508/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/692/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Adds autobackup param in changelv and set the default v...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Adds autobackup param in changelv and set the default value to false .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16094/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15294/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16264/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1070/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8190878fe071fad46800e666795b94779d745abf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: use monotonic timer instead of clock
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37056/5/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 473: def readable(self, dispatcher):
Line 474: return True
Line 475:
Line 476: def _milis(self):
Line 477: return int(round(elapsed_time() * 1000))
os.times()[4] returns in miliseconds already. please remove the * 1000
Line 478:
Line 479:
Line 480: class AsyncClient(object):
Line 481: log = logging.getLogger("yajsonrpc.protocols.stomp.AsyncClient")
--
To view, visit https://gerrit.ovirt.org/37056
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58fa9009c72422f28065282cdb3b5d20f010ec80
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: fix creation and deletion of multiple udev rules
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
hostdev: fix creation and deletion of multiple udev rules
When attaching multiple devices from the same group, each of the
devices needs to be detached and then later reattached to the host. To
this routine is hooked udev rule creation to give qemu access to
/dev/vfio endpoint. This patch corrects behaviour of udev if the file
already exists or does not exist due to creation or deletion of VM.
Change-Id: I83fffb2f6e42cc1746f30ca2b63c5d594de014e5
Signed-off-by: Martin Polednik
---
M vdsm/supervdsmServer
1 file changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/38208/1
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 59b29a9..92d2aa6 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -313,9 +313,14 @@
'/dev/vfio/{}"').format(iommu_group, EXT_CHOWN,
QEMU_PROCESS_USER, QEMU_PROCESS_GROUP,
iommu_group)
-with open(ruleFile, "w") as rf:
-self.log.debug("Creating rule %s: %r", ruleFile, rule)
-rf.write(rule)
+
+if not os.path.isfile(ruleFile):
+# If the file exists, different device from the same group has
+# already been detached and we therefore can skip overwriting the
+# file.
+with open(ruleFile, "w") as rf:
+self.log.debug("Creating rule %s: %r", ruleFile, rule)
+rf.write(rule)
@logDecorator
def rmAppropriateIommuGroup(self, iommu_group):
@@ -326,7 +331,13 @@
rule = os.path.join(_UDEV_RULE_FILE_DIR, _UDEV_RULE_FILE_PREFIX +
"iommu_group_" + iommu_group + _UDEV_RULE_FILE_EXT)
self.log.debug("Removing rule %s", rule)
-os.remove(rule)
+try:
+os.remove(rule)
+except OSError:
+# OSError here means that the rule file does not exist - this is
+# expected when multiple devices in one iommu group were passed
+# through.
+pass
@logDecorator
def ksmTune(self, tuningParams):
--
To view, visit https://gerrit.ovirt.org/38208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83fffb2f6e42cc1746f30ca2b63c5d594de014e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Add Drive.chunked property
Nir Soffer has abandoned this change. Change subject: virt: Add Drive.chunked property .. Abandoned wontfix -- To view, visit https://gerrit.ovirt.org/38086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
Martin Polednik has posted comments on this change.
Change subject: hostdev: display directed-passthrough status in caps
..
Patch Set 1: -Verified
(1 comment)
https://gerrit.ovirt.org/#/c/37701/1/vdsm/caps.py
File vdsm/caps.py:
Line 596: return selinux
Line 597:
Line 598:
Line 599: def _getDirectedPassthrough():
Line 600: return bool(len(os.listdir('/sys/class/iommu')))
> silly comment:
As far as I understand only dmarX should be present. This is still not
*perfect* check, because there are various hardware configurations that require
more setup, but this gets us close.
Line 601:
Line 602:
Line 603: def get():
Line 604: targetArch = getTargetArch()
--
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Alona Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Betak
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Check if a drive is chuhked before extending
Nir Soffer has abandoned this change. Change subject: virt: Check if a drive is chuhked before extending .. Abandoned wontfix -- To view, visit https://gerrit.ovirt.org/38087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Fix limit when calculating next volume size
Nir Soffer has abandoned this change. Change subject: virt: Fix limit when calculating next volume size .. Abandoned wontfix -- To view, visit https://gerrit.ovirt.org/38088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce support for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: introduce support for periodic operations .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/495/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2551/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16060/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1061/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15260/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16230/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1036/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1044/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: dynamic tick support
Yaniv Bronhaim has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16095/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15295/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16265/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1071/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
Martin Polednik has posted comments on this change. Change subject: hostdev: display directed-passthrough status in caps .. Patch Set 2: Verified+1 Manually verified on both intel VT-d enabled and disabled host. -- To view, visit https://gerrit.ovirt.org/37701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add check for hostdev passthrough to caps
Martin Polednik has posted comments on this change. Change subject: hostdev: add check for hostdev passthrough to caps .. Patch Set 8: Verified+1 Manually verified via cmdline and getCaps. -- To view, visit https://gerrit.ovirt.org/30471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f93679740e87b2f5a88351261bc58852990d4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: fix creation and deletion of multiple udev rules
Francesco Romani has posted comments on this change.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
Patch Set 1:
(2 comments)
a couple of possible improvements inside
https://gerrit.ovirt.org/#/c/38208/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 313: '/dev/vfio/{}"').format(iommu_group, EXT_CHOWN,
Line 314: QEMU_PROCESS_USER,
QEMU_PROCESS_GROUP,
Line 315: iommu_group)
Line 316:
Line 317: if not os.path.isfile(ruleFile):
this usage is most often racy. Is that the case? Maybe not since only supervdsm
is supposed to change these files.
If so, let's mention this assumption as comment so we can remember in the future
Line 318: # If the file exists, different device from the same
group has
Line 319: # already been detached and we therefore can skip
overwriting the
Line 320: # file.
Line 321: with open(ruleFile, "w") as rf:
Line 332: "iommu_group_" + iommu_group +
_UDEV_RULE_FILE_EXT)
Line 333: self.log.debug("Removing rule %s", rule)
Line 334: try:
Line 335: os.remove(rule)
Line 336: except OSError:
let's try to narrow down this OSError checking the value of errno
Line 337: # OSError here means that the rule file does not exist -
this is
Line 338: # expected when multiple devices in one iommu group were
passed
Line 339: # through.
Line 340: pass
--
To view, visit https://gerrit.ovirt.org/38208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fffb2f6e42cc1746f30ca2b63c5d594de014e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Martin Betak
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
Francesco Romani has posted comments on this change. Change subject: hostdev: display directed-passthrough status in caps .. Patch Set 2: Code-Review+1 your explanation makes sense to me. Let's get closer to the optimal solution. -- To view, visit https://gerrit.ovirt.org/37701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 21: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/504/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/496/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2556/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16065/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1062/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15265/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16235/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1041/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1045/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16096/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15296/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16266/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1072/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16097/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15297/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16267/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1073/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: introduce the new createVolume command
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: introduce the new createVolume command .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/497/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16079/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1063/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15279/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16249/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1055/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1046/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3ea624f81a04a830cdcbcfe2f777cdd7bd26c08 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: fix the Host.getVMList return value
Francesco Romani has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified-1 Engine has demarshalling issues with this patch. See previous two comments (from me and Piotr) -- To view, visit https://gerrit.ovirt.org/38172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: fix network service status checking
oVirt Jenkins CI Server has posted comments on this change. Change subject: init: fix network service status checking .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16098/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15298/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16268/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1074/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
Francesco Romani has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 2: patch passed basic verification, done by booting a VM. Changes affects the codepath shared by all the creation flows, so this is already a good proof that patch is safe. However I'd like to try out migrations, just in case. -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add round() helper
Nir Soffer has uploaded a new change for review. Change subject: utils: Add round() helper .. utils: Add round() helper We have the same rounding code all over, which does not make the code more fun to work with. This patch adds utils.round() utility to eliminate this duplication. Change-Id: Ie46e48d147d1fc222a6e0404df7ab757226f694b Signed-off-by: Nir Soffer --- M lib/vdsm/utils.py M tests/utilsTests.py 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/38210/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index 8c1a33c..1aa19f4 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -1244,3 +1244,11 @@ suffix = ''.join(random.choice(string.ascii_letters + string.digits) for _ in range(suffix_len)) return prefix + suffix + + +def round(n, size): +""" +Round number n to the next multiple of size +""" +count = int(n + size - 1) / size +return count * size diff --git a/tests/utilsTests.py b/tests/utilsTests.py index 4914707..13245d8 100644 --- a/tests/utilsTests.py +++ b/tests/utilsTests.py @@ -731,3 +731,18 @@ @utils.memoized def memoized_function(test, *args): return test.get(args) + + +@expandPermutations +class RoundTests(TestCaseBase): + +@permutations([ +# n, size, result +(0, 1024, 0), +(1, 1024, 1024), +(3.14, 1024, 1024), +(1024, 1024, 1024), +(1025, 1024, 2048), +]) +def test_round(self, n, size, result): +self.assertEqual(utils.round(n, size), result) -- To view, visit https://gerrit.ovirt.org/38210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie46e48d147d1fc222a6e0404df7ab757226f694b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add round() helper
Nir Soffer has posted comments on this change. Change subject: utils: Add round() helper .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie46e48d147d1fc222a6e0404df7ab757226f694b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add check for hostdev passthrough to caps
Francesco Romani has posted comments on this change. Change subject: hostdev: add check for hostdev passthrough to caps .. Patch Set 8: Code-Review+1 addressed comments both from Dan and me, and looks good to me (though for a bit about other possible /proc/cmdline misdetection, and can't find something _realistic_, so let's go ahead) -- To view, visit https://gerrit.ovirt.org/30471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f93679740e87b2f5a88351261bc58852990d4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: fix network service status checking
oVirt Jenkins CI Server has posted comments on this change. Change subject: init: fix network service status checking .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16099/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15299/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16269/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1075/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: restore_nets: during rollback, ignore removal of a missing bond
Dan Kenigsberg has uploaded a new change for review.
Change subject: restore_nets: during rollback, ignore removal of a missing bond
..
restore_nets: during rollback, ignore removal of a missing bond
If a bond is removed outside vdsm, attempting to restore networks to the
last known-good set of configuration currently fails.
With this patch, if vdsm is asked to remove an already-missing bond
device during an attempt to restore networking, this descripency is
ignored, and restore_nets would go on attempting to restore further
networks, hopefully restoring connectivity to the host.
The accompanying test verifies that restore_nets survive after such
removal. It also verifies that adding a network on top of an
alraedy-existing bond ends with the bonding device being consumed into
the running (and later, persistent) config.
Change-Id: I7b863ffd829026f9ea3030ac77e57cf6521fe6ba
Signed-off-by: Dan Kenigsberg
---
M tests/functional/networkTests.py
M vdsm/network/api.py
2 files changed, 50 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/38211/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 116d91c..61ec152 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -30,7 +30,8 @@
from vdsm.ipwrapper import (routeExists, ruleExists, addrFlush, LinkType,
getLinks, routeShowTable)
from vdsm.netinfo import (bridges, operstate, getRouteDeviceTo,
- _get_dhclient_ifaces, BONDING_SLAVES)
+ _get_dhclient_ifaces, BONDING_SLAVES,
+ BONDING_MASTERS)
from vdsm.netlink import monitor
from vdsm import sysctl
from vdsm.utils import CommandPath, RollbackContext, execCmd, pgrep, running
@@ -2284,3 +2285,37 @@
self.assertEqual(status, SUCCESS, msg)
self.assertNetworkDoesntExist(NETWORK_NAME)
self.assertBondDoesntExist(BONDING_NAME, nics)
+
+@cleanupNet
+@ValidateRunningAsRoot
+def test_setupNetworks_on_external_bond(self):
+with dummyIf(1) as (nic, ):
+with open(BONDING_MASTERS, 'w') as bonds:
+bonds.write('+%s\n' % BONDING_NAME)
+try:
+with open(BONDING_SLAVES % BONDING_NAME, 'w') as f:
+f.write('+%s\n' % nic)
+status, msg = self.vdsm_net.setupNetworks(
+{NETWORK_NAME:
+{'bonding': BONDING_NAME, 'bridged': False}},
+{BONDING_NAME: {'nics': [nic]}}, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertNetworkExists(NETWORK_NAME)
+self.assertBondExists(BONDING_NAME, [nic])
+finally:
+with open(BONDING_MASTERS, 'w') as bonds:
+bonds.write('-%s\n' % BONDING_NAME)
+
+self.vdsm_net.save_config()
+self.vdsm_net.restoreNetConfig()
+
+self.assertNetworkExists(NETWORK_NAME)
+self.assertBondExists(BONDING_NAME, [nic])
+
+status, msg = self.vdsm_net.setupNetworks(
+{NETWORK_NAME: {'remove': True}},
+{BONDING_NAME: {'remove': True}}, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertNetworkDoesntExist(NETWORK_NAME)
+self.assertBondDoesntExist(BONDING_NAME, [nic])
+self.vdsm_net.save_config()
diff --git a/vdsm/network/api.py b/vdsm/network/api.py
index 2706cfe..ad0ee8c 100755
--- a/vdsm/network/api.py
+++ b/vdsm/network/api.py
@@ -554,7 +554,6 @@
"than custom properties). specified attributes: %s" % (
networkAttrs,))
-currentBondings = netinfo.bondings()
currentNicsSet = set(netinfo.nics())
for bonding, bondingAttrs in bondings.iteritems():
Bond.validateName(bonding)
@@ -562,9 +561,6 @@
Bond.validateOptions(bonding, bondingAttrs['options'])
if bondingAttrs.get('remove', False):
-if bonding not in currentBondings:
-raise ConfigNetworkError(ne.ERR_BAD_BONDING, "Cannot remove "
- "bonding %s: Doesn't exist" % bonding)
continue
nics = bondingAttrs.get('nics', None)
@@ -576,7 +572,7 @@
"Unknown nics in: %r" % list(nics))
-def _handleBondings(bondings, configurator):
+def _handleBondings(bondings, configurator, in_rollback):
""" Add/Edit/Remove bond interface """
logger = logging.getLogger("_handleBondings")
@@ -586,6 +582,16 @@
addition = []
for name, attrs in bondings.items():
if 'remove' in attrs:
+if not name in _netinfo.bondings:
+if in_rollback:
+logger.error(
+'Cannot re
Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16100/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15300/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16270/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1076/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7edc9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Madhu Pavan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/506/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/498/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2566/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16101/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1064/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15301/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16271/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1077/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1047/ : FAILURE -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/507/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/499/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2567/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16102/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1065/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15302/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16272/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1078/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1048/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: fix creation and deletion of multiple udev rules
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: fix creation and deletion of multiple udev rules .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16105/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15305/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16275/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1081/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83fffb2f6e42cc1746f30ca2b63c5d594de014e5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: restore_nets: during rollback, ignore removal of a missing bond
Dan Kenigsberg has posted comments on this change. Change subject: restore_nets: during rollback, ignore removal of a missing bond .. Patch Set 1: Verified+1 Passes all unit and functional tests -- To view, visit https://gerrit.ovirt.org/38211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b863ffd829026f9ea3030ac77e57cf6521fe6ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/508/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/500/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2568/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16103/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1066/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15303/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16273/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1079/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1049/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 4: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/509/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/501/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2569/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16104/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1067/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15304/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16274/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1080/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1050/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: display directed-passthrough status in caps .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16106/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15306/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16276/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1082/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add check for hostdev passthrough to caps
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add check for hostdev passthrough to caps .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16107/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15307/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16277/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1083/ : FAILURE -- To view, visit https://gerrit.ovirt.org/30471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f93679740e87b2f5a88351261bc58852990d4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Clarify error handling
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Clarify error handling .. virt: Clarify error handling In diskSizeExtend, error handling was correct but less clear then it should be. We have try except block, returning one value on success, and other value on errors. Change-Id: I1d8f10e3ac46f831ddaea8a30ba289370c697b0e Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/37944 Reviewed-by: Francesco Romani Reviewed-by: Adam Litke --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/37944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d8f10e3ac46f831ddaea8a30ba289370c697b0e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: create gc and delete
Nir Soffer has posted comments on this change.
Change subject: create gc and delete
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/38098/2/vdsm/storage/sdm/volumestore.py
File vdsm/storage/sdm/volumestore.py:
Line 50: isVolumeGarbage
isGarbageVolume() ?
Line 49:
Line 50: def isVolumeGarbage(volUUID):
Line 51: if volUUID.endswith(CREATE_POSTFIX) or
volUUID.endswith(REMOVE_POSTFIX):
Line 52: return True
Line 53: return False
Can be simplified to:
return volUUID.endswith((CREATE_POSTFIX, REMOVE_POSTFIX))
Line 54:
Line 55:
Line 56: def volumeNameToOriginalUUID(name):
Line 57: if not isVolumeGarbage(name):
Line 54:
Line 55:
Line 56: def volumeNameToOriginalUUID(name):
Line 57: if not isVolumeGarbage(name):
Line 58: raise ValueError("Volume name '%s' does not have a valid
suffix", name)
Lets chose suffix or postfix?
Line 59: return name.rsplit('-', 1)[0]
Line 60:
Line 61:
Line 62: class VolumeStore(object):
--
To view, visit https://gerrit.ovirt.org/38098
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f846171bcc9920f05d38dc37d2f30a0443e209
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
Federico Simoncelli has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
