Change in vdsm[master]: stomp: client side subscription
Piotr Kliczewski has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 16: (2 comments) https://gerrit.ovirt.org/#/c/36368/16/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 74: def pop_message(self): Line 75: return self._outbox.popleft() Line 76: Line 77: def queue_frame(self, frame): Line 78: self._outbox.append(frame) this code is duplicated - i'd write stompOutbox class I am not sure what do you suggest. Do you want to have deque wrapper? Line 79: Line 80: def _cmd_connect(self, dispatcher, frame): Line 81: self.log.info(Processing CONNECT request) Line 82: version = frame.headers.get(accept-version, None) Line 361: response_queue Line 362: ): Line 363: sub_id = None Line 364: if request_queue == _FAKE_SUB_ID: Line 365: sub_id = _FAKE_SUB_ID sub_id = _FAKE_SUB_ID if request_queue == _FAKE_SUB_ID else None Done Line 366: Line 367: return JsonRpcClient( Line 368: ClientRpcTransportAdapter( Line 369: stomp_client.subscribe(response_queue, sub_id=sub_id), -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
Piotr Kliczewski has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: disconnecting a port from a bridge should not consider el6 a...
oVirt Jenkins CI Server has posted comments on this change. Change subject: disconnecting a port from a bridge should not consider el6 anymore .. Patch Set 4: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/952/ -- To view, visit https://gerrit.ovirt.org/39544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e126b4986d81d8b3bb831f7d6145cde83645d2a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 5: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18205/ -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 5: Build Started (2/2) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1435/ -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: use subscription when creating a client
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpcvdscli: use subscription when creating a client .. Patch Set 1: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18209/ -- To view, visit https://gerrit.ovirt.org/40307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e1084a4016509aaf0e9e749ff05e33a331f580 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 9: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18208/ -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18208/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1438/ : 0 -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: use subscription when creating a client
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpcvdscli: use subscription when creating a client .. Patch Set 1: Build Started (2/2) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1439/ -- To view, visit https://gerrit.ovirt.org/40307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e1084a4016509aaf0e9e749ff05e33a331f580 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Build Started (6/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/89/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 6: Build Started (6/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/90/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/859/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1404/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/89/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1443/ : 0 -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/851/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/860/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1405/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/90/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1444/ : 0 -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove libvirt configure code from debian prerm script
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove libvirt configure code from debian prerm script .. Patch Set 4: Build Started (6/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/550/ -- To view, visit https://gerrit.ovirt.org/39767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c428fd9d2da431f59e5d54a09ef5a9f7c323555 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (2/6) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1447/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: -Verified Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18217/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: To avoid vdsm upgrade bugs all modules configure should run
oVirt Jenkins CI Server has posted comments on this change. Change subject: To avoid vdsm upgrade bugs all modules configure should run .. Patch Set 1: Build Started (4/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/861/ -- To view, visit https://gerrit.ovirt.org/39492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
Yaniv Bronhaim has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: To avoid vdsm upgrade bugs all modules configure should run
oVirt Jenkins CI Server has posted comments on this change. Change subject: To avoid vdsm upgrade bugs all modules configure should run .. Patch Set 1: Build Started (6/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/852/ -- To view, visit https://gerrit.ovirt.org/39492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
Francesco Romani has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 9: I still don't like jsonrpcvdscli vs vdscli, I'd rather like to have consistent interface, possibly completely transparent to client code. Not just for migration's sake, but for client's sake in general (migration is not special in this regard). However, I can live with curreny layout as well. -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: use subscription when creating a client
Francesco Romani has posted comments on this change. Change subject: jsonrpcvdscli: use subscription when creating a client .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40307/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-04-27 11:54:28 +0300 Line 4: Commit: Yeela Kaplan ykap...@redhat.com Line 5: CommitDate: 2015-04-27 11:54:28 +0300 Line 6: Line 7: jsonrpcvdscli: use subscription when creating a client OK, but why? What's the benefit of this patch, and/or what's the problem with current code? Line 8: Line 9: Change-Id: I33e1084a4016509aaf0e9e749ff05e33a331f580 -- To view, visit https://gerrit.ovirt.org/40307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e1084a4016509aaf0e9e749ff05e33a331f580 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 2: Build Started (4/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/954/ -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 2: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/538/ -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: ovs .. Patch Set 2: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18221/ -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/92/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: avoid needless temporary list
Francesco Romani has posted comments on this change. Change subject: vm.py: avoid needless temporary list .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2147bf3981882e9641b185fad921b352c1aeda4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 15: (2 comments) https://gerrit.ovirt.org/#/c/38451/15/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 133: ) Line 134: connection.send_raw(res) Line 135: Line 136: def _cmd_unsubscribe(self, dispatcher, frame): Line 137: self.log.debug(Unsubscribe command received) info Done Line 138: sub_id = frame.headers.get(id, None) Line 139: Line 140: if not sub_id: Line 141: self._send_error(Missing id header, Line 336: self._stompConn.connect() Line 337: Line 338: def handle_message(self, sub, frame): Line 339: if self._messageHandler is not None: Line 340: self._messageHandler((self, self, frame.body)) which message handler gets twice the same object? much easier to read class Done Line 341: Line 342: def setMessageHandler(self, msgHandler): Line 343: self._messageHandler = msgHandler Line 344: self.check_read() -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: To avoid vdsm upgrade bugs all modules configure should run
Piotr Kliczewski has posted comments on this change. Change subject: To avoid vdsm upgrade bugs all modules configure should run .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39492/1//COMMIT_MSG Commit Message: Line 10: call should be those calls or this call Line 13: to find another solution for specific modules configuration change Line 14: between 3.5 to 3.6 but with this patch from 3.6 and above we won't need Line 15: to worry about other modules - all configurators will run on upgrade. Line 16: Line 17: If between 3.5 to 3.6 multipath.conf must update we need to do it in must update what we need to .. Line 18: vdsmd_init_script as deprecated code. Line 19: Line 20: This patch also removes the calls to '/usr/lib/systemd/systemd-vdsmd' Line 21: '/etc/init.d/vdsmd' which related to 3.3 version and does not need to be -- To view, visit https://gerrit.ovirt.org/39492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Run glusterfs in its own cgroup .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18202/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1432/ : 0 -- To view, visit https://gerrit.ovirt.org/40240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: clientSeen should have it's default timeout
Dan Kenigsberg has posted comments on this change.
Change subject: network: clientSeen should have it's default timeout
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/40087/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-04-21 12:27:50 +0300
Line 4: Commit: Ido Barkan ibar...@redhat.com
Line 5: CommitDate: 2015-04-21 16:03:10 +0300
Line 6:
Line 7: network: clientSeen should have it's default timeout
it's - its
Line 8:
Line 9: Change-Id: Ibe5e28247bebd91878c2a2c687b2eeb9bfec6586
https://gerrit.ovirt.org/#/c/40087/1/vdsm/network/api.py
File vdsm/network/api.py:
Line 513:
Line 514:
Line 515: def clientSeen(timeout=CONNECTIVITY_TIMEOUT_DEFAULT):
Line 516: start = time.time()
Line 517: while timeout = 0:
this explodes if timeout is None. Hence the frightening catching-all except of
line 729 does not remove the exception, only hides its origin.
Better have here
if timeout is None:
timeout = CONNECTIVITY_TIMEOUT_DEFAULT
or move this logic into your new _get_connectivity_timeout
Line 518: try:
Line 519: if os.stat(constants.P_VDSM_CLIENT_LOG).st_mtime start:
Line 520: return True
Line 521: except OSError as e:
Line 724:
Line 725: def _get_connectivity_timeout(options):
Line 726: try:
Line 727: return int(options.get('connectivityTimeout'))
Line 728: except:
We must never swallow exception without a trace. Particularly in this case,
when we got garbage from Engine.
I prefer fully-blown traceback in such conditions.
Line 729: return None
Line 730:
Line 731:
Line 732: def _check_connectivity(connectivity_check_networks, networks,
bondings,
--
To view, visit https://gerrit.ovirt.org/40087
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5e28247bebd91878c2a2c687b2eeb9bfec6586
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: disconnecting a port from a bridge should not consider el6 a...
Dan Kenigsberg has posted comments on this change. Change subject: disconnecting a port from a bridge should not consider el6 anymore .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e126b4986d81d8b3bb831f7d6145cde83645d2a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: disconnecting a port from a bridge should not consider el6 a...
oVirt Jenkins CI Server has posted comments on this change. Change subject: disconnecting a port from a bridge should not consider el6 anymore .. Patch Set 4: Build Started (1/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/540/ -- To view, visit https://gerrit.ovirt.org/39544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e126b4986d81d8b3bb831f7d6145cde83645d2a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: disconnecting a port from a bridge should not consider el6 a...
oVirt Jenkins CI Server has posted comments on this change. Change subject: disconnecting a port from a bridge should not consider el6 anymore .. Patch Set 4: Build Started (6/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/549/ -- To view, visit https://gerrit.ovirt.org/39544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e126b4986d81d8b3bb831f7d6145cde83645d2a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: disconnecting a port from a bridge should not consider el6 a...
oVirt Jenkins CI Server has posted comments on this change. Change subject: disconnecting a port from a bridge should not consider el6 anymore .. Patch Set 4: Build Started (7/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/94/ -- To view, visit https://gerrit.ovirt.org/39544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e126b4986d81d8b3bb831f7d6145cde83645d2a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18205/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1435/ : 0 -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (4/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/87/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/848/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/857/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1402/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/87/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18210/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1440/ : 0 -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
Piotr Kliczewski has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Run glusterfs in its own cgroup .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18211/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1441/ : 0 -- To view, visit https://gerrit.ovirt.org/40240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
mooli tayer has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
Oved Ourfali has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/39823/5//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-04-27 05:47:13 -0400 Line 6: Line 7: Move passwd (set saslpassword for libvirt) to vdsm-tool Line 8: Line 9: In this patch we stop calling saslpassword command directly, don't know if whitespaces in commit message are allowed... Line 10: instead we move passwd logic to vdsm-tool configure. Line 11: with that patch after rpm installation user will need to call configure Line 12: to set the sasl libvirt password - therefore we remove those parts from spec, Line 13: and update the manual accordingly. -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 6: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18214/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 6: Build Started (2/6) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1444/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 6: Build Started (4/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/860/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove libvirt configure code from debian prerm script
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove libvirt configure code from debian prerm script .. Patch Set 4: Build Started (4/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/537/ -- To view, visit https://gerrit.ovirt.org/39767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c428fd9d2da431f59e5d54a09ef5a9f7c323555 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove libvirt configure code from debian prerm script
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove libvirt configure code from debian prerm script .. Patch Set 4: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/953/ -- To view, visit https://gerrit.ovirt.org/39767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c428fd9d2da431f59e5d54a09ef5a9f7c323555 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: ovs .. Patch Set 1: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18216/ -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: ovs .. Patch Set 1: Build Started (2/2) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1446/ -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: ovs .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18216/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1446/ : 0 -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: clientSeen should have its default timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: clientSeen should have its default timeout .. Patch Set 2: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2888/ -- To view, visit https://gerrit.ovirt.org/40087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5e28247bebd91878c2a2c687b2eeb9bfec6586 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: To avoid vdsm upgrade bugs all modules configure should run
oVirt Jenkins CI Server has posted comments on this change. Change subject: To avoid vdsm upgrade bugs all modules configure should run .. Patch Set 1: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1406/ -- To view, visit https://gerrit.ovirt.org/39492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
Dan Kenigsberg has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. tool: Remove leftover libvirtd.log rotating logic. Vdsm libvirt logging definitions were recently dropped in favor of libvirt defaults[1]. It is now up to libvirt to manage logging, rotating included. libvirt.logrotate is a file installed by libvirt's rpm and then modified by vdsm-tool. we need to stop modifying it, and drop modifications when libvirtd.conf updates to include [1] - When we have a version bump. [1] http://gerrit.ovirt.org/#/q/I251c2534d3284aa95bffa56143c449d5de887008,n,z Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149757 Signed-off-by: Mooli Tayer mta...@redhat.com Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: https://gerrit.ovirt.org/33925 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm.install M lib/vdsm/tool/Makefile.am M lib/vdsm/tool/configurators/libvirt.py D lib/vdsm/tool/libvirtd.logrotate M tests/Makefile.am M tests/toolTests.py D tests/toolTests_libvirt_logrotate.conf M vdsm.spec.in M vdsm/Makefile.am D vdsm/vdsm-libvirt-logrotate 10 files changed, 0 insertions(+), 102 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
automat...@ovirt.org has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: * Update tracker::#1149757::OK * Check TR::#1149757::ERROR, 3.6.0 should not match .* -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 2: Build Started (3/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/919/ -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: fix call to super ctor
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: fix call to super ctor .. Patch Set 4: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18207/ -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add systemd_run command modifier
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/40239/1/configure.ac
File configure.ac:
Line 327: AC_PATH_PROG([SUDO_PATH], [sudo], [/usr/bin/sudo])
Line 328: AC_PATH_PROG([SU_PATH], [su], [/bin/su])
Line 329: AC_PATH_PROG([SYSCTL_PATH], [sysctl], [/sbin/sysctl])
Line 330: AC_PATH_PROG([SYSTEMCTL_PATH], [systemctl], [/bin/systemctl])
Line 331: AC_PATH_PROG([SYSTEMD_RUN_PATH], [systemd-run],
[/usr/bin/systemd-run])
if only one place uses it - define it there with CommandPath
Line 332: AC_PATH_PROG([TAR_PATH], [tar], [/bin/tar])
Line 333: AC_PATH_PROG([TC_PATH], [tc], [/sbin/tc])
Line 334: AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee])
Line 335: AC_PATH_PROG([TOUCH_PATH], [touch], [/bin/touch])
https://gerrit.ovirt.org/#/c/40239/1/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:
Line 52: command.extend(cmd)
Line 53: return command
Line 54:
Line 55:
Line 56: def systemd_run(cmd, scope=False, unit=None, slice=None):
this is specific code for systemd - shouldn't be in vdsm core. either have verb
in vdsm-tool for that and call it or have specific systemd code under
init/systemd folder.
Line 57: command = [constants.EXT_SYSTEMD_RUN]
Line 58: if scope:
Line 59: command.append('--scope')
Line 60: if unit:
https://gerrit.ovirt.org/#/c/40239/1/vdsm/sudoers.vdsm.in
File vdsm/sudoers.vdsm.in:
Line 12: @MV_PATH@ /etc/multipath.conf *, \
Line 13: @CP_PATH@ * /etc/iscsi/iscsid.conf, \
Line 14: @SERVICE_PATH@ iscsid *, \
Line 15: @BINDIR@/vdsm-tool service-restart multipathd, \
Line 16: @BINDIR@/vdsm-tool service-reload multipathd, \
if adding any permission I would add vdsm-tool call for it which hides the
specific implementation ^
Line 17: @ISCSIADM_PATH@ *, \
Line 18: @LVM_PATH@, \
Line 19: @CAT_PATH@ /sys/block/*/device/../../*, \
Line 20: @CAT_PATH@ /sys/devices/platform/host*, \
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic35bdae752228b6716c25f0b9975fc500897a592
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: use subscription when creating a client
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpcvdscli: use subscription when creating a client .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18209/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1439/ : 0 -- To view, visit https://gerrit.ovirt.org/40307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e1084a4016509aaf0e9e749ff05e33a331f580 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Run glusterfs in its own cgroup .. Patch Set 2: Build Started (2/2) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1441/ -- To view, visit https://gerrit.ovirt.org/40240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Build Started (5/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1403/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
automat...@ovirt.org has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 6: * Update tracker::#1169338::OK * Check Bug-Url::OK * Check Public Bug::#1169338::OK, public bug * Check Product::#1169338::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
Dan Kenigsberg has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39823/5/lib/vdsm/tool/configurators/passwd.py File lib/vdsm/tool/configurators/passwd.py: Line 46: return NO Line 47: Line 48: Line 49: def configure(): Line 50: script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME) _SASLPASSWD2.cmd returns a string. If it does not - we have a big problem everywhere. Line 51: rc, _, err = utils.execCmd(script, data=libvirt_password()) Line 52: if rc != 0: Line 53: raise RuntimeError(Set password failed: %s % (err,)) Line 54: -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 6: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1405/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove libvirt configure code from debian prerm script
Dan Kenigsberg has posted comments on this change. Change subject: Remove libvirt configure code from debian prerm script .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c428fd9d2da431f59e5d54a09ef5a9f7c323555 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove libvirt configure code from debian prerm script
automat...@ovirt.org has posted comments on this change. Change subject: Remove libvirt configure code from debian prerm script .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c428fd9d2da431f59e5d54a09ef5a9f7c323555 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: To avoid vdsm upgrade bugs all modules configure should run
oVirt Jenkins CI Server has posted comments on this change. Change subject: To avoid vdsm upgrade bugs all modules configure should run .. Patch Set 1: -Verified Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18215/ -- To view, visit https://gerrit.ovirt.org/39492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: To avoid vdsm upgrade bugs all modules configure should run
oVirt Jenkins CI Server has posted comments on this change. Change subject: To avoid vdsm upgrade bugs all modules configure should run .. Patch Set 1: Build Started (2/6) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1445/ -- To view, visit https://gerrit.ovirt.org/39492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove libvirt configure code from debian prerm script
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove libvirt configure code from debian prerm script .. Remove libvirt configure code from debian prerm script The code which configure related services conf files is currently part of vdsm-tool configure verb. This verb is being called by ovirt deploy or manually by the user. This patch calls vdsm-tool remove-config which does that cleanup. Change-Id: I5c428fd9d2da431f59e5d54a09ef5a9f7c323555 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: https://gerrit.ovirt.org/39767 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm.prerm 1 file changed, 1 insertion(+), 16 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c428fd9d2da431f59e5d54a09ef5a9f7c323555 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 2: Build Started (6/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/96/ -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2887/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1448/ : 0 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: python3: eliminate tuple_params
Ido Barkan has posted comments on this change. Change subject: python3: eliminate tuple_params .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I049adecda40deb6f715e3aea2e3ada4030b518a3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: moving changeNumvfs to network/api.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: moving changeNumvfs to network/api.py .. Patch Set 2: Build Started (3/3) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1450/ -- To view, visit https://gerrit.ovirt.org/40086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bfb3885e7366a40499ff2587839491008209b58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: ovs .. Patch Set 3: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18222/ -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 2: Build Started (7/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/551/ -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: ovs .. Patch Set 2: Build Started (2/2) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1451/ -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: To avoid vdsm upgrade bugs all modules configure should run
oVirt Jenkins CI Server has posted comments on this change. Change subject: To avoid vdsm upgrade bugs all modules configure should run .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/852/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/861/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1406/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/91/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1445/ : 0 -- To view, visit https://gerrit.ovirt.org/39492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 2: Build Started (8/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/96/ -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (5/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18210/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (6/6) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1440/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: updated commit message anyhow to make it more clear -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Build Started (2/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/858/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Build Started (4/6) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1442/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
automat...@ovirt.org has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: * Update tracker::#1169338::OK * Check Bug-Url::OK * Check Public Bug::#1169338::OK, public bug * Check Product::#1169338::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18212/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: -Verified Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/849/ -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/849/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1403/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/88/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1442/ : 0 -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
Dan Kenigsberg has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/39823/6/lib/vdsm/tool/configurators/passwd.py File lib/vdsm/tool/configurators/passwd.py: Line 1: # Copyright 2012 IBM, Inc. Also Red Hat and also 2015. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or Line 49: def configure(): Line 50: script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME) Line 51: rc, _, err = utils.execCmd(script, data=libvirt_password()) Line 52: if rc != 0: Line 53: raise RuntimeError(Set password failed: %s % (err,)) should we persist the sasl db? Otherwise, we would call configure on every boot. Line 54: Line 55: Line 56: def removeConf(): Line 57: if isconfigured() == YES: -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
automat...@ovirt.org has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove redundant print which interfere yum output .. Remove redundant print which interfere yum output The print removed configuration of module [module-name] successfully is not necessary and better to avoid it. Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40235 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: mooli tayer mta...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
Piotr Kliczewski has abandoned this change. Change subject: detector: make sure to drop connection when no data .. Abandoned This issue was fixed in different patch. -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: fix call to super ctor
Francesco Romani has posted comments on this change. Change subject: jsonrpc: fix call to super ctor .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
automat...@ovirt.org has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print which interfere yum output
Dan Kenigsberg has posted comments on this change. Change subject: Remove redundant print which interfere yum output .. Patch Set 1: Code-Review+2 I like verbosity - but you're the owner. -- To view, visit https://gerrit.ovirt.org/40235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138302190d11de87ee820c86f9903d6b4558bd0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40088/1/vdsm/network/api.py File vdsm/network/api.py: Line 558: os.makedirs(dir_path) Line 559: except OSError as ose: Line 560: if errno.EEXIST != ose.errno: Line 561: raise Line 562: with open(dir_path, device_name, 'w') as f: os.path.join Done Line 563: f.write(str(numvfs)) Line 564: Line 565: Line 566: def changeNumvfs(device_name, num_vfs): https://gerrit.ovirt.org/#/c/40088/1/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 67: return num_vfs_by_device, missing_devices Line 68: Line 69: Line 70: def _remove_missing_devices_persistence(missing_devices): Line 71: for file_name in missing_devices: please log missing devices - if we suddenly no longer see a device, let the Done Line 72: os.remove(os.path.join(_VIRTUAL_FUNCTIONS_PATH, file_name)) Line 73: Line 74: Line 75: def _restore_sriov_num_vfs(): -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: restore sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: restore sriov devices number of vfs .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
Yaniv Bronhaim has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: moving changeNumvfs to network/api.py
automat...@ovirt.org has posted comments on this change. Change subject: network: moving changeNumvfs to network/api.py .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bfb3885e7366a40499ff2587839491008209b58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: clientSeen should have its default timeout
automat...@ovirt.org has posted comments on this change. Change subject: network: clientSeen should have its default timeout .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5e28247bebd91878c2a2c687b2eeb9bfec6586 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
