Change in vdsm[master]: gluster: Verify volume is Replica 3
Nir Soffer has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/41931/8/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 113: self.assertEquals(gluster.options,
Line 114:
backup-volfile-servers=192.168.122.2:192.168.122.3)
Line 115:
Line 116: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 117: def testUserProvidedGlusterMountOptions(self):
Use lowercase names
Line 118:
Line 119: def glusterVolumeInfo(volname=None, volfileServer=None):
Line 120: return None
Line 121:
Line 126: options=user_options)
Line 127: self.assertEquals(gluster.options, user_options)
Line 128:
Line 129: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 130: def testNotReplica3GlusterVolume(self):
Use lowercase names
Line 131:
Line 132: def glusterVolumeInfo(volumeName=None, remoteServer=None):
Line 133: return {'music': {'brickCount': '2',
Line 134: 'bricks': ['192.168.122.1:/tmp/music',
--
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sahina Bose sab...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing support in sysv and upstart
Dima Kuznetsov has posted comments on this change. Change subject: Removing support in sysv and upstart .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: Remove Vdsm's dependency on gluster-server package.
Darshan N has posted comments on this change. Change subject: WIP: Remove Vdsm's dependency on gluster-server package. .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/41568/2/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 30: from storage import glusterUtils as gu Line 31: Line 32: _glusterCommandPath = utils.CommandPath(gluster, Line 33: /usr/sbin/gluster, Line 34: ) Should be removed as its no longer used... Done Line 35: _TIME_ZONE = time.tzname[0] Line 36: Line 37: Line 38: if hasattr(etree, 'ParseError'): https://gerrit.ovirt.org/#/c/41568/2/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 419: def set_rp_filter_loose(self, dev): Line 420: sysctl.set_rp_filter_loose(dev) Line 421: Line 422: @logDecorator Line 423: def volumeInfo(self, remoteServer, volumeName=None): This is gluster specific verb, should be named glusterVolumeInfo. Done Line 424: return glusterUtils.volumeInfo(remoteServer, volumeName) Line 425: Line 426: @logDecorator Line 427: def set_rp_filter_strict(self, dev): -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refreshPV verb
Freddy Rolland has abandoned this change. Change subject: hsm: Add refreshPV verb .. Abandoned -- To view, visit https://gerrit.ovirt.org/39528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I51139bd556cd3eb3b50c496d3c25a86bb2a09e72 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refreshPV verb
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Add refreshPV verb .. Patch Set 8: * Update tracker::#609689::OK -- To view, visit https://gerrit.ovirt.org/39528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51139bd556cd3eb3b50c496d3c25a86bb2a09e72 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Add resizePV verb
automat...@ovirt.org has posted comments on this change. Change subject: sp: Add resizePV verb .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/39382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57e0fe4fad3e41cd6346b49623869c6d26afaa92 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refreshDevice verb
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Add refreshDevice verb .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/38754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refreshDevice verb
Freddy Rolland has abandoned this change. Change subject: hsm: Add refreshDevice verb .. Abandoned -- To view, visit https://gerrit.ovirt.org/38754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Add resizePV verb
Freddy Rolland has abandoned this change. Change subject: sp: Add resizePV verb .. Abandoned -- To view, visit https://gerrit.ovirt.org/39382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I57e0fe4fad3e41cd6346b49623869c6d26afaa92 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add xfsprogs as dependency to gluster sub-package
Timothy Asir has posted comments on this change. Change subject: gluster: add xfsprogs as dependency to gluster sub-package .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8823e9a5e1c84af8c3afdf1fc5a26e04b4be831b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Simplify subclass mountpoint overriding
Freddy Rolland has posted comments on this change. Change subject: storageServer: Simplify subclass mountpoint overriding .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
Nir Soffer has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 2: (2 comments) Nice! https://gerrit.ovirt.org/#/c/42307/2/tests/storageServerTests.py File tests/storageServerTests.py: Line 18 Line 19 Line 20 Line 21 Line 22 Please sort imports Line 49: Line 50: class MountConnectionTests(VdsmTestCase): Line 51: Line 52: def test_mountpoint(self): Line 53: mountConn = MountConnection(dummy-spec, FakeMount) mountClass is kwarg - it must not be called as positional argument. In this case you are initializing vfsType to FakeMount - this will not do what you want. Should be: mountConn = MountConnection(dummy-spec, mountClass=FakeMount) Also, please use lowercase names (e.g. mountConn - mount_conn). In this context, con is even better. Line 54: self.assertEquals(mountConn._mount.fs_spec, dummy-spec) Line 55: self.assertEquals(mountConn._mount.fs_file, /tmp/dummy-spec) Line 56: Line 57: -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Nir Soffer has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing support in sysv and upstart
Dima Kuznetsov has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/40726/6/vdsm.spec.in
File vdsm.spec.in:
Line 257
Line 258
Line 259
Line 260
Line 261
If we're droping fedora 20 then this can be
%if 0%{?fedora}
Line 594
Line 595
Line 596
Line 597
Line 598
can be removed
Line 839:
:
:
:
:
:
:
:
:
:
:
:
:
:
can be removed
--
To view, visit https://gerrit.ovirt.org/40726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: Remove Vdsm's dependency on gluster-server package.
automat...@ovirt.org has posted comments on this change. Change subject: WIP: Remove Vdsm's dependency on gluster-server package. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Simplify subclass mountpoint overriding
Ala Hino has posted comments on this change. Change subject: storageServer: Simplify subclass mountpoint overriding .. Patch Set 11: -Verified -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
automat...@ovirt.org has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: use subscription when creating a client
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpcvdscli: use subscription when creating a client .. Patch Set 11: * Update tracker::#1112594::OK * Check Bug-Url::OK * Check Public Bug::#1112594::OK, public bug * Check Product::#1112594::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e1084a4016509aaf0e9e749ff05e33a331f580 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
automat...@ovirt.org has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 19: * Update tracker::#1112594::OK * Check Bug-Url::OK * Check Public Bug::#1112594::OK, public bug * Check Product::#1112594::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Yeela Kaplan has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 19: Verified+1 -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageConnection: Refactor MountConnection class
Nir Soffer has posted comments on this change. Change subject: storageConnection: Refactor MountConnection class .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/40575/9//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-05-05 22:13:07 +0300 Line 4: Commit: Ala Hino ah...@redhat.com Line 5: CommitDate: 2015-06-14 11:42:08 +0300 Line 6: Line 7: storageConnection: Refactor MountConnection class Use storageServer: Simplify subclass mountpoint overriding Line 8: Line 9: Define DIR constant that can be overriden by subclasses to provide Line 10: custom storage domain directory. For example, GlusterFSConnection defines DIR Line 11: as glusterSD. Line 7: storageConnection: Refactor MountConnection class Line 8: Line 9: Define DIR constant that can be overriden by subclasses to provide Line 10: custom storage domain directory. For example, GlusterFSConnection defines DIR Line 11: as glusterSD. Please wrap lines at 72 characters in the commit message. Adding this to your .vimrc can help: autocmd FileType gitcommit setlocal textwidth=72 spell Line 12: Line 13: Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Simplify subclass mountpoint overriding
Ala Hino has posted comments on this change. Change subject: storageServer: Simplify subclass mountpoint overriding .. Patch Set 11: Verified+1 -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
Ramesh N has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 7: Verified+1 I was able to reproduce this issues without this fix. But after this fix i could not reproduce the issue at all. Hence marking this patch as verified. -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
automat...@ovirt.org has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
Nir Soffer has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 3: Code-Review+1 Verified+1 Perfect. Marking as verified since the tests pass. -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: daemonAdapter: remove traceback when using help option
Dima Kuznetsov has posted comments on this change. Change subject: daemonAdapter: remove traceback when using help option .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/42147/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-06-10 14:31:13 +0300 Line 4: Commit: Yeela Kaplan ykap...@redhat.com Line 5: CommitDate: 2015-06-10 14:33:46 +0300 Line 6: Line 7: daemonAdapter: remove traceback when using help option why does the help option raise exception at all ? argparser executes the built-in --help, which calls sys.exit(?). The except clause without type caught the SystemExit exception (which is not a subtype of Exception so it should be ok now). Line 8: Line 9: Change-Id: I7c592d73fb72112839b83794fd737967b2c92600 Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120787 -- To view, visit https://gerrit.ovirt.org/42147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c592d73fb72112839b83794fd737967b2c92600 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Simplify subclass mountpoint overriding
Nir Soffer has posted comments on this change. Change subject: storageServer: Simplify subclass mountpoint overriding .. Patch Set 11: Code-Review+1 Please verify - connecting to nfs and gluster storage domain should be enough to verify this. -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
Bala.FA has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Fix COMPELNT/Compellent Vol configuration
Allon Mureinik has posted comments on this change. Change subject: multipath: Fix COMPELNT/Compellent Vol configuration .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3bf5bab082c5063272bf8947a6e2039ce4cf90c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Fix HITACHI/DF.* configuration
Allon Mureinik has posted comments on this change. Change subject: multipath: Fix HITACHI/DF.* configuration .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78195b148aa3953f56b5a0b97366ccbdb3030d00 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: fileSD: Optimize getAllVolumes on file storage
Allon Mureinik has posted comments on this change. Change subject: fileSD: Optimize getAllVolumes on file storage .. Patch Set 1: Yaniv/Dan? Can we move forward here? -- To view, visit https://gerrit.ovirt.org/41127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc19ce272b7e0b9c91d2f90aa46b5ddd21d69ece Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Build vdsm-gluster as part of RHEV vdsm build
automat...@ovirt.org has posted comments on this change. Change subject: build: Build vdsm-gluster as part of RHEV vdsm build .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib487f226a7a0853b600246f1cb0707c3526a7fd0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Verify volume is Replica 3
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 11: * Update tracker::#1123052::OK * Check Bug-Url::OK * Check Public Bug::#1123052::OK, public bug * Check Product::#1123052::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Allow gluster mount with additional servers
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers .. Patch Set 13: * Update tracker::#117::OK * Check Bug-Url::OK * Check Public Bug::#117::OK, public bug * Check Product::#117::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
Ala Hino has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/42307/2/tests/storageServerTests.py File tests/storageServerTests.py: Line 18 Line 19 Line 20 Line 21 Line 22 Please sort imports Done Line 49: Line 50: class MountConnectionTests(VdsmTestCase): Line 51: Line 52: def test_mountpoint(self): Line 53: mountConn = MountConnection(dummy-spec, FakeMount) mountClass is kwarg - it must not be called as positional argument. Done Line 54: self.assertEquals(mountConn._mount.fs_spec, dummy-spec) Line 55: self.assertEquals(mountConn._mount.fs_file, /tmp/dummy-spec) Line 56: Line 57: -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageConnection: Refactor MountConnection class
automat...@ovirt.org has posted comments on this change. Change subject: storageConnection: Refactor MountConnection class .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
automat...@ovirt.org has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing support in sysv and upstart
automat...@ovirt.org has posted comments on this change. Change subject: Removing support in sysv and upstart .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove el6 specific code from spec
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove el6 specific code from spec
..
Remove el6 specific code from spec
Change-Id: Ifef95b7c61b8bd8c86ef2642e74275da87659cb8
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 65 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/42317/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 2f7a936..287d405 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -57,13 +57,8 @@
%global with_systemd 1
%endif
-%if 0%{?rhel} == 6
-%global _udevrulesdir /lib/udev/rules.d/
-%global _udevexecdir /lib/udev/
-%else
%global _udevrulesdir /usr/lib/udev/rules.d/
%global _udevexecdir /usr/lib/udev/
-%endif
Name: %{vdsm_name}
Version:@PACKAGE_VERSION@
@@ -105,15 +100,7 @@
BuildRequires: python-pthreading
BuildRequires: qemu-img
BuildRequires: rpm-python
-%if 0%{?rhel} == 6
-BuildRequires: python-simplejson = 2.0.9
-BuildRequires: policycoreutils-python 2.0.83-19.47
-BuildRequires: python-argparse
-BuildRequires: python-ordereddict
-%endif
-%if 0%{?rhel} 6 || 0%{?fedora}
BuildRequires: python-blivet
-%endif
# Autotools BuildRequires
%if 0%{?enable_autotools}
@@ -170,14 +157,12 @@
Requires: libguestfs-tools-c = 1:1.26.7-2
%endif
-%if 0%{?rhel} = 7 || 0%{?fedora}
Requires: libvirt-daemon-config-nwfilter
Requires: libvirt-daemon-driver-network
Requires: libvirt-daemon-driver-nwfilter
Requires: libvirt-daemon-driver-qemu
-%endif
-%if 0%{?rhel} = 7
+%if 0%{?rhel}
%if 0%{?rhev_build}
Requires: libvirt-daemon = 1.2.8-16.el7_1.2
Requires: libvirt-python = 1.2.8-7.el7_1.1
@@ -185,12 +170,7 @@
Requires: libvirt-daemon = 1.2.8-15.el7
Requires: libvirt-python = 1.2.8-5.el7
%endif # rhev_build
-%endif # rhel 7
-
-%if 0%{?rhel} == 6
-Requires: libvirt = 0.10.2-29.el6_5.4
-Requires: libvirt-python
-%endif
+%endif # rhel
%if 0%{?fedora} = 22
Requires: libvirt-daemon = 1.2.13
@@ -206,11 +186,7 @@
# iscsi-intiator versions
%if 0%{?rhel}
-%if 0%{?rhel} = 7
Requires: iscsi-initiator-utils
-%else
-Requires: iscsi-initiator-utils = 6.2.0.872-15
-%endif # rhel 7
%else # fedora
Requires: iscsi-initiator-utils = 6.2.0.873-21
%endif
@@ -218,7 +194,6 @@
Requires: sanlock = 2.8, sanlock-python
%if 0%{?rhel}
-%if 0%{?rhel} = 7
Requires: device-mapper-multipath = 0.4.9-68
Requires: e2fsprogs
Requires: fence-agents-all
@@ -226,19 +201,6 @@
Requires: python
Requires: policycoreutils-python
Requires: selinux-policy-targeted = 3.13.1-16.el7
-%else
-Requires: python
-Requires: device-mapper-multipath = 0.4.9-75
-Requires: e2fsprogs = 1.41.12-11
-Requires: fence-agents
-Requires: kernel = 2.6.32-465
-Requires: initscripts = 9.03.31-2.el6_3.1
-Requires: policycoreutils = 2.0.83-19.30
-Requires: policycoreutils-python = 2.0.83-19.47.el6_6.1
-Requires: selinux-policy-targeted = 3.7.19-260.el6_6.2
-Requires: lvm2 = 2.02.100-5
-Requires: logrotate 3.8.0
-%endif
%else
Requires: fence-agents-all
Requires: kernel = 3.11.3-201
@@ -267,13 +229,8 @@
%endif # !%{fedora_koji_build}
%if 0%{?rhel}
-%if 0%{?rhel} = 7
Requires: qemu-kvm%{?qemu_suffix} = 10:2.1.2-23.el7_1.2
Requires: qemu-img%{?qemu_suffix} = 10:2.1.2-23.el7_1.2
-%else
-Requires: qemu-kvm%{?qemu_suffix} = 2:0.12.1.2-2.422
-Requires: qemu-img%{?qemu_suffix} = 2:0.12.1.2-2.422
-%endif # rhel = 7
%else
Requires: qemu-kvm = 2:2.0.0-1
Requires: qemu-img = 2:2.0.0-1
@@ -337,10 +294,6 @@
Requires: %{name}-python = %{version}-%{release}
Requires: %{name}-yajsonrpc = %{version}-%{release}
Obsoletes: vdsm-api 4.16
-%if 0%{?rhel} == 6
-Requires: python-ordereddict
-Requires: python-simplejson = 2.0.9
-%endif
%description jsonrpc
A Json-based RPC interface that serves as the protocol for libvdsm.
@@ -652,9 +605,6 @@
%prep
%setup -q
-%if 0%{?rhel} == 6
-sed -i '/ su /d' vdsm/vdsm-logrotate.conf.in
-%endif
%build
%if 0%{?enable_autotools}
@@ -735,19 +685,12 @@
%endif
# Install the polkit for libvirt
-%if 0%{?fedora} || 0%{?rhel} = 7
install -Dm 0644 vdsm/vdsm-libvirt-access.rules \
%{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.rules
-%else
-install -Dm 0644 vdsm/vdsm-libvirt-access.pkla \
- %{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.pkla
-%endif
# Install the libvirt hook for cleaning up the XML
-%if 0%{?fedora} || 0%{?rhel} = 7
install -Dm 0755 vdsm/virt/libvirt-hook.sh \
%{buildroot}%{_sysconfdir}/libvirt/hooks/qemu
-%endif
%check
%if 0%{?with_check}
@@ -1038,9 +981,7 @@
%{_sysconfdir}/dhcp/dhclient.d/sourceRoute.sh
%{_sysconfdir}/sudoers.d/50_vdsm
%{_sysconfdir}/cron.hourly/vdsm-logrotate
-%if 0%{?fedora} || 0%{?rhel} = 7
%{_sysconfdir}/libvirt/hooks/qemu
-%endif
%{_datadir}/%{vdsm_name}/logUtils.py*
%{_datadir}/%{vdsm_name}/dsaversion.py*
%{_libexecdir}/%{vdsm_name}/curl-img-wrap
@@ -1199,11 +1140,7 @@
Change in vdsm[master]: Remove el6 specific code from spec
automat...@ovirt.org has posted comments on this change. Change subject: Remove el6 specific code from spec .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifef95b7c61b8bd8c86ef2642e74275da87659cb8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Simplify subclass mountpoint overriding
automat...@ovirt.org has posted comments on this change. Change subject: storageServer: Simplify subclass mountpoint overriding .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Verify volume is Replica 3
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 12: * Update tracker::#1123052::OK * Check Bug-Url::OK * Check Public Bug::#1123052::OK, public bug * Check Product::#1123052::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Simplify subclass mountpoint overriding
Ala Hino has posted comments on this change. Change subject: storageServer: Simplify subclass mountpoint overriding .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/40575/9//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-05-05 22:13:07 +0300 Line 4: Commit: Ala Hino ah...@redhat.com Line 5: CommitDate: 2015-06-14 11:42:08 +0300 Line 6: Line 7: storageConnection: Refactor MountConnection class Use storageServer: Simplify subclass mountpoint overriding Done Line 8: Line 9: Define DIR constant that can be overriden by subclasses to provide Line 10: custom storage domain directory. For example, GlusterFSConnection defines DIR Line 11: as glusterSD. Line 7: storageConnection: Refactor MountConnection class Line 8: Line 9: Define DIR constant that can be overriden by subclasses to provide Line 10: custom storage domain directory. For example, GlusterFSConnection defines DIR Line 11: as glusterSD. Please wrap lines at 72 characters in the commit message. Done Line 12: Line 13: Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
Yeela Kaplan has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
Yeela Kaplan has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 19: Verified+1 -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
Yeela Kaplan has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Verify volume is Replica 3
Allon Mureinik has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 8:
(5 comments)
https://gerrit.ovirt.org/#/c/41931/8//COMMIT_MSG
Commit Message:
Line 6:
Line 7: gluster: Verify volume is Replica 3
Line 8:
Line 9: Verify that only Replica 3 volumes are used in gluster storage domains.
Line 10:
Shouldn't this have Bug-Url: https://bugzilla.redhat.com/1123052; ?
Line 11: Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
https://gerrit.ovirt.org/#/c/41931/8/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 84: 'name':
Line 85: '192.168.122.1:/tmp/music',
Line 86: 'hostUuid':
Line 87:
'04eb591b-2fd3-489e-a22c-5d342a3c713d'
Line 88: }, {
Unrelated to this patch. If you want to improve formatting, please do so in a
separate patch.
Line 89: 'name':
Line 90: '192.168.122.2:/tmp/music',
Line 91: 'hostUuid':
Line 92:
'04eb591b-2fd3-489e-a22c-5d342a3c713d'
Line 89: 'name':
Line 90: '192.168.122.2:/tmp/music',
Line 91: 'hostUuid':
Line 92:
'04eb591b-2fd3-489e-a22c-5d342a3c713d'
Line 93: }, {
Unrelated to this patch. If you want to improve formatting, please do so in a
separate patch.
Line 94: 'name':
Line 95: '192.168.122.3:/tmp/music',
Line 96: 'hostUuid':
Line 97:
'04eb591b-2fd3-489e-a22c-5d342a3c713d'
Line 94: 'name':
Line 95: '192.168.122.3:/tmp/music',
Line 96: 'hostUuid':
Line 97:
'04eb591b-2fd3-489e-a22c-5d342a3c713d'
Line 98: }],
Unrelated to this patch. If you want to improve formatting, please do so in a
separate patch.
Line 99: 'options': {'auth.allow': '*'},
Line 100: 'replicaCount': '3',
Line 101: 'stripeCount': '1',
Line 102: 'disperseCount': '0',
https://gerrit.ovirt.org/#/c/41931/8/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 289: def validate(self):
Line 290: replicaCount = self.volinfo[self._volname]['replicaCount']
Line 291: if not replicaCount == '3':
Line 292: raise
se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 293:
Do we also want to validate the other parameters described in
http://www.ovirt.org/Gluster_Storage_Domain_Reference ?
Line 294: def _get_gluster_mount_options(self):
Line 295: if backup-volfile-servers in self._options:
Line 296: self.log.warn(User specified mount options will be
used.)
Line 297: return
--
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sahina Bose sab...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: refactor create command
automat...@ovirt.org has posted comments on this change. Change subject: v2v: refactor create command .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9edabb2ec324693432ff71d2a8e682afbe3a35 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add factory method for ImportVm class
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add factory method for ImportVm class .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5689bc80d66499e1884344d80df127b513507ab7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
Nir Soffer has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 2: Please rebase on master - you are working on stale code. -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
Freddy Rolland has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing support in sysv and upstart
Nir Soffer has posted comments on this change. Change subject: Removing support in sysv and upstart .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/40726/6/vdsm.spec.in File vdsm.spec.in: Line 257 Line 258 Line 259 Line 260 Line 261 If we're droping fedora 20 then this can be We are not dropping, we already *dropped* it :-) -- To view, visit https://gerrit.ovirt.org/40726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix vg create failed first time during brick create
Bala.FA has posted comments on this change. Change subject: gluster: fix vg create failed first time during brick create .. Patch Set 8: Code-Review+1 We would need this patch urgently for RHGS downstream. However once this patch https://gerrit.ovirt.org/#/c/42070/ gets merged we will adopt the change accordingly. -- To view, visit https://gerrit.ovirt.org/41392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
Nir Soffer has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 3: Needs rebase -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
Yeela Kaplan has posted comments on this change.
Change subject: migration: Use jsonrpc during migration of vms
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/36701/18/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 133: self._destServer = jsonrpcvdscli.connect(client)
Line 134: self.log.debug('Initiating connection with destination')
Line 135: self._destServer.ping()
Line 136:
Line 137: except Exception:
Never use this catching-all except clause. You would not want to use xmrp
Done
Line 138: if config.getboolean('vars', 'ssl'):
Line 139: self._destServer = vdscli.connect(
Line 140: hostPort,
Line 141: useSSL=True,
--
To view, visit https://gerrit.ovirt.org/36701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 15: * Update tracker::#1112594::OK * Check Bug-Url::OK * Check Public Bug::#1112594::OK, public bug * Check Product::#1112594::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: Remove Vdsm's dependency on gluster-server package.
Allon Mureinik has posted comments on this change. Change subject: WIP: Remove Vdsm's dependency on gluster-server package. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41568/2/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 30: from storage import glusterUtils as gu Line 31: Line 32: _glusterCommandPath = utils.CommandPath(gluster, Line 33: /usr/sbin/gluster, Line 34: ) Should be removed as its no longer used... Line 35: _TIME_ZONE = time.tzname[0] Line 36: Line 37: Line 38: if hasattr(etree, 'ParseError'): -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: Remove Vdsm's dependency on gluster-server package.
Nir Soffer has posted comments on this change. Change subject: WIP: Remove Vdsm's dependency on gluster-server package. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41568/2/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 419: def set_rp_filter_loose(self, dev): Line 420: sysctl.set_rp_filter_loose(dev) Line 421: Line 422: @logDecorator Line 423: def volumeInfo(self, remoteServer, volumeName=None): This is gluster specific verb, should be named glusterVolumeInfo. This should replace the glusterVolumeInfo registered by the gluster when gluster is enabled. Line 424: return glusterUtils.volumeInfo(remoteServer, volumeName) Line 425: Line 426: @logDecorator Line 427: def set_rp_filter_strict(self, dev): -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing support in sysv and upstart
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing support in sysv and upstart
..
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40726/6/vdsm.spec.in
File vdsm.spec.in:
Line 723: # only once after first installation.
Line 724: /bin/systemctl enable vdsmd.service /dev/null 21 || :
Line 725: /bin/systemctl enable vdsm-network.service /dev/null 21 || :
Line 726: /bin/systemctl enable supervdsmd.service /dev/null 21 || :
Line 727: fi
shouldn't be here.
Line 728: /bin/systemctl daemon-reload /dev/null 21 || :
Line 729: exit 0
Line 730:
Line 731: %preun
Line 733: %{_bindir}/vdsm-tool remove-config
Line 734: fi
Line 735: %systemd_preun vdsmd.service
Line 736: %systemd_preun vdsm-network.service
Line 737: %systemd_preun supervdsmd.service
this currently doesn't do anything - we didn't declare unit file for vdsmd.
this patch should rebase on the fix to
https://bugzilla.redhat.com/show_bug.cgi?id=1094936
Line 738: exit 0
Line 739:
Line 740: %postun
Line 741: if [ $1 -ge 1 ]; then
--
To view, visit https://gerrit.ovirt.org/40726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing support in sysv and upstart
automat...@ovirt.org has posted comments on this change. Change subject: Removing support in sysv and upstart .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove el6 specific code from spec
automat...@ovirt.org has posted comments on this change. Change subject: Remove el6 specific code from spec .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifef95b7c61b8bd8c86ef2642e74275da87659cb8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Allow gluster mount with additional servers
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers .. Patch Set 14: * Update tracker::#117::OK * Check Bug-Url::OK * Check Public Bug::#117::OK, public bug * Check Product::#117::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Build vdsm-gluster as part of RHEV vdsm build
automat...@ovirt.org has posted comments on this change. Change subject: build: Build vdsm-gluster as part of RHEV vdsm build .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib487f226a7a0853b600246f1cb0707c3526a7fd0 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Build vdsm-gluster as part of RHEV vdsm build
Nir Soffer has posted comments on this change. Change subject: build: Build vdsm-gluster as part of RHEV vdsm build .. Patch Set 8: Code-Review-1 This patch is ok for testing the next patches, but the real fix is Darshan patch: https://gerrit.ovirt.org/41568 Lets rebase the next patches on that patch instead. -- To view, visit https://gerrit.ovirt.org/41858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib487f226a7a0853b600246f1cb0707c3526a7fd0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Yaniv Bronhaim has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Convert unhelpful warnings to debug messages
Allon Mureinik has posted comments on this change. Change subject: fileUtils: Convert unhelpful warnings to debug messages .. Patch Set 7: Any news? -- To view, visit https://gerrit.ovirt.org/36764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7800b860eb81334b63abefcca9a21a552331458f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
Timothy Asir has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
automat...@ovirt.org has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 6: * Update tracker::#1227742::OK * Check Bug-Url::OK * Check Public Bug::#1227742::OK, public bug * Check Public Bug::#1227788::ERROR, private bug * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix AttributeError and TypeError in exception.py
automat...@ovirt.org has posted comments on this change. Change subject: gluster: fix AttributeError and TypeError in exception.py .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41530 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
Ala Hino has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/42307/1/tests/storageServerTests.py File tests/storageServerTests.py: Line 26: Line 27: class FakeMount(object): Line 28: def __init__(self, fs_spec, fs_file): Line 29: self._fs_spec = fs_spec Line 30: self._fs_file = fs_file use public names, we want to implement the test by comparing these. Done Line 31: Line 32: Line 33: class IscsiConnectionMismatchTests(VdsmTestCase): Line 34: Line 48: Line 49: Line 50: class MountConnectionTests(VdsmTestCase): Line 51: Line 52: def testLocalPathBase(self): This does not test localPathBase, but the mountpoint. Done Line 53: mountConn = MountConnection(, FakeMount) Line 54: self.assertEquals(mountConn._getLocalPath(), /tmp/) Line 55: Line 56: Line 49: Line 50: class MountConnectionTests(VdsmTestCase): Line 51: Line 52: def testLocalPathBase(self): Line 53: mountConn = MountConnection(, FakeMount) You have to modify MountConnection so it accepts a mountClass argument. Done Line 54: self.assertEquals(mountConn._getLocalPath(), /tmp/) Line 55: Line 56: Line 57: class GlusterFSConnectionTests(VdsmTestCase): Line 50: class MountConnectionTests(VdsmTestCase): Line 51: Line 52: def testLocalPathBase(self): Line 53: mountConn = MountConnection(, FakeMount) Line 54: self.assertEquals(mountConn._getLocalPath(), /tmp/) If you test _getLocalPath(), why do you need the FakeMount class? Done Line 55: Line 56: Line 57: class GlusterFSConnectionTests(VdsmTestCase): Line 58: Line 58: Line 59: def testLocalPathBase(self): Line 60: mountConn = GlusterFSConnection(server:/volume, FakeMount) Line 61: self.assertEquals(mountConn._getLocalPath(), Line 62: /tmp/glusterSD/server:_volume) Same as above. Done -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test for mount connection classes
automat...@ovirt.org has posted comments on this change. Change subject: tests: Add test for mount connection classes .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e0b12eaab80dc274ad3c35f79c2897f4dae44a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageConnection: Refactor MountConnection class
automat...@ovirt.org has posted comments on this change. Change subject: storageConnection: Refactor MountConnection class .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a55a7f219a60c7ffb0ce981175492e560bb757f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Verify volume is Replica 3
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Build vdsm-gluster as part of RHEV vdsm build
automat...@ovirt.org has posted comments on this change. Change subject: build: Build vdsm-gluster as part of RHEV vdsm build .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib487f226a7a0853b600246f1cb0707c3526a7fd0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Allow gluster mount with additional servers
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers .. Patch Set 12: * Update tracker::#117::OK * Check Bug-Url::OK * Check Public Bug::#117::OK, public bug * Check Product::#117::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Build vdsm-gluster as part of RHEV vdsm build
Allon Mureinik has posted comments on this change.
Change subject: build: Build vdsm-gluster as part of RHEV vdsm build
..
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/41858/6/vdsm.spec.in
File vdsm.spec.in:
Line 293: Requires: glusterfs-cli
Line 294: Requires: glusterfs-api
Line 295: Requires: glusterfs-fuse
Line 296: Requires: glusterfs-geo-replication
Line 297: Requires: glusterfs-rdma
these packages won't be shipped in the regular rhel channels (or centos builds,
for that matter). I'm fine with always shipping vdsm-gluster and allowing the
end user to decide whether to install it or not, but I'm not fine with breaking
VDSM's installation over gluster if the user doesn't have it installed. These
requirements should be limited to vdsm-gluster - see below.
Line 298:
Line 299: Requires: psmisc = 22.6-15
Line 300: Requires: bridge-utils
Line 301: Requires: sos
Line 714: Requires: %{name} = %{version}-%{release}
Line 715: Requires: glusterfs-server
Line 716: Requires: python-magic
Line 717: %if 0%{?rhel} 6 || 0%{?fedora}
Line 718: Requires: python-blivet
The requirements should be moved here.
Line 719: %endif
Line 720:
Line 721: %description gluster
Line 722: Gluster plugin enables VDSM to serve Gluster functionalities.
--
To view, visit https://gerrit.ovirt.org/41858
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib487f226a7a0853b600246f1cb0707c3526a7fd0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sahina Bose sab...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Verify volume is Replica 3
Ala Hino has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/41931/8//COMMIT_MSG Commit Message: Line 6: Line 7: gluster: Verify volume is Replica 3 Line 8: Line 9: Verify that only Replica 3 volumes are used in gluster storage domains. Line 10: Shouldn't this have Bug-Url: https://bugzilla.redhat.com/1123052; ? Done Line 11: Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Verify volume is Replica 3
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 .. Patch Set 10: * Update tracker::#1123052::OK * Check Bug-Url::OK * Check Public Bug::#1123052::OK, public bug * Check Product::#1123052::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
automat...@ovirt.org has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 7: * Update tracker::#1227742::OK * Check Bug-Url::OK * Check Public Bug::#1227742::OK, public bug * Check Public Bug::#1227788::ERROR, private bug * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
Timothy Asir has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix AttributeError and TypeError in exception.py
Timothy Asir has posted comments on this change. Change subject: gluster: fix AttributeError and TypeError in exception.py .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/41530 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add factory method for ImportVm class
Shahar Havivi has posted comments on this change. Change subject: v2v: Add factory method for ImportVm class .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42065/1/vdsm/v2v.py File vdsm/v2v.py: Line 299: self._aborted = False Line 300: self._prepared_volumes = [] Line 301: Line 302: @classmethod Line 303: def from_libvirt(self, uri, username, password, vminfo, job_id, irs): the idea is neat and I like it. The implementation looks wrong. Right I did fix it in the wrong patch... I will resend it Line 304: self._uri = uri Line 305: self._username = username Line 306: self._password = password Line 307: self._id = job_id -- To view, visit https://gerrit.ovirt.org/42065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5689bc80d66499e1884344d80df127b513507ab7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: refactor create command
Shahar Havivi has posted comments on this change. Change subject: v2v: refactor create command .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/42066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9edabb2ec324693432ff71d2a8e682afbe3a35 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add factory method for ImportVm class
Shahar Havivi has posted comments on this change. Change subject: v2v: Add factory method for ImportVm class .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/42065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5689bc80d66499e1884344d80df127b513507ab7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: config: remove not needed option
Yeela Kaplan has posted comments on this change. Change subject: config: remove not needed option .. Patch Set 1: Code-Review+1 It looks ok, but wasn't it used in the code anywhere? Or did you remove the usage in another patch? -- To view, visit https://gerrit.ovirt.org/42092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31c6b3ea541ad373b4660fb7d9b147d982383120 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Allow gluster mount with additional servers
Nir Soffer has posted comments on this change.
Change subject: gluster: Allow gluster mount with additional servers
..
Patch Set 15:
(3 comments)
https://gerrit.ovirt.org/#/c/40665/15/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 72: self.assertEquals(mount_con._mount.fs_file,
Line 73: /tmp/glusterSD/server:_volume)
Line 74:
Line 75: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 76: def testGlusterMountOptions(self):
Use lower_case names
Line 77: def glusterVolumeInfo(volname=None, volfileServer=None):
Line 78: self.assertEqual(volname, music)
Line 79: self.assertEqual(volfileServer, 192.168.122.1)
Line 80: return {'music': {'brickCount': '3',
Line 114: gluster = GlusterFSConnection(spec=192.168.122.1:/music)
Line 115: self.assertEquals(gluster.options,
Line 116:
backup-volfile-servers=192.168.122.2:192.168.122.3)
Line 117:
Line 118: def testUserProvidedGlusterMountOptions(self):
Use lower_case names
Line 119: user_options = backup-volfile-servers=server1:server2
Line 120: gluster = GlusterFSConnection(spec=192.168.122.1:/music,
Line 121: options=user_options)
https://gerrit.ovirt.org/#/c/40665/15/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 280: mountClass=mount.Mount):
Line 281: super(GlusterFSConnection, self).__init__(spec,
Line 282: vfsType,
Line 283: options,
Line 284: mountClass)
Call kwargs properly:
vfsType=vfsType,
options=options,
mountClass=mountClass
Line 285: self._gluster_options = None
Line 286:
Line 287: @property
Line 288: def options(self):
--
To view, visit https://gerrit.ovirt.org/40665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sahina Bose sab...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move path getters
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: move path getters .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/41995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb49591357e0ae77268789da78e8504864a8057 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move logBlkSize
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: move logBlkSize .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/41996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b9b20e9c8c20fa5c151f7c86337bc54ab526e11 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Allow gluster mount with additional servers
Ala Hino has posted comments on this change.
Change subject: gluster: Allow gluster mount with additional servers
..
Patch Set 15:
(3 comments)
https://gerrit.ovirt.org/#/c/40665/15/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 72: self.assertEquals(mount_con._mount.fs_file,
Line 73: /tmp/glusterSD/server:_volume)
Line 74:
Line 75: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 76: def testGlusterMountOptions(self):
Use lower_case names
Done
Line 77: def glusterVolumeInfo(volname=None, volfileServer=None):
Line 78: self.assertEqual(volname, music)
Line 79: self.assertEqual(volfileServer, 192.168.122.1)
Line 80: return {'music': {'brickCount': '3',
Line 114: gluster = GlusterFSConnection(spec=192.168.122.1:/music)
Line 115: self.assertEquals(gluster.options,
Line 116:
backup-volfile-servers=192.168.122.2:192.168.122.3)
Line 117:
Line 118: def testUserProvidedGlusterMountOptions(self):
Use lower_case names
Done
Line 119: user_options = backup-volfile-servers=server1:server2
Line 120: gluster = GlusterFSConnection(spec=192.168.122.1:/music,
Line 121: options=user_options)
https://gerrit.ovirt.org/#/c/40665/15/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 280: mountClass=mount.Mount):
Line 281: super(GlusterFSConnection, self).__init__(spec,
Line 282: vfsType,
Line 283: options,
Line 284: mountClass)
Call kwargs properly:
Done
Line 285: self._gluster_options = None
Line 286:
Line 287: @property
Line 288: def options(self):
--
To view, visit https://gerrit.ovirt.org/40665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sahina Bose sab...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing support in sysv and upstart
Yeela Kaplan has posted comments on this change. Change subject: Removing support in sysv and upstart .. Patch Set 7: Code-Review-1 Yaniv, you did not answer my comments on patch set 4... -- To view, visit https://gerrit.ovirt.org/40726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add mount windows iso drivers
Shahar Havivi has posted comments on this change. Change subject: v2v: add mount windows iso drivers .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/42128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d4d19a63dcf338f8d48f8e757d6a35ef92d6d54 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
automat...@ovirt.org has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 20: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Dan Kenigsberg has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 19: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: add an option to create a stomp client .. stomp: add an option to create a stomp client Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Signed-off-by: Yeela Kaplan ykap...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38491 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/clientIF.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Yeela Kaplan: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
Dan Kenigsberg has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
automat...@ovirt.org has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Dan Kenigsberg has submitted this change and it was merged. Change subject: sslutils: move createSSLContext from clientIF .. sslutils: move createSSLContext from clientIF This can no longer be a private method, since we need it for creating an ssl context on vm migration. and it should be a part of vdsm's interface. Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Signed-off-by: Yeela Kaplan ykap...@redhat.com Reviewed-on: https://gerrit.ovirt.org/36699 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/sslutils.py M vdsm/clientIF.py 2 files changed, 19 insertions(+), 14 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yeela Kaplan: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronheim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Add resizePV verb
Nir Soffer has posted comments on this change. Change subject: sp: Add resizePV verb .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40467/2//COMMIT_MSG Commit Message: Line 8: Line 9: This command calls pvresize on a device and returns the new PV size. Line 10: Line 11: This command will extend the PV after a LUN was resized on the storage Line 12: server. It should be called after invoking Refresh Device verb, We don't have Refresh Device verb - please describe the current solution. Line 13: otherwise the PV size will not increase. Line 14: This is a SPM operation. Line 15: Line 16: Example outputs: -- To view, visit https://gerrit.ovirt.org/40467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38f9e603a66adbe2655173b8043766f6c04a7913 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add mount windows iso drivers
automat...@ovirt.org has posted comments on this change. Change subject: v2v: add mount windows iso drivers .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d4d19a63dcf338f8d48f8e757d6a35ef92d6d54 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Resize devices on Storage Server Connect
Nir Soffer has posted comments on this change. Change subject: storage: Resize devices on Storage Server Connect .. Patch Set 12: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40864/12//COMMIT_MSG Commit Message: Line 9: While a host was not connected to a storage server, devices may have been Line 10: increased or new devices added. Line 11: Line 12: In order to make sure the host is synced with the devices state, a Line 13: rescan is performed when the host connects to a storage server. a rescan is performed - we refresh storage, rescanning devices and resizing them if needed. Line 14: Line 15: Change-Id: Ia574a59047d2fb5dd3ac7360c2c3a9dde05237ef Line 16: Bug-Url:https://bugzilla.redhat.com/609689 -- To view, visit https://gerrit.ovirt.org/40864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia574a59047d2fb5dd3ac7360c2c3a9dde05237ef Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
