Change in vdsm[master]: vm.py: State saving in hotunplugDisk.
Amit Aviram has posted comments on this change. Change subject: vm.py: State saving in hotunplugDisk. .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/45077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix xfs filesystem is created with wrong inode size
Timothy Asir has posted comments on this change. Change subject: gluster: fix xfs filesystem is created with wrong inode size .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/45299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor v2v jobs for reusability
Shahar Havivi has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 7: Code-Review-1 > the verification is not complete - it is not enough to validate > import of OVA file, but import from vmware should be verified as > well And you need to verify abort and delete job -- To view, visit https://gerrit.ovirt.org/44857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Write multipath.conf atomically
Nir Soffer has posted comments on this change. Change subject: multipath: Write multipath.conf atomically .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/44869/5/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 132 Line 133 Line 134 Line 135 Line 136 > In a follow-up patch, would you please eliminate the sole remaining user of Sure - If you remember, misc.rotateFiles is broken anyway - it does nothing :-) Line 136: delete=False) as f: Line 137: try: Line 138: f.write(_CONF_DATA) Line 139: f.flush() Line 140: os.chmod(f.name, 0o644) > I think we should call a _silent_restorecon after the rename. cp does its o According to cp(1) running without any flags does not modify or preserve selinux labels. I discussed this with Fabian, and we came to the conclusion that we don't have to do anything about selinux context - see https://gerrit.ovirt.org/#/c/44869/3/lib/vdsm/tool/configurators/multipath.py,unified If you believe that cp generate different results then the method suggested here, please suggest way to reproduce this. Do we restore selinux context for other configuration files? (e.g. libvirtd.conf?). Line 141: os.rename(f.name, _CONF_FILE) Line 142: except: Line 143: os.unlink(f.name) Line 144: raise -- To view, visit https://gerrit.ovirt.org/44869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850d621b7cb09f2732b8b3eb2cb2897e87547ddb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add vdsm-hook-emulator
Douglas Schilling Landgraf has posted comments on this change. Change subject: hooks: Add vdsm-hook-emulator .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/45334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f0f5e5947850a3a7fa856ac9919b9155b783d24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add vdsm-hook-emulator
automat...@ovirt.org has posted comments on this change. Change subject: hooks: Add vdsm-hook-emulator .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f0f5e5947850a3a7fa856ac9919b9155b783d24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add vdsm-hook-emulator
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: hooks: Add vdsm-hook-emulator
..
hooks: Add vdsm-hook-emulator
vdsm-hook-emulator has been created to help users change
the default emulator entry from oVirt Engine/VDSM/Libvirt,
in this case, qemu-kvm. After installing this hook the
virtual machines started by oVirt engine will look for
qemu-kvm-modified (script or binary) instead of qemu-kvm.
This approach is useful for cases where qemu-kvm requires
additional flags and needs a wrapper (qemu-kvm-modified)
or even cases where users require to change the emulator.
Change-Id: I6f0f5e5947850a3a7fa856ac9919b9155b783d24
Signed-off-by: Douglas Schilling Landgraf
---
M configure.ac
A debian/vdsm-hook-emulator.docs
A debian/vdsm-hook-emulator.install
M vdsm.spec.in
M vdsm_hooks/Makefile.am
A vdsm_hooks/emulator/Makefile.am
A vdsm_hooks/emulator/before_vm_start.py
7 files changed, 88 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/45334/1
diff --git a/configure.ac b/configure.ac
index ae2b722..a4df66c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -366,6 +366,7 @@
vdsm_hooks/checkimages/Makefile
vdsm_hooks/directlun/Makefile
vdsm_hooks/diskunmap/Makefile
+ vdsm_hooks/emulator/Makefile
vdsm_hooks/ethtool_options/Makefile
vdsm_hooks/extnet/Makefile
vdsm_hooks/fakevmstats/Makefile
diff --git a/debian/vdsm-hook-emulator.docs b/debian/vdsm-hook-emulator.docs
new file mode 100644
index 000..5ecd9c6
--- /dev/null
+++ b/debian/vdsm-hook-emulator.docs
@@ -0,0 +1 @@
+COPYING
diff --git a/debian/vdsm-hook-emulator.install
b/debian/vdsm-hook-emulator.install
new file mode 100644
index 000..c10344f
--- /dev/null
+++ b/debian/vdsm-hook-emulator.install
@@ -0,0 +1 @@
+usr/libexec/vdsm/hooks/before_vm_start/50_emulator
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 9c87915..e02c3b0 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -322,6 +322,15 @@
%description tests
A test suite for verifying the functionality of a running vdsm instance
+%package hook-emulator
+Summary:Replace qemu-kvm emulator entry to qemu-kvm-modified
+Requires: %{name}
+
+%description hook-emulator
+VDSM hook to replace emulator entry from qemu-kvm to qemu-kvm-modified.
+This is useful for act like a wrapper to qemu-kvm or even change in fact
+the emulator.
+
%package hook-allocate_net
Summary:random_network allocation hook for VDSM
Requires: %{name}
@@ -1184,6 +1193,11 @@
%exclude %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_vhostmd
%endif
+%files hook-emulator
+%defattr(-, root, root, -)
+%license COPYING
+%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_emulator
+
%files hook-qemucmdline
%defattr(-, root, root, -)
%license COPYING
diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am
index 7dc9ff2..10cfd53 100644
--- a/vdsm_hooks/Makefile.am
+++ b/vdsm_hooks/Makefile.am
@@ -19,6 +19,7 @@
#
SUBDIRS = \
+ emulator \
ethtool_options \
faqemu \
ipv6 \
diff --git a/vdsm_hooks/emulator/Makefile.am b/vdsm_hooks/emulator/Makefile.am
new file mode 100644
index 000..9f9c173
--- /dev/null
+++ b/vdsm_hooks/emulator/Makefile.am
@@ -0,0 +1,33 @@
+#
+# Copyright 2015 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+# After installing this hook the virtual machines started by oVirt
+# engine will look for qemu-kvm-modified script/binary instead of
+# qemu-kvm. This is useful for act like a wrapper to qemu-kvm
+# or even change in fact the emulator.
+EXTRA_DIST = \
+ before_vm_start.py
+
+install-data-local:
+ $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_vm_start
+ $(INSTALL_SCRIPT) $(srcdir)/before_vm_start.py \
+ $(DESTDIR)$(vdsmhooksdir)/before_vm_start/50_emulator
+
+uninstall-local:
+ $(RM) $(DESTDIR)$(vdsmhooksdir)/before_vm_start/50_emulator
diff --git a/vdsm_hooks/emulator/before_vm_start.py
b/vdsm_hooks/emulator/before_vm_start.py
new file mode 100755
index 000..ea5977b
--- /dev/null
+++ b/vdsm_hooks/emulator/before_vm_start.py
@@ -0,0 +1,37 @@
+#
+# Copyright 2015 Re
Change in vdsm[master]: hooks: Add vdsm-hook-emulator
automat...@ovirt.org has posted comments on this change. Change subject: hooks: Add vdsm-hook-emulator .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f0f5e5947850a3a7fa856ac9919b9155b783d24 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Skip hosted engine stats processing when it is not configured
Hello Sandro Bonazzola, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/45333 to review the following change. Change subject: Skip hosted engine stats processing when it is not configured .. Skip hosted engine stats processing when it is not configured This changes the data collecting to ignore hosted engine when the host id is reported as None or 0. Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248539 Signed-off-by: Martin Sivak Reviewed-on: https://gerrit.ovirt.org/44354 Continuous-Integration: Jenkins CI Reviewed-by: Sandro Bonazzola Reviewed-by: Dan Kenigsberg --- M vdsm/API.py M vdsm/logger.conf.in 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/45333/1 diff --git a/vdsm/API.py b/vdsm/API.py index 36fafe2..4c9f90c 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -1697,8 +1697,12 @@ try: instance = haClient.HAClient() host_id = instance.get_local_host_id() + # If a host id is available, consider HA configured -i['configured'] = True +if host_id: +i['configured'] = True +else: +return i stats = instance.get_all_stats() if 0 in stats: diff --git a/vdsm/logger.conf.in b/vdsm/logger.conf.in index f75c010..9f2a971 100644 --- a/vdsm/logger.conf.in +++ b/vdsm/logger.conf.in @@ -1,5 +1,5 @@ [loggers] -keys=root,vds,Storage,ovirt_hosted_engine_ha,IOProcess,connectivity +keys=root,vds,Storage,ovirt_hosted_engine_ha,ovirt_hosted_engine_ha_config,IOProcess,connectivity [handlers] keys=console,syslog,logfile,connlogfile @@ -30,6 +30,12 @@ qualname=ovirt_hosted_engine_ha propagate=1 +[logger_ovirt_hosted_engine_ha_config] +level=ERROR +handlers= +qualname=ovirt_hosted_engine_ha.env.config +propagate=0 + [logger_IOProcess] level=INFO handlers=logfile -- To view, visit https://gerrit.ovirt.org/45333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sandro Bonazzola ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Skip hosted engine stats processing when it is not configured
automat...@ovirt.org has posted comments on this change. Change subject: Skip hosted engine stats processing when it is not configured .. Patch Set 1: * Update tracker::#1248539::OK * Check Bug-Url::OK * Check Public Bug::#1248539::OK, public bug * Check Product::#1248539::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1248539::ERROR, wrong target release for stable branch, 3.6.0 should match ^3.[54321].* * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/45333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Limit sleep_millisecs to minimum 10
automat...@ovirt.org has posted comments on this change. Change subject: Limit sleep_millisecs to minimum 10 .. Patch Set 2: * Update tracker::#1256949::OK * Check Bug-Url::OK * Check Public Bug::#1256949::OK, public bug * Check Product::#1256949::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7412ca576089f1dae2441ec39f72e7a94b3c8fc9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Limit sleep_millisecs to minimum 10
automat...@ovirt.org has posted comments on this change. Change subject: Limit sleep_millisecs to minimum 10 .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7412ca576089f1dae2441ec39f72e7a94b3c8fc9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Limit sleep_millisecs to minimum 10
Amador Pahim has uploaded a new change for review.
Change subject: Limit sleep_millisecs to minimum 10
..
Limit sleep_millisecs to minimum 10
According to the former KSM controller, ksmtuned, 10 should be the
minimum value for sleep_millisecs:
48 sleep=$[KSM_SLEEP_MSEC * 16 * 1024 * 1024 / total]
49 [ $sleep -le 10 ] && sleep=10 < 10 is the minimum
50 debug sleep $sleep
Systems with a low sleep_millisecs number will run ksmd daemon without
interruption, causing a very high cpu time consumption.
This patch limits sleep_millisecs to the minimum of 10.
Change-Id: I7412ca576089f1dae2441ec39f72e7a94b3c8fc9
Signed-off-by: Amador Pahim
---
M vdsm/mom.d/03-ksm.policy
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/45332/1
diff --git a/vdsm/mom.d/03-ksm.policy b/vdsm/mom.d/03-ksm.policy
index eaa4aae..0b93245 100644
--- a/vdsm/mom.d/03-ksm.policy
+++ b/vdsm/mom.d/03-ksm.policy
@@ -106,7 +106,7 @@
{# else
(Host.Control "ksm_run" 1)
(Host.Control "ksm_sleep_millisecs"
-(/ (* ksm_sleep_ms_baseline 16777216) Host.mem_available))
+(max 10(/ (* ksm_sleep_ms_baseline 16777216) Host.mem_available)))
(if (< (Host.StatAvg "mem_free") ksm_pressure_threshold)
(change_npages ksm_pages_boost)
(change_npages ksm_pages_decay))
--
To view, visit https://gerrit.ovirt.org/45332
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7412ca576089f1dae2441ec39f72e7a94b3c8fc9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: make: unbreak pyflakes test
automat...@ovirt.org has posted comments on this change. Change subject: make: unbreak pyflakes test .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/45297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff48b8f1890b98711ae12a48680377ee22d9de63 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: make: unbreak pyflakes test
Dan Kenigsberg has posted comments on this change. Change subject: make: unbreak pyflakes test .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff48b8f1890b98711ae12a48680377ee22d9de63 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: make: unbreak pyflakes test
Dan Kenigsberg has submitted this change and it was merged. Change subject: make: unbreak pyflakes test .. make: unbreak pyflakes test Much like pep8 which was fixed in https://gerrit.ovirt.org/44416 pyflakes test, too, was inadvertently broken by https://gerrit.ovirt.org/43845. This patch reverts another bit of that message, while fixing some pyflakes damage accumulated since its introduction. Change-Id: Iff48b8f1890b98711ae12a48680377ee22d9de63 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/45254 Continuous-Integration: Jenkins CI Reviewed-by: Yeela Kaplan Reviewed-by: Piotr Kliczewski Reviewed-on: https://gerrit.ovirt.org/45297 --- M Makefile.am M tests/tcTests.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff48b8f1890b98711ae12a48680377ee22d9de63 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: make: unbreak pyflakes test
Dan Kenigsberg has posted comments on this change. Change subject: make: unbreak pyflakes test .. Patch Set 3: Verified+1 passed CI -- To view, visit https://gerrit.ovirt.org/45297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff48b8f1890b98711ae12a48680377ee22d9de63 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: make: unbreak pyflakes test
automat...@ovirt.org has posted comments on this change. Change subject: make: unbreak pyflakes test .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff48b8f1890b98711ae12a48680377ee22d9de63 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: make: unbreak pyflakes test
automat...@ovirt.org has posted comments on this change. Change subject: make: unbreak pyflakes test .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff48b8f1890b98711ae12a48680377ee22d9de63 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Try to be nicer to other processes
Dan Kenigsberg has posted comments on this change. Change subject: v2v: Try to be nicer to other processes .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id163844a5976384ca9e9a75d58a581645f08a89f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Write multipath.conf atomically
Dan Kenigsberg has posted comments on this change. Change subject: multipath: Write multipath.conf atomically .. Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/44869/5/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 136: In a follow-up patch, would you please eliminate the sole remaining user of EXT_CP (in misc.rotateFiles). Its only user was the now-defunct in-vdsm editing of multipath.conf. https://bugzilla.redhat.com/show_bug.cgi?id=527442 Line 136: delete=False) as f: Line 137: try: Line 138: f.write(_CONF_DATA) Line 139: f.flush() Line 140: os.chmod(f.name, 0o644) I think we should call a _silent_restorecon after the rename. cp does its own magic; if it did not do the right thing - we should make sure that the context of the new file is as expected by the effective policy. Line 141: os.rename(f.name, _CONF_FILE) Line 142: except: Line 143: os.unlink(f.name) Line 144: raise -- To view, visit https://gerrit.ovirt.org/44869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850d621b7cb09f2732b8b3eb2cb2897e87547ddb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: Move clusterLock into Manifest
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: Move clusterLock into Manifest .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c019a7fed6ba793d2b3a2459af221b1abbff2a3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: Move validateCreateVolumeParams
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: Move validateCreateVolumeParams .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib971bd6a2edf278445f6fbb9274e6272220f989f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: simplify hasVolumeLeases
automat...@ovirt.org has posted comments on this change. Change subject: storage: simplify hasVolumeLeases .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf0c1cf341e7d028b5d4e30a27e9a045b43470e4 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "tests: functional - convert to run over jsonrpc"
automat...@ovirt.org has posted comments on this change. Change subject: Revert "tests: functional - convert to run over jsonrpc" .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib45fbaa84e25e3c72aa09bfa78c16dd700e6e957 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: before_network_rollback, after_network_rollback
Petr Horáček has posted comments on this change. Change subject: hook: before_network_rollback, after_network_rollback .. Patch Set 4: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/45085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ifcfg: report unsuccessful rollback
Petr Horáček has posted comments on this change. Change subject: net: ifcfg: report unsuccessful rollback .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/45239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia490647b6d4c79f86439147f2640ace0c49fffe2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: iproute2, pyroute2: implement rollback
Petr Horáček has posted comments on this change. Change subject: net: iproute2, pyroute2: implement rollback .. Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/45238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ba8cd7bb1356063abc0df24e65810dbb9235dcd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: executor based thread factory
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py: Line 37:workers_count=_THREADS, Line 38:max_tasks=_TASKS, Line 39:scheduler=scheduler) Line 40: Line 41: self._server = JsonRpcServer(bridge, timeout, self._executor.dispatch) > Do we have a test for this? if not, maybe add it in this patch? Will add. Line 42: self._reactor = StompReactor(subs) Line 43: self.startReactor() Line 44: Line 45: def add_socket(self, reactor, client_socket): -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Replace specific device sections with all_devs se...
Nir Soffer has posted comments on this change. Change subject: multipath: Replace specific device sections with all_devs section .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/44855/1/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 72 Line 73 Line 74 Line 75 Line 76 > So it seems like we are knowingly adding one regression to fix another. No I discussed this with Allon, we don't want to waste time supporting old Fedora versions. If you are on Fedora, you must run the latest version for best support. We have similar issues with iscsi fix in the kernel (available in rhel 7.2, not yet in fedora), and multipath fix for iscsi devices (available in rhel 7.2, not yet in fedora). -- To view, visit https://gerrit.ovirt.org/44855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If035b10558f8df37969ee694bfebd48068d2ee38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Replace specific device sections with all_devs se...
Adam Litke has posted comments on this change. Change subject: multipath: Replace specific device sections with all_devs section .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/44855/1/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 72 Line 73 Line 74 Line 75 Line 76 > Not yet. In the worst case, we on fedora 21 a user using VNX storage will h So it seems like we are knowingly adding one regression to fix another. Not sure if this is a good idea. -- To view, visit https://gerrit.ovirt.org/44855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If035b10558f8df37969ee694bfebd48068d2ee38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor v2v jobs for reusability
Adam Litke has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 7: Arik, would you be kind enough to test this for me? I do not have a vmware environment. -- To view, visit https://gerrit.ovirt.org/44857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor v2v jobs for reusability
Arik Hadas has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 7: Code-Review-1 the verification is not complete - it is not enough to validate import of OVA file, but import from vmware should be verified as well -- To view, visit https://gerrit.ovirt.org/44857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: executor based thread factory
Nir Soffer has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py: Line 37:workers_count=_THREADS, Line 38:max_tasks=_TASKS, Line 39:scheduler=scheduler) Line 40: Line 41: self._server = JsonRpcServer(bridge, timeout, self._executor.dispatch) > It will send it back to the client containing all the information provided. Do we have a test for this? if not, maybe add it in this patch? Line 42: self._reactor = StompReactor(subs) Line 43: self.startReactor() Line 44: Line 45: def add_socket(self, reactor, client_socket): -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fail create NFS domain with correct exception upon ENOSPC
Nir Soffer has posted comments on this change. Change subject: Fail create NFS domain with correct exception upon ENOSPC .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/45302/2/vdsm/storage/nfsSD.py File vdsm/storage/nfsSD.py: Line 84: cls._prepareMetadata(domainDir, sdUUID, domainName, domClass, Line 85: remotePath, storageType, version) Line 86: except OSError as e: Line 87: if e.errno == errno.ENOSPC: Line 88: raise se.StorageServerNoSpaceLeftError You hide all other errors Lets do it like this - first raise any error you cannot handle, then handle what you can. And, when you raise, include the original error, so we can see it in the log. except OSError as e: if e.errno != ENOSPC: raise raise se.StorageServerNoSpaceLeftError(e) I'm also not sure this is the right place to handle this error. What if there was enough space to prepare the meta data, but not for initializing the spm lease (see line 100). Better handle this in a higher level, so any ENOSPC error will be reported correctly in the engine side. Line 89: Line 90: # create domain images folder Line 91: imagesDir = os.path.join(domainDir, sd.DOMAIN_IMAGES) Line 92: oop.getProcessPool(sdUUID).fileUtils.createdir(imagesDir) https://gerrit.ovirt.org/#/c/45302/2/vdsm/storage/storage_exception.py File vdsm/storage/storage_exception.py: Line 1203: def __init__(self, replicaCount): Line 1204: self.value = "replica count = %s" % replicaCount Line 1205: Line 1206: Line 1207: class StorageServerNoSpaceLeftError(StorageException): > The StorageServer prefix does not help, lets remove it: Also, it nice to include some context from the original error. Lets do this: class NoSpaceLeftError(StorageException): code = ... message = ... def __init__(self, error): self.value = "%s: %s" % (self.message, error) This will show error when we log this exception. Line 1208: message = "No space left on path" Line 1209: code = 481 Line 1210: Line 1211: -- To view, visit https://gerrit.ovirt.org/45302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf0342687668ee0c9339df17f017315acd72b1b9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fail create NFS domain with correct exception upon ENOSPC
Nir Soffer has posted comments on this change. Change subject: Fail create NFS domain with correct exception upon ENOSPC .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/45302/2/vdsm/storage/storage_exception.py File vdsm/storage/storage_exception.py: Line 1203: def __init__(self, replicaCount): Line 1204: self.value = "replica count = %s" % replicaCount Line 1205: Line 1206: Line 1207: class StorageServerNoSpaceLeftError(StorageException): The StorageServer prefix does not help, lets remove it: NoSpaceLeftError Is much nicer, and can be used in other context. Line 1208: message = "No space left on path" Line 1209: code = 481 Line 1210: Line 1211: -- To view, visit https://gerrit.ovirt.org/45302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf0342687668ee0c9339df17f017315acd72b1b9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: executor based thread factory
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py: Line 37:workers_count=_THREADS, Line 38:max_tasks=_TASKS, Line 39:scheduler=scheduler) Line 40: Line 41: self._server = JsonRpcServer(bridge, timeout, self._executor.dispatch) > dispatch may raise executor.TooManyTasks - is JsonRpcServer handling this e It will send it back to the client containing all the information provided. It is up to the client to decide what to do with it. Line 42: self._reactor = StompReactor(subs) Line 43: self.startReactor() Line 44: Line 45: def add_socket(self, reactor, client_socket): -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: scheduler: use single instance
Piotr Kliczewski has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43825/5/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Line 58 Line 59 Line 60 Line 61 Line 62 > Add: Done -- To view, visit https://gerrit.ovirt.org/43825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: generalize udevTrigger method
Nir Soffer has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/44767/7/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 281
Line 282
Line 283
Line 284
Line 285
Rename to udevTriggerMultipath, call _udevTrigger with the correct
property_match
Line 281: def setSafeNetworkConfig(self):
Line 282: return setSafeNetworkConfig()
Line 283:
Line 284: @logDecorator
Line 285: def udevTrigger(self, attr_matches=(), property_matches=()):
Rename to _udevTrigger
Line 286: '''
Line 287: Request device events from the kernel.
Line 288:
Line 289: Arguments:
Line 372: with open(rule_file, "w") as rf:
Line 373: self.log.debug("Creating rule %s: %r", rule_file,
rule)
Line 374: rf.write(rule)
Line 375:
Line 376: self.udevTrigger()
Call _udevTrigger
Line 377:
Line 378: @logDecorator
Line 379: def rmAppropriateIommuGroup(self, iommu_group):
Line 380: """
Line 399: else:
Line 400: self.log.debug("Removing rule %s", rule_file)
Line 401:
Line 402: if not error:
Line 403: self.udevTrigger()
Call _udevTrigger
Line 404:
Line 405: @logDecorator
Line 406: def ksmTune(self, tuningParams):
Line 407: '''
--
To view, visit https://gerrit.ovirt.org/44767
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: generalize udevTrigger method
Nir Soffer has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method .. Patch Set 7: Matin, I don't think it is a good idea to merge patches which we do not want to have. The only changes needed are: - Add udevTriggerMultipath with the same api we had before this patch - Rename udevTrigger to _udevTrigger -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: executor based thread factory
Nir Soffer has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 7: Code-Review-1 (1 comment) -1 for visibility https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py: Line 37:workers_count=_THREADS, Line 38:max_tasks=_TASKS, Line 39:scheduler=scheduler) Line 40: Line 41: self._server = JsonRpcServer(bridge, timeout, self._executor.dispatch) dispatch may raise executor.TooManyTasks - is JsonRpcServer handling this exception correctly? Line 42: self._reactor = StompReactor(subs) Line 43: self.startReactor() Line 44: Line 45: def add_socket(self, reactor, client_socket): -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: generalize udevTrigger method
Martin Polednik has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method .. Patch Set 7: Can we keep it general for this patch and do specialization after moving? -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: scheduler: use single instance
Nir Soffer has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43825/5/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Line 58 Line 59 Line 60 Line 61 Line 62 Add: global _executor Otherwise the next line create a new local variable, and we never stop the executor. -- To view, visit https://gerrit.ovirt.org/43825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
Nir Soffer has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/42471/4/vdsm.spec.in
File vdsm.spec.in:
Line 156: Requires: %{name}-jsonrpc = %{version}-%{release}
Line 157: Requires: safelease >= 1.0-5
Line 158: Requires: mom >= 0.4.5
Line 159:
Line 160: %ifnarch ppc64le
> I think it should be then: %ifnarch ppc ppc64 ppc64le
Thanks, this seems to be the correct syntax.
Line 161: Requires: ceph-common
Line 162: %endif
Line 163:
Line 164: %if 0%{?rhel}
--
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Eyal Edri
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sagi Shnaidman
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Remove substitutions from dumpStorageTable
Douglas Schilling Landgraf has posted comments on this change. Change subject: core: Remove substitutions from dumpStorageTable .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id041a7caefe00ae85443cc1350506d0a75932028 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: conflict with plain QEMU
automat...@ovirt.org has posted comments on this change. Change subject: spec: conflict with plain QEMU .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0cbc400f2a6711bc014d67931a4136c871bdd46 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: generalize udevTrigger method
Nir Soffer has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method .. Patch Set 7: Code-Review-1 I talked with Dan about this, and we agreed that having a specific verbs is better. -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: conflict with plain QEMU
Francesco Romani has uploaded a new change for review.
Change subject: spec: conflict with plain QEMU
..
spec: conflict with plain QEMU
The only stack supported by VDSM is
VDSM - libvirt - qemu-kvm{ev,rhev}
Multiple qemu versions are not supported, yet some
users managed to install them.
This triggers a bug in the caps.getEmulatedMachines()
function.
We will improve that function in a future patch to
make it more robust, but first we should enforce
the recommended configuration.
NOTE: this patch is relevant for RPM systems only,
where there is distinction between qemu and qemu-kvm.
Debian-based system do not have this split, so
the misconfiguration is not possible.
https://bugzilla.redhat.com/1239258
Change-Id: Ib0cbc400f2a6711bc014d67931a4136c871bdd46
Signed-off-by: Francesco Romani
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/45323/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 72e7df6..777b832 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -210,6 +210,7 @@
Requires: qemu-kvm >= 2:2.0.0-1
Requires: qemu-img >= 2:2.0.0-1
%endif # rhel
+Conflicts: qemu
# GlusterFS client-side RPMs needed for Gluster SD
%if 0%{?with_gluster}
--
To view, visit https://gerrit.ovirt.org/45323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0cbc400f2a6711bc014d67931a4136c871bdd46
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: more precise emulated machines selection
automat...@ovirt.org has posted comments on this change. Change subject: caps: more precise emulated machines selection .. Patch Set 5: * Update tracker::#1239258::OK * Check Bug-Url::OK * Check Public Bug::#1239258::OK, public bug * Check Product::#1239258::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: split vm operation tests
Francesco Romani has posted comments on this change. Change subject: tests: split vm operation tests .. Patch Set 6: Verified+1 verified again with make check. -- To view, visit https://gerrit.ovirt.org/45064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe9e10e8791d0db850a7bdc365327f35b27896e6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add and use vm.acpiReboot() method
Francesco Romani has posted comments on this change. Change subject: virt: add and use vm.acpiReboot() method .. Patch Set 7: Verified+1 the changes since last verification are covered by tests. V+1 again. -- To view, visit https://gerrit.ovirt.org/44923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d6dd3a81cd4ad981a839849a4a2914e35a53fa6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: split vm operation tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: split vm operation tests .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe9e10e8791d0db850a7bdc365327f35b27896e6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make acpiShutdown handle NotConnectedError
Francesco Romani has posted comments on this change. Change subject: vm: make acpiShutdown handle NotConnectedError .. Patch Set 9: Verified+1 the changes since last verification are covered by tests. Hence V+1 again. -- To view, visit https://gerrit.ovirt.org/34879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244f00d62ee24fb42ba3d654961a8fc22f4a6c25 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add and use vm.acpiReboot() method
automat...@ovirt.org has posted comments on this change. Change subject: virt: add and use vm.acpiReboot() method .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d6dd3a81cd4ad981a839849a4a2914e35a53fa6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make acpiShutdown handle NotConnectedError
automat...@ovirt.org has posted comments on this change. Change subject: vm: make acpiShutdown handle NotConnectedError .. Patch Set 9: * Update tracker::#1154389::OK * Check Bug-Url::OK * Check Public Bug::#1154389::OK, public bug * Check Product::#1154389::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/34879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244f00d62ee24fb42ba3d654961a8fc22f4a6c25 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: split vm operation tests.
automat...@ovirt.org has posted comments on this change. Change subject: tests: split vm operation tests. .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe9e10e8791d0db850a7bdc365327f35b27896e6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "supervdsm: Decorator for supervdsm proxied calls."
Dima Kuznetsov has posted comments on this change. Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls." .. Patch Set 1: I think the ease of use is not a vice. It faces only the developer of the function, and not the user, and allows you keep all the code related to some topic in the same place (vs another method in supervsdmServer). IMO it's irrelevant for whoever uses a specific function, to know whether it should be called through supervdsm proxy or otherwise. One such example is reading hardware info, you care about getting the system data, implementation details (such that dmidecode requires privileges) should be part of the concerns. And I'd trust whoever writes the module to tag only the relevant parts for supervdsm invocation. -- To view, visit https://gerrit.ovirt.org/45316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f83b4a8820f3fef437641329ba514742434dab4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: scheduler: use single instance
automat...@ovirt.org has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: executor based thread factory
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: scheduler: use single instance
Piotr Kliczewski has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 5: Verified+1 Fixed pyflakes issue and the build was rerun. Copying verify flag from previous patch set. -- To view, visit https://gerrit.ovirt.org/43825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "supervdsm: Decorator for supervdsm proxied calls."
automat...@ovirt.org has posted comments on this change. Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls." .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f83b4a8820f3fef437641329ba514742434dab4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: allow to mock monotonic_time method
Piotr Kliczewski has posted comments on this change. Change subject: stomp: allow to mock monotonic_time method .. Patch Set 2: Verified+1 Verified by running vdsm build -- To view, visit https://gerrit.ovirt.org/43745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59b65b12ddbcc547dc2bf45bf4dc3742a7778dea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: StompAdapter test suite
Piotr Kliczewski has posted comments on this change. Change subject: tests: StompAdapter test suite .. Patch Set 6: Verified+1 Verified by running vdsm build -- To view, visit https://gerrit.ovirt.org/43342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic22a8ec43413431ff57ecf66da62e065c534bac7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: JsonRpcServer tests suite
automat...@ovirt.org has posted comments on this change. Change subject: tests: JsonRpcServer tests suite .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1090764c7289544abe331a13ec765ceed2a53afe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: make sure to send error message when no subscription
Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure to send error message when no subscription .. Patch Set 3: Verified+1 Verified by running vdsm build -- To view, visit https://gerrit.ovirt.org/43724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1880caa04bb5e506679da046a58491d3e29e10e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: make sure to send error message when no subscription
automat...@ovirt.org has posted comments on this change. Change subject: stomp: make sure to send error message when no subscription .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1880caa04bb5e506679da046a58491d3e29e10e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: AsyncDispatcher tests suite
Piotr Kliczewski has posted comments on this change. Change subject: tests: AsyncDispatcher tests suite .. Patch Set 4: Verified+1 Verified by running vdsm build -- To view, visit https://gerrit.ovirt.org/43394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18a58d1d8ffe4f8ea2cd8dec9bb2e508c73c7f8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: ignore unknown message id
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: ignore unknown message id .. Patch Set 2: Verified+1 Verified by running vdsm build -- To view, visit https://gerrit.ovirt.org/43746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: JsonRpcClient tests suite
automat...@ovirt.org has posted comments on this change. Change subject: tests: JsonRpcClient tests suite .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48c209915f4047958fd9b7e5dd6a202ca14a50cb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: AsyncClient test suite
Piotr Kliczewski has posted comments on this change. Change subject: tests: AsyncClient test suite .. Patch Set 4: Verified+1 Verified by running vdsm build -- To view, visit https://gerrit.ovirt.org/43393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie102948c2bb7ff964586701b9b81b2867f7ba840 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: AsyncDispatcher tests suite
automat...@ovirt.org has posted comments on this change. Change subject: tests: AsyncDispatcher tests suite .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18a58d1d8ffe4f8ea2cd8dec9bb2e508c73c7f8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "supervdsm: Decorator for supervdsm proxied calls."
Nir Soffer has posted comments on this change. Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls." .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f83b4a8820f3fef437641329ba514742434dab4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: send unsubscribed frame only if there was subscription
automat...@ovirt.org has posted comments on this change. Change subject: stomp: send unsubscribed frame only if there was subscription .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8789b84d131e5551b7383e61e6b71c6da0a512fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: ignore unknown message id
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: ignore unknown message id .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: allow to mock monotonic_time method
automat...@ovirt.org has posted comments on this change. Change subject: stomp: allow to mock monotonic_time method .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59b65b12ddbcc547dc2bf45bf4dc3742a7778dea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: StompAdapter test suite
automat...@ovirt.org has posted comments on this change. Change subject: tests: StompAdapter test suite .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic22a8ec43413431ff57ecf66da62e065c534bac7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: AsyncClient test suite
automat...@ovirt.org has posted comments on this change. Change subject: tests: AsyncClient test suite .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie102948c2bb7ff964586701b9b81b2867f7ba840 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor v2v jobs for reusability
Nir Soffer has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 7: Code-Review+1 Looks even better now with the missing apis :-) -- To view, visit https://gerrit.ovirt.org/44857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "supervdsm: Decorator for supervdsm proxied calls."
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls."
..
Revert "supervdsm: Decorator for supervdsm proxied calls."
I've merged commit 9fad76d2075f315ebe48212508fe9b677d74dfc8
prematurely, before proper discussion about its merits and
disadvantages.
One disadvantage is the relative ease of decorating a
function and then, implicitly, having it run as root in all
contexts.
Change-Id: I1f83b4a8820f3fef437641329ba514742434dab4
Signed-off-by: Dan Kenigsberg
---
M lib/vdsm/supervdsm.py
M tests/functional/supervdsmFuncTests.py
M vdsm/supervdsmServer
3 files changed, 9 insertions(+), 77 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/45316/1
diff --git a/lib/vdsm/supervdsm.py b/lib/vdsm/supervdsm.py
index 018734f..8e42af2 100644
--- a/lib/vdsm/supervdsm.py
+++ b/lib/vdsm/supervdsm.py
@@ -19,7 +19,6 @@
# Refer to the README and COPYING files for full details of the license
#
-import functools
import os
from multiprocessing.managers import BaseManager, RemoteError
import logging
@@ -94,20 +93,3 @@
if _g_singletonSupervdsmInstance is None:
_g_singletonSupervdsmInstance = SuperVdsmProxy()
return _g_singletonSupervdsmInstance
-
-
-def proxied_call(func):
-func.allow_supervdsm_invocation = True
-
-@functools.wraps(func)
-def wrapper(*args, **kwargs):
-if os.geteuid() == 0:
-return func(*args, **kwargs)
-else:
-return getProxy().proxied_call(
-func.__module__,
-func.func_name,
-args,
-kwargs
-)
-return wrapper
diff --git a/tests/functional/supervdsmFuncTests.py
b/tests/functional/supervdsmFuncTests.py
index af15433..93e7c54 100644
--- a/tests/functional/supervdsmFuncTests.py
+++ b/tests/functional/supervdsmFuncTests.py
@@ -17,45 +17,23 @@
# Refer to the README and COPYING files for full details of the license
#
from testlib import VdsmTestCase as TestCaseBase
-import monkeypatch
-from vdsm import hwinfo
+import testValidation
from vdsm import supervdsm
-from vdsm import utils
from vdsm.constants import VDSM_USER
from pwd import getpwnam
import os
-_test_list = []
+class TestSuperVdsmRemotly(TestCaseBase):
-@supervdsm.proxied_call
-def foo(arg):
-_test_list.append(arg)
+def dropPrivileges(self):
+vdsm_uid, vdsm_gid = getpwnam(VDSM_USER)[2:4:]
+os.setgroups([])
+os.setgid(vdsm_gid)
+os.setuid(vdsm_uid)
-
-def dropPrivileges():
-vdsm_uid, vdsm_gid = getpwnam(VDSM_USER)[2:4:]
-os.setgroups([])
-os.setgid(vdsm_gid)
-os.setuid(vdsm_uid)
-dropPrivileges()
-
-
-class TestSuperVdsmRemotely(TestCaseBase):
+@testValidation.ValidateRunningAsRoot
def testPingCall(self):
+self.dropPrivileges()
proxy = supervdsm.getProxy()
self.assertTrue(proxy.ping())
-
-@monkeypatch.MonkeyPatch(os, 'geteuid', lambda: 0)
-def test_proxied_call_run_as_root(self):
-o = object()
-foo(o)
-self.assertIn(o, _test_list)
-
-def test_proxied_call_fails_on_unknown_function(self):
-with self.assertRaises(ImportError):
-foo()
-
-def test_proxied_call_non_decorated_function(self):
-with self.assertRaises(RuntimeError):
-supervdsm.proxied_call(utils.tobool)(None)
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 41d5590..e836368 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -18,7 +18,6 @@
# Refer to the README and COPYING files for full details of the license
#
from pwd import getpwnam
-import importlib
import platform
import sys
import os
@@ -474,33 +473,6 @@
def __udevOperationReload(self):
return self.__udevVersion() > self.UDEV_WITH_RELOAD_VERSION
-
-def proxied_call(self, mod_name, func_name, args, kwargs):
-self.log.debug(
-'proxied call of %s.%s with %s, %s',
-mod_name,
-func_name,
-args,
-kwargs,
-)
-
-if mod_name not in sys.modules:
-self.log.debug('importing module %s', mod_name)
-importlib.import_module(mod_name)
-
-mod = sys.modules.get(mod_name)
-func = getattr(mod, func_name)
-if not getattr(func, 'allow_supervdsm_invocation', False):
-raise RuntimeError('This function cannot be called by supervdsm')
-
-try:
-ret = func(*args, **kwargs)
-except:
-self.log.exception('error in %s.%s', mod_name, func_name)
-raise
-
-self.log.debug('%s.%s returned with %s', mod_name, func_name, ret)
-return ret
def terminate(signo, frame):
--
To view, visit https://gerrit.ovirt.org/45316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Change in vdsm[master]: Revert "supervdsm: Decorator for supervdsm proxied calls."
Dan Kenigsberg has reverted this change. Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls." .. Patch Set 7: Reverted This patchset was reverted in change: I1f83b4a8820f3fef437641329ba514742434dab4 -- To view, visit https://gerrit.ovirt.org/45316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: revert Gerrit-Change-Id: I1f83b4a8820f3fef437641329ba514742434dab4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Libvirt quering after disk detach operation addition.
Nir Soffer has posted comments on this change. Change subject: vm: Libvirt quering after disk detach operation addition. .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45138/1//COMMIT_MSG Commit Message: Line 6: Line 7: vm: Libvirt quering after disk detach operation addition. Line 8: Line 9: As stated in libvirt documentary, after detaching a device using the API Line 10: we need to verify that this device has actually been detached. > After talking to Eric Blake these are the conclusions: If libvirt crash or restart, vdsm will panic and the operation will fail in the engine side. This is not a reason to use polling. We should check how easy is to use the libvirt event. In any case, we should check the state of the vm when getting the event, or on timeout. Line 11: Line 12: Not doing so can cause various problems, as hotunplugDisk could return a Line 13: success result while it did not actually succeeds to detach the disk. Line 14: -- To view, visit https://gerrit.ovirt.org/45138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor v2v jobs for reusability
Nir Soffer has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 7: Adam, when CI fail, you can visit the build url and click "Retrigger" to run the failed job again. If this was just a random failure, the next build will succeed and +1 your patch. -- To view, visit https://gerrit.ovirt.org/44857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Remove substitutions from dumpStorageTable
automat...@ovirt.org has posted comments on this change. Change subject: core: Remove substitutions from dumpStorageTable .. Patch Set 3: * Update tracker::#1098179::OK * Check Bug-Url::OK * Check Public Bug::#1098179::OK, public bug * Check Product::#1098179::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id041a7caefe00ae85443cc1350506d0a75932028 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Replace specific device sections with all_devs se...
Nir Soffer has posted comments on this change. Change subject: multipath: Replace specific device sections with all_devs section .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/44855/1/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 72 Line 73 Line 74 Line 75 Line 76 > Has the Fedora 21 support issue been resolved yet? Seems the bug is still Not yet. In the worst case, we on fedora 21 a user using VNX storage will have to add specific device setting like the one we had here. -- To view, visit https://gerrit.ovirt.org/44855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If035b10558f8df37969ee694bfebd48068d2ee38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: storage: validate vdsm rwx permissions for file storage
automat...@ovirt.org has posted comments on this change. Change subject: storage: validate vdsm rwx permissions for file storage .. Patch Set 3: * Update tracker::#1250752::OK * Check TR::#1250752::OK * Set MODIFIED::bug 1250752#1250752OK -- To view, visit https://gerrit.ovirt.org/45271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: storage: validate vdsm rwx permissions for file storage
Francesco Romani has submitted this change and it was merged. Change subject: storage: validate vdsm rwx permissions for file storage .. storage: validate vdsm rwx permissions for file storage VDSM needs permission to write to file-based storage. Presumably the existing check for qemu permissions or a subsequent failure would throw an error; however, these errors were not always clear nor did they help the user (e.g. a general Error 100, such as in the referenced bug). With an explicit check, we can ensure the failure happens up-front and gives a meaningful error message to the user. Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372 Bug-Url: https://bugzilla.redhat.com/1250752 Signed-off-by: Greg Padgett Reviewed-on: https://gerrit.ovirt.org/2 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/45271 Reviewed-by: Allon Mureinik Reviewed-by: Francesco Romani --- M vdsm/storage/fileSD.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: storage: validate vdsm rwx permissions for file storage
Francesco Romani has posted comments on this change. Change subject: storage: validate vdsm rwx permissions for file storage .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: storage: validate vdsm rwx permissions for file storage
automat...@ovirt.org has posted comments on this change. Change subject: storage: validate vdsm rwx permissions for file storage .. Patch Set 2: * Update tracker::#1250752::OK * Check Bug-Url::OK * Check Public Bug::#1250752::OK, public bug * Check Product::#1250752::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: storage: validate vdsm rwx permissions for file storage
Francesco Romani has posted comments on this change. Change subject: storage: validate vdsm rwx permissions for file storage .. Patch Set 1: Continuous-Integration+1 make check run locally with no issue, overriding jenkins score. -- To view, visit https://gerrit.ovirt.org/45271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Libvirt quering after disk detach operation addition.
Amit Aviram has posted comments on this change. Change subject: vm: Libvirt quering after disk detach operation addition. .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45138/1//COMMIT_MSG Commit Message: Line 6: Line 7: vm: Libvirt quering after disk detach operation addition. Line 8: Line 9: As stated in libvirt documentary, after detaching a device using the API Line 10: we need to verify that this device has actually been detached. > But note that we are using virDomainDetachDevice and not virDomainDetachDev After talking to Eric Blake these are the conclusions: 1. Polling XMLDesc may be uglier and less efficient, but it is still preferred as libvirt can get restarted and lose the event. 2. virDomainDetachDevice acts like virDomainDetachDeviceFlags in that matter. so this change is relevant to us. actually, a "success" returned by it only states that the request to detach had only been sent successfully to the guest. Line 11: Line 12: Not doing so can cause various problems, as hotunplugDisk could return a Line 13: success result while it did not actually succeeds to detach the disk. Line 14: -- To view, visit https://gerrit.ovirt.org/45138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "tests: functional - convert to run over jsonrpc"
Ondřej Svoboda has posted comments on this change. Change subject: Revert "tests: functional - convert to run over jsonrpc" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib45fbaa84e25e3c72aa09bfa78c16dd700e6e957 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor v2v jobs for reusability
Adam Litke has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 7: Oh how I love false CI failures :) -- To view, visit https://gerrit.ovirt.org/44857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rpc.Bridge: sanitize optional, positional argument names
Piotr Kliczewski has posted comments on this change. Change subject: rpc.Bridge: sanitize optional, positional argument names .. Patch Set 5: Please take a look at integration.jsonRpcTest#testMethodCallArgDict I think this is something that you look for. -- To view, visit https://gerrit.ovirt.org/45274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic23ca1d06a394c73ae746e123209375ceb90243c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virtTests: add way to query full stats via jsonrpc
Yeela Kaplan has posted comments on this change. Change subject: virtTests: add way to query full stats via jsonrpc .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45309/1/tests/functional/utils.py File tests/functional/utils.py: Line 220: else: Line 221: return _parse_result(result) Line 222: Line 223: def getVmList(self, vmId): Line 224: result = self.vdscli.getVMFullList() I think you should keep the test as is by giving parameter: self.vdscli.getVMFullList([vmId]) Line 225: code, msg, vm_list = _parse_result(result, True) Line 226: return code, msg, vm_list[0] Line 227: Line 228: def getVdsCapabilities(self): -- To view, visit https://gerrit.ovirt.org/45309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2c2f50d862bfd1447aa812a037b5b41f3efd6af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rpc.Bridge: sanitize optional, positional argument names
Ondřej Svoboda has posted comments on this change. Change subject: rpc.Bridge: sanitize optional, positional argument names .. Patch Set 5: I outlined my idea a little more in a comment to the reverting commit https://gerrit.ovirt.org/45266 I believe _Server._callMethod must accept a dictionary as a parameter (if any helper parameters are desired, which I doubt), or **kwargs, certainly not *args. -- To view, visit https://gerrit.ovirt.org/45274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic23ca1d06a394c73ae746e123209375ceb90243c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "tests: functional - convert to run over jsonrpc"
Ondřej Svoboda has posted comments on this change. Change subject: Revert "tests: functional - convert to run over jsonrpc" .. Patch Set 1: -Verified There are multiple issues. A "cure" to one -- the server side not properly naming parameters transferred as a list (which is schema violation, though) is https://gerrit.ovirt.org/#/c/45274/ A better solution is to let jsonrpcvdscli's _Server._callMethod accept a dictionary or kwargs instead of positional args (that also inevitably lose their name in JSON representation). -- To view, visit https://gerrit.ovirt.org/45266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib45fbaa84e25e3c72aa09bfa78c16dd700e6e957 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virtTests: add way to query full stats via jsonrpc
automat...@ovirt.org has posted comments on this change. Change subject: virtTests: add way to query full stats via jsonrpc .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2c2f50d862bfd1447aa812a037b5b41f3efd6af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Remove substitutions from dumpStorageTable
Dan Kenigsberg has posted comments on this change. Change subject: core: Remove substitutions from dumpStorageTable .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id041a7caefe00ae85443cc1350506d0a75932028 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virtTests: add way to query full stats via jsonrpc
automat...@ovirt.org has posted comments on this change. Change subject: virtTests: add way to query full stats via jsonrpc .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2c2f50d862bfd1447aa812a037b5b41f3efd6af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virtTests: add way to query full stats via jsonrpc
Martin Polednik has uploaded a new change for review.
Change subject: virtTests: add way to query full stats via jsonrpc
..
virtTests: add way to query full stats via jsonrpc
Change-Id: Ic2c2f50d862bfd1447aa812a037b5b41f3efd6af
Signed-off-by: Martin Polednik
---
M lib/vdsm/jsonrpcvdscli.py
M tests/functional/utils.py
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/45309/1
diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 6e65e0d..eda01c4 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -43,6 +43,7 @@
'getVdsStats': 'Host.getStats',
'getVmStats': 'VM.getStats',
'list': 'Host.getVMList',
+'fullList': 'Host.getVMFullList',
'migrationCreate': 'VM.migrationCreate',
'ping': 'Host.ping',
'setBalloonTarget': 'VM.setBalloonTarget',
diff --git a/tests/functional/utils.py b/tests/functional/utils.py
index 26562aa..1414386 100644
--- a/tests/functional/utils.py
+++ b/tests/functional/utils.py
@@ -221,7 +221,7 @@
return _parse_result(result)
def getVmList(self, vmId):
-result = self.vdscli.list('true', [vmId])
+result = self.vdscli.getVMFullList()
code, msg, vm_list = _parse_result(result, True)
return code, msg, vm_list[0]
--
To view, visit https://gerrit.ovirt.org/45309
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2c2f50d862bfd1447aa812a037b5b41f3efd6af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
