Change in vdsm[master]: stomp: message tracking do not clean properly

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: message tracking do not clean properly
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: improve message id handling during response send

[piotr . kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: stomp: improve message id handling during response send
..

stomp: improve message id handling during response send

Signed-off-by: pkliczewski 
Change-Id: I21102b03245da7906d5618ba9e0f9811e8864c34
---
M lib/yajsonrpc/stompreactor.py
1 file changed, 14 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/49185/1

diff --git a/lib/yajsonrpc/stompreactor.py b/lib/yajsonrpc/stompreactor.py
index 6006786..823f19d 100644
--- a/lib/yajsonrpc/stompreactor.py
+++ b/lib/yajsonrpc/stompreactor.py
@@ -322,12 +322,21 @@
 resp = json.loads(message)
 response_id = resp.get("id")
 
-try:
-destination = self._req_dest[response_id]
-del self._req_dest[response_id]
-except KeyError:
-# we could have no reply-to or we could send events (no message id)
+if response_id is None:
+# events do not have ids
 pass
+else:
+try:
+destination = self._req_dest[response_id]
+except KeyError:
+# we could have no reply-to we will use destination
+# provided as method argument
+pass
+try:
+del self._req_dest[response_id]
+except KeyError:
+self.log.warn("Response to a message with id %s was not found",
+  response_id)
 
 try:
 connections = self._sub_map[destination]


-- 
To view, visit https://gerrit.ovirt.org/49185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21102b03245da7906d5618ba9e0f9811e8864c34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: improve message id handling during response send

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: improve message id handling during response send
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21102b03245da7906d5618ba9e0f9811e8864c34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: code coverage: change approach how to enable it

[automation]

gerrit-hooks has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Metadata read utils

[alitke]

Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: Metadata read utils
..


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/41846/18/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 108: meta = misc.readblock(lvm.lvPath(vgname, sd.METADATA),
Line 109:   offs * volume.METADATA_SIZE,
Line 110:   volume.METADATA_SIZE)
Line 111: out = {}
Line 112: for l in meta:
> We should but not now.
Done
Line 113: if l.startswith("EOF"):
Line 114: return out
Line 115: if l.find("=") < 0:
Line 116: continue


-- 
To view, visit https://gerrit.ovirt.org/41846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e02ad8138bae0b1d60b032662afbad15dd4feba
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 10:

* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
* Check Public Bug::#1199782::OK, public bug
* Check Product::#1134256::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check Product::#1199782::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: renaming device unplug related function

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: renaming device unplug related function
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ab2b22e2a79507cde77addf28f29b80bde9e24d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: volume share utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: volume share utilities
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43c7aaf4a8a8b8bce18331c0a55ba533192777f7
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move validateDelete

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move validateDelete
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/48473/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2691: while self._isDriveAttached(device):
Line 2692: time.sleep(sleep_time)
Line 2693: if utils.monotonic_time() > deadline:
Line 2694: raise HotunplugTimeout("Timeout detaching device 
%s"
Line 2695:% device.name)
> why is this rename useful?
We support any device now?
Line 2696: 
Line 2697: def _isDriveAttached(self, device):
Line 2698: root = ET.fromstring(self._dom.XMLDesc(0))
Line 2699: return bool(root.findall(device.xpath))


-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Adding coverage check for unit tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Adding coverage check for unit tests
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2534a165c2576ff7acb2082412f5b2df0f0d1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: image: copy - set VM metadata images format to RAW

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: image: copy - set VM metadata images format to RAW
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49144
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 4:

(10 comments)

https://gerrit.ovirt.org/#/c/48880/4/tests/vmTests.py
File tests/vmTests.py:

Line 1263: @MonkeyPatch(vm, "config", make_config([
Line 1264: ("vars", "hotunplug_timeout", "0.5"),
Line 1265: ("vars", "hotunplug_check_interval", "0.1")
Line 1266: ]))
Line 1267: def test_wait_for_drive_removal_timeout(self):
> We don't need to repeat the class name in the tests - use:
Done
Line 1268: drive = Drive({}, log=self.log, index=0, path='test_path', 
iface="")
Line 1269: testvm = TestingVm(FakeVmDom(self.DRIVE_XML, 
times_to_match=9))
Line 1270: 
Line 1271: self.assertRaises(HotunplugTimeout, 
testvm._waitForDriveRemoval, drive)


Line 1266: ]))
Line 1267: def test_wait_for_drive_removal_timeout(self):
Line 1268: drive = Drive({}, log=self.log, index=0, path='test_path', 
iface="")
Line 1269: testvm = TestingVm(FakeVmDom(self.DRIVE_XML, 
times_to_match=9))
Line 1270: 
> Empty line is not needed, this is a very short and simple test - same for o
Done
Line 1271: self.assertRaises(HotunplugTimeout, 
testvm._waitForDriveRemoval, drive)
Line 1272: 
Line 1273: # The timeout hotunplug_check_interval=1 should never be 
reached. We should
Line 1274: # never reach sleep when device is removed in first check, and 
method


Line 1280: def test_wait_for_drive_removal_removed_on_first_check(self):
Line 1281: drive = Drive({}, log=self.log, index=0, path='test_path', 
iface="")
Line 1282: testvm = TestingVm(FakeVmDom(self.DRIVE_XML))
Line 1283: 
Line 1284: testvm._waitForDriveRemoval(drive)
> Check for testvm._dom.xmldesc_fetched == 1
Done
Line 1285: 
Line 1286: @MonkeyPatch(vm, "config", make_config([
Line 1287: ("vars", "hotunplug_timeout", "1"),
Line 1288: ("vars", "hotunplug_check_interval", "0")


Line 1290: def test_wait_for_drive_removal_removed_on_x_check(self):
Line 1291: drive = Drive({}, log=self.log, index=0, path='test_path', 
iface="")
Line 1292: testvm = TestingVm(FakeVmDom(self.DRIVE_XML, 
times_to_match=2))
Line 1293: 
Line 1294: testvm._waitForDriveRemoval(drive)
> Check for testvm._dom.xmldesc_fetched == 3
Done
Line 1295: 
Line 1296: 
Line 1297: class FakeVmDom(object):
Line 1298: 


Line 1293: 
Line 1294: testvm._waitForDriveRemoval(drive)
Line 1295: 
Line 1296: 
Line 1297: class FakeVmDom(object):
> Lets give this a more specific name.
Done
Line 1298: 
Line 1299: DEFAULT_XML = """
Line 1300: 
Line 1301: 


Line 1298: 
Line 1299: DEFAULT_XML = """
Line 1300: 
Line 1301: 
Line 1302: 
> We need other devices in the default xml. For testing drives, we need other
For the sake of tesing, it might be worthwhile to have some of the devices for 
all checks.
Adding some devices with different types.
Line 1303: """
Line 1304: 
Line 1305: def __init__(self, device_xml, times_to_match=0):
Line 1306: self.matches = times_to_match


Line 1301: 
Line 1302: 
Line 1303: """
Line 1304: 
Line 1305: def __init__(self, device_xml, times_to_match=0):
> Lets add a parameter for the domain_xml, the xml that should be returned wh
The times_to_match should never be exceeded. If it is, we have an unexpected 
behaviour. 
Raising an exception for such a case.
Line 1306: self.matches = times_to_match
Line 1307: result_xml = ET.fromstring(self.DEFAULT_XML)
Line 1308: result_xml.find("devices").append(ET.fromstring(device_xml))
Line 1309: self.xml = ET.tostring(result_xml)


Line 1302: 
Line 1303: """
Line 1304: 
Line 1305: def __init__(self, device_xml, times_to_match=0):
Line 1306: self.matches = times_to_match
> Now that we have a counter, we can keep the name as is
Done
Line 1307: result_xml = ET.fromstring(self.DEFAULT_XML)
Line 1308: result_xml.find("devices").append(ET.fromstring(device_xml))
Line 1309: self.xml = ET.tostring(result_xml)
Line 1310: 


Line 1305: def __init__(self, device_xml, times_to_match=0):
Line 1306: self.matches = times_to_match
Line 1307: result_xml = ET.fromstring(self.DEFAULT_XML)
Line 1308: result_xml.find("devices").append(ET.fromstring(device_xml))
Line 1309: self.xml = ET.tostring(result_xml)
> lets call this self.domain_xml_with_device to make it more clear.
Done
Line 1310: 
Line 1311: def XMLDesc(self, flags):
Line 1312: if self.matches == 0:
Line 1313: return self.DEFAULT_XML


Line 1307: result_xml = ET.fromstring(self.DEFAULT_XML)
Line 1308: result_xml.find("devices").append(ET.fromstring(device_xml))
Line 1309: self.xml = ET.tostring(result_xml)
Line 1310: 
Line 1311: def XMLDesc(self, 

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:

Line 1283: 0.1
Made it still shorter.
With 4 tests, it seemed terribly long when set to 1.


Line 1286:  x
Drive actually goes to the file system to check if the device is a block device.
Need to override in tests (hope this is not too dirty).


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move newMetadata
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move getVolumeSize
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c1fa58d64efbb3cbc7eea84189fc8375b6fa3d
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getParentVolume

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move getParentVolume
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74def8861e0b7b97ca4d218a969440ccba7f07dd
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move getImageVolumes
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e99008b0df26a0bd2f714ac060ceee437e0060e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: code coverage: change approach how to enable it

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1: Code-Review-1

(1 comment)

change looks ok please fix the spelling

https://gerrit.ovirt.org/#/c/49168/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 409: flase
false


-- 
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move refreshVolume

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move refreshVolume
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5041428d8d2e73edc1aa1362fcea8801e5b9116
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm.py: Deprecate getVGList

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: hsm.py: Deprecate getVGList
..


hsm.py: Deprecate getVGList

oVirt Engine commit 4312bfd removed all the usages of getVGList from the
engine's code.

Since this verb is useless to us (the same functionality is covered by
getVGInfo and getDeviceList), and since it's no longer called, this
patch flags it as @deprecated, with the intent to remove it completely
in the future.

Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/48998
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/48998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm.py: Deprecate getVGList

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm.py: Deprecate getVGList
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/48998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move simple metadata getters and setters

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move simple metadata getters and setters
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94a36dcb0d6e586612f869e8ef83925954709362
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move refreshVolume

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move refreshVolume
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5041428d8d2e73edc1aa1362fcea8801e5b9116
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Metadata read utils

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Metadata read utils
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e02ad8138bae0b1d60b032662afbad15dd4feba
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move the getParent API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move the getParent API
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41848
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8489e18c431c89728c180735938a51dfc278671b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move validateDelete

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move validateDelete
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move getImageVolumes
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e99008b0df26a0bd2f714ac060ceee437e0060e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: metadata write utils

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: metadata write utils
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia245c589ea6bc2cf9ac1b2b59b9073d1b5fc9595
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move newMetadata
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move isLeaf, setLeaf and dependencies

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48e05ef7168ab835d31914e05f3abd969b6552b1
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move recheckIfLeaf into *Metadata class

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibddf8fc2feea49859924743f2b30e0f2fc71ebb7
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move getVolumeSize
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: volume share utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: volume share utilities
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43c7aaf4a8a8b8bce18331c0a55ba533192777f7
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getParentVolume

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move getParentVolume
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74def8861e0b7b97ca4d218a969440ccba7f07dd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c1fa58d64efbb3cbc7eea84189fc8375b6fa3d
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: introduce "Async" helper

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: introduce "Async" helper
..


Patch Set 2: Code-Review-1

(11 comments)

I can't get rid of feeling that the implementation is too complicated for the 
simple purpose of checking the start success. Maybe using a semaphore inside 
do() and _set_started() would be a bit easier, not sure, already confused now 
:-). Or perhaps I completely miss something.

https://gerrit.ovirt.org/#/c/49114/2/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:

Line 195: done.set()
Line 196: 
Line 197: self.async.do(helper)
Line 198: 
Line 199: self.assertTrue(done.wait(1.))
Too many blank lines in all the tests? Are they needed at all?
Line 200: 
Line 201: def test_raises_if_busy(self):
Line 202: 
Line 203: def helper():


https://gerrit.ovirt.org/#/c/49114/2/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 133: 
Line 134: Async takes care only of the startup phase;
Line 135: it doesn't report or handle any error that
Line 136: may happen in the callable right after the startup.
Line 137: """
It should be documented here that the instance can't be reused, i.e. `do()' 
shouldn't be called twice (it'd be even better if it was additionally prevented 
or perhaps the instance made reusable).
Line 138: 
Line 139: def __init__(self):
Line 140: self._func = None
Line 141: self._started = False


Line 143: self._starting = threading.Condition()
Line 144: 
Line 145: @property
Line 146: def error(self):
Line 147: """
Why property? It's quite confusing to have self._error and self.error -- 
self._error and self.error() would be better.
And do we need this public method at all? do() already provides the information 
in some way. So unless we want to examine the result in a separate thread 
(really?), this public method is not needed, as demonstrated in vm.py.
Line 148: Returns the startup error of the callable, or
Line 149: None if operation succeded.
Line 150: Block until the callable started, either succesfully
Line 151: or failing.


Line 162: `func' may be callable without arguments.
Line 163: The return value of `func' is ignored.
Line 164: `daemon' and `logger' arguments behave like
Line 165: concurrent.thread.
Line 166: """
Please document that the method throws an exception on start error.
Line 167: 
Line 168: self._func = func
Line 169: self._thread = concurrent.thread(
Line 170: self._run,


Line 164: `daemon' and `logger' arguments behave like
Line 165: concurrent.thread.
Line 166: """
Line 167: 
Line 168: self._func = func
Why using the attribute and not pass `func' to concurrent.thread?
Line 169: self._thread = concurrent.thread(
Line 170: self._run,
Line 171: daemon=daemon,
Line 172: logger=logger)


Line 172: logger=logger)
Line 173: self._thread.start()
Line 174: 
Line 175: err = self.error
Line 176: if err:
According to error() docstring anything but None is error, so `if err is not 
None:' should be used here.
Line 177: raise AsyncStartError(err)
Line 178: 
Line 179: def _run(self):
Line 180: self._set_started(error=None)


Line 189: 
Line 190: class AsyncThrottler(Async):
Line 191: """
Line 192: AsyncThrottler  runs a callable into a background thread,
Line 193: like Async, but only if can acquire an user-provided
... if it can acquire a ...
Line 194: Semaphore-like object.
Line 195: 
Line 196: AsyncThrottler fails to start (do() returns error)
Line 197: if it can't acquire such semaphore.


Line 192: AsyncThrottler  runs a callable into a background thread,
Line 193: like Async, but only if can acquire an user-provided
Line 194: Semaphore-like object.
Line 195: 
Line 196: AsyncThrottler fails to start (do() returns error)
... do() raises AsyncStartError ...
Line 197: if it can't acquire such semaphore.
Line 198: In that case returns the user-provided error code.
Line 199: """
Line 200: 


Line 194: Semaphore-like object.
Line 195: 
Line 196: AsyncThrottler fails to start (do() returns error)
Line 197: if it can't acquire such semaphore.
Line 198: In that case returns the user-provided error code.
... case it returns ...
Line 199: """
Line 200: 
Line 201: def __init__(self, sem, errcode):
Line 202: super(AsyncThrottler, self).__init__()


Line 201: def __init__(self, sem, errcode):
Line 202: super(AsyncThrottler, self).__init__()
Line 203: self._sem = sem
Line 204: self._errcode = errcode
Line 205: 
_error_code and error_code would be better names.
Line 206: def _run(self):
Line 207: acquired = self._sem.acquire(False)
Line 208:   

Change in vdsm[master]: build: Cleanup conditionals in the build system

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
..


Patch Set 18:

(3 comments)

https://gerrit.ovirt.org/#/c/48446/18/vdsm.spec.in
File vdsm.spec.in:

Line 46
Line 47
Line 48
Line 49
Line 50
> When is this used? seems that it will never be true when building for rhel,
:)


Line 636
Line 637
Line 638
Line 639
Line 640
> Are all these flags implemented in our configure script?
bahh :/ not sure what looks better


Line 10: %global snlk_user @SNLKUSER@
Line 11: %global cdrom_group @CDROMGROUP@
Line 12: 
Line 13: # Build types
Line 14: %global koji_build @KOJI_BUILD@
> Can we eliminate this as well, adding koji_build.sh script instead?
no.. this variable just says if to install vhostmd or not and nothing else.. 
its not the same with rhev
Line 15: 
Line 16: # Features
Line 17: %global with_gluster_mgmt @GLUSTER_MGMT@
Line 18: %global with_hooks @HOOKS@


-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: code coverage: change approach how to enable it

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 2:

(2 comments)

Thanks Petr!

Looks good, please see the comments.

https://gerrit.ovirt.org/#/c/49168/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 406: 
Line 407: ('coverage_enable', 'false',
Line 408: 'Enable code coverage (requires python-coverage package). 
'
Line 409: 'false by default. Use environment file 
/etc/sysconfig/vdsm to '
Line 410: 'set COVERAGE_PROCESS_START and COVERAGE_FILE 
variables.'),
So you will install these files on all qe hosts, and then enable coverage via 
the configuration?

To make it easier for everyone, do you want to submit also this file to 
contrib/coverage.sample? (in another patch)
Line 411: 
Line 412: ]),
Line 413: 
Line 414: # Section: [gluster]


https://gerrit.ovirt.org/#/c/49168/2/vdsm/vdsm
File vdsm/vdsm:

Line 124: logging.addLevelName(5, 'TRACE')
Line 125: logging.TRACE = 5  # impolite but helpful
Line 126: 
Line 127: # Used to enable code coverage. To enable it use coverage_enable 
option in
Line 128: # devel section.
The comment is not needed, the line getting the configuration from the config 
explains itself.
Line 129: if config.getboolean('devel', 'coverage_enable'):
Line 130: import coverage
Line 131: coverage.process_startup()
Line 132: 


-- 
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize

[alitke]

Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: move getVolumeSize
..


Patch Set 17:

(1 comment)

https://gerrit.ovirt.org/#/c/41998/17/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 202: """
Line 203: # Just call the SD Manifest method getVSize() - apparently it 
does what
Line 204: # we need. We consider incurred overhead of producing the 
object
Line 205: # to be a small price for code de-duplication.
Line 206: manifest = blockSD.BlockStorageDomainManifest(self.sdUUID)
> This bypass the sd cache, which is nice, since I like to get rid of it. But
Sure.  I will pull in a new patch and we can use the sdCache as follows:

 manifest = sdCache.produce(self.sdUUID).get_manifest()
Line 207: return int(manifest.getVSize(self.imgUUID, self.volUUID) / bs)
Line 208: 
Line 209: getVolumeTrueSize = getVolumeSize
Line 210: 


-- 
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move newVolumeLease
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If18aa7d526d9eb334c638fdf4cc93d31a4943cb6
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: StorageDomain: Add get_manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: StorageDomain: Add get_manifest
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44566
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a7ebd209a77bea90b2b6f306c85a146923f15c6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: add test for nic unplug wait

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: add test for nic unplug wait
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49104
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: devices: drop support for ancient Engines

[smelamud]

Shmuel Leib Melamud has posted comments on this change.

Change subject: vm: devices: drop support for ancient Engines
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9acd500670a2ace449cc50ac99bf94f58f165b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Marek Libra 
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: move device attached check to device itself

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: move device attached check to device itself
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: introduce "Async" helper

[mbetak]

Martin Betak has posted comments on this change.

Change subject: virt: introduce "Async" helper
..


Patch Set 2:

I'm going to have to agree with Milan. We need to ask ourselves, what we are 
getting in exchange for all this complexity. If it is really just to put the 
acquire and release a little bit closer together, I would say we are making a 
bad trade-off, both in readability (understandability) and future 
maintanability of the code.

-- 
To view, visit https://gerrit.ovirt.org/49114
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd277197c7c3819008ae71a8cf2c0679b901397e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm.py: Deprecate getVGList

[alitke]

Adam Litke has posted comments on this change.

Change subject: hsm.py: Deprecate getVGList
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Remove reporting of bond custom options from RunningConfig

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: net: Remove reporting of bond custom options from RunningConfig
..


Patch Set 2: Code-Review+1

Well done!

-- 
To view, visit https://gerrit.ovirt.org/49081
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5863d67b2b2b9ce15cee9c447983d3ba2e0f23ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 6:

Nice work!

See the comments.

-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8: Code-Review+1

(2 comments)

Very nice, waiting for Francesco approval.

https://gerrit.ovirt.org/#/c/48404/8/tests/vmTests.py
File tests/vmTests.py:

Line 289: xml = find_xml_element(domxml.dom.toxml(), './sysinfo')
Line 290: self.assertXMLEqual(xml, sysinfoXML)
Line 291: 
Line 292: @permutations([['serial', True], ['virtio', False]])
Line 293: def testSerialBios(self, console_type, use_serial):
I would like to only lowercase names in new code, even if it is less consistent 
wit surrounding code, but it this is what Francesco prefer I'm ok with it.
Line 294: devices = {'device': 'console', 'type': 'console',
Line 295:'specParams': {'consoleType': console_type}},
Line 296: with fake.VM(devices=devices, create_device_objects=True) as 
fakevm:
Line 297: dom_xml = fakevm._buildDomainXML()


https://gerrit.ovirt.org/#/c/48404/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1569: """
Line 1570: for console in self._devices[hwclass.CONSOLE]:
Line 1571: if console.isSerial:
Line 1572: return console
Line 1573: return None
Maybe raise NotFound error instead returning None?

I'm seeing the future errors:

AttributeError: 'NoneType' object has no attribute 'toxml'
Line 1574: 
Line 1575: def _customDevices(self):
Line 1576: """
Line 1577: Get all devices that have custom properties


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:

Line 1279: drive_block = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1280: path= "/block_path", 
diskType=DISK_TYPE.BLOCK)
Line 1281: 
Line 1282: @MonkeyPatch(vm, "config", make_config([
Line 1283: ("vars", "hotunplug_timeout", "0.1"),
> 0.03 is too short for overloaded ci slaves.
Ok
But you take over the guilt for everyone making a build waiting for 1 (0.25 x 4 
tests) second longer
Line 1284: ("vars", "hotunplug_check_interval", "0.03")
Line 1285: ]))
Line 1286: @MonkeyPatch(utils, "isBlockDevice", lambda x: x == 
"/block_path")
Line 1287: @permutations([[drive_default, FILE_DRIVE_XML],


Line 1338: 
Line 1339: 
Line 1340: 
Line 1341: 
Line 1342: 
> Lets update the xml of the devices to look more like the real xml, see vmSt
Done
Line 1343: 
Line 1344: 
Line 1345: 
Line 1346: 


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: add test for nic unplug wait

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: add test for nic unplug wait
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49104
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: move device attached check to device itself

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: move device attached check to device itself
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 12:

* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
* Check Public Bug::#1199782::OK, public bug
* Check Product::#1134256::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check Product::#1199782::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:

Line 1279: drive_block = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1280: path= "/block_path", 
diskType=DISK_TYPE.BLOCK)
Line 1281: 
Line 1282: @MonkeyPatch(vm, "config", make_config([
Line 1283: ("vars", "hotunplug_timeout", "0.1"),
> Ok
Some test must be slow for correcness. We can skip these test in normal build 
using @slowtest.
See tests README for the details.

Anothet way is to monkeypatch utils.monotonic_time and time sleep, see for 
example mkimageTests.py. But the test slowly become more complicated than the 
actual code they test.
Line 1284: ("vars", "hotunplug_check_interval", "0.03")
Line 1285: ]))
Line 1286: @MonkeyPatch(utils, "isBlockDevice", lambda x: x == 
"/block_path")
Line 1287: @permutations([[drive_default, FILE_DRIVE_XML],


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: startup: Change system default encoding to utf8

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: startup: Change system default encoding to utf8
..


Patch Set 5:

Please review latest change.

-- 
To view, visit https://gerrit.ovirt.org/48661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 8:

Sahina, your ack is welcome.

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 9: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[ahino]

Ala Hino has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 9:

> Uploaded patch set 9.

Fixed identation

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 10: Code-Review-1

This should be squashed with https://gerrit.ovirt.org/49038

-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Adding coverage check for unit tests

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Adding coverage check for unit tests
..


Patch Set 4:

It does not seem that ANY test has been running:

 16:18:11 Complete!
 16:18:11 + coverage html
 16:18:11 No data to report.

-- 
To view, visit https://gerrit.ovirt.org/49130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2534a165c2576ff7acb2082412f5b2df0f0d1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: renaming device unplug related function

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: renaming device unplug related function
..


Patch Set 5: Code-Review-1

This rename belongs to https://gerrit.ovirt.org/48473

-- 
To view, visit https://gerrit.ovirt.org/49038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ab2b22e2a79507cde77addf28f29b80bde9e24d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move newVolumeLease
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If18aa7d526d9eb334c638fdf4cc93d31a4943cb6
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: build: contrib script to build for rhev with the required flags
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh
File contrib/rhev_build.sh:

Line 9: --with-qemu-kvm='qemu-kvm-rhev' \
Line 10: --with-qemu-img='qemu-img-rhev' \
Line 11: --enable-hooks \
Line 12: --disable-gluster-mgmt
Line 13: make dist
> Above here as well
Fabian, do you need any build script here that will help you with node?
Line 14: 
Line 15: echo
Line 16: echo 'Finish to compile VDSM for RHEV'


-- 
To view, visit https://gerrit.ovirt.org/49001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icea013429c828782b68f5c4900c78e089a9f94d4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: move device attached check to device itself

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: move device attached check to device itself
..


Patch Set 7:

(1 comment)

Nice, see the comment about breaking long lines.

https://gerrit.ovirt.org/#/c/48881/7/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 431
Line 432
Line 433
Line 434
Line 435
Please do not use \ it is too fragile.

Use:

return ("./devices/disk/source[@%s='%s']" %
(source_key[self.diskType], self.path))


-- 
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/49023/7/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 1260: 
Line 1261: def unique(iterable):
Line 1262: """
Line 1263: Remove duplicates from provided iterable.
Line 1264: Note that this method supports only iterable objects.
Why not:

Return unique items from iterable of hashable objects, keeping the
original order.
Line 1265: """


https://gerrit.ovirt.org/#/c/49023/7/tests/utilsTests.py
File tests/utilsTests.py:

Line 281: ((i for i in [1, 2, 3, 1, 3]), [1, 2, 3]),
Line 282: (('a', 'a', 'b', 'c', 'a', 'd'), ['a', 'b', 'c', 'd']),
Line 283: (['a', 'a', 'b', 'c', 'a', 'd'], ['a', 'b', 'c', 'd'])
Line 284: ])
Line 285: def test_unique(self, iterable, uniqueList):
uniqueList -> unique_items
Line 286: self.assertEquals(utils.unique(iterable,), uniqueList)
Line 287: 
Line 288: 
Line 289: class AsyncProcessOperationTests(TestCaseBase):


-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mkimage: setup right permissions before mkisofs
..


Patch Set 5: Code-Review+1

(1 comment)

Looks good, one minor comment.

https://gerrit.ovirt.org/#/c/48538/5/vdsm/mkimage.py
File vdsm/mkimage.py:

Line 133: # mkisofs/genisoimage will truncate the content and keep the
Line 134: # permissions.
Line 135: 
Line 136: if os.path.exists(isopath):
Line 137: logging.warning("iso file %s exists, removing", isopath)
Can you use %r ? This make it possible to detect leading and trailing 
whitespace issues and more clear in general - should be our standard for 
logging strings.
Line 138: rmFile(isopath)
Line 139: 
Line 140: fd = os.open(isopath, os.O_CREAT | os.O_RDONLY | os.O_EXCL, 
0o640)
Line 141: os.close(fd)


-- 
To view, visit https://gerrit.ovirt.org/48538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc971a39ae2a8eaf7af934bb0922647e4676d03f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1:

Fred, can you test this?

-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2ea13f318bce2c15cdd9acc65944eb9f2f604d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[ahino]

Ala Hino has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/49023/7/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 1260: 
Line 1261: def unique(iterable):
Line 1262: """
Line 1263: Remove duplicates from provided iterable.
Line 1264: Note that this method supports only iterable objects.
> Why not:
Done
Line 1265: """


https://gerrit.ovirt.org/#/c/49023/7/tests/utilsTests.py
File tests/utilsTests.py:

Line 281: ((i for i in [1, 2, 3, 1, 3]), [1, 2, 3]),
Line 282: (('a', 'a', 'b', 'c', 'a', 'd'), ['a', 'b', 'c', 'd']),
Line 283: (['a', 'a', 'b', 'c', 'a', 'd'], ['a', 'b', 'c', 'd'])
Line 284: ])
Line 285: def test_unique(self, iterable, uniqueList):
> uniqueList -> unique_items
Done
Line 286: self.assertEquals(utils.unique(iterable,), uniqueList)
Line 287: 
Line 288: 
Line 289: class AsyncProcessOperationTests(TestCaseBase):


-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: adding compatibility for ovirt-engine 4.0 support
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in
File vdsm/dsaversion.py.in:

Line 34: version_info = {
Line 35: 'version_name': version_name,
Line 36: 'software_version': software_version,
Line 37: 'software_revision': software_revision,
Line 38: 'supportedENGINEs': ['3.4', '3.5', '3.6', '4.0'],
that fine...
Line 39: 'clusterLevels': ['3.4', '3.5', '3.6', '4.0'],
Line 40: }
Line 41: 
Line 42: if platform.machine() == 'ppc64le':


Line 39:  '4.0'
but we do not support 4.0 clusterLevel yet... We have not even defined what 
this clusterLevel is.


-- 
To view, visit https://gerrit.ovirt.org/49060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eli Mesika 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: add test for nic unplug wait

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: add test for nic unplug wait
..


Patch Set 3: Code-Review+1

Nice! Waiting for Francesco and Ido.

-- 
To view, visit https://gerrit.ovirt.org/49104
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mkimage: check image attributes after creation

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mkimage: check image attributes after creation
..


Patch Set 5: Code-Review+1

(1 comment)

Looks good, one minor comment.

https://gerrit.ovirt.org/#/c/48540/5/vdsm/mkimage.py
File vdsm/mkimage.py:

Line 172: info = os.stat(path)
Line 173: 
Line 174: current_mode = stat.S_IMODE(info.st_mode)
Line 175: if current_mode != mode:
Line 176: logging.warning('wrong mode for %s: expected=%o found=%o',
Use %r


-- 
To view, visit https://gerrit.ovirt.org/48540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3823dc604b2bafecc49154491d1815670a3600fa
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 8: Code-Review+2

Thanks Ala!

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 8:

Piotr, please approve the infra change.

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..


Patch Set 12: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/46692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: pass ip configuration as a namedtuple
..


Patch Set 1: Code-Review+1

okay

-- 
To view, visit https://gerrit.ovirt.org/48830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: skip non-vNic device's XML

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: skip non-vNic device's XML
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/49183/2/vdsm_hooks/ovs/ovs_before_device_create.py
File vdsm_hooks/ovs/ovs_before_device_create.py:

Line 32: network is set as a source.
Line 33: """
Line 34: try:
Line 35: iface = domxml.getElementsByTagName('interface')[0]
Line 36: source = iface.getElementsByTagName('source')[0]
make sure your try-except blocks are as tiny as possible. In this case, keep 
only the iface line in.
Line 37: except IndexError:
Line 38: # This is not a vNic device
Line 39: return
Line 40: source_bridge = source.getAttribute('bridge')


-- 
To view, visit https://gerrit.ovirt.org/49183
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I457d43847f07cccbd56b562fbc7c111a0bb0e1a3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: build: contrib script to build for rhev with the required flags
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh
File contrib/rhev_build.sh:

Line 9: --with-qemu-kvm='qemu-kvm-rhev' \
Line 10: --with-qemu-img='qemu-img-rhev' \
Line 11: --enable-hooks \
Line 12: --disable-gluster-mgmt
Line 13: make dist
> Fabian, do you need any build script here that will help you with node?
I am not aware that this script helps us with node.

AFAIU this script helps to build qemu-kvm-rhev in upstream
Line 14: 
Line 15: echo
Line 16: echo 'Finish to compile VDSM for RHEV'


-- 
To view, visit https://gerrit.ovirt.org/49001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icea013429c828782b68f5c4900c78e089a9f94d4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: hooks: hostusb: make sudoers rule more specific
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48963
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: split netinfo module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: split netinfo module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49198
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I297b55f68f69c4ba0f1c854bcadddc087a2e9089
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 5:

(8 comments)

https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:

Line 1261: 
Line 1262: 
Line 1263: """
Line 1264: NETWORK_DRIVE_XML = """
Line 1265: 
type="network"
Line 1266: 
Line 1267: """
Line 1268: BLOCK_DRIVE_XML = """
Line 1269: 


Line 1265: 
Line 1266: 
Line 1267: """
Line 1268: BLOCK_DRIVE_XML = """
Line 1269: 
type="block"

See vmStorageTests for example xmls.
Line 1270: 
Line 1271: """
Line 1272: 
Line 1273: drive_default = Drive({}, log=logging.getLogger(''), index=0, 
iface="",


Line 1270: 
Line 1271: """
Line 1272: 
Line 1273: drive_default = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1274:   path='test_path', )
We can remove the default, we are not testing the Drive class here.
Line 1275: drive_file = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1276:path='test_path',  diskType=DISK_TYPE.FILE)
Line 1277: drive_network = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1278:   path='test_path', 
diskType=DISK_TYPE.NETWORK)


Line 1276:path='test_path',  diskType=DISK_TYPE.FILE)
Line 1277: drive_network = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1278:   path='test_path', 
diskType=DISK_TYPE.NETWORK)
Line 1279: drive_block = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1280: path= "/block_path", 
diskType=DISK_TYPE.BLOCK)
path is always /rhev/data-center/p/d/images/i/v, (p=poolid, d=domainid, 
i=imageid, v=volumeid) for file and block. For network the path is 
rbd:pool/volume, but it does not really matter. For the tests, using the same 
"test_path" is fine.
Line 1281: 
Line 1282: @MonkeyPatch(vm, "config", make_config([
Line 1283: ("vars", "hotunplug_timeout", "0.1"),
Line 1284: ("vars", "hotunplug_check_interval", "0.03")


Line 1279: drive_block = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1280: path= "/block_path", 
diskType=DISK_TYPE.BLOCK)
Line 1281: 
Line 1282: @MonkeyPatch(vm, "config", make_config([
Line 1283: ("vars", "hotunplug_timeout", "0.1"),
> Made it still shorter.
0.03 is too short for overloaded ci slaves.

Lets use timeout=0.25, check_internal=0.1 will time out after retries, in the 
worst case after one retry, good enough.
Line 1284: ("vars", "hotunplug_check_interval", "0.03")
Line 1285: ]))
Line 1286: @MonkeyPatch(utils, "isBlockDevice", lambda x: x == 
"/block_path")
Line 1287: @permutations([[drive_default, FILE_DRIVE_XML],


Line 1282: @MonkeyPatch(vm, "config", make_config([
Line 1283: ("vars", "hotunplug_timeout", "0.1"),
Line 1284: ("vars", "hotunplug_check_interval", "0.03")
Line 1285: ]))
Line 1286: @MonkeyPatch(utils, "isBlockDevice", lambda x: x == 
"/block_path")
> Drive actually goes to the file system to check if the device is a block de
Looks ok, the actual code is dirty in this case :-)
Line 1287: @permutations([[drive_default, FILE_DRIVE_XML],
Line 1288:[drive_file, FILE_DRIVE_XML],
Line 1289:[drive_network, NETWORK_DRIVE_XML],
Line 1290:[drive_block, BLOCK_DRIVE_XML]])


Line 1338: 
Line 1339: 
Line 1340: 
Line 1341: 
Line 1342: 
Lets update the xml of the devices to look more like the real xml, see 
vmStorageTests.
Line 1343: 
Line 1344: 
Line 1345: 
Line 1346: 


Line 1356: 
Line 1357: def XMLDesc(self, flags):
Line 1358: self.xmldesc_fetched += 1
Line 1359: if self.xmldesc_fetched > self.times_to_match + 1:
Line 1360: raise BaseException(
You should raise an Exception, Base Exception is not for user code (in general).

But I don't think we need it, it will make it less useful, I thin we should 
just count the fetches and assert about them in the tests.
Line 1361: "_waitForDriveRemoval called XMLDesc too many 
times.")
Line 1362: if self.xmldesc_fetched > self.times_to_match:
Line 1363: return self.DEFAULT_XML
Line 1364: else:


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 

Change in vdsm[master]: vm: add test for nic unplug wait

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: add test for nic unplug wait
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49104
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: move device attached check to device itself

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: move device attached check to device itself
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 11:

* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
* Check Public Bug::#1199782::OK, public bug
* Check Product::#1134256::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check Product::#1199782::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
..


Patch Set 5:

(4 comments)

https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:

Line 1261: 
Line 1262: 
Line 1263: """
Line 1264: NETWORK_DRIVE_XML = """
Line 1265: 
> type="network"
This is not checked by the code doing the search
Removing this not to cause confusion as to what is really relevant.
Line 1266: 
Line 1267: """
Line 1268: BLOCK_DRIVE_XML = """
Line 1269: 


Line 1265: 
Line 1266: 
Line 1267: """
Line 1268: BLOCK_DRIVE_XML = """
Line 1269: 
> type="block"
same as above
Line 1270: 
Line 1271: """
Line 1272: 
Line 1273: drive_default = Drive({}, log=logging.getLogger(''), index=0, 
iface="",


Line 1270: 
Line 1271: """
Line 1272: 
Line 1273: drive_default = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1274:   path='test_path', )
> We can remove the default, we are not testing the Drive class here.
Done
Line 1275: drive_file = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1276:path='test_path',  diskType=DISK_TYPE.FILE)
Line 1277: drive_network = Drive({}, log=logging.getLogger(''), index=0, 
iface="",
Line 1278:   path='test_path', 
diskType=DISK_TYPE.NETWORK)


Line 1356: 
Line 1357: def XMLDesc(self, flags):
Line 1358: self.xmldesc_fetched += 1
Line 1359: if self.xmldesc_fetched > self.times_to_match + 1:
Line 1360: raise BaseException(
> You should raise an Exception, Base Exception is not for user code (in gene
Done
Line 1361: "_waitForDriveRemoval called XMLDesc too many 
times.")
Line 1362: if self.xmldesc_fetched > self.times_to_match:
Line 1363: return self.DEFAULT_XML
Line 1364: else:


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: init: configure multipath on upgrade from ovirt-3.3 and 3.4

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If307e37397adf99e8a2c3508c8f953507db3f37b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer multipath version

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer multipath version
..


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/49113/3//COMMIT_MSG
Commit Message:

Line 7: spec: Require newer multipath version
Line 8: 
Line 9: There is a race between udev and multiapth which is solved in newer
Line 10: multipath versions, this patch requires those versions on RHEL 7.2 and
Line 11: Fedora 21,22 and 23
Are these the version fixing the issue, or just a convenient default (just 
require the latest version in each platform)?
Line 12: 
Line 13: We don't require the package on CentOS, since it is not available yet.
Line 14: 
Line 15: Change-Id: I63a607aa0d8df678666d87eb593e37bb0331dd82


https://gerrit.ovirt.org/#/c/49113/3/vdsm.spec.in
File vdsm.spec.in:

Line 182: %if 0%{?rhel}
Line 183: %if 0%{?centos}
Line 184: Requires: device-mapper-multipath >= 0.4.9-68
Line 185: %else
Line 186: Requires: device-mapper-multipath >= 0.4.9-84.el7
Please remove multipath from this block and put it on its own section.
Line 187: %endif
Line 188: Requires: e2fsprogs
Line 189: Requires: fence-agents-all
Line 190: %if 0%{?centos}


Line 215: %else
Line 216: %if 0%{?fedora} >= 23
Line 217: Requires: device-mapper-multipath >= 0.4.9-80.fc23
Line 218: %endif
Line 219: %endif
Look like you wan to add requirement for fedora 21, 22, and 23, so why do we 
need nested if else?

Fedora 21 is EOL in 2015-12-01, so there is not point to require anything, we 
cannot support it any more in master/3.6.

The old spec was hardly readable, and now it is completely unreadbale.

Please move out multipath requirement so we have one if block per platform.
So we are left wit fedora 22 and 23, lets have one block for each - outside the 
rhel/centos block, and not in the else block.

This is what we need:

   # device-mapper-multipath

%if 0%{rhel}
%if 0%{?centos}
...
%else
...
%endif # centos
%endif  # rhel

%if 0%{fedora} == 23
...
%endif

%if 0%{fedora} == 22
...
%endif
Line 220: %endif
Line 221: Requires: e2fsprogs >= 1.41.14
Line 222: %if 0%{?fedora} >= 23
Line 223: Requires: policycoreutils-python-utils


-- 
To view, visit https://gerrit.ovirt.org/49113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63a607aa0d8df678666d87eb593e37bb0331dd82
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 10: Code-Review+1

Waiting for Francesco approval.

-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

[oourfali]

Oved Ourfali has posted comments on this change.

Change subject: adding compatibility for ovirt-engine 4.0 support
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in
File vdsm/dsaversion.py.in:

Line 39:  '4.0'
> but we do not support 4.0 clusterLevel yet... We have not even defined what
This was discussed when we developed 3.6.
In order to be able to develop properly, the engine must be able to accept 
hosts to the cluster. Otherwise you're forcing developers to do this change 
manually in order to developer, which, imo, is wrong.
Please re-consider pushing that, to prevent wasting developers time on hacks.


-- 
To view, visit https://gerrit.ovirt.org/49060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eli Mesika 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove editNetwork old API

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: remove editNetwork old API
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48910
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5c46fc31401cd7b38856d66253d2c5074a51e8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Metadata read utils

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: VolumeMetadata: Metadata read utils
..


Patch Set 19: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/41846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e02ad8138bae0b1d60b032662afbad15dd4feba
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches