Change in vdsm[ovirt-3.6]: net: Clean running config on unified restoration failure
Dan Kenigsberg has posted comments on this change. Change subject: net: Clean running config on unified restoration failure .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie43da8ca26ef0b0e92ec66e1a481a843aea0487f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetworkManager: configure to monitor ifcfg files
Dan Kenigsberg has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56365/1//COMMIT_MSG Commit Message: Line 19: This functionality is required to properly let NetworkManager Line 20: know when VDSM consumes any of its devices (on ifcfg systems, Line 21: by writing NM_CONTROLLED=no to an ifcfg file). Line 22: Line 23: TODO: NetworkManager must be restarted after installing you can do that in the spec file's %post script: if you upgrade from a vdsm version that does not have the config files, restart NetworkManager (if it was already running). But this is utterly needless, as at the moment we keep NetworkManager disabled when we add a new host. Line 24: the new configuration file. Line 25: Line 26: Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Line 27: Bug-Url: https://bugzilla.redhat.com/1304509 -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require test-only py3 packages
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: require test-only py3 packages .. spec: require test-only py3 packages commit 51594ca introduced a test-time dependency on python3-netaddr and libvirt-python3. This patch makes it explicit in vdsm.spec. Change-Id: Ib4d08a4136efe1289f6c9f907196b4e6f089f144 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/56337 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim Tested-by: Yaniv Bronhaim Reviewed-by: Shahar Havivi --- M vdsm.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4d08a4136efe1289f6c9f907196b4e6f089f144 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require test-only py3 packages
gerrit-hooks has posted comments on this change. Change subject: spec: require test-only py3 packages .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4d08a4136efe1289f6c9f907196b4e6f089f144 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require test-only py3 packages
Dan Kenigsberg has posted comments on this change. Change subject: spec: require test-only py3 packages .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4d08a4136efe1289f6c9f907196b4e6f089f144 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetworkManager: configure to monitor ifcfg files
Ondřej Svoboda has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files .. Patch Set 1: Verified+1 Thank you, Fabian! This topic is aimed to address only peaceful coexistence and hopefully the deploy scenario (Cockpit+NM to hand the network to VDSM+network.service). As a byproduct of testing the patchset I may also come up with fixes to test failures (when NM is running alongside network.service) and later we can running them while simply switching NM_CONTROLLED=no to yes. I confirm that the new configuration file makes NM watch for changes in /etc/sysconfig/network-scripts/ifcfg-* and that ultimately the new test (nm_consume_bond) worked thanks to this. -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
Edward Haas has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56149/7/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: PS7, Line 231: yield return -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
Edward Haas has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/56149/7/tests/network/conf_persistence_test.py File tests/network/conf_persistence_test.py: PS7, Line 51: create_netconf_temp_dir nit: _create_netconf Line 134: def tearDown(self): Line 135: rmtree(self.tempdir) Line 136: Line 137: def test_successful_setup(self): Line 138: config = Config(self.tempdir) You can move now: config = Config(self.tempdir) and Transaction(config=config) to the setUp Line 139: Line 140: with Transaction(config=config) as _config: Line 141: _config.setNetwork(NETWORK, NETWORK_ATTRIBUTES) Line 142: -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetworkManager: configure to monitor ifcfg files
Fabian Deutsch has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files .. Patch Set 1: Code-Review+1 In the scope of https://bugzilla.redhat.com/show_bug.cgi?id=1326798 it was discussed if NM could not also handle the ifcfg files. NM-1-0 should be able to handle vlans, bridges, bonds etc. What I want to say: Another approach would be to disable network.service and enable NetworkManager.service and use NM_CONTROLLED=yes However, this patch looks sane. -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver
Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/55958/9/lib/vdsm/network/ovs/driver/__init__.py File lib/vdsm/network/ovs/driver/__init__.py: PS9, Line 130: set_db_entry Can you move this up so the abstract methods will be on top and below them we'll have all the proxies (we will probably have more with time) https://gerrit.ovirt.org/#/c/55958/9/lib/vdsm/network/ovs/driver/vsctl.py File lib/vdsm/network/ovs/driver/vsctl.py: Line 92: class CommandResultDB(Command): Line 93: Line 94: @Command.result.setter Line 95: def result(self, data): Line 96: # If check_error=False, run_vsctl can return None > this is not here anymore The comment should be dropped Line 97: if not data: Line 98: self._result = None Line 99: return Line 100: -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetworkManager: configure to monitor ifcfg files
gerrit-hooks has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files .. Patch Set 1: * #1304509::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1304509::OK, public bug * Check Product::#1304509::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: let VDSM consume a bond created by nmcli
gerrit-hooks has posted comments on this change. Change subject: tests: let VDSM consume a bond created by nmcli .. Patch Set 7: * #1304509::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1304509::OK, public bug * Check Product::#1304509::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: allow to run a DHCP server on multiple interfaces
gerrit-hooks has posted comments on this change. Change subject: tests: allow to run a DHCP server on multiple interfaces .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67819397603fc311a781fadc41fe5de88b14ed7c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetworkManager: configure to monitor ifcfg files
Ondřej Svoboda has uploaded a new change for review.
Change subject: NetworkManager: configure to monitor ifcfg files
..
NetworkManager: configure to monitor ifcfg files
The new configuration file instructs NetworkManager to
automatically reload network configuration from directories
its plugins manage:
/etc/sysconfig/network-scripts/ in the case of ifcfg systems
(Fedora, RHEL, CentOS and derivatives; ifcfg-rh plugin)
/etc/NetworkManager/system-connections/ (keyfile plugin)
and other directories (e.g. specific to Debian or Suse)
This functionality is required to properly let NetworkManager
know when VDSM consumes any of its devices (on ifcfg systems,
by writing NM_CONTROLLED=no to an ifcfg file).
TODO: NetworkManager must be restarted after installing
the new configuration file.
Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477
Bug-Url: https://bugzilla.redhat.com/1304509
Signed-off-by: Ondřej Svoboda
---
M vdsm.spec.in
A vdsm/90-vdsm-monitor-connection-files.conf
M vdsm/Makefile.am
3 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/56365/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 3b761b8..fc343c9 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -870,6 +870,8 @@
%ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/hsm-tasks
%ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/mnt
%dir %{_libexecdir}/%{vdsm_name}
+%dir %{_sysconfdir}/NetworkManager
+%dir %{_sysconfdir}/NetworkManager/conf.d
%dir %{_sysconfdir}/%{vdsm_name}
%dir %{_sysconfdir}/%{vdsm_name}/mom.d
%dir %{_datadir}/%{vdsm_name}
@@ -907,6 +909,7 @@
%{_datadir}/%{vdsm_name}/virt/vmdevices/network.py*
%{_datadir}/%{vdsm_name}/virt/vmdevices/storage.py*
+%config(noreplace)
%{_sysconfdir}/NetworkManager/conf.d/90-vdsm-monitor-connection-files.conf
%config(noreplace) %{_sysconfdir}/%{vdsm_name}/vdsm.conf
%config(noreplace) %{_sysconfdir}/%{vdsm_name}/logger.conf
%config(noreplace) %{_sysconfdir}/%{vdsm_name}/svdsm.logger.conf
diff --git a/vdsm/90-vdsm-monitor-connection-files.conf
b/vdsm/90-vdsm-monitor-connection-files.conf
new file mode 100644
index 000..03d77dd
--- /dev/null
+++ b/vdsm/90-vdsm-monitor-connection-files.conf
@@ -0,0 +1,5 @@
+# This file is necessary to let VDSM properly consume connections owned by
+# NetworkManager (to make it unmanage them), primarily on ifcfg systems.
+
+[main]
+monitor-connection-files=true
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 13c75a7..f72b97f 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -75,6 +75,7 @@
$(nodist_man8_MANS)
EXTRA_DIST = \
+ 90-vdsm-monitor-connection-files.conf \
bonding-defaults.json \
bonding-name2numeric.json \
dumpStorageTable.py.in \
@@ -121,6 +122,7 @@
install-data-logger \
install-data-logrotate \
install-data-mom \
+ install-data-networkmanager \
install-data-rwtab \
install-data-sudoers \
install-data-sysctl
@@ -148,6 +150,7 @@
uninstall-data-logger \
uninstall-data-logrotate \
uninstall-data-mom \
+ uninstall-data-networkmanager \
uninstall-data-rwtab \
uninstall-data-sudoers \
uninstall-data-sysctl
@@ -212,6 +215,15 @@
$(RM) $(DESTDIR)$(vdsmconfdir)/mom.d/*.policy
$(RM) $(DESTDIR)$(vdsmconfdir)/mom.conf
+install-data-networkmanager:
+ $(MKDIR_P) $(DESTDIR)$(sysconfdir)/NetworkManager/conf.d
+ $(INSTALL_DATA) 90-vdsm-monitor-connection-files.conf \
+ $(DESTDIR)$(sysconfdir)/NetworkManager/conf.d
+
+uninstall-data-networkmanager:
+ $(RM) $(DESTDIR)$(sysconfdir)/NetworkManager/conf.d/\
+ 90-vdsm-monitor-connection-files.conf
+
install-data-sudoers:
$(MKDIR_P) $(DESTDIR)$(sysconfdir)/sudoers.d
$(INSTALL_DATA) sudoers.vdsm \
--
To view, visit https://gerrit.ovirt.org/56365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: consume bond slaves owned by NetworkManager
gerrit-hooks has posted comments on this change. Change subject: ifcfg: consume bond slaves owned by NetworkManager .. Patch Set 2: * #1304509::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1304509::OK, public bug * Check Product::#1304509::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77a600cd3bfddc0da48ae801bb121a8093254ae2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM: Always create lv file
Adam Litke has posted comments on this change. Change subject: tests: FakeLVM: Always create lv file .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56169/1/tests/storagefakelib.py File tests/storagefakelib.py: Line 133: self.lvmd[(vgName, lvName)] = lv_md Line 134: self.vgmd[vgName]['lv_count'] = str(lv_count) Line 135: Line 136: # Create a regular file so we have a place to write data Line 137: make_file(self.lvPath(vgName, lvName), int(size)) > We should created this file only if the lv is active, simulating the behavi Done Line 138: Line 139: def activateLVs(self, vgName, lvNames): Line 140: for lv in lvNames: Line 141: try: -- To view, visit https://gerrit.ovirt.org/56169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: consume bond slaves owned by NetworkManager
gerrit-hooks has posted comments on this change. Change subject: ifcfg: consume bond slaves owned by NetworkManager .. Patch Set 1: * #1304509::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1304509::OK, public bug * Check Product::#1304509::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77a600cd3bfddc0da48ae801bb121a8093254ae2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: consume bond slaves owned by NetworkManager
Ondřej Svoboda has uploaded a new change for review. Change subject: ifcfg: consume bond slaves owned by NetworkManager .. ifcfg: consume bond slaves owned by NetworkManager On ifcfg systems NetworkManager uses the "ifcfg-rh" plugin to persist its "connections" (one could say "profiles") in the same directory as initscripts do: /etc/sysconfig/network-scripts/ (in contrast to /etc/NetworkManager/system-connections/ which is used by the default "keyfile" plugin). It can also watch the directory for changes if configured like below and automatically refresh its configuration according to changed files' content. cat /etc/NetworkManager/conf.d/90-vdsm-monitor-connection-files.conf [main] monitor-connection-files=true To let NetworkManager know VDSM wants to consume its devices we have to create ifcfg files with NM_CONTROLLED=no for all of them, not just those that differ from the expected configuration. This patch assumes the above file exists. It will be the focus of a different patch to write this file either upon installation or deployment to a hypervisor. NetworkManager would have to be restarted afterwards. TODO (possibly in different patches): make sure to always write ifcfg files for all types of devices VDSM manages. Change-Id: I77a600cd3bfddc0da48ae801bb121a8093254ae2 Bug-Url: https://bugzilla.redhat.com/1304509 Signed-off-by: Ondřej Svoboda --- M lib/vdsm/network/configurators/ifcfg.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/56364/1 diff --git a/lib/vdsm/network/configurators/ifcfg.py b/lib/vdsm/network/configurators/ifcfg.py index 6c74472..4a5bd41 100644 --- a/lib/vdsm/network/configurators/ifcfg.py +++ b/lib/vdsm/network/configurators/ifcfg.py @@ -159,7 +159,10 @@ for slave in bond.slaves: if slave.name in nicsToAdd: ifdown(slave.name) # nics must be down to join a bond -self.configApplier.addNic(slave) +# NetworkManager compatibility: ifcfg file must be written (with +# NM_CONTROLLED=no) for all NICs we want to consume. +self.configApplier.addNic(slave) +if slave.name in nicsToAdd: _exec_ifup(slave) if bondIfcfgWritten: -- To view, visit https://gerrit.ovirt.org/56364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I77a600cd3bfddc0da48ae801bb121a8093254ae2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver
Petr Horáček has posted comments on this change. Change subject: net: OVS driver .. Patch Set 9: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55958/9/lib/vdsm/network/ovs/driver/vsctl.py File lib/vdsm/network/ovs/driver/vsctl.py: Line 92: class CommandResultDB(Command): Line 93: Line 94: @Command.result.setter Line 95: def result(self, data): Line 96: # If check_error=False, run_vsctl can return None this is not here anymore Line 97: if not data: Line 98: self._result = None Line 99: return Line 100: -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts
Adam Litke has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/55987/4/vdsm/storage/sdm/volume_artifacts.py File vdsm/storage/sdm/volume_artifacts.py: Line 423: lvm.changeLVTags(sd_id, self.vol_id, Line 424: addTags=[blockVolume.TAG_PREFIX_MD + str(mdSlot)]) Line 425: meta_id = (sd_id, mdSlot) Line 426: Line 427: self.vol_class.newMetadata( Change to the VolumeMetadata implementation. Line 428: meta_id, Line 429: sd_id, Line 430: self.img_id, Line 431: parent_vol_id, -- To view, visit https://gerrit.ovirt.org/55987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: use Transaction for rollback triggering
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: use Transaction for rollback triggering .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ea7e4c7c47591650c31f84f0aac40c8a7f4c842 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
gerrit-hooks has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver
Petr Horáček has posted comments on this change. Change subject: net: OVS driver .. Patch Set 9: Verified+1 Passed ovs_driver_test.py -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver
gerrit-hooks has posted comments on this change. Change subject: net: OVS driver .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor metadata operations
Adam Litke has posted comments on this change.
Change subject: Refactor metadata operations
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52671/2/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 212:
Line 213: def info(self):
Line 214: """
Line 215: Return metadata in dictionary format
Line 216: """
This is a legacy function. Name it legacy_info and add a comment.
Line 217: return {
Line 218: FORMAT: str(self.vol_format),
Line 219: TYPE: str(self.prealloc),
Line 220: VOLTYPE: str(self.vol_type),
--
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver
gerrit-hooks has posted comments on this change. Change subject: net: OVS driver .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Remove pep8 and pyflakes requirement
Dan Kenigsberg has posted comments on this change. Change subject: build: Remove pep8 and pyflakes requirement .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: use Transaction for rollback triggering
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: use Transaction for rollback triggering .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ea7e4c7c47591650c31f84f0aac40c8a7f4c842 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver
gerrit-hooks has posted comments on this change. Change subject: net: OVS driver .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovs network setup
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
gerrit-hooks has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovs network setup
Petr Horáček has uploaded a new change for review.
Change subject: net: native ovs: ovs network setup
..
net: native ovs: ovs network setup
TODO: commit msg, tests
Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček
---
M lib/vdsm/network/ovs/Makefile.am
A lib/vdsm/network/ovs/ovs.py
M lib/vdsm/network/ovs/switch.py
M vdsm.spec.in
4 files changed, 130 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/56353/1
diff --git a/lib/vdsm/network/ovs/Makefile.am b/lib/vdsm/network/ovs/Makefile.am
index 756f942..bc39611 100644
--- a/lib/vdsm/network/ovs/Makefile.am
+++ b/lib/vdsm/network/ovs/Makefile.am
@@ -25,6 +25,7 @@
dist_vdsmnetworkovs_PYTHON = \
__init__.py \
+ ovs.py \
switch.py \
validator.py \
$(NULL)
diff --git a/lib/vdsm/network/ovs/ovs.py b/lib/vdsm/network/ovs/ovs.py
new file mode 100644
index 000..305c5d3
--- /dev/null
+++ b/lib/vdsm/network/ovs/ovs.py
@@ -0,0 +1,125 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+import six
+
+from .driver import create
+
+
+BRIDGE_NAME = 'ovsbr0' # TODO: support multiple bridges
+
+ovsdb = create()
+
+
+def _get_nets_by_nics(running_config):
+"""Transform running config into {nic: set(networks)}."""
+nets_by_nic = {}
+for net, attrs in six.iteritems(running_config.networks):
+nic = attrs.get('nic')
+if nic is not None:
+nets_by_nic.setdefault(nic, set()).add(net)
+return nets_by_nic
+
+
+def _add_nic_port(net, nic, nets_by_nic):
+if nic in nets_by_nic:
+nets_by_nic[nic].add(net)
+return ovsdb.do_nothing()
+else:
+nets_by_nic[nic] = set([net])
+return ovsdb.add_port(BRIDGE_NAME, nic, may_exist=True)
+
+
+def _del_nic_port(net, nic, nets_by_nic):
+nets_by_nic[nic].remove(net)
+if len(nets_by_nic[nic]) == 0:
+return ovsdb.del_port(BRIDGE_NAME, nic, if_exists=True)
+else:
+return ovsdb.do_nothing()
+
+
+def _add_ovs_net(net, attrs, running_config, nets_by_nic):
+commands = []
+nic = attrs.get('nic')
+vlan = attrs.get('vlan')
+
+if vlan is not None:
+commands.append(
+ovsdb.add_vlan(BRIDGE_NAME, vlan, fake_bridge_name=net))
+if nic is not None:
+commands.append(_add_nic_port(net, nic, nets_by_nic))
+
+running_config.setNetwork(net, attrs)
+return commands
+
+
+def _remove_ovs_net(net, running_config, nets_by_nic):
+commands = []
+net_conf = running_config.networks.get(net)
+
+if 'vlan' in net_conf:
+commands.append(ovsdb.del_br(net)) # TODO: use del_vlan when fixed
+if 'nic' in net_conf:
+commands.append(_del_nic_port(net, net_conf.get('nic'), nets_by_nic))
+
+running_config.removeNetwork(net)
+return commands
+
+
+def _prepare_addition(nets, running_config):
+commands = []
+nets_by_nic = _get_nets_by_nics(running_config)
+for net, attrs in six.iteritems(nets):
+commands.extend(
+_add_ovs_net(net, attrs, running_config, nets_by_nic))
+return commands
+
+
+def _prepare_removal(nets, running_config):
+commands = []
+nets_by_nic = _get_nets_by_nics(running_config)
+for net in nets:
+commands.extend(_remove_ovs_net(net, running_config, nets_by_nic))
+return commands
+
+
+def remove(nets, running_config):
+commands = _prepare_removal(nets, running_config)
+with ovsdb.transaction() as t:
+t.add(*commands)
+# TODO: We need to store running_config, so optional rollback is able to
+# obtain 'ovs' switch type and do proper rollback. Note, that running
+# config should contain only correct entries and this should be dropped
+# when _split_switch_type_entries() is able to get switch type from kernel
+# config.
+running_config.save()
+
+
+def add(nets, running_config):
+commands = _prepare_addition(nets, running_config)
+with ovsdb.transaction() as t:
+t.add(ovsdb.add_br(BRIDGE_NAME, may_exist=True))
+t.add(*comman
Change in vdsm[master]: net: native ovs: use Transaction for rollback triggering
Petr Horáček has uploaded a new change for review. Change subject: net: native ovs: use Transaction for rollback triggering .. net: native ovs: use Transaction for rollback triggering Use generic netconfpersistence.Transaction() instead of custom ovs.switch.rollback_trigger(). Change-Id: I3ea7e4c7c47591650c31f84f0aac40c8a7f4c842 Bug-Url: https://bugzilla.redhat.com/1195208 Signed-off-by: Petr Horáček --- M lib/vdsm/netconfpersistence.py M lib/vdsm/network/netswitch.py M lib/vdsm/network/ovs/switch.py 3 files changed, 5 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/56352/1 diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py index 954b981..d0321c8 100644 --- a/lib/vdsm/netconfpersistence.py +++ b/lib/vdsm/netconfpersistence.py @@ -228,7 +228,7 @@ self.in_rollback = in_rollback def __enter__(self): -yield self.config +return self.config def __exit__(self, ex_type, ex_value, ex_traceback): if ex_type is None: diff --git a/lib/vdsm/network/netswitch.py b/lib/vdsm/network/netswitch.py index c58e52a..c4ecc03 100644 --- a/lib/vdsm/network/netswitch.py +++ b/lib/vdsm/network/netswitch.py @@ -23,7 +23,7 @@ from vdsm.netinfo.cache import (libvirtNets2vdsm, get as netinfo_get, CachingNetInfo) from vdsm.netinfo import networks as libvirt_nets -from vdsm.netconfpersistence import RunningConfig +from vdsm.netconfpersistence import RunningConfig, Transaction from . import connectivity from . import legacy_switch @@ -133,6 +133,6 @@ def _setup_ovs(networks, bondings, options, in_rollback): -with ovs_switch.rollback_trigger(in_rollback): -ovs_switch.setup(networks, bondings) +with Transaction(in_rollback=in_rollback) as running_config: +ovs_switch.setup(networks, bondings, running_config) connectivity.check(options) diff --git a/lib/vdsm/network/ovs/switch.py b/lib/vdsm/network/ovs/switch.py index 242e41e..b5c3e25 100644 --- a/lib/vdsm/network/ovs/switch.py +++ b/lib/vdsm/network/ovs/switch.py @@ -18,8 +18,6 @@ # from __future__ import absolute_import -from contextlib import contextmanager - import six from vdsm.netconfpersistence import RunningConfig @@ -40,18 +38,7 @@ validator.validate_bond_configuration(attrs, kernel_nics) -@contextmanager -def rollback_trigger(in_rollback): -try: -yield -except: -pass -finally: -pass - - -def setup(nets, bonds): -running_config = RunningConfig() +def setup(nets, bonds, running_config): nets_to_be_added, nets_to_be_removed = _split_nets_action( nets, running_config.networks) bonds_to_be_added_or_edited, bonds_to_be_removed = _split_bonds_action( -- To view, visit https://gerrit.ovirt.org/56352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ea7e4c7c47591650c31f84f0aac40c8a7f4c842 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: require specific pep8 version
David Caro has posted comments on this change. Change subject: require specific pep8 version .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56148/1/automation/check-patch.packages.el7 File automation/check-patch.packages.el7: Line 15: python-inotify Line 16: python-ioprocess Line 17: python-netaddr Line 18: python-nose Line 19: python-pep8=1.5.7 > with this, if you run locally with mock_runner, what do you get? So, a couple of points here: * You should specify the version as yum accepts it, the '=' does not work for me in yum, this does 'python-pep8-1.4.6-2.el7' * There's no python-pep8 1.5.7 available from any of the repos, you should find a repo that has it, or specify a full url to it (http://mycustom.repo/python-pep8-1.5.7-1.el7.noarch.rpm) Line 20: python-pthreading Line 21: python-rtslib Line 22: python-six Line 23: python34-nose -- To view, visit https://gerrit.ovirt.org/56148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie47f108c2065d5bd0e4e0e987121f91db4868397 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add is_assignable flag
gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fd0d39e777c6bc0f3175b737ace9be92df4cca0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: get is_assignable from libvirt when available
gerrit-hooks has posted comments on this change. Change subject: hostdev: get is_assignable from libvirt when available .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80560c0202a494afd15795156d618104b644c4de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: require specific pep8 version
David Caro has posted comments on this change. Change subject: require specific pep8 version .. Patch Set 1: Unfortunately, it does not seem to work (running locally), debugging -- To view, visit https://gerrit.ovirt.org/56148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie47f108c2065d5bd0e4e0e987121f91db4868397 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: let VDSM consume a bond created by nmcli
gerrit-hooks has posted comments on this change. Change subject: tests: let VDSM consume a bond created by nmcli .. Patch Set 6: * #1304509::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1304509::OK, public bug * Check Product::#1304509::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: allow to run a DHCP server on multiple interfaces
gerrit-hooks has posted comments on this change. Change subject: tests: allow to run a DHCP server on multiple interfaces .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67819397603fc311a781fadc41fe5de88b14ed7c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: get is_assignable from libvirt when available
Francesco Romani has posted comments on this change. Change subject: hostdev: get is_assignable from libvirt when available .. Patch Set 1: Code-Review-1 (1 comment) seems ok, even though wasteful (doing twice the same work) -1 for visibility https://gerrit.ovirt.org/#/c/56299/1/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS1, Line 192: params['is_assignable'] = is_assignable so we always override what we learned in line 155 above, possibly doing twice the same work? -- To view, visit https://gerrit.ovirt.org/56299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80560c0202a494afd15795156d618104b644c4de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver
Petr Horáček has posted comments on this change. Change subject: net: OVS driver .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55958/6/lib/vdsm/network/ovs/driver/vsctl.py File lib/vdsm/network/ovs/driver/vsctl.py: PS6, Line 159: bridge bridge is not used here -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: move helper into Progress class
Francesco Romani has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56313/5/tests/vmMigrationTests.py File tests/vmMigrationTests.py: PS5, Line 202: # data_remaining and data_total are both VIR_TYPED_PARAM_ULLONG : # so we cannot get negative values here > As we discussed off-gerrit, I still believe that negative tests or raising And you are just right. -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e5a5cdf2249d73ef45c4f50e1fa6c4338ad8a0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: get is_assignable from libvirt when available
Martin Polednik has posted comments on this change. Change subject: hostdev: get is_assignable from libvirt when available .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56299/1/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS1, Line 192: params['is_assignable'] = is_assignable > so we always override what we learned in line 155 above, possibly doing twi 155 must be dropped. -- To view, visit https://gerrit.ovirt.org/56299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80560c0202a494afd15795156d618104b644c4de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add is_assignable flag
Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: Code-Review+1 (2 comments) minor style nit, +2 on hold. https://gerrit.ovirt.org/#/c/56291/3/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS3, Line 249: device_params['is_assignable'] == 'true' and utils.tobool(device_params['is_assignable']) ? not really sure this is better. Your call. PS3, Line 268: device_params['is_assignable'] == 'true' same -- To view, visit https://gerrit.ovirt.org/56291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fd0d39e777c6bc0f3175b737ace9be92df4cca0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: require specific pep8 version
David Caro has posted comments on this change. Change subject: require specific pep8 version .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56148/1/automation/check-patch.packages.el7 File automation/check-patch.packages.el7: Line 15: python-inotify Line 16: python-ioprocess Line 17: python-netaddr Line 18: python-nose Line 19: python-pep8=1.5.7 > I'm trying to figure how we still get pep8 1.4.7 in some el7 jobs .. this i with this, if you run locally with mock_runner, what do you get? mock_runner.sh -p el7 Line 20: python-pthreading Line 21: python-rtslib Line 22: python-six Line 23: python34-nose -- To view, visit https://gerrit.ovirt.org/56148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie47f108c2065d5bd0e4e0e987121f91db4868397 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: re-enable setNumberOfCpus tests
gerrit-hooks has posted comments on this change. Change subject: tests: re-enable setNumberOfCpus tests .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66fbf32767cd5c5501efe2d3f4d7af53ef2f6e3f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: conf: proper locking in onConnect()
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in onConnect() .. Patch Set 7: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug * Check Product::#1318550::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f75630e204708bb4352f68240550b2b454806cc Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: conf: proper locking in status()
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in status() .. Patch Set 7: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug * Check Product::#1318550::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I397562bb94c8b696a0b34484907e7d489a800878 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: conf: proper locking in setNumberOfCpus()
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in setNumberOfCpus() .. Patch Set 7: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug * Check Product::#1318550::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20822e31af1e7350833d9c3080efc5d0f79a5cbe Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: re-enable setNumberOfCpus tests
Francesco Romani has uploaded a new change for review.
Change subject: tests: re-enable setNumberOfCpus tests
..
tests: re-enable setNumberOfCpus tests
This test was disabled time ago because on CI it tried to connect
to libvirt. It is time to re-enable it, and to fix it.
Change-Id: I66fbf32767cd5c5501efe2d3f4d7af53ef2f6e3f
Signed-off-by: Francesco Romani
---
M tests/vmOperationsTests.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/56348/1
diff --git a/tests/vmOperationsTests.py b/tests/vmOperationsTests.py
index 67e974b..eb037b5 100644
--- a/tests/vmOperationsTests.py
+++ b/tests/vmOperationsTests.py
@@ -276,7 +276,6 @@
self.assertEqual(period + offset,
testvm._vcpuTuneInfo['vcpu_period'])
-@brokentest("sometimes on CI tries to connect to libvirt")
@permutations([[libvirt.VIR_ERR_OPERATION_DENIED, 'setNumberOfCpusErr',
'Failed to set the number of cpus'],
[libvirt.VIR_ERR_NO_DOMAIN, 'noVM', None]])
--
To view, visit https://gerrit.ovirt.org/56348
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66fbf32767cd5c5501efe2d3f4d7af53ef2f6e3f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: move helper into Progress class
Martin Polednik has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56313/5/tests/vmMigrationTests.py File tests/vmMigrationTests.py: PS5, Line 202: # data_remaining and data_total are both VIR_TYPED_PARAM_ULLONG : # so we cannot get negative values here As we discussed off-gerrit, I still believe that negative tests or raising an exception in case where either value is <0 is relevant - might help us catch libvirt error. -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e5a5cdf2249d73ef45c4f50e1fa6c4338ad8a0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: conf: proper locking in onDisconnect()
Francesco Romani has abandoned this change. Change subject: vm: conf: proper locking in onDisconnect() .. Abandoned we don't need this now -- To view, visit https://gerrit.ovirt.org/54908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I372e31b7b0d6eb6f8b69871b65e9243ee3ee45a2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: conf: proper locking in onDisconnect()
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in onDisconnect() .. Patch Set 6: * #1318550::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/54908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I372e31b7b0d6eb6f8b69871b65e9243ee3ee45a2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add device setup and teardown
Martin Polednik has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 8: Verified+1 works w/ supplied tests, fixes hostdev, doesn't break general usage -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require test-only py3 packages
Shahar Havivi has posted comments on this change. Change subject: spec: require test-only py3 packages .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4d08a4136efe1289f6c9f907196b4e6f089f144 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: get is_assignable from libvirt when available
Martin Polednik has posted comments on this change. Change subject: hostdev: get is_assignable from libvirt when available .. Patch Set 1: Verified+1 tested by logging path type, libvirt one is prefered (unfortunately only for bridges/cardbus bridges) -- To view, visit https://gerrit.ovirt.org/56299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80560c0202a494afd15795156d618104b644c4de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add device setup and teardown
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1688: """
Line 1689: Runs after the underlying libvirt domain was destroyed.
Line 1690: """
Line 1691: for dev_objects in self._devices.values():
Line 1692: for dev_object in dev_objects[:]:
> This is already (luckily) used throughout devices. I don't see conf['device
This will be removed sooner or later, we cannot continue to work with the
current state of the code.
Line 1693: try:
Line 1694: dev_object.teardown()
Line 1695: except Exception:
Line 1696: self.log.exception("Failed to teardown device.")
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
Petr Horáček has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 5: Verified+1 conf_persistence_test.py are passing, functional tests are not exposed. -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
gerrit-hooks has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: expose hotplug via vdsClient
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose hotplug via vdsClient .. Patch Set 14: * #1234283::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234283::OK, public bug * Check Product::#1234283::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46fb415c39d04b94428703ac19da505a2cf2800d Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: use setup instead of detach in hotplug
gerrit-hooks has posted comments on this change. Change subject: hostdev: use setup instead of detach in hotplug .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96853249e32c7b15c6a1c11b5a1ab385d7c4c827 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sr-iov: use device setup instead of detach
gerrit-hooks has posted comments on this change. Change subject: sr-iov: use device setup instead of detach .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c97af2ea9f17ef38f9dbb4f41e5f9d1da9eebaa Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add vdsClient hotunplug command
gerrit-hooks has posted comments on this change. Change subject: hostdev: add vdsClient hotunplug command .. Patch Set 14: * #1234283::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234283::OK, public bug * Check Product::#1234283::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie00e5510b5306d689536b24091411332c8b80e75 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Let the engine control the guest lifecycle events
Vinzenz Feenstra has posted comments on this change.
Change subject: Let the engine control the guest lifecycle events
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56286/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 265: self.log.exception("Failed to destroy remote VM")
Line 266: # if the guest was stopped before migration, we need to cont
it
Line 267: if self.hibernating:
Line 268: self._vm.cont()
Line 269: if self._enableGuestEvents:
> instead of adding if()s all around, could be worth to move this check insid
well I was thinking about it, however this comes in via the API on the
'migrate' call, so I would have to set it in the guest agent and unset it
afterwards?
Line 270: self._vm.guestAgent.events.after_hibernation_failure()
Line 271: elif self._enableGuestEvents:
Line 272: self._vm.guestAgent.events.after_migration_failure()
Line 273: # either way, migration has finished
--
To view, visit https://gerrit.ovirt.org/56286
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b78489169260ed53420a3b3fda33a0cc917d66c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: expose parameters needed to support hotunplug
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose parameters needed to support hotunplug .. Patch Set 14: * #1234283::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234283::OK, public bug * Check Product::#1234283::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for hotunplug
gerrit-hooks has posted comments on this change. Change subject: hostdev: add support for hotunplug .. Patch Set 16: * #1234283::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234283::OK, public bug * Check Product::#1234283::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/42747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add the migration/hibernation event handling (GuestAgent)
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Add the migration/hibernation event handling (GuestAgent)
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/51782/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 138:
Line 139: ('guest_agent_timeout', '30',
Line 140: 'Time (in sec) to wait for guest agent.'),
Line 141:
Line 142: ('guest_lifecycle_event_reply_timeout', '10',
> I'd love to have a [guest] section in the config, please consider adding it
I could create the guest section, but how do we migrate the existing values?
Line 143: 'Time (in sec) to wait for the guest agent to reply on
lifecycle'
Line 144: ' events (such as before_migration/before_hibernation'),
Line 145:
Line 146: ('vm_command_timeout', '60',
--
To view, visit https://gerrit.ovirt.org/51782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If298709e7c7788e33003643dbd628f4f48e55366
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: conf: proper locking in setNumberOfCpus()
Francesco Romani has posted comments on this change. Change subject: vm: conf: proper locking in setNumberOfCpus() .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/54910/6/tests/vmOperationsTests.py File tests/vmOperationsTests.py: PS6, Line 299: @permutations([[1], [2], [4], [16]]) : def testSetNumberOfVcpus(self, smp): > looking at testSetNumberOfVcpusFailed, don't we need similar protection for good point -- To view, visit https://gerrit.ovirt.org/54910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20822e31af1e7350833d9c3080efc5d0f79a5cbe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: require specific pep8 version
Yaniv Bronhaim has posted comments on this change. Change subject: require specific pep8 version .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56148/1/automation/check-patch.packages.el7 File automation/check-patch.packages.el7: Line 15: python-inotify Line 16: python-ioprocess Line 17: python-netaddr Line 18: python-nose Line 19: python-pep8=1.5.7 > It should, any yum valid string here should work (dnf on fc>=22) I'm trying to figure how we still get pep8 1.4.7 in some el7 jobs .. this is the real issue actually Line 20: python-pthreading Line 21: python-rtslib Line 22: python-six Line 23: python34-nose -- To view, visit https://gerrit.ovirt.org/56148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie47f108c2065d5bd0e4e0e987121f91db4868397 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require test-only py3 packages
Yaniv Bronhaim has posted comments on this change. Change subject: spec: require test-only py3 packages .. Patch Set 1: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/56337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4d08a4136efe1289f6c9f907196b4e6f089f144 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: allow to run a DHCP server on multiple interfaces
gerrit-hooks has posted comments on this change. Change subject: tests: allow to run a DHCP server on multiple interfaces .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67819397603fc311a781fadc41fe5de88b14ed7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: allow to run a DHCP server on multiple interfaces
Ondřej Svoboda has uploaded a new change for review.
Change subject: tests: allow to run a DHCP server on multiple interfaces
..
tests: allow to run a DHCP server on multiple interfaces
Change-Id: I67819397603fc311a781fadc41fe5de88b14ed7c
Signed-off-by: Ondřej Svoboda
---
M tests/functional/networkTests.py
M tests/functional/networkTestsOVS.py
M tests/network/dhcp.py
M tests/network/netinfo_test.py
M tests/network/nettestlib.py
5 files changed, 20 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/56342/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index fd8be29..b77943a 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1428,7 +1428,7 @@
self.vdsm_net.save_config()
-with dnsmasq_run(server, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+with dnsmasq_run([server], DHCP_RANGE_FROM, DHCP_RANGE_TO,
DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY):
with namedTemporaryDir(dir='/var/lib/dhclient') as dhdir:
dhclient_runner = dhcp.DhclientRunner(client, 4, dhdir,
@@ -2029,7 +2029,7 @@
addrAdd(left, IP_ADDRESS, IP_CIDR)
addrAdd(left, IPv6_ADDRESS, IPv6_CIDR, 6)
linkSet(left, ['up'])
-with dnsmasq_run(left, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+with dnsmasq_run([left], DHCP_RANGE_FROM, DHCP_RANGE_TO,
DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY):
dhcpv4 = 4 in families
dhcpv6 = 6 in families
@@ -2078,7 +2078,7 @@
addrAdd(left, IP_ADDRESS, IP_CIDR)
addrAdd(left, IPv6_ADDRESS, IPv6_CIDR, 6)
linkSet(left, ['up'])
-with dnsmasq_run(left, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+with dnsmasq_run([left], DHCP_RANGE_FROM, DHCP_RANGE_TO,
DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY):
# first, a network without a bridge should get a certain
@@ -2158,7 +2158,7 @@
with veth_pair() as (left, right):
addrAdd(left, IP_ADDRESS, IP_CIDR)
linkSet(left, ['up'])
-with dnsmasq_run(left, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+with dnsmasq_run([left], DHCP_RANGE_FROM, DHCP_RANGE_TO,
DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY):
try:
setup_test_network(dhcp=True)
@@ -2176,7 +2176,7 @@
addrAdd(server, IPv6_ADDRESS, IPv6_CIDR, 6)
linkSet(server, ['up'])
-with dnsmasq_run(server, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+with dnsmasq_run([server], DHCP_RANGE_FROM, DHCP_RANGE_TO,
DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY):
with namedTemporaryDir(dir='/var/lib/dhclient') as dir:
@@ -2447,7 +2447,7 @@
with veth_pair() as (server, client):
addrAdd(server, IP_ADDRESS, IP_CIDR)
linkSet(server, ['up'])
-with dnsmasq_run(server, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+with dnsmasq_run([server], DHCP_RANGE_FROM, DHCP_RANGE_TO,
DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY):
with namedTemporaryDir(dir='/var/lib/dhclient') as dhdir:
# Start a non-vdsm owned dhclient for the 'client' iface
diff --git a/tests/functional/networkTestsOVS.py
b/tests/functional/networkTestsOVS.py
index 166f205..21b8e91 100644
--- a/tests/functional/networkTestsOVS.py
+++ b/tests/functional/networkTestsOVS.py
@@ -205,7 +205,7 @@
addrAdd(left, IP_ADDRESS, IP_CIDR)
addrAdd(left, IPv6_ADDRESS, IPv6_CIDR, 6)
linkSet(left, ['up'])
-with dnsmasq_run(left, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+with dnsmasq_run([left], DHCP_RANGE_FROM, DHCP_RANGE_TO,
DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY):
network = {
NETWORK_NAME: {'nic': right, 'bootproto': 'dhcp',
@@ -298,7 +298,7 @@
addrAdd(left, IP_ADDRESS, IP_CIDR)
addrAdd(left, IPv6_ADDRESS, IPv6_CIDR, 6)
linkSet(left, ['up'])
-with dnsmasq_run(left, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+with dnsmasq_run([left], DHCP_RANGE_FROM, DHCP_RANGE_TO,
DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY):
dhcpv4 = 4 in families
dhcpv6 = 6 in families
diff --git a/tests/network/dhcp.py b/tests/network/dhcp.py
index 5bbfe98..8a1d601 100644
--- a/tests/network/dhcp.py
+++ b/tests/network/dhcp.py
@@ -45,13 +45,14 @@
def __init__(self):
self.proc = None
-def start(self, interface, dhcp_range_from=None, dhcp_range_to=None,
+def start(self, inter
Change in vdsm[master]: tests: let VDSM consume a bond created by nmcli
gerrit-hooks has posted comments on this change. Change subject: tests: let VDSM consume a bond created by nmcli .. Patch Set 5: * #1304509::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1304509::OK, public bug * Check Product::#1304509::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: fix logging
gerrit-hooks has posted comments on this change. Change subject: migration: fix logging .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/56336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe16f15bd3dfad3d8f4bcb97dac3c2e3e00d7021 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: fix logging
Dan Kenigsberg has posted comments on this change. Change subject: migration: fix logging .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe16f15bd3dfad3d8f4bcb97dac3c2e3e00d7021 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for sampling.VMBulkSampler
gerrit-hooks has posted comments on this change. Change subject: tests: add tests for sampling.VMBulkSampler .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ec7d5f2fc3b9b5c3efbffe874ad6ceefe7a3406 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for sampling.VMBulkSampler
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: add tests for sampling.VMBulkSampler .. tests: add tests for sampling.VMBulkSampler The VMBulkSampler class is responsible of the bulk stats sampling, and includes all the logic to deal with blocked domains. This patch add the initial batch of tests to exercise this code. Change-Id: I3ec7d5f2fc3b9b5c3efbffe874ad6ceefe7a3406 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/55856 Continuous-Integration: Jenkins CI Reviewed-by: Martin Polednik Reviewed-by: Dan Kenigsberg --- M tests/Makefile.am A tests/bulk_sampling_test.py 2 files changed, 287 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ec7d5f2fc3b9b5c3efbffe874ad6ceefe7a3406 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for sampling.VMBulkSampler
Dan Kenigsberg has posted comments on this change. Change subject: tests: add tests for sampling.VMBulkSampler .. Patch Set 5: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/55856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ec7d5f2fc3b9b5c3efbffe874ad6ceefe7a3406 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: fix logging
Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: fix logging .. migration: fix logging We now log VIR_DOMAIN_JOB_MEMORY_CONSTANT while monitoring migration, but this value is in pages, not in bytes. Change-Id: Ibe16f15bd3dfad3d8f4bcb97dac3c2e3e00d7021 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/56336 Continuous-Integration: Jenkins CI Reviewed-by: Martin Polednik Reviewed-by: Dan Kenigsberg --- M vdsm/virt/migration.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe16f15bd3dfad3d8f4bcb97dac3c2e3e00d7021 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: move helper into Progress class
gerrit-hooks has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e5a5cdf2249d73ef45c4f50e1fa6c4338ad8a0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: add 'ongoing' property to Progress
gerrit-hooks has posted comments on this change. Change subject: migration: add 'ongoing' property to Progress .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I275aef473f87fc69c38c0a80e15c328e128993c7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: conf: proper locking in setNumberOfCpus()
Martin Polednik has posted comments on this change. Change subject: vm: conf: proper locking in setNumberOfCpus() .. Patch Set 6: Code-Review-1 (1 comment) question inside (CI related) https://gerrit.ovirt.org/#/c/54910/6/tests/vmOperationsTests.py File tests/vmOperationsTests.py: PS6, Line 299: @permutations([[1], [2], [4], [16]]) : def testSetNumberOfVcpus(self, smp): looking at testSetNumberOfVcpusFailed, don't we need similar protection for CI? -- To view, visit https://gerrit.ovirt.org/54910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20822e31af1e7350833d9c3080efc5d0f79a5cbe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for sampling.VMBulkSampler
Martin Polednik has posted comments on this change. Change subject: tests: add tests for sampling.VMBulkSampler .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ec7d5f2fc3b9b5c3efbffe874ad6ceefe7a3406 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: move helper into Progress class
Francesco Romani has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56313/4/tests/vmMigrationTests.py File tests/vmMigrationTests.py: PS4, Line 195: [0, 0, 0], : [0, 100, 100], : [100, 100, 0], : [50, 100, 50], : [33, 100, 67], : [1, 100, 99], : [99, 100, 1], > For sake of completeness please add negative tests. good idea, will do -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e5a5cdf2249d73ef45c4f50e1fa6c4338ad8a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: add 'ongoing' property to Progress
Martin Polednik has posted comments on this change. Change subject: migration: add 'ongoing' property to Progress .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I275aef473f87fc69c38c0a80e15c328e128993c7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: move helper into Progress class
Martin Polednik has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56313/4/tests/vmMigrationTests.py File tests/vmMigrationTests.py: PS4, Line 195: [0, 0, 0], : [0, 100, 100], : [100, 100, 0], : [50, 100, 50], : [33, 100, 67], : [1, 100, 99], : [99, 100, 1], For sake of completeness please add negative tests. [negative, negative, ??] [negative, positive, ??] ... -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e5a5cdf2249d73ef45c4f50e1fa6c4338ad8a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: conf: proper locking in setNumberOfCpus()
Francesco Romani has posted comments on this change. Change subject: vm: conf: proper locking in setNumberOfCpus() .. Patch Set 6: at least now we have transactional semantics. This should not affect the rhbz#1318550 however. -- To view, visit https://gerrit.ovirt.org/54910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20822e31af1e7350833d9c3080efc5d0f79a5cbe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs [5]: rollback trigger
Petr Horáček has abandoned this change. Change subject: net: native ovs [5]: rollback trigger .. Abandoned -- To view, visit https://gerrit.ovirt.org/55312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5bceae0aada964c47aacfcfdbe93ca19eb8f3d15 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver
Petr Horáček has posted comments on this change. Change subject: net: OVS driver .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs [5]: rollback trigger
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [5]: rollback trigger .. Patch Set 8: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/55312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bceae0aada964c47aacfcfdbe93ca19eb8f3d15 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: fix logging
Martin Polednik has posted comments on this change. Change subject: migration: fix logging .. Patch Set 1: Code-Review+1 we could always introduce megapages... :) -- To view, visit https://gerrit.ovirt.org/56336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe16f15bd3dfad3d8f4bcb97dac3c2e3e00d7021 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for hotunplug
gerrit-hooks has posted comments on this change. Change subject: hostdev: add support for hotunplug .. Patch Set 15: * #1234283::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234283::OK, public bug * Check Product::#1234283::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/42747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add vdsClient hotunplug command
gerrit-hooks has posted comments on this change. Change subject: hostdev: add vdsClient hotunplug command .. Patch Set 13: * #1234283::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234283::OK, public bug * Check Product::#1234283::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie00e5510b5306d689536b24091411332c8b80e75 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: use setup instead of detach in hotplug
gerrit-hooks has posted comments on this change. Change subject: hostdev: use setup instead of detach in hotplug .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96853249e32c7b15c6a1c11b5a1ab385d7c4c827 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: expose hotplug via vdsClient
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose hotplug via vdsClient .. Patch Set 13: * #1234283::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234283::OK, public bug * Check Product::#1234283::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46fb415c39d04b94428703ac19da505a2cf2800d Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: expose parameters needed to support hotunplug
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose parameters needed to support hotunplug .. Patch Set 13: * #1234283::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234283::OK, public bug * Check Product::#1234283::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: use setup instead of detach in hotplug
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: use setup instead of detach in hotplug
..
hostdev: use setup instead of detach in hotplug
Change-Id: I96853249e32c7b15c6a1c11b5a1ab385d7c4c827
Signed-off-by: Martin Polednik
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/56338/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7a17a16..920e30a 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2135,7 +2135,7 @@
**dev_spec)
dev_objects.append(dev_object)
try:
-dev_object.detach()
+dev_object.setup()
except libvirt.libvirtError:
# We couldn't detach one of the devices. Halt.
self.log.exception('Could not detach a device from a host.')
--
To view, visit https://gerrit.ovirt.org/56338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96853249e32c7b15c6a1c11b5a1ab385d7c4c827
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: add Transaction() to netconfpersistence
gerrit-hooks has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add is_assignable flag
Martin Polednik has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: Verified+1 works as expected, reports 'false' for bridges (don't have cardbus available) -- To view, visit https://gerrit.ovirt.org/56291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fd0d39e777c6bc0f3175b737ace9be92df4cca0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for sampling.VMBulkSampler
Francesco Romani has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 5:
seems worse than that:
00:09:05.507 ../tests/run_tests_local.sh: line 6: 17806 Segmentation fault
(core dumped) PYTHONDONTWRITEBYTECODE=1 LC_ALL=C
NOSE_VERBOSE=${NOSE_VERBOSE:-3}
PYTHONPATH="../lib:../vdsm:../client:../vdsm_api:$PYTHONPATH" "$PYTHON_EXE"
../tests/testrunner.py --local-modules $@
--
To view, visit https://gerrit.ovirt.org/55856
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ec7d5f2fc3b9b5c3efbffe874ad6ceefe7a3406
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
