date:20160705

Change in vdsm[master]: tests: Add test for testing the timeout mechanism

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: tests: Add test for testing the timeout mechanism
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/58423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia405789ccff21f58bdaafefe1dcefa98e5d5f933
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Terminate watcher when tests fail

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: tests: Terminate watcher when tests fail
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief975ac59c8c3ec106c42c93d5cb2a2fd32b69c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Enable tests watcher only if TIMEOUT set

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: tests: Enable tests watcher only if TIMEOUT set
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60240
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c7f862770402ab05bd64e735123d63758c37ef0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Enable tests watcher only if TIMEOUT set

2016-07-05 Thread nsoffer

Nir Soffer has uploaded a new change for review.

Change subject: tests: Enable tests watcher only if TIMEOUT set
..

tests: Enable tests watcher only if TIMEOUT set

When running tests locally we don't need the watcher; if tests get
stuck, we can attach to the process with gdb manually.

To use the watcher locally, set TIMEOUT:

TIMEOUT=600 ./run_tests_local.sh foobar_test.py

Change-Id: I7c7f862770402ab05bd64e735123d63758c37ef0
Signed-off-by: Nir Soffer 
---
M tests/README
M tests/run_tests_local.sh.in
2 files changed, 24 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/60240/1

diff --git a/tests/README b/tests/README
index 198ce08..2e771c0 100644
--- a/tests/README
+++ b/tests/README
@@ -60,10 +60,9 @@
 Test timeout
 
 
-If a test run is too slow, it is aborted, and a backtrace of all threads is
-printed.
+If TIMEOUT environment variable is set, and a test run is too slow, it is
+aborted, and a backtrace of all threads is printed.
 
-To use a different timeout for the tests temporary, set the TIMEOUT environment
-varaible to the desired value:
+Example usage:
 
 TIMEOUT=600 ./run_tests_local.sh foo_test.py
diff --git a/tests/run_tests_local.sh.in b/tests/run_tests_local.sh.in
index 1b467e2..a2c38c5 100644
--- a/tests/run_tests_local.sh.in
+++ b/tests/run_tests_local.sh.in
@@ -3,8 +3,6 @@
 PYTHON_EXE="@PYTHON@"
 fi
 
-TIMEOUT=${TIMEOUT:-300}
-
 export \
 LC_ALL=C \
 NOSE_LOGFORMAT='%(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) 
%(message)s' \
@@ -16,26 +14,30 @@
 "$PYTHON_EXE" @top_srcdir@/tests/testrunner.py --local-modules -A 
"type!='functional'" $@ &
 runner_pid=$!
 
-(
-sleep $TIMEOUT
-echo
-echo 
""
-echo "=   Timeout completing tests - extracting stacktrace 
  ="
-echo 
""
-echo
-gdb -p $runner_pid --batch -ex "thread apply all py-bt"
-echo
-echo 
""
-echo "=Aborting tests  
  ="
-echo 
""
-kill -KILL $runner_pid
-sleep 5
-) &
-watcher_pid=$!
+if [ -n "$TIMEOUT" ]; then
+(
+sleep $TIMEOUT
+echo
+echo 
""
+echo "=   Timeout completing tests - extracting stacktrace 
  ="
+echo 
""
+echo
+gdb -p $runner_pid --batch -ex "thread apply all py-bt"
+echo
+echo 
""
+echo "=Aborting tests  
  ="
+echo 
""
+kill -KILL $runner_pid
+sleep 5
+) &
+watcher_pid=$!
+fi
 
 wait $runner_pid
 runner_status=$?
 
-kill -TERM $watcher_pid
+if [ -n "$TIMEOUT" ]; then
+kill -TERM $watcher_pid
+fi
 
 exit $runner_status


-- 
To view, visit https://gerrit.ovirt.org/60240
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c7f862770402ab05bd64e735123d63758c37ef0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Terminate watcher when tests fail

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: tests: Terminate watcher when tests fail
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief975ac59c8c3ec106c42c93d5cb2a2fd32b69c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spbackends: Remove StoragePoolDiskBackend

2016-07-05 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: spbackends: Remove StoragePoolDiskBackend
..


spbackends: Remove StoragePoolDiskBackend

As VDSM no longer supports 3.4 clusters (see commit 23650fb), there's no
longer any use for the StoragePoolDiskBackend. This commit removes it
completely from the codebase, as its dead code.

Change-Id: Icced9e5e1d7002419bc5a899721921006123fdf0
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/55859
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M lib/api/vdsm-api.yml
M lib/vdsm/rpc/bindingxmlrpc.py
M vdsm/API.py
M vdsm/storage/hsm.py
M vdsm/storage/spbackends.py
5 files changed, 13 insertions(+), 239 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icced9e5e1d7002419bc5a899721921006123fdf0
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spbackends: Remove StoragePoolDiskBackend

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: spbackends: Remove StoragePoolDiskBackend
..


Patch Set 9: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icced9e5e1d7002419bc5a899721921006123fdf0
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spbackends: Remove StoragePoolDiskBackend

2016-07-05 Thread amureini

Allon Mureinik has posted comments on this change.

Change subject: spbackends: Remove StoragePoolDiskBackend
..


Patch Set 9: Verified+1

Addressed Nir's comments on vdsm-api.yml

-- 
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icced9e5e1d7002419bc5a899721921006123fdf0
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spbackends: Remove StoragePoolDiskBackend

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: spbackends: Remove StoragePoolDiskBackend
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icced9e5e1d7002419bc5a899721921006123fdf0
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spbackends: Remove StoragePoolDiskBackend

2016-07-05 Thread amureini

Allon Mureinik has posted comments on this change.

Change subject: spbackends: Remove StoragePoolDiskBackend
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/55859/8/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 8250: 
Line 8251: -   description: The Storage Domain statuses
Line 8252: name: domainDict
Line 8253: added: '3.4'
Line 8254: type: StorageDomainStatusMap
> The * is required, this is the way type is referenced in yaml.
True 'dat. Stupid mistake ported over from the previous revision of this patch 
with the old json schema. I'm surprised the schema's tests didn't catch it.
Line 8255: 
Line 8256: StoragePool.connectStorageServer:
Line 8257: added: '3.1'
Line 8258: description: Establish a connection to backing storage.


-- 
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icced9e5e1d7002419bc5a899721921006123fdf0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp.py: Assume a hostId when reconstructing master

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: sp.py: Assume a hostId when reconstructing master
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffbb563532a40f67f33fd971f55724e994c49dd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp.py: Assume a hostId when reconstructing master

2016-07-05 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: sp.py: Assume a hostId when reconstructing master
..


sp.py: Assume a hostId when reconstructing master

As we no longer support V1/V2 data domains, we can assume a hostId is
present in any potential new master.

This requirement should be present throughout the API, making all the
positional arguments in hsm.py's reconstructMaster up to, and
including, hostId argument mandatory.

Change-Id: Iaffbb563532a40f67f33fd971f55724e994c49dd
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/55857
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M client/vdsClient.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
3 files changed, 12 insertions(+), 29 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/55857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaffbb563532a40f67f33fd971f55724e994c49dd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: tox: fail make process if required tox version isn't installed.
..


Patch Set 20:

(7 comments)

https://gerrit.ovirt.org/#/c/59306/20/Makefile.am
File Makefile.am:

Line 93
Line 94
Line 95
Line 96
Line 97
I think we can simplify and make it more clear like this:

out=`tox --version`; \
if [ $$? -ne 0 ]; then \
echo "Error: cannot run tox, please install tox $(TOX_MIN_VERSION) or 
later"; \
exit 1; \
fi; \
version=`echo $$out | cut -d' ' -f1`; \
if build-aux/vercmp $$version $(TOX_MIN_VERSION); then \
echo "Error: tox is too old, please install tox $(TOX_MIN_VERSION) or 
later"; \
exit 1; \
fi


Line 91:tox -- pep8
Line 92: 
Line 93: .PHONY: tox
Line 94: tox:
Line 95:if [ `command -v tox` >/dev/null 2>&1 ]; then \
This will run tox on the machine, running all the tests defined in tox.ini - 
very bad idea for checking if tox is installed.
Line 96:if build-aux/vercmp `tox --version | cut -d' ' -f1` \
Line 97:"$(TOX_MIN_VERSION)"; \
Line 98:then \
Line 99:echo "Error: tox is too old please install tox \


Line 93: .PHONY: tox
Line 94: tox:
Line 95:if [ `command -v tox` >/dev/null 2>&1 ]; then \
Line 96:if build-aux/vercmp `tox --version | cut -d' ' -f1` \
Line 97:"$(TOX_MIN_VERSION)"; \
it is very hard to read such code, specially inside a makefile.
Line 98:then \
Line 99:echo "Error: tox is too old please install tox \
Line 100:   $(TOX_MIN_VERSION) or later"; \
Line 101:   exit 1; \


Line 95:if [ `command -v tox` >/dev/null 2>&1 ]; then \
Line 96:if build-aux/vercmp `tox --version | cut -d' ' -f1` \
Line 97:"$(TOX_MIN_VERSION)"; \
Line 98:then \
Line 99:echo "Error: tox is too old please install tox \
We need some punctuation here
Line 100:   $(TOX_MIN_VERSION) or later"; \
Line 101:   exit 1; \
Line 102:   fi \
Line 103:   else \


Line 100:   $(TOX_MIN_VERSION) or later"; \
Line 101:   exit 1; \
Line 102:   fi \
Line 103:   else \
Line 104:   echo "Error: please install tox $(TOX_MIN_VERSION) or 
later.";\
The trailing period is not needed.
Line 105:   exit 1; \
Line 106:   fi
Line 107: 
Line 108: 


Line 104:   echo "Error: please install tox $(TOX_MIN_VERSION) or 
later.";\
Line 105:   exit 1; \
Line 106:   fi
Line 107: 
Line 108: 
Unneeded
Line 109: .PHONY: python3
Line 110: python3: all
Line 111:   if [ "$(PYTHON3_SUPPORT)" == "1" ]; then \
Line 112:   PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) -m compileall \


https://gerrit.ovirt.org/#/c/59306/20/build-aux/vercmp
File build-aux/vercmp:

Line 39: def compare_versions(actual_version, required_version):
Line 40: actual_version = [int(n) for n in actual_version.split('.')]
Line 41: required_version = [int(n) for n in required_version.split('.')]
Line 42: 
Line 43: padding = len(required_version) < len(actual_version)
This should be:

padding = len(actual_version) - len(required_version)

Current code never adds only one 0:

# build-aux/vercmp -v 0.1.0.0 0.1
vercmp: [0, 1, 0, 0] > [0, 1, 0]

This should be:

vercmp: [0, 1, 0, 0] == [0, 1, 0, 0]
Line 44: if padding > 0:
Line 45: required_version += [0] * padding
Line 46: 
Line 47: if actual_version < required_version:


-- 
To view, visit https://gerrit.ovirt.org/59306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spbackends: Remove StoragePoolDiskBackend

2016-07-05 Thread alitke

Adam Litke has posted comments on this change.

Change subject: spbackends: Remove StoragePoolDiskBackend
..


Patch Set 8: Code-Review+1

Looks good after you address Nir's comment.

-- 
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icced9e5e1d7002419bc5a899721921006123fdf0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp.py: Assume a hostId when reconstructing master

2016-07-05 Thread alitke

Adam Litke has posted comments on this change.

Change subject: sp.py: Assume a hostId when reconstructing master
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffbb563532a40f67f33fd971f55724e994c49dd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: infra: moved infra package from lib/vdsm/infra to lib/vdsm/c...

2016-07-05 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: infra: moved infra package from lib/vdsm/infra to 
lib/vdsm/common
..


infra: moved infra package from lib/vdsm/infra to lib/vdsm/common

infra package was under lib/vdsm/infra with a few sub packages.
every package was converted to module and replaced under lib/vdsm/common
vdsm-infra package was also removed from vdsm.spec.in and marked as
obsolete as it was redundant and there is no use for it right now.

Change-Id: I8ffd40750048371c58628dec5890b9f8f97d22b6
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/59304
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
---
M configure.ac
M doc/infra/filecontrol.rst
M doc/infra/sigutils.rst
M doc/infra/zombiereaper.rst
M lib/vdsm/Makefile.am
R lib/vdsm/common/eventfd.py
R lib/vdsm/common/filecontrol.py
R lib/vdsm/common/sigutils.py
R lib/vdsm/common/zombiereaper.py
D lib/vdsm/infra/Makefile.am
D lib/vdsm/infra/__init__.py
D lib/vdsm/infra/eventfd/Makefile.am
D lib/vdsm/infra/filecontrol/Makefile.am
D lib/vdsm/infra/sigutils/Makefile.am
D lib/vdsm/infra/zombiereaper/Makefile.am
M lib/vdsm/protocoldetector.py
M lib/vdsm/storage/asyncevent.py
M lib/vdsm/storage/hba.py
M lib/vdsm/utils.py
M lib/vdsm/v2v.py
M lib/vdsm/virt/guestagent.py
M lib/yajsonrpc/betterAsyncore.py
M tests/eventfd_test.py
M tests/filecontrol_test.py
M tests/sigutils_test.py
M tests/testrunner.py
M tests/tests_child.py
M tests/utilsTests.py
M tests/zombiereaper_test.py
M vdsm.spec.in
M vdsm/supervdsmServer
M vdsm/vdsm
32 files changed, 42 insertions(+), 235 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/59304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ffd40750048371c58628dec5890b9f8f97d22b6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spbackends: Remove StoragePoolDiskBackend

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: spbackends: Remove StoragePoolDiskBackend
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/55859/8/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 8250: 
Line 8251: -   description: The Storage Domain statuses
Line 8252: name: domainDict
Line 8253: added: '3.4'
Line 8254: type: StorageDomainStatusMap
The * is required, this is the way type is referenced in yaml.
Line 8255: 
Line 8256: StoragePool.connectStorageServer:
Line 8257: added: '3.1'
Line 8258: description: Establish a connection to backing storage.


-- 
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icced9e5e1d7002419bc5a899721921006123fdf0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 10:

(4 comments)

Looks mostly good

https://gerrit.ovirt.org/#/c/52354/10//COMMIT_MSG
Commit Message:

Line 4: Commit: Piotr Kliczewski 
Line 5: CommitDate: 2016-07-05 16:08:19 +0200
Line 6: 
Line 7: utils: build cert paths in single place
Line 8: 
Please describe the behavior change - we don't use the trusted store 
configuration option any more.
Line 9: 
Line 10: Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b


https://gerrit.ovirt.org/#/c/52354/10/build-aux/Makefile.subs
File build-aux/Makefile.subs:

Line 28
Line 29
Line 30
Line 31
Line 32
We probably need to remove vdsmtsdir (and TRUSTEDSTORE?) from configure.ac


https://gerrit.ovirt.org/#/c/52354/10/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt'
Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@'
Line 156: 
Line 157: # location of the certificates
Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki/vdsm')
Use:

os.path.join(SYSCONF_PATH, "pki", "vdsm")
Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem')
Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem')


https://gerrit.ovirt.org/#/c/52354/10/lib/vdsm/tool/configurators/libvirt.py
File lib/vdsm/tool/configurators/libvirt.py:

Line 28: from vdsm.tool.configfile import ConfigFile, ParserWrapper
Line 29: from vdsm.tool.validate_ovirt_certs import validate_ovirt_certs
Line 30: from vdsm import utils
Line 31: from vdsm import constants
Line 32: 
Unrelated
Line 33: 
Line 34: if utils.isOvirtNode():
Line 35: from ovirt.node.utils.fs import Config as NodeCfg
Line 36: 


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Using startCmd func for running async execution

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 39
Line 40
Line 41
Line 42
Line 43
run_cmd?


Line 46: resetCpuAffinity=True):
Line 47: """
Line 48: Duplication of startCmd method without the use of deathSignal and 
sync
Line 49: parameters. Using simple_exec_cmd will execute the command by popen
Line 50: in sync to the call and return outputs.
We cannot duplicate code like this. We need to extract the common parts to a 
private helper and call it from both functions.

I can work like this:

def run_cmd(...):
proc = _start_process(...)
log...
communicate...
log...
return rc, out, err

def start_cmd(...):
proc = _start_process(...)
wrap it ...
return proc

def _start_process(...):
wrap command...
start it
return it
Line 51: 
Line 52: This is partial work to keep the usage of asyncProc in v2v and
Line 53: imageSharing.
Line 54: """


Line 83: 
Line 84: return p.returncode, out, err
Line 85: 
Line 86: 
Line 87: def startCmd(command, sudo=False, cwd=None, data=None, raw=False,
start_cmd?
Line 88:  printable=None, env=None, nice=None, ioclass=None,
Line 89:  ioclassdata=None, setsid=False, 
execCmdLogger=logging.root,
Line 90:  deathSignal=0, resetCpuAffinity=True):
Line 91: """


Line 114: p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env,
Line 115:  deathSignal=deathSignal))
Line 116: if data is not None:
Line 117: p.stdin.write(data)
Line 118: p.stdin.flush()
Do we have code using this? If not, better remove this. Code that want to write 
to stdin should do it. See imagesharing for example of such code, it does not 
use this feature.
Line 119: 
Line 120: return p
Line 121: 
Line 122: 


-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Using startCmd func for running async execution

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Remove deathSignal usages in sync execCmd calls

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: Remove deathSignal usages in sync execCmd calls
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5c39fd212429a9b123f4ef9f386db2e91330d0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Using startCmd func for running async execution

2016-07-05 Thread ybronhei

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Using startCmd func for running async execution
..

Using startCmd func for running async execution

Splitting execCmd and startCmd. execCmd still uses deathSignal and
asyncProc which can't run with py3.

Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/commands.py
M lib/vdsm/v2v.py
M tests/utilsTests.py
M vdsm/storage/imageSharing.py
4 files changed, 74 insertions(+), 53 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/60237/1

diff --git a/lib/vdsm/commands.py b/lib/vdsm/commands.py
index bffec83..6b734c7 100644
--- a/lib/vdsm/commands.py
+++ b/lib/vdsm/commands.py
@@ -41,15 +41,59 @@
 
 
 def execCmd(command, sudo=False, cwd=None, data=None, raw=False,
-printable=None, env=None, sync=True, nice=None, ioclass=None,
+printable=None, env=None, nice=None, ioclass=None,
 ioclassdata=None, setsid=False, execCmdLogger=logging.root,
-deathSignal=0, resetCpuAffinity=True):
+resetCpuAffinity=True):
+"""
+Duplication of startCmd method without the use of deathSignal and sync
+parameters. Using simple_exec_cmd will execute the command by popen
+in sync to the call and return outputs.
+
+This is partial work to keep the usage of asyncProc in v2v and
+imageSharing.
+"""
+command = cmdutils.wrap_command(command, with_ioclass=ioclass,
+ioclassdata=ioclassdata, with_nice=nice,
+with_setsid=setsid, with_sudo=sudo,
+reset_cpu_affinity=resetCpuAffinity)
+
+# Unsubscriptable objects (e.g. generators) need conversion
+if not callable(getattr(command, '__getitem__', None)):
+command = tuple(command)
+
+if not printable:
+printable = command
+
+execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd))
+
+p = CPopen(command, close_fds=True, cwd=cwd, env=env)
+
+with terminating(p):
+(out, err) = p.communicate(data)
+
+if out is None:
+# Prevent splitlines() from barfing later on
+out = ""
+
+execCmdLogger.debug(cmdutils.retcode_log_line(p.returncode, err=err))
+
+if not raw:
+out = out.splitlines(False)
+err = err.splitlines(False)
+
+return p.returncode, out, err
+
+
+def startCmd(command, sudo=False, cwd=None, data=None, raw=False,
+ printable=None, env=None, nice=None, ioclass=None,
+ ioclassdata=None, setsid=False, execCmdLogger=logging.root,
+ deathSignal=0, resetCpuAffinity=True):
 """
 Executes an external command, optionally via sudo.
 
 IMPORTANT NOTE: the new process would receive `deathSignal` when the
 controlling thread dies, which may not be what you intended: if you create
-a temporary thread, spawn a sync=False sub-process, and have the thread
+a temporary thread, spawn a sub-process, and have the thread
 finish, the new subprocess would die immediately.
 """
 
@@ -67,30 +111,13 @@
 
 execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd))
 
-p = CPopen(command, close_fds=True, cwd=cwd, env=env,
-   deathSignal=deathSignal)
-if not sync:
-p = AsyncProc(p)
-if data is not None:
-p.stdin.write(data)
-p.stdin.flush()
+p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env,
+ deathSignal=deathSignal))
+if data is not None:
+p.stdin.write(data)
+p.stdin.flush()
 
-return p
-
-with terminating(p):
-(out, err) = p.communicate(data)
-
-if out is None:
-# Prevent splitlines() from barfing later on
-out = ""
-
-execCmdLogger.debug(cmdutils.retcode_log_line(p.returncode, err=err))
-
-if not raw:
-out = out.splitlines(False)
-err = err.splitlines(False)
-
-return p.returncode, out, err
+return p
 
 
 class AsyncProc(object):
@@ -341,9 +368,8 @@
 """
 Executes an external command, optionally via sudo with stop abilities.
 """
-proc = execCmd(command, cwd=cwd, data=data, sync=False,
-   nice=nice, ioclass=ioclass, execCmdLogger=execCmdLogger,
-   deathSignal=deathSignal)
+proc = startCmd(command, cwd=cwd, data=data, nice=nice, ioclass=ioclass,
+execCmdLogger=execCmdLogger, deathSignal=deathSignal)
 
 if not proc.wait(cond=stop):
 proc.kill()
diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index defbe14..24c0415 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -40,7 +40,7 @@
 
 import libvirt
 
-from vdsm.commands import execCmd
+from vdsm.commands import startCmd
 from vdsm.constants import P_VDSM_RUN, EXT_KVM_2_OVIRT
 from vdsm.define import

Change in vdsm[master]: readme: Simplify installation instructions

2016-07-05 Thread sbonazzo

Sandro Bonazzola has posted comments on this change.

Change subject: readme: Simplify installation instructions
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/48713/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: readme: Simplify installation instructions
Line 8: 
Line 9: We need to run ./autogen.sh, and configure is not needed usually, no
Line 10: need to make it look more complex then it is.
then -> than
Line 11: 
Line 12: The --force flag is a good idea in the first run, and it is better to
Line 13: show how to get more help than to duplicate the help in the readme.
Line 14: 


https://gerrit.ovirt.org/#/c/48713/1/README
File README:

Line 19: The Vdsm service can be used by following the standard autotools
Line 20: installation process, documented in the INSTALL file. As a quick
Line 21: start you can do
Line 22: 
Line 23:./autogen.sh --system
> So the current instaructions are good for users, and my version is for deve
> So the current instaructions are good for users, and my version is for 
> developers?


current instructions are good for those who download the released tarball and 
build from it. Your version is good for those who clone git repo and build from 
it.


> Do you think we should keep both in the readme, or only the user version?


I think you can keep both of them.
Line 24:make
Line 25:sudo make install
Line 26: 
Line 27: In order to start vdsm at first time, please perform:


-- 
To view, visit https://gerrit.ovirt.org/48713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I868a3de7991af5d9f39e9e489bf23587b13b1e58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: verify_untrusted_volume: Check compatibility version
..


Patch Set 17:

* #1344289::Update tracker: OK
* Set MODIFIED::bug 1344289#1344289IGNORE, not all related patches are 
closed, check 60113

-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

2016-07-05 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: verify_untrusted_volume: Check compatibility version
..


verify_untrusted_volume: Check compatibility version

When importing a volume using imaged, QCOW2 volumes with an unsupported
compatibility version should be rejected.

Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344289
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/59411
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/storage_hsm_test.py
M vdsm/storage/hsm.py
2 files changed, 26 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 4: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1516: "qcow2 compat %r is not supported" % compat)
Line 1517: 
Line 1518: # Although we can handle both 0.1 and 1.1 compat qcow2 
files, we
Line 1519: # currently limit support to one or the other via the 
vdsm config.
Line 1520: # Once both are supported concurrently this check can be 
removed.
> I don't think we should add version cmp.  It should be a set membership tes
Regarding amend, it seems to be an option only for upgrading an image. 
Downgrading an image from 1.1 to 0.10 may require changes in actual image data 
and require more space (replacing empty clusters with reall zeros).

I tested various images (rhel, fedora, centos, openstack), and all of them use 
the old 0.10 format. If we block this format by checking the current 
configuration, we practically break the image upload feature.

If you want to add verification, it must not block upload of older version.
Line 1521: required_compat = config.get('irs', 'qcow2_compat')
Line 1522: if compat != required_compat:
Line 1523: raise se.ImageVerificationError(
Line 1524: "qcow2 compat %r is not supported by this host" 
% compat)


-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 4:

* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check Product::#1344289::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

2016-07-05 Thread alitke

Adam Litke has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1516: "qcow2 compat %r is not supported" % compat)
Line 1517: 
Line 1518: # Although we can handle both 0.1 and 1.1 compat qcow2 
files, we
Line 1519: # currently limit support to one or the other via the 
vdsm config.
Line 1520: # Once both are supported concurrently this check can be 
removed.
> The config only set the format used to create new images. When you set conf
I don't think we should add version cmp.  It should be a set membership test 
only.  I would also argue that we should limit import to exactly the version 
specified in the config file since we are "creating" a vdsm volume from an 
uploaded image file.  I am also reluctant to add amend support.  Even though 
it's safe according to Kevin, I think we need to think more about if it's 
something we want to do.  Let's not hold up this patch for it.
Line 1521: required_compat = config.get('irs', 'qcow2_compat')
Line 1522: if compat != required_compat:
Line 1523: raise se.ImageVerificationError(
Line 1524: "qcow2 compat %r is not supported by this host" 
% compat)


-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: image: Add timing for copy volume operations

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: image: Add timing for copy volume operations
..


Patch Set 3:

Waiting for qa ack (they ask for this log)

-- 
To view, visit https://gerrit.ovirt.org/60164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a509397c756a51bfed43b89a2505e3e4cbb9edc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: verify_untrusted_volume: Check compatibility version
..


Patch Set 16: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: verify_untrusted_volume: Check compatibility version
..


Patch Set 16:

* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check Product::#1344289::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 3:

* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check Product::#1344289::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Avoid creating unneeded images

2016-07-05 Thread alitke

Adam Litke has posted comments on this change.

Change subject: Avoid creating unneeded images
..


Patch Set 1: Code-Review-2

We'll handle in the previous patch

-- 
To view, visit https://gerrit.ovirt.org/60231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8faab29c23f28b0445f96d424e7f4b7967faa09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

2016-07-05 Thread alitke

Adam Litke has posted comments on this change.

Change subject: verify_untrusted_volume: Check compatibility version
..


Patch Set 15:

(2 comments)

https://gerrit.ovirt.org/#/c/59411/15/tests/storage_hsm_test.py
File tests/storage_hsm_test.py:

Line 76: 
Line 77: def test_unsupported_compat(self):
Line 78: with self.fake_volume(sc.COW_FORMAT) as vol:
Line 79: qemu_fmt = qemuimg.FORMAT.QCOW2
Line 80: qemuimg.create(vol.volumePath, size=self.SIZE, 
format=qemu_fmt)
> We don't need to create the images - the code is not accessing the image si
Done
Line 81: info = {"format": qemu_fmt, "compat": "BAD"}
Line 82: with MonkeyPatchScope([(qemuimg, 'info', lambda unused: 
info)]):
Line 83: h = FakeHSM()
Line 84: self.assertRaises(se.ImageVerificationError,


Line 87: 
Line 88: def test_compat_not_checked_for_raw(self):
Line 89: with self.fake_volume(sc.RAW_FORMAT) as vol:
Line 90: qemu_fmt = qemuimg.FORMAT.RAW
Line 91: qemuimg.create(vol.volumePath, size=self.SIZE, 
format=qemu_fmt)
> Same
Done
Line 92: info = {"format": qemu_fmt, "compat": "BAD"}
Line 93: with MonkeyPatchScope([(qemuimg, 'info', lambda unused: 
info)]):
Line 94: h = FakeHSM()
Line 95: self.assertNotRaises(h.verify_untrusted_volume, 'sp',


-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Introduce supports_compat helper

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Introduce supports_compat helper
..


Patch Set 14:

* #1344289::Update tracker: OK
* Set MODIFIED::bug 1344289#1344289IGNORE, not all related patches are 
closed, check 59411

-- 
To view, visit https://gerrit.ovirt.org/59410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Introduce supports_compat helper

2016-07-05 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: qemuimg: Introduce supports_compat helper
..


qemuimg: Introduce supports_compat helper

To enable checking if a qcow2 image has a supported compatibility level,
add a simple utility function to qemuimg.

Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344289
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/59410
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Reviewed-by: Amit Aviram 
---
M lib/vdsm/qemuimg.py
M tests/qemuimgTests.py
2 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests
  Amit Aviram: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/59410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Unbreak qmemuimg.check

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Unbreak qmemuimg.check
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/60168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-05 Thread piotr . kliczewski

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 14: Verified+1

verified by running jsonrpc Host.getVMList

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Unbreak qmemuimg.check

2016-07-05 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: qemuimg: Unbreak qmemuimg.check
..


qemuimg: Unbreak qmemuimg.check

Since commit 3e7a11954582 (qemuimg: Use --output json for 'check' and
'info') qemuimg.check is broken, but the tests are passing. This is
caused by unneeded mocking.

qemuimg.check fails now with this error:

  File "/usr/lib/python2.7/site-packages/vdsm/qemuimg.py", line 309, in 
_parse_qemuimg_json
obj = json.loads(output)
  File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
return _default_decoder.decode(s)
  File "/usr/lib64/python2.7/json/decoder.py", line 365, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
TypeError: expected string or buffer

Replace the harmful mocking with running qemuimg.check with a real
image, and add the missing raw=True to get a string from the command.

Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/60168
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Adam Litke 
---
M lib/vdsm/qemuimg.py
M tests/qemuimgTests.py
2 files changed, 9 insertions(+), 15 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

2016-07-05 Thread piotr . kliczewski

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 7: Verified+1

verified by running jsonrpc Host.getVMList

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

2016-07-05 Thread piotr . kliczewski

Piotr Kliczewski has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 10: Verified+1

Verified by updating vdsm and starting new vm.

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 2: Code-Review-1

See my comment on version 1:
https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py@1520

-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

2016-07-05 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: verify_untrusted_volume: Check compatibility version
..


Patch Set 15:

(2 comments)

https://gerrit.ovirt.org/#/c/59411/15/tests/storage_hsm_test.py
File tests/storage_hsm_test.py:

Line 76: 
Line 77: def test_unsupported_compat(self):
Line 78: with self.fake_volume(sc.COW_FORMAT) as vol:
Line 79: qemu_fmt = qemuimg.FORMAT.QCOW2
Line 80: qemuimg.create(vol.volumePath, size=self.SIZE, 
format=qemu_fmt)
We don't need to create the images - the code is not accessing the image since 
we monkeypatch qemuimg.info().

See https://gerrit.ovirt.org/#/c/60231
Line 81: info = {"format": qemu_fmt, "compat": "BAD"}
Line 82: with MonkeyPatchScope([(qemuimg, 'info', lambda unused: 
info)]):
Line 83: h = FakeHSM()
Line 84: self.assertRaises(se.ImageVerificationError,


Line 87: 
Line 88: def test_compat_not_checked_for_raw(self):
Line 89: with self.fake_volume(sc.RAW_FORMAT) as vol:
Line 90: qemu_fmt = qemuimg.FORMAT.RAW
Line 91: qemuimg.create(vol.volumePath, size=self.SIZE, 
format=qemu_fmt)
Same
Line 92: info = {"format": qemu_fmt, "compat": "BAD"}
Line 93: with MonkeyPatchScope([(qemuimg, 'info', lambda unused: 
info)]):
Line 94: h = FakeHSM()
Line 95: self.assertNotRaises(h.verify_untrusted_volume, 'sp',


-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: image: Add timing for copy volume operations

2016-07-05 Thread alitke

Adam Litke has posted comments on this change.

Change subject: image: Add timing for copy volume operations
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a509397c756a51bfed43b89a2505e3e4cbb9edc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Unbreak qmemuimg.check

2016-07-05 Thread alitke

Adam Litke has posted comments on this change.

Change subject: qemuimg: Unbreak qmemuimg.check
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: verify_untrusted_volume: Check compatibility version
..


Patch Set 15:

* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check Product::#1344289::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

2016-07-05 Thread alitke

Adam Litke has posted comments on this change.

Change subject: verify_untrusted_volume: Check compatibility version
..


Patch Set 15: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: api: fixing default value for GlusterHost.createBrick

2016-07-05 Thread piotr . kliczewski

Piotr Kliczewski has posted comments on this change.

Change subject: api: fixing default value for GlusterHost.createBrick
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-05 Thread piotr . kliczewski

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/35181/12//COMMIT_MSG
Commit Message:

Line 23: 
Line 24: For invokinng methods with many or complex parameters, you can read the
Line 25: parameters from a file:
Line 26: 
Line 27: # jsonrpc VM.create -f vm-create
Still need to update here
Line 28: ...
Line 29: 
Line 30: It is also possible to read parameters from standard input, creating
Line 31: complex parameters interactively:


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: wip: tests: change testing framework to pytest

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: wip: tests: change testing framework to pytest
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-05 Thread piotr . kliczewski

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 11:

(2 comments)

https://gerrit.ovirt.org/#/c/35181/11/contrib/jsonrpc
File contrib/jsonrpc:

Line 38: 
Line 39: For invokinng methods with many or complex parameters, you can read the
Line 40: parameters from a file:
Line 41: 
Line 42: # jsonrpc VM.create -f vm-create
> could you provide an example how does a complex input like this would look 
File content should look the same as params provided in std input like below. 
Will update here.
Line 43: ...
Line 44: 
Line 45: It is also possible to read parameters from standard input, creating 
complex
Line 46: parameters interactively:


Line 111: 
Line 112: def option_parser():
Line 113: parser = argparse.ArgumentParser()
Line 114: parser.add_argument('-a', '--host', dest="host", 
default="localhost",
Line 115: help='host address (default localhost)')
> can you contact a host with ssl=True (which is the default, common installa
Actually we use ssl=True by default and we use cert location as defined in 
constants. Do you suggest that user should be able to provide cert location?
Line 116: parser.add_argument('method', help='remote method name')
Line 117: parser.add_argument('-f', '--file', dest='file',
Line 118: help="read method parameters from json file. 
Set to"
Line 119:  " '-' to read from standard input")


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs hook: fix dhclient imports

2016-07-05 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: ovs hook: fix dhclient imports
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60154
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13c017538750902713831bbcb07a30c885abd7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: wip: tests: change testing framework to pytest

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: wip: tests: change testing framework to pytest
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: wip: tests: change testing framework to pytest

2016-07-05 Thread igoihman

Irit Goihman has uploaded a new change for review.

Change subject: wip: tests: change testing framework to pytest
..

wip: tests: change testing framework to pytest

Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Signed-off-by: Irit Goihman 
---
A tests/pytest.ini
M tests/testrunner.py
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/60217/1

diff --git a/tests/pytest.ini b/tests/pytest.ini
new file mode 100644
index 000..521a323
--- /dev/null
+++ b/tests/pytest.ini
@@ -0,0 +1,2 @@
+[pytest] 
+python_files = *tests.py *test.py *Test.py *Tests.py
diff --git a/tests/testrunner.py b/tests/testrunner.py
index 27f6f7e..38d970e 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -26,6 +26,7 @@
 import pthreading
 pthreading.monkey_patch()
 
+import pytest
 import warnings
 import logging
 
@@ -85,4 +86,4 @@
 # Mock panic() calls for tests
 panic.panic = panicMock
 
-testlib.run()
+pytest.main()


-- 
To view, visit https://gerrit.ovirt.org/60217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: infra: moved infra package from lib/vdsm/infra to lib/vdsm/c...

2016-07-05 Thread igoihman

Irit Goihman has posted comments on this change.

Change subject: infra: moved infra package from lib/vdsm/infra to 
lib/vdsm/common
..


Patch Set 10:

verified infra removal on fedora 23 and centos 7

-- 
To view, visit https://gerrit.ovirt.org/59304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ffd40750048371c58628dec5890b9f8f97d22b6
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: api: fixing default value for GlusterHost.createBrick

2016-07-05 Thread rnachimu

Ramesh N has posted comments on this change.

Change subject: api: fixing default value for GlusterHost.createBrick
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

2016-07-05 Thread piotr . kliczewski

Piotr Kliczewski has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 157: # localtion of the certificates
Line 158: def get_cert_paths(path):
Line 159: return (os.path.join(path, 'keys', 'vdsmkey.pem'),
Line 160: os.path.join(path, 'certs', 'vdsmcert.pem'),
Line 161: os.path.join(path, 'certs', 'cacert.pem'))
> I don't understand your answe, Piotr.
Sorry for not being clear. Will make them constant


https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 103
Line 104
Line 105
Line 106
Line 107
> this library is for the client side. A client may want to connect to variou
Correct, I will revert this change.


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Remove deathSignal usages in sync execCmd calls

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: Remove deathSignal usages in sync execCmd calls
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5c39fd212429a9b123f4ef9f386db2e91330d0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft patch - removing all deathsignal usages where calls ar...

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: draft patch - removing all deathsignal usages where calls are 
async only to verify work with subprocess32
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a181393923d81c863d7e9e8bde4b75a20fb56de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft patch - removing all deathsignal usages where calls ar...

2016-07-05 Thread ybronhei

Yaniv Bronhaim has uploaded a new change for review.

Change subject: draft patch - removing all deathsignal usages where calls are 
async only to verify work with subprocess32
..

draft patch - removing all deathsignal usages where calls are async only
to verify work with subprocess32

We need to return same object as popen and remove asyncProc - same for
all usages in watchcmd.

Change-Id: I2a181393923d81c863d7e9e8bde4b75a20fb56de
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/commands.py
M lib/vdsm/compat.py
M lib/vdsm/v2v.py
M vdsm/storage/imageSharing.py
4 files changed, 7 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/60209/1

diff --git a/lib/vdsm/commands.py b/lib/vdsm/commands.py
index bffec83..b71ff18 100644
--- a/lib/vdsm/commands.py
+++ b/lib/vdsm/commands.py
@@ -43,14 +43,9 @@
 def execCmd(command, sudo=False, cwd=None, data=None, raw=False,
 printable=None, env=None, sync=True, nice=None, ioclass=None,
 ioclassdata=None, setsid=False, execCmdLogger=logging.root,
-deathSignal=0, resetCpuAffinity=True):
+resetCpuAffinity=True):
 """
 Executes an external command, optionally via sudo.
-
-IMPORTANT NOTE: the new process would receive `deathSignal` when the
-controlling thread dies, which may not be what you intended: if you create
-a temporary thread, spawn a sync=False sub-process, and have the thread
-finish, the new subprocess would die immediately.
 """
 
 command = cmdutils.wrap_command(command, with_ioclass=ioclass,
@@ -67,8 +62,7 @@
 
 execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd))
 
-p = CPopen(command, close_fds=True, cwd=cwd, env=env,
-   deathSignal=deathSignal)
+p = CPopen(command, close_fds=True, cwd=cwd, env=env)
 if not sync:
 p = AsyncProc(p)
 if data is not None:
@@ -337,13 +331,12 @@
 
 
 def watchCmd(command, stop, cwd=None, data=None, nice=None, ioclass=None,
- execCmdLogger=logging.root, deathSignal=signal.SIGKILL):
+ execCmdLogger=logging.root):
 """
 Executes an external command, optionally via sudo with stop abilities.
 """
 proc = execCmd(command, cwd=cwd, data=data, sync=False,
-   nice=nice, ioclass=ioclass, execCmdLogger=execCmdLogger,
-   deathSignal=deathSignal)
+   nice=nice, ioclass=ioclass, execCmdLogger=execCmdLogger)
 
 if not proc.wait(cond=stop):
 proc.kill()
diff --git a/lib/vdsm/compat.py b/lib/vdsm/compat.py
index 8884005..562e554 100644
--- a/lib/vdsm/compat.py
+++ b/lib/vdsm/compat.py
@@ -41,7 +41,7 @@
 
 import sys
 if sys.version_info[0] == 2:
-from cpopen import CPopen
+from subprocess32 import Popen as CPopen
 CPopen  # make pyflakes happy
 else:
 from subprocess import Popen as CPopen
diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index defbe14..890a9c5 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -32,7 +32,6 @@
 import logging
 import os
 import re
-import signal
 import tarfile
 import threading
 import xml.etree.ElementTree as ET
@@ -391,7 +390,6 @@
 def _start_helper(self):
 return execCmd(self._command(),
sync=False,
-   deathSignal=signal.SIGTERM,
nice=NICENESS.HIGH,
ioclass=IOCLASS.IDLE,
env=self._environment())
diff --git a/vdsm/storage/imageSharing.py b/vdsm/storage/imageSharing.py
index b8c3240..6081e9e 100644
--- a/vdsm/storage/imageSharing.py
+++ b/vdsm/storage/imageSharing.py
@@ -18,7 +18,6 @@
 #
 
 import logging
-import signal
 
 from vdsm import commands
 from vdsm import constants
@@ -77,8 +76,7 @@
 totalSize = getLengthFromArgs(methodArgs)
 fileObj = methodArgs['fileObj']
 cmd = [constants.EXT_DD, "of=%s" % dstImgPath, "bs=%s" % constants.MEGAB]
-p = commands.execCmd(cmd, sudo=False, sync=False,
- deathSignal=signal.SIGKILL)
+p = commands.execCmd(cmd, sudo=False, sync=False)
 try:
 _copyData(fileObj, p.stdin, totalSize)
 p.stdin.close()
@@ -103,8 +101,7 @@
 cmd = [constants.EXT_DD, "if=%s" % dstImgPath, "bs=%s" % constants.MEGAB,
"count=%s" % (total_size / constants.MEGAB + 1)]
 
-p = commands.execCmd(cmd, sync=False,
- deathSignal=signal.SIGKILL)
+p = commands.execCmd(cmd, sync=False)
 p.blocking = True
 try:
 _copyData(p.stdout, fileObj, bytes_left)


-- 
To view, visit https://gerrit.ovirt.org/60209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a181393923d81c863d7e9e8bde4b75a20fb56de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim

Change in vdsm[master]: utils: build cert paths in single place

2016-07-05 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 7:

(2 comments)

(very partial review)

https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 157: # localtion of the certificates
Line 158: def get_cert_paths(path):
Line 159: return (os.path.join(path, 'keys', 'vdsmkey.pem'),
Line 160: os.path.join(path, 'certs', 'vdsmcert.pem'),
Line 161: os.path.join(path, 'certs', 'cacert.pem'))
> We need it.
I don't understand your answe, Piotr.


https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 103
Line 104
Line 105
Line 106
Line 107
> Additionally, ovirt-imageio-daemon is using the /etc/pki/vdsm/ - we cannot 
this library is for the client side. A client may want to connect to various 
clusters, each with a different certificate.


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-05 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 11: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/35181/11/contrib/jsonrpc
File contrib/jsonrpc:

Line 38: 
Line 39: For invokinng methods with many or complex parameters, you can read the
Line 40: parameters from a file:
Line 41: 
Line 42: # jsonrpc VM.create -f vm-create
could you provide an example how does a complex input like this would look like?

I don't understand how can this possibly work without json-parsing the file. 
How would you represent the list of device dictionaries?
Line 43: ...
Line 44: 
Line 45: It is also possible to read parameters from standard input, creating 
complex
Line 46: parameters interactively:


Line 111: 
Line 112: def option_parser():
Line 113: parser = argparse.ArgumentParser()
Line 114: parser.add_argument('-a', '--host', dest="host", 
default="localhost",
Line 115: help='host address (default localhost)')
can you contact a host with ssl=True (which is the default, common 
installation)? I see no reference to our pki.
Line 116: parser.add_argument('method', help='remote method name')
Line 117: parser.add_argument('-f', '--file', dest='file',
Line 118: help="read method parameters from json file. 
Set to"
Line 119:  " '-' to read from standard input")


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: api: fixing default value for GlusterHost.createBrick

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: api: fixing default value for GlusterHost.createBrick
..


Patch Set 2:

* #1352656::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1352656::OK, public bug
* Check Product::#1352656::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: api: fixing default value for GlusterHost.createBrick

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: api: fixing default value for GlusterHost.createBrick
..


Patch Set 1:

* #1352656::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1352656::OK, public bug
* Check Product::#1352656::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: api: fixing default value for GlusterHost.createBrick

2016-07-05 Thread rnachimu

Ramesh N has uploaded a new change for review.

Change subject: api: fixing default value for GlusterHost.createBrick
..

api: fixing default value for GlusterHost.createBrick

Change default value for raidParamas to an empty dict in
string format.

Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Bug-Url: https://bugzilla.redhat.com/1352656
Signed-off-by: Ramesh Nachimuthu 
---
M lib/api/vdsm-api-gluster.yml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/60206/1

diff --git a/lib/api/vdsm-api-gluster.yml b/lib/api/vdsm-api-gluster.yml
index 79d5d04..9b23cab 100644
--- a/lib/api/vdsm-api-gluster.yml
+++ b/lib/api/vdsm-api-gluster.yml
@@ -1051,7 +1051,7 @@
 name: fsType
 type: string
 
--   defaultvalue: {}
+-   defaultvalue:'{}'
 description: dictonary contains raid details of a raid device
 name: raidParams
 type: *RaidDevice


-- 
To view, visit https://gerrit.ovirt.org/60206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

2016-07-05 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: v2v: Log detailed output of virt-v2v
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:

Line 13: It would be cleaner to modify execCmd() to store the log output, but
Line 14: this can dangerous without the function being refactored first.
Line 15: Therefore we resort to a dirty hack with shell to redirect stderr to
Line 16: stdout and store everything in a log file. This hack should be cleaned
Line 17: once execCmd() is updated.
I prefer this to be solved in the v2v tool or a helpr script that merges stdout 
and stderr.

Alternatively, vdsm can watch both stdout and stderr in _watch_process_output. 
It can then funnel stdout to the OutputParser and stderr - to vdsm.log.
Line 18: 
Line 19: Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Line 20: Bug-Url: https://bugzilla.redhat.com/1350465


-- 
To view, visit https://gerrit.ovirt.org/59834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: tox: fail make process if required tox version isn't installed.
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Kill and report asyncProc if fails on first write to stdin

2016-07-05 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: Kill and report asyncProc if fails on first write to stdin
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b68742ce1dcae1d9fdad020b7b4a41ca6ad028
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Introduce supports_compat helper

2016-07-05 Thread aaviram

Amit Aviram has posted comments on this change.

Change subject: qemuimg: Introduce supports_compat helper
..


Patch Set 13: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Unbreak qmemuimg.check

2016-07-05 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: qemuimg: Unbreak qmemuimg.check
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: image: Add timing for copy volume operations

2016-07-05 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: image: Add timing for copy volume operations
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a509397c756a51bfed43b89a2505e3e4cbb9edc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

79 matches

Mail list logo