Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash
Freddy Rolland has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: move glusterfs to 3.8
Sahina Bose has posted comments on this change. Change subject: automation: move glusterfs to 3.8 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dac714919587dc6a1d82259a844672892bbe534 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes
Freddy Rolland has posted comments on this change. Change subject: fileUtils: Normalize initial double slashes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
Freddy Rolland has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: revert net: Libvirt hook that enables ovs-legacy migration
gerrit-hooks has posted comments on this change. Change subject: revert net: Libvirt hook that enables ovs-legacy migration .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/62121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ebce73becbfc0ddc202f49e70e46a36f3aaddc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt net: Support VM migration on OVS based networks
gerrit-hooks has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/59645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: revert net: Libvirt hook that enables ovs-legacy migration
Dan Kenigsberg has posted comments on this change. Change subject: revert net: Libvirt hook that enables ovs-legacy migration .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ebce73becbfc0ddc202f49e70e46a36f3aaddc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: revert net: Libvirt hook that enables ovs-legacy migration
Dan Kenigsberg has submitted this change and it was merged. Change subject: revert net: Libvirt hook that enables ovs-legacy migration .. revert net: Libvirt hook that enables ovs-legacy migration Both the integrated and older OVS hook have a libvirt hook that enables VM migration. The two are colliding and only one should be left around. Therefore, the ovs hook one is removed. Future patches should remove the ovs hook completely. This reverts commit 50de041e01b098843b0fd7a4d3927783c11c79b6. Change-Id: I16ebce73becbfc0ddc202f49e70e46a36f3aaddc Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/62121 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg --- D tests/network/hook_ovs_test.py M vdsm.spec.in M vdsm/virt/libvirt-hook.sh M vdsm_hooks/ovs/Makefile.am D vdsm_hooks/ovs/ovs_migrate.py 5 files changed, 1 insertion(+), 320 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/62121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ebce73becbfc0ddc202f49e70e46a36f3aaddc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt net: Support VM migration on OVS based networks
Dan Kenigsberg has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks .. Patch Set 17: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/59645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt net: Support VM migration on OVS based networks
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt net: Support VM migration on OVS based networks .. virt net: Support VM migration on OVS based networks With the introduction of OVS as a network implementation, the migration of VM/s between hosts requires special handling. This patch enables VM/s to migrate between networks of the same kind or mixed. Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/59645 Reviewed-by: Petr Horáček Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- A tests/network/vm_migrate_hook_test.py M vdsm.spec.in M vdsm/virt/Makefile.am M vdsm/virt/libvirt-hook.sh A vdsm/virt/vm_migrate_hook.py 5 files changed, 409 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/59645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: move outOfProcess module to vdsm storage lib
Dan Kenigsberg has posted comments on this change. Change subject: storage: move outOfProcess module to vdsm storage lib .. Patch Set 7: Code-Review-1 rebase please! -- To view, visit https://gerrit.ovirt.org/56576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I390f8bc440c377b225a328aeb424233498522a5a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: move threadPool module to vdsm storage lib
Dan Kenigsberg has posted comments on this change. Change subject: storage: move threadPool module to vdsm storage lib .. Patch Set 4: Code-Review-1 marking with -1 as this needs a rebase and reverification. -- To view, visit https://gerrit.ovirt.org/56571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5f4edd8eea38fdb6bdf3be5c7732fee0b56d58e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Using %{?_smp_mflags} in %install
Dan Kenigsberg has posted comments on this change.
Change subject: Using %{?_smp_mflags} in %install
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/62163/1/vdsm.spec.in
File vdsm.spec.in:
Line 743
Line 744
Line 745
Line 746
Line 747
> maybe.. why?
because the same reasoning that convinced Fedora to require it in %install
should apply here as well
Line 757:
Line 758: sed -i -e 's\@VDSMRPCPYLIBDIR@\%{python_sitelib}/%{vdsm_name}/rpc\g'
lib/vdsm/constants.py
Line 759:
Line 760: %install
Line 761: make %{?_smp_mflags} DESTDIR=%{buildroot} install
> in the re-review of vdsm package they asked to add it here because rpmlint
quieting a Fedora reviewer is a valid reason to add this flag, but let us make
it apparent in the commit message.
Line 762:
Line 763: # Creating VDSM logs in this session to avoid rpmbuild
Line 764: # complain during the build
Line 765: install -dDm 0755 %{buildroot}@VDSMLOGDIR@
--
To view, visit https://gerrit.ovirt.org/62163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I290734e0ac4db6d6891428a9c149d631f5b705f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Removing deprecated lines from spec
Dan Kenigsberg has posted comments on this change. Change subject: Removing deprecated lines from spec .. Patch Set 2: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/62159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45ced2a5d5eec399e5ba55d82f645d8d6709c28 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Removing deprecated lines from spec
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removing deprecated lines from spec
..
Removing deprecated lines from spec
rm -rf %{buildroot} and %defattr(-, root, root, -) are not needed
anymore.
Change-Id: Id45ced2a5d5eec399e5ba55d82f645d8d6709c28
Signed-off-by: Yaniv Bronhaim
Reviewed-on: https://gerrit.ovirt.org/62159
Continuous-Integration: Jenkins CI
Reviewed-by: Douglas Schilling Landgraf
Reviewed-by: Dan Kenigsberg
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Yaniv Bronhaim: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id45ced2a5d5eec399e5ba55d82f645d8d6709c28
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Removing deprecated lines from spec
gerrit-hooks has posted comments on this change. Change subject: Removing deprecated lines from spec .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/62159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45ced2a5d5eec399e5ba55d82f645d8d6709c28 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: early IP+link setup
Dan Kenigsberg has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 15: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
Allon Mureinik has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Restore watermark tracking
Adam Litke has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/60889/13/vdsm/virt/vm.py File vdsm/virt/vm.py: PS13, Line 993: volUUID As Francesco suggested, let's use vol_id instead of volUUID. PS13, Line 1020: pathToVolID Looking forward to you reusing the other function that Francesco pointed out. PS13, Line 4752: COW' Maybe we should also use the storage constant here too. -- To view, visit https://gerrit.ovirt.org/60889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
Nir Soffer has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 3: Verified+1
Verified both positive and negative flows.
I could not reproduce the original error so I added a second call to extend a
volume in the mailbox thread, and this is how it looks now:
This request should fail:
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:20,517::lvm::288::Storage.Misc.excCmd::(cmd) /usr/bin/taskset --cpu-list
0-7 /usr/bin/sudo -n /usr/sbin/lvm lve
xtend --config ' devices { preferred_names = ["^/dev/mapper/"]
ignore_suspended_devices=1 write_cache_state=0 disable_after_error_count=3
filter = [ '\''a|/dev/mapper/360014
05292bb96f19064f81b884fa63f|/dev/mapper/360014052c81462a280847e8a6e3af8cd|/dev/mapper/360014054729dfdd84d1493a818924b0d|/dev/mapper/3600140549f3b93968d440ac9129d124f|/dev/ma
pper/360014054b9a6f2539574211b84356cff|/dev/mapper/360014055b413c342a134486b616d2359|/dev/mapper/360014056cbd26bc649c4862b55905337|/dev/mapper/3600140573f2afb2d0404862b37b08
cd6|/dev/mapper/360014057ce1a1afffd744dc8c34643d7|/dev/mapper/3600140587a66de91f05449a8cd9250b0|/dev/mapper/360014059e68c9a14a494de0bc808663b|/dev/mapper/36001405b6f4ebb5a45
6460c868ed8c7a|/dev/mapper/36001405c27599a89012467784cd463b4|/dev/mapper/36001405cc9ad490392b4277b52aec8d4|/dev/mapper/36001405d2aa1ad2c5ef4fa9820d93aa9|/dev/mapper/36001405
d2d73a8d22ae44a5a36bda08d|/dev/mapper/36001405ef22c7b9fbff43fa93aa78719|/dev/mapper/36001405f148e99c5a3e4781b292fd7e1|/dev/mapper/36001405f16755b12e6444158b55d57db|/dev/mapp
er/36001405fd7e668fdf80479992b012af8|'\'', '\''r|.*|'\'' ] } global {
locking_type=1 prioritise_write_locks=1 wait_for_locks=1 use_lvmetad=0 }
backup { retain_min = 5
0 retain_days = 0 } ' --autobackup n --size 2048m
65059e74-7577-4356-8ce1-89e9634d986b/c3eb6aec-e126-4a60-9a1c-a29aad9191d5 (cwd
None)
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:21,389::lvm::288::Storage.Misc.excCmd::(cmd) FAILED: = ' New size
(16 extents) matches existing size (16 extents)\n'; = 5
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:21,394::lvm::288::Storage.Misc.excCmd::(cmd) /usr/bin/taskset --cpu-list
0-7 /usr/bin/sudo -n /usr/sbin/lvm lvs --config ' devices { preferred_names =
["^/dev/mapper/"] ignore_suspended_devices=1 write_cache_state=0
disable_after_error_count=3 filter = [
'\''a|/dev/mapper/36001405292bb96f19064f81b884fa63f|/dev/mapper/360014052c81462a280847e8a6e3af8cd|/dev/mapper/360014054729dfdd84d1493a818924b0d|/dev/mapper/3600140549f3b93968d440ac9129d124f|/dev/mapper/360014054b9a6f2539574211b84356cff|/dev/mapper/360014055b413c342a134486b616d2359|/dev/mapper/360014056cbd26bc649c4862b55905337|/dev/mapper/3600140573f2afb2d0404862b37b08cd6|/dev/mapper/360014057ce1a1afffd744dc8c34643d7|/dev/mapper/3600140587a66de91f05449a8cd9250b0|/dev/mapper/360014059e68c9a14a494de0bc808663b|/dev/mapper/36001405b6f4ebb5a456460c868ed8c7a|/dev/mapper/36001405c27599a89012467784cd463b4|/dev/mapper/36001405cc9ad490392b4277b52aec8d4|/dev/mapper/36001405d2!
aa1ad2c5ef4fa9820d93aa9|/dev/mapper/36001405d2d73a8d22ae44a5a36bda08d|/dev/mapper/36001405ef22c7b9fbff43fa93aa78719|/dev/mapper/36001405f148e99c5a3e4781b292fd7e1|/dev/mapper/36001405f16755b12e6444158b55d57db|/dev/mapper/36001405fd7e668fdf80479992b012af8|'\'',
'\''r|.*|'\'' ] } global { locking_type=1 prioritise_write_locks=1
wait_for_locks=1 use_lvmetad=0 } backup { retain_min = 50 retain_days = 0 }
' --noheadings --units b --nosuffix --separator '|' --ignoreskippedcluster -o
uuid,name,vg_name,attr,size,seg_start_pe,devices,tags
65059e74-7577-4356-8ce1-89e9634d986b (cwd None)
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:22,267::lvm::463::Storage.LVM::(_reloadlvs) lvs reloaded
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:22,268::lvm::1170::Storage.LVM::(_resizeLV) LV
65059e74-7577-4356-8ce1-89e9634d986b/c3eb6aec-e126-4a60-9a1c-a29aad9191d5
extend unneeded (size=2147483648, requested=2147483648)
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
gerrit-hooks has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 3: * #1363734::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1363734::OK, public bug * Check Product::#1363734::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
Nir Soffer has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1:
(3 comments)
Thanks for the quick review!
https://gerrit.ovirt.org/#/c/62338/1/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 1156: cmd += ("--size", "%sm" % (size,), "%s/%s" % (vgName, lvName))
Line 1157: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
Line 1158:
Line 1159: # If the command failed, we need to check the lv size to detect
pointless
Line 1160: # resizes, these are quite common with corrent code. So we have
invalidate
> to
Done
Line 1161: # the vg/lv in all case, to get the correct value from storage.
Line 1162: _lvminfo._invalidatevgs(vgName)
Line 1163: _lvminfo._invalidatelvs(vgName, lvName)
Line 1164:
Line 1156: cmd += ("--size", "%sm" % (size,), "%s/%s" % (vgName, lvName))
Line 1157: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
Line 1158:
Line 1159: # If the command failed, we need to check the lv size to detect
pointless
Line 1160: # resizes, these are quite common with corrent code. So we have
invalidate
> current
Done
Line 1161: # the vg/lv in all case, to get the correct value from storage.
Line 1162: _lvminfo._invalidatevgs(vgName)
Line 1163: _lvminfo._invalidatelvs(vgName, lvName)
Line 1164:
Line 1157: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
Line 1158:
Line 1159: # If the command failed, we need to check the lv size to detect
pointless
Line 1160: # resizes, these are quite common with corrent code. So we have
invalidate
Line 1161: # the vg/lv in all case, to get the correct value from storage.
> cases
Done
Line 1162: _lvminfo._invalidatevgs(vgName)
Line 1163: _lvminfo._invalidatelvs(vgName, lvName)
Line 1164:
Line 1165: if rc != 0:
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
gerrit-hooks has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 2: * #1363734::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1363734::OK, public bug * Check Product::#1363734::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
Nir Soffer has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62338/1/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 1164:
Line 1165: if rc != 0:
Line 1166: lv = getLV(vgName, lvName)
Line 1167: requested_size = size * constants.MEGAB
Line 1168: if lv.size >= requested_size:
> Why could it be greater? Just in the case of a race?
We request mb aligned sizes, and lvm round to extent size. But it is also
typical that we send multiple extend request for same size (one every 2
seconds), extend takes more than 2 seconds, and spm will try to extend again
after the lv was extended.
This log will help us to minimize the unneeded attempts.
Line 1169: log.debug("LV %s/%s extend unneeded (size=%d,
requested=%d)",
Line 1170: vgName, lvName, lv.size, requested_size)
Line 1171: return
Line 1172:
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
Adam Litke has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 1: (4 comments) A few minor nits and questions but otherwise this looks good, https://gerrit.ovirt.org/#/c/62338/1/vdsm/storage/lvm.py File vdsm/storage/lvm.py: PS1, Line 1160: to PS1, Line 1160: corrent current PS1, Line 1161: case cases PS1, Line 1168: > Why could it be greater? Just in the case of a race? -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: early IP+link setup
Petr Horáček has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 15: Verified+1 Restores IP config OK in the first stage of setup. OVS-DHCP reporting is not working with network.service OK, so it is restored again in second stage, but that is not introduced by this patch. -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
Allon Mureinik has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 1: Just to be clear - the theoretical performance penalty here is that we're invalidating caches on errors whereas the old (wrong) code used to invalidate them only on success, right? If so, I think we can live with it, +1. -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Fix error handling when resizing lvs
..
lvm: Fix error handling when resizing lvs
We depended on undocumented and wrong behavior in lvextend, returning
error code 3 when lvextend fail because lv size is same or bigger then
the requested size. Error code 3 means the command was invoked with
incorrect syntax. In EL 7.3, lvm changed the behavior and now lvextend
is retruning 5 in this case.
This patch changes the wrong code checking the error code to check the
lv size after errors, and fail only if lv size is smaller than the
requested size.
Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49
Bug-Url: https://bugzilla.redhat.com/1363734
Signed-off-by: Nir Soffer
---
M vdsm/storage/lvm.py
1 file changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/62338/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 3d3c31a..e12f535 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -1155,14 +1155,21 @@
cmd = (op,) + LVM_NOBACKUP
cmd += ("--size", "%sm" % (size,), "%s/%s" % (vgName, lvName))
rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
-if rc == 0:
-_lvminfo._invalidatevgs(vgName)
-_lvminfo._invalidatelvs(vgName, lvName)
-elif rc == 3:
-# In LVM we trust. Hope that 3 is only for this.
-log.debug("New size (in extents) matches existing size (in extents).")
-elif rc != 0:
+# If the command failed, we need to check the lv size to detect pointless
+# resizes, these are quite common with corrent code. So we have invalidate
+# the vg/lv in all case, to get the correct value from storage.
+_lvminfo._invalidatevgs(vgName)
+_lvminfo._invalidatelvs(vgName, lvName)
+
+if rc != 0:
+lv = getLV(vgName, lvName)
+requested_size = size * constants.MEGAB
+if lv.size >= requested_size:
+log.debug("LV %s/%s extend unneeded (size=%d, requested=%d)",
+ vgName, lvName, lv.size, requested_size)
+return
+
# get the free extents size
# YaRC
vg = getVG(vgName)
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Fix error handling when resizing lvs
gerrit-hooks has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 1: * #1363734::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1363734::OK, public bug * Check Product::#1363734::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: early IP+link setup
Edward Haas has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces
gerrit-hooks has posted comments on this change. Change subject: storage: Sortable ResourceManager lock namespaces .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: domainMonitor.getAllHostIds() API
gerrit-hooks has posted comments on this change. Change subject: storage: domainMonitor.getAllHostIds() API .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1d89bb114eea58387cd88d9da3c27b69d6affa3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Introduce guarded utilities
gerrit-hooks has posted comments on this change. Change subject: storage: Introduce guarded utilities .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sdm: Use guarded.context in copy_data
gerrit-hooks has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Introduce FakeSanlock
gerrit-hooks has posted comments on this change. Change subject: tests: Introduce FakeSanlock .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: export volume lease state in getVolumeInfo
gerrit-hooks has posted comments on this change. Change subject: storage: export volume lease state in getVolumeInfo .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If07ac876816b0a0ba61444fd94dc761508b09655 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: export volume lease state in getVolumeInfo
Adam Litke has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/61995/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 6854: description: An enumeration of Volume Lease statuses
Line 6855: name: VolumeLeaseStatus
Line 6856: type: enum
Line 6857: values:
Line 6858: NONE: The Volume does not have an associated lease
> The storage domain does not support volume leases.
Done
Line 6859: FREE: The lease is free
Line 6860: EXCLUSIVE: The lease is held in exclusive mode
Line 6861: SHARED: The lease is held in shared mode
Line 6862:
https://gerrit.ovirt.org/#/c/61995/1/lib/vdsm/storage/constants.py
File lib/vdsm/storage/constants.py:
Line 83: RAW_FORMAT: qemuimg.FORMAT.RAW,
Line 84: }
Line 85:
Line 86: # Volume lease states
Line 87: LEASE_NONE = "NONE"# No lease
> LEASE_UNSUPPORTED = "UNSUPPORTED"?
Done
Line 88: LEASE_FREE = "FREE"# The lease is available
Line 89: LEASE_EXCLUSIVE = "EXCLUSIVE" # The lease is held in exlusive mode
Line 90: LEASE_SHARED = "SHARED"# The lease is held in shared moce
Line 91:
Line 86: # Volume lease states
Line 87: LEASE_NONE = "NONE"# No lease
Line 88: LEASE_FREE = "FREE"# The lease is available
Line 89: LEASE_EXCLUSIVE = "EXCLUSIVE" # The lease is held in exlusive mode
Line 90: LEASE_SHARED = "SHARED"# The lease is held in shared moce
> moce -> mode
Done
Line 91:
Line 92: BLANK_UUID = "----"
Line 93:
Line 94:
https://gerrit.ovirt.org/#/c/61995/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 185: sd_manifest = sdCache.produce_manifest(self.sdUUID)
Line 186: if not sd_manifest.hasVolumeLeases():
Line 187: return sc.LEASE_NONE
Line 188: ver, owners = sd_manifest.inquireVolumeLease(self.imgUUID,
Line 189: self.volUUID)
> This does not return owners list but the lease owner host id, so better use
Done
Line 190: return sc.LEASE_EXCLUSIVE if owners else sc.LEASE_FREE
Line 191:
Line 192: def metadata2info(self, meta):
Line 193: return {
Line 186: if not sd_manifest.hasVolumeLeases():
Line 187: return sc.LEASE_NONE
Line 188: ver, owners = sd_manifest.inquireVolumeLease(self.imgUUID,
Line 189: self.volUUID)
Line 190: return sc.LEASE_EXCLUSIVE if owners else sc.LEASE_FREE
> So "if owners" is wrong (in case host_id is 0).
Done
Line 191:
Line 192: def metadata2info(self, meta):
Line 193: return {
Line 194: "uuid": self.volUUID,
--
To view, visit https://gerrit.ovirt.org/61995
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If07ac876816b0a0ba61444fd94dc761508b09655
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: periodic health check - WIP
Milan Zamazal has posted comments on this change. Change subject: virt: periodic health check - WIP .. Patch Set 4: Thank you, this looks like a better direction. -- To view, visit https://gerrit.ovirt.org/61592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad60a4ace3a97b3e69f55bee3f5dad8a638d616d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: infra tests: added functional test for upgrading vdsm
gerrit-hooks has posted comments on this change. Change subject: infra tests: added functional test for upgrading vdsm .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding units to cpu metrics name according to metrics2.0 spec
Nir Soffer has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62156/3/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 104: Line 105: data[prefix + '.vms.active'] = hoststats['vmActive'] Line 106: data[prefix + '.vms.total'] = hoststats['vmCount'] Line 107: Line 108: data[prefix + '.cpu.load_5M'] = hoststats['cpuLoad'] > ok, but it's still in 5 minutes intervals.. so I assumed we would want the This is not intervals, not sure that we need unit info for something that does not have a unit. Line 109: data[prefix + '.cpu.user_jiff'] = hoststats['cpuUser'] Line 110: data[prefix + '.cpu.sys_jiff'] = hoststats['cpuSys'] Line 111: data[prefix + '.cpu.idle_jiff'] = hoststats['cpuIdle'] Line 112: data[prefix + '.cpu.sys_vdsmd_jiff'] = hoststats['cpuSysVdsmd'] -- To view, visit https://gerrit.ovirt.org/62156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I366280bf1c3783fdbbdd7459e49ae7fcf5e8b598 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: infra tests: added functional test for upgrading vdsm
gerrit-hooks has posted comments on this change. Change subject: infra tests: added functional test for upgrading vdsm .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: fixing repos for standard ci
gerrit-hooks has posted comments on this change. Change subject: fixing repos for standard ci .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gal Ben Haim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: fixing repos for standard ci
Eyal Edri has posted comments on this change. Change subject: fixing repos for standard ci .. Patch Set 6: Verified-1 putting -verified since it will break until we'll have centos repos for ppc64le -- To view, visit https://gerrit.ovirt.org/62123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eyal Edri Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gal Ben Haim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: periodic: always re-schedule operations
Milan Zamazal has posted comments on this change. Change subject: periodic: always re-schedule operations .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb5836ca768c88316896e233d756a986e3111d8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: early IP+link setup
gerrit-hooks has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 15: * #1364087::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364087::OK, public bug * Check Product::#1364087::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: early IP+link setup
Petr Horáček has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/60371/14/lib/vdsm/network/restore.py File lib/vdsm/network/restore.py: > Module names in a form of verbs are a a bit weird. Done Line 1: # Copyright 2016 Red Hat, Inc. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by https://gerrit.ovirt.org/#/c/60371/14/vdsm.spec.in File vdsm.spec.in: PS14, Line 1310: networks > drop the 's' Done -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: virt: Limit the number of workers in executor
Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba56d91474c6b14a1cfe2db827b6fd61843a1db2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash
Idan Shaby has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/61581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes
Idan Shaby has posted comments on this change. Change subject: fileUtils: Normalize initial double slashes .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/61580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash
gerrit-hooks has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 2: * #1361182::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1361182::OK, public bug * Check Product::#1361182::OK, Correct classification oVirt * Check TM::#1361182::OK, correct target milestone ovirt-4.0.4 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/61581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes
gerrit-hooks has posted comments on this change. Change subject: fileUtils: Normalize initial double slashes .. Patch Set 2: * #1361182::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1361182::OK, public bug * Check Product::#1361182::OK, Correct classification oVirt * Check TM::#1361182::OK, correct target milestone ovirt-4.0.4 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/61580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: functional tests: fix supervdsmServer test
gerrit-hooks has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Collect ksm values only if exist
Yaniv Kaul has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/62142/4/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 113: Line 114: # only available when mom is configured to run Line 115: if 'ksmPages' in hoststats: Line 116: report[prefix + '.cpu.ksm_pages'] = hoststats['ksmPages'] Line 117: report[prefix + '.cpu.ksm_cpu_precent'] = hoststats['ksmCpu'] typo: precent -> percent Line 118: Line 119: if hoststats['haStats']['configured']: Line 120: report[prefix + '.ha_score'] = hoststats['haScore'] Line 121: -- To view, visit https://gerrit.ovirt.org/62142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d1aa7830bff26c688a7c0322152e7c96ab4ecfa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding units to memory metrics name according to metrics2.0 ...
gerrit-hooks has posted comments on this change. Change subject: Adding units to memory metrics name according to metrics2.0 spec .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1020b89c5ebb2412750352d6c2131097dcbaf407 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding percent suffix to metric name spacing
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding percent suffix to metric name spacing
..
Adding percent suffix to metric name spacing
Change-Id: Ibe87f2b9b31aaa9555b2df68689b5e9edbe398b9
Signed-off-by: Yaniv Bronhaim
---
M lib/vdsm/health.py
M lib/vdsm/host/api.py
M lib/vdsm/metrics/__init__.py
3 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/62335/1
diff --git a/lib/vdsm/health.py b/lib/vdsm/health.py
index 94c9f14..7b9aede 100644
--- a/lib/vdsm/health.py
+++ b/lib/vdsm/health.py
@@ -30,6 +30,7 @@
from . import host
from vdsm.metrics import MB
+from vdsm.metrics import PERCENT
from vdsm.metrics import send
_monitor = None
@@ -128,8 +129,8 @@
report = {}
report[prefix + '.gc.uncollectable'] = \
self._stats['uncollectable_obj']
-report[prefix + '.cpu.user_pct'] = self._stats['utime_pct']
-report[prefix + '.cpu.sys_pct'] = self._stats['stime_pct']
+report[prefix + '.cpu.user' + PERCENT] = self._stats['utime_pct']
+report[prefix + '.cpu.sys' + PERCENT] = self._stats['stime_pct']
report[prefix + '.memory.rss' + MB] = self._stats['rss']
report[prefix + '.threads_count'] = self._stats['threads']
send(report)
diff --git a/lib/vdsm/host/api.py b/lib/vdsm/host/api.py
index 0fb7e3f..52f0e0c 100644
--- a/lib/vdsm/host/api.py
+++ b/lib/vdsm/host/api.py
@@ -31,6 +31,7 @@
from vdsm.define import Kbytes, Mbytes
from vdsm.metrics import JIFFIES
from vdsm.metrics import MB
+from vdsm.metrics import PERCENT
from vdsm.metrics import send
from vdsm.virt import vmstatus
@@ -117,7 +118,7 @@
if 'ksmPages' in hoststats:
data[prefix + '.cpu.ksm_pages'] = hoststats['ksmPages']
-data[prefix + '.cpu.ksm_cpu_precent'] = hoststats['ksmCpu']
+data[prefix + '.cpu.ksm_cpu' + PERCENT] = hoststats['ksmCpu']
if hoststats['haStats']['configured']:
data[prefix + '.ha_score'] = hoststats['haScore']
diff --git a/lib/vdsm/metrics/__init__.py b/lib/vdsm/metrics/__init__.py
index 1007310..f7714e0 100644
--- a/lib/vdsm/metrics/__init__.py
+++ b/lib/vdsm/metrics/__init__.py
@@ -26,6 +26,7 @@
# METRIC UNIT SUFFIX REPRESENTATION
MB = '_M'
JIFFIES = '_jiff'
+PERCENT = '_percent'
_reporter = None
--
To view, visit https://gerrit.ovirt.org/62335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe87f2b9b31aaa9555b2df68689b5e9edbe398b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding percent suffix to metric name spacing
gerrit-hooks has posted comments on this change. Change subject: Adding percent suffix to metric name spacing .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe87f2b9b31aaa9555b2df68689b5e9edbe398b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding memTotal metric
gerrit-hooks has posted comments on this change. Change subject: Adding memTotal metric .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b237aa559f8b0ca835fb55c1205b2766c656a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding units to cpu metrics name according to metrics2.0 spec
gerrit-hooks has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I366280bf1c3783fdbbdd7459e49ae7fcf5e8b598 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding units to cpu metrics name according to metrics2.0 spec
Yaniv Bronhaim has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62156/3/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 104: Line 105: data[prefix + '.vms.active'] = hoststats['vmActive'] Line 106: data[prefix + '.vms.total'] = hoststats['vmCount'] Line 107: Line 108: data[prefix + '.cpu.load_5M'] = hoststats['cpuLoad'] > CPU load is actually how many processes are waiting for CPU in a given time ok, but it's still in 5 minutes intervals.. so I assumed we would want the 5M suffix to have this info Line 109: data[prefix + '.cpu.user_jiff'] = hoststats['cpuUser'] Line 110: data[prefix + '.cpu.sys_jiff'] = hoststats['cpuSys'] Line 111: data[prefix + '.cpu.idle_jiff'] = hoststats['cpuIdle'] Line 112: data[prefix + '.cpu.sys_vdsmd_jiff'] = hoststats['cpuSysVdsmd'] -- To view, visit https://gerrit.ovirt.org/62156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I366280bf1c3783fdbbdd7459e49ae7fcf5e8b598 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Send metrics info only if metrics enabled to avoid parsing l...
Irit Goihman has posted comments on this change. Change subject: Send metrics info only if metrics enabled to avoid parsing logic .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5df7708acb3aeca6b659cd7a5ec72748325b2cb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding get_batch to StatsCache - returns dict with all vms stat
Irit Goihman has posted comments on this change. Change subject: Adding get_batch to StatsCache - returns dict with all vms stat .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Collect ksm values only if exist
gerrit-hooks has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/62142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d1aa7830bff26c688a7c0322152e7c96ab4ecfa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Collect ksm values only if exist
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Collect ksm values only if exist .. Collect ksm values only if exist Ksm values appear only if mom is enabled Change-Id: I5d1aa7830bff26c688a7c0322152e7c96ab4ecfa Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/61767 Reviewed-by: Francesco Romani Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/62142 Reviewed-by: Irit Goihman --- M lib/vdsm/host/api.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d1aa7830bff26c688a7c0322152e7c96ab4ecfa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Collect ksm values only if exist
Yaniv Bronhaim has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d1aa7830bff26c688a7c0322152e7c96ab4ecfa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding report_stats to virt.stats
Irit Goihman has posted comments on this change. Change subject: Adding report_stats to virt.stats .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf494c6a3087d04c12731c587b619f253dd51165 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Rename reports to metrics
Irit Goihman has posted comments on this change. Change subject: Rename reports to metrics .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I340c1854d67ce5b6be01cad6a540c6d81eaa0eff Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Collect ksm values only if exist
Irit Goihman has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d1aa7830bff26c688a7c0322152e7c96ab4ecfa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: change getVolumesList schema conversion
gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: change getVolumesList schema conversion .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac4683cf1abe2eb476e3a628ca5a8b031e7d398a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: change getVolumesList schema conversion
Irit Goihman has posted comments on this change. Change subject: jsonrpcvdscli: change getVolumesList schema conversion .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62325/1//COMMIT_MSG Commit Message: Line 7: jsonrpcvdscli: change getVolumesList schema conversion Line 8: Line 9: getVolumesList was converted to Image.getVolumes in patch Line 10: https://gerrit.ovirt.org/#/c/55252/ while it should be converted Line 11: to StorageDomain.getVolumes in order to be consistent with vdscli > Please mention the commit that added this error. Done Line 12: commands Line 13: Line 14: Change-Id: Iac4683cf1abe2eb476e3a628ca5a8b031e7d398a -- To view, visit https://gerrit.ovirt.org/62325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac4683cf1abe2eb476e3a628ca5a8b031e7d398a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: virt: Fix of Executor._active_workers crash on modification
Milan Zamazal has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaed995109e98c5ab79724a4765c3212140ebebb7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: change getVolumesList schema conversion
Nir Soffer has posted comments on this change. Change subject: jsonrpcvdscli: change getVolumesList schema conversion .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/62325/1//COMMIT_MSG Commit Message: Line 7: jsonrpcvdscli: change getVolumesList schema conversion Line 8: Line 9: getVolumesList was converted to Image.getVolumes while it Line 10: should be converted to StorageDomain.getVolumes in order to be Line 11: consistent with vdscli commands Please mention the commit that added this error. Line 12: Line 13: Change-Id: Iac4683cf1abe2eb476e3a628ca5a8b031e7d398a -- To view, visit https://gerrit.ovirt.org/62325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac4683cf1abe2eb476e3a628ca5a8b031e7d398a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt net: Support VM migration on OVS based networks
Edward Haas has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks .. Patch Set 17: Verified+1 -- To view, visit https://gerrit.ovirt.org/59645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: functional tests: fix supervdsmServer test
Irit Goihman has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/61902/11/tests/functional/Makefile.am File tests/functional/Makefile.am: Line 27:networkTestsOVS.py \ Line 28:sosPluginTests.py \ Line 29:supervdsmFuncTests.py \ Line 30:test_ksm_action.py \ Line 31:test_ping_call.py \ > those are helpers that you don't plan to run directly, why the test prefix? because they are still tests and are run with nosetest? Line 32:utils.py \ Line 33:virtTests.py \ Line 34:vmQoSTests.py \ Line 35:vmRecoveryTests.py \ https://gerrit.ovirt.org/#/c/61902/11/tests/functional/supervdsmFuncTests.py File tests/functional/supervdsmFuncTests.py: Line 32: Line 33: Line 34: class TestSuperVdsmRemotly(TestCaseBase): Line 35: def testPingCall(self): Line 36: p = subprocess.Popen > specify that it must run from /usr/share/vdsm/tests Done Line 37: ( Line 38: ['/usr/share/vdsm/tests/run_tests.sh', Line 39: 'functional/test_ping_call.py'] Line 40: ) -- To view, visit https://gerrit.ovirt.org/61902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: functional tests: fix supervdsmServer test
gerrit-hooks has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding memTotal metric
Yaniv Bronhaim has posted comments on this change. Change subject: Adding memTotal metric .. Patch Set 3: we don't have anything like a general host agent except vdsm currently, and the value for memTotal is that Shirly wants to present this value -- To view, visit https://gerrit.ovirt.org/62154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b237aa559f8b0ca835fb55c1205b2766c656a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding memTotal metric
Yaniv Kaul has posted comments on this change. Change subject: Adding memTotal metric .. Patch Set 3: What's the value of adding this metric? Don't we expect it to be collected by a general host agent that'll send this metric? (same as CPU load and others, btw). -- To view, visit https://gerrit.ovirt.org/62154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b237aa559f8b0ca835fb55c1205b2766c656a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
