Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/62765/3/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

PS3, Line 467: env['LIBGUESTFS_BACKEND'] = 'direct'
> wasn't it always mandatory?
Yes. Nothing has changed about it.


-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: implementing StorageDomain.movePV

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing StorageDomain.movePV
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62785
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.movePV API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.movePV API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62784
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6dce392d4cf157c42a47f70e972fa5d1d9dbdc2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: vdscli: switch to the new devel_warn helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: vdscli: switch to the new devel_warn helper
..


Patch Set 2:

* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1189097826e79290cb996657ccf34a7c2b611ee0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 2:

* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: api: use the new devel_warn helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: api: use the new devel_warn helper
..


Patch Set 2:

* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62210
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc85dde59e09a5882e9d586fb0d37d2434f0a351
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: logUtils: add devel_warn function

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 2:

* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: fileUtils: drop redundant warning

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 2:

* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/62765/3/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

PS3, Line 467: env['LIBGUESTFS_BACKEND'] = 'direct'
wasn't it always mandatory?


-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: mom: create the socket under tmpdir

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 1: Verified+1

test still run, hence V+1

-- 
To view, visit https://gerrit.ovirt.org/62779
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 3:

It seems the job 
(http://jenkins.ovirt.org/job/vdsm_4.0_build-artifacts-manual-fc23-x86_64/1/console)
 is failing for an unrelated issue, and some tests needs to be improved. Please 
rebase on top of 
https://gerrit.ovirt.org/62779
and try again

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: mom: create the socket under tmpdir

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62779
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: mom: create the socket under tmpdir

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: tests: mom: create the socket under tmpdir
..

tests: mom: create the socket under tmpdir

Some tests may fail under automation if Vdsm
is built and its test are run under a too nested
directory.
This because the absolute path of the UNIX domain
socket becomes too long.

To fix this, we create the socket under a temporary
directory.
This also makes cleanup a little easier.

Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Signed-off-by: Francesco Romani 
---
M tests/momTests.py
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/62779/1

diff --git a/tests/momTests.py b/tests/momTests.py
index 764aa57..c454dcb 100644
--- a/tests/momTests.py
+++ b/tests/momTests.py
@@ -19,6 +19,8 @@
 
 from unittest import TestCase
 import logging
+import shutil
+import tempfile
 import threading
 from vdsm.define import Mbytes
 from vdsm.momIF import MomClient
@@ -30,7 +32,7 @@
 from vdsm import cpuarch
 
 MOM_CONF = "/dev/null"
-MOM_PORT = os.path.join(os.path.dirname(__file__), "test_mom_vdsm.sock")
+MOM_SOCK = "test_mom_vdsm.sock"
 
 
 class DummyMomApi(object):
@@ -67,12 +69,20 @@
 # added during the tests.
 @monkeypatch.MonkeyClass(logging.getLogger().manager, "loggerDict", {})
 class MomPolicyTests(TestCase):
+
+_TMP_DIR = '/tmp'
+
 def setUp(self):
+self._tmp_dir = tempfile.mkdtemp(dir=self._TMP_DIR)
 self.config_overrides = configparser.SafeConfigParser()
 self.config_overrides.add_section("logging")
 self.config_overrides.set("logging", "log", "stdio")
 self.config_overrides.add_section("main")
-self.config_overrides.set("main", "rpc-port", str(MOM_PORT))
+self.config_overrides.set("main", "rpc-port",
+  os.path.join(self._tmp_dir, MOM_SOCK))
+
+def tearDown(self):
+shutil.rmtree(self._tmp_dir)
 
 def _getMomClient(self):
 return MomClient(MOM_CONF, self.config_overrides)


-- 
To view, visit https://gerrit.ovirt.org/62779
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/62560/3//COMMIT_MSG
Commit Message:

Line 4: Commit: Sharon Naftaly 
Line 5: CommitDate: 2016-08-24 15:57:58 +0300
Line 6: 
Line 7: Adding build-artifacts-manual.sh script
Line 8: 
what is that script? can you add link to some explanation about it? I recall CI 
wiki that explains each check-* script
Line 9: Adding build-artifacts-manual.sh script and related
Line 10: packages and repos files.
Line 11: 
Line 12: Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7


https://gerrit.ovirt.org/#/c/62560/3/automation/build-artifacts-manual.sh
File automation/build-artifacts-manual.sh:

Line 14: # create the src.rpm, assuming the tarball is in the directory
Line 15: rpmbuild \
Line 16: -D "_srcrpmdir $OUTPUT" \
Line 17: -D "_topmdir $BUILDS" \
Line 18: -ts ./*.gz
why don't you use make rpm?
Line 19: 
Line 20: # install any build requirements
Line 21: yum-builddep output/*src.rpm
Line 22: 


Line 32: find "$PWD" \
Line 33: -maxdepth 1 \
Line 34: -iname vdsm\*.tar.gz \
Line 35: -exec mv {} "$EXPORTS/" \;
Line 36
how is it different than build-artifacts script?


-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: refactor: Move pathToVolID method

[alitke]

Adam Litke has posted comments on this change.

Change subject: vm: refactor: Move pathToVolID method
..


Patch Set 3: Code-Review+1

Was it a false negative CI failure?
Leaving for Francesco to +2 since it's virt.

-- 
To view, visit https://gerrit.ovirt.org/62180
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d8ef439120b8dff79cda9fcff7c42040f75e35e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: Retrieve backing chain stats

[alitke]

Adam Litke has posted comments on this change.

Change subject: sampling: Retrieve backing chain stats
..


Patch Set 4: Code-Review+1

Can you provide an update on the progress of the performance tests?

-- 
To view, visit https://gerrit.ovirt.org/60888
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Restore watermark tracking

[alitke]

Adam Litke has posted comments on this change.

Change subject: Live Merge: Restore watermark tracking
..


Patch Set 14:

(1 comment)

couple of minor things and this will be ready for merge.

https://gerrit.ovirt.org/#/c/60889/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS14, Line 1007: path
Maybe change to '.path' to be safer?


-- 
To view, visit https://gerrit.ovirt.org/60889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Restore watermark tracking

[alitke]

Adam Litke has posted comments on this change.

Change subject: Live Merge: Restore watermark tracking
..


Patch Set 13:

(2 comments)

https://gerrit.ovirt.org/#/c/60889/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS13, Line 931: ret.append((drive, drive.volumeID, capacity, alloc,
  : physical))
This does not need to be moved inside the try block.  You can keep it after 
(like it was originally) and minimize changes.


PS13, Line 4752: COW'
> in a separate patch
please fix in this patch.  Otherwise we're introducing too much noise into the 
commit history.


-- 
To view, visit https://gerrit.ovirt.org/60889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

[alitke]

Adam Litke has posted comments on this change.

Change subject: core: Use constant instead of text
..


Patch Set 1: Code-Review-1

(1 comment)

This patch fixes up code from a previous patch,  Please squash it into the 
previous one.

https://gerrit.ovirt.org/#/c/62366/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS1, Line 4752: vol_format = sc.name2type(baseInfo['format'])
If baseInfo['format'] is a string (like COW or RAW) then just compare against 
the string based constants in sc:

 if drive.chunked and baseInfo['format'] == sc.type2name(sc.COW_FORMAT):


-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: make conf_persistence_test pass

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: py3: make conf_persistence_test pass
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 1:

* #1368474::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1368474::OK, public bug
* Check Product::#1368474::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[rnachimu]

Ramesh N has uploaded a new change for review.

Change subject: gluster: set selinux labels while creating bricks
..

gluster: set selinux labels while creating bricks

brick should have correct selinux labels on the brick mount
points. But it missing in the createBrick vdsm verb.

This patch sets the correct selinux lables on brick mount
point using 'restorecon' and 'semanage' commands

Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Bug-Url: https://bugzilla.redhat.com/1368474
Signed-off-by: Ramesh Nachimuthu 
---
M lib/vdsm/gluster/exception.py
M vdsm/gluster/storagedev.py
2 files changed, 40 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/62773/1

diff --git a/lib/vdsm/gluster/exception.py b/lib/vdsm/gluster/exception.py
index 43ad1da..2fad69e 100644
--- a/lib/vdsm/gluster/exception.py
+++ b/lib/vdsm/gluster/exception.py
@@ -479,6 +479,28 @@
 message = "vgscan failed"
 
 
+class GlusterHostFailedToSetSelinuxContext(GlusterHostException):
+code = 4420
+
+def __init__(self, brickMountPoint=None, rc=0, out=(), err=()):
+self.rc = rc
+self.out = out
+self.err = err
+self.message = "Failed to set selinux context on the brick : %s" \
+   % (brickMountPoint)
+
+
+class GlusterHostFailedToRunRestorecon(GlusterHostException):
+code = 4421
+
+def __init__(self, brickMountPoint=None, rc=0, out=(), err=()):
+self.rc = rc
+self.out = out
+self.err = err
+self.message = "Failed to run restorecon on the brick : %s" \
+   % (brickMountPoint)
+
+
 # Hook
 class GlusterHookException(GlusterException):
 code = 4500
diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 4b56b3c..5ddbb6b 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -54,6 +54,12 @@
 _vgscanCommandPath = utils.CommandPath("vgscan",
"/sbin/vgscan",
"/usr/sbin/vgscan",)
+_semanageCommandPath = utils.CommandPath("semanage",
+ "/sbin/semanage",
+ "/usr/sbin/semanage",)
+_restoreconCommandPath = utils.CommandPath("restorecon",
+   "/sbin/restorecon",
+   "/usr/sbin/restorecon",)
 
 # All size are in MiB unless otherwise specified
 DEFAULT_CHUNK_SIZE_KB = 256
@@ -306,6 +312,18 @@
 thinlv.format.setup(mountpoint=mountPoint)
 blivetEnv.doIt()
 
+#Set correct selinux labels on the brick
+rc, out, err = commands.execCmd([_semanageCommandPath.cmd,
+ 'fcontext', '-a', '-t',
+ 'glusterd_brick_t', mountPoint])
+if rc:
+raise ge.GlusterHostFailedToSetSelinuxContext(mountPoint, rc, out, err)
+
+rc, out, err = commands.execCmd([_restoreconCommandPath.cmd,
+'-Rv', mountPoint])
+if rc:
+raise ge.GlusterHostFailedToRunRestorecon(mountPoint, rc, out, err)
+
 # bz#1230495: lvm devices are invisible and appears only after vgscan
 # Workaround: Till the bz gets fixed, We use vgscan to refresh LVM devices
 rc, out, err = commands.execCmd([_vgscanCommandPath.cmd])


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmdisk hook: add support for booting from image file

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vmdisk hook: add support for booting from image file
..


Patch Set 7:

(3 comments)

https://gerrit.ovirt.org/#/c/58748/6/vdsm_hooks/vmdisk/before_vm_start.py
File vdsm_hooks/vmdisk/before_vm_start.py:

PS6, Line 70: []
> Tried and failed. Not sure why, my python knowledge is not so good :)
Basically, you need to use .add instead of .append with sets.


PS6, Line 84: sorted(boo
> Done
I don't think `sorted' makes much sense here, especially if a set is used 
instead of a list.


https://gerrit.ovirt.org/#/c/58748/7/vdsm_hooks/vmdisk/before_vm_start.py
File vdsm_hooks/vmdisk/before_vm_start.py:

Line 116: hooking.write_domxml(domxml)
Line 117: except:
Line 118: sys.stderr.write('vmdisk: [unexpected error]: %s\n' %
Line 119:  traceback.format_exc())
Line 120: sys.exit(2)
Please add a newline character at the end of this last line, otherwise the 
style checking tools complain and continuous integration fails.


-- 
To view, visit https://gerrit.ovirt.org/58748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b3f6239f3c58a9f9497e74e5d9c8993d78d81e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dmitry Glushenok 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Glushenok 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 3: Verified+1

(1 comment)

Verified. Now virt-v2v completes the import successfully.

https://gerrit.ovirt.org/#/c/62765/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 466: # virt-v2v specific variables
Line 467: env['LIBGUESTFS_BACKEND'] = 'direct'
Line 468: if 'virtio_iso_path' in self._vminfo:
Line 469: env['VIRTIO_WIN'] = self._vminfo['virtio_iso_path']
Line 470: return env
> spurious extra line. Nice, but unneeded.
Removed.
Line 471: 
Line 472: @contextmanager
Line 473: def _password_file(self):
Line 474: fd = os.open(self._passwd_file, os.O_WRONLY | os.O_CREAT, 
0o600)


-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: make conf_persistence_test pass

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: make conf_persistence_test pass
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 3:

* #1367839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367839::OK, public bug
* Check Product::#1367839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: make conf_persistence_test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: make conf_persistence_test
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: define __nonzero__ by means of __bool__

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: define __nonzero__ by means of __bool__
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96beb2c794490def4ed904edd1c52ac2eb7b09a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: make conf_persistence_test

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: py3: make conf_persistence_test
..

py3: make conf_persistence_test

In Python 3, an exception is not iterable, though its args are.

Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Signed-off-by: Dan Kenigsberg 
---
M tests/Makefile.am
M tests/network/conf_persistence_test.py
2 files changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/62772/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 607c1de..2dce548 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -192,7 +192,6 @@
momTests.py \
monkeypatchTests.py \
mountTests.py \
-   network/conf_persistence_test.py \
network/conf_test.py \
network/hook_ovs_test.py \
network/iproute2_test.py \
diff --git a/tests/network/conf_persistence_test.py 
b/tests/network/conf_persistence_test.py
index a55f96f..5981d4c 100644
--- a/tests/network/conf_persistence_test.py
+++ b/tests/network/conf_persistence_test.py
@@ -158,8 +158,7 @@
 with Transaction(config=self.config) as _config:
 _config.setNetwork(NETWORK, NETWORK_ATTRIBUTES)
 raise TestException()
-
-diff, ex_type, _ = roi.exception
+diff, ex_type, _ = roi.exception.args
 self.assertEquals(diff.networks[NETWORK], {'remove': True})
 self.assertEquals(ex_type, TestException)
 file_path = os.path.join(self.tempdir, 'nets', NETWORK)


-- 
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: define __nonzero__ by means of __bool__

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: py3: define __nonzero__ by means of __bool__
..

py3: define __nonzero__ by means of __bool__

Python 3 has renamed __nonzero__ to __bool__. As long as we support both
language flavours, we should have both methods defined.

https://docs.python.org/3/library/2to3.html?highlight=__nonzero__#2to3fixer-nonzero

Signed-off-by: Dan Kenigsberg 
Change-Id: I96beb2c794490def4ed904edd1c52ac2eb7b09a5
---
M lib/vdsm/network/ip/address.py
M lib/vdsm/network/netconfpersistence.py
M lib/vdsm/virt/utils.py
3 files changed, 16 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/62771/1

diff --git a/lib/vdsm/network/ip/address.py b/lib/vdsm/network/ip/address.py
index 0842eb4..35f3eaa 100644
--- a/lib/vdsm/network/ip/address.py
+++ b/lib/vdsm/network/ip/address.py
@@ -57,8 +57,11 @@
 self.defaultRoute = defaultRoute
 self.bootproto = bootproto
 
-def __nonzero__(self):
+def __bool__(self):
 return bool(self.address or self.bootproto)
+
+def __nonzero__(self):  # TODO: drop when py2 is no longer needed
+return self.__bool__()
 
 def __repr__(self):
 return 'IPv4(%s, %s, %s, %s, %s)' % (self.address, self.netmask,
@@ -115,9 +118,12 @@
 self.ipv6autoconf = ipv6autoconf
 self.dhcpv6 = dhcpv6
 
-def __nonzero__(self):
+def __bool__(self):
 return bool(self.address or self.ipv6autoconf or self.dhcpv6)
 
+def __nonzero__(self):  # TODO: drop when py2 is no longer needed
+return self.__bool__()
+
 def __repr__(self):
 return 'IPv6(%s, %s, %s, %s, %s)' % (
 self.address, self.gateway, self.defaultRoute, self.ipv6autoconf,
diff --git a/lib/vdsm/network/netconfpersistence.py 
b/lib/vdsm/network/netconfpersistence.py
index 46d831a..37b9e89 100644
--- a/lib/vdsm/network/netconfpersistence.py
+++ b/lib/vdsm/network/netconfpersistence.py
@@ -89,9 +89,12 @@
 return '%s(%s, %s)' % (self.__class__.__name__, self.networks,
self.bonds)
 
-def __nonzero__(self):
+def __bool__(self):
 return True if self.networks or self.bonds else False
 
+def __nonzero__(self):  # TODO: drop when py2 is no longer needed
+return self.__bool__()
+
 @staticmethod
 def _confDictDiff(lhs, rhs):
 result = {}
diff --git a/lib/vdsm/virt/utils.py b/lib/vdsm/virt/utils.py
index 9d54f7d..ed79111 100644
--- a/lib/vdsm/virt/utils.py
+++ b/lib/vdsm/virt/utils.py
@@ -88,7 +88,7 @@
 with self._lock:
 del self._items[key]
 
-def __nonzero__(self):
+def __bool__(self):
 now = self._clock()
 with self._lock:
 expired_keys = [
@@ -100,6 +100,9 @@
 
 return bool(self._items)
 
+def __nonzero__(self):  # TODO: drop when py2 is no longer needed
+return self.__bool__()
+
 # private
 
 def _get_live(self, key):


-- 
To view, visit https://gerrit.ovirt.org/62771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96beb2c794490def4ed904edd1c52ac2eb7b09a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Adding build-artifacts-manual.sh script

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 3: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches ovirt-4.0, master

-- 
To view, visit https://gerrit.ovirt.org/62557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ea3ad68dbd5f822f6e57f4557b4670cb0e89c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Adding build-artifacts-manual.sh script

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 3: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/62559
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/62765/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 466: # virt-v2v specific variables
Line 467: env['LIBGUESTFS_BACKEND'] = 'direct'
Line 468: if 'virtio_iso_path' in self._vminfo:
Line 469: env['VIRTIO_WIN'] = self._vminfo['virtio_iso_path']
Line 470: 
spurious extra line. Nice, but unneeded.
Line 471: return env
Line 472: 
Line 473: @contextmanager
Line 474: def _password_file(self):


-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: coalesce join() into stop()

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: migration: coalesce join() into stop()
..


Patch Set 3: Code-Review+1

Good idea.

-- 
To view, visit https://gerrit.ovirt.org/62587
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6def55d50a61ac983b45e826c05e09887fe5ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: switch type switch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: switch type switch
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 2:

* #1367839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367839::OK, public bug
* Check Product::#1367839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 1:

* #1367839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367839::OK, public bug
* Check Product::#1367839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[Tomas Golembiovsky]

Tomas Golembiovsky has uploaded a new change for review.

Change subject: v2v: Running virt-v2v with some sane environment
..

v2v: Running virt-v2v with some sane environment

Starting virt-v2v with (almost) empty environment no longer works and
virt-v2v expect at least PATH to be set properly. Otherwise it will fail
to find external tools.

Still, even if virt-v2v was OK with it, having empty environment is not
a good idea either. Since it depends on couple external tools they may
also require some basic environment to work properly.

Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Bug-Url: https://bugzilla.redhat.com/1367839
Signed-off-by: Tomáš Golembiovský 
---
M lib/vdsm/v2v.py
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/62765/1

diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index c6a9943..8b11cf3 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -460,9 +460,14 @@
 return path.rsplit(os.sep, 3)[0]
 
 def _environment(self):
-env = {'LIBGUESTFS_BACKEND': 'direct'}
+# Provide some sane environment
+env = os.environ.copy()
+
+# virt-v2v specific variables
+env['LIBGUESTFS_BACKEND'] = 'direct'
 if 'virtio_iso_path' in self._vminfo:
 env['VIRTIO_WIN'] = self._vminfo['virtio_iso_path']
+
 return env
 
 @contextmanager


-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: lvm: Separate lv reduce and extend

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Separate lv reduce and extend
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62735
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0021d380fb26318ed565b3fae0205404d90bea28
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: lvm: Never hide lvm errors

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Never hide lvm errors
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62733
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce160ecddebfc903fb7bc00ba5a69e63f2cc996
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Improve logging lv activation logging
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62732
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: lvm: Separate lv reduce and extend

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Separate lv reduce and extend
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62740
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0021d380fb26318ed565b3fae0205404d90bea28
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: lvm: Never hide lvm errors

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Never hide lvm errors
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce160ecddebfc903fb7bc00ba5a69e63f2cc996
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: lvm: Fix error handling when resizing lvs

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Fix error handling when resizing lvs
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62739
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: lvm: Improve logging lv activation logging

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Improve logging lv activation logging
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62737
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: lvm: Refresh lvs during activation

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Refresh lvs during activation
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62736
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I845ce1f930d7673ec16cfa0a11399081ae2e6caa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: lvm: Fix error handling when resizing lvs

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Fix error handling when resizing lvs
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62734
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: lvm: Refresh lvs during activation

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: lvm: Refresh lvs during activation
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62731
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I845ce1f930d7673ec16cfa0a11399081ae2e6caa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: switch switch draft

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: switch switch draft
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: filter out Xen VMs with block storage

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/62368/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: v2v: filter out Xen VMs with block storage
Line 8: 
Line 9: virt-v2v is not support importing Xen VMs with block storage domain.
Line 10: No need to return these VMs via get_external_vms verb
> There is no filter in the engine for snapshots... (there is an RFE but solu
Ok.
Line 11: 
Line 12: Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Line 13: Bug-Url: https://bugzilla.redhat.com/1365411


-- 
To view, visit https://gerrit.ovirt.org/62368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: switch switch draft

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: switch switch draft
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: switch switch draft

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: switch switch draft
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: early IP+link setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: early IP+link setup
..


Patch Set 17:

* #1364087::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364087::OK, public bug
* Check Product::#1364087::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: early IP+link setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: early IP+link setup
..


Patch Set 16:

* #1364087::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364087::OK, public bug
* Check Product::#1364087::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: early IP+link setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: early IP+link setup
..


Patch Set 15:

(3 comments)

https://gerrit.ovirt.org/#/c/60371/15/lib/vdsm/network/netrestore.py
File lib/vdsm/network/netrestore.py:

Line 32: from . import netswitch
Line 33: from .netconfpersistence import PersistentConfig
Line 34: 
Line 35: 
Line 36: _NETS_RESTORED_MARK = os.path.join(P_VDSM_RUN, 'nets_restored')
> it's a bit ugly to redifine the same constant here and in vdsm-restore-net-
Done. This is the place. I import NETS_RESTORED_MARK from here.
Line 37: 
Line 38: 
Line 39: def init_nets():
Line 40: _initialize_logging()


PS15, Line 63: set_ovs_links_up(
> I worry about what happens if the ovs db is somehow out of sync with our un
Done, take a look at the draft and let me know what do you think.


Line 84: 
Line 85: def _initialize_logging():
Line 86: threading.current_thread().setName('restore-nets-init')
Line 87: try:
Line 88: logging.config.fileConfig('/etc/vdsm/svdsm.logger.conf',
> this vdsm/vdsm-restore-net-config code begs to be factored out
Done, this is not needed. When error is logged, it will be written in journal. 
If we need to, we can set INFO logging via rsyslog.
Line 89:   disable_existing_loggers=False)
Line 90: except:
Line 91: logging.basicConfig(filename='/dev/stdout', filemode='w+',
Line 92: level=logging.DEBUG)


-- 
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: filter out Xen VMs with block storage

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62368/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: v2v: filter out Xen VMs with block storage
Line 8: 
Line 9: virt-v2v is not support importing Xen VMs with block storage domain.
Line 10: No need to return these VMs via get_external_vms verb
> Shouldn't we rather behave like with snapsnots and running VMs and leave th
There is no filter in the engine for snapshots... (there is an RFE but solution 
not dissected yet).
In this case its limited that will never be solved (block for Xen on Rhel 5.x) 
so I think filtering in vdsm is ok.
Line 11: 
Line 12: Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Line 13: Bug-Url: https://bugzilla.redhat.com/1365411


-- 
To view, visit https://gerrit.ovirt.org/62368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62560/2/automation/build-artifacts-manual.sh
File automation/build-artifacts-manual.sh:

PS2, Line 12: # autogen may already have been executed by check-patch.sh
: if [ ! -f Makefile ]; then
:   ./autogen.sh --system --enable-hooks --enable-vhostmd
: fi
do we ever need this in this script?


-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62383/5/vdsm_hooks/vhostmd/after_vm_destroy.py
File vdsm_hooks/vhostmd/after_vm_destroy.py:

PS5, Line 33: items
> In my opinion we should keep the original key because it could introduce in
OK, I will work on a fix


-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..


Patch Set 5:

Arsène Gschwind  may be willing to verify this patch

-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/62628/3/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 58: requestQueue = requestQueues.split(",")[0]
Line 59: return jsonrpcvdscli.connect(requestQueue=requestQueue)
Line 60: 
Line 61: config = _importVdsmPylibModule("vdsm.config").config
Line 62: dump_volume_chains = 
_importVdsmPylibModule("vdsm.tool.dump_volume_chains")
do we still need this?
Line 63: jsonrpcvdscli = _importVdsmPylibModule("vdsm.jsonrpcvdscli")
Line 64: 
Line 65: 
Line 66: class vdsm(Plugin, RedHatPlugin):


Line 149: for pool in pools_list:
Line 150: self.addObjectAsFile(
Line 151: cli.getSpmStatus(pool), "getSpmStatus " + 
pool)
Line 152: 
Line 153: sd_uuid, = cli.getStorageDomainsList()["items"]
I think this would explode if you have multiple storage domains in the 
datacenter
Line 154: 
Line 155: self.collectExtOutput("vdsm-tool dump-volume-chains %s" % 
sd_uuid)
Line 156: 
Line 157: def _addVdsmRunDir(self):


-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Add PipelineProc, pipeline wrapper object

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: Add PipelineProc, pipeline wrapper object
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62094
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c3741ae7ef9731a2cd9d587e86766b9e6e64f62
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Advertise aggregator ID in bonding interfaces

[danken]

Dan Kenigsberg has abandoned this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Abandoned

I'm afraid this would be available only on 4.0

-- 
To view, visit https://gerrit.ovirt.org/54588
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Advertise aggregator ID in bonding interfaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Advertise aggregator ID in bonding interfaces
..


Patch Set 2:

* #1281666::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/54588
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: hooks:checkips: add checkips hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
..


Patch Set 1:

* update_tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Artyom Lukianov 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: hooks:checkips: add checkips hook

[danken]

Dan Kenigsberg has abandoned this change.

Change subject: hooks:checkips: add checkips hook
..


Abandoned

I'm afraid this would be available only in 4.0.

-- 
To view, visit https://gerrit.ovirt.org/56251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Artyom Lukianov 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: jsonrpc: add example script to run a VM

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: contrib: jsonrpc: add example script to run a VM
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc8ec3a6ea795659834392f94e7649218ac3fda8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: after_vm_start: migrate to jsonrpcvdsli

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: after_vm_start: migrate to jsonrpcvdsli
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66bd62164594c83167e8e72081325ff60d1c0cb0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add default value to request queue argument

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: add default value to request queue argument
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I226e7a66a06ac6d7ce57f1b2733609b0fd7a4d67
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add default value to request queue argument

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpcvdscli: add default value to request queue argument
..


jsonrpcvdscli: add default value to request queue argument

requestQueue argument of jsonrpcvdscli.connect function should
have default value based on vdsm configuration parameters.

Change-Id: I226e7a66a06ac6d7ce57f1b2733609b0fd7a4d67
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/62730
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/62730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I226e7a66a06ac6d7ce57f1b2733609b0fd7a4d67
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Add PipelineProc, pipeline wrapper object

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: Add PipelineProc, pipeline wrapper object
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62094
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c3741ae7ef9731a2cd9d587e86766b9e6e64f62
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[automation]

gerrit-hooks has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 11:

* #1365007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365007::OK, public bug
* Check Product::#1365007::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62383/5/vdsm_hooks/vhostmd/after_vm_destroy.py
File vdsm_hooks/vhostmd/after_vm_destroy.py:

PS5, Line 33: items
> actually when checking it I saw that items is returned:
In my opinion we should keep the original key because it could introduce 
inconsistency across the clients.


-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62383/5/vdsm_hooks/vhostmd/after_vm_destroy.py
File vdsm_hooks/vhostmd/after_vm_destroy.py:

PS5, Line 33: items
> Here is part of definition of this verb in Bridge.py:
actually when checking it I saw that items is returned:
In [6]: server.fullList()
Out[6]: 
{'items': [{'acpiEnable': 'true',
   'afterMigrationStatus': u'',
   'bootMenuEnable': 'false',
   'clientIp': u'',
   'cpuType': 'Penryn',



if you check jsonrpcvdscli.py code you can see that when you return list, its 
name always gets overridden by 'items' when calling 
response.success(items=resp.result)

do we want to change this behavior?


-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/62383/5/vdsm_hooks/vhostmd/after_vm_destroy.py
File vdsm_hooks/vhostmd/after_vm_destroy.py:

PS5, Line 33: items
Here is part of definition of this verb in Bridge.py:

'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},

This means that we should keep 'vmList' here.


-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add default value to request queue argument

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add default value to request queue argument
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I226e7a66a06ac6d7ce57f1b2733609b0fd7a4d67
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: acquire ifaces

[edwardh]

Edward Haas has posted comments on this change.

Change subject: ovs: acquire ifaces
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61956
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: support configuring nameservers by ovs

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: support configuring nameservers by ovs
..


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/62706/3/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

PS3, Line 243: ipv4.defaultRoute and
redundant: canonicalize takes care of this.


PS3, Line 244: resolv.update(attrs['nameservers'])
> this will overwrite original resolv.conf. if it was configured by system (o
How is that different from setting the default route or changing the management 
network IP?

However, we should make sure that in case of a transaction failure, the 
original values are restored.
(we have the original values in the caps and running conf, so this should be 
pretty simple to do).


-- 
To view, visit https://gerrit.ovirt.org/62706
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe4f82fe88e24b43e5f40e96ae4292ebf933a8e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: add a resolv.conf writer

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: add a resolv.conf writer
..


Patch Set 3:

Correcting my last comment: Functional tests will appear in the next patch as 
part of OVS + dns setup.

-- 
To view, visit https://gerrit.ovirt.org/62705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41b81b04fbe3e3e2398f28cb16fb0dbbc0382249
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: add a resolv.conf writer

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: add a resolv.conf writer
..


Patch Set 3: Code-Review-1

(1 comment)

We are also missing functional tests for this, please add them.

https://gerrit.ovirt.org/#/c/62705/3/tests/network/resolv_test.py
File tests/network/resolv_test.py:

PS3, Line 56: test_update
Please describe what is being tested: Replacing existing, appending new ones, 
removing?

What happens when adding only one entry?
What happens when we try to add too many entries?


-- 
To view, visit https://gerrit.ovirt.org/62705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41b81b04fbe3e3e2398f28cb16fb0dbbc0382249
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org