Change in vdsm[master]: net: dhclient command - iface name should appear at the tail

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient command - iface name should appear at the tail
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding bond api with sysfs driver under link

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding bond api with sysfs driver under link
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net func tests: Cleanup ifcfg files after each func test.
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Expose disable IPv6 through ip.address module
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Set dummy ifaces up by default.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Set dummy ifaces up by default.
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient command - iface name should appear at the tail

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient command - iface name should appear at the tail
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Expose disable IPv6 through ip.address module
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding bond api with sysfs driver under link

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding bond api with sysfs driver under link
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net func tests: Cleanup ifcfg files after each func test.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Set dummy ifaces up by default.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Set dummy ifaces up by default.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding bond api with sysfs driver under link

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Adding bond api with sysfs driver under link
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/62828/1/lib/vdsm/network/link/bond.py
File lib/vdsm/network/link/bond.py:

PS1, Line 37: is_bond
> exists?
Done


Line 53: def del_slaves(self, slaves):
Line 54: pass
Line 55: 
Line 56: @abc.abstractmethod
Line 57: def set_options(self, options):
> comment if 'options' will be the result state or combination of the current
I think we should go for the result state, this is how a request will arrive 
and it is simple to understand.
I will add a comment.
Line 58: pass
Line 59: 
Line 60: @abc.abstractmethod
Line 61: def is_bond(self):


PS1, Line 119: self._slaves |= set(slaves)
> this should take place after the system changes (or every single change) in
Done


Line 137: 
Line 138: def is_bond(self):
Line 139: return os.path.exists(self.BONDING_PATH % self._master)
Line 140: 
Line 141: def active_slave(self):
> can be active_slave None? in case both of them are down.
I'm not sure I understand what you are asking.
Line 142: with open(self.BONDING_ACTIVE_SLAVE % self._master) as f:
Line 143: return f.readline().rstrip()
Line 144: 
Line 145: def _import_existing(self):


-- 
To view, visit https://gerrit.ovirt.org/62828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/62827/1/lib/vdsm/network/link/iface.py
File lib/vdsm/network/link/iface.py:

Line 49: 
Line 50: 
Line 51: @contextmanager
Line 52: def _up_blocking(dev):
Line 53: with Monitor(groups=('link',), timeout=2) as mon:
> we should use silent_timeout=True
Done
Line 54: ipwrapper.linkSet(dev, [STATE_UP])
Line 55: if is_up(dev):
Line 56: return
Line 57: mon_device = (e for e in mon if e.get('name') == dev)


PS1, Line 61: # With some devices (seen on dummy), the state event 
arrives
: # as 'unknown', therefore we are forced to check 
again explicitly.
> i see now, is_up does not check IFF_UP but IF_RUNNING, ok. don't mind me.
We do not need it anymore, we check the flags directly.


-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: implementing StorageDomain.reduce

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing StorageDomain.reduce
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62854
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b729edc5a43e0d884e5bd0ad671679c39b5a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.reduce API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.reduce API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: implementing StorageDomain.movePV

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing StorageDomain.movePV
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Expose disable IPv6 through ip.address module
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding bond api with sysfs driver under link

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding bond api with sysfs driver under link
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 3: Code-Review-1

What about silent_timeout?

-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient command - iface name should appear at the tail

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient command - iface name should appear at the tail
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net func tests: Cleanup ifcfg files after each func test.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Set dummy ifaces up by default.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Set dummy ifaces up by default.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: migration: rename classes

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: migration: rename classes
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/62588/3//COMMIT_MSG
Commit Message:

PS3, Line 10: their
: interface can and should be different from threading.Thread
Is there any suggestion to how the interface should look like then? At the 
moment, and I may be missing wider context, this change is just for the sake of 
changing something.


-- 
To view, visit https://gerrit.ovirt.org/62588
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4335158e3666cb8fbb8a74175cb4e1fb8de13d2c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/62560/3/automation/build-artifacts-manual.sh
File automation/build-artifacts-manual.sh:

Line 14: # create the src.rpm, assuming the tarball is in the directory
Line 15: rpmbuild \
Line 16: -D "_srcrpmdir $OUTPUT" \
Line 17: -D "_topmdir $BUILDS" \
Line 18: -ts ./*.gz
> If I understand correctly, using make rpm will also create the tarball. Ple
make srpm ?
Line 19: 
Line 20: # install any build requirements
Line 21: yum-builddep output/*src.rpm
Line 22: 


-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net func tests: Cleanup ifcfg files after each func test.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient command - iface name should appear at the tail

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient command - iface name should appear at the tail
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Expose disable IPv6 through ip.address module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding bond api with sysfs driver under link

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding bond api with sysfs driver under link
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62827/1/lib/vdsm/network/link/iface.py
File lib/vdsm/network/link/iface.py:

Line 47: def is_promisc(dev):
Line 48: return bool(link.get_link(dev)['flags'] & IFF_PROMISC)
Line 49: 
Line 50: 
Line 51: @contextmanager
> why is this contextmanager? there is no yield in it.
Done
Line 52: def _up_blocking(dev):
Line 53: with Monitor(groups=('link',), timeout=2) as mon:
Line 54: ipwrapper.linkSet(dev, [STATE_UP])
Line 55: if is_up(dev):


-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Set dummy ifaces up by default.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Set dummy ifaces up by default.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net func tests: Cleanup ifcfg files after each func test.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 1: Code-Review+1

(2 comments)

just a nit and question

https://gerrit.ovirt.org/#/c/62831/1/lib/vdsm/network/link/setup.py
File lib/vdsm/network/link/setup.py:

Line 25: 
Line 26: from .bond import Bond
Line 27: 
Line 28: 
Line 29: class SetupBonds(object):
will there be a Transaction?
Line 30: def __init__(self, bonds2add, bonds2edit, bonds2remove):
Line 31: self._bonds2add = bonds2add
Line 32: self._bonds2edit = bonds2edit
Line 33: self._bonds2remove = bonds2remove


PS1, Line 44: set
frozenset?


-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62827/1/lib/vdsm/network/link/iface.py
File lib/vdsm/network/link/iface.py:

PS1, Line 61: # With some devices (seen on dummy), the state event 
arrives
: # as 'unknown', therefore we are forced to check 
again explicitly.
> i'm worried some ifaces (also OVS ones) are still in UNKNOWN state (at leas
i see now, is_up does not check IFF_UP but IF_RUNNING, ok. don't mind me.


-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62773/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 321: 
Line 322: rc, out, err = commands.execCmd([_restoreconCommandPath.cmd,
Line 323: '-Rv', mountPoint])
Line 324: if rc:
Line 325: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, rc, 
out, err)
> Good point. Is there way to tell the user that selinux labels where not set
It will be anyway handled by the engine via exception handling. There will be 
specific error shown saying failed to set selinux labels on the brick. So I 
hope its ok.

Note: I moved this as the last step in latest patch set. Also it should be 
executed only when selinux is enabled(either enforcing or permissive).
Line 326: 
Line 327: # bz#1230495: lvm devices are invisible and appears only after 
vgscan
Line 328: # Workaround: Till the bz gets fixed, We use vgscan to refresh 
LVM devices
Line 329: rc, out, err = commands.execCmd([_vgscanCommandPath.cmd])


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 4:

* #1368474::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1368474::OK, public bug
* Check Product::#1368474::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Expose disable IPv6 through ip.address module
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient command - iface name should appear at the tail

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: dhclient command - iface name should appear at the tail
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 3:

* #1368474::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1368474::OK, public bug
* Check Product::#1368474::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding bond api with sysfs driver under link

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Adding bond api with sysfs driver under link
..


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/62828/1/lib/vdsm/network/link/bond.py
File lib/vdsm/network/link/bond.py:

PS1, Line 37: is_bond
exists?


Line 53: def del_slaves(self, slaves):
Line 54: pass
Line 55: 
Line 56: @abc.abstractmethod
Line 57: def set_options(self, options):
comment if 'options' will be the result state or combination of the current 
state and requested (dictionary set or update). if the latter i would go for 
**kwargs to emphasize that we are setting single options not all of them.
Line 58: pass
Line 59: 
Line 60: @abc.abstractmethod
Line 61: def is_bond(self):


PS1, Line 119: self._slaves |= set(slaves)
this should take place after the system changes (or every single change) in 
case system changes fail. same for other methods.


Line 137: 
Line 138: def is_bond(self):
Line 139: return os.path.exists(self.BONDING_PATH % self._master)
Line 140: 
Line 141: def active_slave(self):
can be active_slave None? in case both of them are down.
Line 142: with open(self.BONDING_ACTIVE_SLAVE % self._master) as f:
Line 143: return f.readline().rstrip()
Line 144: 
Line 145: def _import_existing(self):


-- 
To view, visit https://gerrit.ovirt.org/62828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/62827/1/lib/vdsm/network/link/iface.py
File lib/vdsm/network/link/iface.py:

Line 47: def is_promisc(dev):
Line 48: return bool(link.get_link(dev)['flags'] & IFF_PROMISC)
Line 49: 
Line 50: 
Line 51: @contextmanager
why is this contextmanager? there is no yield in it.
Line 52: def _up_blocking(dev):
Line 53: with Monitor(groups=('link',), timeout=2) as mon:
Line 54: ipwrapper.linkSet(dev, [STATE_UP])
Line 55: if is_up(dev):


Line 49: 
Line 50: 
Line 51: @contextmanager
Line 52: def _up_blocking(dev):
Line 53: with Monitor(groups=('link',), timeout=2) as mon:
we should use silent_timeout=True
Line 54: ipwrapper.linkSet(dev, [STATE_UP])
Line 55: if is_up(dev):
Line 56: return
Line 57: mon_device = (e for e in mon if e.get('name') == dev)


PS1, Line 61: # With some devices (seen on dummy), the state event 
arrives
: # as 'unknown', therefore we are forced to check 
again explicitly.
i'm worried some ifaces (also OVS ones) are still in UNKNOWN state (at least in 
ip link output).


-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Revert "configurator: libvirt: do not jump on virtlogd"

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..


Patch Set 1:

* #1370103::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1370103::OK, public bug
* Check Product::#1370103::OK, Correct classification oVirt
* Check TM::#1370103::OK, correct target milestone ovirt-4.0.4
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/62838
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d5ec539ce4d9ffbb92a357cf59104f073b372ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Revert "configurator: libvirt: do not jump on virtlogd"

[fromani]

Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/62838

to review the following change.

Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..

Revert "configurator: libvirt: do not jump on virtlogd"

This reverts commit 0d9be09351814571655fab23bbfa21733916e36d.
The feature looks good for us now.

Change-Id: I9d5ec539ce4d9ffbb92a357cf59104f073b372ef
Bug-Url: https://bugzilla.redhat.com/1370103
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/61481
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/62838/1

diff --git a/lib/vdsm/tool/configurators/libvirt.py 
b/lib/vdsm/tool/configurators/libvirt.py
index 4b9aee2..cb0f970 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -285,7 +285,6 @@
 'remote_display_port_min': 5900,
 'remote_display_port_max': 6923,
 'auto_dump_path': '"/var/log/core"',
-'stdio_handler': '"file"',
 },
 
 },


-- 
To view, visit https://gerrit.ovirt.org/62838
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d5ec539ce4d9ffbb92a357cf59104f073b372ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

[automation]

gerrit-hooks has posted comments on this change.

Change subject: core: Use constant instead of text
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

[ahino]

Ala Hino has abandoned this change.

Change subject: core: Use constant instead of text
..


Abandoned

squashed to https://gerrit.ovirt.org/60889

-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

[ahino]

Ala Hino has posted comments on this change.

Change subject: core: Use constant instead of text
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62366/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS1, Line 4752: vol_format = sc.name2type(baseInfo['format'])
> If baseInfo['format'] is a string (like COW or RAW) then just compare again
Done


-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Restore watermark tracking

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Restore watermark tracking
..


Patch Set 15:

* #1168327::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1168327::OK, public bug
* Check Product::#1168327::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Restore watermark tracking

[ahino]

Ala Hino has posted comments on this change.

Change subject: Live Merge: Restore watermark tracking
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/60889/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS14, Line 1007: path
> Maybe change to '.path' to be safer?
Done


-- 
To view, visit https://gerrit.ovirt.org/60889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: filter out Xen VMs with block storage

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net func tests: Cleanup ifcfg files after each func test.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: Set dummy ifaces up by default.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Set dummy ifaces up by default.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding bond api with sysfs driver under link

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding bond api with sysfs driver under link
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Expose disable IPv6 through ip.address module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient command - iface name should appear at the tail

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient command - iface name should appear at the tail
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: ifcfg - dhclient should always be stopped
..

net: ifcfg - dhclient should always be stopped

While running functional tests, it has been observed that dhclients are
still running on slave ifaces.

This patch is stopping any running dhclient per the configured iface.

Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/62832/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index 111e194..64fe623 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -532,11 +532,12 @@
 cfg += 'BOOTPROTO=none\n'
 elif ipv4.bootproto:
 cfg += 'BOOTPROTO=%s\n' % pipes.quote(ipv4.bootproto)
-if (ipv4.bootproto == 'dhcp' and
-os.path.exists(os.path.join(NET_PATH, name))):
-# Ask dhclient to stop any dhclient running for the device
-dhclient.kill(name)
-address.flush(name, family=4)
+
+if os.path.exists(os.path.join(NET_PATH, name)):
+# Ask dhclient to stop any dhclient running for the device
+dhclient.kill(name)
+address.flush(name, family=4)
+
 if mtu:
 cfg += 'MTU=%d\n' % mtu
 if ipv4.defaultRoute is not None:


-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net func tests: Cleanup ifcfg files after each func test.
..

net func tests: Cleanup ifcfg files after each func test.

Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367
Signed-off-by: Edward Haas 
---
M tests/network/netfunctestlib.py
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/62833/1

diff --git a/tests/network/netfunctestlib.py b/tests/network/netfunctestlib.py
index 7b59fa8..ea8aa4a 100644
--- a/tests/network/netfunctestlib.py
+++ b/tests/network/netfunctestlib.py
@@ -26,6 +26,7 @@
 
 from nose.plugins.skip import SkipTest
 
+from vdsm import utils
 import vdsm.config
 from vdsm.network import kernelconfig
 from vdsm.network.ip import dhclient
@@ -51,6 +52,9 @@
 vdsm.config.config.get('vars', 'net_persistence') == 'unified')
 
 NOCHK = {'connectivityCheck': False}
+
+IFCFG_DIR = '/etc/sysconfig/network-scripts/'
+IFCFG_PREFIX = IFCFG_DIR + 'ifcfg-'
 
 
 def requires_ipaddress():
@@ -408,6 +412,15 @@
 BONDSETUP = {bond: {'remove': True}
  for bond in self.setup_bonds if bond in bonds_caps}
 status, msg = self.vdsm_proxy.setupNetworks(NETSETUP, BONDSETUP, NOCHK)
+
+nics_used = [attr['nic']
+ for attr in six.itervalues(self.setup_networks)
+ if 'nic' in attr]
+for attr in six.itervalues(self.setup_bonds):
+nics_used += attr['nics']
+for nic in nics_used:
+utils.rmFile(IFCFG_PREFIX + nic)
+
 return status, msg
 
 


-- 
To view, visit https://gerrit.ovirt.org/62833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient command - iface name should appear at the tail

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: dhclient command - iface name should appear at the tail
..

net: dhclient command - iface name should appear at the tail

dhclient lookup is expecting the iface on which the dhclient runs
to appear at the end of the command.
When running dhclient directly (not through ifcfg), this is not the
case.

This patch places the iface at the tail of the command.

Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/ip/dhclient.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/62829/1

diff --git a/lib/vdsm/network/ip/dhclient.py b/lib/vdsm/network/ip/dhclient.py
index d69e70b..3fc5b33 100644
--- a/lib/vdsm/network/ip/dhclient.py
+++ b/lib/vdsm/network/ip/dhclient.py
@@ -60,12 +60,13 @@
 if os.path.exists(os.path.join(NET_PATH, self.iface)):
 kill(self.iface, self.family)
 cmd = [DHCLIENT_BINARY.cmd, '-%s' % self.family, '-1', '-pf',
-   self.pidFile, '-lf', self.leaseFile, self.iface]
+   self.pidFile, '-lf', self.leaseFile]
 if not self.default_route:
 # Instruct Fedora/EL's dhclient-script not to set gateway on iface
 cmd += ['-e', 'DEFROUTE=no']
 if self.duid_source_file and supports_duid_file():
 cmd += ['-df', self.duid_source_file]
+cmd += [self.iface]
 cmd = cmdutils.systemd_run(cmd, scope=True, slice=self._cgroup)
 return execCmd(cmd)
 


-- 
To view, visit https://gerrit.ovirt.org/62829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Expose disable IPv6 through ip.address module
..

net: Expose disable IPv6 through ip.address module

Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/ip/address.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/62830/1

diff --git a/lib/vdsm/network/ip/address.py b/lib/vdsm/network/ip/address.py
index 0842eb4..634925a 100644
--- a/lib/vdsm/network/ip/address.py
+++ b/lib/vdsm/network/ip/address.py
@@ -166,6 +166,11 @@
 sysctl.disable_ipv6_local_auto(dev)
 
 
+def disable_ipv6(iface):
+if ipv6_supported():
+sysctl.disable_ipv6(iface)
+
+
 def add(iface, ipv4, ipv6):
 if ipv4.address:
 ipwrapper.addrAdd(iface, ipv4.address, ipv4.netmask)


-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Link setup module - includes bond setup logic.
..

net: Link setup module - includes bond setup logic.

Introducing the bond setup module.
It includes the setup logic for Bond devices, translating the setup
request to the actions needed to apply them.

It uses the bond interface for applying the setup.

Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Signed-off-by: Edward Haas 
---
A lib/vdsm/network/link/setup.py
1 file changed, 88 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/62831/1

diff --git a/lib/vdsm/network/link/setup.py b/lib/vdsm/network/link/setup.py
new file mode 100644
index 000..9579a0a
--- /dev/null
+++ b/lib/vdsm/network/link/setup.py
@@ -0,0 +1,88 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+import six
+
+from vdsm.network.ip import address
+from vdsm.network.ip import dhclient
+
+from .bond import Bond
+
+
+class SetupBonds(object):
+def __init__(self, bonds2add, bonds2edit, bonds2remove):
+self._bonds2add = bonds2add
+self._bonds2edit = bonds2edit
+self._bonds2remove = bonds2remove
+self._acquired_ifaces = set()
+
+def remove_bonds(self):
+for bond_name in self._bonds2remove:
+Bond(bond_name).destroy()
+
+def edit_bonds(self):
+for bond_name, attrs in six.iteritems(self._bonds2edit):
+bond = Bond(bond_name)
+
+requested_slaves = set(attrs['nics'])
+running_slaves = bond.slaves
+slaves2remove = running_slaves - requested_slaves
+
+bond.del_slaves(slaves2remove)
+
+for bond_name, attrs in six.iteritems(self._bonds2edit):
+bond = Bond(bond_name)
+
+requested_slaves = set(attrs['nics'])
+running_slaves = bond.slaves
+slaves2add = requested_slaves - running_slaves
+
+bond.add_slaves(slaves2add)
+_ip_flush(slaves2add)
+
+# TODO: Options
+# attrs.get('options', '')
+
+self._acquired_ifaces |= requested_slaves | {bond_name}
+
+def add_bonds(self):
+for bond_name, attrs in six.iteritems(self._bonds2add):
+requested_slaves = set(attrs['nics'])
+bond = Bond(bond_name, slaves=requested_slaves)
+bond.create()
+
+_ip_flush(requested_slaves)
+
+# TODO: Options
+# attrs.get('options', '')
+
+self._acquired_ifaces |= requested_slaves | {bond_name}
+
+@property
+def acquired_ifaces(self):
+return self._acquired_ifaces
+
+
+def _ip_flush(ifaces):
+# TODO: Tell NetworkManager to unmanage this iface.
+for iface in ifaces:
+dhclient.kill(iface, family=4)
+dhclient.kill(iface, family=6)
+address.flush(iface)


-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding bond api with sysfs driver under link

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Adding bond api with sysfs driver under link
..

net: Adding bond api with sysfs driver under link

Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Signed-off-by: Edward Haas 
---
A lib/vdsm/network/link/bond.py
A tests/network/link_bond_test.py
2 files changed, 236 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/62828/1

diff --git a/lib/vdsm/network/link/bond.py b/lib/vdsm/network/link/bond.py
new file mode 100644
index 000..11498f8
--- /dev/null
+++ b/lib/vdsm/network/link/bond.py
@@ -0,0 +1,160 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+import abc
+import os
+import six
+
+from . import iface
+
+
+@six.add_metaclass(abc.ABCMeta)
+class BondAPI(object):
+"""
+Bond driver interface.
+"""
+def __init__(self, name, slaves=(), options=None):
+self._master = name
+self._slaves = set(slaves)
+self._options = options
+if self.is_bond():
+self._import_existing()
+
+@abc.abstractmethod
+def create(self):
+pass
+
+@abc.abstractmethod
+def destroy(self):
+pass
+
+@abc.abstractmethod
+def add_slaves(self, slaves):
+pass
+
+@abc.abstractmethod
+def del_slaves(self, slaves):
+pass
+
+@abc.abstractmethod
+def set_options(self, options):
+pass
+
+@abc.abstractmethod
+def is_bond(self):
+pass
+
+@abc.abstractmethod
+def active_slave(self):
+pass
+
+@property
+def master(self):
+return self._master
+
+@property
+def slaves(self):
+return self._slaves
+
+@property
+def options(self):
+return self._options
+
+def up(self):
+self._setlinks(up=True)
+
+def down(self):
+self._setlinks(up=False)
+
+@abc.abstractmethod
+def _import_existing(self):
+pass
+
+def _setlinks(self, up):
+setstate = iface.up if up else iface.down
+setstate(self._master)
+for slave in self._slaves:
+setstate(slave)
+
+
+class BondSysFS(BondAPI):
+
+BONDING_MASTERS = '/sys/class/net/bonding_masters'
+BONDING_PATH = '/sys/class/net/%s/bonding'
+BONDING_SLAVES = BONDING_PATH + '/slaves'
+BONDING_ACTIVE_SLAVE = BONDING_PATH + '/active_slave'
+BONDING_OPT = BONDING_PATH + '/%s'
+
+def __init__(self, name, slaves=(), options=None):
+super(BondSysFS, self).__init__(name, slaves, options)
+
+def create(self):
+with open(self.BONDING_MASTERS, 'w') as f:
+f.write('+%s' % self._master)
+if self._slaves:
+self.add_slaves(self._slaves)
+
+def destroy(self):
+with open(self.BONDING_MASTERS, 'w') as f:
+f.write('-%s' % self._master)
+
+def add_slaves(self, slaves):
+self._slaves |= set(slaves)
+for slave in slaves:
+iface.down(slave)
+with open(self.BONDING_SLAVES % self._master, 'w') as f:
+f.write('+%s' % slave)
+
+def del_slaves(self, slaves):
+self._slaves -= set(slaves)
+for slave in slaves:
+iface.down(slave)
+with open(self.BONDING_SLAVES % self._master, 'w') as f:
+f.write('-%s' % slave)
+
+def set_options(self, options):
+self._options.update(options)
+for key, value in options:
+with open(self.BONDING_OPT % (self._master, key), 'w') as f:
+f.write(value)
+
+def is_bond(self):
+return os.path.exists(self.BONDING_PATH % self._master)
+
+def active_slave(self):
+with open(self.BONDING_ACTIVE_SLAVE % self._master) as f:
+return f.readline().rstrip()
+
+def _import_existing(self):
+with open(self.BONDING_SLAVES % self._master) as f:
+self._slaves = set(f.readline().split())
+# TODO: Support options
+self._options = None
+
+
+# TODO: Use a configuration parameter to determine which driver to use.
+def 

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Adding the 'link' package with an iface module
..

net: Adding the 'link' package with an iface module

The link package is to be used for all iface, bond and other related actions.
Its main purpose is to provide an api to access these devices and their
attributes.

The plan is to add drivers for the underlying devices access.

This patch adds the first link module: iface, which present an api to
iface related actions (link up, link down, etc)

Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Signed-off-by: Edward Haas 
---
M configure.ac
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/link/Makefile.am
A lib/vdsm/network/link/__init__.py
A lib/vdsm/network/link/iface.py
M lib/vdsm/network/netswitch.py
A tests/network/link_iface_test.py
M vdsm.spec.in
8 files changed, 158 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/62827/1

diff --git a/configure.ac b/configure.ac
index 02770fa..5756499 100644
--- a/configure.ac
+++ b/configure.ac
@@ -397,6 +397,7 @@
lib/vdsm/network/Makefile
lib/vdsm/network/configurators/Makefile
lib/vdsm/network/ip/Makefile
+   lib/vdsm/network/link/Makefile
lib/vdsm/network/netinfo/Makefile
lib/vdsm/network/netlink/Makefile
lib/vdsm/network/ovs/Makefile
diff --git a/lib/vdsm/network/Makefile.am b/lib/vdsm/network/Makefile.am
index 403ffd2..0fc9d85 100644
--- a/lib/vdsm/network/Makefile.am
+++ b/lib/vdsm/network/Makefile.am
@@ -17,7 +17,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
-SUBDIRS = configurators ip netinfo netlink ovs tc
+SUBDIRS = configurators ip link netinfo netlink ovs tc
 
 include $(top_srcdir)/build-aux/Makefile.subs
 
diff --git a/lib/vdsm/network/link/Makefile.am 
b/lib/vdsm/network/link/Makefile.am
new file mode 100644
index 000..64823ac
--- /dev/null
+++ b/lib/vdsm/network/link/Makefile.am
@@ -0,0 +1,22 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+include $(top_srcdir)/build-aux/Makefile.subs
+
+vdsmnetworklinkdir = $(vdsmpylibdir)/network/link
+dist_vdsmnetworklink_PYTHON = *.py
diff --git a/lib/vdsm/network/link/__init__.py 
b/lib/vdsm/network/link/__init__.py
new file mode 100644
index 000..4a67f47
--- /dev/null
+++ b/lib/vdsm/network/link/__init__.py
@@ -0,0 +1,19 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
diff --git a/lib/vdsm/network/link/iface.py b/lib/vdsm/network/link/iface.py
new file mode 100644
index 000..ee49cfe
--- /dev/null
+++ b/lib/vdsm/network/link/iface.py
@@ -0,0 +1,64 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, 

Change in vdsm[master]: net tests: Set dummy ifaces up by default.

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net tests: Set dummy ifaces up by default.
..

net tests: Set dummy ifaces up by default.

Dummy interfaces should be up when created, removing the need from the
individual tests to raise them.
This change showed several problems with existing tests, which have been
resolved as part of this patch.

Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914
Signed-off-by: Edward Haas 
---
M tests/network/netinfo_test.py
M tests/network/nettestlib.py
M tests/network/ovs_info_test.py
3 files changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/62834/1

diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py
index f0c3a6f..b0b9641 100644
--- a/tests/network/netinfo_test.py
+++ b/tests/network/netinfo_test.py
@@ -400,9 +400,7 @@
 ipwrapper.addrAdd(dev, '2001::88', '64', family=6)
 ip_addrs = addresses.getIpAddrs()[dev]
 self.assertEqual(True, addresses.is_ipv6_local_auto(dev))
-self.assertEqual(
-1, len(ip_addrs),
-'too many addresses %s' % (ip_addrs, ))
+self.assertEqual(2, len(ip_addrs))
 self.assertTrue(addresses.is_ipv6(ip_addrs[0]))
 self.assertTrue(not addresses.is_dynamic(ip_addrs[0]))
 
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index 3069f92..f762125 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -38,6 +38,7 @@
 from vdsm.network.ipwrapper import (
 addrAdd, linkSet, linkAdd, linkDel, IPRoute2Error, netns_add, netns_delete,
 netns_exec)
+from vdsm.network.link import iface as linkiface
 from vdsm.network.netlink import monitor
 from vdsm.commands import execCmd
 from vdsm.utils import CommandPath, random_iface_name
@@ -312,6 +313,7 @@
 dummy_interface = Dummy(prefix, max_length)
 dummy_name = dummy_interface.create()
 try:
+linkiface.up(dummy_name)
 yield dummy_name
 finally:
 dummy_interface.remove()
diff --git a/tests/network/ovs_info_test.py b/tests/network/ovs_info_test.py
index a74f58b..16ec00e 100644
--- a/tests/network/ovs_info_test.py
+++ b/tests/network/ovs_info_test.py
@@ -102,7 +102,6 @@
 'ports': {
 TEST_BOND: {
 'bond': {
-'active_slave': None,
 'fake_iface': False,
 'lacp': None,
 'bond_mode': 'active-backup',
@@ -131,6 +130,9 @@
 ovs_info = info.OvsInfo()
 
 obtained_bridges = ovs_info.bridges
+# Normalize obtained_bridges (remove 'active_slave')
+obtained_bridges[TEST_BRIDGE]['ports'][TEST_BOND]['bond'].pop(
+'active_slave')
 self.assertEqual(obtained_bridges, expected_bridges)
 
 obtained_bridges_by_sb = ovs_info.bridges_by_sb


-- 
To view, visit https://gerrit.ovirt.org/62834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[snaftaly]

Sharon Naftaly has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/62560/3/automation/build-artifacts-manual.sh
File automation/build-artifacts-manual.sh:

Line 14: # create the src.rpm, assuming the tarball is in the directory
Line 15: rpmbuild \
Line 16: -D "_srcrpmdir $OUTPUT" \
Line 17: -D "_topmdir $BUILDS" \
Line 18: -ts ./*.gz
> why don't you use make rpm?
If I understand correctly, using make rpm will also create the tarball. Please 
correct me if I'm wrong.
Line 19: 
Line 20: # install any build requirements
Line 21: yum-builddep output/*src.rpm
Line 22: 


Line 32: find "$PWD" \
Line 33: -maxdepth 1 \
Line 34: -iname vdsm\*.tar.gz \
Line 35: -exec mv {} "$EXPORTS/" \;
Line 36
> how is it different than build-artifacts script?
The idea in this step is to create the rpms from tarball, assuming that the 
tarball is found in the project's topdir. It's meant for developers who wish to 
build from a local tarball. 
There are corresponding jenkins jobs that are supposed to replace the old 
crete-rpms-manual jobs.
I've updted the commit message with the info.


-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62773/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 321: 
Line 322: rc, out, err = commands.execCmd([_restoreconCommandPath.cmd,
Line 323: '-Rv', mountPoint])
Line 324: if rc:
Line 325: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, rc, 
out, err)
> should brick creation fail on failure to set selinux context?
Good point. Is there way to tell the user that selinux labels where not set 
correctly.
Note: at this stage, brick is created and mounted but the /etc/fstab entry and 
selinux labels are missing.
Line 326: 
Line 327: # bz#1230495: lvm devices are invisible and appears only after 
vgscan
Line 328: # Workaround: Till the bz gets fixed, We use vgscan to refresh 
LVM devices
Line 329: rc, out, err = commands.execCmd([_vgscanCommandPath.cmd])


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: filter out Xen VMs with block storage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 2:

* #1365411::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365411::OK, public bug
* Check Product::#1365411::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 4: Code-Review-1

please reply to comments in previous ps

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62560/2/automation/build-artifacts-manual.sh
File automation/build-artifacts-manual.sh:

PS2, Line 12: # autogen may already have been executed by check-patch.sh
: if [ ! -f Makefile ]; then
:   ./autogen.sh --system --enable-hooks --enable-vhostmd
: fi
> do we ever need this in this script?
better to have it. if currently we always run check-patch before we don't need 
it, but we might change the order


-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: filter out Xen VMs with block storage

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62368/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 901: '''
Line 902: Currently we do not support importing VMs with block device from
Line 903: Xen on Rhel 5.x
Line 904: '''
Line 905: if conn.getURI().startswith(_XEN_SSH_PROTOCOL):
> elsewhere below we are using
Done
Line 906: return len(root.findall('.//disk[@type="block"]')) == 0
Line 907: return True
Line 908: 
Line 909: 


-- 
To view, visit https://gerrit.ovirt.org/62368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: implementing StorageDomain.movePV

[automation]

gerrit-hooks has posted comments on this change.

Change subject: implementing StorageDomain.movePV
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62773/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 321: 
Line 322: rc, out, err = commands.execCmd([_restoreconCommandPath.cmd,
Line 323: '-Rv', mountPoint])
Line 324: if rc:
Line 325: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, rc, 
out, err)
should brick creation fail on failure to set selinux context?
Line 326: 
Line 327: # bz#1230495: lvm devices are invisible and appears only after 
vgscan
Line 328: # Workaround: Till the bz gets fixed, We use vgscan to refresh 
LVM devices
Line 329: rc, out, err = commands.execCmd([_vgscanCommandPath.cmd])


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 2:

* #1368474::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1368474::OK, public bug
* Check Product::#1368474::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: filter out Xen VMs with block storage

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 1: Code-Review-1

(1 comment)

Let's just use one way to identify Xen (please see inline comments). Otherwise 
seems fine.

https://gerrit.ovirt.org/#/c/62368/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 901: '''
Line 902: Currently we do not support importing VMs with block device from
Line 903: Xen on Rhel 5.x
Line 904: '''
Line 905: if conn.getURI().startswith(_XEN_SSH_PROTOCOL):
elsewhere below we are using

if conn.getType() == 'Xen':

could we use just one way to detect Xen? I can't tell which way is better, but 
we need to use only one.
Line 906: return len(root.findall('.//disk[@type="block"]')) == 0
Line 907: return True
Line 908: 
Line 909: 


-- 
To view, visit https://gerrit.ovirt.org/62368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 11: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/62324/11/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

PS11, Line 160: items
Please make sure that we do not change the key names. It creates inconsistency 
across the clients.

We need to keep imageslist


PS11, Line 165: items
same here


-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: jsonrpc: add example script to run a VM

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: jsonrpc: add example script to run a VM
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc8ec3a6ea795659834392f94e7649218ac3fda8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: add getVGInfo discard related fields

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: hsm: add getVGInfo discard related fields
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: add getVGInfo discard related fields

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: add getVGInfo discard related fields
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: add getVGInfo discard related fields

[ishaby]

Idan Shaby has uploaded a new change for review.

Change subject: hsm: add getVGInfo discard related fields
..

hsm: add getVGInfo discard related fields

Patch I7ff47 added the fields discard_max_bytes and discard_zeroes_data
to getDeviceList.
This patch adds them also to getVGInfo.

Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Signed-off-by: Idan Shaby 
---
M vdsm/storage/hsm.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/62800/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index d622ffc..0f4932a 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2807,6 +2807,8 @@
 info["vgUUID"] = str(pv.vg_uuid)
 info["pvUUID"] = str(pv.uuid)
 info["GUID"] = str(pv.guid)
+info["discard_max_bytes"] = devInfo["discard_max_bytes"]
+info["discard_zeroes_data"] = devInfo["discard_zeroes_data"]
 return info
 
 @deprecated


-- 
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: add getVGInfo discard related fields

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: add getVGInfo discard related fields
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[ishaby]

Idan Shaby has uploaded a new change for review.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..

multipath: getDeviceDiscardMaxBytes return type

Since /sys/block/dm-X/queue/discard_max_bytes may return more than 4GB,
uint might not be enough.
Thus, this patch chenges getDeviceDiscardMaxBytes to read and return it
as a long value.

Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Signed-off-by: Idan Shaby 
---
M lib/api/vdsm-api.yml
M vdsm/storage/multipath.py
2 files changed, 12 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/62799/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 8ec6f9f..6c0401a 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -221,7 +221,7 @@
 unmapped in a single discard operation. 0 means that the device
 does not support discard functionality.
 name: discard_max_bytes
-type: uint
+type: long
 
 -   description: Indicates whether or not the device deterministically
 returns zeroes when a discarded area is read.
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index 27f720e..6b43bfc 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -168,7 +168,7 @@
 
 def getDeviceDiscardMaxBytes(physDev):
 path = os.path.join(SYS_BLOCK, physDev, QUEUE, "discard_max_bytes")
-return read_int(path)
+return read_long(path)
 
 
 def getDeviceDiscardZeroesData(physDev):
@@ -176,10 +176,17 @@
 return read_int(path)
 
 
-def read_int(path):
+def read_line(path):
 with open(path, "r") as f:
-data = f.readline()
-return int(data)
+return f.readline()
+
+
+def read_int(path):
+return int(read_line(path))
+
+
+def read_long(path):
+return long(read_line(path))
 
 
 def getScsiSerial(physdev):


-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org