Change in vdsm[master]: ceph: Require ceph-common when it is available
Daniel Erez has posted comments on this change. Change subject: ceph: Require ceph-common when it is available .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sagi Shnaidman Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: qemu-kvm-img to handle unaligned images
Daniel Erez has posted comments on this change. Change subject: spec: qemu-kvm-img to handle unaligned images .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/56142/1//COMMIT_MSG Commit Message: Line 15: in EL's qemu-kvm-[rh]ev-2.3.0-31.el7_2.6 (available on RHEL/CentOS Line 16: 7.2.z). Line 17: Line 18: This patch bumps the requirements to make sure we're using a qemu-img Line 19: version which fixes this issue. > We fixed vm metadata files, and they are aligned now. Maybe this is needed Indeed, it could still occur on old VMs, i.e. import/export a VM with memory snapshot created on 3.5 env. Line 20: Line 21: Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6 Line 22: Bug-Url: https://bugzilla.redhat.com/1283278 Line 18: This patch bumps the requirements to make sure we're using a qemu-img Line 19: version which fixes this issue. Line 20: Line 21: Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6 Line 22: Bug-Url: https://bugzilla.redhat.com/1283278 > The bug referenced by Daniel seems unrelated. The qemu-img procces hang has been encountered on bz1282239, see https://bugzilla.redhat.com/show_bug.cgi?id=1282239#c10 -- To view, visit https://gerrit.ovirt.org/56142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: qemu-kvm-img to handle unaligned images
Daniel Erez has posted comments on this change. Change subject: spec: qemu-kvm-img to handle unaligned images .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56142/1//COMMIT_MSG Commit Message: Line 15: in EL's qemu-kvm-[rh]ev-2.3.0-31.el7_2.6 (available on RHEL/CentOS Line 16: 7.2.z). Line 17: Line 18: This patch bumps the requirements to make sure we're using a qemu-img Line 19: version which fixes this issue. > AFAIK, PPC is hit by this. Daniel? IIUC, this patch is for fixing the issue of converting the VM metadata file. See: https://bugzilla.redhat.com/show_bug.cgi?id=1282239#c14 Line 20: Line 21: Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6 Line 22: Bug-Url: https://bugzilla.redhat.com/1283278 -- To view, visit https://gerrit.ovirt.org/56142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move blkid to lib
Daniel Erez has posted comments on this change. Change subject: move blkid to lib .. Patch Set 4: What is it needed for? engine doesn't seem to use it.. -- To view, visit https://gerrit.ovirt.org/53872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92390e82e1bc6b2170c81711ba0e639e3b0a3017 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Use Drive.diskType instead of networkDev and blockDev
Daniel Erez has posted comments on this change. Change subject: virt: Use Drive.diskType instead of networkDev and blockDev .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68bc74b3d788dc82fc61bf8c3de5a52164d0989 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - adding appropriate logs
Daniel Erez has posted comments on this change. Change subject: vm: snapshot - adding appropriate logs .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - adding appropriate logs
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - adding appropriate logs
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50775/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3247: freezed = self.freeze()
Line 3248: try:
Line 3249: self.log.info("Taking a snapshot with drives %s
(memory=%s).",
Line 3250: ', '.join(map(lambda d: d[1]['name'],
Line 3251: newDrives.iteritems())),
> For consistency, lets use:
Done
Line 3252: memoryParams is not None)
Line 3253: self._dom.snapshotCreateXML(snapxml, snapFlags)
Line 3254: self.log.info("Completed live snapshot.")
Line 3255: except libvirt.libvirtError:
--
To view, visit https://gerrit.ovirt.org/50775
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - adding appropriate logs
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - adding appropriate logs
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/50775/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3243
Line 3244
Line 3245
Line 3246
Line 3247
> freeze() has its own info log, so we don't want to log about the snapshot b
Done
Line 3244
Line 3245
Line 3246
Line 3247
Line 3248
> log.info message about the snapshot, drives and memory here.
Done
Line 3245
Line 3246
Line 3247
Line 3248
Line 3249
> log.info message here when snapshot is complete.
Done
Line 3131: padToBlockSize(memoryVolPath)
Line 3132: else:
Line 3133: fileUtils.padToBlockSize(memoryVolPath)
Line 3134:
Line 3135: self.log.info("Taking a live snapshot on VM %s.",
self.conf['vmId'])
> We already have a log about taking a snapshot in jsonrpc bridge, so we don'
Done
Line 3136:
Line 3137: snap = vmxml.Element('domainsnapshot')
Line 3138: disks = vmxml.Element('disks')
Line 3139: newDrives = {}
Line 3183: vmDrives[vmDevName] = vmDrive
Line 3184:
Line 3185: if len(newDrives) == 0:
Line 3186: self.log.info("Include no disks in live snapshot on VM
%s.",
Line 3187: self.conf['vmId'])
> Instead of this, lets log the drives we take a snapshot with later.
Done
Line 3188:
Line 3189: preparedDrives = {}
Line 3190:
Line 3191: for vmDevName, vmDevice in newDrives.iteritems():
Line 3212: snapFlags = (libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT |
Line 3213: libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)
Line 3214:
Line 3215: if memoryParams:
Line 3216: self.log.info("Include memory in live snapshot on VM
%s.",
> Lets log this in the single log before taking a snapshot.
Done
Line 3217: self.conf['vmId'])
Line 3218: # Save the needed vm configuration
Line 3219: # TODO: this, as other places that use pickle.dump
Line 3220: # directly to files, should be done with outOfProcess
Line 3286: self.startDisksStatsCollection()
Line 3287: if memoryParams:
Line 3288: self.cif.teardownVolumePath(memoryVol)
Line 3289:
Line 3290: self.log.info("Completed live snapshot on VM %s.",
self.conf['vmId'])
> Move this when snapshot is finished, before calling thaw(), again, to avoid
Done
Line 3291:
Line 3292: # Returning quiesce to notify the manager whether the guest
agent
Line 3293: # froze and flushed the filesystems or not.
Line 3294: quiesce = should_freeze and freezed["status"]["code"] == 0
--
To view, visit https://gerrit.ovirt.org/50775
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - adding appropriate logs
Daniel Erez has uploaded a new change for review.
Change subject: vm: snapshot - adding appropriate logs
..
vm: snapshot - adding appropriate logs
Following https://gerrit.ovirt.org/#/c/49535,
adding some useful logs to snapshot flow.
Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Signed-off-by: Daniel Erez
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/50775/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ae91531..e4ed2bf 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3132,6 +3132,8 @@
else:
fileUtils.padToBlockSize(memoryVolPath)
+self.log.info("Taking a live snapshot on VM %s.", self.conf['vmId'])
+
snap = vmxml.Element('domainsnapshot')
disks = vmxml.Element('disks')
newDrives = {}
@@ -3180,6 +3182,10 @@
# safely access the blockDev property until after prepareVolumePath
vmDrives[vmDevName] = vmDrive
+if len(newDrives) == 0:
+self.log.info("Include no disks in live snapshot on VM %s.",
+ self.conf['vmId'])
+
preparedDrives = {}
for vmDevName, vmDevice in newDrives.iteritems():
@@ -3207,6 +3213,8 @@
libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)
if memoryParams:
+self.log.info("Include memory in live snapshot on VM %s.",
+ self.conf['vmId'])
# Save the needed vm configuration
# TODO: this, as other places that use pickle.dump
# directly to files, should be done with outOfProcess
@@ -3279,6 +3287,8 @@
if memoryParams:
self.cif.teardownVolumePath(memoryVol)
+self.log.info("Completed live snapshot on VM %s.", self.conf['vmId'])
+
# Returning quiesce to notify the manager whether the guest agent
# froze and flushed the filesystems or not.
quiesce = should_freeze and freezed["status"]["code"] == 0
--
To view, visit https://gerrit.ovirt.org/50775
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7
Daniel Erez has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7
Hello Sandro Bonazzola, Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50766
to review the following change.
Change subject: spec: Require newer qemu version for el7
..
spec: Require newer qemu version for el7
Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assertion error after lvextend caused by a memory
corruption in the block sub-system.
For more details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1277922
* http://marc.info/?l=qemu-devel&m=144740716414450&w=2
Bug-Url: https://bugzilla.redhat.com/1279052
Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Signed-off-by: Daniel Erez
Reviewed-on: https://gerrit.ovirt.org/50435
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer
Reviewed-by: Francesco Romani
Reviewed-by: Sandro Bonazzola
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/50766/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0d9562f..0cd475f 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -238,8 +238,8 @@
%endif
%if 0%{?rhel}
-Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
-Requires: qemu-img-rhev >= 10:2.3.0-13.el7
+Requires: qemu-kvm-rhev >= 10:2.3.0-31.el7_2.4
+Requires: qemu-img-rhev >= 10:2.3.0-31.el7_2.4
%else
Requires: qemu-kvm >= 2:2.1.3-11
Requires: qemu-img >= 2:2.1.3-11
--
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sandro Bonazzola
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer qemu version for el7
Daniel Erez has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 3: Verified+1 Verified on CentOS/EL. -- To view, visit https://gerrit.ovirt.org/50435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata
Daniel Erez has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 530: return meta
Line 531:
Line 532: @classmethod
Line 533: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type,
voltype,
Line 534: disktype, desc="", legality=ILLEGAL_VOL):
> Hmm, not really sure what you mean here. none of the lines are too long.
Just meant to align the variables with newMetadata method for easier
identification of the difference.
I.e.
line 526: voltype, disktype, desc="", legality=ILLEGAL_VOL):
line 534: voltype, disktype, desc="", legality=ILLEGAL_VOL):
Line 535: return {
Line 536: FORMAT: str(format),
Line 537: TYPE: str(type),
Line 538: VOLTYPE: str(voltype),
--
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer qemu version for el7
Daniel Erez has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 2: @Allon - do we need the separation between RHEL and CentOS when bumping qemu version? -- To view, visit https://gerrit.ovirt.org/50435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer qemu version for el7
Daniel Erez has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/50435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer qemu version for el7
Daniel Erez has uploaded a new change for review.
Change subject: spec: Require newer qemu version for el7
..
spec: Require newer qemu version for el7
Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assertion error after lvextend caused by a memory
corruption in the block sub-system.
For more details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1277922
* http://marc.info/?l=qemu-devel&m=144740716414450&w=2
We don't require the package on CentOS, since it is not available yet.
Bug-Url: https://bugzilla.redhat.com/1279052
Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Signed-off-by: Daniel Erez
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/50435/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index d7b6ae8..4ca82cb 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -234,9 +234,15 @@
%endif
%if 0%{?rhel}
+%if 0%{?centos}
+# TODO: Remove when qemu-kvm-rhev 2.3.0-31.el7_2.4 is available
Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
Requires: qemu-img-rhev >= 10:2.3.0-13.el7
%else
+Requires: qemu-kvm-rhev >= 10:2.3.0-31.el7_2.4
+Requires: qemu-img-rhev >= 10:2.3.0-31.el7_2.4
+%endif # centos
+%else
Requires: qemu-kvm >= 2:2.3.0
Requires: qemu-img >= 2:2.3.0
%endif # rhel
--
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: enabling memory snapshot without disks
Daniel Erez has posted comments on this change. Change subject: vm: enabling memory snapshot without disks .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: enabling memory snapshot without disks
Daniel Erez has uploaded a new change for review.
Change subject: vm: enabling memory snapshot without disks
..
vm: enabling memory snapshot without disks
Taking a memory snapshot of a VM without disks should be
supported (or merely with Cinder/LUN disks for that matter).
Hence, removing the early return on 'VM -> snapshot'
in case 'newDrives' is empty.
Instead, proper logging will be added on consecutive patches.
Possible configurations and settings that lead to this flow:
* Unchecking all the disks in the create snapshot dialog.
* VM with only cinder disks.
* VM without disks.
Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Bug-Url: https://bugzilla.redhat.com/1287066
Signed-off-by: Daniel Erez
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/50199/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 2653826..e7fec33 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3108,11 +3108,6 @@
# safely access the blockDev property until after prepareVolumePath
vmDrives[vmDevName] = vmDrive
-# If all the drives are the current ones, return success
-if len(newDrives) == 0:
-self.log.debug('all the drives are already in use, success')
-return {'status': doneCode}
-
preparedDrives = {}
for vmDevName, vmDevice in newDrives.iteritems():
--
To view, visit https://gerrit.ovirt.org/50199
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: move getVolumeSize
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize .. Patch Set 23: -Code-Review -- To view, visit https://gerrit.ovirt.org/41998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata
Daniel Erez has posted comments on this change. Change subject: fileVolume: define file extension for volume artifacts metadata .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: move getVolumeSize
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize .. Patch Set 22: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: move validateDelete
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: move validateDelete .. Patch Set 22: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 22: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80c1fa58d64efbb3cbc7eea84189fc8375b6fa3d Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: move newMetadata
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: move newMetadata .. Patch Set 22: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: move newVolumeLease
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: move newVolumeLease .. Patch Set 22: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If18aa7d526d9eb334c638fdf4cc93d31a4943cb6 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata
Daniel Erez has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 521: def createMetadata(cls, metaId, meta): Line 522: cls._putMetadata(metaId, meta) Line 523: Line 524: @classmethod Line 525: def newMetadata(cls, metaId, sdUUID, imgUUID, puuid, size, format, type, It might be confusing to understand the difference between newMetadata and makeMetadata methods.. Can you please add some documentation the clarify and explain when one should use which? Line 526: voltype, disktype, desc="", legality=ILLEGAL_VOL): Line 527: meta = cls.makeMetadata(sdUUID, imgUUID, puuid, size, format, type, Line 528: voltype, disktype, desc, legality) Line 529: cls.createMetadata(metaId, meta) -- To view, visit https://gerrit.ovirt.org/44045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: move refreshVolume
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 22: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42003/22/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 542: cls.createMetadata(metaId, meta)
Line 543: return meta
Line 544:
Line 545: def refreshVolume(self):
Line 546: pass
maybe worth adding a comment that we implement it in block for example?
Line 547:
Line 548:
Line 549: class Volume(object):
Line 550: log = logging.getLogger('Storage.Volume')
--
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5041428d8d2e73edc1aa1362fcea8801e5b9116
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move getParentVolume
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: Move getParentVolume .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74def8861e0b7b97ca4d218a969440ccba7f07dd Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: volume share utilities
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: volume share utilities .. Patch Set 22: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c7aaf4a8a8b8bce18331c0a55ba533192777f7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata
Daniel Erez has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 530: return meta
Line 531:
Line 532: @classmethod
Line 533: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type,
voltype,
Line 534: disktype, desc="", legality=ILLEGAL_VOL):
readability - consider moving 'voltype' to the prefix of this line...
Line 535: return {
Line 536: FORMAT: str(format),
Line 537: TYPE: str(type),
Line 538: VOLTYPE: str(voltype),
--
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move getImageVolumes
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: Move getImageVolumes .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e99008b0df26a0bd2f714ac060ceee437e0060e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
Daniel Erez has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sagi Shnaidman Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: enabling memory snapshot without disks
Daniel Erez has posted comments on this change. Change subject: vm: enabling memory snapshot without disks .. Patch Set 2: Verified the flows mentioned in the commit message. I.e. memory snapshot on a VM with Cinder disks or no disks. Previewed the snapshot and verified memory by tmpfs consistency... -- To view, visit https://gerrit.ovirt.org/49535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: enabling memory snapshot without disks
Daniel Erez has posted comments on this change. Change subject: vm: enabling memory snapshot without disks .. Patch Set 2: Thanks Michal and Arik. @Nir/Francesco - can we move forward with this then? -- To view, visit https://gerrit.ovirt.org/49535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM
Daniel Erez has posted comments on this change. Change subject: vm: snapshot - enabling memory snapshot for diskless VM .. Patch Set 1: That's not exactly correct - previewing a memory snapshot without disks prevents running the VM. That's worse than merely 'did nothing'. Running the VM would fail with an ugly exception in vdsm. @Michal/Arik - shouldn't we support previewing a memory snapshot without disks? -- To view, visit https://gerrit.ovirt.org/49535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM
Daniel Erez has posted comments on this change. Change subject: vm: snapshot - enabling memory snapshot for diskless VM .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/49535/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-12-01 21:00:52 +0200 Line 4: Commit: Daniel Erez Line 5: CommitDate: 2015-12-01 21:09:15 +0200 Line 6: Line 7: vm: snapshot - enabling memory snapshot for diskless VM > Vm with cinder disk is not diskless - how about: Done Line 8: Line 9: Taking a memory snapshot of a VM without disks should be Line 10: supported (or merely with Cinder/LUN disks for that matter). Line 11: https://gerrit.ovirt.org/#/c/49535/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3137 Line 3138 Line 3139 Line 3140 Line 3141 > This allows memory snapshot without any disks - does this snapshot make sen Previewing a snapshot without disks can be previewed. Though it's probably not very useful, it does make sense in some scenarios. We currently require a master domain in order to use Cinder. So, the ram disk and ovf will be saved on one of the data domains. Detaching is blocked by the engine in case some VMs are using it. And it's not related to this patch any way... :) According to the current behavior, we already have some logic for selecting the target storage domain (free space, etc). Again, not related to this patch at all :) -- To view, visit https://gerrit.ovirt.org/49535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM
Daniel Erez has posted comments on this change. Change subject: vm: snapshot - enabling memory snapshot for diskless VM .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - enabling memory snapshot for diskless VM
Daniel Erez has uploaded a new change for review.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
vm: snapshot - enabling memory snapshot for diskless VM
Taking a memory snapshot of a VM without disks should be
supported (or merely with Cinder/LUN disks for that matter).
Hence, removing the early return on 'VM -> snapshot'
in case 'newDrives' is empty.
Instead, proper logging will be added on consecutive patches.
Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Bug-Url: https://bugzilla.redhat.com/1287066
Signed-off-by: Daniel Erez
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/49535/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 8ec8b1d..8503f64 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3134,11 +3134,6 @@
# safely access the blockDev property until after prepareVolumePath
vmDrives[vmDevName] = vmDrive
-# If all the drives are the current ones, return success
-if len(newDrives) == 0:
-self.log.debug('all the drives are already in use, success')
-return {'status': doneCode}
-
preparedDrives = {}
for vmDevName, vmDevice in newDrives.iteritems():
--
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomain: Add get_manifest
Daniel Erez has posted comments on this change. Change subject: StorageDomain: Add get_manifest .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a7ebd209a77bea90b2b6f306c85a146923f15c6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move recheckIfLeaf into *Metadata class
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibddf8fc2feea49859924743f2b30e0f2fc71ebb7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Metadata read utils
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: Metadata read utils .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e02ad8138bae0b1d60b032662afbad15dd4feba Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: image: copy - set VM metadata images format to RAW
Daniel Erez has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: image: copy - set VM metadata images format to RAW
Hello Adam Litke, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49144
to review the following change.
Change subject: image: copy - set VM metadata images format to RAW
..
image: copy - set VM metadata images format to RAW
Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9
copy of internal raw volumes is done using 'qemu-img convert'
instead of invoking 'dd'.
Consequently, exporting VM metadata images (produce during
live snapshot) fails on qemu-img convert - since the images
'impersonate' to qcow2 (the format in .meta file is cow,
whereas the real format is raw).
Hence, we try to identify the VM metadata image on
'_interImagesCopy' and set its format to RAW
so qemuimg.convert won't fail (QImgError: "Image is
not in qcow2 format").
This approach is a workaround since it's done merely to
conceal the aforementioned miscorrelation, however,
it seems to be simpler than fixing the root cause
(see https://gerrit.ovirt.org/#/c/48768/).
Note: this fix is merely for passing the correct argument
to qemu-img on convert (raw format). I.e. the .meta file of
the target files will still contain the wrong format (cow).
Change-Id: Icaad6599260a2631f580e17404d25554a19ec670
Bug-Url: https://bugzilla.redhat.com/1282239
Signed-off-by: Daniel Erez
Reviewed-on: https://gerrit.ovirt.org/49002
Reviewed-by: Adam Litke
Reviewed-by: Nir Soffer
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani
---
M vdsm/storage/image.py
1 file changed, 26 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/49144/1
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 791b48c..fcb1fca 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -67,6 +67,9 @@
RENAME_RANDOM_STRING_LEN = 8
+# Size in blocks of the conf file generated during RAM snapshot operation.
+VM_CONF_SIZE_BLK = 20
+
# Temporary size of a volume when we optimize out the prezeroing
TEMPORARY_VOLUME_SIZE = 20480 # in sectors (10M)
@@ -430,8 +433,7 @@
try:
dstVol = destDom.produceVolume(imgUUID=imgUUID,
volUUID=srcVol.volUUID)
-srcFormat = volume.fmt2str(srcVol.getFormat())
-dstFormat = volume.fmt2str(dstVol.getFormat())
+srcFormat, dstFormat = self._detect_format(srcVol, dstVol)
parentVol = dstVol.getParentVolume()
@@ -465,6 +467,28 @@
# teardown volumes
self.__cleanupMove(srcLeafVol, dstLeafVol)
+def _detect_format(self, srcVol, dstVol):
+"""
+VM metadata image format is RAW, whereas in .meta file it's COW:
+see bz#1282239. Hence, detecting metadata files by size and format
+mis-correlation.
+"""
+src_format = srcVol.getFormat()
+size_in_blk = srcVol.getSize()
+if src_format == volume.COW_FORMAT and size_in_blk == VM_CONF_SIZE_BLK:
+info = qemuimg.info(srcVol.getVolumePath())
+actual_format = info['format']
+
+if actual_format == qemuimg.FORMAT.RAW:
+self.log.warning("Incorrect volume format %r has been detected"
+ " for volume %r, using the actual format %r.",
+ qemuimg.FORMAT.QCOW2,
+ srcVol.volUUID,
+ qemuimg.FORMAT.RAW)
+return qemuimg.FORMAT.RAW, qemuimg.FORMAT.RAW
+
+return volume.fmt2str(src_format), volume.fmt2str(dstVol.getFormat())
+
def _finalizeDestinationImage(self, destDom, imgUUID, chains, force):
for srcVol in chains['srcChain']:
try:
--
To view, visit https://gerrit.ovirt.org/49144
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: copy - set VM metadata images format to RAW
Daniel Erez has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 7: Verified+1 Verified: * export/import of new VMs with ram snapshots. * export/import of old VMs with ram snapshots (3.5). * preview of a snapshot with memory seems to work as expected, VM starts with the previous memory (verified on el guest). -- To view, visit https://gerrit.ovirt.org/49002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Metadata read utils
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: Metadata read utils
..
Patch Set 18:
(2 comments)
https://gerrit.ovirt.org/#/c/41846/18/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
Line 108: meta = misc.readblock(lvm.lvPath(vgname, sd.METADATA),
Line 109: offs * volume.METADATA_SIZE,
Line 110: volume.METADATA_SIZE)
Line 111: out = {}
Line 112: for l in meta:
this logic seems similar to the one in fileVolume, can't we reuse it?
Line 113: if l.startswith("EOF"):
Line 114: return out
Line 115: if l.find("=") < 0:
Line 116: continue
https://gerrit.ovirt.org/#/c/41846/18/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 1061
Line 1062
Line 1063
Line 1064
Line 1065
shouldn't be extracted to VolumeMetadata as well?
--
To view, visit https://gerrit.ovirt.org/41846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e02ad8138bae0b1d60b032662afbad15dd4feba
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: copy - set VM metadata images format to RAW
Daniel Erez has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/49002/6/vdsm/storage/image.py File vdsm/storage/image.py: Line 67: Line 68: RENAME_RANDOM_STRING_LEN = 8 Line 69: Line 70: # Size in blocks of the conf file generated during RAM snapshot operation Line 71: VM_CONF_SIZE_BLK = 20 > This size isn't referenced by the code which creates the VM conf volume. H The size is determined by the engine. I.e. the engine creates an image in size of 10K. So I don't think we could actually ensure that. However, since the issue is only with old/existing images, it shouldn't be a problem. New images are should already be created by engine as raw. See - https://gerrit.ovirt.org/#/c/48768/ Line 72: Line 73: # Temporary size of a volume when we optimize out the prezeroing Line 74: TEMPORARY_VOLUME_SIZE = 20480 # in sectors (10M) Line 75: Line 503: mis-correlation. Line 504: """ Line 505: format = srcVol.getFormat() Line 506: size_in_blk = srcVol.getSize() Line 507: if format == volume.COW_FORMAT and size_in_blk == VM_CONF_SIZE_BLK: > Is there a better way to detect these volumes other than using the size? Yeah, you're right, the thing is that we don't have a better way to identify these files... Any way, it affects only old files, new one should be created correctly by the engine - see - https://gerrit.ovirt.org/#/c/48768/ Line 508: info = qemuimg.info(srcVol.getVolumePath()) Line 509: actual_format = info['format'] Line 510: Line 511: if actual_format == qemuimg.FORMAT.RAW: -- To view, visit https://gerrit.ovirt.org/49002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: copy - set VM metadata images format to RAW
Daniel Erez has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/49002/3/vdsm/storage/image.py File vdsm/storage/image.py: Line 67: Line 68: RENAME_RANDOM_STRING_LEN = 8 Line 69: Line 70: # Size in blocks of the conf file generated during RAM snapshot operation Line 71: VM_CONF_SIZE = 20 > why is it 20? is this the minimum we allocate everytime? yeah, we create the disk with virtual size of 10K - i.e. 20 blocks. Line 72: Line 73: # Temporary size of a volume when we optimize out the prezeroing Line 74: TEMPORARY_VOLUME_SIZE = 20480 # in sectors (10M) Line 75: -- To view, visit https://gerrit.ovirt.org/49002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: copy - set VM metadata images format to RAW
Daniel Erez has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 3: (7 comments) https://gerrit.ovirt.org/#/c/49002/3/vdsm/storage/image.py File vdsm/storage/image.py: Line 495: finally: Line 496: # teardown volumes Line 497: self.__cleanupMove(srcLeafVol, dstLeafVol) Line 498: Line 499: def _detect_src_format(self, volume, srcVol): > Please add a docstring explaining this workaround instead of the comment be Done Line 500: format_from_meta = srcVol.getFormat() Line 501: if format_from_meta == volume.COW_FORMAT: Line 502: info = qemuimg.info(srcVol.getVolumePath()) Line 503: format_from_info = info['format'] Line 496: # teardown volumes Line 497: self.__cleanupMove(srcLeafVol, dstLeafVol) Line 498: Line 499: def _detect_src_format(self, volume, srcVol): Line 500: format_from_meta = srcVol.getFormat() > Lets call this "format", since we don't want to call size_in_blocks size_in Done Line 501: if format_from_meta == volume.COW_FORMAT: Line 502: info = qemuimg.info(srcVol.getVolumePath()) Line 503: format_from_info = info['format'] Line 504: size_in_blocks = srcVol.getSize() Line 497: self.__cleanupMove(srcLeafVol, dstLeafVol) Line 498: Line 499: def _detect_src_format(self, volume, srcVol): Line 500: format_from_meta = srcVol.getFormat() Line 501: if format_from_meta == volume.COW_FORMAT: > Check the size here as well - we want to do this check only for vm conf vol Done Line 502: info = qemuimg.info(srcVol.getVolumePath()) Line 503: format_from_info = info['format'] Line 504: size_in_blocks = srcVol.getSize() Line 505: Line 499: def _detect_src_format(self, volume, srcVol): Line 500: format_from_meta = srcVol.getFormat() Line 501: if format_from_meta == volume.COW_FORMAT: Line 502: info = qemuimg.info(srcVol.getVolumePath()) Line 503: format_from_info = info['format'] > Call this "actual_format" Done Line 504: size_in_blocks = srcVol.getSize() Line 505: Line 506: # VM metadata image format is RAW, whereas in .meta file it's COW: Line 507: # see bz#1282239 Line 500: format_from_meta = srcVol.getFormat() Line 501: if format_from_meta == volume.COW_FORMAT: Line 502: info = qemuimg.info(srcVol.getVolumePath()) Line 503: format_from_info = info['format'] Line 504: size_in_blocks = srcVol.getSize() > Lets add do the size test before running qemu-img. If this is not a vm conf Done Line 505: Line 506: # VM metadata image format is RAW, whereas in .meta file it's COW: Line 507: # see bz#1282239 Line 508: if format_from_info == 'raw' and size_in_blocks == VM_CONF_SIZE: Line 504: size_in_blocks = srcVol.getSize() Line 505: Line 506: # VM metadata image format is RAW, whereas in .meta file it's COW: Line 507: # see bz#1282239 Line 508: if format_from_info == 'raw' and size_in_blocks == VM_CONF_SIZE: > Use the qemuimg.FORMAT.RAW Done Line 509: return format_from_info Line 510: Line 511: return volume.fmt2str(format_from_meta) Line 512: Line 505: Line 506: # VM metadata image format is RAW, whereas in .meta file it's COW: Line 507: # see bz#1282239 Line 508: if format_from_info == 'raw' and size_in_blocks == VM_CONF_SIZE: Line 509: return format_from_info > Log here big warning about incorrect volume format and using the actual for Done Line 510: Line 511: return volume.fmt2str(format_from_meta) Line 512: Line 513: def _finalizeDestinationImage(self, destDom, imgUUID, chains, force): -- To view, visit https://gerrit.ovirt.org/49002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: copy - set VM metadata images format to RAW
Daniel Erez has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: fall-back to dd - workaround for bz#1282239
Daniel Erez has abandoned this change. Change subject: image: fall-back to dd - workaround for bz#1282239 .. Abandoned replaced by https://gerrit.ovirt.org/#/c/49002/ -- To view, visit https://gerrit.ovirt.org/48907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3508f0cab1bc841dc8c7277146b2b54ff787f3ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: copy - set VM metadata images format to RAW
Daniel Erez has uploaded a new change for review. Change subject: image: copy - set VM metadata images format to RAW .. image: copy - set VM metadata images format to RAW Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9 copy of internal raw volumes is done using 'qemu-img convert' instead of invoking 'dd'. Consequently, exporting VM metadata images (produce during live snapshot) fails on qemu-img convert - since the images 'impersonate' to qcow2 (the format in .meta file is cow, whereas the real format is raw). Hence, we try to identify the VM metadata image on '_interImagesCopy' and set its format to RAW so qemuimg.convert could behave nicely. This approach is a workaround since it's done merely to conceal the aforementioned miscorrelation, however, it seems to be simpler than fixing the root cause (see https://gerrit.ovirt.org/#/c/48768/). Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Bug-Url: https://bugzilla.redhat.com/1282239 Signed-off-by: Daniel Erez --- M vdsm/storage/image.py 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/49002/1 diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index 956c805..c2a63ee 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -27,6 +27,7 @@ import volume from vdsm import qemuimg from vdsm import virtsparsify +from vdsm import constants from sdc import sdCache import sd import misc @@ -458,7 +459,7 @@ try: dstVol = destDom.produceVolume(imgUUID=imgUUID, volUUID=srcVol.volUUID) -srcFormat = volume.fmt2str(srcVol.getFormat()) +srcFormat = self._getSrcFormat(volume, srcVol) dstFormat = volume.fmt2str(dstVol.getFormat()) parentVol = dstVol.getParentVolume() @@ -493,6 +494,20 @@ # teardown volumes self.__cleanupMove(srcLeafVol, dstLeafVol) +def _getSrcFormat(self, volume, srcVol): +imgInfo = qemuimg.info(srcVol.getVolumePath()) +srcVirtualSizeInBytes = imgInfo['virtualsize'] +srcFormatImgInfo = imgInfo['format'] +srcFormatFromMeta = volume.fmt2str(srcVol.getFormat()) + +# VM metadata image format is RAW, whereas in .meta file it's COW: +# see bz#1282239 +if srcFormatFromMeta != srcFormatImgInfo \ +and srcVirtualSizeInBytes < constants.GIB: +return srcFormatImgInfo + +return srcFormatFromMeta + def _finalizeDestinationImage(self, destDom, imgUUID, chains, force): for srcVol in chains['srcChain']: try: -- To view, visit https://gerrit.ovirt.org/49002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: snapshot - use r+ to open vm conf file
Daniel Erez has posted comments on this change. Change subject: vm: snapshot - use r+ to open vm conf file .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/48912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: snapshot - use r+ to open vm conf file
Hello Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/48912 to review the following change. Change subject: vm: snapshot - use r+ to open vm conf file .. vm: snapshot - use r+ to open vm conf file Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9 copy of internal raw volumes is done using 'qemu-img convert' instead of invoking 'dd'. Hence, we should avoid changing the file size by opening it in a non-truncate mode to avoid qemu-img from hanging during the convert operation. The issue reproduces for files size of multiplicity of 512. E.g. Doesn't work: $ dd if=/dev/zero of=/tmp/test.raw bs=5474 count=1 $ ./qemu-img convert -p -t none -T none -O raw /tmp/test.raw /tmp/dest.raw Works: $ dd if=/dev/zero of=/tmp/test.raw bs=5120 count=1 $ ./qemu-img convert -p -t none -T none -O raw /tmp/test.raw /tmp/dest.raw Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Bug-Url: https://bugzilla.redhat.com/1282239 Relates-To: https://bugzilla.redhat.com/1229394 Signed-off-by: Daniel Erez Reviewed-on: https://gerrit.ovirt.org/48776 Reviewed-by: Nir Soffer Continuous-Integration: Nir Soffer Reviewed-by: Francesco Romani --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/48912/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index a5eead1..27d9826 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -3133,7 +3133,8 @@ vmConfVolPath = self.cif.prepareVolumePath(vmConfVol) vmConf = _vmConfForMemorySnapshot() try: -with open(vmConfVolPath, "w") as f: +# Use r+ to avoid truncating the file, see BZ#1282239 +with open(vmConfVolPath, "r+") as f: pickle.dump(vmConf, f) finally: self.cif.teardownVolumePath(vmConfVol) -- To view, visit https://gerrit.ovirt.org/48912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: fall-back to dd - workaround for bz#1282239
Daniel Erez has posted comments on this change. Change subject: image: fall-back to dd - workaround for bz#1282239 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/48907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3508f0cab1bc841dc8c7277146b2b54ff787f3ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: fall-back to dd - workaround for bz#1282239
Daniel Erez has uploaded a new change for review. Change subject: image: fall-back to dd - workaround for bz#1282239 .. image: fall-back to dd - workaround for bz#1282239 Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9 copy of internal raw volumes is done using 'qemu-img convert' instead of invoking 'dd'. Consequently, exporting VM metadata images (produce during live snapshot) fails on qemu-img convert - since the images 'impersonate' to qcow2 (the format in .meta file is cow, whereas the real format is raw). This approach is a workaround since it's done merely to conceal the aforementioned miscorrelation, however, it seems to be simpler than fixing the root cause (see https://gerrit.ovirt.org/#/c/48768/). Change-Id: I3508f0cab1bc841dc8c7277146b2b54ff787f3ef Bug-Url: https://bugzilla.redhat.com/1282239 Signed-off-by: Daniel Erez --- M vdsm/storage/image.py 1 file changed, 27 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/48907/1 diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index 956c805..9bd7675 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -461,24 +461,35 @@ srcFormat = volume.fmt2str(srcVol.getFormat()) dstFormat = volume.fmt2str(dstVol.getFormat()) -parentVol = dstVol.getParentVolume() +srcFormatFromMeta = qemuimg.info( +srcVol.getVolumePath())['format'] +if srcFormatFromMeta == srcFormat: +parentVol = dstVol.getParentVolume() -if parentVol is not None: -backing = volume.getBackingVolumePath( -imgUUID, parentVol.volUUID) -backingFormat = volume.fmt2str(parentVol.getFormat()) +if parentVol is not None: +backing = volume.getBackingVolumePath( +imgUUID, parentVol.volUUID) +backingFormat = volume.fmt2str( +parentVol.getFormat()) +else: +backing = None +backingFormat = None + +operation = qemuimg.convert( +srcVol.getVolumePath(), +dstVol.getVolumePath(), +srcFormat=srcFormat, +dstFormat=dstFormat, +backing=backing, +backingFormat=backingFormat) +self._wait_for_qemuimg_operation(operation) else: -backing = None -backingFormat = None - -operation = qemuimg.convert( -srcVol.getVolumePath(), -dstVol.getVolumePath(), -srcFormat=srcFormat, -dstFormat=dstFormat, -backing=backing, -backingFormat=backingFormat) -self._wait_for_qemuimg_operation(operation) +# fall-back to dd - workaround for bz#1282239 +srcSize = srcVol.getVolumeSize(bs=1) +misc.ddWatchCopy(srcVol.getVolumePath(), + dstVol.getVolumePath(), + vars.task.aborting, + size=srcSize) except ActionStopped: raise except se.StorageException: -- To view, visit https://gerrit.ovirt.org/48907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3508f0cab1bc841dc8c7277146b2b54ff787f3ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - use r+ to open vm conf file
Daniel Erez has posted comments on this change. Change subject: vm: snapshot - use r+ to open vm conf file .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48776/2//COMMIT_MSG Commit Message: Line 23: to a sector boundary like a valid raw image would be. In upstream Line 24: it does work (with the destination image size rounded up to the Line 25: next full sector), but the lesson to learn is that you should Line 26: only use qemu-img convert with disk images, never with random Line 27: other files. > This additional text does not explain much in particular the part about not So why a reference to the BZ is not good enough? Line 28: " Line 29: Line 30: Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Line 31: Bug-Url: https://bugzilla.redhat.com/1282239 -- To view, visit https://gerrit.ovirt.org/48776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - use r+ to open vm conf file
Daniel Erez has posted comments on this change. Change subject: vm: snapshot - use r+ to open vm conf file .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/48776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - use r+ to open vm conf file
Daniel Erez has posted comments on this change. Change subject: vm: snapshot - use r+ to open vm conf file .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/48776/1//COMMIT_MSG Commit Message: Line 10: copy of internal raw volumes is done using 'qemu-img convert' Line 11: instead of invoking 'dd'. Hence, we should avoid changing Line 12: the file size by opening it in a non-truncate mode to avoid Line 13: qemu-img from hanging during the convert operation Line 14: (see https://bugzilla.redhat.com/show_bug.cgi?id=1282239#c16). > I would like to understand why truncating cause dd to hang. Can you get si Done Line 15: Line 16: Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Line 17: Bug-Url: https://bugzilla.redhat.com/1282239 https://gerrit.ovirt.org/#/c/48776/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3159 Line 3160 Line 3161 Line 3162 Line 3163 > We need a comment here - "Use r+ to avoid truncating the file, see https://gerrit.ovirt.org/48776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot - use r+ to open vm conf file
Daniel Erez has uploaded a new change for review. Change subject: vm: snapshot - use r+ to open vm conf file .. vm: snapshot - use r+ to open vm conf file Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9 copy of internal raw volumes is done using 'qemu-img convert' instead of invoking 'dd'. Hence, we should avoid changing the file size by opening it in a non-truncate mode to avoid qemu-img from hanging during the convert operation (see https://bugzilla.redhat.com/show_bug.cgi?id=1282239#c16). Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Bug-Url: https://bugzilla.redhat.com/1282239 Signed-off-by: Daniel Erez --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/48776/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 867f100..24d7d2a 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -3160,7 +3160,7 @@ vmConfVolPath = self.cif.prepareVolumePath(vmConfVol) vmConf = _vmConfForMemorySnapshot() try: -with open(vmConfVolPath, "w") as f: +with open(vmConfVolPath, "r+") as f: pickle.dump(vmConf, f) finally: self.cif.teardownVolumePath(vmConfVol) -- To view, visit https://gerrit.ovirt.org/48776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Report vg name in getDeviceList
Daniel Erez has posted comments on this change. Change subject: hsm: Report vg name in getDeviceList .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I116714cb5143ea92f5cb54c3f80f895c07ada536 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: hotunplug: Supporting lun and cinder disks fix.
Daniel Erez has posted comments on this change. Change subject: hotunplug: Supporting lun and cinder disks fix. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/47846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hotunplug: Supporting lun and cinder disks fix.
Daniel Erez has posted comments on this change. Change subject: hotunplug: Supporting lun and cinder disks fix. .. Patch Set 3: Code-Review+1 Verified+1 Verified with Cinder disks. -- To view, visit https://gerrit.ovirt.org/47795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Report librbd1 version also on Debian
Daniel Erez has posted comments on this change. Change subject: ceph: Report librbd1 version also on Debian .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic97979fd208364f3e2009ab29930702688a42d5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Improve error handling when Vm._dom is None
Daniel Erez has posted comments on this change. Change subject: vm: Improve error handling when Vm._dom is None .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5349ec51c7accf3b417b3bc9489c7eed5bfd8733 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: snapshot: Add Vm.freeze() and Vm.thaw() methods
Daniel Erez has posted comments on this change. Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/43018 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e4c54f461039de99823c3b80a10be0a960c4273 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: snapshot: Add VM.freeze() and VM.thaw() verbs
Daniel Erez has posted comments on this change. Change subject: snapshot: Add VM.freeze() and VM.thaw() verbs .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/43058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44c4237841e44548f48f626f4241d3f2e484930e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: snapshot: Add vdsClient freeze() and thaw() APIs
Daniel Erez has posted comments on this change. Change subject: snapshot: Add vdsClient freeze() and thaw() APIs .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/43098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98872132767f3edd6d028cd9545e282e89f12777 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
Daniel Erez has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sagi Shnaidman Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add option to clear other secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Add option to clear other secrets .. Patch Set 15: The add/remove/set design might seem a bit superfluous and would require extra work in engine side, but, it's also cleaner and probably the best of a bad lot. So, +1 from me on that design. -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear only ovirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Clear only ovirt secrets .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b86bd43a6d33a31ef2ee638a16f46657113316d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Undefine existing secret if usage changed
Daniel Erez has posted comments on this change. Change subject: ceph: Undefine existing secret if usage changed .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib258f0be1cdd4f2672b9adaad35da13d48279ce6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear only ovirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Clear only ovirt secrets .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/41302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b86bd43a6d33a31ef2ee638a16f46657113316d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add option to clear other secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Add option to clear other secrets .. Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear all secrets during startup and shutdown
Daniel Erez has posted comments on this change. Change subject: ceph: Clear all secrets during startup and shutdown .. Patch Set 8: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/40968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c5aa36ed752642745b7febc785750b438c102bb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 23: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support hotunplug of network disks
Daniel Erez has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Validate network disk parameters
Daniel Erez has posted comments on this change. Change subject: ceph: Validate network disk parameters .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b10c54ba2732ee75e0e55c67e5e8c7bdfafa41d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Daniel Erez has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Require ceph-common package
Daniel Erez has posted comments on this change. Change subject: ceph: Require ceph-common package .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244100d29b0b06c0387a2fdc69e659c902bbcd3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Input validation using properties
Daniel Erez has posted comments on this change. Change subject: ceph: Input validation using properties .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41049/2/vdsm/virt/secret.py File vdsm/virt/secret.py: Line 21: unused import -- To view, visit https://gerrit.ovirt.org/41049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I225a3722073f3dbe940c5553b347fb87768d1ae9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: properties: Add properties module
Daniel Erez has posted comments on this change. Change subject: properties: Add properties module .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40822/3/lib/vdsm/properties.py File lib/vdsm/properties.py: Line 2: reusable add to Makefile/vdsm.spec/vdsm-python/... -- To view, visit https://gerrit.ovirt.org/40822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62175172dddce7f84319e3c8669747994e06a697 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 18: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/40712/14/tests/vmSecretTests.py File tests/vmSecretTests.py: Line 230: res pep8: line too long... -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/40712/13/vdsm/virt/secret.py File vdsm/virt/secret.py: Line 93: setValue 'setValue' expects c_ubyte (according to c api [*]). Since the function encodes the given value to base64, the following solves the problem: 'virsecret.setValue(base64.b64decode(self.password))' [*] https://libvirt.org/html/libvirt-libvirt-secret.html#virSecretSetValue -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/40712/8/vdsm/virt/secret.py File vdsm/virt/secret.py: Line 1: # this file should be added to vdsm.spec.in -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Daniel Erez has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/40712/8/vdsm/virt/secret.py
File vdsm/virt/secret.py:
Line 48: # TODO: Use response.success when it is available
Line 49: return {'status': doneCode}
Line 50:
Line 51:
Line 52: def unregister(uuids):
It's probably worth to invoke unregister for all secrets on host upon vdsm
restart (to have a clear slate and to correlate to libvirt restart).
Line 53: try:
Line 54: uuids = [str(uuid.UUID(s)) for s in uuids]
Line 55: except ValueError as e:
Line 56: logging.warning("Attempt to unregister invalid uuid %s: %s" %
Line 91: key
shouldn't we use "value" instead, to accommodate to libvirt's format
(https://libvirt.org/formatsecret.html).
Line 92:
I guess we can drop these for now and just use the default values ('yes'), at
least until we decide to support it...
--
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: task: streamlining lock acquiring api
Daniel Erez has abandoned this change. Change subject: task: streamlining lock acquiring api .. Abandoned -- To view, visit https://gerrit.ovirt.org/29729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iac7eaa5ad577279a602651ab2df9e53ee58ac9d5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support hotunplug of network disks
Daniel Erez has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 3: Verified+1 Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Daniel Erez has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 4: Verified+1 Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Return true "truesize" for block volumes
Daniel Erez has posted comments on this change. Change subject: hsm: Return true "truesize" for block volumes .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37785/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 618: return int(size) Line 619: Line 620: def getVAllocSize(self, imgUUID, volUUID): Line 621: """ Returns block volume true size in bytes. """ Line 622: return self.produceVolume(imgUUID, volUUID).getVolumeTrueSize(bs=1) The engine treats 'truesize' as actual size (as opposed to 'apparentsize' which represents the virtual size - the size that is visible to the VM). So I think we should simply switch the logic of these functions (getVSize and getVAllocSize) to correlate the behavior of fileSD - just need to be careful with the current usages of 'getVSize'... :) Line 623: Line 624: def validateCreateVolumeParams(self, volFormat, srcVolUUID, Line 625:preallocate=None): Line 626: super(BlockStorageDomain, self).validateCreateVolumeParams( -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Make it easy to debug assertXMLEqual failures
Daniel Erez has posted comments on this change. Change subject: tests: Make it easy to debug assertXMLEqual failures .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eeaadcbb973fc30d41810fd5cfbc0ea67abe571 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Rename assertXML to assertXMLEqual
Daniel Erez has posted comments on this change. Change subject: tests: Rename assertXML to assertXMLEqual .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31f395eb9afa9887aab5c93eb0b3b94ca143ce07 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: move diskSizeExtend logic from BindingXMLRPC
Daniel Erez has posted comments on this change. Change subject: API: move diskSizeExtend logic from BindingXMLRPC .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9014154f376609d8bd547b7c008954981785b551 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: move diskSizeExtend logic from BindingXMLRPC
Daniel Erez has posted comments on this change. Change subject: API: move diskSizeExtend logic from BindingXMLRPC .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/36590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9014154f376609d8bd547b7c008954981785b551 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: move diskSizeExtend logic from BindingXMLRPC
Daniel Erez has uploaded a new change for review. Change subject: API: move diskSizeExtend logic from BindingXMLRPC .. API: move diskSizeExtend logic from BindingXMLRPC In order to make cold extend disk usable with JSON-RPC, move logic verifying specified VM id from 'BindingXMLRPC -> diskSizeExtend' into 'API (VM class) -> diskSizeExtend' [since there's no other mediator for this logic to both xml/json rpc protocols]. Change-Id: I9014154f376609d8bd547b7c008954981785b551 Bug-Url: https://bugzilla.redhat.com/1178499 Signed-off-by: Daniel Erez --- M vdsm/API.py M vdsm/rpc/BindingXMLRPC.py 2 files changed, 13 insertions(+), 15 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/36590/1 diff --git a/vdsm/API.py b/vdsm/API.py index 2aeaac0..6c5db7e 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -590,10 +590,17 @@ return v.diskReplicateFinish(srcDisk, dstDisk) def diskSizeExtend(self, driveSpecs, newSize): -v = self._cif.vmContainer.get(self._UUID) -if not v: -return errCode['noVM'] -return v.diskSizeExtend(driveSpecs, newSize) +if self._UUID == VM.BLANK_UUID: +try: +volume = Volume( +driveSpecs['volumeID'], driveSpecs['poolID'], +driveSpecs['domainID'], driveSpecs['imageID']) +except KeyError: +return errCode['imageErr'] +return volume.updateSize(newSize) +else: +v = self._cif.vmContainer.get(self._UUID) +return v.diskSizeExtend(driveSpecs, newSize) def pause(self): v = self._cif.vmContainer.get(self._UUID) diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py index 759ed78..a6b75f3 100644 --- a/vdsm/rpc/BindingXMLRPC.py +++ b/vdsm/rpc/BindingXMLRPC.py @@ -543,17 +543,8 @@ return api.getDiskAlignment(driveSpecs) def diskSizeExtend(self, vmId, driveSpecs, newSize): -if vmId == API.VM.BLANK_UUID: -try: -volume = API.Volume( -driveSpecs['volumeID'], driveSpecs['poolID'], -driveSpecs['domainID'], driveSpecs['imageID']) -except KeyError: -return errCode['imageErr'] -return volume.updateSize(newSize) -else: -vm = API.VM(vmId) -return vm.diskSizeExtend(driveSpecs, newSize) +api = API.VM(vmId) +return api.diskSizeExtend(driveSpecs, newSize) def addNetwork(self, bridge, vlan=None, bond=None, nics=None, options=None): -- To view, visit http://gerrit.ovirt.org/36590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9014154f376609d8bd547b7c008954981785b551 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Improve iscsi connection logging
Daniel Erez has posted comments on this change. Change subject: storageServer: Improve iscsi connection logging .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9de4ec72f09777e84273933ff41e9d1424e7aa09 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: remove dead code from getSessionInfo
Daniel Erez has posted comments on this change. Change subject: storageServer: remove dead code from getSessionInfo .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd93fd7d0257caea60bb3981ec1a6604e0dcc723 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: remove dead code from getSessionInfo
Daniel Erez has posted comments on this change. Change subject: storageServer: remove dead code from getSessionInfo .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34537/1/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 404 Line 405 Line 406 Line 407 Line 408 > This looks like an optimization attempt to check first the last session we Yes, the entire method has been added as one patch: http://gerrit.ovirt.org/#/c/1038/ -- To view, visit http://gerrit.ovirt.org/34537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd93fd7d0257caea60bb3981ec1a6604e0dcc723 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: remove dead code from getSessionInfo
Daniel Erez has uploaded a new change for review.
Change subject: storageServer: remove dead code from getSessionInfo
..
storageServer: remove dead code from getSessionInfo
storageServer -> getSessionInfo:
cleanup of unused code ('sessions' varibale is never used).
Change-Id: Idd93fd7d0257caea60bb3981ec1a6604e0dcc723
Signed-off-by: Daniel Erez
---
M vdsm/storage/storageServer.py
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/34537/1
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 76c043c..b2390dc 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -17,7 +17,6 @@
#
# Refer to the README and COPYING files for full details of the license
#
-from itertools import chain
import errno
import logging
from os.path import normpath, basename, splitext
@@ -400,13 +399,6 @@
return True
def getSessionInfo(self):
-sessions = iscsi.iterateIscsiSessions()
-try:
-info = iscsi.getSessionInfo(self._lastSessionId)
-sessions = chain(info, sessions)
-except Exception:
-pass
-
for session in iscsi.iterateIscsiSessions():
if self.isSession(session):
self._lastSessionId = session.id
--
To view, visit http://gerrit.ovirt.org/34537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd93fd7d0257caea60bb3981ec1a6604e0dcc723
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing verbs in command info
Daniel Erez has posted comments on this change. Change subject: jsonrpc: mssing verbs in command info .. Patch Set 3: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ravi Nori Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
