Change in vdsm[master]: vdsm: Try to reconnect on vmchannel after errors
Gal Hammer has posted comments on this change. Change subject: vdsm: Try to reconnect on vmchannel after errors .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Jason Dillaman jdill...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add additional exception handling within vmChannels.py
Gal Hammer has posted comments on this change. Change subject: vdsm: Add additional exception handling within vmChannels.py .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie733ca7ccd2689f6041ee18bbe335f355a89ac55 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Jason Dillaman jdill...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Try to reconnect on vmchannel after timeout
Gal Hammer has posted comments on this change.
Change subject: vdsm: Try to reconnect on vmchannel after timeout
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
File vdsm/guestIF.py
Line 102: ret = False
Line 103: try:
Line 104: self.log.debug(Attempting connection to %s,
self._socketName)
Line 105: result = self._sock.connect_ex(self._socketName)
Line 106: if result == 0:
Are you sure that connect_ex returns an error and doesn't throw an exception?
Line 107: self.log.debug(Connected to %s, self._socketName)
Line 108: self._messageState = MessageState.NORMAL
Line 109: self._clearReadBuffer()
Line 110: self._forward('refresh')
Line 272: if self.guestStatus not in (Powered down,
RebootInProgress):
Line 273: self.log.log(logging.TRACE, Guest connection timed out)
Line 274: self.guestStatus = None
Line 275: self.log.debug(Attempting to reconnect to channel after
timeout)
Line 276: self._connect()
You shouldn't do that here. The logic should be in VmChannels code
(_handle_timeouts method). If you think that a read timeout mean that you need
to re-connected the channel, then add the channel to the unconnected channel
list. That way you'll be in the same code path when a new channel is connected
and gain a connect retries.
Line 277:
Line 278: def _clearReadBuffer(self):
Line 279: self._buffer = []
Line 280: self._bufferSize = 0
--
To view, visit http://gerrit.ovirt.org/11977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add qemu's memory usage to VM statistics.
Gal Hammer has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics.
..
Patch Set 3: (1 inline comment)
File vdsm/libvirtvm.py
Line 173:
Line 174: def _sampleMem(self):
Line 175: memUsage = {}
Line 176: if self.conf['pid'] != '0':
Line 177: for line in open('/proc/%d/status' % (self.conf['pid'])):
I'm sure not about the fd leak, but I don't mind changing the code.
Done.
Line 178: var, value = line.strip().split()[0:2]
Line 179: if var in ('VmSize:', 'VmRSS:', 'VmData:'):
Line 180: memUsage[var[:-1]] = long(value)
Line 181: return memUsage
--
To view, visit http://gerrit.ovirt.org/9006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add qemu's memory usage to VM statistics.
Gal Hammer has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics.
..
Patch Set 2: (2 inline comments)
Commit Message
Line 6:
Line 7: Add qemu's memory usage to VM statistics.
Line 8:
Line 9: Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0
Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=799285
I'll remove it.
File vdsm/libvirtvm.py
Line 172: return netSamples
Line 173:
Line 174: def _sampleMem(self):
Line 175: memUsage = {}
Line 176: for line in open('/proc/%d/status' %(self.conf['pid'])):
I don't know if using with is more pythonic. I think I use with only if
more than one method is executed.
As for the conf['pid']. The _sampleMem function is called from the vmstats
thread, so I don't understand why it is a problem.
Line 177: var, value = line.strip().split()[0:2]
Line 178: if var in ('VmSize:', 'VmRSS:', 'VmData:'):
Line 179: memUsage[var[:-1]] = long(value)
Line 180: return memUsage
--
To view, visit http://gerrit.ovirt.org/9006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add qemu's memory usage to VM statistics.
Gal Hammer has uploaded a new change for review.
Change subject: Add qemu's memory usage to VM statistics.
..
Add qemu's memory usage to VM statistics.
Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=799285
Signed-off-by: Gal Hammer gham...@redhat.com
---
M vdsm/config.py.in
M vdsm/libvirtvm.py
2 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/9006/1
diff --git a/vdsm/config.py.in b/vdsm/config.py.in
index df85e7e..ee1627b 100644
--- a/vdsm/config.py.in
+++ b/vdsm/config.py.in
@@ -111,6 +111,8 @@
('vm_sample_net_interval', '5', None),
('vm_sample_net_window', '2', None),
+
+('vm_sample_memory_interval', '2', None),
('trust_store_path', '@TRUSTSTORE@',
'Where the certificates and keys are situated.'),
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 86e39a3..f76f35c 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -91,10 +91,13 @@
self._sampleNet,
config.getint('vars', 'vm_sample_net_interval'),
config.getint('vars', 'vm_sample_net_window')))
+self.sampleMem = (utils.AdvancedStatsFunction(self._sampleMem,
+config.getint('vars', 'vm_sample_memory_interval')))
self.addStatsFunction(
self.highWrite, self.updateVolumes, self.sampleCpu,
-self.sampleDisk, self.sampleDiskLatency, self.sampleNet)
+self.sampleDisk, self.sampleDiskLatency, self.sampleNet,
+self.sampleMem)
def _highWrite(self):
if not self._vm.isDisksStatsCollectionEnabled():
@@ -168,6 +171,14 @@
netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
return netSamples
+def _sampleMem(self):
+memUsage = {}
+for line in open('/proc/%d/status' %(self.conf['pid'])):
+var, value = line.strip().split()[0:2]
+if var in ('VmSize:', 'VmRSS:', 'VmData:'):
+memUsage[var[:-1]] = long(value)
+return memUsage
+
def _diff(self, prev, curr, val):
return prev[val] - curr[val]
--
To view, visit http://gerrit.ovirt.org/9006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.
Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 4: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added a support for a guest hibernate command.
Gal Hammer has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 8: (1 inline comment)
Now it is: def vmHibernate(self, vmId, target=API.VM.HibernateTarget.DISK)
I guess it should be target=None as before.
File vdsm/vm.py
Line 848: return self._shutdownCommand('Powering down', int(timeout),
Line 849: 'sys_shutdown_timeout', self.guestAgent.desktopShutdown,
timeout,
Line 850: message)
Line 851:
Line 852: def hibernate(self, target='disk'):
I don't remember. This patch was written months ago.
I can guess that it is either because I didn't update the code after I've added
the HibernateTarget constants or because HibernateTarget is not imported in
this file.
Line 853: return self._shutdownCommand('Prepare for hibernate', 0,
Line 854: 'sys_hibernate_timeout', self.guestAgent.hibernate,
target)
Line 855:
Line 856: def _shutdownCommand(self, event, timeout, timeout_var, command,
*args):
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Haim Ateya hat...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added a support for a guest hibernate command.
Gal Hammer has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 8: I don't understand. Do you want me to re-write the patch in such a way that it will break backward compatibility and then fix that?! Will someone explain to me what am I missing and how did I break compatibility? -- To view, visit http://gerrit.ovirt.org/1121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.
Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 1: (1 inline comment) Commit Message Line 3: AuthorDate: 2012-10-24 14:38:37 +0200 Line 4: Commit: Gal Hammer gham...@redhat.com Line 5: CommitDate: 2012-10-24 14:38:37 +0200 Line 6: Line 7: BZ#867439 VM unexpectedly was shutdown after migration. No URL. Line 8: Line 9: Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.
Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.
Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 2: I don't agree with you. The thread is released in the same code path where vdsm get aware that qemu is down. -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.
Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 2: I don't agree with you. The thread is released in the same code path where vdsm get aware that qemu is down. -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...
Gal Hammer has posted comments on this change. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. Patch Set 1: (1 inline comment) File vdsm/libvirtvm.py Line 2440: # when migration completes, see qemuMigrationFinish function). Line 2441: # In this case self._dom is None because the function Line 2442: # _waitForIncomingMigrationFinish didn't update it yet. Line 2443: if self._dom: Line 2444: hooks.after_vm_pause(self._dom.XMLDesc(0), self.conf) I don't think that this comment is not relevant to this patch. Line 2445: elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED: Line 2446: self._guestCpuRunning = True Line 2447: if detail == libvirt.VIR_DOMAIN_EVENT_RESUMED_UNPAUSED: Line 2448: hooks.after_vm_cont(self._dom.XMLDesc(0), self.conf) -- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.
Gal Hammer has uploaded a new change for review. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. BZ#867439 VM unexpectedly was shutdown after migration. Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/8774/1 diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index 2b2b891..25a7ad9 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -2576,6 +2576,9 @@ else: if detail == libvirt.VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN: self.user_destroy = True +elif (detail == libvirt.VIR_DOMAIN_EVENT_STOPPED_FAILED and + self.lastStatus == 'Migration Destination'): +self._incomingMigrationFinished.set() self._onQemuDeath() elif event == libvirt.VIR_DOMAIN_EVENT_SUSPENDED: self._guestCpuRunning = False -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#867439 VM unexpectedly was shutdown after migration.
Gal Hammer has posted comments on this change. Change subject: BZ#867439 VM unexpectedly was shutdown after migration. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28470aeb86bd855fa17b29a881e76fb3ad58b2c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add -d parameter when umouning in mk_sysprep_floppy
Gal Hammer has posted comments on this change. Change subject: add -d parameter when umouning in mk_sysprep_floppy .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70e802b9062e586b10937c700f9a481bf1fe51b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jarod.w work.iec23...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Jarod.w work.iec23...@gmail.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added a support for a guest hibernate command.
Gal Hammer has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 8: (1 inline comment)
File vdsm/API.py
Line 342: stats = v.getStats().copy()
Line 343: stats['vmId'] = self._UUID
Line 344: return {'status': doneCode, 'statsList': [stats]}
Line 345:
Line 346: def hibernate(self, target):
International Islamic University Chittagong?
No. It does not expected to breaks backwards compatibility. I've added a
special targets called disk and mem. These were illegal target names in
the old code.
Line 347:
Line 348: Hibernate a VM.
Line 349:
Line 350: :param target: Either disk, mem or an opaque string,
indicating
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Haim Ateya hat...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [RFE] Integrate Smartcard support
Gal Hammer has posted comments on this change. Change subject: [RFE] Integrate Smartcard support .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek tjeli...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Tomas Jelinek tjeli...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Related to BZ#845020 - Catch bad VM drive specification.
Gal Hammer has posted comments on this change. Change subject: Related to BZ#845020 - Catch bad VM drive specification. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [RFE] Integrate Smartcard support
Gal Hammer has posted comments on this change.
Change subject: [RFE] Integrate Smartcard support
..
Patch Set 3: (1 inline comment)
File vdsm/libvirtvm.py
Line 787: Add smartcard section to domain xml
Line 788:
Line 789: smartcard mode='passthrough' type='spicevmc'/
Line 790:
Line 791: if self.conf.get('smartcard_enabled') == 'true':
I think you should use this style:
if utils.tobool(self.conf.get(''smartcard_enabled'', 'false'):
It is safer and include a default value.
Line 792: card = self.doc.createElement('smartcard')
Line 793: card.setAttribute('mode', 'passthrough')
Line 794: card.setAttribute('type', 'spicevmc')
Line 795: self._devices.appendChild(card)
--
To view, visit http://gerrit.ovirt.org/8450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek tjeli...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Tomas Jelinek tjeli...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#829110 Remove a Domain not found error from stats threa...
Gal Hammer has uploaded a new change for review.
Change subject: BZ#829110 Remove a Domain not found error from stats thread.
..
BZ#829110 Remove a Domain not found error from stats thread.
Removed redundant code which changed VM status if error occured on
the stats thead.
Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a
Signed-off-by: Gal Hammer gham...@redhat.com
---
M vdsm/libvirtvm.py
1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/7746/1
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 6323d0c..2f6e544 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -291,17 +291,6 @@
if ex.get_error_code() != libvirt.VIR_ERR_NO_DOMAIN:
return False
-# If a VM is down, hibernating, migrating, destroyed or in the
-# process of being shutdown we were expecting it to disappear
-if ((self._vm.lastStatus in ('Down',
- 'Saving State', 'Migration Source'))
-or self._vm.destroyed
-or self._vm._guestEvent == 'Powering down'):
-return True
-
-self._log.debug(VM not found, moving to Down, exc_info=True)
-self._vm.setDownStatus(ERROR, str(ex))
-
return True
--
To view, visit http://gerrit.ovirt.org/7746
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f648b9e3a70dca66cbf056c1f143bc6f0455e4a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Gal Hammer has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...
Gal Hammer has posted comments on this change. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Gal Hammer has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...
Gal Hammer has posted comments on this change. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. Patch Set 1: (1 inline comment) File vdsm/libvirtvm.py Line 2438: # Libvirt sometimes send the SUSPENDED/SUSPENDED_PAUSED event Line 2439: # after RESUMED/RESUMED_MIGRATED (when VM status is PAUSED Line 2440: # when migration completes, see qemuMigrationFinish function). Line 2441: # In this case self._dom is None because the function Line 2442: # _waitForIncomingMigrationFinish didn't update it yet. (I can delete it then...) Yes. This is what I understand from reading the qemuMigrationFinish function code. I assume that qemu pause the VM in order to finalize the migration process and *something* libvirt is fast enough to catch this state. Line 2443: if self._dom: Line 2444: hooks.after_vm_pause(self._dom.XMLDesc(0), self.conf) Line 2445: elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED: Line 2446: self._guestCpuRunning = True -- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#845994 VM failed to start after file injection.
Gal Hammer has posted comments on this change. Change subject: BZ#845994 VM failed to start after file injection. .. Patch Set 3: (2 inline comments) File vdsm_hooks/fileinject/before_vm_start.py Line 4: import sys Line 5: import hooking Line 6: import traceback Line 7: import guestfs Line 8: import tempfile Done Line 9: Line 10: ''' Line 11: fileinject vdsm hook Line 12: Line 23: syntax: Line 24: fileinject=/target file name : file content Line 25: fileinject=/myfile:some file content\netc... Line 26: ''' Line 27: Done Line 28: def inject_file(filepath, content, drive, diskformat): Line 29: injected = False Line 30: gfs = guestfs.GuestFS() Line 31: try: -- To view, visit http://gerrit.ovirt.org/6956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb705a7153b1d2662a1c1135c694c568cabd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#845994 VM failed to start after file injection.
Gal Hammer has posted comments on this change. Change subject: BZ#845994 VM failed to start after file injection. .. Patch Set 4: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb705a7153b1d2662a1c1135c694c568cabd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report host hyperthreads as real cores
Gal Hammer has posted comments on this change. Change subject: Report host hyperthreads as real cores .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I950c1ce84933204b2d33844c3b3d9485667581af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetworkTests: use context to manage monkey patches
Gal Hammer has posted comments on this change. Change subject: configNetworkTests: use context to manage monkey patches .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ecb4589f2edbf605e62a8963889d314c2535537 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rename xml.dom.minidom.parseString to _domParseStr in libvir...
Gal Hammer has posted comments on this change. Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#842771 Fix for exception TypeError: cannot marshal None
Gal Hammer has posted comments on this change. Change subject: BZ#842771 Fix for exception TypeError: cannot marshal None .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I873eff7541016609d81eea0a1b16613f214fcb70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#845994 VM failed to start after file injection.
Gal Hammer has posted comments on this change.
Change subject: BZ#845994 VM failed to start after file injection.
..
Patch Set 2: (3 inline comments)
File vdsm_hooks/fileinject/before_vm_start.py
Line 34: sys.stderr.write('fileinject: [error in inject_file]: %s\n' %
e)
I preferred not to change the function's behavior too much in one patch. The
calling code expect the inject_file function not to fail and return a boolean
value.
Line 46: try:
Done
Line 50: gfs.upload(temp.name, filepath)
Done. I've used the existing code and not too familiar with the GuestFS
library's functions.
--
To view, visit http://gerrit.ovirt.org/6956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb705a7153b1d2662a1c1135c694c568cabd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#845994 VM failed to start after file injection.
Gal Hammer has uploaded a new change for review. Change subject: BZ#845994 VM failed to start after file injection. .. BZ#845994 VM failed to start after file injection. The before_vm_start hook created a file inside the guest's image file using the GuestFS library. The image was not unmounted explicitly and this caused libvirt to fail when it tried to read the image file. Change-Id: Ibb705a7153b1d2662a1c1135c694c568cabd Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm_hooks/fileinject/before_vm_start.py 1 file changed, 25 insertions(+), 37 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/6956/1 -- To view, visit http://gerrit.ovirt.org/6956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb705a7153b1d2662a1c1135c694c568cabd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#845994 VM failed to start after file injection.
Gal Hammer has posted comments on this change. Change subject: BZ#845994 VM failed to start after file injection. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/6956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb705a7153b1d2662a1c1135c694c568cabd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#841555 A migration failure with an AttributeError excep...
Gal Hammer has uploaded a new change for review. Change subject: BZ#841555 A migration failure with an AttributeError exception. .. BZ#841555 A migration failure with an AttributeError exception. Libvirt sometimes send the SUSPENDED/SUSPENDED_PAUSED event after RESUMED/RESUMED_MIGRATED (when VM status is PAUSED when migration completes, see qemuMigrationFinish function). In this case self._dom is None because the function _waitForIncomingMigrationFinish didn't update it yet. Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/6901/1 -- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#842771 Fix for exception TypeError: cannot marshal None
Gal Hammer has uploaded a new change for review. Change subject: BZ#842771 Fix for exception TypeError: cannot marshal None .. BZ#842771 Fix for exception TypeError: cannot marshal None The VM's mirror and mirrorPath properties had a value of None rather than an empty string. Change-Id: I873eff7541016609d81eea0a1b16613f214fcb70 Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/6909/1 -- To view, visit http://gerrit.ovirt.org/6909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I873eff7541016609d81eea0a1b16613f214fcb70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a channel in vdsm for introducing qemu-ga
Gal Hammer has posted comments on this change. Change subject: Add a channel in vdsm for introducing qemu-ga .. Patch Set 14: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added a support for a guest hibernate command.
Gal Hammer has posted comments on this change. Change subject: Added a support for a guest hibernate command. .. Patch Set 7: (1 inline comment) File vdsm/BindingXMLRPC.py Line 322: def vmHibernate(self, vmId, target='disk'): Done -- To view, visit http://gerrit.ovirt.org/1121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Related to BZ#843387 - Payload should set volPath or raise.
Gal Hammer has posted comments on this change. Change subject: Related to BZ#843387 - Payload should set volPath or raise. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d5b36a88752ad2191226191c9502c1717033bbc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Related to BZ#843387 - Payload should set volPath or raise.
Gal Hammer has posted comments on this change. Change subject: Related to BZ#843387 - Payload should set volPath or raise. .. Patch Set 2: Looks good to me, but someone else must approve I think that the try's else is redundant but I don't mind if you keep it. -- To view, visit http://gerrit.ovirt.org/6803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d5b36a88752ad2191226191c9502c1717033bbc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a channel in vdsm for introducing qemu-ga
Gal Hammer has posted comments on this change. Change subject: Add a channel in vdsm for introducing qemu-ga .. Patch Set 13: Fails; I would prefer that you didn't submit this (1 inline comment) Please fix the code and +1 Verify if it works (qemu starts running with two virtio-serial channels). Thanks. File vdsm/libvirtvm.py Line 1232: vm.Vm._cleanup() vm.Vm._cleanup(self) -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a channel in vdsm for introducing qemu-ga
Gal Hammer has posted comments on this change. Change subject: Add a channel in vdsm for introducing qemu-ga .. Patch Set 13: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a channel in vdsm for introducing qemu-ga
Gal Hammer has posted comments on this change. Change subject: Add a channel in vdsm for introducing qemu-ga .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Gal Hammer has uploaded a new change for review. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Change waitForMigrationDestinationPrepare function waiting. The change is to avoid timeouts during migration of several VMs at once. The new implementation doesn't start the timer until the VM starts it creation (e.g. acquired the _ongoingCreations lock). Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm/libvirtvm.py M vdsm/vm.py 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/6396/1 -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change source of CPU sockets/cores to /sys and add cpuThre...
Gal Hammer has posted comments on this change.
Change subject: Change source of CPU sockets/cores to /sys and add cpuThreads.
..
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
File vdsm/caps.py
Line 83: findregex = re.compile('^cpu[0-9]+')
Do you need to compile the regex each time? (e.g. Can you put it outside the
for loop?).
Using something like this could save you some ifs and nested code:
re = re.compile('^cpu[0-9]+')
cpu_dirs = [ f for f in os.listdir(/sys/devices/system/cpu/) if re.match(f) ]
Line 94: ## 0-7,64-71
I'm not sure but I think you can handle all these cases with one regular
expression.
Line 105:
This code looks similar (the csl and tsl calc). Can you join it to a function?
Line 116: except:
Please log the exception.
Also can you please write which exception are expected? Without that even
Python's syntax errors will silencelly get discarded.
--
To view, visit http://gerrit.ovirt.org/5481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 7: Looks good to me, but someone else must approve (1 inline comment) File vdsm/vm.py Line 857: elif self.guestAgent and self.guestAgent.isResponsive(): I don't agree with this code either. But I do prefer not to review it in this patch. I really prefer to have two patches for this feature. One that add the channel and a second that add the shutdown though qemu ga. -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 7: I would prefer that you didn't submit this Ops. Gave it +1 by mistake. See my comment about splitting the patch to two in previous review. -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 2: I would prefer that you didn't submit this (4 inline comments) I think that the code that handle the qga and qga's shutdown should only be in libvirtvm. I'm not sure if we still support running a vm without libvirt (Dan?) but since the code call libvirt functions it should not be in the vm.Vm class. File vdsm/libvirtvm.py Line 748: target type='virtio' name=name / Changing this line is redundant. This is an example on how a name might look like. File vdsm/vm.py Line 299: '.qemu.guest.socket' This should moved to libvirtvm. The channel is used only with libvirt+qga. Line 867: self._qemugaShutdown() Should be in libvirtvm as well. Line 916: utils.rmFile(self._qemuguestSocketFile) Should be in libvirtvm as well. -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 2: (1 inline comment) File vdsm/vm.py Line 299: '.qemu.guest.socket' *A* socket can be used without libvirt. But this is a *specific* socket that libvirt own (based on the socket's name). You don't need to move everything. libvirtvm class inherit from vm class so it can use its methods. -- To view, visit http://gerrit.ovirt.org/5640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#737104 Disallow cross-vendor virtualization.
Gal Hammer has posted comments on this change. Change subject: BZ#737104 Disallow cross-vendor virtualization. .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/5035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id52f757971e28058257d819036e58e0f1925c44d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: additional capsTests
Gal Hammer has posted comments on this change. Change subject: additional capsTests .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#737104 Disallow cross-vendor virtualization.
Gal Hammer has posted comments on this change. Change subject: BZ#737104 Disallow cross-vendor virtualization. .. Patch Set 2: (4 inline comments) Commit Message Line 8: Done File vdsm/caps.py Line 109: cpu_map = minidom.parseString( Done Line 120: # If current model doesn't have a vendor, check if it have a model Done Line 146: in allModels.items() if compatible(model, vendor) ] Done -- To view, visit http://gerrit.ovirt.org/5035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id52f757971e28058257d819036e58e0f1925c44d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#737104 Disallow cross-vendor virtualization.
Gal Hammer has uploaded a new change for review. Change subject: BZ#737104 Disallow cross-vendor virtualization. .. BZ#737104 Disallow cross-vendor virtualization. Change-Id: Id52f757971e28058257d819036e58e0f1925c44d Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm/caps.py 1 file changed, 19 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/5035/1 -- To view, visit http://gerrit.ovirt.org/5035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id52f757971e28058257d819036e58e0f1925c44d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: additional capsTests
Gal Hammer has posted comments on this change. Change subject: additional capsTests .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: require updated libvirt for USB support
Gal Hammer has posted comments on this change. Change subject: vdsm: require updated libvirt for USB support .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee1ba361b795d503d52927eac38feb583dce2e6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove /rhel/data-center after vdsm uninstalled
Gal Hammer has posted comments on this change. Change subject: remove /rhel/data-center after vdsm uninstalled .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27a697a5aa7cc3ebade7937ea6f6a293d6778168 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for redir devices
Gal Hammer has posted comments on this change. Change subject: Add support for redir devices .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia91922a0f34cb4b32efa2c6397d13fe59aec04e7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede hdego...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Hans De Goede hdego...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm.py: Refactor device xml generation
Gal Hammer has posted comments on this change. Change subject: libvirtvm.py: Refactor device xml generation .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e1c5a2d0998af38fa80d53975b0e528b9257a6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede hdego...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Hans De Goede hdego...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rest-api: Model VMs
Gal Hammer has posted comments on this change. Change subject: rest-api: Model VMs .. Patch Set 6: I would prefer that you didn't submit this (4 inline comments) I didn't look at the code yet as I think that the REST api (as explained in the commit message) should be defined first. Commit Message Line 16: - Create a new VM and launch it It should be: POST /api/vms data needed to create a vm Line 24: - Assign a connection password for the VM's display I would add a action (or something) to all the these paths: /api/vms/id/action/ticket Line 32: POST /api/vms/id/nics/add - Add a NIC POST /api/vms/id/disks POST /api/vms/id/cdroms POST /api/vms/id/nics Line 41: all sub-collections inline. I don't think this is a deviation from the REST model. Since a creation of a VM requires all its hardware, you can't create a new VM resource unless you provide all the information. After the VM was created and started, one can use the VM's URL and modify or query its hardware profile. -- To view, visit http://gerrit.ovirt.org/3756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibed650a0215e7d841f5af0dd5f111a3e4a27ecf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rest-api: Model VMs
Gal Hammer has posted comments on this change. Change subject: rest-api: Model VMs .. Patch Set 6: (1 inline comment) Commit Message Line 16: - Create a new VM and launch it Are you sure it is apply to vm creation as well? -- To view, visit http://gerrit.ovirt.org/3756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibed650a0215e7d841f5af0dd5f111a3e4a27ecf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: additional capsTests
Gal Hammer has posted comments on this change. Change subject: additional capsTests .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove /rhel/data-center after vdsm uninstalled
Gal Hammer has posted comments on this change. Change subject: remove /rhel/data-center after vdsm uninstalled .. Patch Set 5: Why not to use %attr(0775, vdsm, qemu) in the spec file to create the directory with a specific owner? -- To view, visit http://gerrit.ovirt.org/4026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27a697a5aa7cc3ebade7937ea6f6a293d6778168 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm.py: Refactor device xml generation
Gal Hammer has posted comments on this change. Change subject: libvirtvm.py: Refactor device xml generation .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Looks okay, other than a minor comment. File vdsm/libvirtvm.py Line 838: if not hasattr(self, attrName): nit: I would prefer to see a if hasattr condition rather than a continue. -- To view, visit http://gerrit.ovirt.org/4132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e1c5a2d0998af38fa80d53975b0e528b9257a6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede hdego...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Hans De Goede hdego...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove /rhel/data-center after vdsm unstalled
Gal Hammer has posted comments on this change. Change subject: remove /rhel/data-center after vdsm unstalled .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) Commit Message Line 7: remove /rhel/data-center after vdsm unstalled typo: uninstalled. -- To view, visit http://gerrit.ovirt.org/4026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27a697a5aa7cc3ebade7937ea6f6a293d6778168 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added a support for a guest hibernate command.
Gal Hammer has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 5: (8 inline comments)
File vdsm/API.py
Line 408: def guestHibernate(self, state='disk'):
The name hibernate for the function is already un used by the hibernate
function.
Dan rejected my offer to add the S4 feature the existing hibernate function.
The values are defined in the vdsClient.py file.
File vdsm/BindingXMLRPC.py
Line 330: def vmGuestHibernate(self, vmId, state='disk'):
Like the one on line 326?
Line 330: def vmGuestHibernate(self, vmId, state='disk'):
See vdsClient.py for the allowed values.
The name state come from the Windows' API SetSystemState that put the guest
into S4.
Line 755: (self.vmGuestHibernate, 'guestHibernate'),
(self.vmHibernate, 'hibernate'), ... already in use.
File vdsm_cli/vdsClient.py
Line 57: # Guest Hibernate
Don't you just love them? :-)
Line 59: HIBERNATE_DEFAULT = 'disk'
I don't see that API.py is used in vdsClient.py.
File vdsm/vm.py
Line 850: return self._shutdownCommand('Powering down', int(timeout),
The casting to int was the exiting code (including the config.getint). So I saw
no reason to change it in this patch.
Line 854: def hibernate(self, state='disk'):
I just follow the same naming convernsion as other commands like shutdown (and
not guestShutdown).
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Haim Ateya hat...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: A new method to read from VMs' channels.
Gal Hammer has posted comments on this change. Change subject: A new method to read from VMs' channels. .. Patch Set 10: (5 inline comments) File vdsm/vmChannels.py Line 65: self.log.exception(Exception on timeout callback.) No need. The log.exception include the back trace. Line 93: try: Done Line 108: if obj['connect_cb'](obj['opaque']) == True: Done Line 115: self.log.exception(Exception on connect callback.) The log.exception include the back trace. Same as exc_info=True, but much nicer (to my opinion). Line 148: try: Done -- To view, visit http://gerrit.ovirt.org/869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added an option to create a memory balloon device.
Gal Hammer has posted comments on this change. Change subject: Added an option to create a memory balloon device. .. Patch Set 6: (1 inline comment) File vdsm/libvirtvm.py Line 1258: for dev in devices[devType]: Nice. But the question is how is it possible not to pass a balloon device? The code in in vm.py check if no balloon device exists and create one with a 'none' type. -- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added an option to create a memory balloon device.
Gal Hammer has posted comments on this change.
Change subject: Added an option to create a memory balloon device.
..
Patch Set 3: (1 inline comment)
File vdsm/vm.py
Line 422: devices[BALLOON_DEVICES].append({'type':
CONTROLLER_DEVICES,
A copypaste typo. Fixed.
--
To view, visit http://gerrit.ovirt.org/1573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added an option to create a memory balloon device.
Gal Hammer has posted comments on this change.
Change subject: Added an option to create a memory balloon device.
..
Patch Set 5: (4 inline comments)
File vdsm/libvirtvm.py
Line 1885: xml = xml.dom.minidom.parseString(self._lastXMLDesc) \
Done
Line 1887: .getElementsByTagName('memballon')
Done
File vdsm/vm.py
Line 423: 'device': 'memballon', 'model': 'none'})
Done
Line 424:
Done
--
To view, visit http://gerrit.ovirt.org/1573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: A new method to read from VMs' channels.
Gal Hammer has posted comments on this change. Change subject: A new method to read from VMs' channels. .. Patch Set 2: (3 inline comments) File vdsm/clientIF.py Line 119: self.channelListener = Listener(self.log) Yes. It it accessible by all guestIF instances. This is not a singleton. File vdsm/vmChannels.py Line 59: now = int(time.time()) Because I don't care about milliseconds resolution? Line 111: read_callback, timeout_callback, param) Sure it does. I don't see it now. Is changing the param to opaque is good enough? -- To view, visit http://gerrit.ovirt.org/869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: A new method to read from VMs' channels.
Gal Hammer has uploaded a new change for review. Change subject: A new method to read from VMs' channels. .. A new method to read from VMs' channels. Replaced having a thread-per-VM that monitor and read from the VM's virtual channel with a 1-thread listener that handle all VMs' channels. Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc --- M vdsm.spec.in M vdsm/Makefile.am M vdsm/clientIF.py M vdsm/guestIF.py M vdsm/libvirtvm.py A vdsm/vmChannels.py 6 files changed, 164 insertions(+), 69 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/869/1 -- To view, visit http://gerrit.ovirt.org/869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
