Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 11: Verified+1 Functional tests works on my server. -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add IPv6 support to configNetwork .. Add IPv6 support to configNetwork This patch add IPv6 functionality to network configuration. We want to run every device as dual stack device so IPConfig now uses IPv4 AND IPv6(or one of them). This patch was built on Hunt Xu's patch 11741. Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Signed-off-by: Petr Sebek pse...@redhat.com Reviewed-on: http://gerrit.ovirt.org/18284 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/networkTests.py M vdsm/configNetwork.py M vdsm/netconf/__init__.py M vdsm/netconf/ifcfg.py M vdsm/netmodels.py 5 files changed, 173 insertions(+), 35 deletions(-) Approvals: Petr Šebek: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Dan Kenigsberg has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 11: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 9:
(3 comments)
File vdsm/sourceRoute.py
Line 49: self.rules = None
Line 50:
Line 51: def _generateTableId(self):
Line 52: #TODO: Future proof for IPv6
Line 53: return netaddr.IPAddress(self.ipaddr.split('/')[0]).value
Dan: I used it because ipv6 address is usually in form address[/prefixlen].
Assaf: Ok, I didn't understand that comment so I just tried something. I will
think about some solution how to assign 32b number to ipv6 address.
Line 54:
Line 55: def _buildRoutes(self):
Line 56: return [Route(network='0.0.0.0/0', ipaddr=self.gateway,
Line 57: device=self.device, table=self.table),
Line 93: def remove(self):
Line 94: self.configurator.removeSourceRoute(None, None, self.device)
Line 95:
Line 96:
Line 97: class StaticIPv6SourceRoute(StaticSourceRoute):
Dan: Currently there is not working setting gateway to nics. I had to add
source route adding for ipv6 to netconf/__init__.py. I thought it will be
easier to add new more specific class than add some conditions to original
StaticSourceRoute class. Anyway, it still does not set the gateway :(.
Assaf: I will think about it.
Line 98: def __init__(self, device, configurator):
Line 99: super(StaticIPv6SourceRoute, self).__init__(device,
configurator)
Line 100:
Line 101: def _buildRoutes(self):
Line 110: return
Line 111:
Line 112: addr = ipaddr.split('/')
Line 113: self.ipaddr = addr[0]
Line 114: self.prefixlen = addr[1] if len(addr) 1 else '0'
Currently for nothing. I had to split it because netaddr.IPAddress does not
accept ipaddr[/prefixlen] but just ipaddr.
Line 115: self.gateway = gateway.split('/')[0]
Line 116: self.table = self._generateTableId()
Line 117: self.network = ipaddr
Line 118:
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 10: Verified+1 It passes all functional tests at my server. -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/708/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5019/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5093/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5019/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5093/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/709/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5019/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5093/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/710/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5019/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5093/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/711/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5020/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4216/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5094/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/712/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5062/ : ABORTED http://jenkins.ovirt.org/job/vdsm_network_functional_tests/706/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4988/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4181/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5063/ : ABORTED http://jenkins.ovirt.org/job/vdsm_network_functional_tests/707/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4989/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4182/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Dan Kenigsberg has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 9: Code-Review-1
(3 comments)
File vdsm/sourceRoute.py
Line 49: self.rules = None
Line 50:
Line 51: def _generateTableId(self):
Line 52: #TODO: Future proof for IPv6
Line 53: return netaddr.IPAddress(self.ipaddr.split('/')[0]).value
I could use a comment about this change. Why is it needed? How is it harmless
to former use cases?
Line 54:
Line 55: def _buildRoutes(self):
Line 56: return [Route(network='0.0.0.0/0', ipaddr=self.gateway,
Line 57: device=self.device, table=self.table),
Line 93: def remove(self):
Line 94: self.configurator.removeSourceRoute(None, None, self.device)
Line 95:
Line 96:
Line 97: class StaticIPv6SourceRoute(StaticSourceRoute):
could you explain why this class is urgently required?
Line 98: def __init__(self, device, configurator):
Line 99: super(StaticIPv6SourceRoute, self).__init__(device,
configurator)
Line 100:
Line 101: def _buildRoutes(self):
Line 110: return
Line 111:
Line 112: addr = ipaddr.split('/')
Line 113: self.ipaddr = addr[0]
Line 114: self.prefixlen = addr[1] if len(addr) 1 else '0'
why do we need self.prefixlen? why is it a string?
Line 115: self.gateway = gateway.split('/')[0]
Line 116: self.table = self._generateTableId()
Line 117: self.network = ipaddr
Line 118:
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Assaf Muller has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 9: Verified-1 Code-Review-1
(2 comments)
New generateTableId won't work for IPv6 addresses whose value representation is
over (2 ** 32) - 1.
File vdsm/sourceRoute.py
Line 49: self.rules = None
Line 50:
Line 51: def _generateTableId(self):
Line 52: #TODO: Future proof for IPv6
Line 53: return netaddr.IPAddress(self.ipaddr.split('/')[0]).value
netaddr.IPAddress supports both IPv4 and IPv6. self.ipaddr should be the ip
address both for IPv4 and IPv6 without the netmask so I am unclear why the
split is needed.
For IPv6 this won't work as the value can be a number requiring more than 32
bits and the table ID must be represented by 32 bits or less. (This is the
reason for the TODO comment) - We need a clever-er solution than just getting
the value :)
Line 54:
Line 55: def _buildRoutes(self):
Line 56: return [Route(network='0.0.0.0/0', ipaddr=self.gateway,
Line 57: device=self.device, table=self.table),
Line 93: def remove(self):
Line 94: self.configurator.removeSourceRoute(None, None, self.device)
Line 95:
Line 96:
Line 97: class StaticIPv6SourceRoute(StaticSourceRoute):
Seems like there's a decent amount of code duplication, is there a way to share
more code with the base class?
Line 98: def __init__(self, device, configurator):
Line 99: super(StaticIPv6SourceRoute, self).__init__(device,
configurator)
Line 100:
Line 101: def _buildRoutes(self):
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 6:
(1 comment)
File tests/functional/networkTests.py
Line 1424: {'nic': nic, 'bootproto': 'static', 'ipv6addr':
IPv6_ADDRESS,
Line 1425: 'ipv6gateway': IPv6_GATEWAY, 'ipaddr': IP_ADDRESS,
Line 1426: 'gateway': IP_GATEWAY,
Line 1427: 'netmask': prefix2netmask(int(IP_CIDR))}}
Line 1428: for network in networks:
You are right.
Line 1429: with self.vdsm_net.pinger():
Line 1430: status, msg = self.vdsm_net.setupNetworks(
Line 1431: {network: networks[network]}, {}, {})
Line 1432: self.assertEqual(status, SUCCESS, msg)
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 7: Verified-1 Fixed bug with not showing IPv6 related attributes in ipconfig and ifcfg file. But there is still no ipv6addrs when run getVdsCaps, what is generated using ethtool. Maybe there is some problem with ifcfg file. -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4975/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4089/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4899/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/691/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Dan Kenigsberg has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 6: Code-Review+1
(1 comment)
File tests/functional/networkTests.py
Line 1424: {'nic': nic, 'bootproto': 'static', 'ipv6addr':
IPv6_ADDRESS,
Line 1425: 'ipv6gateway': IPv6_GATEWAY, 'ipaddr': IP_ADDRESS,
Line 1426: 'gateway': IP_GATEWAY,
Line 1427: 'netmask': prefix2netmask(int(IP_CIDR))}}
Line 1428: for network in networks:
for network, netdict in networks.iteritems()
is more stylish.
Line 1429: with self.vdsm_net.pinger():
Line 1430: status, msg = self.vdsm_net.setupNetworks(
Line 1431: {network: networks[network]}, {}, {})
Line 1432: self.assertEqual(status, SUCCESS, msg)
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/659/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4848/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3963/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 6: Verified-1 Added functional test but it fails, need to fix. Don't know why connection refused in those other failing tests, though. -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Dan Kenigsberg has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 5: Code-Review-1 reminder: add functional tests. -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 4:
(2 comments)
File vdsm/netmodels.py
Line 407: class IpConfig(object):
Line 408: ipConfig = namedtuple('ipConfig', ['ipaddr', 'netmask', 'gateway',
Line 409:'defaultRoute', 'ipv6addr',
Line 410:'ipv6gateway',
'ipv6defaultRoute',
Line 411:'bootproto', 'async',
'ipv6autoconf',
Fixed
Line 412:'dhcpv6'])
Line 413:
Line 414: def __init__(self, inet4=None, inet6=None, bootproto=None,
blocking=False,
Line 415: ipv6autoconf=None, dhcpv6=None):
Line 411:'bootproto', 'async',
'ipv6autoconf',
Line 412:'dhcpv6'])
Line 413:
Line 414: def __init__(self, inet4=None, inet6=None, bootproto=None,
blocking=False,
Line 415: ipv6autoconf=None, dhcpv6=None):
You are right that was the problem. Now I pass both configuration even if it
has only None values.
Line 416: if inet4 is None and inet6 is None:
Line 417: raise ConfigNetworkError(ne.ERR_BAD_ADDR, 'You need to
specify '
Line 418: 'IPv4 or IPv6 or both address.')
Line 419: if ((inet4 and inet4.address and bootproto == 'dhcp') or
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_network_functional_tests/653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4809/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3924/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 2: (2 comments) File vdsm/configNetwork.py Line 471: ipaddr=ip Line 472: netmask=ip Line 473: gateway=ip Line 474: bootproto=... Line 475: ipv6addr=ip[/prefixlen] Done Line 476: ipv6gateway=ip Line 477: ipv6autoconf=0|1 Line 478: dhcpv6=0|1 Line 479: delay=... File vdsm/netmodels.py Line 43: raise NotImplementedError Line 44: Line 45: @property Line 46: def ipConfig(self): Line 47: return self.ip.getConfig() I put it back. Line 48: Line 49: @property Line 50: def bridge(self): Line 51: if isinstance(self.master, Bridge): -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/641/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4671/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4747/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3862/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 3: Code-Review-1 TODO add functional tests. Tests will be little incomplete, though. Functional tests with dummy nic can't use dhcp, static addressing, (I suppose that ipv6autoconf won't work either), theres not much to test. -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/642/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4748/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3863/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Dan Kenigsberg has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 4:
(1 comment)
Are the func tests failure real?
File vdsm/netmodels.py
Line 407: class IpConfig(object):
Line 408: ipConfig = namedtuple('ipConfig', ['ipaddr', 'netmask', 'gateway',
Line 409:'defaultRoute', 'ipv6addr',
Line 410:'ipv6gateway',
'ipv6defaultRoute',
Line 411:'bootproto', 'async',
'ipv6autoconf',
doublespace
Line 412:'dhcpv6'])
Line 413:
Line 414: def __init__(self, inet4=None, inet6=None, bootproto=None,
blocking=False,
Line 415: ipv6autoconf=None, dhcpv6=None):
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Assaf Muller has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 4: Verified-1 (1 comment) They are. I explained in an inline comment. File vdsm/netmodels.py Line 411:'bootproto', 'async', 'ipv6autoconf', Line 412:'dhcpv6']) Line 413: Line 414: def __init__(self, inet4=None, inet6=None, bootproto=None, blocking=False, Line 415: ipv6autoconf=None, dhcpv6=None): It used to be valid for the ipaddr, netmask, gateway and bootproto fields to be None (For example if from the webadmin you choose None as the boot proto). Now you raise an exception if you didn't get an ip configuration, which is the reason that the functional tests are failing. Most functional tests we don't pass it in an ip configuration. Line 416: if inet4 is None and inet6 is None: Line 417: raise ConfigNetworkError(ne.ERR_BAD_ADDR, 'You need to specify ' Line 418: 'IPv4 or IPv6 or both address.') Line 419: if ((inet4 and inet4.address and bootproto == 'dhcp') or -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Dan Kenigsberg has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 2: Code-Review-1 (2 comments) Please include a test or two for the added functionality. File vdsm/configNetwork.py Line 471: ipaddr=ip Line 472: netmask=ip Line 473: gateway=ip Line 474: bootproto=... Line 475: ipv6addr=ip[/prefixlen] better say here explicitly that an ipv6 address is expected, and that ipaddr is ipv4. Line 476: ipv6gateway=ip Line 477: ipv6autoconf=0|1 Line 478: dhcpv6=0|1 Line 479: delay=... File vdsm/netmodels.py Line 43: raise NotImplementedError Line 44: Line 45: @property Line 46: def ipConfig(self): Line 47: return self.ip.getConfig() why have you dropped the try-except? self.ip may still be None if I'm not mistaken. Line 48: Line 49: @property Line 50: def bridge(self): Line 51: if isinstance(self.master, Bridge): -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4022/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3133/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3940/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Antoni Segura Puimedon has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 2: Code-Review-1 (2 comments) The present comments plus the ifcfg and netmodels of the previous patchset require action. File vdsm/netconf/ifcfg.py Line 478: if ipv6gateway is not None: Line 479: cfg += 'IPV6_DEFAULTGW=%s\n' % pipes.quote(ipv6gateway) Line 480: elif dhcpv6: Line 481: cfg += 'DHCPV6C=yes\n' Line 482: if ipv6autoconf: Is this if necessary? Either we have this if and then the following line assigns yes always, or we drop it and keep the if else of the following line. Line 483: cfg += 'IPV6_AUTOCONF=%s\n' % 'yes' if ipv6autoconf else 'no' Line 484: BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'bondingOptions', Line 485: 'force', 'blockingdhcp', Line 486: 'connectivityCheck', 'connectivityTimeout', Line 499: conf = 'TYPE=Bridge\nDELAY=%s\n' % bridge.forwardDelay Line 500: self._createConfFile(conf, bridge.name, ipconfig.ipaddr, Line 501: ipconfig.netmask, ipconfig.gateway, Line 502: ipconfig.bootproto, bridge.mtu, Line 503: self._toIfcfgFormat(self.defaultRoute), This is not fixed. See my comment on the previous patchset. Line 504: **opts) Line 505: Line 506: def addVlan(self, vlan, **opts): Line 507: Create ifcfg-* file with proper fields for VLAN -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 2: (1 comment) File vdsm/netconf/ifcfg.py Line 478: if ipv6gateway is not None: Line 479: cfg += 'IPV6_DEFAULTGW=%s\n' % pipes.quote(ipv6gateway) Line 480: elif dhcpv6: Line 481: cfg += 'DHCPV6C=yes\n' Line 482: if ipv6autoconf: Yes I forgot it there. Line 483: cfg += 'IPV6_AUTOCONF=%s\n' % 'yes' if ipv6autoconf else 'no' Line 484: BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'bondingOptions', Line 485: 'force', 'blockingdhcp', Line 486: 'connectivityCheck', 'connectivityTimeout', -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has uploaded a new change for review. Change subject: Add IPv6 support to configNetwork .. Add IPv6 support to configNetwork This patch add IPv6 functionality to network configuration. We want to run every device as dual stack device so IPConfig now uses IPv4 AND IPv6(or one of them). This patch was built on Hunt Xu's patch 11741. Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Signed-off-by: Petr Sebek pse...@redhat.com --- M vdsm/configNetwork.py M vdsm/netconf/ifcfg.py M vdsm/netmodels.py 3 files changed, 157 insertions(+), 65 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/18284/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 155d22a..ac458ed 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -35,6 +35,7 @@ from netmodels import Bond from netmodels import Bridge from netmodels import IPv4 +from netmodels import IPv6 from netmodels import IpConfig from netmodels import Nic from netmodels import Vlan @@ -45,6 +46,8 @@ def objectivizeNetwork(bridge=None, vlan=None, bonding=None, bondingOptions=None, nics=None, mtu=None, ipaddr=None, netmask=None, gateway=None, bootproto=None, + ipv6addr=None, ipv6gateway=None, ipv6autoconf=None, + dhcpv6=None, _netinfo=None, configurator=None, blockingdhcp=None, implicitBonding=None, defaultRoute=None, **opts): @@ -61,6 +64,10 @@ :param netmask: IPv4 mask in dotted decimal format. :param gateway: IPv4 address in dotted decimal format. :param bootproto: protocol for getting IP config for the net, e.g., 'dhcp' +:param ipv6addr: IPv6 address in format address[/prefixlen]. +:param ipv6gateway: IPv6 address in format address[/prefixlen]. +:param ipv6autoconf: whether to use stateless autoconfiguration. +:param dhcpv6: whether to use DHCPv6. :param _netinfo: network information snapshot. :param configurator: instance to use to apply the network configuration. :param blockingdhcp: whether to acquire dhcp IP config in a synced manner. @@ -103,9 +110,18 @@ if topNetDev is None: raise ConfigNetworkError(ne.ERR_BAD_PARAMS, 'Network defined without' 'devices.') -topNetDev.ip = IpConfig(inet=IPv4(ipaddr, netmask, gateway, defaultRoute), -bootproto=bootproto, -blocking=utils.tobool(blockingdhcp)) +if ipv6addr is not None: +ipv6 = IPv6(ipv6addr, ipv6gateway, defaultRoute) +else: +ipv6 = None + +if ipaddr is not None: +ipv4 = IPv4(ipaddr, netmask, gateway, defaultRoute) +else: +ipv4 = None +topNetDev.ip = IpConfig(inet4=ipv4, inet6=ipv6, bootproto=bootproto, +blocking=utils.tobool(blockingdhcp), +ipv6autoconf=ipv6autoconf, dhcpv6=dhcpv6) return topNetDev @@ -150,7 +166,8 @@ def addNetwork(network, vlan=None, bonding=None, nics=None, ipaddr=None, - netmask=None, prefix=None, mtu=None, gateway=None, force=False, + netmask=None, prefix=None, mtu=None, gateway=None, + ipv6addr=None, ipv6gateway=None, force=False, configurator=None, bondingOptions=None, bridged=True, _netinfo=None, qosInbound=None, qosOutbound=None, **options): nics = nics or () @@ -199,7 +216,8 @@ netEnt = objectivizeNetwork(network if bridged else None, vlan, bonding, bondingOptions, nics, mtu, ipaddr, netmask, -gateway, bootproto, _netinfo, configurator, +gateway, bootproto, ipv6addr, ipv6gateway, +_netinfo=_netinfo, configurator=configurator, defaultRoute=defaultRoute, **options) netEnt.configure(**options) diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py index 8fafbd0..0d50a06 100644 --- a/vdsm/netconf/ifcfg.py +++ b/vdsm/netconf/ifcfg.py @@ -446,7 +446,8 @@ return 'yes' if defaultRoute else 'no' def _createConfFile(self, conf, name, ipaddr=None, netmask=None, -gateway=None, bootproto=None, mtu=None, +gateway=None, bootproto=None, mtu=None, ipv6addr=None, +ipv6gateway=None, ipv6autoconf=None, dhcpv6=None, defaultRoute=None, onboot='yes', **kwargs): Create ifcfg-* file with proper fields per device cfg = self.CONFFILE_HEADER + '\n' @@ -470,6 +471,18 @@ if defaultRoute: cfg = cfg + 'DEFROUTE=%s\n' % defaultRoute cfg += 'NM_CONTROLLED=no\n' +if ipv6addr or ipv6gateway or ipv6autoconf or dhcpv6: +cfg +=
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4009/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3926/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3120/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4009/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3120/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3927/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Antoni Segura Puimedon has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 1: Code-Review-1 (17 comments) And we should have unit tests for the new netmodels parts, probably also for the configNetworks one. File vdsm/configNetwork.py Line 47:bondingOptions=None, nics=None, mtu=None, ipaddr=None, Line 48:netmask=None, gateway=None, bootproto=None, Line 49:ipv6addr=None, ipv6gateway=None, ipv6autoconf=None, Line 50:dhcpv6=None, Line 51:_netinfo=None, configurator=None, blockingdhcp=None, Please, reformat this so the almost empty line ends up the last one. Line 52:implicitBonding=None, defaultRoute=None, **opts): Line 53: Line 54: Constructs an object hierarchy that describes the network configuration Line 55: that is passed in the parameters. Line 65: :param gateway: IPv4 address in dotted decimal format. Line 66: :param bootproto: protocol for getting IP config for the net, e.g., 'dhcp' Line 67: :param ipv6addr: IPv6 address in format address[/prefixlen]. Line 68: :param ipv6gateway: IPv6 address in format address[/prefixlen]. Line 69: :param ipv6autoconf: whether to use stateless autoconfiguration. s/whether to use stateless autoconfiguration/whether to use IPv6 's stateless autoconfiguration/ Line 70: :param dhcpv6: whether to use DHCPv6. Line 71: :param _netinfo: network information snapshot. Line 72: :param configurator: instance to use to apply the network configuration. Line 73: :param blockingdhcp: whether to acquire dhcp IP config in a synced manner. Line 472: netmask=ip Line 473: gateway=ip Line 474: bootproto=... Line 475: delay=... Line 476: onboot=yes|no I'd probably add the new options here. Line 477: (other options will be passed to the config file AS-IS) Line 478: -- OR -- Line 479: remove=True (other attributes can't be specified) Line 480: File vdsm/netconf/ifcfg.py Line 470: cfg = cfg + 'MTU=%d\n' % mtu Line 471: if defaultRoute: Line 472: cfg = cfg + 'DEFROUTE=%s\n' % defaultRoute Line 473: cfg += 'NM_CONTROLLED=no\n' Line 474: if ipv6addr or ipv6gateway or ipv6autoconf or dhcpv6: I think ipv6gateway is unnecessary. Even without gateway, if we have an ipv6addr we need to set ipv6init to yes. Line 475: cfg += 'IPV6INIT=yes\n' Line 476: ipv6autoconf = 'no' Line 477: if ipv6addr is not None: Line 478: cfg += 'IPV6ADDR=%s\n' % pipes.quote(ipv6addr) Line 472: cfg = cfg + 'DEFROUTE=%s\n' % defaultRoute Line 473: cfg += 'NM_CONTROLLED=no\n' Line 474: if ipv6addr or ipv6gateway or ipv6autoconf or dhcpv6: Line 475: cfg += 'IPV6INIT=yes\n' Line 476: ipv6autoconf = 'no' I think this is unnecessary Line 477: if ipv6addr is not None: Line 478: cfg += 'IPV6ADDR=%s\n' % pipes.quote(ipv6addr) Line 479: if ipv6gateway is not None: Line 480: cfg += 'IPV6_DEFAULTGW=%s\n' % pipes.quote(ipv6gateway) Line 480: cfg += 'IPV6_DEFAULTGW=%s\n' % pipes.quote(ipv6gateway) Line 481: elif dhcpv6: Line 482: cfg += 'DHCPV6C=yes\n' Line 483: if ipv6autoconf: Line 484: ipv6autoconf = 'yes' You're always setting ipv6autoconf to 'yes' because you're always setting it to 'no' (which is a True value). Line 485: cfg += 'IPV6_AUTOCONF=%s\n' % pipes.quote(ipv6autoconf) Line 486: BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'bondingOptions', Line 487: 'force', 'blockingdhcp', Line 488: 'connectivityCheck', 'connectivityTimeout', Line 481: elif dhcpv6: Line 482: cfg += 'DHCPV6C=yes\n' Line 483: if ipv6autoconf: Line 484: ipv6autoconf = 'yes' Line 485: cfg += 'IPV6_AUTOCONF=%s\n' % pipes.quote(ipv6autoconf) Shouldn't this line just be: cfg += 'IPV6_AUTOCONF=%s\n' % 'yes' if ipv6autoconf else 'no' Line 486: BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'bondingOptions', Line 487: 'force', 'blockingdhcp', Line 488: 'connectivityCheck', 'connectivityTimeout', Line 489: 'implicitBonding'] Line 502: self._createConfFile(conf, bridge.name, ipconfig.ipaddr, Line 503: ipconfig.netmask,
