Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: virt: Make BIOS messages available on vmconsole
..


virt: Make BIOS messages available on vmconsole

ovirt-vmconsole allows access to VMs via serial console.  However, this
currently works only for processes running on the VM operating system,
such as getty.  It would be useful if vmconsole could interact with the
user before the OS starts, i.e. if it displayed BIOS messages, boot
menu, GRUB menu etc. and the user could select the menu items or type
GRUB commands.

This change is the first step towards the goal.  It enables BIOS serial
console interaction in a VM's XML domain description when a serial
console is available.

Note that a console of type `serial' (not just `virtio') must be present
in order to make this feature work.  When oVirt Engine is used to manage
VMs' serial console access, recent version of oVirt Engine (currently at
least 3.6 snapshot) is required to receive `serial' console type in
calls from Engine.

Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/48404
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Nir Soffer 
---
M tests/vmTests.py
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
3 files changed, 39 insertions(+), 6 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/48404/8/tests/vmTests.py
File tests/vmTests.py:

Line 289: xml = find_xml_element(domxml.dom.toxml(), './sysinfo')
Line 290: self.assertXMLEqual(xml, sysinfoXML)
Line 291: 
Line 292: @permutations([['serial', True], ['virtio', False]])
Line 293: def testSerialBios(self, console_type, use_serial):
> I would like to only lowercase names in new code, even if it is less consis
No problem for me. Francesco?
Line 294: devices = {'device': 'console', 'type': 'console',
Line 295:'specParams': {'consoleType': console_type}},
Line 296: with fake.VM(devices=devices, create_device_objects=True) as 
fakevm:
Line 297: dom_xml = fakevm._buildDomainXML()


https://gerrit.ovirt.org/#/c/48404/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1569: """
Line 1570: for console in self._devices[hwclass.CONSOLE]:
Line 1571: if console.isSerial:
Line 1572: return console
Line 1573: return None
> Maybe raise NotFound error instead returning None?
It may be a valid concern but at least in the current code it would require us 
to handle the exception without any benefit. Not having serial console is 
perfectly OK, not an exceptional situation, after all.
Line 1574: 
Line 1575: def _customDevices(self):
Line 1576: """
Line 1577: Get all devices that have custom properties


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/48404/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1569: """
Line 1570: for console in self._devices[hwclass.CONSOLE]:
Line 1571: if console.isSerial:
Line 1572: return console
Line 1573: return None
> It may be a valid concern but at least in the current code it would require
OK
Line 1574: 
Line 1575: def _customDevices(self):
Line 1576: """
Line 1577: Get all devices that have custom properties


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/48404/8/tests/vmTests.py
File tests/vmTests.py:

Line 289: xml = find_xml_element(domxml.dom.toxml(), './sysinfo')
Line 290: self.assertXMLEqual(xml, sysinfoXML)
Line 291: 
Line 292: @permutations([['serial', True], ['virtio', False]])
Line 293: def testSerialBios(self, console_type, use_serial):
> No problem for me. Francesco?
For new code we should use pep8 names, otherwise we'll be stuck in this 
camelCaseLimboForever. However not worth a new upload, we could do a mass 
rename in a separate patch (which we need anyway, so fixing here doesn't really 
help).
Line 294: devices = {'device': 'console', 'type': 'console',
Line 295:'specParams': {'consoleType': console_type}},
Line 296: with fake.VM(devices=devices, create_device_objects=True) as 
fakevm:
Line 297: dom_xml = fakevm._buildDomainXML()


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8: Code-Review+2

Milan, can you verify this and explain how you tested?

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8: Verified+1

I verified by:

- Building Engine version ovirt-engine-3.6.0.3 + fbfaf94 (vmconsole didn't work 
for me in newer versions).
- Disabling VirtIO serial console in the engine for a given VM and enabling it 
again (to convert it to serial type in the engine).
- Starting the VM in pause mode and with boot menu enabled.
- Connecting to the console: ssh -t -p  ovirt-vmconsole@ENGINE-HOST
- Unpausing the VM.
- Watching boot menu, selecting its items, watching GRUB menu and basic 
interaction with it (selecting menu items, typing in the command prompt after 
`c').

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8:

Waiting for Dan.

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8: Code-Review+1

(2 comments)

Very nice, waiting for Francesco approval.

https://gerrit.ovirt.org/#/c/48404/8/tests/vmTests.py
File tests/vmTests.py:

Line 289: xml = find_xml_element(domxml.dom.toxml(), './sysinfo')
Line 290: self.assertXMLEqual(xml, sysinfoXML)
Line 291: 
Line 292: @permutations([['serial', True], ['virtio', False]])
Line 293: def testSerialBios(self, console_type, use_serial):
I would like to only lowercase names in new code, even if it is less consistent 
wit surrounding code, but it this is what Francesco prefer I'm ok with it.
Line 294: devices = {'device': 'console', 'type': 'console',
Line 295:'specParams': {'consoleType': console_type}},
Line 296: with fake.VM(devices=devices, create_device_objects=True) as 
fakevm:
Line 297: dom_xml = fakevm._buildDomainXML()


https://gerrit.ovirt.org/#/c/48404/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1569: """
Line 1570: for console in self._devices[hwclass.CONSOLE]:
Line 1571: if console.isSerial:
Line 1572: return console
Line 1573: return None
Maybe raise NotFound error instead returning None?

I'm seeing the future errors:

AttributeError: 'NoneType' object has no attribute 'toxml'
Line 1574: 
Line 1575: def _customDevices(self):
Line 1576: """
Line 1577: Get all devices that have custom properties


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 7: Verified+1

Verified by manually testing it as usually.

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 6:

(5 comments)

https://gerrit.ovirt.org/#/c/48404/6//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: ovirt-vmconsole allows access to VMs via serial console.  However, this
Line 10: currently works only for processes running on the VM operating system,
Line 11: such as getty.  It would be useful if vmconsole interacted immediately
Line 12: since the start of a VM.
> This is not clear - how do you wan to interact with the vm if not with some
Clarified.
Line 13: 
Line 14: This change is the first step towards the goal.  It enables BIOS serial
Line 15: console interaction in a VM's XML domain description when a serial
Line 16: console is available.


https://gerrit.ovirt.org/#/c/48404/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1592: for consoleDev in self._devices[hwclass.CONSOLE]:
Line 1593: if consoleDev.isSerial:
Line 1594: break
Line 1595: else:
Line 1596: consoleDev = None
> Please avoid for-else syntax, it is always confusing and unneeded.
Done
Line 1597: bios_use_serial = consoleDev is not None
Line 1598: 
Line 1599: domxml = vmxml.Domain(self.conf, self.log, self.arch)
Line 1600: domxml.appendOs(bios_use_serial=bios_use_serial)


Line 1593: if consoleDev.isSerial:
Line 1594: break
Line 1595: else:
Line 1596: consoleDev = None
Line 1597: bios_use_serial = consoleDev is not None
> This variable it not needed.
Removed.
Line 1598: 
Line 1599: domxml = vmxml.Domain(self.conf, self.log, self.arch)
Line 1600: domxml.appendOs(bios_use_serial=bios_use_serial)
Line 1601: 


Line 1596: consoleDev = None
Line 1597: bios_use_serial = consoleDev is not None
Line 1598: 
Line 1599: domxml = vmxml.Domain(self.conf, self.log, self.arch)
Line 1600: domxml.appendOs(bios_use_serial=bios_use_serial)
> This should be:
Done
Line 1601: 
Line 1602: if self.arch == caps.Architecture.X86_64:
Line 1603: osd = caps.osversion()
Line 1604: 


https://gerrit.ovirt.org/#/c/48404/6/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 230: self.dom.setAttr('xmlns:' + METADATA_VM_TUNE_PREFIX,
Line 231:  METADATA_VM_TUNE_URI)
Line 232: self.dom.appendChild(self._metadata)
Line 233: 
Line 234: def appendOs(self, bios_use_serial=False):
> Do we have other useserial attributes in this element?
Done
Line 235: """
Line 236: Add  element to domain:
Line 237: 
Line 238: 


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 7: Code-Review-1

(1 comment)

minor issue with naming, everything else looks good

https://gerrit.ovirt.org/#/c/48404/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1561: return response.error('migCancelErr')
Line 1562: finally:
Line 1563: self._guestCpuLock.release()
Line 1564: 
Line 1565: def _serialConsole(self):
please use _getSerialConsole or _findSerialConsole() like we do elsewhere in 
vm.py
Line 1566: """
Line 1567: Return serial console device.
Line 1568: If no serial console device is available, return 'None'.
Line 1569: """


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/48404/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1561: return response.error('migCancelErr')
Line 1562: finally:
Line 1563: self._guestCpuLock.release()
Line 1564: 
Line 1565: def _serialConsole(self):
> please use _getSerialConsole or _findSerialConsole() like we do elsewhere i
Done (originally wanted to be consistent with _customDevices immediately below).
Line 1566: """
Line 1567: Return serial console device.
Line 1568: If no serial console device is available, return 'None'.
Line 1569: """


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 6: Code-Review-1

(5 comments)

https://gerrit.ovirt.org/#/c/48404/6//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: ovirt-vmconsole allows access to VMs via serial console.  However, this
Line 10: currently works only for processes running on the VM operating system,
Line 11: such as getty.  It would be useful if vmconsole interacted immediately
Line 12: since the start of a VM.
This is not clear - how do you wan to interact with the vm if not with some 
process running on it?

What do you mean by interacted immediately?
Line 13: 
Line 14: This change is the first step towards the goal.  It enables BIOS serial
Line 15: console interaction in a VM's XML domain description when a serial
Line 16: console is available.


https://gerrit.ovirt.org/#/c/48404/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1592: for consoleDev in self._devices[hwclass.CONSOLE]:
Line 1593: if consoleDev.isSerial:
Line 1594: break
Line 1595: else:
Line 1596: consoleDev = None
Please avoid for-else syntax, it is always confusing and unneeded.

Please add instead a private method returning the the serial console device.

Also, since consoleDev is always a serial console, why not call it 
serial_console?
Line 1597: bios_use_serial = consoleDev is not None
Line 1598: 
Line 1599: domxml = vmxml.Domain(self.conf, self.log, self.arch)
Line 1600: domxml.appendOs(bios_use_serial=bios_use_serial)


Line 1593: if consoleDev.isSerial:
Line 1594: break
Line 1595: else:
Line 1596: consoleDev = None
Line 1597: bios_use_serial = consoleDev is not None
This variable it not needed.
Line 1598: 
Line 1599: domxml = vmxml.Domain(self.conf, self.log, self.arch)
Line 1600: domxml.appendOs(bios_use_serial=bios_use_serial)
Line 1601: 


Line 1596: consoleDev = None
Line 1597: bios_use_serial = consoleDev is not None
Line 1598: 
Line 1599: domxml = vmxml.Domain(self.conf, self.log, self.arch)
Line 1600: domxml.appendOs(bios_use_serial=bios_use_serial)
This should be:

bios_use_serial=consoleDev is not None
Line 1601: 
Line 1602: if self.arch == caps.Architecture.X86_64:
Line 1603: osd = caps.osversion()
Line 1604: 


https://gerrit.ovirt.org/#/c/48404/6/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 230: self.dom.setAttr('xmlns:' + METADATA_VM_TUNE_PREFIX,
Line 231:  METADATA_VM_TUNE_URI)
Line 232: self.dom.appendChild(self._metadata)
Line 233: 
Line 234: def appendOs(self, bios_use_serial=False):
Do we have other useserial attributes in this element?

Does the caller care about the bios element, or about using a serial console?
If the later is more correct, use_serial_console is a better argument name.
Line 235: """
Line 236: Add  element to domain:
Line 237: 
Line 238: 


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 5: Code-Review+1

(1 comment)

minor comment inside

https://gerrit.ovirt.org/#/c/48404/5/tests/vmTests.py
File tests/vmTests.py:

Line 292: @permutations([['serial', True], ['virtio', False]])
Line 293: def testSerialBios(self, console_type, use_serial):
Line 294: devices = {'device': 'console', 'type': 'console',
Line 295:'specParams': {'consoleType': console_type}},
Line 296: with fake.VM(devices=devices, create_device_objects=True) as 
v:
minor: we usually avoid so short names. "fakevm" or "testvm" could be a better 
choice here.
Line 297: dom_xml = v._buildDomainXML()
Line 298: tree = etree.fromstring(dom_xml)
Line 299: element = tree.find(".//bios[@useserial='yes']")
Line 300: self.assertEqual(element is not None, use_serial)


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 5:

(1 comment)

Just renamed a one-char variable in tests.

https://gerrit.ovirt.org/#/c/48404/5/tests/vmTests.py
File tests/vmTests.py:

Line 292: @permutations([['serial', True], ['virtio', False]])
Line 293: def testSerialBios(self, console_type, use_serial):
Line 294: devices = {'device': 'console', 'type': 'console',
Line 295:'specParams': {'consoleType': console_type}},
Line 296: with fake.VM(devices=devices, create_device_objects=True) as 
v:
> minor: we usually avoid so short names. "fakevm" or "testvm" could be a bet
Done
Line 297: dom_xml = v._buildDomainXML()
Line 298: tree = etree.fromstring(dom_xml)
Line 299: element = tree.find(".//bios[@useserial='yes']")
Line 300: self.assertEqual(element is not None, use_serial)


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 6:

please verify, and document how you did that

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 6: Verified+1

It still works, verified in the same way as in Patch Set 4.

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 4: Code-Review+1

(3 comments)

codewise looks ok, tests could be improved.

https://gerrit.ovirt.org/#/c/48404/4/tests/vmTests.py
File tests/vmTests.py:

Line 1407: self.assertEqual(res, response.error("thawErr",
Line 1408:  message="fake error"))
Line 1409: 
Line 1410: 
Line 1411: class UseSerialTests(TestCaseBase):
I'd rename 'SerialBiosTests'. Maybe put it alongside the other xml tests on 
this module? Perhaps next to console device tests?
Line 1412: 
Line 1413: def testUseSerial(self):
Line 1414: test_cases = (('serial', True),
Line 1415:   ('virtio', False),)


Line 1411: class UseSerialTests(TestCaseBase):
Line 1412: 
Line 1413: def testUseSerial(self):
Line 1414: test_cases = (('serial', True),
Line 1415:   ('virtio', False),)
please use permutations, there are many examples under tests/*
Line 1416: for console_type, use_serial in test_cases:
Line 1417: devices = {'device': 'console', 'type': 'console',
Line 1418:'specParams': {'consoleType': console_type}},
Line 1419: with fake.VM(devices=devices, 
create_device_objects=True) as v:


Line 1417: devices = {'device': 'console', 'type': 'console',
Line 1418:'specParams': {'consoleType': console_type}},
Line 1419: with fake.VM(devices=devices, 
create_device_objects=True) as v:
Line 1420: dom_xml = v._buildDomainXML()
Line 1421: self.assertEqual('' in 
dom_xml,
please use smarter approach than string check, using ElementTree facilities.
Line 1422:  use_serial)
Line 1423: 
Line 1424: 
Line 1425: def _load_xml(name):


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 4:

(3 comments)

Is the test better in patch set 5?

https://gerrit.ovirt.org/#/c/48404/4/tests/vmTests.py
File tests/vmTests.py:

Line 1407: self.assertEqual(res, response.error("thawErr",
Line 1408:  message="fake error"))
Line 1409: 
Line 1410: 
Line 1411: class UseSerialTests(TestCaseBase):
> I'd rename 'SerialBiosTests'. Maybe put it alongside the other xml tests on
Right, there is no reason to put the test in a separate class, I moved it 
alongside the other XML tests.
Line 1412: 
Line 1413: def testUseSerial(self):
Line 1414: test_cases = (('serial', True),
Line 1415:   ('virtio', False),)


Line 1411: class UseSerialTests(TestCaseBase):
Line 1412: 
Line 1413: def testUseSerial(self):
Line 1414: test_cases = (('serial', True),
Line 1415:   ('virtio', False),)
> please use permutations, there are many examples under tests/*
Done
Line 1416: for console_type, use_serial in test_cases:
Line 1417: devices = {'device': 'console', 'type': 'console',
Line 1418:'specParams': {'consoleType': console_type}},
Line 1419: with fake.VM(devices=devices, 
create_device_objects=True) as v:


Line 1417: devices = {'device': 'console', 'type': 'console',
Line 1418:'specParams': {'consoleType': console_type}},
Line 1419: with fake.VM(devices=devices, 
create_device_objects=True) as v:
Line 1420: dom_xml = v._buildDomainXML()
Line 1421: self.assertEqual('' in 
dom_xml,
> please use smarter approach than string check, using ElementTree facilities
Done
Line 1422:  use_serial)
Line 1423: 
Line 1424: 
Line 1425: def _load_xml(name):


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 4: Verified+1

I verified the patch works by:
- Building Engine version ovirt-engine-3.6.0.3 + fbfaf94 (vmconsole didn't work 
for me in newer versions).
- Disabling VirtIO serial console in the engine for a given VM an enabling it 
again (to convert it to serial type in the engine).
- Starting the VM in pause mode.
- Connecting to the console: ssh -t -p  ovirt-vmconsole@ENGINE-HOST
- Unpausing the VM and interacting with the console.

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:

Line 1: #
Line 2: # Copyright IBM Corp. 2012
Line 3: # Copyright 2013-2015 Red Hat, Inc.
> there is not such habit. A separate copyright-bump patch will probably a be
Done
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
Line 6: # it under the terms of the GNU General Public License as published by
Line 7: # the Free Software Foundation; either version 2 of the License, or


Line 1418:'specParams': {'consoleType': console_type}},
Line 1419: with fake.VM(devices=devices, 
create_device_objects=True) as v:
Line 1420: dom_xml = v._buildDomainXML()
Line 1421: self.assertEqual('' in 
dom_xml,
Line 1422:  use_serial)
> Could'nt that be solved by some monkeypatching?
I don't get how monkeypatching could help here. Basically, we need to check 
that _buildDomainXML correctly identifies presence of a serial console, passes 
correct argument to appendOs and appendOs produces correct output.
Line 1423: 
Line 1424: 
Line 1425: def _load_xml(name):
Line 1426: test_path = os.path.realpath(__file__)


https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1: #
Line 2: # Copyright 2008-2015 Red Hat, Inc.
> correct, but unneeded here
Done
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 1: #
Line 2: # Copyright 2008-2015 Red Hat, Inc.
> correct, but unneeded for this patch.
Done
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/48404/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 230: self.dom.setAttr('xmlns:' + METADATA_VM_TUNE_PREFIX,
Line 231:  METADATA_VM_TUNE_URI)
Line 232: self.dom.appendChild(self._metadata)
Line 233: 
Line 234: def appendOs(self, serial_console_available=False):
> I'd go for the shorter and equally expressive
Done
Line 235: """
Line 236: Add  element to domain:
Line 237: 
Line 238: 


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/48404/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 230: self.dom.setAttr('xmlns:' + METADATA_VM_TUNE_PREFIX,
Line 231:  METADATA_VM_TUNE_URI)
Line 232: self.dom.appendChild(self._metadata)
Line 233: 
Line 234: def appendOs(self, serial_console_available=False):
I'd go for the shorter and equally expressive
'bios_use_serial'
Line 235: """
Line 236: Add  element to domain:
Line 237: 
Line 238: 


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:

Line 1: #
Line 2: # Copyright IBM Corp. 2012
Line 3: # Copyright 2013-2015 Red Hat, Inc.
> Are the copyright years in VDSM updated in a different way than on the firs
there is not such habit. A separate copyright-bump patch will probably a better 
fit.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
Line 6: # it under the terms of the GNU General Public License as published by
Line 7: # the Free Software Foundation; either version 2 of the License, or


Line 1418:'specParams': {'consoleType': console_type}},
Line 1419: with fake.VM(devices=devices, 
create_device_objects=True) as v:
Line 1420: dom_xml = v._buildDomainXML()
Line 1421: self.assertEqual('' in 
dom_xml,
Line 1422:  use_serial)
> The problem is that presence of useserial is dependent on presence of the s
Could'nt that be solved by some monkeypatching?
Line 1423: 
Line 1424: 
Line 1425: def _load_xml(name):
Line 1426: test_path = os.path.realpath(__file__)


https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 276: if utils.tobool(self.conf.get('bootMenuEnable', False)):
Line 277: oselem.appendChildWithArgs('bootmenu', enable='yes')
Line 278: 
Line 279: if self.conf.get('_serialConsoleAvailable'):
Line 280: oselem.appendChildWithArgs('bios', useserial='yes')
> If serial console is not available then libvirt complains and the VM doesn'
fair enough, so we need a condition :)
Line 281: 
Line 282: def appendSysinfo(self, osname, osversion, serialNumber):
Line 283: """
Line 284: Add  element to domain:


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:

Line 1: #
Line 2: # Copyright IBM Corp. 2012
Line 3: # Copyright 2013-2015 Red Hat, Inc.
correct, but unneeded for this patch.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
Line 6: # it under the terms of the GNU General Public License as published by
Line 7: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 1:

(7 comments)

https://gerrit.ovirt.org/#/c/48404/1//COMMIT_MSG
Commit Message:

Line 14: This change is the first step towards the goal.  It enables BIOS serial
Line 15: console interaction in a VM's XML domain description when a serial
Line 16: console is available.
Line 17: 
Line 18: Note that at least oVirt Engine 3.6 snapshot is required to make the
this is true for oVirt/RHEV. For VDSM, is sufficient that the console is 
'type'='serial'.
I think you should either mention both or just the latter in the commit message.
Line 19: functionality actually working.  The reason is that access to BIOS
Line 20: messages requires presence of serial (not virtio) console.
Line 21: 
Line 22: Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973


https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:

Line 1418:'specParams': {'consoleType': console_type}},
Line 1419: with fake.VM(devices=devices, 
create_device_objects=True) as v:
Line 1420: dom_xml = v._buildDomainXML()
Line 1421: self.assertEqual('' in 
dom_xml,
Line 1422:  use_serial)
Kudos for the test. However, I'd prefer something more like
testOSXMLBootMenu, which is more focused and doesn't test internal methods 
(_buildDomainXML)
Line 1423: 
Line 1424: 
Line 1425: def _load_xml(name):
Line 1426: test_path = os.path.realpath(__file__)


https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1: #
Line 2: # Copyright 2008-2015 Red Hat, Inc.
correct, but unneeded here
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 1590: 
Line 1591: def _buildDomainXML(self):
Line 1592: for consoleDev in self._devices[hwclass.CONSOLE]:
Line 1593: if consoleDev.isSerial:
Line 1594: break
nice refactoring, but not needed for this patch.
Line 1595: else:
Line 1596: consoleDev = None
Line 1597: self.conf['_serialConsoleAvailable'] = consoleDev is not None
Line 1598: 


Line 1593: if consoleDev.isSerial:
Line 1594: break
Line 1595: else:
Line 1596: consoleDev = None
Line 1597: self.conf['_serialConsoleAvailable'] = consoleDev is not None
we should avoid to add attributes to Vm.conf unless it is really needed. 
_hidden attributes are particularly troublesome, especially if short lived.

We need a better way to notify appendOs here.
Line 1598: 
Line 1599: domxml = vmxml.Domain(self.conf, self.log, self.arch)
Line 1600: domxml.appendOs()
Line 1601: 


https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 1: #
Line 2: # Copyright 2008-2015 Red Hat, Inc.
correct, but unneeded for this patch.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 276: if utils.tobool(self.conf.get('bootMenuEnable', False)):
Line 277: oselem.appendChildWithArgs('bootmenu', enable='yes')
Line 278: 
Line 279: if self.conf.get('_serialConsoleAvailable'):
Line 280: oselem.appendChildWithArgs('bios', useserial='yes')
what happens if we inconditionally enable useserial?
Line 281: 
Line 282: def appendSysinfo(self, osname, osversion, serialNumber):
Line 283: """
Line 284: Add  element to domain:


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1590: 
Line 1591: def _buildDomainXML(self):
Line 1592: for consoleDev in self._devices[hwclass.CONSOLE]:
Line 1593: if consoleDev.isSerial:
Line 1594: break
> nice refactoring, but not needed for this patch.
please discard this comment.
Line 1595: else:
Line 1596: consoleDev = None
Line 1597: self.conf['_serialConsoleAvailable'] = consoleDev is not None
Line 1598: 


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48404/1//COMMIT_MSG
Commit Message:

Line 14: This change is the first step towards the goal.  It enables BIOS serial
Line 15: console interaction in a VM's XML domain description when a serial
Line 16: console is available.
Line 17: 
Line 18: Note that at least oVirt Engine 3.6 snapshot is required to make the
> this is true for oVirt/RHEV. For VDSM, is sufficient that the console is 't
Done
Line 19: functionality actually working.  The reason is that access to BIOS
Line 20: messages requires presence of serial (not virtio) console.
Line 21: 
Line 22: Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:

Line 1: #
Line 2: # Copyright IBM Corp. 2012
Line 3: # Copyright 2013-2015 Red Hat, Inc.
> correct, but unneeded for this patch.
Are the copyright years in VDSM updated in a different way than on the first 
change in given file each year?
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
Line 6: # it under the terms of the GNU General Public License as published by
Line 7: # the Free Software Foundation; either version 2 of the License, or


Line 1418:'specParams': {'consoleType': console_type}},
Line 1419: with fake.VM(devices=devices, 
create_device_objects=True) as v:
Line 1420: dom_xml = v._buildDomainXML()
Line 1421: self.assertEqual('' in 
dom_xml,
Line 1422:  use_serial)
> Kudos for the test. However, I'd prefer something more like
The problem is that presence of useserial is dependent on presence of the 
serial console. So we have to invoke more of the XML domain building process to 
test it, not just the  part.
Line 1423: 
Line 1424: 
Line 1425: def _load_xml(name):
Line 1426: test_path = os.path.realpath(__file__)


https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1593: if consoleDev.isSerial:
Line 1594: break
Line 1595: else:
Line 1596: consoleDev = None
Line 1597: self.conf['_serialConsoleAvailable'] = consoleDev is not None
> we should avoid to add attributes to Vm.conf unless it is really needed. _h
I agree, so let's try passing an argument to appendOs instead.
Line 1598: 
Line 1599: domxml = vmxml.Domain(self.conf, self.log, self.arch)
Line 1600: domxml.appendOs()
Line 1601: 


https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 276: if utils.tobool(self.conf.get('bootMenuEnable', False)):
Line 277: oselem.appendChildWithArgs('bootmenu', enable='yes')
Line 278: 
Line 279: if self.conf.get('_serialConsoleAvailable'):
Line 280: oselem.appendChildWithArgs('bios', useserial='yes')
> what happens if we inconditionally enable useserial?
If serial console is not available then libvirt complains and the VM doesn't 
start.
Line 281: 
Line 282: def appendSysinfo(self, osname, osversion, serialNumber):
Line 283: """
Line 284: Add  element to domain:


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches