Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 27: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 27: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9142/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9285/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8354/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 28: Verified+1 Changes: * tried to de-uglify the code, but the benefits where debateable, and that lead to relaxation of the checks in API.py, thus reverted again. * the net effect if an engine which wants to use the new (muiltiple) graphic devices must send anyway an hollow-soon-to-be-overwritten 'display' param. It is ugly, but I can't find a better solution * de-uglified the names into the schema, it was pointless to repeat 'display' multiple times. Moreover, the new information are really about display, so the name should reflect that. Verification: - the new path was verified using functional tests and vdsClient - the old path was verified using real unaware engine 3.5.0 master (~ alpha1) * creation of VMs using both spice and vnc (but without SSL) * migration of VMs back and forth patched VDSM and vanilla 4.14.8.1 verified together with http://gerrit.ovirt.org/#/c/26897 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 28: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9152/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9295/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8364/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Vinzenz Feenstra has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 28: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Dan Kenigsberg has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 28: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: graphdev: support multiple graphics devices .. virt: graphdev: support multiple graphics devices This patch allows a Vm to have more than one Graphics Devices, so a we can now have multiple consoles (e.g. SPICE and VNC at the same time). With this feature, a user can switch clients without restarting that VM. Another possible use case is the regular users using SPICE for performance and the administrator using VNC for portability. Bug-Url: https://bugzilla.redhat.com/976044 Change-Id: I5be348b342359d42c878937dca27454fe206a35a Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27215 Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/virtTests.py M tests/vmTests.py M vdsm/virt/vm.py M vdsm_api/vdsmapi-schema.json 4 files changed, 149 insertions(+), 23 deletions(-) Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 29: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1337/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 26: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8329/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 26: Code-Review-1 the legacy path seems fine, found a bug while verifying the new path giving only new proper Graphics Devices. Will upload a fixed and verified patch ASAP. -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9043/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9184/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8255/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Michal Skrivanek has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 24: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 25: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9071/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8283/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 25: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27215/25/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4898: dev['port'] = port
Line 4899: tlsPort = gxml.getAttribute('tlsPort')
Line 4900: if tlsPort:
Line 4901: dev['tlsPort'] = tlsPort
Line 4902: if not updated:
can this ever be updated? an update is imedately followed by break.
Line 4903: self._updateLegacyConf(dev)
Line 4904: updated = True
Line 4905: break
Line 4906:
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8979/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9120/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8191/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9000/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9141/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8212/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9008/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9149/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8220/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8917/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9054/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8127/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 19: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8868/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9004/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8078/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8827/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8963/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8037/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 18: greatly simplified after the discussion in the last VDSM sync call; -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8763/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8899/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7973/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 17: Verified+1
Vetrified with http://gerrit.ovirt.org/#/c/26895/ ,
http://gerrit.ovirt.org/#/c/27595/ and http://gerrit.ovirt.org/#/c/27596/
Verification (all the following using unpatched engine 3.5.0 snapshot:
* creation flow: booted a VM, connected with spice
* recovery: booted a VM, restarted VDSM, connected with spice
* migration: migrated back and forth another host running VDSM 4.14.8.1
* hibernate: booted a VM, restarted and connected with spice.
* verified the output of vdsClient
* cursory look at vdsm logs and to engine logs seems OK.
Found
Received a spice Device without an address when processing VM
025d59e3-f12c-41b8-be3f-de8dc22d23ce devices, skipping device: {port=5900,
specParams={keyMap=en-us, copyPasteEnable=false, displayIp=0,
fileTransferEnable=false}, device=spice, type=graphics}
but that is expected since the graphics device do not have PCI addresses.
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 17: verified the multiple graphics device using the functional tests due to lack of engine support. -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Dan Kenigsberg has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 17: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7913/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8834/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Dan Kenigsberg has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Michal Skrivanek has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/27215/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1762: devices[VIDEO_DEVICES] = self.getConfVideo()
Line 1763: devices[GRAPHICS_DEVICES] = self.getConfGraphics()
Line 1764: devices[CONTROLLER_DEVICES] = self.getConfController()
Line 1765: else:
Line 1766: if 'display' in self.conf:
is the move of the code to is significant?
I think the move of the new legacy-handling code here where we already handle
the pre-3.1 legacy makes sense. Should be kept together (and when it grows
further should be split out to a dedicated function)
Line 1767: devices[GRAPHICS_DEVICES] = self.getConfGraphics()
Line 1768:
Line 1769: for dev in self.conf.get('devices'):
Line 1770: try:
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 13:
(3 comments)
http://gerrit.ovirt.org/#/c/27215/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1762: devices[VIDEO_DEVICES] = self.getConfVideo()
Line 1763: devices[GRAPHICS_DEVICES] = self.getConfGraphics()
Line 1764: devices[CONTROLLER_DEVICES] = self.getConfController()
Line 1765: else:
Line 1766: if 'display' in self.conf:
is the move of the code to is significant?
Yes it is, albeit probably too obscure. The meaning is we should create the
first graphic device from the old configuration (display* params), because
doing so:
- old engine/clients see no differences
- new engine/clients can use the explicit graphic devices to create
*additional* displays.
AFAIK the order of graphic devices has no particular meaning nor there is an
explicit requirement, so if this change makes the code too obscure I'll change
it.
My reasoning was something like this:
we must keep the display* params, so better to bind them to the *first* graphic
device to make the API a little bit more understable (and only for this
reason!). Additional graphic devices can be added as explicit devices. When we
are allowed to break compatibility, just use the explicit graphic devices and
build them in the order the client provided them.
Line 1767: devices[GRAPHICS_DEVICES] = self.getConfGraphics()
Line 1768:
Line 1769: for dev in self.conf.get('devices'):
Line 1770: try:
Line 1815: for device in (WATCHDOG_DEVICES, CONSOLE_DEVICES):
Line 1816: if len(devices[device]) 1:
Line 1817: raise ValueError(only a single %s device is
Line 1818: supported % device)
Line 1819: graphDevs = set()
In this patch (further down) the same graphDevs variable name is used for s
Will change the name
Line 1820: for dev in devices[GRAPHICS_DEVICES]:
Line 1821: if dev.get('device') not in graphDevs:
Line 1822: graphDevs.add(dev.get('device'))
Line 1823: else:
Line 2966: self.setDownStatus(ERROR,
vmexitreason.LIBVIRT_START_FAILED)
Line 2967: return
Line 2968: self._domDependentInit()
Line 2969:
Line 2970: def _updateDevices(self, devices):
this part only moves code to a function, and as such could be split to anot
Yes, I just want to group this code into a function.
will extract this function, aake a separate patch and rebase all this changeset
on top of that.
I was unsure it was worth a different separate patch.
Line 2971:
Line 2972: Update self.conf with updated devices
Line 2973: For old type vmParams, new 'devices' key will be
Line 2974: created with all devices info
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8603/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7813/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8731/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 15:
(1 comment)
Addressed reviewer's remark either with code changes (most of time) or with
inline code comments/docstrings.
Preliminary verifications seems OK (migrations/recovery), more tests still in
progress, thus not ticking verified.
http://gerrit.ovirt.org/#/c/27215/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1877:
Line 1878: Normalize graphics device provided by conf.
Line 1879:
Line 1880: graphDevs = []
Line 1881: if 'display' in self.conf:
To be forward-compatible with future engine which will just send graphic
devices. However a few changes are still needed, getConfVideo is just the first
which comes to mind.
Line 1882: graphDevs.append({
Line 1883: 'type': GRAPHICS_DEVICES,
Line 1884: 'device': 'spice' if self.conf['display'] == 'qxl'
Line 1885: else 'vnc',
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8612/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7822/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8740/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 15: re-verified using an unaware old engine (sending legacy graphic display) * creation * migration (between two patched VDSM) * recovert * suspend/resume manually inspected -but with cursory glance- the VDSM logs: domain XML looks OK, no unexpected things found. Still to be verified: migration between patched VDSM and unpatched VDSM e.g. 4.14.6 -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 13: Code-Review-1
(3 comments)
pardon my laziness, but I find it important to keep this complex patchset as
simple as possible.
http://gerrit.ovirt.org/#/c/27215/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1762: devices[VIDEO_DEVICES] = self.getConfVideo()
Line 1763: devices[GRAPHICS_DEVICES] = self.getConfGraphics()
Line 1764: devices[CONTROLLER_DEVICES] = self.getConfController()
Line 1765: else:
Line 1766: if 'display' in self.conf:
is the move of the code to is significant?
Line 1767: devices[GRAPHICS_DEVICES] = self.getConfGraphics()
Line 1768:
Line 1769: for dev in self.conf.get('devices'):
Line 1770: try:
Line 1815: for device in (WATCHDOG_DEVICES, CONSOLE_DEVICES):
Line 1816: if len(devices[device]) 1:
Line 1817: raise ValueError(only a single %s device is
Line 1818: supported % device)
Line 1819: graphDevs = set()
In this patch (further down) the same graphDevs variable name is used for
something completely different. Unless I am confused, graphDevDisplayTypes is a
more exact name.
Line 1820: for dev in devices[GRAPHICS_DEVICES]:
Line 1821: if dev.get('device') not in graphDevs:
Line 1822: graphDevs.add(dev.get('device'))
Line 1823: else:
Line 2966: self.setDownStatus(ERROR,
vmexitreason.LIBVIRT_START_FAILED)
Line 2967: return
Line 2968: self._domDependentInit()
Line 2969:
Line 2970: def _updateDevices(self, devices):
this part only moves code to a function, and as such could be split to another
patch, which could be merged first with next-to-zero worries.
BTW, it's an over-complex way to write
self.conf['devices'] = reduce(extend, devices.values())
but that's besides the point.
Line 2971:
Line 2972: Update self.conf with updated devices
Line 2973: For old type vmParams, new 'devices' key will be
Line 2974: created with all devices info
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8519/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8646/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 11: added functional test -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7752/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8669/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8547/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8674/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 13: Verified+1 Verification: * verified the backward compatibility using unaware engine 3.5.0 master and vdsClient * verified the new code using functional and unit tests due the lack of UI. I'm ticking verified but I'll be more than happy to do further testing. -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8492/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8617/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 7: Patch set 7, 8: rebased -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8497/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7707/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8622/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8502/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8628/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 9: * fix enumerate() silliness (previous testing was way too narrow) * if the graphic device has to be reconstructed by the display* params, it must be the first one * added unit tests -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8508/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7718/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8634/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 3: patch set 3: rebased, fixed pep8 glitches -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8422/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8543/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 5: (1 comment) Patch set 5: enhanced commit message, added better explanations. http://gerrit.ovirt.org/#/c/27215/5/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 6042: 'disksUsage': ['GuestMountInfo'], Line 6043: 'netIfaces': ['GuestNetworkDeviceInfo'], Line 6044: '*watchdogEvent': 'WatchdogEvent', 'guestFQDN': 'str', Line 6045: '*migrationProgress': 'uint', 'guestCPUCount': 'int', Line 6046: 'graphicDevices': ['GraphicsDeviceInfo']}} I find this approach clearer than the proposal in http://www.ovirt.org/Features/Multiple_Consoles In the longer term, when we are allowed to break comaptibility (4.x) I'd like to get rid of the display* fields here and to have only the informations in graphicDevices. That said, I am ok (I like it less but I can live with this) the additionalDisplayPort field if turns out it is better or simpler. Line 6047: Line 6048: ## Line 6049: # @VmStats: Line 6050: # -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 6: Patch set 6: since we do need to support the old interface (aka display* parameters) until 4.x, always consider those data both as input and as output. The first Graphic Device will be always constructed and reported using the display* fields. Doing this way this patch is closer to what is documented on http://www.ovirt.org/Features/Multiple_Consoles -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8434/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7644/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8555/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8451/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7661/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8572/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has uploaded a new change for review.
Change subject: virt: graphdev: support multiple graphics devices
..
virt: graphdev: support multiple graphics devices
This patch allows a Vm to have more than one Graphics Devices.
Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 37 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/27215/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6563f68..c5c8daa 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1816,8 +1816,16 @@
if len(devices[device]) 1:
raise ValueError(only a single %s device is
supported % device)
-if len(devices[GRAPHICS_DEVICES]) != 1:
-raise ValueError(graphics device is required)
+graphDevs = set()
+for dev in devices[GRAPHICS_DEVICES]:
+if dev.device not in graphDevs:
+graphDevs.add(dev.device)
+else:
+raise ValueError(only a single graphic device
+ per type is supported)
+if not graphDevs:
+raise ValueError(at least one graphics device is required)
+
def getConfController(self):
@@ -2576,7 +2584,10 @@
stats['displayType'] = 'qxl'
return stats
+# backward compatibility
stats.update(getInfo(self.getConfGraphics()[0]))
+stats['graphicDevices'] = [getInfo(dev, legacy=False)
+for dev in self.getConfGraphics()]
def isMigrating(self):
return self._migrationSourceThread.isAlive()
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 5836f1d..57a78e1 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -5825,6 +5825,25 @@
'balloon_target': 'str'}}
##
+# @GraphicsDeviceInfo:
+#
+# Graphics Device information.
+#
+# @displayPort:The port in use for unencrypted display data
+#
+# @displaySecurePort: The port in use for encrypted display data
+#
+# @displayType:The type of display in use
+#
+# @displayIp: The IP address to use for accessing the VM display
+#
+# Since: 4.15.0
+##
+{'type': 'GraphicsDeviceInfo',
+ 'data': {'displayPort': 'uint', 'displaySecurePort': 'uint',
+ 'displayType': 'VmGraphicsDeviceType', 'displayIp': 'str'}}
+
+##
# @GuestMountInfo:
#
# Information about a mounted filesystem as reported by the guest agent.
@@ -6001,6 +6020,9 @@
# @guestCPUCount: The number of CPU cores are visible as online on the
# guest OS. This value is -1 if not supported to report
#
+# @graphicDevices: Graphics device informations.
+# (new in version 4.15.0)
+#
# Since: 4.10.0
##
{'type': 'RunningVmStats',
@@ -6020,7 +6042,8 @@
'disksUsage': ['GuestMountInfo'],
'netIfaces': ['GuestNetworkDeviceInfo'],
'*watchdogEvent': 'WatchdogEvent', 'guestFQDN': 'str',
- '*migrationProgress': 'uint', 'guestCPUCount': 'int'}}
+ '*migrationProgress': 'uint', 'guestCPUCount': 'int',
+ 'graphicDevices': ['GraphicsDeviceInfo']}}
##
# @VmStats:
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8392/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7602/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8512/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 2: patch set 2: rebased -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 2: Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8396/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7606/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8516/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8403/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8523/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
