[webkit-changes] [99398] trunk/LayoutTests
Title: [99398] trunk/LayoutTests Revision 99398 Author ph...@webkit.org Date 2011-11-07 00:09:56 -0800 (Mon, 07 Nov 2011) Log Message Unreviewed, skip fast/events/platform-wheelevent-paging on GTK because this platform does not support a paging mouse wheel event. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99397 => 99398) --- trunk/LayoutTests/ChangeLog 2011-11-07 07:18:13 UTC (rev 99397) +++ trunk/LayoutTests/ChangeLog 2011-11-07 08:09:56 UTC (rev 99398) @@ -1,3 +1,10 @@ +2011-11-07 Philippe Normand pnorm...@igalia.com + +Unreviewed, skip fast/events/platform-wheelevent-paging on GTK +because this platform does not support a paging mouse wheel event. + +* platform/gtk/Skipped: + 2011-11-06 Ben Wells benwe...@chromium.org [GTK] Skip new failing test. Modified: trunk/LayoutTests/platform/gtk/Skipped (99397 => 99398) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-07 07:18:13 UTC (rev 99397) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-07 08:09:56 UTC (rev 99398) @@ -444,6 +444,18 @@ # HiDPI tests require test infrastructure enhancements fast/hidpi +# Skip because this platform does not support a paging mouse wheel event +fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html +fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html +fast/events/platform-wheelevent-paging-x-in-scrolling-div.html +fast/events/platform-wheelevent-paging-x-in-scrolling-page.html +fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html +fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html +fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html +fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html +fast/events/platform-wheelevent-paging-y-in-scrolling-div.html +fast/events/platform-wheelevent-paging-y-in-scrolling-page.html + ### # TESTS FAILING ### ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99399] trunk/LayoutTests
Title: [99399] trunk/LayoutTests Revision 99399 Author yu...@chromium.org Date 2011-11-07 00:48:43 -0800 (Mon, 07 Nov 2011) Log Message [Chromium] Unreviewed gardening. * platform/chromium/test_expectations.txt: Mark two tests as flaky. Remove some obsolete expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99398 => 99399) --- trunk/LayoutTests/ChangeLog 2011-11-07 08:09:56 UTC (rev 99398) +++ trunk/LayoutTests/ChangeLog 2011-11-07 08:48:43 UTC (rev 99399) @@ -1,3 +1,10 @@ +2011-11-07 Yuta Kitamura yu...@chromium.org + +[Chromium] Unreviewed gardening. + +* platform/chromium/test_expectations.txt: +Mark two tests as flaky. Remove some obsolete expectations. + 2011-11-07 Philippe Normand pnorm...@igalia.com Unreviewed, skip fast/events/platform-wheelevent-paging on GTK Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99398 => 99399) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 08:09:56 UTC (rev 99398) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 08:48:43 UTC (rev 99399) @@ -3291,9 +3291,6 @@ // After r87526, these all have extra scrollbars where the platform/mac expectations do not. BUGWK61664 LINUX : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE -BUGCR84317 DEBUG : svg/wicd/test-scalable-background-image1.xhtml = CRASH -BUGCR84317 MAC LEOPARD RELEASE : svg/wicd/test-scalable-background-image1.xhtml = IMAGE - BUGABARTH LINUX : svg/text/scaling-font-with-geometric-precision.html = PASS IMAGE BUGCR84157 WIN GPU : fast/canvas/canvas-currentColor.html = TEXT @@ -3842,7 +3839,7 @@ BUGWK71074 MAC : fast/table/border-collapsing/border-collapsing-head-foot.html = IMAGE+TEXT -BUGWK71083 MAC : fast/frames/iframe-double-scale-contents.html = FAIL CRASH +BUGWK71083 MAC : fast/frames/iframe-double-scale-contents.html = PASS CRASH BUGWK71127 : fast/js/kde/RegExp.html = TEXT BUGWK71127 : fast/js/exception-sequencing-binops2.html = TEXT @@ -3882,8 +3879,6 @@ BUGWK71451 LINUX : http/tests/security/contentSecurityPolicy/policy-does-not-affect-child.html = TEXT PASS BUGWK71451 LINUX : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = TEXT PASS -BUGWK71536 : storage/indexeddb/exception-in-event-aborts.html = TEXT - BUGENNE GPU : compositing/geometry/fixed-position.html = FAIL BUGENNE GPU : compositing/geometry/horizontal-scroll-composited.html = FAIL BUGENNE GPU : compositing/geometry/vertical-scroll-composited.html = FAIL @@ -3902,3 +3897,7 @@ BUGWK71606 MAC CPU-CG : fast/events/platform-wheelevent-paging-x-in-scrolling-page.html = TEXT BUGWK71606 MAC CPU-CG : fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html = TEXT BUGWK71606 MAC CPU-CG : fast/events/platform-wheelevent-paging-y-in-scrolling-page.html = TEXT + +BUGWK71652 WIN RELEASE : perf/document-contains.html = PASS TIMEOUT + +BUGWK71653 : platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html = PASS TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99400] trunk/LayoutTests
Title: [99400] trunk/LayoutTests Revision 99400 Author ph...@webkit.org Date 2011-11-07 01:26:00 -0800 (Mon, 07 Nov 2011) Log Message Unreviewed, unkip a working test and reclassify the wheelevent missing DRT features. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99399 => 99400) --- trunk/LayoutTests/ChangeLog 2011-11-07 08:48:43 UTC (rev 99399) +++ trunk/LayoutTests/ChangeLog 2011-11-07 09:26:00 UTC (rev 99400) @@ -1,3 +1,9 @@ +2011-11-07 Philippe Normand pnorm...@igalia.com + +Unreviewed, unkip a working test and reclassify the wheelevent missing DRT features. + +* platform/gtk/Skipped: + 2011-11-07 Yuta Kitamura yu...@chromium.org [Chromium] Unreviewed gardening. Modified: trunk/LayoutTests/platform/gtk/Skipped (99399 => 99400) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-07 08:48:43 UTC (rev 99399) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-07 09:26:00 UTC (rev 99400) @@ -444,18 +444,6 @@ # HiDPI tests require test infrastructure enhancements fast/hidpi -# Skip because this platform does not support a paging mouse wheel event -fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html -fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html -fast/events/platform-wheelevent-paging-x-in-scrolling-div.html -fast/events/platform-wheelevent-paging-x-in-scrolling-page.html -fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html -fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html -fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html -fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html -fast/events/platform-wheelevent-paging-y-in-scrolling-div.html -fast/events/platform-wheelevent-paging-y-in-scrolling-page.html - ### # TESTS FAILING ### @@ -604,9 +592,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=51213 fast/dom/gc-11.html -# https://bugs.webkit.org/show_bug.cgi?id=51242 -fast/dom/global-constructors.html - # https://bugs.webkit.org/show_bug.cgi?id=53085 # Cairo doesn't support repeat-x and repeat-y fast/canvas/patternfill-repeat.html @@ -614,6 +599,7 @@ # keygen element rendering is broken # https://bugs.webkit.org/show_bug.cgi?id=54136 fast/html/keygen.html +http/tests/misc/submit-post-keygen.html # [GTK] GTK+ does not support hyphenation # https://bugs.webkit.org/show_bug.cgi?id=44478 @@ -881,6 +867,16 @@ fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html fast/events/scroll-in-scaled-page-with-overflow-hidden.html +fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html +fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html +fast/events/platform-wheelevent-paging-x-in-scrolling-div.html +fast/events/platform-wheelevent-paging-x-in-scrolling-page.html +fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html +fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html +fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html +fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html +fast/events/platform-wheelevent-paging-y-in-scrolling-div.html +fast/events/platform-wheelevent-paging-y-in-scrolling-page.html # Misses setMediaType() implementation fast/media/print-restores-previous-mediatype.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99401] trunk
Title: [99401] trunk
Revision 99401
Author apav...@chromium.org
Date 2011-11-07 01:59:27 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: Cannot edit elements commented with !--
https://bugs.webkit.org/show_bug.cgi?id=71357
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateNodeContextMenu):
LayoutTests:
* inspector/elements/edit-dom-actions-expected.txt:
* inspector/elements/edit-dom-actions.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/elements/edit-dom-actions-expected.txt
trunk/LayoutTests/inspector/elements/edit-dom-actions.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
Diff
Modified: trunk/LayoutTests/ChangeLog (99400 => 99401)
--- trunk/LayoutTests/ChangeLog 2011-11-07 09:26:00 UTC (rev 99400)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 09:59:27 UTC (rev 99401)
@@ -1,3 +1,13 @@
+2011-11-07 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: Cannot edit elements commented with !--
+https://bugs.webkit.org/show_bug.cgi?id=71357
+
+Reviewed by Pavel Feldman.
+
+* inspector/elements/edit-dom-actions-expected.txt:
+* inspector/elements/edit-dom-actions.html:
+
2011-11-07 Philippe Normand pnorm...@igalia.com
Unreviewed, unkip a working test and reclassify the wheelevent missing DRT features.
Modified: trunk/LayoutTests/inspector/elements/edit-dom-actions-expected.txt (99400 => 99401)
--- trunk/LayoutTests/inspector/elements/edit-dom-actions-expected.txt 2011-11-07 09:26:00 UTC (rev 99400)
+++ trunk/LayoutTests/inspector/elements/edit-dom-actions-expected.txt 2011-11-07 09:59:27 UTC (rev 99401)
@@ -3,6 +3,7 @@
Edited Text
Span contents
+Element
Running: testSetUp
@@ -75,6 +76,17 @@
div id=node-to-add-attribute newattr=new-value/div
/div
+Running: testEditCommentAsHTML
+ before
+- div id=testEditCommentAsHTML
+ !-- Comment --
+ /div
+!-- Comment --
+ after
+- div id=testEditCommentAsHTML
+ div foo=bar-commentElement/div
+ /div
+
Running: testEditAsHTML
before
- div id=testEditAsHTML
Modified: trunk/LayoutTests/inspector/elements/edit-dom-actions.html (99400 => 99401)
--- trunk/LayoutTests/inspector/elements/edit-dom-actions.html 2011-11-07 09:26:00 UTC (rev 99400)
+++ trunk/LayoutTests/inspector/elements/edit-dom-actions.html 2011-11-07 09:59:27 UTC (rev 99401)
@@ -18,7 +18,7 @@
function testRemove(next)
{
-domActionTest(testRemove, node-to-remove, testBody, next);
+domActionTestForNodeId(testRemove, node-to-remove, testBody, next);
function testBody(node, done)
{
@@ -30,7 +30,7 @@
function testSetNodeName(next)
{
-domActionTest(testSetNodeName, node-to-set-name, testBody, next);
+domActionTestForNodeId(testSetNodeName, node-to-set-name, testBody, next);
function testBody(node, done)
{
@@ -40,7 +40,7 @@
function testSetNodeNameInput(next)
{
-domActionTest(testSetNodeNameInput, node-to-set-name-input, testBody, next);
+domActionTestForNodeId(testSetNodeNameInput, node-to-set-name-input, testBody, next);
function testBody(node, done)
{
@@ -50,7 +50,7 @@
function testSetNodeValue(next)
{
-domActionTest(testSetNodeValue, node-to-set-value, testBody, next);
+domActionTestForNodeId(testSetNodeValue, node-to-set-value, testBody, next);
function testBody(node, done)
{
@@ -60,7 +60,7 @@
function testSetAttribute(next)
{
-domActionTest(testSetAttribute, node-to-set-attribute, testBody, next);
+domActionTestForNodeId(testSetAttribute, node-to-set-attribute, testBody, next);
function testBody(node, done)
{
@@ -70,7 +70,7 @@
function testRemoveAttribute(next)
{
-domActionTest(testRemoveAttribute, node-to-remove-attribute, testBody, next);
+domActionTestForNodeId(testRemoveAttribute, node-to-remove-attribute, testBody, next);
function testBody(node, done)
{
@@ -80,7 +80,7 @@
function testAddAttribute(next)
{
-domActionTest(testAddAttribute, node-to-add-attribute, testBody, next);
+domActionTestForNodeId(testAddAttribute,
[webkit-changes] [99402] trunk/LayoutTests
Title: [99402] trunk/LayoutTests Revision 99402 Author yu...@chromium.org Date 2011-11-07 02:51:30 -0800 (Mon, 07 Nov 2011) Log Message Web Inspector: Cannot edit elements commented with !-- https://bugs.webkit.org/show_bug.cgi?id=71357 Patch by Alexander Pavlov apav...@chromium.org on 2011-11-07 Reviewed by Pavel Feldman. * inspector/elements/edit-dom-actions-expected.txt: * inspector/elements/edit-dom-actions.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99401 => 99402) --- trunk/LayoutTests/ChangeLog 2011-11-07 09:59:27 UTC (rev 99401) +++ trunk/LayoutTests/ChangeLog 2011-11-07 10:51:30 UTC (rev 99402) @@ -19,6 +19,14 @@ [Chromium] Unreviewed gardening. * platform/chromium/test_expectations.txt: +Move tests experiencing the same assertion failure (bug 59552) into one place. +Mark fast/frames/sandboxed-iframe-navigation-targetlink.html as flaky (pass / timeout). + +2011-11-07 Yuta Kitamura yu...@chromium.org + +[Chromium] Unreviewed gardening. + +* platform/chromium/test_expectations.txt: Mark two tests as flaky. Remove some obsolete expectations. 2011-11-07 Philippe Normand pnorm...@igalia.com Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99401 => 99402) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 09:59:27 UTC (rev 99401) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 10:51:30 UTC (rev 99402) @@ -3159,7 +3159,6 @@ BUG_HCLAM : fast/url/ipv6.html = TEXT // Flaky -BUGWK60344 MAC DEBUG : fast/css/counters/complex-before.html = PASS CRASH BUGWK60346 : fast/xpath/4XPath/Core/test_boolean_expr.html = PASS CRASH // Since http://trac.webkit.org/changeset/85788 @@ -3813,10 +3812,6 @@ BUGWK70837 : compositing/video/video-poster.html = PASS TIMEOUT TEXT -// Intermittent ASSERT seen on the bot. -BUGWK67031 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH -BUGWK67031 SNOWLEOPARD DEBUG : fast/dom/Element/id-in-frame.html = PASS CRASH - BUGWK70866 LINUX DEBUG : fast/forms/form-associated-element-crash3.html = TIMEOUT BUGWK70971 MAC : storage/domstorage/events/basic-setattribute.html = PASS CRASH @@ -3839,17 +3834,10 @@ BUGWK71074 MAC : fast/table/border-collapsing/border-collapsing-head-foot.html = IMAGE+TEXT -BUGWK71083 MAC : fast/frames/iframe-double-scale-contents.html = PASS CRASH - BUGWK71127 : fast/js/kde/RegExp.html = TEXT BUGWK71127 : fast/js/exception-sequencing-binops2.html = TEXT BUGWK71127 : fast/js/array-prototype-properties.html = TEXT -BUGWK71139 SNOWLEOPARD : http/tests/security/cross-frame-access-custom.html = CRASH PASS -BUGWK71139 SNOWLEOPARD : fast/frames/content-opacity-2.html = CRASH PASS -BUGWK71139 SNOWLEOPARD : fast/parser/close-while-stopping.html = CRASH PASS -BUGWK71139 SNOWLEOPARD : fast/frames/sandboxed-iframe-navigation-targetlink.html = CRASH PASS - BUGWK71181 : fast/forms/input-step-as-double.html = PASS TEXT BUGWK71209 LINUX MAC GPU GPU-CG : compositing/visibility/visibility-image-layers.html = IMAGE @@ -3901,3 +3889,13 @@ BUGWK71652 WIN RELEASE : perf/document-contains.html = PASS TIMEOUT BUGWK71653 : platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html = PASS TIMEOUT + +// Intermittent assertion failures on snowleopard bots. +BUGWK59552 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : fast/dom/Element/id-in-frame.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/content-opacity-2.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : fast/parser/close-while-stopping.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/iframe-double-scale-contents.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/set-parent-src-synchronously.html = PASS CRASH + +BUGWK71658 MAC DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = PASS TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99403] trunk
Title: [99403] trunk
Revision 99403
Author kei...@webkit.org
Date 2011-11-07 03:39:32 -0800 (Mon, 07 Nov 2011)
Log Message
Change ColorChooser from singleton to ordinary object
https://bugs.webkit.org/show_bug.cgi?id=71644
Reviewed by Kent Tamura.
Source/WebCore:
Changing WebCore::ColorChooser from a singleton to an ordinary object can broaden how browsers implement the color chooser interface.
* WebCore.exp.in:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::~ColorInputType):
(WebCore::ColorInputType::setValue): If a chooser exists, calls Chrome::setSelectedColorInColorChooser
(WebCore::ColorInputType::handleDOMActivateEvent):
(WebCore::ColorInputType::detach):
(WebCore::ColorInputType::didCleanup): Called after cleanup is complete.
(WebCore::ColorInputType::cleanupColorChooser): Renamed from cleanupColorChooserIfCurrentClient.
* html/ColorInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::selectColorInColorChooser):
* html/HTMLInputElement.h:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Ditto.
* page/Chrome.cpp:
(WebCore::Chrome::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
(WebCore::Chrome::setSelectedColorInColorChooser): Ditto.
* page/Chrome.h:
* page/ChromeClient.h:
* platform/ColorChooser.cpp:
(WebCore::ColorChooserClient::~ColorChooserClient):
(WebCore::ColorChooserClient::newColorChooser): Creates a new color chooser that is connected to itself.
(WebCore::ColorChooserClient::discardChooser): Discards the connected color chooser.
(WebCore::ColorChooser::ColorChooser): ColorChooser is RefCounted.
(WebCore::ColorChooser::create): Creates a ColorChooser that is connected to the given ColorChooserClient.
(WebCore::ColorChooser::~ColorChooser):
(WebCore::ColorChooser::didChooseColor): Called from WebKit side when user chose a color. Calls ColorChooserClient::didChooseColor
(WebCore::ColorChooser::didCleanup): Called from WebKit side when user color chooser was cleaned up. Calls ColorChooserClient::didCleanup
* platform/ColorChooser.h:
(WebCore::ColorChooserClient::chooser): Returns the current ColorChooser.
(WebCore::ColorChooser::disconnectClient): Disconnects the ColorChooserClient.
* testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser): Added element argument. This calls didChooseColor on the ColorChooser of that element.
* testing/Internals.h:
* testing/Internals.idl: Removed connectColorChooserClient and updated selectColorInColorChooser.
LayoutTests:
* fast/forms/color/input-color-onchange-event.html: Changed to match the changes to window.internals object
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/color/input-color-onchange-event.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/html/ColorInputType.cpp
trunk/Source/WebCore/html/ColorInputType.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/page/Chrome.cpp
trunk/Source/WebCore/page/Chrome.h
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/platform/ColorChooser.cpp
trunk/Source/WebCore/platform/ColorChooser.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (99402 => 99403)
--- trunk/LayoutTests/ChangeLog 2011-11-07 10:51:30 UTC (rev 99402)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 11:39:32 UTC (rev 99403)
@@ -1,3 +1,12 @@
+2011-11-07 Keishi Hattori kei...@webkit.org
+
+Change ColorChooser from singleton to ordinary object
+https://bugs.webkit.org/show_bug.cgi?id=71644
+
+Reviewed by Kent Tamura.
+
+* fast/forms/color/input-color-onchange-event.html: Changed to match the changes to window.internals object
+
2011-11-07 Alexander Pavlov apav...@chromium.org
Web Inspector: Cannot edit elements commented with !--
Modified: trunk/LayoutTests/fast/forms/color/input-color-onchange-event.html (99402 => 99403)
--- trunk/LayoutTests/fast/forms/color/input-color-onchange-event.html 2011-11-07 10:51:30 UTC (rev 99402)
+++ trunk/LayoutTests/fast/forms/color/input-color-onchange-event.html 2011-11-07 11:39:32 UTC (rev 99403)
@@ -7,21 +7,32 @@
p id=description/p
div id=console/div
script
-description('Test if change event fires properly when color chooser changes. Bug 66848');
+description('Test if change event fires properly when color chooser changes. Bug 66848 br To manually test this, click on the input color element in the top left corner and change the value from the color chooser. See if the number of value changed messages matches the number of times you changed the color.');
var input =
[webkit-changes] [99404] trunk/LayoutTests
Title: [99404] trunk/LayoutTests Revision 99404 Author ph...@webkit.org Date 2011-11-07 03:46:23 -0800 (Mon, 07 Nov 2011) Log Message Unreviewed, fast/dom/gc-11.html is now passing on GTK, it seems. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99403 => 99404) --- trunk/LayoutTests/ChangeLog 2011-11-07 11:39:32 UTC (rev 99403) +++ trunk/LayoutTests/ChangeLog 2011-11-07 11:46:23 UTC (rev 99404) @@ -1,3 +1,9 @@ +2011-11-07 Philippe Normand pnorm...@igalia.com + +Unreviewed, fast/dom/gc-11.html is now passing on GTK, it seems. + +* platform/gtk/Skipped: + 2011-11-07 Keishi Hattori kei...@webkit.org Change ColorChooser from singleton to ordinary object Modified: trunk/LayoutTests/platform/gtk/Skipped (99403 => 99404) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-07 11:39:32 UTC (rev 99403) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-07 11:46:23 UTC (rev 99404) @@ -589,9 +589,6 @@ # Possible bug in eventSender.zoomPageOut() ? https://bugs.webkit.org/show_bug.cgi?id=30575 fast/dom/elementFromPoint-relative-to-viewport.html -# https://bugs.webkit.org/show_bug.cgi?id=51213 -fast/dom/gc-11.html - # https://bugs.webkit.org/show_bug.cgi?id=53085 # Cairo doesn't support repeat-x and repeat-y fast/canvas/patternfill-repeat.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99405] trunk
Title: [99405] trunk
Revision 99405
Author pfeld...@chromium.org
Date 2011-11-07 04:19:57 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: split script-formatter test into multiple tests.
https://bugs.webkit.org/show_bug.cgi?id=71607
Patch by Pavel Feldman pfeld...@chromium.org on 2011-11-07
Reviewed by Yury Semikhatsky.
Source/WebCore:
Tests: inspector/debugger/script-formatter-breakpoints.html
inspector/debugger/script-formatter-console.html
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
LayoutTests:
* inspector/debugger/script-formatter-breakpoints-expected.txt: Added.
* inspector/debugger/script-formatter-breakpoints.html: Added.
* inspector/debugger/script-formatter-console-expected.txt: Added.
* inspector/debugger/script-formatter-console.html: Added.
* inspector/debugger/script-formatter-expected.txt:
* inspector/debugger/script-formatter.html:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt
trunk/LayoutTests/inspector/debugger/script-formatter.html
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
Added Paths
trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt
trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints.html
trunk/LayoutTests/inspector/debugger/script-formatter-console-expected.txt
trunk/LayoutTests/inspector/debugger/script-formatter-console.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99404 => 99405)
--- trunk/LayoutTests/ChangeLog 2011-11-07 11:46:23 UTC (rev 99404)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 12:19:57 UTC (rev 99405)
@@ -1,3 +1,20 @@
+2011-11-07 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: split script-formatter test into multiple tests.
+https://bugs.webkit.org/show_bug.cgi?id=71607
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/script-formatter-breakpoints-expected.txt: Added.
+* inspector/debugger/script-formatter-breakpoints.html: Added.
+* inspector/debugger/script-formatter-console-expected.txt: Added.
+* inspector/debugger/script-formatter-console.html: Added.
+* inspector/debugger/script-formatter-expected.txt:
+* inspector/debugger/script-formatter.html:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+
2011-11-07 Philippe Normand pnorm...@igalia.com
Unreviewed, fast/dom/gc-11.html is now passing on GTK, it seems.
Added: trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt (0 => 99405)
--- trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt 2011-11-07 12:19:57 UTC (rev 99405)
@@ -0,0 +1,15 @@
+Tests the script formatting is working fine with breakpoints.
+
+Debugger was enabled.
+
+Running: testBreakpointsInOriginalAndFormattedSource
+Script execution paused.
+Script execution resumed.
+Page reloaded.
+Navigated to test-navigation.html
+Page reloaded.
+Navigated back to test page.
+Script execution paused.
+Script execution resumed.
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints.html (0 => 99405)
--- trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints.html (rev 0)
+++ trunk/LayoutTests/inspector/debugger/script-formatter-breakpoints.html 2011-11-07 12:19:57 UTC (rev 99405)
@@ -0,0 +1,96 @@
+html
+head
+script src=""
+script src=""
+
+script
+
+function f1()
+{
+var a=0;var b=1;var c=3;var d=4;var e=5;
+var f=0;
+return 0;
+}
+
+function f2()
+{
+var x = 0;
+return 0;
+}
+
+var test = function()
+{
+var panel = WebInspector.panels.scripts;
+
+InspectorTest.runDebuggerTestSuite([
+function testBreakpointsInOriginalAndFormattedSource(next)
+{
+var root;
+InspectorTest.showScriptSource(script-formatter-breakpoints.html, didShowScriptSource);
+
+function didShowScriptSource(sourceFrame)
+{
+root = sourceFrame._url.substr(0, sourceFrame._url.lastIndexOf(/) + 1);
+InspectorTest.setBreakpoint(sourceFrame, 10, , true);
+InspectorTest.waitUntilPaused(pausedInF1);
+InspectorTest.evaluateInPageWithTimeout(f1());
+}
+
+function pausedInF1(callFrames)
+{
+
[webkit-changes] [99406] trunk/LayoutTests
Title: [99406] trunk/LayoutTests Revision 99406 Author ph...@webkit.org Date 2011-11-07 04:44:33 -0800 (Mon, 07 Nov 2011) Log Message Unreviewed, GTK flaky tests clean-up. Moved most of them to test_expectations. * platform/gtk/Skipped: * platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt: * platform/gtk/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt trunk/LayoutTests/platform/gtk/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99405 => 99406) --- trunk/LayoutTests/ChangeLog 2011-11-07 12:19:57 UTC (rev 99405) +++ trunk/LayoutTests/ChangeLog 2011-11-07 12:44:33 UTC (rev 99406) @@ -1,3 +1,12 @@ +2011-11-07 Philippe Normand pnorm...@igalia.com + +Unreviewed, GTK flaky tests clean-up. Moved most of them to +test_expectations. + +* platform/gtk/Skipped: +* platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt: +* platform/gtk/test_expectations.txt: + 2011-11-07 Pavel Feldman pfeld...@chromium.org Web Inspector: split script-formatter test into multiple tests. Modified: trunk/LayoutTests/platform/gtk/Skipped (99405 => 99406) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-07 12:19:57 UTC (rev 99405) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-07 12:44:33 UTC (rev 99406) @@ -34,58 +34,6 @@ ### # FLAKY TESTS ### -# Anonymous flaky tests. -fast/block/float/marquee-shrink-to-avoid-floats.html -fast/events/overflow-events.html -http/tests/xmlhttprequest/interactive-state.html -media/event-attributes.html -platform/gtk/accessibility/name-from-label.html - -# As explained in https://bugs.webkit.org/show_bug.cgi?id=34372 this -# test seems to suffer from a race condition that just turned to the -# failing side with the normalization of priorities; it used to fail -# consistently for me locally (k...@webkit.org), and now passes from -# time to time, but the situation is inversed in the bot, so I'm -# skipping it. -# See also https://bugs.webkit.org/show_bug.cgi?id=36165 -media/video-played-collapse.html - -# https://bugs.webkit.org/show_bug.cgi?id=37550 -fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html - -# https://bugs.webkit.org/show_bug.cgi?id=37557 -http/tests/misc/image-blocked-src-change.html - -# https://bugs.webkit.org/show_bug.cgi?id=37560 -svg/dom/SVGScriptElement/script-set-href.svg - -# https://bugs.webkit.org/show_bug.cgi?id=37562 -plugins/update-widgets-crash.html - -# https://bugs.webkit.org/show_bug.cgi?id=37572 -plugins/open-and-close-window-with-plugin.html - -# Flaky due to JSC debugger issue. -# https://bugs.webkit.org/show_bug.cgi?id=43034 -inspector/debugger/debugger-breakpoints-not-activated-on-reload.html - -# https://bugs.webkit.org/show_bug.cgi?id=53995 -editing/selection/end-of-document.html - -# https://bugs.webkit.org/show_bug.cgi?id=51325 -editing/selection/extend-by-character-003.html - -# https://bugs.webkit.org/show_bug.cgi?id=51699 -editing/selection/extend-by-character-004.html -editing/selection/extend-by-character-005.html - -# https://bugs.webkit.org/show_bug.cgi?id=53074 -editing/selection/extend-selection-bidi.html - -# This test is randomly failing on the GTK 32-bit Debug bot -# https://bugs.webkit.org/show_bug.cgi?id=61932 -jquery/manipulation.html - # Still working out flakiness issues with the perf tests. # https://bugs.webkit.org/show_bug.cgi?id=44199 perf/ @@ -93,40 +41,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=47727 mathml/presentation -# https://bugs.webkit.org/show_bug.cgi?id=53428 -http/tests/misc/favicon-as-image.html - -# 1 2 pixels diff in 32-bit 64-bit -# https://bugs.webkit.org/show_bug.cgi?id=54637 -media/video-display-toggle.html -media/video-controls-in-media-document.html -media/controls-after-reload.html - -# 1 2 pixels diff in 32-bit 64-bit -# https://bugs.webkit.org/show_bug.cgi?id=61914 -svg/custom/object-sizing-explicit-width-height.xhtml -svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml -svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml - -# https://bugs.webkit.org/show_bug.cgi?id=55126 -media/video-aspect-ratio.html - -# https://bugs.webkit.org/show_bug.cgi?id=37623 -scrollbars/scrollbar-crash-on-refresh.html - -# https://bugs.webkit.org/show_bug.cgi?id=22770 -tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html - -# https://bugs.webkit.org/show_bug.cgi?id=61852 -svg/custom/animate-target-id-changed.svg - -# https://bugs.webkit.org/show_bug.cgi?id=56561 -svg/custom/clip-path-referencing-use2.svg - -# https://bugs.webkit.org/show_bug.cgi?id=59937 -# flaky on 64-bits Debug
[webkit-changes] [99408] trunk/Source/WebCore
Title: [99408] trunk/Source/WebCore Revision 99408 Author pfeld...@chromium.org Date 2011-11-07 05:22:09 -0800 (Mon, 07 Nov 2011) Log Message Web Inspector: introduce UserAgent override setting. https://bugs.webkit.org/show_bug.cgi?id=71627 Patch by Pavel Feldman pfeld...@chromium.org on 2011-11-07 Reviewed by Yury Semikhatsky. * English.lproj/localizedStrings.js: * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::applyUserAgentOverride): (WebCore::InspectorResourceAgent::setUserAgentOverride): * inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype.show): (WebInspector.HelpScreen.prototype._onBlur): * inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged): (WebInspector.NetworkManager.prototype._userAgentSettingChanged): * inspector/front-end/Settings.js: (WebInspector.Settings): * inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._createSelectSetting.get for): (WebInspector.SettingsScreen.prototype._createCustomSetting): (WebInspector.SettingsScreen.prototype._createUserActionControl.checkboxClicked): (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const): (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textDoubleClicked): (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textChanged): * inspector/front-end/helpScreen.css: (.help-table td): (.help-content fieldset label): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp trunk/Source/WebCore/inspector/front-end/HelpScreen.js trunk/Source/WebCore/inspector/front-end/NetworkManager.js trunk/Source/WebCore/inspector/front-end/Settings.js trunk/Source/WebCore/inspector/front-end/SettingsScreen.js trunk/Source/WebCore/inspector/front-end/helpScreen.css Diff Modified: trunk/Source/WebCore/ChangeLog (99407 => 99408) --- trunk/Source/WebCore/ChangeLog 2011-11-07 12:50:02 UTC (rev 99407) +++ trunk/Source/WebCore/ChangeLog 2011-11-07 13:22:09 UTC (rev 99408) @@ -1,3 +1,36 @@ +2011-11-07 Pavel Feldman pfeld...@chromium.org + +Web Inspector: introduce UserAgent override setting. +https://bugs.webkit.org/show_bug.cgi?id=71627 + +Reviewed by Yury Semikhatsky. + +* English.lproj/localizedStrings.js: +* inspector/InspectorResourceAgent.cpp: +(WebCore::InspectorResourceAgent::clearFrontend): +(WebCore::InspectorResourceAgent::applyUserAgentOverride): +(WebCore::InspectorResourceAgent::setUserAgentOverride): +* inspector/front-end/HelpScreen.js: +(WebInspector.HelpScreen): +(WebInspector.HelpScreen.prototype.show): +(WebInspector.HelpScreen.prototype._onBlur): +* inspector/front-end/NetworkManager.js: +(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged): +(WebInspector.NetworkManager.prototype._userAgentSettingChanged): +* inspector/front-end/Settings.js: +(WebInspector.Settings): +* inspector/front-end/SettingsScreen.js: +(WebInspector.SettingsScreen): +(WebInspector.SettingsScreen.prototype._createSelectSetting.get for): +(WebInspector.SettingsScreen.prototype._createCustomSetting): +(WebInspector.SettingsScreen.prototype._createUserActionControl.checkboxClicked): +(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const): +(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textDoubleClicked): +(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textChanged): +* inspector/front-end/helpScreen.css: +(.help-table td): +(.help-content fieldset label): + 2011-11-07 Alexander Pavlov apav...@chromium.org Web Inspector: autocomplete combobox for Styles sidebar and Console. Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (Binary files differ) Modified: trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp (99407 => 99408) --- trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp 2011-11-07 12:50:02 UTC (rev 99407) +++ trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp 2011-11-07 13:22:09 UTC (rev 99408) @@ -73,6 +73,7 @@ static const char resourceAgentEnabled[] = resourceAgentEnabled; static const char extraRequestHeaders[] = extraRequestHeaders; static const char cacheDisabled[] = cacheDisabled; +static const char userAgentOverride[] = userAgentOverride; } void InspectorResourceAgent::setFrontend(InspectorFrontend* frontend) @@ -85,7 +86,6 @@ m_frontend = 0; ErrorString error; disable(error); -m_userAgentOverride = ; } void InspectorResourceAgent::restore() @@ -348,8
[webkit-changes] [99409] trunk/Source/WebCore
Title: [99409] trunk/Source/WebCore
Revision 99409
Author andreas.kl...@nokia.com
Date 2011-11-07 05:31:31 -0800 (Mon, 07 Nov 2011)
Log Message
CSSValue: Devirtualize cssValueType().
http://webkit.org/b/71667
Reviewed by Antti Koivisto.
Keep the cssValueType in a CSSValue member instead of using
virtual functions.
This is part of a project to completely devirtualize CSSValue
http://webkit.org/b/71666 and will incur a temporary object
size regression for CSSValue while the work is ongoing.
* css/CSSInheritedValue.cpp:
* css/CSSInheritedValue.h:
(WebCore::CSSInheritedValue::CSSInheritedValue):
* css/CSSInitialValue.cpp:
* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::CSSInitialValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValue.h:
* css/CSSValue.h:
(WebCore::CSSValue::cssValueType):
(WebCore::CSSValue::CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
* css/CSSValueList.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSInheritedValue.cpp
trunk/Source/WebCore/css/CSSInheritedValue.h
trunk/Source/WebCore/css/CSSInitialValue.cpp
trunk/Source/WebCore/css/CSSInitialValue.h
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
trunk/Source/WebCore/css/CSSPrimitiveValue.h
trunk/Source/WebCore/css/CSSValue.h
trunk/Source/WebCore/css/CSSValueList.cpp
trunk/Source/WebCore/css/CSSValueList.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99408 => 99409)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 13:22:09 UTC (rev 99408)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 13:31:31 UTC (rev 99409)
@@ -1,3 +1,33 @@
+2011-11-06 Andreas Kling kl...@webkit.org
+
+CSSValue: Devirtualize cssValueType().
+http://webkit.org/b/71667
+
+Reviewed by Antti Koivisto.
+
+Keep the cssValueType in a CSSValue member instead of using
+virtual functions.
+
+This is part of a project to completely devirtualize CSSValue
+http://webkit.org/b/71666 and will incur a temporary object
+size regression for CSSValue while the work is ongoing.
+
+* css/CSSInheritedValue.cpp:
+* css/CSSInheritedValue.h:
+(WebCore::CSSInheritedValue::CSSInheritedValue):
+* css/CSSInitialValue.cpp:
+* css/CSSInitialValue.h:
+(WebCore::CSSInitialValue::CSSInitialValue):
+* css/CSSPrimitiveValue.cpp:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+* css/CSSPrimitiveValue.h:
+* css/CSSValue.h:
+(WebCore::CSSValue::cssValueType):
+(WebCore::CSSValue::CSSValue):
+* css/CSSValueList.cpp:
+(WebCore::CSSValueList::CSSValueList):
+* css/CSSValueList.h:
+
2011-11-07 Pavel Feldman pfeld...@chromium.org
Web Inspector: introduce UserAgent override setting.
Modified: trunk/Source/WebCore/css/CSSInheritedValue.cpp (99408 => 99409)
--- trunk/Source/WebCore/css/CSSInheritedValue.cpp 2011-11-07 13:22:09 UTC (rev 99408)
+++ trunk/Source/WebCore/css/CSSInheritedValue.cpp 2011-11-07 13:31:31 UTC (rev 99409)
@@ -25,11 +25,6 @@
namespace WebCore {
-unsigned short CSSInheritedValue::cssValueType() const
-{
-return CSS_INHERIT;
-}
-
String CSSInheritedValue::cssText() const
{
return inherit;
Modified: trunk/Source/WebCore/css/CSSInheritedValue.h (99408 => 99409)
--- trunk/Source/WebCore/css/CSSInheritedValue.h 2011-11-07 13:22:09 UTC (rev 99408)
+++ trunk/Source/WebCore/css/CSSInheritedValue.h 2011-11-07 13:31:31 UTC (rev 99409)
@@ -36,8 +36,10 @@
virtual String cssText() const;
private:
-CSSInheritedValue() { }
-virtual unsigned short cssValueType() const;
+CSSInheritedValue()
+: CSSValue(CSS_INHERIT)
+{
+}
};
} // namespace WebCore
Modified: trunk/Source/WebCore/css/CSSInitialValue.cpp (99408 => 99409)
--- trunk/Source/WebCore/css/CSSInitialValue.cpp 2011-11-07 13:22:09 UTC (rev 99408)
+++ trunk/Source/WebCore/css/CSSInitialValue.cpp 2011-11-07 13:31:31 UTC (rev 99409)
@@ -25,11 +25,6 @@
namespace WebCore {
-unsigned short CSSInitialValue::cssValueType() const
-{
-return CSS_INITIAL;
-}
-
String CSSInitialValue::cssText() const
{
return initial;
Modified: trunk/Source/WebCore/css/CSSInitialValue.h (99408 => 99409)
--- trunk/Source/WebCore/css/CSSInitialValue.h 2011-11-07 13:22:09 UTC (rev 99408)
+++ trunk/Source/WebCore/css/CSSInitialValue.h 2011-11-07 13:31:31 UTC (rev 99409)
@@ -43,7 +43,8 @@
private:
CSSInitialValue(bool implicit)
-: m_implicit(implicit)
+: CSSValue(CSS_INITIAL)
+, m_implicit(implicit)
{
}
@@ -52,7 +53,6 @@
return adoptRef(new CSSInitialValue(implicit));
}
-virtual unsigned short cssValueType() const;
virtual bool isImplicitInitialValue() const { return m_implicit; }
bool m_implicit;
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (99408 => 99409)
---
[webkit-changes] [99411] trunk
Title: [99411] trunk
Revision 99411
Author ca...@chromium.org
Date 2011-11-07 05:43:17 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: use toString as the Date object description.
https://bugs.webkit.org/show_bug.cgi?id=71605
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/remote-object.html
* inspector/InjectedScriptSource.js:
(.):
LayoutTests:
* inspector/remote-object-expected.txt: Added.
* inspector/remote-object.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
Added Paths
trunk/LayoutTests/inspector/remote-object-expected.txt
trunk/LayoutTests/inspector/remote-object.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99410 => 99411)
--- trunk/LayoutTests/ChangeLog 2011-11-07 13:40:40 UTC (rev 99410)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 13:43:17 UTC (rev 99411)
@@ -1,3 +1,13 @@
+2011-11-07 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: use toString as the Date object description.
+https://bugs.webkit.org/show_bug.cgi?id=71605
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/remote-object-expected.txt: Added.
+* inspector/remote-object.html: Added.
+
2011-11-07 Philippe Normand pnorm...@igalia.com
Unreviewed, GTK flaky tests clean-up. Moved most of them to
Added: trunk/LayoutTests/inspector/remote-object-expected.txt (0 => 99411)
--- trunk/LayoutTests/inspector/remote-object-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/remote-object-expected.txt 2011-11-07 13:43:17 UTC (rev 99411)
@@ -0,0 +1,4 @@
+Tests formatting of different types of remote objects.
+
+date = Wed Dec 07 2011 12:01:00
+
Property changes on: trunk/LayoutTests/inspector/remote-object-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/remote-object.html (0 => 99411)
--- trunk/LayoutTests/inspector/remote-object.html (rev 0)
+++ trunk/LayoutTests/inspector/remote-object.html 2011-11-07 13:43:17 UTC (rev 99411)
@@ -0,0 +1,25 @@
+html
+head
+script src=""
+script
+
+function test()
+{
+function callback(result)
+{
+InspectorTest.addResult(date = + result.description.substring(0, 25));
+InspectorTest.completeTest();
+}
+InspectorTest.evaluateInPage(new Date(2011, 11, 7, 12, 01), callback);
+}
+
+/script
+/head
+
+body _onload_=runTest()
+p
+Tests formatting of different types of remote objects.
+/p
+
+/body
+/html
Property changes on: trunk/LayoutTests/inspector/remote-object.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (99410 => 99411)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 13:40:40 UTC (rev 99410)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 13:43:17 UTC (rev 99411)
@@ -1,3 +1,15 @@
+2011-11-07 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: use toString as the Date object description.
+https://bugs.webkit.org/show_bug.cgi?id=71605
+
+Reviewed by Yury Semikhatsky.
+
+Test: inspector/remote-object.html
+
+* inspector/InjectedScriptSource.js:
+(.):
+
2011-10-26 Andrey Kosyakov ca...@chromium.org
Web Inspector: [refactoring] get JS-specific methods out of SourceFrame
Modified: trunk/Source/WebCore/inspector/InjectedScriptSource.js (99410 => 99411)
--- trunk/Source/WebCore/inspector/InjectedScriptSource.js 2011-11-07 13:40:40 UTC (rev 99410)
+++ trunk/Source/WebCore/inspector/InjectedScriptSource.js 2011-11-07 13:43:17 UTC (rev 99411)
@@ -430,6 +430,9 @@
if (subtype === regexp)
return this._toString(obj);
+if (subtype === date)
+return this._toString(obj);
+
var className = InjectedScriptHost.internalConstructorName(obj);
if (subtype === array) {
if (typeof obj.length === number)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99412] trunk/Source/WebCore
Title: [99412] trunk/Source/WebCore
Revision 99412
Author andreas.kl...@nokia.com
Date 2011-11-07 05:46:37 -0800 (Mon, 07 Nov 2011)
Log Message
CSSPrimitiveValue: Remove unused virtual function parseString().
http://webkit.org/b/71671
Reviewed by Antti Koivisto.
* css/CSSPrimitiveValue.cpp:
* css/CSSPrimitiveValue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
trunk/Source/WebCore/css/CSSPrimitiveValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99411 => 99412)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 13:43:17 UTC (rev 99411)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 13:46:37 UTC (rev 99412)
@@ -1,3 +1,13 @@
+2011-11-07 Andreas Kling kl...@webkit.org
+
+CSSPrimitiveValue: Remove unused virtual function parseString().
+http://webkit.org/b/71671
+
+Reviewed by Antti Koivisto.
+
+* css/CSSPrimitiveValue.cpp:
+* css/CSSPrimitiveValue.h:
+
2011-11-07 Andrey Kosyakov ca...@chromium.org
Web Inspector: use toString as the Date object description.
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (99411 => 99412)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2011-11-07 13:43:17 UTC (rev 99411)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2011-11-07 13:46:37 UTC (rev 99412)
@@ -670,12 +670,6 @@
return m_value.pair;
}
-bool CSSPrimitiveValue::parseString(const String /*string*/, bool /*strict*/)
-{
-// FIXME
-return false;
-}
-
int CSSPrimitiveValue::getIdent() const
{
if (m_type != CSS_IDENT)
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (99411 => 99412)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-11-07 13:43:17 UTC (rev 99411)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-11-07 13:46:37 UTC (rev 99412)
@@ -207,7 +207,6 @@
int getIdent() const;
templatetypename T inline operator T() const; // Defined in CSSPrimitiveValueMappings.h
-virtual bool parseString(const String, bool = false);
virtual String cssText() const;
bool isQuirkValue() { return m_isQuirkValue; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99413] trunk/LayoutTests
Title: [99413] trunk/LayoutTests Revision 99413 Author o...@webkit.org Date 2011-11-07 06:04:34 -0800 (Mon, 07 Nov 2011) Log Message [Qt] Skip a new failing test on Qt https://bugs.webkit.org/show_bug.cgi?id=70893 Patch by Ben Wells benwe...@chromium.org on 2011-11-07 Reviewed by Csaba Osztrogonác. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99412 => 99413) --- trunk/LayoutTests/ChangeLog 2011-11-07 13:46:37 UTC (rev 99412) +++ trunk/LayoutTests/ChangeLog 2011-11-07 14:04:34 UTC (rev 99413) @@ -1,3 +1,12 @@ +2011-11-07 Ben Wells benwe...@chromium.org + +[Qt] Skip a new failing test on Qt +https://bugs.webkit.org/show_bug.cgi?id=70893 + +Reviewed by Csaba Osztrogonác. + +* platform/qt/Skipped: + 2011-11-07 Andrey Kosyakov ca...@chromium.org Web Inspector: use toString as the Date object description. Modified: trunk/LayoutTests/platform/qt/Skipped (99412 => 99413) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-07 13:46:37 UTC (rev 99412) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-07 14:04:34 UTC (rev 99413) @@ -2459,9 +2459,10 @@ # https://bugs.webkit.org/show_bug.cgi?id=70593 fast/events/touch/page-scaled-touch-gesture-click.html -# fast/canvas/canvas-composite-image.html is failing +# fast/canvas/canvas-composite-image.html and -canvas.html is failing # https://bugs.webkit.org/show_bug.cgi?id=70893 fast/canvas/canvas-composite-image.html +fast/canvas/canvas-composite-canvas.html # [Qt] inspector/extensions/extensions-console.html is failing # https://bugs.webkit.org/show_bug.cgi?id=70905 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99414] trunk/Source/WebKit/chromium
Title: [99414] trunk/Source/WebKit/chromium
Revision 99414
Author commit-qu...@webkit.org
Date 2011-11-07 06:09:57 -0800 (Mon, 07 Nov 2011)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-07
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (99413 => 99414)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-07 14:04:34 UTC (rev 99413)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-07 14:09:57 UTC (rev 99414)
@@ -1,3 +1,9 @@
+2011-11-07 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2011-11-05 Daniel Cheng dch...@chromium.org
[chromium] Use the security origin instead of the URL when checking notification permissions
Modified: trunk/Source/WebKit/chromium/DEPS (99413 => 99414)
--- trunk/Source/WebKit/chromium/DEPS 2011-11-07 14:04:34 UTC (rev 99413)
+++ trunk/Source/WebKit/chromium/DEPS 2011-11-07 14:09:57 UTC (rev 99414)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '108476'
+ 'chromium_rev': '108839'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99415] trunk/Source/WebCore
Title: [99415] trunk/Source/WebCore
Revision 99415
Author andreas.kl...@nokia.com
Date 2011-11-07 06:10:56 -0800 (Mon, 07 Nov 2011)
Log Message
CSSImageValue: Remove inheritance from CachedImageClient.
http://webkit.org/b/71675
Reviewed by Antti Koivisto.
CSSImageValue doesn't actually use any of the CachedImageClient
functionality, and holds a reference to the resource via the
CachedResourceHandle in StyleCachedImage.
So we can safely remove the multiple inheritance and simplify
the class.
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::~CSSImageValue):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::clearCachedImage):
* css/CSSImageValue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSImageValue.cpp
trunk/Source/WebCore/css/CSSImageValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99414 => 99415)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 14:09:57 UTC (rev 99414)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 14:10:56 UTC (rev 99415)
@@ -1,5 +1,25 @@
2011-11-07 Andreas Kling kl...@webkit.org
+CSSImageValue: Remove inheritance from CachedImageClient.
+http://webkit.org/b/71675
+
+Reviewed by Antti Koivisto.
+
+CSSImageValue doesn't actually use any of the CachedImageClient
+functionality, and holds a reference to the resource via the
+CachedResourceHandle in StyleCachedImage.
+
+So we can safely remove the multiple inheritance and simplify
+the class.
+
+* css/CSSImageValue.cpp:
+(WebCore::CSSImageValue::~CSSImageValue):
+(WebCore::CSSImageValue::cachedImage):
+(WebCore::CSSImageValue::clearCachedImage):
+* css/CSSImageValue.h:
+
+2011-11-07 Andreas Kling kl...@webkit.org
+
CSSPrimitiveValue: Remove unused virtual function parseString().
http://webkit.org/b/71671
Modified: trunk/Source/WebCore/css/CSSImageValue.cpp (99414 => 99415)
--- trunk/Source/WebCore/css/CSSImageValue.cpp 2011-11-07 14:09:57 UTC (rev 99414)
+++ trunk/Source/WebCore/css/CSSImageValue.cpp 2011-11-07 14:10:56 UTC (rev 99415)
@@ -45,8 +45,6 @@
CSSImageValue::~CSSImageValue()
{
-if (m_image m_image-isCachedImage())
-static_castStyleCachedImage*(m_image.get())-cachedImage()-removeClient(this);
}
StyleImage* CSSImageValue::cachedOrPendingImage()
@@ -73,10 +71,8 @@
m_accessedImage = true;
ResourceRequest request(loader-document()-completeURL(url));
-if (CachedImage* cachedImage = loader-requestImage(request)) {
-cachedImage-addClient(this);
+if (CachedImage* cachedImage = loader-requestImage(request))
m_image = StyleCachedImage::create(cachedImage);
-}
}
return (m_image m_image-isCachedImage()) ? static_castStyleCachedImage*(m_image.get()) : 0;
@@ -91,8 +87,6 @@
void CSSImageValue::clearCachedImage()
{
-if (m_image m_image-isCachedImage())
-static_castStyleCachedImage*(m_image.get())-cachedImage()-removeClient(this);
m_image = 0;
m_accessedImage = false;
}
Modified: trunk/Source/WebCore/css/CSSImageValue.h (99414 => 99415)
--- trunk/Source/WebCore/css/CSSImageValue.h 2011-11-07 14:09:57 UTC (rev 99414)
+++ trunk/Source/WebCore/css/CSSImageValue.h 2011-11-07 14:10:56 UTC (rev 99415)
@@ -22,7 +22,6 @@
#define CSSImageValue_h
#include CSSPrimitiveValue.h
-#include CachedImage.h
#include wtf/RefPtr.h
namespace WebCore {
@@ -31,7 +30,7 @@
class StyleCachedImage;
class StyleImage;
-class CSSImageValue : public CSSPrimitiveValue, private CachedImageClient {
+class CSSImageValue : public CSSPrimitiveValue {
WTF_MAKE_FAST_ALLOCATED;
public:
static PassRefPtrCSSImageValue create() { return adoptRef(new CSSImageValue); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99416] trunk/Source/WebCore
Title: [99416] trunk/Source/WebCore
Revision 99416
Author vse...@chromium.org
Date 2011-11-07 06:20:23 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: Add advanced search shortcut to ShortcutsScreen.
https://bugs.webkit.org/show_bug.cgi?id=71302
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.createShortcut):
* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99415 => 99416)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 14:10:56 UTC (rev 99415)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 14:20:23 UTC (rev 99416)
@@ -1,3 +1,16 @@
+2011-11-07 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Add advanced search shortcut to ShortcutsScreen.
+https://bugs.webkit.org/show_bug.cgi?id=71302
+
+Reviewed by Pavel Feldman.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/AdvancedSearchController.js:
+(WebInspector.AdvancedSearchController.createShortcut):
+* inspector/front-end/inspector.js:
+(WebInspector._registerShortcuts):
+
2011-11-07 Andreas Kling kl...@webkit.org
CSSImageValue: Remove inheritance from CachedImageClient.
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js (99415 => 99416)
--- trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2011-11-07 14:10:56 UTC (rev 99415)
+++ trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2011-11-07 14:20:23 UTC (rev 99416)
@@ -41,7 +41,10 @@
WebInspector.AdvancedSearchController.createShortcut = function()
{
-return WebInspector.KeyboardShortcut.makeDescriptor(f, WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta | WebInspector.KeyboardShortcut.Modifiers.Shift);
+if (WebInspector.isMac())
+return WebInspector.KeyboardShortcut.makeDescriptor(f, WebInspector.KeyboardShortcut.Modifiers.Meta | WebInspector.KeyboardShortcut.Modifiers.Alt);
+else
+return WebInspector.KeyboardShortcut.makeDescriptor(f, WebInspector.KeyboardShortcut.Modifiers.Ctrl | WebInspector.KeyboardShortcut.Modifiers.Shift);
}
WebInspector.AdvancedSearchController.prototype = {
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (99415 => 99416)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2011-11-07 14:10:56 UTC (rev 99415)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2011-11-07 14:20:23 UTC (rev 99416)
@@ -553,6 +553,10 @@
section.addRelatedKeys(keys, WebInspector.UIString(Next/previous panel));
section.addKey(shortcut.shortcutToString(shortcut.Keys.Esc), WebInspector.UIString(Toggle console));
section.addKey(shortcut.shortcutToString(f, shortcut.Modifiers.CtrlOrMeta), WebInspector.UIString(Search));
+
+var advancedSearchShortcut = WebInspector.AdvancedSearchController.createShortcut();
+section.addKey(advancedSearchShortcut.name, WebInspector.UIString(Search across all scripts));
+
if (WebInspector.isMac()) {
keys = [
shortcut.shortcutToString(g, shortcut.Modifiers.Meta),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99417] trunk/Source
Title: [99417] trunk/Source
Revision 99417
Author yu...@chromium.org
Date 2011-11-07 06:30:41 -0800 (Mon, 07 Nov 2011)
Log Message
[Chromium] Web Inspector: use native worker inspector instead of fake workers
https://bugs.webkit.org/show_bug.cgi?id=71670
Source/WebCore:
Removed context menu option for switching between native and fake workers
debugger. Native debugger is used by default on platforms that support it.
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
* inspector/front-end/scriptsPanel.css:
(#shared-workers-list):
Source/WebKit/chromium:
chrome://workers link is replaced with instructions on discovering shared workers
in Task Manager.
Reviewed by Pavel Feldman.
* src/js/DevTools.js:
():
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/WorkersSidebarPane.js
trunk/Source/WebCore/inspector/front-end/scriptsPanel.css
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/DevTools.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99416 => 99417)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 14:20:23 UTC (rev 99416)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 14:30:41 UTC (rev 99417)
@@ -1,3 +1,24 @@
+2011-11-07 Yury Semikhatsky yu...@chromium.org
+
+[Chromium] Web Inspector: use native worker inspector instead of fake workers
+https://bugs.webkit.org/show_bug.cgi?id=71670
+
+Removed context menu option for switching between native and fake workers
+debugger. Native debugger is used by default on platforms that support it.
+
+Reviewed by Pavel Feldman.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
+* inspector/front-end/Settings.js:
+(WebInspector.Settings):
+* inspector/front-end/WorkersSidebarPane.js:
+(WebInspector.WorkerListSidebarPane):
+(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
+* inspector/front-end/scriptsPanel.css:
+(#shared-workers-list):
+
2011-11-07 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Add advanced search shortcut to ShortcutsScreen.
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (99416 => 99417)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-11-07 14:20:23 UTC (rev 99416)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-11-07 14:30:41 UTC (rev 99417)
@@ -117,9 +117,7 @@
this.sidebarPanes.eventListenerBreakpoints = new WebInspector.EventListenerBreakpointsSidebarPane();
}
-if (Preferences.canInspectWorkers WebInspector.workerManager)
-this.sidebarElement.addEventListener(contextmenu, this._contextMenu.bind(this), false);
-if (Preferences.canInspectWorkers WebInspector.workerManager WebInspector.settings.workerInspectionEnabled.get()) {
+if (Preferences.canInspectWorkers WebInspector.workerManager) {
WorkerAgent.setWorkerInspectionEnabled(true);
this.sidebarPanes.workerList = new WebInspector.WorkerListSidebarPane(WebInspector.workerManager);
} else
@@ -1146,32 +1144,6 @@
{
this._toggleFormatSourceButton.toggled = !this._toggleFormatSourceButton.toggled;
this._presentationModel.setFormatSource(this._toggleFormatSourceButton.toggled);
-},
-
-_contextMenu: function(event)
-{
-var contextMenu = new WebInspector.ContextMenu();
-
-function enableWorkerInspection()
-{
-var newValue = !WebInspector.settings.workerInspectionEnabled.get();
-WebInspector.settings.workerInspectionEnabled.set(newValue);
-WorkerAgent.setWorkerInspectionEnabled(newValue);
-if (newValue) {
-var element = this.sidebarPanes.workers.element;
-delete this.sidebarPanes.workers;
-this.sidebarPanes.workerList = new WebInspector.WorkerListSidebarPane(WebInspector.workerManager);
-element.parentNode.replaceChild(this.sidebarPanes.workerList.element, element);
-} else {
-var element = this.sidebarPanes.workerList.element;
-delete this.sidebarPanes.workerList;
-this.sidebarPanes.workers = new WebInspector.WorkersSidebarPane();
-
[webkit-changes] [99418] trunk
Title: [99418] trunk
Revision 99418
Author hausm...@webkit.org
Date 2011-11-07 06:32:57 -0800 (Mon, 07 Nov 2011)
Log Message
[Qt] Fix failing inspector tests after build system changes https://bugs.webkit.org/show_bug.cgi?id=71677
Reviewed by Tor Arne Vestbø.
Source/WebKit/qt:
Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.
* Api/qwebpage.cpp:
(initResources):
(QWebPagePrivate::QWebPagePrivate):
Source/WebKit2:
Ensure symbols from the qt resource system are referenced
from outside the static webcore library. One way of doing that is
to initialize the resources right away, as explained in the documentation
of th Qt resource system.
* WebProcess/WebPage/qt/WebPageQt.cpp:
(initResources):
(WebKit::WebPage::platformInitialize):
LayoutTests:
* platform/qt/Skipped: Unskip previously failing tests.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebKit/qt/Api/qwebpage.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (99417 => 99418)
--- trunk/LayoutTests/ChangeLog 2011-11-07 14:30:41 UTC (rev 99417)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 14:32:57 UTC (rev 99418)
@@ -1,3 +1,12 @@
+2011-11-07 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Fix failing inspector tests after build system changes
+https://bugs.webkit.org/show_bug.cgi?id=71677
+
+Reviewed by Tor Arne Vestbø.
+
+* platform/qt/Skipped: Unskip previously failing tests.
+
2011-11-07 Ben Wells benwe...@chromium.org
[Qt] Skip a new failing test on Qt
Modified: trunk/LayoutTests/platform/qt/Skipped (99417 => 99418)
--- trunk/LayoutTests/platform/qt/Skipped 2011-11-07 14:30:41 UTC (rev 99417)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-11-07 14:32:57 UTC (rev 99418)
@@ -2521,11 +2521,6 @@
fast/events/platform-wheelevent-paging-y-in-scrolling-div.html
fast/events/platform-wheelevent-paging-y-in-scrolling-page.html
-# disable inspector tests temporarily because of a bug near build system refactoring
-http/tests/inspector-enabled
-http/tests/inspector
-inspector
-
# disable a few more failures due to build system refactoring.
editing/deleting/5408255.html
editing/deleting/deletionUI-single-instance.html
Modified: trunk/Source/WebKit/qt/Api/qwebpage.cpp (99417 => 99418)
--- trunk/Source/WebKit/qt/Api/qwebpage.cpp 2011-11-07 14:30:41 UTC (rev 99417)
+++ trunk/Source/WebKit/qt/Api/qwebpage.cpp 2011-11-07 14:32:57 UTC (rev 99418)
@@ -291,6 +291,17 @@
return result;
}
+static void initResources()
+{
+static bool initialized = false;
+if (initialized)
+return;
+Q_INIT_RESOURCE(WebKit);
+Q_INIT_RESOURCE(WebCore);
+Q_INIT_RESOURCE(InspectorBackendStub);
+initialized = true;
+}
+
QWebPagePrivate::QWebPagePrivate(QWebPage *qq)
: q(qq)
, page(0)
@@ -315,6 +326,7 @@
, inspectorIsInternalOnly(false)
, m_lastDropAction(Qt::IgnoreAction)
{
+initResources();
WebCore::InitializeLoggingChannelsIfNecessary();
ScriptController::initializeThreading();
WTF::initializeMainThread();
Modified: trunk/Source/WebKit/qt/ChangeLog (99417 => 99418)
--- trunk/Source/WebKit/qt/ChangeLog 2011-11-07 14:30:41 UTC (rev 99417)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-11-07 14:32:57 UTC (rev 99418)
@@ -1,3 +1,19 @@
+2011-11-07 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Fix failing inspector tests after build system changes
+https://bugs.webkit.org/show_bug.cgi?id=71677
+
+Reviewed by Tor Arne Vestbø.
+
+Ensure symbols from the qt resource system are referenced
+from outside the static webcore library. One way of doing that is
+to initialize the resources right away, as explained in the documentation
+of th Qt resource system.
+
+* Api/qwebpage.cpp:
+(initResources):
+(QWebPagePrivate::QWebPagePrivate):
+
2011-11-04 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Refactor and clean up the qmake build system
Modified: trunk/Source/WebKit2/ChangeLog (99417 => 99418)
--- trunk/Source/WebKit2/ChangeLog 2011-11-07 14:30:41 UTC (rev 99417)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-07 14:32:57 UTC (rev 99418)
@@ -1,3 +1,19 @@
+2011-11-07 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Fix failing inspector tests after build system changes
+https://bugs.webkit.org/show_bug.cgi?id=71677
+
+Reviewed by Tor Arne Vestbø.
+
+Ensure symbols from the qt resource system are referenced
+from outside the static webcore library. One way of doing that is
+to initialize the resources right away, as explained in the documentation
+of th Qt resource
[webkit-changes] [99419] trunk/Tools
Title: [99419] trunk/Tools
Revision 99419
Author ves...@webkit.org
Date 2011-11-07 06:42:42 -0800 (Mon, 07 Nov 2011)
Log Message
[Qt] Print right order for changing feature defines
Reviewed by Simon Hausmann.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (99418 => 99419)
--- trunk/Tools/ChangeLog 2011-11-07 14:32:57 UTC (rev 99418)
+++ trunk/Tools/ChangeLog 2011-11-07 14:42:42 UTC (rev 99419)
@@ -1,3 +1,12 @@
+2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Print right order for changing feature defines
+
+Reviewed by Simon Hausmann.
+
+* Scripts/webkitdirs.pm:
+(buildQMakeProject):
+
2011-11-06 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed trivial fix after build system refactoring.
Modified: trunk/Tools/Scripts/webkitdirs.pm (99418 => 99419)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-11-07 14:32:57 UTC (rev 99418)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-11-07 14:42:42 UTC (rev 99419)
@@ -1764,7 +1764,7 @@
}
if ($defines{$1} != $2) {
-print Feature $1 has changed ($defines{$1} - $2);
+print Feature $1 has changed ($2 - $defines{$1});
$needsCleanBuild = 1;
last;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99420] trunk/Tools
Title: [99420] trunk/Tools
Revision 99420
Author ves...@webkit.org
Date 2011-11-07 06:43:01 -0800 (Mon, 07 Nov 2011)
Log Message
[Qt] Sanitize qmake paths correctly before comparing
The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
which caused us to always generate derived webcore sources, but never build
them. The bug has been fixed, and we now also sanitize paths for the injected
bundle derived sources.
Reviewed-by Simon Husmann.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/DerivedSources.pri
trunk/Tools/qmake/mkspecs/features/functions.prf
Diff
Modified: trunk/Tools/ChangeLog (99419 => 99420)
--- trunk/Tools/ChangeLog 2011-11-07 14:42:42 UTC (rev 99419)
+++ trunk/Tools/ChangeLog 2011-11-07 14:43:01 UTC (rev 99420)
@@ -1,5 +1,19 @@
2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
+[Qt] Sanitize qmake paths correctly before comparing
+
+The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
+which caused us to always generate derived webcore sources, but never build
+them. The bug has been fixed, and we now also sanitize paths for the injected
+bundle derived sources.
+
+Reviewed by Simon Hausmann.
+
+* WebKitTestRunner/InjectedBundle/DerivedSources.pri:
+* qmake/mkspecs/features/functions.prf:
+
+2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
[Qt] Print right order for changing feature defines
Reviewed by Simon Hausmann.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/DerivedSources.pri (99419 => 99420)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/DerivedSources.pri 2011-11-07 14:42:42 UTC (rev 99419)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/DerivedSources.pri 2011-11-07 14:43:01 UTC (rev 99420)
@@ -8,7 +8,8 @@
# so that the resulting generated sources can be added to SOURCES.
# We only set the template if we're a top level target, so that we
# don't override what Target.pri has already set.
-equals(_FILE_, $$_PRO_FILE_): TEMPLATE = derived
+sanitizedFile = $$toSanitizedPath($$_FILE_)
+equals(sanitizedFile, $$toSanitizedPath($$_PRO_FILE_)):TEMPLATE = derived
load(features)
Modified: trunk/Tools/qmake/mkspecs/features/functions.prf (99419 => 99420)
--- trunk/Tools/qmake/mkspecs/features/functions.prf 2011-11-07 14:42:42 UTC (rev 99419)
+++ trunk/Tools/qmake/mkspecs/features/functions.prf 2011-11-07 14:43:01 UTC (rev 99420)
@@ -6,12 +6,13 @@
# ---
defineReplace(toSanitizedPath) {
-win* {
-components = $$split(1, :)
+path = $$1
+win32-msvc* {
+components = $$split(path, :)
count(components, 2): path = $$lower($$first(components)):$$last(components)
return($$replace(path, , /))
} else {
-return($$1)
+return($$path)
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99421] trunk
Title: [99421] trunk
Revision 99421
Author ves...@webkit.org
Date 2011-11-07 06:43:17 -0800 (Mon, 07 Nov 2011)
Log Message
[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
Reviewed-by Simon Hausmann.
Modified Paths
trunk/ChangeLog
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf
Diff
Modified: trunk/ChangeLog (99420 => 99421)
--- trunk/ChangeLog 2011-11-07 14:43:01 UTC (rev 99420)
+++ trunk/ChangeLog 2011-11-07 14:43:17 UTC (rev 99421)
@@ -1,3 +1,11 @@
+2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
+
+Reviewed-by Simon Hausmann.
+
+* Source/api.pri:
+
2011-11-04 Philippe Normand pnorm...@igalia.com
[GTK] Disable VIDEO_TRACK for now
Modified: trunk/Source/api.pri (99420 => 99421)
--- trunk/Source/api.pri 2011-11-07 14:43:01 UTC (rev 99420)
+++ trunk/Source/api.pri 2011-11-07 14:43:17 UTC (rev 99421)
@@ -13,8 +13,6 @@
include(WebKit/WebKit.pri)
-DEFINES += BUILDING_WEBKIT
-
!v8:CONFIG += _javascript_core
CONFIG += webcore
Modified: trunk/Tools/ChangeLog (99420 => 99421)
--- trunk/Tools/ChangeLog 2011-11-07 14:43:01 UTC (rev 99420)
+++ trunk/Tools/ChangeLog 2011-11-07 14:43:17 UTC (rev 99421)
@@ -1,5 +1,13 @@
2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
+[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
+
+Reviewed-by Simon Hausmann.
+
+* qmake/mkspecs/features/default_post.prf:
+
+2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
[Qt] Sanitize qmake paths correctly before comparing
The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (99420 => 99421)
--- trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-07 14:43:01 UTC (rev 99420)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-07 14:43:17 UTC (rev 99421)
@@ -117,6 +117,9 @@
}
contains(TEMPLATE, lib) {
+# Triggers the right export macro for the QtWebKit API (see qwebkitglobal.h)
+DEFINES += BUILDING_WEBKIT
+
DEFINES += QT_ASCII_CAST_WARNINGS
win32-msvc*|win32-icc: INCLUDEPATH += $$ROOT_WEBKIT_DIR/Source/_javascript_Core/os-win32
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99422] trunk/LayoutTests
Title: [99422] trunk/LayoutTests Revision 99422 Author hausm...@webkit.org Date 2011-11-07 07:22:41 -0800 (Mon, 07 Nov 2011) Log Message [Qt] Gardening, unskip tests that appear to pass now. Rubber-stamped by Ossy. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99421 => 99422) --- trunk/LayoutTests/ChangeLog 2011-11-07 14:43:17 UTC (rev 99421) +++ trunk/LayoutTests/ChangeLog 2011-11-07 15:22:41 UTC (rev 99422) @@ -1,5 +1,13 @@ 2011-11-07 Simon Hausmann simon.hausm...@nokia.com +[Qt] Gardening, unskip tests that appear to pass now. + +Rubber-stamped by Ossy. + +* platform/qt/Skipped: + +2011-11-07 Simon Hausmann simon.hausm...@nokia.com + [Qt] Fix failing inspector tests after build system changes https://bugs.webkit.org/show_bug.cgi?id=71677 Modified: trunk/LayoutTests/platform/qt/Skipped (99421 => 99422) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-07 14:43:17 UTC (rev 99421) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-07 15:22:41 UTC (rev 99422) @@ -2522,15 +2522,4 @@ fast/events/platform-wheelevent-paging-y-in-scrolling-page.html # disable a few more failures due to build system refactoring. -editing/deleting/5408255.html -editing/deleting/deletionUI-single-instance.html -editing/execCommand/insertImage.html -fast/block/float/015.html -fast/dom/Element/id-in-deletebutton.html -fast/dom/inner-text.html -fast/encoding/utf-16-big-endian.html -fast/encoding/utf-16-little-endian.html -fast/images/pdf-as-image.html -tables/mozilla/bugs/bug2962.html -tables/mozilla/bugs/bug56201.html http/tests/misc/submit-post-keygen.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99423] trunk/LayoutTests
Title: [99423] trunk/LayoutTests Revision 99423 Author hausm...@webkit.org Date 2011-11-07 07:43:21 -0800 (Mon, 07 Nov 2011) Log Message [Qt] More gardening. Skip keygen related tests. Rubber-stamped by Ossy. * platform/qt/Skipped: We don't support keygen, so group the keygen failures and add a comment. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99422 => 99423) --- trunk/LayoutTests/ChangeLog 2011-11-07 15:22:41 UTC (rev 99422) +++ trunk/LayoutTests/ChangeLog 2011-11-07 15:43:21 UTC (rev 99423) @@ -1,5 +1,14 @@ 2011-11-07 Simon Hausmann simon.hausm...@nokia.com +[Qt] More gardening. Skip keygen related tests. + +Rubber-stamped by Ossy. + +* platform/qt/Skipped: We don't support keygen, so group +the keygen failures and add a comment. + +2011-11-07 Simon Hausmann simon.hausm...@nokia.com + [Qt] Gardening, unskip tests that appear to pass now. Rubber-stamped by Ossy. Modified: trunk/LayoutTests/platform/qt/Skipped (99422 => 99423) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-07 15:22:41 UTC (rev 99422) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-07 15:43:21 UTC (rev 99423) @@ -1176,7 +1176,6 @@ fast/forms/textarea-scrollbar.html fast/forms/textarea-scrolled-type.html fast/frames/iframe-window-focus.html -fast/html/keygen.html fast/invalid/missing-end-tag.xhtml fast/invalid/residual-style.html fast/js/string-capitalization.html @@ -1338,6 +1337,9 @@ # --crashed with --platform mac --ignore-metrics fast/text/midword-break-after-breakable-char.html +# No support for keygen with Qt (see TemporaryLinkStubs.cpp) +fast/html/keygen.html +http/tests/misc/submit-post-keygen.html # -- pass with --platform mac --ignore-metrics fast/backgrounds/animated-gif-as-background.html @@ -2520,6 +2522,3 @@ fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html fast/events/platform-wheelevent-paging-y-in-scrolling-div.html fast/events/platform-wheelevent-paging-y-in-scrolling-page.html - -# disable a few more failures due to build system refactoring. -http/tests/misc/submit-post-keygen.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99424] trunk/Source/WebKit2
Title: [99424] trunk/Source/WebKit2
Revision 99424
Author hausm...@webkit.org
Date 2011-11-07 07:58:00 -0800 (Mon, 07 Nov 2011)
Log Message
[Qt] Make it possible to include qdesktopwebview.h from apps
Reviewed by Tor Arne Vestbø.
* UIProcess/API/qt/qdesktopwebview.h: Don't include C API headers, forward
declare the structs manually.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99423 => 99424)
--- trunk/Source/WebKit2/ChangeLog 2011-11-07 15:43:21 UTC (rev 99423)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-07 15:58:00 UTC (rev 99424)
@@ -1,5 +1,14 @@
2011-11-07 Simon Hausmann simon.hausm...@nokia.com
+[Qt] Make it possible to include qdesktopwebview.h from apps
+
+Reviewed by Tor Arne Vestbø.
+
+* UIProcess/API/qt/qdesktopwebview.h: Don't include C API headers, forward
+declare the structs manually.
+
+2011-11-07 Simon Hausmann simon.hausm...@nokia.com
+
[Qt] Fix failing inspector tests after build system changes
https://bugs.webkit.org/show_bug.cgi?id=71677
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h (99423 => 99424)
--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h 2011-11-07 15:43:21 UTC (rev 99423)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h 2011-11-07 15:58:00 UTC (rev 99424)
@@ -23,7 +23,6 @@
#include qbasewebview.h
#include qwebkitglobal.h
-#include WebKit2/WKBase.h
class QDesktopWebViewPrivate;
@@ -43,6 +42,10 @@
class QWheelEvent;
QT_END_NAMESPACE
+typedef const struct OpaqueWKContext* WKContextRef;
+typedef const struct OpaqueWKPageGroup* WKPageGroupRef;
+typedef const struct OpaqueWKPage* WKPageRef;
+
namespace WTR {
class PlatformWebView;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99425] trunk/Source/WebKit2
Title: [99425] trunk/Source/WebKit2
Revision 99425
Author kenn...@webkit.org
Date 2011-11-07 08:24:50 -0800 (Mon, 07 Nov 2011)
Log Message
[Qt] Put handling of gestures and their interaction in one place
https://bugs.webkit.org/show_bug.cgi?id=71682
Reviewed by Simon Hausmann.
Before this patch, the interaction (ie. cancelling animations, events)
was handled in the respective recognizers which then knew about each
others.
* UIProcess/qt/QtGestureRecognizer.h:
(WebKit::QtGestureRecognizer::isRecognized):
* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtPanGestureRecognizer.h:
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::recognize):
* UIProcess/qt/QtPinchGestureRecognizer.h:
* UIProcess/qt/QtTouchWebPageProxy.cpp:
(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::doneWithTouchEvent):
* UIProcess/qt/QtTouchWebPageProxy.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScrollAnimation):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::scaleAnimationActive):
(WebKit::QtViewportInteractionEngine::interruptScaleAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureActive):
* UIProcess/qt/QtViewportInteractionEngine.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtGestureRecognizer.h
trunk/Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp
trunk/Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.h
trunk/Source/WebKit2/UIProcess/qt/QtPinchGestureRecognizer.cpp
trunk/Source/WebKit2/UIProcess/qt/QtPinchGestureRecognizer.h
trunk/Source/WebKit2/UIProcess/qt/QtTouchWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtTouchWebPageProxy.h
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99424 => 99425)
--- trunk/Source/WebKit2/ChangeLog 2011-11-07 15:58:00 UTC (rev 99424)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-07 16:24:50 UTC (rev 99425)
@@ -1,3 +1,37 @@
+2011-11-07 Kenneth Rohde Christiansen kenn...@webkit.org
+
+[Qt] Put handling of gestures and their interaction in one place
+https://bugs.webkit.org/show_bug.cgi?id=71682
+
+Reviewed by Simon Hausmann.
+
+Before this patch, the interaction (ie. cancelling animations, events)
+was handled in the respective recognizers which then knew about each
+others.
+
+* UIProcess/qt/QtGestureRecognizer.h:
+(WebKit::QtGestureRecognizer::isRecognized):
+* UIProcess/qt/QtPanGestureRecognizer.cpp:
+(WebKit::QtPanGestureRecognizer::recognize):
+* UIProcess/qt/QtPanGestureRecognizer.h:
+* UIProcess/qt/QtPinchGestureRecognizer.cpp:
+(WebKit::QtPinchGestureRecognizer::recognize):
+* UIProcess/qt/QtPinchGestureRecognizer.h:
+* UIProcess/qt/QtTouchWebPageProxy.cpp:
+(QtTouchWebPageProxy::QtTouchWebPageProxy):
+(QtTouchWebPageProxy::doneWithTouchEvent):
+* UIProcess/qt/QtTouchWebPageProxy.h:
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::pagePositionRequest):
+(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
+(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
+(WebKit::QtViewportInteractionEngine::interruptScrollAnimation):
+(WebKit::QtViewportInteractionEngine::panGestureActive):
+(WebKit::QtViewportInteractionEngine::scaleAnimationActive):
+(WebKit::QtViewportInteractionEngine::interruptScaleAnimation):
+(WebKit::QtViewportInteractionEngine::pinchGestureActive):
+* UIProcess/qt/QtViewportInteractionEngine.h:
+
2011-11-07 Simon Hausmann simon.hausm...@nokia.com
[Qt] Make it possible to include qdesktopwebview.h from apps
Modified: trunk/Source/WebKit2/UIProcess/qt/QtGestureRecognizer.h (99424 => 99425)
--- trunk/Source/WebKit2/UIProcess/qt/QtGestureRecognizer.h 2011-11-07 15:58:00 UTC (rev 99424)
+++ trunk/Source/WebKit2/UIProcess/qt/QtGestureRecognizer.h 2011-11-07 16:24:50 UTC (rev 99425)
@@ -31,6 +31,9 @@
class QtViewportInteractionEngine;
class QtGestureRecognizer {
+public:
+bool isRecognized() const { return m_state == GestureRecognized; }
+
protected:
QtGestureRecognizer(QtViewportInteractionEngine*);
void reset();
Modified: trunk/Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp (99424 => 99425)
--- trunk/Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp 2011-11-07 15:58:00 UTC (rev 99424)
+++
[webkit-changes] [99426] trunk/Source/WebCore
Title: [99426] trunk/Source/WebCore
Revision 99426
Author rolandstei...@chromium.org
Date 2011-11-07 08:31:51 -0800 (Mon, 07 Nov 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70223
CSSStyleSheet: finding the owner node should be in its own method
Add styleSheetOwnerNode() function that returns the owner Node of the style sheet, or 0.
Reviewed by Dimitri Glazkov.
No new tests. (refactoring)
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::styleSheetOwnerNode):
(WebCore::CSSStyleSheet::document):
* css/CSSStyleSheet.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSheet.cpp
trunk/Source/WebCore/css/CSSStyleSheet.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99425 => 99426)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 16:24:50 UTC (rev 99425)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 16:31:51 UTC (rev 99426)
@@ -1,3 +1,19 @@
+2011-11-07 Roland Steiner rolandstei...@chromium.org
+
+https://bugs.webkit.org/show_bug.cgi?id=70223
+CSSStyleSheet: finding the owner node should be in its own method
+
+Add styleSheetOwnerNode() function that returns the owner Node of the style sheet, or 0.
+
+Reviewed by Dimitri Glazkov.
+
+No new tests. (refactoring)
+
+* css/CSSStyleSheet.cpp:
+(WebCore::CSSStyleSheet::styleSheetOwnerNode):
+(WebCore::CSSStyleSheet::document):
+* css/CSSStyleSheet.h:
+
2011-11-07 Yury Semikhatsky yu...@chromium.org
[Chromium] Web Inspector: use native worker inspector instead of fake workers
Modified: trunk/Source/WebCore/css/CSSStyleSheet.cpp (99425 => 99426)
--- trunk/Source/WebCore/css/CSSStyleSheet.cpp 2011-11-07 16:24:50 UTC (rev 99425)
+++ trunk/Source/WebCore/css/CSSStyleSheet.cpp 2011-11-07 16:31:51 UTC (rev 99426)
@@ -245,15 +245,23 @@
owner-startLoadingDynamicSheet();
}
-Document* CSSStyleSheet::document()
+Node* CSSStyleSheet::styleSheetOwnerNode() const
{
-for (CSSStyleSheet* sheet = this; sheet; sheet = sheet-parentStyleSheet()) {
+for (const CSSStyleSheet* sheet = this; sheet; sheet = sheet-parentStyleSheet()) {
if (Node* ownerNode = sheet-ownerNode())
-return ownerNode-document();
+return ownerNode;
}
return 0;
}
+Document* CSSStyleSheet::document()
+{
+Node* ownerNode = styleSheetOwnerNode();
+
+return ownerNode ? ownerNode-document() : 0;
+}
+
+
void CSSStyleSheet::styleSheetChanged()
{
CSSStyleSheet* rootSheet = this;
Modified: trunk/Source/WebCore/css/CSSStyleSheet.h (99425 => 99426)
--- trunk/Source/WebCore/css/CSSStyleSheet.h 2011-11-07 16:24:50 UTC (rev 99425)
+++ trunk/Source/WebCore/css/CSSStyleSheet.h 2011-11-07 16:31:51 UTC (rev 99426)
@@ -95,6 +95,7 @@
virtual void checkLoaded();
void startLoadingDynamicSheet();
+Node* styleSheetOwnerNode() const;
Document* document();
const String charset() const { return m_charset; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99427] trunk/Source/WebCore
Title: [99427] trunk/Source/WebCore
Revision 99427
Author pfeld...@chromium.org
Date 2011-11-07 08:48:35 -0800 (Mon, 07 Nov 2011)
Log Message
2011-11-07 Pavel Feldman pfeld...@google.com
Not reviewed: follow up to r99407. Style the suggest box.
https://bugs.webkit.org/show_bug.cgi?id=65511
* inspector/front-end/TextPrompt.js:
* inspector/front-end/inspector.css:
* inspector/front-end/textPrompt.css:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
trunk/Source/WebCore/inspector/front-end/inspector.css
trunk/Source/WebCore/inspector/front-end/inspectorCommon.css
trunk/Source/WebCore/inspector/front-end/textPrompt.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (99426 => 99427)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 16:48:35 UTC (rev 99427)
@@ -1,3 +1,13 @@
+2011-11-07 Pavel Feldman pfeld...@google.com
+
+Not reviewed: follow up to r99407. Style the suggest box.
+https://bugs.webkit.org/show_bug.cgi?id=65511
+
+
+* inspector/front-end/TextPrompt.js:
+* inspector/front-end/inspector.css:
+* inspector/front-end/textPrompt.css:
+
2011-11-07 Roland Steiner rolandstei...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=70223
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99426 => 99427)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 16:48:35 UTC (rev 99427)
@@ -815,7 +815,7 @@
window.addEventListener(scroll, this._boundOnScroll, true);
window.addEventListener(resize, this._boundOnResize, true);
-this._element = this._parentElement.createChild(div, suggest-box custom-popup-vertical-scroll custom-popup-horizontal-scroll + (className || ));
+this._element = this._parentElement.createChild(div, suggest-box + (className || ));
this._element.addEventListener(mousedown, this._onboxmousedown.bind(this), true);
this.containerElement = this._element.createChild(div, container);
this.contentElement = this.containerElement.createChild(div, content);
@@ -855,9 +855,9 @@
// Lay out the suggest-box relative to the anchorBox.
const anchorBox = this._inputElement.boxInWindow(window, this._parentElement);
const suggestBoxPaddingX = 21;
-const suggestBoxPaddingY = 12;
+const suggestBoxPaddingY = 2;
const spacer = 6;
-const minHeight = 50;
+const minHeight = 25;
const maxWidth = document.body.offsetWidth - anchorBox.x - spacer;
const width = Math.min(contentWidth, maxWidth - suggestBoxPaddingX) + suggestBoxPaddingX;
@@ -967,7 +967,7 @@
*/
updateSuggestionsSoon: function(completions)
{
-if (!(_suggestTimeout in this))
+if (!this._suggestTimeout)
this._suggestTimeout = setTimeout(this.updateSuggestions.bind(this, completions), 10);
},
@@ -976,7 +976,7 @@
*/
updateSuggestions: function(completions)
{
-if (_suggestTimeout in this) {
+if (this._suggestTimeout) {
clearTimeout(this._suggestTimeout);
delete this._suggestTimeout;
}
@@ -1017,6 +1017,7 @@
var child = this.contentElement.firstChild;
var childText = child ? child.textContent : null;
this.contentElement.removeChildren();
+
delete this._selectedElement;
var userEnteredText = this._textPrompt._userEnteredText;
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (99426 => 99427)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2011-11-07 16:48:35 UTC (rev 99427)
@@ -2520,21 +2520,14 @@
/* Generic suggest box style */
.suggest-box.generic-suggest {
-border-radius: 0 5px 5px 5px;
margin-left: -1px;
border-color: rgb(66%, 66%, 66%);
--webkit-box-shadow: 8px 8px 6px rgba(40, 40, 40, 0.40);
}
.suggest-box.generic-suggest.above-anchor {
border-radius: 5px 5px 5px 0;
--webkit-box-shadow: 8px -8px 6px rgba(40, 40, 40, 0.40);
}
-.suggest-box.generic-suggest .content {
-margin: 3px;
-}
-
/* Custom popup scrollers */
.custom-popup-horizontal-scroll ::-webkit-scrollbar, .custom-popup-vertical-scroll ::-webkit-scrollbar {
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (99426 => 99427)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2011-11-07 16:31:51 UTC (rev 99426)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2011-11-07 16:48:35 UTC (rev 99427)
@@ -13,7 +13,6 @@
font-family: Lucida Grande, sans-serif;
font-size: 10px;
margin: 0;
--webkit-text-size-adjust: none;
[webkit-changes] [99429] trunk/Source/WebCore
Title: [99429] trunk/Source/WebCore
Revision 99429
Author ves...@webkit.org
Date 2011-11-07 08:51:28 -0800 (Mon, 07 Nov 2011)
Log Message
Fix the Qt build on Mac OS X when using the QuickTime media backend
When QtWebKit is built on Mac OS X using the QuickTime media backend
we build both KURLCFNet.cpp and KURLMac, just like the Mac port, so
we have to guard the potentially duplicate symbol createCFURL with
more than just !PLATFORM(MAC).
Reviewed by Andreas Kling.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cf/KURLCFNet.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99428 => 99429)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 16:51:15 UTC (rev 99428)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 16:51:28 UTC (rev 99429)
@@ -1,3 +1,16 @@
+2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+Fix the Qt build on Mac OS X when using the QuickTime media backend
+
+When QtWebKit is built on Mac OS X using the QuickTime media backend
+we build both KURLCFNet.cpp and KURLMac, just like the Mac port, so
+we have to guard the potentially duplicate symbol createCFURL with
+more than just !PLATFORM(MAC).
+
+Reviewed by Andreas Kling.
+
+* platform/cf/KURLCFNet.cpp:
+
2011-11-07 Pavel Feldman pfeld...@google.com
Not reviewed: follow up to r99407. Style the suggest box.
Modified: trunk/Source/WebCore/platform/cf/KURLCFNet.cpp (99428 => 99429)
--- trunk/Source/WebCore/platform/cf/KURLCFNet.cpp 2011-11-07 16:51:15 UTC (rev 99428)
+++ trunk/Source/WebCore/platform/cf/KURLCFNet.cpp 2011-11-07 16:51:28 UTC (rev 99429)
@@ -75,7 +75,7 @@
return result;
}
-#if !PLATFORM(MAC)
+#if !PLATFORM(MAC) !(PLATFORM(QT) USE(QTKIT))
CFURLRef KURL::createCFURL() const
{
// FIXME: What should this return for invalid URLs?
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99430] trunk/Source/WebCore
Title: [99430] trunk/Source/WebCore
Revision 99430
Author apav...@chromium.org
Date 2011-11-07 09:15:36 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: TextPrompt+SuggestBox should autocomplete on Right keydown and with a single suggestion in place
https://bugs.webkit.org/show_bug.cgi?id=71676
Reviewed by Pavel Feldman.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
* inspector/front-end/inspectorCommon.css:
(body): Revert inadvertent style change from a preceding commit.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
trunk/Source/WebCore/inspector/front-end/inspectorCommon.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (99429 => 99430)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 16:51:28 UTC (rev 99429)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 17:15:36 UTC (rev 99430)
@@ -1,3 +1,16 @@
+2011-11-07 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: TextPrompt+SuggestBox should autocomplete on Right keydown and with a single suggestion in place
+https://bugs.webkit.org/show_bug.cgi?id=71676
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype.onKeyDown):
+(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
+* inspector/front-end/inspectorCommon.css:
+(body): Revert inadvertent style change from a preceding commit.
+
2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
Fix the Qt build on Mac OS X when using the QuickTime media backend
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99429 => 99430)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 16:51:28 UTC (rev 99429)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 17:15:36 UTC (rev 99430)
@@ -228,8 +228,13 @@
break;
case Right:
case End:
-if (!this.acceptAutoComplete())
-this.autoCompleteSoon();
+if (this.isSuggestBoxVisible())
+handled = this._suggestBox.tabKeyPressed(event);
+else {
+handled = this.acceptAutoComplete();
+if (!handled)
+this.autoCompleteSoon();
+}
break;
case U+001B: // Esc
if (this.isSuggestBoxVisible()) {
@@ -1018,8 +1023,6 @@
var childText = child ? child.textContent : null;
this.contentElement.removeChildren();
-delete this._selectedElement;
-
var userEnteredText = this._textPrompt._userEnteredText;
for (var i = 0; i items.length; ++i) {
var item = items[i];
@@ -1027,6 +1030,7 @@
this.contentElement.appendChild(currentItemElement);
}
+this._selectedElement = this.contentElement.firstChild;
this._updateSelection();
},
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (99429 => 99430)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2011-11-07 16:51:28 UTC (rev 99429)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2011-11-07 17:15:36 UTC (rev 99430)
@@ -13,6 +13,7 @@
font-family: Lucida Grande, sans-serif;
font-size: 10px;
margin: 0;
+-webkit-text-size-adjust: none;
-webkit-user-select: none;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99431] trunk/Source/WebCore
Title: [99431] trunk/Source/WebCore
Revision 99431
Author domin...@chromium.org
Date 2011-11-07 09:16:18 -0800 (Mon, 07 Nov 2011)
Log Message
Remove initPageTransitionEvent method
https://bugs.webkit.org/show_bug.cgi?id=71689
Reviewed by Ojan Vafai.
initPageTransitionEvent was removed from the HTML spec; it has
been replaced by new PageTransitionEvent(...).
Removing a method, so no new tests.
* dom/PageTransitionEvent.cpp:
* dom/PageTransitionEvent.h:
* dom/PageTransitionEvent.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/PageTransitionEvent.cpp
trunk/Source/WebCore/dom/PageTransitionEvent.h
trunk/Source/WebCore/dom/PageTransitionEvent.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (99430 => 99431)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 17:15:36 UTC (rev 99430)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 17:16:18 UTC (rev 99431)
@@ -1,3 +1,19 @@
+2011-11-07 Dominic Cooney domin...@chromium.org
+
+Remove initPageTransitionEvent method
+https://bugs.webkit.org/show_bug.cgi?id=71689
+
+Reviewed by Ojan Vafai.
+
+initPageTransitionEvent was removed from the HTML spec; it has
+been replaced by new PageTransitionEvent(...).
+
+Removing a method, so no new tests.
+
+* dom/PageTransitionEvent.cpp:
+* dom/PageTransitionEvent.h:
+* dom/PageTransitionEvent.idl:
+
2011-11-07 Alexander Pavlov apav...@chromium.org
Web Inspector: TextPrompt+SuggestBox should autocomplete on Right keydown and with a single suggestion in place
Modified: trunk/Source/WebCore/dom/PageTransitionEvent.cpp (99430 => 99431)
--- trunk/Source/WebCore/dom/PageTransitionEvent.cpp 2011-11-07 17:15:36 UTC (rev 99430)
+++ trunk/Source/WebCore/dom/PageTransitionEvent.cpp 2011-11-07 17:16:18 UTC (rev 99431)
@@ -56,19 +56,6 @@
{
}
-void PageTransitionEvent::initPageTransitionEvent(const AtomicString type,
-bool canBubbleArg,
-bool cancelableArg,
-bool persisted)
-{
-if (dispatched())
-return;
-
-initEvent(type, canBubbleArg, cancelableArg);
-
-m_persisted = persisted;
-}
-
const AtomicString PageTransitionEvent::interfaceName() const
{
return eventNames().interfaceForPageTransitionEvent;
Modified: trunk/Source/WebCore/dom/PageTransitionEvent.h (99430 => 99431)
--- trunk/Source/WebCore/dom/PageTransitionEvent.h 2011-11-07 17:15:36 UTC (rev 99430)
+++ trunk/Source/WebCore/dom/PageTransitionEvent.h 2011-11-07 17:16:18 UTC (rev 99431)
@@ -53,11 +53,6 @@
virtual ~PageTransitionEvent();
-void initPageTransitionEvent(const AtomicString type,
- bool canBubbleArg,
- bool cancelableArg,
- bool persisted);
-
virtual const AtomicString interfaceName() const;
bool persisted() const { return m_persisted; }
Modified: trunk/Source/WebCore/dom/PageTransitionEvent.idl (99430 => 99431)
--- trunk/Source/WebCore/dom/PageTransitionEvent.idl 2011-11-07 17:15:36 UTC (rev 99430)
+++ trunk/Source/WebCore/dom/PageTransitionEvent.idl 2011-11-07 17:16:18 UTC (rev 99431)
@@ -29,13 +29,7 @@
CanBeConstructed,
CustomConstructor
] PageTransitionEvent : Event {
-
readonly attribute boolean persisted;
-
-void initPageTransitionEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
- in [Optional=CallWithDefaultValue] boolean canBubbleArg,
- in [Optional=CallWithDefaultValue] boolean cancelableArg,
- in [Optional=CallWithDefaultValue] boolean persisted);
};
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99432] trunk/Source/WebCore
Title: [99432] trunk/Source/WebCore
Revision 99432
Author vse...@chromium.org
Date 2011-11-07 09:36:23 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: Suggest box should consume enter key pressed event.
https://bugs.webkit.org/show_bug.cgi?id=71700
Reviewed by Pavel Feldman.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99431 => 99432)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 17:16:18 UTC (rev 99431)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 17:36:23 UTC (rev 99432)
@@ -1,3 +1,16 @@
+2011-11-07 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Suggest box should consume enter key pressed event.
+https://bugs.webkit.org/show_bug.cgi?id=71700
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView):
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype._attachInternal):
+(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
+
2011-11-07 Dominic Cooney domin...@chromium.org
Remove initPageTransitionEvent method
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99431 => 99432)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-07 17:16:18 UTC (rev 99431)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-07 17:36:23 UTC (rev 99432)
@@ -61,7 +61,6 @@
this.promptElement.id = console-prompt;
this.promptElement.className = source-code;
this.promptElement.spellcheck = false;
-this.promptElement.addEventListener(keydown, this._promptKeyDown.bind(this), true);
this.messagesElement.appendChild(this.promptElement);
this.messagesElement.appendChild(document.createElement(br));
@@ -114,6 +113,7 @@
this.prompt = new WebInspector.TextPromptWithHistory(this.completions.bind(this), ExpressionStopCharacters + .);
this.prompt.setSuggestBoxEnabled(generic-suggest);
this.prompt.attach(this.promptElement);
+this.prompt.proxyElement.addEventListener(keydown, this._promptKeyDown.bind(this), false);
this.prompt.setHistoryData(WebInspector.settings.consoleHistory.get());
}
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99431 => 99432)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 17:16:18 UTC (rev 99431)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 17:36:23 UTC (rev 99432)
@@ -105,7 +105,7 @@
element.parentElement.insertBefore(this.proxyElement, element);
this.proxyElement.appendChild(element);
this._element.addStyleClass(text-prompt);
-this._element.addEventListener(keydown, this._boundOnKeyDown, true);
+this._element.addEventListener(keydown, this._boundOnKeyDown, false);
this._element.addEventListener(selectstart, this._selectStart.bind(this), false);
if (typeof this._suggestBoxClassName === string)
@@ -1078,7 +1078,8 @@
enterKeyPressed: function(event)
{
-return this.acceptSuggestion();
+this.acceptSuggestion();
+return true;
},
tabKeyPressed: function(event)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99433] trunk/LayoutTests
Title: [99433] trunk/LayoutTests
Revision 99433
Author ph...@webkit.org
Date 2011-11-07 09:43:43 -0800 (Mon, 07 Nov 2011)
Log Message
[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71655
Reviewed by Martin Robinson.
* fast/frames/flattening/frameset-flattening-simple.html: Trigger
the test only after the embedded frame has been loaded.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/frames/flattening/frameset-flattening-simple.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99432 => 99433)
--- trunk/LayoutTests/ChangeLog 2011-11-07 17:36:23 UTC (rev 99432)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 17:43:43 UTC (rev 99433)
@@ -1,3 +1,13 @@
+2011-11-07 Philippe Normand pnorm...@igalia.com
+
+[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=71655
+
+Reviewed by Martin Robinson.
+
+* fast/frames/flattening/frameset-flattening-simple.html: Trigger
+the test only after the embedded frame has been loaded.
+
2011-11-07 Simon Hausmann simon.hausm...@nokia.com
[Qt] More gardening. Skip keygen related tests.
Modified: trunk/LayoutTests/fast/frames/flattening/frameset-flattening-simple.html (99432 => 99433)
--- trunk/LayoutTests/fast/frames/flattening/frameset-flattening-simple.html 2011-11-07 17:36:23 UTC (rev 99432)
+++ trunk/LayoutTests/fast/frames/flattening/frameset-flattening-simple.html 2011-11-07 17:43:43 UTC (rev 99433)
@@ -15,8 +15,8 @@
}
/script
/head
-frameset border=0 cols=*,200 _onload_=test()
-frame src=""
+frameset border=0 cols=*,200
+frame _onload_=test() src=""
stylebody { background-color: green; }/style
p
Test for frameset flattening. The flattening only works inside the DRT.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99435] trunk
Title: [99435] trunk
Revision 99435
Author domin...@chromium.org
Date 2011-11-07 09:51:09 -0800 (Mon, 07 Nov 2011)
Log Message
Remove initOverflowEvent from _javascript_ bindings
https://bugs.webkit.org/show_bug.cgi?id=71687
Reviewed by Ojan Vafai.
Source/WebCore:
Now that OverflowEvent has a constructor, we don't need the
initOverflowEvent method. It has to remain in the Objective C
binding because it is part of the Objective C public API.
* dom/OverflowEvent.idl:
LayoutTests:
OverflowEvent initialization is tested in
fast/events/constructors/overflow-event-constructor.html
* fast/events/init-events-expected.txt:
* fast/events/script-tests/init-events.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/init-events-expected.txt
trunk/LayoutTests/fast/events/script-tests/init-events.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/OverflowEvent.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (99434 => 99435)
--- trunk/LayoutTests/ChangeLog 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 17:51:09 UTC (rev 99435)
@@ -1,3 +1,16 @@
+2011-11-07 Dominic Cooney domin...@chromium.org
+
+Remove initOverflowEvent from _javascript_ bindings
+https://bugs.webkit.org/show_bug.cgi?id=71687
+
+Reviewed by Ojan Vafai.
+
+OverflowEvent initialization is tested in
+fast/events/constructors/overflow-event-constructor.html
+
+* fast/events/init-events-expected.txt:
+* fast/events/script-tests/init-events.js:
+
2011-11-07 Philippe Normand pnorm...@igalia.com
[GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
Modified: trunk/LayoutTests/fast/events/init-events-expected.txt (99434 => 99435)
--- trunk/LayoutTests/fast/events/init-events-expected.txt 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/LayoutTests/fast/events/init-events-expected.txt 2011-11-07 17:51:09 UTC (rev 99435)
@@ -116,15 +116,6 @@
PASS testInitEvent('Mutation', 'a, false, false, null, b, c, d, 1001').attrName is 'd'
PASS testInitEvent('Mutation', 'a, false, false, null, b, c, null, 1001').attrName is 'null'
PASS testInitEvent('Mutation', 'a, false, false, null, b, c, d, 1001').attrChange is 1001
-PASS testInitEvent('Overflow', '1001, false, false').type is 'overflowchanged'
-PASS testInitEvent('Overflow', '1001, false, false').bubbles is false
-PASS testInitEvent('Overflow', '1001, false, false').cancelable is false
-PASS testInitEvent('Overflow', '1001, false, false').orient is 1001
-PASS testInitEvent('Overflow', '1001, false, false').horizontalOverflow is false
-PASS testInitEvent('Overflow', '1001, true, false').horizontalOverflow is true
-PASS testInitEvent('Overflow', '1001, false, false').verticalOverflow is false
-PASS testInitEvent('Overflow', '1001, false, true').verticalOverflow is true
-PASS createEventHelper('Overflow').orient is OverflowEvent.VERTICAL
PASS testInitEvent('Progress', 'a, false, false, false, 1001, 1002').type is 'a'
PASS testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type is 'null'
PASS testInitEvent('Progress', 'a, false, false, false, 1001, 1002').bubbles is false
Modified: trunk/LayoutTests/fast/events/script-tests/init-events.js (99434 => 99435)
--- trunk/LayoutTests/fast/events/script-tests/init-events.js 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/LayoutTests/fast/events/script-tests/init-events.js 2011-11-07 17:51:09 UTC (rev 99435)
@@ -130,17 +130,6 @@
shouldBe(testInitEvent('Mutation', '\a\, false, false, null, \b\, \c\, null, 1001').attrName, 'null');
shouldBe(testInitEvent('Mutation', '\a\, false, false, null, \b\, \c\, \d\, 1001').attrChange, 1001);
-// initOverflowEvent has an interface that has an design that's inconsistent with the init functions from other events.
-shouldBe(testInitEvent('Overflow', '1001, false, false').type, 'overflowchanged');
-shouldBe(testInitEvent('Overflow', '1001, false, false').bubbles, false);
-shouldBe(testInitEvent('Overflow', '1001, false, false').cancelable, false);
-shouldBe(testInitEvent('Overflow', '1001, false, false').orient, 1001);
-shouldBe(testInitEvent('Overflow', '1001, false, false').horizontalOverflow, false);
-shouldBe(testInitEvent('Overflow', '1001, true, false').horizontalOverflow, true);
-shouldBe(testInitEvent('Overflow', '1001, false, false').verticalOverflow, false);
-shouldBe(testInitEvent('Overflow', '1001, false, true').verticalOverflow, true);
-shouldBe(createEventHelper('Overflow').orient, OverflowEvent.VERTICAL);
-
shouldBe(testInitEvent('Progress', '\a\, false, false, false, 1001, 1002').type, 'a');
shouldBe(testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type, 'null');
shouldBe(testInitEvent('Progress', '\a\, false, false, false, 1001, 1002').bubbles, false);
Modified: trunk/Source/WebCore/ChangeLog (99434 => 99435)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 17:48:41 UTC (rev 99434)
+++ trunk/Source/WebCore/ChangeLog
[webkit-changes] [99437] trunk/Source
Title: [99437] trunk/Source Revision 99437 Author ander...@apple.com Date 2011-11-07 10:00:24 -0800 (Mon, 07 Nov 2011) Log Message Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins https://bugs.webkit.org/show_bug.cgi?id=71699 Reviewed by Sam Weinig. Source/WebCore: Export AffineTransform symbols used by WebKit2. * WebCore.exp.in: Source/WebKit2: Add a getScreenTransform function which given a coordinate space returns a transform that converts a point from that coordinate space to the screen coordinate space. We then get the source - screen transform and the destination - screen transform. We invert the destination - screen transform, multiply it with the source - screen transform and use mapPoint to get a complete affine transform from the source to the destination space and use mapPoint to map the source point and return the destination point. * WebProcess/Plugins/Netscape/NetscapePlugin.h: * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::getScreenTransform): (WebKit::NetscapePlugin::convertPoint): * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::initializePlugin): Call windowAndViewFramesChanged before viewGeometryDidChange so that the window and view frames will be up to date by the time NPP_SetWindow is called in the plug-in. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (99436 => 99437) --- trunk/Source/WebCore/ChangeLog 2011-11-07 17:54:15 UTC (rev 99436) +++ trunk/Source/WebCore/ChangeLog 2011-11-07 18:00:24 UTC (rev 99437) @@ -1,3 +1,14 @@ +2011-11-07 Anders Carlsson ander...@apple.com + +Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins +https://bugs.webkit.org/show_bug.cgi?id=71699 + +Reviewed by Sam Weinig. + +Export AffineTransform symbols used by WebKit2. + +* WebCore.exp.in: + 2011-11-07 Michael Saboff msab...@apple.com Towards 8 Bit Strings: Templatize JSC::Lexer class by character type Modified: trunk/Source/WebCore/WebCore.exp.in (99436 => 99437) --- trunk/Source/WebCore/WebCore.exp.in 2011-11-07 17:54:15 UTC (rev 99436) +++ trunk/Source/WebCore/WebCore.exp.in 2011-11-07 18:00:24 UTC (rev 99437) @@ -401,6 +401,9 @@ __ZN7WebCore14StorageTracker18diskUsageForOriginEPNS_14SecurityOriginE __ZN7WebCore14StorageTracker32syncFileSystemAndTrackerDatabaseEv __ZN7WebCore14endOfParagraphERKNS_15VisiblePositionENS_27EditingBoundaryCrossingRuleE +__ZN7WebCore15AffineTransform5flipYEv +__ZN7WebCore15AffineTransform8multiplyERKS0_ +__ZN7WebCore15AffineTransform9translateEdd __ZN7WebCore15AffineTransformC1Edd __ZN7WebCore15AffineTransformC1Ev __ZN7WebCore15ArchiveResource6createEN3WTF10PassRefPtrINS_12SharedBufferEEERKNS_4KURLERKNS1_6StringESA_SA_RKNS_16ResourceResponseE @@ -1223,8 +1226,10 @@ __ZNK7WebCore14SecurityOrigin10canDisplayERKNS_4KURLE __ZNK7WebCore14SecurityOrigin18databaseIdentifierEv __ZNK7WebCore14SecurityOrigin5equalEPKS0_ +__ZNK7WebCore15AffineTransform10isIdentityEv __ZNK7WebCore15AffineTransform12isInvertibleEv __ZNK7WebCore15AffineTransform7inverseEv +__ZNK7WebCore15AffineTransform8mapPointERKNS_10FloatPointE __ZNK7WebCore15AffineTransform8mapPointERKNS_8IntPointE __ZNK7WebCore15FocusController18focusedOrMainFrameEv __ZNK7WebCore15GraphicsContext15platformContextEv Modified: trunk/Source/WebKit2/ChangeLog (99436 => 99437) --- trunk/Source/WebKit2/ChangeLog 2011-11-07 17:54:15 UTC (rev 99436) +++ trunk/Source/WebKit2/ChangeLog 2011-11-07 18:00:24 UTC (rev 99437) @@ -1,3 +1,26 @@ +2011-11-07 Anders Carlsson ander...@apple.com + +Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins +https://bugs.webkit.org/show_bug.cgi?id=71699 + +Reviewed by Sam Weinig. + +Add a getScreenTransform function which given a coordinate space returns a transform that converts a +point from that coordinate space to the screen coordinate space. We then get the source - screen transform +and the destination - screen transform. We invert the destination - screen transform, multiply it with the +source - screen transform and use mapPoint to get a complete affine transform from the source to the destination space +and use mapPoint to map the source point and return the destination point. + +* WebProcess/Plugins/Netscape/NetscapePlugin.h: +* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: +(WebKit::NetscapePlugin::getScreenTransform): +(WebKit::NetscapePlugin::convertPoint): + +* WebProcess/Plugins/PluginView.cpp: +
[webkit-changes] [99438] trunk
Title: [99438] trunk Revision 99438 Author domin...@chromium.org Date 2011-11-07 10:04:51 -0800 (Mon, 07 Nov 2011) Log Message Remove initCloseEvent method https://bugs.webkit.org/show_bug.cgi?id=71374 Reviewed by Ojan Vafai. Source/WebCore: Test: fast/dom/Window/window-properties.html * websockets/CloseEvent.h: (WebCore::CloseEvent::initCloseEvent): * websockets/CloseEvent.idl: LayoutTests: * fast/dom/Window/window-properties-expected.txt: * platform/gtk/fast/dom/Window/window-properties-expected.txt: * platform/mac/fast/dom/Window/window-properties-expected.txt: * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/win/fast/dom/Window/window-properties-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/websockets/CloseEvent.h trunk/Source/WebCore/websockets/CloseEvent.idl trunk/Source/WebCore/websockets/WebSocket.cpp Diff Modified: trunk/LayoutTests/ChangeLog (99437 => 99438) --- trunk/LayoutTests/ChangeLog 2011-11-07 18:00:24 UTC (rev 99437) +++ trunk/LayoutTests/ChangeLog 2011-11-07 18:04:51 UTC (rev 99438) @@ -1,5 +1,19 @@ 2011-11-07 Dominic Cooney domin...@chromium.org +Remove initCloseEvent method +https://bugs.webkit.org/show_bug.cgi?id=71374 + +Reviewed by Ojan Vafai. + +* fast/dom/Window/window-properties-expected.txt: +* platform/gtk/fast/dom/Window/window-properties-expected.txt: +* platform/mac/fast/dom/Window/window-properties-expected.txt: +* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/dom/Window/window-properties-expected.txt: +* platform/win/fast/dom/Window/window-properties-expected.txt: + +2011-11-07 Dominic Cooney domin...@chromium.org + Remove initOverflowEvent from _javascript_ bindings https://bugs.webkit.org/show_bug.cgi?id=71687 Modified: trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt (99437 => 99438) --- trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2011-11-07 18:00:24 UTC (rev 99437) +++ trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2011-11-07 18:04:51 UTC (rev 99438) @@ -509,7 +509,6 @@ window.CloseEvent.prototype.MOUSEOVER [number] window.CloseEvent.prototype.MOUSEUP [number] window.CloseEvent.prototype.SELECT [number] -window.CloseEvent.prototype.initCloseEvent [function] window.CloseEvent.prototype.initEvent [function] window.CloseEvent.prototype.preventDefault [function] window.CloseEvent.prototype.stopImmediatePropagation [function] Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (99437 => 99438) --- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-07 18:00:24 UTC (rev 99437) +++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-07 18:04:51 UTC (rev 99438) @@ -509,7 +509,6 @@ window.CloseEvent.prototype.MOUSEOVER [number] window.CloseEvent.prototype.MOUSEUP [number] window.CloseEvent.prototype.SELECT [number] -window.CloseEvent.prototype.initCloseEvent [function] window.CloseEvent.prototype.initEvent [function] window.CloseEvent.prototype.preventDefault [function] window.CloseEvent.prototype.stopImmediatePropagation [function] Modified: trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt (99437 => 99438) --- trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2011-11-07 18:00:24 UTC (rev 99437) +++ trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2011-11-07 18:04:51 UTC (rev 99438) @@ -534,7 +534,6 @@ window.CloseEvent.prototype.MOUSEOVER [number] window.CloseEvent.prototype.MOUSEUP [number] window.CloseEvent.prototype.SELECT [number] -window.CloseEvent.prototype.initCloseEvent [function] window.CloseEvent.prototype.initEvent [function] window.CloseEvent.prototype.preventDefault [function] window.CloseEvent.prototype.stopImmediatePropagation [function] Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (99437 => 99438) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-07 18:00:24 UTC (rev 99437) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-07 18:04:51 UTC (rev 99438) @@ -507,7 +507,6 @@ window.CloseEvent.prototype.MOUSEOVER [number]
[webkit-changes] [99439] trunk/Source
Title: [99439] trunk/Source Revision 99439 Author jber...@webkit.org Date 2011-11-07 10:16:33 -0800 (Mon, 07 Nov 2011) Log Message Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is enabled. https://bugs.webkit.org/show_bug.cgi?id=71631 Reviewed by Jon Honeycutt. Source/WebCore: Check the SchemeRegistry before preventing read/write access to Local Storage and Databases in Private Browsing. * WebCore.exp.in: Export the symbols for registering the schemes as allowing Local Storage and Database access in Private Browsing. * dom/Document.cpp: (WebCore::Document::allowDatabaseAccess): Check if the scheme allows Database access in Private Browsing. * platform/SchemeRegistry.cpp: (WebCore::schemesAllowingLocalStorageAccessInPrivateBrowsing): (WebCore::schemesAllowingDatabaseAccessInPrivateBrowsing): (WebCore::SchemeRegistry::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing): (WebCore::SchemeRegistry::allowsLocalStorageAccessInPrivateBrowsing): (WebCore::SchemeRegistry::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing): (WebCore::SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing): * platform/SchemeRegistry.h: * storage/Storage.cpp: (WebCore::Storage::length): Ask the storage area if it is disabled by Private Browsing in the frame instead of just checking if Private Browsing is enabled for that frame because the answer might depend on what type of storage that storage area is. (WebCore::Storage::key): Ditto. (WebCore::Storage::getItem): Ditto. (WebCore::Storage::contains): Ditto. * storage/StorageArea.h: Make it possible to query a StorageArea for whether it is disabled by Private Browsing in a Frame. * storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame): Renamed from privateBrowsingEnabled. Check not only if Private Browsing is enabled for the Frame, but also if the storage type is Local Storage and if there is an exception for the scheme of the resource currently loaded into the Frame. (WebCore::StorageAreaImpl::setItem): Renamed privateBrowsingEnabled - disabledByPrivateBrowsingInFrame. (WebCore::StorageAreaImpl::removeItem): Ditto. (WebCore::StorageAreaImpl::clear): Ditto. * storage/StorageAreaImpl.h: Source/WebKit/chromium: * src/StorageAreaProxy.h: (WebCore::StorageAreaProxy::disabledByPrivateBrowsingInFrame): Chromium uses a different method to track its icognito mode, so always return false. Source/WebKit/mac: Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and Databases. * WebView/WebView.mm: (+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]): Call through to the SchemeRegistry function. (+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]): Ditto. * WebView/WebViewPrivate.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/platform/SchemeRegistry.cpp trunk/Source/WebCore/platform/SchemeRegistry.h trunk/Source/WebCore/storage/Storage.cpp trunk/Source/WebCore/storage/StorageArea.h trunk/Source/WebCore/storage/StorageAreaImpl.cpp trunk/Source/WebCore/storage/StorageAreaImpl.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/StorageAreaProxy.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebView.mm trunk/Source/WebKit/mac/WebView/WebViewPrivate.h Diff Modified: trunk/Source/WebCore/ChangeLog (99438 => 99439) --- trunk/Source/WebCore/ChangeLog 2011-11-07 18:04:51 UTC (rev 99438) +++ trunk/Source/WebCore/ChangeLog 2011-11-07 18:16:33 UTC (rev 99439) @@ -1,3 +1,60 @@ +2011-11-07 Jessie Berlin jber...@apple.com + +Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is +enabled. +https://bugs.webkit.org/show_bug.cgi?id=71631 + +Reviewed by Jon Honeycutt. + +Check the SchemeRegistry before preventing read/write access to Local Storage and Databases +in Private Browsing. + +* WebCore.exp.in: +Export the symbols for registering the schemes as allowing Local Storage and Database access +in Private Browsing. + +* dom/Document.cpp: +(WebCore::Document::allowDatabaseAccess): +Check if the scheme allows Database access in Private Browsing. + +* platform/SchemeRegistry.cpp: +(WebCore::schemesAllowingLocalStorageAccessInPrivateBrowsing): +(WebCore::schemesAllowingDatabaseAccessInPrivateBrowsing): +(WebCore::SchemeRegistry::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing): +(WebCore::SchemeRegistry::allowsLocalStorageAccessInPrivateBrowsing): +(WebCore::SchemeRegistry::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing): +(WebCore::SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing): +* platform/SchemeRegistry.h: + +* storage/Storage.cpp: +
[webkit-changes] [99440] trunk
Title: [99440] trunk
Revision 99440
Author fsam...@chromium.org
Date 2011-11-07 10:24:48 -0800 (Mon, 07 Nov 2011)
Log Message
[Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
https://bugs.webkit.org/show_bug.cgi?id=71485
Reviewed by Darin Fisher.
Source/WebKit/chromium:
Created new method setPageScaleFactor to replace scalePage to match
renamed method in WebCore. This change will happen in three stages:
1. A new method is created called setPageScaleFactor with the same
functionality as scalePage.
2. All call sites of scalePage are changed to setPageScaleFactor in the Chromium
repository.
3. scalePage is deleted from WebView/WebViewImpl
* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::pageScaleFactor):
(WebKit::WebViewImpl::scalePage):
(WebKit::WebViewImpl::setPageScaleFactor):
* src/WebViewImpl.h:
Tools:
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::scalePageBy):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/EventSender.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (99439 => 99440)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-07 18:16:33 UTC (rev 99439)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-07 18:24:48 UTC (rev 99440)
@@ -1,3 +1,26 @@
+2011-11-07 Fady Samuel fsam...@chromium.org
+
+[Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
+https://bugs.webkit.org/show_bug.cgi?id=71485
+
+Reviewed by Darin Fisher.
+
+Created new method setPageScaleFactor to replace scalePage to match
+renamed method in WebCore. This change will happen in three stages:
+
+1. A new method is created called setPageScaleFactor with the same
+ functionality as scalePage.
+2. All call sites of scalePage are changed to setPageScaleFactor in the Chromium
+ repository.
+3. scalePage is deleted from WebView/WebViewImpl
+
+* public/WebView.h:
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::pageScaleFactor):
+(WebKit::WebViewImpl::scalePage):
+(WebKit::WebViewImpl::setPageScaleFactor):
+* src/WebViewImpl.h:
+
2011-11-07 Jessie Berlin jber...@apple.com
Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
Modified: trunk/Source/WebKit/chromium/public/WebView.h (99439 => 99440)
--- trunk/Source/WebKit/chromium/public/WebView.h 2011-11-07 18:16:33 UTC (rev 99439)
+++ trunk/Source/WebKit/chromium/public/WebView.h 2011-11-07 18:24:48 UTC (rev 99440)
@@ -211,10 +211,13 @@
// is scaled up, 1.0 is scaled down.
virtual float pageScaleFactor() const = 0;
+// FIXME: Delete this once Chromium side has been updated.
+virtual void scalePage(float scaleFactor, const WebPoint origin) = 0;
+
// Scales a page by a factor of scaleFactor and then sets a scroll position to (x, y).
-// scalePage() magnifies and shrinks a page without affecting layout.
+// setPageScaleFactor() magnifies and shrinks a page without affecting layout.
// On the other hand, zooming affects layout of the page.
-virtual void scalePage(float scaleFactor, WebPoint origin) = 0;
+virtual void setPageScaleFactor(float scaleFactor, const WebPoint origin) = 0;
// The ratio of the current device's screen DPI to the target device's screen DPI.
virtual float deviceScaleFactor() const = 0;
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (99439 => 99440)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-11-07 18:16:33 UTC (rev 99439)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-11-07 18:24:48 UTC (rev 99440)
@@ -1841,13 +1841,18 @@
float WebViewImpl::pageScaleFactor() const
{
if (!page())
-return 1.0;
+return 1;
return page()-pageScaleFactor();
}
-void WebViewImpl::scalePage(float scaleFactor, WebPoint origin)
+void WebViewImpl::scalePage(float scaleFactor, const WebPoint origin)
{
+setPageScaleFactor(scaleFactor, origin);
+}
+
+void WebViewImpl::setPageScaleFactor(float scaleFactor, const WebPoint origin)
+{
if (!page())
return;
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (99439 => 99440)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-11-07 18:16:33 UTC (rev 99439)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-11-07 18:24:48 UTC (rev 99440)
@@ -158,7 +158,8 @@
virtual void zoomLimitsChanged(double minimumZoomLevel,
double maximumZoomLevel);
virtual float pageScaleFactor() const;
-virtual void
[webkit-changes] [99441] trunk/Source/WebCore
Title: [99441] trunk/Source/WebCore
Revision 99441
Author wei...@apple.com
Date 2011-11-07 10:26:49 -0800 (Mon, 07 Nov 2011)
Log Message
Add missing .in and .pl files to the Xcode project for easy access.
Reviewed by Eric Carlson.
* WebCore.xcodeproj/project.pbxproj:
Add some missing files to the Xcode project.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (99440 => 99441)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 18:24:48 UTC (rev 99440)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 18:26:49 UTC (rev 99441)
@@ -1,3 +1,12 @@
+2011-11-07 Sam Weinig s...@webkit.org
+
+Add missing .in and .pl files to the Xcode project for easy access.
+
+Reviewed by Eric Carlson.
+
+* WebCore.xcodeproj/project.pbxproj:
+Add some missing files to the Xcode project.
+
2011-11-07 Jessie Berlin jber...@apple.com
Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (99440 => 99441)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-07 18:24:48 UTC (rev 99440)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-07 18:26:49 UTC (rev 99441)
@@ -12426,6 +12426,12 @@
BC98543C0CD3D98B00069BC1 /* JSConsole.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSConsole.h; sourceTree = group; };
BC98A27C0C0C9950004BEBF7 /* JSStyleSheetCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSStyleSheetCustom.cpp; sourceTree = group; };
BC99812D0DBE807A008CE9EF /* DOMAbstractViewFrame.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMAbstractViewFrame.h; sourceTree = group; };
+ BC9A6141146859D9006057FD /* DOMExceptions.in */ = {isa = PBXFileReference; lastKnownFileType = text; path = DOMExceptions.in; sourceTree = group; };
+ BC9A6142146859D9006057FD /* EventFactory.in */ = {isa = PBXFileReference; lastKnownFileType = text; path = EventFactory.in; sourceTree = group; };
+ BC9A6143146859D9006057FD /* EventTargetFactory.in */ = {isa = PBXFileReference; lastKnownFileType = text; path = EventTargetFactory.in; sourceTree = group; };
+ BC9A6144146859D9006057FD /* make_dom_exceptions.pl */ = {isa = PBXFileReference; lastKnownFileType = text.script.perl; path = make_dom_exceptions.pl; sourceTree = group; };
+ BC9A6145146859D9006057FD /* make_event_factory.pl */ = {isa = PBXFileReference; lastKnownFileType = text.script.perl; path = make_event_factory.pl; sourceTree = group; };
+ BC9A6146146859D9006057FD /* make_names.pl */ = {isa = PBXFileReference; lastKnownFileType = text.script.perl; path = make_names.pl; sourceTree = group; };
BC9ADD220CC4032600098C4C /* WebKitCSSTransformValue.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = WebKitCSSTransformValue.h; sourceTree = group; };
BC9ADD7F0CC4092200098C4C /* WebKitCSSTransformValue.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = WebKitCSSTransformValue.cpp; sourceTree = group; };
BCA169A00BFD55B40019CA76 /* JSHTMLTableCaptionElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLTableCaptionElement.cpp; sourceTree = group; };
@@ -21024,6 +21030,7 @@
978D07BD145A0F6C0096908D /* DOMCoreException.cpp */,
BC60D6E80D28D83400B9918F /* DOMCoreException.h */,
BC60D6EB0D28D99900B9918F /* DOMCoreException.idl */,
+BC9A6141146859D9006057FD /* DOMExceptions.in */,
A8185F3609765765005826D9 /* DOMImplementation.cpp */,
A8185F3309765765005826D9 /* DOMImplementation.h */,
93EEC1E909C2877700C515D1 /* DOMImplementation.idl */,
@@ -21055,14 +21062,15 @@
14E836D209F8512000B85AE4 /* Event.idl */,
4138D3341244054800323D33 /* EventContext.cpp */,
4138D3331244054800323D33 /* EventContext.h */,
+418A06CF133C04D500CD379C /* EventDispatcher.cpp */,
+418A06CE133C04D500CD379C /* EventDispatcher.h */,
4AF1AD3C13FD23A400AA9590 /* EventDispatchMediator.cpp */,
4AF1AD3D13FD23A400AA9590 /* EventDispatchMediator.h */,
-418A06CF133C04D500CD379C /* EventDispatcher.cpp */,
-418A06CE133C04D500CD379C /* EventDispatcher.h */,
978D07BB145A0F560096908D /* EventException.cpp */,
BC60D9090D2A17CE00B9918F /* EventException.h */,
BC60D90A0D2A17CE00B9918F /* EventException.idl */,
97665011144FAA4200F6BB51 /* EventFactory.h */,
+BC9A6142146859D9006057FD /* EventFactory.in */,
935FBC4409BA00B900E230B1 /* EventListener.h */,
85AFA7410AAF298400E84305 /* EventListener.idl */,
AD4495F1141FC08900541EDF /* EventListenerMap.cpp */,
@@ -21073,6 +21081,7 @@
E12EDBE90B308E0B002704B6 /* EventTarget.cpp */,
[webkit-changes] [99442] trunk
Title: [99442] trunk
Revision 99442
Author commit-qu...@webkit.org
Date 2011-11-07 10:28:28 -0800 (Mon, 07 Nov 2011)
Log Message
[EFL] Support requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=67112
Patch by ChangSeok Oh shivami...@gmail.com on 2011-11-07
Reviewed by Andreas Kling.
.:
Add build-option for requestAnimationFrame feature.
* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:
Source/_javascript_Core:
Let EFL port use REQUEST_ANIMATION_FRAME_TIMER.
* wtf/Platform.h:
Source/WebCore:
Add some files to build-target when enabling requestAnimationFrame option.
fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html
* CMakeLists.txt:
* UseJSC.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/UseJSC.cmake
trunk/Source/cmake/OptionsEfl.cmake
trunk/Source/cmakeconfig.h.cmake
Diff
Modified: trunk/ChangeLog (99441 => 99442)
--- trunk/ChangeLog 2011-11-07 18:26:49 UTC (rev 99441)
+++ trunk/ChangeLog 2011-11-07 18:28:28 UTC (rev 99442)
@@ -1,3 +1,15 @@
+2011-11-07 ChangSeok Oh shivami...@gmail.com
+
+[EFL] Support requestAnimationFrame API
+https://bugs.webkit.org/show_bug.cgi?id=67112
+
+Reviewed by Andreas Kling.
+
+Add build-option for requestAnimationFrame feature.
+
+* Source/cmake/OptionsEfl.cmake:
+* Source/cmakeconfig.h.cmake:
+
2011-11-07 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
Modified: trunk/Source/_javascript_Core/ChangeLog (99441 => 99442)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-07 18:26:49 UTC (rev 99441)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-07 18:28:28 UTC (rev 99442)
@@ -1,3 +1,14 @@
+2011-11-07 ChangSeok Oh shivami...@gmail.com
+
+[EFL] Support requestAnimationFrame API
+https://bugs.webkit.org/show_bug.cgi?id=67112
+
+Reviewed by Andreas Kling.
+
+Let EFL port use REQUEST_ANIMATION_FRAME_TIMER.
+
+* wtf/Platform.h:
+
2011-11-07 Michael Saboff msab...@apple.com
Towards 8 Bit Strings: Templatize JSC::Lexer class by character type
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (99441 => 99442)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2011-11-07 18:26:49 UTC (rev 99441)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-11-07 18:28:28 UTC (rev 99442)
@@ -1093,7 +1093,7 @@
#define WTF_USE_AVFOUNDATION 1
#endif
-#if PLATFORM(MAC) || PLATFORM(GTK) || (PLATFORM(WIN) !OS(WINCE) !PLATFORM(WIN_CAIRO))
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL) || (PLATFORM(WIN) !OS(WINCE) !PLATFORM(WIN_CAIRO))
#define WTF_USE_REQUEST_ANIMATION_FRAME_TIMER 1
#endif
Modified: trunk/Source/WebCore/CMakeLists.txt (99441 => 99442)
--- trunk/Source/WebCore/CMakeLists.txt 2011-11-07 18:26:49 UTC (rev 99441)
+++ trunk/Source/WebCore/CMakeLists.txt 2011-11-07 18:28:28 UTC (rev 99442)
@@ -2171,6 +2171,15 @@
)
ENDIF ()
+IF (ENABLE_REQUEST_ANIMATION_FRAME)
+LIST(APPEND WebCore_IDL_FILES
+dom/RequestAnimationFrameCallback.idl
+)
+LIST(APPEND WebCore_SOURCES
+dom/ScriptedAnimationController.cpp
+)
+ENDIF ()
+
# Modules that the bindings generator scripts may use
SET(SCRIPTS_BINDINGS
${WEBCORE_DIR}/bindings/scripts/IDLParser.pm
Modified: trunk/Source/WebCore/ChangeLog (99441 => 99442)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 18:26:49 UTC (rev 99441)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 18:28:28 UTC (rev 99442)
@@ -1,3 +1,23 @@
+2011-11-07 ChangSeok Oh shivami...@gmail.com
+
+[EFL] Support requestAnimationFrame API
+https://bugs.webkit.org/show_bug.cgi?id=67112
+
+Reviewed by Andreas Kling.
+
+Add some files to build-target when enabling requestAnimationFrame option.
+
+fast/animation/request-animation-frame-cancel.html
+fast/animation/request-animation-frame-cancel2.html
+fast/animation/request-animation-frame-display.html
+fast/animation/request-animation-frame-during-modal.html
+fast/animation/request-animation-frame-timestamps.html
+fast/animation/request-animation-frame-within-callback.html
+fast/animation/request-animation-frame.html
+
+* CMakeLists.txt:
+* UseJSC.cmake:
+
2011-11-07 Sam Weinig s...@webkit.org
Add missing .in and .pl files to the Xcode project for easy access.
Modified: trunk/Source/WebCore/UseJSC.cmake (99441 => 99442)
---
[webkit-changes] [99443] trunk/Source/WebKit2
Title: [99443] trunk/Source/WebKit2
Revision 99443
Author wei...@apple.com
Date 2011-11-07 10:46:58 -0800 (Mon, 07 Nov 2011)
Log Message
WKPage.h should be in PrivateHeaders.
Rubber-stamped by Anders Carlsson.
* WebKit2.xcodeproj/project.pbxproj:
Mark WKPage.h private.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99442 => 99443)
--- trunk/Source/WebKit2/ChangeLog 2011-11-07 18:28:28 UTC (rev 99442)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-07 18:46:58 UTC (rev 99443)
@@ -1,3 +1,12 @@
+2011-11-07 Sam Weinig s...@webkit.org
+
+WKPage.h should be in PrivateHeaders.
+
+Rubber-stamped by Anders Carlsson.
+
+* WebKit2.xcodeproj/project.pbxproj:
+Mark WKPage.h private.
+
2011-11-07 Anders Carlsson ander...@apple.com
Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (99442 => 99443)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2011-11-07 18:28:28 UTC (rev 99442)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2011-11-07 18:46:58 UTC (rev 99443)
@@ -727,7 +727,7 @@
BCD597D0112B56AC00EC8C23 /* WKPreferences.h in Headers */ = {isa = PBXBuildFile; fileRef = BCD597CE112B56AC00EC8C23 /* WKPreferences.h */; settings = {ATTRIBUTES = (Private, ); }; };
BCD597D1112B56AC00EC8C23 /* WKPreferences.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCD597CF112B56AC00EC8C23 /* WKPreferences.cpp */; };
BCD597D6112B56DC00EC8C23 /* WKPage.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCD597D4112B56DC00EC8C23 /* WKPage.cpp */; };
- BCD597D7112B56DC00EC8C23 /* WKPage.h in Headers */ = {isa = PBXBuildFile; fileRef = BCD597D5112B56DC00EC8C23 /* WKPage.h */; settings = {ATTRIBUTES = (Public, ); }; };
+ BCD597D7112B56DC00EC8C23 /* WKPage.h in Headers */ = {isa = PBXBuildFile; fileRef = BCD597D5112B56DC00EC8C23 /* WKPage.h */; settings = {ATTRIBUTES = (Private, ); }; };
BCD597FF112B57BE00EC8C23 /* WebPreferences.h in Headers */ = {isa = PBXBuildFile; fileRef = BCD597FD112B57BE00EC8C23 /* WebPreferences.h */; };
BCD59800112B57BE00EC8C23 /* WebPreferences.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCD597FE112B57BE00EC8C23 /* WebPreferences.cpp */; };
BCD598AC112B7FDF00EC8C23 /* WebPreferencesStore.h in Headers */ = {isa = PBXBuildFile; fileRef = BCD598AA112B7FDF00EC8C23 /* WebPreferencesStore.h */; };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99444] trunk/Source/WebCore
Title: [99444] trunk/Source/WebCore
Revision 99444
Author andreas.kl...@nokia.com
Date 2011-11-07 11:09:44 -0800 (Mon, 07 Nov 2011)
Log Message
REGRESSION(r99409): Broke transitions/clip-transition.html
http://webkit.org/b/71692
Reviewed by Darin Adler.
Add missing base class initializers to CSSPrimitiveValue constructors.
This was causing some CSSPrimitiveValues to masquerade as CSS_CUSTOM values.
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.h
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99443 => 99444)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 18:46:58 UTC (rev 99443)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 19:09:44 UTC (rev 99444)
@@ -1,3 +1,18 @@
+2011-11-07 Andreas Kling kl...@webkit.org
+
+REGRESSION(r99409): Broke transitions/clip-transition.html
+http://webkit.org/b/71692
+
+Reviewed by Darin Adler.
+
+Add missing base class initializers to CSSPrimitiveValue constructors.
+This was causing some CSSPrimitiveValues to masquerade as CSS_CUSTOM values.
+
+* css/CSSPrimitiveValue.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+
2011-11-07 ChangSeok Oh shivami...@gmail.com
[EFL] Support requestAnimationFrame API
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (99443 => 99444)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-11-07 18:46:58 UTC (rev 99443)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-11-07 19:09:44 UTC (rev 99444)
@@ -225,9 +225,18 @@
CSSPrimitiveValue(const Length);
templatetypename T CSSPrimitiveValue(T); // Defined in CSSPrimitiveValueMappings.h
-templatetypename T CSSPrimitiveValue(T* val) { init(PassRefPtrT(val)); }
-templatetypename T CSSPrimitiveValue(PassRefPtrT val) { init(val); }
+templatetypename T CSSPrimitiveValue(T* val)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+{
+init(PassRefPtrT(val));
+}
+templatetypename T CSSPrimitiveValue(PassRefPtrT val)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+{
+init(val);
+}
+
static void create(int); // compile-time guard
static void create(unsigned); // compile-time guard
templatetypename T operator T*(); // compile-time guard
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (99443 => 99444)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-11-07 18:46:58 UTC (rev 99443)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-11-07 19:09:44 UTC (rev 99444)
@@ -50,7 +50,8 @@
namespace WebCore {
template inline CSSPrimitiveValue::CSSPrimitiveValue(short i)
-: m_type(CSS_NUMBER)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+, m_type(CSS_NUMBER)
, m_hasCachedCSSText(false)
{
m_value.num = static_castdouble(i);
@@ -66,7 +67,8 @@
}
template inline CSSPrimitiveValue::CSSPrimitiveValue(unsigned short i)
-: m_type(CSS_NUMBER)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+, m_type(CSS_NUMBER)
, m_hasCachedCSSText(false)
{
m_value.num = static_castdouble(i);
@@ -82,7 +84,8 @@
}
template inline CSSPrimitiveValue::CSSPrimitiveValue(int i)
-: m_type(CSS_NUMBER)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+, m_type(CSS_NUMBER)
, m_hasCachedCSSText(false)
{
m_value.num = static_castdouble(i);
@@ -98,7 +101,8 @@
}
template inline CSSPrimitiveValue::CSSPrimitiveValue(unsigned i)
-: m_type(CSS_NUMBER)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+, m_type(CSS_NUMBER)
, m_hasCachedCSSText(false)
{
m_value.num = static_castdouble(i);
@@ -115,7 +119,8 @@
template inline CSSPrimitiveValue::CSSPrimitiveValue(float i)
-: m_type(CSS_NUMBER)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+, m_type(CSS_NUMBER)
, m_hasCachedCSSText(false)
{
m_value.num = static_castdouble(i);
@@ -131,7 +136,8 @@
}
template inline CSSPrimitiveValue::CSSPrimitiveValue(ColumnSpan columnSpan)
-: m_hasCachedCSSText(false)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+, m_hasCachedCSSText(false)
{
switch (columnSpan) {
case ColumnSpanAll:
@@ -157,7 +163,8 @@
template inline CSSPrimitiveValue::CSSPrimitiveValue(PrintColorAdjust value)
-: m_type(CSS_IDENT)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+, m_type(CSS_IDENT)
, m_hasCachedCSSText(false)
{
switch (value) {
@@ -185,7 +192,8 @@
template inline CSSPrimitiveValue::CSSPrimitiveValue(EBorderStyle e)
-: m_type(CSS_IDENT)
+: CSSValue(CSS_PRIMITIVE_VALUE)
+, m_type(CSS_IDENT)
, m_hasCachedCSSText(false)
{
switch (e) {
@@ -237,7 +245,8 @@
}
template inline CSSPrimitiveValue::CSSPrimitiveValue(CompositeOperator e)
-
[webkit-changes] [99446] branches/safari-534.54-branch/
Title: [99446] branches/safari-534.54-branch/ Revision 99446 Author lforsch...@apple.com Date 2011-11-07 11:10:40 -0800 (Mon, 07 Nov 2011) Log Message New Branch. Added Paths branches/safari-534.54-branch/ Diff Property changes: branches/safari-534.54-branch Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99447] trunk/Source/WebCore
Title: [99447] trunk/Source/WebCore
Revision 99447
Author o...@webkit.org
Date 2011-11-07 11:12:08 -0800 (Mon, 07 Nov 2011)
Log Message
Unreviewed, rolling out r99432.
http://trac.webkit.org/changeset/99432
https://bugs.webkit.org/show_bug.cgi?id=71709
It made layout tests extra slow on all bots (Requested by
Ossy_night on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-07
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99446 => 99447)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 19:10:40 UTC (rev 99446)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 19:12:08 UTC (rev 99447)
@@ -1,3 +1,18 @@
+2011-11-07 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r99432.
+http://trac.webkit.org/changeset/99432
+https://bugs.webkit.org/show_bug.cgi?id=71709
+
+It made layout tests extra slow on all bots (Requested by
+Ossy_night on #webkit).
+
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView):
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype._attachInternal):
+(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
+
2011-11-07 Andreas Kling kl...@webkit.org
REGRESSION(r99409): Broke transitions/clip-transition.html
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99446 => 99447)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-07 19:10:40 UTC (rev 99446)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-07 19:12:08 UTC (rev 99447)
@@ -61,6 +61,7 @@
this.promptElement.id = console-prompt;
this.promptElement.className = source-code;
this.promptElement.spellcheck = false;
+this.promptElement.addEventListener(keydown, this._promptKeyDown.bind(this), true);
this.messagesElement.appendChild(this.promptElement);
this.messagesElement.appendChild(document.createElement(br));
@@ -113,7 +114,6 @@
this.prompt = new WebInspector.TextPromptWithHistory(this.completions.bind(this), ExpressionStopCharacters + .);
this.prompt.setSuggestBoxEnabled(generic-suggest);
this.prompt.attach(this.promptElement);
-this.prompt.proxyElement.addEventListener(keydown, this._promptKeyDown.bind(this), false);
this.prompt.setHistoryData(WebInspector.settings.consoleHistory.get());
}
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99446 => 99447)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 19:10:40 UTC (rev 99446)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 19:12:08 UTC (rev 99447)
@@ -105,7 +105,7 @@
element.parentElement.insertBefore(this.proxyElement, element);
this.proxyElement.appendChild(element);
this._element.addStyleClass(text-prompt);
-this._element.addEventListener(keydown, this._boundOnKeyDown, false);
+this._element.addEventListener(keydown, this._boundOnKeyDown, true);
this._element.addEventListener(selectstart, this._selectStart.bind(this), false);
if (typeof this._suggestBoxClassName === string)
@@ -1078,8 +1078,7 @@
enterKeyPressed: function(event)
{
-this.acceptSuggestion();
-return true;
+return this.acceptSuggestion();
},
tabKeyPressed: function(event)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99450] trunk/Source/WebCore
Title: [99450] trunk/Source/WebCore Revision 99450 Author andreas.kl...@nokia.com Date 2011-11-07 11:20:59 -0800 (Mon, 07 Nov 2011) Log Message Don't use CSSOM's CSSValue.cssValueType internally in WebCore. http://webkit.org/b/71679 Reviewed by Darin Adler. Swap out cssValueType() usage for isPrimitiveValue(), isInitialValue() and isInheritedValue() to increase code clarity. The plan is to turn cssValueType() into a computed value based on the CSSValue subclass (coming soon to http://webkit.org/b/71668.) This is a clean-up in preparation for that. * bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter): * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::V8CSSStyleDeclaration::namedPropertyGetter): * css/CSSInheritedValue.h: (WebCore::CSSInheritedValue::isInheritedValue): * css/CSSInitialValue.h: (WebCore::CSSInitialValue::isInitialValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseColor): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyDeclaration): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapFillAttachment): (WebCore::CSSStyleSelector::mapFillClip): (WebCore::CSSStyleSelector::mapFillComposite): (WebCore::CSSStyleSelector::mapFillOrigin): (WebCore::CSSStyleSelector::mapFillImage): (WebCore::CSSStyleSelector::mapFillRepeatX): (WebCore::CSSStyleSelector::mapFillRepeatY): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition): (WebCore::CSSStyleSelector::mapAnimationDelay): (WebCore::CSSStyleSelector::mapAnimationDirection): (WebCore::CSSStyleSelector::mapAnimationDuration): (WebCore::CSSStyleSelector::mapAnimationFillMode): (WebCore::CSSStyleSelector::mapAnimationIterationCount): (WebCore::CSSStyleSelector::mapAnimationName): (WebCore::CSSStyleSelector::mapAnimationPlayState): (WebCore::CSSStyleSelector::mapAnimationProperty): (WebCore::CSSStyleSelector::mapAnimationTimingFunction): * css/CSSValue.h: (WebCore::CSSValue::isInheritedValue): (WebCore::CSSValue::isInitialValue): * css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): * editing/EditingStyle.cpp: (WebCore::EditingStyle::extractFontSizeDelta): (WebCore::EditingStyle::mergeStyleFromRulesForSerialization): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp trunk/Source/WebCore/css/CSSInheritedValue.h trunk/Source/WebCore/css/CSSInitialValue.h trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/css/CSSValue.h trunk/Source/WebCore/css/SVGCSSStyleSelector.cpp trunk/Source/WebCore/editing/EditingStyle.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (99449 => 99450) --- trunk/Source/WebCore/ChangeLog 2011-11-07 19:20:40 UTC (rev 99449) +++ trunk/Source/WebCore/ChangeLog 2011-11-07 19:20:59 UTC (rev 99450) @@ -1,3 +1,58 @@ +2011-11-07 Andreas Kling kl...@webkit.org + +Don't use CSSOM's CSSValue.cssValueType internally in WebCore. +http://webkit.org/b/71679 + +Reviewed by Darin Adler. + +Swap out cssValueType() usage for isPrimitiveValue(), isInitialValue() +and isInheritedValue() to increase code clarity. + +The plan is to turn cssValueType() into a computed value based on the +CSSValue subclass (coming soon to http://webkit.org/b/71668.) +This is a clean-up in preparation for that. + +* bindings/js/JSCSSStyleDeclarationCustom.cpp: +(WebCore::JSCSSStyleDeclaration::nameGetter): +* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: +(WebCore::V8CSSStyleDeclaration::namedPropertyGetter): +* css/CSSInheritedValue.h: +(WebCore::CSSInheritedValue::isInheritedValue): +* css/CSSInitialValue.h: +(WebCore::CSSInitialValue::isInitialValue): +* css/CSSParser.cpp: +(WebCore::CSSParser::parseColor): +* css/CSSStyleSelector.cpp: +(WebCore::CSSStyleSelector::applyDeclaration): +(WebCore::CSSStyleSelector::applyProperty): +(WebCore::CSSStyleSelector::mapFillAttachment): +(WebCore::CSSStyleSelector::mapFillClip): +(WebCore::CSSStyleSelector::mapFillComposite): +(WebCore::CSSStyleSelector::mapFillOrigin): +(WebCore::CSSStyleSelector::mapFillImage): +(WebCore::CSSStyleSelector::mapFillRepeatX): +(WebCore::CSSStyleSelector::mapFillRepeatY): +(WebCore::CSSStyleSelector::mapFillSize): +(WebCore::CSSStyleSelector::mapFillXPosition): +(WebCore::CSSStyleSelector::mapFillYPosition): +(WebCore::CSSStyleSelector::mapAnimationDelay): +(WebCore::CSSStyleSelector::mapAnimationDirection): +(WebCore::CSSStyleSelector::mapAnimationDuration): +(WebCore::CSSStyleSelector::mapAnimationFillMode): +
[webkit-changes] [99452] branches/chromium/874/Source/WebCore/bindings/v8
Title: [99452] branches/chromium/874/Source/WebCore/bindings/v8
Revision 99452
Author jap...@chromium.org
Date 2011-11-07 11:46:54 -0800 (Mon, 07 Nov 2011)
Log Message
Merge 99311 - [V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
https://bugs.webkit.org/show_bug.cgi?id=71569
Reviewed by Adam Barth.
No new tests, this has only been successfully triggered
using ppapi flash.
* bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):
* bindings/v8/npruntime.cpp:
TBR=jap...@chromium.org
Review URL: http://codereview.chromium.org/8493015
Modified Paths
branches/chromium/874/Source/WebCore/bindings/v8/V8Helpers.cpp
branches/chromium/874/Source/WebCore/bindings/v8/npruntime.cpp
Diff
Modified: branches/chromium/874/Source/WebCore/bindings/v8/V8Helpers.cpp (99451 => 99452)
--- branches/chromium/874/Source/WebCore/bindings/v8/V8Helpers.cpp 2011-11-07 19:32:04 UTC (rev 99451)
+++ branches/chromium/874/Source/WebCore/bindings/v8/V8Helpers.cpp 2011-11-07 19:46:54 UTC (rev 99452)
@@ -32,6 +32,7 @@
#include V8Helpers.h
#include DOMWindow.h
+#include Frame.h
#include NPV8Object.h
#include V8Proxy.h
@@ -40,6 +41,9 @@
v8::Localv8::Context toV8Context(NPP npp, NPObject* npObject)
{
V8NPObject* object = reinterpret_castV8NPObject*(npObject);
+DOMWindow* domWindow = object-rootObject;
+if (!domWindow || domWindow != domWindow-frame()-domWindow())
+return v8::Localv8::Context();
return V8Proxy::mainWorldContext(object-rootObject-frame());
}
Modified: branches/chromium/874/Source/WebCore/bindings/v8/npruntime.cpp (99451 => 99452)
--- branches/chromium/874/Source/WebCore/bindings/v8/npruntime.cpp 2011-11-07 19:32:04 UTC (rev 99451)
+++ branches/chromium/874/Source/WebCore/bindings/v8/npruntime.cpp 2011-11-07 19:46:54 UTC (rev 99452)
@@ -418,6 +418,13 @@
set-remove(sub_object);
liveObjectMap.remove(sub_object);
+// Script objects hold a refernce to their DOMWindow*, which is going away if
+// we're unregistering the associated owner NPObject. Clear it out.
+if (sub_object-_class == npScriptObjectClass) {
+V8NPObject* v8npObject = reinterpret_castV8NPObject*(sub_object);
+v8npObject-rootObject = 0;
+}
+
// Remove the JS references to the object.
forgetV8ObjectForNPObject(sub_object);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99453] trunk/Source/WebCore
Title: [99453] trunk/Source/WebCore
Revision 99453
Author vse...@chromium.org
Date 2011-11-07 12:09:42 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: Suggest box should not accept suggestion on space key pressed.
https://bugs.webkit.org/show_bug.cgi?id=71706
Reviewed by Pavel Feldman.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99452 => 99453)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 19:46:54 UTC (rev 99452)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 20:09:42 UTC (rev 99453)
@@ -1,3 +1,14 @@
+2011-11-07 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Suggest box should not accept suggestion on space key pressed.
+https://bugs.webkit.org/show_bug.cgi?id=71706
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype.onKeyDown):
+(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):
+
2011-11-07 Andreas Kling kl...@webkit.org
Don't use CSSOM's CSSValue.cssValueType internally in WebCore.
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99452 => 99453)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 19:46:54 UTC (rev 99452)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 20:09:42 UTC (rev 99453)
@@ -246,8 +246,7 @@
if (this._suggestForceable event.ctrlKey !event.metaKey !event.altKey !event.shiftKey) {
this.defaultKeyHandler(event, true);
handled = true;
-} else if (this.isSuggestBoxVisible())
-handled = this._suggestBox.spaceKeyPressed(event);
+}
break;
case Alt:
case Meta:
@@ -1084,11 +1083,5 @@
tabKeyPressed: function(event)
{
return this.enterKeyPressed(event);
-},
-
-spaceKeyPressed: function(event)
-{
-this.acceptSuggestion();
-return false; // Do not inhibit a whitespace entry after the suggestion.
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99454] trunk
Title: [99454] trunk
Revision 99454
Author commit-qu...@webkit.org
Date 2011-11-07 12:18:52 -0800 (Mon, 07 Nov 2011)
Log Message
Optimize outline rendering to avoid transparency layers
https://bugs.webkit.org/show_bug.cgi?id=60750
Source/WebCore:
Add fast path for solid block outlines with alpha.
Improve readability of piecewise path while at it.
Patch by David Barr davidb...@chromium.org on 2011-11-07
Reviewed by Simon Fraser.
No intended change in behaviour, no new tests.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintOutline):
LayoutTests:
Rebaseline pixel tests to accommodate subtle change in rounding.
Patch by David Barr davidb...@chromium.org on 2011-11-07
Reviewed by Simon Fraser.
* platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png: Added.
* platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Added Paths
trunk/LayoutTests/platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/layers/self-painting-outline-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (99453 => 99454)
--- trunk/LayoutTests/ChangeLog 2011-11-07 20:09:42 UTC (rev 99453)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 20:18:52 UTC (rev 99454)
@@ -1,3 +1,15 @@
+2011-11-07 David Barr davidb...@chromium.org
+
+Optimize outline rendering to avoid transparency layers
+https://bugs.webkit.org/show_bug.cgi?id=60750
+
+Rebaseline pixel tests to accommodate subtle change in rounding.
+
+Reviewed by Simon Fraser.
+
+* platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png: Added.
+* platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Added.
+
2011-11-07 Tony Chang t...@chromium.org
[chromium] Mark perf/documnet-contians.html as slow.
Added: trunk/LayoutTests/platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png (0 => 99454)
--- trunk/LayoutTests/platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/box-shadow/box-shadow-radius-expected.png 2011-11-07 20:18:52 UTC (rev 99454)
@@ -0,0 +1,98 @@
+\x89PNG
+
+
+IHDR X \xAD\xA8rB )tEXtchecksum a550ee84a1a8e910dfbb74564106be9fjVE) zPLTE|\x82|}\x83}~\x84~\x85\x80\x86\x80\x81\x87\x81\x82\x88\x82\x83\x89\x83\x84\x8A\x84\x85\x8B\x85\x86\x8C\x86\x87\x8D\x87\x88\x8E\x88\x89\x8F\x89\x8A\x90\x8A\x8A\x91\x8A\x8B\x92\x8B\x8C\x93\x8C\x8D\x94\x8D\x8E\x95\x8E\x8F\x96\x8F\x90\x97\x90\x91\x98\x91\x92\x99\x92\x93\x9A\x93\x94\x9B\x94\x95\x9C\x95\x96\x9D\x96\x97\x9E\x97\x98\x9F\x98\x99\xA0\x99\x9A\xA1\x9A\x9B\xA2\x9B\x9B\xA3\x9B\x9C\xA4\x9C\x9D\xA5\x9D\x9E\xA6\x9E\x9F\xA7\x9F\xA0\xA8\xA0\xA1\xA9\xA1\xA2\xAA\xA2\xA3\xAB\xA3\xA4\xAC\xA4\xA5\xAD\xA5\xA6\xAE\xA6\xA7\xAF\xA7\xA8\xB0\xA8\xA9\xB1\xA9\xAA\xB2\xAA\xAB\xB3\xAB\xAC\xB4\xAC\xAC\xB5\xAC\xAD\xB6\xAD\xAE\xB7\xAE\xAF\xB8\xAF\xB0\xB9\xB0\xB1\xBA\xB1\xB2\xBB\xB2\xB3\xBC\xB3\xB4\xBD\xB4\xB5\xBE\xB5\xB6\xBF\xB6\xB7\xC0\xB7\xB8\xC1\xB8\xB9¹\xBAú\xBBĻ\xBCż\xBDƽ\xBEǾ\xBEȾ\xBFɿ\xC0\xC0\xC0\xC0\xCA\xC0\xC1\xCB\xC1\xC2\xCC\xC2\xC3\xCD\xC3\xC4\xCE\xC4\xC5\xCF\xC5\xC6\xD0\xC6\xC7\xD1\xC7\xC8\xD2\xC8\xC9\xD3\xC9\xCA\xD4\xCA\xCB\xD5\xCB\xCC\xD6\xCC\xCD\xD7\xCD\xCE\xD8\xCE\xCF\xD9\xCF\xCF\xDA\xCF\xD0\xDB\xD0\xD1\xDC\xD1\xD2\xDD\xD2\xD3\xDE\xD3\xD4\xDF\xD4\xD5\xE0\xD5\xD6\xE1\xD6\xD7\xE2\xD7\xD8\xE3\xD8\xD9\xE4\xD9\xDA\xE5\xDA\xDB\xE6\xDB\xDC\xE7\xDC\xDD\xE8\xDD\xDE\xE9\xDE\xDF\xEA\xDF\xE0\xEB\xE0\xE0\xEC\xE0\xE1\xED\xE1\xE2\xEE\xE2\xE3\xEF\xE3\xE4\xF0\xE4\xE5\xF1\xE5\xE6\xF2\xE6\xE7\xF3\xE7\xE8\xF4\xE8\xE9\xF5\xE9\xEA\xF6\xEA\xEB\xF7\xEB\xEC\xF8\xEC\xED\xF9\xED\xEE\xFA\xEE\xEF\xFB\xEF\xF0\xFC\xF0\xF2\xFE\xF2\xFF\xFF\xFF\xE6\xAD\xE0T .qIDATx\xDA\xEC\xDAMN\xE40\x80\xD1*'W\x9A\xE3\xCD \xB9R⚅\x93\xA67 !\xDCC\x82\xDE\xEB\xF0\xB3\xA7\xBF\x94-ȿ|\xA4Y\x81\x80@@ \xF0d}\xFA\xFE\xCDr|\xE0\x8F5\xFA\xC2\xFD\xDA@~\xEB\xEF\xF8mo\xD6\xE8Kkd\x8B\xCE \x80@@ \x81\x80@@ \x80@@ \x81\x80@@ \x80@@ \x81\x80@ \x81\x80@@ \x81\x80@ \x81\x80@@ \x81 \x81\x80@@ \x81 \x81\x80@@ b\xB5?\xA1.\xF4\xB3\xA4\xDBa\x82\x80@@ pH\xE7?\x9Fݝ\xC6r\xF76jv,OQd\xA9D \xF7\xAD\xA3 _\x8F\x92W\xE4\xA8D#\xB9[ u\xBC\xCEL\xE6%r\xE61\xAE\xAC\x8C,\x89\xE4V}TTTUԣ\x93駏\x8C\x8C\xCC\xC8 \x9B-\x85\\x90\x9F\xFA{qެ\x8F\x8Az\xF7\x82BF '\x85\x98 7룪\xAA\x9Fף\x90\x9A\xF5\xA88\xFAh\xE7\x95
+\xB9\ \xD3\xEE\xF8\xA7\xEF\x83\xDB\xF6ѫ\xF7\xE3c\xFA9\xC7G\xCB\xD6Z\xB6j\xD9̐krl^\x96HF \xFB\xEB\xBCi \xBD\xF7\xBE\xF7\xBE\xF7\xDE\xFB\xD8g\xCD\xA4gffk\xAD-\xAD-U-r\xA5@*\xEAx0\xBEp\x82 \x8F\xC8\x{33518CF}}x$s '9șDz,}Yb\xFC\xFF\x84\xAEHU\xF5\xEE\xFC\xCB
+\xC9 \xF7\xBFZ\xDE\xED\x80 1\xFAض}\xDB\xF6m߷\xC7 \x99Ș 벬˺\xF6\xEC\x9Cˎ\xDB0 E\xF5\xB4g0?\xD5O\xEF7
[webkit-changes] [99455] trunk/Source/WebKit2
Title: [99455] trunk/Source/WebKit2
Revision 99455
Author ander...@apple.com
Date 2011-11-07 12:21:36 -0800 (Mon, 07 Nov 2011)
Log Message
Remove unused DrawingArea::syncCompositingLayers
https://bugs.webkit.org/show_bug.cgi?id=71717
Reviewed by John Sullivan.
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/TiledDrawingArea.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99454 => 99455)
--- trunk/Source/WebKit2/ChangeLog 2011-11-07 20:18:52 UTC (rev 99454)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-07 20:21:36 UTC (rev 99455)
@@ -1,5 +1,16 @@
2011-11-07 Anders Carlsson ander...@apple.com
+Remove unused DrawingArea::syncCompositingLayers
+https://bugs.webkit.org/show_bug.cgi?id=71717
+
+Reviewed by John Sullivan.
+
+* WebProcess/WebPage/DrawingArea.h:
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+* WebProcess/WebPage/TiledDrawingArea.h:
+
+2011-11-07 Anders Carlsson ander...@apple.com
+
Rename NetscapePlugin::wantsWindowRelativeNPWindowCoordinates to NetscapePlugin::wantsPluginRelativeNPWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71708
Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h (99454 => 99455)
--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h 2011-11-07 20:18:52 UTC (rev 99454)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h 2011-11-07 20:21:36 UTC (rev 99455)
@@ -79,7 +79,6 @@
#if USE(ACCELERATED_COMPOSITING)
virtual void setRootCompositingLayer(WebCore::GraphicsLayer*) = 0;
virtual void scheduleCompositingLayerSync() = 0;
-virtual void syncCompositingLayers() = 0;
#if USE(TEXTURE_MAPPER)
virtual void didReceiveLayerTreeHostMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) = 0;
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp (99454 => 99455)
--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp 2011-11-07 20:18:52 UTC (rev 99454)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp 2011-11-07 20:21:36 UTC (rev 99455)
@@ -310,10 +310,6 @@
m_layerTreeHost-scheduleLayerFlush();
}
-void DrawingAreaImpl::syncCompositingLayers()
-{
-}
-
void DrawingAreaImpl::updateBackingStoreState(uint64_t stateID, bool respondImmediately, float deviceScaleFactor, const WebCore::IntSize size, const WebCore::IntSize scrollOffset)
{
ASSERT(!m_inUpdateBackingStoreState);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.h (99454 => 99455)
--- trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.h 2011-11-07 20:18:52 UTC (rev 99454)
+++ trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.h 2011-11-07 20:21:36 UTC (rev 99455)
@@ -48,7 +48,6 @@
virtual void detachCompositingContext() { }
virtual void setRootCompositingLayer(WebCore::GraphicsLayer*) { }
virtual void scheduleCompositingLayerSync() { }
-virtual void syncCompositingLayers() { }
virtual void didReceiveLayerTreeHostMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*);
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99456] trunk
Title: [99456] trunk
Revision 99456
Author ves...@webkit.org
Date 2011-11-07 12:26:49 -0800 (Mon, 07 Nov 2011)
Log Message
[Qt] Build all libraries in both debug and release on Mac OS X
We were already building the final shared library in debug and release,
but were missing the static _javascript_Core and WebCore libraries, which
then broke the build.
Reviewed-by Andreas Kling.
Modified Paths
trunk/Source/WebKit2/Target.pri
trunk/Source/api.pri
trunk/Tools/WebKitTestRunner/InjectedBundle/Target.pri
trunk/Tools/qmake/mkspecs/features/default_post.prf
Diff
Modified: trunk/Source/WebKit2/Target.pri (99455 => 99456)
--- trunk/Source/WebKit2/Target.pri 2011-11-07 20:21:36 UTC (rev 99455)
+++ trunk/Source/WebKit2/Target.pri 2011-11-07 20:26:49 UTC (rev 99456)
@@ -17,9 +17,6 @@
QT += declarative
-# Build both debug and release configurations
-mac: CONFIG += build_all
-
WEBKIT1_HEADERS_SHARED_WITH_WEBKIT2= \
$$PWD/../WebKit/qt/WebCoreSupport/QtWebComboBox.h
Modified: trunk/Source/api.pri (99455 => 99456)
--- trunk/Source/api.pri 2011-11-07 20:21:36 UTC (rev 99455)
+++ trunk/Source/api.pri 2011-11-07 20:26:49 UTC (rev 99456)
@@ -209,20 +209,18 @@
!build_pass {
message(Building QtWebKit as a framework, as that's how Qt was built. You can)
message(override this by passing CONFIG+=webkit_no_framework to build-webkit.)
-
-CONFIG += build_all
} else {
isEmpty(QT_SOURCE_TREE):debug_and_release:TARGET = $$qtLibraryTarget($$TARGET)
}
CONFIG += lib_bundle qt_no_framework_direct_includes qt_framework
FRAMEWORK_HEADERS.version = Versions
-FRAMEWORK_HEADERS.files = $$dirname(headers.files)/$${TARGET}
+FRAMEWORK_HEADERS.files = $$dirname(headers.files)/QtWebKit
FRAMEWORK_HEADERS.path = Headers
QMAKE_BUNDLE_DATA += FRAMEWORK_HEADERS
# No-op to satisfy the dependency for FRAMEWORK_HEADERS
-module_include.target = $$dirname(headers.files)/$${TARGET}
+module_include.target = $$dirname(headers.files)/QtWebKit
module_include.commands = $${MAKEFILE_NOOP_COMMAND}
contains(QMAKE_EXTRA_TARGETS, fwheader_generator): module_include.depends += fwheader_generator
QMAKE_EXTRA_TARGETS += module_include
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Target.pri (99455 => 99456)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/Target.pri 2011-11-07 20:21:36 UTC (rev 99455)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Target.pri 2011-11-07 20:26:49 UTC (rev 99456)
@@ -7,6 +7,8 @@
TEMPLATE = lib
TARGET = WTRInjectedBundle
+mac:debug_and_release:TARGET = $$qtLibraryTarget($$TARGET)
+
SOURCES += \
InjectedBundle.cpp \
InjectedBundle.h \
@@ -42,12 +44,6 @@
QT += declarative widgets
-!CONFIG(release, debug|release) {
-OBJECTS_DIR = obj/debug
-} else { # Release
-OBJECTS_DIR = obj/release
-}
-
load(features)
load(webcore)
Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (99455 => 99456)
--- trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-07 20:21:36 UTC (rev 99455)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-07 20:26:49 UTC (rev 99456)
@@ -120,6 +120,9 @@
# Triggers the right export macro for the QtWebKit API (see qwebkitglobal.h)
DEFINES += BUILDING_WEBKIT
+# Build both debug and release configurations
+mac: CONFIG += build_all
+
DEFINES += QT_ASCII_CAST_WARNINGS
win32-msvc*|win32-icc: INCLUDEPATH += $$ROOT_WEBKIT_DIR/Source/_javascript_Core/os-win32
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99457] trunk/LayoutTests
Title: [99457] trunk/LayoutTests
Revision 99457
Author rob...@webkit.org
Date 2011-11-07 12:29:09 -0800 (Mon, 07 Nov 2011)
Log Message
[chromium] css2.1/20110323/block-non-replaced-width-008.htm fails on mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=71214
Reviewed by Adam Barth.
* platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (99456 => 99457)
--- trunk/LayoutTests/ChangeLog 2011-11-07 20:26:49 UTC (rev 99456)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 20:29:09 UTC (rev 99457)
@@ -1,3 +1,12 @@
+2011-11-07 Robert Hogan rob...@webkit.org
+
+[chromium] css2.1/20110323/block-non-replaced-width-008.htm fails on mac 10.5 CG
+https://bugs.webkit.org/show_bug.cgi?id=71214
+
+Reviewed by Adam Barth.
+
+* platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
+
2011-11-07 David Barr davidb...@chromium.org
Optimize outline rendering to avoid transparency layers
Added: trunk/LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png (0 => 99457)
--- trunk/LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png 2011-11-07 20:29:09 UTC (rev 99457)
@@ -0,0 +1,18 @@
+\x89PNG
+
+
+IHDR X \x9Av\x82p )tEXtchecksum 12c7c837f262dad07fecb0e48d038eeb\xDC\xC8*\xD0 IDATx\x9C\xED\xDD\x94\x95u\x9D\xC0\xF1?\x848@\xE2\x90\x96%%\xD4ԤR\xC8
+K[6\xC5\xE3Aw\xDD\xD3\xC1]-u=\xC7\\xCB-\xD7\xCAl\xB7\xD2\xD5e\x9A\xA8\x94ئ\x92\x98H\xE8.\xB6\x8A\xA6\xE8\xA6e*\xEC\xD15 ݐ\x86\xDF\xCC|\xF7\xCE\xDCe\x86\xB9wf\xFC`\xF5z\x9D\xD3\xC9{\xE7\xDE\xE7\xF9\xDF\xEF#\xF2\x9E\xFB\xCC3\xDDJ)% t\xDF\xD7 \xFEx \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2\x90\xBDl͚5\xF1\xF2\xCB/\xEF\xF6\xFC\xEAի\xE3\xE1\x87 \x8E7\xDF|\xB3\xDDm444\xC4k\xAF\xBD\xF6V \xAF]\xD5\xC6\xFFV\xD8uNZ\xEFw\xEB֭\xF1\xD8c\x8FU}\xDC\x8D\x8D\x8D\xF1\xEB_\xFF\xBA\xCB\xE3\xA5cb\xE5ʕ{\xF4ޮ\xAC\xF3\xBE\xE6\x80\x8Ei7@\xFAя\xC6\xF0\xE1\xC3\xE3\xB4\xD3N\x8B\xB3\xCF;z\xF4\xE8 |p\x9Cu\xD6Yq\xF2\xC9'\xC7~\xFB\xEDs\xE6\xCC\xC9\xEB\xEF\x85+\xAF\xBC2N?\xFD\xF4\xCF}\xF3\x9Bߌ \xFD\xE8G\xF1\xD8c\x8FŸq\xE3b\xEB֭U\xDF\xFF\xC3 \xFE0\x86 \xB7\xDF~\xFB[=\xD46\xB55\xFE\xB7B\xEB9\xB9\xE2\x8A+*\xFB}ꩧ\xE2\x98c\x8E\xA9\xFA\xB83\x9Ey\xE6\x998\xF2\xC8#\xE3S\x9F\xFA\xD4^ ?m\xBB\xF5\xD6[\xA3\xAE\xAE.\xEE\xBE\xFB\xEEN\xBF\xB7+뼯\xFD\x9Fg\xB7\xDEzk \xBAu\xEB\xF37\xB3\xAF\x87\xC0 \x83Ҏ3f\x947\xDF|\xB3\xF2\xB8O\x9F\xE5\x9CsΩ\x9E7o^\xB9馛\xDA\xDBLU
+
+
+\xE5\xFE\xFB\xEF\xDF\xE3\xF7\xBF\xDDlܸ\xB1\xFC\x{1B7FED}^\xBF~}\xE9ӧOijj*\xA5\x94\xF2\xE2\x8B/\xEE\xF6\x9E\xD6s0nܸr\xF5\xD5W\xBF\xF5\x83mC\xEB\xF1\xBFښ\x93\xD6\xFB\xFD\x97\xF9\x972t\xE8Ъ\x8F;\xE3\x82 .( \xFC\xE0\xBB6h:lذa\xE5\xEB_\xFF\xFA \xBD\xB7+뼯\xFD\x9Fgg\x9DuV\x89\x88\xF2\xD7\xFD\xD7\xFBz( \xFCh\xF7\x90O\xFA\xD31hР\xAA_\xFF\xF8\xC7? 'N\xECL\xF0T\xFEy۶mq\xC6g\xC4\xD3O?\xDD\xE9\xF7\xB6\xB6}\xFB\xF6N\xBF\xAF\xD6\xF6\xF6d \xFD\xFA\xF5\x8B\xA1C\x87V ?\xFF\xFC\xF3\xD1\xD8\xD8ݺu\x8B\x88\x88C=\xB4\xC5\xEBۚ\x83\x9E={V^\x9F\xAD\xF5\xF8\x9But\xAEj\xADC\xB3\xB6\xE6\xA4\xF5~[\xCF\xC1\x9E\xCCISSSDD\xF4\xE8\xD1#\xBAwo\xFFj\xC3=9 \xB2\xBCUc\xEB\xC8zuVW\xCE\xDF}u\xEEwe :{\x9E\xBD \xF5\xE8\xD1#b\x9F\xFD\xB9\xC0 \x97\x9E\xED\xBD\xE0\xFD\xEFͯ\xF7\xEA\xD5+\xDE\xF7\xBE\xF7E\xC4\xCEk\xFA\xBF\xF6\xB5\xAF\xC53\xCF\xF5\xF5\xF5\xF1\xAF\xFF\xFA\xAFq\xEC\xB1\xC7FD\xC4\xF7\xBF\xFF\xFDX\xB7n]lذ!\xEE\xB9\xE7\x9Ex\xEC\xB1\xC7\xE2\xFA믏E\x8BŪU\xAB\xE2\xD5W_\x8D뮻.\xF6\xDF\xFFʶ.\\xB7\xDCrK r\xC8!\xB1u\xEB֘3gN\xF4\xEA\xD5+\xBE\xFB\xDD\xEF\xC6ԩS#bѢE\xB1lٲ\xE8{\xDC{\xEF\xBDq\xE3\x8D7Ƅ \xAA\xEE\xB3\xD6\xF3\x9D k+W\xAE\x8C9s\xE6\xC4}\xF7\xDDK\x97.\x8D[n\xB9%\xEE\xBE\xFB\xEEرcG\x\xE1\x85ѷo߸\xE6\x9AkZ\xBC\xA7\xAD9\x88\xD8y=\xF9?\xFC\xC3?\xC4\xED\xB7\xDF \x88\xF9\xF3\xE7\xC7\xC1 \s\x9CO\xF9d|\xE7;߉\xA1C\x87\xC6~\xFB\xED\xDF\xFC\xE67c\xC1\x821r\xE4Ȫ\xC7Uk\xFC =\xEE\xF6\xD6aWm\xCDɅ^\xB8\xDB~\xDBSk\xAD\xE2\xD2K/\x8D#F\xC4\xEAի\xE3\xBF\xFE뿢o߾U\xB7\xB5q\xE3Ƙ={v 4(~\xFD\xEB_\xC7\xC0\x81c q\xDCq\xC7E\x9F}:=\xA7\xD5ƶx\xF1\xE2\xF8\xF6\xB7\xBF \xEFz\xE2\xD0C\x8Dk\xAE\xB9z\xF6\xEC?\xF9\xC9Ob\xF4\xE8\xD1m\x8E\xAD\xDA\xFCoڴ)\xAE\xB8\xE2\x8A6lX\xF9\xE4\x931hРX\xBF~}\xDCu\xD7]q\xF7\xDDw\xC7g\xF3\x99\xB8\xEC\xB2\xCB\xE2\x82 .\x88\xBB\xEE\xBA+\xFF\xF9\xCFǔ)S⦛n\xAA\xB9^]=\x87v\x9DӋ/\xBE8\xEE\xBC\xF3\xCE1bD̙3'Ə \xDF\xEEڵ\xB6~\xFD\xFA\xB8\xFC\xF2ˣ_\xBF~\xB1bŊ|x\s\xCD5\xB1\xFF\xFE\xFBǽ\xF7\xDE\xE7\x9Dw^\x9Cp\xC2
[webkit-changes] [99458] trunk
Title: [99458] trunk
Revision 99458
Author vse...@chromium.org
Date 2011-11-07 12:35:16 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: Suggest box should consume enter key pressed event.
https://bugs.webkit.org/show_bug.cgi?id=71700
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
LayoutTests:
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.evaluateInConsole):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/inspector-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/LayoutTests/ChangeLog (99457 => 99458)
--- trunk/LayoutTests/ChangeLog 2011-11-07 20:29:09 UTC (rev 99457)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 20:35:16 UTC (rev 99458)
@@ -1,3 +1,13 @@
+2011-11-07 vse...@chromium.org vse...@chromium.org
+
+Web Inspector: Suggest box should consume enter key pressed event.
+https://bugs.webkit.org/show_bug.cgi?id=71700
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/inspector-test.js:
+(initialize_InspectorTest.InspectorTest.evaluateInConsole):
+
2011-11-07 Robert Hogan rob...@webkit.org
[chromium] css2.1/20110323/block-non-replaced-width-008.htm fails on mac 10.5 CG
Modified: trunk/LayoutTests/http/tests/inspector/inspector-test.js (99457 => 99458)
--- trunk/LayoutTests/http/tests/inspector/inspector-test.js 2011-11-07 20:29:09 UTC (rev 99457)
+++ trunk/LayoutTests/http/tests/inspector/inspector-test.js 2011-11-07 20:35:16 UTC (rev 99458)
@@ -33,7 +33,7 @@
WebInspector.consoleView.prompt.text = code;
var event = document.createEvent(KeyboardEvent);
event.initKeyboardEvent(keydown, true, true, null, Enter, );
-WebInspector.consoleView.promptElement.dispatchEvent(event);
+WebInspector.consoleView.prompt.proxyElement.dispatchEvent(event);
InspectorTest.addConsoleSniffer(
function(commandResult) {
callback(commandResult.toMessageElement().textContent);
Modified: trunk/Source/WebCore/ChangeLog (99457 => 99458)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 20:29:09 UTC (rev 99457)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 20:35:16 UTC (rev 99458)
@@ -1,3 +1,16 @@
+2011-11-07 vse...@chromium.org vse...@chromium.org
+
+Web Inspector: Suggest box should consume enter key pressed event.
+https://bugs.webkit.org/show_bug.cgi?id=71700
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView):
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype._attachInternal):
+(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
+
2011-11-07 David Barr davidb...@chromium.org
Optimize outline rendering to avoid transparency layers
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (99457 => 99458)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-07 20:29:09 UTC (rev 99457)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-11-07 20:35:16 UTC (rev 99458)
@@ -61,7 +61,6 @@
this.promptElement.id = console-prompt;
this.promptElement.className = source-code;
this.promptElement.spellcheck = false;
-this.promptElement.addEventListener(keydown, this._promptKeyDown.bind(this), true);
this.messagesElement.appendChild(this.promptElement);
this.messagesElement.appendChild(document.createElement(br));
@@ -114,6 +113,7 @@
this.prompt = new WebInspector.TextPromptWithHistory(this.completions.bind(this), ExpressionStopCharacters + .);
this.prompt.setSuggestBoxEnabled(generic-suggest);
this.prompt.attach(this.promptElement);
+this.prompt.proxyElement.addEventListener(keydown, this._promptKeyDown.bind(this), false);
this.prompt.setHistoryData(WebInspector.settings.consoleHistory.get());
}
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99457 => 99458)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 20:29:09 UTC (rev 99457)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 20:35:16 UTC (rev 99458)
@@ -105,7 +105,7 @@
element.parentElement.insertBefore(this.proxyElement, element);
this.proxyElement.appendChild(element);
this._element.addStyleClass(text-prompt);
-this._element.addEventListener(keydown, this._boundOnKeyDown, true);
+this._element.addEventListener(keydown, this._boundOnKeyDown, false);
this._element.addEventListener(selectstart, this._selectStart.bind(this), false);
if (typeof this._suggestBoxClassName ===
[webkit-changes] [99459] trunk/Source/WebCore
Title: [99459] trunk/Source/WebCore
Revision 99459
Author vse...@chromium.org
Date 2011-11-07 12:37:06 -0800 (Mon, 07 Nov 2011)
Log Message
Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space.
https://bugs.webkit.org/show_bug.cgi?id=71710
Reviewed by Pavel Feldman.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99458 => 99459)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 20:35:16 UTC (rev 99458)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 20:37:06 UTC (rev 99459)
@@ -1,3 +1,14 @@
+2011-11-07 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space.
+https://bugs.webkit.org/show_bug.cgi?id=71710
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype.clearAutoComplete):
+(WebInspector.TextPrompt.prototype.autoCompleteSoon):
+
2011-11-07 vse...@chromium.org vse...@chromium.org
Web Inspector: Suggest box should consume enter key pressed event.
Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (99458 => 99459)
--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 20:35:16 UTC (rev 99458)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js 2011-11-07 20:37:06 UTC (rev 99459)
@@ -296,7 +296,7 @@
*/
clearAutoComplete: function(includeTimeout)
{
-if (includeTimeout _completeTimeout in this) {
+if (includeTimeout this._completeTimeout) {
clearTimeout(this._completeTimeout);
delete this._completeTimeout;
}
@@ -334,8 +334,9 @@
*/
autoCompleteSoon: function(force)
{
-if (!(_completeTimeout in this))
-this._completeTimeout = setTimeout(this.complete.bind(this, true, force), this.isSuggestBoxVisible() ? 0 : 250);
+var immediately = this.isSuggestBoxVisible() || force;
+if (!this._completeTimeout)
+this._completeTimeout = setTimeout(this.complete.bind(this, true, force), immediately ? 0 : 250);
},
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99460] trunk
Title: [99460] trunk
Revision 99460
Author timothy_hor...@apple.com
Date 2011-11-07 12:40:24 -0800 (Mon, 07 Nov 2011)
Log Message
getBBox() on a SVGPathElement with curves incorrectly includes control points
https://bugs.webkit.org/show_bug.cgi?id=53512
rdar://problem/9861154
Reviewed by Oliver Hunt.
Split Path::boundingRect() into two, adding Path::fastBoundingRect()
for a rough estimate of the bounding rect (always equal to or larger
than boundingRect()). fastBoundingRect() currently falls back to
boundingRect() for all ports besides CG, though in most cases
(on a port-by-port basis) the current implementation of boundingRect()
will need to become fastBoundingRect(), and a new, more accurate method will
be implemented for boundingRect().
All previous callers of boundingRect() are transitioned to using fastBoundingRect()
except SVGPathElement::getBBox, which wants an accurate bounding box.
The CoreGraphics implementation of Path::boundingRect() called
CGPathGetBoundingBox, which includes the path's control points in its
calculations. Snow Leopard added CGPathGetPathBoundingBox, which
finds the bounding box of only points within the path, and does not
include control points. On Snow Leopard and above, we now use the latter.
Test: svg/custom/getBBox-path.svg
* html/HTMLAreaElement.cpp:
* html/canvas/CanvasRenderingContext2D.cpp:
* platform/graphics/Path.cpp:
* platform/graphics/Path.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::boundingRect):
* rendering/RenderObject.h:
* rendering/svg/RenderSVGPath.cpp:
* svg/SVGPathElement.cpp:
* svg/SVGPathElement.h:
Add a test that ensures that getBBox does not include control points in the rect it returns.
* platform/chromium/test_expectations.txt:
* svg/custom/getBBox-path-expected.txt: Added.
* svg/custom/getBBox-path.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAreaElement.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
trunk/Source/WebCore/platform/graphics/Path.cpp
trunk/Source/WebCore/platform/graphics/Path.h
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp
trunk/Source/WebCore/svg/SVGPathElement.cpp
trunk/Source/WebCore/svg/SVGPathElement.h
Added Paths
trunk/LayoutTests/svg/custom/getBBox-path-expected.txt
trunk/LayoutTests/svg/custom/getBBox-path.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (99459 => 99460)
--- trunk/LayoutTests/ChangeLog 2011-11-07 20:37:06 UTC (rev 99459)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 20:40:24 UTC (rev 99460)
@@ -1,3 +1,17 @@
+2011-11-07 Tim Horton timothy_hor...@apple.com
+
+getBBox() on a SVGPathElement with curves incorrectly includes control points
+https://bugs.webkit.org/show_bug.cgi?id=53512
+rdar://problem/9861154
+
+Reviewed by Oliver Hunt.
+
+Add a test that ensures that getBBox does not include control points in the rect it returns.
+
+* platform/chromium/test_expectations.txt:
+* svg/custom/getBBox-path-expected.txt: Added.
+* svg/custom/getBBox-path.svg: Added.
+
2011-11-07 vse...@chromium.org vse...@chromium.org
Web Inspector: Suggest box should consume enter key pressed event.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99459 => 99460)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 20:37:06 UTC (rev 99459)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 20:40:24 UTC (rev 99460)
@@ -3899,3 +3899,6 @@
BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/set-parent-src-synchronously.html = PASS CRASH
BUGWK71658 MAC DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = PASS TIMEOUT
+
+// Introduced due to BUGWK53512, fails under Skia right now
+BUGWK65939 : svg/custom/getBBox-path.svg = TEXT
Added: trunk/LayoutTests/svg/custom/getBBox-path-expected.txt (0 => 99460)
--- trunk/LayoutTests/svg/custom/getBBox-path-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/getBBox-path-expected.txt 2011-11-07 20:40:24 UTC (rev 99460)
@@ -0,0 +1 @@
+100 37.5 PASS
Added: trunk/LayoutTests/svg/custom/getBBox-path.svg (0 => 99460)
--- trunk/LayoutTests/svg/custom/getBBox-path.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/getBBox-path.svg 2011-11-07 20:40:24 UTC (rev 99460)
@@ -0,0 +1,21 @@
+?xml version=1.0 encoding=UTF-8?
+svg xmlns=http://www.w3.org/2000/svg _onload_=init()
+ script type=text/_javascript_
+ ![CDATA[
+function init()
+{
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+var txt = document.getElementById(text);
+size =
[webkit-changes] [99461] trunk/Tools
Title: [99461] trunk/Tools Revision 99461 Author e...@webkit.org Date 2011-11-07 12:42:33 -0800 (Mon, 07 Nov 2011) Log Message new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=62199 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py Diff Modified: trunk/Tools/ChangeLog (99460 => 99461) --- trunk/Tools/ChangeLog 2011-11-07 20:40:24 UTC (rev 99460) +++ trunk/Tools/ChangeLog 2011-11-07 20:42:33 UTC (rev 99461) @@ -1,3 +1,14 @@ +2011-11-07 Eric Seidel e...@webkit.org + +new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests +https://bugs.webkit.org/show_bug.cgi?id=62199 + +Reviewed by Dirk Pranke. + +* Scripts/webkitpy/layout_tests/controllers/manager.py: +* Scripts/webkitpy/layout_tests/run_webkit_tests.py: +* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: + 2011-11-07 Fady Samuel fsam...@chromium.org [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (99460 => 99461) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-11-07 20:40:24 UTC (rev 99460) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-11-07 20:42:33 UTC (rev 99461) @@ -504,6 +504,16 @@ skipped = self._split_into_chunks_if_necessary(skipped) +# FIXME: It's unclear how --repeat-each and --iterations should interact with chunks? +if self._options.repeat_each: +list_with_repetitions = [] +for test in self._test_files_list: +list_with_repetitions += ([test] * self._options.repeat_each) +self._test_files_list = list_with_repetitions + +if self._options.iterations: +self._test_files_list = self._test_files_list * self._options.iterations + result_summary = ResultSummary(self._expectations, self._test_files | skipped) self._print_expected_results_of_type(result_summary, test_expectations.PASS, passes) self._print_expected_results_of_type(result_summary, test_expectations.FAIL, failures) Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (99460 => 99461) --- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2011-11-07 20:40:24 UTC (rev 99460) +++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2011-11-07 20:42:33 UTC (rev 99461) @@ -387,8 +387,8 @@ optparse.make_option(--exit-after-n-crashes-or-timeouts, type=int, default=20, help=Exit after the first N crashes instead of running all tests), -# FIXME: consider: --iterations n -# Number of times to run the set of tests (e.g. ABCABCABC) +optparse.make_option(--iterations, type=int, help=Number of times to run the set of tests (e.g. ABCABCABC)), +optparse.make_option(--repeat-each, type=int, help=Number of times to run each test (e.g. AAABBBCCC)), optparse.make_option(--retry-failures, action="" default=True, help=Re-try any tests that produce unexpected results (default)), Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (99460 => 99461) --- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2011-11-07 20:40:24 UTC (rev 99460) +++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2011-11-07 20:42:33 UTC (rev 99461) @@ -326,6 +326,16 @@ def test_threaded(self): self.assertTrue(passing_run(['--threaded'])) +def test_repeat_each(self): +tests_to_run = ['passes/image.html', 'passes/text.html'] +tests_run = get_tests_run(['--repeat-each', '2'] + tests_to_run, tests_included=True, flatten_batches=True) +self.assertEquals(tests_run, ['passes/image.html', 'passes/image.html', 'passes/text.html', 'passes/text.html']) + +def test_iterations(self): +tests_to_run = ['passes/image.html', 'passes/text.html'] +tests_run = get_tests_run(['--iterations', '2'] + tests_to_run, tests_included=True, flatten_batches=True) +self.assertEquals(tests_run, ['passes/image.html', 'passes/text.html', 'passes/image.html', 'passes/text.html']) + def test_run_chunk(self): # Test that we actually select the right chunk all_tests_run = get_tests_run(flatten_batches=True) ___
[webkit-changes] [99462] trunk
Title: [99462] trunk
Revision 99462
Author commit-qu...@webkit.org
Date 2011-11-07 12:48:35 -0800 (Mon, 07 Nov 2011)
Log Message
Crash due to mixed direction text runs
https://bugs.webkit.org/show_bug.cgi?id=66015
Patch by Ken Buchanan ke...@chromium.org on 2011-11-07
Reviewed by David Hyatt.
Source/WebCore:
Test for bug fix.
* fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html: Added
* fast/text/international/bidi-neutral-in-mixed-direction-run-cras-expected.txt: Added
LayoutTests:
In some cases extra bidi runs were being added because appendRun() was being called
after the last run of the line was already appended.
This converts a previous fix for this bug to an ASSERT, because the check is
unnecessary, though it is a symptom that text runs have somehow gotten messed up.
* rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun): Abort append if we've already appended the last
run of the line
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox): Revert the previous patch, change to an assert
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineIterator.h
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash-expected.txt
trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html
Property Changed
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/LayoutTests/ChangeLog (99461 => 99462)
--- trunk/LayoutTests/ChangeLog 2011-11-07 20:42:33 UTC (rev 99461)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 20:48:35 UTC (rev 99462)
@@ -1,3 +1,22 @@
+2011-11-07 Ken Buchanan ke...@chromium.org
+
+Crash due to mixed direction text runs
+https://bugs.webkit.org/show_bug.cgi?id=66015
+
+Reviewed by David Hyatt.
+
+In some cases extra bidi runs were being added because appendRun() was being called
+after the last run of the line was already appended.
+
+This converts a previous fix for this bug to an ASSERT, because the check is
+unnecessary, though it is a symptom that text runs have somehow gotten messed up.
+
+* rendering/InlineIterator.h:
+(WebCore::InlineBidiResolver::appendRun): Abort append if we've already appended the last
+run of the line
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::positionLineBox): Revert the previous patch, change to an assert
+
2011-11-07 Tim Horton timothy_hor...@apple.com
getBBox() on a SVGPathElement with curves incorrectly includes control points
Property changes on: trunk/LayoutTests/ChangeLog
___
Added: svn:executable
Added: trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash-expected.txt (0 => 99462)
--- trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash-expected.txt 2011-11-07 20:48:35 UTC (rev 99462)
@@ -0,0 +1 @@
+PASS, if no crash or exceptions thrown
Added: trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html (0 => 99462)
--- trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html (rev 0)
+++ trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html 2011-11-07 20:48:35 UTC (rev 99462)
@@ -0,0 +1,25 @@
+html
+style
+body { direction: rtl; padding-left: 100%; }
+/style
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function runTest() {
+document.body.innerHTML = PASS, if no crash or exceptions thrown;
+
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+setTimeout(runTest(), 0);
+/script
+0span
+image
+A 0div/div
+/span
+/html
+
Property changes on: trunk/LayoutTests/fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html
___
Added: svn:executable
Modified: trunk/Source/WebCore/ChangeLog (99461 => 99462)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 20:42:33 UTC (rev 99461)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 20:48:35 UTC (rev 99462)
@@ -1,3 +1,15 @@
+2011-11-07 Ken Buchanan ke...@chromium.org
+
+Crash due to mixed direction text runs
+https://bugs.webkit.org/show_bug.cgi?id=66015
+
+Reviewed by David Hyatt.
+
+Test for bug fix.
+
+* fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html: Added
+* fast/text/international/bidi-neutral-in-mixed-direction-run-cras-expected.txt: Added
+
[webkit-changes] [99463] trunk/Source/WebCore
Title: [99463] trunk/Source/WebCore
Revision 99463
Author hara...@chromium.org
Date 2011-11-07 12:50:13 -0800 (Mon, 07 Nov 2011)
Log Message
Refactor CodeGeneratorV8.pm before making a core change for bug 71093.
https://bugs.webkit.org/show_bug.cgi?id=71659
Reviewed by Adam Barth.
Just refactor CodeGeneratorV8.pm without any change in behavior,
as the first step for fixing bug 71093.
Tests: WebCore/bindings/scripts/test/TestObj.idl
WebCore/bindings/scripts/test/TestInterface.idl
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader): Sort generated headers in alphabetical order. Removed unnecessary variable names from method signatures. These changes are for silencing style check errors when a new Test.idl is added.
(GenerateConstructorCallback): Renamed variables to clarify their roles.
(WriteData): Removed an unused array @implHeaderContent.
* bindings/scripts/test/V8/V8TestInterface.h: Updated a run-binding-tests result.
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
* bindings/scripts/test/V8/V8TestObj.h: Ditto.
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99462 => 99463)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 20:48:35 UTC (rev 99462)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 20:50:13 UTC (rev 99463)
@@ -1,3 +1,25 @@
+2011-11-07 Kentaro Hara hara...@chromium.org
+
+Refactor CodeGeneratorV8.pm before making a core change for bug 71093.
+https://bugs.webkit.org/show_bug.cgi?id=71659
+
+Reviewed by Adam Barth.
+
+Just refactor CodeGeneratorV8.pm without any change in behavior,
+as the first step for fixing bug 71093.
+
+Tests: WebCore/bindings/scripts/test/TestObj.idl
+ WebCore/bindings/scripts/test/TestInterface.idl
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateHeader): Sort generated headers in alphabetical order. Removed unnecessary variable names from method signatures. These changes are for silencing style check errors when a new Test.idl is added.
+(GenerateConstructorCallback): Renamed variables to clarify their roles.
+(WriteData): Removed an unused array @implHeaderContent.
+* bindings/scripts/test/V8/V8TestInterface.h: Updated a run-binding-tests result.
+* bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
+* bindings/scripts/test/V8/V8TestObj.h: Ditto.
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
+
2011-11-07 Ken Buchanan ke...@chromium.org
Crash due to mixed direction text runs
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (99462 => 99463)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-07 20:48:35 UTC (rev 99462)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-07 20:50:13 UTC (rev 99463)
@@ -39,7 +39,6 @@
my @headerContent = ();
my @implContentHeader = ();
my @implFixedHeader = ();
-my @implHeaderContent = ();
my @implContent = ();
my @implContentDecls = ();
my %implIncludes = ();
@@ -283,6 +282,8 @@
$headerIncludes{wtf/text/StringHash.h} = 1;
$headerIncludes{WrapperTypeInfo.h} = 1;
$headerIncludes{V8DOMWrapper.h} = 1;
+$headerIncludes{wtf/HashMap.h} = 1;
+$headerIncludes{v8.h} = 1;
my $headerClassInclude = GetHeaderClassInclude($implClassName);
$headerIncludes{$headerClassInclude} = 1 if $headerClassInclude ne ;
@@ -290,16 +291,13 @@
my ($svgPropertyType, $svgListPropertyType, $svgNativeType) = GetSVGPropertyTypes($implClassName);
foreach my $headerInclude (sort keys(%headerIncludes)) {
-if ($headerInclude =~ /wtf/) {
+if ($headerInclude =~ /wtf|v8\.h/) {
push(@headerContent, #include \${headerInclude}\\n);
} else {
push(@headerContent, #include \${headerInclude}\\n);
}
}
-push(@headerContent, #include v8.h\n);
-push(@headerContent, #include wtf/HashMap.h\n);
-
push(@headerContent, \nnamespace WebCore {\n);
push(@headerContent, \ntemplatetypename PropertyType class SVGPropertyTearOff;\n) if $svgPropertyType;
if ($svgNativeType) {
@@ -339,7 +337,7 @@
my $forceNewObjectCall = IsDOMNodeType($interfaceName) ? , forceNewObject : ;
push(@headerContent, END);
-static bool HasInstance(v8::Handlev8::Value value);
+static bool HasInstance(v8::Handlev8::Value);
static v8::Persistentv8::FunctionTemplate GetRawTemplate();
static
[webkit-changes] [99469] trunk/Tools
Title: [99469] trunk/Tools
Revision 99469
Author commit-qu...@webkit.org
Date 2011-11-07 13:20:10 -0800 (Mon, 07 Nov 2011)
Log Message
[NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
https://bugs.webkit.org/show_bug.cgi?id=70912
Patch by Balazs Ankes ankes.bal...@stud.u-szeged.hu on 2011-11-07
Reviewed by Ojan Vafai.
* Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (99468 => 99469)
--- trunk/Tools/ChangeLog 2011-11-07 21:19:45 UTC (rev 99468)
+++ trunk/Tools/ChangeLog 2011-11-07 21:20:10 UTC (rev 99469)
@@ -1,3 +1,13 @@
+2011-11-07 Balazs Ankes ankes.bal...@stud.u-szeged.hu
+
+[NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
+https://bugs.webkit.org/show_bug.cgi?id=70912
+
+Reviewed by Ojan Vafai.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
+
2011-11-07 Eric Seidel e...@webkit.org
new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (99468 => 99469)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-11-07 21:19:45 UTC (rev 99468)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-11-07 21:20:10 UTC (rev 99469)
@@ -356,7 +356,7 @@
expectations_path = self.path_to_test_expectations_file()
if self._filesystem.exists(expectations_path):
_log.debug(Using test_expectations.txt: %s % expectations_path)
-expectations = self._filesystem.read_text_file(expectations_path) + expectations
+expectations = self._filesystem.read_text_file(expectations_path) + '\n' + expectations
return expectations
def _skipped_list_as_expectations(self):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (99468 => 99469)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-11-07 21:19:45 UTC (rev 99468)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-11-07 21:20:10 UTC (rev 99469)
@@ -163,10 +163,21 @@
mock_fs = MockFileSystem(files)
port = TestWebKitPort(filesystem=mock_fs)
self.assertEqual(port.test_expectations(),
+BUG_TESTEXPECTATIONS SKIP : fast/html/article-element.html = FAIL\n
+BUG_SKIPPED SKIP : fast/html/keygen.html = FAIL
+BUG_SKIPPED SKIP : media = FAIL)
+files = {
+'/mock-checkout/LayoutTests/platform/testwebkitport/test_expectations.txt': 'BUG_TESTEXPECTATIONS SKIP : fast/html/article-element.html = FAIL',
+'/mock-checkout/LayoutTests/platform/testwebkitport/Skipped': 'fast/html/keygen.html',
+}
+mock_fs = MockFileSystem(files)
+port = TestWebKitPort(filesystem=mock_fs)
+self.assertEqual(port.test_expectations(),
BUG_TESTEXPECTATIONS SKIP : fast/html/article-element.html = FAIL
BUG_SKIPPED SKIP : fast/html/keygen.html = FAIL
BUG_SKIPPED SKIP : media = FAIL)
+
def test_build_driver(self):
output = OutputCapture()
port = TestWebKitPort()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99478] trunk/Tools
Title: [99478] trunk/Tools
Revision 99478
Author t...@chromium.org
Date 2011-11-07 14:31:30 -0800 (Mon, 07 Nov 2011)
Log Message
[chromium] update flakiness dashboard to reflect current bots
Reviewed by Ojan Vafai.
* TestResultServer/static-dashboards/builders.js: Remove (deps) debug
bots and merged linux debug bots into a single bot.
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(setupExpectationsTest):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/builders.js
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js
Diff
Modified: trunk/Tools/ChangeLog (99477 => 99478)
--- trunk/Tools/ChangeLog 2011-11-07 22:20:20 UTC (rev 99477)
+++ trunk/Tools/ChangeLog 2011-11-07 22:31:30 UTC (rev 99478)
@@ -1,3 +1,14 @@
+2011-11-07 Tony Chang t...@chromium.org
+
+[chromium] update flakiness dashboard to reflect current bots
+
+Reviewed by Ojan Vafai.
+
+* TestResultServer/static-dashboards/builders.js: Remove (deps) debug
+bots and merged linux debug bots into a single bot.
+* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
+(setupExpectationsTest):
+
2011-11-07 Dana Jansens dan...@chromium.org
Add cc-bugs group to watch changes in chromium graphics
Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (99477 => 99478)
--- trunk/Tools/TestResultServer/static-dashboards/builders.js 2011-11-07 22:20:20 UTC (rev 99477)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js 2011-11-07 22:31:30 UTC (rev 99478)
@@ -91,17 +91,9 @@
var CHROMIUM_DEPS_BUILDERS = [
['Webkit Win (deps)', BuilderGroup.DEFAULT_BUILDER],
-['Webkit Win (deps)(dbg)(1)'],
-['Webkit Win (deps)(dbg)(2)'],
['Webkit Linux (deps)', BuilderGroup.EXPECTATIONS_BUILDER],
-['Webkit Linux (deps)(dbg)(1)'],
-['Webkit Linux (deps)(dbg)(2)'],
['Webkit Mac10.6 (deps)'],
-['Webkit Mac10.6 (deps)(dbg)(1)'],
-['Webkit Mac10.6 (deps)(dbg)(2)'],
['Webkit Mac10.6 (CG)(deps)'],
-['Webkit Mac10.6 (CG)(deps)(dbg)(1)'],
-['Webkit Mac10.6 (CG)(deps)(dbg)(2)']
];
associateBuildersWithMaster(CHROMIUM_DEPS_BUILDERS, CHROMIUM_WEBKIT_BUILDER_MASTER);
@@ -113,8 +105,7 @@
['Webkit Win (dbg)(2)'],
['Webkit Linux', BuilderGroup.EXPECTATIONS_BUILDER],
['Webkit Linux 32'],
-['Webkit Linux (dbg)(1)'],
-['Webkit Linux (dbg)(2)'],
+['Webkit Linux (dbg)'],
['Webkit Mac10.5'],
['Webkit Mac10.5 (dbg)(1)'],
['Webkit Mac10.5 (dbg)(2)'],
@@ -150,18 +141,17 @@
['Webkit Win (dbg)(2) - GPU'],
['Webkit Linux - GPU', BuilderGroup.EXPECTATIONS_BUILDER],
['Webkit Linux 32 - GPU'],
-['Webkit Linux (dbg)(1) - GPU'],
-['Webkit Linux (dbg)(2) - GPU'],
-['Webkit Mac10.5 (CG) - GPU'],
-['Webkit Mac10.5 (CG)(dbg)(1) - GPU'],
-['Webkit Mac10.5 (CG)(dbg)(2) - GPU'],
-['Webkit Mac10.6 (CG) - GPU'],
-['Webkit Mac10.6 (CG)(dbg) - GPU'],
+['Webkit Linux (dbg) - GPU'],
['Webkit Mac10.5 - GPU'],
['Webkit Mac10.5 (dbg)(1) - GPU'],
['Webkit Mac10.5 (dbg)(2) - GPU'],
['Webkit Mac10.6 - GPU'],
-['Webkit Mac10.6 (dbg) - GPU']
+['Webkit Mac10.6 (dbg) - GPU'],
+['Webkit Mac10.5 (CG) - GPU'],
+['Webkit Mac10.5 (CG)(dbg)(1) - GPU'],
+['Webkit Mac10.5 (CG)(dbg)(2) - GPU'],
+['Webkit Mac10.6 (CG) - GPU'],
+['Webkit Mac10.6 (CG)(dbg) - GPU']
];
associateBuildersWithMaster(CHROMIUM_GPU_MESA_BUILDERS, CHROMIUM_WEBKIT_BUILDER_MASTER);
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js (99477 => 99478)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js 2011-11-07 22:20:20 UTC (rev 99477)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js 2011-11-07 22:31:30 UTC (rev 99478)
@@ -49,6 +49,10 @@
g_builders = {};
g_allExpectations = null;
g_allTests = null;
+g_currentState = {};
+for (var key in g_defaultCrossDashboardStateValues) {
+g_currentState[key] = g_defaultCrossDashboardStateValues[key];
+}
}
// Processes the expectations for a test and asserts that the final expectations
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99479] trunk/LayoutTests
Title: [99479] trunk/LayoutTests Revision 99479 Author t...@chromium.org Date 2011-11-07 14:35:13 -0800 (Mon, 07 Nov 2011) Log Message Layout Test fast/events/platform-wheelevent-paging-x-in-scrolling-page.html is failing https://bugs.webkit.org/show_bug.cgi?id=71606 Patch by Stephen Chenney schen...@chromium.org on 2011-11-07 Reviewed by Tony Chang. * platform/chromium/test_expectations.txt: Remove the expected failure. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (99478 => 99479) --- trunk/LayoutTests/ChangeLog 2011-11-07 22:31:30 UTC (rev 99478) +++ trunk/LayoutTests/ChangeLog 2011-11-07 22:35:13 UTC (rev 99479) @@ -1,3 +1,12 @@ +2011-11-07 Stephen Chenney schen...@chromium.org + +Layout Test fast/events/platform-wheelevent-paging-x-in-scrolling-page.html is failing +https://bugs.webkit.org/show_bug.cgi?id=71606 + +Reviewed by Tony Chang. + +* platform/chromium/test_expectations.txt: Remove the expected failure. + 2011-11-07 Dominic Cooney domin...@chromium.org Remove initPopStateEvent method Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99478 => 99479) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 22:31:30 UTC (rev 99478) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 22:35:13 UTC (rev 99479) @@ -3884,10 +3884,6 @@ BUGWK71543 : media/media-element-play-after-eos.html = PASS TIMEOUT -BUGWK71606 MAC CPU-CG : fast/events/platform-wheelevent-paging-x-in-scrolling-page.html = TEXT -BUGWK71606 MAC CPU-CG : fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html = TEXT -BUGWK71606 MAC CPU-CG : fast/events/platform-wheelevent-paging-y-in-scrolling-page.html = TEXT - BUGWK71653 : platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html = PASS TIMEOUT // Intermittent assertion failures on snowleopard bots. Added: trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt (0 => 99479) --- trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt 2011-11-07 22:35:13 UTC (rev 99479) @@ -0,0 +1,6 @@ +PASS event.wheelDeltaY is 0 +PASS event.wheelDeltaX is window.givenScrollLeft * -3 +PASS event.wheelDelta is window.givenScrollLeft * -3 +PASS document.body.scrollTop is window.expectedScrollTop +FAIL document.body.scrollLeft should be 700. Was 760. + Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt ___ Added: svn:eol-style Added: trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt (0 => 99479) --- trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt 2011-11-07 22:35:13 UTC (rev 99479) @@ -0,0 +1,6 @@ +PASS event.wheelDeltaY is window.givenScrollTop * -3 +PASS event.wheelDeltaX is window.givenScrollLeft * -3 +PASS event.wheelDelta is window.givenScrollTop * -3 +FAIL document.body.scrollTop should be 511. Was 545. +FAIL document.body.scrollLeft should be 686. Was 745. + Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt ___ Added: svn:eol-style Added: trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt (0 => 99479) --- trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-cg-mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt 2011-11-07 22:35:13 UTC (rev 99479) @@ -0,0 +1,6 @@ +PASS event.wheelDeltaY is window.givenScrollTop * -3 +PASS event.wheelDeltaX is 0 +PASS event.wheelDelta is window.givenScrollTop * -3 +FAIL document.body.scrollTop should be 525. Was 560. +PASS document.body.scrollLeft is window.expectedScrollLeft + Property
[webkit-changes] [99480] trunk/Source/WebKit/efl
Title: [99480] trunk/Source/WebKit/efl Revision 99480 Author commit-qu...@webkit.org Date 2011-11-07 14:38:32 -0800 (Mon, 07 Nov 2011) Log Message [EFL] Emit the frame,created signal earlier. https://bugs.webkit.org/show_bug.cgi?id=71696 Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-11-07 Reviewed by Kenneth Rohde Christiansen. FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were emitting the frame,created signal after that, applications would connect to it after some other frame signals had already been emitted. Should help tests such as http/tests/loading/empty-subframe.html pass. * ewk/ewk_frame.cpp: (ewk_frame_child_add): * ewk/ewk_view.cpp: (ewk_view_frame_create): Modified Paths trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/ewk/ewk_frame.cpp trunk/Source/WebKit/efl/ewk/ewk_view.cpp Diff Modified: trunk/Source/WebKit/efl/ChangeLog (99479 => 99480) --- trunk/Source/WebKit/efl/ChangeLog 2011-11-07 22:35:13 UTC (rev 99479) +++ trunk/Source/WebKit/efl/ChangeLog 2011-11-07 22:38:32 UTC (rev 99480) @@ -1,3 +1,21 @@ +2011-11-07 Raphael Kubo da Costa k...@profusion.mobi + +[EFL] Emit the frame,created signal earlier. +https://bugs.webkit.org/show_bug.cgi?id=71696 + +Reviewed by Kenneth Rohde Christiansen. + +FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call +FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were +emitting the frame,created signal after that, applications would connect to +it after some other frame signals had already been emitted. Should help tests +such as http/tests/loading/empty-subframe.html pass. + +* ewk/ewk_frame.cpp: +(ewk_frame_child_add): +* ewk/ewk_view.cpp: +(ewk_view_frame_create): + 2011-11-04 Raphael Kubo da Costa k...@profusion.mobi [EFL] DRT: Fix the order of the items in the dumped history list. Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (99479 => 99480) --- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-11-07 22:35:13 UTC (rev 99479) +++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-11-07 22:38:32 UTC (rev 99480) @@ -1151,6 +1151,7 @@ return true; } +evas_object_smart_callback_call(smartData-view, frame,created, frame); smartData-frame-loader()-loadURLIntoChildFrame(url, referrer, coreFrame); // The frame's onload handler may have removed it from the document. @@ -1160,7 +1161,6 @@ return true; } -// TODO: announce frame was created? return true; } Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (99479 => 99480) --- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-11-07 22:35:13 UTC (rev 99479) +++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-11-07 22:38:32 UTC (rev 99480) @@ -3393,7 +3393,6 @@ smartData-changed.frame_rect = true; _ewk_view_smart_changed(smartData); -evas_object_smart_callback_call(ewkView, frame,created, frame); return coreFrame.release(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99481] trunk/Source/WebCore
Title: [99481] trunk/Source/WebCore
Revision 99481
Author hara...@chromium.org
Date 2011-11-07 14:39:41 -0800 (Mon, 07 Nov 2011)
Log Message
Remove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8
https://bugs.webkit.org/show_bug.cgi?id=71660
Reviewed by Adam Barth.
Currently, new Audio() uses a custom getter to get the template
of 'HTMLAudioElementConstructor'. However, this getter does not need to
be custom and can use a default getter 'DOMWindowInternal::DOMWindowConstructorGetter'.
Tests: fast/js/custom-constructors.html
media/audio-constructor.html
media/audio-constructor-src.html
media/audio-constructor-preload.html
media/audio-controls-do-not-fade-out.html
media/audio-controls-rendering.html
* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
* page/DOMWindow.idl: Removed [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8. Renamed 'HTMLAudioElementConstructor' to 'HTMLAudioElementConstructorConstructor' in order to make 'new Audio()' use the template of (not 'HTMLAudioElement' but) 'HTMLAudioElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from an IDL type.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): If an IDL type is 'ConstructorConstructor', then we do not add a header file 'Constructor.h' to JSDOMWindow.cpp, because the NamedConstructor declaration is written in the header file of class '.h'. Incidentally, the reason why CodeGeneratorV8.pm does not need a corresponding change is that V8 is still generating the NamedConstructor declaration in its dedicated header file 'Constructor.h'. This V8 issue will be fixed in the upcoming patch that implements [NamedConstructor] IDL in V8.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (99480 => 99481)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 22:38:32 UTC (rev 99480)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 22:39:41 UTC (rev 99481)
@@ -1,3 +1,26 @@
+2011-11-07 Kentaro Hara hara...@chromium.org
+
+Remove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8
+https://bugs.webkit.org/show_bug.cgi?id=71660
+
+Reviewed by Adam Barth.
+
+Currently, new Audio() uses a custom getter to get the template
+of 'HTMLAudioElementConstructor'. However, this getter does not need to
+be custom and can use a default getter 'DOMWindowInternal::DOMWindowConstructorGetter'.
+
+Tests: fast/js/custom-constructors.html
+ media/audio-constructor.html
+ media/audio-constructor-src.html
+ media/audio-constructor-preload.html
+ media/audio-controls-do-not-fade-out.html
+ media/audio-controls-rendering.html
+
+* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
+* page/DOMWindow.idl: Removed [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8. Renamed 'HTMLAudioElementConstructor' to 'HTMLAudioElementConstructorConstructor' in order to make 'new Audio()' use the template of (not 'HTMLAudioElement' but) 'HTMLAudioElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from an IDL type.
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation): If an IDL type is 'ConstructorConstructor', then we do not add a header file 'Constructor.h' to JSDOMWindow.cpp, because the NamedConstructor declaration is written in the header file of class '.h'. Incidentally, the reason why CodeGeneratorV8.pm does not need a corresponding change is that V8 is still generating the NamedConstructor declaration in its dedicated header file 'Constructor.h'. This V8 issue will be fixed in the upcoming patch that implements [NamedConstructor] IDL in V8.
+
2011-11-07 Robert Sesek rse...@chromium.org
[chromium] Update WebCore.gyp to not use WebKitLibraries in include_dirs
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (99480 => 99481)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-07 22:38:32 UTC (rev 99480)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-07 22:39:41 UTC (rev 99481)
@@ -1817,7 +1817,10 @@
} elsif ($attribute-signature-type =~ /Constructor$/) {
my $constructorType = $attribute-signature-type;
$constructorType =~ s/Constructor$//;
-if ($constructorType ne DOMObject) {
+# $constructorType ~= /Constructor$/ indicates that it is NamedConstructor.
+# We do not generate the header file for NamedConstructor of class ,
+# since we generate
[webkit-changes] [99483] trunk/Source/WebKit2
Title: [99483] trunk/Source/WebKit2 Revision 99483 Author a...@apple.com Date 2011-11-07 14:51:59 -0800 (Mon, 07 Nov 2011) Log Message The Full Keyboard Access preference should be read in the UI process https://bugs.webkit.org/show_bug.cgi?id=71734 rdar://problem/9237619 Reviewed by Darin Adler. This is consistent with how other global preferences (like language) are handled, and lets us tighten up the sandbox a little. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: Added fullKeyboardAccessEnabled, so that newly started processes have the right preference value. * UIProcess/WebContext.h: * UIProcess/WebContext.cpp: (WebKit::WebContext::fullKeyboardAccessModeChanged): If preference changes while a web process is already running, tell it. (WebKit::WebContext::ensureWebProcess): Set parameters.fullKeyboardAccessEnabled from current preference. * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled): * UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::fullKeyboardAccessEnabled): * UIProcess/WebProcessProxy.h: Proxy it to Objective-C code. WebProcessProxy is as good place to have the static function as any. One day, we will make code more consistent with language and other global preferences. * UIProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.h. * UIProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.mm. * WebProcess/mac/WKFullKeyboardAccessWatcher.h: Removed. * WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Removed. (-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]): Once retrieved, push the preference value. * WebKit2.xcodeproj/project.pbxproj: WKFullKeyboardAccessWatcher is now in UI process. * WebProcess/WebProcess.h: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::fullKeyboardAccessModeChanged): (WebKit::WebProcess::fullKeyboardAccessEnabled): * WebProcess/mac/WebProcessMac.mm: WebCprocess now holds the preference value in a mamber value, which UI process pushes updates to. * WebProcess/WebProcess.messages.in: Added a message for changes preference value. * WebProcess/com.apple.WebProcess.sb: We no longer need read access to com.apple.universalaccess.plist. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h trunk/Source/WebKit2/UIProcess/WebContext.cpp trunk/Source/WebKit2/UIProcess/WebContext.h trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp trunk/Source/WebKit2/UIProcess/WebProcessProxy.h trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/WebProcess/WebProcess.cpp trunk/Source/WebKit2/WebProcess/WebProcess.h trunk/Source/WebKit2/WebProcess/WebProcess.messages.in trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb trunk/Source/WebKit2/WebProcess/mac/WebProcessMac.mm Added Paths trunk/Source/WebKit2/UIProcess/mac/WKFullKeyboardAccessWatcher.h trunk/Source/WebKit2/UIProcess/mac/WKFullKeyboardAccessWatcher.mm Removed Paths trunk/Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.h trunk/Source/WebKit2/WebProcess/mac/WKFullKeyboardAccessWatcher.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (99482 => 99483) --- trunk/Source/WebKit2/ChangeLog 2011-11-07 22:46:35 UTC (rev 99482) +++ trunk/Source/WebKit2/ChangeLog 2011-11-07 22:51:59 UTC (rev 99483) @@ -1,3 +1,55 @@ +2011-11-07 Alexey Proskuryakov a...@apple.com + +The Full Keyboard Access preference should be read in the UI process +https://bugs.webkit.org/show_bug.cgi?id=71734 +rdar://problem/9237619 + +Reviewed by Darin Adler. + +This is consistent with how other global preferences (like language) are handled, and lets +us tighten up the sandbox a little. + +* Shared/WebProcessCreationParameters.cpp: +(WebKit::WebProcessCreationParameters::encode): +(WebKit::WebProcessCreationParameters::decode): +* Shared/WebProcessCreationParameters.h: +Added fullKeyboardAccessEnabled, so that newly started processes have the right preference value. + +* UIProcess/WebContext.h: +* UIProcess/WebContext.cpp: +(WebKit::WebContext::fullKeyboardAccessModeChanged): If preference changes while a web process +is already running, tell it. +
[webkit-changes] [99484] trunk/Source/WebCore
Title: [99484] trunk/Source/WebCore Revision 99484 Author commit-qu...@webkit.org Date 2011-11-07 14:55:30 -0800 (Mon, 07 Nov 2011) Log Message [MutationObservers] Fix mac build (with mutation_observers enabled) https://bugs.webkit.org/show_bug.cgi?id=71728 Patch by Rafael Weinstein rafa...@chromium.org on 2011-11-07 Reviewed by Tony Chang. Errant forward declaration of MutationObserverRegistration removed from Node.h this would have broken a port that tried to build with mutation_observers=1. * dom/Node.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Node.h Diff Modified: trunk/Source/WebCore/ChangeLog (99483 => 99484) --- trunk/Source/WebCore/ChangeLog 2011-11-07 22:51:59 UTC (rev 99483) +++ trunk/Source/WebCore/ChangeLog 2011-11-07 22:55:30 UTC (rev 99484) @@ -1,3 +1,15 @@ +2011-11-07 Rafael Weinstein rafa...@chromium.org + +[MutationObservers] Fix mac build (with mutation_observers enabled) +https://bugs.webkit.org/show_bug.cgi?id=71728 + +Reviewed by Tony Chang. + +Errant forward declaration of MutationObserverRegistration removed from +Node.h this would have broken a port that tried to build with mutation_observers=1. + +* dom/Node.h: + 2011-11-07 Kentaro Hara hara...@chromium.org Remove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8 Modified: trunk/Source/WebCore/dom/Node.h (99483 => 99484) --- trunk/Source/WebCore/dom/Node.h 2011-11-07 22:51:59 UTC (rev 99483) +++ trunk/Source/WebCore/dom/Node.h 2011-11-07 22:55:30 UTC (rev 99484) @@ -82,8 +82,6 @@ class TagNodeList; class TreeScope; -struct MutationObserverRegistration; - typedef int ExceptionCode; const int nodeStyleChangeShift = 25; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99485] trunk
Title: [99485] trunk
Revision 99485
Author vange...@chromium.org
Date 2011-11-07 15:03:05 -0800 (Mon, 07 Nov 2011)
Log Message
Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames
that forceCompositingMode can be used without turning frames into composited layers.
https://bugs.webkit.org/show_bug.cgi?id=71714
Reviewed by James Robinson.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled):
(WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
* testing/Internals.cpp:
(WebCore::Internals::setEnableCompositingForScrollableFrames):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from
forceCompositingMode.
https://bugs.webkit.org/show_bug.cgi?id=71714
Adjust the force-compositing-mode layout tests to explicitly set the new flag.
Reviewed by James Robinson.
* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html
trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html
trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html
trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html
trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html
trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (99484 => 99485)
--- trunk/LayoutTests/ChangeLog 2011-11-07 22:55:30 UTC (rev 99484)
+++ trunk/LayoutTests/ChangeLog 2011-11-07 23:03:05 UTC (rev 99485)
@@ -1,3 +1,20 @@
+2011-11-07 Vangelis Kokkevis vange...@chromium.org
+
+[chromium] Make compositing for scrollable [i]frames a setting separate from
+forceCompositingMode.
+https://bugs.webkit.org/show_bug.cgi?id=71714
+
+Adjust the force-compositing-mode layout tests to explicitly set the new flag.
+
+Reviewed by James Robinson.
+
+* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
+* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
+* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
+* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
+* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
+* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
+
2011-11-07 Tony Chang t...@chromium.org
Update chromium test_expectations.txt.
Modified: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html (99484 => 99485)
--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html 2011-11-07 22:55:30 UTC (rev 99484)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html 2011-11-07 23:03:05 UTC (rev 99485)
@@ -1,8 +1,10 @@
html
head
script
- if (window.internals)
+ if (window.internals) {
window.internals.setForceCompositingMode(document, true);
+window.internals.setEnableCompositingForScrollableFrames(document, true);
+ }
function doTest() {
if (window.layoutTestController) {
document.getElementById(layertree).innerText = layoutTestController.layerTreeAsText();
Modified: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html (99484 => 99485)
--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html 2011-11-07 22:55:30 UTC (rev 99484)
+++
[webkit-changes] [99486] trunk/Source/JavaScriptCore
Title: [99486] trunk/Source/_javascript_Core
Revision 99486
Author fpi...@apple.com
Date 2011-11-07 15:08:54 -0800 (Mon, 07 Nov 2011)
Log Message
Switch the value profiler back to 8 buckets, because we suspect that while this
is more expensive it's also more stable.
Rubber stamped by Geoff Garen.
* bytecode/ValueProfile.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/ValueProfile.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99485 => 99486)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-07 23:03:05 UTC (rev 99485)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-07 23:08:54 UTC (rev 99486)
@@ -1,3 +1,12 @@
+2011-11-07 Filip Pizlo fpi...@apple.com
+
+Switch the value profiler back to 8 buckets, because we suspect that while this
+is more expensive it's also more stable.
+
+Rubber stamped by Geoff Garen.
+
+* bytecode/ValueProfile.h:
+
2011-11-07 Andrew Wason rectalo...@rectalogic.com
Uninitialized Heap member var
Modified: trunk/Source/_javascript_Core/bytecode/ValueProfile.h (99485 => 99486)
--- trunk/Source/_javascript_Core/bytecode/ValueProfile.h 2011-11-07 23:03:05 UTC (rev 99485)
+++ trunk/Source/_javascript_Core/bytecode/ValueProfile.h 2011-11-07 23:08:54 UTC (rev 99486)
@@ -38,7 +38,7 @@
#if ENABLE(VALUE_PROFILER)
struct ValueProfile {
-static const unsigned logNumberOfBuckets = 0; // 1 bucket
+static const unsigned logNumberOfBuckets = 3; // 8 buckets
static const unsigned numberOfBuckets = 1 logNumberOfBuckets;
static const unsigned numberOfSpecFailBuckets = 1;
static const unsigned bucketIndexMask = numberOfBuckets - 1;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99487] trunk/LayoutTests
Title: [99487] trunk/LayoutTests Revision 99487 Author t...@chromium.org Date 2011-11-07 15:16:47 -0800 (Mon, 07 Nov 2011) Log Message [chromium] disable 2 tests that are slow in debug * platform/chromium/test_expectations.txt: only run fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html in release builds Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99486 => 99487) --- trunk/LayoutTests/ChangeLog 2011-11-07 23:08:54 UTC (rev 99486) +++ trunk/LayoutTests/ChangeLog 2011-11-07 23:16:47 UTC (rev 99487) @@ -1,3 +1,11 @@ +2011-11-07 Tony Chang t...@chromium.org + +[chromium] disable 2 tests that are slow in debug + +* platform/chromium/test_expectations.txt: only run +fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html +in release builds + 2011-11-07 Vangelis Kokkevis vange...@chromium.org [chromium] Make compositing for scrollable [i]frames a setting separate from Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99486 => 99487) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 23:08:54 UTC (rev 99486) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 23:16:47 UTC (rev 99487) @@ -2088,10 +2088,11 @@ // HTML5 Geolocation API does not use window.clientInformation. BUGCR11246 SKIP : fast/dom/Window/window-properties-geolocation.html = TEXT -BUGCR46603 SLOW RELEASE : fast/frames/lots-of-iframes.html = PASS TEXT -BUGCR46603 SLOW RELEASE : fast/frames/lots-of-objects.html = PASS TEXT -BUGCR46603 DEBUG : fast/frames/lots-of-iframes.html = TIMEOUT -BUGCR46603 DEBUG : fast/frames/lots-of-objects.html = TIMEOUT +BUGCR46603 SLOW RELEASE : fast/frames/lots-of-iframes.html = PASS +BUGCR46603 SLOW RELEASE : fast/frames/lots-of-objects.html = PASS +// These tests are really slow in debug. +BUGCR46603 SKIP DEBUG : fast/frames/lots-of-iframes.html = TIMEOUT +BUGCR46603 SKIP DEBUG : fast/frames/lots-of-objects.html = TIMEOUT // LayoutTestController::pageProperty is not implemented for Chromium yet. BUGWK35961 : printing/page-rule-selection.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99488] trunk/Source/WebCore
Title: [99488] trunk/Source/WebCore Revision 99488 Author jer.no...@apple.com Date 2011-11-07 15:17:42 -0800 (Mon, 07 Nov 2011) Log Message Rename PlatformClockPOSIX - ClockGeneric, and use WTF::currentTime() for its timing source. https://bugs.webkit.org/show_bug.cgi?id=71702 Reviewed by Sam Weinig. No new tests; covered by existing tests. * platform/Clock.cpp: (Clock::create): * platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp. (ClockGeneric::GenericClock): (ClockGeneric::setCurrentTime): (ClockGeneric::currentTime): (ClockGeneric::setPlayRate): (ClockGeneric::start): (ClockGeneric::stop): * platform/ClockGeneric.h: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.h. (WebCore::ClockGeneric::playRate): (WebCore::ClockGeneric::isRunning): Boilerplate project file changes: * CMakeLists.txt: * Target.pri: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/Clock.cpp Added Paths trunk/Source/WebCore/platform/ClockGeneric.cpp trunk/Source/WebCore/platform/ClockGeneric.h Removed Paths trunk/Source/WebCore/platform/posix/PlatformClockPOSIX.cpp trunk/Source/WebCore/platform/posix/PlatformClockPOSIX.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (99487 => 99488) --- trunk/Source/WebCore/CMakeLists.txt 2011-11-07 23:16:47 UTC (rev 99487) +++ trunk/Source/WebCore/CMakeLists.txt 2011-11-07 23:17:42 UTC (rev 99488) @@ -1022,6 +1022,7 @@ page/animation/KeyframeAnimation.cpp platform/Arena.cpp +platform/Clock.cpp platform/ContextMenu.cpp platform/ContextMenuItem.cpp platform/ContentType.cpp @@ -1033,6 +1034,7 @@ platform/FileChooser.cpp platform/FileIconLoader.cpp platform/FileSystem.cpp +platform/ClockGeneric.cpp platform/GeolocationService.cpp platform/KURL.cpp platform/KillRingNone.cpp Modified: trunk/Source/WebCore/ChangeLog (99487 => 99488) --- trunk/Source/WebCore/ChangeLog 2011-11-07 23:16:47 UTC (rev 99487) +++ trunk/Source/WebCore/ChangeLog 2011-11-07 23:17:42 UTC (rev 99488) @@ -1,3 +1,31 @@ +2011-11-07 Jer Noble jer.no...@apple.com + +Rename PlatformClockPOSIX - ClockGeneric, and use WTF::currentTime() for its timing source. +https://bugs.webkit.org/show_bug.cgi?id=71702 + +Reviewed by Sam Weinig. + +No new tests; covered by existing tests. + +* platform/Clock.cpp: +(Clock::create): +* platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp. +(ClockGeneric::GenericClock): +(ClockGeneric::setCurrentTime): +(ClockGeneric::currentTime): +(ClockGeneric::setPlayRate): +(ClockGeneric::start): +(ClockGeneric::stop): +* platform/ClockGeneric.h: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.h. +(WebCore::ClockGeneric::playRate): +(WebCore::ClockGeneric::isRunning): + +Boilerplate project file changes: +* CMakeLists.txt: +* Target.pri: +* WebCore.gypi: +* WebCore.xcodeproj/project.pbxproj: + 2011-11-07 Vangelis Kokkevis vange...@chromium.org Create a separate setting for compositing of for scrollable [i]frames Modified: trunk/Source/WebCore/Target.pri (99487 => 99488) --- trunk/Source/WebCore/Target.pri 2011-11-07 23:16:47 UTC (rev 99487) +++ trunk/Source/WebCore/Target.pri 2011-11-07 23:17:42 UTC (rev 99488) @@ -1032,6 +1032,7 @@ platform/FileIconLoader.cpp \ platform/FileStream.cpp \ platform/FileSystem.cpp \ +platform/ClockGeneric.cpp \ platform/GeolocationService.cpp \ platform/image-decoders/qt/ImageFrameQt.cpp \ platform/graphics/FontDescription.cpp \ @@ -2070,6 +2071,7 @@ platform/mock/GeolocationServiceMock.h \ platform/mock/SpeechInputClientMock.h \ platform/mock/ScrollbarThemeMock.h \ +platform/ClockGeneric.h \ platform/graphics/BitmapImage.h \ platform/graphics/Color.h \ platform/graphics/filters/FEBlend.h \ Modified: trunk/Source/WebCore/WebCore.gypi (99487 => 99488) --- trunk/Source/WebCore/WebCore.gypi 2011-11-07 23:16:47 UTC (rev 99487) +++ trunk/Source/WebCore/WebCore.gypi 2011-11-07 23:17:42 UTC (rev 99488) @@ -658,6 +658,7 @@ 'page/animation/AnimationController.h', 'page/mac/WebCoreFrameView.h', 'platform/AsyncFileStream.h', +'platform/Clock.h', 'platform/ContextMenu.h', 'platform/ContextMenuItem.h', 'platform/Cookie.h', @@ -3044,6 +3045,8 @@ 'platform/AsyncFileSystem.h', 'platform/AsyncFileSystemCallbacks.h', 'platform/AutodrainedPool.h', +'platform/Clock.cpp', +
[webkit-changes] [99489] trunk/Source/WebCore
Title: [99489] trunk/Source/WebCore
Revision 99489
Author aba...@webkit.org
Date 2011-11-07 15:20:18 -0800 (Mon, 07 Nov 2011)
Log Message
Move parseSandboxPolicy to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=71732
Reviewed by Eric Seidel.
As requested by Eric, this patch resolves a layering inversion. Now
that we have SecurityContext to hold the sandbox bits and the origin,
it's a logical place to put the parser for sandbox policies.
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
* dom/SecurityContext.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::applySandboxPolicy):
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/SecurityContext.cpp
trunk/Source/WebCore/dom/SecurityContext.h
trunk/Source/WebCore/html/HTMLIFrameElement.cpp
trunk/Source/WebCore/page/ContentSecurityPolicy.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/page/SecurityOrigin.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99488 => 99489)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 23:17:42 UTC (rev 99488)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 23:20:18 UTC (rev 99489)
@@ -1,3 +1,24 @@
+2011-11-07 Adam Barth aba...@webkit.org
+
+Move parseSandboxPolicy to SecurityContext
+https://bugs.webkit.org/show_bug.cgi?id=71732
+
+Reviewed by Eric Seidel.
+
+As requested by Eric, this patch resolves a layering inversion. Now
+that we have SecurityContext to hold the sandbox bits and the origin,
+it's a logical place to put the parser for sandbox policies.
+
+* dom/SecurityContext.cpp:
+(WebCore::SecurityContext::parseSandboxPolicy):
+* dom/SecurityContext.h:
+* html/HTMLIFrameElement.cpp:
+(WebCore::HTMLIFrameElement::parseMappedAttribute):
+* page/ContentSecurityPolicy.cpp:
+(WebCore::ContentSecurityPolicy::applySandboxPolicy):
+* page/SecurityOrigin.cpp:
+* page/SecurityOrigin.h:
+
2011-11-07 Jer Noble jer.no...@apple.com
Rename PlatformClockPOSIX - ClockGeneric, and use WTF::currentTime() for its timing source.
Modified: trunk/Source/WebCore/dom/SecurityContext.cpp (99488 => 99489)
--- trunk/Source/WebCore/dom/SecurityContext.cpp 2011-11-07 23:17:42 UTC (rev 99488)
+++ trunk/Source/WebCore/dom/SecurityContext.cpp 2011-11-07 23:20:18 UTC (rev 99489)
@@ -28,6 +28,7 @@
#include SecurityContext.h
#include ContentSecurityPolicy.h
+#include HTMLParserIdioms.h
#include SecurityOrigin.h
namespace WebCore {
@@ -51,4 +52,40 @@
m_contentSecurityPolicy = contentSecurityPolicy;
}
+SandboxFlags SecurityContext::parseSandboxPolicy(const String policy)
+{
+// http://www.w3.org/TR/html5/the-iframe-element.html#attr-iframe-sandbox
+// Parse the unordered set of unique space-separated tokens.
+SandboxFlags flags = SandboxAll;
+const UChar* characters = policy.characters();
+unsigned length = policy.length();
+unsigned start = 0;
+while (true) {
+while (start length isHTMLSpace(characters[start]))
+++start;
+if (start = length)
+break;
+unsigned end = start + 1;
+while (end length !isHTMLSpace(characters[end]))
+++end;
+
+// Turn off the corresponding sandbox flag if it's set as allowed.
+String sandboxToken = policy.substring(start, end - start);
+if (equalIgnoringCase(sandboxToken, allow-same-origin))
+flags = ~SandboxOrigin;
+else if (equalIgnoringCase(sandboxToken, allow-forms))
+flags = ~SandboxForms;
+else if (equalIgnoringCase(sandboxToken, allow-scripts))
+flags = ~SandboxScripts;
+else if (equalIgnoringCase(sandboxToken, allow-top-navigation))
+flags = ~SandboxTopNavigation;
+else if (equalIgnoringCase(sandboxToken, allow-popups))
+flags = ~SandboxPopups;
+
+start = end + 1;
+}
+
+return flags;
}
+
+}
Modified: trunk/Source/WebCore/dom/SecurityContext.h (99488 => 99489)
--- trunk/Source/WebCore/dom/SecurityContext.h 2011-11-07 23:17:42 UTC (rev 99488)
+++ trunk/Source/WebCore/dom/SecurityContext.h 2011-11-07 23:20:18 UTC (rev 99489)
@@ -29,6 +29,7 @@
#include wtf/PassRefPtr.h
#include wtf/RefPtr.h
+#include wtf/text/WTFString.h
namespace WebCore {
@@ -58,6 +59,8 @@
void enforceSandboxFlags(SandboxFlags mask) { m_sandboxFlags |= mask; }
bool isSandboxed(SandboxFlags mask) const { return m_sandboxFlags mask; }
+static SandboxFlags parseSandboxPolicy(const String policy);
+
protected:
SecurityContext();
~SecurityContext();
Modified: trunk/Source/WebCore/html/HTMLIFrameElement.cpp (99488 => 99489)
--- trunk/Source/WebCore/html/HTMLIFrameElement.cpp 2011-11-07 23:17:42 UTC
[webkit-changes] [99490] trunk/Source/WebCore
Title: [99490] trunk/Source/WebCore
Revision 99490
Author jer.no...@apple.com
Date 2011-11-07 15:25:52 -0800 (Mon, 07 Nov 2011)
Log Message
Build fix due to a erroneous search-and-replace.
Unreviewed build fix.
Replace all instances of GenericClock with ClockGeneric.
* WebCore.xcodeproj/project.pbxproj:
* platform/ClockGeneric.cpp:
(ClockGeneric::ClockGeneric):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/ClockGeneric.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99489 => 99490)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 23:20:18 UTC (rev 99489)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 23:25:52 UTC (rev 99490)
@@ -1,3 +1,15 @@
+2011-11-07 Jer Noble jer.no...@apple.com
+
+Build fix due to a erroneous search-and-replace.
+
+Unreviewed build fix.
+
+Replace all instances of GenericClock with ClockGeneric.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/ClockGeneric.cpp:
+(ClockGeneric::ClockGeneric):
+
2011-11-07 Adam Barth aba...@webkit.org
Move parseSandboxPolicy to SecurityContext
@@ -31,7 +43,7 @@
* platform/Clock.cpp:
(Clock::create):
* platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp.
-(ClockGeneric::GenericClock):
+(ClockGeneric::ClockGeneric):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (99489 => 99490)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-07 23:20:18 UTC (rev 99489)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-07 23:25:52 UTC (rev 99490)
@@ -5715,7 +5715,7 @@
CD8203101395ACE700F956C6 /* WebWindowAnimation.h in Headers */ = {isa = PBXBuildFile; fileRef = CD82030E1395ACE700F956C6 /* WebWindowAnimation.h */; };
CD8203111395ACE700F956C6 /* WebWindowAnimation.mm in Sources */ = {isa = PBXBuildFile; fileRef = CD82030F1395ACE700F956C6 /* WebWindowAnimation.mm */; };
CDEA763014608A53008B31F1 /* PlatformClockCA.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDEA762E146084DE008B31F1 /* PlatformClockCA.cpp */; };
- CDEA76341460B56F008B31F1 /* ClockGeneric.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDEA76321460AE29008B31F1 /* GenericClock.cpp */; };
+ CDEA76341460B56F008B31F1 /* ClockGeneric.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDEA76321460AE29008B31F1 /* ClockGeneric.cpp */; };
CDEA76351460B71A008B31F1 /* Clock.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDEA76331460B462008B31F1 /* Clock.cpp */; };
CDEA7C841276230400B846DD /* RenderFullScreen.h in Headers */ = {isa = PBXBuildFile; fileRef = CDEA7C821276230400B846DD /* RenderFullScreen.h */; };
CDEA7C851276230400B846DD /* RenderFullScreen.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDEA7C831276230400B846DD /* RenderFullScreen.cpp */; };
@@ -13025,8 +13025,8 @@
CDEA762C14608224008B31F1 /* Clock.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Clock.h; sourceTree = group; };
CDEA762E146084DE008B31F1 /* PlatformClockCA.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PlatformClockCA.cpp; sourceTree = group; };
CDEA762F146084EE008B31F1 /* PlatformClockCA.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformClockCA.h; sourceTree = group; };
- CDEA76311460AE1B008B31F1 /* ClockGeneric.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GenericClock.h; sourceTree = group; };
- CDEA76321460AE29008B31F1 /* ClockGeneric.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GenericClock.cpp; sourceTree = group; };
+ CDEA76311460AE1B008B31F1 /* ClockGeneric.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ClockGeneric.h; sourceTree = group; };
+ CDEA76321460AE29008B31F1 /* ClockGeneric.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ClockGeneric.cpp; sourceTree = group; };
CDEA76331460B462008B31F1 /* Clock.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Clock.cpp; sourceTree = group; };
CDEA7C821276230400B846DD /* RenderFullScreen.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderFullScreen.h; sourceTree = group; };
CDEA7C831276230400B846DD /* RenderFullScreen.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderFullScreen.cpp; sourceTree = group; };
Modified: trunk/Source/WebCore/platform/ClockGeneric.cpp (99489 => 99490)
---
[webkit-changes] [99491] trunk/Source/WebCore
Title: [99491] trunk/Source/WebCore Revision 99491 Author andreas.kl...@nokia.com Date 2011-11-07 15:39:29 -0800 (Mon, 07 Nov 2011) Log Message Unreviewed Windows build fix after r99468. * css/CSSPrimitiveValue.h: Unmark single-argument constructors as explicit, since this conflicts with the template constructors in CSSPrimitiveValueMappings.h. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPrimitiveValue.h Diff Modified: trunk/Source/WebCore/ChangeLog (99490 => 99491) --- trunk/Source/WebCore/ChangeLog 2011-11-07 23:25:52 UTC (rev 99490) +++ trunk/Source/WebCore/ChangeLog 2011-11-07 23:39:29 UTC (rev 99491) @@ -1,3 +1,11 @@ +2011-11-07 Andreas Kling kl...@webkit.org + +Unreviewed Windows build fix after r99468. + +* css/CSSPrimitiveValue.h: Unmark single-argument constructors +as explicit, since this conflicts with the template constructors +in CSSPrimitiveValueMappings.h. + 2011-11-07 Jer Noble jer.no...@apple.com Build fix due to a erroneous search-and-replace. @@ -3031,6 +3039,24 @@ 2011-11-03 Andreas Kling kl...@webkit.org +CSSRuleList: Move rule orphaning from deleteRule() out to callers. +https://bugs.webkit.org/show_bug.cgi?id=71470 + +Reviewed by Antti Koivisto. + +Rule parenting is the responsibility of the owner rule (the rule containing +the rule list), so move parent clearing out of CSSRuleList::deleteRule() and +into the (two) call sites. + +* css/CSSMediaRule.cpp: +(WebCore::CSSMediaRule::deleteRule): +* css/CSSRuleList.cpp: +(WebCore::CSSRuleList::deleteRule): +* css/WebKitCSSKeyframesRule.cpp: +(WebCore::WebKitCSSKeyframesRule::deleteRule): + +2011-11-03 Andreas Kling kl...@webkit.org + Unreviewed build fix, sigh. * css/CSSFontFaceRule.h: Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (99490 => 99491) --- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-11-07 23:25:52 UTC (rev 99490) +++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-11-07 23:39:29 UTC (rev 99491) @@ -220,9 +220,9 @@ private: CSSPrimitiveValue(); // FIXME: int vs. unsigned overloading is too subtle to distinguish the color and identifier cases. -explicit CSSPrimitiveValue(int ident); -explicit CSSPrimitiveValue(unsigned color); // RGB value -explicit CSSPrimitiveValue(const Length); +CSSPrimitiveValue(int ident); +CSSPrimitiveValue(unsigned color); // RGB value +CSSPrimitiveValue(const Length); CSSPrimitiveValue(const String, UnitTypes); CSSPrimitiveValue(double, UnitTypes); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99492] trunk/Source/WebCore
Title: [99492] trunk/Source/WebCore
Revision 99492
Author aboxh...@chromium.org
Date 2011-11-07 15:43:21 -0800 (Mon, 07 Nov 2011)
Log Message
Remove unnecessary use of function pointer in FrameSelection::modify()
https://bugs.webkit.org/show_bug.cgi?id=71646
Reviewed by Ryosuke Niwa.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modify):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99491 => 99492)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 23:39:29 UTC (rev 99491)
+++ trunk/Source/WebCore/ChangeLog 2011-11-07 23:43:21 UTC (rev 99492)
@@ -1,3 +1,13 @@
+2011-11-07 Alice Boxhall aboxh...@chromium.org
+
+Remove unnecessary use of function pointer in FrameSelection::modify()
+https://bugs.webkit.org/show_bug.cgi?id=71646
+
+Reviewed by Ryosuke Niwa.
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::modify):
+
2011-11-07 Andreas Kling kl...@webkit.org
Unreviewed Windows build fix after r99468.
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (99491 => 99492)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2011-11-07 23:39:29 UTC (rev 99491)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2011-11-07 23:43:21 UTC (rev 99492)
@@ -1024,7 +1024,11 @@
VisiblePosition result;
VisiblePosition next;
for (VisiblePosition p = pos; ; p = next) {
-next = (direction == DirectionUp ? previousLinePosition : nextLinePosition)(p, xPos);
+if (direction == DirectionUp)
+next = previousLinePosition(p, xPos);
+else
+next = nextLinePosition(p, xPos);
+
if (next.isNull() || next == p)
break;
LayoutUnit nextY;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99493] trunk/Source
Title: [99493] trunk/Source Revision 99493 Author bda...@apple.com Date 2011-11-07 15:45:23 -0800 (Mon, 07 Nov 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=71490 Support uiStateTransitionProgress for scrollbars -and corresponding- rdar://problem/9849612 Reviewed by Sam Weinig. Source/WebCore: Step 1 of supporting uiStateTransitionProgress is knowing when the mouse has entered or exited a scrollbar. These changes to Scrollbar pass that information on to the ScrollAnimator. Also, Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter. This is necessary because m_hoveredNode is not always up to date on a mouseUp, so mouseUp must hitTest the scrollbar to see if the mouse has exited the scrollbar. * platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): * platform/Scrollbar.h: These changes are required now that Scrollbar::mouseUp() takes a parameter. * WebCore.exp.in: * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent): * platform/chromium/PopupListBox.cpp: (WebCore::PopupListBox::handleMouseReleaseEvent): * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::wndProc): ScrollAnimator passes the information on to AppKit. * platform/ScrollAnimator.h: (WebCore::ScrollAnimator::mouseEnteredScrollbar): (WebCore::ScrollAnimator::mouseExitedScrollbar): * platform/mac/ScrollAnimatorMac.h: (WebCore::ScrollAnimatorMac::mouseEnteredScrollbar): (WebCore::ScrollAnimatorMac::mouseExitedScrollbar): There are several new pieces of AppKit api we must call into. * platform/mac/NSScrollerImpDetails.h: This is a temporary function that is needed for the time being since there is new AppKit api required for this to work. * platform/mac/ScrollAnimatorMac.mm: (supportsUIStateTransitionProgress): I refactored WebScrollbarPartAnimation so that it can handle the uiStateTransitionProgress animation as well as the alpha animations it already handled. This mostly involved re-naming things and making use of a new enum called FeatureToAnimate which keeps track of what the instance of WebScrollbarPartAnimation is animating. (-[WebScrollbarPartAnimation initWithScrollbarPainter:animate:scrollAnimator:animateFrom:animateTo:duration:]): (-[WebScrollbarPartAnimation setScrollbarPainter:]): (-[WebScrollbarPartAnimation setStartValue:]): (-[WebScrollbarPartAnimation setEndValue:]): (-[WebScrollbarPartAnimation setCurrentProgress:]): WebScrollbarPainterDelegate has two new animations, _verticalUIStateTransitionAnimation, and _horizontalUIStateTransitionAnimation. It also responds to a few new delegate calls. (-[WebScrollbarPainterDelegate cancelAnimations]): This is a new delegate call needed for uiStateTransitionProgress. (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): I re-named setUpAnimation to setUpAlphaAnimation since it does a lot of things that are specific to the alpha animation and I chose not to re-use it for uiStateTransition. (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): New delegate call for the uiStateTransition animation that sets up that animation and kicks it off. (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]): Source/WebKit/chromium: Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter. * src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::onMouseUp): Source/WebKit/win: Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter. * WebScrollBar.cpp: (WebScrollBar::handleMouseEvent): Source/WebKit2: Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter. * UIProcess/win/WebPopupMenuProxyWin.cpp: (WebKit::WebPopupMenuProxyWin::onLButtonUp): * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::handleMouseEvent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/platform/ScrollAnimator.h trunk/Source/WebCore/platform/Scrollbar.cpp trunk/Source/WebCore/platform/Scrollbar.h trunk/Source/WebCore/platform/chromium/PopupListBox.cpp trunk/Source/WebCore/platform/mac/NSScrollerImpDetails.h trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm trunk/Source/WebCore/platform/win/PopupMenuWin.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebScrollbarImpl.cpp trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebScrollBar.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp
[webkit-changes] [99494] trunk/Tools
Title: [99494] trunk/Tools Revision 99494 Author commit-qu...@webkit.org Date 2011-11-07 15:46:08 -0800 (Mon, 07 Nov 2011) Log Message Unreviewed, rolling out r99470. http://trac.webkit.org/changeset/99470 https://bugs.webkit.org/show_bug.cgi?id=71740 Broke test-webkitpy (Requested by eseidel2 on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-07 * Scripts/webkitpy/common/config/watchlist: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/watchlist Diff Modified: trunk/Tools/ChangeLog (99493 => 99494) --- trunk/Tools/ChangeLog 2011-11-07 23:45:23 UTC (rev 99493) +++ trunk/Tools/ChangeLog 2011-11-07 23:46:08 UTC (rev 99494) @@ -1,3 +1,13 @@ +2011-11-07 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r99470. +http://trac.webkit.org/changeset/99470 +https://bugs.webkit.org/show_bug.cgi?id=71740 + +Broke test-webkitpy (Requested by eseidel2 on #webkit). + +* Scripts/webkitpy/common/config/watchlist: + 2011-11-07 Tony Chang t...@chromium.org [chromium] update flakiness dashboard to reflect current bots Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (99493 => 99494) --- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-11-07 23:45:23 UTC (rev 99493) +++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-11-07 23:46:08 UTC (rev 99494) @@ -115,7 +115,7 @@ # Specifically, le...@chromium.org and levin+thread...@chromium.org are # two different accounts as far as bugzilla is concerned. ChromiumDumpRenderTree: [ tk...@chromium.org, ], -ChromiumGraphics: [ jam...@chromium.org, cc-b...@google.com ], +ChromiumGraphics: [ jam...@chromium.org, ], ChromiumPublicApi: [ fi...@chromium.org, ], Forms: [ tk...@chromium.org, ], GStreamerGraphics: [ pnorm...@igalia.com, ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99495] trunk/Source/JavaScriptCore
Title: [99495] trunk/Source/_javascript_Core
Revision 99495
Author dslo...@google.com
Date 2011-11-07 15:49:17 -0800 (Mon, 07 Nov 2011)
Log Message
Unreviewed. Release build fix.
* parser/Lexer.cpp:
(JSC::assertCharIsIn8BitRange):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Lexer.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99494 => 99495)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-07 23:46:08 UTC (rev 99494)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-07 23:49:17 UTC (rev 99495)
@@ -1,3 +1,10 @@
+2011-11-07 Dmitry Lomov dslo...@google.com
+
+Unreviewed. Release build fix.
+
+* parser/Lexer.cpp:
+(JSC::assertCharIsIn8BitRange):
+
2011-11-07 Filip Pizlo fpi...@apple.com
Switch the value profiler back to 8 buckets, because we suspect that while this
Modified: trunk/Source/_javascript_Core/parser/Lexer.cpp (99494 => 99495)
--- trunk/Source/_javascript_Core/parser/Lexer.cpp 2011-11-07 23:46:08 UTC (rev 99494)
+++ trunk/Source/_javascript_Core/parser/Lexer.cpp 2011-11-07 23:49:17 UTC (rev 99495)
@@ -428,6 +428,7 @@
template typename T
inline void assertCharIsIn8BitRange(T c)
{
+UNUSED_PARAM(c);
ASSERT(c = 0);
ASSERT(c = 0xFF);
}
@@ -435,6 +436,7 @@
template
inline void assertCharIsIn8BitRange(UChar c)
{
+UNUSED_PARAM(c);
ASSERT(c = 0xFF);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99496] trunk/LayoutTests
Title: [99496] trunk/LayoutTests Revision 99496 Author t...@chromium.org Date 2011-11-07 15:53:04 -0800 (Mon, 07 Nov 2011) Log Message [chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation-targetlink.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99495 => 99496) --- trunk/LayoutTests/ChangeLog 2011-11-07 23:49:17 UTC (rev 99495) +++ trunk/LayoutTests/ChangeLog 2011-11-07 23:53:04 UTC (rev 99496) @@ -1,5 +1,11 @@ 2011-11-07 Tony Chang t...@chromium.org +[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation-targetlink.html + +* platform/chromium/test_expectations.txt: + +2011-11-07 Tony Chang t...@chromium.org + [chromium] disable 2 tests that are slow in debug * platform/chromium/test_expectations.txt: only run Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99495 => 99496) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 23:49:17 UTC (rev 99495) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-07 23:53:04 UTC (rev 99496) @@ -38,7 +38,7 @@ BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/frames/sandboxed-iframe-navigation-parent.html = PASS BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/js/repeat-cached-vm-reentry.html = PASS BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/dom/Window/window-postmessage-clone-deep-array.html = PASS -//BUGCR24182 SLOW DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = PASS +BUGCR24182 SLOW DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = PASS BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/frames/calculate-percentage.html = PASS // See BUGCR104797 //BUGCR24182 SLOW DEBUG SNOWLEOPARD : svg/hixie/perf/007.xml = PASS @@ -3895,8 +3895,6 @@ BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/iframe-double-scale-contents.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/set-parent-src-synchronously.html = PASS CRASH -BUGWK71658 MAC DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = PASS TIMEOUT - // Introduced due to BUGWK53512, fails under Skia right now BUGWK65939 : svg/custom/getBBox-path.svg = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99497] trunk/Source
Title: [99497] trunk/Source
Revision 99497
Author mhahnenb...@apple.com
Date 2011-11-07 15:57:37 -0800 (Mon, 07 Nov 2011)
Log Message
De-virtualize JSObject::putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71716
Reviewed by Darin Adler.
Source/_javascript_Core:
Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* API/JSObjectRef.cpp:
(JSObjectSetProperty):
* _javascript_Core.exp:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::putWithAttributes):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::putWithAttributes):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::putWithAttributes):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::putWithAttributes):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::putWithAttributes):
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::putWithAttributes):
* runtime/JSVariableObject.h:
Source/WebCore:
No new tests.
Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::putWithAttributes):
* bindings/js/JSDOMWindowShell.h:
Modified Paths
trunk/Source/_javascript_Core/API/JSObjectRef.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/debugger/DebuggerActivation.cpp
trunk/Source/_javascript_Core/debugger/DebuggerActivation.h
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/runtime/ClassInfo.h
trunk/Source/_javascript_Core/runtime/JSActivation.cpp
trunk/Source/_javascript_Core/runtime/JSActivation.h
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSStaticScopeObject.cpp
trunk/Source/_javascript_Core/runtime/JSStaticScopeObject.h
trunk/Source/_javascript_Core/runtime/JSVariableObject.cpp
trunk/Source/_javascript_Core/runtime/JSVariableObject.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowShell.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowShell.h
Diff
Modified: trunk/Source/_javascript_Core/API/JSObjectRef.cpp (99496 => 99497)
--- trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2011-11-07 23:53:04 UTC (rev 99496)
+++ trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2011-11-07 23:57:37 UTC (rev 99497)
@@ -274,7 +274,7 @@
JSValue jsValue = toJS(exec, value);
if (attributes !jsObject-hasProperty(exec, name))
-jsObject-putWithAttributes(exec, name, jsValue, attributes);
+jsObject-methodTable()-putWithAttributes(jsObject, exec, name, jsValue, attributes);
else {
PutPropertySlot slot;
jsObject-methodTable()-put(jsObject, exec, name, jsValue, slot);
Modified: trunk/Source/_javascript_Core/ChangeLog (99496 => 99497)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-07 23:53:04 UTC (rev 99496)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-07 23:57:37 UTC (rev 99497)
@@ -1,3 +1,44 @@
+2011-11-07 Mark Hahnenberg mhahnenb...@apple.com
+
+De-virtualize JSObject::putWithAttributes
+https://bugs.webkit.org/show_bug.cgi?id=71716
+
+Reviewed by Darin Adler.
+
+Added putWithAttributes to the MethodTable, changed all the virtual
+implementations of putWithAttributes to static ones, and replaced
+all call sites with corresponding lookups in the MethodTable.
+
+* API/JSObjectRef.cpp:
+(JSObjectSetProperty):
+* _javascript_Core.exp:
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+* debugger/DebuggerActivation.cpp:
+(JSC::DebuggerActivation::putWithAttributes):
+* debugger/DebuggerActivation.h:
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::execute):
+* runtime/ClassInfo.h:
+* runtime/JSActivation.cpp:
+(JSC::JSActivation::putWithAttributes):
+* runtime/JSActivation.h:
+* runtime/JSCell.cpp:
+(JSC::JSCell::putWithAttributes):
+*
[webkit-changes] [99498] trunk/Source/WebCore
Title: [99498] trunk/Source/WebCore
Revision 99498
Author hara...@chromium.org
Date 2011-11-07 16:10:42 -0800 (Mon, 07 Nov 2011)
Log Message
Remove [CustomGetter] IDL for window.Option of V8
https://bugs.webkit.org/show_bug.cgi?id=71735
Reviewed by Nate Chapin.
Currently, window.Option uses a custom getter to get the template
of 'HTMLOptionElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.
Tests: fast/js/custom-constructors.html
fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html
* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
* page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Option of V8. Renamed 'HTMLOptionElementConstructor' to 'HTMLOptionElementConstructorConstructor' in order to make window.Option use the template of (not 'HTMLOptionElement' but) 'HTMLOptionElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (99497 => 99498)
--- trunk/Source/WebCore/ChangeLog 2011-11-07 23:57:37 UTC (rev 99497)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 00:10:42 UTC (rev 99498)
@@ -1,3 +1,23 @@
+2011-11-07 Kentaro Hara hara...@chromium.org
+
+Remove [CustomGetter] IDL for window.Option of V8
+https://bugs.webkit.org/show_bug.cgi?id=71735
+
+Reviewed by Nate Chapin.
+
+Currently, window.Option uses a custom getter to get the template
+of 'HTMLOptionElementConstructor'. However, this getter does not need to
+be custom and can use a default getter
+'DOMWindowInternal::DOMWindowConstructorGetter'.
+
+Tests: fast/js/custom-constructors.html
+ fast/forms/option-index.html
+ fast/forms/add-and-remove-option.html
+ fast/dom/dom-add-optionelement.html
+
+* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
+* page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Option of V8. Renamed 'HTMLOptionElementConstructor' to 'HTMLOptionElementConstructorConstructor' in order to make window.Option use the template of (not 'HTMLOptionElement' but) 'HTMLOptionElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
+
2011-11-07 Mark Hahnenberg mhahnenb...@apple.com
De-virtualize JSObject::putWithAttributes
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (99497 => 99498)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2011-11-07 23:57:37 UTC (rev 99497)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2011-11-08 00:10:42 UTC (rev 99498)
@@ -58,7 +58,6 @@
#include V8HiddenPropertyName.h
#include V8HTMLCollection.h
#include V8HTMLImageElementConstructor.h
-#include V8HTMLOptionElementConstructor.h
#include V8MessagePortCustom.h
#include V8Node.h
#include V8Proxy.h
@@ -232,12 +231,6 @@
return V8DOMWrapper::getConstructor(V8HTMLImageElementConstructor::info, window);
}
-v8::Handlev8::Value V8DOMWindow::OptionAccessorGetter(v8::Localv8::String name, const v8::AccessorInfo info)
-{
-DOMWindow* window = V8DOMWindow::toNative(info.Holder());
-return V8DOMWrapper::getConstructor(V8HTMLOptionElementConstructor::info, window);
-}
-
v8::Handlev8::Value V8DOMWindow::addEventListenerCallback(const v8::Arguments args)
{
INC_STATS(DOM.DOMWindow.addEventListener());
Modified: trunk/Source/WebCore/page/DOMWindow.idl (99497 => 99498)
--- trunk/Source/WebCore/page/DOMWindow.idl 2011-11-07 23:57:37 UTC (rev 99497)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2011-11-08 00:10:42 UTC (rev 99498)
@@ -491,7 +491,7 @@
attribute HTMLUnknownElementConstructor HTMLUnknownElement;
attribute [CustomGetter] HTMLImageElementConstructor Image; // Usable with new operator
-attribute [CustomGetter] HTMLOptionElementConstructor Option; // Usable with new operator
+attribute [JSCCustomGetter] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
attribute CanvasPatternConstructor CanvasPattern;
attribute CanvasGradientConstructor CanvasGradient;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99499] tags/Safari-534.53.1/
Title: [99499] tags/Safari-534.53.1/ Revision 99499 Author lforsch...@apple.com Date 2011-11-07 16:21:23 -0800 (Mon, 07 Nov 2011) Log Message New tag. Added Paths tags/Safari-534.53.1/ Diff Property changes: tags/Safari-534.53.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99500] trunk/Source/WebCore
Title: [99500] trunk/Source/WebCore
Revision 99500
Author commit-qu...@webkit.org
Date 2011-11-07 16:27:44 -0800 (Mon, 07 Nov 2011)
Log Message
Allow gamepad API to be enabled at runtime
https://bugs.webkit.org/show_bug.cgi?id=71736
Part of full patch, found at
https://bugs.webkit.org/show_bug.cgi?id=69451
Patch by Scott Graham scot...@chromium.org on 2011-11-07
Reviewed by Adam Barth.
No new tests. No new functionality.
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99499 => 99500)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 00:21:23 UTC (rev 99499)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 00:27:44 UTC (rev 99500)
@@ -1,3 +1,20 @@
+2011-11-07 Scott Graham scot...@chromium.org
+
+Allow gamepad API to be enabled at runtime
+https://bugs.webkit.org/show_bug.cgi?id=71736
+
+Part of full patch, found at
+https://bugs.webkit.org/show_bug.cgi?id=69451
+
+Reviewed by Adam Barth.
+
+No new tests. No new functionality.
+
+* bindings/generic/RuntimeEnabledFeatures.cpp:
+* bindings/generic/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled):
+(WebCore::RuntimeEnabledFeatures::gamepadsEnabled):
+
2011-11-07 Kentaro Hara hara...@chromium.org
Remove [CustomGetter] IDL for window.Option of V8
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (99499 => 99500)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2011-11-08 00:21:23 UTC (rev 99499)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2011-11-08 00:27:44 UTC (rev 99500)
@@ -60,6 +60,10 @@
bool RuntimeEnabledFeatures::isMediaStreamEnabled = true;
#endif
+#if ENABLE(GAMEPAD)
+bool RuntimeEnabledFeatures::isGamepadEnabled = false;
+#endif
+
#if ENABLE(XHR_RESPONSE_BLOB)
bool RuntimeEnabledFeatures::isXHRResponseBlobEnabled = false;
#endif
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (99499 => 99500)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2011-11-08 00:21:23 UTC (rev 99499)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2011-11-08 00:27:44 UTC (rev 99500)
@@ -170,6 +170,11 @@
static bool webkitPeerConnectionEnabled() { return isMediaStreamEnabled; }
#endif
+#if ENABLE(GAMEPAD)
+static void setGamepadsEnabled(bool isEnabled) { isGamepadEnabled = isEnabled; }
+static bool gamepadsEnabled() { return isGamepadEnabled; }
+#endif
+
#if ENABLE(QUOTA)
static bool quotaEnabled() { return isQuotaEnabled; }
static void setQuotaEnabled(bool isEnabled) { isQuotaEnabled = isEnabled; }
@@ -218,6 +223,10 @@
static bool isMediaStreamEnabled;
#endif
+#if ENABLE(GAMEPAD)
+static bool isGamepadEnabled;
+#endif
+
#if ENABLE(QUOTA)
static bool isQuotaEnabled;
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99501] trunk/LayoutTests
Title: [99501] trunk/LayoutTests
Revision 99501
Author t...@chromium.org
Date 2011-11-07 16:33:20 -0800 (Mon, 07 Nov 2011)
Log Message
Fix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html
* platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (99500 => 99501)
--- trunk/LayoutTests/ChangeLog 2011-11-08 00:27:44 UTC (rev 99500)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 00:33:20 UTC (rev 99501)
@@ -1,5 +1,12 @@
2011-11-07 Tony Chang t...@chromium.org
+Fix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html
+
+* platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png.
+
+2011-11-07 Tony Chang t...@chromium.org
+
[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation-targetlink.html
* platform/chromium/test_expectations.txt:
Deleted: trunk/LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png (99500 => 99501)
--- trunk/LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png 2011-11-08 00:27:44 UTC (rev 99500)
+++ trunk/LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png 2011-11-08 00:33:20 UTC (rev 99501)
@@ -1,23 +0,0 @@
-\x89PNG
-
-
-IHDR X \x9Av\x82p )tEXtchecksum e87db63453aa2143e6ce48efc6c08560 \xBB@ IDATx\x9C\xED\xDD{\x98Wu\x9D\xC0\xF1\xCF 7QA\x8C\x8B\x97\xC1\xB4\x8Bff\xA4.ZKі\x99\xA9\xABKiۮe\xFB\xF4\xB4k\xAE]TJӮJf\xE5\x85B\xED\xC9E\x934#ٌrў))Q\xF3ISDf`\xE6\xBB\xF8\xCC\xEFq\x86\x99\xDF\xDC\xE0\x83\xD5\xEB\xF5\x8F\x9Eߜ\xDF9\xDF\xF3=\xC7q\xDE\xF3;\xBF\xDFԔRJ $\xA8\xDD\xD9 \xFE~ \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2 \x8D \xD2\x90\xED\xEC\xF9矏+Vl\xF3\xF8\xAAU\xABbѢE\xF1\xC2 /t\xBA\x8D
-6ēO\xB9#\x86ש\x8Eƿ#\xBCrN\xDA\xA1!~\xF9\xCB_v\xB8\xDC MMM\xF1\x87?\xFC\xA1\xD7\xE3\xA5k6l\xD8\xF9\xCB_z\xF4\xDCޜ\xE7\x9D\xCDu ]\xD3i\x80L\x9F=\x86 \xC7 |\xBC\xEF}\xEF\x8B}\xFA\xC4\xF8\xF1\xE3\xE3\xBD\xEF}o u\xD4QѧO\x9F\xB8\xFE\xFA\xEB3\xC6\xFAW᳟\xFDl\xBC\xFB\xDD\xEFn\xF5ط\xBF\xFD\xED\x987o^,^\xBC8:\xE8\xA0hhh\xE8\xF0\xF9?\xF8\xC1b\xE4ȑq\xC3
-7\xEC衶\xAB\xBD\xF1\xEFm\xE7\xE4?\xFF\xF3?+\xFB]\xBAti ~\xF8\xE11cƌv\x97\xBB\xE37\xBF\xF9ML\x992%\xFE\xE5_\xFEe\xBB\x8E\x9F\xF6͙3'\x86
-\xB7\xDCrK\xB7\x9Fۛ\xF3\xBC\xB3\xFD5_g\xD7^{m\x8C 92jjj\xE2\xEC\xB3\xCF\xDE\xD9\xC3\xE0\xEFA\xE9Ĵi\xD3\xCA\xE3\x8F?^Y\xDEe\x97]\xCA駟^Y\xBE\xFC\xF2\xCB˜9s:\xDBL\x876o\xDE\-Z\xD4\xE3\xE7\xBFڬ^\xBD\xBA\xF2\xC8#\x95\xE5
-6\x94A\x83\x95\xA6\xA6\xA6RJ)\xFF\xFB\xBF\xFF\xBB\xCDs\xDA\xCE\xC1ĉ\xCB\xBF\xF8\xC5 ?\xD8v\xB4 \xFF\x8E\xD0ޜ\xB4\xDD\xEFe\x97]VF\x8E \xD9\xE1rw|\xECc +\xC7 {l\xEFM\x97\x8D 9\xB2\q\xC5=zno\xCE\xF3\xCE\xF6\xD7|\x9D\x9Dr\xCA)%\xCA?\xFF\xF3?\xEF\xEC\xA1 \xF0w\xA0\xD3W@\xF1\x89O\xC4\xF8\xF1\xE3;\xFC\xFA\xACY\xB3⠃\xEAN\xF0T\xFE}˖-\xF1\xA1}(\xEE\xBB\xEF\xBEn?\xB7\xAD\xAD[\xB7v\xFByնד1DD 6,\xF6\xDF\xFF\xCAr}}}466Fm\xED\xCBS}\xE4\x91G\xB6Z\xBF\xBD9\xE8ׯ_\xD4\xD4\xD4t{l\xDBC\xDB\xF1\xB7\xE8\xEA\U;-ڛ\x93\xB6\xFB\xED߿\xAB9h\xBB\xDC\xCD\xCD\xCDѷo\xDFʾ\xAA\xE9\xC9\xF5\x90eG\x8D\xAD+竻zs\xFD\xF6\xE4o\xBD\x99\x87\xEE^g\xAFF}\xFB\xF6\x8D\x88\xD8i\xDFw \xF8\xFBҷ\xB3\xDE\xF9\xCEwV\xFD\xFA\xA0A\x83\xE2-oyKDD\xFB\xEC\xB31{\xF6\xEC\xF8\xBF\xFF\xFB\xBFذaC|\xF3\x9Bߌ7\xBF\xF9\xCDq\xD3M7\xC5 /\xBC\xEB֭\x8B\xF9\xF3\xE7\xC7/\xF9˸\xF2\xCA+\xE3\xB6\xDBn\x8BG }4 {\xEC\xB1\xF8ַ\xBE\x83
-\xAAl{\xE1
q\xED\xB5\xD7\xC6~\xFB\xED[\xB6l\x89\xEF\xFF\xFBѿ\xFF\xF8\xEEw\xBF\xC7 w\DD\xDCs\xCF=\xF1\xC0DMMM̟??\xE6̙ |p\x87\xFB\xAC\xF6xw\xC7\xDF\xD63\xCF7\xDCpC\xDCz\xEB\xADq\xFF\xFD\xF7\xC7w\xBE\xF3\x9D\xF8я~[\xB7n\x8Ds\xCF=7 \x97]vY\xAB\xE7\xB47/\xFFP\xF3\xD9\xCF~6\xBE\xFF\xFD\xEF\xC7\xEE\xBB\xEF \xB7\xDF~{%;\xE7\xB2e\xCBbΜ91bĈ8p`\y\xE5\x95q\xC7 w\xC4رc;\xAEj\xE3\xEF\xEAqwv
[webkit-changes] [99502] trunk/Source/JavaScriptCore
Title: [99502] trunk/Source/_javascript_Core
Revision 99502
Author fpi...@apple.com
Date 2011-11-07 16:37:33 -0800 (Mon, 07 Nov 2011)
Log Message
DFG operationCreateThis slow path may get the wrong callee in case of inlining
https://bugs.webkit.org/show_bug.cgi?id=71647
Reviewed by Oliver Hunt.
No new tests because I only saw this manifest itself when I had other bugs
leading to spurious slow path executions.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99501 => 99502)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-08 00:33:20 UTC (rev 99501)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-08 00:37:33 UTC (rev 99502)
@@ -1,3 +1,22 @@
+2011-11-06 Filip Pizlo fpi...@apple.com
+
+DFG operationCreateThis slow path may get the wrong callee in case of inlining
+https://bugs.webkit.org/show_bug.cgi?id=71647
+
+Reviewed by Oliver Hunt.
+
+No new tests because I only saw this manifest itself when I had other bugs
+leading to spurious slow path executions.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::callOperation):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
2011-11-07 Mark Hahnenberg mhahnenb...@apple.com
De-virtualize JSObject::putWithAttributes
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (99501 => 99502)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-11-08 00:33:20 UTC (rev 99501)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-11-08 00:37:33 UTC (rev 99502)
@@ -1396,6 +1396,11 @@
setupArgumentsWithExecState(arg1);
return appendCallWithExceptionCheckSetResult(operation, result);
}
+JITCompiler::Call callOperation(C_DFGOperation_ECC operation, GPRReg result, GPRReg arg1, JSCell* cell)
+{
+setupArgumentsWithExecState(arg1, TrustedImmPtr(cell));
+return appendCallWithExceptionCheckSetResult(operation, result);
+}
JITCompiler::Call callOperation(S_DFGOperation_EJ operation, GPRReg result, GPRReg arg1)
{
setupArgumentsWithExecState(arg1);
@@ -1549,6 +1554,11 @@
setupArgumentsWithExecState(arg1);
return appendCallWithExceptionCheckSetResult(operation, result);
}
+JITCompiler::Call callOperation(C_DFGOperation_ECC operation, GPRReg result, GPRReg arg1, JSCell* cell)
+{
+setupArgumentsWithExecState(arg1, TrustedImmPtr(cell));
+return appendCallWithExceptionCheckSetResult(operation, result);
+}
JITCompiler::Call callOperation(S_DFGOperation_EJ operation, GPRReg result, GPRReg arg1Tag, GPRReg arg1Payload)
{
setupArgumentsWithExecState(arg1Payload, arg1Tag);
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (99501 => 99502)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-11-08 00:33:20 UTC (rev 99501)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-11-08 00:37:33 UTC (rev 99502)
@@ -163,10 +163,8 @@
return JSValue::encode(JSValue::decode(encodedOp).toThisObject(exec));
}
-JSCell* DFG_OPERATION operationCreateThis(ExecState* exec, JSCell* prototype)
+inline JSCell* createThis(ExecState* exec, JSCell* prototype, JSFunction* constructor)
{
-JSFunction* constructor = asFunction(exec-callee());
-
#if !ASSERT_DISABLED
ConstructData constructData;
ASSERT(constructor-methodTable()-getConstructData(constructor, constructData) == ConstructTypeJS);
@@ -183,6 +181,16 @@
return constructEmptyObject(exec, structure);
}
+JSCell* DFG_OPERATION operationCreateThis(ExecState* exec, JSCell* prototype)
+{
+return createThis(exec, prototype, asFunction(exec-callee()));
+}
+
+JSCell* DFG_OPERATION operationCreateThisInlined(ExecState* exec, JSCell* prototype, JSCell* constructor)
+{
+return createThis(exec, prototype, static_castJSFunction*(constructor));
+}
+
JSCell* DFG_OPERATION operationNewObject(ExecState* exec)
{
return constructEmptyObject(exec);
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.h (99501 => 99502)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.h 2011-11-08 00:33:20 UTC (rev 99501)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.h
[webkit-changes] [99503] branches/chromium/912/Source
Title: [99503] branches/chromium/912/Source
Revision 99503
Author vange...@chromium.org
Date 2011-11-07 16:42:30 -0800 (Mon, 07 Nov 2011)
Log Message
Merge 98185 - [chromium] Make setVisibility extension- and thread-correct
https://bugs.webkit.org/show_bug.cgi?id=70635
Reviewed by Kenneth Russell.
Source/WebCore:
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setVisible):
Source/WebKit/chromium:
* public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::setVisibilityCHROMIUM):
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DPrivate.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):
TBR=nd...@chromium.org
Review URL: http://codereview.chromium.org/8479052
Modified Paths
branches/chromium/912/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h
branches/chromium/912/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
branches/chromium/912/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
branches/chromium/912/Source/WebKit/chromium/public/WebGraphicsContext3D.h
branches/chromium/912/Source/WebKit/chromium/src/Extensions3DChromium.cpp
branches/chromium/912/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
branches/chromium/912/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h
branches/chromium/912/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h
Diff
Modified: branches/chromium/912/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h (99502 => 99503)
--- branches/chromium/912/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h 2011-11-08 00:37:33 UTC (rev 99502)
+++ branches/chromium/912/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h 2011-11-08 00:42:30 UTC (rev 99503)
@@ -69,6 +69,9 @@
void* mapTexSubImage2DCHROMIUM(unsigned target, int level, int xoffset, int yoffset, int width, int height, unsigned format, unsigned type, unsigned access);
void unmapTexSubImage2DCHROMIUM(const void*);
+// GL_CHROMIUM_set_visibility
+void setVisibilityCHROMIUM(bool);
+
// GL_CHROMIUM_swapbuffers_complete_callback
class SwapBuffersCompleteCallbackCHROMIUM {
public:
Modified: branches/chromium/912/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (99502 => 99503)
--- branches/chromium/912/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-11-08 00:37:33 UTC (rev 99502)
+++ branches/chromium/912/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-11-08 00:42:30 UTC (rev 99503)
@@ -166,6 +166,10 @@
if (m_capabilities.usingMapSub)
extensions-ensureEnabled(GL_CHROMIUM_map_sub);
+m_capabilities.usingSetVisibility = extensions-supports(GL_CHROMIUM_set_visibility);
+if (m_capabilities.usingSetVisibility)
+extensions-ensureEnabled(GL_CHROMIUM_set_visibility);
+
GLC(m_context.get(), m_context-getIntegerv(GraphicsContext3D::MAX_TEXTURE_SIZE, m_capabilities.maxTextureSize));
m_capabilities.bestTextureFormat = PlatformColor::bestTextureFormat(m_context.get());
@@ -212,6 +216,16 @@
LOG_ERROR(GL command failed: File: %s\n\tLine %d\n\tcommand: %s, error %x\n, file, line, command, static_castint(error));
}
+void LayerRendererChromium::setVisible(bool visible)
+{
+if (!visible)
+releaseRenderSurfaceTextures();
+if (m_capabilities.usingSetVisibility) {
+Extensions3DChromium* extensions3DChromium = static_castExtensions3DChromium*(m_context-getExtensions());
+extensions3DChromium-setVisibilityCHROMIUM(visible);
+}
+}
+
void LayerRendererChromium::releaseRenderSurfaceTextures()
{
m_renderSurfaceTextureManager-evictAndDeleteAllTextures(m_renderSurfaceTextureAllocator.get());
Modified: branches/chromium/912/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h (99502 => 99503)
--- branches/chromium/912/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-11-08 00:37:33 UTC (rev 99502)
+++ branches/chromium/912/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-11-08 00:42:30 UTC (rev 99503)
@@ -144,7 +144,7 @@
bool isContextLost();
-void releaseRenderSurfaceTextures();
+void setVisible(bool);
GC3Denum bestTextureFormat();
@@ -169,6 +169,8 @@
[webkit-changes] [99504] branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc
Title: [99504] branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc
Revision 99504
Author vange...@chromium.org
Date 2011-11-07 16:44:10 -0800 (Mon, 07 Nov 2011)
Log Message
Merge 98392 - LayerRendererChromium::setVisible called needlessly without a visibility change
https://bugs.webkit.org/show_bug.cgi?id=70766
Patch by Michal Mocny mmo...@google.com on 2011-10-25
Reviewed by Kenneth Russell.
Check that visibility has actually changed before calling LayerRendererChromium::setVisible
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
TBR=commit-qu...@webkit.org
Review URL: http://codereview.chromium.org/8491030
Modified Paths
branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
Diff
Modified: branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (99503 => 99504)
--- branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2011-11-08 00:42:30 UTC (rev 99503)
+++ branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2011-11-08 00:44:10 UTC (rev 99504)
@@ -47,6 +47,7 @@
: m_sourceFrameNumber(-1)
, m_frameNumber(0)
, m_settings(settings)
+, m_visible(true)
{
ASSERT(CCProxy::isImplThread());
}
@@ -122,6 +123,10 @@
void CCLayerTreeHostImpl::setVisible(bool visible)
{
+if (m_visible == visible)
+return;
+m_visible = visible;
+
if (m_layerRenderer)
m_layerRenderer-setVisible(visible);
}
Modified: branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h (99503 => 99504)
--- branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h 2011-11-08 00:42:30 UTC (rev 99503)
+++ branches/chromium/912/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h 2011-11-08 00:44:10 UTC (rev 99504)
@@ -97,6 +97,7 @@
RefPtrCCLayerImpl m_rootLayerImpl;
CCSettings m_settings;
IntSize m_viewportSize;
+bool m_visible;
};
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99505] trunk
Title: [99505] trunk
Revision 99505
Author aba...@webkit.org
Date 2011-11-07 16:51:28 -0800 (Mon, 07 Nov 2011)
Log Message
WebWorkers fail with document.domain set when accessing from subdomain
https://bugs.webkit.org/show_bug.cgi?id=67978
Reviewed by Sam Weinig.
Source/WebCore:
Workers should ignore document.domain when deciding which URLs a
document can request, just like XMLHttpRequest and every other API.
Test: http/tests/workers/worker-document-domain-security.html
* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL):
LayoutTests:
Test that a document can still create same-origin workers after setting
document.domain.
* http/tests/workers/worker-document-domain-security-expected.txt: Added.
* http/tests/workers/worker-document-domain-security.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/AbstractWorker.cpp
Added Paths
trunk/LayoutTests/http/tests/workers/worker-document-domain-security-expected.txt
trunk/LayoutTests/http/tests/workers/worker-document-domain-security.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99504 => 99505)
--- trunk/LayoutTests/ChangeLog 2011-11-08 00:44:10 UTC (rev 99504)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 00:51:28 UTC (rev 99505)
@@ -1,3 +1,16 @@
+2011-11-07 Adam Barth aba...@webkit.org
+
+WebWorkers fail with document.domain set when accessing from subdomain
+https://bugs.webkit.org/show_bug.cgi?id=67978
+
+Reviewed by Sam Weinig.
+
+Test that a document can still create same-origin workers after setting
+document.domain.
+
+* http/tests/workers/worker-document-domain-security-expected.txt: Added.
+* http/tests/workers/worker-document-domain-security.html: Added.
+
2011-11-07 Tony Chang t...@chromium.org
Fix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html
Added: trunk/LayoutTests/http/tests/workers/worker-document-domain-security-expected.txt (0 => 99505)
--- trunk/LayoutTests/http/tests/workers/worker-document-domain-security-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/workers/worker-document-domain-security-expected.txt 2011-11-08 00:51:28 UTC (rev 99505)
@@ -0,0 +1,3 @@
+PASS: Got security error.
+PASS: No exception throw when accessing a same-origin URL after setting document.domain.
+
Added: trunk/LayoutTests/http/tests/workers/worker-document-domain-security.html (0 => 99505)
--- trunk/LayoutTests/http/tests/workers/worker-document-domain-security.html (rev 0)
+++ trunk/LayoutTests/http/tests/workers/worker-document-domain-security.html 2011-11-08 00:51:28 UTC (rev 99505)
@@ -0,0 +1,34 @@
+html
+body
+div id=result/div
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function log(message)
+{
+document.getElementById(result).innerHTML += message + br;
+}
+
+document.domain = 0.0.1;
+
+try {
+new Worker(http://0.0.1/worker.js);
+log(FAIL: No exception thrown when accessing a worker from another domain.);
+} catch (error) {
+if (error.code == 18)
+log(PASS: Got security error.);
+else
+log(FAIL: Got error code + error.code + . Expected error code 18.);
+}
+
+try {
+new Worker(resources/non-existent.js);
+log(PASS: No exception throw when accessing a same-origin URL after setting document.domain.);
+} catch (error) {
+log(FAIL: Got error code + error.code + .);
+}
+
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (99504 => 99505)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 00:44:10 UTC (rev 99504)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 00:51:28 UTC (rev 99505)
@@ -1,3 +1,18 @@
+2011-11-07 Adam Barth aba...@webkit.org
+
+WebWorkers fail with document.domain set when accessing from subdomain
+https://bugs.webkit.org/show_bug.cgi?id=67978
+
+Reviewed by Sam Weinig.
+
+Workers should ignore document.domain when deciding which URLs a
+document can request, just like XMLHttpRequest and every other API.
+
+Test: http/tests/workers/worker-document-domain-security.html
+
+* workers/AbstractWorker.cpp:
+(WebCore::AbstractWorker::resolveURL):
+
2011-11-07 Scott Graham scot...@chromium.org
Allow gamepad API to be enabled at runtime
Modified: trunk/Source/WebCore/workers/AbstractWorker.cpp (99504 => 99505)
--- trunk/Source/WebCore/workers/AbstractWorker.cpp 2011-11-08 00:44:10 UTC (rev 99504)
+++ trunk/Source/WebCore/workers/AbstractWorker.cpp 2011-11-08 00:51:28 UTC (rev 99505)
@@ -80,10 +80,11 @@
return KURL();
}
-if (!scriptExecutionContext()-securityOrigin()-canAccess(SecurityOrigin::create(scriptURL).get())) {
+if (!scriptExecutionContext()-securityOrigin()-canRequest(scriptURL)) {
ec = SECURITY_ERR;
return KURL();
}
+
return scriptURL;
}
[webkit-changes] [99506] trunk/Source/WebCore
Title: [99506] trunk/Source/WebCore Revision 99506 Author aba...@webkit.org Date 2011-11-07 16:57:10 -0800 (Mon, 07 Nov 2011) Log Message addMessage's last few arguments should be optional https://bugs.webkit.org/show_bug.cgi?id=70946 Reviewed by Darin Adler. As requested by Darin Adler. I wanted to call this method addMessage, but the compiler was unhappy locating the overload on ScriptExecutionContext when Document had an override too. Changing the name to addConsoleMessage made all the code happier. * dom/Document.cpp: (WebCore::Document::processHttpEquiv): * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addMessage): * dom/ScriptExecutionContext.h: * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): * html/parser/XSSAuditor.cpp: (WebCore::XSSAuditor::filterToken): * loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): * page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::reportViolation): (WebCore::ContentSecurityPolicy::logUnrecognizedDirective): * page/EventSource.cpp: (WebCore::EventSource::didReceiveResponse): * webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::looping): (WebCore::AudioBufferSourceNode::setLooping): * webaudio/AudioContext.cpp: (WebCore::AudioContext::createLowPass2Filter): (WebCore::AudioContext::createHighPass2Filter): * xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/ScriptExecutionContext.cpp trunk/Source/WebCore/dom/ScriptExecutionContext.h trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp trunk/Source/WebCore/html/parser/XSSAuditor.cpp trunk/Source/WebCore/loader/ImageLoader.cpp trunk/Source/WebCore/page/ContentSecurityPolicy.cpp trunk/Source/WebCore/page/EventSource.cpp trunk/Source/WebCore/webaudio/AudioBufferSourceNode.cpp trunk/Source/WebCore/webaudio/AudioContext.cpp trunk/Source/WebCore/xml/XMLHttpRequest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (99505 => 99506) --- trunk/Source/WebCore/ChangeLog 2011-11-08 00:51:28 UTC (rev 99505) +++ trunk/Source/WebCore/ChangeLog 2011-11-08 00:57:10 UTC (rev 99506) @@ -1,5 +1,42 @@ 2011-11-07 Adam Barth aba...@webkit.org +addMessage's last few arguments should be optional +https://bugs.webkit.org/show_bug.cgi?id=70946 + +Reviewed by Darin Adler. + +As requested by Darin Adler. I wanted to call this method addMessage, +but the compiler was unhappy locating the overload on +ScriptExecutionContext when Document had an override too. Changing the +name to addConsoleMessage made all the code happier. + +* dom/Document.cpp: +(WebCore::Document::processHttpEquiv): +* dom/ScriptExecutionContext.cpp: +(WebCore::ScriptExecutionContext::addMessage): +* dom/ScriptExecutionContext.h: +* html/canvas/CanvasRenderingContext2D.cpp: +(WebCore::CanvasRenderingContext2D::getImageData): +* html/parser/XSSAuditor.cpp: +(WebCore::XSSAuditor::filterToken): +* loader/ImageLoader.cpp: +(WebCore::ImageLoader::notifyFinished): +* page/ContentSecurityPolicy.cpp: +(WebCore::ContentSecurityPolicy::reportViolation): +(WebCore::ContentSecurityPolicy::logUnrecognizedDirective): +* page/EventSource.cpp: +(WebCore::EventSource::didReceiveResponse): +* webaudio/AudioBufferSourceNode.cpp: +(WebCore::AudioBufferSourceNode::looping): +(WebCore::AudioBufferSourceNode::setLooping): +* webaudio/AudioContext.cpp: +(WebCore::AudioContext::createLowPass2Filter): +(WebCore::AudioContext::createHighPass2Filter): +* xml/XMLHttpRequest.cpp: +(WebCore::reportUnsafeUsage): + +2011-11-07 Adam Barth aba...@webkit.org + WebWorkers fail with document.domain set when accessing from subdomain https://bugs.webkit.org/show_bug.cgi?id=67978 Modified: trunk/Source/WebCore/dom/Document.cpp (99505 => 99506) --- trunk/Source/WebCore/dom/Document.cpp 2011-11-08 00:51:28 UTC (rev 99505) +++ trunk/Source/WebCore/dom/Document.cpp 2011-11-08 00:57:10 UTC (rev 99506) @@ -2601,7 +2601,7 @@ frame-navigationScheduler()-scheduleLocationChange(securityOrigin(), blankURL(), String()); DEFINE_STATIC_LOCAL(String, consoleMessage, (Refused to display document because display forbidden by X-Frame-Options.\n)); -frame-domWindow()-console()-addMessage(JSMessageSource, LogMessageType, ErrorMessageLevel, consoleMessage, 1, String()); +addConsoleMessage(JSMessageSource, LogMessageType, ErrorMessageLevel, consoleMessage); } } } else if (equalIgnoringCase(equiv, x-webkit-csp)) Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.cpp (99505 => 99506) ---
[webkit-changes] [99507] trunk/Source/WebCore
Title: [99507] trunk/Source/WebCore
Revision 99507
Author dslo...@google.com
Date 2011-11-07 16:59:33 -0800 (Mon, 07 Nov 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=71534
[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.
Reviewed by David Levin.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
* html/canvas/DataView.cpp:
* html/canvas/DataView.h:
* html/canvas/Float32Array.h:
* html/canvas/Float64Array.h:
* html/canvas/Int16Array.h:
* html/canvas/Int32Array.h:
* html/canvas/Int8Array.h:
* html/canvas/TypedArrayBase.h:
* html/canvas/Uint16Array.h:
* html/canvas/Uint32Array.h:
* html/canvas/Uint8Array.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/html/canvas/DataView.cpp
trunk/Source/WebCore/html/canvas/DataView.h
trunk/Source/WebCore/html/canvas/Float32Array.h
trunk/Source/WebCore/html/canvas/Float64Array.h
trunk/Source/WebCore/html/canvas/Int16Array.h
trunk/Source/WebCore/html/canvas/Int32Array.h
trunk/Source/WebCore/html/canvas/Int8Array.h
trunk/Source/WebCore/html/canvas/TypedArrayBase.h
trunk/Source/WebCore/html/canvas/Uint16Array.h
trunk/Source/WebCore/html/canvas/Uint32Array.h
trunk/Source/WebCore/html/canvas/Uint8Array.h
Property Changed
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/WebCore/ChangeLog (99506 => 99507)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 00:59:33 UTC (rev 99507)
@@ -1,3 +1,25 @@
+2011-11-07 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=71534
+[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.
+
+Reviewed by David Levin.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorV8.pm:
+* html/canvas/DataView.cpp:
+* html/canvas/DataView.h:
+* html/canvas/Float32Array.h:
+* html/canvas/Float64Array.h:
+* html/canvas/Int16Array.h:
+* html/canvas/Int32Array.h:
+* html/canvas/Int8Array.h:
+* html/canvas/TypedArrayBase.h:
+* html/canvas/Uint16Array.h:
+* html/canvas/Uint32Array.h:
+* html/canvas/Uint8Array.h:
+
2011-11-07 Adam Barth aba...@webkit.org
addMessage's last few arguments should be optional
Property changes on: trunk/Source/WebCore/ChangeLog
___
Deleted: svn:executable
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (99506 => 99507)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-08 00:59:33 UTC (rev 99507)
@@ -2216,6 +2216,14 @@
push(@implContent, ;\n}\n);
}
+if ($parentClassName eq JSArrayBufferView) {
+push(@implContent, END);
+void ${implType}::neuterBinding(ScriptExecutionContext*) {
+}
+END
+}
+
+
push(@implContent, \n}\n);
my $conditionalString = GenerateConditionalString($dataNode);
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (99506 => 99507)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-08 00:59:33 UTC (rev 99507)
@@ -2476,6 +2476,16 @@
GenerateToV8Converters($dataNode, $interfaceName, $className, $nativeType, $serializedAttribute);
+if (IsSubType($dataNode, ArrayBufferView) not $interfaceName eq ArrayBufferView) {
+push(@implContent, END);
+void ${nativeType}::neuterBinding(ScriptExecutionContext*) {
+v8::Handlev8::Value bound = toV8(this);
+v8::Handlev8::Object object(bound.Asv8::Object());
+object-SetIndexedPropertiesToExternalArrayData(0, v8::kExternalByteArray, 0);
+}
+END
+}
+
push(@implContent, END);
void ${className}::derefObject(void* object)
Modified: trunk/Source/WebCore/html/canvas/DataView.cpp (99506 => 99507)
--- trunk/Source/WebCore/html/canvas/DataView.cpp 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/html/canvas/DataView.cpp 2011-11-08 00:59:33 UTC (rev 99507)
@@ -242,9 +242,4 @@
neuterBinding(context);
}
-void DataView::neuterBinding(ScriptExecutionContext*)
-{
-// FIXME https://bugs.webkit.org/show_bug.cgi?id=71534
}
-
-}
Modified: trunk/Source/WebCore/html/canvas/DataView.h (99506 => 99507)
--- trunk/Source/WebCore/html/canvas/DataView.h 2011-11-08 00:57:10 UTC (rev 99506)
+++ trunk/Source/WebCore/html/canvas/DataView.h 2011-11-08 00:59:33 UTC (rev 99507)
@@ -74,7 +74,7 @@
protected:
virtual void neuter(ScriptExecutionContext*);
-
[webkit-changes] [99508] trunk/Source/WebCore
Title: [99508] trunk/Source/WebCore
Revision 99508
Author m...@apple.com
Date 2011-11-07 17:16:35 -0800 (Mon, 07 Nov 2011)
Log Message
rdar://problem/10405215 REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71743
Reviewed by Beth Dakin.
* page/FrameView.cpp:
(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99507 => 99508)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 00:59:33 UTC (rev 99507)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 01:16:35 UTC (rev 99508)
@@ -1,3 +1,13 @@
+2011-11-07 Dan Bernstein m...@apple.com
+
+rdar://problem/10405215 REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
+https://bugs.webkit.org/show_bug.cgi?id=71743
+
+Reviewed by Beth Dakin.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.
+
2011-11-07 Dmitry Lomov dslo...@google.com
https://bugs.webkit.org/show_bug.cgi?id=71534
Modified: trunk/Source/WebCore/page/FrameView.cpp (99507 => 99508)
--- trunk/Source/WebCore/page/FrameView.cpp 2011-11-08 00:59:33 UTC (rev 99507)
+++ trunk/Source/WebCore/page/FrameView.cpp 2011-11-08 01:16:35 UTC (rev 99508)
@@ -2429,6 +2429,8 @@
bool FrameView::isOnActivePage() const
{
+if (!m_frame)
+return false;
if (m_frame-view() != this)
return false;
if (Document* document = m_frame-document())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99509] trunk/Source
Title: [99509] trunk/Source
Revision 99509
Author aba...@webkit.org
Date 2011-11-07 17:37:47 -0800 (Mon, 07 Nov 2011)
Log Message
Move DomainRelaxationForbidden scheme registry to SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=71750
Reviewed by Eric Seidel.
Source/WebCore:
As stated in the FIXME, scheme registries belong in SchemeRegistry, not
in SecurityOrigin.
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::setDomain):
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:
* platform/SchemeRegistry.cpp:
(WebCore::schemesForbiddenFromDomainRelaxation):
(WebCore::SchemeRegistry::setDomainRelaxationForbiddenForURLScheme):
(WebCore::SchemeRegistry::isDomainRelaxationForbiddenForURLScheme):
* platform/SchemeRegistry.h:
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDomainRelaxationForbidden):
Source/WebKit/mac:
* WebView/WebView.mm:
(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
Source/WebKit/qt:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):
Source/WebKit/win:
* WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):
Source/WebKit2:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setDomainRelaxationForbiddenForURLScheme):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/page/SecurityOrigin.h
trunk/Source/WebCore/platform/SchemeRegistry.cpp
trunk/Source/WebCore/platform/SchemeRegistry.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99508 => 99509)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 01:16:35 UTC (rev 99508)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 01:37:47 UTC (rev 99509)
@@ -1,3 +1,24 @@
+2011-11-07 Adam Barth aba...@webkit.org
+
+Move DomainRelaxationForbidden scheme registry to SchemeRegistry
+https://bugs.webkit.org/show_bug.cgi?id=71750
+
+Reviewed by Eric Seidel.
+
+As stated in the FIXME, scheme registries belong in SchemeRegistry, not
+in SecurityOrigin.
+
+* WebCore.exp.in:
+* dom/Document.cpp:
+(WebCore::Document::setDomain):
+* page/SecurityOrigin.cpp:
+* page/SecurityOrigin.h:
+* platform/SchemeRegistry.cpp:
+(WebCore::schemesForbiddenFromDomainRelaxation):
+(WebCore::SchemeRegistry::setDomainRelaxationForbiddenForURLScheme):
+(WebCore::SchemeRegistry::isDomainRelaxationForbiddenForURLScheme):
+* platform/SchemeRegistry.h:
+
2011-11-07 Dan Bernstein m...@apple.com
rdar://problem/10405215 REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
Modified: trunk/Source/WebCore/WebCore.exp.in (99508 => 99509)
--- trunk/Source/WebCore/WebCore.exp.in 2011-11-08 01:16:35 UTC (rev 99508)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-11-08 01:37:47 UTC (rev 99509)
@@ -366,6 +366,7 @@
__ZN7WebCore14SchemeRegistry25registerURLSchemeAsSecureERKN3WTF6StringE
__ZN7WebCore14SchemeRegistry32registerURLSchemeAsEmptyDocumentERKN3WTF6StringE
__ZN7WebCore14SchemeRegistry34shouldLoadURLSchemeAsEmptyDocumentERKN3WTF6StringE
+__ZN7WebCore14SchemeRegistry40setDomainRelaxationForbiddenForURLSchemeEbRKN3WTF6StringE
__ZN7WebCore14SchemeRegistry62registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsingERKN3WTF6StringE
__ZN7WebCore14SchemeRegistry58registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsingERKN3WTF6StringE
__ZN7WebCore14ScrollableArea16handleWheelEventERKNS_18PlatformWheelEventE
@@ -390,7 +391,6 @@
__ZN7WebCore14SecurityOrigin28createFromDatabaseIdentifierERKN3WTF6StringE
__ZN7WebCore14SecurityOrigin29addOriginAccessWhitelistEntryERKS0_RKN3WTF6StringES6_b
__ZN7WebCore14SecurityOrigin32removeOriginAccessWhitelistEntryERKS0_RKN3WTF6StringES6_b
-__ZN7WebCore14SecurityOrigin40setDomainRelaxationForbiddenForURLSchemeEbRKN3WTF6StringE
__ZN7WebCore14SecurityOrigin6createERKN3WTF6StringES4_i
__ZN7WebCore14SecurityOrigin6createERKNS_4KURLEb
__ZN7WebCore14StorageTracker7originsERN3WTF6VectorINS1_6RefPtrINS_14SecurityOriginEEELm0EEE
Modified: trunk/Source/WebCore/dom/Document.cpp (99508 => 99509)
--- trunk/Source/WebCore/dom/Document.cpp 2011-11-08 01:16:35 UTC (rev 99508)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-11-08 01:37:47 UTC (rev 99509)
@@ -3597,7 +3597,7 @@
void Document::setDomain(const String newDomain, ExceptionCode ec)
{
-if
[webkit-changes] [99510] trunk
Title: [99510] trunk
Revision 99510
Author hara...@chromium.org
Date 2011-11-07 18:08:06 -0800 (Mon, 07 Nov 2011)
Log Message
Fixed wrong test results of fast/js/custom-constructors.html
https://bugs.webkit.org/show_bug.cgi?id=71669
Reviewed by Darin Adler.
According to the HTMLOptionElement spec
(http://dev.w3.org/html5/spec/the-button-element.html#the-option-element),
'text', 'label' and 'value' have neither [TreatUndefinedAs=EmptyString]
nor [TreatNullAs=EmptyString]. Thus, an undefined value should be
converted to a string undefined and a null value should be
converted to a string null, following the step 3 of the IDL
conversion spec (http://dev.w3.org/2006/webapi/WebIDL/#es-DOMString).
Source/WebCore:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::constructHTMLOptionElement): Removed isUndefined() check from 'text' and 'value' since the spec does not have [TreatUndefinedAs=EmptyString].
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.
* html/HTMLOptionElement.idl: Removed [ConvertNullToNullString] from 'text', 'label' and 'value' since the spec does not have [TreatNullAs=EmptyString].
LayoutTests:
* fast/dom/element-attribute-js-null-expected.txt: Fixed the test result.
* fast/dom/element-attribute-js-null.html: Ditto.
* fast/js/custom-constructors-expected.txt: Ditto.
* fast/js/script-tests/custom-constructors.js: Ditto.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt
trunk/LayoutTests/fast/dom/element-attribute-js-null.html
trunk/LayoutTests/fast/js/custom-constructors-expected.txt
trunk/LayoutTests/fast/js/script-tests/custom-constructors.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSOptionConstructor.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionElementConstructor.cpp
trunk/Source/WebCore/html/HTMLOptionElement.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (99509 => 99510)
--- trunk/LayoutTests/ChangeLog 2011-11-08 01:37:47 UTC (rev 99509)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 02:08:06 UTC (rev 99510)
@@ -1,3 +1,23 @@
+2011-11-07 Kentaro Hara hara...@chromium.org
+
+Fixed wrong test results of fast/js/custom-constructors.html
+https://bugs.webkit.org/show_bug.cgi?id=71669
+
+Reviewed by Darin Adler.
+
+According to the HTMLOptionElement spec
+(http://dev.w3.org/html5/spec/the-button-element.html#the-option-element),
+'text', 'label' and 'value' have neither [TreatUndefinedAs=EmptyString]
+nor [TreatNullAs=EmptyString]. Thus, an undefined value should be
+converted to a string undefined and a null value should be
+converted to a string null, following the step 3 of the IDL
+conversion spec (http://dev.w3.org/2006/webapi/WebIDL/#es-DOMString).
+
+* fast/dom/element-attribute-js-null-expected.txt: Fixed the test result.
+* fast/dom/element-attribute-js-null.html: Ditto.
+* fast/js/custom-constructors-expected.txt: Ditto.
+* fast/js/script-tests/custom-constructors.js: Ditto.
+
2011-11-07 Adam Barth aba...@webkit.org
WebWorkers fail with document.domain set when accessing from subdomain
Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt (99509 => 99510)
--- trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt 2011-11-08 01:37:47 UTC (rev 99509)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt 2011-11-08 02:08:06 UTC (rev 99510)
@@ -184,9 +184,9 @@
TEST SUCCEEDED: The value was the empty string. [tested HTMLOptGroupElement.label]
-TEST SUCCEEDED: The value was the empty string. [tested HTMLOptionElement.text]
-TEST SUCCEEDED: The value was the empty string. [tested HTMLOptionElement.label]
-TEST SUCCEEDED: The value was the empty string. [tested HTMLOptionElement.value]
+TEST SUCCEEDED: The value was the string 'null'. [tested HTMLOptionElement.text]
+TEST SUCCEEDED: The value was the string 'null'. [tested HTMLOptionElement.label]
+TEST SUCCEEDED: The value was the string 'null'. [tested HTMLOptionElement.value]
TEST SUCCEEDED: The value was the empty string. [tested HTMLParagraphElement.align]
Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null.html (99509 => 99510)
--- trunk/LayoutTests/fast/dom/element-attribute-js-null.html 2011-11-08 01:37:47 UTC (rev 99509)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null.html 2011-11-08 02:08:06 UTC (rev 99510)
@@ -445,9 +445,9 @@
type: 'HTMLOptionElement',
elementToUse: document.createElement('option'),
attributes: [
-{name: 'text', expectedNull: ''},
-{name: 'label', expectedNull: ''},
-{name: 'value', expectedNull: ''}
+{name: 'text', expectedNull: 'null'},
+{name:
[webkit-changes] [99512] trunk/Tools
Title: [99512] trunk/Tools Revision 99512 Author wangxian...@chromium.org Date 2011-11-07 18:14:56 -0800 (Mon, 07 Nov 2011) Log Message Add myself as a committer. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (99511 => 99512) --- trunk/Tools/ChangeLog 2011-11-08 02:11:06 UTC (rev 99511) +++ trunk/Tools/ChangeLog 2011-11-08 02:14:56 UTC (rev 99512) @@ -1,3 +1,9 @@ +2011-11-07 Xianzhu Wang wangxian...@chromium.org + +Added myself as a committer. + +* Scripts/webkitpy/common/config/committers.py: + 2011-11-07 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r99470. Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (99511 => 99512) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-11-08 02:11:06 UTC (rev 99511) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-11-08 02:14:56 UTC (rev 99512) @@ -117,7 +117,6 @@ Contributor(Tamas Czene, [tcz...@inf.u-szeged.hu, czene.ta...@stud.u-szeged.hu], tczene), Contributor(Tom Zakrajsek, t...@codeaurora.org, tomz), Contributor(Wyatt Carss, [wca...@chromium.org, wca...@google.com], wcarss), -Contributor(Xianzhu Wang, [wangxian...@chromium.org, phnix...@gmail.com, wangxian...@google.com], wangxianzhu), Contributor(Zoltan Arvai, zar...@inf.u-szeged.hu, azbest_hu), Contributor(Zsolt Feher, fehe...@inf.u-szeged.hu, Smith), ] @@ -305,6 +304,7 @@ Committer(Vsevolod Vlasov, vse...@chromium.org), Committer(William Siegrist, wsiegr...@apple.com, wms), Committer(W. James MacLean, wjmacl...@chromium.org, wjmaclean), +Committer(Xianzhu Wang, [wangxian...@chromium.org, phnix...@gmail.com, wangxian...@google.com], wangxianzhu), Committer(Xiaomei Ji, x...@chromium.org, xji), Committer(Yael Aharon, yael.aha...@nokia.com, yael), Committer(Yaar Schnitman, [y...@chromium.org, y...@google.com]), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99513] trunk
Title: [99513] trunk
Revision 99513
Author ar...@webkit.org
Date 2011-11-07 18:25:20 -0800 (Mon, 07 Nov 2011)
Log Message
use strict can not contain escape sequences or line continuation
https://bugs.webkit.org/show_bug.cgi?id=71532
Reviewed by Darin Adler.
Source/_javascript_Core:
Store the actual literal length (before the escapes and line
continuation are encoded) while parsing the directive and use it
for the directive comparison.
* parser/Parser.cpp:
(JSC::Parser::parseSourceElements):
(JSC::Parser::parseStatement):
* parser/Parser.h:
LayoutTests:
* fast/js/basic-strict-mode-expected.txt:
* fast/js/script-tests/basic-strict-mode.js:
(testLineContinuation): Added.
(testEscapeSequence): Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/basic-strict-mode-expected.txt
trunk/LayoutTests/fast/js/script-tests/basic-strict-mode.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/parser/Parser.h
Diff
Modified: trunk/LayoutTests/ChangeLog (99512 => 99513)
--- trunk/LayoutTests/ChangeLog 2011-11-08 02:14:56 UTC (rev 99512)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 02:25:20 UTC (rev 99513)
@@ -1,3 +1,15 @@
+2011-11-07 Ariya Hidayat ar...@sencha.com
+
+use strict can not contain escape sequences or line continuation
+https://bugs.webkit.org/show_bug.cgi?id=71532
+
+Reviewed by Darin Adler.
+
+* fast/js/basic-strict-mode-expected.txt:
+* fast/js/script-tests/basic-strict-mode.js:
+(testLineContinuation): Added.
+(testEscapeSequence): Added.
+
2011-11-07 Kentaro Hara hara...@chromium.org
Fixed wrong test results of fast/js/custom-constructors.html
Modified: trunk/LayoutTests/fast/js/basic-strict-mode-expected.txt (99512 => 99513)
--- trunk/LayoutTests/fast/js/basic-strict-mode-expected.txt 2011-11-08 02:14:56 UTC (rev 99512)
+++ trunk/LayoutTests/fast/js/basic-strict-mode-expected.txt 2011-11-08 02:25:20 UTC (rev 99513)
@@ -8,6 +8,8 @@
PASS testThis.call(true) is true
PASS testThis.call(false) is false
PASS testThis.call(undefined) is undefined
+PASS testLineContinuation.call(undefined) === undefined is false
+PASS testEscapeSequence.call(undefined) === undefined is false
PASS testThis.call('a string') is 'a string'
PASS testThisDotAccess.call('a string') is 'a string'.length
PASS testThisDotAccess.call(null) threw exception TypeError: 'null' is not an object (evaluating 'this.length').
Modified: trunk/LayoutTests/fast/js/script-tests/basic-strict-mode.js (99512 => 99513)
--- trunk/LayoutTests/fast/js/script-tests/basic-strict-mode.js 2011-11-08 02:14:56 UTC (rev 99512)
+++ trunk/LayoutTests/fast/js/script-tests/basic-strict-mode.js 2011-11-08 02:25:20 UTC (rev 99513)
@@ -20,12 +20,23 @@
shouldThrow(str);
shouldThrow((function(){ + str + }));
}
+function testLineContinuation() {
+use stric\
+t;
+return this;
+}
+function testEscapeSequence() {
+use\u0020strict;
+return this;
+}
shouldBe(testThis.call(null), null);
shouldBe(testThis.call(1), 1);
shouldBe(testThis.call(true), true);
shouldBe(testThis.call(false), false);
shouldBe(testThis.call(undefined), undefined);
+shouldBeFalse(testLineContinuation.call(undefined) === undefined);
+shouldBeFalse(testEscapeSequence.call(undefined) === undefined);
shouldBe(testThis.call('a string'), 'a string');
shouldBe(testThisDotAccess.call('a string'), 'a string'.length);
shouldThrow(testThisDotAccess.call(null));
Modified: trunk/Source/_javascript_Core/ChangeLog (99512 => 99513)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-08 02:14:56 UTC (rev 99512)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-08 02:25:20 UTC (rev 99513)
@@ -1,3 +1,19 @@
+2011-11-07 Ariya Hidayat ar...@sencha.com
+
+use strict can not contain escape sequences or line continuation
+https://bugs.webkit.org/show_bug.cgi?id=71532
+
+Reviewed by Darin Adler.
+
+Store the actual literal length (before the escapes and line
+continuation are encoded) while parsing the directive and use it
+for the directive comparison.
+
+* parser/Parser.cpp:
+(JSC::Parser::parseSourceElements):
+(JSC::Parser::parseStatement):
+* parser/Parser.h:
+
2011-11-06 Filip Pizlo fpi...@apple.com
DFG operationCreateThis slow path may get the wrong callee in case of inlining
Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (99512 => 99513)
--- trunk/Source/_javascript_Core/parser/Parser.cpp 2011-11-08 02:14:56 UTC (rev 99512)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp 2011-11-08 02:25:20 UTC (rev 99513)
@@ -129,17 +129,20 @@
template Parser::SourceElementsMode mode, class TreeBuilder TreeSourceElements Parser::parseSourceElements(TreeBuilder context)
{
+const unsigned lengthOfUseStrictLiteral = 12; // use strict.length
TreeSourceElements sourceElements =
[webkit-changes] [99514] trunk
Title: [99514] trunk
Revision 99514
Author cfleiz...@apple.com
Date 2011-11-07 18:25:59 -0800 (Mon, 07 Nov 2011)
Log Message
REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
https://bugs.webkit.org/show_bug.cgi?id=71421
Reviewed by Ryosuke Niwa.
Source/WebCore:
Remove an assert that was added by r99035. It was added based on a comment in the code, but not tested.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectOption):
LayoutTests:
Re-enable test after removing an erroneous assert.
* platform/mac/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLSelectElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (99513 => 99514)
--- trunk/LayoutTests/ChangeLog 2011-11-08 02:25:20 UTC (rev 99513)
+++ trunk/LayoutTests/ChangeLog 2011-11-08 02:25:59 UTC (rev 99514)
@@ -1,3 +1,14 @@
+2011-11-07 Chris Fleizach cfleiz...@apple.com
+
+REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
+https://bugs.webkit.org/show_bug.cgi?id=71421
+
+Reviewed by Ryosuke Niwa.
+
+Re-enable test after removing an erroneous assert.
+
+* platform/mac/test_expectations.txt:
+
2011-11-07 Ariya Hidayat ar...@sencha.com
use strict can not contain escape sequences or line continuation
Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (99513 => 99514)
--- trunk/LayoutTests/platform/mac/test_expectations.txt 2011-11-08 02:25:20 UTC (rev 99513)
+++ trunk/LayoutTests/platform/mac/test_expectations.txt 2011-11-08 02:25:59 UTC (rev 99514)
@@ -31,5 +31,3 @@
BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH
BUGWK6 RELEASE : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TEXT PASS
-
-BUGWK71421 DEBUG : platform/mac/accessibility/select-element-selection-with-optgroups.html = CRASH
Modified: trunk/Source/WebCore/ChangeLog (99513 => 99514)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 02:25:20 UTC (rev 99513)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 02:25:59 UTC (rev 99514)
@@ -1,3 +1,15 @@
+2011-11-07 Chris Fleizach cfleiz...@apple.com
+
+REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
+https://bugs.webkit.org/show_bug.cgi?id=71421
+
+Reviewed by Ryosuke Niwa.
+
+Remove an assert that was added by r99035. It was added based on a comment in the code, but not tested.
+
+* html/HTMLSelectElement.cpp:
+(WebCore::HTMLSelectElement::selectOption):
+
2011-11-07 Emil A Eklund e...@chromium.org
Revert platform and scrolling to ints
Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (99513 => 99514)
--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-11-08 02:25:20 UTC (rev 99513)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-11-08 02:25:59 UTC (rev 99514)
@@ -788,9 +788,7 @@
scrollToSelection();
-if (!usesMenuList())
-ASSERT(!(flags DispatchChangeEvent));
-else {
+if (usesMenuList()) {
m_isProcessingUserDrivenChange = flags UserDriven;
if (flags DispatchChangeEvent)
dispatchChangeEventForMenuList();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99515] trunk/Source/WebCore
Title: [99515] trunk/Source/WebCore
Revision 99515
Author hara...@chromium.org
Date 2011-11-07 18:41:53 -0800 (Mon, 07 Nov 2011)
Log Message
Remove [CustomGetter] IDL for window.Image of V8
https://bugs.webkit.org/show_bug.cgi?id=71739
Reviewed by Adam Barth.
Currently, window.Image uses a custom getter to get the template
of 'HTMLImageElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.
Tests: fast/js/custom-constructors.html
fast/dom/image-object.html
fast/dom/gc-image-element.html
fast/dom/Window/custom-constructors.html
* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
* page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Image of V8. Renamed 'HTMLImageElementConstructor' to 'HTMLImageElementConstructorConstructor' in order to make window.Image use the template of (not 'HTMLImageElement' but) 'HTMLImageElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (99514 => 99515)
--- trunk/Source/WebCore/ChangeLog 2011-11-08 02:25:59 UTC (rev 99514)
+++ trunk/Source/WebCore/ChangeLog 2011-11-08 02:41:53 UTC (rev 99515)
@@ -1,3 +1,23 @@
+2011-11-07 Kentaro Hara hara...@chromium.org
+
+Remove [CustomGetter] IDL for window.Image of V8
+https://bugs.webkit.org/show_bug.cgi?id=71739
+
+Reviewed by Adam Barth.
+
+Currently, window.Image uses a custom getter to get the template
+of 'HTMLImageElementConstructor'. However, this getter does not need to
+be custom and can use a default getter
+'DOMWindowInternal::DOMWindowConstructorGetter'.
+
+Tests: fast/js/custom-constructors.html
+ fast/dom/image-object.html
+ fast/dom/gc-image-element.html
+ fast/dom/Window/custom-constructors.html
+
+* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
+* page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Image of V8. Renamed 'HTMLImageElementConstructor' to 'HTMLImageElementConstructorConstructor' in order to make window.Image use the template of (not 'HTMLImageElement' but) 'HTMLImageElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.
+
2011-11-07 Chris Fleizach cfleiz...@apple.com
REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (99514 => 99515)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2011-11-08 02:25:59 UTC (rev 99514)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2011-11-08 02:41:53 UTC (rev 99515)
@@ -57,7 +57,6 @@
#include V8GCForContextDispose.h
#include V8HiddenPropertyName.h
#include V8HTMLCollection.h
-#include V8HTMLImageElementConstructor.h
#include V8MessagePortCustom.h
#include V8Node.h
#include V8Proxy.h
@@ -225,12 +224,6 @@
info.This()-Set(name, value);
}
-v8::Handlev8::Value V8DOMWindow::ImageAccessorGetter(v8::Localv8::String name, const v8::AccessorInfo info)
-{
-DOMWindow* window = V8DOMWindow::toNative(info.Holder());
-return V8DOMWrapper::getConstructor(V8HTMLImageElementConstructor::info, window);
-}
-
v8::Handlev8::Value V8DOMWindow::addEventListenerCallback(const v8::Arguments args)
{
INC_STATS(DOM.DOMWindow.addEventListener());
Modified: trunk/Source/WebCore/page/DOMWindow.idl (99514 => 99515)
--- trunk/Source/WebCore/page/DOMWindow.idl 2011-11-08 02:25:59 UTC (rev 99514)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2011-11-08 02:41:53 UTC (rev 99515)
@@ -490,7 +490,7 @@
attribute HTMLAllCollectionConstructor HTMLAllCollection;
attribute HTMLUnknownElementConstructor HTMLUnknownElement;
-attribute [CustomGetter] HTMLImageElementConstructor Image; // Usable with new operator
+attribute [JSCCustomGetter] HTMLImageElementConstructorConstructor Image; // Usable with new operator
attribute [JSCCustomGetter] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
attribute CanvasPatternConstructor CanvasPattern;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99516] trunk/Source/JavaScriptCore
Title: [99516] trunk/Source/_javascript_Core
Revision 99516
Author fpi...@apple.com
Date 2011-11-07 19:02:19 -0800 (Mon, 07 Nov 2011)
Log Message
Switch back to 1+1 value profiling buckets, since it didn't help on arewefastyet,
but it appears to help on other benchmarks.
Rubber stamped by Oliver Hunt.
* bytecode/ValueProfile.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/ValueProfile.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99515 => 99516)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-08 02:41:53 UTC (rev 99515)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-08 03:02:19 UTC (rev 99516)
@@ -1,3 +1,12 @@
+2011-11-07 Filip Pizlo fpi...@apple.com
+
+Switch back to 1+1 value profiling buckets, since it didn't help on arewefastyet,
+but it appears to help on other benchmarks.
+
+Rubber stamped by Oliver Hunt.
+
+* bytecode/ValueProfile.h:
+
2011-11-07 Ariya Hidayat ar...@sencha.com
use strict can not contain escape sequences or line continuation
Modified: trunk/Source/_javascript_Core/bytecode/ValueProfile.h (99515 => 99516)
--- trunk/Source/_javascript_Core/bytecode/ValueProfile.h 2011-11-08 02:41:53 UTC (rev 99515)
+++ trunk/Source/_javascript_Core/bytecode/ValueProfile.h 2011-11-08 03:02:19 UTC (rev 99516)
@@ -38,7 +38,7 @@
#if ENABLE(VALUE_PROFILER)
struct ValueProfile {
-static const unsigned logNumberOfBuckets = 3; // 8 buckets
+static const unsigned logNumberOfBuckets = 0; // 1 bucket
static const unsigned numberOfBuckets = 1 logNumberOfBuckets;
static const unsigned numberOfSpecFailBuckets = 1;
static const unsigned bucketIndexMask = numberOfBuckets - 1;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
