[webkit-changes] [213273] trunk/Source/WebCore
Title: [213273] trunk/Source/WebCore Revision 213273 Author carlo...@webkit.org Date 2017-03-02 00:59:12 -0800 (Thu, 02 Mar 2017) Log Message REGRESSION(r213062): [SOUP] UTF-8 filename in Content-Disposition header incorrectly handled since r213062 https://bugs.webkit.org/show_bug.cgi?id=169024 Reviewed by Youenn Fablet. This made test http/tests/download/literal-utf-8.html to start failing. The problem is that I removed the conversion made by String::fromUTF8WithLatin1Fallback that was added in r176930. I removed it because that made fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html to timeout. This patch brings back the String::fromUTF8WithLatin1Fallback call but only when the header string is 8 bit one. Fixes: http/tests/download/literal-utf-8.html * platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::platformSuggestedFilename): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (213272 => 213273) --- trunk/Source/WebCore/ChangeLog 2017-03-02 07:43:41 UTC (rev 213272) +++ trunk/Source/WebCore/ChangeLog 2017-03-02 08:59:12 UTC (rev 213273) @@ -1,3 +1,20 @@ +2017-03-01 Carlos Garcia Campos + +REGRESSION(r213062): [SOUP] UTF-8 filename in Content-Disposition header incorrectly handled since r213062 +https://bugs.webkit.org/show_bug.cgi?id=169024 + +Reviewed by Youenn Fablet. + +This made test http/tests/download/literal-utf-8.html to start failing. The problem is that I removed the +conversion made by String::fromUTF8WithLatin1Fallback that was added in r176930. I removed it because that made +fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html to timeout. This patch brings back +the String::fromUTF8WithLatin1Fallback call but only when the header string is 8 bit one. + +Fixes: http/tests/download/literal-utf-8.html + +* platform/network/soup/ResourceResponseSoup.cpp: +(WebCore::ResourceResponse::platformSuggestedFilename): + 2017-03-01 Alex Christensen Actually fix Windows build. Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (213272 => 213273) --- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2017-03-02 07:43:41 UTC (rev 213272) +++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2017-03-02 08:59:12 UTC (rev 213273) @@ -96,8 +96,13 @@ String ResourceResponse::platformSuggestedFilename() const { +String contentDisposition(httpHeaderField(HTTPHeaderName::ContentDisposition)); +if (contentDisposition.isEmpty()) +return String(); + +if (contentDisposition.is8Bit()) +contentDisposition = String::fromUTF8WithLatin1Fallback(contentDisposition.characters8(), contentDisposition.length()); SoupMessageHeaders* soupHeaders = soup_message_headers_new(SOUP_MESSAGE_HEADERS_RESPONSE); -String contentDisposition(httpHeaderField(HTTPHeaderName::ContentDisposition)); soup_message_headers_append(soupHeaders, "Content-Disposition", contentDisposition.utf8().data()); GRefPtr params; soup_message_headers_get_content_disposition(soupHeaders, nullptr, ¶ms.outPtr()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213274] trunk/Source/WebCore
Title: [213274] trunk/Source/WebCore Revision 213274 Author akl...@apple.com Date 2017-03-02 01:03:41 -0800 (Thu, 02 Mar 2017) Log Message Don't keep dead resources in MemoryCache while under memory pressure. Reviewed by Antti Koivisto. Have CachedResource::deleteIfPossible() remove the resource from the MemoryCache if we're under memory pressure and that was the only thing keeping it alive. This is consistent with the policy where dead resources are evicted from the cache as we come under pressure. * loader/cache/CachedResource.cpp: (WebCore::CachedResource::deleteIfPossible): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/cache/CachedResource.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (213273 => 213274) --- trunk/Source/WebCore/ChangeLog 2017-03-02 08:59:12 UTC (rev 213273) +++ trunk/Source/WebCore/ChangeLog 2017-03-02 09:03:41 UTC (rev 213274) @@ -1,3 +1,19 @@ +2017-03-02 Andreas Kling + +Don't keep dead resources in MemoryCache while under memory pressure. + + +Reviewed by Antti Koivisto. + +Have CachedResource::deleteIfPossible() remove the resource from the MemoryCache +if we're under memory pressure and that was the only thing keeping it alive. + +This is consistent with the policy where dead resources are evicted from the cache +as we come under pressure. + +* loader/cache/CachedResource.cpp: +(WebCore::CachedResource::deleteIfPossible): + 2017-03-01 Carlos Garcia Campos REGRESSION(r213062): [SOUP] UTF-8 filename in Content-Disposition header incorrectly handled since r213062 Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (213273 => 213274) --- trunk/Source/WebCore/loader/cache/CachedResource.cpp 2017-03-02 08:59:12 UTC (rev 213273) +++ trunk/Source/WebCore/loader/cache/CachedResource.cpp 2017-03-02 09:03:41 UTC (rev 213274) @@ -549,6 +549,12 @@ bool CachedResource::deleteIfPossible() { if (canDelete()) { +if (inCache() && MemoryPressureHandler::singleton().isUnderMemoryPressure()) { +MemoryCache::singleton().remove(*this); +// MemoryCache::remove() will call back into deleteIfPossible() and succeed. +// FIXME: This would be less incomprehensible if CachedResource were ref-counted. +return true; +} if (!inCache()) { InspectorInstrumentation::willDestroyCachedResource(*this); delete this; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213275] trunk/Source/JavaScriptCore
Title: [213275] trunk/Source/_javascript_Core Revision 213275 Author tpop...@redhat.com Date 2017-03-02 01:43:18 -0800 (Thu, 02 Mar 2017) Log Message Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals() https://bugs.webkit.org/show_bug.cgi?id=169034 Reviewed by Mark Lam. It should not assign to offset, but compare to offset. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::addStaticGlobals): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (213274 => 213275) --- trunk/Source/_javascript_Core/ChangeLog 2017-03-02 09:03:41 UTC (rev 213274) +++ trunk/Source/_javascript_Core/ChangeLog 2017-03-02 09:43:18 UTC (rev 213275) @@ -1,3 +1,15 @@ +2017-03-02 Tomas Popela + +Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals() +https://bugs.webkit.org/show_bug.cgi?id=169034 + +Reviewed by Mark Lam. + +It should not assign to offset, but compare to offset. + +* runtime/JSGlobalObject.cpp: +(JSC::JSGlobalObject::addStaticGlobals): + 2017-03-01 Alex Christensen Unreviewed, rolling out r213259. Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp (213274 => 213275) --- trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2017-03-02 09:03:41 UTC (rev 213274) +++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2017-03-02 09:43:18 UTC (rev 213275) @@ -1316,7 +1316,7 @@ { ConcurrentJSLocker locker(symbolTable()->m_lock); ScopeOffset offset = symbolTable()->takeNextScopeOffset(locker); -RELEASE_ASSERT(offset = startOffset + i); +RELEASE_ASSERT(offset == startOffset + i); SymbolTableEntry newEntry(VarOffset(offset), global.attributes); newEntry.prepareToWatch(); watchpointSet = newEntry.watchpointSet(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213276] trunk/Source/WebCore
Title: [213276] trunk/Source/WebCore Revision 213276 Author carlo...@webkit.org Date 2017-03-02 03:44:41 -0800 (Thu, 02 Mar 2017) Log Message [GTK] Crash in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired https://bugs.webkit.org/show_bug.cgi?id=166420 Reviewed by Žan Doberšek. This is happening when closing a page that is being inspected. When CoordinatedGraphicsLayer::removeFromParent() is called, the coordinator has already been invalidated, so all its layers were set a nullptr coordinator. I think it's safe to simply handle m_coordinator being nullptr in notifyFlushRequired(). * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Return early if the coordinator is nullptr. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (213275 => 213276) --- trunk/Source/WebCore/ChangeLog 2017-03-02 09:43:18 UTC (rev 213275) +++ trunk/Source/WebCore/ChangeLog 2017-03-02 11:44:41 UTC (rev 213276) @@ -1,3 +1,17 @@ +2017-03-02 Carlos Garcia Campos + +[GTK] Crash in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired +https://bugs.webkit.org/show_bug.cgi?id=166420 + +Reviewed by Žan Doberšek. + +This is happening when closing a page that is being inspected. When CoordinatedGraphicsLayer::removeFromParent() +is called, the coordinator has already been invalidated, so all its layers were set a nullptr coordinator. I +think it's safe to simply handle m_coordinator being nullptr in notifyFlushRequired(). + +* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: +(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Return early if the coordinator is nullptr. + 2017-03-02 Andreas Kling Don't keep dead resources in MemoryCache while under memory pressure. Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (213275 => 213276) --- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2017-03-02 09:43:18 UTC (rev 213275) +++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2017-03-02 11:44:41 UTC (rev 213276) @@ -53,7 +53,9 @@ void CoordinatedGraphicsLayer::notifyFlushRequired() { -ASSERT(m_coordinator); +if (!m_coordinator) +return; + if (m_coordinator->isFlushingLayerChanges()) return; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213277] trunk/LayoutTests
Title: [213277] trunk/LayoutTests Revision 213277 Author jfernan...@igalia.com Date 2017-03-02 05:15:42 -0800 (Thu, 02 Mar 2017) Log Message [GTK] Unreviewed test gardening https://bugs.webkit.org/show_bug.cgi?id=169076 Unreviewed GTK+ gardening. Some tests fail after r213020: - editing/deleting/skip-virama-001.html [ Failure ] - editing/selection/extend-by-character-007.html [ Failure ] - editing/selection/regional-indicators.html [ Failure ] * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (213276 => 213277) --- trunk/LayoutTests/ChangeLog 2017-03-02 11:44:41 UTC (rev 213276) +++ trunk/LayoutTests/ChangeLog 2017-03-02 13:15:42 UTC (rev 213277) @@ -1,3 +1,15 @@ +2017-03-02 Javier Fernandez + +[GTK] Unreviewed test gardening +https://bugs.webkit.org/show_bug.cgi?id=169076 + +Unreviewed GTK+ gardening. Some tests fail after r213020: + - editing/deleting/skip-virama-001.html [ Failure ] + - editing/selection/extend-by-character-007.html [ Failure ] + - editing/selection/regional-indicators.html [ Failure ] + +* TestExpectations: + 2017-03-01 Myles C. Maxfield Implement font-stretch for installed fonts Modified: trunk/LayoutTests/TestExpectations (213276 => 213277) --- trunk/LayoutTests/TestExpectations 2017-03-02 11:44:41 UTC (rev 213276) +++ trunk/LayoutTests/TestExpectations 2017-03-02 13:15:42 UTC (rev 213277) @@ -218,7 +218,9 @@ webkit.org/b/133057 fast/table/border-collapsing/collapsed-borders-adjoining-sections.html [ ImageOnlyFailure ] -webkit.org/b/142548 editing/selection/extend-by-character-007.html [ Failure ] +webkit.org/b/169075 editing/selection/extend-by-character-007.html [ Failure ] +webkit.org/b/169075 editing/selection/regional-indicators.html [ Failure ] +webkit.org/b/169075 editing/deleting/skip-virama-001.html [ Failure ] # CSS Font Loading is not yet enabled on all platforms webkit.org/b/135390 fast/css/fontloader-download-error.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213278] trunk
Title: [213278] trunk Revision 213278 Author tpop...@redhat.com Date 2017-03-02 06:20:47 -0800 (Thu, 02 Mar 2017) Log Message [WK2] Keyboard menu key should show context menu https://bugs.webkit.org/show_bug.cgi?id=72099 Source/WebCore: Reviewed by Carlos Garcia Campos. Show the context menu when the GtkWidget::popup-menu signal is emitted. This signal is triggered by pressing a key (usually the Menu key or the Shift + F10 shortcut) or it could be emitted on WebKitWebView. Test: fast/events/context-activated-by-key-event.html Also could be tested by: ManualTests/keyboard-menukey-event.html ManualTests/win/contextmenu-key.html ManualTests/win/contextmenu-key2.html * page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEventForKey): Correctly send the mouse event that used for showing the context menu. Previously the event was immediately dispatched as it is, but this was only the right way if some element was focused on the page. If there was no focused element or non-empty text range then the event lacked the right node, where it was supposed to be shown. The correct node is determined and added to the event in the sendContextMenuEvent() so we have to use this function to send the event. Also use absoluteBoundingBoxRect() instead of pixelSnappedAbsoluteClippedOverflowRect() when determining a coordinate where to show the context menu for the currently focus element. The latter is not returning a right box (it is bigger) which could lead to the situation that no menu will be displayed at all, because the HitTest won't contain the right element as the determined coordinates could be outside of the element. * page/EventHandler.h: Source/WebKit2: Reviewed by Carlos Garcia Campos. Show the context menu when the GtkWidget::popup-menu signal is emitted. This signal is triggered by pressing a key (usually the Menu key or the Shift + F10 shortcut) or it could be emitted on WebKitWebView. * UIProcess/API/gtk/WebKitWebView.cpp: (webkit_web_view_class_init): (webkit_web_view_class_init): Update the documentation for the context-menu signal * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBasePopupMenu): Connect to the popup-menu signal and save the event that was used to trigger the signal. If there is no such event create a new GdkEvent with GDK_NOTHING type. (webkitWebViewBasePopupMenu): (webkit_web_view_base_class_init): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleContextMenuKeyEvent): * UIProcess/WebPageProxy.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::contextMenuForKeyEvent): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Tools: Show the context menu when the GtkWidget::popup-menu signal is emitted. This signal is triggered by pressing a key (usually the Menu key or the Shift + F10 shortcut) or it could be emitted on WebKitWebView. Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: (testContextMenuDefaultMenu): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp: (WebViewTest::emitPopupMenuSignal): * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: LayoutTests: Reviewed by Carlos Garcia Campos. Skip the fast/events/context-activated-by-key-event.html on Mac as it does not have a key to activate the context menu and on iOS as well. * platform/ios-simulator-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h Added Paths trunk/LayoutTests/fast/events/context-activated-by-key-event-expected.txt trunk/LayoutTests/fast/events/context-activated-by-key-event.html Diff Modified: trunk/LayoutTests/ChangeLog (213277 => 213278) --- trunk/LayoutTests/ChangeLog 2017-03-02 13:15:42 UTC (rev 213277) +++ trunk/LayoutTests/ChangeLog 2017-03-02 14:20:47 UTC (rev 213278) @@ -1,3 +1,17 @@ +2017-03-02 Tomas Popela + +[WK2] Keyboard menu key should show context menu +https://bugs.webkit.org/show_bug.cgi?id=72099 + +Reviewed by Carlos Garcia Campos. + +Skip the fast/events/context-activated-by-key-event.html on Mac as it +
[webkit-changes] [213279] trunk/Source/WebCore/platform/gtk/po
Title: [213279] trunk/Source/WebCore/platform/gtk/po Revision 213279 Author mcatanz...@igalia.com Date 2017-03-02 07:07:40 -0800 (Thu, 02 Mar 2017) Log Message [l10n] Updated Polish translation of WebKitGTK+ for 2.16 https://bugs.webkit.org/show_bug.cgi?id=169072 Patch by Piotr Drąg on 2017-03-02 Rubber-stamped by Michael Catanzaro. * pl.po: Modified Paths trunk/Source/WebCore/platform/gtk/po/ChangeLog trunk/Source/WebCore/platform/gtk/po/pl.po Diff Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (213278 => 213279) --- trunk/Source/WebCore/platform/gtk/po/ChangeLog 2017-03-02 14:20:47 UTC (rev 213278) +++ trunk/Source/WebCore/platform/gtk/po/ChangeLog 2017-03-02 15:07:40 UTC (rev 213279) @@ -1,3 +1,12 @@ +2017-03-02 Piotr Drąg + +[l10n] Updated Polish translation of WebKitGTK+ for 2.16 +https://bugs.webkit.org/show_bug.cgi?id=169072 + +Rubber-stamped by Michael Catanzaro. + +* pl.po: + 2017-02-14 Rafael Fontenelle [GTK] [l10n] Updated Brazilian Portuguese translation of WebKitGTK+ Modified: trunk/Source/WebCore/platform/gtk/po/pl.po (213278 => 213279) --- trunk/Source/WebCore/platform/gtk/po/pl.po 2017-03-02 14:20:47 UTC (rev 213278) +++ trunk/Source/WebCore/platform/gtk/po/pl.po 2017-03-02 15:07:40 UTC (rev 213279) @@ -1,15 +1,15 @@ # Polish translation for webkitgtk. -# Copyright © 2011-2016 the webkitgtk authors. +# Copyright © 2011-2017 the webkitgtk authors. # This file is distributed under the same license as the webkitgtk package. -# Piotr Drąg , 2011-2016. -# Aviary.pl , 2011-2016. +# Piotr Drąg , 2011-2017. +# Aviary.pl , 2011-2017. # msgid "" msgstr "" "Project-Id-Version: webkitgtk\n" "Report-Msgid-Bugs-To: https://bugs.webkit.org/\n" -"POT-Creation-Date: 2016-09-07 02:30+\n" -"PO-Revision-Date: 2016-09-07 16:44+0200\n" +"POT-Creation-Date: 2017-03-02 09:06+\n" +"PO-Revision-Date: 2017-03-02 10:42+0100\n" "Last-Translator: Piotr Drąg \n" "Language-Team: Polish \n" "Language: pl\n" @@ -206,7 +206,7 @@ #: ../LocalizedStringsGtk.cpp:288 msgid "_Search the Web" -msgstr "Wy_szukaj w sieci" +msgstr "Wy_szukaj w Internecie" #: ../LocalizedStringsGtk.cpp:293 msgid "_Look Up in Dictionary" @@ -325,316 +325,399 @@ msgstr "opis" #: ../LocalizedStringsGtk.cpp:451 +msgid "details" +msgstr "szczegóły" + +#: ../LocalizedStringsGtk.cpp:456 +msgid "summary" +msgstr "podsumowanie" + +#: ../LocalizedStringsGtk.cpp:461 +msgid "figure" +msgstr "ilustracja" + +#: ../LocalizedStringsGtk.cpp:466 +msgid "output" +msgstr "wyjście" + +#: ../LocalizedStringsGtk.cpp:471 +msgid "email field" +msgstr "pole adresu e-mail" + +#: ../LocalizedStringsGtk.cpp:476 +msgid "telephone number field" +msgstr "pole numeru telefonu" + +#: ../LocalizedStringsGtk.cpp:481 +msgid "URL field" +msgstr "pole adresu URL" + +#: ../LocalizedStringsGtk.cpp:486 +msgid "date field" +msgstr "pole daty" + +#: ../LocalizedStringsGtk.cpp:491 +msgid "time field" +msgstr "pole czasu" + +#: ../LocalizedStringsGtk.cpp:496 +msgid "date and time field" +msgstr "pole daty i czasu" + +#: ../LocalizedStringsGtk.cpp:501 +msgid "month and year field" +msgstr "pole miesiąca i roku" + +#: ../LocalizedStringsGtk.cpp:506 +msgid "number field" +msgstr "pole liczbowe" + +#: ../LocalizedStringsGtk.cpp:511 +msgid "week and year field" +msgstr "pole tygodnia i roku" + +#: ../LocalizedStringsGtk.cpp:516 msgid "footer" msgstr "stopka" -#: ../LocalizedStringsGtk.cpp:456 +#: ../LocalizedStringsGtk.cpp:521 msgid "cancel" msgstr "anuluj" -#: ../LocalizedStringsGtk.cpp:461 +#: ../LocalizedStringsGtk.cpp:526 msgid "password auto fill" msgstr "automatyczne wypełnianie hasła" -#: ../LocalizedStringsGtk.cpp:466 +#: ../LocalizedStringsGtk.cpp:531 msgid "contact info auto fill" msgstr "automatyczne wypełnianie informacji kontaktowych" -#: ../LocalizedStringsGtk.cpp:471 +#: ../LocalizedStringsGtk.cpp:536 msgid "press" msgstr "naciśnięcie" -#: ../LocalizedStringsGtk.cpp:476 +#: ../LocalizedStringsGtk.cpp:541 msgid "select" msgstr "wybór" -#: ../LocalizedStringsGtk.cpp:481 +#: ../LocalizedStringsGtk.cpp:546 msgid "activate" msgstr "aktywacja" -#: ../LocalizedStringsGtk.cpp:486 +#: ../LocalizedStringsGtk.cpp:551 msgid "uncheck" msgstr "odznaczenie" -#: ../LocalizedStringsGtk.cpp:491 +#: ../LocalizedStringsGtk.cpp:556 msgid "check" msgstr "zaznaczenie" -#: ../LocalizedStringsGtk.cpp:496 +#: ../LocalizedStringsGtk.cpp:561 msgid "jump" msgstr "przejście" -#: ../LocalizedStringsGtk.cpp:516 +#: ../LocalizedStringsGtk.cpp:581 msgid "Missing Plug-in" msgstr "Brak wtyczki" -#: ../LocalizedStringsGtk.cpp:522 +#: ../LocalizedStringsGtk.cpp:587 msgid "Plug-in Failure" msgstr "Niepowodzenie wtyczki" #. FIXME: If this file gets localized, this should really be localized as one string with a wildcard for the number. -#: ../LocalizedStringsGtk.cpp:540 +#: ../LocalizedStringsGtk.cpp:605 msgid " files" msgstr " plików" -#: ../LocalizedStringsGtk.
[webkit-changes] [213280] trunk/LayoutTests
Title: [213280] trunk/LayoutTests Revision 213280 Author jfernan...@igalia.com Date 2017-03-02 07:45:58 -0800 (Thu, 02 Mar 2017) Log Message [GTK] Unreviewed test gardening https://bugs.webkit.org/show_bug.cgi?id=169081 Unreviewed GTK+ gardening. Moved some failures to the GTK TestExpectations * TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (213279 => 213280) --- trunk/LayoutTests/ChangeLog 2017-03-02 15:07:40 UTC (rev 213279) +++ trunk/LayoutTests/ChangeLog 2017-03-02 15:45:58 UTC (rev 213280) @@ -1,3 +1,13 @@ +2017-03-02 Javier Fernandez + +[GTK] Unreviewed test gardening +https://bugs.webkit.org/show_bug.cgi?id=169081 + +Unreviewed GTK+ gardening. Moved some failures to the GTK TestExpectations + +* TestExpectations: +* platform/gtk/TestExpectations: + 2017-03-02 Tomas Popela [WK2] Keyboard menu key should show context menu Modified: trunk/LayoutTests/TestExpectations (213279 => 213280) --- trunk/LayoutTests/TestExpectations 2017-03-02 15:07:40 UTC (rev 213279) +++ trunk/LayoutTests/TestExpectations 2017-03-02 15:45:58 UTC (rev 213280) @@ -219,8 +219,6 @@ webkit.org/b/133057 fast/table/border-collapsing/collapsed-borders-adjoining-sections.html [ ImageOnlyFailure ] webkit.org/b/169075 editing/selection/extend-by-character-007.html [ Failure ] -webkit.org/b/169075 editing/selection/regional-indicators.html [ Failure ] -webkit.org/b/169075 editing/deleting/skip-virama-001.html [ Failure ] # CSS Font Loading is not yet enabled on all platforms webkit.org/b/135390 fast/css/fontloader-download-error.html [ Skip ] Modified: trunk/LayoutTests/platform/gtk/TestExpectations (213279 => 213280) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-03-02 15:07:40 UTC (rev 213279) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-03-02 15:45:58 UTC (rev 213280) @@ -2918,6 +2918,9 @@ webkit.org/b/168719 fast/css/paint-order-shadow.html [ ImageOnlyFailure ] +webkit.org/b/169075 editing/selection/regional-indicators.html [ Failure ] +webkit.org/b/169075 editing/deleting/skip-virama-001.html [ Failure ] + # # End of non-crashing, non-flaky tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [213281] trunk
Title: [213281] trunk Revision 213281 Author eric.carl...@apple.com Date 2017-03-02 07:50:09 -0800 (Thu, 02 Mar 2017) Log Message [MediaStream] UIClient may not be notified of capture state change when leaving a page https://bugs.webkit.org/show_bug.cgi?id=169014 Reviewed by Youenn Fablet. Enable and update the WebKit API test WebKit2.UserMedia. * dom/Document.cpp: (WebCore::Document::prepareForDestruction): Always call page.updateIsPlayingMedia() if there is active media in the document because it won't be possible when the state changes later because the frame will have been cleared. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Tools/TestWebKitAPI/Tests/WebKit2/UserMedia.cpp trunk/Tools/TestWebKitAPI/Tests/WebKit2/getUserMedia.html Diff Modified: trunk/Source/WebCore/ChangeLog (213280 => 213281) --- trunk/Source/WebCore/ChangeLog 2017-03-02 15:45:58 UTC (rev 213280) +++ trunk/Source/WebCore/ChangeLog 2017-03-02 15:50:09 UTC (rev 213281) @@ -1,3 +1,18 @@ +2017-03-02 Eric Carlson + +[MediaStream] UIClient may not be notified of capture state change when leaving a page +https://bugs.webkit.org/show_bug.cgi?id=169014 + + +Reviewed by Youenn Fablet. + +Enable and update the WebKit API test WebKit2.UserMedia. + +* dom/Document.cpp: +(WebCore::Document::prepareForDestruction): Always call page.updateIsPlayingMedia() if there +is active media in the document because it won't be possible when the state changes later +because the frame will have been cleared. + 2017-03-02 Tomas Popela [WK2] Keyboard menu key should show context menu Modified: trunk/Source/WebCore/dom/Document.cpp (213280 => 213281) --- trunk/Source/WebCore/dom/Document.cpp 2017-03-02 15:45:58 UTC (rev 213280) +++ trunk/Source/WebCore/dom/Document.cpp 2017-03-02 15:50:09 UTC (rev 213281) @@ -2327,6 +2327,11 @@ } #endif +if (page() && m_mediaState != MediaProducer::IsNotPlaying) { +m_mediaState = MediaProducer::IsNotPlaying; +page()->updateIsPlayingMedia(HTMLMediaElementInvalidID); +} + detachFromFrame(); m_hasPreparedForDestruction = true; Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/UserMedia.cpp (213280 => 213281) --- trunk/Tools/TestWebKitAPI/Tests/WebKit2/UserMedia.cpp 2017-03-02 15:45:58 UTC (rev 213280) +++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/UserMedia.cpp 2017-03-02 15:50:09 UTC (rev 213281) @@ -25,6 +25,9 @@ #include "PlatformUtilities.h" #include "PlatformWebView.h" #include "Test.h" +#include +#include +#include #include #include #include @@ -31,10 +34,16 @@ namespace TestWebKitAPI { -static bool done; +static bool wasPrompted; +static bool isPlayingChanged; +static bool didFinishLoad; -void decidePolicyForUserMediaPermissionRequestCallBack(WKPageRef, WKFrameRef, WKSecurityOriginRef, WKSecurityOriginRef, WKUserMediaPermissionRequestRef permissionRequest, const void* /* clientInfo */) +static void nullJavaScriptCallback(WKSerializedScriptValueRef, WKErrorRef error, void*) { +} + +static void decidePolicyForUserMediaPermissionRequestCallBack(WKPageRef, WKFrameRef, WKSecurityOriginRef, WKSecurityOriginRef, WKUserMediaPermissionRequestRef permissionRequest, const void* /* clientInfo */) +{ WKRetainPtr audioDeviceUIDs = WKUserMediaPermissionRequestAudioDeviceUIDs(permissionRequest); WKRetainPtr videoDeviceUIDs = WKUserMediaPermissionRequestVideoDeviceUIDs(permissionRequest); @@ -54,27 +63,73 @@ WKUserMediaPermissionRequestAllow(permissionRequest, audioDeviceUID.get(), videoDeviceUID.get()); } -done = true; +wasPrompted = true; } -TEST(WebKit2, DISABLED_UserMediaBasic) +static void isPlayingDidChangeCallback(WKPageRef page, const void*) { +isPlayingChanged = true; +} + +static void didFinishLoadForFrame(WKPageRef page, WKFrameRef, WKTypeRef, const void*) +{ +didFinishLoad = true; +} + +TEST(WebKit2, UserMediaBasic) +{ auto context = adoptWK(WKContextCreate()); -PlatformWebView webView(context.get()); -WKPageUIClientV5 uiClient; -memset(&uiClient, 0, sizeof(uiClient)); +WKRetainPtr pageGroup(AdoptWK, WKPageGroupCreateWithIdentifier(Util::toWK("GetUserMedia").get())); +WKPreferencesRef preferences = WKPageGroupGetPreferences(pageGroup.get()); +WKPreferencesSetMediaStreamEnabled(preferences, true); +WKPreferencesSetFileAccessFromFileURLsAllowed(preferences, true); +WKPreferencesSetMediaCaptureRequiresSecureConnection(preferences, false); +WKPreferencesSetMockCaptureDevicesEnabled(preferences, true); -uiClient.base.version = 5; +WKPageLoaderClientV0 loaderClient; +memset(&loaderClient, 0, sizeof(loaderClient)); +loaderClient.base.version = 0; +loaderClient.didFinishLoadForFrame = didFinishLoadForFrame; + +WKPageUIClientV6 uiClient; +memset(&uiClient, 0, sizeof(uiClient)); +uiClient.base.version
[webkit-changes] [213282] trunk/LayoutTests
Title: [213282] trunk/LayoutTests Revision 213282 Author commit-qu...@webkit.org Date 2017-03-02 08:05:53 -0800 (Thu, 02 Mar 2017) Log Message Activate some new webrtc tests https://bugs.webkit.org/show_bug.cgi?id=168850 Patch by Youenn Fablet on 2017-03-02 Reviewed by Alex Christensen. * TestExpectations: Activating tests in debug builds. * webrtc/datachannel/basic-expected.txt: Added. * webrtc/datachannel/basic.html: Activating real webrtc backend. * webrtc/libwebrtc/release-while-creating-offer-expected.txt: Added. * webrtc/libwebrtc/release-while-getting-stats-expected.txt: Added. * webrtc/libwebrtc/release-while-setting-local-description-expected.txt: Added. * webrtc/video-disabled-black-expected.txt: * webrtc/video-disabled-black.html: Setting expected alpha channel to zero for black frames. * webrtc/video-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/LayoutTests/webrtc/datachannel/basic-expected.txt trunk/LayoutTests/webrtc/datachannel/basic.html trunk/LayoutTests/webrtc/video-disabled-black-expected.txt trunk/LayoutTests/webrtc/video-disabled-black.html trunk/LayoutTests/webrtc/video-expected.txt Added Paths trunk/LayoutTests/webrtc/libwebrtc/release-while-creating-offer-expected.txt trunk/LayoutTests/webrtc/libwebrtc/release-while-getting-stats-expected.txt trunk/LayoutTests/webrtc/libwebrtc/release-while-setting-local-description-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (213281 => 213282) --- trunk/LayoutTests/ChangeLog 2017-03-02 15:50:09 UTC (rev 213281) +++ trunk/LayoutTests/ChangeLog 2017-03-02 16:05:53 UTC (rev 213282) @@ -1,3 +1,20 @@ +2017-03-02 Youenn Fablet + +Activate some new webrtc tests +https://bugs.webkit.org/show_bug.cgi?id=168850 + +Reviewed by Alex Christensen. + +* TestExpectations: Activating tests in debug builds. +* webrtc/datachannel/basic-expected.txt: Added. +* webrtc/datachannel/basic.html: Activating real webrtc backend. +* webrtc/libwebrtc/release-while-creating-offer-expected.txt: Added. +* webrtc/libwebrtc/release-while-getting-stats-expected.txt: Added. +* webrtc/libwebrtc/release-while-setting-local-description-expected.txt: Added. +* webrtc/video-disabled-black-expected.txt: +* webrtc/video-disabled-black.html: Setting expected alpha channel to zero for black frames. +* webrtc/video-expected.txt: + 2017-03-02 Javier Fernandez [GTK] Unreviewed test gardening Modified: trunk/LayoutTests/TestExpectations (213281 => 213282) --- trunk/LayoutTests/TestExpectations 2017-03-02 15:50:09 UTC (rev 213281) +++ trunk/LayoutTests/TestExpectations 2017-03-02 16:05:53 UTC (rev 213282) @@ -688,9 +688,9 @@ # Media Sessions is not yet enabled by default: ENABLE(MEDIA_SESSION) media/session [ Skip ] -# WebRTC backend not enabled by default on Mac/iOS. +# WebRTC backend not enabled by default on Mac/iOS release bots. # GTK enables some of this tests on their TestExpectations file. -webrtc [ Skip ] +[ Release ] webrtc [ Skip ] fast/mediastream/getUserMedia-webaudio.html [ Skip ] fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Skip ] fast/mediastream/RTCPeerConnection-closed-state.html [ Skip ] Modified: trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations (213281 => 213282) --- trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations 2017-03-02 15:50:09 UTC (rev 213281) +++ trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations 2017-03-02 16:05:53 UTC (rev 213282) @@ -7,6 +7,10 @@ editing/input/focus-change-with-marked-text.html [ Pass ] +# Skip WebRTC for now in WK1 +imported/w3c/web-platform-tests/webrtc [ Skip ] +webrtc [ Skip ] + # LayoutTests: Enable editing tests after we support editing editing/deleting/4922367.html editing/deleting/5126166.html Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (213281 => 213282) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-03-02 15:50:09 UTC (rev 213281) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-03-02 16:05:53 UTC (rev 213282) @@ -96,6 +96,7 @@ # Skip WebRTC for now in WK1 imported/w3c/web-platform-tests/webrtc [ Skip ] +webrtc [ Skip ] # These tests test the Shadow DOM based HTML form validation UI but Mac WK1 is using native dialogs instead. fast/forms/validation-message-on-listbox.html Modified: trunk/LayoutTests/platform/win/TestExpectations (213281 => 213282) --- trunk/LayoutTests/platform/win/TestExpectations 2017-03-02 15:50:09 UTC (rev 213281) +++ trunk/LayoutTests/platform/win/TestExpectations 2017-03-02 16:05:53 UTC (rev 213282) @@ -3785,6 +3785,7 @@ # webrtc not supported imported/w3c/web-platform-tests/webrtc [ Skip ] +webrtc [ Skip ] # Resource Timing
[webkit-changes] [213283] trunk
Title: [213283] trunk Revision 213283 Author commit-qu...@webkit.org Date 2017-03-02 08:24:30 -0800 (Thu, 02 Mar 2017) Log Message [WebRTC] Activate ICE candidate privacy policy https://bugs.webkit.org/show_bug.cgi?id=168975 Patch by Youenn Fablet on 2017-03-02 Reviewed by Alex Christensen. Source/WebCore: Test: webrtc/datachannel/filter-ice-candidate.html * testing/Internals.cpp: (WebCore::Internals::Internals): Disabling ICE candidate filtering by default for rwt. (WebCore::Internals::setICECandidateFiltering): * testing/Internals.h: * testing/Internals.idl: Source/WebKit/mac: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]): (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]): (-[WebPreferences iceCandidateFilteringEnabled]): (-[WebPreferences setIceCandidateFilteringEnabled:]): * WebView/WebPreferencesPrivate.h: Source/WebKit2: Disabling network enumeration by default. Enabling ICE candidate filtering by default. Chaning ICE candidate filtering according userMediaAccess policy: - If access is denied, filtering is on. - If access is granted, filtering is off. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: * Shared/WebPreferencesDefinitions.h: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetICECandidateFilteringEnabled): (WKPreferencesGetICECandidateFilteringEnabled): (WKPreferencesSetEnumeratingAllNetworkInterfacesEnabled): (WKPreferencesGetEnumeratingAllNetworkInterfacesEnabled): * UIProcess/API/C/WKPreferencesRefPrivate.h: * UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::toWebCore): (WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): * UIProcess/UserMediaProcessManager.cpp: (WebKit::UserMediaProcessManager::willCreateMediaStream): (WebKit::UserMediaProcessManager::endedCaptureSession): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): * WebProcess/WebPage/WebPage.cpp: LayoutTests: * webrtc/datachannel/filter-ice-candidate-expected.txt: Added. * webrtc/datachannel/filter-ice-candidate.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h trunk/Source/WebKit/mac/WebView/WebPreferences.mm trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp trunk/Source/WebKit2/Shared/WebPageCreationParameters.h trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h trunk/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp trunk/Source/WebKit2/UIProcess/UserMediaProcessManager.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Added Paths trunk/LayoutTests/webrtc/datachannel/filter-ice-candidate-expected.txt trunk/LayoutTests/webrtc/datachannel/filter-ice-candidate.html Diff Modified: trunk/LayoutTests/ChangeLog (213282 => 213283) --- trunk/LayoutTests/ChangeLog 2017-03-02 16:05:53 UTC (rev 213282) +++ trunk/LayoutTests/ChangeLog 2017-03-02 16:24:30 UTC (rev 213283) @@ -1,5 +1,15 @@ 2017-03-02 Youenn Fablet +[WebRTC] Activate ICE candidate privacy policy +https://bugs.webkit.org/show_bug.cgi?id=168975 + +Reviewed by Alex Christensen. + +* webrtc/datachannel/filter-ice-candidate-expected.txt: Added. +* webrtc/datachannel/filter-ice-candidate.html: Added. + +2017-03-02 Youenn Fablet + Activate some new webrtc tests https://bugs.webkit.org/show_bug.cgi?id=168850 Added: trunk/LayoutTests/webrtc/datachannel/filter-ice-candidate-expected.txt (0 => 213283) --- trunk/LayoutTests/webrtc/datachannel/filter-ice-candidate-expected.txt (rev 0) +++ trunk/LayoutTests/webrtc/datachannel/filter-ice-candidate-expected.txt 2017-03-02 16:24:30 UTC (rev 213283) @@ -0,0 +1,4 @@ + +PASS Gathering ICE candidates from a data channel peer connection with ICE candidate filtering off +PASS Gathering ICE candidates from a data channel peer connection with ICE candidate filtering on + Added: trunk/LayoutTests/webrtc/datachannel/filter-ice-candidate.html (0 => 213283) --- trunk/LayoutTests/webrtc/datachannel/filter-ice-candidate.html (rev 0) +++ trunk/LayoutTests/webrtc/datachannel/filter-ice-candidate.html 2017-03-02 16:24:30 UTC (rev 213283) @@ -0,0 +1,61 @@ + + + + +Testing ICE candidate filtering when using data channel + + +