[webkit-changes] [257046] trunk
Title: [257046] trunk
Revision 257046
Author commit-qu...@webkit.org
Date 2020-02-19 22:41:20 -0800 (Wed, 19 Feb 2020)
Log Message
ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=151030
Patch by Jack Lee on 2020-02-19
Reviewed by Darin Adler.
Track if m_accumulatedOffset ever becomes saturated, and if so, do not assert on unexpected rendererMappedResult.
Source/WebCore:
Test: fast/layers/geometry-map-saturated-offset-assert.html
* platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::mightBeSaturated const):
* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer const):
(WebCore::RenderGeometryMap::stepInserted):
(WebCore::RenderGeometryMap::stepRemoved):
* rendering/RenderGeometryMap.h:
LayoutTests:
* fast/layers/geometry-map-saturated-offset-assert-expected.txt: Added.
* fast/layers/geometry-map-saturated-offset-assert.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/LayoutSize.h
trunk/Source/WebCore/rendering/RenderGeometryMap.cpp
trunk/Source/WebCore/rendering/RenderGeometryMap.h
Added Paths
trunk/LayoutTests/fast/layers/geometry-map-saturated-offset-assert-expected.txt
trunk/LayoutTests/fast/layers/geometry-map-saturated-offset-assert.html
Diff
Modified: trunk/LayoutTests/ChangeLog (257045 => 257046)
--- trunk/LayoutTests/ChangeLog 2020-02-20 06:25:44 UTC (rev 257045)
+++ trunk/LayoutTests/ChangeLog 2020-02-20 06:41:20 UTC (rev 257046)
@@ -1,3 +1,16 @@
+2020-02-19 Jack Lee
+
+ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer
+https://bugs.webkit.org/show_bug.cgi?id=151030
+
+
+Reviewed by Darin Adler.
+
+Track if m_accumulatedOffset ever becomes saturated, and if so, do not assert on unexpected rendererMappedResult.
+
+* fast/layers/geometry-map-saturated-offset-assert-expected.txt: Added.
+* fast/layers/geometry-map-saturated-offset-assert.html: Added.
+
2020-02-19 Youenn Fablet
Add support for AudioSession handling in GPUProcess for capture
Added: trunk/LayoutTests/fast/layers/geometry-map-saturated-offset-assert-expected.txt (0 => 257046)
--- trunk/LayoutTests/fast/layers/geometry-map-saturated-offset-assert-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/layers/geometry-map-saturated-offset-assert-expected.txt 2020-02-20 06:41:20 UTC (rev 257046)
@@ -0,0 +1 @@
+Tests geometry map with saturated offset. The test passes if WebKit doesn't crash or hit an assertion.
Added: trunk/LayoutTests/fast/layers/geometry-map-saturated-offset-assert.html (0 => 257046)
--- trunk/LayoutTests/fast/layers/geometry-map-saturated-offset-assert.html (rev 0)
+++ trunk/LayoutTests/fast/layers/geometry-map-saturated-offset-assert.html 2020-02-20 06:41:20 UTC (rev 257046)
@@ -0,0 +1,13 @@
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+input, big {
+-webkit-appearance:button;
+vertical-align:-53772756.9in;
+overflow-y:hidden;
+-webkit-padding-before:+.8mm;
+}
+
+Tests geometry map with saturated offset. The test passes if WebKit doesn't crash or hit an assertion.
Modified: trunk/Source/WebCore/ChangeLog (257045 => 257046)
--- trunk/Source/WebCore/ChangeLog 2020-02-20 06:25:44 UTC (rev 257045)
+++ trunk/Source/WebCore/ChangeLog 2020-02-20 06:41:20 UTC (rev 257046)
@@ -1,3 +1,23 @@
+2020-02-19 Jack Lee
+
+ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer
+https://bugs.webkit.org/show_bug.cgi?id=151030
+
+
+Reviewed by Darin Adler.
+
+Track if m_accumulatedOffset ever becomes saturated, and if so, do not assert on unexpected rendererMappedResult.
+
+Test: fast/layers/geometry-map-saturated-offset-assert.html
+
+* platform/graphics/LayoutSize.h:
+(WebCore::LayoutSize::mightBeSaturated const):
+* rendering/RenderGeometryMap.cpp:
+(WebCore::RenderGeometryMap::mapToContainer const):
+(WebCore::RenderGeometryMap::stepInserted):
+(WebCore::RenderGeometryMap::stepRemoved):
+* rendering/RenderGeometryMap.h:
+
2020-02-19 Youenn Fablet
Add support for AudioSession handling in GPUProcess for capture
Modified: trunk/Source/WebCore/platform/graphics/LayoutSize.h (257045 => 257046)
--- trunk/Source/WebCore/platform/graphics/LayoutSize.h 2020-02-20 06:25:44 UTC (rev 257045)
+++ trunk/Source/WebCore/platform/graphics/LayoutSize.h 2020-02-20 06:41:20 UTC (rev 257046)
@@ -136,6 +136,11 @@
return LayoutSize(width(), width() * aspectRatio.height() / aspectRatio.width());
}
+bool mightBeSaturated() const
+{
+
[webkit-changes] [257045] trunk/Source/WebKit
Title: [257045] trunk/Source/WebKit
Revision 257045
Author cdu...@apple.com
Date 2020-02-19 22:25:44 -0800 (Wed, 19 Feb 2020)
Log Message
Regression(r246188) WebProcess is launched too eagerly when [WKWebView _restoreSessionState] is called
https://bugs.webkit.org/show_bug.cgi?id=207908
Reviewed by Darin Adler.
Since r246188, the WebProcess is launched eagerly when [WKWebView _restoreSessionState] is called. This is bad
for performance because we are unable to leverage the process cache at this point (since we don't know which
domain will be loaded).
This patch thus reverts r246188 and fixes what r246188 was trying to address in a different way. If the process
was not launched yet when restoreSessionState() is called, the session state properly gets sent to the WebProcess
after launch, via the WebPageCreationParameters. What was missing at that point was that the session state was
restore by an API Request. To fix this, we now pass an extra itemStatesWereRestoredByAPIRequest flag in
WebPageCreationParameters.
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromSessionState):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_overriddenMediaType):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp
trunk/Source/WebKit/Shared/WebPageCreationParameters.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (257044 => 257045)
--- trunk/Source/WebKit/ChangeLog 2020-02-20 06:24:43 UTC (rev 257044)
+++ trunk/Source/WebKit/ChangeLog 2020-02-20 06:25:44 UTC (rev 257045)
@@ -1,3 +1,30 @@
+2020-02-19 Chris Dumez
+
+Regression(r246188) WebProcess is launched too eagerly when [WKWebView _restoreSessionState] is called
+https://bugs.webkit.org/show_bug.cgi?id=207908
+
+Reviewed by Darin Adler.
+
+Since r246188, the WebProcess is launched eagerly when [WKWebView _restoreSessionState] is called. This is bad
+for performance because we are unable to leverage the process cache at this point (since we don't know which
+domain will be loaded).
+
+This patch thus reverts r246188 and fixes what r246188 was trying to address in a different way. If the process
+was not launched yet when restoreSessionState() is called, the session state properly gets sent to the WebProcess
+after launch, via the WebPageCreationParameters. What was missing at that point was that the session state was
+restore by an API Request. To fix this, we now pass an extra itemStatesWereRestoredByAPIRequest flag in
+WebPageCreationParameters.
+
+* Shared/WebPageCreationParameters.cpp:
+(WebKit::WebPageCreationParameters::encode const):
+(WebKit::WebPageCreationParameters::decode):
+* Shared/WebPageCreationParameters.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::restoreFromSessionState):
+* UIProcess/WebPageProxy.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::m_overriddenMediaType):
+
2020-02-19 Commit Queue
Unreviewed, rolling out r257029.
Modified: trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp (257044 => 257045)
--- trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp 2020-02-20 06:24:43 UTC (rev 257044)
+++ trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp 2020-02-20 06:25:44 UTC (rev 257045)
@@ -52,6 +52,7 @@
encoder << gapBetweenPages;
encoder << paginationLineGridEnabled;
encoder << userAgent;
+encoder << itemStatesWereRestoredByAPIRequest;
encoder << itemStates;
encoder << userContentControllerID;
encoder << visitedLinkTableID;
@@ -206,6 +207,12 @@
return WTF::nullopt;
parameters.userAgent = WTFMove(*userAgent);
+Optional itemStatesWereRestoredByAPIRequest;
+decoder >> itemStatesWereRestoredByAPIRequest;
+if (!itemStatesWereRestoredByAPIRequest)
+return WTF::nullopt;
+parameters.itemStatesWereRestoredByAPIRequest = *itemStatesWereRestoredByAPIRequest;
+
Optional> itemStates;
decoder >> itemStates;
if (!itemStates)
Modified: trunk/Source/WebKit/Shared/WebPageCreationParameters.h (257044 => 257045)
--- trunk/Source/WebKit/Shared/WebPageCreationParameters.h 2020-02-20 06:24:43 UTC (rev 257044)
+++ trunk/Source/WebKit/Shared/WebPageCreationParameters.h 2020-02-20 06:25:44 UTC (rev 257045)
@@ -97,6 +97,7 @@
String userAgent;
+bool itemStatesWereRestoredByAPIRequest { false };
Vector itemStates;
UserContentControllerIdentifier userContentControllerID;
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (257044 =>
[webkit-changes] [257044] trunk/Source
Title: [257044] trunk/Source
Revision 257044
Author commit-qu...@webkit.org
Date 2020-02-19 22:24:43 -0800 (Wed, 19 Feb 2020)
Log Message
Unreviewed, rolling out r257029.
https://bugs.webkit.org/show_bug.cgi?id=207996
Doesn't fix the issue (Requested by ap on #webkit).
Reverted changeset:
"[iOS] Rename NSUserDefaultsSPI.h"
https://bugs.webkit.org/show_bug.cgi?id=207977
https://trac.webkit.org/changeset/257029
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.h
Added Paths
trunk/Source/WebCore/PAL/pal/spi/cocoa/NSUserDefaultsSPI.h
Removed Paths
trunk/Source/WebCore/PAL/pal/spi/cocoa/UserDefaultsSPI.h
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (257043 => 257044)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-02-20 06:19:41 UTC (rev 257043)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-02-20 06:24:43 UTC (rev 257044)
@@ -1,3 +1,16 @@
+2020-02-19 Commit Queue
+
+Unreviewed, rolling out r257029.
+https://bugs.webkit.org/show_bug.cgi?id=207996
+
+Doesn't fix the issue (Requested by ap on #webkit).
+
+Reverted changeset:
+
+"[iOS] Rename NSUserDefaultsSPI.h"
+https://bugs.webkit.org/show_bug.cgi?id=207977
+https://trac.webkit.org/changeset/257029
+
2020-02-19 Per Arne Vollan
[iOS] Rename NSUserDefaultsSPI.h
Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (257043 => 257044)
--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2020-02-20 06:19:41 UTC (rev 257043)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2020-02-20 06:24:43 UTC (rev 257044)
@@ -164,7 +164,7 @@
A3AB6E651F3D217F009C14B1 /* SystemSleepListenerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = A3AB6E631F3D217F009C14B1 /* SystemSleepListenerMac.mm */; };
A3C66CDC1F462D6A009E6EE9 /* SessionID.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */; };
A3C66CDD1F462D6A009E6EE9 /* SessionID.h in Headers */ = {isa = PBXBuildFile; fileRef = A3C66CDB1F462D6A009E6EE9 /* SessionID.h */; };
- C15CBB3523F3548A00300CC7 /* UserDefaultsSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = C15CBB3223F34A1200300CC7 /* UserDefaultsSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ C15CBB3523F3548A00300CC7 /* NSUserDefaultsSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
CDACB3602387425B0018D7CE /* MediaToolboxSoftLink.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDACB35E23873E480018D7CE /* MediaToolboxSoftLink.cpp */; };
CDACB361238742740018D7CE /* MediaToolboxSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = CDACB35F23873E480018D7CE /* MediaToolboxSoftLink.h */; };
CDF91113220E4EEC001EA39E /* CelestialSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CDF91112220E4EEC001EA39E /* CelestialSPI.h */; };
@@ -341,7 +341,7 @@
A3AB6E631F3D217F009C14B1 /* SystemSleepListenerMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SystemSleepListenerMac.mm; sourceTree = ""; };
A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SessionID.cpp; sourceTree = ""; };
A3C66CDB1F462D6A009E6EE9 /* SessionID.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SessionID.h; sourceTree = ""; };
- C15CBB3223F34A1200300CC7 /* UserDefaultsSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = UserDefaultsSPI.h; sourceTree = ""; };
+ C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NSUserDefaultsSPI.h; sourceTree = ""; };
C2147A4A1EFD0AA600056FA5 /* CopyPALHeaders.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = CopyPALHeaders.xcconfig; sourceTree = ""; };
CDACB35E23873E480018D7CE /* MediaToolboxSoftLink.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = MediaToolboxSoftLink.cpp; sourceTree = ""; };
CDACB35F23873E480018D7CE /* MediaToolboxSoftLink.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MediaToolboxSoftLink.h; sourceTree = ""; };
@@ -445,6 +445,7 @@
0C2DA1361F3BEB4900DBC317 /* NSURLConnectionSPI.h */,
0C2DA1371F3BEB4900DBC317 /* NSURLDownloadSPI.h */,
0C2DA1381F3BEB4900DBC317 /* NSURLFileTypeMappingsSPI.h */,
+C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */,
570AB8F820AF6E3D00B8BE87 /* NSXPCConnectionSPI.h */,
EB707FA4239737F80059053A /* OSVariantSPI.h */,
0C2DA1391F3BEB4900DBC317 /* PassKitSPI.h */,
@@ -454,7 +455,6 @@
570AB8F020AE2E8D00B8BE87 /* SecKeyProxySPI.h */,
[webkit-changes] [257043] trunk/Source/WebInspectorUI
Title: [257043] trunk/Source/WebInspectorUI
Revision 257043
Author j...@apple.com
Date 2020-02-19 22:19:41 -0800 (Wed, 19 Feb 2020)
Log Message
Fixed object trees using the wrong theme of type icon
https://bugs.webkit.org/show_bug.cgi?id=207980
Reviewed by Darin Adler.
* UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property.boolean > .icon):
(.object-tree-property.function > .icon):
(.object-tree-property.number > .icon):
(.object-tree-property.bigint > .icon):
(.object-tree-property.object > .icon):
(.object-tree-property.object.null > .icon):
(.object-tree-property.object.node > .icon):
(.object-tree-property.regex > .icon):
(.object-tree-property.string > .icon):
(.object-tree-property.symbol > .icon):
(.object-tree-property.accessor > .icon,):
(.object-tree-property.had-error > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.boolean > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.function > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.number > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.bigint > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.object > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.object.null > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.object.node > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.regex > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.string > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.symbol > .icon):
(@media (prefers-color-scheme: dark) .object-tree-property.accessor > .icon,):
(@media (prefers-color-scheme: dark) .object-tree-property.had-error > .icon):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (257042 => 257043)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-02-20 06:11:32 UTC (rev 257042)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-02-20 06:19:41 UTC (rev 257043)
@@ -1,3 +1,36 @@
+2020-02-19 Jon Davis
+
+Fixed object trees using the wrong theme of type icon
+https://bugs.webkit.org/show_bug.cgi?id=207980
+
+Reviewed by Darin Adler.
+
+* UserInterface/Views/ObjectTreePropertyTreeElement.css:
+(.object-tree-property.boolean > .icon):
+(.object-tree-property.function > .icon):
+(.object-tree-property.number > .icon):
+(.object-tree-property.bigint > .icon):
+(.object-tree-property.object > .icon):
+(.object-tree-property.object.null > .icon):
+(.object-tree-property.object.node > .icon):
+(.object-tree-property.regex > .icon):
+(.object-tree-property.string > .icon):
+(.object-tree-property.symbol > .icon):
+(.object-tree-property.accessor > .icon,):
+(.object-tree-property.had-error > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.boolean > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.function > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.number > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.bigint > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.object > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.object.null > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.object.node > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.regex > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.string > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.symbol > .icon):
+(@media (prefers-color-scheme: dark) .object-tree-property.accessor > .icon,):
+(@media (prefers-color-scheme: dark) .object-tree-property.had-error > .icon):
+
2020-02-17 Nikita Vasilyev
Web Inspector: Add "outline focused element" debug setting
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css (257042 => 257043)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css 2020-02-20 06:11:32 UTC (rev 257042)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css 2020-02-20 06:19:41 UTC (rev 257043)
@@ -29,52 +29,52 @@
}
.object-tree-property.boolean > .icon {
-content: url(../Images/TypeIcons.svg#TypeBoolean-dark);
+content: url(../Images/TypeIcons.svg#TypeBoolean-light);
}
.object-tree-property.function > .icon {
-content: url(../Images/TypeIcons.svg#Function-dark);
+content: url(../Images/TypeIcons.svg#Function-light);
}
.object-tree-property.number > .icon {
-content: url(../Images/TypeIcons.svg#TypeNumber-dark);
+content:
[webkit-changes] [257042] trunk/Source/WebKit
Title: [257042] trunk/Source/WebKit
Revision 257042
Author bb...@apple.com
Date 2020-02-19 22:11:32 -0800 (Wed, 19 Feb 2020)
Log Message
Web Automation: Automation.setWindowFrameOfBrowsingContext should accept negative x and y-origin values
https://bugs.webkit.org/show_bug.cgi?id=207974
Reviewed by Darin Adler.
According to the spec, negative origin values are supported:
https://w3c.github.io/webdriver/#set-window-rect
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (257041 => 257042)
--- trunk/Source/WebKit/ChangeLog 2020-02-20 06:08:12 UTC (rev 257041)
+++ trunk/Source/WebKit/ChangeLog 2020-02-20 06:11:32 UTC (rev 257042)
@@ -1,3 +1,18 @@
+2020-02-19 Brian Burg
+
+Web Automation: Automation.setWindowFrameOfBrowsingContext should accept negative x and y-origin values
+https://bugs.webkit.org/show_bug.cgi?id=207974
+
+
+Reviewed by Darin Adler.
+
+According to the spec, negative origin values are supported:
+
+https://w3c.github.io/webdriver/#set-window-rect
+
+* UIProcess/Automation/WebAutomationSession.cpp:
+(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
+
2020-02-19 Chris Dumez
Resources larger than 10MB are not stored in the disk cache
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (257041 => 257042)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2020-02-20 06:08:12 UTC (rev 257041)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2020-02-20 06:11:32 UTC (rev 257042)
@@ -389,12 +389,6 @@
if (!(y = optionalOriginObject->getNumber("y"_s)))
ASYNC_FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(MissingParameter, "The 'y' parameter was not found or invalid.");
-
-if (x.value() < 0)
-ASYNC_FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(InvalidParameter, "The 'x' parameter had an invalid value.");
-
-if (y.value() < 0)
-ASYNC_FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(InvalidParameter, "The 'y' parameter had an invalid value.");
}
Optional width;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257041] trunk/Source/WebKit
Title: [257041] trunk/Source/WebKit
Revision 257041
Author cdu...@apple.com
Date 2020-02-19 22:08:12 -0800 (Wed, 19 Feb 2020)
Log Message
Resources larger than 10MB are not stored in the disk cache
https://bugs.webkit.org/show_bug.cgi?id=207967
Reviewed by Darin Adler.
This patch makes two policy changes to our disk cache:
1. The capacity of the disk cache is now doubled. Based on available disk space, it could
previously use up to 500MB of disk space. The limit is now 1GB.
2. The per cache-entry limit is raised from 10MB to 1/8 of the disk cache capacity (so
up to 128MB based on new maximum capacity).
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveBuffer):
* Shared/CacheModel.cpp:
(WebKit::calculateURLCacheSizes):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/Shared/CacheModel.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (257040 => 257041)
--- trunk/Source/WebKit/ChangeLog 2020-02-20 05:36:56 UTC (rev 257040)
+++ trunk/Source/WebKit/ChangeLog 2020-02-20 06:08:12 UTC (rev 257041)
@@ -1,3 +1,22 @@
+2020-02-19 Chris Dumez
+
+Resources larger than 10MB are not stored in the disk cache
+https://bugs.webkit.org/show_bug.cgi?id=207967
+
+
+Reviewed by Darin Adler.
+
+This patch makes two policy changes to our disk cache:
+1. The capacity of the disk cache is now doubled. Based on available disk space, it could
+ previously use up to 500MB of disk space. The limit is now 1GB.
+2. The per cache-entry limit is raised from 10MB to 1/8 of the disk cache capacity (so
+ up to 128MB based on new maximum capacity).
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::didReceiveBuffer):
+* Shared/CacheModel.cpp:
+(WebKit::calculateURLCacheSizes):
+
2020-02-19 Maciej Stachowiak
Use consistent capitalization and spacing in process-related feature names
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (257040 => 257041)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2020-02-20 05:36:56 UTC (rev 257040)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2020-02-20 06:08:12 UTC (rev 257041)
@@ -584,8 +584,8 @@
ASSERT(!m_cacheEntryForValidation);
if (m_bufferedDataForCache) {
-// Prevent memory growth in case of streaming data.
-const size_t maximumCacheBufferSize = 10 * 1024 * 1024;
+// Prevent memory growth in case of streaming data and limit size of entries in the cache.
+const size_t maximumCacheBufferSize = m_cache->capacity() / 8;
if (m_bufferedDataForCache->size() + buffer->size() <= maximumCacheBufferSize)
m_bufferedDataForCache->append(buffer.get());
else
Modified: trunk/Source/WebKit/Shared/CacheModel.cpp (257040 => 257041)
--- trunk/Source/WebKit/Shared/CacheModel.cpp 2020-02-20 05:36:56 UTC (rev 257040)
+++ trunk/Source/WebKit/Shared/CacheModel.cpp 2020-02-20 06:08:12 UTC (rev 257041)
@@ -185,17 +185,17 @@
// Disk cache capacity (in bytes)
if (diskFreeSize >= 16384)
+urlCacheDiskCapacity = 1 * GB;
+else if (diskFreeSize >= 8192)
urlCacheDiskCapacity = 500 * MB;
-else if (diskFreeSize >= 8192)
+else if (diskFreeSize >= 4096)
urlCacheDiskCapacity = 250 * MB;
-else if (diskFreeSize >= 4096)
-urlCacheDiskCapacity = 125 * MB;
else if (diskFreeSize >= 2048)
-urlCacheDiskCapacity = 100 * MB;
+urlCacheDiskCapacity = 200 * MB;
else if (diskFreeSize >= 1024)
-urlCacheDiskCapacity = 75 * MB;
+urlCacheDiskCapacity = 150 * MB;
else
-urlCacheDiskCapacity = 50 * MB;
+urlCacheDiskCapacity = 100 * MB;
break;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257040] trunk/Source/WebKit
Title: [257040] trunk/Source/WebKit Revision 257040 Author m...@apple.com Date 2020-02-19 21:36:56 -0800 (Wed, 19 Feb 2020) Log Message Use consistent capitalization and spacing in process-related feature names https://bugs.webkit.org/show_bug.cgi?id=207989 Reviewed by Zalan Bujtas. No new tests, we don't test feature flag names. * Shared/WebPreferences.yaml: Adjust some feature names and descriptions. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferences.yaml Diff Modified: trunk/Source/WebKit/ChangeLog (257039 => 257040) --- trunk/Source/WebKit/ChangeLog 2020-02-20 03:51:21 UTC (rev 257039) +++ trunk/Source/WebKit/ChangeLog 2020-02-20 05:36:56 UTC (rev 257040) @@ -1,3 +1,14 @@ +2020-02-19 Maciej Stachowiak + +Use consistent capitalization and spacing in process-related feature names +https://bugs.webkit.org/show_bug.cgi?id=207989 + +Reviewed by Zalan Bujtas. + +No new tests, we don't test feature flag names. + +* Shared/WebPreferences.yaml: Adjust some feature names and descriptions. + 2020-02-19 Youenn Fablet Add support for AudioSession handling in GPUProcess for capture Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (257039 => 257040) --- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-02-20 03:51:21 UTC (rev 257039) +++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-02-20 05:36:56 UTC (rev 257040) @@ -1456,7 +1456,7 @@ type: bool defaultValue: DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED humanReadableName: "Swap Processes on Cross-Site Navigation" - humanReadableDescription: "Swap WebContent processes on cross-site navigations" + humanReadableDescription: "Swap WebContent Processes on cross-site navigations" category: experimental webcoreBinding: none @@ -1527,8 +1527,8 @@ CaptureVideoInUIProcessEnabled: type: bool defaultValue: false - humanReadableName: "Capture video in UIProcess" - humanReadableDescription: "Enable video capture in UIProcess" + humanReadableName: "Capture video in UI Process" + humanReadableDescription: "Enable video capture in UI Process" category: experimental webcoreBinding: none condition: ENABLE(MEDIA_STREAM) @@ -1536,8 +1536,8 @@ CaptureVideoInGPUProcessEnabled: type: bool defaultValue: false - humanReadableName: "Capture video in GPUProcess" - humanReadableDescription: "Enable video capture in GPUProcess" + humanReadableName: "Capture video in GPU Process" + humanReadableDescription: "Enable video capture in GPU Process" category: internal webcoreBinding: none condition: ENABLE(MEDIA_STREAM) @@ -1726,8 +1726,8 @@ CaptureAudioInUIProcessEnabled: type: bool defaultValue: DEFAULT_CAPTURE_AUDIO_IN_UIPROCESS - humanReadableName: "Capture audio in UIProcess" - humanReadableDescription: "Enable audio capture in UIProcess" + humanReadableName: "Capture Audio in UI Process" + humanReadableDescription: "Enable audio capture in UI Process" category: internal webcoreBinding: none condition: ENABLE(MEDIA_STREAM) @@ -1735,8 +1735,8 @@ CaptureAudioInGPUProcessEnabled: type: bool defaultValue: false - humanReadableName: "Capture audio in GPUProcess" - humanReadableDescription: "Capture audio in GPUProcess" + humanReadableName: "Capture Audio in GPU Process" + humanReadableDescription: "Enable audio capture in GPU Process" category: internal webcoreBinding: none condition: ENABLE(MEDIA_STREAM) @@ -1744,8 +1744,8 @@ RestrictedHTTPResponseAccess: type: bool defaultValue: true - humanReadableName: "Filter HTTP Response for WebProcesses" - humanReadableDescription: "Enable HTTP Response filtering for WebProcesses" + humanReadableName: "Filter HTTP Response for Web Processes" + humanReadableDescription: "Enable HTTP Response filtering for Web Processes" category: internal webcoreBinding: RuntimeEnabledFeatures @@ -1920,8 +1920,8 @@ type: bool defaultValue: false condition: ENABLE(GPU_PROCESS) -humanReadableName: "Media in GPU process" -humanReadableDescription: "Do all media loading and playback in the GPU process" +humanReadableName: "Media in GPU Process" +humanReadableDescription: "Do all media loading and playback in the GPU Process" category: internal webcoreName: useGPUProcessForMedia ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257039] trunk
Title: [257039] trunk Revision 257039 Author you...@apple.com Date 2020-02-19 19:51:21 -0800 (Wed, 19 Feb 2020) Log Message Add support for AudioSession handling in GPUProcess for capture https://bugs.webkit.org/show_bug.cgi?id=207950 Reviewed by Eric Carlson. Source/WebCore: Add a dedicated interface for handling audio capture in session manager. This was previoulsy PlatformMediaSessionClient, but this one is more related to audio/video rendering. Use this new interface for MediaStreamTrack capture sources. The session manager now owns a WeakHashSet of capture sources to compute the correct AudioSession category. Modernize the code, for instance use an enum class for MediaType to remove some debug asserts. Add a new PlatformMediaSessionManager::create that is used for sharedManager. Remove the direct use of PlatformMediaSessionManager::sharedManager from classes that can be used outside of WebProcess. This includes BaseAudioSharedUnit, for which we add a audioUnitWillStart callback so that we compute the right AudioSession category before starting the capture. Covered by existing tests and debug assertions to check for AudioSession category computation. * Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::MediaStreamTrack): (WebCore::MediaStreamTrack::~MediaStreamTrack): (WebCore::MediaStreamTrack::configureTrackRendering): (WebCore::MediaStreamTrack::isCapturingAudio const): * Modules/mediastream/MediaStreamTrack.h: * Modules/webaudio/AudioContext.h: * html/HTMLAudioElement.h: * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::shouldDisableSleep const): (WebCore::HTMLMediaElement::mediaType const): (WebCore::HTMLMediaElement::presentationType const): * html/HTMLVideoElement.h: * html/MediaElementSession.cpp: (WebCore::MediaElementSession::canShowControlsManager const): * html/MediaElementSession.h: * platform/audio/PlatformMediaSession.cpp: (WebCore::PlatformMediaSession::PlatformMediaSession): (WebCore::PlatformMediaSession::activeAudioSessionRequired const): * platform/audio/PlatformMediaSession.h: * platform/audio/PlatformMediaSessionManager.cpp: (WebCore::sharedPlatformMediaSessionManager): (WebCore::PlatformMediaSessionManager::sharedManager): (WebCore::PlatformMediaSessionManager::sharedManagerIfExists): (WebCore::PlatformMediaSessionManager::create): (WebCore::indexFromMediaType): (WebCore::PlatformMediaSessionManager::resetRestrictions): (WebCore::PlatformMediaSessionManager::has const): (WebCore::PlatformMediaSessionManager::count const): (WebCore::PlatformMediaSessionManager::countActiveAudioCaptureSources): (WebCore::PlatformMediaSessionManager::addRestriction): (WebCore::PlatformMediaSessionManager::removeRestriction): (WebCore::PlatformMediaSessionManager::restrictions): (WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback): (WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive): (WebCore::PlatformMediaSessionManager::applicationDidBecomeActive): (WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): (WebCore::PlatformMediaSessionManager::applicationWillEnterForeground): (WebCore::PlatformMediaSessionManager::sessionIsPlayingToWirelessPlaybackTargetChanged): (WebCore::PlatformMediaSessionManager::addAudioCaptureSource): (WebCore::PlatformMediaSessionManager::removeAudioCaptureSource): * platform/audio/PlatformMediaSessionManager.h: * platform/audio/cocoa/MediaSessionManagerCocoa.mm: (PlatformMediaSessionManager::create): (MediaSessionManagerCocoa::updateSessionState): * platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::PlatformMediaSessionManager::create): (WebCore::MediaSessionManageriOS::resetRestrictions): * platform/mediastream/MediaStreamTrackPrivate.cpp: (WebCore::MediaStreamTrackPrivate::audioUnitWillStart): * platform/mediastream/MediaStreamTrackPrivate.h: * platform/mediastream/RealtimeMediaSource.h: * platform/mediastream/mac/BaseAudioSharedUnit.cpp: (WebCore::BaseAudioSharedUnit::startUnit): * platform/mediastream/mac/BaseAudioSharedUnit.h: * platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSource::audioUnitWillStart): * platform/mediastream/mac/CoreAudioCaptureSource.h: * testing/Internals.cpp: (WebCore::mediaTypeFromString): (WebCore::Internals::setMediaSessionRestrictions): (WebCore::Internals::mediaSessionRestrictions const): Source/WebKit: Create a session manager for the GPUConnectionToWebProcess. Pass it to any audio capture source proxy. For UIProcesss audio capture, we still use the shared manager. * GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::sessionManager): * GPUProcess/GPUConnectionToWebProcess.h: * GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::setMockCaptureDevicesEnabled): * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: (WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy): (WebKit::UserMediaCaptureManagerProxy::SourceProxy::~SourceProxy):
[webkit-changes] [257037] branches/safari-609-branch/Source/WebCore
Title: [257037] branches/safari-609-branch/Source/WebCore Revision 257037 Author alanc...@apple.com Date 2020-02-19 19:48:09 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59611915 Modified Paths branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/html/HTMLMediaElement.cpp branches/safari-609-branch/Source/WebCore/html/HTMLMediaElementEnums.h branches/safari-609-branch/Source/WebCore/html/shadow/MediaControlElements.cpp branches/safari-609-branch/Source/WebCore/html/shadow/MediaControlElements.h branches/safari-609-branch/Source/WebCore/platform/graphics/TextTrackRepresentation.cpp branches/safari-609-branch/Source/WebCore/platform/graphics/TextTrackRepresentation.h branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManagerObjC.h branches/safari-609-branch/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManagerObjC.mm branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.h branches/safari-609-branch/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm branches/safari-609-branch/Source/WebCore/rendering/RenderMediaControlElements.cpp Diff Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (257036 => 257037) --- branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-20 03:36:53 UTC (rev 257036) +++ branches/safari-609-branch/Source/WebCore/ChangeLog 2020-02-20 03:48:09 UTC (rev 257037) @@ -1,5 +1,83 @@ 2020-02-19 Russell Epstein +Apply patch. rdar://problem/59611915 + +2020-02-19 Eric Carlson + +Captions sometimes render at the wrong size when in fullscreen and PiP +https://bugs.webkit.org/show_bug.cgi?id=207389 + + +The TextTrackRepresentation, used to render captions when in fullscreen and PiP on +iOS and and in PiP on macOS, frequently rendered captions before layout completed +immediately after it was created. Fix this by having it not render until a layout +happens. Additionally, make the code more efficient by hiding the TextTrackRepresentation's +backing layer when cues are not visible instead of destroying the whole object. +Drive by: RELEASE_LOG_DISABLED is always defined for PLATFORM(COCOA), so remove it +from the macOS/iOS media players to make it easier to add logging to VideoFullscreenLayerManagerObjC. + + +* html/HTMLMediaElement.cpp: +(WebCore::convertEnumerationToString): +(WebCore::HTMLMediaElement::configureTextTrackDisplay): +* html/HTMLMediaElementEnums.h: +(WTF::LogArgument::toString): +* html/shadow/MediaControlElements.cpp: +(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): +(WebCore::MediaControlTextTrackContainerElement::updateDisplay): +(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation): +(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation): +(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentationStyle): +(WebCore::MediaControlTextTrackContainerElement::layoutIfNecessary): +(WebCore::MediaControlTextTrackContainerElement::updateVideoDisplaySize): +(WebCore::MediaControlTextTrackContainerElement::updateSizes): +(WebCore::MediaControlTextTrackContainerElement::updateCueStyles): +(WebCore::MediaControlTextTrackContainerElement::logger const): +(WebCore::MediaControlTextTrackContainerElement::logIdentifier const): +(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Deleted. +(WebCore::MediaControlTextTrackContainerElement::updateStyleForTextTrackRepresentation): Deleted. +* platform/graphics/TextTrackRepresentation.h: +* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: +(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): +(WebCore::MediaPlayerPrivateAVFoundation::logChannel const): +* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: +*
[webkit-changes] [257038] branches/safari-609-branch
Title: [257038] branches/safari-609-branch Revision 257038 Author alanc...@apple.com Date 2020-02-19 19:48:16 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59611912 Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/LayoutTests/TestExpectations branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events-expected.txt branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events-expected.txt branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/animation/AnimationTimeline.cpp branches/safari-609-branch/Source/WebCore/animation/AnimationTimeline.h branches/safari-609-branch/Source/WebCore/animation/CSSAnimation.cpp branches/safari-609-branch/Source/WebCore/animation/CSSAnimation.h branches/safari-609-branch/Source/WebCore/animation/KeyframeEffect.cpp branches/safari-609-branch/Source/WebCore/animation/KeyframeEffect.h branches/safari-609-branch/Source/WebCore/style/StyleTreeResolver.cpp Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (257037 => 257038) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-02-20 03:48:09 UTC (rev 257037) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-02-20 03:48:16 UTC (rev 257038) @@ -1,3 +1,19 @@ +2020-02-19 Alan Coon + +Apply patch. rdar://problem/59611912 + +2020-02-19 Antoine Quint + +[Web Animations] Style changes due to Web Animations should not trigger CSS Transitions +https://bugs.webkit.org/show_bug.cgi?id=207760 + + +Reviewed by Simon Fraser. + +Mark that a couple of tests are no longer flaky. + +* TestExpectations: + 2020-02-19 Russell Epstein Cherry-pick r256859. rdar://problem/59576018 Modified: branches/safari-609-branch/LayoutTests/TestExpectations (257037 => 257038) --- branches/safari-609-branch/LayoutTests/TestExpectations 2020-02-20 03:48:09 UTC (rev 257037) +++ branches/safari-609-branch/LayoutTests/TestExpectations 2020-02-20 03:48:16 UTC (rev 257038) @@ -2651,9 +2651,6 @@ webkit.org/b/179069 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/sandbox_032.htm [ Pass Failure ] -webkit.org/b/202107 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events.html [ Pass Failure ] -webkit.org/b/202108 imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events.html [ Pass Failure ] - webkit.org/b/157068 [ Debug ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Crash ] webkit.org/b/157068 [ Release ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Failure ] Modified: branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog (257037 => 257038) --- branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog 2020-02-20 03:48:09 UTC (rev 257037) +++ branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog 2020-02-20 03:48:16 UTC (rev 257038) @@ -1,3 +1,22 @@ +2020-02-19 Alan Coon + +Apply patch. rdar://problem/59611912 + +2020-02-19 Antoine Quint + +[Web Animations] Style changes due to Web Animations should not trigger CSS Transitions +https://bugs.webkit.org/show_bug.cgi?id=207760 + + +Reviewed by Simon Fraser. + +Mark Web Platform Tests progressions. + +* web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt: +* web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt: +* web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events-expected.txt: +* web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events-expected.txt: + 2020-02-18 Alan Coon Apply patch. rdar://problem/59465474 Modified: branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt (257037 => 257038) --- branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt 2020-02-20 03:48:09 UTC (rev 257037) +++ branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt 2020-02-20 03:48:16 UTC (rev 257038) @@ -132,7 +132,7 @@ PASS Element.animate() correctly sets the Animation's
[webkit-changes] [257036] trunk
Title: [257036] trunk
Revision 257036
Author commit-qu...@webkit.org
Date 2020-02-19 19:36:53 -0800 (Wed, 19 Feb 2020)
Log Message
Fix crash when Node::normalize() triggers mutation event that modifies child order
https://bugs.webkit.org/show_bug.cgi?id=207875
Patch by Sunny He on 2020-02-19
Reviewed by Ryosuke Niwa.
When Node::normalize() merges two text nodes, it calls appendData
before textNodesMerged. If there is a mutator event registered, it
will fire on the call to appendData, potentially changing the child
order and causing a nullptr crash due to incorrect sibling pointers.
Reverse the order of these calls to ensure order gets correctly
updated.
Source/WebCore:
Test: fast/dom/Node/normalize-mutation-event.html
* dom/Node.cpp:
(WebCore::Node::normalize):
LayoutTests:
* fast/dom/Node/normalize-mutation-event-expected.txt: Added.
* fast/dom/Node/normalize-mutation-event.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
Added Paths
trunk/LayoutTests/fast/dom/Node/normalize-mutation-event-expected.txt
trunk/LayoutTests/fast/dom/Node/normalize-mutation-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (257035 => 257036)
--- trunk/LayoutTests/ChangeLog 2020-02-20 03:25:30 UTC (rev 257035)
+++ trunk/LayoutTests/ChangeLog 2020-02-20 03:36:53 UTC (rev 257036)
@@ -1,3 +1,21 @@
+2020-02-19 Sunny He
+
+Fix crash when Node::normalize() triggers mutation event that modifies child order
+https://bugs.webkit.org/show_bug.cgi?id=207875
+
+
+Reviewed by Ryosuke Niwa.
+
+When Node::normalize() merges two text nodes, it calls appendData
+before textNodesMerged. If there is a mutator event registered, it
+will fire on the call to appendData, potentially changing the child
+order and causing a nullptr crash due to incorrect sibling pointers.
+Reverse the order of these calls to ensure order gets correctly
+updated.
+
+* fast/dom/Node/normalize-mutation-event-expected.txt: Added.
+* fast/dom/Node/normalize-mutation-event.html: Added.
+
2020-02-19 Diego Pino Garcia
[GTK][WPE] Gardening, update baselines of websocket tests
Added: trunk/LayoutTests/fast/dom/Node/normalize-mutation-event-expected.txt (0 => 257036)
--- trunk/LayoutTests/fast/dom/Node/normalize-mutation-event-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Node/normalize-mutation-event-expected.txt 2020-02-20 03:36:53 UTC (rev 257036)
@@ -0,0 +1 @@
+Test that normalize() behaves correctly in the presence of a mutation event that modifies the child order. PASS if test does not crash. abc
Added: trunk/LayoutTests/fast/dom/Node/normalize-mutation-event.html (0 => 257036)
--- trunk/LayoutTests/fast/dom/Node/normalize-mutation-event.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Node/normalize-mutation-event.html 2020-02-20 03:36:53 UTC (rev 257036)
@@ -0,0 +1,18 @@
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function eventhandler() {
+document.body.appendChild(document.body.firstChild);
+}
+function run() {
+document.caretRangeFromPoint(0,0);
+document.body.firstChild.after("abc")
+document.body.firstChild.addEventListener("DOMSubtreeModified", eventhandler);
+element.getRootNode().normalize();
+}
+
+
+Test that normalize() behaves correctly in the presence of a mutation event that modifies the child order. PASS if test does not crash.
+
+
Modified: trunk/Source/WebCore/ChangeLog (257035 => 257036)
--- trunk/Source/WebCore/ChangeLog 2020-02-20 03:25:30 UTC (rev 257035)
+++ trunk/Source/WebCore/ChangeLog 2020-02-20 03:36:53 UTC (rev 257036)
@@ -1,3 +1,23 @@
+2020-02-19 Sunny He
+
+Fix crash when Node::normalize() triggers mutation event that modifies child order
+https://bugs.webkit.org/show_bug.cgi?id=207875
+
+
+Reviewed by Ryosuke Niwa.
+
+When Node::normalize() merges two text nodes, it calls appendData
+before textNodesMerged. If there is a mutator event registered, it
+will fire on the call to appendData, potentially changing the child
+order and causing a nullptr crash due to incorrect sibling pointers.
+Reverse the order of these calls to ensure order gets correctly
+updated.
+
+Test: fast/dom/Node/normalize-mutation-event.html
+
+* dom/Node.cpp:
+(WebCore::Node::normalize):
+
2020-02-19 Peng Liu
Fix check-webkit-style errors related to AVFoundationSPI.h
Modified: trunk/Source/WebCore/dom/Node.cpp (257035 => 257036)
--- trunk/Source/WebCore/dom/Node.cpp 2020-02-20 03:25:30 UTC (rev 257035)
+++ trunk/Source/WebCore/dom/Node.cpp 2020-02-20 03:36:53 UTC (rev 257036)
@@ -670,8 +670,13 @@
// Both non-empty text nodes. Merge them.
unsigned offset =
[webkit-changes] [257034] trunk
Title: [257034] trunk
Revision 257034
Author ross.kirsl...@sony.com
Date 2020-02-19 19:01:03 -0800 (Wed, 19 Feb 2020)
Log Message
Computed Properties with increment sometimes produces incorrect results
https://bugs.webkit.org/show_bug.cgi?id=170934
Reviewed by Yusuke Suzuki.
JSTests:
* stress/computed-property-increment.js: Added.
* test262/expectations.yaml: Mark two test cases as passing.
Source/_javascript_Core:
When the key and value of a computed property each have side effects, the eval order should be key-before-value.
Not only have we had this backwards, we've also been giving them both the same target register.
* bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitPutConstantProperty):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
Added Paths
trunk/JSTests/stress/computed-property-increment.js
Diff
Modified: trunk/JSTests/ChangeLog (257033 => 257034)
--- trunk/JSTests/ChangeLog 2020-02-20 03:00:03 UTC (rev 257033)
+++ trunk/JSTests/ChangeLog 2020-02-20 03:01:03 UTC (rev 257034)
@@ -1,3 +1,13 @@
+2020-02-19 Ross Kirsling
+
+Computed Properties with increment sometimes produces incorrect results
+https://bugs.webkit.org/show_bug.cgi?id=170934
+
+Reviewed by Yusuke Suzuki.
+
+* stress/computed-property-increment.js: Added.
+* test262/expectations.yaml: Mark two test cases as passing.
+
2020-02-19 Keith Miller
Disable Wasm reference types by default
Added: trunk/JSTests/stress/computed-property-increment.js (0 => 257034)
--- trunk/JSTests/stress/computed-property-increment.js (rev 0)
+++ trunk/JSTests/stress/computed-property-increment.js 2020-02-20 03:01:03 UTC (rev 257034)
@@ -0,0 +1,18 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error(`expected ${expected} but got ${actual}`);
+}
+
+function test() {
+let c = 0;
+shouldBe(`${Object.entries({ [++c]: ++c })}`, '1,2');
+
+{
+let c = 0;
+shouldBe(`${Object.entries({ [++c]: ++c })}`, '1,2');
+}
+}
+noInline(test);
+
+for (let i = 0; i < 1; i++)
+ test();
Modified: trunk/JSTests/test262/expectations.yaml (257033 => 257034)
--- trunk/JSTests/test262/expectations.yaml 2020-02-20 03:00:03 UTC (rev 257033)
+++ trunk/JSTests/test262/expectations.yaml 2020-02-20 03:01:03 UTC (rev 257034)
@@ -2808,9 +2808,6 @@
test/language/expressions/object/__proto__-permitted-dup.js:
default: 'SyntaxError: Attempted to redefine __proto__ property.'
strict mode: 'SyntaxError: Attempted to redefine __proto__ property.'
-test/language/expressions/object/computed-property-evaluation-order.js:
- default: 'Test262Error: Expected SameValue(«2», «1») to be true'
- strict mode: 'Test262Error: Expected SameValue(«2», «1») to be true'
test/language/expressions/object/covered-ident-name-prop-name-literal-break-escaped.js:
default: "SyntaxError: Unexpected escaped characters in keyword token: 'bre\\u0061k'"
strict mode: "SyntaxError: Unexpected escaped characters in keyword token: 'bre\\u0061k'"
Modified: trunk/Source/_javascript_Core/ChangeLog (257033 => 257034)
--- trunk/Source/_javascript_Core/ChangeLog 2020-02-20 03:00:03 UTC (rev 257033)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-02-20 03:01:03 UTC (rev 257034)
@@ -1,3 +1,16 @@
+2020-02-19 Ross Kirsling
+
+Computed Properties with increment sometimes produces incorrect results
+https://bugs.webkit.org/show_bug.cgi?id=170934
+
+Reviewed by Yusuke Suzuki.
+
+When the key and value of a computed property each have side effects, the eval order should be key-before-value.
+Not only have we had this backwards, we've also been giving them both the same target register.
+
+* bytecompiler/NodesCodegen.cpp:
+(JSC::PropertyListNode::emitPutConstantProperty):
+
2020-02-19 Keith Miller
Disable Wasm reference types by default
Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (257033 => 257034)
--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2020-02-20 03:00:03 UTC (rev 257033)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2020-02-20 03:01:03 UTC (rev 257034)
@@ -713,6 +713,17 @@
void PropertyListNode::emitPutConstantProperty(BytecodeGenerator& generator, RegisterID* newObj, PropertyNode& node)
{
+bool shouldSetFunctionName = generator.shouldSetFunctionName(node.m_assign);
+
+RefPtr propertyName;
+if (!node.name()) {
+propertyName = generator.newTemporary();
+if (shouldSetFunctionName)
+generator.emitToPropertyKey(propertyName.get(), generator.emitNode(node.m_expression));
+else
+generator.emitNode(propertyName.get(), node.m_expression);
+}
+
RefPtr value =
[webkit-changes] [257032] branches/safari-609-branch/Source/WebKit
Title: [257032] branches/safari-609-branch/Source/WebKit
Revision 257032
Author alanc...@apple.com
Date 2020-02-19 18:59:58 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r257013. rdar://problem/59614282
Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
https://bugs.webkit.org/show_bug.cgi?id=207973
Reviewed by Chris Dumez.
Use RefPtr to store Frame*.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (257031 => 257032)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-20 02:59:53 UTC (rev 257031)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-20 02:59:58 UTC (rev 257032)
@@ -1,5 +1,34 @@
2020-02-19 Russell Epstein
+Cherry-pick r257013. rdar://problem/59614282
+
+Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
+https://bugs.webkit.org/show_bug.cgi?id=207973
+
+Reviewed by Chris Dumez.
+
+Use RefPtr to store Frame*.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-19 Ryosuke Niwa
+
+Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
+https://bugs.webkit.org/show_bug.cgi?id=207973
+
+Reviewed by Chris Dumez.
+
+Use RefPtr to store Frame*.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+
+2020-02-19 Russell Epstein
+
Cherry-pick r256859. rdar://problem/59576018
[macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
Modified: branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (257031 => 257032)
--- branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-02-20 02:59:53 UTC (rev 257031)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-02-20 02:59:58 UTC (rev 257032)
@@ -4227,7 +4227,7 @@
{
PageClientProtector protector(pageClient());
-WebFrameProxy* frame = process->webFrame(frameID);
+auto frame = makeRefPtr(process->webFrame(frameID));
MESSAGE_CHECK(process, frame);
MESSAGE_CHECK_URL(process, url);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257031] branches/safari-609-branch
Title: [257031] branches/safari-609-branch Revision 257031 Author alanc...@apple.com Date 2020-02-19 18:59:53 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256859. rdar://problem/59576018 [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded https://bugs.webkit.org/show_bug.cgi?id=207899 Reviewed by Tim Horton and Simon Fraser. Source/WebCore: Mitigates a null pointer crash in ServicesOverlayController::buildPotentialHighlightsIfNeeded(), wherein the focused frame may not have a FrameView when the ServicesOverlayController's selection invalidation timer fires. This is possible if, while being focused, the newly focused subframe is unparented and reparented, which causes it to momentarily have a null view. During this time, if a selection change had occurred earlier in the runloop, it will schedule the page overlay controller invalidation timer, which will fire and discover that the currently focused frame no longer has a FrameView. Test: editing/selection/selection-change-in-disconnected-frame-crash.html * page/mac/ServicesOverlayController.mm: (WebCore::ServicesOverlayController::buildSelectionHighlight): Source/WebKit: Add another missing null check on iOS, for the case where FrameView is null. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::platformEditorState const): Tools: Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag. * WebKitTestRunner/TestController.cpp: (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: (WTR::TestOptions::hasSameInitializationOptions const): * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView): LayoutTests: Add a new layout test to verify that we don't crash under this circumstance. * editing/selection/selection-change-in-disconnected-frame-crash-expected.txt: Added. * editing/selection/selection-change-in-disconnected-frame-crash.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256859 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609-branch/LayoutTests/ChangeLog branches/safari-609-branch/Source/WebCore/ChangeLog branches/safari-609-branch/Source/WebCore/page/mac/ServicesOverlayController.mm branches/safari-609-branch/Source/WebKit/ChangeLog branches/safari-609-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm branches/safari-609-branch/Tools/ChangeLog branches/safari-609-branch/Tools/WebKitTestRunner/TestController.cpp branches/safari-609-branch/Tools/WebKitTestRunner/TestOptions.h branches/safari-609-branch/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm Added Paths branches/safari-609-branch/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash-expected.txt branches/safari-609-branch/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash.html Diff Modified: branches/safari-609-branch/LayoutTests/ChangeLog (257030 => 257031) --- branches/safari-609-branch/LayoutTests/ChangeLog 2020-02-20 02:59:46 UTC (rev 257030) +++ branches/safari-609-branch/LayoutTests/ChangeLog 2020-02-20 02:59:53 UTC (rev 257031) @@ -1,3 +1,67 @@ +2020-02-19 Russell Epstein + +Cherry-pick r256859. rdar://problem/59576018 + +[macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded +https://bugs.webkit.org/show_bug.cgi?id=207899 + + +Reviewed by Tim Horton and Simon Fraser. + +Source/WebCore: + +Mitigates a null pointer crash in ServicesOverlayController::buildPotentialHighlightsIfNeeded(), wherein the +focused frame may not have a FrameView when the ServicesOverlayController's selection invalidation timer fires. +This is possible if, while being focused, the newly focused subframe is unparented and reparented, which causes +it to momentarily have a null view. During this time, if a selection change had occurred earlier in the runloop, +it will schedule the page overlay controller invalidation timer, which will fire and discover that the currently +focused frame no longer has a FrameView. + +Test: editing/selection/selection-change-in-disconnected-frame-crash.html + +* page/mac/ServicesOverlayController.mm: +(WebCore::ServicesOverlayController::buildSelectionHighlight): + +Source/WebKit: + +Add another missing null check on iOS, for the case where FrameView is null. + +* WebProcess/WebPage/ios/WebPageIOS.mm: +(WebKit::WebPage::platformEditorState const): + +Tools: + +Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag. + +* WebKitTestRunner/TestController.cpp: +(WTR::updateTestOptionsFromTestHeader): +* WebKitTestRunner/TestOptions.h: +
[webkit-changes] [257030] branches/safari-609-branch/Source/WebKit
Title: [257030] branches/safari-609-branch/Source/WebKit
Revision 257030
Author alanc...@apple.com
Date 2020-02-19 18:59:46 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256790. rdar://problem/59576023
Data detectors do not trigger on macCatalyst
https://bugs.webkit.org/show_bug.cgi?id=207860
Reviewed by Tim Horton.
The lookup gesture which run data detection needs touch information to function. Allow touches to be sent to the gesture.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (257029 => 257030)
--- branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-20 02:43:58 UTC (rev 257029)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog 2020-02-20 02:59:46 UTC (rev 257030)
@@ -1,3 +1,34 @@
+2020-02-19 Russell Epstein
+
+Cherry-pick r256790. rdar://problem/59576023
+
+Data detectors do not trigger on macCatalyst
+https://bugs.webkit.org/show_bug.cgi?id=207860
+
+
+Reviewed by Tim Horton.
+
+The lookup gesture which run data detection needs touch information to function. Allow touches to be sent to the gesture.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-17 Megan Gardner
+
+Data detectors do not trigger on macCatalyst
+https://bugs.webkit.org/show_bug.cgi?id=207860
+
+
+Reviewed by Tim Horton.
+
+The lookup gesture which run data detection needs touch information to function. Allow touches to be sent to the gesture.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
+
2020-02-18 Alan Coon
Cherry-pick r256191. rdar://problem/59447003
Modified: branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (257029 => 257030)
--- branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-02-20 02:43:58 UTC (rev 257029)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-02-20 02:59:46 UTC (rev 257030)
@@ -1514,7 +1514,7 @@
- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceiveTouch:(UITouch *)touch
{
#if HAVE(HOVER_GESTURE_RECOGNIZER)
-if (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch)
+if (gestureRecognizer != _lookupGestureRecognizer && (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch))
return NO;
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257033] branches/safari-609-branch/Source/JavaScriptCore
Title: [257033] branches/safari-609-branch/Source/_javascript_Core
Revision 257033
Author alanc...@apple.com
Date 2020-02-19 19:00:03 -0800 (Wed, 19 Feb 2020)
Log Message
Apply patch. rdar://problem/59611919
Modified Paths
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/runtime/Structure.cpp
branches/safari-609-branch/Source/_javascript_Core/runtime/Structure.h
branches/safari-609-branch/Source/_javascript_Core/runtime/StructureTransitionTable.h
Diff
Modified: branches/safari-609-branch/Source/_javascript_Core/ChangeLog (257032 => 257033)
--- branches/safari-609-branch/Source/_javascript_Core/ChangeLog 2020-02-20 02:59:58 UTC (rev 257032)
+++ branches/safari-609-branch/Source/_javascript_Core/ChangeLog 2020-02-20 03:00:03 UTC (rev 257033)
@@ -1,3 +1,33 @@
+2020-02-19 Alan Coon
+
+Apply patch. rdar://problem/59611919
+
+2020-02-19 Yusuke Suzuki
+
+[JSC] Compact StructureTransitionTable
+https://bugs.webkit.org/show_bug.cgi?id=207616
+
+Reviewed by Mark Lam.
+
+Some of StructureTransitionTable are shown as very large HashMap and we can compact it by encoding key.
+We leverage 48bit pointers and 8byte alignment of UniquedStringImpl* to encode other parameters into it.
+
+* runtime/Structure.cpp:
+(JSC::StructureTransitionTable::contains const):
+(JSC::StructureTransitionTable::get const):
+(JSC::StructureTransitionTable::add):
+* runtime/Structure.h:
+* runtime/StructureTransitionTable.h:
+(JSC::StructureTransitionTable::Hash::Key::Key):
+(JSC::StructureTransitionTable::Hash::Key::isHashTableDeletedValue const):
+(JSC::StructureTransitionTable::Hash::Key::impl const):
+(JSC::StructureTransitionTable::Hash::Key::isAddition const):
+(JSC::StructureTransitionTable::Hash::Key::attributes const):
+(JSC::StructureTransitionTable::Hash::Key::operator==):
+(JSC::StructureTransitionTable::Hash::Key::operator!=):
+(JSC::StructureTransitionTable::Hash::hash):
+(JSC::StructureTransitionTable::Hash::equal):
+
2020-02-18 Simon Fraser
Unreviewed build fix.
Modified: branches/safari-609-branch/Source/_javascript_Core/runtime/Structure.cpp (257032 => 257033)
--- branches/safari-609-branch/Source/_javascript_Core/runtime/Structure.cpp 2020-02-20 02:59:58 UTC (rev 257032)
+++ branches/safari-609-branch/Source/_javascript_Core/runtime/Structure.cpp 2020-02-20 03:00:03 UTC (rev 257033)
@@ -93,7 +93,7 @@
Structure* transition = singleTransition();
return transition && transition->m_nameInPrevious == rep && transition->attributesInPrevious() == attributes;
}
-return map()->get(std::make_pair(rep, attributes));
+return map()->get(StructureTransitionTable::Hash::Key(rep, attributes, false));
}
inline Structure* StructureTransitionTable::get(UniquedStringImpl* rep, unsigned attributes) const
@@ -102,7 +102,7 @@
Structure* transition = singleTransition();
return (transition && transition->m_nameInPrevious == rep && transition->attributesInPrevious() == attributes) ? transition : 0;
}
-return map()->get(std::make_pair(rep, attributes));
+return map()->get(StructureTransitionTable::Hash::Key(rep, attributes, false));
}
void StructureTransitionTable::add(VM& vm, Structure* structure)
@@ -123,11 +123,7 @@
}
// Add the structure to the map.
-
-// Newer versions of the STL have an std::make_pair function that takes rvalue references.
-// When either of the parameters are bitfields, the C++ compiler will try to bind them as lvalues, which is invalid. To work around this, use unary "+" to make the parameter an rvalue.
-// See https://bugs.webkit.org/show_bug.cgi?id=59261 for more details
-map()->set(std::make_pair(structure->m_nameInPrevious.get(), +structure->attributesInPrevious()), structure);
+map()->set(StructureTransitionTable::Hash::Key(structure->m_nameInPrevious.get(), +structure->attributesInPrevious(), false), structure);
}
void Structure::dumpStatistics()
Modified: branches/safari-609-branch/Source/_javascript_Core/runtime/Structure.h (257032 => 257033)
--- branches/safari-609-branch/Source/_javascript_Core/runtime/Structure.h 2020-02-20 02:59:58 UTC (rev 257032)
+++ branches/safari-609-branch/Source/_javascript_Core/runtime/Structure.h 2020-02-20 03:00:03 UTC (rev 257033)
@@ -638,6 +638,7 @@
#define DEFINE_BITFIELD(type, lowerName, upperName, width, offset) \
static constexpr uint32_t s_##lowerName##Shift = offset;\
static constexpr uint32_t s_##lowerName##Mask = ((1 << (width - 1)) | ((1 << (width - 1)) - 1));\
+static constexpr uint32_t s_bitWidthOf##upperName = width;\
type lowerName() const { return static_cast((m_bitField >> offset) &
[webkit-changes] [257029] trunk/Source
Title: [257029] trunk/Source
Revision 257029
Author pvol...@apple.com
Date 2020-02-19 18:43:58 -0800 (Wed, 19 Feb 2020)
Log Message
[iOS] Rename NSUserDefaultsSPI.h
https://bugs.webkit.org/show_bug.cgi?id=207977
Source/WebCore/PAL:
Reviewed by Brent Fulgham.
* PAL.xcodeproj/project.pbxproj:
* pal/spi/cocoa/NSUserDefaultsSPI.h: Removed.
* pal/spi/cocoa/UserDefaultsSPI.h: Copied from Source/WebCore/PAL/pal/spi/cocoa/NSUserDefaultsSPI.h.
Source/WebKit:
Reviewed by Brent Fulgham.
No new tests, no behavior change.
* UIProcess/Cocoa/PreferenceObserver.h:
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.h
Added Paths
trunk/Source/WebCore/PAL/pal/spi/cocoa/UserDefaultsSPI.h
Removed Paths
trunk/Source/WebCore/PAL/pal/spi/cocoa/NSUserDefaultsSPI.h
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (257028 => 257029)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-02-20 02:33:45 UTC (rev 257028)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-02-20 02:43:58 UTC (rev 257029)
@@ -1,3 +1,15 @@
+2020-02-19 Per Arne Vollan
+
+[iOS] Rename NSUserDefaultsSPI.h
+https://bugs.webkit.org/show_bug.cgi?id=207977
+
+
+Reviewed by Brent Fulgham.
+
+* PAL.xcodeproj/project.pbxproj:
+* pal/spi/cocoa/NSUserDefaultsSPI.h: Removed.
+* pal/spi/cocoa/UserDefaultsSPI.h: Copied from Source/WebCore/PAL/pal/spi/cocoa/NSUserDefaultsSPI.h.
+
2020-02-17 Chris Dumez
[WK2][Cocoa] Implement in-WebProcess cookie cache to avoid sync IPC for document.cookie in most cases
Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (257028 => 257029)
--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2020-02-20 02:33:45 UTC (rev 257028)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2020-02-20 02:43:58 UTC (rev 257029)
@@ -164,7 +164,7 @@
A3AB6E651F3D217F009C14B1 /* SystemSleepListenerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = A3AB6E631F3D217F009C14B1 /* SystemSleepListenerMac.mm */; };
A3C66CDC1F462D6A009E6EE9 /* SessionID.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */; };
A3C66CDD1F462D6A009E6EE9 /* SessionID.h in Headers */ = {isa = PBXBuildFile; fileRef = A3C66CDB1F462D6A009E6EE9 /* SessionID.h */; };
- C15CBB3523F3548A00300CC7 /* NSUserDefaultsSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ C15CBB3523F3548A00300CC7 /* UserDefaultsSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = C15CBB3223F34A1200300CC7 /* UserDefaultsSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
CDACB3602387425B0018D7CE /* MediaToolboxSoftLink.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDACB35E23873E480018D7CE /* MediaToolboxSoftLink.cpp */; };
CDACB361238742740018D7CE /* MediaToolboxSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = CDACB35F23873E480018D7CE /* MediaToolboxSoftLink.h */; };
CDF91113220E4EEC001EA39E /* CelestialSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CDF91112220E4EEC001EA39E /* CelestialSPI.h */; };
@@ -341,7 +341,7 @@
A3AB6E631F3D217F009C14B1 /* SystemSleepListenerMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SystemSleepListenerMac.mm; sourceTree = ""; };
A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SessionID.cpp; sourceTree = ""; };
A3C66CDB1F462D6A009E6EE9 /* SessionID.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SessionID.h; sourceTree = ""; };
- C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NSUserDefaultsSPI.h; sourceTree = ""; };
+ C15CBB3223F34A1200300CC7 /* UserDefaultsSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = UserDefaultsSPI.h; sourceTree = ""; };
C2147A4A1EFD0AA600056FA5 /* CopyPALHeaders.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = CopyPALHeaders.xcconfig; sourceTree = ""; };
CDACB35E23873E480018D7CE /* MediaToolboxSoftLink.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = MediaToolboxSoftLink.cpp; sourceTree = ""; };
CDACB35F23873E480018D7CE /* MediaToolboxSoftLink.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MediaToolboxSoftLink.h; sourceTree = ""; };
@@ -445,7 +445,6 @@
0C2DA1361F3BEB4900DBC317 /* NSURLConnectionSPI.h */,
0C2DA1371F3BEB4900DBC317 /* NSURLDownloadSPI.h */,
0C2DA1381F3BEB4900DBC317 /* NSURLFileTypeMappingsSPI.h */,
-C15CBB3223F34A1200300CC7 /* NSUserDefaultsSPI.h */,
570AB8F820AF6E3D00B8BE87 /*
[webkit-changes] [257028] tags/Safari-609.1.20.0.2/
Title: [257028] tags/Safari-609.1.20.0.2/ Revision 257028 Author alanc...@apple.com Date 2020-02-19 18:33:45 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.0.2. Added Paths tags/Safari-609.1.20.0.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257027] branches/safari-609.1.20.0-branch/Source/WebCore/platform/ graphics/cg/PDFDocumentImage.cpp
Title: [257027] branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp Revision 257027 Author alanc...@apple.com Date 2020-02-19 18:31:39 -0800 (Wed, 19 Feb 2020) Log Message Unreviewed build fix. Modified Paths branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp Diff Modified: branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp (257026 => 257027) --- branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp 2020-02-20 02:29:38 UTC (rev 257026) +++ branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp 2020-02-20 02:31:39 UTC (rev 257027) @@ -42,6 +42,7 @@ #include "SharedBuffer.h" #include #include +#include #include #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257026] branches/safari-609.1.20.0-branch/Source
Title: [257026] branches/safari-609.1.20.0-branch/Source Revision 257026 Author alanc...@apple.com Date 2020-02-19 18:29:38 -0800 (Wed, 19 Feb 2020) Log Message Versioning. Modified Paths branches/safari-609.1.20.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-609.1.20.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-609.1.20.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-609.1.20.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-609.1.20.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-609.1.20.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-609.1.20.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-609.1.20.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (257025 => 257026) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-20 02:12:53 UTC (rev 257025) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-20 02:29:38 UTC (rev 257026) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (257025 => 257026) --- branches/safari-609.1.20.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-20 02:12:53 UTC (rev 257025) +++ branches/safari-609.1.20.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-20 02:29:38 UTC (rev 257026) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (257025 => 257026) --- branches/safari-609.1.20.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-20 02:12:53 UTC (rev 257025) +++ branches/safari-609.1.20.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-20 02:29:38 UTC (rev 257026) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.0-branch/Source/WebCore/Configurations/Version.xcconfig (257025 => 257026) --- branches/safari-609.1.20.0-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-20 02:12:53 UTC (rev 257025) +++ branches/safari-609.1.20.0-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-20 02:29:38 UTC (rev 257026) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (257025 => 257026) --- branches/safari-609.1.20.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-20 02:12:53 UTC (rev 257025) +++ branches/safari-609.1.20.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-20 02:29:38 UTC (rev 257026) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (257025 => 257026) --- branches/safari-609.1.20.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-02-20 02:12:53 UTC (rev 257025) +++ branches/safari-609.1.20.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-02-20 02:29:38 UTC (rev 257026) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [257025] trunk/Source/WebKit
Title: [257025] trunk/Source/WebKit Revision 257025 Author ysuz...@apple.com Date 2020-02-19 18:12:53 -0800 (Wed, 19 Feb 2020) Log Message NetworkCache should use 4KB threshold for mmap-ed files instead of 16KB https://bugs.webkit.org/show_bug.cgi?id=207882 Reviewed by Alex Christensen. We found that a lot of Vectors in Membuster is holding resource content. This is because we have 16KB threshold for mmap-ed files. If a file is smaller than 16KB, it is copied to Vector instead. But this is costly in terms of memory. If we use mmap-ed files, it becomes named-pages instead of anonymous-pages. File-backed non-dirty named-pages have a lot of benefit. 1. The application is offering a hint that pages are file-backed. This means that OS can purge them at any time since the content can be recovered from the disk. This is cheaper than swapping / compressing anonymous pages since just discarding works. 2. The application is offering a hint that pages have spatial locality. Purging pages in one named-pages region is better compared to purging the same # of anonymous pages randomly. Anonymous pages are split by malloc implementation and access pattern of pages in one VA is random. On the other hand, named-pages are accessed together because it is file, and file typically has sequential locality. And recovery of named pages are also cheap compared to anonymous pages since OS can prefetch pages once access happens because of sequential locality of files. This tendency makes OS like purging named pages instead of anonymous pages. In WebKit use case, this works perfectly. CachedResource typically has decoded content. So typically WebProcess does not access SharedBuffer after the content is decoded. This patch reduces the threshold from 16KB to page size (4KB in macOS, 16KB in iOS). This is pre-2015 behavior. This offers 2.56% progression with 98% probability in Membuster. * NetworkProcess/cache/NetworkCacheStorage.cpp: (WebKit::NetworkCache::maximumInlineBodySize): (WebKit::NetworkCache::estimateRecordsSize): (WebKit::NetworkCache::Storage::shouldStoreBodyAsBlob): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (257024 => 257025) --- trunk/Source/WebKit/ChangeLog 2020-02-20 02:09:04 UTC (rev 257024) +++ trunk/Source/WebKit/ChangeLog 2020-02-20 02:12:53 UTC (rev 257025) @@ -1,3 +1,31 @@ +2020-02-19 Yusuke Suzuki + +NetworkCache should use 4KB threshold for mmap-ed files instead of 16KB +https://bugs.webkit.org/show_bug.cgi?id=207882 + +Reviewed by Alex Christensen. + +We found that a lot of Vectors in Membuster is holding resource content. This is because we have 16KB threshold for mmap-ed files. +If a file is smaller than 16KB, it is copied to Vector instead. But this is costly in terms of memory. If we use mmap-ed files, +it becomes named-pages instead of anonymous-pages. File-backed non-dirty named-pages have a lot of benefit. + +1. The application is offering a hint that pages are file-backed. This means that OS can purge them at any time since the content can be recovered + from the disk. This is cheaper than swapping / compressing anonymous pages since just discarding works. +2. The application is offering a hint that pages have spatial locality. Purging pages in one named-pages region is better compared to purging + the same # of anonymous pages randomly. Anonymous pages are split by malloc implementation and access pattern of pages in one VA is random. On + the other hand, named-pages are accessed together because it is file, and file typically has sequential locality. And recovery of named pages are + also cheap compared to anonymous pages since OS can prefetch pages once access happens because of sequential locality of files. This tendency makes + OS like purging named pages instead of anonymous pages. In WebKit use case, this works perfectly. CachedResource typically has decoded content. So + typically WebProcess does not access SharedBuffer after the content is decoded. + +This patch reduces the threshold from 16KB to page size (4KB in macOS, 16KB in iOS). This is pre-2015 behavior. +This offers 2.56% progression with 98% probability in Membuster. + +* NetworkProcess/cache/NetworkCacheStorage.cpp: +(WebKit::NetworkCache::maximumInlineBodySize): +(WebKit::NetworkCache::estimateRecordsSize): +(WebKit::NetworkCache::Storage::shouldStoreBodyAsBlob): + 2020-02-19 Ryosuke Niwa Crash in WebPageProxy::didStartProvisionalLoadForFrameShared Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp (257024 => 257025) --- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp 2020-02-20 02:09:04 UTC (rev 257024) +++
[webkit-changes] [257024] trunk/Tools
Title: [257024] trunk/Tools
Revision 257024
Author hironori.fu...@sony.com
Date 2020-02-19 18:09:04 -0800 (Wed, 19 Feb 2020)
Log Message
[Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
https://bugs.webkit.org/show_bug.cgi?id=207749
Reviewed by Ross Kirsling.
Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
* MiniBrowser/win/MainWindow.cpp:
(MainWindow::createToolbar):
(MainWindow::WndProc):
(MainWindow::setDefaultURLToCurrentURL):
(MainWindow::goHome): Added.
(MainWindow::onURLBarEnter):
* MiniBrowser/win/MainWindow.h:
* MiniBrowser/win/MiniBrowserLib.rc:
* MiniBrowser/win/MiniBrowserLibResource.h:
* MiniBrowser/win/MiniBrowserReplace.h:
* MiniBrowser/win/WinMain.cpp:
(wWinMain):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/win/MainWindow.cpp
trunk/Tools/MiniBrowser/win/MainWindow.h
trunk/Tools/MiniBrowser/win/MiniBrowserLib.rc
trunk/Tools/MiniBrowser/win/MiniBrowserLibResource.h
trunk/Tools/MiniBrowser/win/MiniBrowserReplace.h
trunk/Tools/MiniBrowser/win/WinMain.cpp
Diff
Modified: trunk/Tools/ChangeLog (257023 => 257024)
--- trunk/Tools/ChangeLog 2020-02-20 01:55:05 UTC (rev 257023)
+++ trunk/Tools/ChangeLog 2020-02-20 02:09:04 UTC (rev 257024)
@@ -1,3 +1,25 @@
+2020-02-19 Fujii Hironori
+
+[Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
+https://bugs.webkit.org/show_bug.cgi?id=207749
+
+Reviewed by Ross Kirsling.
+
+Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
+
+* MiniBrowser/win/MainWindow.cpp:
+(MainWindow::createToolbar):
+(MainWindow::WndProc):
+(MainWindow::setDefaultURLToCurrentURL):
+(MainWindow::goHome): Added.
+(MainWindow::onURLBarEnter):
+* MiniBrowser/win/MainWindow.h:
+* MiniBrowser/win/MiniBrowserLib.rc:
+* MiniBrowser/win/MiniBrowserLibResource.h:
+* MiniBrowser/win/MiniBrowserReplace.h:
+* MiniBrowser/win/WinMain.cpp:
+(wWinMain):
+
2020-02-19 Peng Liu
Fix check-webkit-style errors related to AVFoundationSPI.h
Modified: trunk/Tools/MiniBrowser/win/MainWindow.cpp (257023 => 257024)
--- trunk/Tools/MiniBrowser/win/MainWindow.cpp 2020-02-20 01:55:05 UTC (rev 257023)
+++ trunk/Tools/MiniBrowser/win/MainWindow.cpp 2020-02-20 02:09:04 UTC (rev 257024)
@@ -46,6 +46,8 @@
float deviceScaleFactorForWindow(HWND);
}
+static const wchar_t* kMiniBrowserRegistryKey = L"Software\\WebKit\\MiniBrowser";
+
static constexpr int kToolbarImageSize = 24;
static constexpr int kToolbarURLBarIndex = 4;
static constexpr int kToolbarProgressIndicatorIndex = 6;
@@ -140,7 +142,7 @@
{ MAKELONG(HIST_BACK, ImageListID), IDM_HISTORY_BACKWARD, TBSTATE_ENABLED, buttonStyles | BTNS_DROPDOWN, { }, 0, (INT_PTR)L"Back" },
{ MAKELONG(HIST_FORWARD, ImageListID), IDM_HISTORY_FORWARD, TBSTATE_ENABLED, buttonStyles | BTNS_DROPDOWN, { }, 0, (INT_PTR)L"Forward"},
{ I_IMAGENONE, IDM_RELOAD, TBSTATE_ENABLED, buttonStyles | BTNS_SHOWTEXT, { }, 0, (INT_PTR)L"↺"},
-{ I_IMAGENONE, IDM_RELOAD, 0, buttonStyles | BTNS_SHOWTEXT, { }, 0, (INT_PTR)L"⌂"},
+{ I_IMAGENONE, IDM_GO_HOME, TBSTATE_ENABLED, buttonStyles | BTNS_SHOWTEXT, { }, 0, (INT_PTR)L"⌂"},
{ 0, 0, TBSTATE_ENABLED, BTNS_SEP, { }, 0, 0}, // URL bar
{ MAKELONG(HIST_ADDTOFAVORITES, ImageListID), IDM_ABOUT, 0, buttonStyles, { }, 0, (INT_PTR)L"Add to Bookmarks"},
{ 0, 0, TBSTATE_ENABLED, BTNS_SEP, { }, 0, 0}, // Progress indicator
@@ -278,6 +280,7 @@
result = 1;
break;
case APPCOMMAND_BROWSER_HOME:
+thisWindow->goHome();
break;
case APPCOMMAND_BROWSER_REFRESH:
thisWindow->browserWindow()->reload();
@@ -329,6 +332,9 @@
case IDM_ABOUT:
DialogBox(hInst, MAKEINTRESOURCE(IDD_ABOUTBOX), hWnd, About);
break;
+case IDM_GO_HOME:
+thisWindow->goHome();
+break;
case IDM_EXIT:
DestroyWindow(hWnd);
break;
@@ -341,6 +347,9 @@
case IDM_PROXY_SETTINGS:
thisWindow->browserWindow()->openProxySettings();
break;
+case IDM_SET_DEFAULT_URL:
+thisWindow->setDefaultURLToCurrentURL();
+break;
case IDM_CACHES:
if (!::IsWindow(thisWindow->m_hCacheWnd)) {
thisWindow->m_hCacheWnd = CreateDialogParam(hInst, MAKEINTRESOURCE(IDD_CACHES), hWnd, cachesDialogProc, reinterpret_cast(thisWindow.get()));
@@ -425,6 +434,16 @@
}
}
+void MainWindow::setDefaultURLToCurrentURL()
+{
+wchar_t url[INTERNET_MAX_URL_LENGTH];
+GetWindowText(m_hURLBarWnd, url, INTERNET_MAX_URL_LENGTH);
+auto length = wcslen(url);
+if (!length)
+return;
+RegSetKeyValue(HKEY_CURRENT_USER, kMiniBrowserRegistryKey, L"DefaultURL", REG_SZ, url, (length + 1) * sizeof(wchar_t));
+}
+
bool
[webkit-changes] [257023] tags/Safari-609.1.20.0.1/
Title: [257023] tags/Safari-609.1.20.0.1/ Revision 257023 Author alanc...@apple.com Date 2020-02-19 17:55:05 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.0.1. Added Paths tags/Safari-609.1.20.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257022] tags/Safari-609.1.20.0.1/
Title: [257022] tags/Safari-609.1.20.0.1/ Revision 257022 Author alanc...@apple.com Date 2020-02-19 17:54:59 -0800 (Wed, 19 Feb 2020) Log Message Delete tag. Removed Paths tags/Safari-609.1.20.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257020] branches/safari-609.1.20.0-branch
Title: [257020] branches/safari-609.1.20.0-branch Revision 257020 Author alanc...@apple.com Date 2020-02-19 17:52:28 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256632. rdar://problem/59478906 NetworkLoadMetrics should be shared by multiple ResourceResponse instances https://bugs.webkit.org/show_bug.cgi?id=207747 Reviewed by Keith Miller. Source/WebCore: ResourceResponse is value data, and it is copied multiple times in various places, (1) to create a new ResourceResponse which has slightly different fields, or (1) to hold ResourceResponse even after loading finishes. For example, DocumentLoader has Vector to replay response dispatching in the case of loading from BackForwardCache. The problem is that ResourceResponse is very large: 440 bytes. While we sometimes copy ResourceResponse to modify some part of it, NetworkLoadMetrics is immutable. It is set when response is created, and is never changed. And NetworkLoadMetrics is large: sizeof(NetworkLoadMetrics) is 184 bytes. Given that we have multiple copies of ResourceResponse in WebCore, we should share NetworkLoadMetrics by them. This patch puts Box in ResourceResponse to share it with all copied ResourceResponses. We do not make NetworkLoadMetrics RefCounted<> for now since some legit data structures embed NetworkLoadMetrics. This patch adds ArgumentCoder for Box so that we can encode / decode Box in ResourceResponse in IPC. To ensure NetworkLoadMetrics in ResourceResponse immutable, we add ResourceResponse::setDeprecatedNetworkLoadMetrics instead of modifying NetworkLoadMetrics already created in ResourceResponse. We also attempt to compact ResourceResponse more by using bit-fields. And removing m_isValid field in ParsedContentRange since this can be represented by the different field. These changes make sizeof(ResourceResponse) from 440 to 248. No behavior change. * inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::buildObjectForTiming): (WebCore::InspectorNetworkAgent::buildObjectForResourceResponse): * inspector/agents/InspectorNetworkAgent.h: * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading): * page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::domainLookupStart const): (WebCore::PerformanceTiming::domainLookupEnd const): (WebCore::PerformanceTiming::connectStart const): (WebCore::PerformanceTiming::connectEnd const): (WebCore::PerformanceTiming::secureConnectionStart const): (WebCore::PerformanceTiming::requestStart const): (WebCore::PerformanceTiming::responseStart const): * platform/network/NetworkLoadMetrics.h: * platform/network/ParsedContentRange.cpp: (WebCore::areContentRangeValuesValid): (WebCore::parseContentRange): (WebCore::ParsedContentRange::ParsedContentRange): (WebCore::ParsedContentRange::headerValue const): * platform/network/ParsedContentRange.h: (WebCore::ParsedContentRange::isValid const): (WebCore::ParsedContentRange::invalidValue): (WebCore::ParsedContentRange::MarkableTraits::isEmptyValue): (WebCore::ParsedContentRange::MarkableTraits::emptyValue): (WebCore::ParsedContentRange::ParsedContentRange): Deleted. * platform/network/ResourceHandle.h: * platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::crossThreadData const): (WebCore::ResourceResponseBase::fromCrossThreadData): (WebCore::ResourceResponseBase::compare): * platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::deprecatedNetworkLoadMetricsOrNull const): (WebCore::ResourceResponseBase::setDeprecatedNetworkLoadMetrics): (WebCore::ResourceResponseBase::encode const): (WebCore::ResourceResponseBase::decode): (WebCore::ResourceResponseBase::deprecatedNetworkLoadMetrics const): Deleted. * platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): * platform/network/cocoa/NetworkLoadMetrics.mm: (WebCore::copyTimingData): * platform/network/curl/CurlResourceHandleDelegate.cpp: (WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse): * platform/network/curl/ResourceResponse.h: * platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::setDeprecatedNetworkLoadMetrics): Deleted. * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::getConnectionTimingData): * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]): Source/WebKit: Add ArgumentCoder support for Box. * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate
[webkit-changes] [257021] branches/safari-609.1.20.0-branch
Title: [257021] branches/safari-609.1.20.0-branch Revision 257021 Author alanc...@apple.com Date 2020-02-19 17:52:35 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59465474 Modified Paths branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations branches/safari-609.1.20.0-branch/LayoutTests/compositing/backing/animate-into-view.html branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-startTime.tentative-expected.txt branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events-expected.txt branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-expected.txt branches/safari-609.1.20.0-branch/LayoutTests/webanimations/css-transition-in-flight-reversal-accelerated.html branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSTransition.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/DeclarativeAnimation.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/DeclarativeAnimation.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/DocumentTimeline.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/DocumentTimeline.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/WebAnimation.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/WebAnimation.h Diff Modified: branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog (257020 => 257021) --- branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-20 01:52:28 UTC (rev 257020) +++ branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-20 01:52:35 UTC (rev 257021) @@ -1,5 +1,27 @@ 2020-02-19 Alan Coon +Apply patch. rdar://problem/59465474 + +2020-02-19 Antoine Quint + +[Web Animations] Ensure CSS Transition and CSS Animation events are queued, sorted and dispatched by their timeline +https://bugs.webkit.org/show_bug.cgi?id=207364 + + +Reviewed by Simon Fraser. + +Fix a couple of tests that made some incorrect assumptions. + +* TestExpectations: imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html is no longer flaky. +* compositing/backing/animate-into-view.html: Because the "animationstart" event is now dispatched during the "update animations and send events" procedure, which happens +during page rendering _before_ rAF callbacks are serviced, we must remove the rAF callback used prior to adding the "animationstart" event listener or else we would never +get it and the test would time out. +* webanimations/css-transition-in-flight-reversal-accelerated.html: We must wait for the initial transition to start and then two frames before reversing the transition, +to be certain that the animation did start. Indeed, the "transitionstart" event will be fired right before the next rAF callback is called, as the animation starts in that +very same frame, and so progress will be 0 and the transition wouldn't be reversable until the next frame when the animation has progress > 0. + +2020-02-19 Alan Coon + Cherry-pick r256513. rdar://problem/59446986 REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side Modified: branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations (257020 => 257021) --- branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations 2020-02-20 01:52:28 UTC (rev 257020) +++ branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations 2020-02-20 01:52:35 UTC (rev 257021) @@ -2653,7 +2653,6 @@ webkit.org/b/202107 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events.html [ Pass Failure ] webkit.org/b/202108 imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events.html [ Pass Failure ] -webkit.org/b/202109 imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html [ Pass Failure ] webkit.org/b/157068 [ Debug ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Crash ] webkit.org/b/157068 [ Release ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Failure ] Modified:
[webkit-changes] [257016] branches/safari-609.1.20.0-branch/Source/WebCore
Title: [257016] branches/safari-609.1.20.0-branch/Source/WebCore
Revision 257016
Author alanc...@apple.com
Date 2020-02-19 17:52:08 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256400. rdar://problem/59446986
Unreviewed, partial rollout of r255037.
* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm
branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm
Diff
Modified: branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog (257015 => 257016)
--- branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog 2020-02-20 01:52:05 UTC (rev 257015)
+++ branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog 2020-02-20 01:52:08 UTC (rev 257016)
@@ -1,5 +1,29 @@
2020-02-19 Alan Coon
+Cherry-pick r256400. rdar://problem/59446986
+
+Unreviewed, partial rollout of r255037.
+
+
+* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
+(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
+* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
+(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-11 Ryan Haddad
+
+Unreviewed, partial rollout of r255037.
+
+
+* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
+(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
+* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
+(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
+
+2020-02-19 Alan Coon
+
Cherry-pick r256191. rdar://problem/59447003
Disallow setting base URL to a data or _javascript_ URL
Modified: branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm (257015 => 257016)
--- branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm 2020-02-20 01:52:05 UTC (rev 257015)
+++ branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm 2020-02-20 01:52:08 UTC (rev 257016)
@@ -77,7 +77,7 @@
if (is(*ancestor)) {
// Fixed nodes are positioned relative to the containing frame scrolling node.
// We bail out after finding one.
-auto layoutViewport = downcast(*ancestor).layoutViewportRespectingRubberBanding();
+auto layoutViewport = downcast(*ancestor).layoutViewport();
return m_constraints.layerPositionForViewportRect(layoutViewport) - overflowScrollDelta;
}
Modified: branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm (257015 => 257016)
--- branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm 2020-02-20 01:52:05 UTC (rev 257015)
+++ branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm 2020-02-20 01:52:08 UTC (rev 257016)
@@ -73,7 +73,7 @@
FloatRect constrainingRect;
if (is(scrollingNode)) {
auto& frameScrollingNode = downcast(scrollingNode);
-constrainingRect = frameScrollingNode.layoutViewportRespectingRubberBanding();
+constrainingRect = frameScrollingNode.layoutViewport();
} else {
auto& overflowScrollingNode = downcast(scrollingNode);
constrainingRect = FloatRect(overflowScrollingNode.currentScrollPosition(), m_constraints.constrainingRectAtLastLayout().size());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257019] branches/safari-609.1.20.0-branch/Source/WebCore
Title: [257019] branches/safari-609.1.20.0-branch/Source/WebCore Revision 257019 Author alanc...@apple.com Date 2020-02-19 17:52:20 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256610. rdar://problem/59478918 [Web Animations] Make all animation event types inherit from the same base class https://bugs.webkit.org/show_bug.cgi?id=207629 Reviewed by Simon Fraser. Currently we dispatch events CSS Transitions and CSS Animations events using a dedicated event queue on DeclarativeAnimation, while the events added by the Web Animations specification (of type AnimationPlaybackEvent) are dispatched using a shared queue on the DocumentTimeline that is processed during the "update animations and send events procedure". The Web Animations specification dictates that all events should be dispatched during that procedure, which includes sorting of such events based on their timeline time and associated animation relative composite order. In this patch, we prepare the work towards spec compliance for animation events dispatch by making all event types (AnimationPlaybackEvent, TransitionEvent and AnimationEvent) inherit from a single AnimationEventBase interface. This will allow DocumentTimeline to enqueue, sort and dispatch all such events with a single queue in a future patch. Due to CSSAnimationController, we must make the "timeline time" and "animation" parameters optional. When we drop support for CSSAnimationController we'll be able to enforce stronger requirements for these. No new test since this should not introduce any behavior change. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * animation/AnimationEventBase.cpp: Added. (WebCore::AnimationEventBase::AnimationEventBase): * animation/AnimationEventBase.h: Added. (WebCore::AnimationEventBase::create): (WebCore::AnimationEventBase::isAnimationPlaybackEvent const): (WebCore::AnimationEventBase::isAnimationEvent const): (WebCore::AnimationEventBase::isTransitionEvent const): (WebCore::AnimationEventBase::timelineTime const): (WebCore::AnimationEventBase::animation const): * animation/AnimationPlaybackEvent.cpp: (WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent): (WebCore::AnimationPlaybackEvent::bindingsTimelineTime const): * animation/AnimationPlaybackEvent.h: * animation/CSSAnimation.cpp: (WebCore::CSSAnimation::createEvent): * animation/CSSAnimation.h: * animation/CSSTransition.cpp: (WebCore::CSSTransition::createEvent): * animation/CSSTransition.h: * animation/DeclarativeAnimation.cpp: (WebCore::DeclarativeAnimation::enqueueDOMEvent): * animation/DeclarativeAnimation.h: * animation/WebAnimation.cpp: (WebCore::WebAnimation::enqueueAnimationPlaybackEvent): * dom/AnimationEvent.cpp: (WebCore::AnimationEvent::AnimationEvent): * dom/AnimationEvent.h: * dom/TransitionEvent.cpp: (WebCore::TransitionEvent::TransitionEvent): * dom/TransitionEvent.h: * page/animation/CSSAnimationController.cpp: (WebCore::CSSAnimationControllerPrivate::fireEventsAndUpdateStyle): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256610 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.0-branch/Source/WebCore/Sources.txt branches/safari-609.1.20.0-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj branches/safari-609.1.20.0-branch/Source/WebCore/animation/AnimationPlaybackEvent.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/AnimationPlaybackEvent.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSAnimation.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSAnimation.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSTransition.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSTransition.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/DeclarativeAnimation.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/DeclarativeAnimation.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/WebAnimation.cpp branches/safari-609.1.20.0-branch/Source/WebCore/dom/AnimationEvent.cpp branches/safari-609.1.20.0-branch/Source/WebCore/dom/AnimationEvent.h branches/safari-609.1.20.0-branch/Source/WebCore/dom/TransitionEvent.cpp branches/safari-609.1.20.0-branch/Source/WebCore/dom/TransitionEvent.h branches/safari-609.1.20.0-branch/Source/WebCore/page/animation/CSSAnimationController.cpp Added Paths branches/safari-609.1.20.0-branch/Source/WebCore/animation/AnimationEventBase.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/AnimationEventBase.h Diff Modified: branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog (257018 => 257019) --- branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog 2020-02-20 01:52:14 UTC (rev 257018) +++
[webkit-changes] [257014] branches/safari-609.1.20.0-branch
Title: [257014] branches/safari-609.1.20.0-branch
Revision 257014
Author alanc...@apple.com
Date 2020-02-19 17:51:51 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r255037. rdar://problem/59446986
Fixed elements no longer stay fixed with elastic overscroll
https://bugs.webkit.org/show_bug.cgi?id=206227
rdar://problem/58707084
Reviewed by Antti Koivisto.
Source/WebCore:
Intended behavior on iOS and macOS is for position:fixed and sticky elements to maintain
their position relative to the view bounds when rubber-banding ("overscrolling"). This broke
some time back. This change restores the correct behavior with the call to layoutViewportRespectingRubberBanding()
in ScrollingTreeFixedNode::applyLayerPositions() and ScrollingTreeStickyNode::computeLayerPosition().
layoutViewportRespectingRubberBanding() computes a layout viewport without clamping.
The rest of the changes are to support testing. internals.unconstrainedScrollTo()
didn't work for main frame scrolling because of scroll position clamping in various places,
so propagate ScrollClamping in more places (and replace the redundant ScrollPositionClamp with ScrollClamping).
"requested scroll position" updates now carry along both clamping and "is programmatic" data, wrapped in a struct
which is passed around the scrolling tree. This allows us to not clamp the scroll position (for testing) in more places.
Internals::unconstrainedScrollTo() needs one weird hack to trigger a layout (and thus a scrolling tree commit),
because the layout is normally triggered by a layout viewport change, but when rubber-banding we clamp the layoutViewport
used for layout, so those layouts are never triggered.
Tests: tiled-drawing/scrolling/fixed/fixed-during-rubberband.html
tiled-drawing/scrolling/sticky/sticky-during-rubberband.html
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.cpp:
(WebCore::Element::scrollTo):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollTo const):
* page/FrameView.cpp:
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::requestScrollPositionUpdate):
* page/FrameView.h:
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ScrollingCoordinator.cpp:
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollData):
(WebCore::ScrollingStateScrollingNode::dumpProperties const):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition): Deleted.
* page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::RequestedScrollData::operator== const):
(WebCore::ScrollingStateScrollingNode::requestedScrollData const):
(WebCore::ScrollingStateScrollingNode::requestedScrollPosition const): Deleted.
(WebCore::ScrollingStateScrollingNode::requestedScrollPositionRepresentsProgrammaticScroll const): Deleted.
* page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::scrollingTreeNodeRequestsScroll):
* page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
(WebCore::ScrollingTreeFrameScrollingNode::layoutViewportForScrollPosition const):
(WebCore::ScrollingTreeFrameScrollingNode::layoutViewportRespectingRubberBanding const):
* page/scrolling/ScrollingTreeFrameScrollingNode.h:
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren):
(WebCore::ScrollingTreeScrollingNode::adjustedScrollPosition const):
(WebCore::ScrollingTreeScrollingNode::scrollBy):
(WebCore::ScrollingTreeScrollingNode::scrollTo):
(WebCore::ScrollingTreeScrollingNode::wasScrolledByDelegatedScrolling):
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::adjustedScrollPosition const):
* page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
* page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:
(WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateAfterChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::adjustedScrollPosition const):
* page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
[webkit-changes] [257017] branches/safari-609.1.20.0-branch/LayoutTests
Title: [257017] branches/safari-609.1.20.0-branch/LayoutTests Revision 257017 Author alanc...@apple.com Date 2020-02-19 17:52:11 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256435. rdar://problem/59446986 REGRESSION: (256400) tiled-drawing/scrolling/fixed/fixed-during-rubberband.html is failing https://bugs.webkit.org/show_bug.cgi?id=207631 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256435 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog branches/safari-609.1.20.0-branch/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog (257016 => 257017) --- branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-20 01:52:08 UTC (rev 257016) +++ branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-20 01:52:11 UTC (rev 257017) @@ -1,5 +1,27 @@ 2020-02-19 Alan Coon +Cherry-pick r256435. rdar://problem/59446986 + +REGRESSION: (256400) tiled-drawing/scrolling/fixed/fixed-during-rubberband.html is failing +https://bugs.webkit.org/show_bug.cgi?id=207631 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256435 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-12 Jacob Uphoff + +REGRESSION: (256400) tiled-drawing/scrolling/fixed/fixed-during-rubberband.html is failing +https://bugs.webkit.org/show_bug.cgi?id=207631 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + +2020-02-19 Alan Coon + Cherry-pick r256191. rdar://problem/59447003 Disallow setting base URL to a data or _javascript_ URL Modified: branches/safari-609.1.20.0-branch/LayoutTests/platform/mac-wk2/TestExpectations (257016 => 257017) --- branches/safari-609.1.20.0-branch/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-20 01:52:08 UTC (rev 257016) +++ branches/safari-609.1.20.0-branch/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-20 01:52:11 UTC (rev 257017) @@ -929,3 +929,6 @@ webkit.org/b/205886 http/wpt/service-workers/persistent-importScripts.html [ Pass Failure ] webkit.org/b/206958 http/tests/media/media-stream/get-display-media-prompt.html [ Pass Failure Timeout ] + +webkit.org/b/207631 tiled-drawing/scrolling/fixed/fixed-during-rubberband.html [ Pass ImageOnlyFailure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257018] branches/safari-609.1.20.0-branch
Title: [257018] branches/safari-609.1.20.0-branch Revision 257018 Author alanc...@apple.com Date 2020-02-19 17:52:14 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256513. rdar://problem/59446986 REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side https://bugs.webkit.org/show_bug.cgi?id=207674 rdar://problem/59404866 Reviewed by Antti Koivisto. Source/WebCore: Remove the early return in ScrollingStateScrollingNode::setRequestedScrollData(); comparing with the last m_requestedScrollData is wrong, because requested scroll positions are not "state" in the scrolling tree, they are requests to scroll. Ideally, they would be represented in some different way in the scrolling tree. Test: fast/scrolling/programmatic-scroll-to-zero-zero.html * page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::setRequestedScrollData): LayoutTests: Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0, which is expected to work. * fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added. * fast/scrolling/programmatic-scroll-to-zero-zero.html: Added. * platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256513 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog branches/safari-609.1.20.0-branch/LayoutTests/platform/ios/TestExpectations branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.0-branch/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp Added Paths branches/safari-609.1.20.0-branch/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html branches/safari-609.1.20.0-branch/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero.html Diff Modified: branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog (257017 => 257018) --- branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-20 01:52:11 UTC (rev 257017) +++ branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-20 01:52:14 UTC (rev 257018) @@ -1,5 +1,54 @@ 2020-02-19 Alan Coon +Cherry-pick r256513. rdar://problem/59446986 + +REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side +https://bugs.webkit.org/show_bug.cgi?id=207674 +rdar://problem/59404866 + +Reviewed by Antti Koivisto. + +Source/WebCore: + +Remove the early return in ScrollingStateScrollingNode::setRequestedScrollData(); comparing +with the last m_requestedScrollData is wrong, because requested scroll positions are not "state" +in the scrolling tree, they are requests to scroll. Ideally, they would be represented in some +different way in the scrolling tree. + +Test: fast/scrolling/programmatic-scroll-to-zero-zero.html + +* page/scrolling/ScrollingStateScrollingNode.cpp: +(WebCore::ScrollingStateScrollingNode::setRequestedScrollData): + +LayoutTests: + +Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0, +which is expected to work. + +* fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added. +* fast/scrolling/programmatic-scroll-to-zero-zero.html: Added. +* platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256513 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-13 Simon Fraser + +REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side +https://bugs.webkit.org/show_bug.cgi?id=207674 +rdar://problem/59404866 + +Reviewed by Antti Koivisto. + +Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0, +which is expected to work. + +* fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added. +* fast/scrolling/programmatic-scroll-to-zero-zero.html: Added. +* platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping. + +2020-02-19 Alan Coon + Cherry-pick r256435. rdar://problem/59446986 REGRESSION: (256400) tiled-drawing/scrolling/fixed/fixed-during-rubberband.html is failing Added: branches/safari-609.1.20.0-branch/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html (0 => 257018) --- branches/safari-609.1.20.0-branch/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html (rev 0)
[webkit-changes] [257013] trunk/Source/WebKit
Title: [257013] trunk/Source/WebKit
Revision 257013
Author rn...@webkit.org
Date 2020-02-19 17:50:59 -0800 (Wed, 19 Feb 2020)
Log Message
Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
https://bugs.webkit.org/show_bug.cgi?id=207973
Reviewed by Chris Dumez.
Use RefPtr to store Frame*.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (257012 => 257013)
--- trunk/Source/WebKit/ChangeLog 2020-02-20 01:27:49 UTC (rev 257012)
+++ trunk/Source/WebKit/ChangeLog 2020-02-20 01:50:59 UTC (rev 257013)
@@ -1,3 +1,15 @@
+2020-02-19 Ryosuke Niwa
+
+Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
+https://bugs.webkit.org/show_bug.cgi?id=207973
+
+Reviewed by Chris Dumez.
+
+Use RefPtr to store Frame*.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+
2020-02-19 Ben Nham
Avoid preconnecting to custom URL schemes
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (257012 => 257013)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-02-20 01:27:49 UTC (rev 257012)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-02-20 01:50:59 UTC (rev 257013)
@@ -4272,7 +4272,7 @@
{
PageClientProtector protector(pageClient());
-WebFrameProxy* frame = process->webFrame(frameID);
+auto frame = makeRefPtr(process->webFrame(frameID));
MESSAGE_CHECK(process, frame);
MESSAGE_CHECK_URL(process, url);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257012] trunk/LayoutTests
Title: [257012] trunk/LayoutTests Revision 257012 Author lawrenc...@apple.com Date 2020-02-19 17:27:49 -0800 (Wed, 19 Feb 2020) Log Message [ Mac ] imported/w3c/web-platform-tests/service-workers/service-worker/resource-timing.sub.https.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207978 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (257011 => 257012) --- trunk/LayoutTests/ChangeLog 2020-02-20 01:26:36 UTC (rev 257011) +++ trunk/LayoutTests/ChangeLog 2020-02-20 01:27:49 UTC (rev 257012) @@ -1,5 +1,14 @@ 2020-02-19 Jason Lawrence +[ Mac ] imported/w3c/web-platform-tests/service-workers/service-worker/resource-timing.sub.https.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=207978 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2020-02-19 Jason Lawrence + [ Mac ] css3/selectors3/xml/css3-modsel-d1.xml is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207971 Modified: trunk/LayoutTests/platform/mac/TestExpectations (257011 => 257012) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-20 01:26:36 UTC (rev 257011) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-20 01:27:49 UTC (rev 257012) @@ -2035,3 +2035,5 @@ webkit.org/b/207858 webgl/1.0.3/conformance/programs/program-test.html [ Failure ] webkit.org/b/207971 css3/selectors3/xml/css3-modsel-d1.xml [ Pass Failure ] + +webkit.org/b/207978 imported/w3c/web-platform-tests/service-workers/service-worker/resource-timing.sub.https.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257011] tags/Safari-609.1.20.1.1/
Title: [257011] tags/Safari-609.1.20.1.1/ Revision 257011 Author alanc...@apple.com Date 2020-02-19 17:26:36 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.1.1. Added Paths tags/Safari-609.1.20.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257010] tags/Safari-609.1.20.1.1/
Title: [257010] tags/Safari-609.1.20.1.1/ Revision 257010 Author alanc...@apple.com Date 2020-02-19 17:26:19 -0800 (Wed, 19 Feb 2020) Log Message Delete tag. Removed Paths tags/Safari-609.1.20.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257009] branches/safari-609.1.20.1-branch/Source/WebKit/Shared/ WebPreferences.yaml
Title: [257009] branches/safari-609.1.20.1-branch/Source/WebKit/Shared/WebPreferences.yaml Revision 257009 Author alanc...@apple.com Date 2020-02-19 17:24:58 -0800 (Wed, 19 Feb 2020) Log Message Unreviewed build fix. rdar://problem/59576820 Modified Paths branches/safari-609.1.20.1-branch/Source/WebKit/Shared/WebPreferences.yaml Diff Modified: branches/safari-609.1.20.1-branch/Source/WebKit/Shared/WebPreferences.yaml (257008 => 257009) --- branches/safari-609.1.20.1-branch/Source/WebKit/Shared/WebPreferences.yaml 2020-02-20 01:12:26 UTC (rev 257008) +++ branches/safari-609.1.20.1-branch/Source/WebKit/Shared/WebPreferences.yaml 2020-02-20 01:24:58 UTC (rev 257009) @@ -219,10 +219,6 @@ type: bool defaultValue: false -AllowTopNavigationToDataURLs: - type: bool - defaultValue: false - ShouldRestrictBaseURLSchemes: type: bool defaultValue: false ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257008] trunk/Source/WebKit
Title: [257008] trunk/Source/WebKit
Revision 257008
Author commit-qu...@webkit.org
Date 2020-02-19 17:12:26 -0800 (Wed, 19 Feb 2020)
Log Message
Avoid preconnecting to custom URL schemes
https://bugs.webkit.org/show_bug.cgi?id=207964
Patch by Ben Nham on 2020-02-19
Reviewed by Ryosuke Niwa.
This makes NetworkProcess::preconnectTo not preconnect to custom URL schemes. This matches
the existing behavior in NetworkConnectionToWebProcess::preconnectTo.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::preconnectTo):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (257007 => 257008)
--- trunk/Source/WebKit/ChangeLog 2020-02-20 01:12:26 UTC (rev 257007)
+++ trunk/Source/WebKit/ChangeLog 2020-02-20 01:12:26 UTC (rev 257008)
@@ -1,3 +1,16 @@
+2020-02-19 Ben Nham
+
+Avoid preconnecting to custom URL schemes
+https://bugs.webkit.org/show_bug.cgi?id=207964
+
+Reviewed by Ryosuke Niwa.
+
+This makes NetworkProcess::preconnectTo not preconnect to custom URL schemes. This matches
+the existing behavior in NetworkConnectionToWebProcess::preconnectTo.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::preconnectTo):
+
2020-02-19 Chris Dumez
Regression(r247567) HTTP Disk cache capacity is no longer set
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (257007 => 257008)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2020-02-20 01:12:26 UTC (rev 257007)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2020-02-20 01:12:26 UTC (rev 257008)
@@ -1304,6 +1304,11 @@
void NetworkProcess::preconnectTo(PAL::SessionID sessionID, const URL& url, const String& userAgent, WebCore::StoredCredentialsPolicy storedCredentialsPolicy)
{
#if ENABLE(SERVER_PRECONNECT)
+#if ENABLE(LEGACY_CUSTOM_PROTOCOL_MANAGER)
+if (supplement()->supportsScheme(url.protocol().toString()))
+return;
+#endif
+
NetworkLoadParameters parameters;
parameters.request = ResourceRequest { url };
if (!userAgent.isEmpty()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257007] tags/Safari-609.1.20.101.1/
Title: [257007] tags/Safari-609.1.20.101.1/ Revision 257007 Author alanc...@apple.com Date 2020-02-19 17:12:26 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.101.1. Added Paths tags/Safari-609.1.20.101.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257006] branches/safari-609.1.20.101-branch/Source
Title: [257006] branches/safari-609.1.20.101-branch/Source Revision 257006 Author alanc...@apple.com Date 2020-02-19 17:07:35 -0800 (Wed, 19 Feb 2020) Log Message Versioning. Modified Paths branches/safari-609.1.20.101-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-609.1.20.101-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-609.1.20.101-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-609.1.20.101-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-609.1.20.101-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-609.1.20.101-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-609.1.20.101-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-609.1.20.101-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-609.1.20.101-branch/Source/_javascript_Core/Configurations/Version.xcconfig (257005 => 257006) --- branches/safari-609.1.20.101-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-20 01:01:48 UTC (rev 257005) +++ branches/safari-609.1.20.101-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-20 01:07:35 UTC (rev 257006) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 101; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.101-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (257005 => 257006) --- branches/safari-609.1.20.101-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-20 01:01:48 UTC (rev 257005) +++ branches/safari-609.1.20.101-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-20 01:07:35 UTC (rev 257006) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 101; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.101-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (257005 => 257006) --- branches/safari-609.1.20.101-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-20 01:01:48 UTC (rev 257005) +++ branches/safari-609.1.20.101-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-20 01:07:35 UTC (rev 257006) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 101; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.101-branch/Source/WebCore/Configurations/Version.xcconfig (257005 => 257006) --- branches/safari-609.1.20.101-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-20 01:01:48 UTC (rev 257005) +++ branches/safari-609.1.20.101-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-20 01:07:35 UTC (rev 257006) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 101; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.101-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (257005 => 257006) --- branches/safari-609.1.20.101-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-20 01:01:48 UTC (rev 257005) +++ branches/safari-609.1.20.101-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-20 01:07:35 UTC (rev 257006) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
[webkit-changes] [257005] tags/Safari-609.1.20.1.1/
Title: [257005] tags/Safari-609.1.20.1.1/ Revision 257005 Author repst...@apple.com Date 2020-02-19 17:01:48 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.1.1. Added Paths tags/Safari-609.1.20.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257004] tags/Safari-609.1.20.0.1/
Title: [257004] tags/Safari-609.1.20.0.1/ Revision 257004 Author alanc...@apple.com Date 2020-02-19 16:59:16 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.0.1. Added Paths tags/Safari-609.1.20.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257003] trunk
Title: [257003] trunk Revision 257003 Author peng.l...@apple.com Date 2020-02-19 16:57:25 -0800 (Wed, 19 Feb 2020) Log Message Fix check-webkit-style errors related to AVFoundationSPI.h https://bugs.webkit.org/show_bug.cgi?id=207834 Reviewed by Daniel Bates. Source/WebCore: No new tests, no functional change. Revert the change in r256770 regarding the headers ordering. * platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm: * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: Tools: Revert the change in r256770 regarding the headers ordering. Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). * Scripts/webkitpy/style/checkers/cpp.py: (check_include_line): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py Diff Modified: trunk/Source/WebCore/ChangeLog (257002 => 257003) --- trunk/Source/WebCore/ChangeLog 2020-02-20 00:55:02 UTC (rev 257002) +++ trunk/Source/WebCore/ChangeLog 2020-02-20 00:57:25 UTC (rev 257003) @@ -1,3 +1,17 @@ +2020-02-19 Peng Liu + +Fix check-webkit-style errors related to AVFoundationSPI.h +https://bugs.webkit.org/show_bug.cgi?id=207834 + +Reviewed by Daniel Bates. + +No new tests, no functional change. + +Revert the change in r256770 regarding the headers ordering. + +* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm: +* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: + 2020-02-19 Zalan Bujtas [LFC][Integration] Do not try to lay out a formatting context unless there's some content in it Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm (257002 => 257003) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm 2020-02-20 00:55:02 UTC (rev 257002) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm 2020-02-20 00:57:25 UTC (rev 257003) @@ -29,11 +29,11 @@ #if ENABLE(WIRELESS_PLAYBACK_TARGET) && !PLATFORM(IOS_FAMILY) #import "Logging.h" +#import +#import #import #import #import -#import -#import #import #import Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (257002 => 257003) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2020-02-20 00:55:02 UTC (rev 257002) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2020-02-20 00:57:25 UTC (rev 257003) @@ -44,10 +44,10 @@ #import "WebCoreDecompressionSession.h" #import #import +#import #import #import #import -#import #import #import #import Modified: trunk/Tools/ChangeLog (257002 => 257003) --- trunk/Tools/ChangeLog 2020-02-20 00:55:02 UTC (rev 257002) +++ trunk/Tools/ChangeLog 2020-02-20 00:57:25 UTC (rev 257003) @@ -1,3 +1,16 @@ +2020-02-19 Peng Liu + +Fix check-webkit-style errors related to AVFoundationSPI.h +https://bugs.webkit.org/show_bug.cgi?id=207834 + +Reviewed by Daniel Bates. + +Revert the change in r256770 regarding the headers ordering. +Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). + +* Scripts/webkitpy/style/checkers/cpp.py: +(check_include_line): + 2020-02-19 Jonathan Bedard results.webkit.org: Correctly report JSC tests for windows Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (257002 => 257003) --- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2020-02-20 00:55:02 UTC (rev 257002) +++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2020-02-20 00:57:25 UTC (rev 257003) @@ -3270,7 +3270,7 @@ if previous_header_type == _OTHER_HEADER: if '<' in previous_line and '"' in line: error(line_number, 'build/include_order', 4, 'Bad include order. Mixing system and custom headers.') -elif previous_line.strip().lower() > line.strip().lower(): +elif previous_line.strip() > line.strip(): # This type of error is potentially a problem with this line or the previous one, # so if the error is filtered for one line, report it for the next. This is so that # we properly handle patches, for which only modified lines produce errors. ___ webkit-changes mailing list webkit-changes@lists.webkit.org
[webkit-changes] [257002] tags/Safari-609.1.20.100.1/
Title: [257002] tags/Safari-609.1.20.100.1/ Revision 257002 Author alanc...@apple.com Date 2020-02-19 16:55:02 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.100.1. Added Paths tags/Safari-609.1.20.100.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257000] branches/safari-609.1.20.100-branch/Source
Title: [257000] branches/safari-609.1.20.100-branch/Source Revision 257000 Author repst...@apple.com Date 2020-02-19 16:49:34 -0800 (Wed, 19 Feb 2020) Log Message Versioning. Modified Paths branches/safari-609.1.20.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-609.1.20.100-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-609.1.20.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-609.1.20.100-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-609.1.20.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-609.1.20.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-609.1.20.100-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-609.1.20.100-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-609.1.20.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256999 => 257000) --- branches/safari-609.1.20.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-20 00:48:04 UTC (rev 256999) +++ branches/safari-609.1.20.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-20 00:49:34 UTC (rev 257000) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 100; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.100-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256999 => 257000) --- branches/safari-609.1.20.100-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-20 00:48:04 UTC (rev 256999) +++ branches/safari-609.1.20.100-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-20 00:49:34 UTC (rev 257000) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 100; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256999 => 257000) --- branches/safari-609.1.20.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-20 00:48:04 UTC (rev 256999) +++ branches/safari-609.1.20.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-20 00:49:34 UTC (rev 257000) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 100; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.100-branch/Source/WebCore/Configurations/Version.xcconfig (256999 => 257000) --- branches/safari-609.1.20.100-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-20 00:48:04 UTC (rev 256999) +++ branches/safari-609.1.20.100-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-20 00:49:34 UTC (rev 257000) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 100; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256999 => 257000) --- branches/safari-609.1.20.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-20 00:48:04 UTC (rev 256999) +++ branches/safari-609.1.20.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-20 00:49:34 UTC (rev 257000) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
[webkit-changes] [257001] trunk/Source/WebCore
Title: [257001] trunk/Source/WebCore
Revision 257001
Author za...@apple.com
Date 2020-02-19 16:49:59 -0800 (Wed, 19 Feb 2020)
Log Message
[LFC][Integration] Do not try to lay out a formatting context unless there's some content in it
https://bugs.webkit.org/show_bug.cgi?id=207956
Reviewed by Simon Fraser.
LineLayout::layout() normally don't get called when the block level box has not children (canUse() returns false for such cases), but we are probably missing some invalidation here
so we end up with an "empty" formatting context.
* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (257000 => 257001)
--- trunk/Source/WebCore/ChangeLog 2020-02-20 00:49:34 UTC (rev 257000)
+++ trunk/Source/WebCore/ChangeLog 2020-02-20 00:49:59 UTC (rev 257001)
@@ -1,5 +1,19 @@
2020-02-19 Zalan Bujtas
+[LFC][Integration] Do not try to lay out a formatting context unless there's some content in it
+https://bugs.webkit.org/show_bug.cgi?id=207956
+
+
+Reviewed by Simon Fraser.
+
+LineLayout::layout() normally don't get called when the block level box has not children (canUse() returns false for such cases), but we are probably missing some invalidation here
+so we end up with an "empty" formatting context.
+
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::layout):
+
+2020-02-19 Zalan Bujtas
+
[First paint] Introduce FrameView::m_firstVisuallyNonEmptyLayoutMilestoneIsPending
https://bugs.webkit.org/show_bug.cgi?id=207966
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (257000 => 257001)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2020-02-20 00:49:34 UTC (rev 257000)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2020-02-20 00:49:59 UTC (rev 257001)
@@ -98,6 +98,9 @@
void LineLayout::layout()
{
+if (!rootLayoutBox().hasInFlowOrFloatingChild())
+return;
+
prepareLayoutState();
prepareFloatingState();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256999] trunk/Source/WebCore
Title: [256999] trunk/Source/WebCore
Revision 256999
Author za...@apple.com
Date 2020-02-19 16:48:04 -0800 (Wed, 19 Feb 2020)
Log Message
[First paint] Introduce FrameView::m_firstVisuallyNonEmptyLayoutMilestoneIsPending
https://bugs.webkit.org/show_bug.cgi?id=207966
Reviewed by Simon Fraser.
This is in preparation for decoupling the "content is qualified as visually non-empty" check and layout, when
the check happens soon after style recalc/render tree building and we need to wait until after layout to
issue the milestone.
* page/FrameView.cpp:
(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
* page/FrameView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (256998 => 256999)
--- trunk/Source/WebCore/ChangeLog 2020-02-20 00:45:17 UTC (rev 256998)
+++ trunk/Source/WebCore/ChangeLog 2020-02-20 00:48:04 UTC (rev 256999)
@@ -1,3 +1,20 @@
+2020-02-19 Zalan Bujtas
+
+[First paint] Introduce FrameView::m_firstVisuallyNonEmptyLayoutMilestoneIsPending
+https://bugs.webkit.org/show_bug.cgi?id=207966
+
+
+Reviewed by Simon Fraser.
+
+This is in preparation for decoupling the "content is qualified as visually non-empty" check and layout, when
+the check happens soon after style recalc/render tree building and we need to wait until after layout to
+issue the milestone.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::resetLayoutMilestones):
+(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
+* page/FrameView.h:
+
2020-02-19 Youenn Fablet
[mac debug] Regression: http/tests/websocket/tests/hybi/workers/worker-reload.html is a flaky crash
Modified: trunk/Source/WebCore/page/FrameView.cpp (256998 => 256999)
--- trunk/Source/WebCore/page/FrameView.cpp 2020-02-20 00:45:17 UTC (rev 256998)
+++ trunk/Source/WebCore/page/FrameView.cpp 2020-02-20 00:48:04 UTC (rev 256999)
@@ -264,7 +264,8 @@
void FrameView::resetLayoutMilestones()
{
m_firstLayoutCallbackPending = false;
-m_isVisuallyNonEmpty = false;
+m_firstVisuallyNonEmptyLayoutMilestoneIsPending = true;
+m_contentQualifiesAsVisuallyNonEmpty = false;
m_hasReachedSignificantRenderedTextThreshold = false;
m_renderedSignificantAmountOfText = false;
m_visuallyNonEmptyCharacterCount = 0;
@@ -2849,7 +2850,7 @@
void FrameView::loadProgressingStatusChanged()
{
-if (!m_isVisuallyNonEmpty && frame().loader().isComplete())
+if (!m_contentQualifiesAsVisuallyNonEmpty && frame().loader().isComplete())
fireLayoutRelatedMilestonesIfNeeded();
updateLayerFlushThrottling();
adjustTiledBackingCoverage();
@@ -5135,11 +5136,15 @@
page->startCountingRelevantRepaintedObjects();
}
-if (!m_isVisuallyNonEmpty && qualifiesAsVisuallyNonEmpty()) {
-m_isVisuallyNonEmpty = true;
-addPaintPendingMilestones(DidFirstMeaningfulPaint);
-if (requestedMilestones & DidFirstVisuallyNonEmptyLayout)
-milestonesAchieved.add(DidFirstVisuallyNonEmptyLayout);
+if (m_firstVisuallyNonEmptyLayoutMilestoneIsPending) {
+if (!m_contentQualifiesAsVisuallyNonEmpty && qualifiesAsVisuallyNonEmpty()) {
+m_contentQualifiesAsVisuallyNonEmpty = true;
+m_firstVisuallyNonEmptyLayoutMilestoneIsPending = false;
+
+addPaintPendingMilestones(DidFirstMeaningfulPaint);
+if (requestedMilestones & DidFirstVisuallyNonEmptyLayout)
+milestonesAchieved.add(DidFirstVisuallyNonEmptyLayout);
+}
}
if (!m_renderedSignificantAmountOfText && qualifiesAsSignificantRenderedText()) {
Modified: trunk/Source/WebCore/page/FrameView.h (256998 => 256999)
--- trunk/Source/WebCore/page/FrameView.h 2020-02-20 00:45:17 UTC (rev 256998)
+++ trunk/Source/WebCore/page/FrameView.h 2020-02-20 00:48:04 UTC (rev 256999)
@@ -396,7 +396,7 @@
void incrementVisuallyNonEmptyCharacterCount(const String&);
void incrementVisuallyNonEmptyPixelCount(const IntSize&);
-bool isVisuallyNonEmpty() const { return m_isVisuallyNonEmpty; }
+bool isVisuallyNonEmpty() const { return m_contentQualifiesAsVisuallyNonEmpty; }
WEBCORE_EXPORT bool qualifiesAsVisuallyNonEmpty() const;
WEBCORE_EXPORT void enableAutoSizeMode(bool enable, const IntSize& minSize);
@@ -920,7 +920,8 @@
bool m_isPainting { false };
-bool m_isVisuallyNonEmpty { false };
+bool m_contentQualifiesAsVisuallyNonEmpty { false };
+bool m_firstVisuallyNonEmptyLayoutMilestoneIsPending { true };
bool m_renderedSignificantAmountOfText { false };
bool m_hasReachedSignificantRenderedTextThreshold { false };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [256998] tags/Safari-609.1.20.0.1/
Title: [256998] tags/Safari-609.1.20.0.1/ Revision 256998 Author alanc...@apple.com Date 2020-02-19 16:45:17 -0800 (Wed, 19 Feb 2020) Log Message Delete tag. Removed Paths tags/Safari-609.1.20.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256995] branches/safari-609.1.20.0-branch
Title: [256995] branches/safari-609.1.20.0-branch Revision 256995 Author alanc...@apple.com Date 2020-02-19 16:41:44 -0800 (Wed, 19 Feb 2020) Log Message Revert r256963. rdar://problem/59478837 Modified Paths branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events-expected.txt branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.0-branch/Source/WebCore/animation/AnimationTimeline.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/AnimationTimeline.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSAnimation.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSAnimation.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/KeyframeEffect.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/KeyframeEffect.h branches/safari-609.1.20.0-branch/Source/WebCore/style/StyleTreeResolver.cpp Diff Modified: branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog (256994 => 256995) --- branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-20 00:40:38 UTC (rev 256994) +++ branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-20 00:41:44 UTC (rev 256995) @@ -1,3 +1,7 @@ +2020-02-19 Alan Coon + +Revert r256963. rdar://problem/59478837 + 2020-02-19 Russell Epstein Apply patch. rdar://problem/59478837 Modified: branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations (256994 => 256995) --- branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations 2020-02-20 00:40:38 UTC (rev 256994) +++ branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations 2020-02-20 00:41:44 UTC (rev 256995) @@ -2651,6 +2651,8 @@ webkit.org/b/179069 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/sandbox_032.htm [ Pass Failure ] +webkit.org/b/202107 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events.html [ Pass Failure ] +webkit.org/b/202108 imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events.html [ Pass Failure ] webkit.org/b/202109 imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html [ Pass Failure ] webkit.org/b/157068 [ Debug ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Crash ] Modified: branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog (256994 => 256995) --- branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog 2020-02-20 00:40:38 UTC (rev 256994) +++ branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog 2020-02-20 00:41:44 UTC (rev 256995) @@ -1,3 +1,7 @@ +2020-02-19 Alan Coon + +Revert r256963. rdar://problem/59478837 + 2020-02-19 Russell Epstein Apply patch. rdar://problem/59478837 Modified: branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt (256994 => 256995) --- branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt 2020-02-20 00:40:38 UTC (rev 256994) +++ branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt 2020-02-20 00:41:44 UTC (rev 256995) @@ -1,26 +1,26 @@ PASS All property keys are recognized -PASS Animation.id produces expected style change events -PASS Animation.effect produces expected style change events -PASS Animation.timeline produces expected style change events -PASS Animation.startTime produces expected style change events -PASS Animation.currentTime produces expected style change events -PASS Animation.playbackRate produces expected style change events -PASS Animation.playState produces expected style change events -PASS Animation.replaceState produces expected style change events -PASS Animation.pending produces expected style change events -PASS Animation.onfinish produces expected style change events -PASS Animation.oncancel produces expected style change events -PASS Animation.onremove produces expected style change events -PASS Animation.ready produces expected style change events -PASS Animation.finished produces expected style change events -PASS Animation.cancel produces expected style change events -PASS Animation.finish produces expected style change events -PASS Animation.play produces expected style change events -PASS Animation.pause produces expected style change events -PASS
[webkit-changes] [256997] branches/safari-609.1.20.0-branch/Source/WebCore
Title: [256997] branches/safari-609.1.20.0-branch/Source/WebCore
Revision 256997
Author alanc...@apple.com
Date 2020-02-19 16:41:55 -0800 (Wed, 19 Feb 2020)
Log Message
Revert r256989. rdar://problem/59298138
Modified Paths
branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElementEnums.h
branches/safari-609.1.20.0-branch/Source/WebCore/html/shadow/MediaControlElements.cpp
branches/safari-609.1.20.0-branch/Source/WebCore/html/shadow/MediaControlElements.h
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/TextTrackRepresentation.cpp
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/TextTrackRepresentation.h
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManagerObjC.h
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManagerObjC.mm
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.h
branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm
branches/safari-609.1.20.0-branch/Source/WebCore/rendering/RenderMediaControlElements.cpp
Diff
Modified: branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog (256996 => 256997)
--- branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog 2020-02-20 00:41:50 UTC (rev 256996)
+++ branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog 2020-02-20 00:41:55 UTC (rev 256997)
@@ -1,5 +1,9 @@
2020-02-19 Alan Coon
+Revert r256989. rdar://problem/59298138
+
+2020-02-19 Alan Coon
+
Revert r256963. rdar://problem/59478837
2020-02-19 Alan Coon
Modified: branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElement.cpp (256996 => 256997)
--- branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElement.cpp 2020-02-20 00:41:50 UTC (rev 256996)
+++ branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElement.cpp 2020-02-20 00:41:55 UTC (rev 256997)
@@ -274,18 +274,6 @@
return values[static_cast(enumerationValue)];
}
-String convertEnumerationToString(HTMLMediaElement::TextTrackVisibilityCheckType enumerationValue)
-{
-static const NeverDestroyed values[] = {
-MAKE_STATIC_STRING_IMPL("CheckTextTrackVisibility"),
-MAKE_STATIC_STRING_IMPL("AssumeTextTrackVisibilityChanged"),
-};
-static_assert(static_cast(HTMLMediaElement::TextTrackVisibilityCheckType::CheckTextTrackVisibility) == 0, "TextTrackVisibilityCheckType::CheckTextTrackVisibility is not 0 as expected");
-static_assert(static_cast(HTMLMediaElement::TextTrackVisibilityCheckType::AssumeTextTrackVisibilityChanged) == 1, "TextTrackVisibilityCheckType::AssumeTextTrackVisibilityChanged is not 1 as expected");
-ASSERT(static_cast(enumerationValue) < WTF_ARRAY_LENGTH(values));
-return values[static_cast(enumerationValue)];
-}
-
#if ENABLE(VIDEO_TRACK)
class TrackDisplayUpdateScope {
@@ -6547,7 +6535,7 @@
#if ENABLE(VIDEO_TRACK)
void HTMLMediaElement::configureTextTrackDisplay(TextTrackVisibilityCheckType checkType)
{
-ALWAYS_LOG(LOGIDENTIFIER, checkType);
+ALWAYS_LOG(LOGIDENTIFIER);
ASSERT(m_textTracks);
if (m_processingPreferenceChange)
Modified: branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElementEnums.h (256996 => 256997)
--- branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElementEnums.h 2020-02-20 00:41:50 UTC (rev 256996)
+++ branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElementEnums.h 2020-02-20 00:41:55 UTC (rev 256997)
@@ -47,7 +47,6 @@
String convertEnumerationToString(HTMLMediaElementEnums::ReadyState);
String convertEnumerationToString(HTMLMediaElementEnums::NetworkState);
-String convertEnumerationToString(HTMLMediaElementEnums::TextTrackVisibilityCheckType);
} // namespace WebCore
@@ -72,13 +71,5 @@
}
};
-template <>
-struct LogArgument {
-static String toString(const WebCore::HTMLMediaElementEnums::TextTrackVisibilityCheckType type)
-{
-return convertEnumerationToString(type);
-}
-};
-
}; // namespace WTF
Modified:
[webkit-changes] [256996] branches/safari-609.1.20.0-branch/Source/JavaScriptCore
Title: [256996] branches/safari-609.1.20.0-branch/Source/_javascript_Core
Revision 256996
Author alanc...@apple.com
Date 2020-02-19 16:41:50 -0800 (Wed, 19 Feb 2020)
Log Message
Revert r256988. rdar://problem/59478911
Modified Paths
branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.cpp
branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.h
branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/StructureTransitionTable.h
Diff
Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog (256995 => 256996)
--- branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-20 00:41:44 UTC (rev 256995)
+++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-20 00:41:50 UTC (rev 256996)
@@ -1,5 +1,9 @@
2020-02-19 Alan Coon
+Revert r256988. rdar://problem/59478911
+
+2020-02-19 Alan Coon
+
Apply patch. rdar://problem/59478911
2020-02-19 Yusuke Suzuki
Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.cpp (256995 => 256996)
--- branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.cpp 2020-02-20 00:41:44 UTC (rev 256995)
+++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.cpp 2020-02-20 00:41:50 UTC (rev 256996)
@@ -93,7 +93,7 @@
Structure* transition = singleTransition();
return transition && transition->m_nameInPrevious == rep && transition->attributesInPrevious() == attributes;
}
-return map()->get(StructureTransitionTable::Hash::Key(rep, attributes, false));
+return map()->get(std::make_pair(rep, attributes));
}
inline Structure* StructureTransitionTable::get(UniquedStringImpl* rep, unsigned attributes) const
@@ -102,7 +102,7 @@
Structure* transition = singleTransition();
return (transition && transition->m_nameInPrevious == rep && transition->attributesInPrevious() == attributes) ? transition : 0;
}
-return map()->get(StructureTransitionTable::Hash::Key(rep, attributes, false));
+return map()->get(std::make_pair(rep, attributes));
}
void StructureTransitionTable::add(VM& vm, Structure* structure)
@@ -123,7 +123,11 @@
}
// Add the structure to the map.
-map()->set(StructureTransitionTable::Hash::Key(structure->m_nameInPrevious.get(), +structure->attributesInPrevious(), false), structure);
+
+// Newer versions of the STL have an std::make_pair function that takes rvalue references.
+// When either of the parameters are bitfields, the C++ compiler will try to bind them as lvalues, which is invalid. To work around this, use unary "+" to make the parameter an rvalue.
+// See https://bugs.webkit.org/show_bug.cgi?id=59261 for more details
+map()->set(std::make_pair(structure->m_nameInPrevious.get(), +structure->attributesInPrevious()), structure);
}
void Structure::dumpStatistics()
Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.h (256995 => 256996)
--- branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.h 2020-02-20 00:41:44 UTC (rev 256995)
+++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.h 2020-02-20 00:41:50 UTC (rev 256996)
@@ -638,7 +638,6 @@
#define DEFINE_BITFIELD(type, lowerName, upperName, width, offset) \
static constexpr uint32_t s_##lowerName##Shift = offset;\
static constexpr uint32_t s_##lowerName##Mask = ((1 << (width - 1)) | ((1 << (width - 1)) - 1));\
-static constexpr uint32_t s_bitWidthOf##upperName = width;\
type lowerName() const { return static_cast((m_bitField >> offset) & s_##lowerName##Mask); }\
void set##upperName(type newValue) \
{\
@@ -663,8 +662,6 @@
DEFINE_BITFIELD(bool, isAddingPropertyForTransition, IsAddingPropertyForTransition, 1, 28);
DEFINE_BITFIELD(bool, hasUnderscoreProtoPropertyExcludingOriginalProto, HasUnderscoreProtoPropertyExcludingOriginalProto, 1, 29);
-static_assert(s_bitWidthOfAttributesInPrevious <= sizeof(TransitionPropertyAttributes) * 8);
-
private:
friend class LLIntOffsetsExtractor;
Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/StructureTransitionTable.h (256995 => 256996)
--- branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/StructureTransitionTable.h 2020-02-20 00:41:44 UTC (rev 256995)
+++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/StructureTransitionTable.h 2020-02-20 00:41:50 UTC (rev 256996)
@@ -52,7 +52,6 @@
Seal,
Freeze
};
-using TransitionPropertyAttributes = uint16_t;
inline unsigned toAttributes(NonPropertyTransition transition)
{
@@ -144,74 +143,8 @@
static constexpr intptr_t UsingSingleSlotFlag = 1;
-#if CPU(ADDRESS64)
struct Hash {
-// Logically, Key is a tuple of (1)
[webkit-changes] [256994] branches/safari-609.1.20.101-branch/
Title: [256994] branches/safari-609.1.20.101-branch/ Revision 256994 Author kocsen_ch...@apple.com Date 2020-02-19 16:40:38 -0800 (Wed, 19 Feb 2020) Log Message New branch. Added Paths branches/safari-609.1.20.101-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256993] branches/safari-609.1.20.100-branch/
Title: [256993] branches/safari-609.1.20.100-branch/ Revision 256993 Author kocsen_ch...@apple.com Date 2020-02-19 16:37:57 -0800 (Wed, 19 Feb 2020) Log Message New branch. Added Paths branches/safari-609.1.20.100-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256991] branches/safari-609.1.20.1-branch/Source/JavaScriptCore/runtime/ OptionsList.h
Title: [256991] branches/safari-609.1.20.1-branch/Source/_javascript_Core/runtime/OptionsList.h Revision 256991 Author alanc...@apple.com Date 2020-02-19 16:29:45 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59576777 Modified Paths branches/safari-609.1.20.1-branch/Source/_javascript_Core/runtime/OptionsList.h Diff Modified: branches/safari-609.1.20.1-branch/Source/_javascript_Core/runtime/OptionsList.h (256990 => 256991) --- branches/safari-609.1.20.1-branch/Source/_javascript_Core/runtime/OptionsList.h 2020-02-19 23:59:43 UTC (rev 256990) +++ branches/safari-609.1.20.1-branch/Source/_javascript_Core/runtime/OptionsList.h 2020-02-20 00:29:45 UTC (rev 256991) @@ -473,7 +473,7 @@ v(Size, webAssemblyBBQAirModeThreshold, isIOS() ? (10 * MB) : 0, Normal, "If 0, we always use BBQ Air. If Wasm module code size hits this threshold, we compile Wasm module with B3 BBQ mode.") \ v(Bool, useWebAssemblyStreamingApi, enableWebAssemblyStreamingApi, Normal, "Allow to run WebAssembly's Streaming API") \ v(Bool, useEagerWebAssemblyModuleHashing, false, Normal, "Unnamed WebAssembly modules are identified in backtraces through their hash, if available.") \ -v(Bool, useWebAssemblyReferences, true, Normal, "Allow types from the wasm references spec.") \ +v(Bool, useWebAssemblyReferences, false, Normal, "Allow types from the wasm references spec.") \ v(Bool, useWebAssemblyMultiValues, true, Normal, "Allow types from the wasm mulit-values spec.") \ v(Bool, useWeakRefs, false, Normal, "Expose the WeakRef constructor.") \ v(Bool, useBigInt, false, Normal, "If true, we will enable BigInt support.") \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256992] branches/safari-609.1.20.1-branch/Source/JavaScriptCore
Title: [256992] branches/safari-609.1.20.1-branch/Source/_javascript_Core Revision 256992 Author alanc...@apple.com Date 2020-02-19 16:29:51 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59576803 Modified Paths branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.1-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/bytecode/CodeBlock.h branches/safari-609.1.20.1-branch/Source/_javascript_Core/dfg/DFGJITCode.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/dfg/DFGJITCode.h branches/safari-609.1.20.1-branch/Source/_javascript_Core/dfg/DFGJITCompiler.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/dfg/DFGJITFinalizer.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/dfg/DFGPlan.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/ftl/FTLJITCode.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/ftl/FTLJITCode.h branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JIT.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JIT.h branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITCode.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITCode.h branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITInlines.h Diff Modified: branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog (256991 => 256992) --- branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog 2020-02-20 00:29:45 UTC (rev 256991) +++ branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog 2020-02-20 00:29:51 UTC (rev 256992) @@ -1,5 +1,70 @@ 2020-02-19 Alan Coon +Apply patch. rdar://problem/59576803 + +2020-02-19 Yusuke Suzuki + +[JSC] CodeBlock::shrinkToFit should shrink m_constantRegisters and m_constantsSourceCodeRepresentation in 64bit architectures +https://bugs.webkit.org/show_bug.cgi?id=207356 + +Reviewed by Mark Lam. + +Only 32bit architectures are using m_constantRegisters's address. 64bit architectures are not relying on m_constantRegisters's address. +This patches fixes the thing so that CodeBlock::shrinkToFit will shrink m_constantRegisters and m_constantsSourceCodeRepresentation +regardless of whether this is EarlyShrink or not. We also move DFG/FTL's LateShrink call to the place after calling DFGCommon reallyAdd +since they can add more constant registers. + +Relanding it by fixing dead-lock. + +* bytecode/CodeBlock.cpp: +(JSC::CodeBlock::shrinkToFit): +* bytecode/CodeBlock.h: +* dfg/DFGJITCompiler.cpp: +(JSC::DFG::JITCompiler::compile): +(JSC::DFG::JITCompiler::compileFunction): +* dfg/DFGJITFinalizer.cpp: +(JSC::DFG::JITFinalizer::finalizeCommon): +* dfg/DFGPlan.cpp: +(JSC::DFG::Plan::compileInThreadImpl): +(JSC::DFG::Plan::finalizeWithoutNotifyingCallback): +* jit/JIT.cpp: +(JSC::JIT::link): +* jit/JIT.h: +* jit/JITInlines.h: +(JSC::JIT::emitLoadDouble): +(JSC::JIT::emitLoadInt32ToDouble): Deleted. + +2020-01-31 Yusuke Suzuki + +[JSC] DFG::CommonData::shrinkToFit called before DFG::Plan::reallyAdd is called +https://bugs.webkit.org/show_bug.cgi?id=207083 + +Reviewed by Mark Lam. + +We are calling DFG::CommonData::shrinkToFit, but calling this too early: we execute +DFG::Plan::reallyAdd(DFG::CommonData*) after that, and this adds many entries to +DFG::CommonData*. We should call DFG::CommonData::shrinkToFit after calling DFG::Plan::reallyAdd. + +To implement it, we make DFG::JITCode::shrinkToFit virtual function in JSC::JITCode. Then, we +can also implement FTL::JITCode::shrinkToFit which was previously not implemented. + +* dfg/DFGJITCode.cpp: +(JSC::DFG::JITCode::shrinkToFit): +* dfg/DFGJITCode.h: +* dfg/DFGJITCompiler.cpp: +(JSC::DFG::JITCompiler::compile): +(JSC::DFG::JITCompiler::compileFunction): +* dfg/DFGPlan.cpp: +(JSC::DFG::Plan::finalizeWithoutNotifyingCallback): +* ftl/FTLJITCode.cpp: +(JSC::FTL::JITCode::shrinkToFit): +* ftl/FTLJITCode.h: +* jit/JITCode.cpp: +(JSC::JITCode::shrinkToFit): +* jit/JITCode.h: + +2020-02-19 Alan Coon + Apply patch. rdar://problem/59576778 2020-02-19 Yusuke Suzuki Modified: branches/safari-609.1.20.1-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp (256991 => 256992) --- branches/safari-609.1.20.1-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp 2020-02-20 00:29:45 UTC (rev 256991) +++ branches/safari-609.1.20.1-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp 2020-02-20
[webkit-changes] [256990] tags/Safari-609.1.20.0.1/
Title: [256990] tags/Safari-609.1.20.0.1/ Revision 256990 Author alanc...@apple.com Date 2020-02-19 15:59:43 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.0.1. Added Paths tags/Safari-609.1.20.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256989] branches/safari-609.1.20.0-branch/Source/WebCore
Title: [256989] branches/safari-609.1.20.0-branch/Source/WebCore Revision 256989 Author alanc...@apple.com Date 2020-02-19 15:56:37 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59298138 Modified Paths branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElement.cpp branches/safari-609.1.20.0-branch/Source/WebCore/html/HTMLMediaElementEnums.h branches/safari-609.1.20.0-branch/Source/WebCore/html/shadow/MediaControlElements.cpp branches/safari-609.1.20.0-branch/Source/WebCore/html/shadow/MediaControlElements.h branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/TextTrackRepresentation.cpp branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/TextTrackRepresentation.h branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManagerObjC.h branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManagerObjC.mm branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.h branches/safari-609.1.20.0-branch/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm branches/safari-609.1.20.0-branch/Source/WebCore/rendering/RenderMediaControlElements.cpp Diff Modified: branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog (256988 => 256989) --- branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog 2020-02-19 23:54:34 UTC (rev 256988) +++ branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog 2020-02-19 23:56:37 UTC (rev 256989) @@ -1,3 +1,81 @@ +2020-02-19 Alan Coon + +Apply patch. rdar://problem/59298138 + +2020-02-19 Eric Carlson + +Captions sometimes render at the wrong size when in fullscreen and PiP +https://bugs.webkit.org/show_bug.cgi?id=207389 + + +The TextTrackRepresentation, used to render captions when in fullscreen and PiP on +iOS and and in PiP on macOS, frequently rendered captions before layout completed +immediately after it was created. Fix this by having it not render until a layout +happens. Additionally, make the code more efficient by hiding the TextTrackRepresentation's +backing layer when cues are not visible instead of destroying the whole object. +Drive by: RELEASE_LOG_DISABLED is always defined for PLATFORM(COCOA), so remove it +from the macOS/iOS media players to make it easier to add logging to VideoFullscreenLayerManagerObjC. + + +* html/HTMLMediaElement.cpp: +(WebCore::convertEnumerationToString): +(WebCore::HTMLMediaElement::configureTextTrackDisplay): +* html/HTMLMediaElementEnums.h: +(WTF::LogArgument::toString): +* html/shadow/MediaControlElements.cpp: +(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): +(WebCore::MediaControlTextTrackContainerElement::updateDisplay): +(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation): +(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation): +(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentationStyle): +(WebCore::MediaControlTextTrackContainerElement::layoutIfNecessary): +(WebCore::MediaControlTextTrackContainerElement::updateVideoDisplaySize): +(WebCore::MediaControlTextTrackContainerElement::updateSizes): +(WebCore::MediaControlTextTrackContainerElement::updateCueStyles): +(WebCore::MediaControlTextTrackContainerElement::logger const): +(WebCore::MediaControlTextTrackContainerElement::logIdentifier const): +(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Deleted. +(WebCore::MediaControlTextTrackContainerElement::updateStyleForTextTrackRepresentation): Deleted. +* platform/graphics/TextTrackRepresentation.h: +* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: +(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): +(WebCore::MediaPlayerPrivateAVFoundation::logChannel
[webkit-changes] [256988] branches/safari-609.1.20.0-branch/Source/JavaScriptCore
Title: [256988] branches/safari-609.1.20.0-branch/Source/_javascript_Core Revision 256988 Author alanc...@apple.com Date 2020-02-19 15:54:34 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59478911 Modified Paths branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/StructureTransitionTable.h Diff Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog (256987 => 256988) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:45:29 UTC (rev 256987) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:54:34 UTC (rev 256988) @@ -1,3 +1,33 @@ +2020-02-19 Alan Coon + +Apply patch. rdar://problem/59478911 + +2020-02-19 Yusuke Suzuki + +[JSC] Compact StructureTransitionTable +https://bugs.webkit.org/show_bug.cgi?id=207616 + +Reviewed by Mark Lam. + +Some of StructureTransitionTable are shown as very large HashMap and we can compact it by encoding key. +We leverage 48bit pointers and 8byte alignment of UniquedStringImpl* to encode other parameters into it. + +* runtime/Structure.cpp: +(JSC::StructureTransitionTable::contains const): +(JSC::StructureTransitionTable::get const): +(JSC::StructureTransitionTable::add): +* runtime/Structure.h: +* runtime/StructureTransitionTable.h: +(JSC::StructureTransitionTable::Hash::Key::Key): +(JSC::StructureTransitionTable::Hash::Key::isHashTableDeletedValue const): +(JSC::StructureTransitionTable::Hash::Key::impl const): +(JSC::StructureTransitionTable::Hash::Key::isAddition const): +(JSC::StructureTransitionTable::Hash::Key::attributes const): +(JSC::StructureTransitionTable::Hash::Key::operator==): +(JSC::StructureTransitionTable::Hash::Key::operator!=): +(JSC::StructureTransitionTable::Hash::hash): +(JSC::StructureTransitionTable::Hash::equal): + 2020-02-19 Russell Epstein Cherry-pick r256898. rdar://problem/59551695 Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.cpp (256987 => 256988) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.cpp 2020-02-19 23:45:29 UTC (rev 256987) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.cpp 2020-02-19 23:54:34 UTC (rev 256988) @@ -93,7 +93,7 @@ Structure* transition = singleTransition(); return transition && transition->m_nameInPrevious == rep && transition->attributesInPrevious() == attributes; } -return map()->get(std::make_pair(rep, attributes)); +return map()->get(StructureTransitionTable::Hash::Key(rep, attributes, false)); } inline Structure* StructureTransitionTable::get(UniquedStringImpl* rep, unsigned attributes) const @@ -102,7 +102,7 @@ Structure* transition = singleTransition(); return (transition && transition->m_nameInPrevious == rep && transition->attributesInPrevious() == attributes) ? transition : 0; } -return map()->get(std::make_pair(rep, attributes)); +return map()->get(StructureTransitionTable::Hash::Key(rep, attributes, false)); } void StructureTransitionTable::add(VM& vm, Structure* structure) @@ -123,11 +123,7 @@ } // Add the structure to the map. - -// Newer versions of the STL have an std::make_pair function that takes rvalue references. -// When either of the parameters are bitfields, the C++ compiler will try to bind them as lvalues, which is invalid. To work around this, use unary "+" to make the parameter an rvalue. -// See https://bugs.webkit.org/show_bug.cgi?id=59261 for more details -map()->set(std::make_pair(structure->m_nameInPrevious.get(), +structure->attributesInPrevious()), structure); +map()->set(StructureTransitionTable::Hash::Key(structure->m_nameInPrevious.get(), +structure->attributesInPrevious(), false), structure); } void Structure::dumpStatistics() Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.h (256987 => 256988) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.h 2020-02-19 23:45:29 UTC (rev 256987) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/Structure.h 2020-02-19 23:54:34 UTC (rev 256988) @@ -638,6 +638,7 @@ #define DEFINE_BITFIELD(type, lowerName, upperName, width, offset) \ static constexpr uint32_t s_##lowerName##Shift = offset;\ static constexpr uint32_t s_##lowerName##Mask = ((1 << (width - 1)) | ((1 << (width - 1)) - 1));\ +static constexpr
[webkit-changes] [256987] trunk/LayoutTests
Title: [256987] trunk/LayoutTests Revision 256987 Author lawrenc...@apple.com Date 2020-02-19 15:45:29 -0800 (Wed, 19 Feb 2020) Log Message [ Mac ] css3/selectors3/xml/css3-modsel-d1.xml is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=207971 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256986 => 256987) --- trunk/LayoutTests/ChangeLog 2020-02-19 23:39:13 UTC (rev 256986) +++ trunk/LayoutTests/ChangeLog 2020-02-19 23:45:29 UTC (rev 256987) @@ -1,3 +1,12 @@ +2020-02-19 Jason Lawrence + +[ Mac ] css3/selectors3/xml/css3-modsel-d1.xml is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=207971 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2020-02-19 Lauro Moura [GTK] More media tests gardening Modified: trunk/LayoutTests/platform/mac/TestExpectations (256986 => 256987) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-02-19 23:39:13 UTC (rev 256986) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-02-19 23:45:29 UTC (rev 256987) @@ -2033,3 +2033,5 @@ webkit.org/b/207858 fast/canvas/webgl/webgl2-texture-upload-enums.html [ Failure ] webkit.org/b/207858 fast/canvas/webgl/texImage2D-video-flipY-false.html [ Skip ] webkit.org/b/207858 webgl/1.0.3/conformance/programs/program-test.html [ Failure ] + +webkit.org/b/207971 css3/selectors3/xml/css3-modsel-d1.xml [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256981] branches/safari-609.1.20.1-branch/JSTests
Title: [256981] branches/safari-609.1.20.1-branch/JSTests Revision 256981 Author repst...@apple.com Date 2020-02-19 15:38:37 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256698. rdar://problem/59576809 Unreviewed: fix broken tests added in r256665 https://bugs.webkit.org/show_bug.cgi?id=207727 Our inline WAT doesn't seem to like named blocks/branch targets. * wasm/regress/llint-callee-saves-with-fast-memory.js: * wasm/regress/llint-callee-saves-without-fast-memory.js: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.1-branch/JSTests/ChangeLog branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js Diff Modified: branches/safari-609.1.20.1-branch/JSTests/ChangeLog (256980 => 256981) --- branches/safari-609.1.20.1-branch/JSTests/ChangeLog 2020-02-19 23:38:32 UTC (rev 256980) +++ branches/safari-609.1.20.1-branch/JSTests/ChangeLog 2020-02-19 23:38:37 UTC (rev 256981) @@ -1,5 +1,29 @@ 2020-02-19 Alan Coon +Cherry-pick r256698. rdar://problem/59576809 + +Unreviewed: fix broken tests added in r256665 +https://bugs.webkit.org/show_bug.cgi?id=207727 + +Our inline WAT doesn't seem to like named blocks/branch targets. + +* wasm/regress/llint-callee-saves-with-fast-memory.js: +* wasm/regress/llint-callee-saves-without-fast-memory.js: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-14 Tadeu Zagallo + +Unreviewed: fix broken tests added in r256665 +https://bugs.webkit.org/show_bug.cgi?id=207727 + +Our inline WAT doesn't seem to like named blocks/branch targets. + +* wasm/regress/llint-callee-saves-with-fast-memory.js: +* wasm/regress/llint-callee-saves-without-fast-memory.js: + +2020-02-19 Alan Coon + Cherry-pick r256665. rdar://problem/59576809 [WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention. Modified: branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js (256980 => 256981) --- branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js 2020-02-19 23:38:32 UTC (rev 256980) +++ branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js 2020-02-19 23:38:37 UTC (rev 256981) @@ -23,11 +23,11 @@ (func (export "main") (local $i i32) (local.set $i (i32.const 10)) -(loop $warmup +(loop (i32.sub (local.get $i) (i32.const 1)) (local.tee $i) (call $f (i32.const 1)) -(br_if $warmup) +(br_if 0) ) (call $f (i32.const 0)) ) Modified: branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js (256980 => 256981) --- branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js 2020-02-19 23:38:32 UTC (rev 256980) +++ branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js 2020-02-19 23:38:37 UTC (rev 256981) @@ -21,11 +21,11 @@ (func (export "main") (local $i i32) (local.set $i (i32.const 10)) -(loop $warmup +(loop (i32.sub (local.get $i) (i32.const 1)) (local.tee $i) (call $f (i32.const 1)) -(br_if $warmup) +(br_if 0) ) (call $f (i32.const 0)) ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256984] branches/safari-609.1.20.1-branch/Source/WebCore
Title: [256984] branches/safari-609.1.20.1-branch/Source/WebCore
Revision 256984
Author repst...@apple.com
Date 2020-02-19 15:38:53 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256584. rdar://problem/59576819
MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
https://bugs.webkit.org/show_bug.cgi?id=207733
Reviewed by Maciej Stachowiak.
* platform/mac/PlatformScreenMac.mm:
(WebCore::setShouldOverrideScreenSupportsHighDynamicRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.1-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm
Diff
Modified: branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog (256983 => 256984)
--- branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog 2020-02-19 23:38:48 UTC (rev 256983)
+++ branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog 2020-02-19 23:38:53 UTC (rev 256984)
@@ -1,5 +1,32 @@
2020-02-19 Alan Coon
+Cherry-pick r256584. rdar://problem/59576819
+
+MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
+https://bugs.webkit.org/show_bug.cgi?id=207733
+
+
+Reviewed by Maciej Stachowiak.
+
+* platform/mac/PlatformScreenMac.mm:
+(WebCore::setShouldOverrideScreenSupportsHighDynamicRange):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-13 Jer Noble
+
+MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
+https://bugs.webkit.org/show_bug.cgi?id=207733
+
+
+Reviewed by Maciej Stachowiak.
+
+* platform/mac/PlatformScreenMac.mm:
+(WebCore::setShouldOverrideScreenSupportsHighDynamicRange):
+
+2020-02-19 Alan Coon
+
Cherry-pick r255881. rdar://problem/59576819
Adopt MTOverrideShouldPlayHDRVideo()
Modified: branches/safari-609.1.20.1-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm (256983 => 256984)
--- branches/safari-609.1.20.1-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm 2020-02-19 23:38:48 UTC (rev 256983)
+++ branches/safari-609.1.20.1-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm 2020-02-19 23:38:53 UTC (rev 256984)
@@ -158,7 +158,7 @@
void setShouldOverrideScreenSupportsHighDynamicRange(bool shouldOverride, bool supportsHighDynamicRange)
{
-if (PAL::canLoad_MediaToolbox_MTOverrideShouldPlayHDRVideo())
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTOverrideShouldPlayHDRVideo())
PAL::softLink_MediaToolbox_MTOverrideShouldPlayHDRVideo(shouldOverride, supportsHighDynamicRange);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256986] branches/safari-609.1.20.1-branch
Title: [256986] branches/safari-609.1.20.1-branch Revision 256986 Author repst...@apple.com Date 2020-02-19 15:39:13 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59576808 Modified Paths branches/safari-609.1.20.1-branch/LayoutTests/ChangeLog branches/safari-609.1.20.1-branch/LayoutTests/TestExpectations branches/safari-609.1.20.1-branch/LayoutTests/compositing/backing/animate-into-view.html branches/safari-609.1.20.1-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-609.1.20.1-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-startTime.tentative-expected.txt branches/safari-609.1.20.1-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt branches/safari-609.1.20.1-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt branches/safari-609.1.20.1-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events-expected.txt branches/safari-609.1.20.1-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-expected.txt branches/safari-609.1.20.1-branch/LayoutTests/webanimations/css-transition-in-flight-reversal-accelerated.html branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.1-branch/Source/WebCore/animation/CSSTransition.h branches/safari-609.1.20.1-branch/Source/WebCore/animation/DeclarativeAnimation.cpp branches/safari-609.1.20.1-branch/Source/WebCore/animation/DeclarativeAnimation.h branches/safari-609.1.20.1-branch/Source/WebCore/animation/DocumentTimeline.cpp branches/safari-609.1.20.1-branch/Source/WebCore/animation/DocumentTimeline.h branches/safari-609.1.20.1-branch/Source/WebCore/animation/WebAnimation.cpp branches/safari-609.1.20.1-branch/Source/WebCore/animation/WebAnimation.h Diff Modified: branches/safari-609.1.20.1-branch/LayoutTests/ChangeLog (256985 => 256986) --- branches/safari-609.1.20.1-branch/LayoutTests/ChangeLog 2020-02-19 23:39:05 UTC (rev 256985) +++ branches/safari-609.1.20.1-branch/LayoutTests/ChangeLog 2020-02-19 23:39:13 UTC (rev 256986) @@ -1,5 +1,27 @@ 2020-02-19 Alan Coon +Apply patch. rdar://problem/59576808 + +2020-02-19 Antoine Quint + +[Web Animations] Ensure CSS Transition and CSS Animation events are queued, sorted and dispatched by their timeline +https://bugs.webkit.org/show_bug.cgi?id=207364 + + +Reviewed by Simon Fraser. + +Fix a couple of tests that made some incorrect assumptions. + +* TestExpectations: imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html is no longer flaky. +* compositing/backing/animate-into-view.html: Because the "animationstart" event is now dispatched during the "update animations and send events" procedure, which happens +during page rendering _before_ rAF callbacks are serviced, we must remove the rAF callback used prior to adding the "animationstart" event listener or else we would never +get it and the test would time out. +* webanimations/css-transition-in-flight-reversal-accelerated.html: We must wait for the initial transition to start and then two frames before reversing the transition, +to be certain that the animation did start. Indeed, the "transitionstart" event will be fired right before the next rAF callback is called, as the animation starts in that +very same frame, and so progress will be 0 and the transition wouldn't be reversable until the next frame when the animation has progress > 0. + +2020-02-19 Alan Coon + Cherry-pick r256513. rdar://problem/59576794 REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side Modified: branches/safari-609.1.20.1-branch/LayoutTests/TestExpectations (256985 => 256986) --- branches/safari-609.1.20.1-branch/LayoutTests/TestExpectations 2020-02-19 23:39:05 UTC (rev 256985) +++ branches/safari-609.1.20.1-branch/LayoutTests/TestExpectations 2020-02-19 23:39:13 UTC (rev 256986) @@ -2653,7 +2653,6 @@ webkit.org/b/202107 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events.html [ Pass Failure ] webkit.org/b/202108 imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events.html [ Pass Failure ] -webkit.org/b/202109 imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html [ Pass Failure ] webkit.org/b/157068 [ Debug ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Crash ] webkit.org/b/157068 [ Release ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Failure ] Modified:
[webkit-changes] [256979] branches/safari-609.1.20.1-branch
Title: [256979] branches/safari-609.1.20.1-branch
Revision 256979
Author repst...@apple.com
Date 2020-02-19 15:38:25 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256432. rdar://problem/59576791
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
https://bugs.webkit.org/show_bug.cgi?id=207537
Reviewed by Chris Dumez.
Source/WebKit:
Covered by added API test.
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog
branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
branches/safari-609.1.20.1-branch/Tools/ChangeLog
branches/safari-609.1.20.1-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
Diff
Modified: branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog (256978 => 256979)
--- branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog 2020-02-19 23:38:20 UTC (rev 256978)
+++ branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog 2020-02-19 23:38:25 UTC (rev 256979)
@@ -1,5 +1,42 @@
2020-02-19 Alan Coon
+Cherry-pick r256432. rdar://problem/59576791
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Source/WebKit:
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
+Tools:
+
+* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-12 Youenn Fablet
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
+2020-02-19 Alan Coon
+
Cherry-pick r256383. rdar://problem/59576791
Unreviewed, rolling out r256314.
Modified: branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256978 => 256979)
--- branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:38:20 UTC (rev 256978)
+++ branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:38:25 UTC (rev 256979)
@@ -319,6 +319,7 @@
bool isNewOrigin = WTF::allOf(m_clientOrigins.values(), [](auto& origin) {
return contextOrigin != origin.clientOrigin;
});
+auto* contextConnection = isNewOrigin ? server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin }) : nullptr;
auto clientOrigin = ClientOrigin { WTFMove(topOrigin), WTFMove(contextOrigin) };
m_clientOrigins.add(data.identifier, clientOrigin);
@@ -327,11 +328,9 @@
if (!m_isThrottleable)
updateThrottleState();
-if (isNewOrigin) {
-if (auto* contextConnection = server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin })) {
-auto& connection = static_cast(*contextConnection);
-m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
-}
+if (contextConnection) {
+auto& connection = static_cast(*contextConnection);
+m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
}
}
Modified: branches/safari-609.1.20.1-branch/Tools/ChangeLog (256978 => 256979)
--- branches/safari-609.1.20.1-branch/Tools/ChangeLog 2020-02-19 23:38:20 UTC (rev 256978)
+++ branches/safari-609.1.20.1-branch/Tools/ChangeLog 2020-02-19 23:38:25 UTC (rev 256979)
@@ -1,5 +1,38 @@
2020-02-19 Alan Coon
+Cherry-pick
[webkit-changes] [256976] branches/safari-609.1.20.1-branch
Title: [256976] branches/safari-609.1.20.1-branch
Revision 256976
Author repst...@apple.com
Date 2020-02-19 15:38:08 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256766. rdar://problem/59576813
[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
https://bugs.webkit.org/show_bug.cgi?id=207849
Reviewed by Mark Lam.
JSTests:
* wasm/regress/regress-256665.js: Added.
(f):
Source/_javascript_Core:
When generating the call IC, we should select the callee saves using BoundsChecking mode in order
to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
register when calling the Wasm LLInt through the call IC.
* wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::calleeSaves const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.1-branch/JSTests/ChangeLog
branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-609.1.20.1-branch/Source/_javascript_Core/wasm/js/WebAssemblyFunction.cpp
Added Paths
branches/safari-609.1.20.1-branch/JSTests/wasm/regress/regress-256665.js
Diff
Modified: branches/safari-609.1.20.1-branch/JSTests/ChangeLog (256975 => 256976)
--- branches/safari-609.1.20.1-branch/JSTests/ChangeLog 2020-02-19 23:38:03 UTC (rev 256975)
+++ branches/safari-609.1.20.1-branch/JSTests/ChangeLog 2020-02-19 23:38:08 UTC (rev 256976)
@@ -1,3 +1,39 @@
+2020-02-19 Alan Coon
+
+Cherry-pick r256766. rdar://problem/59576813
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
+Source/_javascript_Core:
+
+When generating the call IC, we should select the callee saves using BoundsChecking mode in order
+to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
+register when calling the Wasm LLInt through the call IC.
+
+* wasm/js/WebAssemblyFunction.cpp:
+(JSC::WebAssemblyFunction::calleeSaves const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-17 Tadeu Zagallo
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
2020-02-03 Russell Epstein
Cherry-pick r255529. rdar://problem/59098310
Added: branches/safari-609.1.20.1-branch/JSTests/wasm/regress/regress-256665.js (0 => 256976)
--- branches/safari-609.1.20.1-branch/JSTests/wasm/regress/regress-256665.js (rev 0)
+++ branches/safari-609.1.20.1-branch/JSTests/wasm/regress/regress-256665.js 2020-02-19 23:38:08 UTC (rev 256976)
@@ -0,0 +1,12 @@
+//@ requireOptions("--useConcurrentJIT=false", "--jitPolicyScale=0")
+
+function f() {
+var buffer = new Uint8Array([0, 97, 115, 109, 1, 0, 0, 0, 1, 6, 1, 96, 1, 127, 1, 127, 3, 2, 1, 0, 5, 3, 1, 0, 0, 7, 8, 1, 4, 108, 111, 97, 100, 0, 0, 10, 9, 1, 7, 0, 32, 0, 40, 0, 100, 11]);
+var module = new WebAssembly.Module(buffer);
+var instance = new WebAssembly.Instance(module);
+try { instance.exports.load(0x1 - 100 - 4); } catch (e) {}
+(555)[0];
+}
+
+f();
+f();
Modified: branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog (256975 => 256976)
--- branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:38:03 UTC (rev 256975)
+++ branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:38:08 UTC (rev 256976)
@@ -1,3 +1,43 @@
+2020-02-19 Alan Coon
+
+Cherry-pick r256766. rdar://problem/59576813
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
+Source/_javascript_Core:
+
+When generating the call IC, we should select the callee saves using BoundsChecking mode in order
+to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
+register when calling the Wasm LLInt through the call IC.
+
+* wasm/js/WebAssemblyFunction.cpp:
+(JSC::WebAssemblyFunction::calleeSaves const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-17 Tadeu Zagallo
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+
[webkit-changes] [256982] branches/safari-609.1.20.1-branch/Source/JavaScriptCore
Title: [256982] branches/safari-609.1.20.1-branch/Source/_javascript_Core Revision 256982 Author repst...@apple.com Date 2020-02-19 15:38:41 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256898. rdar://problem/59576798 Unreviewed build fix. * jit/JITThunks.cpp: (JSC::JITThunks::hostFunctionStub): git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-609-branch@256898 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITThunks.cpp Diff Modified: branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog (256981 => 256982) --- branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:38:37 UTC (rev 256981) +++ branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:38:41 UTC (rev 256982) @@ -1,5 +1,23 @@ 2020-02-19 Alan Coon +Cherry-pick r256898. rdar://problem/59576798 + +Unreviewed build fix. + +* jit/JITThunks.cpp: +(JSC::JITThunks::hostFunctionStub): + +git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-609-branch@256898 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-18 Simon Fraser + +Unreviewed build fix. + +* jit/JITThunks.cpp: +(JSC::JITThunks::hostFunctionStub): + +2020-02-19 Alan Coon + Cherry-pick r256665. rdar://problem/59576809 [WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention. Modified: branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITThunks.cpp (256981 => 256982) --- branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITThunks.cpp 2020-02-19 23:38:37 UTC (rev 256981) +++ branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITThunks.cpp 2020-02-19 23:38:41 UTC (rev 256982) @@ -218,7 +218,7 @@ ASSERT(!*addResult.iterator); *addResult.iterator = Weak(nativeExecutable, this); ASSERT(*addResult.iterator); -#if ASSERT_ENABLED +#if !ASSERT_DISABLED auto iterator = m_nativeExecutableSet.find(hostFunctionKey); ASSERT(iterator != m_nativeExecutableSet.end()); ASSERT(iterator->get() == nativeExecutable); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256977] branches/safari-609.1.20.1-branch
Title: [256977] branches/safari-609.1.20.1-branch Revision 256977 Author repst...@apple.com Date 2020-02-19 15:38:15 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256779. rdar://problem/59576798 [JSC] JITThunk should be HashSet> with appropriate GC weakness handling https://bugs.webkit.org/show_bug.cgi?id=207715 Reviewed by Darin Adler. JSTests: * stress/stress-jitthunks.js: Added. (let.set newGlobal): (set catch): Source/_javascript_Core: This patch refines JITThunks GC-aware Weak hash map for NativeExecutable. Previously, we have HashMap, Weak> table. But this is not good because the first tuple's information is already in NativeExecutable. But we were using this design since Weak can be nullified because of Weak<>. If this happens, we could have invalid Entry in HashMap which does not have corresponding values. This will cause crash when rehasing requires hash code for this entry. But this HashMap is very bad in terms of memory usage. Each entry has 32 bytes, and this table gets enough large. We identified that this table is consuming much memory in Membuster. So it is worth designing carefully crafted data structure which only holds Weak by leveraging the deep interaction with our GC implementation. This patch implements new design of JITThunks, which uses HashSet> and carefully crafted HashTraits / KeyTraits to handle Weak<> well. 1. Each Weak should have finalizer, and this finalizer should remove dead Weak from HashSet. This is ensuring that all the keys in HashSet is, even if Weak<> is saying it is Dead, it still has an way to access content of NativeExecutable if the content is not a JS objects. For example, we can get function pointer from dead Weak if it is not yet finalized. Since we remove all finalized Weak<> from the table, this finalizer mechanism allows us to access function pointers etc. from Weak so long as it is held in this table. 2. Getting NativeExecutable* from JITThunks should have special protocol. When getting NativeExecutable* from JITThunks, we do the following, 1. First, we check we have an Entry in JITThunks. If it does not exist, we should insert it anyway. 1.1. If it exists, we should check whether this Weak is dead or not. It is possible that dead one is still in the table because "dead" does not mean that it is "finalized". Until finalizing happens (and it can be delayed by incremental-sweeper), Weak can be dead but still accessible. So the table is still holding dead one. If we get dead one, we should insert a new one. 1.2. If it is not dead, we return it. 2. Second, we create a new NativeExecutable and insert it. In that case, it is possible that the table already has Weak, but it is dead. In that case, we need to explicitly replace it with newly created one since old one is holding old content. If we replaced, finalizer of Weak<> will not be invoked since it immediately deallocates Weak<>. So, it does not happen that this newly inserted NativeExecutable* is removed by the finalizer registered by the old Weak<>. This change makes memory usage of JITThunks table 1/4. * heap/Weak.cpp: (JSC::weakClearSlowCase): * heap/Weak.h: (JSC::Weak::Weak): (JSC::Weak::isHashTableEmptyValue const): (JSC::Weak::unsafeImpl const): (WTF::HashTraits>::isEmptyValue): * heap/WeakInlines.h: (JSC::Weak::Weak): * jit/JITThunks.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::WeakNativeExecutableHash::hash): (JSC::JITThunks::WeakNativeExecutableHash::equal): (JSC::JITThunks::HostKeySearcher::hash): (JSC::JITThunks::HostKeySearcher::equal): (JSC::JITThunks::NativeExecutableTranslator::hash): (JSC::JITThunks::NativeExecutableTranslator::equal): (JSC::JITThunks::NativeExecutableTranslator::translate): (JSC::JITThunks::finalize): (JSC::JITThunks::hostFunctionStub): (JSC::JITThunks::clearHostFunctionStubs): Deleted. * jit/JITThunks.h: * runtime/NativeExecutable.h: * tools/JSDollarVM.cpp: (JSC::functionGCSweepAsynchronously): (JSC::functionCreateEmptyFunctionWithName): (JSC::JSDollarVM::finishCreation): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256779 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.1-branch/JSTests/ChangeLog branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.1-branch/Source/_javascript_Core/heap/Weak.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/heap/Weak.h branches/safari-609.1.20.1-branch/Source/_javascript_Core/heap/WeakInlines.h branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITThunks.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/jit/JITThunks.h
[webkit-changes] [256980] branches/safari-609.1.20.1-branch
Title: [256980] branches/safari-609.1.20.1-branch Revision 256980 Author repst...@apple.com Date 2020-02-19 15:38:32 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256665. rdar://problem/59576809 [WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention. https://bugs.webkit.org/show_bug.cgi?id=207727 JSTests: Reviewed by Mark Lam. * wasm/regress/llint-callee-saves-with-fast-memory.js: Added. * wasm/regress/llint-callee-saves-without-fast-memory.js: Added. Source/_javascript_Core: Reviewed by Mark Lam. The Wasm JIT has unusual calling conventions, which were further complicated by the addition of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly saving and restoring the callee save registers used for the memory base and size). Here's a summary of the calling convention: - When entering Wasm from JS, the wrapper must: - Preserve the base and size when entering LLInt regardless of the mode. (Prior to this patch we only preserved the base in Signaling mode) - Preserve the memory base in either mode, and the size for BoundsChecking. - Both tiers must preserve every *other* register they use. e.g. the LLInt must preserve PB and wasmInstance, but must *not* preserve memoryBase and memorySize. - Changes to memoryBase and memorySize are visible to the caller. This means that: - Intra-module calls can assume these registers are up-to-date even if the memory was resized. The only exception here is if the LLInt calls a signaling JIT, in which case the JIT will not update the size register, since it won't be using it. - Inter-module and JS calls require the caller to reload these registers. These calls may result in memory changes (e.g. the callee may call memory.grow). - A Signaling JIT caller must be aware that the LLInt may trash the size register, since it always bounds checks. * llint/WebAssembly.asm: * wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::addCall): * wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addCall): * wasm/WasmCallee.cpp: (JSC::Wasm::LLIntCallee::calleeSaveRegisters): * wasm/WasmCallingConvention.h: * wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation): * wasm/WasmMemoryInformation.cpp: (JSC::Wasm::PinnedRegisterInfo::get): (JSC::Wasm::getPinnedRegisters): Deleted. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256665 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.1-branch/JSTests/ChangeLog branches/safari-609.1.20.1-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.1-branch/Source/_javascript_Core/llint/WebAssembly.asm branches/safari-609.1.20.1-branch/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/wasm/WasmCallee.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/wasm/WasmCallingConvention.h branches/safari-609.1.20.1-branch/Source/_javascript_Core/wasm/WasmLLIntPlan.cpp branches/safari-609.1.20.1-branch/Source/_javascript_Core/wasm/WasmMemoryInformation.cpp Added Paths branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js branches/safari-609.1.20.1-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js Diff Modified: branches/safari-609.1.20.1-branch/JSTests/ChangeLog (256979 => 256980) --- branches/safari-609.1.20.1-branch/JSTests/ChangeLog 2020-02-19 23:38:25 UTC (rev 256979) +++ branches/safari-609.1.20.1-branch/JSTests/ChangeLog 2020-02-19 23:38:32 UTC (rev 256980) @@ -1,5 +1,70 @@ 2020-02-19 Alan Coon +Cherry-pick r256665. rdar://problem/59576809 + +[WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention. +https://bugs.webkit.org/show_bug.cgi?id=207727 + +JSTests: + +Reviewed by Mark Lam. + +* wasm/regress/llint-callee-saves-with-fast-memory.js: Added. +* wasm/regress/llint-callee-saves-without-fast-memory.js: Added. + +Source/_javascript_Core: + +Reviewed by Mark Lam. + +The Wasm JIT has unusual calling conventions, which were further complicated by the addition +of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly +saving and restoring the callee save registers used for the memory base and size). Here's a summary +of the calling convention: + +- When entering Wasm from JS, the wrapper must: +- Preserve the base and size when entering LLInt regardless of the mode. (Prior to this + patch we only preserved the base in Signaling mode) +- Preserve the memory base in either mode, and the size
[webkit-changes] [256975] branches/safari-609.1.20.1-branch
Title: [256975] branches/safari-609.1.20.1-branch Revision 256975 Author repst...@apple.com Date 2020-02-19 15:38:03 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256632. rdar://problem/59576783 NetworkLoadMetrics should be shared by multiple ResourceResponse instances https://bugs.webkit.org/show_bug.cgi?id=207747 Reviewed by Keith Miller. Source/WebCore: ResourceResponse is value data, and it is copied multiple times in various places, (1) to create a new ResourceResponse which has slightly different fields, or (1) to hold ResourceResponse even after loading finishes. For example, DocumentLoader has Vector to replay response dispatching in the case of loading from BackForwardCache. The problem is that ResourceResponse is very large: 440 bytes. While we sometimes copy ResourceResponse to modify some part of it, NetworkLoadMetrics is immutable. It is set when response is created, and is never changed. And NetworkLoadMetrics is large: sizeof(NetworkLoadMetrics) is 184 bytes. Given that we have multiple copies of ResourceResponse in WebCore, we should share NetworkLoadMetrics by them. This patch puts Box in ResourceResponse to share it with all copied ResourceResponses. We do not make NetworkLoadMetrics RefCounted<> for now since some legit data structures embed NetworkLoadMetrics. This patch adds ArgumentCoder for Box so that we can encode / decode Box in ResourceResponse in IPC. To ensure NetworkLoadMetrics in ResourceResponse immutable, we add ResourceResponse::setDeprecatedNetworkLoadMetrics instead of modifying NetworkLoadMetrics already created in ResourceResponse. We also attempt to compact ResourceResponse more by using bit-fields. And removing m_isValid field in ParsedContentRange since this can be represented by the different field. These changes make sizeof(ResourceResponse) from 440 to 248. No behavior change. * inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::buildObjectForTiming): (WebCore::InspectorNetworkAgent::buildObjectForResourceResponse): * inspector/agents/InspectorNetworkAgent.h: * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading): * page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::domainLookupStart const): (WebCore::PerformanceTiming::domainLookupEnd const): (WebCore::PerformanceTiming::connectStart const): (WebCore::PerformanceTiming::connectEnd const): (WebCore::PerformanceTiming::secureConnectionStart const): (WebCore::PerformanceTiming::requestStart const): (WebCore::PerformanceTiming::responseStart const): * platform/network/NetworkLoadMetrics.h: * platform/network/ParsedContentRange.cpp: (WebCore::areContentRangeValuesValid): (WebCore::parseContentRange): (WebCore::ParsedContentRange::ParsedContentRange): (WebCore::ParsedContentRange::headerValue const): * platform/network/ParsedContentRange.h: (WebCore::ParsedContentRange::isValid const): (WebCore::ParsedContentRange::invalidValue): (WebCore::ParsedContentRange::MarkableTraits::isEmptyValue): (WebCore::ParsedContentRange::MarkableTraits::emptyValue): (WebCore::ParsedContentRange::ParsedContentRange): Deleted. * platform/network/ResourceHandle.h: * platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::crossThreadData const): (WebCore::ResourceResponseBase::fromCrossThreadData): (WebCore::ResourceResponseBase::compare): * platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::deprecatedNetworkLoadMetricsOrNull const): (WebCore::ResourceResponseBase::setDeprecatedNetworkLoadMetrics): (WebCore::ResourceResponseBase::encode const): (WebCore::ResourceResponseBase::decode): (WebCore::ResourceResponseBase::deprecatedNetworkLoadMetrics const): Deleted. * platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): * platform/network/cocoa/NetworkLoadMetrics.mm: (WebCore::copyTimingData): * platform/network/curl/CurlResourceHandleDelegate.cpp: (WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse): * platform/network/curl/ResourceResponse.h: * platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::setDeprecatedNetworkLoadMetrics): Deleted. * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::getConnectionTimingData): * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]): Source/WebKit: Add ArgumentCoder support for Box. * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate
[webkit-changes] [256972] branches/safari-609.1.20.1-branch/Source/WebKit
Title: [256972] branches/safari-609.1.20.1-branch/Source/WebKit
Revision 256972
Author repst...@apple.com
Date 2020-02-19 15:37:38 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256426. rdar://problem/59576790
[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
https://bugs.webkit.org/show_bug.cgi?id=207509
Reviewed by Chris Dumez.
Covered by existing tests.
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::writeSizeFile):
Make sure completion handler is always called on the main thread.
Minor refactoring to make things more efficient.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog
branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
Diff
Modified: branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog (256971 => 256972)
--- branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog 2020-02-19 23:37:33 UTC (rev 256971)
+++ branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog 2020-02-19 23:37:38 UTC (rev 256972)
@@ -1,5 +1,40 @@
2020-02-19 Alan Coon
+Cherry-pick r256426. rdar://problem/59576790
+
+[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
+https://bugs.webkit.org/show_bug.cgi?id=207509
+
+
+Reviewed by Chris Dumez.
+
+Covered by existing tests.
+
+* NetworkProcess/cache/CacheStorageEngine.cpp:
+(WebKit::CacheStorage::Engine::writeSizeFile):
+Make sure completion handler is always called on the main thread.
+Minor refactoring to make things more efficient.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-11 Youenn Fablet
+
+[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
+https://bugs.webkit.org/show_bug.cgi?id=207509
+
+
+Reviewed by Chris Dumez.
+
+Covered by existing tests.
+
+* NetworkProcess/cache/CacheStorageEngine.cpp:
+(WebKit::CacheStorage::Engine::writeSizeFile):
+Make sure completion handler is always called on the main thread.
+Minor refactoring to make things more efficient.
+
+2020-02-19 Alan Coon
+
Cherry-pick r256314. rdar://problem/59576791
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
Modified: branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (256971 => 256972)
--- branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2020-02-19 23:37:33 UTC (rev 256971)
+++ branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2020-02-19 23:37:38 UTC (rev 256972)
@@ -530,23 +530,25 @@
void Engine::writeSizeFile(const String& path, uint64_t size, CompletionHandler&& completionHandler)
{
-CompletionHandlerCallingScope completionHandlerCaller(WTFMove(completionHandler));
+ASSERT(RunLoop::isMain());
+
if (!shouldPersist())
-return;
+return completionHandler();
-m_ioQueue->dispatch([path = path.isolatedCopy(), size, completionHandlerCaller = WTFMove(completionHandlerCaller)]() mutable {
+m_ioQueue->dispatch([path = path.isolatedCopy(), size, completionHandler = WTFMove(completionHandler)]() mutable {
LockHolder locker(globalSizeFileLock);
auto fileHandle = FileSystem::openFile(path, FileSystem::FileOpenMode::Write);
-auto closeFileHandler = makeScopeExit([&] {
+
+if (FileSystem::isHandleValid(fileHandle)) {
+FileSystem::truncateFile(fileHandle, 0);
+
+auto value = String::number(size).utf8();
+FileSystem::writeToFile(fileHandle, value.data(), value.length());
+
FileSystem::closeFile(fileHandle);
-});
-if (!FileSystem::isHandleValid(fileHandle))
-return;
+}
-FileSystem::truncateFile(fileHandle, 0);
-FileSystem::writeToFile(fileHandle, String::number(size).utf8().data(), String::number(size).utf8().length());
-
-RunLoop::main().dispatch([completionHandlerCaller = WTFMove(completionHandlerCaller)]() mutable { });
+RunLoop::main().dispatch(WTFMove(completionHandler));
});
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256970] branches/safari-609.1.20.1-branch
Title: [256970] branches/safari-609.1.20.1-branch
Revision 256970
Author repst...@apple.com
Date 2020-02-19 15:37:28 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256314. rdar://problem/59576791
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
https://bugs.webkit.org/show_bug.cgi?id=207537
Reviewed by Chris Dumez.
Source/WebKit:
Covered by added API test.
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog
branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
branches/safari-609.1.20.1-branch/Tools/ChangeLog
branches/safari-609.1.20.1-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
Diff
Modified: branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog (256969 => 256970)
--- branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog 2020-02-19 23:37:22 UTC (rev 256969)
+++ branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog 2020-02-19 23:37:28 UTC (rev 256970)
@@ -1,5 +1,42 @@
2020-02-19 Alan Coon
+Cherry-pick r256314. rdar://problem/59576791
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Source/WebKit:
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
+Tools:
+
+* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-11 Youenn Fablet
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
+2020-02-19 Alan Coon
+
Cherry-pick r256191. rdar://problem/59576820
Disallow setting base URL to a data or _javascript_ URL
Modified: branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256969 => 256970)
--- branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:37:22 UTC (rev 256969)
+++ branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:37:28 UTC (rev 256970)
@@ -319,6 +319,7 @@
bool isNewOrigin = WTF::allOf(m_clientOrigins.values(), [](auto& origin) {
return contextOrigin != origin.clientOrigin;
});
+auto* contextConnection = isNewOrigin ? server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin }) : nullptr;
auto clientOrigin = ClientOrigin { WTFMove(topOrigin), WTFMove(contextOrigin) };
m_clientOrigins.add(data.identifier, clientOrigin);
@@ -327,11 +328,9 @@
if (!m_isThrottleable)
updateThrottleState();
-if (isNewOrigin) {
-if (auto* contextConnection = server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin })) {
-auto& connection = static_cast(*contextConnection);
-m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
-}
+if (contextConnection) {
+auto& connection = static_cast(*contextConnection);
+m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
}
}
Modified: branches/safari-609.1.20.1-branch/Tools/ChangeLog (256969 => 256970)
--- branches/safari-609.1.20.1-branch/Tools/ChangeLog 2020-02-19 23:37:22 UTC (rev 256969)
+++ branches/safari-609.1.20.1-branch/Tools/ChangeLog 2020-02-19 23:37:28 UTC (rev 256970)
@@ -1,3 +1,36 @@
+2020-02-19 Alan Coon
+
+
[webkit-changes] [256978] branches/safari-609.1.20.1-branch
Title: [256978] branches/safari-609.1.20.1-branch
Revision 256978
Author repst...@apple.com
Date 2020-02-19 15:38:20 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256383. rdar://problem/59576791
Unreviewed, rolling out r256314.
https://bugs.webkit.org/show_bug.cgi?id=207594
It is breaking an API test (Requested by youenn on #webkit).
Reverted changeset:
"WebSWServerConnection::registerServiceWorkerClient is not
sending IPC message to UIProcess when it should"
https://bugs.webkit.org/show_bug.cgi?id=207537
https://trac.webkit.org/changeset/256314
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog
branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
branches/safari-609.1.20.1-branch/Tools/ChangeLog
branches/safari-609.1.20.1-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
Diff
Modified: branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog (256977 => 256978)
--- branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog 2020-02-19 23:38:15 UTC (rev 256977)
+++ branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog 2020-02-19 23:38:20 UTC (rev 256978)
@@ -1,5 +1,37 @@
2020-02-19 Alan Coon
+Cherry-pick r256383. rdar://problem/59576791
+
+Unreviewed, rolling out r256314.
+https://bugs.webkit.org/show_bug.cgi?id=207594
+
+It is breaking an API test (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"WebSWServerConnection::registerServiceWorkerClient is not
+sending IPC message to UIProcess when it should"
+https://bugs.webkit.org/show_bug.cgi?id=207537
+https://trac.webkit.org/changeset/256314
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-11 Commit Queue
+
+Unreviewed, rolling out r256314.
+https://bugs.webkit.org/show_bug.cgi?id=207594
+
+It is breaking an API test (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"WebSWServerConnection::registerServiceWorkerClient is not
+sending IPC message to UIProcess when it should"
+https://bugs.webkit.org/show_bug.cgi?id=207537
+https://trac.webkit.org/changeset/256314
+
+2020-02-19 Alan Coon
+
Cherry-pick r256632. rdar://problem/59576783
NetworkLoadMetrics should be shared by multiple ResourceResponse instances
Modified: branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256977 => 256978)
--- branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:38:15 UTC (rev 256977)
+++ branches/safari-609.1.20.1-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:38:20 UTC (rev 256978)
@@ -319,7 +319,6 @@
bool isNewOrigin = WTF::allOf(m_clientOrigins.values(), [](auto& origin) {
return contextOrigin != origin.clientOrigin;
});
-auto* contextConnection = isNewOrigin ? server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin }) : nullptr;
auto clientOrigin = ClientOrigin { WTFMove(topOrigin), WTFMove(contextOrigin) };
m_clientOrigins.add(data.identifier, clientOrigin);
@@ -328,9 +327,11 @@
if (!m_isThrottleable)
updateThrottleState();
-if (contextConnection) {
-auto& connection = static_cast(*contextConnection);
-m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
+if (isNewOrigin) {
+if (auto* contextConnection = server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin })) {
+auto& connection = static_cast(*contextConnection);
+m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
+}
}
}
Modified: branches/safari-609.1.20.1-branch/Tools/ChangeLog (256977 => 256978)
--- branches/safari-609.1.20.1-branch/Tools/ChangeLog 2020-02-19 23:38:15 UTC (rev 256977)
+++ branches/safari-609.1.20.1-branch/Tools/ChangeLog 2020-02-19 23:38:20 UTC (rev 256978)
@@ -1,5 +1,37 @@
2020-02-19 Alan Coon
+Cherry-pick r256383. rdar://problem/59576791
+
+Unreviewed, rolling out r256314.
+https://bugs.webkit.org/show_bug.cgi?id=207594
+
+It is breaking an API test (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"WebSWServerConnection::registerServiceWorkerClient is not
+sending IPC message to UIProcess when it should"
+
[webkit-changes] [256974] branches/safari-609.1.20.1-branch/Source/WebCore
Title: [256974] branches/safari-609.1.20.1-branch/Source/WebCore Revision 256974 Author repst...@apple.com Date 2020-02-19 15:37:52 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256610. rdar://problem/59576806 [Web Animations] Make all animation event types inherit from the same base class https://bugs.webkit.org/show_bug.cgi?id=207629 Reviewed by Simon Fraser. Currently we dispatch events CSS Transitions and CSS Animations events using a dedicated event queue on DeclarativeAnimation, while the events added by the Web Animations specification (of type AnimationPlaybackEvent) are dispatched using a shared queue on the DocumentTimeline that is processed during the "update animations and send events procedure". The Web Animations specification dictates that all events should be dispatched during that procedure, which includes sorting of such events based on their timeline time and associated animation relative composite order. In this patch, we prepare the work towards spec compliance for animation events dispatch by making all event types (AnimationPlaybackEvent, TransitionEvent and AnimationEvent) inherit from a single AnimationEventBase interface. This will allow DocumentTimeline to enqueue, sort and dispatch all such events with a single queue in a future patch. Due to CSSAnimationController, we must make the "timeline time" and "animation" parameters optional. When we drop support for CSSAnimationController we'll be able to enforce stronger requirements for these. No new test since this should not introduce any behavior change. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * animation/AnimationEventBase.cpp: Added. (WebCore::AnimationEventBase::AnimationEventBase): * animation/AnimationEventBase.h: Added. (WebCore::AnimationEventBase::create): (WebCore::AnimationEventBase::isAnimationPlaybackEvent const): (WebCore::AnimationEventBase::isAnimationEvent const): (WebCore::AnimationEventBase::isTransitionEvent const): (WebCore::AnimationEventBase::timelineTime const): (WebCore::AnimationEventBase::animation const): * animation/AnimationPlaybackEvent.cpp: (WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent): (WebCore::AnimationPlaybackEvent::bindingsTimelineTime const): * animation/AnimationPlaybackEvent.h: * animation/CSSAnimation.cpp: (WebCore::CSSAnimation::createEvent): * animation/CSSAnimation.h: * animation/CSSTransition.cpp: (WebCore::CSSTransition::createEvent): * animation/CSSTransition.h: * animation/DeclarativeAnimation.cpp: (WebCore::DeclarativeAnimation::enqueueDOMEvent): * animation/DeclarativeAnimation.h: * animation/WebAnimation.cpp: (WebCore::WebAnimation::enqueueAnimationPlaybackEvent): * dom/AnimationEvent.cpp: (WebCore::AnimationEvent::AnimationEvent): * dom/AnimationEvent.h: * dom/TransitionEvent.cpp: (WebCore::TransitionEvent::TransitionEvent): * dom/TransitionEvent.h: * page/animation/CSSAnimationController.cpp: (WebCore::CSSAnimationControllerPrivate::fireEventsAndUpdateStyle): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256610 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.1-branch/Source/WebCore/Sources.txt branches/safari-609.1.20.1-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj branches/safari-609.1.20.1-branch/Source/WebCore/animation/AnimationPlaybackEvent.cpp branches/safari-609.1.20.1-branch/Source/WebCore/animation/AnimationPlaybackEvent.h branches/safari-609.1.20.1-branch/Source/WebCore/animation/CSSAnimation.cpp branches/safari-609.1.20.1-branch/Source/WebCore/animation/CSSAnimation.h branches/safari-609.1.20.1-branch/Source/WebCore/animation/CSSTransition.cpp branches/safari-609.1.20.1-branch/Source/WebCore/animation/CSSTransition.h branches/safari-609.1.20.1-branch/Source/WebCore/animation/DeclarativeAnimation.cpp branches/safari-609.1.20.1-branch/Source/WebCore/animation/DeclarativeAnimation.h branches/safari-609.1.20.1-branch/Source/WebCore/animation/WebAnimation.cpp branches/safari-609.1.20.1-branch/Source/WebCore/dom/AnimationEvent.cpp branches/safari-609.1.20.1-branch/Source/WebCore/dom/AnimationEvent.h branches/safari-609.1.20.1-branch/Source/WebCore/dom/TransitionEvent.cpp branches/safari-609.1.20.1-branch/Source/WebCore/dom/TransitionEvent.h branches/safari-609.1.20.1-branch/Source/WebCore/page/animation/CSSAnimationController.cpp Added Paths branches/safari-609.1.20.1-branch/Source/WebCore/animation/AnimationEventBase.cpp branches/safari-609.1.20.1-branch/Source/WebCore/animation/AnimationEventBase.h Diff Modified: branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog (256973 => 256974) --- branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog 2020-02-19 23:37:44 UTC (rev 256973) +++
[webkit-changes] [256983] branches/safari-609.1.20.1-branch/Source
Title: [256983] branches/safari-609.1.20.1-branch/Source Revision 256983 Author repst...@apple.com Date 2020-02-19 15:38:48 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r255881. rdar://problem/59576819 Adopt MTOverrideShouldPlayHDRVideo() https://bugs.webkit.org/show_bug.cgi?id=207275 Reviewed by Eric Carlson. Source/WebCore: * platform/PlatformScreen.h: * platform/mac/PlatformScreenMac.mm: (WebCore::setShouldOverrideScreenSupportsHighDynamicRange): Source/WebCore/PAL: * pal/cocoa/MediaToolboxSoftLink.cpp: * pal/cocoa/MediaToolboxSoftLink.h: Source/WebKit: The WebProcess sandbox can block access to the services necessary for MediaToolbox to determine whether the current display is capable of displaying HDR. Rather than opening up the sandbox, provide the information gathered by the UIProcess by way of MTOverrideShouldPlayHDRVideo(). * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::windowScreenDidChange): (WebKit::WebPage::displayID const): * WebProcess/WebPage/WebPage.h: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::setScreenProperties): Deleted. * WebProcess/WebProcess.h: * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::setScreenProperties): (WebKit::WebProcess::updatePageScreenProperties): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255881 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.1-branch/Source/WebCore/PAL/ChangeLog branches/safari-609.1.20.1-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.cpp branches/safari-609.1.20.1-branch/Source/WebCore/PAL/pal/cocoa/MediaToolboxSoftLink.h branches/safari-609.1.20.1-branch/Source/WebCore/platform/PlatformScreen.h branches/safari-609.1.20.1-branch/Source/WebCore/platform/mac/PlatformScreenMac.mm branches/safari-609.1.20.1-branch/Source/WebKit/ChangeLog branches/safari-609.1.20.1-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp branches/safari-609.1.20.1-branch/Source/WebKit/WebProcess/WebProcess.cpp branches/safari-609.1.20.1-branch/Source/WebKit/WebProcess/WebProcess.h branches/safari-609.1.20.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Diff Modified: branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog (256982 => 256983) --- branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog 2020-02-19 23:38:41 UTC (rev 256982) +++ branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog 2020-02-19 23:38:48 UTC (rev 256983) @@ -1,5 +1,57 @@ 2020-02-19 Alan Coon +Cherry-pick r255881. rdar://problem/59576819 + +Adopt MTOverrideShouldPlayHDRVideo() +https://bugs.webkit.org/show_bug.cgi?id=207275 + + +Reviewed by Eric Carlson. + +Source/WebCore: + +* platform/PlatformScreen.h: +* platform/mac/PlatformScreenMac.mm: +(WebCore::setShouldOverrideScreenSupportsHighDynamicRange): + +Source/WebCore/PAL: + +* pal/cocoa/MediaToolboxSoftLink.cpp: +* pal/cocoa/MediaToolboxSoftLink.h: + +Source/WebKit: + +The WebProcess sandbox can block access to the services necessary for MediaToolbox to determine whether +the current display is capable of displaying HDR. Rather than opening up the sandbox, provide the information +gathered by the UIProcess by way of MTOverrideShouldPlayHDRVideo(). + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::windowScreenDidChange): +(WebKit::WebPage::displayID const): +* WebProcess/WebPage/WebPage.h: +* WebProcess/WebProcess.cpp: +(WebKit::WebProcess::setScreenProperties): Deleted. +* WebProcess/WebProcess.h: +* WebProcess/cocoa/WebProcessCocoa.mm: +(WebKit::WebProcess::setScreenProperties): +(WebKit::WebProcess::updatePageScreenProperties): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255881 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-05 Jer Noble + +Adopt MTOverrideShouldPlayHDRVideo() +https://bugs.webkit.org/show_bug.cgi?id=207275 + + +Reviewed by Eric Carlson. + +* platform/PlatformScreen.h: +* platform/mac/PlatformScreenMac.mm: +(WebCore::setShouldOverrideScreenSupportsHighDynamicRange): + +2020-02-19 Alan Coon + Cherry-pick r256632. rdar://problem/59576783 NetworkLoadMetrics should be shared by multiple ResourceResponse instances Modified: branches/safari-609.1.20.1-branch/Source/WebCore/PAL/ChangeLog (256982 => 256983) --- branches/safari-609.1.20.1-branch/Source/WebCore/PAL/ChangeLog 2020-02-19 23:38:41 UTC (rev 256982) +++ branches/safari-609.1.20.1-branch/Source/WebCore/PAL/ChangeLog 2020-02-19 23:38:48 UTC (rev 256983) @@ -1,3 +1,54 @@ +2020-02-19 Alan Coon + +Cherry-pick r255881. rdar://problem/59576819 + +Adopt MTOverrideShouldPlayHDRVideo() +
[webkit-changes] [256971] branches/safari-609.1.20.1-branch/Source/WebCore
Title: [256971] branches/safari-609.1.20.1-branch/Source/WebCore
Revision 256971
Author repst...@apple.com
Date 2020-02-19 15:37:33 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256400. rdar://problem/59576794
Unreviewed, partial rollout of r255037.
* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm
branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm
Diff
Modified: branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog (256970 => 256971)
--- branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog 2020-02-19 23:37:28 UTC (rev 256970)
+++ branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog 2020-02-19 23:37:33 UTC (rev 256971)
@@ -1,5 +1,29 @@
2020-02-19 Alan Coon
+Cherry-pick r256400. rdar://problem/59576794
+
+Unreviewed, partial rollout of r255037.
+
+
+* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
+(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
+* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
+(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-11 Ryan Haddad
+
+Unreviewed, partial rollout of r255037.
+
+
+* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
+(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
+* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
+(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
+
+2020-02-19 Alan Coon
+
Cherry-pick r256191. rdar://problem/59576820
Disallow setting base URL to a data or _javascript_ URL
Modified: branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm (256970 => 256971)
--- branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm 2020-02-19 23:37:28 UTC (rev 256970)
+++ branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm 2020-02-19 23:37:33 UTC (rev 256971)
@@ -77,7 +77,7 @@
if (is(*ancestor)) {
// Fixed nodes are positioned relative to the containing frame scrolling node.
// We bail out after finding one.
-auto layoutViewport = downcast(*ancestor).layoutViewportRespectingRubberBanding();
+auto layoutViewport = downcast(*ancestor).layoutViewport();
return m_constraints.layerPositionForViewportRect(layoutViewport) - overflowScrollDelta;
}
Modified: branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm (256970 => 256971)
--- branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm 2020-02-19 23:37:28 UTC (rev 256970)
+++ branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm 2020-02-19 23:37:33 UTC (rev 256971)
@@ -73,7 +73,7 @@
FloatRect constrainingRect;
if (is(scrollingNode)) {
auto& frameScrollingNode = downcast(scrollingNode);
-constrainingRect = frameScrollingNode.layoutViewportRespectingRubberBanding();
+constrainingRect = frameScrollingNode.layoutViewport();
} else {
auto& overflowScrollingNode = downcast(scrollingNode);
constrainingRect = FloatRect(overflowScrollingNode.currentScrollPosition(), m_constraints.constrainingRectAtLastLayout().size());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256968] branches/safari-609.1.20.1-branch
Title: [256968] branches/safari-609.1.20.1-branch
Revision 256968
Author repst...@apple.com
Date 2020-02-19 15:37:05 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r255037. rdar://problem/59576794
Fixed elements no longer stay fixed with elastic overscroll
https://bugs.webkit.org/show_bug.cgi?id=206227
rdar://problem/58707084
Reviewed by Antti Koivisto.
Source/WebCore:
Intended behavior on iOS and macOS is for position:fixed and sticky elements to maintain
their position relative to the view bounds when rubber-banding ("overscrolling"). This broke
some time back. This change restores the correct behavior with the call to layoutViewportRespectingRubberBanding()
in ScrollingTreeFixedNode::applyLayerPositions() and ScrollingTreeStickyNode::computeLayerPosition().
layoutViewportRespectingRubberBanding() computes a layout viewport without clamping.
The rest of the changes are to support testing. internals.unconstrainedScrollTo()
didn't work for main frame scrolling because of scroll position clamping in various places,
so propagate ScrollClamping in more places (and replace the redundant ScrollPositionClamp with ScrollClamping).
"requested scroll position" updates now carry along both clamping and "is programmatic" data, wrapped in a struct
which is passed around the scrolling tree. This allows us to not clamp the scroll position (for testing) in more places.
Internals::unconstrainedScrollTo() needs one weird hack to trigger a layout (and thus a scrolling tree commit),
because the layout is normally triggered by a layout viewport change, but when rubber-banding we clamp the layoutViewport
used for layout, so those layouts are never triggered.
Tests: tiled-drawing/scrolling/fixed/fixed-during-rubberband.html
tiled-drawing/scrolling/sticky/sticky-during-rubberband.html
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.cpp:
(WebCore::Element::scrollTo):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollTo const):
* page/FrameView.cpp:
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::requestScrollPositionUpdate):
* page/FrameView.h:
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ScrollingCoordinator.cpp:
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollData):
(WebCore::ScrollingStateScrollingNode::dumpProperties const):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition): Deleted.
* page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::RequestedScrollData::operator== const):
(WebCore::ScrollingStateScrollingNode::requestedScrollData const):
(WebCore::ScrollingStateScrollingNode::requestedScrollPosition const): Deleted.
(WebCore::ScrollingStateScrollingNode::requestedScrollPositionRepresentsProgrammaticScroll const): Deleted.
* page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::scrollingTreeNodeRequestsScroll):
* page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
(WebCore::ScrollingTreeFrameScrollingNode::layoutViewportForScrollPosition const):
(WebCore::ScrollingTreeFrameScrollingNode::layoutViewportRespectingRubberBanding const):
* page/scrolling/ScrollingTreeFrameScrollingNode.h:
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren):
(WebCore::ScrollingTreeScrollingNode::adjustedScrollPosition const):
(WebCore::ScrollingTreeScrollingNode::scrollBy):
(WebCore::ScrollingTreeScrollingNode::scrollTo):
(WebCore::ScrollingTreeScrollingNode::wasScrolledByDelegatedScrolling):
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::adjustedScrollPosition const):
* page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
* page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:
(WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateAfterChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::adjustedScrollPosition const):
* page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
[webkit-changes] [256973] branches/safari-609.1.20.1-branch
Title: [256973] branches/safari-609.1.20.1-branch Revision 256973 Author repst...@apple.com Date 2020-02-19 15:37:44 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256513. rdar://problem/59576794 REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side https://bugs.webkit.org/show_bug.cgi?id=207674 rdar://problem/59404866 Reviewed by Antti Koivisto. Source/WebCore: Remove the early return in ScrollingStateScrollingNode::setRequestedScrollData(); comparing with the last m_requestedScrollData is wrong, because requested scroll positions are not "state" in the scrolling tree, they are requests to scroll. Ideally, they would be represented in some different way in the scrolling tree. Test: fast/scrolling/programmatic-scroll-to-zero-zero.html * page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::setRequestedScrollData): LayoutTests: Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0, which is expected to work. * fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added. * fast/scrolling/programmatic-scroll-to-zero-zero.html: Added. * platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256513 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.1-branch/LayoutTests/ChangeLog branches/safari-609.1.20.1-branch/LayoutTests/platform/ios/TestExpectations branches/safari-609.1.20.1-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.1-branch/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp Added Paths branches/safari-609.1.20.1-branch/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html branches/safari-609.1.20.1-branch/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero.html Diff Modified: branches/safari-609.1.20.1-branch/LayoutTests/ChangeLog (256972 => 256973) --- branches/safari-609.1.20.1-branch/LayoutTests/ChangeLog 2020-02-19 23:37:38 UTC (rev 256972) +++ branches/safari-609.1.20.1-branch/LayoutTests/ChangeLog 2020-02-19 23:37:44 UTC (rev 256973) @@ -1,5 +1,54 @@ 2020-02-19 Alan Coon +Cherry-pick r256513. rdar://problem/59576794 + +REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side +https://bugs.webkit.org/show_bug.cgi?id=207674 +rdar://problem/59404866 + +Reviewed by Antti Koivisto. + +Source/WebCore: + +Remove the early return in ScrollingStateScrollingNode::setRequestedScrollData(); comparing +with the last m_requestedScrollData is wrong, because requested scroll positions are not "state" +in the scrolling tree, they are requests to scroll. Ideally, they would be represented in some +different way in the scrolling tree. + +Test: fast/scrolling/programmatic-scroll-to-zero-zero.html + +* page/scrolling/ScrollingStateScrollingNode.cpp: +(WebCore::ScrollingStateScrollingNode::setRequestedScrollData): + +LayoutTests: + +Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0, +which is expected to work. + +* fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added. +* fast/scrolling/programmatic-scroll-to-zero-zero.html: Added. +* platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256513 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-13 Simon Fraser + +REGRESSION (r255037): Zooming in and out on Quip in macOS Safari can cause the content to be offset to the side +https://bugs.webkit.org/show_bug.cgi?id=207674 +rdar://problem/59404866 + +Reviewed by Antti Koivisto. + +Test that does a programmatic scroll to 0,0, does a user scroll, then a second programmatic scroll to 0,0, +which is expected to work. + +* fast/scrolling/programmatic-scroll-to-zero-zero-expected.html: Added. +* fast/scrolling/programmatic-scroll-to-zero-zero.html: Added. +* platform/ios/TestExpectations: Skip the new test on iOS (it relies on eventSender) and sort the grouping. + +2020-02-19 Alan Coon + Cherry-pick r256191. rdar://problem/59576820 Disallow setting base URL to a data or _javascript_ URL Added: branches/safari-609.1.20.1-branch/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html (0 => 256973) --- branches/safari-609.1.20.1-branch/LayoutTests/fast/scrolling/programmatic-scroll-to-zero-zero-expected.html (rev 0) +++
[webkit-changes] [256967] trunk/Source/WebKit
Title: [256967] trunk/Source/WebKit Revision 256967 Author cdu...@apple.com Date 2020-02-19 15:33:56 -0800 (Wed, 19 Feb 2020) Log Message Regression(r247567) HTTP Disk cache capacity is no longer set https://bugs.webkit.org/show_bug.cgi?id=207959 Reviewed by Alex Christensen. NetworkProcess::initializeNetworkProcess() was setting the cache model, which would iterate over all network sessions to update their network cache capacity. The issue was that network sessions were not constructed yet at this point. When the network session(s) would get created later on, they would construct their NetworkCache and it would use the default capacity (i.e. std::numeric_limits::max()). To make this safer, I have moved the capacity computation to the Cache::open() method and now pass the capacity when constructing the network cache storage. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeNetworkProcess): (WebKit::NetworkProcess::setCacheModelSynchronouslyForTesting): (WebKit::NetworkProcess::setCacheModel): * NetworkProcess/NetworkProcess.h: (WebKit::NetworkProcess::cacheModel const): * NetworkProcess/NetworkProcess.messages.in: * NetworkProcess/cache/CacheStorageEngineCaches.cpp: (WebKit::CacheStorage::Caches::initialize): * NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::computeCapacity): (WebKit::NetworkCache::Cache::open): (WebKit::NetworkCache::Cache::capacity const): (WebKit::NetworkCache::Cache::updateCapacity): (WebKit::NetworkCache::Cache::setCapacity): Deleted. * NetworkProcess/cache/NetworkCache.h: * NetworkProcess/cache/NetworkCacheStorage.cpp: (WebKit::NetworkCache::Storage::open): (WebKit::NetworkCache::Storage::Storage): (WebKit::NetworkCache::Storage::setCapacity): * NetworkProcess/cache/NetworkCacheStorage.h: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::setCacheModel): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcess.h trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h trunk/Source/WebKit/UIProcess/WebProcessPool.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (256966 => 256967) --- trunk/Source/WebKit/ChangeLog 2020-02-19 23:24:57 UTC (rev 256966) +++ trunk/Source/WebKit/ChangeLog 2020-02-19 23:33:56 UTC (rev 256967) @@ -1,3 +1,45 @@ +2020-02-19 Chris Dumez + +Regression(r247567) HTTP Disk cache capacity is no longer set +https://bugs.webkit.org/show_bug.cgi?id=207959 + + +Reviewed by Alex Christensen. + +NetworkProcess::initializeNetworkProcess() was setting the cache model, which +would iterate over all network sessions to update their network cache capacity. +The issue was that network sessions were not constructed yet at this point. +When the network session(s) would get created later on, they would construct +their NetworkCache and it would use the default capacity (i.e. +std::numeric_limits::max()). + +To make this safer, I have moved the capacity computation to the Cache::open() +method and now pass the capacity when constructing the network cache storage. + +* NetworkProcess/NetworkProcess.cpp: +(WebKit::NetworkProcess::initializeNetworkProcess): +(WebKit::NetworkProcess::setCacheModelSynchronouslyForTesting): +(WebKit::NetworkProcess::setCacheModel): +* NetworkProcess/NetworkProcess.h: +(WebKit::NetworkProcess::cacheModel const): +* NetworkProcess/NetworkProcess.messages.in: +* NetworkProcess/cache/CacheStorageEngineCaches.cpp: +(WebKit::CacheStorage::Caches::initialize): +* NetworkProcess/cache/NetworkCache.cpp: +(WebKit::NetworkCache::computeCapacity): +(WebKit::NetworkCache::Cache::open): +(WebKit::NetworkCache::Cache::capacity const): +(WebKit::NetworkCache::Cache::updateCapacity): +(WebKit::NetworkCache::Cache::setCapacity): Deleted. +* NetworkProcess/cache/NetworkCache.h: +* NetworkProcess/cache/NetworkCacheStorage.cpp: +(WebKit::NetworkCache::Storage::open): +(WebKit::NetworkCache::Storage::Storage): +(WebKit::NetworkCache::Storage::setCapacity): +* NetworkProcess/cache/NetworkCacheStorage.h: +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::setCacheModel): + 2020-02-19 Wenson Hsieh [iOS] fast/dom/focus-shift-crash.html and editing/selection/selection-change-in-disconnected-frame-crash.html crash after r256864 Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (256966 => 256967) ---
[webkit-changes] [256966] trunk/LayoutTests
Title: [256966] trunk/LayoutTests Revision 256966 Author lmo...@igalia.com Date 2020-02-19 15:24:57 -0800 (Wed, 19 Feb 2020) Log Message [GTK] More media tests gardening https://bugs.webkit.org/show_bug.cgi?id=207965 Unreviewed test gardening. * platform/gtk-wayland/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk-wayland/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256965 => 256966) --- trunk/LayoutTests/ChangeLog 2020-02-19 23:14:19 UTC (rev 256965) +++ trunk/LayoutTests/ChangeLog 2020-02-19 23:24:57 UTC (rev 256966) @@ -1,3 +1,13 @@ +2020-02-19 Lauro Moura + +[GTK] More media tests gardening +https://bugs.webkit.org/show_bug.cgi?id=207965 + +Unreviewed test gardening. + +* platform/gtk-wayland/TestExpectations: +* platform/gtk/TestExpectations: + 2020-02-19 Ryan Haddad Flaky Test: editing/spelling/spellcheck-attribute.html Modified: trunk/LayoutTests/platform/gtk/TestExpectations (256965 => 256966) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-19 23:14:19 UTC (rev 256965) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-19 23:24:57 UTC (rev 256966) @@ -1506,7 +1506,7 @@ webkit.org/b/89811 media/media-blocked-by-beforeload.html [ Failure Pass ] webkit.org/b/84856 media/media-controller-playback.html [ Crash Failure Timeout Pass ] -webkit.org/b/83878 media/track/track-mode.html [ Failure Pass ] +webkit.org/b/83878 webkit.org/b/198830 media/track/track-mode.html [ Failure Pass ] webkit.org/b/49179 animations/stop-animation-on-suspend.html [ Failure Pass ] webkit.org/b/49179 legacy-animation-engine/animations/stop-animation-on-suspend.html [ Failure Pass ] @@ -1718,7 +1718,8 @@ webkit.org/b/36642 fast/replaced/border-radius-clip.html [ Failure Pass ] webkit.org/b/134576 media/track/audio/audio-track-mkv-vorbis-language.html [ Failure Timeout Pass ] -webkit.org/b/134576 media/track/track-cue-rendering.html [ Failure Timeout Pass ] +webkit.org/b/134576 webkit.org/b/198830 [ Release ] media/track/track-cue-rendering.html [ Failure Timeout Pass Crash ] +webkit.org/b/134576 [ Debug ] media/track/track-cue-rendering.html [ Failure Timeout Pass ] webkit.org/b/134576 media/track/video/video-track-mkv-theora-selected.html [ Failure Timeout Pass Crash ] webkit.org/b/134576 webkit.org/b/198830 media/track/video/video-track-mkv-theora-language.html [ Failure Timeout Pass Crash ] webkit.org/b/134577 svg/dom/svg-root-lengths.html [ Failure Timeout Pass ] @@ -1819,9 +1820,6 @@ # Probably failing because resizing is asynchronous. webkit.org/b/53959 fast/dom/Window/window-resize.html [ Failure Timeout Pass ] -# This failures only seem to happen if the environment variable XVFB_SCREEN_DEPTH=8 is not set -webkit.org/b/132126 webkit.org/b/198830 [ Release ] media/track/track-cues-cuechange.html [ Timeout Pass Crash ] -webkit.org/b/132126 media/track/track-cues-enter-exit.html [ Timeout Pass ] webkit.org/b/153771 animations/resume-after-page-cache.html [ Timeout Failure Pass ] webkit.org/b/153771 legacy-animation-engine/animations/resume-after-page-cache.html [ Timeout Failure Pass ] @@ -1909,8 +1907,6 @@ webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Pass Failure ] -webkit.org/b/168373 media/video-seek-past-end-paused.html [ Failure Pass ] - webkit.org/b/174353 media/video-restricted-invisible-autoplay-not-allowed.html [ Crash Pass ] webkit.org/b/175933 media/audio-controls-timeline-in-media-document.html [ Pass Failure Crash ] @@ -2451,6 +2447,54 @@ webkit.org/b/198830 [ Release ] media/track/audio-track.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/autoplay-with-broken-track.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_canplaythrough.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_order_canplay_canplaythrough.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_play.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/video_loop_base.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] media/media-controller-drag-crash.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] media/media-extension-with-fragment.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] media/media-fragments/TC0015.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] media/media-fragments/TC0024.html [
[webkit-changes] [256965] trunk/LayoutTests
Title: [256965] trunk/LayoutTests Revision 256965 Author ryanhad...@apple.com Date 2020-02-19 15:14:19 -0800 (Wed, 19 Feb 2020) Log Message Flaky Test: editing/spelling/spellcheck-attribute.html https://bugs.webkit.org/show_bug.cgi?id=206178 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Mark test as flaky on Mojave so since the commit queue bots keep hitting it. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256964 => 256965) --- trunk/LayoutTests/ChangeLog 2020-02-19 23:09:55 UTC (rev 256964) +++ trunk/LayoutTests/ChangeLog 2020-02-19 23:14:19 UTC (rev 256965) @@ -1,3 +1,13 @@ +2020-02-19 Ryan Haddad + +Flaky Test: editing/spelling/spellcheck-attribute.html +https://bugs.webkit.org/show_bug.cgi?id=206178 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: Mark test as flaky on Mojave so +since the commit queue bots keep hitting it. + 2020-02-19 Jason Lawrence [ Mac wk2 ] accessibility/mac/aria-menu-item-selected-notification.html is flaky timing out. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256964 => 256965) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-02-19 23:09:55 UTC (rev 256964) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-02-19 23:14:19 UTC (rev 256965) @@ -946,3 +946,5 @@ webkit.org/b/207891 imported/w3c/web-platform-tests/css/css-position/fixed-z-index-blend.html [ Pass Failure ] http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html [ Skip ] + +webkit.org/b/206178 [ Mojave ] editing/spelling/spellcheck-attribute.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256964] tags/Safari-609.1.20.2.2/
Title: [256964] tags/Safari-609.1.20.2.2/ Revision 256964 Author alanc...@apple.com Date 2020-02-19 15:09:55 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.2.2. Added Paths tags/Safari-609.1.20.2.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256962] branches/safari-609.1.20.0-branch/Source/JavaScriptCore
Title: [256962] branches/safari-609.1.20.0-branch/Source/_javascript_Core Revision 256962 Author alanc...@apple.com Date 2020-02-19 15:08:04 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256898. rdar://problem/59551695 Unreviewed build fix. * jit/JITThunks.cpp: (JSC::JITThunks::hostFunctionStub): git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-609-branch@256898 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITThunks.cpp Diff Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog (256961 => 256962) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:08:02 UTC (rev 256961) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:08:04 UTC (rev 256962) @@ -1,5 +1,23 @@ 2020-02-19 Russell Epstein +Cherry-pick r256898. rdar://problem/59551695 + +Unreviewed build fix. + +* jit/JITThunks.cpp: +(JSC::JITThunks::hostFunctionStub): + +git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-609-branch@256898 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-18 Simon Fraser + +Unreviewed build fix. + +* jit/JITThunks.cpp: +(JSC::JITThunks::hostFunctionStub): + +2020-02-19 Russell Epstein + Cherry-pick r256779. rdar://problem/59551695 [JSC] JITThunk should be HashSet> with appropriate GC weakness handling Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITThunks.cpp (256961 => 256962) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITThunks.cpp 2020-02-19 23:08:02 UTC (rev 256961) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITThunks.cpp 2020-02-19 23:08:04 UTC (rev 256962) @@ -218,7 +218,7 @@ ASSERT(!*addResult.iterator); *addResult.iterator = Weak(nativeExecutable, this); ASSERT(*addResult.iterator); -#if ASSERT_ENABLED +#if !ASSERT_DISABLED auto iterator = m_nativeExecutableSet.find(hostFunctionKey); ASSERT(iterator != m_nativeExecutableSet.end()); ASSERT(iterator->get() == nativeExecutable); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256960] branches/safari-609.1.20.0-branch
Title: [256960] branches/safari-609.1.20.0-branch
Revision 256960
Author alanc...@apple.com
Date 2020-02-19 15:07:57 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256766. rdar://problem/59551706
[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
https://bugs.webkit.org/show_bug.cgi?id=207849
Reviewed by Mark Lam.
JSTests:
* wasm/regress/regress-256665.js: Added.
(f):
Source/_javascript_Core:
When generating the call IC, we should select the callee saves using BoundsChecking mode in order
to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
register when calling the Wasm LLInt through the call IC.
* wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::calleeSaves const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.0-branch/JSTests/ChangeLog
branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-609.1.20.0-branch/Source/_javascript_Core/wasm/js/WebAssemblyFunction.cpp
Added Paths
branches/safari-609.1.20.0-branch/JSTests/wasm/regress/regress-256665.js
Diff
Modified: branches/safari-609.1.20.0-branch/JSTests/ChangeLog (256959 => 256960)
--- branches/safari-609.1.20.0-branch/JSTests/ChangeLog 2020-02-19 23:07:54 UTC (rev 256959)
+++ branches/safari-609.1.20.0-branch/JSTests/ChangeLog 2020-02-19 23:07:57 UTC (rev 256960)
@@ -1,5 +1,41 @@
2020-02-19 Russell Epstein
+Cherry-pick r256766. rdar://problem/59551706
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
+Source/_javascript_Core:
+
+When generating the call IC, we should select the callee saves using BoundsChecking mode in order
+to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
+register when calling the Wasm LLInt through the call IC.
+
+* wasm/js/WebAssemblyFunction.cpp:
+(JSC::WebAssemblyFunction::calleeSaves const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-17 Tadeu Zagallo
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
+2020-02-19 Russell Epstein
+
Cherry-pick r256698. rdar://problem/59551715
Unreviewed: fix broken tests added in r256665
Added: branches/safari-609.1.20.0-branch/JSTests/wasm/regress/regress-256665.js (0 => 256960)
--- branches/safari-609.1.20.0-branch/JSTests/wasm/regress/regress-256665.js (rev 0)
+++ branches/safari-609.1.20.0-branch/JSTests/wasm/regress/regress-256665.js 2020-02-19 23:07:57 UTC (rev 256960)
@@ -0,0 +1,12 @@
+//@ requireOptions("--useConcurrentJIT=false", "--jitPolicyScale=0")
+
+function f() {
+var buffer = new Uint8Array([0, 97, 115, 109, 1, 0, 0, 0, 1, 6, 1, 96, 1, 127, 1, 127, 3, 2, 1, 0, 5, 3, 1, 0, 0, 7, 8, 1, 4, 108, 111, 97, 100, 0, 0, 10, 9, 1, 7, 0, 32, 0, 40, 0, 100, 11]);
+var module = new WebAssembly.Module(buffer);
+var instance = new WebAssembly.Instance(module);
+try { instance.exports.load(0x1 - 100 - 4); } catch (e) {}
+(555)[0];
+}
+
+f();
+f();
Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog (256959 => 256960)
--- branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:07:54 UTC (rev 256959)
+++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:07:57 UTC (rev 256960)
@@ -1,5 +1,45 @@
2020-02-19 Russell Epstein
+Cherry-pick r256766. rdar://problem/59551706
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
+Source/_javascript_Core:
+
+When generating the call IC, we should select the callee saves using BoundsChecking mode in order
+to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
+register when calling the Wasm LLInt through the call IC.
+
+* wasm/js/WebAssemblyFunction.cpp:
+(JSC::WebAssemblyFunction::calleeSaves const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-17 Tadeu Zagallo
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC
[webkit-changes] [256958] branches/safari-609.1.20.0-branch
Title: [256958] branches/safari-609.1.20.0-branch Revision 256958 Author alanc...@apple.com Date 2020-02-19 15:07:52 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256665. rdar://problem/59551715 [WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention. https://bugs.webkit.org/show_bug.cgi?id=207727 JSTests: Reviewed by Mark Lam. * wasm/regress/llint-callee-saves-with-fast-memory.js: Added. * wasm/regress/llint-callee-saves-without-fast-memory.js: Added. Source/_javascript_Core: Reviewed by Mark Lam. The Wasm JIT has unusual calling conventions, which were further complicated by the addition of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly saving and restoring the callee save registers used for the memory base and size). Here's a summary of the calling convention: - When entering Wasm from JS, the wrapper must: - Preserve the base and size when entering LLInt regardless of the mode. (Prior to this patch we only preserved the base in Signaling mode) - Preserve the memory base in either mode, and the size for BoundsChecking. - Both tiers must preserve every *other* register they use. e.g. the LLInt must preserve PB and wasmInstance, but must *not* preserve memoryBase and memorySize. - Changes to memoryBase and memorySize are visible to the caller. This means that: - Intra-module calls can assume these registers are up-to-date even if the memory was resized. The only exception here is if the LLInt calls a signaling JIT, in which case the JIT will not update the size register, since it won't be using it. - Inter-module and JS calls require the caller to reload these registers. These calls may result in memory changes (e.g. the callee may call memory.grow). - A Signaling JIT caller must be aware that the LLInt may trash the size register, since it always bounds checks. * llint/WebAssembly.asm: * wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::addCall): * wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addCall): * wasm/WasmCallee.cpp: (JSC::Wasm::LLIntCallee::calleeSaveRegisters): * wasm/WasmCallingConvention.h: * wasm/WasmLLIntPlan.cpp: (JSC::Wasm::LLIntPlan::didCompleteCompilation): * wasm/WasmMemoryInformation.cpp: (JSC::Wasm::PinnedRegisterInfo::get): (JSC::Wasm::getPinnedRegisters): Deleted. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256665 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.0-branch/JSTests/ChangeLog branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.0-branch/Source/_javascript_Core/llint/WebAssembly.asm branches/safari-609.1.20.0-branch/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/wasm/WasmCallee.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/wasm/WasmCallingConvention.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/wasm/WasmLLIntPlan.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/wasm/WasmMemoryInformation.cpp Added Paths branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js Diff Modified: branches/safari-609.1.20.0-branch/JSTests/ChangeLog (256957 => 256958) --- branches/safari-609.1.20.0-branch/JSTests/ChangeLog 2020-02-19 23:07:48 UTC (rev 256957) +++ branches/safari-609.1.20.0-branch/JSTests/ChangeLog 2020-02-19 23:07:52 UTC (rev 256958) @@ -1,3 +1,68 @@ +2020-02-19 Russell Epstein + +Cherry-pick r256665. rdar://problem/59551715 + +[WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention. +https://bugs.webkit.org/show_bug.cgi?id=207727 + +JSTests: + +Reviewed by Mark Lam. + +* wasm/regress/llint-callee-saves-with-fast-memory.js: Added. +* wasm/regress/llint-callee-saves-without-fast-memory.js: Added. + +Source/_javascript_Core: + +Reviewed by Mark Lam. + +The Wasm JIT has unusual calling conventions, which were further complicated by the addition +of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly +saving and restoring the callee save registers used for the memory base and size). Here's a summary +of the calling convention: + +- When entering Wasm from JS, the wrapper must: +- Preserve the base and size when entering LLInt regardless of the mode. (Prior to this + patch we only preserved the base in Signaling mode) +- Preserve the memory base in either mode, and the
[webkit-changes] [256959] branches/safari-609.1.20.0-branch/JSTests
Title: [256959] branches/safari-609.1.20.0-branch/JSTests Revision 256959 Author alanc...@apple.com Date 2020-02-19 15:07:54 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256698. rdar://problem/59551715 Unreviewed: fix broken tests added in r256665 https://bugs.webkit.org/show_bug.cgi?id=207727 Our inline WAT doesn't seem to like named blocks/branch targets. * wasm/regress/llint-callee-saves-with-fast-memory.js: * wasm/regress/llint-callee-saves-without-fast-memory.js: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.0-branch/JSTests/ChangeLog branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js Diff Modified: branches/safari-609.1.20.0-branch/JSTests/ChangeLog (256958 => 256959) --- branches/safari-609.1.20.0-branch/JSTests/ChangeLog 2020-02-19 23:07:52 UTC (rev 256958) +++ branches/safari-609.1.20.0-branch/JSTests/ChangeLog 2020-02-19 23:07:54 UTC (rev 256959) @@ -1,5 +1,29 @@ 2020-02-19 Russell Epstein +Cherry-pick r256698. rdar://problem/59551715 + +Unreviewed: fix broken tests added in r256665 +https://bugs.webkit.org/show_bug.cgi?id=207727 + +Our inline WAT doesn't seem to like named blocks/branch targets. + +* wasm/regress/llint-callee-saves-with-fast-memory.js: +* wasm/regress/llint-callee-saves-without-fast-memory.js: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-14 Tadeu Zagallo + +Unreviewed: fix broken tests added in r256665 +https://bugs.webkit.org/show_bug.cgi?id=207727 + +Our inline WAT doesn't seem to like named blocks/branch targets. + +* wasm/regress/llint-callee-saves-with-fast-memory.js: +* wasm/regress/llint-callee-saves-without-fast-memory.js: + +2020-02-19 Russell Epstein + Cherry-pick r256665. rdar://problem/59551715 [WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention. Modified: branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js (256958 => 256959) --- branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js 2020-02-19 23:07:52 UTC (rev 256958) +++ branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js 2020-02-19 23:07:54 UTC (rev 256959) @@ -23,11 +23,11 @@ (func (export "main") (local $i i32) (local.set $i (i32.const 10)) -(loop $warmup +(loop (i32.sub (local.get $i) (i32.const 1)) (local.tee $i) (call $f (i32.const 1)) -(br_if $warmup) +(br_if 0) ) (call $f (i32.const 0)) ) Modified: branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js (256958 => 256959) --- branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js 2020-02-19 23:07:52 UTC (rev 256958) +++ branches/safari-609.1.20.0-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js 2020-02-19 23:07:54 UTC (rev 256959) @@ -21,11 +21,11 @@ (func (export "main") (local $i i32) (local.set $i (i32.const 10)) -(loop $warmup +(loop (i32.sub (local.get $i) (i32.const 1)) (local.tee $i) (call $f (i32.const 1)) -(br_if $warmup) +(br_if 0) ) (call $f (i32.const 0)) ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256951] branches/safari-609.1.20.0-branch/Source/JavaScriptCore
Title: [256951] branches/safari-609.1.20.0-branch/Source/_javascript_Core Revision 256951 Author alanc...@apple.com Date 2020-02-19 15:07:21 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59446991 Modified Paths branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.0-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/bytecode/CodeBlock.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/dfg/DFGJITCode.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/dfg/DFGJITCode.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/dfg/DFGJITCompiler.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/dfg/DFGJITFinalizer.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/dfg/DFGPlan.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/ftl/FTLJITCode.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/ftl/FTLJITCode.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JIT.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JIT.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITCode.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITCode.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITInlines.h Diff Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog (256950 => 256951) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-19 22:19:53 UTC (rev 256950) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog 2020-02-19 23:07:21 UTC (rev 256951) @@ -1,3 +1,68 @@ +2020-02-19 Russell Epstein + +Apply patch. rdar://problem/59446991 + +2020-02-19 Yusuke Suzuki + +[JSC] CodeBlock::shrinkToFit should shrink m_constantRegisters and m_constantsSourceCodeRepresentation in 64bit architectures +https://bugs.webkit.org/show_bug.cgi?id=207356 + +Reviewed by Mark Lam. + +Only 32bit architectures are using m_constantRegisters's address. 64bit architectures are not relying on m_constantRegisters's address. +This patches fixes the thing so that CodeBlock::shrinkToFit will shrink m_constantRegisters and m_constantsSourceCodeRepresentation +regardless of whether this is EarlyShrink or not. We also move DFG/FTL's LateShrink call to the place after calling DFGCommon reallyAdd +since they can add more constant registers. + +Relanding it by fixing dead-lock. + +* bytecode/CodeBlock.cpp: +(JSC::CodeBlock::shrinkToFit): +* bytecode/CodeBlock.h: +* dfg/DFGJITCompiler.cpp: +(JSC::DFG::JITCompiler::compile): +(JSC::DFG::JITCompiler::compileFunction): +* dfg/DFGJITFinalizer.cpp: +(JSC::DFG::JITFinalizer::finalizeCommon): +* dfg/DFGPlan.cpp: +(JSC::DFG::Plan::compileInThreadImpl): +(JSC::DFG::Plan::finalizeWithoutNotifyingCallback): +* jit/JIT.cpp: +(JSC::JIT::link): +* jit/JIT.h: +* jit/JITInlines.h: +(JSC::JIT::emitLoadDouble): +(JSC::JIT::emitLoadInt32ToDouble): Deleted. + +2020-01-31 Yusuke Suzuki + +[JSC] DFG::CommonData::shrinkToFit called before DFG::Plan::reallyAdd is called +https://bugs.webkit.org/show_bug.cgi?id=207083 + +Reviewed by Mark Lam. + +We are calling DFG::CommonData::shrinkToFit, but calling this too early: we execute +DFG::Plan::reallyAdd(DFG::CommonData*) after that, and this adds many entries to +DFG::CommonData*. We should call DFG::CommonData::shrinkToFit after calling DFG::Plan::reallyAdd. + +To implement it, we make DFG::JITCode::shrinkToFit virtual function in JSC::JITCode. Then, we +can also implement FTL::JITCode::shrinkToFit which was previously not implemented. + +* dfg/DFGJITCode.cpp: +(JSC::DFG::JITCode::shrinkToFit): +* dfg/DFGJITCode.h: +* dfg/DFGJITCompiler.cpp: +(JSC::DFG::JITCompiler::compile): +(JSC::DFG::JITCompiler::compileFunction): +* dfg/DFGPlan.cpp: +(JSC::DFG::Plan::finalizeWithoutNotifyingCallback): +* ftl/FTLJITCode.cpp: +(JSC::FTL::JITCode::shrinkToFit): +* ftl/FTLJITCode.h: +* jit/JITCode.cpp: +(JSC::JITCode::shrinkToFit): +* jit/JITCode.h: + 2020-02-14 Russell Epstein Cherry-pick r256498. rdar://problem/59478929 Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp (256950 => 256951) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp 2020-02-19 22:19:53 UTC (rev 256950) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp 2020-02-19 23:07:21 UTC (rev
[webkit-changes] [256957] branches/safari-609.1.20.0-branch
Title: [256957] branches/safari-609.1.20.0-branch
Revision 256957
Author alanc...@apple.com
Date 2020-02-19 15:07:48 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256432. rdar://problem/59446974
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
https://bugs.webkit.org/show_bug.cgi?id=207537
Reviewed by Chris Dumez.
Source/WebKit:
Covered by added API test.
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
branches/safari-609.1.20.0-branch/Tools/ChangeLog
branches/safari-609.1.20.0-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
Diff
Modified: branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog (256956 => 256957)
--- branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog 2020-02-19 23:07:45 UTC (rev 256956)
+++ branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog 2020-02-19 23:07:48 UTC (rev 256957)
@@ -1,5 +1,42 @@
2020-02-19 Russell Epstein
+Cherry-pick r256432. rdar://problem/59446974
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Source/WebKit:
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
+Tools:
+
+* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-12 Youenn Fablet
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
+2020-02-19 Russell Epstein
+
Cherry-pick r256426. rdar://problem/59447008
[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
Modified: branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256956 => 256957)
--- branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:07:45 UTC (rev 256956)
+++ branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:07:48 UTC (rev 256957)
@@ -319,6 +319,7 @@
bool isNewOrigin = WTF::allOf(m_clientOrigins.values(), [](auto& origin) {
return contextOrigin != origin.clientOrigin;
});
+auto* contextConnection = isNewOrigin ? server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin }) : nullptr;
auto clientOrigin = ClientOrigin { WTFMove(topOrigin), WTFMove(contextOrigin) };
m_clientOrigins.add(data.identifier, clientOrigin);
@@ -327,11 +328,9 @@
if (!m_isThrottleable)
updateThrottleState();
-if (isNewOrigin) {
-if (auto* contextConnection = server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin })) {
-auto& connection = static_cast(*contextConnection);
-m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
-}
+if (contextConnection) {
+auto& connection = static_cast(*contextConnection);
+m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
}
}
Modified: branches/safari-609.1.20.0-branch/Tools/ChangeLog (256956 => 256957)
--- branches/safari-609.1.20.0-branch/Tools/ChangeLog 2020-02-19 23:07:45 UTC (rev 256956)
+++ branches/safari-609.1.20.0-branch/Tools/ChangeLog 2020-02-19 23:07:48 UTC (rev 256957)
@@ -1,5
[webkit-changes] [256961] branches/safari-609.1.20.0-branch
Title: [256961] branches/safari-609.1.20.0-branch Revision 256961 Author alanc...@apple.com Date 2020-02-19 15:08:02 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256779. rdar://problem/59551695 [JSC] JITThunk should be HashSet> with appropriate GC weakness handling https://bugs.webkit.org/show_bug.cgi?id=207715 Reviewed by Darin Adler. JSTests: * stress/stress-jitthunks.js: Added. (let.set newGlobal): (set catch): Source/_javascript_Core: This patch refines JITThunks GC-aware Weak hash map for NativeExecutable. Previously, we have HashMap, Weak> table. But this is not good because the first tuple's information is already in NativeExecutable. But we were using this design since Weak can be nullified because of Weak<>. If this happens, we could have invalid Entry in HashMap which does not have corresponding values. This will cause crash when rehasing requires hash code for this entry. But this HashMap is very bad in terms of memory usage. Each entry has 32 bytes, and this table gets enough large. We identified that this table is consuming much memory in Membuster. So it is worth designing carefully crafted data structure which only holds Weak by leveraging the deep interaction with our GC implementation. This patch implements new design of JITThunks, which uses HashSet> and carefully crafted HashTraits / KeyTraits to handle Weak<> well. 1. Each Weak should have finalizer, and this finalizer should remove dead Weak from HashSet. This is ensuring that all the keys in HashSet is, even if Weak<> is saying it is Dead, it still has an way to access content of NativeExecutable if the content is not a JS objects. For example, we can get function pointer from dead Weak if it is not yet finalized. Since we remove all finalized Weak<> from the table, this finalizer mechanism allows us to access function pointers etc. from Weak so long as it is held in this table. 2. Getting NativeExecutable* from JITThunks should have special protocol. When getting NativeExecutable* from JITThunks, we do the following, 1. First, we check we have an Entry in JITThunks. If it does not exist, we should insert it anyway. 1.1. If it exists, we should check whether this Weak is dead or not. It is possible that dead one is still in the table because "dead" does not mean that it is "finalized". Until finalizing happens (and it can be delayed by incremental-sweeper), Weak can be dead but still accessible. So the table is still holding dead one. If we get dead one, we should insert a new one. 1.2. If it is not dead, we return it. 2. Second, we create a new NativeExecutable and insert it. In that case, it is possible that the table already has Weak, but it is dead. In that case, we need to explicitly replace it with newly created one since old one is holding old content. If we replaced, finalizer of Weak<> will not be invoked since it immediately deallocates Weak<>. So, it does not happen that this newly inserted NativeExecutable* is removed by the finalizer registered by the old Weak<>. This change makes memory usage of JITThunks table 1/4. * heap/Weak.cpp: (JSC::weakClearSlowCase): * heap/Weak.h: (JSC::Weak::Weak): (JSC::Weak::isHashTableEmptyValue const): (JSC::Weak::unsafeImpl const): (WTF::HashTraits>::isEmptyValue): * heap/WeakInlines.h: (JSC::Weak::Weak): * jit/JITThunks.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::WeakNativeExecutableHash::hash): (JSC::JITThunks::WeakNativeExecutableHash::equal): (JSC::JITThunks::HostKeySearcher::hash): (JSC::JITThunks::HostKeySearcher::equal): (JSC::JITThunks::NativeExecutableTranslator::hash): (JSC::JITThunks::NativeExecutableTranslator::equal): (JSC::JITThunks::NativeExecutableTranslator::translate): (JSC::JITThunks::finalize): (JSC::JITThunks::hostFunctionStub): (JSC::JITThunks::clearHostFunctionStubs): Deleted. * jit/JITThunks.h: * runtime/NativeExecutable.h: * tools/JSDollarVM.cpp: (JSC::functionGCSweepAsynchronously): (JSC::functionCreateEmptyFunctionWithName): (JSC::JSDollarVM::finishCreation): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256779 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.0-branch/JSTests/ChangeLog branches/safari-609.1.20.0-branch/Source/_javascript_Core/ChangeLog branches/safari-609.1.20.0-branch/Source/_javascript_Core/heap/Weak.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/heap/Weak.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/heap/WeakInlines.h branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITThunks.cpp branches/safari-609.1.20.0-branch/Source/_javascript_Core/jit/JITThunks.h
[webkit-changes] [256956] branches/safari-609.1.20.0-branch/Source/WebKit
Title: [256956] branches/safari-609.1.20.0-branch/Source/WebKit
Revision 256956
Author alanc...@apple.com
Date 2020-02-19 15:07:45 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256426. rdar://problem/59447008
[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
https://bugs.webkit.org/show_bug.cgi?id=207509
Reviewed by Chris Dumez.
Covered by existing tests.
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::writeSizeFile):
Make sure completion handler is always called on the main thread.
Minor refactoring to make things more efficient.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
Diff
Modified: branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog (256955 => 256956)
--- branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog 2020-02-19 23:07:42 UTC (rev 256955)
+++ branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog 2020-02-19 23:07:45 UTC (rev 256956)
@@ -1,5 +1,40 @@
2020-02-19 Russell Epstein
+Cherry-pick r256426. rdar://problem/59447008
+
+[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
+https://bugs.webkit.org/show_bug.cgi?id=207509
+
+
+Reviewed by Chris Dumez.
+
+Covered by existing tests.
+
+* NetworkProcess/cache/CacheStorageEngine.cpp:
+(WebKit::CacheStorage::Engine::writeSizeFile):
+Make sure completion handler is always called on the main thread.
+Minor refactoring to make things more efficient.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-11 Youenn Fablet
+
+[ Mac Debug wk2 ] ASSERTION FAILED: m_wasConstructedOnMainThread == isMainThread()
+https://bugs.webkit.org/show_bug.cgi?id=207509
+
+
+Reviewed by Chris Dumez.
+
+Covered by existing tests.
+
+* NetworkProcess/cache/CacheStorageEngine.cpp:
+(WebKit::CacheStorage::Engine::writeSizeFile):
+Make sure completion handler is always called on the main thread.
+Minor refactoring to make things more efficient.
+
+2020-02-19 Russell Epstein
+
Cherry-pick r256383. rdar://problem/59446974
Unreviewed, rolling out r256314.
Modified: branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (256955 => 256956)
--- branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2020-02-19 23:07:42 UTC (rev 256955)
+++ branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2020-02-19 23:07:45 UTC (rev 256956)
@@ -530,23 +530,25 @@
void Engine::writeSizeFile(const String& path, uint64_t size, CompletionHandler&& completionHandler)
{
-CompletionHandlerCallingScope completionHandlerCaller(WTFMove(completionHandler));
+ASSERT(RunLoop::isMain());
+
if (!shouldPersist())
-return;
+return completionHandler();
-m_ioQueue->dispatch([path = path.isolatedCopy(), size, completionHandlerCaller = WTFMove(completionHandlerCaller)]() mutable {
+m_ioQueue->dispatch([path = path.isolatedCopy(), size, completionHandler = WTFMove(completionHandler)]() mutable {
LockHolder locker(globalSizeFileLock);
auto fileHandle = FileSystem::openFile(path, FileSystem::FileOpenMode::Write);
-auto closeFileHandler = makeScopeExit([&] {
+
+if (FileSystem::isHandleValid(fileHandle)) {
+FileSystem::truncateFile(fileHandle, 0);
+
+auto value = String::number(size).utf8();
+FileSystem::writeToFile(fileHandle, value.data(), value.length());
+
FileSystem::closeFile(fileHandle);
-});
-if (!FileSystem::isHandleValid(fileHandle))
-return;
+}
-FileSystem::truncateFile(fileHandle, 0);
-FileSystem::writeToFile(fileHandle, String::number(size).utf8().data(), String::number(size).utf8().length());
-
-RunLoop::main().dispatch([completionHandlerCaller = WTFMove(completionHandlerCaller)]() mutable { });
+RunLoop::main().dispatch(WTFMove(completionHandler));
});
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256954] branches/safari-609.1.20.0-branch
Title: [256954] branches/safari-609.1.20.0-branch
Revision 256954
Author alanc...@apple.com
Date 2020-02-19 15:07:39 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256314. rdar://problem/59446974
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
https://bugs.webkit.org/show_bug.cgi?id=207537
Reviewed by Chris Dumez.
Source/WebKit:
Covered by added API test.
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
branches/safari-609.1.20.0-branch/Tools/ChangeLog
branches/safari-609.1.20.0-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
Diff
Modified: branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog (256953 => 256954)
--- branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog 2020-02-19 23:07:36 UTC (rev 256953)
+++ branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog 2020-02-19 23:07:39 UTC (rev 256954)
@@ -1,3 +1,40 @@
+2020-02-19 Russell Epstein
+
+Cherry-pick r256314. rdar://problem/59446974
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Source/WebKit:
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
+Tools:
+
+* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-11 Youenn Fablet
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
2020-02-14 Russell Epstein
Cherry-pick r252849. rdar://problem/59446998
Modified: branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256953 => 256954)
--- branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:07:36 UTC (rev 256953)
+++ branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:07:39 UTC (rev 256954)
@@ -319,6 +319,7 @@
bool isNewOrigin = WTF::allOf(m_clientOrigins.values(), [](auto& origin) {
return contextOrigin != origin.clientOrigin;
});
+auto* contextConnection = isNewOrigin ? server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin }) : nullptr;
auto clientOrigin = ClientOrigin { WTFMove(topOrigin), WTFMove(contextOrigin) };
m_clientOrigins.add(data.identifier, clientOrigin);
@@ -327,11 +328,9 @@
if (!m_isThrottleable)
updateThrottleState();
-if (isNewOrigin) {
-if (auto* contextConnection = server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin })) {
-auto& connection = static_cast(*contextConnection);
-m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
-}
+if (contextConnection) {
+auto& connection = static_cast(*contextConnection);
+m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
}
}
Modified: branches/safari-609.1.20.0-branch/Tools/ChangeLog (256953 => 256954)
--- branches/safari-609.1.20.0-branch/Tools/ChangeLog 2020-02-19 23:07:36 UTC (rev 256953)
+++ branches/safari-609.1.20.0-branch/Tools/ChangeLog 2020-02-19 23:07:39 UTC (rev 256954)
@@ -1,3 +1,36 @@
+2020-02-19 Russell Epstein
+
+Cherry-pick r256314.
[webkit-changes] [256955] branches/safari-609.1.20.0-branch
Title: [256955] branches/safari-609.1.20.0-branch
Revision 256955
Author alanc...@apple.com
Date 2020-02-19 15:07:42 -0800 (Wed, 19 Feb 2020)
Log Message
Cherry-pick r256383. rdar://problem/59446974
Unreviewed, rolling out r256314.
https://bugs.webkit.org/show_bug.cgi?id=207594
It is breaking an API test (Requested by youenn on #webkit).
Reverted changeset:
"WebSWServerConnection::registerServiceWorkerClient is not
sending IPC message to UIProcess when it should"
https://bugs.webkit.org/show_bug.cgi?id=207537
https://trac.webkit.org/changeset/256314
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog
branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
branches/safari-609.1.20.0-branch/Tools/ChangeLog
branches/safari-609.1.20.0-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
Diff
Modified: branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog (256954 => 256955)
--- branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog 2020-02-19 23:07:39 UTC (rev 256954)
+++ branches/safari-609.1.20.0-branch/Source/WebKit/ChangeLog 2020-02-19 23:07:42 UTC (rev 256955)
@@ -1,5 +1,37 @@
2020-02-19 Russell Epstein
+Cherry-pick r256383. rdar://problem/59446974
+
+Unreviewed, rolling out r256314.
+https://bugs.webkit.org/show_bug.cgi?id=207594
+
+It is breaking an API test (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"WebSWServerConnection::registerServiceWorkerClient is not
+sending IPC message to UIProcess when it should"
+https://bugs.webkit.org/show_bug.cgi?id=207537
+https://trac.webkit.org/changeset/256314
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-11 Commit Queue
+
+Unreviewed, rolling out r256314.
+https://bugs.webkit.org/show_bug.cgi?id=207594
+
+It is breaking an API test (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"WebSWServerConnection::registerServiceWorkerClient is not
+sending IPC message to UIProcess when it should"
+https://bugs.webkit.org/show_bug.cgi?id=207537
+https://trac.webkit.org/changeset/256314
+
+2020-02-19 Russell Epstein
+
Cherry-pick r256314. rdar://problem/59446974
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
Modified: branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256954 => 256955)
--- branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:07:39 UTC (rev 256954)
+++ branches/safari-609.1.20.0-branch/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2020-02-19 23:07:42 UTC (rev 256955)
@@ -319,7 +319,6 @@
bool isNewOrigin = WTF::allOf(m_clientOrigins.values(), [](auto& origin) {
return contextOrigin != origin.clientOrigin;
});
-auto* contextConnection = isNewOrigin ? server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin }) : nullptr;
auto clientOrigin = ClientOrigin { WTFMove(topOrigin), WTFMove(contextOrigin) };
m_clientOrigins.add(data.identifier, clientOrigin);
@@ -328,9 +327,11 @@
if (!m_isThrottleable)
updateThrottleState();
-if (contextConnection) {
-auto& connection = static_cast(*contextConnection);
-m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
+if (isNewOrigin) {
+if (auto* contextConnection = server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin })) {
+auto& connection = static_cast(*contextConnection);
+m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
+}
}
}
Modified: branches/safari-609.1.20.0-branch/Tools/ChangeLog (256954 => 256955)
--- branches/safari-609.1.20.0-branch/Tools/ChangeLog 2020-02-19 23:07:39 UTC (rev 256954)
+++ branches/safari-609.1.20.0-branch/Tools/ChangeLog 2020-02-19 23:07:42 UTC (rev 256955)
@@ -1,5 +1,37 @@
2020-02-19 Russell Epstein
+Cherry-pick r256383. rdar://problem/59446974
+
+Unreviewed, rolling out r256314.
+https://bugs.webkit.org/show_bug.cgi?id=207594
+
+It is breaking an API test (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"WebSWServerConnection::registerServiceWorkerClient is not
+sending IPC message to UIProcess when it
[webkit-changes] [256963] branches/safari-609.1.20.0-branch
Title: [256963] branches/safari-609.1.20.0-branch Revision 256963 Author alanc...@apple.com Date 2020-02-19 15:08:09 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59478837 Modified Paths branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events-expected.txt branches/safari-609.1.20.0-branch/Source/WebCore/ChangeLog branches/safari-609.1.20.0-branch/Source/WebCore/animation/AnimationTimeline.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/AnimationTimeline.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSAnimation.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/CSSAnimation.h branches/safari-609.1.20.0-branch/Source/WebCore/animation/KeyframeEffect.cpp branches/safari-609.1.20.0-branch/Source/WebCore/animation/KeyframeEffect.h branches/safari-609.1.20.0-branch/Source/WebCore/style/StyleTreeResolver.cpp Diff Modified: branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog (256962 => 256963) --- branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-19 23:08:04 UTC (rev 256962) +++ branches/safari-609.1.20.0-branch/LayoutTests/ChangeLog 2020-02-19 23:08:09 UTC (rev 256963) @@ -1,3 +1,19 @@ +2020-02-19 Russell Epstein + +Apply patch. rdar://problem/59478837 + +2020-02-19 Antoine Quint + +[Web Animations] Style changes due to Web Animations should not trigger CSS Transitions +https://bugs.webkit.org/show_bug.cgi?id=207760 + + +Reviewed by Simon Fraser. + +Mark that a couple of tests are no longer flaky. + +* TestExpectations: + 2020-02-14 Russell Epstein Cherry-pick r256623. rdar://problem/59478938 Modified: branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations (256962 => 256963) --- branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations 2020-02-19 23:08:04 UTC (rev 256962) +++ branches/safari-609.1.20.0-branch/LayoutTests/TestExpectations 2020-02-19 23:08:09 UTC (rev 256963) @@ -2651,8 +2651,6 @@ webkit.org/b/179069 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/sandbox_032.htm [ Pass Failure ] -webkit.org/b/202107 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events.html [ Pass Failure ] -webkit.org/b/202108 imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events.html [ Pass Failure ] webkit.org/b/202109 imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html [ Pass Failure ] webkit.org/b/157068 [ Debug ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Crash ] Modified: branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog (256962 => 256963) --- branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog 2020-02-19 23:08:04 UTC (rev 256962) +++ branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/ChangeLog 2020-02-19 23:08:09 UTC (rev 256963) @@ -1,3 +1,22 @@ +2020-02-19 Russell Epstein + +Apply patch. rdar://problem/59478837 + +2020-02-19 Antoine Quint + +[Web Animations] Style changes due to Web Animations should not trigger CSS Transitions +https://bugs.webkit.org/show_bug.cgi?id=207760 + + +Reviewed by Simon Fraser. + +Mark Web Platform Tests progressions. + +* web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt: +* web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt: +* web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events-expected.txt: +* web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events-expected.txt: + 2020-02-14 Russell Epstein Cherry-pick r256207. rdar://problem/59447263 Modified: branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt (256962 => 256963) --- branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt 2020-02-19 23:08:04 UTC (rev 256962) +++ branches/safari-609.1.20.0-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt 2020-02-19 23:08:09 UTC (rev 256963) @@ -1,26 +1,26 @@ PASS All property keys are recognized -FAIL Animation.id produces
[webkit-changes] [256953] branches/safari-609.1.20.0-branch/Source/JavaScriptCore/runtime/ OptionsList.h
Title: [256953] branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/OptionsList.h Revision 256953 Author alanc...@apple.com Date 2020-02-19 15:07:36 -0800 (Wed, 19 Feb 2020) Log Message Apply patch. rdar://problem/59447266 Modified Paths branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/OptionsList.h Diff Modified: branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/OptionsList.h (256952 => 256953) --- branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/OptionsList.h 2020-02-19 23:07:33 UTC (rev 256952) +++ branches/safari-609.1.20.0-branch/Source/_javascript_Core/runtime/OptionsList.h 2020-02-19 23:07:36 UTC (rev 256953) @@ -473,7 +473,7 @@ v(Size, webAssemblyBBQAirModeThreshold, isIOS() ? (10 * MB) : 0, Normal, "If 0, we always use BBQ Air. If Wasm module code size hits this threshold, we compile Wasm module with B3 BBQ mode.") \ v(Bool, useWebAssemblyStreamingApi, enableWebAssemblyStreamingApi, Normal, "Allow to run WebAssembly's Streaming API") \ v(Bool, useEagerWebAssemblyModuleHashing, false, Normal, "Unnamed WebAssembly modules are identified in backtraces through their hash, if available.") \ -v(Bool, useWebAssemblyReferences, true, Normal, "Allow types from the wasm references spec.") \ +v(Bool, useWebAssemblyReferences, false, Normal, "Allow types from the wasm references spec.") \ v(Bool, useWebAssemblyMultiValues, true, Normal, "Allow types from the wasm mulit-values spec.") \ v(Bool, useWeakRefs, false, Normal, "Expose the WeakRef constructor.") \ v(Bool, useBigInt, false, Normal, "If true, we will enable BigInt support.") \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256950] trunk/LayoutTests
Title: [256950] trunk/LayoutTests Revision 256950 Author lawrenc...@apple.com Date 2020-02-19 14:19:53 -0800 (Wed, 19 Feb 2020) Log Message [ Mac wk2 ] accessibility/mac/aria-menu-item-selected-notification.html is flaky timing out. https://bugs.webkit.org/show_bug.cgi?id=207962 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256949 => 256950) --- trunk/LayoutTests/ChangeLog 2020-02-19 22:10:22 UTC (rev 256949) +++ trunk/LayoutTests/ChangeLog 2020-02-19 22:19:53 UTC (rev 256950) @@ -1,3 +1,12 @@ +2020-02-19 Jason Lawrence + +[ Mac wk2 ] accessibility/mac/aria-menu-item-selected-notification.html is flaky timing out. +https://bugs.webkit.org/show_bug.cgi?id=207962 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-02-19 Lauro Moura [GTK] Layout Test media/track/audio-track.html is flaky Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256949 => 256950) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-19 22:10:22 UTC (rev 256949) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-02-19 22:19:53 UTC (rev 256950) @@ -1060,4 +1060,6 @@ webkit.org/b/207953 [ Release ] fast/scrolling/latching/scroll-iframe-in-overflow.html [ Pass Failure ] -webkit.org/b/207954 http/tests/inspector/network/har/har-page.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/207954 http/tests/inspector/network/har/har-page.html [ Pass Failure ] + +webkit.org/b/207962 accessibility/mac/aria-menu-item-selected-notification.html [ Slow ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256949] trunk/Source/WebCore
Title: [256949] trunk/Source/WebCore
Revision 256949
Author you...@apple.com
Date 2020-02-19 14:10:22 -0800 (Wed, 19 Feb 2020)
Log Message
[mac debug] Regression: http/tests/websocket/tests/hybi/workers/worker-reload.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=207940
Reviewed by Chris Dumez.
Covered by debug asserts.
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
Pass registrable domain instead of URL.
Isolate copy the domain before hopping to main thread for extra protection.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WebSocket.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (256948 => 256949)
--- trunk/Source/WebCore/ChangeLog 2020-02-19 22:02:10 UTC (rev 256948)
+++ trunk/Source/WebCore/ChangeLog 2020-02-19 22:10:22 UTC (rev 256949)
@@ -1,5 +1,20 @@
2020-02-19 Youenn Fablet
+[mac debug] Regression: http/tests/websocket/tests/hybi/workers/worker-reload.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=207940
+
+
+Reviewed by Chris Dumez.
+
+Covered by debug asserts.
+
+* Modules/websockets/WebSocket.cpp:
+(WebCore::WebSocket::connect):
+Pass registrable domain instead of URL.
+Isolate copy the domain before hopping to main thread for extra protection.
+
+2020-02-19 Youenn Fablet
+
Remove PlatformMediaSession::characteristics()
https://bugs.webkit.org/show_bug.cgi?id=207926
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (256948 => 256949)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2020-02-19 22:02:10 UTC (rev 256948)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2020-02-19 22:10:22 UTC (rev 256949)
@@ -324,9 +324,9 @@
}
#if ENABLE(RESOURCE_LOAD_STATISTICS)
-auto reportRegistrableDomain = [url = "" context) {
+auto reportRegistrableDomain = [domain = RegistrableDomain(m_url).isolatedCopy()](auto& context) mutable {
if (auto* frame = downcast(context).frame())
-frame->loader().client().addLoadedRegistrableDomain(RegistrableDomain(url));
+frame->loader().client().addLoadedRegistrableDomain(WTFMove(domain));
};
if (is(context))
reportRegistrableDomain(context);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256948] trunk/Source/WebKitLegacy
Title: [256948] trunk/Source/WebKitLegacy
Revision 256948
Author dba...@webkit.org
Date 2020-02-19 14:02:10 -0800 (Wed, 19 Feb 2020)
Log Message
[iOS][LegacyWebKit] Override EditorClient::shouldRevealCurrentSelectionAfterInsertion()
https://bugs.webkit.org/show_bug.cgi?id=207955
Reviewed by Wenson Hsieh.
Source/WebKitLegacy/ios:
Adds a stub function for -shouldRevealCurrentSelectionAfterInsertion that returns YES,
to keep our current behavior.
* DefaultDelegates/WebDefaultUIKitDelegate.m:
(-[WebDefaultUIKitDelegate shouldRevealCurrentSelectionAfterInsertion]): Added.
* WebView/WebUIKitDelegate.h:
Source/WebKitLegacy/mac:
Wire up EditorClient::shouldRevealCurrentSelectionAfterInsertion() in Legacy WebKit. This
allows Legacy WebKit clients to toggle whether the current selection is revealed after
an insertion, which they may want to do to achieve a desired UI effect.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldRevealCurrentSelectionAfterInsertion const): Added. Ask the _UIKitDelegateForwarder
if it responds to -shouldRevealCurrentSelectionAfterInsertion. If it does then return its
response. Otherwise, return true to do what we do now: reveal the current selection after
an insertion.
Modified Paths
trunk/Source/WebKitLegacy/ios/ChangeLog
trunk/Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.m
trunk/Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
Diff
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (256947 => 256948)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2020-02-19 21:54:40 UTC (rev 256947)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2020-02-19 22:02:10 UTC (rev 256948)
@@ -1,3 +1,18 @@
+2020-02-19 Daniel Bates
+
+[iOS][LegacyWebKit] Override EditorClient::shouldRevealCurrentSelectionAfterInsertion()
+https://bugs.webkit.org/show_bug.cgi?id=207955
+
+
+Reviewed by Wenson Hsieh.
+
+Adds a stub function for -shouldRevealCurrentSelectionAfterInsertion that returns YES,
+to keep our current behavior.
+
+* DefaultDelegates/WebDefaultUIKitDelegate.m:
+(-[WebDefaultUIKitDelegate shouldRevealCurrentSelectionAfterInsertion]): Added.
+* WebView/WebUIKitDelegate.h:
+
2020-02-07 Jon Lee
Web Inspector: Revert slim toolbar
Modified: trunk/Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.m (256947 => 256948)
--- trunk/Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.m 2020-02-19 21:54:40 UTC (rev 256947)
+++ trunk/Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.m 2020-02-19 22:02:10 UTC (rev 256948)
@@ -252,6 +252,11 @@
return CGPointZero;
}
+- (BOOL)shouldRevealCurrentSelectionAfterInsertion
+{
+return YES;
+}
+
- (void)showPlaybackTargetPicker:(BOOL)hasVideo fromRect:(CGRect)elementRect
{
}
Modified: trunk/Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h (256947 => 256948)
--- trunk/Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h 2020-02-19 21:54:40 UTC (rev 256947)
+++ trunk/Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h 2020-02-19 22:02:10 UTC (rev 256948)
@@ -126,6 +126,8 @@
- (CGPoint)interactionLocation;
- (void)showPlaybackTargetPicker:(BOOL)hasVideo fromRect:(CGRect)elementRect;
+- (BOOL)shouldRevealCurrentSelectionAfterInsertion;
+
#if ENABLE_ORIENTATION_EVENTS
- (int)deviceOrientation;
#endif
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (256947 => 256948)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-02-19 21:54:40 UTC (rev 256947)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-02-19 22:02:10 UTC (rev 256948)
@@ -1,3 +1,22 @@
+2020-02-19 Daniel Bates
+
+[iOS][LegacyWebKit] Override EditorClient::shouldRevealCurrentSelectionAfterInsertion()
+https://bugs.webkit.org/show_bug.cgi?id=207955
+
+
+Reviewed by Wenson Hsieh.
+
+Wire up EditorClient::shouldRevealCurrentSelectionAfterInsertion() in Legacy WebKit. This
+allows Legacy WebKit clients to toggle whether the current selection is revealed after
+an insertion, which they may want to do to achieve a desired UI effect.
+
+* WebCoreSupport/WebEditorClient.h:
+* WebCoreSupport/WebEditorClient.mm:
+(WebEditorClient::shouldRevealCurrentSelectionAfterInsertion const): Added. Ask the _UIKitDelegateForwarder
+if it responds to -shouldRevealCurrentSelectionAfterInsertion. If it does then return its
+response. Otherwise, return true to do what we do now: reveal the current selection after
+an insertion.
+
2020-02-18 Simon Fraser
Move from "layer flush" terminology to "rendering update"
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h (256947 => 256948)
---
[webkit-changes] [256947] trunk/LayoutTests
Title: [256947] trunk/LayoutTests Revision 256947 Author lmo...@igalia.com Date 2020-02-19 13:54:40 -0800 (Wed, 19 Feb 2020) Log Message [GTK] Layout Test media/track/audio-track.html is flaky https://bugs.webkit.org/show_bug.cgi?id=134573 Unreviewed test gardening. This test has not timeout (on its own) since r180689 (Feb 2015) other than 4 timeouts on a bot hiccup up to r2545640 with other media tests. Updating its expectation to reflect the new behavior affected by bug198830. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (256946 => 256947) --- trunk/LayoutTests/ChangeLog 2020-02-19 21:43:56 UTC (rev 256946) +++ trunk/LayoutTests/ChangeLog 2020-02-19 21:54:40 UTC (rev 256947) @@ -1,3 +1,17 @@ +2020-02-19 Lauro Moura + +[GTK] Layout Test media/track/audio-track.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=134573 + +Unreviewed test gardening. + +This test has not timeout (on its own) since r180689 (Feb 2015) other +than 4 timeouts on a bot hiccup up to r2545640 with other media tests. +Updating its expectation to reflect the new behavior affected by +bug198830. + +* platform/gtk/TestExpectations: + 2020-02-19 Jason Lawrence [ Mac wk2 ] http/tests/inspector/network/har/har-page.html is flaky failing Modified: trunk/LayoutTests/platform/gtk/TestExpectations (256946 => 256947) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-19 21:43:56 UTC (rev 256946) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-02-19 21:54:40 UTC (rev 256947) @@ -1717,7 +1717,6 @@ webkit.org/b/36642 fast/replaced/border-radius-clip.html [ Failure Pass ] -webkit.org/b/134573 media/track/audio-track.html [ Failure Timeout Pass ] webkit.org/b/134576 media/track/audio/audio-track-mkv-vorbis-language.html [ Failure Timeout Pass ] webkit.org/b/134576 media/track/track-cue-rendering.html [ Failure Timeout Pass ] webkit.org/b/134576 media/track/video/video-track-mkv-theora-selected.html [ Failure Timeout Pass Crash ] @@ -2450,6 +2449,8 @@ webkit.org/b/198830 [ Release ] media/W3C/video/events/event_playing.html [ Pass Crash ] webkit.org/b/198830 [ Release ] media/W3C/video/networkState/networkState_during_loadstart.html [ Pass Crash ] +webkit.org/b/198830 [ Release ] media/track/audio-track.html [ Pass Crash ] + webkit.org/b/207927 [ Release ] media/audio-playback-restriction-removed-muted.html [ Pass Crash ] webkit.org/b/170484 swipe/main-frame-pinning-requirement.html [ Pass Failure Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256946] tags/Safari-609.1.20.3.2/
Title: [256946] tags/Safari-609.1.20.3.2/ Revision 256946 Author alanc...@apple.com Date 2020-02-19 13:43:56 -0800 (Wed, 19 Feb 2020) Log Message Tag Safari-609.1.20.3.2. Added Paths tags/Safari-609.1.20.3.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256944] branches/safari-609.1.20.1-branch/Source
Title: [256944] branches/safari-609.1.20.1-branch/Source Revision 256944 Author repst...@apple.com Date 2020-02-19 13:40:49 -0800 (Wed, 19 Feb 2020) Log Message Versioning. Modified Paths branches/safari-609.1.20.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-609.1.20.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-609.1.20.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-609.1.20.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-609.1.20.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-609.1.20.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-609.1.20.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-609.1.20.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-609.1.20.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256943 => 256944) --- branches/safari-609.1.20.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) +++ branches/safari-609.1.20.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-19 21:40:49 UTC (rev 256944) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256943 => 256944) --- branches/safari-609.1.20.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) +++ branches/safari-609.1.20.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-19 21:40:49 UTC (rev 256944) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256943 => 256944) --- branches/safari-609.1.20.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) +++ branches/safari-609.1.20.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-19 21:40:49 UTC (rev 256944) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.1-branch/Source/WebCore/Configurations/Version.xcconfig (256943 => 256944) --- branches/safari-609.1.20.1-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) +++ branches/safari-609.1.20.1-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-19 21:40:49 UTC (rev 256944) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-609.1.20.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256943 => 256944) --- branches/safari-609.1.20.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) +++ branches/safari-609.1.20.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-19 21:40:49 UTC (rev 256944) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 20; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION =
[webkit-changes] [256943] branches/safari-609.1.20.3-branch/Source
Title: [256943] branches/safari-609.1.20.3-branch/Source Revision 256943 Author alanc...@apple.com Date 2020-02-19 13:34:29 -0800 (Wed, 19 Feb 2020) Log Message Versioning. Modified Paths branches/safari-609.1.20.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-609.1.20.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-609.1.20.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-609.1.20.3-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-609.1.20.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-609.1.20.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-609.1.20.3-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-609.1.20.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-609.1.20.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256942 => 256943) --- branches/safari-609.1.20.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-19 21:31:20 UTC (rev 256942) +++ branches/safari-609.1.20.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 3; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256942 => 256943) --- branches/safari-609.1.20.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-19 21:31:20 UTC (rev 256942) +++ branches/safari-609.1.20.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 3; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256942 => 256943) --- branches/safari-609.1.20.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-19 21:31:20 UTC (rev 256942) +++ branches/safari-609.1.20.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 3; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.3-branch/Source/WebCore/Configurations/Version.xcconfig (256942 => 256943) --- branches/safari-609.1.20.3-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-19 21:31:20 UTC (rev 256942) +++ branches/safari-609.1.20.3-branch/Source/WebCore/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 3; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256942 => 256943) --- branches/safari-609.1.20.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-19 21:31:20 UTC (rev 256942) +++ branches/safari-609.1.20.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 3; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-609.1.20.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (256942 => 256943) --- branches/safari-609.1.20.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-02-19 21:31:20 UTC (rev 256942) +++ branches/safari-609.1.20.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-02-19 21:34:29 UTC (rev 256943) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 3; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [256942] branches/safari-609.1.20.2-branch
Title: [256942] branches/safari-609.1.20.2-branch Revision 256942 Author alanc...@apple.com Date 2020-02-19 13:31:20 -0800 (Wed, 19 Feb 2020) Log Message Cherry-pick r256225. rdar://problem/59446983 [watchOS] Notification listener is never unregistered https://bugs.webkit.org/show_bug.cgi?id=207459 Source/WebKit: Reviewed by Maciej Stachowiak. On watchOS, the backlight changed notification is registered in WebProcessPool::registerNotificationObservers(), but not unregistered in WebProcessPool::unregisterNotificationObservers(). API test: WebKit.BacklightLevelNotificationCrash * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::unregisterNotificationObservers): Tools: Reviewed by Maciej Stachowiak. Add a test which tests that posting a backlight level change notification will not cause a crash. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added. (TEST): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256225 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-609.1.20.2-branch/Source/WebKit/ChangeLog branches/safari-609.1.20.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm branches/safari-609.1.20.2-branch/Tools/ChangeLog branches/safari-609.1.20.2-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Added Paths branches/safari-609.1.20.2-branch/Tools/TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm Diff Modified: branches/safari-609.1.20.2-branch/Source/WebKit/ChangeLog (256941 => 256942) --- branches/safari-609.1.20.2-branch/Source/WebKit/ChangeLog 2020-02-19 21:23:23 UTC (rev 256941) +++ branches/safari-609.1.20.2-branch/Source/WebKit/ChangeLog 2020-02-19 21:31:20 UTC (rev 256942) @@ -1,3 +1,51 @@ +2020-02-19 Alan Coon + +Cherry-pick r256225. rdar://problem/59446983 + +[watchOS] Notification listener is never unregistered +https://bugs.webkit.org/show_bug.cgi?id=207459 +Source/WebKit: + + + +Reviewed by Maciej Stachowiak. + +On watchOS, the backlight changed notification is registered in WebProcessPool::registerNotificationObservers(), +but not unregistered in WebProcessPool::unregisterNotificationObservers(). + +API test: WebKit.BacklightLevelNotificationCrash + +* UIProcess/Cocoa/WebProcessPoolCocoa.mm: +(WebKit::WebProcessPool::unregisterNotificationObservers): + +Tools: + +Reviewed by Maciej Stachowiak. + +Add a test which tests that posting a backlight level change notification will not cause a crash. + +* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: +* TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added. +(TEST): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256225 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-02-10 Per Arne Vollan + +[watchOS] Notification listener is never unregistered +https://bugs.webkit.org/show_bug.cgi?id=207459 + + +Reviewed by Maciej Stachowiak. + +On watchOS, the backlight changed notification is registered in WebProcessPool::registerNotificationObservers(), +but not unregistered in WebProcessPool::unregisterNotificationObservers(). + +API test: WebKit.BacklightLevelNotificationCrash + +* UIProcess/Cocoa/WebProcessPoolCocoa.mm: +(WebKit::WebProcessPool::unregisterNotificationObservers): + 2020-02-14 Russell Epstein Cherry-pick r252849. rdar://problem/59446998 Modified: branches/safari-609.1.20.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (256941 => 256942) --- branches/safari-609.1.20.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-02-19 21:23:23 UTC (rev 256941) +++ branches/safari-609.1.20.2-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-02-19 21:31:20 UTC (rev 256942) @@ -553,9 +553,11 @@ #endif [[NSNotificationCenter defaultCenter] removeObserver:m_activationObserver.get()]; [[NSNotificationCenter defaultCenter] removeObserver:m_deactivationObserver.get()]; -#elif PLATFORM(IOS) +#elif !PLATFORM(MACCATALYST) CFNotificationCenterRemoveObserver(CFNotificationCenterGetDarwinNotifyCenter(), this, static_cast(UIBacklightLevelChangedNotification) , nullptr); +#if PLATFORM(IOS) [[NSNotificationCenter defaultCenter] removeObserver:m_accessibilityEnabledObserver.get()]; +#endif // PLATFORM(IOS) #endif // !PLATFORM(IOS_FAMILY) } Modified: branches/safari-609.1.20.2-branch/Tools/ChangeLog (256941 => 256942) --- branches/safari-609.1.20.2-branch/Tools/ChangeLog 2020-02-19 21:23:23 UTC (rev 256941) +++ branches/safari-609.1.20.2-branch/Tools/ChangeLog 2020-02-19 21:31:20 UTC (rev 256942) @@ -1,3 +1,48 @@ +2020-02-19 Alan Coon + +Cherry-pick r256225.
[webkit-changes] [256941] trunk
Title: [256941] trunk
Revision 256941
Author keith_mil...@apple.com
Date 2020-02-19 13:23:23 -0800 (Wed, 19 Feb 2020)
Log Message
Disable Wasm reference types by default
https://bugs.webkit.org/show_bug.cgi?id=207952
Reviewed by Mark Lam.
JSTests:
* wasm/stress/immutable-globals.js:
* wasm/stress/local-ref.js:
* wasm/stress/mutable-globals.js:
Source/_javascript_Core:
* runtime/OptionsList.h:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/wasm/stress/immutable-globals.js
trunk/JSTests/wasm/stress/local-ref.js
trunk/JSTests/wasm/stress/mutable-globals.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/OptionsList.h
Diff
Modified: trunk/JSTests/ChangeLog (256940 => 256941)
--- trunk/JSTests/ChangeLog 2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/JSTests/ChangeLog 2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,14 @@
+2020-02-19 Keith Miller
+
+Disable Wasm reference types by default
+https://bugs.webkit.org/show_bug.cgi?id=207952
+
+Reviewed by Mark Lam.
+
+* wasm/stress/immutable-globals.js:
+* wasm/stress/local-ref.js:
+* wasm/stress/mutable-globals.js:
+
2020-02-18 Ross Kirsling
[JSC] Computed function properties compute their keys twice
Modified: trunk/JSTests/wasm/stress/immutable-globals.js (256940 => 256941)
--- trunk/JSTests/wasm/stress/immutable-globals.js 2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/JSTests/wasm/stress/immutable-globals.js 2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,4 @@
+//@ requireOptions("--useWebAssemblyReferences=1")
import Builder from '../Builder.js'
import * as assert from '../assert.js'
Modified: trunk/JSTests/wasm/stress/local-ref.js (256940 => 256941)
--- trunk/JSTests/wasm/stress/local-ref.js 2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/JSTests/wasm/stress/local-ref.js 2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,4 @@
+//@ requireOptions("--useWebAssemblyReferences=1")
import { instantiate } from "../wabt-wrapper.js";
instantiate(`
Modified: trunk/JSTests/wasm/stress/mutable-globals.js (256940 => 256941)
--- trunk/JSTests/wasm/stress/mutable-globals.js 2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/JSTests/wasm/stress/mutable-globals.js 2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,4 @@
+//@ requireOptions("--useWebAssemblyReferences=1")
import Builder from '../Builder.js'
import * as assert from '../assert.js'
Modified: trunk/Source/_javascript_Core/ChangeLog (256940 => 256941)
--- trunk/Source/_javascript_Core/ChangeLog 2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-02-19 21:23:23 UTC (rev 256941)
@@ -1,3 +1,12 @@
+2020-02-19 Keith Miller
+
+Disable Wasm reference types by default
+https://bugs.webkit.org/show_bug.cgi?id=207952
+
+Reviewed by Mark Lam.
+
+* runtime/OptionsList.h:
+
2020-02-19 Stephan Szabo
[PlayStation] Get jsc test wrappers using find_package
Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (256940 => 256941)
--- trunk/Source/_javascript_Core/runtime/OptionsList.h 2020-02-19 21:22:34 UTC (rev 256940)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h 2020-02-19 21:23:23 UTC (rev 256941)
@@ -478,7 +478,7 @@
v(Size, webAssemblyBBQAirModeThreshold, isIOS() ? (10 * MB) : 0, Normal, "If 0, we always use BBQ Air. If Wasm module code size hits this threshold, we compile Wasm module with B3 BBQ mode.") \
v(Bool, useWebAssemblyStreamingApi, enableWebAssemblyStreamingApi, Normal, "Allow to run WebAssembly's Streaming API") \
v(Bool, useEagerWebAssemblyModuleHashing, false, Normal, "Unnamed WebAssembly modules are identified in backtraces through their hash, if available.") \
-v(Bool, useWebAssemblyReferences, true, Normal, "Allow types from the wasm references spec.") \
+v(Bool, useWebAssemblyReferences, false, Normal, "Allow types from the wasm references spec.") \
v(Bool, useWebAssemblyMultiValues, true, Normal, "Allow types from the wasm mulit-values spec.") \
v(Bool, useWeakRefs, false, Normal, "Expose the WeakRef constructor.") \
v(Bool, useBigInt, false, Normal, "If true, we will enable BigInt support.") \
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
