[webkit-changes] [225054] trunk
Title: [225054] trunk Revision 225054 Author ma...@webkit.org Date 2017-11-20 14:02:46 -0800 (Mon, 20 Nov 2017) Log Message [GTK] New API to add, retrieve and delete cookies via WebKitCookieManager https://bugs.webkit.org/show_bug.cgi?id=177932 Reviewed by Carlos Garcia Campos. Source/WebCore: Implemented setCookie(), getCookies() and deleteCookie() in the Soup backend, and refactored some utility functions and conversions out of NetworkStorageSessionSoup into a new CookieSoup.cpp file, so that we now can convert between SoupCookie* and WebCore::Cookie easily from anywhere (this is now needed from the UI Process). * platform/Cookie.h: Add declarations for the new conversions. * platform/SourcesSoup.txt: Add CookieSoup.cpp. * platform/network/soup/CookieSoup.cpp: Added. (WebCore::Cookie::Cookie): New constructor, creates a WebCore::Cookie out of a SoupCookie*. (WebCore::msToSoupDate): Moved from NetworkStorageSessionSoup.cpp. (WebCore::Cookie::toSoupCookie): New, based on toSoupCookie() from NetworkStorageSessionSoup.cpp. * platform/network/soup/NetworkStorageSessionSoup.cpp: (WebCore::NetworkStorageSession::setCookies): Used the new implicit conversion. (WebCore::NetworkStorageSession::setCookie): Newly implemented. (WebCore::NetworkStorageSession::deleteCookie): Newly implemented. (WebCore::NetworkStorageSession::getCookies): Newly implemented. Source/WebKit: Added new API to WebKitCookieManager to add, retrieve and delete complete cookies into/out-of a running session, and updated documentation sections. * UIProcess/API/glib/WebKitCookieManager.cpp: (webkit_cookie_manager_add_cookie): New function. (webkit_cookie_manager_add_cookie_finish): Ditto. (webkit_cookie_manager_get_cookies): Ditto. (webkit_cookie_manager_get_cookies_finish): Ditto. (webkit_cookie_manager_delete_cookie): Ditto. (webkit_cookie_manager_delete_cookie_finish): Ditto. * UIProcess/API/gtk/WebKitCookieManager.h: Added new functions. * UIProcess/API/wpe/WebKitCookieManager.h: Ditto. * UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Ditto. Tools: Added new test cases to cover the newly added API for WebKitCookieManager: webkit_cookie_manager_add_cookie, webkit_cookie_manager_get_cookies and webkit_cookie_manager_delete_cookie. * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: (testCookieManagerAddCookie): Added. (testCookieManagerGetCookies): Added. (testCookieManagerDeleteCookie): Added. (serverCallback): Small update to avoid hardcoding strings we reuse. (beforeAll): Added the new test cases to the test suite. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/Cookie.h trunk/Source/WebCore/platform/SourcesSoup.txt trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp trunk/Source/WebKit/UIProcess/API/gtk/WebKitCookieManager.h trunk/Source/WebKit/UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt trunk/Source/WebKit/UIProcess/API/wpe/WebKitCookieManager.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp Added Paths trunk/Source/WebCore/platform/network/soup/CookieSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (225053 => 225054) --- trunk/Source/WebCore/ChangeLog 2017-11-20 21:20:15 UTC (rev 225053) +++ trunk/Source/WebCore/ChangeLog 2017-11-20 22:02:46 UTC (rev 225054) @@ -1,3 +1,28 @@ +2017-11-20 Mario Sanchez Prada <ma...@endlessm.com> + +[GTK] New API to add, retrieve and delete cookies via WebKitCookieManager +https://bugs.webkit.org/show_bug.cgi?id=177932 + +Reviewed by Carlos Garcia Campos. + +Implemented setCookie(), getCookies() and deleteCookie() in the Soup +backend, and refactored some utility functions and conversions out of +NetworkStorageSessionSoup into a new CookieSoup.cpp file, so +that we now can convert between SoupCookie* and WebCore::Cookie +easily from anywhere (this is now needed from the UI Process). + +* platform/Cookie.h: Add declarations for the new conversions. +* platform/SourcesSoup.txt: Add CookieSoup.cpp. +* platform/network/soup/CookieSoup.cpp: Added. +(WebCore::Cookie::Cookie): New constructor, creates a WebCore::Cookie out of a SoupCookie*. +(WebCore::msToSoupDate): Moved from NetworkStorageSessionSoup.cpp. +(WebCore::Cookie::toSoupCookie): New, based on toSoupCookie() from NetworkStorageSessionSoup.cpp. +* platform/network/soup/NetworkStorageSessionSoup.cpp: +(WebCore::NetworkStorageSession::setCookies): Used the new implicit conversion. +(WebCore::NetworkStorageSession::setCookie): Newly implemented. +(WebCore::NetworkStorageSession::deleteCookie): Newly implemented. +(WebCore::NetworkStorageSession::getCookies): Newly implemented. + 2017-11-20 Zalan Bujtas <za...@apple.com> Remove slow repaint object
[webkit-changes] [213509] trunk/Tools
Title: [213509] trunk/Tools Revision 213509 Author ma...@webkit.org Date 2017-03-07 02:15:38 -0800 (Tue, 07 Mar 2017) Log Message Unreviewed. Removed myself from the Accessibility watch list Patch by Mario Sanchez Prada <ma...@webkit.org> on 2017-03-07 * Scripts/webkitpy/common/config/watchlist: Removed myself. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/watchlist Diff Modified: trunk/Tools/ChangeLog (213508 => 213509) --- trunk/Tools/ChangeLog 2017-03-07 09:51:17 UTC (rev 213508) +++ trunk/Tools/ChangeLog 2017-03-07 10:15:38 UTC (rev 213509) @@ -1,3 +1,9 @@ +2017-03-07 Mario Sanchez Prada <ma...@webkit.org> + +Unreviewed. Removed myself from the Accessibility watch list + +* Scripts/webkitpy/common/config/watchlist: Removed myself. + 2017-03-06 Fujii Hironori <hironori.fu...@sony.com> Add Fujii Hironori to contributor's list Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (213508 => 213509) --- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2017-03-07 09:51:17 UTC (rev 213508) +++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2017-03-07 10:15:38 UTC (rev 213509) @@ -358,7 +358,7 @@ # Note: All email addresses listed must be registered with bugzilla. # Specifically, le...@chromium.org and levin+thread...@chromium.org are # two different accounts as far as bugzilla is concerned. -"Accessibility": [ "cfleiz...@apple.com", "dmazz...@google.com", "apinhe...@igalia.com", "jdi...@igalia.com", "aboxh...@chromium.org", "ma...@webkit.org", "samuel_wh...@apple.com", "jcr...@apple.com" ], +"Accessibility": [ "cfleiz...@apple.com", "dmazz...@google.com", "apinhe...@igalia.com", "jdi...@igalia.com", "aboxh...@chromium.org", "samuel_wh...@apple.com", "jcr...@apple.com" ], "Animation" : [ "simon.fra...@apple.com", "d...@apple.com", "dstockw...@chromium.org" ], "MotionMark" : [ "sabouhall...@apple.com" ], "BindingsScripts": [ "cdu...@apple.com" ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206859] trunk/Source/WebCore
Title: [206859] trunk/Source/WebCore Revision 206859 Author ma...@webkit.org Date 2016-10-06 03:22:59 -0700 (Thu, 06 Oct 2016) Log Message [GStreamer] Can't play any video with GSTREAMER_GL enabled https://bugs.webkit.org/show_bug.cgi?id=162669 Reviewed by Philippe Normand. Make sure an EGLDisplay type is passed when creating the GstGlDisplay for the EGL code path, instead of a native X11 display type, so that we get a valid GstGlDisplay as a result, not a dummy one. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: (WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (206858 => 206859) --- trunk/Source/WebCore/ChangeLog 2016-10-06 10:00:28 UTC (rev 206858) +++ trunk/Source/WebCore/ChangeLog 2016-10-06 10:22:59 UTC (rev 206859) @@ -1,3 +1,17 @@ +2016-10-06 Mario Sanchez Prada <ma...@endlessm.com> + +[GStreamer] Can't play any video with GSTREAMER_GL enabled +https://bugs.webkit.org/show_bug.cgi?id=162669 + +Reviewed by Philippe Normand. + +Make sure an EGLDisplay type is passed when creating the GstGlDisplay +for the EGL code path, instead of a native X11 display type, so +that we get a valid GstGlDisplay as a result, not a dummy one. + +* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: +(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext): + 2016-10-06 Youenn Fablet <you...@apple.com> [Fetch API] Forbid redirection to non-HTTP(s) URL in non-navigation mode. Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (206858 => 206859) --- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2016-10-06 10:00:28 UTC (rev 206858) +++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2016-10-06 10:22:59 UTC (rev 206859) @@ -262,13 +262,13 @@ m_glDisplay = GST_GL_DISPLAY(gst_gl_display_x11_new_with_display(downcast(sharedDisplay).native())); #elif USE(EGL) if (is(sharedDisplay)) -m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast(sharedDisplay).native())); +m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast(sharedDisplay).eglDisplay())); #endif #endif #if PLATFORM(WAYLAND) if (is(sharedDisplay)) -m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast(sharedDisplay).native())); +m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast(sharedDisplay).eglDisplay())); #endif ASSERT(m_glDisplay); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [195811] trunk/Source/WebKit2
Title: [195811] trunk/Source/WebKit2
Revision 195811
Author ma...@webkit.org
Date 2016-01-29 08:26:23 -0800 (Fri, 29 Jan 2016)
Log Message
[GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Guard all the new DnD-related code under GTK_CHECK_VERSION #if's to
make sure we don't bump the required version of GTK+ up to 3.16, and
it's buildable again with GTK+ >= 3.6.
* UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler):
(WebKit::DragAndDropHandler::startDrag):
(WebKit::DragAndDropHandler::fillDragData):
(WebKit::DragAndDropHandler::finishDrag):
* UIProcess/gtk/DragAndDropHandler.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp
trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (195810 => 195811)
--- trunk/Source/WebKit2/ChangeLog 2016-01-29 10:58:17 UTC (rev 195810)
+++ trunk/Source/WebKit2/ChangeLog 2016-01-29 16:26:23 UTC (rev 195811)
@@ -1,3 +1,21 @@
+2016-01-29 Mario Sanchez Prada <ma...@endlessm.com>
+
+[GTK] WebProcess crashes when quickly attempting many DnD operations
+https://bugs.webkit.org/show_bug.cgi?id=138468
+
+Reviewed by Michael Catanzaro.
+
+Guard all the new DnD-related code under GTK_CHECK_VERSION #if's to
+make sure we don't bump the required version of GTK+ up to 3.16, and
+it's buildable again with GTK+ >= 3.6.
+
+* UIProcess/gtk/DragAndDropHandler.cpp:
+(WebKit::DragAndDropHandler::DragAndDropHandler):
+(WebKit::DragAndDropHandler::startDrag):
+(WebKit::DragAndDropHandler::fillDragData):
+(WebKit::DragAndDropHandler::finishDrag):
+* UIProcess/gtk/DragAndDropHandler.h:
+
2016-01-28 Antti Koivisto <an...@apple.com>
Enable background tab suspension by default on OSX
Modified: trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp (195810 => 195811)
--- trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp 2016-01-29 10:58:17 UTC (rev 195810)
+++ trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp 2016-01-29 16:26:23 UTC (rev 195811)
@@ -44,7 +44,9 @@
DragAndDropHandler::DragAndDropHandler(WebPageProxy& page)
: m_page(page)
+#if GTK_CHECK_VERSION(3, 16, 0)
, m_dragContext(nullptr)
+#endif
{
}
@@ -111,20 +113,30 @@
void DragAndDropHandler::startDrag(const DragData& dragData, PassRefPtr dragImage)
{
+#if GTK_CHECK_VERSION(3, 16, 0)
m_draggingDataObject = adoptRef(dragData.platformData());
+GRefPtr targetList = adoptGRef(PasteboardHelper::singleton().targetListForDataObject(m_draggingDataObject.get()));
+#else
+RefPtr dataObject = adoptRef(dragData.platformData());
+GRefPtr targetList = adoptGRef(PasteboardHelper::singleton().targetListForDataObject(dataObject.get()));
+#endif
-GRefPtr targetList = adoptGRef(PasteboardHelper::singleton().targetListForDataObject(m_draggingDataObject.get()));
GUniquePtr currentEvent(gtk_get_current_event());
-
GdkDragContext* context = gtk_drag_begin(m_page.viewWidget(), targetList.get(), dragOperationToGdkDragActions(dragData.draggingSourceOperationMask()),
GDK_BUTTON_PRIMARY, currentEvent.get());
+#if GTK_CHECK_VERSION(3, 16, 0)
// WebCore::EventHandler does not support more than one DnD operation at the same time for
// a given page, so we should cancel any previous operation whose context we might have
// stored, should we receive a new startDrag event before finishing a previous DnD operation.
if (m_dragContext)
gtk_drag_cancel(m_dragContext.get());
m_dragContext = context;
+#else
+// We don't have gtk_drag_cancel() in GTK+ < 3.16, so we use the old code.
+// See https://bugs.webkit.org/show_bug.cgi?id=138468
+m_draggingDataObjects.set(context, dataObject.get());
+#endif
if (dragImage) {
RefPtr image(dragImage->createCairoSurface());
@@ -137,6 +149,7 @@
void DragAndDropHandler::fillDragData(GdkDragContext* context, GtkSelectionData* selectionData, unsigned info)
{
+#if GTK_CHECK_VERSION(3, 16, 0)
// This can happen when attempting to call finish drag from webkitWebViewBaseDragDataGet()
// for a obsolete DnD operation that got previously cancelled in startDrag().
if (m_dragContext.get() != context)
@@ -144,10 +157,15 @@
ASSERT(m_draggingDataObject);
PasteboardHelper::singleton().fillSelectionData(selectionData, info, m_draggingDataObject.get());
+#else
+if (DataObjectGtk* dataObject = m_draggingDataObjects.get(context))
+PasteboardHelper::singleton().fillSelectionData(selectionData, info, dataObject);
+#endif
}
void DragAndDropHandler::finishDrag(GdkDragContext* context)
{
+#if GTK_CHECK_VERSION(3, 16, 0)
// This can happen when attempting to call fin
[webkit-changes] [195586] trunk
Title: [195586] trunk Revision 195586 Author ma...@webkit.org Date 2016-01-26 01:45:51 -0800 (Tue, 26 Jan 2016) Log Message [GTK] WebProcess crashes when quickly attempting many DnD operations https://bugs.webkit.org/show_bug.cgi?id=138468 Reviewed by Michael Catanzaro. Source/WebKit2: Do not allow different DnD operations over the same element at the same time, so that any new attempt to DnD an element happening before a previous attempt has ended will take precedence, cancelling the older operation before going ahead with the new one. This is consistent with how WebCore::EventHandler handles DnD operations, preventing the web process from crashing in scenarios where the user might try to perform many DnD operations over the same element very quickly. * UIProcess/gtk/DragAndDropHandler.cpp: (WebKit::DragAndDropHandler::DragAndDropHandler): Initialized new member. (WebKit::DragAndDropHandler::startDrag): Ensure a previous DnD operation is cancelled before handling the new one that has just started. (WebKit::DragAndDropHandler::fillDragData): Protect against calling this function from webkitWebViewBaseDragDataGet for already cancelled operations. (WebKit::DragAndDropHandler::finishDrag): Protect against calling this function from webkitWebViewBaseDragEnd for already cancelled operations. * UIProcess/gtk/DragAndDropHandler.h: LayoutTests: New test added to check that the web process does not crash when multiple DnD operations are quickly attempted over the same draggable element. * fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt: Added. * fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html: Added. Added the new test to the failure expectations for mac-wk2, as there's no suitable implementation of eventSender in place yet (see bug 42194). * platform/mac-wk2/TestExpectations: Added failure expectation for the new test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.cpp trunk/Source/WebKit2/UIProcess/gtk/DragAndDropHandler.h Added Paths trunk/LayoutTests/fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt trunk/LayoutTests/fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (195585 => 195586) --- trunk/LayoutTests/ChangeLog 2016-01-26 08:17:31 UTC (rev 195585) +++ trunk/LayoutTests/ChangeLog 2016-01-26 09:45:51 UTC (rev 195586) @@ -1,3 +1,21 @@ +2016-01-26 Mario Sanchez Prada <ma...@endlessm.com> + +[GTK] WebProcess crashes when quickly attempting many DnD operations +https://bugs.webkit.org/show_bug.cgi?id=138468 + +Reviewed by Michael Catanzaro. + +New test added to check that the web process does not crash when multiple +DnD operations are quickly attempted over the same draggable element. + +* fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt: Added. +* fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html: Added. + +Added the new test to the failure expectations for mac-wk2, as there's no +suitable implementation of eventSender in place yet (see bug 42194). + +* platform/mac-wk2/TestExpectations: Added failure expectation for the new test. + 2016-01-25 Youenn Fablet <youenn.fab...@crf.canon.fr> imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently Added: trunk/LayoutTests/fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt (0 => 195586) --- trunk/LayoutTests/fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt (rev 0) +++ trunk/LayoutTests/fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt 2016-01-26 09:45:51 UTC (rev 195586) @@ -0,0 +1,35 @@ +HTML hyperlink + +This test checks that quickly attempting a drag'n'drop operation multiple times over the same element does not crash the web process. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +Dragging HTML hyperlink around. Attempt #1 +Dragging HTML hyperlink around. Attempt #2 +Dragging HTML hyperlink around. Attempt #3 +Dragging HTML hyperlink around. Attempt #4 +Dragging HTML hyperlink around. Attempt #5 +Dragging HTML hyperlink around. Attempt #6 +Dragging HTML hyperlink around. Attempt #7 +Dragging HTML hyperlink around. Attempt #8 +Dragging HTML hyperlink around. Attempt #9 +Dragging HTML hyperlink around. Attempt #10 +Dragging HTML hyperlink around. Attempt #11 +Dragging HTML hyperlink around. Attempt #12 +Dragging HTML hyperlink around. Attempt #13 +Dragging HTML hyperlink around. Attempt #14 +Dragging HTML hyperlink around. Attempt #15 +Dragging HTML hyperlink around. Attem
[webkit-changes] [194962] trunk/LayoutTests
Title: [194962] trunk/LayoutTests Revision 194962 Author ma...@webkit.org Date 2016-01-13 04:30:26 -0800 (Wed, 13 Jan 2016) Log Message [GTK] Unreviewed gardening. Patch by Mario Sanchez Prada <ma...@webkit.org> on 2016-01-13 * platform/gtk/TestExpectations: Mark three tests failing in the GTK bots as Crash, Timeout (release builds only) and Failure. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (194961 => 194962) --- trunk/LayoutTests/ChangeLog 2016-01-13 10:32:31 UTC (rev 194961) +++ trunk/LayoutTests/ChangeLog 2016-01-13 12:30:26 UTC (rev 194962) @@ -1,3 +1,10 @@ +2016-01-13 Mario Sanchez Prada <ma...@webkit.org> + +[GTK] Unreviewed gardening. + +* platform/gtk/TestExpectations: Mark three tests failing in the +GTK bots as Crash, Timeout (release builds only) and Failure. + 2016-01-12 Ryan Haddad <ryanhad...@apple.com> Changing expectation from flaky to skip for two crashing tests. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194961 => 194962) --- trunk/LayoutTests/platform/gtk/TestExpectations 2016-01-13 10:32:31 UTC (rev 194961) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-01-13 12:30:26 UTC (rev 194962) @@ -725,6 +725,8 @@ webkit.org/b/152642 http/tests/misc/detached-frame-console.html [ Crash Pass Timeout Failure ] +webkit.org/b/153060 imported/blink/editing/selection/selectstart-event-crash.html [ Crash ] + # # End of Crashing tests # @@ -1404,6 +1406,8 @@ webkit.org/b/146731 fast/events/touch/touch-scaled-scrolled.html [ Timeout ] webkit.org/b/146731 fast/events/touch/touch-stale-node-crash.html [ Timeout ] +webkit.org/b/153061 [ Release ] imported/w3c/indexeddb/idbindex-multientry-big.htm [ Timeout ] + # # End of Tests timing out # @@ -2524,6 +2528,8 @@ webkit.org/b/152823 imported/w3c/css/css-multicol-1/multicol-rule-inset-000.xht [ ImageOnlyFailure ] webkit.org/b/152823 imported/w3c/css/css-multicol-1/multicol-rule-outset-000.xht [ ImageOnlyFailure ] +webkit.org/b/153062 accessibility/gtk/entry-and-password.html [ Failure ] + # # End of Tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [194846] trunk/Source/WebKit2
Title: [194846] trunk/Source/WebKit2 Revision 194846 Author ma...@webkit.org Date 2016-01-11 03:32:07 -0800 (Mon, 11 Jan 2016) Log Message [WK2][GTK] Propagate motion-notify-event signals from the WebView https://bugs.webkit.org/show_bug.cgi?id=152974 Reviewed by Carlos Garcia Campos. Always propagate motion-notify-event signals, regardless of what the web process does, so that we can listen for those events (which does not act on specific targets inside the webview) from the container widget too, and not just from the WebView itself. * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseMotionNotifyEvent): Ensure the signal gets propagated. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (194845 => 194846) --- trunk/Source/WebKit2/ChangeLog 2016-01-11 10:49:47 UTC (rev 194845) +++ trunk/Source/WebKit2/ChangeLog 2016-01-11 11:32:07 UTC (rev 194846) @@ -1,3 +1,18 @@ +2016-01-11 Mario Sanchez Prada <ma...@endlessm.com> + +[WK2][GTK] Propagate motion-notify-event signals from the WebView +https://bugs.webkit.org/show_bug.cgi?id=152974 + +Reviewed by Carlos Garcia Campos. + +Always propagate motion-notify-event signals, regardless of what the +web process does, so that we can listen for those events (which does +not act on specific targets inside the webview) from the container +widget too, and not just from the WebView itself. + +* UIProcess/API/gtk/WebKitWebViewBase.cpp: +(webkitWebViewBaseMotionNotifyEvent): Ensure the signal gets propagated. + 2016-01-10 Dan Bernstein <m...@apple.com> [Cocoa] Disable header postprocessing when building for El Capitan Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (194845 => 194846) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2016-01-11 10:49:47 UTC (rev 194845) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2016-01-11 11:32:07 UTC (rev 194846) @@ -793,11 +793,11 @@ WebKitWebViewBasePrivate* priv = webViewBase->priv; if (priv->authenticationDialog) -return TRUE; +return GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->motion_notify_event(widget, event); priv->pageProxy->handleMouseEvent(NativeWebMouseEvent(reinterpret_cast<GdkEvent*>(event), 0 /* currentClickCount */)); -return TRUE; +return FALSE; } #if ENABLE(TOUCH_EVENTS) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [193815] trunk/Tools
Title: [193815] trunk/Tools
Revision 193815
Author ma...@webkit.org
Date 2015-12-09 03:09:31 -0800 (Wed, 09 Dec 2015)
Log Message
Refactored initialization code in LoadTrackingTest.
Rubber-stamped by Carlos Garcia Campos.
Small refactoring to make sure that the state of a LoadTrackingTest
gets properly reset before loading new web content.
* TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
* TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
(LoadTrackingTest::reset): New, refactored code from *load*() and go*()
functions and reset the remaining local variables.
(LoadTrackingTest::loadURI): Call reset();
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadBytes): Ditto.
(LoadTrackingTest::loadRequest): Ditto.
(LoadTrackingTest::reload): Ditto.
(LoadTrackingTest::goBack): Ditto.
(LoadTrackingTest::goForward): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp
trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h
Diff
Modified: trunk/Tools/ChangeLog (193814 => 193815)
--- trunk/Tools/ChangeLog 2015-12-09 10:35:35 UTC (rev 193814)
+++ trunk/Tools/ChangeLog 2015-12-09 11:09:31 UTC (rev 193815)
@@ -1,3 +1,25 @@
+2015-12-09 Mario Sanchez Prada <ma...@endlessm.com>
+
+Refactored initialization code in LoadTrackingTest.
+
+Rubber-stamped by Carlos Garcia Campos.
+
+Small refactoring to make sure that the state of a LoadTrackingTest
+gets properly reset before loading new web content.
+
+* TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
+* TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
+(LoadTrackingTest::reset): New, refactored code from *load*() and go*()
+functions and reset the remaining local variables.
+(LoadTrackingTest::loadURI): Call reset();
+(LoadTrackingTest::loadHtml): Ditto.
+(LoadTrackingTest::loadPlainText): Ditto.
+(LoadTrackingTest::loadBytes): Ditto.
+(LoadTrackingTest::loadRequest): Ditto.
+(LoadTrackingTest::reload): Ditto.
+(LoadTrackingTest::goBack): Ditto.
+(LoadTrackingTest::goForward): Ditto.
+
2015-12-09 Gyuyoung Kim <gyuyoung@webkit.org>
[EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
Modified: trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp (193814 => 193815)
--- trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp 2015-12-09 10:35:35 UTC (rev 193814)
+++ trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp 2015-12-09 11:09:31 UTC (rev 193815)
@@ -180,64 +180,57 @@
void LoadTrackingTest::loadURI(const char* uri)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadURI(uri);
}
void LoadTrackingTest::loadHtml(const char* html, const char* baseURI)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadHtml(html, baseURI);
}
void LoadTrackingTest::loadPlainText(const char* plainText)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadPlainText(plainText);
}
void LoadTrackingTest::loadBytes(GBytes* bytes, const char* mimeType, const char* encoding, const char* baseURI)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadBytes(bytes, mimeType, encoding, baseURI);
}
void LoadTrackingTest::loadRequest(WebKitURIRequest* request)
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::loadRequest(request);
}
void LoadTrackingTest::reload()
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
webkit_web_view_reload(m_webView);
}
void LoadTrackingTest::goBack()
{
-m_loadEvents.clear();
-m_estimatedProgress = 0;
-m_error.reset();
+reset();
WebViewTest::goBack();
}
void LoadTrackingTest::goForward()
{
+reset();
+WebViewTest::goForward();
+}
+
+void LoadTrackingTest::reset()
+{
+m_runLoadUntilCompletion = false;
+m_loadFailed = false;
m_loadEvents.clear();
m_estimatedProgress = 0;
m_error.reset();
-WebViewTest::goForward();
}
Modified: trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h (193814 => 193815)
--- trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h 2015-12-09 10:35:35 UTC (rev 193814)
+++ trunk/Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h 2015-12-09 11:09:31 UTC (rev 193815)
@@ -48,6 +48,7 @@
void reload();
void goBack();
void goForward();
+void reset();
void setRedirectURI(const char* uri) { m_redirectURI = uri; }
___
webkit-changes mailing list
webkit-changes@l
[webkit-changes] [193830] trunk
Title: [193830] trunk Revision 193830 Author ma...@webkit.org Date 2015-12-09 06:52:46 -0800 (Wed, 09 Dec 2015) Log Message [GTK] Crash in WebProcess when loading large content with custom URI schemes https://bugs.webkit.org/show_bug.cgi?id=144262 Reviewed by Carlos Garcia Campos. Source/WebKit2: Properly handle scenarios where errors happen after reading the first chunk of data coming from the GInputStream provided by the application. * UIProcess/API/gtk/WebKitWebContextPrivate.h: * UIProcess/API/gtk/WebKitWebContext.cpp: (webkitWebContextIsLoadingCustomProtocol): New, checks whether a load is still in progress, after the startLoading method has been called. * UIProcess/API/gtk/WebKitURISchemeRequest.cpp: (webkitURISchemeRequestReadCallback): Early return if the stream has been cancelled on finish_error, so that we make sure we don't keep on reading the GInputStream after that point. (webkit_uri_scheme_request_finish_error): Don't send a didFailWithError message to the Network process if the load is not longer in progress. * Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp: (WebKit::CustomProtocolManagerImpl::didFailWithError): Handle the case where an error is notified from the UI process after the first chunk has been read. (WebKit::CustomProtocolManagerImpl::didReceiveResponse): Handle the case where data might no longer be available if an error happened even before this point. * WebProcess/soup/WebKitSoupRequestInputStream.h: * WebProcess/soup/WebKitSoupRequestInputStream.cpp: (webkitSoupRequestInputStreamDidFailWithError): Notify the custom GInputStream that we no longer want to keep reading data in chunks due to a specific error. (webkitSoupRequestInputStreamReadAsync): Early finish the GTask with a specific error whenever webkitSoupRequestInputStreamDidFailWithError() has been called. Tools: Added new unit test to check the additional scenarios we now handle for custom URI schemes. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (generateHTMLContent): New helper function to generate big enough content. (testWebContextURIScheme): New unit test. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURISchemeRequest.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h trunk/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp trunk/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (193829 => 193830) --- trunk/Source/WebKit2/ChangeLog 2015-12-09 14:46:11 UTC (rev 193829) +++ trunk/Source/WebKit2/ChangeLog 2015-12-09 14:52:46 UTC (rev 193830) @@ -1,3 +1,35 @@ +2015-12-09 Mario Sanchez Prada <ma...@endlessm.com> + +[GTK] Crash in WebProcess when loading large content with custom URI schemes +https://bugs.webkit.org/show_bug.cgi?id=144262 + +Reviewed by Carlos Garcia Campos. + +Properly handle scenarios where errors happen after reading the first +chunk of data coming from the GInputStream provided by the application. + +* UIProcess/API/gtk/WebKitWebContextPrivate.h: +* UIProcess/API/gtk/WebKitWebContext.cpp: +(webkitWebContextIsLoadingCustomProtocol): New, checks whether a load +is still in progress, after the startLoading method has been called. +* UIProcess/API/gtk/WebKitURISchemeRequest.cpp: +(webkitURISchemeRequestReadCallback): Early return if the stream has been +cancelled on finish_error, so that we make sure we don't keep on reading +the GInputStream after that point. +(webkit_uri_scheme_request_finish_error): Don't send a didFailWithError +message to the Network process if the load is not longer in progress. +* Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp: +(WebKit::CustomProtocolManagerImpl::didFailWithError): Handle the case where +an error is notified from the UI process after the first chunk has been read. +(WebKit::CustomProtocolManagerImpl::didReceiveResponse): Handle the case where +data might no longer be available if an error happened even before this point. +* WebProcess/soup/WebKitSoupRequestInputStream.h: +* WebProcess/soup/WebKitSoupRequestInputStream.cpp: +(webkitSoupRequestInputStreamDidFailWithError): Notify the custom GInputStream +that we no longer want to keep reading data in chunks due to a specific error. +(webkitSoupRequestInputStreamReadAsync): Early finish the GTask with a specific +error whenever webkitSoupRequestInputStreamDidFailWithError() has been called. + 2015-12-09 Ryuan Choi <ryuan.c...@n
[webkit-changes] [192103] trunk
Title: [192103] trunk
Revision 192103
Author ma...@webkit.org
Date 2015-11-06 08:25:50 -0800 (Fri, 06 Nov 2015)
Log Message
Layout Test accessibility/win/linked-elements.html is crashing on win debug
https://bugs.webkit.org/show_bug.cgi?id=150944
Reviewed by Chris Fleizach.
Source/WebCore:
Be more precise ASSERTing on textUnderElement, only checking that the render
tree is stable before using TextIteraror when in 'IncludeAllChildren' mode.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
LayoutTests:
Removed accessibility/win/linked-elements.html crashing expectation.
* platform/win/TestExpectations: Removed crashing expectation.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (192102 => 192103)
--- trunk/LayoutTests/ChangeLog 2015-11-06 14:51:48 UTC (rev 192102)
+++ trunk/LayoutTests/ChangeLog 2015-11-06 16:25:50 UTC (rev 192103)
@@ -1,3 +1,14 @@
+2015-11-06 Mario Sanchez Prada <ma...@endlessm.com>
+
+Layout Test accessibility/win/linked-elements.html is crashing on win debug
+https://bugs.webkit.org/show_bug.cgi?id=150944
+
+Reviewed by Chris Fleizach.
+
+Removed accessibility/win/linked-elements.html crashing expectation.
+
+* platform/win/TestExpectations: Removed crashing expectation.
+
2015-11-05 Sukolsak Sakshuwong <sukol...@gmail.com>
Layout Test js/intl-collator.html is crashing on win 7 debug
Modified: trunk/LayoutTests/platform/win/TestExpectations (192102 => 192103)
--- trunk/LayoutTests/platform/win/TestExpectations 2015-11-06 14:51:48 UTC (rev 192102)
+++ trunk/LayoutTests/platform/win/TestExpectations 2015-11-06 16:25:50 UTC (rev 192103)
@@ -3305,8 +3305,6 @@
webkit.org/b/147933 streams/reference-implementation/writable-stream-abort.html [ Pass Failure ]
-webkit.org/b/150944 [ Debug ] accessibility/win/linked-elements.html [ Crash ]
-
webkit.org/b/150946 [ Debug ] scrollbars/custom-scrollbar-appearance-property.html [ Crash ]
webkit.org/b/150948 [ Debug ] imported/blink/transitions/unprefixed-transform.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (192102 => 192103)
--- trunk/Source/WebCore/ChangeLog 2015-11-06 14:51:48 UTC (rev 192102)
+++ trunk/Source/WebCore/ChangeLog 2015-11-06 16:25:50 UTC (rev 192103)
@@ -1,3 +1,16 @@
+2015-11-06 Mario Sanchez Prada <ma...@endlessm.com>
+
+Layout Test accessibility/win/linked-elements.html is crashing on win debug
+https://bugs.webkit.org/show_bug.cgi?id=150944
+
+Reviewed by Chris Fleizach.
+
+Be more precise ASSERTing on textUnderElement, only checking that the render
+tree is stable before using TextIteraror when in 'IncludeAllChildren' mode.
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::textUnderElement):
+
2015-11-06 Carlos Garcia Campos <cgar...@igalia.com>
[GStreamer] Use MainThreadNotifier to send notifications to main thread in WebKitWebSourceGStreamer
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (192102 => 192103)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2015-11-06 14:51:48 UTC (rev 192102)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2015-11-06 16:25:50 UTC (rev 192103)
@@ -632,10 +632,12 @@
if (m_renderer->isBR())
return ASCIILiteral("\n");
+bool isRenderText = is(*m_renderer);
+
#if ENABLE(MATHML)
// Math operators create RenderText nodes on the fly that are not tied into the DOM in a reasonable way,
// so rangeOfContents does not work for them (nor does regular text selection).
-if (is(*m_renderer) && m_renderer->isAnonymous() && ancestorsOfType(*m_renderer).first())
+if (isRenderText && m_renderer->isAnonymous() && ancestorsOfType(*m_renderer).first())
return downcast(*m_renderer).text();
if (is(*m_renderer) && !m_renderer->isAnonymous())
return downcast(*m_renderer).element().textContent();
@@ -647,7 +649,8 @@
// We use a text iterator for text objects AND for those cases where we are
// explicitly asking for the full text under a given element.
-if (is(*m_renderer) || mode.childrenInclusion == AccessibilityTextUnderElementMode::TextUnderElementModeIncludeAllChildren) {
+bool shouldIncludeAllChildren = mode.childrenInclusion == AccessibilityTextUnderElementMode::TextUnderElementModeIncludeAllChildren;
+if (isRenderText || shouldIncludeAllChildren) {
// If possible, use a text iterator to get the text, so that whitespace
// is handled consistently.
Document* nodeDocument = nullptr;
@@ -687
[webkit-changes] [192022] trunk
Title: [192022] trunk
Revision 192022
Author ma...@webkit.org
Date 2015-11-04 06:46:19 -0800 (Wed, 04 Nov 2015)
Log Message
[AX] WebProcess from WebKitGtk+ 2.10.0 compiled in Debug mode hits ASSERT on textUnderElement
https://bugs.webkit.org/show_bug.cgi?id=150670
Source/WebCore:
Patch by Mario Sanchez Prada <ma...@webkit.org> on 2015-11-04
Reviewed by Chris Fleizach.
Move the ASSERTs stating that the render tree is stable before using the
TextIterator to their right place, in AccessibilityRenderObject, so that
we don't crash in debug builds in cases when this condition is irrelevant.
Test: accessibility/gtk/list-item-with-pseudo-element-crash.html
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement): Removed ASSERTs.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Added ASSERTs, but
only before calling plainText and using the right document for the node.
LayoutTests:
Patch by Joanmarie Diggs <jdi...@igalia.com> on 2015-11-04
Reviewed by Chris Fleizach.
* accessibility/list-item-with-pseudo-element-crash-expected.txt: Added.
* accessibility/list-item-with-pseudo-element-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Added Paths
trunk/LayoutTests/accessibility/list-item-with-pseudo-element-crash-expected.txt
trunk/LayoutTests/accessibility/list-item-with-pseudo-element-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (192021 => 192022)
--- trunk/LayoutTests/ChangeLog 2015-11-04 11:15:51 UTC (rev 192021)
+++ trunk/LayoutTests/ChangeLog 2015-11-04 14:46:19 UTC (rev 192022)
@@ -1,3 +1,13 @@
+2015-11-04 Joanmarie Diggs <jdi...@igalia.com>
+
+[AX] WebProcess from WebKitGtk+ 2.10.0 compiled in Debug mode hits ASSERT on textUnderElement
+https://bugs.webkit.org/show_bug.cgi?id=150670
+
+Reviewed by Chris Fleizach.
+
+* accessibility/list-item-with-pseudo-element-crash-expected.txt: Added.
+* accessibility/list-item-with-pseudo-element-crash.html: Added.
+
2015-11-04 Xabier Rodriguez Calvar <calva...@igalia.com>
[Streams API] Shield streams against user replacing the Promise constructor
Added: trunk/LayoutTests/accessibility/list-item-with-pseudo-element-crash-expected.txt (0 => 192022)
--- trunk/LayoutTests/accessibility/list-item-with-pseudo-element-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/list-item-with-pseudo-element-crash-expected.txt 2015-11-04 14:46:19 UTC (rev 192022)
@@ -0,0 +1,11 @@
+Foo
+BAR
+This verifies that list items with pseudo elements and styles do not trigger an assertion.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/accessibility/list-item-with-pseudo-element-crash.html (0 => 192022)
--- trunk/LayoutTests/accessibility/list-item-with-pseudo-element-crash.html (rev 0)
+++ trunk/LayoutTests/accessibility/list-item-with-pseudo-element-crash.html 2015-11-04 14:46:19 UTC (rev 192022)
@@ -0,0 +1,26 @@
+
+
+
+
+.item:before {content:""; }
+</style>
+</head>
+<body>
+<ul id="list" style="display:none;">
+<li id="item1" class="item" style="float:left;">Foo</li>
+<li id="item2" class="item" style="text-transform:uppercase;">Bar</li>
+</ul>
+<p id="description"></p>
+<div id="console"></div>
+<script>
+description("This verifies that list items with pseudo elements and styles do not trigger an assertion.");
+
+if (window.testRunner && window.accessibilityController) {
+var list = document.getElementById("list");
+list.style.display = "";
+}
+
+
[webkit-changes] [190855] trunk/Tools
Title: [190855] trunk/Tools Revision 190855 Author ma...@webkit.org Date 2015-10-12 08:30:32 -0700 (Mon, 12 Oct 2015) Log Message [GTK] Update jhbuild's version of harfbuzz https://bugs.webkit.org/show_bug.cgi?id=149749 Reviewed by Martin Robinson. Update harfbuzz to 0.9.35, following the lead of Debian Stable. * gtk/jhbuild.modules: Updated details for harfbuzz. Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (190854 => 190855) --- trunk/Tools/ChangeLog 2015-10-12 12:37:05 UTC (rev 190854) +++ trunk/Tools/ChangeLog 2015-10-12 15:30:32 UTC (rev 190855) @@ -1,5 +1,16 @@ 2015-10-12 Mario Sanchez Prada <ma...@endlessm.com> +[GTK] Update jhbuild's version of harfbuzz +https://bugs.webkit.org/show_bug.cgi?id=149749 + +Reviewed by Martin Robinson. + +Update harfbuzz to 0.9.35, following the lead of Debian Stable. + +* gtk/jhbuild.modules: Updated details for harfbuzz. + +2015-10-12 Mario Sanchez Prada <ma...@endlessm.com> + [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2 https://bugs.webkit.org/show_bug.cgi?id=150026 Modified: trunk/Tools/gtk/jhbuild.modules (190854 => 190855) --- trunk/Tools/gtk/jhbuild.modules 2015-10-12 12:37:05 UTC (rev 190854) +++ trunk/Tools/gtk/jhbuild.modules 2015-10-12 15:30:32 UTC (rev 190855) @@ -104,11 +104,12 @@ -+ repo="freedesktop.org" -hash="sha256:d07c0ffdbbbfdfbb6c65e73fe9c76466e87dbf04b094cbd0abf5fd7d571a4004" -md5sum="7e1990b79060e98e2d31f677a0ac9eed"> +hash="sha256:0aa1a8aba6f502321cf6fef3c9d2c73dde48389c5ed1d3615a7691944c2a06ed" +md5sum="531ee8650626ecddcd90b2a4637e31d4"> ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [190854] trunk/Tools
Title: [190854] trunk/Tools Revision 190854 Author ma...@webkit.org Date 2015-10-12 05:37:05 -0700 (Mon, 12 Oct 2015) Log Message [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2 https://bugs.webkit.org/show_bug.cgi?id=150026 Reviewed by Philippe Normand. Backport upstream patch from gst-plugins-bad so that the right version of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad gets compiled properly, avoiding crashes on runtime while running tests. * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added. * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad. Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules Added Paths trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch Diff Modified: trunk/Tools/ChangeLog (190853 => 190854) --- trunk/Tools/ChangeLog 2015-10-12 11:31:26 UTC (rev 190853) +++ trunk/Tools/ChangeLog 2015-10-12 12:37:05 UTC (rev 190854) @@ -1,3 +1,17 @@ +2015-10-12 Mario Sanchez Prada <ma...@endlessm.com> + +[GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2 +https://bugs.webkit.org/show_bug.cgi?id=150026 + +Reviewed by Philippe Normand. + +Backport upstream patch from gst-plugins-bad so that the right version +of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad +gets compiled properly, avoiding crashes on runtime while running tests. + +* gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added. +* gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad. + 2015-10-11 Myles C. Maxfield <mmaxfi...@apple.com> Test font-variant-* and font-feature-settings with mocked preinstalled fonts Modified: trunk/Tools/gtk/jhbuild.modules (190853 => 190854) --- trunk/Tools/gtk/jhbuild.modules 2015-10-12 11:31:26 UTC (rev 190853) +++ trunk/Tools/gtk/jhbuild.modules 2015-10-12 12:37:05 UTC (rev 190854) @@ -322,6 +322,7 @@ hash="sha256:e41b36105c0a13a2cb1ff9f559714e839b82dc3841484cd664790fb7947e55c7" md5sum="972c6e22dd2e44fcf0b04b9d810a56be"> + Added: trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch (0 => 190854) --- trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch (rev 0) +++ trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch 2015-10-12 12:37:05 UTC (rev 190854) @@ -0,0 +1,35 @@ +From 1f738ca5b8711ca5532a326cd646312e60484863 Mon Sep 17 00:00:00 2001 +From: Wim Taymans <wtaym...@redhat.com> +Date: Wed, 13 May 2015 16:23:26 +0200 +Subject: [PATCH] fix faad2 version check + +On fedora 22, the output of cpp inserts extra debug comments, which +makes our regexp for the faad2 version check fail. This in turn causes +it to compile with the wrong arguments passed which then causes stack +corruption and crashes. + +Fix this by only checking for the version (which should be by itself on +a single line). This is potentially less safe, it might be possible that +a similar string would appear in a later version in the header file. + +Fixes https://bugzilla.gnome.org/show_bug.cgi?id=748571 +--- + configure.ac | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/configure.ac b/configure.ac +index f5ce28c..d295253 100644 +--- a/configure.ac b/configure.ac +@@ -2008,9 +2008,9 @@ AG_GST_CHECK_FEATURE(FAAD, [AAC decoder plug-in], faad, [ + AC_MSG_CHECKING([Checking FAAD2 version in $faad_hdr]) + for minor in 10 9 8 7 6 5 0; do + if test x$faad2_minor_version = "x"; then +- AC_EGREP_CPP([GST_CHECK_FAAD_VERSION \"2\.$minor\"], [ ++ AC_EGREP_CPP([\"2\.$minor\"$], [ + #include <$faad_hdr> +- GST_CHECK_FAAD_VERSION FAAD2_VERSION ++ FAAD2_VERSION + ], [ + faad2_minor_version=$minor + ]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187854] trunk
Title: [187854] trunk
Revision 187854
Author ma...@webkit.org
Date 2015-08-04 05:58:10 -0700 (Tue, 04 Aug 2015)
Log Message
[GTK] Accelerated 2D Canvas enabled when cairo-gl is not available
https://bugs.webkit.org/show_bug.cgi?id=147625
Reviewed by Martin Robinson.
Do not set the CAIRO_COMPONENT_* CMake variables for cairo-gl
components unless they were actually found, not to accidentally
enable Accelerated 2D canvas, which would cause the build to fail.
* Source/cmake/FindCairoGL.cmake: Set this variables only when
pkg_check_modules() had actually found the relevant component.
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/FindCairoGL.cmake
Diff
Modified: trunk/ChangeLog (187853 => 187854)
--- trunk/ChangeLog 2015-08-04 12:54:09 UTC (rev 187853)
+++ trunk/ChangeLog 2015-08-04 12:58:10 UTC (rev 187854)
@@ -1,3 +1,17 @@
+2015-08-04 Mario Sanchez Prada ma...@endlessm.com
+
+[GTK] Accelerated 2D Canvas enabled when cairo-gl is not available
+https://bugs.webkit.org/show_bug.cgi?id=147625
+
+Reviewed by Martin Robinson.
+
+Do not set the CAIRO_COMPONENT_* CMake variables for cairo-gl
+components unless they were actually found, not to accidentally
+enable Accelerated 2D canvas, which would cause the build to fail.
+
+* Source/cmake/FindCairoGL.cmake: Set this variables only when
+pkg_check_modules() had actually found the relevant component.
+
2015-08-03 Csaba Osztrogonác o...@webkit.org
[CMake] Add an option to build AllInOne files
Modified: trunk/Source/cmake/FindCairoGL.cmake (187853 => 187854)
--- trunk/Source/cmake/FindCairoGL.cmake 2015-08-04 12:54:09 UTC (rev 187853)
+++ trunk/Source/cmake/FindCairoGL.cmake 2015-08-04 12:58:10 UTC (rev 187854)
@@ -37,8 +37,12 @@
string(TOUPPER ${_component} _UPPER_NAME)
string(REGEX REPLACE - _ _UPPER_NAME ${_UPPER_NAME})
pkg_check_modules(${_UPPER_NAME} ${_component})
-set(CAIROGL_INCLUDE_DIRS ${CAIROGL_INCLUDE_DIRS} ${_UPPER_NAME}_INCLUDE_DIRS)
-set(CAIROGL_LIBRARIES ${CAIROGL_LIBRARIES} ${_UPPER_NAME}_LIBRARIES)
+if (${_UPPER_NAME}_INCLUDE_DIRS)
+ set(CAIROGL_INCLUDE_DIRS ${CAIROGL_INCLUDE_DIRS} ${_UPPER_NAME}_INCLUDE_DIRS)
+endif ()
+if (${_UPPER_NAME}_LIBRARIES)
+ set(CAIROGL_LIBRARIES ${CAIROGL_LIBRARIES} ${_UPPER_NAME}_LIBRARIES)
+endif ()
endforeach ()
include(FindPackageHandleStandardArgs)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [186263] trunk/Source/WebCore
Title: [186263] trunk/Source/WebCore
Revision 186263
Author ma...@webkit.org
Date 2015-07-03 13:39:08 -0700 (Fri, 03 Jul 2015)
Log Message
Crash on xLarge memory allocation using bmalloc on 32bit systems
https://bugs.webkit.org/show_bug.cgi?id=146440
Reviewed by Gustavo Noronha Silva.
Disable the gcc's -ftree-sra optimization (automatically enabled
with -O1 and higher levels) for WebCore and 32bit Intel architectures,
as that causes the crash in bmalloc when allocating large amounts of
memory from the texture mapper's tiled backing store implementation.
* CMakeLists.txt: Pass -fno-free-sra to gcc on 32bit Intel architectures.
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (186262 => 186263)
--- trunk/Source/WebCore/CMakeLists.txt 2015-07-03 18:45:42 UTC (rev 186262)
+++ trunk/Source/WebCore/CMakeLists.txt 2015-07-03 20:39:08 UTC (rev 186263)
@@ -3574,6 +3574,14 @@
set_target_properties(WebCore PROPERTIES COMPILE_DEFINITIONS BUILDING_WebCore)
set_target_properties(WebCore PROPERTIES FOLDER WebCore)
+# The -ftree-sra optimization (implicit with -O2) causes crashes when
+# allocating large chunks of memory using bmalloc on Intel 32bit.
+# See https://bugs.webkit.org/show_bug.cgi?id=146440
+string(TOLOWER ${CMAKE_HOST_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_HOST_SYSTEM_PROCESSOR)
+if (CMAKE_COMPILER_IS_GNUCXX AND ${LOWERCASE_CMAKE_HOST_SYSTEM_PROCESSOR} MATCHES (i[3-6]86|x86)$)
+ADD_TARGET_PROPERTIES(WebCore COMPILE_FLAGS -fno-tree-sra)
+endif ()
+
if (WebCore_OUTPUT_NAME)
set_target_properties(WebCore PROPERTIES OUTPUT_NAME ${WebCore_OUTPUT_NAME})
endif ()
Modified: trunk/Source/WebCore/ChangeLog (186262 => 186263)
--- trunk/Source/WebCore/ChangeLog 2015-07-03 18:45:42 UTC (rev 186262)
+++ trunk/Source/WebCore/ChangeLog 2015-07-03 20:39:08 UTC (rev 186263)
@@ -1,3 +1,17 @@
+2015-07-03 Mario Sanchez Prada ma...@endlessm.com
+
+Crash on xLarge memory allocation using bmalloc on 32bit systems
+https://bugs.webkit.org/show_bug.cgi?id=146440
+
+Reviewed by Gustavo Noronha Silva.
+
+Disable the gcc's -ftree-sra optimization (automatically enabled
+with -O1 and higher levels) for WebCore and 32bit Intel architectures,
+as that causes the crash in bmalloc when allocating large amounts of
+memory from the texture mapper's tiled backing store implementation.
+
+* CMakeLists.txt: Pass -fno-free-sra to gcc on 32bit Intel architectures.
+
2015-07-03 Csaba Osztrogonác o...@webkit.org
Fix the !ENABLE(VIDEO) build after r186054
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183699] trunk/Tools
Title: [183699] trunk/Tools
Revision 183699
Author ma...@webkit.org
Date 2015-05-01 16:52:06 -0700 (Fri, 01 May 2015)
Log Message
Unreviewed, updated my list of email addresses.
* Scripts/webkitpy/common/config/contributors.json: Updated.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (183698 => 183699)
--- trunk/Tools/ChangeLog 2015-05-01 23:47:03 UTC (rev 183698)
+++ trunk/Tools/ChangeLog 2015-05-01 23:52:06 UTC (rev 183699)
@@ -1,3 +1,9 @@
+2015-05-01 Mario Sanchez Prada ma...@endlessm.com
+
+Unreviewed, updated my list of email addresses.
+
+* Scripts/webkitpy/common/config/contributors.json: Updated.
+
2015-05-01 Martin Robinson mrobin...@igalia.com
USE(...) macro should expect unprefixed variables
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (183698 => 183699)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2015-05-01 23:47:03 UTC (rev 183698)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2015-05-01 23:52:06 UTC (rev 183699)
@@ -4380,6 +4380,7 @@
Mario Sanchez Prada : {
emails : [
ma...@webkit.org,
+ma...@endlessm.com,
mario.pr...@samsung.com,
msanc...@igalia.com
],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174342] trunk/Tools
Title: [174342] trunk/Tools
Revision 174342
Author ma...@webkit.org
Date 2014-10-06 05:47:26 -0700 (Mon, 06 Oct 2014)
Log Message
Unreviewed, updated list of email addresses in contributors.json
* Scripts/webkitpy/common/config/contributors.json: Added my former
email address in Igalia, for the sake of completeness.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (174341 => 174342)
--- trunk/Tools/ChangeLog 2014-10-06 09:10:55 UTC (rev 174341)
+++ trunk/Tools/ChangeLog 2014-10-06 12:47:26 UTC (rev 174342)
@@ -1,3 +1,10 @@
+2014-10-06 Mario Sanchez Prada ma...@webkit.org
+
+Unreviewed, updated list of email addresses in contributors.json
+
+* Scripts/webkitpy/common/config/contributors.json: Added my former
+email address in Igalia, for the sake of completeness.
+
2014-10-06 Zsolt Borbely zsborbely.u-sze...@partner.samsung.com
Unreviewed, moved myself to the list of committers.
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (174341 => 174342)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-10-06 09:10:55 UTC (rev 174341)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-10-06 12:47:26 UTC (rev 174342)
@@ -4283,7 +4283,8 @@
Mario Sanchez Prada : {
emails : [
ma...@webkit.org,
-mario.pr...@samsung.com
+mario.pr...@samsung.com,
+msanc...@igalia.com
],
expertise : WebKitGTK+, Accessibility, WebKit2, Epiphany/WebKit Contributor,
nicks : [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171221] trunk/LayoutTests
Title: [171221] trunk/LayoutTests Revision 171221 Author ma...@webkit.org Date 2014-07-18 08:23:16 -0700 (Fri, 18 Jul 2014) Log Message [GTK] Unreviewed GTK gardening. Tests passing after SVN r171001 * platform/gtk/TestExpectations: Removed tests that are now passing. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (171220 => 171221) --- trunk/LayoutTests/ChangeLog 2014-07-18 14:12:26 UTC (rev 171220) +++ trunk/LayoutTests/ChangeLog 2014-07-18 15:23:16 UTC (rev 171221) @@ -1,3 +1,9 @@ +2014-07-18 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Unreviewed GTK gardening. Tests passing after SVN r171001 + +* platform/gtk/TestExpectations: Removed tests that are now passing. + 2014-07-18 Radu Stavila stav...@adobe.com REGRESSION (r169105): Crash in selection Modified: trunk/LayoutTests/platform/gtk/TestExpectations (171220 => 171221) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-07-18 14:12:26 UTC (rev 171220) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-07-18 15:23:16 UTC (rev 171221) @@ -1986,11 +1986,7 @@ webkit.org/b/132923 http/tests/security/cross-origin-plugin-private-browsing-toggled.html [ Failure ] -webkit.org/b/133146 css3/flexbox/flex-rounding.html [ Failure ] -webkit.org/b/133146 fast/css/image-resolution/image-resolution.html [ Failure ] -webkit.org/b/133146 fast/sub-pixel/client-width-height-snapping.html [ Failure ] webkit.org/b/133146 fast/sub-pixel/inline-block-with-padding.html [ Failure ] -webkit.org/b/133146 fast/sub-pixel/client-rect-has-subpixel-precision.html [ ImageOnlyFailure ] webkit.org/b/133147 fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius.html [ ImageOnlyFailure ] webkit.org/b/133147 fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171223] trunk/LayoutTests
Title: [171223] trunk/LayoutTests Revision 171223 Author ma...@webkit.org Date 2014-07-18 10:01:44 -0700 (Fri, 18 Jul 2014) Log Message [GTK] Unreviewed gardening. Removing failure expectations for tests now passing. * platform/gtk/TestExpectations: Removed failure expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (171222 => 171223) --- trunk/LayoutTests/ChangeLog 2014-07-18 16:53:51 UTC (rev 171222) +++ trunk/LayoutTests/ChangeLog 2014-07-18 17:01:44 UTC (rev 171223) @@ -1,3 +1,9 @@ +2014-07-18 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Unreviewed gardening. Removing failure expectations for tests now passing. + +* platform/gtk/TestExpectations: Removed failure expectations. + 2014-07-18 Commit Queue commit-qu...@webkit.org Unreviewed, rolling out r171218. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (171222 => 171223) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-07-18 16:53:51 UTC (rev 171222) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-07-18 17:01:44 UTC (rev 171223) @@ -1234,9 +1234,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=39160 webkit.org/b/39160 security/block-test-no-port.html [ Failure ] -# Apparently our WebkitTestRunner is disregarding window features? We open the window sized 800x600. -webkit.org/b/122535 fast/dom/Window/open-window-min-size.html [ Failure ] - # Unexplained failures Bug(GTK) editing/selection/5136696.html [ Failure ] Bug(GTK) editing/selection/inactive-selection.html [ Failure ] @@ -1775,11 +1772,6 @@ webkit.org/b/121905 fast/images/exif-orientation.html [ Failure ] -webkit.org/b/122147 fast/css/drop-shadow-viewport-height.html [ ImageOnlyFailure ] -webkit.org/b/122147 fast/css/drop-shadow-viewport-vmax.html [ ImageOnlyFailure ] -webkit.org/b/122147 fast/css/drop-shadow-viewport-vmin.html [ ImageOnlyFailure ] -webkit.org/b/122147 fast/css/drop-shadow-viewport-width.html [ ImageOnlyFailure ] - webkit.org/b/124360 media/video-canvas-drawing-output.html [ Failure ] webkit.org/b/124504 fast/text/break-word-pre-wrap.html [ ImageOnlyFailure ] @@ -1964,8 +1956,6 @@ webkit.org/b/132126 media/video-poster-background.html [ ImageOnlyFailure ] webkit.org/b/132126 media/restore-from-page-cache.html [ Crash ] -webkit.org/b/132232 fast/forms/textarea-placeholder-wrapping.html [ ImageOnlyFailure ] - webkit.org/b/132233 fast/regions/clip-to-padding-box-vertical-lr.html [ ImageOnlyFailure ] webkit.org/b/132234 fast/regions/wheel-scrollable-single-region.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170806] trunk/LayoutTests
Title: [170806] trunk/LayoutTests Revision 170806 Author mario.pr...@samsung.com Date 2014-07-04 08:31:57 -0700 (Fri, 04 Jul 2014) Log Message buildAccessibilityTree() needs to be removed from individual layout tests https://bugs.webkit.org/show_bug.cgi?id=95286 Reviewed by Chris Fleizach. Extracted two functions to 'dump' and 'touch' the accessibility hierarchies out of different layout tests and into a single file, living in LayoutTests/resources/accessibility-helper.js * resources/accessibility-helper.js: Added. (dumpAccessibilityTree): New, based on buildAccessibilityTree() for the cases where it was used to actually 'dump' it into the output. (touchAccessibilityTree): Same, but for the cases where we don't want to dump the accessibility tree, just to make sure is generated. Updated affected layout tests to use the newly added helper functions. * accessibility/adjacent-continuations-cause-assertion-failure.html: Updated. * accessibility/children-changed-sends-notification.html: Ditto. * accessibility/deleting-iframe-destroys-axcache.html: Ditto. * accessibility/div-within-anchors-causes-crash.html: Ditto. * accessibility/first-letter-text-transform-causes-crash.html: Ditto. * accessibility/image-map-update-parent-crash.html: Ditto. * accessibility/table-with-empty-thead-causes-crash.html: Ditto. * platform/efl/accessibility/media-emits-object-replacement.html: Ditto. * platform/gtk/accessibility/entry-and-password.html: Ditto. * platform/gtk/accessibility/media-emits-object-replacement.html: Ditto. * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Ditto. Updated Mac specific expectations not to print the End of test element. * platform/mac-wk2/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated. * platform/mac/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Ditto. * platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Ditto. * platform/mac/accessibility/div-within-anchors-causes-crash-expected.txt: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure.html trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt trunk/LayoutTests/accessibility/children-changed-sends-notification.html trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html trunk/LayoutTests/accessibility/div-within-anchors-causes-crash.html trunk/LayoutTests/accessibility/first-letter-text-transform-causes-crash.html trunk/LayoutTests/accessibility/image-map-update-parent-crash.html trunk/LayoutTests/accessibility/table-with-empty-thead-causes-crash.html trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement.html trunk/LayoutTests/platform/gtk/accessibility/entry-and-password.html trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement.html trunk/LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html trunk/LayoutTests/platform/mac/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt trunk/LayoutTests/platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt trunk/LayoutTests/platform/mac/accessibility/div-within-anchors-causes-crash-expected.txt trunk/LayoutTests/platform/mac-wk2/accessibility/deleting-iframe-destroys-axcache-expected.txt Added Paths trunk/LayoutTests/resources/accessibility-helper.js Diff Modified: trunk/LayoutTests/ChangeLog (170805 => 170806) --- trunk/LayoutTests/ChangeLog 2014-07-04 13:55:55 UTC (rev 170805) +++ trunk/LayoutTests/ChangeLog 2014-07-04 15:31:57 UTC (rev 170806) @@ -1,3 +1,41 @@ +2014-07-04 Mario Sanchez Prada mario.pr...@samsung.com + +buildAccessibilityTree() needs to be removed from individual layout tests +https://bugs.webkit.org/show_bug.cgi?id=95286 + +Reviewed by Chris Fleizach. + +Extracted two functions to 'dump' and 'touch' the accessibility +hierarchies out of different layout tests and into a single file, +living in LayoutTests/resources/accessibility-helper.js + +* resources/accessibility-helper.js: Added. +(dumpAccessibilityTree): New, based on buildAccessibilityTree() +for the cases where it was used to actually 'dump' it into the output. +(touchAccessibilityTree): Same, but for the cases where we don't +want to dump the accessibility tree, just to make sure is generated. + +Updated affected layout tests to use the newly added helper functions. + +* accessibility/adjacent-continuations-cause-assertion-failure.html: Updated. +* accessibility/children-changed-sends-notification.html: Ditto. +* accessibility/deleting-iframe-destroys-axcache.html: Ditto. +* accessibility/div-within-anchors-causes-crash.html: Ditto. +* accessibility/first-letter-text-transform-causes-crash.html: Ditto. +* accessibility/image-map-upd
[webkit-changes] [170704] trunk
Title: [170704] trunk
Revision 170704
Author mario.pr...@samsung.com
Date 2014-07-02 02:52:38 -0700 (Wed, 02 Jul 2014)
Log Message
REGRESSION(r170008): [GTK] Layout Tests fast/forms/option-constructor-selected.html and fast/forms/select-live-pseudo-selectors.html crash.
https://bugs.webkit.org/show_bug.cgi?id=134399
Reviewed by Chris Fleizach.
Source/WebCore:
Check that the value of optionIndex passed as a parameter is valid
before calling didUpdateActiveOption() over the item of the menu
list, to prevent crashes in platforms where renderers (and therefore
accessibility objects) might not be created for items at the time
of calling AccessibilityMenuList::didUpdateActiveOption().
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption): Added check.
LayoutTests:
Removing Crash expectations for two layout tests.
* platform/gtk/TestExpectations: Updated.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (170703 => 170704)
--- trunk/LayoutTests/ChangeLog 2014-07-02 08:22:01 UTC (rev 170703)
+++ trunk/LayoutTests/ChangeLog 2014-07-02 09:52:38 UTC (rev 170704)
@@ -1,3 +1,14 @@
+2014-07-02 Mario Sanchez Prada mario.pr...@samsung.com
+
+REGRESSION(r170008): [GTK] Layout Tests fast/forms/option-constructor-selected.html and fast/forms/select-live-pseudo-selectors.html crash.
+https://bugs.webkit.org/show_bug.cgi?id=134399
+
+Reviewed by Chris Fleizach.
+
+Removing Crash expectations for two layout tests.
+
+* platform/gtk/TestExpectations: Updated.
+
2014-07-01 Frédéric Wang fred.w...@free.fr
The OpenType MATH table is not read on Mac
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (170703 => 170704)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-07-02 08:22:01 UTC (rev 170703)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-07-02 09:52:38 UTC (rev 170704)
@@ -515,9 +515,6 @@
webkit.org/b/133797 fast/dom/NavigatorContentUtils/register-protocol-handler.html [ Crash ]
-webkit.org/b/134399 fast/forms/option-constructor-selected.html [ Crash ]
-webkit.org/b/134399 fast/forms/select-live-pseudo-selectors.html [ Crash ]
-
#
# End of Crashing tests
#
Modified: trunk/Source/WebCore/ChangeLog (170703 => 170704)
--- trunk/Source/WebCore/ChangeLog 2014-07-02 08:22:01 UTC (rev 170703)
+++ trunk/Source/WebCore/ChangeLog 2014-07-02 09:52:38 UTC (rev 170704)
@@ -1,3 +1,19 @@
+2014-07-02 Mario Sanchez Prada mario.pr...@samsung.com
+
+REGRESSION(r170008): [GTK] Layout Tests fast/forms/option-constructor-selected.html and fast/forms/select-live-pseudo-selectors.html crash.
+https://bugs.webkit.org/show_bug.cgi?id=134399
+
+Reviewed by Chris Fleizach.
+
+Check that the value of optionIndex passed as a parameter is valid
+before calling didUpdateActiveOption() over the item of the menu
+list, to prevent crashes in platforms where renderers (and therefore
+accessibility objects) might not be created for items at the time
+of calling AccessibilityMenuList::didUpdateActiveOption().
+
+* accessibility/AccessibilityMenuList.cpp:
+(WebCore::AccessibilityMenuList::didUpdateActiveOption): Added check.
+
2014-07-02 Carlos Garcia Campos cgar...@igalia.com
[GTK] Do not add forward declaration of class struct for interfaces
Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp (170703 => 170704)
--- trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp 2014-07-02 08:22:01 UTC (rev 170703)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp 2014-07-02 09:52:38 UTC (rev 170704)
@@ -120,7 +120,8 @@
// before asking it to update its active option, or it will read invalid memory.
// You can reproduce the issue in the GTK+ port by removing this check and running
// accessibility/insert-selected-option-into-select-causes-crash.html (will crash).
-if (childObjects[0]-isMenuListPopup() childObjects[0]-children().size()) {
+int popupChildrenSize = static_castint(childObjects[0]-children().size());
+if (childObjects[0]-isMenuListPopup() optionIndex = 0 optionIndex popupChildrenSize) {
if (AccessibilityMenuListPopup* popup = toAccessibilityMenuListPopup(childObjects[0].get()))
popup-didUpdateActiveOption(optionIndex);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170145] trunk/LayoutTests
Title: [170145] trunk/LayoutTests
Revision 170145
Author mario.pr...@samsung.com
Date 2014-06-19 02:14:52 -0700 (Thu, 19 Jun 2014)
Log Message
Unreviewed GTK gardening.
Updated text expectations after r170138.
* platform/gtk/accessibility/image-map2-expected.txt: Updated.
* platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Updated.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt
trunk/LayoutTests/platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (170144 => 170145)
--- trunk/LayoutTests/ChangeLog 2014-06-19 07:25:18 UTC (rev 170144)
+++ trunk/LayoutTests/ChangeLog 2014-06-19 09:14:52 UTC (rev 170145)
@@ -1,3 +1,12 @@
+2014-06-19 Mario Sanchez Prada mario.pr...@samsung.com
+
+Unreviewed GTK gardening.
+
+Updated text expectations after r170138.
+
+* platform/gtk/accessibility/image-map2-expected.txt: Updated.
+* platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Updated.
+
2014-06-19 Rohit Kumar kumar.ro...@samsung.com
[EFL] Add expectations for failing svg/wicd/rightsizing-grid.xhtml layout test
Modified: trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt (170144 => 170145)
--- trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt 2014-06-19 07:25:18 UTC (rev 170144)
+++ trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt 2014-06-19 09:14:52 UTC (rev 170145)
@@ -26,6 +26,7 @@
AXSize: { 123.00, 62.00 }
AXTitle:
AXDescription: Link1
+AXValue:
AXFocusable: 0
AXFocused: 0
AXSelectable: 0
@@ -45,6 +46,7 @@
AXSize: { 122.00, 14.00 }
AXTitle:
AXDescription: Link2
+AXValue:
AXFocusable: 0
AXFocused: 0
AXSelectable: 0
Modified: trunk/LayoutTests/platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt (170144 => 170145)
--- trunk/LayoutTests/platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-06-19 07:25:18 UTC (rev 170144)
+++ trunk/LayoutTests/platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt 2014-06-19 09:14:52 UTC (rev 170145)
@@ -433,6 +433,7 @@
label:
role: group
liveRegionAtomic: true
+liveRegionRelevant: additions,text
liveRegionStatus: assertive
parentNodeId: exists
@@ -441,6 +442,7 @@
label:
role: group
liveRegionAtomic: false
+liveRegionRelevant: additions,text
liveRegionStatus: polite
parentNodeId: exists
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [170008] trunk
Title: [170008] trunk Revision 170008 Author mario.pr...@samsung.com Date 2014-06-16 08:01:06 -0700 (Mon, 16 Jun 2014) Log Message [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard https://bugs.webkit.org/show_bug.cgi?id=133512 Reviewed by Chris Fleizach. Source/WebCore: Make sure that AccessibilityMenuList objects update their active option when it changes, which will send a platform-dependent accessibility-related notification when needed. Test: accessibility/combo-box-collapsed-selection-changed.html * rendering/RenderMenuList.cpp: (RenderMenuList::didUpdateActiveOption): Keep the out-of-bounds check for the index passed but don't avoid updating the option for the associated AccessibilityMenuList object if the selected list item does not have a renderer, because that could be the case for cases where the popup (and its elements) would be rendered in the UI Process (e.g. GTK+ port uses GtkMenu and GtkMenuItem for that). * accessibility/AccessibilityMenuList.cpp: (WebCore::AccessibilityMenuList::didUpdateActiveOption): Ensure that the AccessibilityMenuListPopup object for a given menu list has accessibility children before updating its active option. Tools: Added support for connecting to AtkSelection's 'selection-changed' signal, and print it out as AXSelectedChildrenChanged in the tests. Also removed some dead code, that became useless after r169487. * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated. LayoutTests: Re-implemented test for combo boxes in terms of addNotificationListener() instead of using the (already deprecated) logAccessibilityEvents method, and made the test cross platform (as the fix is not platform specific). * accessibility/combo-box-collapsed-selection-changed.html: Implemented based on the former gtk-only test, and made it cross-platform. * accessibility/combo-box-collapsed-selection-changed-expected.txt: New. * platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed. * platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed. Updated expectation for test that checks that a notification is sent when navigating through a multiselection list box, now that we are actually printing such a notification. * accessibility/multiselect-list-reports-active-option-expected.txt: Updated. Removed two expected failures from TestExpectations for tests that are now passing, one for the combo box test mentioned above and another one for a test that is passing as well now, after applying this fix: accessibility/menu-list-sends-change-notification.html * platform/gtk/TestExpectations: Removed two 'failure' expectations. * platform/mac/TestExpectations: Skip accessiblity test timing out, probably because those kind of notifications while navigating a combo box are not needed in the Mac. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp trunk/Source/WebCore/rendering/RenderMenuList.cpp trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp Added Paths trunk/LayoutTests/accessibility/combo-box-collapsed-selection-changed-expected.txt trunk/LayoutTests/accessibility/combo-box-collapsed-selection-changed.html Removed Paths trunk/LayoutTests/platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt trunk/LayoutTests/platform/gtk/accessibility/combo-box-collapsed-selection-changed.html Diff Modified: trunk/LayoutTests/ChangeLog (170007 => 170008) --- trunk/LayoutTests/ChangeLog 2014-06-16 12:17:10 UTC (rev 170007) +++ trunk/LayoutTests/ChangeLog 2014-06-16 15:01:06 UTC (rev 170008) @@ -1,3 +1,36 @@ +2014-06-16 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard +https://bugs.webkit.org/show_bug.cgi?id=133512 + +Reviewed by Chris Fleizach. + +Re-implemented test for combo boxes in terms of addNotificationListener() +instead of using the (already deprecated) logAccessibilityEvents method, +and made the test cross platform (as the fix is not platform specific). + +* accessibility/combo-box-collapsed-selection-changed.html: +Implemented based on the former gtk-only test, and made it cross-platform. +* accessibility/combo-box-collapsed-selection-changed-expected.txt: New. +* platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed. +* platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed. + +Updated expectation for t
[webkit-changes] [169646] trunk/LayoutTests
Title: [169646] trunk/LayoutTests
Revision 169646
Author mario.pr...@samsung.com
Date 2014-06-06 09:19:54 -0700 (Fri, 06 Jun 2014)
Log Message
[GTK] Layout Test accessibility/table-fallback-roles-expose-element-attributes.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133519
Reviewed by Chris Fleizach.
Adapted test to play nicely with the different types of
accessibility hierarchies exposed for Mac and ATK.
* accessibility/table-fallback-roles-expose-element-attributes.html:
Updated text to print information of cells from every platform but
only print information of their children in the Mac.
* accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
Updated expectation to match ATK platforms (GTK EFL).
* platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
Copied from LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt.
* platform/gtk/TestExpectations: Removed expected failure.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt
trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html
trunk/LayoutTests/platform/gtk/TestExpectations
Added Paths
trunk/LayoutTests/platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (169645 => 169646)
--- trunk/LayoutTests/ChangeLog 2014-06-06 15:49:08 UTC (rev 169645)
+++ trunk/LayoutTests/ChangeLog 2014-06-06 16:19:54 UTC (rev 169646)
@@ -1,3 +1,24 @@
+2014-06-06 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Layout Test accessibility/table-fallback-roles-expose-element-attributes.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=133519
+
+Reviewed by Chris Fleizach.
+
+Adapted test to play nicely with the different types of
+accessibility hierarchies exposed for Mac and ATK.
+
+* accessibility/table-fallback-roles-expose-element-attributes.html:
+Updated text to print information of cells from every platform but
+only print information of their children in the Mac.
+
+* accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
+Updated expectation to match ATK platforms (GTK EFL).
+* platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
+Copied from LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt.
+
+* platform/gtk/TestExpectations: Removed expected failure.
+
2014-06-06 Frédéric Wang fred.w...@free.fr
Add test references for horizontal stretchy operators.
Modified: trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt (169645 => 169646)
--- trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt 2014-06-06 15:49:08 UTC (rev 169645)
+++ trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt 2014-06-06 16:19:54 UTC (rev 169646)
@@ -6,11 +6,11 @@
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-cellChild: AXRole: AXStaticText, AXValue: item1
+cell: AXRole: AXCell, AXValue: item1
-cellChild: AXRole: AXStaticText, AXValue: item1
+cell: AXRole: AXCell, AXValue: item1
-cellChild: AXRole: AXStaticText, AXValue: item1
+cell: AXRole: AXCell, AXValue: item1
PASS successfullyParsed is true
Modified: trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html (169645 => 169646)
--- trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html 2014-06-06 15:49:08 UTC (rev 169645)
+++ trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html 2014-06-06 16:19:54 UTC (rev 169646)
@@ -28,11 +28,14 @@
for (var k = 1; k 4; k++) {
var grid = accessibilityController.accessibleElementById(grid + k);
- var cellChild = grid.cellForColumnAndRow(0, 0).childAtIndex(0);
- debug(cellChild: + cellChild.role + , + cellChild.stringValue + \n);
+ var cell = grid.cellForColumnAndRow(0, 0);
+ debug(cell: + cell.role + , + cell.stringValue + \n);
+ if (accessibilityController.platformName != atk) {
+ var cellChild = cell.childAtIndex(0);
+ debug(cellChild: + cellChild.role + , + cellChild.stringValue + \n);
+ }
}
}
-
/script
script src=""
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (169645 => 169646)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-06-06 15:49:08 UTC (rev 169645)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-06-06 16:19:54 UTC (rev 169646)
@@ -1972,8 +1972,6 @@
webkit.org/b/133147 fast/shapes/shape-outside-floats/shape-outside-floats-inset-rou
[webkit-changes] [169572] trunk/Source/WebCore
Title: [169572] trunk/Source/WebCore
Revision 169572
Author mario.pr...@samsung.com
Date 2014-06-03 14:38:00 -0700 (Tue, 03 Jun 2014)
Log Message
[ATK] accessibility/textarea-selected-text-range.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133479
Reviewed by Chris Fleizach.
Implement atk_text_set_caret_offset() in terms of
atk_text_set_selection() for zero-length selections.
No new tests needed, the following test should just start
passing again now: accessibility/textarea-selected-text-range.html.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextSetCaretOffset): Reimplemented this function
in terms of webkitAccessibleTextSetSelection().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (169571 => 169572)
--- trunk/Source/WebCore/ChangeLog 2014-06-03 21:37:06 UTC (rev 169571)
+++ trunk/Source/WebCore/ChangeLog 2014-06-03 21:38:00 UTC (rev 169572)
@@ -1,3 +1,20 @@
+2014-06-03 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] accessibility/textarea-selected-text-range.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=133479
+
+Reviewed by Chris Fleizach.
+
+Implement atk_text_set_caret_offset() in terms of
+atk_text_set_selection() for zero-length selections.
+
+No new tests needed, the following test should just start
+passing again now: accessibility/textarea-selected-text-range.html.
+
+* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+(webkitAccessibleTextSetCaretOffset): Reimplemented this function
+in terms of webkitAccessibleTextSetSelection().
+
2014-06-03 Alex Christensen achristen...@webkit.org
Corrected arm64 assertion in css jit.
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (169571 => 169572)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2014-06-03 21:37:06 UTC (rev 169571)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2014-06-03 21:38:00 UTC (rev 169572)
@@ -1233,29 +1233,9 @@
static gboolean webkitAccessibleTextSetCaretOffset(AtkText* text, gint offset)
{
-g_return_val_if_fail(ATK_TEXT(text), FALSE);
-returnValIfWebKitAccessibleIsInvalid(WEBKIT_ACCESSIBLE(text), FALSE);
-
-AccessibilityObject* coreObject = core(text);
-if (!coreObject-isAccessibilityRenderObject())
-return FALSE;
-
-// We need to adjust the offsets for the list item marker.
-int offsetAdjustment = offsetAdjustmentForListItem(coreObject);
-if (offsetAdjustment) {
-if (offset offsetAdjustment)
-return FALSE;
-
-offset = atkOffsetToWebCoreOffset(text, offset);
-}
-
-PlainTextRange textRange(offset, 0);
-VisiblePositionRange range = coreObject-visiblePositionRangeForRange(textRange);
-if (range.isNull())
-return FALSE;
-
-coreObject-setSelectedVisiblePositionRange(range);
-return TRUE;
+// Internally, setting the caret offset is equivalent to set a zero-length
+// selection, so delegate in that implementation and void duplicated code.
+return webkitAccessibleTextSetSelection(text, 0, offset, offset);
}
#if ATK_CHECK_VERSION(2, 10, 0)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [169485] trunk/Tools
Title: [169485] trunk/Tools
Revision 169485
Author mario.pr...@samsung.com
Date 2014-05-30 08:20:26 -0700 (Fri, 30 May 2014)
Log Message
[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
https://bugs.webkit.org/show_bug.cgi?id=132280
Rubber stamped by Carlos Garcia Campos.
Fix two small issues with previous patch (r169483), that caused some tests to break.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
duplicated entry.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Diff
Modified: trunk/Tools/ChangeLog (169484 => 169485)
--- trunk/Tools/ChangeLog 2014-05-30 14:16:54 UTC (rev 169484)
+++ trunk/Tools/ChangeLog 2014-05-30 15:20:26 UTC (rev 169485)
@@ -1,3 +1,18 @@
+2014-05-30 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
+https://bugs.webkit.org/show_bug.cgi?id=132280
+
+Rubber stamped by Carlos Garcia Campos.
+
+Fix two small issues with previous patch (r169483), that caused some tests to break.
+
+* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
+duplicated entry.
+* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+(WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
+
2014-05-30 Jarek Czekalski jarekc...@poczta.onet.pl
[ATK] Added new accessibility signal: text-caret-moved.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp (169484 => 169485)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp 2014-05-30 14:16:54 UTC (rev 169484)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp 2014-05-30 15:20:26 UTC (rev 169485)
@@ -251,7 +251,6 @@
const char* signalNames[] = {
ATK:AtkObject:state-change,
-ATK:AtkObject:state-change,
ATK:AtkObject:focus-event,
ATK:AtkObject:active-descendant-changed,
ATK:AtkObject:children-changed,
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (169484 => 169485)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2014-05-30 14:16:54 UTC (rev 169484)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2014-05-30 15:20:26 UTC (rev 169485)
@@ -1585,7 +1585,7 @@
if (!ATK_IS_TEXT(m_element.get()))
return false;
-if (length)
+if (!length)
return atk_text_set_caret_offset(ATK_TEXT(m_element.get()), location);
return atk_text_set_selection(ATK_TEXT(m_element.get()), 0, location, location + length);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [169487] trunk
Title: [169487] trunk Revision 169487 Author mario.pr...@samsung.com Date 2014-05-30 09:47:06 -0700 (Fri, 30 May 2014) Log Message [ATK] Deprecate usage of logAccessibilityEvents() in layout tests https://bugs.webkit.org/show_bug.cgi?id=132280 Reviewed by Chris Fleizach. Tools: Remove implementation of logAccessibilityEvents() for ATK based ports, as this has proved to be a flaky method of checking that ATK events are being properly emitted. Instead, it's better to use the addNotificationListener() functions and provide a JS callback to check that the right events are being emmitted from the tests. * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: (WTR::AccessibilityController::logAccessibilityEvents): Replaced with dummy implementation. * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed LayoutTests: Removed 36 flaky expectations from TestExpectations for tests that were ocassionally showing the output of logAccessibilityEvents() even if they did not make use of that feature (thus the flakiness). * platform/gtk/TestExpectations: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h Diff Modified: trunk/LayoutTests/ChangeLog (169486 => 169487) --- trunk/LayoutTests/ChangeLog 2014-05-30 15:43:55 UTC (rev 169486) +++ trunk/LayoutTests/ChangeLog 2014-05-30 16:47:06 UTC (rev 169487) @@ -1,3 +1,16 @@ +2014-05-30 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] Deprecate usage of logAccessibilityEvents() in layout tests +https://bugs.webkit.org/show_bug.cgi?id=132280 + +Reviewed by Chris Fleizach. + +Removed 36 flaky expectations from TestExpectations for tests that +were ocassionally showing the output of logAccessibilityEvents() +even if they did not make use of that feature (thus the flakiness). + +* platform/gtk/TestExpectations: Updated. + 2014-05-30 Jarek Czekalski jarekc...@poczta.onet.pl [ATK] Convert caret offset tests from testatk.c. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (169486 => 169487) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-05-30 15:43:55 UTC (rev 169486) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-05-30 16:47:06 UTC (rev 169487) @@ -823,44 +823,6 @@ webkit.org/b/132277 fast/images/imagemap-case.html [ Failure Pass ] webkit.org/b/132277 fast/images/imagemap-dynamic-area-updates.html [ Failure Pass ] -#Accessibility -webkit.org/b/132280 platform/gtk/accessibility/aria-table-hierarchy.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/aria-toggle-button-role.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/button-accessible-name.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/caret-browsing-select-focus.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/caret-browsing-text-focus.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/entry-and-password.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/input-slider.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/list-items-always-exposed.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/media-controls-panel-title.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/media-emits-object-replacement.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/name-from-label.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/object-with-title.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/remapped-aria-crash.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/spans-paragraphs-and-divs.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/spans.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/table-hierarchy.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/text-at-offset-embedded-objects.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/text-at-offset-newlines.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/text-at-offset-preformatted.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/text-at-offset-simple.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/text-at-offset-special-chars.html [ Failure Pass ] -webkit.org/b/132280 platform/gtk/accessibility/text-at-offset-textare
[webkit-changes] [169488] trunk/LayoutTests
Title: [169488] trunk/LayoutTests
Revision 169488
Author mario.pr...@samsung.com
Date 2014-05-30 09:49:26 -0700 (Fri, 30 May 2014)
Log Message
[GTK] Don't use logAccessibilityEvents() in aria-slider-required-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=133405
Reviewed by Chris Fleizach.
Change the test to use addNotificationListener() instead.
* platform/gtk/TestExpectations: Removed failure expectation
* platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated
* platform/gtk/accessibility/aria-slider-required-attributes.html: Updated
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html
Diff
Modified: trunk/LayoutTests/ChangeLog (169487 => 169488)
--- trunk/LayoutTests/ChangeLog 2014-05-30 16:47:06 UTC (rev 169487)
+++ trunk/LayoutTests/ChangeLog 2014-05-30 16:49:26 UTC (rev 169488)
@@ -1,5 +1,18 @@
2014-05-30 Mario Sanchez Prada mario.pr...@samsung.com
+[GTK] Don't use logAccessibilityEvents() in aria-slider-required-attributes.html
+https://bugs.webkit.org/show_bug.cgi?id=133405
+
+Reviewed by Chris Fleizach.
+
+Change the test to use addNotificationListener() instead.
+
+* platform/gtk/TestExpectations: Removed failure expectation
+* platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated
+* platform/gtk/accessibility/aria-slider-required-attributes.html: Updated
+
+2014-05-30 Mario Sanchez Prada mario.pr...@samsung.com
+
[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
https://bugs.webkit.org/show_bug.cgi?id=132280
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (169487 => 169488)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-05-30 16:47:06 UTC (rev 169487)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-05-30 16:49:26 UTC (rev 169488)
@@ -1641,7 +1641,6 @@
webkit.org/b/113772 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html [ Failure ]
webkit.org/b/113772 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html [ Failure ]
-webkit.org/b/114259 platform/gtk/accessibility/aria-slider-required-attributes.html [ Failure ]
webkit.org/b/114259 platform/gtk/accessibility/combo-box-collapsed-selection-changed.html [ Failure ]
webkit.org/b/115025 fast/events/constructors/mouse-event-constructor.html [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt (169487 => 169488)
--- trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt 2014-05-30 16:47:06 UTC (rev 169487)
+++ trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt 2014-05-30 16:49:26 UTC (rev 169488)
@@ -1,18 +1,16 @@
-Accessibility object emitted state-change:busy = 0 / Name: (No name) / Role: 80
-Accessibility object emitted property-change:accessible-value / Name: (No name) / Role: 50
-Accessibility object emitted property-change:accessible-value / Name: (No name) / Role: 50
This tests the exposure of attributes for an ARIA slider.
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-PASS successfullyParsed is true
-
-TEST COMPLETE
PASS axSlider.role is 'AXRole: AXSlider'
PASS axSlider.intValue is 50
PASS axSlider.minValue is 0
PASS axSlider.maxValue is 100
PASS axSlider.intValue is 75
PASS axSlider.intValue is 35
+PASS valueChangedNotifications is 2
+PASS successfullyParsed is true
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html (169487 => 169488)
--- trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html 2014-05-30 16:47:06 UTC (rev 169487)
+++ trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html 2014-05-30 16:49:26 UTC (rev 169488)
@@ -1,19 +1,34 @@
!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
html
head
+script src=""
+/head
+body id=body
+div role=application
+ span id=slider tabindex=0 role=slider aria-valuemin=0 aria-valuemax=100 aria-valuenow=50/span
+/div
+p id=description/p
+div id=console/div
script
+window.jsTestIsAsync = true;
-function finishTest()
-{
-testRunner.notifyDone();
+description(This tests the exposure of attributes for an ARIA slider.);
+
+var valueChangedNotifications = 0;
+
+function notificationCallback(element, notification) {
+if (element.role == AXRole: AXSlider notification == AXValueChanged)
+valueChangedNotifications++;
}
-function runTest()
-{
+if (window.testRunner window.accessibilityController) {
+testRunner.dumpAsText();
+
slider = document
[webkit-changes] [167009] trunk/LayoutTests
Title: [167009] trunk/LayoutTests
Revision 167009
Author mario.pr...@samsung.com
Date 2014-04-09 02:39:03 -0700 (Wed, 09 Apr 2014)
Log Message
Unreviewed gardening for GTK.
Updated test expectations after r166175, which removed an hr
from the original test accessibility/lists.html.
* platform/gtk/accessibility/lists-expected.txt: Updated
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (167008 => 167009)
--- trunk/LayoutTests/ChangeLog 2014-04-09 08:28:06 UTC (rev 167008)
+++ trunk/LayoutTests/ChangeLog 2014-04-09 09:39:03 UTC (rev 167009)
@@ -1,3 +1,12 @@
+2014-04-09 Mario Sanchez Prada mario.pr...@samsung.com
+
+Unreviewed gardening for GTK.
+
+Updated test expectations after r166175, which removed an hr
+from the original test accessibility/lists.html.
+
+* platform/gtk/accessibility/lists-expected.txt: Updated
+
2014-04-09 Alexey Proskuryakov a...@apple.com
[WK2] HTTP authentication regression tests fail
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (167008 => 167009)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-09 08:28:06 UTC (rev 167008)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-09 09:39:03 UTC (rev 167009)
@@ -1059,7 +1059,6 @@
webkit.org/b/131294 accessibility/adjacent-continuations-cause-assertion-failure.html [ Failure ]
webkit.org/b/131294 accessibility/deleting-iframe-destroys-axcache.html [ Failure ]
webkit.org/b/131294 accessibility/div-within-anchors-causes-crash.html [ Failure ]
-webkit.org/b/131294 accessibility/lists.html [ Failure ]
webkit.org/b/131294 platform/gtk/accessibility/entry-and-password.html [ Failure ]
webkit.org/b/131294 platform/gtk/accessibility/media-emits-object-replacement.html [ Failure ]
webkit.org/b/131294 platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt (167008 => 167009)
--- trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt 2014-04-09 08:28:06 UTC (rev 167008)
+++ trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt 2014-04-09 09:39:03 UTC (rev 167009)
@@ -69,10 +69,10 @@
AXParent: AXWebArea
AXChildren: 0
AXPosition: { 8.00, 217.00 }
-AXSize: { 784.00, 51.00 }
+AXSize: { 784.00, 68.00 }
AXTitle:
AXDescription:
-AXValue: \n\n\n
+AXValue: \n\n\n\n
AXFocusable: 0
AXFocused: 0
AXSelectable: 0
@@ -84,44 +84,6 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
-AXRole: AXSeparator
-AXParent: AXWebArea
-AXChildren: 0
-AXPosition: { 8.00, 276.00 }
-AXSize: { 784.00, 2.00 }
-AXTitle:
-AXDescription:
-AXValue:
-AXFocusable: 0
-AXFocused: 0
-AXSelectable: 0
-AXSelected: 0
-AXMultiSelectable: 0
-AXEnabled: 1
-AXExpanded: 0
-AXRequired: 0
-AXChecked: 0
-AXPlatformAttributes: toolkit:WebKitGtk
-
-AXRole: AXGroup
-AXParent: AXWebArea
-AXChildren: 0
-AXPosition: { 8.00, 286.00 }
-AXSize: { 784.00, 17.00 }
-AXTitle:
-AXDescription:
-AXValue: \n
-AXFocusable: 0
-AXFocused: 0
-AXSelectable: 0
-AXSelected: 0
-AXMultiSelectable: 0
-AXEnabled: 1
-AXExpanded: 0
-AXRequired: 0
-AXChecked: 0
-AXPlatformAttributes: toolkit:WebKitGtk
-
AXRole: AXListItem
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167011] trunk
Title: [167011] trunk
Revision 167011
Author mario.pr...@samsung.com
Date 2014-04-09 08:05:58 -0700 (Wed, 09 Apr 2014)
Log Message
[AX][GTK] No new lines in some AX tests output
https://bugs.webkit.org/show_bug.cgi?id=131294
Reviewed by Martin Robinson.
Source/WebCore:
Do not implement Hypetext or AtkText for the WebArea. Those
interfaces will be implemented by the containers (automatically
generated or not) for the different parts of the DOM and the
render subtree under this element anyway.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getInterfaceMaskFromObject): Make sure we don't apply
WAIHypertext nor WAIText to objects with role WebAreaRole.
LayoutTests:
Removed failure expectations for tests now passing.
* platform/gtk/TestExpectations: Updated.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (167010 => 167011)
--- trunk/LayoutTests/ChangeLog 2014-04-09 09:48:26 UTC (rev 167010)
+++ trunk/LayoutTests/ChangeLog 2014-04-09 15:05:58 UTC (rev 167011)
@@ -1,5 +1,16 @@
2014-04-09 Mario Sanchez Prada mario.pr...@samsung.com
+[AX][GTK] No new lines in some AX tests output
+https://bugs.webkit.org/show_bug.cgi?id=131294
+
+Reviewed by Martin Robinson.
+
+Removed failure expectations for tests now passing.
+
+* platform/gtk/TestExpectations: Updated.
+
+2014-04-09 Mario Sanchez Prada mario.pr...@samsung.com
+
Unreviewed gardening for GTK.
Updated test expectations after r166175, which removed an hr
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (167010 => 167011)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-09 09:48:26 UTC (rev 167010)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-09 15:05:58 UTC (rev 167011)
@@ -1055,14 +1055,6 @@
webkit.org/b/120401 fast/events [ Skip ]
webkit.org/b/120401 editing/selection [ Skip ]
-# AX tests failing
-webkit.org/b/131294 accessibility/adjacent-continuations-cause-assertion-failure.html [ Failure ]
-webkit.org/b/131294 accessibility/deleting-iframe-destroys-axcache.html [ Failure ]
-webkit.org/b/131294 accessibility/div-within-anchors-causes-crash.html [ Failure ]
-webkit.org/b/131294 platform/gtk/accessibility/entry-and-password.html [ Failure ]
-webkit.org/b/131294 platform/gtk/accessibility/media-emits-object-replacement.html [ Failure ]
-webkit.org/b/131294 platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html [ Failure ]
-
webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ]
webkit.org/b/131380 accessibility/children-changed-sends-notification.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (167010 => 167011)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 09:48:26 UTC (rev 167010)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 15:05:58 UTC (rev 167011)
@@ -1,3 +1,19 @@
+2014-04-09 Mario Sanchez Prada mario.pr...@samsung.com
+
+[AX][GTK] No new lines in some AX tests output
+https://bugs.webkit.org/show_bug.cgi?id=131294
+
+Reviewed by Martin Robinson.
+
+Do not implement Hypetext or AtkText for the WebArea. Those
+interfaces will be implemented by the containers (automatically
+generated or not) for the different parts of the DOM and the
+render subtree under this element anyway.
+
+* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+(getInterfaceMaskFromObject): Make sure we don't apply
+WAIHypertext nor WAIText to objects with role WebAreaRole.
+
2014-04-08 Conrad Shultz conrad_shu...@apple.com
nil should only be used for objects
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (167010 => 167011)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-04-09 09:48:26 UTC (rev 167010)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-04-09 15:05:58 UTC (rev 167011)
@@ -1155,29 +1155,27 @@
if (coreObject-isLink() || (renderer renderer-isReplaced()))
interfaceMask |= 1 WAIHyperlink;
-// Text Editable Text
+// Text, Editable Text Hypertext
if (role == StaticTextRole || coreObject-isMenuListOption())
interfaceMask |= 1 WAIText;
-else {
-if (coreObject-isTextControl()) {
-interfaceMask |= 1 WAIText;
-if (!coreObject-isReadOnly())
-interfaceMask |= 1 WAIEditableText;
-} else {
-if (role != TableRole) {
-interfaceMask |= 1 WAIHypertext;
-if ((renderer renderer-childrenInline()) || roleIsTextType(role))
-interfaceMask |= 1 WAIText;
-}
+else if (coreObject-isTextControl()) {
+interfaceMask |
[webkit-changes] [167012] trunk
Title: [167012] trunk
Revision 167012
Author mario.pr...@samsung.com
Date 2014-04-09 08:08:17 -0700 (Wed, 09 Apr 2014)
Log Message
[GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
https://bugs.webkit.org/show_bug.cgi?id=131380
Reviewed by Chris Fleizach.
Source/WebCore:
Don't emit signals for added objects that we know won't be exposed
to the accessibility hierarchy (e.g. static text).
* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::attachWrapper): Add extra check and early return.
LayoutTests:
Updated TestExpectations file and update layout test that was not
correctly written, and expecting the signals in the wrong order.
* platform/gtk/TestExpectations: Removed failure expectations.
* accessibility/children-changed-sends-notification.html: Updated
test to make sure we touch the accessibility tree after adding a
button so we get the 'add' signal at the right moment.
* accessibility/children-changed-sends-notification-expected.txt:
Updated expectations to expect the 'add' and 'remove' signals in
the right order.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt
trunk/LayoutTests/accessibility/children-changed-sends-notification.html
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (167011 => 167012)
--- trunk/LayoutTests/ChangeLog 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/LayoutTests/ChangeLog 2014-04-09 15:08:17 UTC (rev 167012)
@@ -1,5 +1,25 @@
2014-04-09 Mario Sanchez Prada mario.pr...@samsung.com
+[GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
+https://bugs.webkit.org/show_bug.cgi?id=131380
+
+Reviewed by Chris Fleizach.
+
+Updated TestExpectations file and update layout test that was not
+correctly written, and expecting the signals in the wrong order.
+
+* platform/gtk/TestExpectations: Removed failure expectations.
+
+* accessibility/children-changed-sends-notification.html: Updated
+test to make sure we touch the accessibility tree after adding a
+button so we get the 'add' signal at the right moment.
+
+* accessibility/children-changed-sends-notification-expected.txt:
+Updated expectations to expect the 'add' and 'remove' signals in
+the right order.
+
+2014-04-09 Mario Sanchez Prada mario.pr...@samsung.com
+
[AX][GTK] No new lines in some AX tests output
https://bugs.webkit.org/show_bug.cgi?id=131294
Modified: trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt (167011 => 167012)
--- trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2014-04-09 15:08:17 UTC (rev 167012)
@@ -6,10 +6,10 @@
Plain text paragraph
End of test
+PARAGRAPH notification: AXChildrenAdded
+GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
PARAGRAPH notification: AXChildrenRemoved
GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph
-PARAGRAPH notification: AXChildrenAdded
-GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
PASS paragraphNotificationCount is globalNotificationCount
PASS globalNotificationCount is 2
PASS successfullyParsed is true
Modified: trunk/LayoutTests/accessibility/children-changed-sends-notification.html (167011 => 167012)
--- trunk/LayoutTests/accessibility/children-changed-sends-notification.html 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/LayoutTests/accessibility/children-changed-sends-notification.html 2014-04-09 15:08:17 UTC (rev 167012)
@@ -57,6 +57,9 @@
window.newChild = document.createElement('button');
par.appendChild(newChild);
+// Ensure the new child is added.
+touchAccessibilityTree(axWebArea);
+
window.setTimeout(function() {
var link = document.getElementById('testLink');
link.style.display = 'none';
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (167011 => 167012)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-09 15:05:58 UTC (rev 167011)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-09 15:08:17 UTC (rev 167012)
@@ -1057,9 +1057,6 @@
webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ]
-webkit.org/b/131380 accessibility/children-changed-sends-notification.html [ Failure ]
-webkit.org/b/131380 accessibility/notification-listeners.html [ Failure ]
-
# svg/ failures
webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ]
webkit.org/b/4245
[webkit-changes] [166577] trunk/Tools
Title: [166577] trunk/Tools Revision 166577 Author mario.pr...@samsung.com Date 2014-04-01 05:36:48 -0700 (Tue, 01 Apr 2014) Log Message [GTK] Running minibrowser with url crashes in debug build https://bugs.webkit.org/show_bug.cgi?id=130492 Reviewed by Martin Robinson. Update uri-scheme test not to use invalid URIs in it, so we don't get a mistmatch when comparing the original URI stored in the test class with the one returned by the WebKitWebView. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextURIScheme): Update the test. Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp Diff Modified: trunk/Tools/ChangeLog (166576 => 166577) --- trunk/Tools/ChangeLog 2014-04-01 11:38:37 UTC (rev 166576) +++ trunk/Tools/ChangeLog 2014-04-01 12:36:48 UTC (rev 166577) @@ -1,3 +1,17 @@ +2014-04-01 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Running minibrowser with url crashes in debug build +https://bugs.webkit.org/show_bug.cgi?id=130492 + +Reviewed by Martin Robinson. + +Update uri-scheme test not to use invalid URIs in it, so we +don't get a mistmatch when comparing the original URI stored in +the test class with the one returned by the WebKitWebView. + +* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: +(testWebContextURIScheme): Update the test. + 2014-04-01 Mihai Tica mit...@adobe.com Unreviewed: Add myself as a commiter to the contributors list. Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp (166576 => 166577) --- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp 2014-04-01 11:38:37 UTC (rev 166576) +++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp 2014-04-01 12:36:48 UTC (rev 166577) @@ -195,7 +195,7 @@ g_assert(!strncmp(mainResourceData, kBarHTML, mainResourceDataSize)); test-registerURISchemeHandler(echo, kEchoHTMLFormat, -1, text/html); -test-loadURI(echo:hello world); +test-loadURI(echo:hello-world); test-waitUntilLoadFinished(); GUniquePtrchar echoHTML(g_strdup_printf(kEchoHTMLFormat, webkit_uri_scheme_request_get_path(test-m_uriSchemeRequest.get(; mainResourceDataSize = 0; @@ -205,7 +205,7 @@ test-registerURISchemeHandler(nomime, kBarHTML, -1, 0); test-m_loadEvents.clear(); -test-loadURI(nomime:foo bar); +test-loadURI(nomime:foo-bar); test-waitUntilLoadFinished(); g_assert(test-m_loadEvents.contains(LoadTrackingTest::ProvisionalLoadFailed)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166406] trunk/Source/WebCore
Title: [166406] trunk/Source/WebCore
Revision 166406
Author mario.pr...@samsung.com
Date 2014-03-28 08:34:03 -0700 (Fri, 28 Mar 2014)
Log Message
[GTK] Geoclue2 providers won't work after reloading
https://bugs.webkit.org/show_bug.cgi?id=130898
Reviewed by Martin Robinson.
Don't reuse the Geoclue2 client proxy between different calls to
startPosition(), and create a new client proxy each time instead.
* platform/geoclue/GeolocationProviderGeoclue2.cpp:
(GeolocationProviderGeoclue::startUpdating): Don't reuse the
client proxy, by always calling geoclue_manager_call_get_client().
(GeolocationProviderGeoclue::stopUpdating): Disconnect from the
'location-updated' signal and dispose the client proxy.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/geoclue/GeolocationProviderGeoclue2.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166405 => 166406)
--- trunk/Source/WebCore/ChangeLog 2014-03-28 14:18:46 UTC (rev 166405)
+++ trunk/Source/WebCore/ChangeLog 2014-03-28 15:34:03 UTC (rev 166406)
@@ -1,3 +1,19 @@
+2014-03-28 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Geoclue2 providers won't work after reloading
+https://bugs.webkit.org/show_bug.cgi?id=130898
+
+Reviewed by Martin Robinson.
+
+Don't reuse the Geoclue2 client proxy between different calls to
+startPosition(), and create a new client proxy each time instead.
+
+* platform/geoclue/GeolocationProviderGeoclue2.cpp:
+(GeolocationProviderGeoclue::startUpdating): Don't reuse the
+client proxy, by always calling geoclue_manager_call_get_client().
+(GeolocationProviderGeoclue::stopUpdating): Disconnect from the
+'location-updated' signal and dispose the client proxy.
+
2014-03-28 Diego Pino Garcia dp...@igalia.com
[GTK] Too many redirects visiting www.globalforestwatch.org
Modified: trunk/Source/WebCore/platform/geoclue/GeolocationProviderGeoclue2.cpp (166405 => 166406)
--- trunk/Source/WebCore/platform/geoclue/GeolocationProviderGeoclue2.cpp 2014-03-28 14:18:46 UTC (rev 166405)
+++ trunk/Source/WebCore/platform/geoclue/GeolocationProviderGeoclue2.cpp 2014-03-28 15:34:03 UTC (rev 166406)
@@ -73,18 +73,16 @@
return;
}
-if (!m_clientProxy) {
-geoclue_manager_call_get_client(m_managerProxy.get(), nullptr, reinterpret_castGAsyncReadyCallback(getGeoclueClientCallback), this);
-return;
-}
-
-startGeoclueClient();
+geoclue_manager_call_get_client(m_managerProxy.get(), nullptr, reinterpret_castGAsyncReadyCallback(getGeoclueClientCallback), this);
}
void GeolocationProviderGeoclue::stopUpdating()
{
-if (m_clientProxy)
+if (m_clientProxy) {
geoclue_client_call_stop(m_clientProxy.get(), nullptr, nullptr, nullptr);
+g_signal_handlers_disconnect_by_func(m_clientProxy.get(), reinterpret_castgpointer(locationUpdatedCallback), this);
+m_clientProxy = nullptr;
+}
m_isUpdating = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166410] trunk/Source/WebKit2
Title: [166410] trunk/Source/WebKit2 Revision 166410 Author mario.pr...@samsung.com Date 2014-03-28 09:42:02 -0700 (Fri, 28 Mar 2014) Log Message [GTK] Running minibrowser with url crashes in debug build https://bugs.webkit.org/show_bug.cgi?id=130492 Reviewed by Martin Robinson. Use the ResourceRequest(const URL url) constructor, instead of the one taking a String, to call WebPageProxy::loadRequest(), so we ensure that the passed URI is correctly constructed. * UIProcess/API/gtk/WebKitWebView.cpp: (webkit_web_view_load_uri): Create an URL out of a SoupURI and use that to create a ResourceRequest to pass to loadRequest(). Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (166409 => 166410) --- trunk/Source/WebKit2/ChangeLog 2014-03-28 16:18:01 UTC (rev 166409) +++ trunk/Source/WebKit2/ChangeLog 2014-03-28 16:42:02 UTC (rev 166410) @@ -1,3 +1,18 @@ +2014-03-28 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Running minibrowser with url crashes in debug build +https://bugs.webkit.org/show_bug.cgi?id=130492 + +Reviewed by Martin Robinson. + +Use the ResourceRequest(const URL url) constructor, instead of the +one taking a String, to call WebPageProxy::loadRequest(), so we +ensure that the passed URI is correctly constructed. + +* UIProcess/API/gtk/WebKitWebView.cpp: +(webkit_web_view_load_uri): Create an URL out of a SoupURI and +use that to create a ResourceRequest to pass to loadRequest(). + 2014-03-27 Pratik Solanki psola...@apple.com [iOS WebKit2] Tweak cache sizes for iOS Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (166409 => 166410) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-03-28 16:18:01 UTC (rev 166409) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-03-28 16:42:02 UTC (rev 166410) @@ -2004,7 +2004,8 @@ g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView)); g_return_if_fail(uri); -getPage(webView)-loadRequest(String::fromUTF8(uri)); +GUniquePtrSoupURI soupURI(soup_uri_new(uri)); +getPage(webView)-loadRequest(URL(soupURI.get())); } /** ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [165588] trunk
Title: [165588] trunk Revision 165588 Author mario.pr...@samsung.com Date 2014-03-13 18:51:45 -0700 (Thu, 13 Mar 2014) Log Message [CMake] Failure to link with older installations of WebP https://bugs.webkit.org/show_bug.cgi?id=130195 Reviewed by Gustavo Noronha Silva. Fix the issue by using a temporary variable as the output parameter to check_include_files(), setting WEBP_FOUND accordingly later. * Source/cmake/FindWebP.cmake: Avoid reusing the WEBP_FOUND variable in check_include_files(), as it will lead to misleading results (will always be FALSE). Use a temporary variable instead and explicitly set WEBP_FOUND to TRUE later if needed. Modified Paths trunk/ChangeLog trunk/Source/cmake/FindWebP.cmake Diff Modified: trunk/ChangeLog (165587 => 165588) --- trunk/ChangeLog 2014-03-14 01:41:31 UTC (rev 165587) +++ trunk/ChangeLog 2014-03-14 01:51:45 UTC (rev 165588) @@ -1,3 +1,18 @@ +2014-03-13 Mario Sanchez Prada mario.pr...@samsung.com + +[CMake] Failure to link with older installations of WebP +https://bugs.webkit.org/show_bug.cgi?id=130195 + +Reviewed by Gustavo Noronha Silva. + +Fix the issue by using a temporary variable as the output parameter +to check_include_files(), setting WEBP_FOUND accordingly later. + +* Source/cmake/FindWebP.cmake: Avoid reusing the WEBP_FOUND +variable in check_include_files(), as it will lead to misleading +results (will always be FALSE). Use a temporary variable instead +and explicitly set WEBP_FOUND to TRUE later if needed. + 2014-03-12 Martin Robinson mrobin...@igalia.com [CMake] Changes to the bindings generator Perl modules do not trigger regeneration of bindings Modified: trunk/Source/cmake/FindWebP.cmake (165587 => 165588) --- trunk/Source/cmake/FindWebP.cmake 2014-03-14 01:41:31 UTC (rev 165587) +++ trunk/Source/cmake/FindWebP.cmake 2014-03-14 01:51:45 UTC (rev 165588) @@ -35,9 +35,10 @@ if (NOT(WEBP_FOUND)) # Older installations of libwebp do not install a pkgconfig file, so we fall # back to a manual search for a libwebp header file. -check_include_files(webp/decode.h WEBP_FOUND) -if (WEBP_FOUND) +check_include_files(webp/decode.h WEBP_FOUND_HEADER) +if (WEBP_FOUND_HEADER) set(WEBP_LIBRARIES -lwebp) +set(WEBP_FOUND TRUE) endif () endif () ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [164867] trunk
Title: [164867] trunk
Revision 164867
Author mario.pr...@samsung.com
Date 2014-02-28 10:12:52 -0800 (Fri, 28 Feb 2014)
Log Message
paragraphs with different directionality in textarea with unicode-bidi: plaintext are aligned the same
https://bugs.webkit.org/show_bug.cgi?id=71194
Reviewed by David Hyatt.
Merged from Blink r157263 by igo...@sisa.samsung.com
https://src.chromium.org/viewvc/blink?revision=157263view=revision
Source/WebCore:
In the css3-text spec (http://www.w3.org/TR/css3-text/#bidi-linebox):
The start and end edges of a line box are determined by the inline
base direction of the line box. In most cases, this is given by
its containing block's computed ‘direction’. However if its
containing block has ‘unicode-bidi: plaintext’, the inline base
direction the line box must be determined by the base direction of
the bidi paragraph to which it belongs: that is, the bidi
paragraph for which the line box holds content.
This patch just implements the behavior described above modifying
updateLogicalWidthForAlignment and setting the bidi level of the
RootInlineBox.
* rendering/RenderBlockFlow.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateLogicalWidthForAlignment):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::deleteEllipsisLineBoxes):
(WebCore::RenderBlockFlow::checkLinesForTextOverflow):
(WebCore::RenderBlockFlow::startAlignedOffsetForLine):
LayoutTests:
Modified expectations for two layout tests to make them conforming to the spec.
* fast/text/international/unicode-bidi-plaintext-expected.html:
* platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
* platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text/international/unicode-bidi-plaintext-expected.html
trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt
trunk/LayoutTests/platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (164866 => 164867)
--- trunk/LayoutTests/ChangeLog 2014-02-28 18:09:24 UTC (rev 164866)
+++ trunk/LayoutTests/ChangeLog 2014-02-28 18:12:52 UTC (rev 164867)
@@ -1,3 +1,19 @@
+2014-02-28 Mario Sanchez Prada mario.pr...@samsung.com
+
+paragraphs with different directionality in textarea with unicode-bidi: plaintext are aligned the same
+https://bugs.webkit.org/show_bug.cgi?id=71194
+
+Reviewed by David Hyatt.
+
+Merged from Blink r157263 by igo...@sisa.samsung.com
+https://src.chromium.org/viewvc/blink?revision=157263view=revision
+
+Modified expectations for two layout tests to make them conforming to the spec.
+
+* fast/text/international/unicode-bidi-plaintext-expected.html:
+* platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
+* platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
+
2014-02-28 Jochen Eisinger joc...@chromium.org
Update meta-referrer behavior for invalid policies
Modified: trunk/LayoutTests/fast/text/international/unicode-bidi-plaintext-expected.html (164866 => 164867)
--- trunk/LayoutTests/fast/text/international/unicode-bidi-plaintext-expected.html 2014-02-28 18:09:24 UTC (rev 164866)
+++ trunk/LayoutTests/fast/text/international/unicode-bidi-plaintext-expected.html 2014-02-28 18:12:52 UTC (rev 164867)
@@ -2,24 +2,34 @@
html
head
meta http-equiv=Content-Type content=text/html; charset=utf-8
+style
+.rightAligned {
+ display: block;
+ text-align: right;
+}
+/style
/head
body
divThis tests proper handling of unicode-bidi: plaintext. You should not see any red./div
div dir=ltr
!hello.br
-span dir=rtl
+span class=rightAligned dir=rtl
!שלום.
-/spanbr
+/span
span dir=ltr
hello, לוי!
/spanbr
-span dir=rtl
-שלום, WebKit!/spanbr
-pre
+span class=rightAligned dir=rtl
+שלום, WebKit!/span
+pre style=margin-bottom: 0px
a
(
-!WebKit ,שלום
+/pre
+pre dir=rtl style=margin: 0px
+שלום, WebKit!
+/pre
+pre style=margin-top: 0px
hello, לוי!
)
/pre
Modified: trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt (164866 => 164867)
--- trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt 2014-02-28 18:09:24 UTC (rev 164866)
+++ trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt 2014-02-28 18:12:52 UTC (rev 164867)
@@ -16,36 +16,36 @@
layer at (10
[webkit-changes] [164096] trunk/Source/JavaScriptCore
Title: [164096] trunk/Source/_javascript_Core Revision 164096 Author mario.pr...@samsung.com Date 2014-02-14 03:10:28 -0800 (Fri, 14 Feb 2014) Log Message Cleaning the JSStaticScopeObject files left behind after renaming their objects to JSNameScope https://bugs.webkit.org/show_bug.cgi?id=127595 Patch by Andres Gomez ago...@igalia.com on 2014-02-14 Reviewed by Mario Sanchez Prada. JSStaticScopeObject was renamed to JSNameScope and removed long ago but the files were left behind empty and the CMake compilation in need of its existance. Now, we are definitely getting rid of them. * CMakeLists.txt: * runtime/JSStaticScopeObject.cpp: Removed. * runtime/JSStaticScopeObject.h: Removed. Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog Removed Paths trunk/Source/_javascript_Core/runtime/JSStaticScopeObject.cpp trunk/Source/_javascript_Core/runtime/JSStaticScopeObject.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (164095 => 164096) --- trunk/Source/_javascript_Core/CMakeLists.txt 2014-02-14 09:47:10 UTC (rev 164095) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2014-02-14 11:10:28 UTC (rev 164096) @@ -409,7 +409,6 @@ runtime/JSSegmentedVariableObject.cpp runtime/JSSet.cpp runtime/JSSetIterator.cpp -runtime/JSStaticScopeObject.cpp runtime/JSString.cpp runtime/JSStringJoiner.cpp runtime/JSSymbolTableObject.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (164095 => 164096) --- trunk/Source/_javascript_Core/ChangeLog 2014-02-14 09:47:10 UTC (rev 164095) +++ trunk/Source/_javascript_Core/ChangeLog 2014-02-14 11:10:28 UTC (rev 164096) @@ -1,3 +1,19 @@ +2014-02-14 Andres Gomez ago...@igalia.com + +Cleaning the JSStaticScopeObject files left behind after renaming their objects to JSNameScope +https://bugs.webkit.org/show_bug.cgi?id=127595 + +Reviewed by Mario Sanchez Prada. + +JSStaticScopeObject was renamed to JSNameScope and removed long +ago but the files were left behind empty and the CMake compilation +in need of its existance. Now, we are definitely getting rid of +them. + +* CMakeLists.txt: +* runtime/JSStaticScopeObject.cpp: Removed. +* runtime/JSStaticScopeObject.h: Removed. + 2014-02-13 Filip Pizlo fpi...@apple.com Kill some of the last vestiges of the C++ interpreter's PICs Deleted: trunk/Source/_javascript_Core/runtime/JSStaticScopeObject.cpp ( => ) Deleted: trunk/Source/_javascript_Core/runtime/JSStaticScopeObject.h === ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161966] trunk
Title: [161966] trunk Revision 161966 Author mario.pr...@samsung.com Date 2014-01-14 07:45:32 -0800 (Tue, 14 Jan 2014) Log Message [ATK] AXChildrenChanged notification handling is a performance black hole https://bugs.webkit.org/show_bug.cgi?id=126970 Reviewed by Gustavo Noronha Silva. Source/WebCore: Remove code that is causing a huge performance problem when loading big pages, just to be able to emit the children-changed:add signal at the exact time a child is added. This removal does not imply that the signal won't be ever emitted, just that it will be emitted a bit later (when the new child is asynchronously added to the tree), which should be good enough anyway for Accessible Technologies, without impacting perfformance in such a negative way. * accessibility/atk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): Removed extremely expensive referring loop when AXChildrenChanged is received. LayoutTests: Because of the removal of the referring test when AXChildrenChanged is received, the children-changed:add signal is now emitted later, so we need to reorder the expectations. * accessibility/children-changed-sends-notification-expected.txt: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (161965 => 161966) --- trunk/LayoutTests/ChangeLog 2014-01-14 15:41:32 UTC (rev 161965) +++ trunk/LayoutTests/ChangeLog 2014-01-14 15:45:32 UTC (rev 161966) @@ -1,3 +1,16 @@ +2014-01-14 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] AXChildrenChanged notification handling is a performance black hole +https://bugs.webkit.org/show_bug.cgi?id=126970 + +Reviewed by Gustavo Noronha Silva. + +Because of the removal of the referring test when +AXChildrenChanged is received, the children-changed:add signal is +now emitted later, so we need to reorder the expectations. + +* accessibility/children-changed-sends-notification-expected.txt: Updated. + 2014-01-14 Mihai Tica mit...@adobe.com [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend Modified: trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt (161965 => 161966) --- trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2014-01-14 15:41:32 UTC (rev 161965) +++ trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt 2014-01-14 15:45:32 UTC (rev 161966) @@ -6,10 +6,10 @@ Plain text paragraph End of test +PARAGRAPH notification: AXChildrenRemoved +GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph PARAGRAPH notification: AXChildrenAdded GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph -PARAGRAPH notification: AXChildrenRemoved -GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph PASS paragraphNotificationCount is globalNotificationCount PASS globalNotificationCount is 2 PASS successfullyParsed is true Modified: trunk/Source/WebCore/ChangeLog (161965 => 161966) --- trunk/Source/WebCore/ChangeLog 2014-01-14 15:41:32 UTC (rev 161965) +++ trunk/Source/WebCore/ChangeLog 2014-01-14 15:45:32 UTC (rev 161966) @@ -1,3 +1,24 @@ +2014-01-14 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] AXChildrenChanged notification handling is a performance black hole +https://bugs.webkit.org/show_bug.cgi?id=126970 + +Reviewed by Gustavo Noronha Silva. + +Remove code that is causing a huge performance problem when +loading big pages, just to be able to emit the children-changed:add +signal at the exact time a child is added. + +This removal does not imply that the signal won't be ever emitted, +just that it will be emitted a bit later (when the new child is +asynchronously added to the tree), which should be good enough +anyway for Accessible Technologies, without impacting perfformance +in such a negative way. + +* accessibility/atk/AXObjectCacheAtk.cpp: +(WebCore::AXObjectCache::postPlatformNotification): Removed +extremely expensive referring loop when AXChildrenChanged is received. + 2014-01-14 Mihai Tica mit...@adobe.com [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend Modified: trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (161965 => 161966) --- trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-01-14 15:41:32 UTC (rev 161965) +++ trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-01-14 15:45:32 UTC (rev 161966) @@ -193,16 +193,6 @@ atk_object_notify_state_change(axObject, ATK_STATE_CHECKED, coreObject-isChecked());
[webkit-changes] [161666] trunk
trunk/Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (161665 => 161666)
--- trunk/LayoutTests/ChangeLog 2014-01-10 21:08:51 UTC (rev 161665)
+++ trunk/LayoutTests/ChangeLog 2014-01-10 21:10:57 UTC (rev 161666)
@@ -1,3 +1,19 @@
+2014-01-10 Mario Sanchez Prada mario.pr...@samsung.com
+
+Move platformName property from testRunner to accessibilityController
+https://bugs.webkit.org/show_bug.cgi?id=126689
+
+Reviewed by Chris Fleizach.
+
+Updated tests and expectations affected by the move of
+platformName from TestRunner to AccessibilityController.
+
+* accessibility/canvas-fallback-content.html:
+* accessibility/ignore-spacer-elements.html:
+* accessibility/platform-name.html:
+* platform/efl/accessibility/platform-name-expected.txt:
+* platform/gtk/accessibility/platform-name-expected.txt:
+
2014-01-10 Anders Carlsson ander...@apple.com
Remove supportMultipleWindows setting
Modified: trunk/LayoutTests/accessibility/canvas-fallback-content.html (161665 => 161666)
--- trunk/LayoutTests/accessibility/canvas-fallback-content.html 2014-01-10 21:08:51 UTC (rev 161665)
+++ trunk/LayoutTests/accessibility/canvas-fallback-content.html 2014-01-10 21:10:57 UTC (rev 161666)
@@ -52,7 +52,7 @@
debug();
}
-var comboBoxRole = (testRunner.platformName == gtk || testRunner.platformName == efl) ? AXRole: AXComboBox : AXRole: AXPopUpButton;
+var comboBoxRole = accessibilityController.platformName == atk ? AXRole: AXComboBox : AXRole: AXPopUpButton;
// Check rendered controls.
check(link1, AXRole: AXLink);
Modified: trunk/LayoutTests/accessibility/ignore-spacer-elements.html (161665 => 161666)
--- trunk/LayoutTests/accessibility/ignore-spacer-elements.html 2014-01-10 21:08:51 UTC (rev 161665)
+++ trunk/LayoutTests/accessibility/ignore-spacer-elements.html 2014-01-10 21:10:57 UTC (rev 161666)
@@ -25,7 +25,7 @@
var container = accessibilityController.focusedElement.childAtIndex(0);
// The Gtk and EFL ports ATs expect the bold inline text to not have accessible objects.
-var expectedCount = (testRunner.platformName == gtk || testRunner.platformName == efl) ? 2 : 4;
+var expectedCount = accessibilityController.platformName == atk ? 2 : 4;
if (container.childrenCount == expectedCount) {
result.innerText += Test passed\n;
}
Modified: trunk/LayoutTests/accessibility/platform-name.html (161665 => 161666)
--- trunk/LayoutTests/accessibility/platform-name.html 2014-01-10 21:08:51 UTC (rev 161665)
+++ trunk/LayoutTests/accessibility/platform-name.html 2014-01-10 21:10:57 UTC (rev 161666)
@@ -8,10 +8,10 @@
div id=console/div
script
description(This test just prints the name of the current platform.);
-if (window.testRunner) {
+if (window.testRunner window.accessibilityController) {
testRunner.dumpAsText();
- debug(Platform name: + testRunner.platformName);
+ debug(Platform name: + accessibilityController.platformName);
}
/script
script src=""
Modified: trunk/LayoutTests/platform/efl/accessibility/platform-name-expected.txt (161665 => 161666)
--- trunk/LayoutTests/platform/efl/accessibility/platform-name-expected.txt 2014-01-10 21:08:51 UTC (rev 161665)
+++ trunk/LayoutTests/platform/efl/accessibility/platform-name-expected.txt 2014-01-10 21:10:57 UTC (rev 161666)
@@ -3,7 +3,7 @@
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-Platform name: efl
+Platform name: atk
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/platform/gtk/accessibility/platform-name-expected.txt (161665 => 161666)
--- trunk/LayoutTests/platform/gtk/accessibility/platform-name-expected.txt 2014-01-10 21:08:51 UTC (rev 161665)
+++ trunk/LayoutTests/platform/gtk/accessibility/platform-name-expected.txt 2014-01-10 21:10:57 UTC (rev 161666)
@@ -3,7 +3,7 @@
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-Platform name: gtk
+Platform name: atk
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Tools/ChangeLog (161665 => 161666)
--- trunk/Tools/ChangeLog 2014-01-10 21:08:51 UTC (rev 161665)
+++ trunk/Tools/ChangeLog 2014-01-10 21:10:57 UTC (rev 161666)
@@ -1,3 +1,74 @@
+2014-01-10 Mario Sanchez Prada mario.pr...@samsung.com
+
+Move platformName property from testRunner to accessibilityController
+https://bugs.webkit.org/show_bug.cgi?id=126689
+
+Reviewed by Chris Fleizach.
+
+Move the platformNa
[webkit-changes] [161492] trunk/Source/WebCore
Title: [161492] trunk/Source/WebCore
Revision 161492
Author mario.pr...@samsung.com
Date 2014-01-08 02:58:37 -0800 (Wed, 08 Jan 2014)
Log Message
AX: Make roleValue() return DescriptionListRole for dl elements
https://bugs.webkit.org/show_bug.cgi?id=126579
Reviewed by Chris Fleizach.
Implement AccessibilityList::roleValue() so it will return
ListRole or DescriptionListRole depending on the type of list.
No new tests needed, as no new functionality was added and ports
should still be exposing the right role for dl elements
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::roleValue): Implemented.
* accessibility/AccessibilityList.h:
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Removed extra checks for objects with ListRole role.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityList.cpp
trunk/Source/WebCore/accessibility/AccessibilityList.h
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161491 => 161492)
--- trunk/Source/WebCore/ChangeLog 2014-01-08 09:47:59 UTC (rev 161491)
+++ trunk/Source/WebCore/ChangeLog 2014-01-08 10:58:37 UTC (rev 161492)
@@ -1,3 +1,23 @@
+2014-01-08 Mario Sanchez Prada mario.pr...@samsung.com
+
+AX: Make roleValue() return DescriptionListRole for dl elements
+https://bugs.webkit.org/show_bug.cgi?id=126579
+
+Reviewed by Chris Fleizach.
+
+Implement AccessibilityList::roleValue() so it will return
+ListRole or DescriptionListRole depending on the type of list.
+
+No new tests needed, as no new functionality was added and ports
+should still be exposing the right role for dl elements
+
+* accessibility/AccessibilityList.cpp:
+(WebCore::AccessibilityList::roleValue): Implemented.
+* accessibility/AccessibilityList.h:
+
+* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+(atkRole): Removed extra checks for objects with ListRole role.
+
2014-01-08 Andreas Kling akl...@apple.com
createMathMLOperator() should return RenderPtr.
Modified: trunk/Source/WebCore/accessibility/AccessibilityList.cpp (161491 => 161492)
--- trunk/Source/WebCore/accessibility/AccessibilityList.cpp 2014-01-08 09:47:59 UTC (rev 161491)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.cpp 2014-01-08 10:58:37 UTC (rev 161492)
@@ -93,6 +93,13 @@
Node* node = m_renderer-node();
return node node-hasTagName(dlTag);
}
+
+AccessibilityRole AccessibilityList::roleValue() const
+{
+if (isDescriptionList())
+return DescriptionListRole;
+return ListRole;
+}
} // namespace WebCore
Modified: trunk/Source/WebCore/accessibility/AccessibilityList.h (161491 => 161492)
--- trunk/Source/WebCore/accessibility/AccessibilityList.h 2014-01-08 09:47:59 UTC (rev 161491)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.h 2014-01-08 10:58:37 UTC (rev 161492)
@@ -46,7 +46,7 @@
bool isOrderedList() const;
bool isDescriptionList() const;
-virtual AccessibilityRole roleValue() const OVERRIDE { return ListRole; }
+virtual AccessibilityRole roleValue() const OVERRIDE FINAL;
private:
virtual bool computeAccessibilityIsIgnored() const OVERRIDE;
};
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (161491 => 161492)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-01-08 09:47:59 UTC (rev 161491)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-01-08 10:58:37 UTC (rev 161492)
@@ -634,10 +634,6 @@
case ColorWellRole:
return ATK_ROLE_COLOR_CHOOSER;
case ListRole:
-#if ATK_CHECK_VERSION(2, 11, 4)
-if (coreObject-isList() toAccessibilityList(coreObject)-isDescriptionList())
-return ATK_ROLE_DESCRIPTION_LIST;
-#endif
return ATK_ROLE_LIST;
case ScrollBarRole:
return ATK_ROLE_SCROLL_BAR;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [160903] trunk
Title: [160903] trunk Revision 160903 Author mario.pr...@samsung.com Date 2013-12-20 03:52:17 -0800 (Fri, 20 Dec 2013) Log Message Programmatically-inserted children lack accessibility events https://bugs.webkit.org/show_bug.cgi?id=100275 Reviewed by Chris Fleizach. Source/WebCore: Test: accessibility/children-changed-sends-notification.html Emit children-changed::add and children-changed::remove whenever an object has been added/removed to the accessibility hierarchy, that is, when a new AtkObject is being attached/detached. * accessibility/AXObjectCache.h: (WebCore::AXObjectCache::detachWrapper): Added a new parameter and updated all the prototypes in different ports. * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::~AXObjectCache): Call detachWrapper() specifying that we do it because the cache is being destroyed. (WebCore::AXObjectCache::remove): Call detachWrapper() specifying that we do it because an accessible element is being destroyed. * accessibility/atk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::detachWrapper): Emit the children-changed signal when needed. We rely on the cached reference to the parent AtkObject (using the implementation of atk_object_get_parent from the AtkObject class) to find the right object to emit the signal from here, since the accessibility hierarchy from WebCore will no longer be accessible at this point. (WebCore::AXObjectCache::attachWrapper): Emit the children-change signal from here unless we are in the middle of a layout update, trying to provide as much information (e.g. the offset) as possible. (WebCore::AXObjectCache::postPlatformNotification): Make sure we update (touch) the subtree under an accessibility object whenever we receive AXChildrenChanded from WebCore, to ensure that those objects will also be visible rightaway to ATs, and that those get properly notified of the event at that very same moment. * accessibility/ios/AXObjectCacheIOS.mm: (WebCore::AXObjectCache::detachWrapper): Updated function signature. * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::detachWrapper): Ditto. * accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::detachWrapper): Ditto. * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::children): Add the option ot request the AccessibilityChildrenVector without updating it if needed, to avoid maybe recreating the child subtree when trying to get the offset of a newly attached element from attachWrapper. * accessibility/AccessibilityObject.h: Tools: Update DRT and WebKitTestRunner to handle the children-changed signal properly, considering the detail and optional parameters. * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated. (axObjectEventListener): * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated. LayoutTests: Add new test to chack that children-changed signals are properly emitted when adding/removing elements in the accessibility hierarchy. * accessibility/children-changed-sends-notification-expected.txt: Added. * accessibility/children-changed-sends-notification.html: Added. Update test to filter out unrelated non-loading events. * accessibility/loading-iframe-sends-notification.html: Updated. Skip the test on the Mac as it does not expose these kind of notifications when children are being added or removed. * platform/mac/TestExpectations: Skip newly added test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/loading-iframe-sends-notification.html trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AXObjectCache.h trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp Added Paths trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt trunk/LayoutTests/accessibility/children-changed-sends-notification.html Diff Modified: trunk/LayoutTests/ChangeLog (160902 => 160903) --- trunk/LayoutTests/ChangeLog 2013-12-20 11:28:40 UTC (rev 160902) +++ trunk/LayoutTests/ChangeLog 2013-12-20 11:52:17 UTC (rev 160903) @@ -1,3 +1,23 @@ +2013-12-20 Mario Sanchez Prada mario.pr...@samsung.com + +Programmatically-inserted children lack accessibility events +https://bugs.webkit.org/show_bug.cgi?id=100275 + +Reviewed by Chris Fleizach. + +Add new test to chack that children-changed signals are properly +emitted when adding/removing eleme
[webkit-changes] [160907] trunk
Title: [160907] trunk Revision 160907 Author mario.pr...@samsung.com Date 2013-12-20 06:12:04 -0800 (Fri, 20 Dec 2013) Log Message [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing https://bugs.webkit.org/show_bug.cgi?id=125854 Reviewed by Chris Fleizach. Tools: Ensure we don't ever create instances of AccessibilityUIElement wrapping invalid platform-specific accessibility objects in DRT, both for consistency with what WKTR does (so we avoid situations where some tests fail in WK2 and not in WK1) and also to avoid overlooking tests that might not be checking the right thing. * DumpRenderTree/AccessibilityUIElement.cpp: (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a nullPtr if the platformUIElement() is not a valid one. * DumpRenderTree/AccessibilityUIElement.h: (AccessibilityUIElement::platformUIElement): Added const modifier. LayoutTests: Updated tests and expectations to keep them passing after the change done in DRT, without changing their actual purpose. * platform/gtk/accessibility/roles-exposed.html: Make sure we print AXRole: (no element) when accessibilityElementByID() does not return a valid object, not to confuse it with cases where the returned string for the role is an empty string. * platform/gtk/accessibility/roles-exposed-expected.txt: Update test expectations to reflect the AXRole: (no element) string that is now being exposed. Also, replace the (wrongly added) PASS expectations with FAIL for rowgroups, which are currently not being exposed for ATK either. * accessibility/deleting-iframe-destroys-axcache.html: Just consider the first and third sons of the accessibility object for the body (instead of the grandsons), so the test can run both in Mac, where sons and grandsons are exposed, and ATK, where only sons are exposed (no StaticText objects exposed there). * accessibility/non-data-table-cell-title-ui-element.html: Use accessibilityElementById() to get the accessibility object for the skip table header instead of navigating with childAtIndex(), since the hierarchy is not the same for Mac and ATK based ports. * platform/mac/accessibility/search-predicate.html: Do not rely on shouldBe() together with the string AXRole: when asking for the role of objects that should no longer be in the accessibility tree, and use shouldBeUndefined() instead. * platform/mac/accessibility/search-when-element-starts-in-table.html: Ditto. * platform/mac/accessibility/search-predicate-expected.txt: Update expectations according to the usage of shouldBeUndefined(). * platform/mac/accessibility/search-when-element-starts-in-table-expected.txt: Ditto. * platform/mac/TestExpectations: Add loading-iframe-updates-axtree.html here, since it seems not to be returning the expected values for either the scrollarea and the webarea in the iframe (see bug 126066). * platform/mac-wk2/TestExpectations: Add search-when-element-starts-in-table.html here, since it does not return an undefined object in WebKit2 when the search query should return no results (see bug 125996). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html trunk/LayoutTests/accessibility/non-data-table-cell-title-ui-element.html trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt trunk/LayoutTests/platform/mac/accessibility/search-predicate.html trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp trunk/Tools/DumpRenderTree/AccessibilityUIElement.h Diff Modified: trunk/LayoutTests/ChangeLog (160906 => 160907) --- trunk/LayoutTests/ChangeLog 2013-12-20 13:47:42 UTC (rev 160906) +++ trunk/LayoutTests/ChangeLog 2013-12-20 14:12:04 UTC (rev 160907) @@ -1,3 +1,52 @@ +2013-12-20 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing +https://bugs.webkit.org/show_bug.cgi?id=125854 + +Reviewed by Chris Fleizach. + +Updated tests and expectations to keep them passing after the +change done in DRT, without changing their actual purpose. + +* platform/gtk/accessibility/roles-exposed.html: Make sure we +print AXRole: (no element) when accessibilityElementByID() does +not return a valid object, not to confuse it with cases where the +returned string for the role is an empty string. +* platform/gtk/accessibility/roles-exposed-expected.txt: Update +test expectations to reflect the AXRole: (no element) string +that is now being expo
[webkit-changes] [160842] trunk
Title: [160842] trunk Revision 160842 Author mario.pr...@samsung.com Date 2013-12-19 10:14:32 -0800 (Thu, 19 Dec 2013) Log Message [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing https://bugs.webkit.org/show_bug.cgi?id=125854 Reviewed by Chris Fleizach. Tools: Ensure we don't ever create instances of AccessibilityUIElement wrapping invalid platform-specific accessibility objects in DRT, both for consistency with what WKTR does (so we avoid situations where some tests fail in WK2 and not in WK1) and also to avoid overlooking tests that might not be checking the right thing. * DumpRenderTree/AccessibilityUIElement.cpp: (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a nullPtr if the platformUIElement() is not a valid one. * DumpRenderTree/AccessibilityUIElement.h: (AccessibilityUIElement::platformUIElement): Added const modifier. LayoutTests: Updated tests and expectations to keep them passing after the change done in DRT, without changing their actual purpose. * platform/gtk/accessibility/roles-exposed.html: Make sure we print AXRole: (no element) when accessibilityElementByID() does not return a valid object, not to confuse it with cases where the returned string for the role is an empty string. * platform/gtk/accessibility/roles-exposed-expected.txt: Update test expectations to reflect the AXRole: (no element) string that is now being exposed. Also, replace the (wrongly added) PASS expectations with FAIL for rowgroups, which are currently not being exposed for ATK either. * accessibility/deleting-iframe-destroys-axcache.html: Just consider the first and third sons of the accessibility object for the body (instead of the grandsons), so the test can run both in Mac, where sons and grandsons are exposed, and ATK, where only sons are exposed (no StaticText objects exposed there). * accessibility/non-data-table-cell-title-ui-element.html: Use accessibilityElementById() to get the accessibility object for the skip table header instead of navigating with childAtIndex(), since the hierarchy is not the same for Mac and ATK based ports. * accessibility/loading-iframe-updates-axtree.html: Use the new web area inside the iframe to compare against the old one, instead of doing it the other way around, to avoid calling isEqual for an undefined value (the old web area). * accessibility/loading-iframe-updates-axtree-expected.txt: Removed line comparing the old and new web areas inside the iframe. * platform/mac/accessibility/search-predicate.html: Do not rely on shouldBe() together with the string AXRole: when asking for the role of objects that should no longer be in the accessibility tree, and use shouldBeUndefined() instead. * platform/mac/accessibility/search-when-element-starts-in-table.html: Ditto. * platform/mac/accessibility/search-predicate-expected.txt: Update expectations according to the usage of shouldBeUndefined(). * platform/mac/accessibility/search-when-element-starts-in-table-expected.txt: Ditto. * platform/mac-wk2/TestExpectations: Add search-when-element-starts-in-table.html here, since it does not return an undefined object in WebKit2 when the search query should return no results (see bug 125996). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/deleting-iframe-destroys-axcache.html trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html trunk/LayoutTests/accessibility/non-data-table-cell-title-ui-element.html trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html trunk/LayoutTests/platform/mac/accessibility/search-predicate-expected.txt trunk/LayoutTests/platform/mac/accessibility/search-predicate.html trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp trunk/Tools/DumpRenderTree/AccessibilityUIElement.h Diff Modified: trunk/LayoutTests/ChangeLog (160841 => 160842) --- trunk/LayoutTests/ChangeLog 2013-12-19 18:10:07 UTC (rev 160841) +++ trunk/LayoutTests/ChangeLog 2013-12-19 18:14:32 UTC (rev 160842) @@ -1,3 +1,55 @@ +2013-12-19 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing +https://bugs.webkit.org/show_bug.cgi?id=125854 + +Reviewed by Chris Fleizach. + +Updated tests and expectations to keep them passing after the +change done in DRT, without changing their actual purpose. + +* platform/gtk/accessibility/roles-exposed.html: Make sure we +print AXRole: (no element) when accessibilityElementByID() does +not return a valid object, not to confuse it with ca
[webkit-changes] [160702] trunk/LayoutTests
Title: [160702] trunk/LayoutTests Revision 160702 Author mario.pr...@samsung.com Date 2013-12-17 05:30:17 -0800 (Tue, 17 Dec 2013) Log Message [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR https://bugs.webkit.org/show_bug.cgi?id=116971 Unreviewed. Moving test expectation to the right place, as this is an issue that actually affects both to Webkit1 and Webkit2. * platform/gtk-wk2/TestExpectations: Removed expectation. * platform/gtk/TestExpectations: Added expectation. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (160701 => 160702) --- trunk/LayoutTests/ChangeLog 2013-12-17 12:26:19 UTC (rev 160701) +++ trunk/LayoutTests/ChangeLog 2013-12-17 13:30:17 UTC (rev 160702) @@ -1,3 +1,14 @@ +2013-12-17 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK][WK2] rowAtIndex is not implemented in DRT/WKTR +https://bugs.webkit.org/show_bug.cgi?id=116971 + +Unreviewed. Moving test expectation to the right place, as this is +an issue that actually affects both to Webkit1 and Webkit2. + +* platform/gtk-wk2/TestExpectations: Removed expectation. +* platform/gtk/TestExpectations: Added expectation. + 2013-12-17 Mihnea Ovidenie mih...@adobe.com [CSSRegions] Remove left-over test expectations in fast/regions/layers Modified: trunk/LayoutTests/platform/gtk/TestExpectations (160701 => 160702) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-17 12:26:19 UTC (rev 160701) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-17 13:30:17 UTC (rev 160702) @@ -955,6 +955,8 @@ webkit.org/b/125506 accessibility/alt-tag-on-image-with-nonimage-role.html [ Failure ] +webkit.org/b/116971 accessibility/poorly-formed-aria-table.html [ Failure ] + # Blur and focus events are not received for the following tests. Bug(GTK) fast/events/blur-focus-window-should-blur-focus-element.html [ Failure ] Bug(GTK) fast/dom/HTMLDocument/hasFocus.html [ Failure ] Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (160701 => 160702) --- trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-12-17 12:26:19 UTC (rev 160701) +++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-12-17 13:30:17 UTC (rev 160702) @@ -326,7 +326,6 @@ webkit.org/b/106338 accessibility/aria-hidden-updates-alldescendants.html [ Failure ] webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ] webkit.org/b/116970 accessibility/multiselect-list-reports-active-option.html [ Failure ] -webkit.org/b/116971 accessibility/poorly-formed-aria-table.html [ Failure ] # svg/ failures webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [160712] trunk
Title: [160712] trunk
Revision 160712
Author mario.pr...@samsung.com
Date 2013-12-17 10:08:34 -0800 (Tue, 17 Dec 2013)
Log Message
[ATK] Expose accessibility objects for dl, dt and dd
https://bugs.webkit.org/show_bug.cgi?id=125857
Reviewed by Chris Fleizach.
Source/WebCore:
Map description lists to the newly introduced ATK roles
ATK_ROLE_DESCRIPTION_LIST, ATK_ROLE_DESCRIPTION_TERM and
ATK_ROLE_DESCRIPTION_VALUE, introduced in ATK 2.11.4.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Do the right mapping.
(webkitAccessibleGetRole): Update call to atkRole, now that it
receives an AccessibilityObject* as parameter.
Tools:
Add mappings to DRT WKTR for the newly exposed roles, and
increase the version of ATK used by the internal jhbuild.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
* gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
LayoutTests:
Update test to update expectations.
* platform/gtk/accessibility/roles-exposed-expected.txt:
* platform/gtk/accessibility/roles-exposed.html:
Updated test expectations for other test using description lists.
* platform/efl-wk1/accessibility/lists-expected.txt:
* platform/efl-wk2/accessibility/lists-expected.txt:
* platform/gtk/accessibility/lists-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt
trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/gtk/jhbuild.modules
Diff
Modified: trunk/LayoutTests/ChangeLog (160711 => 160712)
--- trunk/LayoutTests/ChangeLog 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/LayoutTests/ChangeLog 2013-12-17 18:08:34 UTC (rev 160712)
@@ -1,3 +1,22 @@
+2013-12-17 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Expose accessibility objects for dl, dt and dd
+https://bugs.webkit.org/show_bug.cgi?id=125857
+
+Reviewed by Chris Fleizach.
+
+Update test to update expectations.
+
+* platform/gtk/accessibility/roles-exposed-expected.txt:
+* platform/gtk/accessibility/roles-exposed.html:
+
+Updated test expectations for other test using description lists.
+
+* platform/efl-wk1/accessibility/lists-expected.txt:
+* platform/efl-wk2/accessibility/lists-expected.txt:
+* platform/gtk/accessibility/lists-expected.txt:
+
+
2013-12-17 Frédéric Wang fred.w...@free.fr
Ensure inferred mrows for msqrt, mstyle, merror, mphantom and math.
Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt (160711 => 160712)
--- trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt 2013-12-17 17:56:21 UTC (rev 160711)
+++ trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt 2013-12-17 18:08:34 UTC (rev 160712)
@@ -47,7 +47,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
-AXRole: AXList
+AXRole: AXDescriptionList
AXParent: AXWebArea
AXChildren: 5
AXPosition: { 8.00, 120.00 }
@@ -204,8 +204,8 @@
-AXRole: AXUnknown
-AXParent: AXList
+AXRole: AXDescriptionTerm
+AXParent: AXDescriptionList
AXChildren: 0
AXPosition: { 8.00, 120.00 }
AXSize: { 769.00, 18.00 }
@@ -223,8 +223,8 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
-AXRole: AXUnknown
-AXParent: AXList
+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
AXChildren: 0
AXPosition: { 48.00, 138.00 }
AXSize: { 729.00, 18.00 }
@@ -242,8 +242,8 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
-AXRole: AXUnknown
-AXParent: AXList
+AXRole: AXDescriptionTerm
+AXParent: AXDescriptionList
AXChildren: 0
AXPosition: { 8.00, 156.00 }
AXSize: { 769.00, 18.00 }
@@ -261,8 +261,8 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
-AXRole: AXUnknown
-AXParent: AXList
+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
AXChildren: 0
AXPosition: { 48.00, 174.00 }
AXSize: { 729.00, 18.00 }
@@ -280,8 +280,8 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
-AXRole: AXUnknown
-AXParent: AXList
+AXRole: AXDescriptionValue
+AXParent: AXDescriptionList
AXChildren: 0
AXPosition: { 48.00, 192.00 }
AXSize: { 729.00, 18.00 }
Modified: trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt (160711 => 160712)
--- trunk/LayoutTests/platform/efl-wk2/acce
[webkit-changes] [160637] trunk
Title: [160637] trunk Revision 160637 Author mario.pr...@samsung.com Date 2013-12-16 07:17:58 -0800 (Mon, 16 Dec 2013) Log Message [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE https://bugs.webkit.org/show_bug.cgi?id=125587 Reviewed by Chris Fleizach. Source/WebCore: Exposed accessibility objects with article role with the proper AtkRole, to be provided by the next stable release of ATK. * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: (atkRole): Tools: Add mappings to DRT WKTR for article roles. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: LayoutTests: Update test to unskip article objects and update expectations. * accessibility/aria-mappings-expected.txt: * platform/gtk/accessibility/roles-exposed-expected.txt: * platform/gtk/accessibility/roles-exposed.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/aria-mappings-expected.txt trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (160636 => 160637) --- trunk/LayoutTests/ChangeLog 2013-12-16 15:08:27 UTC (rev 160636) +++ trunk/LayoutTests/ChangeLog 2013-12-16 15:17:58 UTC (rev 160637) @@ -1,3 +1,16 @@ +2013-12-16 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] Expose accessibility objects with ATK_ROLE_ARTICLE +https://bugs.webkit.org/show_bug.cgi?id=125587 + +Reviewed by Chris Fleizach. + +Update test to unskip article objects and update expectations. + +* accessibility/aria-mappings-expected.txt: +* platform/gtk/accessibility/roles-exposed-expected.txt: +* platform/gtk/accessibility/roles-exposed.html: + 2013-11-27 Sergio Villar Senin svil...@igalia.com [CSS Grid Layout] Fix the preferred logical widths code to work with spanning grid items Modified: trunk/LayoutTests/accessibility/aria-mappings-expected.txt (160636 => 160637) --- trunk/LayoutTests/accessibility/aria-mappings-expected.txt 2013-12-16 15:08:27 UTC (rev 160636) +++ trunk/LayoutTests/accessibility/aria-mappings-expected.txt 2013-12-16 15:17:58 UTC (rev 160637) @@ -25,7 +25,7 @@ role=article is a section of a page that consists of a composition that forms an independent part of a document, page, or site -Role for 'article' div is: AXRole: AXDocument +Role for 'article' div is: AXRole: AXArticle role=dialog is an application window that is designed to interrupt the current processing of an application in order to prompt the user to enter information or require a response. Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (160636 => 160637) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-16 15:08:27 UTC (rev 160636) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-16 15:17:58 UTC (rev 160637) @@ -9,6 +9,9 @@ PASS: address AXRole: AXLandmarkContentInfo +PASS: article + AXRole: AXArticle + PASS: aside AXRole: AXLandmarkComplementary @@ -231,6 +234,9 @@ PASS: div[role=application] AXRole: AXEmbedded +PASS: div[role=article] + AXRole: AXArticle + PASS: div[role=banner] AXRole: AXLandmarkBanner Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html (160636 => 160637) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-16 15:08:27 UTC (rev 160636) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-16 15:17:58 UTC (rev 160637) @@ -12,7 +12,7 @@ !-- skipped ATK: not focusable abbr data-role= class=exX/abbr-- address data-role=AXLandmarkContentInfo class=exX/address !-- skipped area -- -!-- http://webkit.org/b/125493 article data-role=AXArticle class=exX/article-- +article data-role=AXArticle class=exX/article aside data-role=AXLandmarkComplementary class=exX/aside !-- http://webkit.org/b/125491 audio data-role= class=exX/audio-- !-- skipped ATK: not focusable b data-role= class=exX/b-- @@ -189,7 +189,7 @@ div role=alertdata-role=AXAlert class=exX/div div role=alertdialog data-role=AXAlert class=exX/div div role=application data-role=AXEmbedded class=exX/div -!-- http://webkit.org/b/125493 div role=article data-role=AXArticle class=exX/div-- +div role=article data-role=AXArticle class=exX/div div role=banner data-role=AXLandmarkBanner class=exX/div div role=button data-role=AXButton c
[webkit-changes] [160638] trunk
Title: [160638] trunk Revision 160638 Author mario.pr...@samsung.com Date 2013-12-16 07:58:34 -0800 (Mon, 16 Dec 2013) Log Message [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM https://bugs.webkit.org/show_bug.cgi?id=125594 Reviewed by Chris Fleizach. Source/WebCore: Exposed accessibility objects with checkmenuitem role with the proper AtkRole, to be provided by the next stable release of ATK. * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: (atkRole): Tools: Add mappings to DRT WKTR for checkmenuitem role. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: LayoutTests: Update test to update expectations. * platform/gtk/accessibility/roles-exposed-expected.txt: * platform/gtk/accessibility/roles-exposed.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (160637 => 160638) --- trunk/LayoutTests/ChangeLog 2013-12-16 15:17:58 UTC (rev 160637) +++ trunk/LayoutTests/ChangeLog 2013-12-16 15:58:34 UTC (rev 160638) @@ -1,5 +1,17 @@ 2013-12-16 Mario Sanchez Prada mario.pr...@samsung.com +[ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM +https://bugs.webkit.org/show_bug.cgi?id=125594 + +Reviewed by Chris Fleizach. + +Update test to update expectations. + +* platform/gtk/accessibility/roles-exposed-expected.txt: +* platform/gtk/accessibility/roles-exposed.html: + +2013-12-16 Mario Sanchez Prada mario.pr...@samsung.com + [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE https://bugs.webkit.org/show_bug.cgi?id=125587 Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (160637 => 160638) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-16 15:17:58 UTC (rev 160637) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-16 15:58:34 UTC (rev 160638) @@ -305,6 +305,9 @@ PASS: div[role=menuitem] AXRole: AXMenuItem +PASS: div[role=menuitemcheckbox] + AXRole: AXCheckMenuItem + PASS: div[role=menuitemradio] AXRole: AXRadioMenuItem @@ -314,6 +317,9 @@ PASS: div[role=menuitem] AXRole: AXMenuItem +PASS: div[role=menuitemcheckbox] + AXRole: AXCheckMenuItem + PASS: div[role=menuitemradio] AXRole: AXRadioMenuItem Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html (160637 => 160638) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-16 15:17:58 UTC (rev 160637) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-16 15:58:34 UTC (rev 160638) @@ -228,13 +228,13 @@ div role=menu data-role=AXMenu class=ex !-- Note: diff between menuitem types is an attribute; need additional non-role verification in another test. -- div role=menuitem data-role=AXMenuItem class=exX/div -!-- http://webkit.org/b/125493 div role=menuitemcheckbox data-role=AXCheckMenuItem class=exX/div-- +div role=menuitemcheckbox data-role=AXCheckMenuItem class=exX/div div role=menuitemradiodata-role=AXRadioMenuItem class=exX/div /div div role=menubar data-role=AXMenuBar class=ex !-- Note: diff between menuitem types is an attribute; need additional non-role verification in another test. -- div role=menuitem data-role=AXMenuItem class=exX/div -!-- http://webkit.org/b/125493 div role=menuitemcheckbox data-role=AXCheckMenuItem class=exX/div-- +div role=menuitemcheckbox data-role=AXCheckMenuItem class=exX/div div role=menuitemradiodata-role=AXRadioMenuItem class=exX/div /div div role=navigation data-role=AXLandmarkNavigation class=exX/div Modified: trunk/Source/WebCore/ChangeLog (160637 => 160638) --- trunk/Source/WebCore/ChangeLog 2013-12-16 15:17:58 UTC (rev 160637) +++ trunk/Source/WebCore/ChangeLog 2013-12-16 15:58:34 UTC (rev 160638) @@ -1,5 +1,18 @@ 2013-12-16 Mario Sanchez Prada mario.pr...@samsung.com +[ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM +https://bugs.webkit.org/show_bug.cgi?id=125594 + +Reviewed by Chris Fleizach. + +Exposed accessibility objects with checkmenuitem role with the +proper AtkRole, to be provided by the next stable release of ATK. + +* accessibility/atk/WebKitAccessibleWrapperAtk.cpp: +(atkRole): +
[webkit-changes] [160641] trunk
Title: [160641] trunk Revision 160641 Author mario.pr...@samsung.com Date 2013-12-16 08:18:30 -0800 (Mon, 16 Dec 2013) Log Message [ATK] Expose accessibility objects for more WAI-ARIA roles https://bugs.webkit.org/show_bug.cgi?id=125596 Reviewed by Chris Fleizach. Source/WebCore: Exposed accessibility objects with the proper AtkRoles, some of them to be provided by the next stable release of ATK. * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: (atkRole): Tools: Add mappings to DRT WKTR for the newly exposed roles. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: LayoutTests: Update test to update expectations. * platform/gtk/accessibility/roles-exposed-expected.txt: * platform/gtk/accessibility/roles-exposed.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (160640 => 160641) --- trunk/LayoutTests/ChangeLog 2013-12-16 16:04:50 UTC (rev 160640) +++ trunk/LayoutTests/ChangeLog 2013-12-16 16:18:30 UTC (rev 160641) @@ -1,3 +1,15 @@ +2013-12-16 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] Expose accessibility objects for more WAI-ARIA roles +https://bugs.webkit.org/show_bug.cgi?id=125596 + +Reviewed by Chris Fleizach. + +Update test to update expectations. + +* platform/gtk/accessibility/roles-exposed-expected.txt: +* platform/gtk/accessibility/roles-exposed.html: + 2013-12-16 Eric Carlson eric.carl...@apple.com Fix QuickTime plug-in replacement scripting bugs Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (160640 => 160641) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-16 16:04:50 UTC (rev 160640) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-16 16:18:30 UTC (rev 160641) @@ -126,6 +126,9 @@ PASS: input[type='week'] AXRole: AXTextField +PASS: math + AXRole: AXMath + PASS: nav AXRole: AXLandmarkNavigation @@ -255,6 +258,12 @@ PASS: div[role=contentinfo] AXRole: AXLandmarkContentInfo +PASS: div[role=definition] + AXRole: AXDefinition + +PASS: div[role=dialog] + AXRole: AXDialog + PASS: div[role=directory] AXRole: AXList @@ -296,9 +305,18 @@ PASS: div[role=option] AXRole: AXListItem +PASS: div[role=log] + AXRole: AXLog + PASS: div[role=main] AXRole: AXLandmarkMain +PASS: div[role=marquee] + AXRole: AXMarquee + +PASS: div[role=math] + AXRole: AXMath + PASS: div[role=menu] AXRole: AXMenu @@ -326,6 +344,9 @@ PASS: div[role=navigation] AXRole: AXLandmarkNavigation +PASS: div[role=note] + AXRole: AXComment + PASS: div[role=progressbar] AXRole: AXProgressIndicator @@ -359,6 +380,9 @@ PASS: div[role=textbox] AXRole: AXTextField +PASS: div[role=timer] + AXRole: AXTimer + PASS: div[role=toolbar] AXRole: AXToolbar Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html (160640 => 160641) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-16 16:04:50 UTC (rev 160640) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-16 16:18:30 UTC (rev 160641) @@ -1,4 +1,3 @@ - !DOCTYPE HTML html body @@ -90,7 +89,7 @@ !-- skipped link -- !-- skipped map -- !-- skipped ATK: not focusable -- http://webkit.org/b/109018 mark data-role= class=exX/mark-- -!-- http://webkit.org/b/125493 math data-role=AXMath class=exX/math-- +math data-role=AXMath class=exX/math !-- skipped menu -- !-- skipped meta -- !-- http://webkit.org/b/125491 meter data-role=AXProgressIndicator class=ex value=0.75X/meter-- @@ -196,8 +195,8 @@ div role=combobox data-role=AXComboBox class=exX/div div role=complementarydata-role=AXLandmarkComplementary class=exX/div div role=contentinfo data-role=AXLandmarkContentInfo class=exX/div -!-- http://webkit.org/b/125493 div role=definition data-role=AXDefinition class=exX/div-- -!-- http://webkit.org/b/125493 div role=dialog data-role=AXGroup class=exX/div-- +div role=definition data-role=AXDefinition class=exX/div +div role=dialog data-role=AXDialog class=exX/div div role=directorydata-role=AXList class=exX/div !-- http://webkit.org/b/125493
[webkit-changes] [160417] trunk
Title: [160417] trunk Revision 160417 Author mario.pr...@samsung.com Date 2013-12-11 02:28:21 -0800 (Wed, 11 Dec 2013) Log Message Programmatically-inserted children lack accessibility events https://bugs.webkit.org/show_bug.cgi?id=100275 Reviewed by Chris Fleizach. Source/WebCore: Test: accessibility/children-changed-sends-notification.html Emit children-changed::add and children-changed::remove whenever an object has been added/removed to the accessibility hierarchy, that is, when a new AtkObject is being attached/detached. * accessibility/AXObjectCache.h: Added new enumeration to know when we are detaching a wrapper because of the cache or the element is being destroyed, so we can use that information. (WebCore::AXObjectCache::detachWrapper): Added a new parameter and updated all the prototypes in different ports. * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::~AXObjectCache): Call detachWrapper() specifying that we do it because the cache is being destroyed. (WebCore::AXObjectCache::remove): Call detachWrapper() specifying that we do it because an accessible element is being destroyed. * accessibility/atk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::detachWrapper): Emit the children-changed signal when needed. We rely on the cached reference to the parent AtkObject (using the implementation of atk_object_get_parent from the AtkObject class) to find the right object to emit the signal from here, since the accessibility hierarchy from WebCore will no longer be accessible at this point. (WebCore::AXObjectCache::attachWrapper): Emit the children-change signal from here unless we are in the middle of a layout update, trying to provide as much information (e.g. the offset) as possible. (WebCore::AXObjectCache::postPlatformNotification): Make sure we update (touch) the subtree under an accessibility object whenever we receive AXChildrenChanded from WebCore, to ensure that those objects will also be visible rightaway to ATs, and that those get properly notified of the event at that very same moment. * accessibility/ios/AXObjectCacheIOS.mm: (WebCore::AXObjectCache::detachWrapper): Updated function signature. * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::detachWrapper): Ditto. * accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::detachWrapper): Ditto. Tools: Update DRT and WebKitTestRunner to handle the children-changed signal properly, considering the detail and optional parameters. * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated. (axObjectEventListener): * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated. LayoutTests: Add new test to chack that children-changed signals are properly emitted when adding/removing elements in the accessibility hierarchy. * accessibility/children-changed-sends-notification-expected.txt: Added. * accessibility/children-changed-sends-notification.html: Added. Update test to filter out unrelated non-loading events. * accessibility/loading-iframe-sends-notification.html: Updated. Skip the test on the Mac as it does not expose these kind of notifications when children are being added or removed. * platform/mac/TestExpectations: Skip newly added test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/loading-iframe-sends-notification.html trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AXObjectCache.h trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp Added Paths trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt trunk/LayoutTests/accessibility/children-changed-sends-notification.html Diff Modified: trunk/LayoutTests/ChangeLog (160416 => 160417) --- trunk/LayoutTests/ChangeLog 2013-12-11 10:00:59 UTC (rev 160416) +++ trunk/LayoutTests/ChangeLog 2013-12-11 10:28:21 UTC (rev 160417) @@ -1,3 +1,23 @@ +2013-12-11 Mario Sanchez Prada mario.pr...@samsung.com + +Programmatically-inserted children lack accessibility events +https://bugs.webkit.org/show_bug.cgi?id=100275 + +Reviewed by Chris Fleizach. + +Add new test to chack that children-changed signals are properly +emitted when adding/removing elements in the accessibility hierarchy. + +* accessibility/children-changed-sends-notification-expected.txt: Added. +* accessibility/children-changed-sends-notification.html: Added. + +Update test to filter out unrelated non-loading events. +* accessibility/loading-ifr
[webkit-changes] [160447] trunk/LayoutTests
Title: [160447] trunk/LayoutTests Revision 160447 Author mario.pr...@samsung.com Date 2013-12-11 10:58:23 -0800 (Wed, 11 Dec 2013) Log Message [ATK] Add new layout test to check ATK roles in a central place https://bugs.webkit.org/show_bug.cgi?id=125525 Reviewed by Chris Fleizach. New test added, with some skipped tests already present in platform/mac/accessibility/role-subrole-roledescription.html (this test is based in that one) as well as some issues specific to ATK that have been reported in bugs, for traceability. * platform/gtk/accessibility/roles-exposed-expected.txt: Added. * platform/gtk/accessibility/roles-exposed.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html Diff Modified: trunk/LayoutTests/ChangeLog (160446 => 160447) --- trunk/LayoutTests/ChangeLog 2013-12-11 18:25:06 UTC (rev 160446) +++ trunk/LayoutTests/ChangeLog 2013-12-11 18:58:23 UTC (rev 160447) @@ -1,3 +1,18 @@ +2013-12-11 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] Add new layout test to check ATK roles in a central place +https://bugs.webkit.org/show_bug.cgi?id=125525 + +Reviewed by Chris Fleizach. + +New test added, with some skipped tests already present in +platform/mac/accessibility/role-subrole-roledescription.html (this +test is based in that one) as well as some issues specific to ATK +that have been reported in bugs, for traceability. + +* platform/gtk/accessibility/roles-exposed-expected.txt: Added. +* platform/gtk/accessibility/roles-exposed.html: Added. + 2013-12-11 Zan Dobersek zdober...@igalia.com [GTK] Enable Battery Status API Added: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (0 => 160447) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-11 18:58:23 UTC (rev 160447) @@ -0,0 +1,336 @@ +This tests that native elements and ARIA overrides result in the expected role and role description. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS: a[href] + AXRole: AXLink + +PASS: blockquote + AXRole: AXGroup + +PASS: button + AXRole: AXButton + +PASS: div + AXRole: AXSection + +PASS: fieldset + AXRole: AXGroup + +PASS: legend + AXRole: AXLabel + +PASS: form + AXRole: AXForm + +PASS: hgroup + AXRole: AXGroup + +PASS: h1 + AXRole: AXHeading + +PASS: h2 + AXRole: AXHeading + +PASS: h3 + AXRole: AXHeading + +PASS: h4 + AXRole: AXHeading + +PASS: h5 + AXRole: AXHeading + +PASS: h6 + AXRole: AXHeading + +PASS: hr + AXRole: AXSeparator + +PASS: img[alt='X'] + AXRole: AXImage + +PASS: input[type='button'] + AXRole: AXButton + +PASS: input[type='checkbox'] + AXRole: AXCheckBox + +PASS: input[type='date'] + AXRole: AXTextField + +PASS: input[type='datetime'] + AXRole: AXTextField + +PASS: input[type='datetime-local'] + AXRole: AXTextField + +PASS: input[type='email'] + AXRole: AXTextField + +PASS: input[type='file'] + AXRole: AXButton + +PASS: input[type='image'] + AXRole: AXButton + +PASS: input[type='month'] + AXRole: AXTextField + +PASS: input[type='number'] + AXRole: AXTextField + +PASS: input[type='password'] + AXRole: AXPasswordField + +PASS: input[type='radio'] + AXRole: AXRadioButton + +PASS: input[type='range'] + AXRole: AXSlider + +PASS: input[type='reset'] + AXRole: AXButton + +PASS: input[type='search'] + AXRole: AXTextField + +PASS: input[type='submit'] + AXRole: AXButton + +PASS: input[type='tel'] + AXRole: AXTextField + +PASS: input[type='text'] + AXRole: AXTextField + +PASS: input[type='time'] + AXRole: AXTextField + +PASS: input[type='url'] + AXRole: AXTextField + +PASS: input[type='week'] + AXRole: AXTextField + +PASS: ol + AXRole: AXList + +PASS: li + AXRole: AXListItem + +PASS: p + AXRole: AXParagraph + +PASS: pre + AXRole: AXGroup + +PASS: progress + AXRole: AXProgressIndicator + +PASS: select:not([multiple]) + AXRole: AXComboBox + +PASS: select[multiple] + AXRole: AXList + +PASS: option + AXRole: AXListItem + +PASS: optgroup + AXRole: AXListItem + +PASS: table + AXRole: AXTable + +FAIL: tr + + Expected: AXRow + +PASS: th + AXRole: AXCell + +FAIL: tr + + Expected: AXRow + +PA
[webkit-changes] [160450] trunk
Title: [160450] trunk Revision 160450 Author mario.pr...@samsung.com Date 2013-12-11 11:49:39 -0800 (Wed, 11 Dec 2013) Log Message [ATK] Expose accessibility objects WAI-ARIA landmark roles https://bugs.webkit.org/show_bug.cgi?id=125584 Reviewed by Chris Fleizach. Source/WebCore: Exposed accessibility objects with landmark roles with the proper AtkRole, to be provided by the next stable release of ATK. * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: (webkitAccessibleGetAttributes): (atkRole): Tools: Add mappings to DRT WKTR for landmark roles. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::role): * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::role): * gtk/jhbuild.modules: LayoutTests: Update test to unskip landmark elements and update expectations. * platform/gtk/accessibility/roles-exposed-expected.txt: * platform/gtk/accessibility/roles-exposed.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/LayoutTests/ChangeLog (160449 => 160450) --- trunk/LayoutTests/ChangeLog 2013-12-11 19:18:08 UTC (rev 160449) +++ trunk/LayoutTests/ChangeLog 2013-12-11 19:49:39 UTC (rev 160450) @@ -1,5 +1,17 @@ 2013-12-11 Mario Sanchez Prada mario.pr...@samsung.com +[ATK] Expose accessibility objects WAI-ARIA landmark roles +https://bugs.webkit.org/show_bug.cgi?id=125584 + +Reviewed by Chris Fleizach. + +Update test to unskip landmark elements and update expectations. + +* platform/gtk/accessibility/roles-exposed-expected.txt: +* platform/gtk/accessibility/roles-exposed.html: + +2013-12-11 Mario Sanchez Prada mario.pr...@samsung.com + [ATK] Add new layout test to check ATK roles in a central place https://bugs.webkit.org/show_bug.cgi?id=125525 Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (160449 => 160450) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-11 19:18:08 UTC (rev 160449) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2013-12-11 19:49:39 UTC (rev 160450) @@ -6,6 +6,12 @@ PASS: a[href] AXRole: AXLink +PASS: address + AXRole: AXLandmarkContentInfo + +PASS: aside + AXRole: AXLandmarkComplementary + PASS: blockquote AXRole: AXGroup @@ -24,6 +30,9 @@ PASS: form AXRole: AXForm +PASS: header + AXRole: AXLandmarkBanner + PASS: hgroup AXRole: AXGroup @@ -114,6 +123,9 @@ PASS: input[type='week'] AXRole: AXTextField +PASS: nav + AXRole: AXLandmarkNavigation + PASS: ol AXRole: AXList @@ -216,6 +228,12 @@ PASS: div[role=alertdialog] AXRole: AXAlert +PASS: div[role=application] + AXRole: AXEmbedded + +PASS: div[role=banner] + AXRole: AXLandmarkBanner + PASS: div[role=button] AXRole: AXButton @@ -225,6 +243,12 @@ PASS: div[role=combobox] AXRole: AXComboBox +PASS: div[role=complementary] + AXRole: AXLandmarkComplementary + +PASS: div[role=contentinfo] + AXRole: AXLandmarkContentInfo + PASS: div[role=directory] AXRole: AXList @@ -266,6 +290,9 @@ PASS: div[role=option] AXRole: AXListItem +PASS: div[role=main] + AXRole: AXLandmarkMain + PASS: div[role=menu] AXRole: AXMenu @@ -284,6 +311,9 @@ PASS: div[role=menuitemradio] AXRole: AXRadioMenuItem +PASS: div[role=navigation] + AXRole: AXLandmarkNavigation + PASS: div[role=progressbar] AXRole: AXProgressIndicator @@ -296,6 +326,9 @@ PASS: div[role=scrollbar] AXRole: AXScrollBar +PASS: div[role=search] + AXRole: AXLandmarkSearch + PASS: div[role=separator] AXRole: AXSeparator Modified: trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html (160449 => 160450) --- trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-11 19:18:08 UTC (rev 160449) +++ trunk/LayoutTests/platform/gtk/accessibility/roles-exposed.html 2013-12-11 19:49:39 UTC (rev 160450) @@ -10,10 +10,10 @@ a data-role=AXLink href="" data-note=[href] class=exX/a !-- skipped ATK: not focusable a data-role= data-note=:not([href]) class=exX/a-- !-- skipped ATK: not focusable abbr data-role= class=exX/abbr-- -!-- http://webkit.org/b/125493 address data-role=AXLandmarkContentInf
[webkit-changes] [160379] trunk
Title: [160379] trunk
Revision 160379
Author mario.pr...@samsung.com
Date 2013-12-10 12:11:18 -0800 (Tue, 10 Dec 2013)
Log Message
[ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
https://bugs.webkit.org/show_bug.cgi?id=125521
Reviewed by Chris Fleizach.
Source/WebCore:
Stop exposing alert dialogs as ATK_ROLE_DIALOG and do it as
ATK_ROLE_ALERT instead.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
Update expected result in layout test.
* accessibility/aria-mappings-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/aria-mappings-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (160378 => 160379)
--- trunk/LayoutTests/ChangeLog 2013-12-10 19:43:10 UTC (rev 160378)
+++ trunk/LayoutTests/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
@@ -1,3 +1,14 @@
+2013-12-10 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
+https://bugs.webkit.org/show_bug.cgi?id=125521
+
+Reviewed by Chris Fleizach.
+
+Update expected result in layout test.
+
+* accessibility/aria-mappings-expected.txt:
+
2013-12-10 László Langó la...@inf.u-szeged.hu
PageConsole::addMessage should automatically determine column number alongside line number
Modified: trunk/LayoutTests/accessibility/aria-mappings-expected.txt (160378 => 160379)
--- trunk/LayoutTests/accessibility/aria-mappings-expected.txt 2013-12-10 19:43:10 UTC (rev 160378)
+++ trunk/LayoutTests/accessibility/aria-mappings-expected.txt 2013-12-10 20:11:18 UTC (rev 160379)
@@ -21,7 +21,7 @@
role=alertdialog is a dialog which contains an alert message.
-Role for 'alertdialog' div is: AXRole: AXDialog
+Role for 'alertdialog' div is: AXRole: AXAlert
role=article is a section of a page that consists of a composition that forms an independent part of a document, page, or site
Modified: trunk/Source/WebCore/ChangeLog (160378 => 160379)
--- trunk/Source/WebCore/ChangeLog 2013-12-10 19:43:10 UTC (rev 160378)
+++ trunk/Source/WebCore/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
@@ -1,3 +1,16 @@
+2013-12-10 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
+https://bugs.webkit.org/show_bug.cgi?id=125521
+
+Reviewed by Chris Fleizach.
+
+Stop exposing alert dialogs as ATK_ROLE_DIALOG and do it as
+ATK_ROLE_ALERT instead.
+
+* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+(atkRole):
+
2013-12-10 Brendan Long b.l...@cablelabs.com
[GTK][GStreamer] media/video-preload.html is flakily crashing on WK2
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (160378 => 160379)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-10 19:43:10 UTC (rev 160378)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-10 20:11:18 UTC (rev 160379)
@@ -534,10 +534,10 @@
static AtkRole atkRole(AccessibilityRole role)
{
switch (role) {
+case ApplicationAlertDialogRole:
case ApplicationAlertRole:
return ATK_ROLE_ALERT;
case ApplicationDialogRole:
-case ApplicationAlertDialogRole:
return ATK_ROLE_DIALOG;
case ApplicationStatusRole:
return ATK_ROLE_STATUSBAR;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [160380] trunk
Title: [160380] trunk
Revision 160380
Author mario.pr...@samsung.com
Date 2013-12-10 12:12:56 -0800 (Tue, 10 Dec 2013)
Log Message
[ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
https://bugs.webkit.org/show_bug.cgi?id=125522
Reviewed by Chris Fleizach.
Source/WebCore:
Expose objects with SplitterRole role as ATK_ROLE_SEPARATOR.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Update strings representing ATK_ROLE_SEPARATOR for layout tests.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Update expected results in layout test for EFL and GTK.
* platform/efl-wk1/accessibility/lists-expected.txt:
* platform/efl-wk2/accessibility/lists-expected.txt:
* platform/gtk/accessibility/lists-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt
trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (160379 => 160380)
--- trunk/LayoutTests/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/ChangeLog 2013-12-10 20:12:56 UTC (rev 160380)
@@ -1,5 +1,18 @@
2013-12-10 Mario Sanchez Prada mario.pr...@samsung.com
+[ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
+https://bugs.webkit.org/show_bug.cgi?id=125522
+
+Reviewed by Chris Fleizach.
+
+Update expected results in layout test for EFL and GTK.
+
+* platform/efl-wk1/accessibility/lists-expected.txt:
+* platform/efl-wk2/accessibility/lists-expected.txt:
+* platform/gtk/accessibility/lists-expected.txt:
+
+2013-12-10 Mario Sanchez Prada mario.pr...@samsung.com
+
[ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
https://bugs.webkit.org/show_bug.cgi?id=125521
Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt (160379 => 160380)
--- trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/efl-wk1/accessibility/lists-expected.txt 2013-12-10 20:12:56 UTC (rev 160380)
@@ -84,7 +84,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
-AXRole: AXHorizontalRule
+AXRole: AXSeparator
AXParent: AXWebArea
AXChildren: 0
AXPosition: { 8.00, 288.00 }
Modified: trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt (160379 => 160380)
--- trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/lists-expected.txt 2013-12-10 20:12:56 UTC (rev 160380)
@@ -84,7 +84,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
-AXRole: AXHorizontalRule
+AXRole: AXSeparator
AXParent: AXWebArea
AXChildren: 0
AXPosition: { 0.00, 0.00 }
Modified: trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt (160379 => 160380)
--- trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt 2013-12-10 20:12:56 UTC (rev 160380)
@@ -84,7 +84,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
-AXRole: AXHorizontalRule
+AXRole: AXSeparator
AXParent: AXWebArea
AXChildren: 0
AXPosition: { 8.00, 276.00 }
Modified: trunk/Source/WebCore/ChangeLog (160379 => 160380)
--- trunk/Source/WebCore/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Source/WebCore/ChangeLog 2013-12-10 20:12:56 UTC (rev 160380)
@@ -1,5 +1,17 @@
2013-12-10 Mario Sanchez Prada mario.pr...@samsung.com
+[ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
+https://bugs.webkit.org/show_bug.cgi?id=125522
+
+Reviewed by Chris Fleizach.
+
+Expose objects with SplitterRole role as ATK_ROLE_SEPARATOR.
+
+* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+(atkRole):
+
+2013-12-10 Mario Sanchez Prada mario.pr...@samsung.com
+
[ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
https://bugs.webkit.org/show_bug.cgi?id=125521
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (160379 => 160380)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-10 20:11:18 UTC (rev 160379)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-10 20:12:56 UTC (rev 160380)
@@ -600,7 +600,7 @@
case SplitGroupRole:
return A
[webkit-changes] [160323] trunk
Title: [160323] trunk Revision 160323 Author mario.pr...@samsung.com Date 2013-12-09 12:16:50 -0800 (Mon, 09 Dec 2013) Log Message [ATK] Translate ATK_ROLE_SECTION into AXSection in DRT/WKTR https://bugs.webkit.org/show_bug.cgi?id=125456 Reviewed by Chris Fleizach. Tools: Return 'AXSection' for section roles instead of 'AXDiv'. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: LayoutTests: Update expectations for GTK and EFL that were expecting AXDiv for section roles, so they now expect AXSection. * accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: * accessibility/div-within-anchors-causes-crash-expected.txt: * platform/efl-wk1/accessibility/image-map2-expected.txt: * platform/efl-wk1/accessibility/transformed-element-expected.txt: * platform/efl-wk2/accessibility/image-map2-expected.txt: * platform/efl-wk2/accessibility/transformed-element-expected.txt: * platform/efl/accessibility/media-emits-object-replacement-expected.txt: * platform/gtk/accessibility/aria-roles-unignored-expected.txt: * platform/gtk/accessibility/aria-roles-unignored.html: * platform/gtk/accessibility/entry-and-password-expected.txt: * platform/gtk/accessibility/image-map2-expected.txt: * platform/gtk/accessibility/media-emits-object-replacement-expected.txt: * platform/gtk/accessibility/object-with-title-expected.txt: * platform/gtk/accessibility/object-with-title.html: * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: * platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: * platform/gtk/accessibility/spans-paragraphs-and-divs.html: * platform/gtk/accessibility/transformed-element-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement-expected.txt trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt trunk/LayoutTests/platform/efl-wk1/accessibility/transformed-element-expected.txt trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt trunk/LayoutTests/platform/efl-wk2/accessibility/transformed-element-expected.txt trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html trunk/LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt trunk/LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt trunk/LayoutTests/platform/gtk/accessibility/object-with-title.html trunk/LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html trunk/LayoutTests/platform/gtk/accessibility/transformed-element-expected.txt trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (160322 => 160323) --- trunk/LayoutTests/ChangeLog 2013-12-09 19:45:21 UTC (rev 160322) +++ trunk/LayoutTests/ChangeLog 2013-12-09 20:16:50 UTC (rev 160323) @@ -1,3 +1,32 @@ +2013-12-09 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] Translate ATK_ROLE_SECTION into AXSection in DRT/WKTR +https://bugs.webkit.org/show_bug.cgi?id=125456 + +Reviewed by Chris Fleizach. + +Update expectations for GTK and EFL that were expecting AXDiv for +section roles, so they now expect AXSection. + +* accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: +* accessibility/div-within-anchors-causes-crash-expected.txt: +* platform/efl-wk1/accessibility/image-map2-expected.txt: +* platform/efl-wk1/accessibility/transformed-element-expected.txt: +* platform/efl-wk2/accessibility/image-map2-expected.txt: +* platform/efl-wk2/accessibility/transformed-element-expected.txt: +* platform/efl/accessibility/media-emits-object-replacement-expected.txt: +* platform/gtk/accessibility/aria-roles-unignored-expected.txt: +* platform/gtk/accessibility/aria-roles-unignored.html: +* platform/gtk/accessibility/entry-and-password-expected.txt: +* platform/gtk/accessibility/image-map2-expected.txt: +* platform/gtk/accessibility/media-emits-object-replacement-expected.txt: +* platform/gtk/accessibility/object-with-title-expected.txt: +* platform/gtk/accessibility/object-with-title.h
[webkit-changes] [160095] trunk/LayoutTests
Title: [160095] trunk/LayoutTests Revision 160095 Author mario.pr...@samsung.com Date 2013-12-04 09:40:29 -0800 (Wed, 04 Dec 2013) Log Message Unreviewed GTK gardening. Updated expectations for GTK and share them with EFL. * accessibility/multiselect-list-reports-active-option-expected.txt: Renamed from LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt. * platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt Removed Paths trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt trunk/LayoutTests/platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (160094 => 160095) --- trunk/LayoutTests/ChangeLog 2013-12-04 16:40:17 UTC (rev 160094) +++ trunk/LayoutTests/ChangeLog 2013-12-04 17:40:29 UTC (rev 160095) @@ -1,3 +1,10 @@ +2013-12-04 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed GTK gardening. Updated expectations for GTK and share them with EFL. + +* accessibility/multiselect-list-reports-active-option-expected.txt: Renamed from LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt. +* platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt: Removed. + 2013-12-03 Alexey Proskuryakov a...@apple.com Update WebCrypto JWK mapping to newer proposal Copied: trunk/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt (from rev 160094, trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt) (0 => 160095) --- trunk/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt 2013-12-04 17:40:29 UTC (rev 160095) @@ -0,0 +1,27 @@ + +This tests that navigating in a multiselect list updates selection and the active selected option and sends a notification. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS accessibleOne.isSelected is true +PASS accessibleOne.isSelectedOptionActive is true +PASS accessibleTwo.isSelected is false +PASS accessibleTwo.isSelectedOptionActive is false +PASS accessibleThree.isSelected is false +PASS accessibleThree.isSelectedOptionActive is false +PASS accessibleOne.isSelected is false +PASS accessibleOne.isSelectedOptionActive is false +PASS accessibleTwo.isSelected is true +PASS accessibleTwo.isSelectedOptionActive is true +PASS accessibleThree.isSelected is false +PASS accessibleThree.isSelectedOptionActive is false +PASS accessibleOne.isSelected is false +PASS accessibleOne.isSelectedOptionActive is false +PASS accessibleTwo.isSelected is true +PASS accessibleTwo.isSelectedOptionActive is false +PASS accessibleThree.isSelected is true +PASS accessibleThree.isSelectedOptionActive is true + +TEST COMPLETE + Deleted: trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt (160094 => 160095) --- trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt 2013-12-04 16:40:17 UTC (rev 160094) +++ trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt 2013-12-04 17:40:29 UTC (rev 160095) @@ -1,27 +0,0 @@ - -This tests that navigating in a multiselect list updates selection and the active selected option and sends a notification. - -On success, you will see a series of PASS messages, followed by TEST COMPLETE. - - -PASS accessibleOne.isSelected is true -PASS accessibleOne.isSelectedOptionActive is true -PASS accessibleTwo.isSelected is false -PASS accessibleTwo.isSelectedOptionActive is false -PASS accessibleThree.isSelected is false -PASS accessibleThree.isSelectedOptionActive is false -PASS accessibleOne.isSelected is false -PASS accessibleOne.isSelectedOptionActive is false -PASS accessibleTwo.isSelected is true -PASS accessibleTwo.isSelectedOptionActive is true -PASS accessibleThree.isSelected is false -PASS accessibleThree.isSelectedOptionActive is false -PASS accessibleOne.isSelected is false -PASS accessibleOne.isSelectedOptionActive is false -PASS accessibleTwo.isSelected is true -PASS accessibleTwo.isSelectedOptionActive is false -PASS accessibleThree.isSelected is true -PASS accessibleThree.isSelectedOptionActive is true - -TEST COMPLETE - Deleted: trunk/LayoutTests/platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt (160094 => 160095) --- trunk/LayoutTests/platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt 2013-12-04 16:40:17 UTC (rev 160094) +++ trunk/LayoutTests/platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt 2013-12-04 17:40:29 UTC (rev 160095) @@ -1,27 +0,0 @@ -
[webkit-changes] [159182] trunk/Tools
Title: [159182] trunk/Tools Revision 159182 Author ma...@webkit.org Date 2013-11-13 03:07:57 -0800 (Wed, 13 Nov 2013) Log Message Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaselineTest.test_baseline_directory): Updated. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py Diff Modified: trunk/Tools/ChangeLog (159181 => 159182) --- trunk/Tools/ChangeLog 2013-11-13 10:02:00 UTC (rev 159181) +++ trunk/Tools/ChangeLog 2013-11-13 11:07:57 UTC (rev 159182) @@ -1,3 +1,10 @@ +2013-11-13 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot. + +* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: +(TestRebaselineTest.test_baseline_directory): Updated. + 2013-11-13 Krzysztof Czech k.cz...@samsung.com [ATK] Support compilation of EFL/GTK without accessibility Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py (159181 => 159182) --- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py 2013-11-13 10:02:00 UTC (rev 159181) +++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py 2013-11-13 11:07:57 UTC (rev 159182) @@ -94,6 +94,7 @@ self.assertMultiLineEqual(command._baseline_directory(Apple Mavericks Release WK2 (Tests)), /mock-checkout/LayoutTests/platform/mac-wk2) self.assertMultiLineEqual(command._baseline_directory(GTK Linux 64-bit Debug WK1), /mock-checkout/LayoutTests/platform/gtk-wk1) self.assertMultiLineEqual(command._baseline_directory(GTK Linux 64-bit Release WK1 (Tests)), /mock-checkout/LayoutTests/platform/gtk-wk1) +self.assertMultiLineEqual(command._baseline_directory(GTK Linux 64-bit Release), /mock-checkout/LayoutTests/platform/gtk-wk2) self.assertMultiLineEqual(command._baseline_directory(EFL Linux 64-bit Release WK2), /mock-checkout/LayoutTests/platform/efl-wk2) def test_rebaseline_updates_expectations_file_noop(self): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159107] trunk/LayoutTests
Title: [159107] trunk/LayoutTests Revision 159107 Author ma...@webkit.org Date 2013-11-12 06:56:28 -0800 (Tue, 12 Nov 2013) Log Message Unreviewed GTK gardening. Share expectations for vertical text among WK1 and WK2. * platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed. * platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed. * platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed. * platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Removed. * platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/gtk-wk2/fast/repaint/ trunk/LayoutTests/platform/gtk-wk2/fast/text/ Diff Modified: trunk/LayoutTests/ChangeLog (159106 => 159107) --- trunk/LayoutTests/ChangeLog 2013-11-12 14:53:14 UTC (rev 159106) +++ trunk/LayoutTests/ChangeLog 2013-11-12 14:56:28 UTC (rev 159107) @@ -1,3 +1,13 @@ +2013-11-12 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed GTK gardening. Share expectations for vertical text among WK1 and WK2. + +* platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed. +* platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed. +* platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed. +* platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Removed. +* platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Removed. + 2013-11-12 Michał Pakuła vel Rutka m.pak...@samsung.com Unreviewed EFL gardening ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [158914] trunk
Title: [158914] trunk Revision 158914 Author ma...@webkit.org Date 2013-11-08 02:55:38 -0800 (Fri, 08 Nov 2013) Log Message AX: [ATK] span elements exposed through ATK when not needed https://bugs.webkit.org/show_bug.cgi?id=123885 Reviewed by Chris Fleizach. Source/WebCore: As per SVN r158195, the way it's decided whether span elements should be ignored or not has slightly changed, causing that the GTK/EFL ports expose them in cases that they should be ignored, such as for text elements that neither are focusable (e.g. by explicitly setting tabindex) nor have a meaningful accessible name suggesting they should be exposed. As a result, the flattening that ATK based ports normally do for this kind of elements (by folding them into their parents) do not work correctly anymore, making two tests to fail: platform/gtk/accessibility/spans-paragraphs-and-divs.html platform/gtk/accessibility/spans.html This patch encapsulates the part of the logic that affects this in the computeAccessibilityIsIgnored() method, placing it in a new method of AccessibilityObject that we can call from ATK's accessibilityPlatformIncludesObject() to ensure we hide those span elements when they don't fulfill those requirements. * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::hasAttributesRequiredForInclusion): New virtual method encapsulating part of the logic from the function that computes whether accessibility should be ignored or not. * accessibility/AccessibilityObject.h: * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion): Override of the new method adding additional checks, as extracted from the original bits in computeAccessibilityIsIgnored(). * accessibility/AccessibilityNodeObject.h: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored): Use the newly added function where we had the original code before. * accessibility/atk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Make sure span elements are ignored if they are not focusable and they don't have a meaningful accessible name. LayoutTests: Removed failure expectations for tests now passing. * platform/gtk/TestExpectations: Removed expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (158913 => 158914) --- trunk/LayoutTests/ChangeLog 2013-11-08 10:24:39 UTC (rev 158913) +++ trunk/LayoutTests/ChangeLog 2013-11-08 10:55:38 UTC (rev 158914) @@ -1,3 +1,14 @@ +2013-11-08 Mario Sanchez Prada mario.pr...@samsung.com + +AX: [ATK] span elements exposed through ATK when not needed +https://bugs.webkit.org/show_bug.cgi?id=123885 + +Reviewed by Chris Fleizach. + +Removed failure expectations for tests now passing. + +* platform/gtk/TestExpectations: Removed expectations. + 2013-11-08 Krzysztof Czech k.cz...@samsung.com [GTK] accessibility/aria-link-supports-press.html is failing Modified: trunk/LayoutTests/platform/gtk/TestExpectations (158913 => 158914) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-08 10:24:39 UTC (rev 158913) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-08 10:55:38 UTC (rev 158914) @@ -1322,9 +1322,6 @@ webkit.org/b/114259 platform/gtk/accessibility/aria-slider-required-attributes.html [ Failure ] webkit.org/b/114259 platform/gtk/accessibility/combo-box-collapsed-selection-changed.html [ Failure ] -webkit.org/b/123885 platform/gtk/accessibility/spans-paragraphs-and-divs.html [ Failure ] -webkit.org/b/123885 platform/gtk/accessibility/spans.html [ Failure ] - webkit.org/b/114612 editing/style/block-style-005.html [ Failure ] webkit.org/b/115025 fast/events/constructors/mouse-event-constructor.html [ Failure ] Modified: trunk/Source/WebCore/ChangeLog (158913 => 158914) --- trunk/Source/WebCore/ChangeLog 2013-11-08 10:24:39 UTC (rev 158913) +++ trunk/Source/WebCore/ChangeLog 2013-11-08 10:55:38 UTC (rev 158914) @@ -1,3 +1,51 @@ +2013-11-08 Mario Sanchez Prada mario.pr...@samsung.com + +AX: [ATK] span elements exposed through ATK when not needed +https://bugs.webkit.org/show_bug.cgi?id=123885 + +Reviewed by Chris Fleizach. + +As per SVN r158195, the way it's decided whether span elements +should be ignored or not has slightly changed, causing that the +GTK/EFL ports expose them in cases that th
[webkit-changes] [158841] trunk
Title: [158841] trunk Revision 158841 Author ma...@webkit.org Date 2013-11-07 03:12:23 -0800 (Thu, 07 Nov 2013) Log Message AX: [ATK] Video and audio elements are not properly exposed https://bugs.webkit.org/show_bug.cgi?id=123894 Reviewed by Chris Fleizach. Source/WebCore: Expose audio and video elements with ATK_ROLE_EMBEDDED, so we can identify them properly from ATK/AT-SPI based ATs. Tests: platform/gtk/accessibility/media-controls-panel-title.html platform/efl/accessibility/media-emits-object-replacement.html platform/gtk/accessibility/media-emits-object-replacement.html * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: (atkRole): Add the new mapping. Tools: Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated. LayoutTests: Updated tests and expectations according to the new behavior. Updated failing test to reflect the new reality. * platform/gtk/accessibility/media-element-expected.txt: Updated. Extended GTK specific test by adding an audio element besides the video one and printing all the information about those related to their media nature. * platform/gtk/accessibility/media-controls-panel-title.html: Extended. * platform/gtk/accessibility/media-controls-panel-title-expected.txt: Updated. Added new tests for GTK and EFL to check that the replaced character is being properly emitter for both video and audio elements. Inspired in the ones in platform/mac, we use a different approach here to print the test since we don't have the textMarkerRangeForElement functionality in our DRT/WKTR, and because we expect embedded objects to show up in the results in a GTK/EFL specific way (using the obj string). * platform/efl/accessibility/media-emits-object-replacement-expected.txt: Added. * platform/efl/accessibility/media-emits-object-replacement.html: Added. * platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Added. * platform/gtk/accessibility/media-emits-object-replacement.html: Added. Removed tests with failure expectations that are now passing. * platform/gtk/TestExpectations: Removed passing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title-expected.txt trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title.html trunk/LayoutTests/platform/gtk/accessibility/media-element-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp Added Paths trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement-expected.txt trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement.html trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement.html Diff Modified: trunk/LayoutTests/ChangeLog (158840 => 158841) --- trunk/LayoutTests/ChangeLog 2013-11-07 11:04:16 UTC (rev 158840) +++ trunk/LayoutTests/ChangeLog 2013-11-07 11:12:23 UTC (rev 158841) @@ -1,3 +1,39 @@ +2013-11-07 Mario Sanchez Prada mario.pr...@samsung.com + +AX: [ATK] Video and audio elements are not properly exposed +https://bugs.webkit.org/show_bug.cgi?id=123894 + +Reviewed by Chris Fleizach. + +Updated tests and expectations according to the new behavior. + +Updated failing test to reflect the new reality. +* platform/gtk/accessibility/media-element-expected.txt: Updated. + +Extended GTK specific test by adding an audio element besides +the video one and printing all the information about those +related to their media nature. + +* platform/gtk/accessibility/media-controls-panel-title.html: Extended. +* platform/gtk/accessibility/media-controls-panel-title-expected.txt: Updated. + +Added new tests for GTK and EFL to check that the replaced +character is being properly emitter for both video and audio +elements. Inspired in the ones in platform/mac, we use a different +approach here to print the test since we don't have the +textMarkerRangeForElement functionality in our DRT/WKTR, and +because we expect embedded objects to show up in the results in a +GTK/EFL specific way (using the obj string). + +* platform/efl/accessibility/media-emits-object-replacement-expected.txt: Added. +* platform/efl/accessibility/media-emits-object-replacement.html: Added. +* platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Added. +* platform/gtk/accessibility/media-emits-obj
[webkit-changes] [158740] trunk/LayoutTests
Title: [158740] trunk/LayoutTests Revision 158740 Author ma...@webkit.org Date 2013-11-06 03:17:45 -0800 (Wed, 06 Nov 2013) Log Message Unreviewed GTK gardening. Tests failing after r158195 * platform/gtk/TestExpectations: Added failure expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (158739 => 158740) --- trunk/LayoutTests/ChangeLog 2013-11-06 11:11:07 UTC (rev 158739) +++ trunk/LayoutTests/ChangeLog 2013-11-06 11:17:45 UTC (rev 158740) @@ -1,3 +1,9 @@ +2013-11-06 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed GTK gardening. Tests failing after r158195 + +* platform/gtk/TestExpectations: Added failure expectations. + 2013-11-06 Ryosuke Niwa rn...@webkit.org Notify nodes removal to Range/Selection after dispatching blur and mutation event Modified: trunk/LayoutTests/platform/gtk/TestExpectations (158739 => 158740) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-06 11:11:07 UTC (rev 158739) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-06 11:17:45 UTC (rev 158740) @@ -1327,6 +1327,9 @@ webkit.org/b/114259 platform/gtk/accessibility/aria-slider-required-attributes.html [ Failure ] webkit.org/b/114259 platform/gtk/accessibility/combo-box-collapsed-selection-changed.html [ Failure ] +webkit.org/b/123885 platform/gtk/accessibility/spans-paragraphs-and-divs.html [ Failure ] +webkit.org/b/123885 platform/gtk/accessibility/spans.html [ Failure ] + webkit.org/b/114612 editing/style/block-style-005.html [ Failure ] webkit.org/b/115025 fast/events/constructors/mouse-event-constructor.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [158755] trunk/LayoutTests
Title: [158755] trunk/LayoutTests Revision 158755 Author ma...@webkit.org Date 2013-11-06 09:43:33 -0800 (Wed, 06 Nov 2013) Log Message Unreviewed GTK gardening. Media elements wrongly exposed after r158743. * platform/gtk/TestExpectations: Added failure expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (158754 => 158755) --- trunk/LayoutTests/ChangeLog 2013-11-06 17:39:01 UTC (rev 158754) +++ trunk/LayoutTests/ChangeLog 2013-11-06 17:43:33 UTC (rev 158755) @@ -1,3 +1,9 @@ +2013-11-06 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed GTK gardening. Media elements wrongly exposed after r158743. + +* platform/gtk/TestExpectations: Added failure expectations. + 2013-11-06 Krzysztof Czech k.cz...@samsung.com [ATK] Providing new table related accessibility expectations after r158742 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (158754 => 158755) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-06 17:39:01 UTC (rev 158754) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-06 17:43:33 UTC (rev 158755) @@ -1328,6 +1328,9 @@ webkit.org/b/123885 platform/gtk/accessibility/spans-paragraphs-and-divs.html [ Failure ] webkit.org/b/123885 platform/gtk/accessibility/spans.html [ Failure ] +webkit.org/b/123894 accessibility/media-element.html [ Failure ] +webkit.org/b/123894 platform/gtk/accessibility/media-controls-panel-title.html [ Failure ] + webkit.org/b/114612 editing/style/block-style-005.html [ Failure ] webkit.org/b/115025 fast/events/constructors/mouse-event-constructor.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [158666] trunk/LayoutTests
Title: [158666] trunk/LayoutTests Revision 158666 Author ma...@webkit.org Date 2013-11-05 06:50:09 -0800 (Tue, 05 Nov 2013) Log Message Unreviewed GTK gardening. Two tests pass after r158575 and r15856. * platform/gtk/TestExpectations: Removed passing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (158665 => 158666) --- trunk/LayoutTests/ChangeLog 2013-11-05 14:35:47 UTC (rev 158665) +++ trunk/LayoutTests/ChangeLog 2013-11-05 14:50:09 UTC (rev 158666) @@ -1,3 +1,9 @@ +2013-11-05 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed GTK gardening. Two tests pass after r158575 and r15856. + +* platform/gtk/TestExpectations: Removed passing tests. + 2013-11-05 Robert Plociennik r.plocien...@samsung.com [EFL] accessibility/svg-group-element-with-title.html is failing Modified: trunk/LayoutTests/platform/gtk/TestExpectations (158665 => 158666) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-05 14:35:47 UTC (rev 158665) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-05 14:50:09 UTC (rev 158666) @@ -880,13 +880,11 @@ webkit.org/b/98355 accessibility/aria-link-supports-press.html [ Failure ] webkit.org/b/98357 accessibility/aria-readonly.html [ Failure ] webkit.org/b/98359 accessibility/aria-text-role.html [ Failure ] -webkit.org/b/98361 accessibility/button-press-action.html [ Failure ] webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ] webkit.org/b/98371 accessibility/loading-iframe-updates-axtree.html [ Failure ] webkit.org/b/98372 accessibility/onclick-handlers.html [ Failure ] webkit.org/b/98375 accessibility/secure-textfield-title-ui.html [ Failure ] webkit.org/b/98377 accessibility/textarea-insertion-point-line-number.html [ Failure ] -webkit.org/b/98378 accessibility/textarea-line-for-index.html [ Failure ] webkit.org/b/98380 accessibility/th-as-title-ui.html [ Failure ] webkit.org/b/98382 accessibility/visible-elements.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [158428] trunk
Title: [158428] trunk Revision 158428 Author ma...@webkit.org Date 2013-11-01 03:59:33 -0700 (Fri, 01 Nov 2013) Log Message [ATK] Avoid explicit traversal of text controls and the render tree in AtkText implementation https://bugs.webkit.org/show_bug.cgi?id=123153 Reviewed by Chris Fleizach. Source/WebCore: Remove functions from the AtkText implementation that manually walk the render tree to compose the text for a exposed objects in certain cases (e.g. anonymous blocks, text controls). The reason for this change is that the current implementation follows an error-prone approach, since by doing things like manually walking the render tree from here we are not properly considering all the possible scenarios that might happen when traversing text. This, however, is a task that is better suited for the TextIterator, which is already written to consider all those cases and to emit the proper character in every single situation: text nodes, replaced objects and so on. So, by removing all that too specific code (textForObject() and textForRenderer() mainly) from WebKitAccessibleInterfaceText.cpp and relying in AccessibilityObject::textUnderElement(), which it ends up using the TextIterator for certain cases, we have a much better and robust method of retrieving the text associated with an instance of AtkObject implementing the AtkText interface. * accessibility/atk/WebKitAccessibleInterfaceText.cpp: (webkitAccessibleTextGetText): Removed call to textForObject(), now that we have just removed that function, together with textForRenderer(). Make AccessibilityRenderObject::textUnderElement() able to deal with anonymous blocks directly, by creating a range based in the boundaries defined by the first and last child renderers for that block. This will make possible to treat an anonymous block as a whole instead of having to rely in the concatenation of each of its children, as it does now. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::textUnderElement): Added a new code path to deal with anonymous blocks for text renderers, or when including all the children is explicitly requested. Modified TextIterator so text for children of replaced objects are ignored if we are emmiting the special character for those objects. * editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): Make sure no children are handled a replaced object if m_emitsObjectReplacementCharacters is set. * editing/TextIterator.h: Updated m_emitsObjectReplacementCharacters description to reflect the new behavior. LayoutTests: Updated test expectations to properly reflect the new reality when it comes to exposing replaced objects and anymous blocks. * platform/gtk/accessibility/table-with-rules-expected.txt: Updated to print \n explicitly for the two instances of BR that are present in the test, that will be included as part of an anonymous block. * platform/efl/accessibility/table-with-rules-expected.txt: Ditto. * platform/efl-wk2/accessibility/table-with-rules-expected.txt: Ditto. * platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated expectations not to expect the text of a button to be shown. * platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Ditto. * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Ditto. * platform/gtk/TestExpectations: Removed replaced-objects-in-anonymous-blocks.html from the list of expected failures, as it's now being properly exposed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt trunk/LayoutTests/platform/efl/accessibility/table-with-rules-expected.txt trunk/LayoutTests/platform/efl-wk2/accessibility/table-with-rules-expected.txt trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt trunk/LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt trunk/LayoutTests/platform/gtk/accessibility/table-with-rules-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp trunk/Source/WebCore/editing/TextIterator.cpp trunk/Source/WebCore/editing/TextIterator.h Diff Modified: trunk/LayoutTests/ChangeLog (158427 => 158428) --- trunk/LayoutTests/ChangeLog 2013-11-01 07:15:45 UTC (rev 158427) +++ trunk/LayoutTests/ChangeLog 2013-11-01 10:59:33 UTC (rev 158428) @@ -1,3 +1,27 @@ +2013-11-01 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] Avoid explicit traversal of text controls and the render tree in AtkText implementation +https://bugs.webkit.org/show_bug.cgi?id=123153 + +Reviewed by Chris Fleizach. + +Updated test expectations to properly reflect the new reality when it +comes to exposing repla
[webkit-changes] [158429] trunk/LayoutTests
Title: [158429] trunk/LayoutTests Revision 158429 Author ma...@webkit.org Date 2013-11-01 04:54:21 -0700 (Fri, 01 Nov 2013) Log Message Unreviewed GTK gardening. Tests passing after r158273 and r158352 and rebaseline needed after r158195. * platform/gtk/TestExpectations: Removed tests now passing. * platform/gtk/accessibility/media-element-expected.txt: Rebaseline. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/accessibility/media-element-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (158428 => 158429) --- trunk/LayoutTests/ChangeLog 2013-11-01 10:59:33 UTC (rev 158428) +++ trunk/LayoutTests/ChangeLog 2013-11-01 11:54:21 UTC (rev 158429) @@ -1,5 +1,13 @@ 2013-11-01 Mario Sanchez Prada mario.pr...@samsung.com +Unreviewed GTK gardening. Tests passing after r158273 and r158352 +and rebaseline needed after r158195. + +* platform/gtk/TestExpectations: Removed tests now passing. +* platform/gtk/accessibility/media-element-expected.txt: Rebaseline. + +2013-11-01 Mario Sanchez Prada mario.pr...@samsung.com + [ATK] Avoid explicit traversal of text controls and the render tree in AtkText implementation https://bugs.webkit.org/show_bug.cgi?id=123153 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (158428 => 158429) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-01 10:59:33 UTC (rev 158428) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-01 11:54:21 UTC (rev 158429) @@ -887,7 +887,6 @@ webkit.org/b/98375 accessibility/secure-textfield-title-ui.html [ Failure ] webkit.org/b/98377 accessibility/textarea-insertion-point-line-number.html [ Failure ] webkit.org/b/98378 accessibility/textarea-line-for-index.html [ Failure ] -webkit.org/b/98379 accessibility/textarea-selected-text-range.html [ Failure ] webkit.org/b/98380 accessibility/th-as-title-ui.html [ Failure ] webkit.org/b/98382 accessibility/visible-elements.html [ Failure ] @@ -1093,8 +1092,6 @@ webkit.org/b/61630 fast/events/dropzone-005.html [ Failure ] -webkit.org/b/67713 accessibility/textbox-role-reports-selection.html [ Failure ] - webkit.org/b/68278 http/tests/history/back-with-fragment-change.php [ Failure ] webkit.org/b/68512 accessibility/aria-hidden-updates-alldescendants.html [ Failure ] Modified: trunk/LayoutTests/platform/gtk/accessibility/media-element-expected.txt (158428 => 158429) --- trunk/LayoutTests/platform/gtk/accessibility/media-element-expected.txt 2013-11-01 10:59:33 UTC (rev 158428) +++ trunk/LayoutTests/platform/gtk/accessibility/media-element-expected.txt 2013-11-01 11:54:21 UTC (rev 158429) @@ -4,28 +4,32 @@ State at 'canplaythrough' event: -description: AXDescription: video playback -role: AXRole: AXToolbar +description: AXDescription: +role: AXRole: AXGroup description: AXDescription: video playback role: AXRole: AXToolbar -description: AXDescription: play -role: AXRole: AXButton +description: AXDescription: video playback +role: AXRole: AXToolbar -description: AXDescription: -role: AXRole: AXSlider +description: AXDescription: play +role: AXRole: AXButton -description: AXDescription: enter fullscreen -role: AXRole: AXButton +description: AXDescription: +role: AXRole: AXSlider -description: AXDescription: mute -role: AXRole: AXButton +description: AXDescription: enter fullscreen +role: AXRole: AXButton +description: AXDescription: mute +role: AXRole: AXButton + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [158104] trunk
Title: [158104] trunk Revision 158104 Author ma...@webkit.org Date 2013-10-28 02:57:48 -0700 (Mon, 28 Oct 2013) Log Message [GTK] Expose title and alternative text for links in image maps https://bugs.webkit.org/show_bug.cgi?id=84045 Reviewed by Chris Fleizach. Source/WebCore: Change the way we decide when the title attribute should be used for the accessible description, by not relying in the titleTagShouldBeUsedInDescriptionField() helper function but in whether we have found a visible text for it or not. This actually mimics what the Mac port does and so makes possible to share both the layout test and its expected results. * accessibility/atk/WebKitAccessibleUtil.cpp: (accessibilityDescription): Update the method to determine whether the title attribute should be used for the description. LayoutTests: Share test expectations among Mac, GTK and EFL ports and remove expected failures for GTK and EFL. * accessibility/image-map1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/image-map1-expected.txt. * platform/gtk/accessibility/image-map1-expected.txt: Removed. * platform/efl/TestExpectations: Removed failure expectations. * platform/gtk/TestExpectations: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp Added Paths trunk/LayoutTests/accessibility/image-map1-expected.txt Removed Paths trunk/LayoutTests/platform/gtk/accessibility/image-map1-expected.txt trunk/LayoutTests/platform/mac/accessibility/image-map1-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (158103 => 158104) --- trunk/LayoutTests/ChangeLog 2013-10-28 09:29:14 UTC (rev 158103) +++ trunk/LayoutTests/ChangeLog 2013-10-28 09:57:48 UTC (rev 158104) @@ -1,3 +1,18 @@ +2013-10-28 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Expose title and alternative text for links in image maps +https://bugs.webkit.org/show_bug.cgi?id=84045 + +Reviewed by Chris Fleizach. + +Share test expectations among Mac, GTK and EFL ports and +remove expected failures for GTK and EFL. + +* accessibility/image-map1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/image-map1-expected.txt. +* platform/gtk/accessibility/image-map1-expected.txt: Removed. +* platform/efl/TestExpectations: Removed failure expectations. +* platform/gtk/TestExpectations: Ditto. + 2013-10-26 Simon Fraser simon.fra...@apple.com Crashy WebGL test is crashy. Copied: trunk/LayoutTests/accessibility/image-map1-expected.txt (from rev 158103, trunk/LayoutTests/platform/mac/accessibility/image-map1-expected.txt) (0 => 158104) --- trunk/LayoutTests/accessibility/image-map1-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/image-map1-expected.txt 2013-10-28 09:57:48 UTC (rev 158104) @@ -0,0 +1,22 @@ + +This tests that you can reach the links within an image map. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +Link1 role: AXRole: AXLink +Link1 title: AXTitle: +Link1 description: AXDescription: Link1 + +Link2 role: AXRole: AXLink +Link2 title: AXTitle: +Link2 description: AXDescription: Link2 + +Link3 role: AXRole: AXLink +Link3 title: AXTitle: +Link3 description: AXDescription: Link3 + +PASS successfullyParsed is true + +TEST COMPLETE + Modified: trunk/LayoutTests/platform/efl/TestExpectations (158103 => 158104) --- trunk/LayoutTests/platform/efl/TestExpectations 2013-10-28 09:29:14 UTC (rev 158103) +++ trunk/LayoutTests/platform/efl/TestExpectations 2013-10-28 09:57:48 UTC (rev 158104) @@ -1413,7 +1413,6 @@ webkit.org/b/115659 accessibility/meter-element.html [ Missing ] webkit.org/b/121684 accessibility/aria-describedby-on-input.html [ Failure ] -webkit.org/b/84045 accessibility/image-map1.html [ Failure ] webkit.org/b/121593 accessibility/radio-button-title-label.html [ Failure ] # Newly added test at r139111 is failing. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (158103 => 158104) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-10-28 09:29:14 UTC (rev 158103) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-10-28 09:57:48 UTC (rev 158104) @@ -1403,8 +1403,6 @@ webkit.org/b/120596 css3/masking/mask-repeat-space-content.html [ ImageOnlyFailure ] webkit.org/b/120596 css3/masking/mask-repeat-space-padding.html [ ImageOnlyFailure ] -webkit.org/b/84045 accessibility/image-map1.html [ Failure ] - webkit.org/b/120836 fast/regions/text-region-split-vertical-rl.html [ Failure ] webkit.org/b/120839 animations/cross-fade-background-image.html [ ImageOnlyFailure ] Deleted: trunk/LayoutTests/platform/gtk/accessibility/image-map1-expected.txt (158103 => 158104) --- trunk/LayoutTests/platform/gtk/accessibility/image-ma
[webkit-changes] [157853] trunk/Source/WebKit2
Title: [157853] trunk/Source/WebKit2
Revision 157853
Author ma...@webkit.org
Date 2013-10-23 02:17:45 -0700 (Wed, 23 Oct 2013)
Log Message
[GTK] Add WebKit2 API for TLS errors
https://bugs.webkit.org/show_bug.cgi?id=120160
Patch by Brian Holt brian.h...@samsung.com on 2013-10-23
Reviewed by Mario Sanchez Prada.
Revert back to using PlatformCertificateInfo following the rollout
of https://bugs.webkit.org/show_bug.cgi?id=118520.
* Shared/soup/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
* Shared/soup/PlatformCertificateInfo.h:
* UIProcess/API/gtk/WebKitCertificateInfo.cpp:
(webkitCertificateInfoGetCertificateInfo):
* UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp
trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfo.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfoPrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (157852 => 157853)
--- trunk/Source/WebKit2/ChangeLog 2013-10-23 08:24:50 UTC (rev 157852)
+++ trunk/Source/WebKit2/ChangeLog 2013-10-23 09:17:45 UTC (rev 157853)
@@ -1,3 +1,20 @@
+2013-10-23 Brian Holt brian.h...@samsung.com
+
+[GTK] Add WebKit2 API for TLS errors
+https://bugs.webkit.org/show_bug.cgi?id=120160
+
+Reviewed by Mario Sanchez Prada.
+
+Revert back to using PlatformCertificateInfo following the rollout
+of https://bugs.webkit.org/show_bug.cgi?id=118520.
+
+* Shared/soup/PlatformCertificateInfo.cpp:
+(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
+* Shared/soup/PlatformCertificateInfo.h:
+* UIProcess/API/gtk/WebKitCertificateInfo.cpp:
+(webkitCertificateInfoGetCertificateInfo):
+* UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
+
2013-10-23 Tim Horton timothy_hor...@apple.com
Remote Layer Tree: Implement superlayer, removeFromSuperlayer, replaceSublayer, and adoptSublayers
Modified: trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp (157852 => 157853)
--- trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp 2013-10-23 08:24:50 UTC (rev 157852)
+++ trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp 2013-10-23 09:17:45 UTC (rev 157853)
@@ -54,6 +54,12 @@
{
}
+PlatformCertificateInfo::PlatformCertificateInfo(GTlsCertificate* certificate, GTlsCertificateFlags tlsErrors)
+: m_certificate(certificate)
+, m_tlsErrors(tlsErrors)
+{
+}
+
PlatformCertificateInfo::~PlatformCertificateInfo()
{
}
Modified: trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.h (157852 => 157853)
--- trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.h 2013-10-23 08:24:50 UTC (rev 157852)
+++ trunk/Source/WebKit2/Shared/soup/PlatformCertificateInfo.h 2013-10-23 09:17:45 UTC (rev 157853)
@@ -47,6 +47,7 @@
PlatformCertificateInfo();
explicit PlatformCertificateInfo(const WebCore::ResourceResponse);
explicit PlatformCertificateInfo(const WebCore::ResourceError);
+explicit PlatformCertificateInfo(GTlsCertificate*, GTlsCertificateFlags);
~PlatformCertificateInfo();
GTlsCertificate* certificate() const { return m_certificate.get(); }
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfo.cpp (157852 => 157853)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfo.cpp 2013-10-23 08:24:50 UTC (rev 157852)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfo.cpp 2013-10-23 09:17:45 UTC (rev 157853)
@@ -42,7 +42,7 @@
G_DEFINE_BOXED_TYPE(WebKitCertificateInfo, webkit_certificate_info, webkit_certificate_info_copy, webkit_certificate_info_free)
-const CertificateInfo webkitCertificateInfoGetCertificateInfo(WebKitCertificateInfo* info)
+const PlatformCertificateInfo webkitCertificateInfoGetCertificateInfo(WebKitCertificateInfo* info)
{
ASSERT(info);
return info-certificateInfo;
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfoPrivate.h (157852 => 157853)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfoPrivate.h 2013-10-23 08:24:50 UTC (rev 157852)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfoPrivate.h 2013-10-23 09:17:45 UTC (rev 157853)
@@ -20,7 +20,7 @@
#ifndef WebKitCertificateInfoPrivate_h
#define WebKitCertificateInfoPrivate_h
-#include CertificateInfo.h
+#include PlatformCertificateInfo.h
#include WebKitCertificateInfo.h
#include WebKitPrivate.h
@@ -35,9 +35,9 @@
{
}
-WebCore::CertificateInfo certificateInfo;
+WebKit::PlatformCertificateInfo certificateInfo;
};
-const WebCore::CertificateInfo webkitCertificateInfoGetCertificateInfo(WebKitCertificateInfo*);
+const WebKit::PlatformCertificateInfo webkitCertificateInfoGetCertificateInfo(WebKitCertificateInfo*);
#endif // WebKitCertifica
[webkit-changes] [157859] trunk
Title: [157859] trunk Revision 157859 Author ma...@webkit.org Date 2013-10-23 09:23:30 -0700 (Wed, 23 Oct 2013) Log Message [GTK] Expose image links properly https://bugs.webkit.org/show_bug.cgi?id=84044 Reviewed by Chris Fleizach. Tools: Expose the accessible URL if present, as yet another attribute for the AccessibilityUIElement wrapper. For coherence with what the Mac port does (and what you would expect as the output of the layout test), we strip the absolute URL path for relative references, if it's the case, leaving the base of the URL path out of the exposed string. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (attributesOfElement): Print the AXURL, if available. (AccessibilityUIElement::url): Expose the URL if present. That is, if the wrapped AtkObject implements AtkHyperlinkImpl. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (attributesOfElement): Print the AXURL, if available. (WTR::AccessibilityUIElement::url): Expose the URL if present. That is, if the wrapped AtkObject implements AtkHyperlinkImpl. LayoutTests: Rebaseline some tests that would now be printing the new AXURL string for implementations of AtkHyperlinkImpl. * platform/efl-wk1/accessibility/image-link-expected.txt: Updated. * platform/efl-wk1/accessibility/image-map2-expected.txt: Ditto. * platform/efl-wk2/accessibility/image-link-expected.txt: Ditto. * platform/efl-wk2/accessibility/image-map2-expected.txt: Ditto. * platform/gtk/accessibility/image-link-expected.txt: Ditto. * platform/gtk/accessibility/image-map2-expected.txt: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk1/accessibility/image-link-expected.txt trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt trunk/LayoutTests/platform/efl-wk2/accessibility/image-link-expected.txt trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt trunk/LayoutTests/platform/gtk/accessibility/image-link-expected.txt trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (157858 => 157859) --- trunk/LayoutTests/ChangeLog 2013-10-23 16:16:06 UTC (rev 157858) +++ trunk/LayoutTests/ChangeLog 2013-10-23 16:23:30 UTC (rev 157859) @@ -1,3 +1,20 @@ +2013-10-23 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Expose image links properly +https://bugs.webkit.org/show_bug.cgi?id=84044 + +Reviewed by Chris Fleizach. + +Rebaseline some tests that would now be printing the new +AXURL string for implementations of AtkHyperlinkImpl. + +* platform/efl-wk1/accessibility/image-link-expected.txt: Updated. +* platform/efl-wk1/accessibility/image-map2-expected.txt: Ditto. +* platform/efl-wk2/accessibility/image-link-expected.txt: Ditto. +* platform/efl-wk2/accessibility/image-map2-expected.txt: Ditto. +* platform/gtk/accessibility/image-link-expected.txt: Ditto. +* platform/gtk/accessibility/image-map2-expected.txt: Ditto. + 2013-10-23 Krzysztof Wolanski k.wolan...@samsung.com [GTK] accessibility/self-referencing-aria-labelledby.html is failing Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/image-link-expected.txt (157858 => 157859) --- trunk/LayoutTests/platform/efl-wk1/accessibility/image-link-expected.txt 2013-10-23 16:16:06 UTC (rev 157858) +++ trunk/LayoutTests/platform/efl-wk1/accessibility/image-link-expected.txt 2013-10-23 16:23:30 UTC (rev 157859) @@ -20,6 +20,7 @@ AXExpanded: 0 AXRequired: 0 AXChecked: 0 +AXURL: http://www.wowhead.com/?item=33924 AXPlatformAttributes: html-id:test, toolkit:WebKitEfl Child 0: @@ -39,6 +40,7 @@ AXExpanded: 0 AXRequired: 0 AXChecked: 0 +AXURL: LayoutTests/accessibility/resources/cake.png AXPlatformAttributes: toolkit:WebKitEfl Modified: trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt (157858 => 157859) --- trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt 2013-10-23 16:16:06 UTC (rev 157858) +++ trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt 2013-10-23 16:23:30 UTC (rev 157859) @@ -35,6 +35,7 @@ AXExpanded: 0 AXRequired: 0 AXChecked: 0 +AXURL: http://www.apple.com/ AXPlatformAttributes: toolkit:WebKitEfl AXRole: AXLink @@ -53,6 +54,7 @@ AXExpanded: 0 AXRequired: 0 AXChecked: 0 +AXURL: http://www.apple.com/ AXPlatformAttributes: toolkit:WebKitEfl Modified: trunk/LayoutTests/platform/efl-wk2/accessibility/image-link-expected.txt (157858 => 157859) --- trunk/LayoutTests/platform/efl-wk2/accessibility/image-link-expected.txt 2013-10-23 16:16:06 UTC (rev 157858) +++ trunk/LayoutTests/platform/efl-wk2/accessibility/image-link-expected.txt 2013-10-23 16:23:30 UTC (rev 1578
[webkit-changes] [157861] trunk/Source/WebKit2
Title: [157861] trunk/Source/WebKit2 Revision 157861 Author ma...@webkit.org Date 2013-10-23 09:49:08 -0700 (Wed, 23 Oct 2013) Log Message [GTK] Enable respect image orientation by default https://bugs.webkit.org/show_bug.cgi?id=122120 Patch by Anton Obzhirov a.obzhi...@samsung.com on 2013-10-23 Reviewed by Gustavo Noronha Silva. Add enable respect image orientation by default in GTK port. * UIProcess/API/gtk/WebKitSettings.cpp: (webKitSettingsConstructed): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (157860 => 157861) --- trunk/Source/WebKit2/ChangeLog 2013-10-23 16:38:47 UTC (rev 157860) +++ trunk/Source/WebKit2/ChangeLog 2013-10-23 16:49:08 UTC (rev 157861) @@ -1,3 +1,15 @@ +2013-10-23 Anton Obzhirov a.obzhi...@samsung.com + +[GTK] Enable respect image orientation by default +https://bugs.webkit.org/show_bug.cgi?id=122120 + +Reviewed by Gustavo Noronha Silva. + +Add enable respect image orientation by default in GTK port. + +* UIProcess/API/gtk/WebKitSettings.cpp: +(webKitSettingsConstructed): + 2013-10-23 Brian Holt brian.h...@samsung.com [GTK] Add WebKit2 API for TLS errors Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (157860 => 157861) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2013-10-23 16:38:47 UTC (rev 157860) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2013-10-23 16:49:08 UTC (rev 157861) @@ -147,6 +147,8 @@ bool regionBasedColumnsEnabled = features.isEnabled(ExperimentalFeatures::RegionBasedColumns); if (prefs-regionBasedColumnsEnabled() != regionBasedColumnsEnabled) prefs-setRegionBasedColumnsEnabled(regionBasedColumnsEnabled); + +prefs-setShouldRespectImageOrientation(true); } static void webKitSettingsSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [157718] trunk/Source/WebCore
Title: [157718] trunk/Source/WebCore
Revision 157718
Author ma...@webkit.org
Date 2013-10-21 07:02:03 -0700 (Mon, 21 Oct 2013)
Log Message
[ATK] Use atk_object_notify_state_change instead of manually emitting signals
https://bugs.webkit.org/show_bug.cgi?id=122968
Patch by Anton Obzhirov a.obzhi...@samsung.com on 2013-10-21
Reviewed by Mario Sanchez Prada.
Refactor emitting state-change event to use atk_object_notify_state_change
instead of using g_signal_emit_by_name.
* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleDetach):
* editing/atk/FrameSelectionAtk.cpp:
(WebCore::maybeEmitTextFocusChange):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
trunk/Source/WebCore/editing/atk/FrameSelectionAtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (157717 => 157718)
--- trunk/Source/WebCore/ChangeLog 2013-10-21 09:53:08 UTC (rev 157717)
+++ trunk/Source/WebCore/ChangeLog 2013-10-21 14:02:03 UTC (rev 157718)
@@ -1,3 +1,23 @@
+2013-10-21 Anton Obzhirov a.obzhi...@samsung.com
+
+[ATK] Use atk_object_notify_state_change instead of manually emitting signals
+https://bugs.webkit.org/show_bug.cgi?id=122968
+
+Reviewed by Mario Sanchez Prada.
+
+Refactor emitting state-change event to use atk_object_notify_state_change
+instead of using g_signal_emit_by_name.
+
+* accessibility/atk/AXObjectCacheAtk.cpp:
+(WebCore::notifyChildrenSelectionChange):
+(WebCore::AXObjectCache::postPlatformNotification):
+(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
+(WebCore::AXObjectCache::handleFocusedUIElementChanged):
+* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+(webkitAccessibleDetach):
+* editing/atk/FrameSelectionAtk.cpp:
+(WebCore::maybeEmitTextFocusChange):
+
2013-10-21 Gyuyoung Kim gyuyoung@samsung.com
Make TYPE_CASTS_BASE more flexible
Modified: trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (157717 => 157718)
--- trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2013-10-21 09:53:08 UTC (rev 157717)
+++ trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2013-10-21 14:02:03 UTC (rev 157718)
@@ -121,15 +121,15 @@
// Old focused object just lost focus, so emit the events.
if (axOldFocusedObject axItem != axOldFocusedObject) {
g_signal_emit_by_name(axOldFocusedObject, focus-event, false);
-g_signal_emit_by_name(axOldFocusedObject, state-change, focused, false);
+atk_object_notify_state_change(axOldFocusedObject, ATK_STATE_FOCUSED, false);
}
// Emit needed events for the currently (un)selected item.
if (axItem) {
bool isSelected = item-isSelected();
-g_signal_emit_by_name(axItem, state-change, selected, isSelected);
+atk_object_notify_state_change(axItem, ATK_STATE_SELECTED, isSelected);
g_signal_emit_by_name(axItem, focus-event, isSelected);
-g_signal_emit_by_name(axItem, state-change, focused, isSelected);
+atk_object_notify_state_change(axItem, ATK_STATE_FOCUSED, isSelected);
}
// Update pointers to the previously involved objects.
@@ -146,11 +146,11 @@
if (notification == AXCheckedStateChanged) {
if (!coreObject-isCheckboxOrRadio())
return;
-g_signal_emit_by_name(axObject, state-change, checked, coreObject-isChecked());
+atk_object_notify_state_change(axObject, ATK_STATE_CHECKED, coreObject-isChecked());
} else if (notification == AXSelectedChildrenChanged || notification == AXMenuListValueChanged) {
if (notification == AXMenuListValueChanged coreObject-isMenuList()) {
g_signal_emit_by_name(axObject, focus-event, true);
-g_signal_emit_by_name(axObject, state-change, focused, true);
+atk_object_notify_state_change(axObject, ATK_STATE_FOCUSED, true);
}
notifyChildrenSelectionChange(coreObject);
} else if (notification == AXValueChanged) {
@@ -165,7 +165,7 @@
g_signal_emit_by_name(ATK_OBJECT(axObject), property-change::accessible-value, propertyValues, NULL);
} else if (notification == AXInvalidStatusChanged)
-g_signal_emit_by_name(axObject, state-change, invalid-entry, coreObject-invalidStatus() != false);
+atk_object_notify_state_change(axObject, ATK_STATE_INVALID_ENTRY, coreObject-invalidStatus() != false);
}
void AXObjectCache::nodeTextChangePlatformNotification(AccessibilityObject* object, AXTextChange textChange, unsigned offset, const Strin
[webkit-changes] [157628] trunk/Source/WebCore
Title: [157628] trunk/Source/WebCore
Revision 157628
Author ma...@webkit.org
Date 2013-10-18 03:15:13 -0700 (Fri, 18 Oct 2013)
Log Message
[ATK] Simplify implementation of atk_text_get_text
https://bugs.webkit.org/show_bug.cgi?id=122644
Reviewed by Chris Fleizach.
Simplified code so we only call textUnderElement() directly once
and only when needed. Also, moved the specific code for ColorWell
objects up to the beginning of that function, so we don't do any
additional efforts like computing text ranges in those cases.
No new tests are needed, just to make sure that the current layout
and unit tests are still passing, which they are.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(textForObject): Fixed a issue that got detected while working on
this patch, which was causing a '\n' to be artificially appended
at the end of text controls all the time.
(webkitAccessibleTextGetText): Simplified function.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::doAXStringForRange): Removed
the check that prevents from pass ranges exceeding the limits of
the element's text, since those will be checked anyway when
calling String::substring().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (157627 => 157628)
--- trunk/Source/WebCore/ChangeLog 2013-10-18 09:17:16 UTC (rev 157627)
+++ trunk/Source/WebCore/ChangeLog 2013-10-18 10:15:13 UTC (rev 157628)
@@ -1,3 +1,30 @@
+2013-10-18 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Simplify implementation of atk_text_get_text
+https://bugs.webkit.org/show_bug.cgi?id=122644
+
+Reviewed by Chris Fleizach.
+
+Simplified code so we only call textUnderElement() directly once
+and only when needed. Also, moved the specific code for ColorWell
+objects up to the beginning of that function, so we don't do any
+additional efforts like computing text ranges in those cases.
+
+No new tests are needed, just to make sure that the current layout
+and unit tests are still passing, which they are.
+
+* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+(textForObject): Fixed a issue that got detected while working on
+this patch, which was causing a '\n' to be artificially appended
+at the end of text controls all the time.
+(webkitAccessibleTextGetText): Simplified function.
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::doAXStringForRange): Removed
+the check that prevents from pass ranges exceeding the limits of
+the element's text, since those will be checked anyway when
+calling String::substring().
+
2013-10-18 Brendan Long b.l...@cablelabs.com
[GStreamer][GTK] Add GRefPtr::outPtr()
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (157627 => 157628)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2013-10-18 09:17:16 UTC (rev 157627)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2013-10-18 10:15:13 UTC (rev 157628)
@@ -2094,9 +2094,6 @@
return String();
String elementText = isPasswordField() ? passwordFieldValue() : text();
-if (range.start + range.length elementText.length())
-return String();
-
return elementText.substring(range.start, range.length);
}
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (157627 => 157628)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-10-18 09:17:16 UTC (rev 157627)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-10-18 10:15:13 UTC (rev 157628)
@@ -148,12 +148,14 @@
int lineNumber = 0;
PlainTextRange range = coreObject-doAXRangeForLine(lineNumber);
while (range.length) {
-// When a line of text wraps in a text area, the final space is removed.
-if (range.start + range.length textLength)
-range.length -= 1;
String lineText = coreObject-doAXStringForRange(range);
g_string_append(str, lineText.utf8().data());
-g_string_append(str, \n);
+
+// When a line of text wraps in a text area, the final space
+// after each non-final line must be replaced with a line break.
+if (range.start + range.length textLength)
+g_string_overwrite_len(str, str-len - 1, \n, 1);
+
range = coreObject-doAXRangeForLine(++lineNumber);
}
} else if (coreObject-isAccessibilityRenderObject()) {
@@ -569,12 +571,13 @@
AccessibilityObject* coreObject = core(text);
-int end = endOffset;
-if (endOff
[webkit-changes] [157394] trunk
Title: [157394] trunk Revision 157394 Author ma...@webkit.org Date 2013-10-14 03:41:26 -0700 (Mon, 14 Oct 2013) Log Message [EFL] Present replaced objects with 0xFFFC character https://bugs.webkit.org/show_bug.cgi?id=122744 Patch by Krzysztof Czech k.cz...@samsung.com on 2013-10-14 Reviewed by Mario Sanchez Prada. Source/WebCore: Replaced elements should be emitted in GTK/EFL and marked their presence with the replacement character. * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::textIteratorBehaviorForTextRange): LayoutTests: Added new accessibility expectation after r156532. * platform/efl-wk2/TestExpectations: * platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityObject.cpp Added Paths trunk/LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (157393 => 157394) --- trunk/LayoutTests/ChangeLog 2013-10-14 10:36:39 UTC (rev 157393) +++ trunk/LayoutTests/ChangeLog 2013-10-14 10:41:26 UTC (rev 157394) @@ -1,3 +1,15 @@ +2013-10-14 Krzysztof Czech k.cz...@samsung.com + +[EFL] Present replaced objects with 0xFFFC character +https://bugs.webkit.org/show_bug.cgi?id=122744 + +Reviewed by Mario Sanchez Prada. + +Added new accessibility expectation after r156532. + +* platform/efl-wk2/TestExpectations: +* platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added. + 2013-09-16 Sergio Villar Senin svil...@igalia.com [CSS Grid Layout] Implement support for flex Added: trunk/LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt (0 => 157394) --- trunk/LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt (rev 0) +++ trunk/LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt 2013-10-14 10:41:26 UTC (rev 157394) @@ -0,0 +1,41 @@ +Before + +After + +End of test + +This tests that deleting an iframe doesn't cause the accessibility cache to be destroyed and recreated. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + + +Before: +AXRole: AXScrollArea +AXRole: AXWebArea +AXRole: AXParagraph AXValue: Before +AXRole: AXGroup AXValue: obj +AXRole: AXScrollArea +AXRole: AXWebArea +AXRole: AXGroup AXValue: objClick me +AXRole: AXButton +AXRole: AXParagraph AXValue: After +AXRole: AXParagraph AXValue: End of test + +After: +AXRole: AXScrollArea +AXRole: AXWebArea +AXRole: AXParagraph AXValue: Before +AXRole: AXParagraph AXValue: After +AXRole: AXParagraph AXValue: End of test + +PASS frameBodyRole == frameBody.role is false +PASS frameGroupRole == frameGroup.role is false +PASS frameButtonRole == frameButton.role is false +PASS root.isEqual(newRoot) is true +PASS body.isEqual(newBody) is true +PASS before.isEqual(newBefore) is true +PASS after.isEqual(newAfter) is true + +TEST COMPLETE + Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (157393 => 157394) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-10-14 10:36:39 UTC (rev 157393) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-10-14 10:41:26 UTC (rev 157394) @@ -180,7 +180,6 @@ webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ] -accessibility/deleting-iframe-destroys-axcache.html [ Skip ] accessibility/img-fallsback-to-title.html [ Skip ] accessibility/internal-link-anchors2.html [ Skip ] accessibility/media-element.html [ Skip ] Modified: trunk/Source/WebCore/ChangeLog (157393 => 157394) --- trunk/Source/WebCore/ChangeLog 2013-10-14 10:36:39 UTC (rev 157393) +++ trunk/Source/WebCore/ChangeLog 2013-10-14 10:41:26 UTC (rev 157394) @@ -1,3 +1,16 @@ +2013-10-14 Krzysztof Czech k.cz...@samsung.com + +[EFL] Present replaced objects with 0xFFFC character +https://bugs.webkit.org/show_bug.cgi?id=122744 + +Reviewed by Mario Sanchez Prada. + +Replaced elements should be emitted in GTK/EFL and +marked their presence with the replacement character. + +* accessibility/AccessibilityObject.cpp: +(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange): + 2013-09-16 Sergio Villar Senin svil...@igalia.com [CSS Grid Layout] Implement support for flex Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (157393 => 157394) --- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2013-10-14 10:36:39 UTC (rev 157393) +++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2013-10-14 10
[webkit-changes] [157095] trunk/LayoutTests
Title: [157095] trunk/LayoutTests
Revision 157095
Author ma...@webkit.org
Date 2013-10-08 03:45:36 -0700 (Tue, 08 Oct 2013)
Log Message
Unreviewed GTK gardening. Name for tables are now properly showing
up when exposing information for the parent of a table's cell.
* platform/gtk/accessibility/table-cells-expected.txt: Updated.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (157094 => 157095)
--- trunk/LayoutTests/ChangeLog 2013-10-08 09:56:51 UTC (rev 157094)
+++ trunk/LayoutTests/ChangeLog 2013-10-08 10:45:36 UTC (rev 157095)
@@ -1,3 +1,10 @@
+2013-10-08 Mario Sanchez Prada mario.pr...@samsung.com
+
+Unreviewed GTK gardening. Name for tables are now properly showing
+up when exposing information for the parent of a table's cell.
+
+* platform/gtk/accessibility/table-cells-expected.txt: Updated.
+
2013-10-07 Grzegorz Czajkowski g.czajkow...@samsung.com
context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901
Modified: trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt (157094 => 157095)
--- trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt 2013-10-08 09:56:51 UTC (rev 157094)
+++ trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt 2013-10-08 10:45:36 UTC (rev 157095)
@@ -11,7 +11,7 @@
[0,0]
AXRole: AXCell
-AXParent: AXTable
+AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 235.00, 26.00 }
AXSize: { 144.00, 63.00 }
@@ -31,7 +31,7 @@
[3,1]
AXRole: AXCell
-AXParent: AXTable
+AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 447.00, 55.00 }
AXSize: { 53.00, 34.00 }
@@ -51,7 +51,7 @@
[1,1]
AXRole: AXCell
-AXParent: AXTable
+AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 227.00, 26.00 }
AXSize: { 143.00, 63.00 }
@@ -71,7 +71,7 @@
[2,2]
AXRole: AXCell
-AXParent: AXTable
+AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 370.00, 89.00 }
AXSize: { 69.00, 29.00 }
@@ -91,7 +91,7 @@
[3,5]
AXRole: AXCell
-AXParent: AXTable
+AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 439.00, 176.00 }
AXSize: { 52.00, 29.00 }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [157096] trunk
Title: [157096] trunk
Revision 157096
Author ma...@webkit.org
Date 2013-10-08 03:55:25 -0700 (Tue, 08 Oct 2013)
Log Message
[ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
https://bugs.webkit.org/show_bug.cgi?id=122104
Reviewed by Chris Fleizach.
Source/WebCore:
Map invalid state of an AccessibilityObject to the proper AtkState.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject): Add the mapping.
Tools:
Updated stringAttributeValue to double check that the exposure of
aria-invalid as a state is consistent with its exposure as a text
attribute as well, when it applies (implementations of AtkText).
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringAttributeValue): Add double check.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (157095 => 157096)
--- trunk/Source/WebCore/ChangeLog 2013-10-08 10:45:36 UTC (rev 157095)
+++ trunk/Source/WebCore/ChangeLog 2013-10-08 10:55:25 UTC (rev 157096)
@@ -1,3 +1,15 @@
+2013-10-08 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
+https://bugs.webkit.org/show_bug.cgi?id=122104
+
+Reviewed by Chris Fleizach.
+
+Map invalid state of an AccessibilityObject to the proper AtkState.
+
+* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+(setAtkStateSetFromCoreObject): Add the mapping.
+
2013-10-07 Carlos Garcia Campos cgar...@igalia.com
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (157095 => 157096)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-10-08 10:45:36 UTC (rev 157095)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-10-08 10:55:25 UTC (rev 157096)
@@ -725,6 +725,9 @@
if (coreObject-isIndeterminate())
atk_state_set_add_state(stateSet, ATK_STATE_INDETERMINATE);
+if (coreObject-invalidStatus() != false)
+atk_state_set_add_state(stateSet, ATK_STATE_INVALID_ENTRY);
+
if (coreObject-isMultiSelectable())
atk_state_set_add_state(stateSet, ATK_STATE_MULTISELECTABLE);
Modified: trunk/Tools/ChangeLog (157095 => 157096)
--- trunk/Tools/ChangeLog 2013-10-08 10:45:36 UTC (rev 157095)
+++ trunk/Tools/ChangeLog 2013-10-08 10:55:25 UTC (rev 157096)
@@ -1,3 +1,19 @@
+2013-10-08 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
+https://bugs.webkit.org/show_bug.cgi?id=122104
+
+Reviewed by Chris Fleizach.
+
+Updated stringAttributeValue to double check that the exposure of
+aria-invalid as a state is consistent with its exposure as a text
+attribute as well, when it applies (implementations of AtkText).
+
+* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+(AccessibilityUIElement::stringAttributeValue): Add double check.
+* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
+
2013-10-07 Filip Pizlo fpi...@apple.com
run-jsc-stress-tests progress meter should update more quickly on older Rubies
Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (157095 => 157096)
--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-10-08 10:45:36 UTC (rev 157095)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-10-08 10:55:25 UTC (rev 157096)
@@ -1038,6 +1038,20 @@
if (attributeValue.isEmpty() ATK_IS_TEXT(m_element))
attributeValue = getAttributeSetValueForId(ATK_OBJECT(m_element), TextAttributeType, atkAttributeName);
+// Additional check to make sure that the exposure of the state ATK_STATE_INVALID_ENTRY
+// is consistent with the exposure of aria-invalid as a text attribute, if present.
+if (atkAttributeName == attributesMap[InvalidNameIndex][AtkDomain]) {
+bool isInvalidState = checkElementState(m_element, ATK_STATE_INVALID_ENTRY);
+if (attributeValue.isEmpty())
+return JSStringCreateWithUTF8CString(isInvalidState ? true : false);
+
+// If the text attribute was there, check that it's consistent with
+// what the state says or force the test to fail otherwise.
+bool isAriaInvalid = attributeValue != false;
+if (isInvalidState != isAriaInvalid)
+return JSStringCreateWithCharacters(0, 0);
+}
+
return JSStringCreateWithUTF8CString(attribu
[webkit-changes] [156645] trunk/LayoutTests
Title: [156645] trunk/LayoutTests Revision 156645 Author ma...@webkit.org Date 2013-09-30 03:56:08 -0700 (Mon, 30 Sep 2013) Log Message Unreviewed GTK gardening. Two tests are passing in WK2 after r156541. * platform/gtk-wk2/TestExpectations: Removed passing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (156644 => 156645) --- trunk/LayoutTests/ChangeLog 2013-09-30 10:46:52 UTC (rev 156644) +++ trunk/LayoutTests/ChangeLog 2013-09-30 10:56:08 UTC (rev 156645) @@ -1,3 +1,9 @@ +2013-09-30 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed GTK gardening. Two tests are passing in WK2 after r156541. + +* platform/gtk-wk2/TestExpectations: Removed passing tests. + 2013-09-30 Krzysztof Czech k.cz...@samsung.com [EFL] Accessibility tests pass after r156532 and r156551 Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (156644 => 156645) --- trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-09-30 10:46:52 UTC (rev 156644) +++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-09-30 10:56:08 UTC (rev 156645) @@ -359,11 +359,9 @@ # accessibility/ failures webkit.org/b/106338 accessibility/aria-hidden-updates-alldescendants.html [ Failure ] webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ] -webkit.org/b/106345 platform/gtk/accessibility/input-slider.html [ Failure ] webkit.org/b/116970 accessibility/multiselect-list-reports-active-option.html [ Failure ] webkit.org/b/116971 accessibility/poorly-formed-aria-table.html [ Failure ] webkit.org/b/106346 accessibility/svg-remote-element.html [ Failure ] -webkit.org/b/116973 platform/gtk/accessibility/caret-browsing-select-focus.html [ Failure ] # svg/ failures webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [156530] trunk
Title: [156530] trunk
Revision 156530
Author ma...@webkit.org
Date 2013-09-27 01:58:08 -0700 (Fri, 27 Sep 2013)
Log Message
[ATK] accessibility/aria-sort.html is failing after r156409
https://bugs.webkit.org/show_bug.cgi?id=121947
Reviewed by Chris Fleizach.
Source/WebCore:
The WAI-ARIA spec says to translate the value as is from the
attribute, so do just that instead of mapping values from the
AccessibilitySortDirection enumeration into strings.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Do the right mapping for aria-sort.
Tools:
Implement AccessibilityUIElement::isSupported for the ATK
platforms, just by checking whether we have an associated object
attribute exposed for the wrapper object matching the required
attribute in the layout test (e.g AXSortDirection - sort).
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isAttributeSupported): Implemented.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (156529 => 156530)
--- trunk/Source/WebCore/ChangeLog 2013-09-27 07:48:50 UTC (rev 156529)
+++ trunk/Source/WebCore/ChangeLog 2013-09-27 08:58:08 UTC (rev 156530)
@@ -1,3 +1,18 @@
+2013-09-27 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] accessibility/aria-sort.html is failing after r156409
+https://bugs.webkit.org/show_bug.cgi?id=121947
+
+Reviewed by Chris Fleizach.
+
+The WAI-ARIA spec says to translate the value as is from the
+attribute, so do just that instead of mapping values from the
+AccessibilitySortDirection enumeration into strings.
+http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property
+
+* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+(webkitAccessibleGetAttributes): Do the right mapping for aria-sort.
+
2013-09-26 Gyuyoung Kim gyuyoung@samsung.com
Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue()
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (156529 => 156530)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-09-27 07:48:50 UTC (rev 156529)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-09-27 08:58:08 UTC (rev 156530)
@@ -497,8 +497,9 @@
AccessibilitySortDirection sortDirection = coreObject-sortDirection();
if (sortDirection != SortDirectionNone) {
-attributeSet = addToAtkAttributeSet(attributeSet, sort,
-sortDirection == SortDirectionAscending ? ascending : descending);
+// WAI-ARIA spec says to translate the value as is from the attribute.
+const AtomicString sortAttribute = coreObject-getAttribute(HTMLNames::aria_sortAttr);
+attributeSet = addToAtkAttributeSet(attributeSet, sort, sortAttribute.string().utf8().data());
}
return attributeSet;
Modified: trunk/Tools/ChangeLog (156529 => 156530)
--- trunk/Tools/ChangeLog 2013-09-27 07:48:50 UTC (rev 156529)
+++ trunk/Tools/ChangeLog 2013-09-27 08:58:08 UTC (rev 156530)
@@ -1,3 +1,20 @@
+2013-09-27 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] accessibility/aria-sort.html is failing after r156409
+https://bugs.webkit.org/show_bug.cgi?id=121947
+
+Reviewed by Chris Fleizach.
+
+Implement AccessibilityUIElement::isSupported for the ATK
+platforms, just by checking whether we have an associated object
+attribute exposed for the wrapper object matching the required
+attribute in the layout test (e.g AXSortDirection - sort).
+
+* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+(AccessibilityUIElement::isAttributeSupported): Implemented.
+* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+(WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
+
2013-09-26 Eric Carlson eric.carl...@apple.com
[MediaStream] make MediaStream testable
Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (156529 => 156530)
--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-09-27 07:48:50 UTC (rev 156529)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-09-27 08:58:08 UTC (rev 156530)
@@ -948,7 +948,15 @@
bool AccessibilityUIElement::isAttributeSupported(JSStringRef attribute)
{
-return false;
+if (!ATK_IS_OBJECT(m_element))
+return false;
+
+String atkA
[webkit-changes] [156531] trunk/Tools
Title: [156531] trunk/Tools Revision 156531 Author ma...@webkit.org Date 2013-09-27 02:07:17 -0700 (Fri, 27 Sep 2013) Log Message [ATK] Normalize checks in entry points for DRT and WKTR https://bugs.webkit.org/show_bug.cgi?id=121959 Reviewed by Chris Fleizach. Always check if we have a proper instance of AtkObject, implementing the interfaces that we might need for each case, at the entry point of every method of AccessibilityUIElement for ATK, and do those checks in an uniform way across DRT and WKTR, to avoid confusion and issues when modifying these files in the future. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::getChildren): Use normalized checks. (AccessibilityUIElement::getChildrenWithRange): Ditto. (AccessibilityUIElement::rowCount): Ditto. (AccessibilityUIElement::columnCount): Ditto. (AccessibilityUIElement::childrenCount): Ditto. (AccessibilityUIElement::elementAtPoint): Ditto. (AccessibilityUIElement::getChildAtIndex): Ditto. (AccessibilityUIElement::allAttributes): Ditto. (AccessibilityUIElement::titleUIElement): Ditto. (AccessibilityUIElement::parentElement): Ditto. (AccessibilityUIElement::attributesOfChildren): Ditto. (AccessibilityUIElement::role): Ditto. (AccessibilityUIElement::title): Ditto. (AccessibilityUIElement::description): Ditto. (AccessibilityUIElement::stringValue): Ditto. (AccessibilityUIElement::language): Ditto. (AccessibilityUIElement::x): Ditto. (AccessibilityUIElement::y): Ditto. (AccessibilityUIElement::width): Ditto. (AccessibilityUIElement::height): Ditto. (AccessibilityUIElement::orientation): Ditto. (AccessibilityUIElement::intValue): Ditto. (AccessibilityUIElement::minValue): Ditto. (AccessibilityUIElement::maxValue): Ditto. (indexRangeInTable): Ditto. (AccessibilityUIElement::cellForColumnAndRow): Ditto. (AccessibilityUIElement::stringAttributeValue): Ditto. (alterCurrentValue): Ditto. (AccessibilityUIElement::press): Ditto. (AccessibilityUIElement::documentEncoding): Ditto. (AccessibilityUIElement::documentURI): Ditto. (AccessibilityUIElement::hasPopup): Ditto. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::indexRangeInTable): Use normalized checks. (WTR::alterCurrentValue): Ditto. (WTR::AccessibilityUIElement::getChildren): Ditto. (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto. (WTR::AccessibilityUIElement::childrenCount): Ditto. (WTR::AccessibilityUIElement::elementAtPoint): Ditto. (WTR::AccessibilityUIElement::indexOfChild): Ditto. (WTR::AccessibilityUIElement::childAtIndex): Ditto. (WTR::AccessibilityUIElement::titleUIElement): Ditto. (WTR::AccessibilityUIElement::parentElement): Ditto. (WTR::AccessibilityUIElement::attributesOfChildren): Ditto. (WTR::AccessibilityUIElement::allAttributes): Ditto. (WTR::AccessibilityUIElement::stringAttributeValue): Ditto. (WTR::AccessibilityUIElement::role): Ditto. (WTR::AccessibilityUIElement::title): Ditto. (WTR::AccessibilityUIElement::description): Ditto. (WTR::AccessibilityUIElement::orientation): Ditto. (WTR::AccessibilityUIElement::stringValue): Ditto. (WTR::AccessibilityUIElement::language): Ditto. (WTR::AccessibilityUIElement::x): Ditto. (WTR::AccessibilityUIElement::y): Ditto. (WTR::AccessibilityUIElement::width): Ditto. (WTR::AccessibilityUIElement::height): Ditto. (WTR::AccessibilityUIElement::intValue): Ditto. (WTR::AccessibilityUIElement::minValue): Ditto. (WTR::AccessibilityUIElement::maxValue): Ditto. (WTR::AccessibilityUIElement::rowCount): Ditto. (WTR::AccessibilityUIElement::columnCount): Ditto. (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto. (WTR::AccessibilityUIElement::press): Ditto. (WTR::AccessibilityUIElement::documentEncoding): Ditto. (WTR::AccessibilityUIElement::documentURI): Ditto. (WTR::AccessibilityUIElement::hasPopup): Ditto. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp Diff Modified: trunk/Tools/ChangeLog (156530 => 156531) --- trunk/Tools/ChangeLog 2013-09-27 08:58:08 UTC (rev 156530) +++ trunk/Tools/ChangeLog 2013-09-27 09:07:17 UTC (rev 156531) @@ -1,5 +1,87 @@ 2013-09-27 Mario Sanchez Prada mario.pr...@samsung.com +[ATK] Normalize checks in entry points for DRT and WKTR +https://bugs.webkit.org/show_bug.cgi?id=121959 + +Reviewed by Chris Fleizach. + +Always check if we have a proper instance of AtkObject, +implementing the interfaces that we might need for each case, at +the entry point of every method of AccessibilityUIElement for ATK, +and do those checks in an uniform way across DRT and WKTR, to +avoid confusion and issues when modifying these files in the future. + +* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: +(AccessibilityUIElement::getChildren): Use normalized checks. +(AccessibilityUIElement::getChildrenWithRange): Di
[webkit-changes] [156551] trunk
Title: [156551] trunk
Revision 156551
Author ma...@webkit.org
Date 2013-09-27 09:59:49 -0700 (Fri, 27 Sep 2013)
Log Message
[GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106924
Reviewed by Chris Fleizach.
Tools:
Consider headings levels as values to be returned in intValue()
both in DRT and WKTR, so we can share more tests with other ports.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::intValue): Consider headings too.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::intValue): Ditto.
LayoutTests:
Removed accesibility/heading-level.html from failure expectations.
* platform/gtk/TestExpectations: Removed test now passing.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (156550 => 156551)
--- trunk/LayoutTests/ChangeLog 2013-09-27 16:39:41 UTC (rev 156550)
+++ trunk/LayoutTests/ChangeLog 2013-09-27 16:59:49 UTC (rev 156551)
@@ -1,3 +1,14 @@
+2013-09-27 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=106924
+
+Reviewed by Chris Fleizach.
+
+Removed accesibility/heading-level.html from failure expectations.
+
+* platform/gtk/TestExpectations: Removed test now passing.
+
2013-09-27 Jer Noble jer.no...@apple.com
[Mac] Implement the media controls in _javascript_.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (156550 => 156551)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-27 16:39:41 UTC (rev 156550)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-27 16:59:49 UTC (rev 156551)
@@ -1224,8 +1224,6 @@
webkit.org/b/106316 accessibility/render-counter-text.html [ Failure ]
-webkit.org/b/106924 accessibility/heading-level.html [ Failure ]
-
webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html [ Failure ]
webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html [ Failure ]
webkit.org/b/103927 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html [ Failure ]
Modified: trunk/Tools/ChangeLog (156550 => 156551)
--- trunk/Tools/ChangeLog 2013-09-27 16:39:41 UTC (rev 156550)
+++ trunk/Tools/ChangeLog 2013-09-27 16:59:49 UTC (rev 156551)
@@ -1,3 +1,18 @@
+2013-09-27 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=106924
+
+Reviewed by Chris Fleizach.
+
+Consider headings levels as values to be returned in intValue()
+both in DRT and WKTR, so we can share more tests with other ports.
+
+* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+(AccessibilityUIElement::intValue): Consider headings too.
+* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+(WTR::AccessibilityUIElement::intValue): Ditto.
+
2013-09-26 Darin Adler da...@apple.com
rename KURL to URL
Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (156550 => 156551)
--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-09-27 16:39:41 UTC (rev 156550)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-09-27 16:59:49 UTC (rev 156551)
@@ -628,14 +628,29 @@
double AccessibilityUIElement::intValue() const
{
-if (!ATK_IS_VALUE(m_element))
+if (!ATK_IS_OBJECT(m_element))
return 0;
-GValue value = G_VALUE_INIT;
-atk_value_get_current_value(ATK_VALUE(m_element), value);
-if (!G_VALUE_HOLDS_FLOAT(value))
-return 0;
-return g_value_get_float(value);
+if (ATK_IS_VALUE(m_element)) {
+GValue value = G_VALUE_INIT;
+atk_value_get_current_value(ATK_VALUE(m_element), value);
+if (!G_VALUE_HOLDS_FLOAT(value))
+return 0;
+return g_value_get_float(value);
+}
+
+// Consider headings as an special case when returning the int value of
+// an AccessibilityUIElement, so we can reuse some tests to check the level
+// both for HTML headings and objects with the aria-level attribute.
+if (atk_object_get_role(ATK_OBJECT(m_element)) == ATK_ROLE_HEADING) {
+String headingLevel = getAttributeSetValueForId(ATK_OBJECT(m_element), level);
+bool ok;
+double headi
[webkit-changes] [156454] trunk/LayoutTests
Title: [156454] trunk/LayoutTests Revision 156454 Author ma...@webkit.org Date 2013-09-26 04:13:40 -0700 (Thu, 26 Sep 2013) Log Message Unreviewed GTK gardening. Remove failure expectation for test passing after r156209. * platform/gtk-wk2/TestExpectations: Removed failure expectation. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (156453 => 156454) --- trunk/LayoutTests/ChangeLog 2013-09-26 08:58:41 UTC (rev 156453) +++ trunk/LayoutTests/ChangeLog 2013-09-26 11:13:40 UTC (rev 156454) @@ -1,3 +1,9 @@ +2013-09-26 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed GTK gardening. Remove failure expectation for test passing after r156209. + +* platform/gtk-wk2/TestExpectations: Removed failure expectation. + 2013-09-26 Krzysztof Wolanski k.wolan...@samsung.com [EFL] Remove inappropriate expectations for tests that are now passing on EFL port Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (156453 => 156454) --- trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-09-26 08:58:41 UTC (rev 156453) +++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-09-26 11:13:40 UTC (rev 156454) @@ -369,7 +369,6 @@ webkit.org/b/116971 accessibility/poorly-formed-aria-table.html [ Failure ] webkit.org/b/106346 accessibility/svg-remote-element.html [ Failure ] webkit.org/b/116973 platform/gtk/accessibility/caret-browsing-select-focus.html [ Failure ] -Bug(GTK) accessibility/notification-listeners.html [ Failure ] # svg/ failures webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [156455] trunk/LayoutTests
Title: [156455] trunk/LayoutTests Revision 156455 Author ma...@webkit.org Date 2013-09-26 04:18:29 -0700 (Thu, 26 Sep 2013) Log Message REGRESSION(r144831-r144846):Crashes in accessibility/aria-hidden-with-elements.html, accessibility/table-with-hidden-head-section.html https://bugs.webkit.org/show_bug.cgi?id=112152 Unreviewed GTK gardening. Removed crash expectations now passing. * platform/gtk/TestExpectations: Removed crashing expectations that are now passing after r156141-r156209. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (156454 => 156455) --- trunk/LayoutTests/ChangeLog 2013-09-26 11:13:40 UTC (rev 156454) +++ trunk/LayoutTests/ChangeLog 2013-09-26 11:18:29 UTC (rev 156455) @@ -1,5 +1,15 @@ 2013-09-26 Mario Sanchez Prada mario.pr...@samsung.com +REGRESSION(r144831-r144846):Crashes in accessibility/aria-hidden-with-elements.html, accessibility/table-with-hidden-head-section.html +https://bugs.webkit.org/show_bug.cgi?id=112152 + +Unreviewed GTK gardening. Removed crash expectations now passing. + +* platform/gtk/TestExpectations: Removed crashing expectations +that are now passing after r156141-r156209. + +2013-09-26 Mario Sanchez Prada mario.pr...@samsung.com + Unreviewed GTK gardening. Remove failure expectation for test passing after r156209. * platform/gtk-wk2/TestExpectations: Removed failure expectation. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (156454 => 156455) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-26 11:13:40 UTC (rev 156454) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-26 11:18:29 UTC (rev 156455) @@ -474,9 +474,6 @@ webkit.org/b/110546 [ Debug ] fast/parser/document-write-fighting-eof.html [ Skip ] webkit.org/b/110546 [ Debug ] fast/parser/document-write-partial-entity-before-load.html [ Skip ] -webkit.org/b/112152 [ Debug ] accessibility/aria-hidden-with-elements.html [ Crash ] -webkit.org/b/112152 [ Debug ] accessibility/table-with-hidden-head-section.html [ Crash ] - webkit.org/b/111451 [ Debug ] editing/selection/selection-in-iframe-removed-crash.html [ Crash Pass ] webkit.org/b/111902 [ Debug ] http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html [ Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [156459] trunk/LayoutTests
Title: [156459] trunk/LayoutTests Revision 156459 Author ma...@webkit.org Date 2013-09-26 08:02:20 -0700 (Thu, 26 Sep 2013) Log Message [GTK] Logging of accessibility events is not disabled between tests https://bugs.webkit.org/show_bug.cgi?id=121957 Unreviewed gardening. Marking accessibility tests as flaky while an issue with the logging of accessibility events is investigated. * platform/gtk/TestExpectations: Added flaky expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (156458 => 156459) --- trunk/LayoutTests/ChangeLog 2013-09-26 14:24:59 UTC (rev 156458) +++ trunk/LayoutTests/ChangeLog 2013-09-26 15:02:20 UTC (rev 156459) @@ -1,5 +1,15 @@ 2013-09-26 Mario Sanchez Prada mario.pr...@samsung.com +[GTK] Logging of accessibility events is not disabled between tests +https://bugs.webkit.org/show_bug.cgi?id=121957 + +Unreviewed gardening. Marking accessibility tests as flaky while +an issue with the logging of accessibility events is investigated. + +* platform/gtk/TestExpectations: Added flaky expectations. + +2013-09-26 Mario Sanchez Prada mario.pr...@samsung.com + REGRESSION(r144831-r144846):Crashes in accessibility/aria-hidden-with-elements.html, accessibility/table-with-hidden-head-section.html https://bugs.webkit.org/show_bug.cgi?id=112152 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (156458 => 156459) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-26 14:24:59 UTC (rev 156458) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-26 15:02:20 UTC (rev 156459) @@ -520,6 +520,20 @@ webkit.org/b/74493 platform/gtk/accessibility/unknown-roles-not-exposed.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/aria-table-hierarchy.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/aria-toggle-button-role.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/button-accessible-name.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/caret-browsing-text-focus.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/entry-and-password.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/list-items-always-exposed.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/media-controls-panel-title.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/name-from-label.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/object-with-title.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/remapped-aria-crash.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/spans-paragraphs-and-divs.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/spans.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/table-hierarchy.html [ Failure Pass ] + webkit.org/b/76385 tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html [ Failure Pass ] webkit.org/b/78344 fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html [ ImageOnlyFailure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [156460] trunk/LayoutTests
Title: [156460] trunk/LayoutTests Revision 156460 Author ma...@webkit.org Date 2013-09-26 08:16:10 -0700 (Thu, 26 Sep 2013) Log Message [GTK][WK2] Logging of accessibility events is not disabled between tests https://bugs.webkit.org/show_bug.cgi?id=121957 Unreviewed gardening again. Now moving the expected flakiness to the WebKit2GTK+ port, where it actually belongs to. * platform/gtk-wk2/TestExpectations: Added expectations. * platform/gtk/TestExpectations: Removed expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (156459 => 156460) --- trunk/LayoutTests/ChangeLog 2013-09-26 15:02:20 UTC (rev 156459) +++ trunk/LayoutTests/ChangeLog 2013-09-26 15:16:10 UTC (rev 156460) @@ -1,5 +1,16 @@ 2013-09-26 Mario Sanchez Prada mario.pr...@samsung.com +[GTK][WK2] Logging of accessibility events is not disabled between tests +https://bugs.webkit.org/show_bug.cgi?id=121957 + +Unreviewed gardening again. Now moving the expected flakiness to +the WebKit2GTK+ port, where it actually belongs to. + +* platform/gtk-wk2/TestExpectations: Added expectations. +* platform/gtk/TestExpectations: Removed expectations. + +2013-09-26 Mario Sanchez Prada mario.pr...@samsung.com + [GTK] Logging of accessibility events is not disabled between tests https://bugs.webkit.org/show_bug.cgi?id=121957 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (156459 => 156460) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-26 15:02:20 UTC (rev 156459) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-26 15:16:10 UTC (rev 156460) @@ -520,20 +520,6 @@ webkit.org/b/74493 platform/gtk/accessibility/unknown-roles-not-exposed.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/aria-table-hierarchy.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/aria-toggle-button-role.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/button-accessible-name.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/caret-browsing-text-focus.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/entry-and-password.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/list-items-always-exposed.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/media-controls-panel-title.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/name-from-label.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/object-with-title.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/remapped-aria-crash.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/spans-paragraphs-and-divs.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/spans.html [ Failure Pass ] -webkit.org/b/121957 platform/gtk/accessibility/table-hierarchy.html [ Failure Pass ] - webkit.org/b/76385 tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html [ Failure Pass ] webkit.org/b/78344 fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html [ ImageOnlyFailure Pass ] Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (156459 => 156460) --- trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-09-26 15:02:20 UTC (rev 156459) +++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-09-26 15:16:10 UTC (rev 156460) @@ -261,6 +261,19 @@ webkit.org/b/72698 media/audio-garbage-collect.html [ Failure Pass ] # Tests showing flakiness in the bot +webkit.org/b/121957 platform/gtk/accessibility/aria-table-hierarchy.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/aria-toggle-button-role.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/button-accessible-name.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/caret-browsing-text-focus.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/entry-and-password.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/list-items-always-exposed.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/media-controls-panel-title.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/name-from-label.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/object-with-title.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/remapped-aria-crash.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/spans-paragraphs-and-divs.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/spans.html [ Failure Pass ] +webkit.org/b/121957 platform/gtk/accessibility/table-hierarchy.html [ Failure Pass ] Bug(GTK) editing/pasteboard/smart-paste-004.html [ Failure Pass ] Bug(GTK
[webkit-changes] [156388] trunk/Tools
Title: [156388] trunk/Tools
Revision 156388
Author ma...@webkit.org
Date 2013-09-25 05:33:27 -0700 (Wed, 25 Sep 2013)
Log Message
[ATK] Fix style issues in AccessibilityUIElementAtk
https://bugs.webkit.org/show_bug.cgi?id=121898
Reviewed by Chris Fleizach.
Avoid the '.f' suffix for float literals and use G_VALUE_INIT
instead of { 0, { { 0 } } } to initialize a GValue.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::clickPointX): Remove suffix.
(AccessibilityUIElement::clickPointY): Ditto.
(AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(AccessibilityUIElement::numberAttributeValue): Remove suffix.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::clickPointX): Ditto.
(WTR::AccessibilityUIElement::clickPointY): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Diff
Modified: trunk/Tools/ChangeLog (156387 => 156388)
--- trunk/Tools/ChangeLog 2013-09-25 12:21:41 UTC (rev 156387)
+++ trunk/Tools/ChangeLog 2013-09-25 12:33:27 UTC (rev 156388)
@@ -1,3 +1,32 @@
+2013-09-25 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Fix style issues in AccessibilityUIElementAtk
+https://bugs.webkit.org/show_bug.cgi?id=121898
+
+Reviewed by Chris Fleizach.
+
+Avoid the '.f' suffix for float literals and use G_VALUE_INIT
+instead of { 0, { { 0 } } } to initialize a GValue.
+
+* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+(AccessibilityUIElement::clickPointX): Remove suffix.
+(AccessibilityUIElement::clickPointY): Ditto.
+(AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
+(AccessibilityUIElement::minValue): Ditto.
+(AccessibilityUIElement::maxValue): Ditto.
+(AccessibilityUIElement::numberAttributeValue): Remove suffix.
+* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+(WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
+(WTR::AccessibilityUIElement::x): Ditto.
+(WTR::AccessibilityUIElement::y): Ditto.
+(WTR::AccessibilityUIElement::width): Ditto.
+(WTR::AccessibilityUIElement::height): Ditto.
+(WTR::AccessibilityUIElement::clickPointX): Ditto.
+(WTR::AccessibilityUIElement::clickPointY): Ditto.
+(WTR::AccessibilityUIElement::intValue): Ditto.
+(WTR::AccessibilityUIElement::minValue): Ditto.
+(WTR::AccessibilityUIElement::maxValue): Ditto.
+
2013-09-25 Krzysztof Czech k.cz...@samsung.com
[EFL] accessibility/loading-iframe-sends-notification.html is failing
Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (156387 => 156388)
--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-09-25 12:21:41 UTC (rev 156387)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-09-25 12:33:27 UTC (rev 156388)
@@ -583,13 +583,13 @@
double AccessibilityUIElement::clickPointX()
{
// Note: This is not something we have in ATK.
-return 0.f;
+return 0;
}
double AccessibilityUIElement::clickPointY()
{
// Note: This is not something we have in ATK.
-return 0.f;
+return 0;
}
JSStringRef AccessibilityUIElement::orientation() const
@@ -611,40 +611,40 @@
double AccessibilityUIElement::intValue() const
{
-GValue value = { 0, { { 0 } } };
+GValue value = G_VALUE_INIT;
if (!ATK_IS_VALUE(m_element))
-return 0.0f;
+return 0;
atk_value_get_current_value(ATK_VALUE(m_element), value);
if (!G_VALUE_HOLDS_FLOAT(value))
-return 0.0f;
+return 0;
return g_value_get_float(value);
}
double AccessibilityUIElement::minValue()
{
-GValue value = { 0, { { 0 } } };
+GValue value = G_VALUE_INIT;
if (!ATK_IS_VALUE(m_element))
-return 0.0f;
+return 0;
atk_value_get_minimum_value(ATK_VALUE(m_element), value);
if (!G_VALUE_HOLDS_FLOAT(value))
-return 0.0f;
+return 0;
return g_value_get_float(value);
}
double AccessibilityUIElement::maxValue()
{
-GValue value = { 0, { { 0 } } };
+GValue value = G_VALUE_INIT;
if (!ATK_IS_VALUE(m_element))
-return 0.0f;
+return 0;
atk_value_get_maximum_value(ATK_VALUE(m_element),
[webkit-changes] [156203] trunk
Title: [156203] trunk Revision 156203 Author ma...@webkit.org Date 2013-09-20 14:56:10 -0700 (Fri, 20 Sep 2013) Log Message [ATK] Do not expose aria-help in ATK based platforms https://bugs.webkit.org/show_bug.cgi?id=121675 Patch by Mario Sanchez Prada mario.pr...@samsung.com on 2013-09-20 Reviewed by Chris Fleizach. Source/WebCore: Stop exposing the value for the 'aria-help' attribute as an AtkObject attribute, based in AccessibilityObject::helpText(). * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: (webkitAccessibleGetAttributes): Remove the mapping. Source/WebKit/efl: Removed accessibilityHelpText() helper method from DumpRenderSupportEfl's API, since it's not longer needed. * WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Removed method. * WebCoreSupport/DumpRenderTreeSupportEfl.h: Ditto. Source/WebKit/gtk: Removed accessibilityHelpText() helper method from DumpRenderSupportGtk's API, since it's not longer needed. * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Removed method. * WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto. Tools: Remove the implementations for AccessibilityUIElement::helpText() from DRT and WKTR for GTK and EFL, since they are based on the AccessibilityObject::helpText() method and the 'aria-help' attributes, which is wrong since they should not depend on that but in ATK specific API (see also http://webkit.org/b/121684). * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::helpText): Added a new and empty implementation, now that we are no longer using this in ATK. * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file as the only function provided here was helpText(). * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto. * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp removed from the list of sources to compile. * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp. * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::helpText): Replaced old implementation based in DumpRenderTreeSupportGtk with an empty one. LayoutTests: Moved test based in helpText() into the Mac directory, and update expectations for platforms as needed. * platform/mac/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/aria-help-expected.txt. * platform/mac/accessibility/aria-help.html: Renamed from LayoutTests/accessibility/aria-help.html. * platform/gtk-wk2/TestExpectations: Removed failure expectation for aria-help, now moved to Mac, and for aria-describedby-on-input, which is now moved to the generic TestExpectations file for GTK. * platform/gtk/TestExpectations: Added aria-describedby-on-input, linking it to the newly filed bug 121684. * platform/gtk-wk2/TestExpectations: Removed failure expectation. * platform/win/TestExpectations: Removed failure expectation. * platform/wincairo/TestExpectations: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk-wk2/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/LayoutTests/platform/wincairo/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/DumpRenderTree/efl/CMakeLists.txt trunk/Tools/GNUmakefile.am trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp Added Paths trunk/LayoutTests/platform/mac/accessibility/aria-help-expected.txt trunk/LayoutTests/platform/mac/accessibility/aria-help.html Removed Paths trunk/LayoutTests/accessibility/aria-help-expected.txt trunk/LayoutTests/accessibility/aria-help.html trunk/Tools/DumpRenderTree/efl/AccessibilityUIElementEfl.cpp trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (156202 => 156203) --- trunk/LayoutTests/ChangeLog 2013-09-20 21:54:42 UTC (rev 156202) +++ trunk/LayoutTests/ChangeLog 2013-09-20 21:56:10 UTC (rev 156203) @@ -1,3 +1,24 @@ +2013-09-20 Mario Sanchez Prada mario.pr...@samsung.com + +[ATK] Do not expose aria-help in ATK based platforms +https://bugs.webkit.org/show_bug.cgi?id=121675 + +Reviewed by Chris Fleizach. + +Moved test based in helpText() into the Mac directory, and update +expectations for platforms as needed. + +* platform/mac/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/aria-help-expected.txt. +* platform/mac/accessibility/aria-help.html: Renamed from LayoutTe
[webkit-changes] [155848] trunk/LayoutTests
Title: [155848] trunk/LayoutTests Revision 155848 Author ma...@webkit.org Date 2013-09-16 03:49:37 -0700 (Mon, 16 Sep 2013) Log Message Unreviewed gardening. Removed fail expectations for test in the GTK EFL ports, consistently passing after r155374. * platform/efl/TestExpectations: Removed test. * platform/gtk/TestExpectations: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (155847 => 155848) --- trunk/LayoutTests/ChangeLog 2013-09-16 09:27:16 UTC (rev 155847) +++ trunk/LayoutTests/ChangeLog 2013-09-16 10:49:37 UTC (rev 155848) @@ -1,3 +1,11 @@ +2013-09-16 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed gardening. Removed fail expectations for test in +the GTK EFL ports, consistently passing after r155374. + +* platform/efl/TestExpectations: Removed test. +* platform/gtk/TestExpectations: Ditto. + 2013-09-16 Wojciech Bielawski w.bielaw...@samsung.com [WKTR] Add implementation of click() method of objects returned by eventSender.contextClick(). Modified: trunk/LayoutTests/platform/efl/TestExpectations (155847 => 155848) --- trunk/LayoutTests/platform/efl/TestExpectations 2013-09-16 09:27:16 UTC (rev 155847) +++ trunk/LayoutTests/platform/efl/TestExpectations 2013-09-16 10:49:37 UTC (rev 155848) @@ -1665,9 +1665,6 @@ # Newly added test in r148131 is failing. webkit.org/b/114876 media/click-volume-bar-not-pausing.html [ Failure ] -# Newly added test in r148136 is failing. -webkit.org/b/114877 accessibility/link-inside-button-accessible-text.html [ Failure ] - webkit.org/b/114612 editing/style/block-style-005.html [ Failure ] # Unidentified failing media tests Modified: trunk/LayoutTests/platform/gtk/TestExpectations (155847 => 155848) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-16 09:27:16 UTC (rev 155847) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-16 10:49:37 UTC (rev 155848) @@ -1329,8 +1329,6 @@ webkit.org/b/114625 http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html [ Failure ] -webkit.org/b/114626 accessibility/link-inside-button-accessible-text.html [ Failure ] - webkit.org/b/114612 editing/style/block-style-005.html [ Failure ] webkit.org/b/115025 fast/events/constructors/mouse-event-constructor.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155516] trunk/Source
Title: [155516] trunk/Source
Revision 155516
Author ma...@webkit.org
Date 2013-09-11 03:32:00 -0700 (Wed, 11 Sep 2013)
Log Message
[GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114872
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Re-implement these functions without using GailTextUtil nor Pango.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(lineAtPositionForAtkBoundary): New helper function to find the
line at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextLineForBoundary): New function,
implementing atk_text_get_text_*_offset for LINE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
LINE boundaries with webkitAccessibleTextLineForBoundary().
Source/WebKit/gtk:
Fixed wrong unit test.
* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithPreformattedText): This test was
reporting a trailing '\n' for some reason for a pre block, which
is plainly wrong since, in order to return that, there should be
at least a trailing empty space after that and before the /pre
closing tag. This is fixed now.
(testWebkitAtkGetTextAtOffsetWithWrappedLines): Uncommented tests
that were previously not passing due to a bug in GailTextUtil.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/tests/testatk.c
Diff
Modified: trunk/Source/WebCore/ChangeLog (155515 => 155516)
--- trunk/Source/WebCore/ChangeLog 2013-09-11 09:54:19 UTC (rev 155515)
+++ trunk/Source/WebCore/ChangeLog 2013-09-11 10:32:00 UTC (rev 155516)
@@ -1,3 +1,20 @@
+2013-09-10 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries
+https://bugs.webkit.org/show_bug.cgi?id=114872
+
+Reviewed by Gustavo Noronha Silva.
+
+Re-implement these functions without using GailTextUtil nor Pango.
+
+* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+(lineAtPositionForAtkBoundary): New helper function to find the
+line at a given position considering values of AtkTextBoundary.
+(webkitAccessibleTextLineForBoundary): New function,
+implementing atk_text_get_text_*_offset for LINE.
+(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
+LINE boundaries with webkitAccessibleTextLineForBoundary().
+
2013-09-11 Andreas Kling akl...@apple.com
Missed one BackForwardListImpl.h in the last commit.
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (155515 => 155516)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-09-11 09:54:19 UTC (rev 155515)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-09-11 10:32:00 UTC (rev 155516)
@@ -973,6 +973,113 @@
return webkitAccessibleTextGetText(text, *startOffset, *endOffset);
}
+static VisibleSelection lineAtPositionForAtkBoundary(const AccessibilityObject* coreObject, const VisiblePosition position, AtkTextBoundary boundaryType)
+{
+VisiblePosition startPosition;
+VisiblePosition endPosition;
+
+switch (boundaryType) {
+case ATK_TEXT_BOUNDARY_LINE_START:
+startPosition = isStartOfLine(position) ? position : logicalStartOfLine(position);
+endPosition = logicalEndOfLine(position);
+
+// In addition to checking that we are not at the end of a block, we need
+// to check that endPosition has not UPSTREAM affinity, since that would
+// cause trouble inside of text controls (we would be advancing too much).
+if (!isEndOfBlock(endPosition) endPosition.affinity() != UPSTREAM)
+endPosition = endPosition.next();
+break;
+
+case ATK_TEXT_BOUNDARY_LINE_END:
+startPosition = isEndOfLine(position) ? position : logicalStartOfLine(position);
+if (!isStartOfBlock(startPosition))
+startPosition = startPosition.previous();
+endPosition = logicalEndOfLine(position);
+break;
+
+default:
+ASSERT_NOT_REACHED();
+}
+
+VisibleSelection selectedLine(startPosition, endPosition);
+
+// We mark the selection as 'upstream' so we can use that information later,
+// when finding the actual offsets in getSelectionOffsetsForObject().
+if (boundaryType == ATK_TEXT_BOUNDARY_LINE_END)
+selectedLine.setAffinity(UPSTREAM);
+
+return selectedLine;
+}
+
+static char* webkitAccessibleTextLineForBoundary(AtkText* text, int offset, AtkTextBoundary boundaryType, GetTextRelativePosition textPosition, int* startOffset, int* endOffset)
+{
+AccessibilityObject* coreObject = core(text);
+Document* document = coreObject-document();
+if (!document)
+return emptyTextSelectionAtOffset(0, startOffset, endOffset);
+
+Node* node = getNodeForAccessibility
[webkit-changes] [155520] trunk/Source/WebCore
Title: [155520] trunk/Source/WebCore
Revision 155520
Author ma...@webkit.org
Date 2013-09-11 05:05:10 -0700 (Wed, 11 Sep 2013)
Log Message
[GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
https://bugs.webkit.org/show_bug.cgi?id=114867
Reviewed by Martin Robinson.
Removed all trace of Gail and Pango specific code from the AtkText
implementation, now everything has been reimplemented.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): Removed fallback code
relying in Gail/Pango, now all the related code has been
removed. Also, replaced the collection of if statements with a
switch, for better readability of the code.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155519 => 155520)
--- trunk/Source/WebCore/ChangeLog 2013-09-11 11:44:58 UTC (rev 155519)
+++ trunk/Source/WebCore/ChangeLog 2013-09-11 12:05:10 UTC (rev 155520)
@@ -1,3 +1,19 @@
+2013-09-11 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
+https://bugs.webkit.org/show_bug.cgi?id=114867
+
+Reviewed by Martin Robinson.
+
+Removed all trace of Gail and Pango specific code from the AtkText
+implementation, now everything has been reimplemented.
+
+* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+(webkitAccessibleTextGetTextForOffset): Removed fallback code
+relying in Gail/Pango, now all the related code has been
+removed. Also, replaced the collection of if statements with a
+switch, for better readability of the code.
+
2013-09-11 Allan Sandfeld Jensen allan.jen...@digia.com
Mouseenter/-leave not triggered when element under cursor is moved/removed
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (155519 => 155520)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-09-11 11:44:58 UTC (rev 155519)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-09-11 12:05:10 UTC (rev 155520)
@@ -54,11 +54,6 @@
#include wtf/gobject/GOwnPtr.h
#include wtf/text/CString.h
-#if PLATFORM(GTK)
-#include libgail-util/gail-util.h
-#include pango/pango.h
-#endif
-
using namespace WebCore;
static AccessibilityObject* core(AtkText* text)
@@ -164,39 +159,6 @@
return g_string_free(str, FALSE);
}
-static gchar* webkitAccessibleTextGetText(AtkText*, gint startOffset, gint endOffset);
-
-#if PLATFORM(GTK)
-static GailTextUtil* getGailTextUtilForAtk(AtkText* textObject)
-{
-GailTextUtil* gailTextUtil = gail_text_util_new();
-GOwnPtrchar text(webkitAccessibleTextGetText(textObject, 0, -1));
-gail_text_util_text_setup(gailTextUtil, text.get());
-return gailTextUtil;
-}
-
-static PangoLayout* getPangoLayoutForAtk(AtkText* textObject)
-{
-AccessibilityObject* coreObject = core(textObject);
-
-Document* document = coreObject-document();
-if (!document)
-return 0;
-
-HostWindow* hostWindow = document-view()-hostWindow();
-if (!hostWindow)
-return 0;
-PlatformPageClient webView = hostWindow-platformPageClient();
-if (!webView)
-return 0;
-
-// Create a string with the layout as it appears on the screen
-GOwnPtrchar objectText(textForObject(coreObject));
-PangoLayout* layout = gtk_widget_create_pango_layout(static_castGtkWidget*(webView), objectText.get());
-return layout;
-}
-#endif
-
static int baselinePositionForRenderObject(RenderObject* renderObject)
{
// FIXME: This implementation of baselinePosition originates from RenderObject.cpp and was
@@ -368,6 +330,8 @@
return attributeSet1;
}
+static gchar* webkitAccessibleTextGetText(AtkText*, gint startOffset, gint endOffset);
+
static guint accessibilityObjectLength(const AccessibilityObject* object)
{
// Non render objects are not taken into account
@@ -1086,46 +1050,27 @@
if (!coreObject || !coreObject-isAccessibilityRenderObject())
return emptyTextSelectionAtOffset(0, startOffset, endOffset);
-if (boundaryType == ATK_TEXT_BOUNDARY_CHAR)
+switch (boundaryType) {
+case ATK_TEXT_BOUNDARY_CHAR:
return webkitAccessibleTextGetChar(text, offset, textPosition, startOffset, endOffset);
-if (boundaryType == ATK_TEXT_BOUNDARY_WORD_START || boundaryType == ATK_TEXT_BOUNDARY_WORD_END)
+case ATK_TEXT_BOUNDARY_WORD_START:
+case ATK_TEXT_BOUNDARY_WORD_END:
return webkitAccessibleTextWordForBoundary(text, offset, boundaryType, textPosition, startOffset, endOffset);
-if (boundaryType == ATK_TEXT_BOUNDARY_SENTENCE_START || boundaryType == ATK_TEXT_BOUNDARY_SENTENCE_END)
-return webkitAccessibleTextSentenceForBoundary(text, offset, boundaryType, textPosition, startOffset, end
[webkit-changes] [155534] trunk
Title: [155534] trunk
Revision 155534
Author ma...@webkit.org
Date 2013-09-11 09:25:19 -0700 (Wed, 11 Sep 2013)
Log Message
[GTK] Remove Gail dependency from build system for GTK3
https://bugs.webkit.org/show_bug.cgi?id=119673
Reviewed by Gustavo Noronha Silva.
.:
* Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
* Source/autotools/Versions.m4: Removed any reference to GAIL.
* Source/cmake/FindGAIL3.cmake: Removed.
* Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.
Source/WebCore:
* GNUmakefile.am: Removed GAIL_CFLAGS.
* PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.
Source/WebKit/gtk:
* GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.
Source/WebKit2:
* GNUmakefile.am: Removed GAIL_LIBS.
Tools:
* EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
* TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/autotools/FindDependencies.m4
trunk/Source/autotools/Versions.m4
trunk/Source/cmake/OptionsGTK.cmake
trunk/Tools/ChangeLog
trunk/Tools/EWSTools/ubuntu-ews-packages
trunk/Tools/Scripts/webkitpy/port/gtk.py
trunk/Tools/TestWebKitAPI/GNUmakefile.am
trunk/Tools/gtk/install-dependencies
Removed Paths
trunk/Source/cmake/FindGAIL3.cmake
Diff
Modified: trunk/ChangeLog (155533 => 155534)
--- trunk/ChangeLog 2013-09-11 16:15:33 UTC (rev 155533)
+++ trunk/ChangeLog 2013-09-11 16:25:19 UTC (rev 155534)
@@ -1,3 +1,15 @@
+2013-09-11 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Remove Gail dependency from build system for GTK3
+https://bugs.webkit.org/show_bug.cgi?id=119673
+
+Reviewed by Gustavo Noronha Silva.
+
+* Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
+* Source/autotools/Versions.m4: Removed any reference to GAIL.
+* Source/cmake/FindGAIL3.cmake: Removed.
+* Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.
+
2013-09-11 Patrick Gansterer par...@webkit.org
[CMake] Split out generic Windows files into its own file
Modified: trunk/Source/WebCore/ChangeLog (155533 => 155534)
--- trunk/Source/WebCore/ChangeLog 2013-09-11 16:15:33 UTC (rev 155533)
+++ trunk/Source/WebCore/ChangeLog 2013-09-11 16:25:19 UTC (rev 155534)
@@ -1,3 +1,13 @@
+2013-09-11 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Remove Gail dependency from build system for GTK3
+https://bugs.webkit.org/show_bug.cgi?id=119673
+
+Reviewed by Gustavo Noronha Silva.
+
+* GNUmakefile.am: Removed GAIL_CFLAGS.
+* PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.
+
2013-09-11 Andreas Kling akl...@apple.com
Remove Widget::widgetPositionsUpdated().
Modified: trunk/Source/WebCore/GNUmakefile.am (155533 => 155534)
--- trunk/Source/WebCore/GNUmakefile.am 2013-09-11 16:15:33 UTC (rev 155533)
+++ trunk/Source/WebCore/GNUmakefile.am 2013-09-11 16:25:19 UTC (rev 155534)
@@ -577,7 +577,6 @@
$(COVERAGE_CFLAGS) \
$(ENCHANT_CFLAGS) \
$(FREETYPE_CFLAGS) \
- $(GAIL_CFLAGS) \
$(GAMEPAD_CFLAGS) \
$(GEOCLUE_CFLAGS) \
$(GLIB_CFLAGS) \
Modified: trunk/Source/WebCore/PlatformGTK.cmake (155533 => 155534)
--- trunk/Source/WebCore/PlatformGTK.cmake 2013-09-11 16:15:33 UTC (rev 155533)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2013-09-11 16:25:19 UTC (rev 155534)
@@ -252,7 +252,6 @@
${GLIB_GIO_LIBRARIES}
${GLIB_GOBJECT_LIBRARIES}
${GLIB_GMODULE_LIBRARIES}
-${GAIL3_LIBRARIES}
${GTK3_LIBRARIES}
${LIBSOUP_LIBRARIES}
${ZLIB_LIBRARIES}
@@ -274,7 +273,6 @@
${LIBXML2_INCLUDE_DIR}
${LIBXSLT_INCLUDE_DIR}
${SQLITE_INCLUDE_DIR}
-${GAIL3_INCLUDE_DIRS}
${GLIB_INCLUDE_DIRS}
${GTK3_INCLUDE_DIRS}
${LIBSOUP_INCLUDE_DIRS}
Modified: trunk/Source/WebKit/gtk/ChangeLog (155533 => 155534)
--- trunk/Source/WebKit/gtk/ChangeLog 2013-09-11 16:15:33 UTC (rev 155533)
+++ trunk/Source/WebKit/gtk/ChangeLog 2013-09-11 16:25:19 UTC (rev 155534)
@@ -1,3 +1,12 @@
+2013-09-11 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Remove Gail dependency from build system for GTK3
+https://bugs.webkit.org/show_bug.cgi?id=119673
+
+Reviewed by Gustavo Noronha Silva.
+
+* GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.
+
2013-09-10 Mario Sanchez Prada mario.pr...@samsung.com
[GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries
Modified: trunk/Source/WebKit/gtk/GNUmakefile.am (155533 => 155534)
--- trunk/Source/WebKit/gtk/GNUmakefile.am 2013-09-11 16:15:33 UTC (rev 155533)
+++ trunk
[webkit-changes] [155428] trunk
Title: [155428] trunk
Revision 155428
Author ma...@webkit.org
Date 2013-09-10 01:52:07 -0700 (Tue, 10 Sep 2013)
Log Message
[GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
https://bugs.webkit.org/show_bug.cgi?id=105538
Reviewed by Chris Fleizach.
Source/WebCore:
Expose '\n' for linebreaks when they were explicitly set by the
author of the web content with a br tag.
Tests: accessibility/paragraph-with-linebreaks.html
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldAddSpaceBeforeAppendingNextElement): Helper
function to decide when to append spaces when building the text
under an element, considering line breaks.
(WebCore::AccessibilityNodeObject::textUnderElement): Use the
shouldAddSpaceBeforeAppendingNextElement() function here.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Return the
renderer's text for accessibility objects exposing br elements.
* html/parser/HTMLParserIdioms.h:
(WebCore::isHTMLSpaceButNotLineBreak): New helper function, useful
to be passed to other functions like simplifyWhiteSpace().
Tools:
Unskip passing test getTextInParagraphAndBodyModerate.
* Scripts/run-gtk-tests:
(TestRunner): Unskip pasing test.
LayoutTests:
Added new Layout test and platform specific expectations.
* platform/efl/accessibility/paragraph-with-linebreaks-expected.txt: Added.
* platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt: Added.
* accessibility/paragraph-with-linebreaks.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/html/parser/HTMLParserIdioms.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
Added Paths
trunk/LayoutTests/accessibility/paragraph-with-linebreaks.html
trunk/LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (155427 => 155428)
--- trunk/LayoutTests/ChangeLog 2013-09-10 08:51:27 UTC (rev 155427)
+++ trunk/LayoutTests/ChangeLog 2013-09-10 08:52:07 UTC (rev 155428)
@@ -1,3 +1,16 @@
+2013-09-10 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
+https://bugs.webkit.org/show_bug.cgi?id=105538
+
+Reviewed by Chris Fleizach.
+
+Added new Layout test and platform specific expectations.
+
+* platform/efl/accessibility/paragraph-with-linebreaks-expected.txt: Added.
+* platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt: Added.
+* accessibility/paragraph-with-linebreaks.html: Added.
+
2013-09-10 Arpita Bahuguna a@samsung.com
When deleting editable content, typing style should be reset when moving into another node.
Added: trunk/LayoutTests/accessibility/paragraph-with-linebreaks.html (0 => 155428)
--- trunk/LayoutTests/accessibility/paragraph-with-linebreaks.html (rev 0)
+++ trunk/LayoutTests/accessibility/paragraph-with-linebreaks.html 2013-09-10 08:52:07 UTC (rev 155428)
@@ -0,0 +1,48 @@
+html
+head
+script src=""
+/head
+body
+
+p
+ Lorem ipsum dolor sit amet,br
+ consectetur adipiscing elit.br
+ Aliquam faucibus diam sit amet nunc vestibulum auctor.
+/p
+
+p style=max-width:150px;
+ Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam faucibus diam sit amet nunc vestibulum auctor.
+/p
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This test checks that linebreaks explicitly set by the author are properly exposed to ATs.);
+
+if (window.testRunner) {
+ testRunner.dumpAsText();
+
+ if (window.accessibilityController) {
+
+document.body.focus();
+var webArea = accessibilityController.focusedElement;
+
+var brokenParagraph = webArea.childAtIndex(0);
+debug(Role of the paragraph with break lines: + brokenParagraph.role);
+debug(Value of the paragraph with break lines: + brokenParagraph.stringValue);
+debug(br);
+
+var wrappedParagraph = webArea.childAtIndex(1);
+debug(Role of the paragraph with wrapped lines: + wrappedParagraph.role);
+debug(Value of the paragraph with wrapped lines: + wrappedParagraph.stringValue);
+debug(br);
+ }
+}
+/script
+
+script src=""
+
+/body
+/html
Added: trunk/LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt (0 => 155428)
--- trunk/LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt 2013-09-10 08:52:07 UTC (rev 155428)
@@ -0,0 +1,23 @@
+Lorem ipsum dolor sit amet,
+consectetur adipiscing elit.
+Aliquam faucibus diam sit amet nunc vestibulum auc
[webkit-changes] [155445] trunk/LayoutTests
Title: [155445] trunk/LayoutTests Revision 155445 Author ma...@webkit.org Date 2013-09-10 07:54:25 -0700 (Tue, 10 Sep 2013) Log Message Unreviewed. Updated paths for JS resources in test after r155411. * accessibility/paragraph-with-linebreaks.html: Use ../resources/js-test-pre.js instead of ../fast/js/resources/js-test-pre.js. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/paragraph-with-linebreaks.html Diff Modified: trunk/LayoutTests/ChangeLog (155444 => 155445) --- trunk/LayoutTests/ChangeLog 2013-09-10 14:46:13 UTC (rev 155444) +++ trunk/LayoutTests/ChangeLog 2013-09-10 14:54:25 UTC (rev 155445) @@ -1,3 +1,10 @@ +2013-09-10 Mario Sanchez Prada mario.pr...@samsung.com + +Unreviewed. Updated paths for JS resources in test after r155411. + +* accessibility/paragraph-with-linebreaks.html: Use ../resources/js-test-pre.js +instead of ../fast/js/resources/js-test-pre.js. + 2013-09-10 Krzysztof Czech k.cz...@samsung.com [ATK] Incorrect type for holding float value Modified: trunk/LayoutTests/accessibility/paragraph-with-linebreaks.html (155444 => 155445) --- trunk/LayoutTests/accessibility/paragraph-with-linebreaks.html 2013-09-10 14:46:13 UTC (rev 155444) +++ trunk/LayoutTests/accessibility/paragraph-with-linebreaks.html 2013-09-10 14:54:25 UTC (rev 155445) @@ -1,6 +1,6 @@ html head -script src="" +script src="" /head body @@ -42,7 +42,7 @@ } /script -script src="" +script src="" /body /html ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155446] trunk/LayoutTests
Title: [155446] trunk/LayoutTests Revision 155446 Author ma...@webkit.org Date 2013-09-10 08:01:55 -0700 (Tue, 10 Sep 2013) Log Message Unreviewed. Removed failure expectations for tests that are now passing after the rebaseline done in r155033. * platform/gtk/TestExpectations: Removed 7 expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (155445 => 155446) --- trunk/LayoutTests/ChangeLog 2013-09-10 14:54:25 UTC (rev 155445) +++ trunk/LayoutTests/ChangeLog 2013-09-10 15:01:55 UTC (rev 155446) @@ -1,5 +1,12 @@ 2013-09-10 Mario Sanchez Prada mario.pr...@samsung.com +Unreviewed. Removed failure expectations for tests that are +now passing after the rebaseline done in r155033. + +* platform/gtk/TestExpectations: Removed 7 expectations. + +2013-09-10 Mario Sanchez Prada mario.pr...@samsung.com + Unreviewed. Updated paths for JS resources in test after r155411. * accessibility/paragraph-with-linebreaks.html: Use ../resources/js-test-pre.js Modified: trunk/LayoutTests/platform/gtk/TestExpectations (155445 => 155446) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-10 14:54:25 UTC (rev 155445) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-09-10 15:01:55 UTC (rev 155446) @@ -1455,14 +1455,6 @@ webkit.org/b/120669 accessibility/notification-listeners.html [ Failure ] -webkit.org/b/120670 accessibility/lists.html [ Failure ] -webkit.org/b/120670 accessibility/plugin.html [ Failure ] -webkit.org/b/120670 accessibility/table-detection.html [ Failure ] -webkit.org/b/120670 accessibility/table-one-cell.html [ Failure ] -webkit.org/b/120670 accessibility/table-with-aria-role.html [ Failure ] -webkit.org/b/120670 accessibility/table-with-rules.html [ Failure ] -webkit.org/b/120670 accessibility/transformed-element.html [ Failure ] - webkit.org/b/120596 css3/background/background-repeat-space-border.html [ ImageOnlyFailure ] webkit.org/b/120596 css3/background/background-repeat-space-content.html [ ImageOnlyFailure ] webkit.org/b/120596 css3/background/background-repeat-space-padding.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [155031] trunk/Source/WebCore
Title: [155031] trunk/Source/WebCore
Revision 155031
Author ma...@webkit.org
Date 2013-09-04 03:11:00 -0700 (Wed, 04 Sep 2013)
Log Message
[GTK] Reimplement atk_text_get_text_*_offset for SENTENCE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114873
Reviewed by Chris Fleizach.
Re-implement these functions without using GailTextUtil nor Pango.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextWordForBoundary): Renamed from webkitAccessibleTextGetWordForBoundary,
to keep it consistent with names for new functions.
(isSentenceBoundary): Helper function to know when we are either
at the beginning or the end of a sentence.
(isWhiteSpaceBetweenSentences): It returns true if we are in the
middle of a white space between sentences. Useful for implementing
the SENTENCE_END boundary type.
(sentenceAtPositionForAtkBoundary): New helper function to find the
sentence at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextSentenceForBoundary): New function,
implementing atk_text_get_text_*_offset for SENTENCE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
SENTENCE boundaries with webkitAccessibleTextSentenceForBoundary().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (155030 => 155031)
--- trunk/Source/WebCore/ChangeLog 2013-09-04 10:09:42 UTC (rev 155030)
+++ trunk/Source/WebCore/ChangeLog 2013-09-04 10:11:00 UTC (rev 155031)
@@ -1,3 +1,27 @@
+2013-09-04 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Reimplement atk_text_get_text_*_offset for SENTENCE boundaries
+https://bugs.webkit.org/show_bug.cgi?id=114873
+
+Reviewed by Chris Fleizach.
+
+Re-implement these functions without using GailTextUtil nor Pango.
+
+* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+(webkitAccessibleTextWordForBoundary): Renamed from webkitAccessibleTextGetWordForBoundary,
+to keep it consistent with names for new functions.
+(isSentenceBoundary): Helper function to know when we are either
+at the beginning or the end of a sentence.
+(isWhiteSpaceBetweenSentences): It returns true if we are in the
+middle of a white space between sentences. Useful for implementing
+the SENTENCE_END boundary type.
+(sentenceAtPositionForAtkBoundary): New helper function to find the
+sentence at a given position considering values of AtkTextBoundary.
+(webkitAccessibleTextSentenceForBoundary): New function,
+implementing atk_text_get_text_*_offset for SENTENCE.
+(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
+SENTENCE boundaries with webkitAccessibleTextSentenceForBoundary().
+
2013-09-04 Andrei Bucur abu...@adobe.com
[CSS Regions] Extend the RenderRegionRange class to include overflow information + apply the layout overflow
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (155030 => 155031)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-09-04 10:09:42 UTC (rev 155030)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-09-04 10:11:00 UTC (rev 155031)
@@ -38,6 +38,7 @@
#include Document.h
#include Font.h
#include FrameView.h
+#include HTMLParserIdioms.h
#include HostWindow.h
#include InlineTextBox.h
#include NotImplemented.h
@@ -771,7 +772,7 @@
return count;
}
-static char* webkitAccessibleTextGetWordForBoundary(AtkText* text, int offset, AtkTextBoundary boundaryType, GetTextRelativePosition textPosition, int* startOffset, int* endOffset)
+static char* webkitAccessibleTextWordForBoundary(AtkText* text, int offset, AtkTextBoundary boundaryType, GetTextRelativePosition textPosition, int* startOffset, int* endOffset)
{
AccessibilityObject* coreObject = core(text);
Document* document = coreObject-document();
@@ -832,6 +833,139 @@
return webkitAccessibleTextGetText(text, *startOffset, *endOffset);
}
+static bool isSentenceBoundary(const VisiblePosition pos)
+{
+if (pos.isNull())
+return false;
+
+// It's definitely a sentence boundary if there's nothing before.
+if (pos.previous().isNull())
+return true;
+
+// We go backwards and forward to make sure about this.
+VisiblePosition startOfPreviousSentence = startOfSentence(pos);
+return startOfPreviousSentence.isNotNull() pos == endOfSentence(startOfPreviousSentence);
+}
+
+static bool isWhiteSpaceBetweenSentences(const VisiblePosition position)
+{
+if (position.isNull())
+return false;
+
+if (!isWhitespace(position.characterAfter()))
+return false;
+
+VisiblePosition startOfWhiteSpace = startOfWord(position, RightWordIfOnBoundary);
+VisiblePosition endOfWhiteSpace = endOfWord(startOfWhit
[webkit-changes] [155038] trunk/Tools
Title: [155038] trunk/Tools Revision 155038 Author ma...@webkit.org Date 2013-09-04 06:31:12 -0700 (Wed, 04 Sep 2013) Log Message REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing https://bugs.webkit.org/show_bug.cgi?id=100408 Unreviewed gardening. Unskip TestWebKitAccessibility after manually checking that it's running properly in the bot. * Scripts/run-gtk-tests: (TestRunner): Unskipped TestWebKitAccessibility. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (155037 => 155038) --- trunk/Tools/ChangeLog 2013-09-04 12:42:21 UTC (rev 155037) +++ trunk/Tools/ChangeLog 2013-09-04 13:31:12 UTC (rev 155038) @@ -1,3 +1,14 @@ +2013-09-04 Mario Sanchez Prada mario.pr...@samsung.com + +REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing +https://bugs.webkit.org/show_bug.cgi?id=100408 + +Unreviewed gardening. Unskip TestWebKitAccessibility after +manually checking that it's running properly in the bot. + +* Scripts/run-gtk-tests: +(TestRunner): Unskipped TestWebKitAccessibility. + 2013-09-04 Zan Dobersek zdober...@igalia.com [GTK] Add support for the Wayland build target Modified: trunk/Tools/Scripts/run-gtk-tests (155037 => 155038) --- trunk/Tools/Scripts/run-gtk-tests 2013-09-04 12:42:21 UTC (rev 155037) +++ trunk/Tools/Scripts/run-gtk-tests 2013-09-04 13:31:12 UTC (rev 155038) @@ -68,7 +68,6 @@ SkippedTest(unittests/testwebview, /webkit/webview/icon-uri, Test times out in GTK Linux 64-bit Release bot, 82328), SkippedTest(unittests/testatk, /webkit/atk/getTextInParagraphAndBodyModerate, Test fails, 105538), SkippedTest(WebKit2APITests/TestResources, /webkit2/WebKitWebView/resources, Test is flaky in GTK Linux 32-bit Release bot, 82868), -SkippedTest(WebKit2APITests/TestWebKitAccessibility, /webkit2/WebKitAccessibility/atspi-basic-hierarchy, Test fails, 100408), SkippedTest(WebKit2APITests/TestWebKitWebView, SkippedTest.ENTIRE_SUITE, Test times out after r150890, 117689), SkippedTest(WebKit2APITests/TestContextMenu, SkippedTest.ENTIRE_SUITE, Test times out after r150890, 117689), SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.CanHandleRequest, Test fails, 88453), ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [154950] trunk/Tools
Title: [154950] trunk/Tools
Revision 154950
Author ma...@webkit.org
Date 2013-09-02 05:41:13 -0700 (Mon, 02 Sep 2013)
Log Message
Unreviewed. Move myself to the reviewers list.
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (154949 => 154950)
--- trunk/Tools/ChangeLog 2013-09-02 06:36:21 UTC (rev 154949)
+++ trunk/Tools/ChangeLog 2013-09-02 12:41:13 UTC (rev 154950)
@@ -1,3 +1,9 @@
+2013-09-02 Mario Sanchez Prada mario.pr...@samsung.com
+
+Unreviewed. Move myself to the reviewers list.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2013-09-01 Alexey Proskuryakov a...@apple.com
[WK2][Mac] Drag and drop tests interfere with user's UI
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (154949 => 154950)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2013-09-02 06:36:21 UTC (rev 154949)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2013-09-02 12:41:13 UTC (rev 154950)
@@ -1564,16 +1564,6 @@
bul...@chromium.org
]
},
- Mario Sanchez Prada : {
- emails : [
-ma...@webkit.org,
-mario.pr...@samsung.com
- ],
- expertise : WebKitGTK+, a11y, Epiphany/WebKit Contributor,
- nicks : [
-msanchez
- ]
- },
Mark Lam : {
emails : [
mark@apple.com
@@ -3899,6 +3889,16 @@
othermaciej
]
},
+ Mario Sanchez Prada : {
+ emails : [
+ma...@webkit.org,
+mario.pr...@samsung.com
+ ],
+ expertise : WebKitGTK+, Accessibility, WebKit2, Epiphany/WebKit Contributor,
+ nicks : [
+msanchez
+ ]
+ },
Mark Hahnenberg : {
emails : [
mhahnenb...@apple.com
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [154105] trunk/LayoutTests
Title: [154105] trunk/LayoutTests Revision 154105 Author ma...@webkit.org Date 2013-08-15 09:49:59 -0700 (Thu, 15 Aug 2013) Log Message [GTK] Unreviewed gardening. Move Mac specific expectation for accessibility test to the cross platform directory, as the result it's shared with GTK and EFL ports. * accessibility/heading-title-includes-links-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/heading-title-includes-links-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/accessibility/heading-title-includes-links-expected.txt Removed Paths trunk/LayoutTests/platform/mac/accessibility/heading-title-includes-links-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (154104 => 154105) --- trunk/LayoutTests/ChangeLog 2013-08-15 16:44:33 UTC (rev 154104) +++ trunk/LayoutTests/ChangeLog 2013-08-15 16:49:59 UTC (rev 154105) @@ -1,3 +1,12 @@ +2013-08-15 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Unreviewed gardening. Move Mac specific expectation for +accessibility test to the cross platform directory, as the result +it's shared with GTK and EFL ports. + +* accessibility/heading-title-includes-links-expected.txt: Renamed +from LayoutTests/platform/mac/accessibility/heading-title-includes-links-expected.txt. + 2013-08-15 Allan Sandfeld Jensen allan.jen...@digia.com Empty qt-5.0 expectations into qt expectations Copied: trunk/LayoutTests/accessibility/heading-title-includes-links-expected.txt (from rev 154103, trunk/LayoutTests/platform/mac/accessibility/heading-title-includes-links-expected.txt) (0 => 154105) --- trunk/LayoutTests/accessibility/heading-title-includes-links-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/heading-title-includes-links-expected.txt 2013-08-15 16:49:59 UTC (rev 154105) @@ -0,0 +1,12 @@ +Apple + +This tests that the title of a heading will include links if available. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS successfullyParsed is true + +TEST COMPLETE +Heading title: AXTitle: Apple + Deleted: trunk/LayoutTests/platform/mac/accessibility/heading-title-includes-links-expected.txt (154104 => 154105) --- trunk/LayoutTests/platform/mac/accessibility/heading-title-includes-links-expected.txt 2013-08-15 16:44:33 UTC (rev 154104) +++ trunk/LayoutTests/platform/mac/accessibility/heading-title-includes-links-expected.txt 2013-08-15 16:49:59 UTC (rev 154105) @@ -1,12 +0,0 @@ -Apple - -This tests that the title of a heading will include links if available. - -On success, you will see a series of PASS messages, followed by TEST COMPLETE. - - -PASS successfullyParsed is true - -TEST COMPLETE -Heading title: AXTitle: Apple - ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153652] trunk/Source
Title: [153652] trunk/Source Revision 153652 Author ma...@webkit.org Date 2013-08-02 09:02:11 -0700 (Fri, 02 Aug 2013) Log Message Implement atk_text_get_text_*_offset for WORD https://bugs.webkit.org/show_bug.cgi?id=114871 Reviewed by Martin Robinson. Source/WebCore: Re-implement this functions without using GailTextUtil nor Pango. * accessibility/atk/WebKitAccessibleInterfaceText.cpp: (textForObject): Made the parameter a const, to avoid warnings. (getSelectionOffsetsForObject): Add special cases for END boundaries. (emptyTextSelectionAtOffset): Convenience function to be used in early returns from functions returning both text and offsets. (webkitAccessibleTextGetChar): Use emptyTextSelectionAtOffset(), and remove checks that are now done outside of this function, in webkitAccessibleTextGetTextForOffset(). (nextWordStartPosition): Helper function to reliably find the start of the next word as and user would do it by navigating with Ctrl and the arrows (considering spaces and punctuation). (previousWordEndPosition): Similar to nextWordStartPosition, but written to help find the end of the previous one. (wordAtPositionForAtkBoundary): Helper function to find the word at a given position considering values of AtkTextBoundary. (numberOfReplacedElementsBeforeOffset): Helper function to help figure out how many embedded objects we have exposed for an AtkText object, used to adjust offsets coming from outside. (webkitAccessibleTextGetWordForBoundary): New function, implementing atk_text_get_text_*_offset for WORD. (webkitAccessibleTextGetTextForOffset): Replace usage of Gail for WORD boundaries with webkitAccessibleTextGetWordForBoundary(). Also, moved the initialization of the start and end offsets to the bottom, into the gail/pango section, since those values will be from now on initialized in getSelectionOffsetsForObject(). (webkitAccessibleTextGetSelection): Removed the initialization of the start and end offsets, since those values will be from now on initialized in getSelectionOffsetsForObject(). Source/WebKit/gtk: Updated current unit tests and add a new one specific for embedded objects, to ensure we are covering even more cases than before. * tests/testatk.c: (testWebkitAtkGetTextAtOffsetWithEmbeddedObjects): New. (main): Added new test to the test suite. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/tests/testatk.c Diff Modified: trunk/Source/WebCore/ChangeLog (153651 => 153652) --- trunk/Source/WebCore/ChangeLog 2013-08-02 15:52:39 UTC (rev 153651) +++ trunk/Source/WebCore/ChangeLog 2013-08-02 16:02:11 UTC (rev 153652) @@ -1,3 +1,41 @@ +2013-08-02 Mario Sanchez Prada mario.pr...@samsung.com + +Implement atk_text_get_text_*_offset for WORD +https://bugs.webkit.org/show_bug.cgi?id=114871 + +Reviewed by Martin Robinson. + +Re-implement this functions without using GailTextUtil nor Pango. + +* accessibility/atk/WebKitAccessibleInterfaceText.cpp: +(textForObject): Made the parameter a const, to avoid warnings. +(getSelectionOffsetsForObject): Add special cases for END boundaries. +(emptyTextSelectionAtOffset): Convenience function to be used in +early returns from functions returning both text and offsets. +(webkitAccessibleTextGetChar): Use emptyTextSelectionAtOffset(), +and remove checks that are now done outside of this function, in +webkitAccessibleTextGetTextForOffset(). +(nextWordStartPosition): Helper function to reliably find the +start of the next word as and user would do it by navigating with +Ctrl and the arrows (considering spaces and punctuation). +(previousWordEndPosition): Similar to nextWordStartPosition, but +written to help find the end of the previous one. +(wordAtPositionForAtkBoundary): Helper function to find the word +at a given position considering values of AtkTextBoundary. +(numberOfReplacedElementsBeforeOffset): Helper function to help +figure out how many embedded objects we have exposed for an +AtkText object, used to adjust offsets coming from outside. +(webkitAccessibleTextGetWordForBoundary): New function, +implementing atk_text_get_text_*_offset for WORD. +(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for +WORD boundaries with webkitAccessibleTextGetWordForBoundary(). +Also, moved the initialization of the start and end offsets to the +bottom, into the gail/pango section, since those values will be +from now on initialized in getSelectionOffsetsForObject(). +(webkitAccessibleTextGetSelection): Removed the initialization of +the start and end offsets, since those values will be from now on +initialized in getSelectionOffsetsForObject(). + 2013
[webkit-changes] [153427] trunk/Source
Title: [153427] trunk/Source
Revision 153427
Author ma...@webkit.org
Date 2013-07-29 08:46:35 -0700 (Mon, 29 Jul 2013)
Log Message
[ATK] Issues with edge cases when getting offsets for a text range in AtkText
https://bugs.webkit.org/show_bug.cgi?id=118908
Reviewed by Martin Robinson.
Source/WebCore:
Reimplement getSelectionOffsetsForObject() just in term of
Positions instead of using ranges, which makes it simpler and
works better. Also, make sure we use the right Node as reference
for the accessibility object by getting the proper one both for
text control objects (e.g. input, text area) and normal ones.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getNodeForAccessibilityObject): New helper function to ensure we
always get the relevant object from the DOM tree for a given
accessibility object, in the context of the implementation of
AtkText, so it works both with Text Controls and other elements.
(getSelectionOffsetsForObject): Rewritten this function in terms
of VisiblePositions and avoiding weird operations with ranges, so
we have more control to fine tune the results and give more
accurate ones. Besides, now it works better with edge cases.
Source/WebKit/gtk:
* tests/testatk.c:
(runGetTextTests): Updated unit tests to check more cases of
calling the atk_text_get_text_*_offset() functions for WORD.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/tests/testatk.c
Diff
Modified: trunk/Source/WebCore/ChangeLog (153426 => 153427)
--- trunk/Source/WebCore/ChangeLog 2013-07-29 15:36:54 UTC (rev 153426)
+++ trunk/Source/WebCore/ChangeLog 2013-07-29 15:46:35 UTC (rev 153427)
@@ -1,3 +1,26 @@
+2013-07-29 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Issues with edge cases when getting offsets for a text range in AtkText
+https://bugs.webkit.org/show_bug.cgi?id=118908
+
+Reviewed by Martin Robinson.
+
+Reimplement getSelectionOffsetsForObject() just in term of
+Positions instead of using ranges, which makes it simpler and
+works better. Also, make sure we use the right Node as reference
+for the accessibility object by getting the proper one both for
+text control objects (e.g. input, text area) and normal ones.
+
+* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+(getNodeForAccessibilityObject): New helper function to ensure we
+always get the relevant object from the DOM tree for a given
+accessibility object, in the context of the implementation of
+AtkText, so it works both with Text Controls and other elements.
+(getSelectionOffsetsForObject): Rewritten this function in terms
+of VisiblePositions and avoiding weird operations with ranges, so
+we have more control to fine tune the results and give more
+accurate ones. Besides, now it works better with edge cases.
+
2013-07-29 Zan Dobersek zdober...@igalia.com
Clean up DragImage
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (153426 => 153427)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-07-29 15:36:54 UTC (rev 153426)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-07-29 15:46:35 UTC (rev 153427)
@@ -501,53 +501,65 @@
return offset - offsetAdjustmentForListItem(coreObject);
}
+static Node* getNodeForAccessibilityObject(AccessibilityObject* coreObject)
+{
+if (!coreObject-isNativeTextControl())
+return coreObject-node();
+
+// For text controls, we get the first visible position on it (which will
+// belong to its inner element, unreachable from the DOM) and return its
+// parent node, so we have a bounding node for the accessibility object.
+VisiblePosition positionInTextControlInnerElement = coreObject-visiblePositionForIndex(0, true);
+Node* innerMostNode = positionInTextControlInnerElement.deepEquivalent().anchorNode();
+if (!innerMostNode)
+return 0;
+
+return innerMostNode-parentNode();
+}
+
static void getSelectionOffsetsForObject(AccessibilityObject* coreObject, VisibleSelection selection, gint startOffset, gint endOffset)
{
-if (!coreObject-isAccessibilityRenderObject())
+// Default values, unless the contrary is proved.
+startOffset = 0;
+endOffset = 0;
+
+Node* node = getNodeForAccessibilityObject(coreObject);
+if (!node)
return;
-// Early return if the selection doesn't affect the selected node.
-if (!selectionBelongsToObject(coreObject, selection))
+if (selection.isNone())
return;
-// We need to find the exact start and end positions in the
-// selected node that intersects the selection, to later on get
-// the right values for the effective start and end offsets.
-Po
[webkit-changes] [153435] trunk
Title: [153435] trunk
Revision 153435
Author ma...@webkit.org
Date 2013-07-29 11:26:52 -0700 (Mon, 29 Jul 2013)
Log Message
[ATK] Implement attributesOfChildren() for AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118967
Reviewed by Gustavo Noronha Silva.
Tools:
Implemented AccessibilityUIElement::attributesOfChildren() both
in DumpRenderTree and the WebKitTestRunner.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::attributesOfChildren): Implemented.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
LayoutTests:
Removed fixed tests from TestExpectations and added/updated expected
results for tests that are now dumping more useful information.
* platform/gtk/TestExpectations: Removed three fixed tests.
* platform/gtk/accessibility/image-map2-expected.txt: Updated.
* platform/gtk/accessibility/lists-expected.txt: Added.
* platform/gtk/accessibility/plugin-expected.txt: Added.
* platform/gtk/accessibility/table-with-aria-role-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Added Paths
trunk/LayoutTests/platform/gtk/accessibility/lists-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/plugin-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/table-with-aria-role-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (153434 => 153435)
--- trunk/LayoutTests/ChangeLog 2013-07-29 18:10:32 UTC (rev 153434)
+++ trunk/LayoutTests/ChangeLog 2013-07-29 18:26:52 UTC (rev 153435)
@@ -1,3 +1,19 @@
+2013-07-29 Mario Sanchez Prada mario.pr...@samsung.com
+
+[ATK] Implement attributesOfChildren() for AccessibilityUIElement
+https://bugs.webkit.org/show_bug.cgi?id=118967
+
+Reviewed by Gustavo Noronha Silva.
+
+Removed fixed tests from TestExpectations and added/updated expected
+results for tests that are now dumping more useful information.
+
+* platform/gtk/TestExpectations: Removed three fixed tests.
+* platform/gtk/accessibility/image-map2-expected.txt: Updated.
+* platform/gtk/accessibility/lists-expected.txt: Added.
+* platform/gtk/accessibility/plugin-expected.txt: Added.
+* platform/gtk/accessibility/table-with-aria-role-expected.txt: Added.
+
2013-07-29 Renata Hodovan r...@webkit.org
ASSERT_NOT_REACHED was touched in WebCore::SVGAnimatedType::valueAsString
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (153434 => 153435)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-07-29 18:10:32 UTC (rev 153434)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-07-29 18:26:52 UTC (rev 153435)
@@ -79,8 +79,6 @@
webkit.org/b/98348 accessibility/radio-button-group-members.html [ WontFix Missing ]
webkit.org/b/98348 accessibility/table-attributes.html [ WontFix Missing ]
webkit.org/b/98348 accessibility/table-sections.html [ WontFix Missing ]
-webkit.org/b/98348 accessibility/table-with-aria-role.html [ WontFix Missing ]
-webkit.org/b/98348 accessibility/plugin.html [ WontFix Missing ]
# Feature disabled, see: https://bugs.webkit.org/show_bug.cgi?id=85425
webkit.org/b/98925 fast/viewport/viewport-legacy-handheldfriendly.html [ Skip ]
@@ -864,9 +862,6 @@
webkit.org/b/98380 accessibility/th-as-title-ui.html [ Failure ]
webkit.org/b/98382 accessibility/visible-elements.html [ Failure ]
-# No platform-specific expectations available until we implement attributesOfChildren().
-webkit.org/b/118967 accessibility/lists.html [ Failure Missing ]
-
# Blur and focus events are not received for the following tests.
Bug(GTK) fast/events/blur-focus-window-should-blur-focus-element.html [ Failure ]
Bug(GTK) fast/dom/HTMLDocument/hasFocus.html [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt (153434 => 153435)
--- trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt 2013-07-29 18:10:32 UTC (rev 153434)
+++ trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt 2013-07-29 18:26:52 UTC (rev 153435)
@@ -1,5 +1,60 @@
Image map - test 2 - 2 Links (alt tags)
--
+AXRole: AXDiv
+AXParent: AXWebArea
+AXChildren: 0
+AXPosition: { 8.00, 8.00 }
+AXSize: { 784.00, 34.00 }
+AXTitle:
+AXDescription:
+AXValue: Image map - test 2 - 2 Links (alt tags)\n--\n
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: html-id:result, toolkit:WebKitGtk
+
+AXRole: AXLink
+AXParent: AXWebArea
+AXChildren: 0
+A
[webkit-changes] [153036] trunk/LayoutTests
Title: [153036] trunk/LayoutTests
Revision 153036
Author ma...@webkit.org
Date 2013-07-23 03:03:05 -0700 (Tue, 23 Jul 2013)
Log Message
[GTK] Unreviewed gardening. Added needed baselines for GTK+.
* platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
* platform/gtk/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
* platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt: Added.
* platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Added.
* platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Added.
* platform/gtk/fast/text/text-combine-different-fonts-expected.txt: Added.
* platform/gtk/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt
trunk/LayoutTests/platform/gtk/fast/css-generated-content/details-summary-before-after-expected.txt
trunk/LayoutTests/platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt
trunk/LayoutTests/platform/gtk/fast/regions/region-dynamic-after-before-expected.txt
trunk/LayoutTests/platform/gtk/fast/regions/region-generated-content-before-after-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/text-combine-different-fonts-expected.txt
trunk/LayoutTests/platform/gtk/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (153035 => 153036)
--- trunk/LayoutTests/ChangeLog 2013-07-23 09:49:31 UTC (rev 153035)
+++ trunk/LayoutTests/ChangeLog 2013-07-23 10:03:05 UTC (rev 153036)
@@ -1,3 +1,15 @@
+2013-07-23 Mario Sanchez Prada mario.pr...@samsung.com
+
+[GTK] Unreviewed gardening. Added needed baselines for GTK+.
+
+* platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
+* platform/gtk/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
+* platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt: Added.
+* platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Added.
+* platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Added.
+* platform/gtk/fast/text/text-combine-different-fonts-expected.txt: Added.
+* platform/gtk/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt: Added.
+
2013-07-23 Frédéric Wang fred.w...@free.fr
Enable some MathML reftests on Windows and EFL ports.
Added: trunk/LayoutTests/platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt (0 => 153036)
--- trunk/LayoutTests/platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt 2013-07-23 10:03:05 UTC (rev 153036)
@@ -0,0 +1,68 @@
+layer at (0,0) size 785x619
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x619
+ RenderBlock {html} at (0,0) size 785x619
+RenderBody {body} at (8,8) size 769x603
+ RenderBlock {div} at (0,0) size 769x201
+RenderBlock {div} at (0,0) size 55x146 [border: (1px solid #FF)]
+ RenderText {#text} at (1,1) size 53x48
+text run at (1,1) width 48: \x{70BA}
+ RenderRuby (inline) {ruby} at (0,0) size 53x48
+RenderRubyRun (anonymous) at (1,49) size 53x48
+ RenderRubyBase (anonymous) at (0,0) size 53x48
+RenderText {#text} at (0,0) size 53x48
+ text run at (0,0) width 48: \x{6AFB}
+ RenderText {#text} at (1,97) size 53x48
+text run at (1,97) width 48: \x{7530}
+RenderBlock {div} at (0,146) size 769x55 [border: (1px solid #008000)]
+ RenderText {#text} at (1,1) size 48x53
+text run at (1,1) width 48: \x{70BA}
+ RenderRuby (inline) {ruby} at (0,0) size 48x53
+RenderRubyRun (anonymous) at (49,1) size 48x53
+ RenderRubyBase (anonymous) at (0,0) size 48x53
+RenderText {#text} at (0,0) size 48x53
+ text run at (0,0) width 48: \x{6AFB}
+ RenderText {#text} at (97,1) size 48x53
+text run at (97,1) width 48: \x{7530}
+ RenderBlock {div} at (0,201) size 769x201
+RenderBlock {div} at (0,0) size 55x146 [border: (1px solid #FF)]
+ RenderText {#text} at (1,1) size 53x48
+text run at (1,1) width 48: \x{70BA}
+ RenderRuby (inline) {ruby} at (0,0) size 53x48
+RenderRubyRun (anonymous) at (1,49) size 53x48
+ RenderRubyBase (anonymous) at (0,0) size 53x48
+RenderText {#text} at (0,0) size 53x48
+ text run at (0,0) width 48: \x{6AFB}
+ Rend
[webkit-changes] [153047] trunk/LayoutTests
Title: [153047] trunk/LayoutTests Revision 153047 Author ma...@webkit.org Date 2013-07-23 05:24:40 -0700 (Tue, 23 Jul 2013) Log Message [GTK] Unreviewed gardening. Added needed baselines after r104133. * platform/gtk/perf/nested-combined-selectors-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/gtk/perf/ trunk/LayoutTests/platform/gtk/perf/nested-combined-selectors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (153046 => 153047) --- trunk/LayoutTests/ChangeLog 2013-07-23 11:51:04 UTC (rev 153046) +++ trunk/LayoutTests/ChangeLog 2013-07-23 12:24:40 UTC (rev 153047) @@ -1,3 +1,9 @@ +2013-07-23 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Unreviewed gardening. Added needed baselines after r104133. + +* platform/gtk/perf/nested-combined-selectors-expected.txt: Added. + 2013-07-23 Simon Pena simon.p...@samsung.com [GTK] Unreviewed gardening. New baselines after r152941. Added: trunk/LayoutTests/platform/gtk/perf/nested-combined-selectors-expected.txt (0 => 153047) --- trunk/LayoutTests/platform/gtk/perf/nested-combined-selectors-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/perf/nested-combined-selectors-expected.txt 2013-07-23 12:24:40 UTC (rev 153047) @@ -0,0 +1,4 @@ +Tests styling multiple combinators have linear performance +PASS +PASS + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [153049] trunk/LayoutTests
Title: [153049] trunk/LayoutTests
Revision 153049
Author ma...@webkit.org
Date 2013-07-23 06:20:41 -0700 (Tue, 23 Jul 2013)
Log Message
[GTK] Unreviewed gardening. Baseline and rebaseline needed after r152612 and r152911.
* platform/gtk/editing/caret/caret-color-expected.txt: Added.
* platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Updated.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt
Added Paths
trunk/LayoutTests/platform/gtk/editing/caret/
trunk/LayoutTests/platform/gtk/editing/caret/caret-color-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (153048 => 153049)
--- trunk/LayoutTests/ChangeLog 2013-07-23 12:35:48 UTC (rev 153048)
+++ trunk/LayoutTests/ChangeLog 2013-07-23 13:20:41 UTC (rev 153049)
@@ -1,5 +1,12 @@
2013-07-23 Mario Sanchez Prada mario.pr...@samsung.com
+[GTK] Unreviewed gardening. Baseline and rebaseline needed after r152612 and r152911.
+
+* platform/gtk/editing/caret/caret-color-expected.txt: Added.
+* platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Updated.
+
+2013-07-23 Mario Sanchez Prada mario.pr...@samsung.com
+
[GTK] Unreviewed gardening. Added needed baselines after r104133.
* platform/gtk/perf/nested-combined-selectors-expected.txt: Added.
Added: trunk/LayoutTests/platform/gtk/editing/caret/caret-color-expected.txt (0 => 153049)
--- trunk/LayoutTests/platform/gtk/editing/caret/caret-color-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/caret/caret-color-expected.txt 2013-07-23 13:20:41 UTC (rev 153049)
@@ -0,0 +1,18 @@
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x91
+ RenderBlock {HTML} at (0,0) size 800x91
+RenderBody {BODY} at (8,16) size 784x67
+ RenderBlock {P} at (0,0) size 784x34
+RenderText {#text} at (0,0) size 735x34
+ text run at (0,0) width 735: This tests to make sure that the caret is visible in the black background by getting the caret color from the color of the
+ text run at (0,17) width 621: element(span) containing the text, not the parent element(div) that has the contentEditable attribute.
+ RenderBlock {DIV} at (0,50) size 784x17
+RenderInline {SPAN} at (0,0) size 121x17 [color=#FF] [bgcolor=#00]
+ RenderText {#text} at (0,0) size 121x17
+text run at (0,0) width 121: Where is my caret?
+RenderText {#text} at (0,0) size 0x0
+caret: position 17 of child 0 {#text} of child 1 {SPAN} of child 3 {DIV} of body
Modified: trunk/LayoutTests/platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt (153048 => 153049)
--- trunk/LayoutTests/platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt 2013-07-23 12:35:48 UTC (rev 153048)
+++ trunk/LayoutTests/platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt 2013-07-23 13:20:41 UTC (rev 153049)
@@ -1,9 +1,8 @@
layer at (0,0) size 800x600
- RenderView at (0,0) size 400x600
-layer at (-16,0) size 416x600 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (384,0) size 416x600
RenderBlock {HTML} at (0,0) size 416x600
RenderBody {BODY} at (8,8) size 400x600
RenderBlock {DIV} at (0,0) size 400x600
RenderImage {IMG} at (392,0) size 400x600
RenderText {#text} at (0,0) size 0x0
-scrolled to -400,0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
