[MediaWiki-CodeReview] [MediaWiki r85953]: New comment added, and revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r85953.

Old Status: new
New Status: fixme

User "Catrope" also posted a comment on MediaWiki.r85953.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85953#c15941

Comment:


-   title = new mw.Title( result.title ).setNamespace( 
'file' ).getNameText();
+   title = new mw.Title( result.title ).setNamespace( 
'file' );
} catch ( e ) {
// unparseable result from unique test? 
title = '[unparseable name]';

The code below treats title as an mw.Title object, 
even though the catch path sets it to a string. Calling 
.toString() on a string is safe though, but calling 
.getNameText() is not.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85958]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r85958.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85958#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85973]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r85973.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85973#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86020]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86020.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86020#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86022]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86022.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86022#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86024]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86024.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86024#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86026]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86026.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86026#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86029]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86029.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86029#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85994]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r85994.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85994#c15942

Comment:

Should probably be
 +$wgOut->addHTML( $this->msg->parseBlock() );
But! I think better idea would be to modify (add|wrap)WikiMsg(Array)? to accept 
Message objects. That would be more natural. Also you could construct a message 
object from the message key and params, so you don't need to check later which 
one you got.


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86033]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86033.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86033#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85953]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r85953.

Old Status: fixme
New Status: resolved

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85953#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86035]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86035.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86035#c0

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86013]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r86013.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86013#c15943

Comment:

Could you mention what and how it was wrong before you fixed it. From the diffs 
I only see expected output.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86015]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r86015.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86015#c15944

Comment:

If you are going to work on this, wfMessage->exists() could be useful.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] MediaWiki security release 1.16.4

[Tim Starling]

Our patch for the Internet Explorer 6 XSS issue (bug 28235) released
two days ago in 1.16.3 was insufficient to fix that bug. The original
reporter, Masato Kinugawa, pointed out the flaw on bug 28507. So we
are doing another release, which contains a second attempt at fixing
the issue.

Apologies to everyone for the inconvenience. Big thanks go to Masato
Kinugawa for helping to keep MediaWiki secure. Thanks also to Roan
Kattouw who helped me test the patch this time around, so that we can
hopefully avoid a repeat.

It is necessary to upgrade MediaWiki to avoid an XSS vulnerability for
Internet Explorer clients, version 6 and earlier. Also, if you used
the Apache configuration I suggested in the previous release
announcement, you should update it to:

RewriteEngine On
RewriteCond %{QUERY_STRING} \.[a-z0-9]{1,4}(#|\?|$) [nocase]
RewriteRule . - [forbidden]


We missed the fact that there can be more than one question mark in a
URL. In certain circumstances, IE 6 will use a file extension
immediately before a question mark character, regardless of how many
question marks precede it. For example, with the URL:

http://example.com/a?b?c.html?d?e

IE 6 will see the file extension as ".html".

**
Download:
http://download.wikimedia.org/mediawiki/1.16/mediawiki-1.16.4.tar.gz

Patch to previous version (1.16.3):
http://download.wikimedia.org/mediawiki/1.16/mediawiki-1.16.4.patch.gz

GPG signatures:
http://download.wikimedia.org/mediawiki/1.16/mediawiki-1.16.4.tar.gz.sig
http://download.wikimedia.org/mediawiki/1.16/mediawiki-1.16.4.patch.gz.sig

Public keys:
https://secure.wikimedia.org/keys.html


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] MediaWiki security release 1.16.4

[Daniel Kinzler]

On 14.04.2011 09:47, Tim Starling wrote:
> We missed the fact that there can be more than one question mark in a
> URL. In certain circumstances, IE 6 will use a file extension
> immediately before a question mark character, regardless of how many
> question marks precede it. For example, with the URL:
> 
> http://example.com/a?b?c.html?d?e
> 
> IE 6 will see the file extension as ".html".

Wow, seriously? IE6 should be taken out the back and shot...

-- daniel

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping IE6 support (was: MediaWiki security release 1.16.4)

[Siebrand Mazeland]

On 14-04-11 10:02 Daniel Kinzler  wrote:


>Wow, seriously? IE6 should be taken out the back and shot...

You're in luck. These days, even Microsoft agrees with you:

http://www.ie6countdown.com/

So when will we be able to drop IE6 support in MediaWiki completely? What
metrics/thresholds can we use?

I would suggest to set a percentage of worldwide usage as reported by some
"trusted" statistics reported, or possibly a percentage of Wikimedia
pageviews. 3% or 4%?

Any thoughts?

Siebrand



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping IE6 support (was: MediaWiki security release 1.16.4)

[Roan Kattouw]

2011/4/14 Siebrand Mazeland :
> So when will we be able to drop IE6 support in MediaWiki completely? What
> metrics/thresholds can we use?
>
IMO there's a difference between no longer supporting IE6 and no
longer protecting IE6 users from XSS attacks.

> I would suggest to set a percentage of worldwide usage as reported by some
> "trusted" statistics reported, or possibly a percentage of Wikimedia
> pageviews. 3% or 4%?
>
At least for JavaScript feature development, our unofficial cutoff for
"we're not gonna spend any time on this browser, if it works, great,
if it doesn't, tough luck" is 0.5%. However, that's just for JS
enhancements; it's my opinion that at least reading Wikipedia should
be possible (i.e. not severely broken) in almost every browser.

Roan Kattouw (Catrope)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping IE6 support

[Daniel Kinzler]

On 14.04.2011 11:10, Siebrand Mazeland wrote:
> On 14-04-11 10:02 Daniel Kinzler  wrote:
> 
>> Wow, seriously? IE6 should be taken out the back and shot...
> 
> You're in luck. These days, even Microsoft agrees with you:
> 
> http://www.ie6countdown.com/

Aw man, someone please spoof this website and replace "Internet Explorer 6" with
just "Internet Explorer", and make the download link point to firefox.

msiecountdown.com is still free...

-- daniel

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping IE6 support

[Guillaume Paumier]

Hi,

Le jeudi 14 avril 2011 11:21:57, Daniel Kinzler a écrit :
> On 14.04.2011 11:10, Siebrand Mazeland wrote:
> > On 14-04-11 10:02 Daniel Kinzler  wrote:
> >> Wow, seriously? IE6 should be taken out the back and shot...
> > 
> > You're in luck. These days, even Microsoft agrees with you:
> > 
> > http://www.ie6countdown.com/
> 
> Aw man, someone please spoof this website and replace "Internet Explorer 6"
> with just "Internet Explorer", and make the download link point to
> firefox.
> 
> msiecountdown.com is still free...

On a related note: http://theie9countdown.com

-- 
Guillaume Paumier

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping IE6 support

[Daniel Kinzler]

On 14.04.2011 11:46, Guillaume Paumier wrote:
> Hi,
>>> You're in luck. These days, even Microsoft agrees with you:
>>>
>>> http://www.ie6countdown.com/
>>
>> Aw man, someone please spoof this website and replace "Internet Explorer 6"
>> with just "Internet Explorer", and make the download link point to
>> firefox.
>>
>> msiecountdown.com is still free...
> 
> On a related note: http://theie9countdown.com
> 
hahaha thank you!

-- daniel

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping IE6 support (was: MediaWiki security release 1.16.4)

[Gerard Meijssen]

Hoi,
The people with IE6 have disproportionally problems with reading Wikipedia
in their mother tongue and IE6 can be found particularly in the "global
south". Also CommScore numbers are unlikely to see this potential.

The question is not should we support IE6, it is just that I wonder about
what our numbers show.
Thanks,
  GerardM

On 14 April 2011 11:14, Roan Kattouw  wrote:

> 2011/4/14 Siebrand Mazeland :
> > So when will we be able to drop IE6 support in MediaWiki completely? What
> > metrics/thresholds can we use?
> >
> IMO there's a difference between no longer supporting IE6 and no
> longer protecting IE6 users from XSS attacks.
>
> > I would suggest to set a percentage of worldwide usage as reported by
> some
> > "trusted" statistics reported, or possibly a percentage of Wikimedia
> > pageviews. 3% or 4%?
> >
> At least for JavaScript feature development, our unofficial cutoff for
> "we're not gonna spend any time on this browser, if it works, great,
> if it doesn't, tough luck" is 0.5%. However, that's just for JS
> enhancements; it's my opinion that at least reading Wikipedia should
> be possible (i.e. not severely broken) in almost every browser.
>
> Roan Kattouw (Catrope)
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added

[MediaWiki Mail]

User "DieBuche" posted a comment on MediaWiki.r85922.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15945
Commit summary:



Comment:

This is fixed r86039

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added

[MediaWiki Mail]

User "DieBuche" posted a comment on MediaWiki.r85922.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15946
Commit summary:



Comment:

But didn't it practically disappear previously as well (besides leaving an 
invisible table) ?
Parser test for Bug 529 works again in r86039.
And thanks for the followups!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Dropping IE6 support (was: MediaWiki security release 1.16.4)

[Roan Kattouw]

2011/4/14 Gerard Meijssen :
> Hoi,
> The people with IE6 have disproportionally problems with reading Wikipedia
> in their mother tongue and IE6 can be found particularly in the "global
> south". Also CommScore numbers are unlikely to see this potential.
>
> The question is not should we support IE6, it is just that I wonder about
> what our numbers show.

According to http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm
, IE6 is 3.65% of our traffic. There is no per-country breakdown of
browsers that I know of, though, maybe Erik Z could be talked into
making one.

Roan Kattouw (Catrope)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added

[MediaWiki Mail]

User "Bryan" posted a comment on MediaWiki.r86041.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c15947
Commit summary:

r86001, now with less scariness :P  I took out the delete action and did purge 
instead, which is a much more self-contained action-with-a-form.  Also 
implement a few changes suggested by Brion on IRC last night.

Comment:

You're awesome. I think you have cured the nightmares that many people get when 
they open Article.php.

A few remarks:


+   /**
+* Returns the name that goes in the \ page title
+*
+* Derived classes can override this, but usually it is easier to keep 
the
+* default behaviour. Messages can be added at run-time, see
+* MessageCache.php.
+*
+* @return String
+*/
+   protected function getDescription() {
+   return wfMsg( strtolower( $this->getName() ) );
+   }

I think you should return a wfMessage() instead of wfMsg(). This allows callers 
to determine themselves how to represent the message. For example, the API 
wants to return the plaintext, possibly parsemag'ed version of the message, 
while the regular UI wants a HTML representation.


Something that I don't like about this design, is the fact that UI-generation 
and backend-actions are tightly coupled, by means of the Form(less)Action class 
which derives from Action. I would personally decouple them something like this:

class Action {}
class ProtectAction extends Action {
[...]
}

class FormAction {
[...]
}

$form = new FormAction;
$form->setAction( 'ProtectAction' );
$form->show();

class ApiForAction {
[...]
}

$api = new ApiAction;
$api->setAction( 'ProtectAction' );
$api->execute();


(I haven't though very well about it, and it might be overzealous abstraction, 
but I'd at least look into this way)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] Status of 1.17 & 1.18

[Bryan Tong Minh]

Hi all,


I'm wondering what the status for 1.17 is. How far are we from RC? Is
there any more review left?

Related to this, as our review burden for 1.17 lessens, we should
start to think about 1.18: re-recruit reviewers again, start thinking
about when to branch 1.18, etc. Are there any plans related to that?


Bryan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Gantt extension for MediaWiki

[Maciej Jaros]

Hi.

I'm getting close to releasing JSWikiGantt extension and I'm wondering 
if this should go to SVN or not? And in effect should I ask for commit 
access to SVN or not. I have my own server so I can put my code there, 
but I'm not sure what are the habits with extensions.

Just to clarify what the extension is - it's basically a port of JSGantt 
to MediaWiki. It allows injecting Gantt diagrams as XML into articles. 
There's certainly a lot room for improvement (like e.g. an ability to 
have more then one diagram per page) and I still need to go for i18n, 
but that should be ready soon (I hope).

BTW are there any guidelines (or at least good examples) of i18n in JS? 
What I mean is - I need to use some (most) localized strings in JS and 
would like to use existing code (if possible) for pushing strings from 
PHP to JS.

I also have another extension for editing diagrams of certain type - 
namely calendar-diagrams for activities such as "Delegation", 
"Vacation", "Sick leave". From what I've read this probably shouldn't go 
to SVN or should it?

Oh, both extensions where written for 1.16, but I'm mostly using JS 
anyway so this probably shouldn't matter.

Regards,
Nux.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gantt extension for MediaWiki

[Roan Kattouw]

2011/4/14 Maciej Jaros :
> BTW are there any guidelines (or at least good examples) of i18n in JS?
> What I mean is - I need to use some (most) localized strings in JS and
> would like to use existing code (if possible) for pushing strings from
> PHP to JS.
>
[snip]
> Oh, both extensions where written for 1.16, but I'm mostly using JS
> anyway so this probably shouldn't matter.
>
Use ResourceLoader, which handles i18n for you. ResourceLoader is new
in 1.17 though, so code written with ResourceLoader will not work with
1.16 unless you go out of your way to make it dual-compatible.

See 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/ResourceLoader/Documentation/Using_with_extensions

Roan Kattouw (Catrope)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed

[MediaWiki Mail]

User "IAlex" changed the status of MediaWiki.r86041.

Old Status: new
New Status: fixme

User "IAlex" also posted a comment on MediaWiki.r86041.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86041#c15948
Commit summary:

r86001, now with less scariness :P  I took out the delete action and did purge 
instead, which is a much more self-contained action-with-a-form.  Also 
implement a few changes suggested by Brion on IRC last night.

Comment:

* This broke inline credits: Fatal error:  Class 'Credits' not found in 
includes/SkinTemplate.php on line 385 (there's a similar call in 
SkinLegacy)
* Action class is missing an accessor for the user language object (i.e. 
replacement of $wgLang)
* Asking people to ''not use globals $wgOut, $wgRequest, etc'' and in the 
meantime using wfMessage() or other wfMsg*() functions is inconsistent, since 
wfMessage() is depending on $wgLang, $wgOut and $wgTitle (depending on how your 
are using it).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86043]: New comment added

[MediaWiki Mail]

User "IAlex" posted a comment on MediaWiki.r86043.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86043#c15949
Commit summary:

Fix regression introduced in r82451. Only happens when getAllHeaders was not 
called before LanguageSelector hook was executed, not sure in which conditions 
this happens or not.

Comment:

Thanks for the fix!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Gantt extension for MediaWiki

[K. Peachey]

On Thu, Apr 14, 2011 at 9:26 PM, Maciej Jaros  wrote:
> Hi.
>
> I'm getting close to releasing JSWikiGantt extension and I'm wondering
> if this should go to SVN or not? And in effect should I ask for commit
> access to SVN or not. I have my own server so I can put my code there,
> but I'm not sure what are the habits with extensions.
> ...snip...
Yes, It's very nice when they are in our SVN server since you get the
added benefit of code going via our Code Review system and other users
can contribute when they see issues or want to improve on it.

More info about requesting commit access can be found here:
http://www.mediawiki.org/wiki/Commit_access#Requesting_commit_access

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added

[MediaWiki Mail]

User "Happy-melon" posted a comment on MediaWiki.r86041.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c15950
Commit summary:

r86001, now with less scariness :P  I took out the delete action and did purge 
instead, which is a much more self-contained action-with-a-form.  Also 
implement a few changes suggested by Brion on IRC last night.

Comment:

"Incomplete", maybe, but not inconsistent.  The point of not accessing the 
globals (apart from encouraging our drive away from globals full stop) is so 
that you can capture the output of the action and discard it if you want.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86041]: Revision status changed

[MediaWiki Mail]

User "Happy-melon" changed the status of MediaWiki.r86041.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c0
Commit summary:

r86001, now with less scariness :P  I took out the delete action and did purge 
instead, which is a much more self-contained action-with-a-form.  Also 
implement a few changes suggested by Brion on IRC last night.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

[MediaWiki Mail]

User "Helder.wiki" posted a comment on MediaWiki.r86047.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c15951
Commit summary:

History: Adding JS that converts  buttons to links for better UX. Patch based 
on one by Matthew Flaschen. Fixes Bug 16165

Comment:

FYI: See also the version at [[Snippets/Compare link]]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86042]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r86042.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86042#c0
Commit summary:

Move $rxTc initialization next to where it is used

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86049]: New comment added

[MediaWiki Mail]

User "Raymond" posted a comment on MediaWiki.r86049.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86049#c15952
Commit summary:

Kill comment box autofocus, bug 28533 Cursor jumps into comment field


Remove unused global

Comment:

Could someone pls deploy this asap? Thanks!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86049]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86049.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86049#c0
Commit summary:

Kill comment box autofocus, bug 28533 Cursor jumps into comment field


Remove unused global

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added

[MediaWiki Mail]

User "Aaron Schulz" posted a comment on MediaWiki.r86041.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c15953
Commit summary:

r86001, now with less scariness :P  I took out the delete action and did purge 
instead, which is a much more self-contained action-with-a-form.  Also 
implement a few changes suggested by Brion on IRC last night.

Comment:

I'd agree about separating UI from action logic here. I ended up doing that for 
FlaggedRevs actions a good while ago so that the GUI and API could share the 
logic.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

[MediaWiki Mail]

User "DieBuche" posted a comment on MediaWiki.r86047.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c15954
Commit summary:

History: Adding JS that converts  buttons to links for better UX. Patch based 
on one by Matthew Flaschen. Fixes Bug 16165

Comment:

Nice! It's much more concise. It doesn't support the HTML diff button though

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Gantt extension for MediaWiki

[Maciej Jaros]

Roan Kattouw (2011-04-14 13:30):
> 2011/4/14 Maciej Jaros:
>> BTW are there any guidelines (or at least good examples) of i18n in JS?
>> What I mean is - I need to use some (most) localized strings in JS and
>> would like to use existing code (if possible) for pushing strings from
>> PHP to JS
> [snip]
>> Oh, both extensions where written for 1.16, but I'm mostly using JS
>> anyway so this probably shouldn't matter.
> Use ResourceLoader, which handles i18n for you. ResourceLoader is new
> in 1.17 though, so code written with ResourceLoader will not work with
> 1.16 unless you go out of your way to make it dual-compatible.
>
> See 
> https://secure.wikimedia.org/wikipedia/mediawiki/wiki/ResourceLoader/Documentation/Using_with_extensions

Sadly not an option for me. It must work on 1.16 as I cannot upgrade 
office wiki to 1.17 (some extensions like e.g. WYSWIG don't work there). 
Is there some more or less standard way to do it for 1.16?

BTW [[mw:Localisation]] is missing that info.

Regards,
Nux.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gantt extension for MediaWiki

[Maciej Jaros]

Roan Kattouw (2011-04-14 13:30):
> 2011/4/14 Maciej Jaros:
>> BTW are there any guidelines (or at least good examples) of i18n in JS?
>> What I mean is - I need to use some (most) localized strings in JS and
>> would like to use existing code (if possible) for pushing strings from
>> PHP to JS
> [snip]
>> Oh, both extensions where written for 1.16, but I'm mostly using JS
>> anyway so this probably shouldn't matter.
> Use ResourceLoader, which handles i18n for you. ResourceLoader is new
> in 1.17 though, so code written with ResourceLoader will not work with
> 1.16 unless you go out of your way to make it dual-compatible.
>
> See 
> https://secure.wikimedia.org/wikipedia/mediawiki/wiki/ResourceLoader/Documentation/Using_with_extensions

Sadly not an option for me. It must work on 1.16 as I cannot upgrade 
office wiki to 1.17 (some extensions like e.g. WYSWIG don't work there). 
Is there some more or less standard way to do it for 1.16?

BTW [[mw:Localisation]] is missing that info.

Regards,
Nux.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added

[MediaWiki Mail]

User "IAlex" posted a comment on MediaWiki.r86041.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86041#c15955
Commit summary:

r86001, now with less scariness :P  I took out the delete action and did purge 
instead, which is a much more self-contained action-with-a-form.  Also 
implement a few changes suggested by Brion on IRC last night.

Comment:

A possiblity is also to run this internally (as the parser does when including 
special pages), in which case you need to have the correct context.

Also, for the ActionModifyFormFields and the ActionBeforeFormDisplay hook, 
wouldn't it be better to the pass the Action object itself and add an accessor 
for the Article object instead of passing only its name and the Article object?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85894]: Revision status changed

[MediaWiki Mail]

User "DieBuche" changed the status of MediaWiki.r85894.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85894#c0
Commit summary:

updating release notes, follow up to r85847 and r83212

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85898]: Revision status changed

[MediaWiki Mail]

User "DieBuche" changed the status of MediaWiki.r85898.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85898#c0
Commit summary:

less redundant wording, follow up to r85894

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86052]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r86052.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86052#c15956
Commit summary:

Polish off all special-page-by-global-function instances in extensions.  The 
preferred syntax is now exclusively $wgSpecialPages['PageName'] = 
'ClassExtendingSpecialPage', where that class has a constructor which calls 
SpecialPage::__construct('PageName').

Comment:

No, where it calls parent::__construct() :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86052]: New comment added

[MediaWiki Mail]

User "Happy-melon" posted a comment on MediaWiki.r86052.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86052#c15957
Commit summary:

Polish off all special-page-by-global-function instances in extensions.  The 
preferred syntax is now exclusively $wgSpecialPages['PageName'] = 
'ClassExtendingSpecialPage', where that class has a constructor which calls 
SpecialPage::__construct('PageName').

Comment:

Given that I just slapped a wfDeprecated() on the B/C for old constructors, yes 
indeed :D

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85881]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r85881.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85881#c0
Commit summary:

Made install.php fail gracefully on PHP4

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84619]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84619.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84619#c0
Commit summary:

Follow-up r84610: removed fr_fileSHA1Keys and use core file version tracking 
instead. Handles query spam FIXME in code.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86045]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r86045.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86045#c0
Commit summary:

Fix description in maintenance script

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86051]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r86051.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86051#c0
Commit summary:

MFT r86049

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85378]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r85378.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85378#c0
Commit summary:

Partial merge of r83017

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81699]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81699.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81699#c0
Commit summary:

1.17wmf1: Merge r80908 from 1.16wmf4 to prevent SVN from deleting all these 
files

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81695]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81695.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81695#c0
Commit summary:

Back out trunk r70657. It's broken without the $wgAdaptiveMessageCache-related 
followups, which were reverted.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81701]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81701.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81701#c0
Commit summary:

1.17wmf1: Remove broken 1.17 version check from Gadgets extension

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81702]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81702.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81702#c0
Commit summary:

1.17wmf1: Alias file for Nuke

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81706]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81706.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81706#c0
Commit summary:

Fixes for r71961

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81708]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81708.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81708#c0
Commit summary:

1.17wmf1: MFT r81707

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81725]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81725.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81725#c0
Commit summary:

1.17wmf1: Fix bug in mergeMessageFileList.php causing $IP not to be set because 
the parent constructor wasn't called

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81726]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81726.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81726#c0
Commit summary:

Merge r81725 from 1.17wmf1: add parent constructor call so $IP is set properly

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81724]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81724.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81724#c0
Commit summary:

1.17wmf1: Use mediaWiki.loader.load() instead of importScriptURI() in 
FundraiserPortal

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81727]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81727.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81727#c0
Commit summary:

Merge r81724 from 1.17wmf1: use mediaWiki.loader.load() to load JS instead of 
importScriptURI()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81733]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81733.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81733#c0
Commit summary:

1.17wmf1: Fix JS/CSS loading in ReaderFeedback, was totally broken

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81712]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81712.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81712#c0
Commit summary:

1.17wmf1: Fix ReaderFeedback, which was adding a 

[MediaWiki-CodeReview] [MediaWiki r81748]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81748.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81748#c0
Commit summary:

1.17wmf1: Hack old LQT to hopefully work with new WikiEditor. At least this 
won't throw fatals any more

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added, and revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r86047.

Old Status: new
New Status: fixme

User "Krinkle" also posted a comment on MediaWiki.r86047.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c15958
Commit summary:

History: Adding JS that converts  buttons to links for better UX. Patch based 
on one by Matthew Flaschen. Fixes Bug 16165

Comment:

Please don't create new global legacy variables, or anything new in legacy 
files for that matter.

Neither fixCompare, compareLink or updateCompare is globally 
(window.) needed. They are not referenced outside of their current 
scope (ie. another file)

Instead define them '''locally''' (var) in 
mediawiki.action.history.js

var updateCompare = function(){
};
var compareLink = {};
var fixCompare = funciton(){
  compareLink.
};
..
fixCompare();


or, if needed outside this scope:

var compareLink = {};
mw.history = {};
mw.history.updateCompare = function(){
};
mw.history.fixCompare = funciton(){
  compareLink.
};
..
mw.history.fixCompare();


The only globals that should be created/used in core are mw 
(mediaWiki) and jQuery. Everything else is either 
part of those objects or local, or aliased.

mediawiki.action.history.js already has an alias from jQuery to $, so 
$ can be used safely here.

Also, there's no need for an additional anonymous function for the call, and 
the fullname global 'mediaWiki' (alias mw is globally available).


+   mediaWiki.loader.using('jquery.ui.button', function() {
+   window.fixCompare();
+   });

Functions are objects and are always passed by reference, the following is more 
effecient

+   mw.loader.using('jquery.ui.button', window.fixCompare );


This is creating an additional http request for all history pages though, 
should be added as a dependancy on the server side instead.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r86047.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c15959
Commit summary:

History: Adding JS that converts  buttons to links for better UX. Patch based 
on one by Matthew Flaschen. Fixes Bug 16165

Comment:

I see the latter has been addressed in r86050 already.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81786]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81786.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81786#c0
Commit summary:

1.17wmf1: Fix undeclared global causing message cache bugs. Seen by vvv

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

[MediaWiki Mail]

User "DieBuche" posted a comment on MediaWiki.r86047.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c15960
Commit summary:

History: Adding JS that converts  buttons to links for better UX. Patch based 
on one by Matthew Flaschen. Fixes Bug 16165

Comment:

Yep, I realized his as well. I'm reqriting it and moving it to action.history.js

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r82534]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r82534.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82534#c0
Commit summary:

Followup r82533: fix botched merge

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r82533]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r82533.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82533#c0
Commit summary:

1.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456, 
r82457, r82458, r82460, r82465, r82474, r82478, r82482, r82486, r82513, r82518, 
r82530

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r86047.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c15961
Commit summary:

History: Adding JS that converts  buttons to links for better UX. Patch based 
on one by Matthew Flaschen. Fixes Bug 16165

Comment:

Something else real quick, be careful not to reference deprecated functionality.

* wgScript is a deprecated global as of 1.17, use mw.config instead ([[RL/JD]]) 
* Take the time to read the [[Manual:Coding conventions]] for core php and 
javascript. There's some minor whitespace issues. 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83003]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83003.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83003#c0
Commit summary:

Combined SQL patch file for the second round of schema changes.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83274]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83274.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83274#c0
Commit summary:

Commit live hack that seems to fix LQT namespaces on svwikisource and others

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83313]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83313.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83313#c0
Commit summary:

1.17wmf1: Live-hack WikimediaMobile to put the mobile redirect script back in 
the 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83214]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83214.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83214#c0
Commit summary:

MFT r83212 (excluded update of RELEASE NOTES).

Localisation updates from http://translatewiki.net.
* Adding support for Liv language with fallback to Estonian.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84095]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84095.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84095#c0
Commit summary:

Narayam: Fix typo in variable name

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r86047.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c15962
Commit summary:

History: Adding JS that converts  buttons to links for better UX. Patch based 
on one by Matthew Flaschen. Fixes Bug 16165

Comment:

HTMLDiff was killed, you can remove anything relating to that.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86013]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r86013.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86013#c15963
Commit summary:

Move  and  to its own line (unless it's an empty cell)
Fixes the other r86004 test case and r86010 one.

Comment:

Mismatched tags: Cell

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Merging content from multiple wikis

[Dmitriy Sintsov]

On 23.03.2011 17:46, Tod wrote:
> This is a fork of this thread:
> http://www.gossamer-threads.com/lists/wiki/wikitech/228949?page=last
>
>
> Is there a possibility that I could instead (easily) merge the handful
> of individual wiki's content into one consolidated wiki and implement a
> more enhanced search against it instead? I've no experience performing a
> merge like this so expert advice would be appreciated!
>
>
> Thanks - Tod
>
>
If you are still monitoring the list, I probably would try to merge xml 
dumps (only --current should be enough for search), then I'd import 
merged dump into "common" wiki. Should not be too hard, if not 
performance issues for very large wikis. If your wikis aren't very 
large, that is possible. However, that is offline slow process and 
adding of new pages has to be performed with slow re-merge. One may use 
remote api calls at individual wikis to duplicate-write every saved 
"individual" article into the "common" wiki, however an extension has do 
be developed for that. This way is much faster and keeps in sync.
Dmitriy

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added

[MediaWiki Mail]

User "DieBuche" posted a comment on MediaWiki.r86047.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c15964
Commit summary:

History: Adding JS that converts  buttons to links for better UX. Patch based 
on one by Matthew Flaschen. Fixes Bug 16165

Comment:

All done in r86056

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Status of 1.17 & 1.18

[Mark A. Hershberger]

Bryan Tong Minh  writes:

> I'm wondering what the status for 1.17 is. How far are we from RC? Is
> there any more review left?

Initially, Chad was going to be the release manager for 1.17, but other
issues meant that he isn't going to have time to manage it right now.

I think the current plan is to have Tim make the 1.17 release.  I don't
think any merges are left at this time besides, maybe, the recent XSS
fix.

Still, since Tim is is the release manager, he should have more
definitive answers.

> Related to this, as our review burden for 1.17 lessens, we should
> start to think about 1.18: re-recruit reviewers again, start thinking
> about when to branch 1.18, etc. Are there any plans related to that?

Nothing formal yet, but all of us are very aware of the need to make
code review happen in a timely manner.  I'll be watching CRStats
(http://toolserver.org/~robla/crstats/crstats.html) closely and
encouraging developers to help in code review.

I think branching 1.18 immediately after the 1.17 release (or now, for
that matter) will help us manage code review better.  If we have people
testing the 1.18 branch and updating regularly (similar to what Ubuntu
does for their development) and we set a date (July 15th?) when we know
we have to have a release prepared, then that will help Code Review all
the more.

But after a bit of discussion on IRC, I think we should try to get
Tim's, Brion's and anyone else's opinion on what they think about the
release schedule and code review.

Mark

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] RFC: Change of RELEASE-NOTES location for trunk

[Platonides]

MediaWiki is currently developed in two branches, with everything going
to trunk, and a slower number of revisions getting also copied to the
stable branch.
That's also the way we want to continue working, having a trunk and a
stable branch.

Currently we store the release notes in a file called RELEASE-NOTES in
the phase3 root of each branch. This is a problem when adding a revision
for backport, since the release notes are not suitable to be added to
the trunk RELEASE-NOTES (they would go inside HISTORY)
but it needs to be added to REL1_X RELEASE-NOTES.
So we end up with release notes added in a different commit, or
revisions with merge conflicts for merging. Which is inconvenient.

Thus, I propose that, from the point we branch 1.18, we keep the stable
branch release notes in trunk, and add trunk release notes in a
different file. trunk and branch RELEASE-NOTES would effectively be the
same file (a revision modifing RELEASE-NOTES and not tagged for backport
would be a bug). This simple change would give us much cleaner merges.

When tagging a new branch, the trunk RELEASE-NOTES would move to
HISTORY, the trunk release notes file to RELEASE-NOTES and a new one
would be created for trunk.


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Merging content from multiple wikis

[Platonides]

Dmitriy Sintsov wrote:
> If you are still monitoring the list, I probably would try to merge xml 
> dumps (only --current should be enough for search), then I'd import 
> merged dump into "common" wiki. Should not be too hard, if not 
> performance issues for very large wikis. If your wikis aren't very 
> large, that is possible. However, that is offline slow process and 
> adding of new pages has to be performed with slow re-merge. One may use 
> remote api calls at individual wikis to duplicate-write every saved 
> "individual" article into the "common" wiki, however an extension has do 
> be developed for that. This way is much faster and keeps in sync.
> Dmitriy

There's also the transwiki feature.



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r86059]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r86059.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86059#c15965
Commit summary:

CodeReview.tooltips: use built-in functions

Comment:

Marking scaptrap, as it needs r86054 in core to work correctly

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Status of 1.17 & 1.18

[Roan Kattouw]

2011/4/14 Mark A. Hershberger :
> I think branching 1.18 immediately after the 1.17 release (or now, for
> that matter) will help us manage code review better.  If we have people
> testing the 1.18 branch and updating regularly (similar to what Ubuntu
> does for their development) and we set a date (July 15th?) when we know
> we have to have a release prepared, then that will help Code Review all
> the more.
>
July?!?

I know 1.17 took a long time, but that was like a year's worth of
code. We should strike to keep the branch-to-release time as low as we
can, and it definitely needs to be WAY less than 3 months. It's been
like 4 months for 1.17, but 1.17 was quite exceptional, and more
frequent and quicker releases should become the rule.

My opinion is it would be best to branch 1.18 now-ish and revert
Happy-melon's Action changes (he wholeheartedly agreed that's 1.19
material).

Slightly off-topic:

Also, we should get our code review act together in a more sustainable
way. I've brought this up before, but it hasn't gotten a lot of
attention, probably due to the 1.17 craze. We have to have a serious
discussion about code review reform (to use a political-sounding
term); I think the tech staff meeting after the Berlin hackathon would
be a good venue for discussing the WMF side of this. The conference
itself is really supposed to be a hackathon this time, so I'm not sure
that having a protracted discussion there would be a very good idea;
that's basically what we did the whole time last year, and this year
is supposed to not be like that for a reason.

As always we do of course need to be careful to not want to solve this
"internally" between WMF staff, but have a public discussion with
everyone regardless of whether they happen to be paid.  However, my
impression is that this particular topic is one that mainly involves
staff and that it would be acceptable to hammer something out
internally and propose that on wikitech-l as something of a draft, in
this particular case. I'd be very interested to hear how unpaid
developers feel about that, as some of them have called out this
practice as undesirable back in September.

Roan Kattouw (Catrope)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] RFC: Change of RELEASE-NOTES location for trunk

[Roan Kattouw]

2011/4/14 Platonides :
> Thus, I propose that, from the point we branch 1.18, we keep the stable
> branch release notes in trunk, and add trunk release notes in a
> different file. trunk and branch RELEASE-NOTES would effectively be the
> same file (a revision modifing RELEASE-NOTES and not tagged for backport
> would be a bug). This simple change would give us much cleaner merges.
>
> When tagging a new branch, the trunk RELEASE-NOTES would move to
> HISTORY, the trunk release notes file to RELEASE-NOTES and a new one
> would be created for trunk.
>
Wouldn't it be cleaner to just name the files RELEASE-NOTES-1.18 and
so on? We can do the rename-and-move-stuff-to-HISTORY thing right
before we release.

Roan Kattouw (Catrope)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] New SVN committer

[Priyanka Dhanda]

Extension and Core:
* Patrick Reilly (preilly)

Patrick has joined the WMF engineering team as Sr. Software Developer 
for mobile.

-- 
Priyanka Dhanda
Code Maintenance Engineer
Wikimedia Foundation
http://wikimediafoundation.org
San Francisco, CA



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] New SVN committer

[Jay Ashworth]

- Original Message -
> From: "Priyanka Dhanda" 

> Extension and Core:
> * Patrick Reilly (preilly)
> 
> Patrick has joined the WMF engineering team as Sr. Software Developer
> for mobile.

Congrats to him.

I've got an Android phone, 6 years as a Wikipedian, and 25 years experience
writing good tickets, if he needs any help from the field.  :-)

Cheers,
-- jra

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Status of 1.17 & 1.18

[Roan Kattouw]

2011/4/14 Mark Hershberger :
> Sorry, I should have been clearer.  Yes, branch now(ish) and then aim for a
> 1.18 release on July 15th.  My idea is that setting a date for the release
> to be soon and early would provide the motivation to the people involved in
> code review to keep it up-to-date.
>
The point I was trying to make was that July is by no means "soon and
early" in my book. It's three months away, which is way to long.
Setting a date is nice, but if we can get a release out before the set
date, that's a good thing, and I think we can (and /should/) get 1.18
out way faster.

Roan Kattouw (Catrope)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] New SVN committer

[Delay]

It drives me crazy to see all those commit access request got handled and
I'm still waiting :-(

2011/4/14 Jay Ashworth 

> - Original Message -
> > From: "Priyanka Dhanda" 
>
> > Extension and Core:
> > * Patrick Reilly (preilly)
> >
> > Patrick has joined the WMF engineering team as Sr. Software Developer
> > for mobile.
>
> Congrats to him.
>
> I've got an Android phone, 6 years as a Wikipedian, and 25 years experience
> writing good tickets, if he needs any help from the field.  :-)
>
> Cheers,
> -- jra
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Registration open for the Hackathon in Berlin, May 13-15

[Daniel Kinzler]

Hi all!

Wikimedia Germany invites anyone interested in improving MediaWiki to come and
join us at or third developer meet-up. Like the last two years, it's going to be
awesome! Unlike the last two years, there will be more hacking and less talking
- it'll be a Hackathon, not a BarCamp.

We'll meet on May 13 to 15, in Berlin, on the 4th floor of the betahaus
coworking space .

There will not be an entrance fee, but registration is mandatory and now open:

.

Registration will close on April 10. If you like to attend, please register in
time!

More information can be found at

.

The Berlin Hackathon 2011 is an opportunity for MediaWiki hackers to come
together, squash bugs and write crazy new features. Our main focus this time
around will probably be:

* Improving usability / accessibility
* Interactive Maps
* Fixing the parser
* WMF Ops (new data center, virtualization)
* Supporting the Wiki Loves Monuments image hunt
* Squashing bugs

If you have different ideas, please let us know:



The Hackathon will be hosting the Language committee and Wiki loves Monuments
group. There is a limited number of seats reserved for these groups and if you
belong to one of them, you should receive an invitation code soon.

If you have any doubts or questions, contact us at .

We’re excited to see you in Berlin, your Hackathon Team

Daniel Kinzler (Program Coordinator)
Nicole Ebber (Logistics)
Cornelius Kibelka (Assistant)



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping IE6 support (was: MediaWiki security release 1.16.4)

[Trevor Parscal]

*For reading*, we aim to support any browser with 0.1%[1] use or more.

This has both culled things out, like IE 5.5, and surfaced things like NetFront 
(Sony Playstation Browser). 

*For security*, if it's possible to protect the site or our users, and we have 
money in the bank, we should be doing what it takes to protect them.

*For everything else*, we support various browsers based on a variety of 
factors:

* Whether the browser can ever support the feature at all
* Level of difficulty getting the feature to work in the browser
* Level of resources dedicated to the project

We normally knock out the most commonly-used and easy-to-get-working browsers 
first, and then sort out details on other browsers in order of use. There's no 
base percentage here, just hopes and dreams.

- Trevor

[1] http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm

On Apr 14, 2011, at 2:10 AM, Siebrand Mazeland wrote:

> On 14-04-11 10:02 Daniel Kinzler  wrote:
> 
> 
>> Wow, seriously? IE6 should be taken out the back and shot...
> 
> You're in luck. These days, even Microsoft agrees with you:
> 
> http://www.ie6countdown.com/
> 
> So when will we be able to drop IE6 support in MediaWiki completely? What
> metrics/thresholds can we use?
> 
> I would suggest to set a percentage of worldwide usage as reported by some
> "trusted" statistics reported, or possibly a percentage of Wikimedia
> pageviews. 3% or 4%?
> 
> Any thoughts?
> 
> Siebrand
> 
> 
> 
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r86064]: New comment added

[MediaWiki Mail]

User "Trevor Parscal" posted a comment on MediaWiki.r86064.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86064#c15966
Commit summary:

Fix for r85990, which broke lists inside tables; adding test for it

Comment:

Are you sure this is a follow up to r85990? It seems unrelated, did you get the 
revision number wrong?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86064]: New comment added

[MediaWiki Mail]

User "DieBuche" posted a comment on MediaWiki.r86064.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86064#c15967
Commit summary:

Fix for r85990, which broke lists inside tables; adding test for it

Comment:

Uh,sorry; I meant r85991

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86076]: New comment added, and revision status changed

[MediaWiki Mail]

User "Bawolff" changed the status of MediaWiki.r86076.

Old Status: new
New Status: ok

User "Bawolff" also posted a comment on MediaWiki.r86076.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86076#c15968
Commit summary:

Adding my USERINFO file.

Comment:

I took the liberty of linking your commit id to [[user:ShakataGaNai]].

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added

[MediaWiki Mail]

User "Leonsp" posted a comment on MediaWiki.r85885.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15969
Commit summary:

Fixes to DB2 support. DB2 support integration with 1.17 Installer and Updater. 
Developed by Andre, Tiago, Diego, and Cesar as described in wikitech-l message. 
Reviewed by me.

Comment:

Updated the message in r86079 to:

* "Your DB2 database has a default tablespace with insufficient pagesize. The 
pagesize has to be '''32K''' or greater."

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85784]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r85784.

Old Status: new
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85784#c0
Commit summary:

* (bug 27639) Transaction timeout when trying to OldLocalFile::upgradeRow()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86008]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r86008.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86008#c0
Commit summary:

Added better error checking for load responses.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83302]: Revision status changed

[MediaWiki Mail]

User "Bryan" changed the status of MediaWiki.r83302.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83302#c0
Commit summary:

(bug 27018) Added action=filerevert to revert files to an old version. Copied 
procedure from FileRevertForm, as most of the verification procedure is simple 
enough to not warrant the effort of writing a dedicated backend.

Further changes:
* Added Status::getErrorsByType() which returns the internal error array 
untouched
* Added ApiResult::convertStatusToArray() which converts a Status object to 
something useful for the Api

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview