[MediaWiki-CodeReview] [MediaWiki r87696]: Revision status changed
User DieBuche changed the status of MediaWiki.r87696. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87696#c0 Commit summary: Remove second argument in str.substr() in $.ucFirst, not needed, defaults to full length of string ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83936]: Revision status changed
User DieBuche changed the status of MediaWiki.r83936. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83936#c0 Commit summary: Follow-up r82310 CR: Adding comment about document ready (since it uses jQuery and interacts with DOM elements) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83203]: Revision status changed
User DieBuche changed the status of MediaWiki.r83203. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83203#c0 Commit summary: Adding isIp-tests to MW JS Test Suite (based on IPTest.php) * fixing a typo in variable statement (semicolon-comma, thx JSHint, browsers tend to ignore) * Clean up comments ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81660]: Revision status changed
User DieBuche changed the status of MediaWiki.r81660. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81660#c0 Commit summary: Renaming new jQuery.jsMessage plugin to jQuery.mesageBox(). Name was too generic and could be confusing with localization messages. . Next commit will deal with the contents of the messageBox .js/css files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81662]: Revision status changed
User DieBuche changed the status of MediaWiki.r81662. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81662#c0 Commit summary: Follow-up r81660. (Renaming new jQuery.jsMessage plugin to jQuery.mesageBox() ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81500]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r81500.
Old Status: new
New Status: ok
User DieBuche also posted a comment on MediaWiki.r81500.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81500#c16694
Commit summary:
Making a start with $.jsMessage. A more flexible way for messages. Supports
grouping them and making the replacing of previous messages into option (the
current jsMsg() function always replaces older messages. Time has shown that
there is need for the ability to show older messages as well and grouping to
avoid different scripts from erasing or clearing eachother's output (current
Commons and a few other wikis have created similar functions to enable keeping
previous messages)
* See also bug 26888. Not resolving the bug yet, this plugins needs a little
more testing and should then be called from within mw.util.jsMessage with some
wiki specific things.
Examples:
// Show a simple message in the default group
$.jsMessage( {
message: 'Hello',
target: 'mw-js-message'
} );
// Add a new message this time stating the defaults
$.jsMessage( {
message: 'World',
group: 'default',
replace: false,
target: 'mw-js-message'
} );
// Post a new message, replacing the previous ones
$.jsMessage( {
message: 'New',
group: 'default',
replace: true,
target: 'mw-js-message'
} );
// Add a messages in a new group (groups separated by a line)
$.jsMessage( {
message: 'A new group',
group: 'something',
target: 'mw-js-message'
} );
// Clear the default group
// See code comments for more info
$.jsMessage( {
message: '',
replace: true,
target: 'mw-js-message'
} );
// Clear the 'something'-group
// Since this leaves no visible groups, the main box will hide (slideUp) right
after
$.jsMessage( {
message: '',
group: 'something',
replace: true,
target: 'mw-js-message'
} );
If testing goes well, mw.util.jsMsg(message, className, replace) will call
$.jsMessage( { message: message, group: className, replace: replace, target:
$.jsMessage(ge' );
So it's more a backend plugin, not used directly by core modules.
But this way extensions or third party sites can easily re-use this plugin
and/or create multiple message boxes
on one page, by calling $.jsMessageNew and giving an id and location for it on
the page.
Comment:
IMO jsMessageNew could use a better name, but that's not worth a new rev.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80793]: Revision status changed
User DieBuche changed the status of MediaWiki.r80793. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80793#c0 Commit summary: 'skin' sometimes interferes with the global. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] WYSIWYG and parser plans (was What is wrong with Wikia's WYSIWYG?)
I've spent a lot of time profiling and optimising the parser in the
past. It's a complex process. You can't just look at one number for a
large amount of very complex text and conclude that you've found an
optimisation target.
unless it is {{cite}}
Cheers,
Domas
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87686]: New comment added
User JanPaul123 posted a comment on MediaWiki.r87686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87686#c16695 Commit summary: Reverted r87521 for now. Couldn't find any documentation that elastic textareas are available in jQuery UI. Comment: Right, but that's not the same as an elastic textarea. With jquery.ui.resizable you can only add a handle, you still have to drag-n-drop manually. It doesn't do auto-growing/shrinking as jquery.elastic does (a la Facebook comments). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87357]: New comment added, and revision status changed
User MaxSem changed the status of MediaWiki.r87357. Old Status: fixme New Status: new User MaxSem also posted a comment on MediaWiki.r87357. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87357#c16696 Commit summary: (bug 19408) user_properties.up_property: 32 bytes is not enough. Increased it to 255 bytes to be like page titles Some minor tweaks to modifyField() in the installer to make it more useful and added insertUpdateRow() Comment: Reverted in r87706. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87537]: New comment added
User Faure.thomas posted a comment on MediaWiki.r87537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87537#c16697 Commit summary: new Categorize extension Comment: Thanks ^demon for your details, I corrected my extension and submitted it in revision 87707. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87706]: New comment added
User Nikerabbit posted a comment on MediaWiki.r87706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87706#c16700 Commit summary: Revert SQLite-related part of r87357: sauses SLQ errors, not needed Comment: Sausages? Super leet query? We're you under the influence of alcohol when committing? :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87707]: New comment added
User Raymond posted a comment on MediaWiki.r87707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87707#c16701 Commit summary: Categorize: use wgAPIListModules for AJAX call, use wgAutoloadClasses to load files, separate hooks, Comment: Please fix English texts too. They contain French test like: 'categorize-taglabel'= 'Cateacute;gories populaires', Furthermore you use an editor with a wrong encoding: pre - 'author' = 'Thomas Faureacute;', + 'author' = 'Thomas Faur�', /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87707]: New comment added
User Faure.thomas posted a comment on MediaWiki.r87707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87707#c16702 Commit summary: Categorize: use wgAPIListModules for AJAX call, use wgAutoloadClasses to load files, separate hooks, Comment: right encoding is UTF-8, isn't it ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87707]: New comment added
User Raymond posted a comment on MediaWiki.r87707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87707#c16703 Commit summary: Categorize: use wgAPIListModules for AJAX call, use wgAutoloadClasses to load files, separate hooks, Comment: yes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87707]: New comment added
User Faure.thomas posted a comment on MediaWiki.r87707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87707#c16704 Commit summary: Categorize: use wgAPIListModules for AJAX call, use wgAutoloadClasses to load files, separate hooks, Comment: ok thanks, I will correct it, I was in ANSI... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] AJAX call avoiding CSS error
I'd like to make a call to a service on another server and present the results in a mediawiki page. Does the current release of MW (1.16.5 I think) have a built in proxy to support this ? Thanks - Tod ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Mediawiki Development IDE
Is there an IDE that the MW developer community has settled on and can recommend? tip-toeing softly away from the list Thanks - Tod ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] AJAX call avoiding CSS error
On Mon, May 9, 2011 at 3:05 PM, Tod listac...@gmail.com wrote: I'd like to make a call to a service on another server and present the results in a mediawiki page. Does the current release of MW (1.16.5 I think) have a built in proxy to support this ? No. Writing one should be trivial, but currently I don't believe such proxies exist. Bryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87706]: New comment added
User MaxSem posted a comment on MediaWiki.r87706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87706#c16705 Commit summary: Revert SQLite-related part of r87357: sauses SLQ errors, not needed Comment: a) Today is Russia's national holidaybr b) no ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87706]: New comment added
User Reedy posted a comment on MediaWiki.r87706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87706#c16706 Commit summary: Revert SQLite-related part of r87357: sauses SLQ errors, not needed Comment: In Soviet Russia, Holiday has you? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85707]: Revision status changed
User Catrope changed the status of MediaWiki.r85707. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85707#c0 Commit summary: Creating new extension for collecting and verifying email addresses. This code is nearly complete but totally untested. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85810]: Revision status changed
User Catrope changed the status of MediaWiki.r85810. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85810#c0 Commit summary: Fixed schema issues, syntax errors in the schema update code, made path to SQL file absolute (by adding a true at the end of the array) and got the form working for verifying an email address. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85811]: Revision status changed
User Catrope changed the status of MediaWiki.r85811. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85811#c0 Commit summary: (part 2 of 2 - see r85810) Fixed schema issues, syntax errors in the schema update code, made path to SQL file absolute (by adding a true at the end of the array) and got the form working for verifying an email address. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85815]: Revision status changed
User Catrope changed the status of MediaWiki.r85815. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85815#c0 Commit summary: Added from-name for outgoing emails. Fixed API syntax errors and use of affectedRows (was never tested before) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87714]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r87714. Old Status: new New Status: fixme User Siebrand also posted a comment on MediaWiki.r87714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87714#c16707 Commit summary: delete some unused translations and remove an empty loop in JS file. Comment: Please remove PHP4-ism ? at end of file (at least in trunk/extensions/Categorize/Categorize.i18n.php). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87522]: Revision status changed
User Catrope changed the status of MediaWiki.r87522. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87522#c0 Commit summary: Followup r87402, r87381, r87379 * Functionalized creation of array data store for highs/lows from database object for easy reuse * Now caching data object of highs/lows rather than full DB result object * Now relying on data store array generation in special page to generate data for cache population in maint script * Wrapped 'where' clauses for database abstraction layer in arrays * Switched to use += array_slice() when munging highest and lowest of the highs/lows rather than array_merge to prevent overwriting keys * Switched to using isset() rather in_array( blah, array_keys()) for simplicity's sake * No longer checking for availability of cache before attempting to populate it in maintenance script ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87714]: New comment added
User Faure.thomas posted a comment on MediaWiki.r87714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87714#c16708 Commit summary: delete some unused translations and remove an empty loop in JS file. Comment: done in revision 87720. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87310]: Revision status changed
User Catrope changed the status of MediaWiki.r87310. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87310#c0 Commit summary: Adding sql to create table for article feedback stats relating to high/low article ratings; Adding maintenance script to periodically populate high/low article feedback stats table ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87402]: Revision status changed
User Catrope changed the status of MediaWiki.r87402. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87402#c0 Commit summary: Added caching of latest highs/lows in high/low populating maintenance script; Added data-fetching logic for getDailyHighsAndLows() in special page (including cachability); Change how the title is generated in renderDailyHighsAndLows() to use page id ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87379]: Revision status changed
User Catrope changed the status of MediaWiki.r87379. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87379#c0 Commit summary: Follow up r87310; Adding index to timestamp files in article_feedback and article_feedback_stats_highs_lows tables; Now calculating rating averages in PHP rather than relying on MySQL in populateAFStatistics.php and removed associated cruft ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87381]: Revision status changed
User Catrope changed the status of MediaWiki.r87381. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87381#c0 Commit summary: Now actually determing only the top and bottom 50 rated pages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87720]: Revision status changed
User Siebrand changed the status of MediaWiki.r87720. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87720#c0 Commit summary: remove PHP4-ism ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87714]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r87714. Old Status: fixme New Status: ok User Siebrand also posted a comment on MediaWiki.r87714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87714#c16709 Commit summary: delete some unused translations and remove an empty loop in JS file. Comment: Thanks. If you make a follow-up revision, please use rX in your commit summary. That will automagically link that revision to the original revision. Now I have made the connection manually. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87719]: New comment added
User Awjrichards posted a comment on MediaWiki.r87719. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87719#c16710 Commit summary: ArticleFeedback: Fix for r87522: SpecialPageFactory doesn't exist in 1.17wmf1. Instead, call the function statically. Comment: Thanks for fixing this, Roan - what is the problem with having the logic in the special page class? I wanted to keep the logic in one place rather than have it in both the maint script as well as the special page. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki Development IDE
On Mon, May 9, 2011 at 9:08 AM, Tod listac...@gmail.com wrote: Is there an IDE that the MW developer community has settled on and can recommend? Depends on who you ask. Dmitriy pointed out vim and Eclipse. I personally use Netbeans when I want a full IDE, and I know a few other people who do as well. For quick one line edits? Vim. Gedit. Smultron. Depends on my mood :) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki Development IDE
On Mon, May 9, 2011 at 6:08 AM, Tod listac...@gmail.com wrote: Is there an IDE that the MW developer community has settled on and can recommend? There is no magic bullet. :) In the early days I mostly used fairly lightweight syntax-highlighting program editors (bbedit on Mac, jedit on Linux/Windows, joe or vim if stuck in a terminal) and a command line for grep version control, and that was Good Enough For Me. I mostly use Netbeans these days -- like Eclipse it's an open-source pluggable Java-based IDE mega-framework, but I've found it more stable and comfortable to use than Eclipse. Its PHP JavaScript mode does decent highlighting, it has standard integration with SVN and Git, and it handles project navigation, autocomplete etc including extracting type information from doc comment annotations. Most importantly, project-wide search and replace works and is speedy enough compared to mucking about with find and grep. Some folks around the office also use Eclipse. The downside of either of these is that they're huge apps -- they eat memory for breakfast, and if they're unstable can be very frustrating. The upside is that they tend to be very flexible, but much less intimidating than classic Unixy stuff like vim or emacs. Others are still very happy with a lighter-weight programming editor: something in the GUI flavors like TextMate or bbedit (Mac), Kate or gedit (Linux), or whatever the heck Windows people use. Some hardcore people use a terminal-based editor like vim or emacs by choice; the best of these are extremely powerful with syntax navigation features though they tend to have a higher learning curve. The most important things you probably want in a programming environment are: * project-wide search search-and-replace (you will kill yourself playing with 'grep' without this) * PHP JavaScript syntax highlighting (a must) * quick way to pop around to other files in the project by name/path (even if just from a command line) Some folks will care also about: * version control integration (all I ever use is a 'svn annotate' shortcut!) * debugger integration (if/when you can actually make it work, AWESOME) * autocompletion assistance (it's a help but if you can navigate around or look up help easily, it's not key) * integration with language library documentation (if you know your way around php.net, no biggie) -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Catrope posted a comment on MediaWiki.r87482. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87482#c16711 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: It's checking against QUERY_STRING, so the actual value fed is not codeload.php/code but something more like codedebug=falsemodules=jquery.ui.foo|jquery.ui.barskin=vector/code . But the general principle is the same: this contains dots, so it matches the regex and triggers 403s for IE clients. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87575]: Revision status changed
User Catrope changed the status of MediaWiki.r87575. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87575#c0 Commit summary: Added squid updateer upon rating, which purges the API call made by the ArticleFeedback frontend to get ratings for a page. I'm pretty sure this is right, but I have not tested it on a squid yet. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87730]: New comment added, and revision status changed
User Awjrichards changed the status of MediaWiki.r87730. Old Status: new New Status: fixme User Awjrichards also posted a comment on MediaWiki.r87730. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87730#c16713 Commit summary: Added maxage=0 and smaxage= to the ApiQueryArticleFeedback call and cache purge. Comment: +$wgArticleFeedbackSMaxage = 2592; Should be: $wgArticleFeedbackSMaxage = 2592000; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87730]: Revision status changed
User Catrope changed the status of MediaWiki.r87730. Old Status: fixme New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87730#c0 Commit summary: Added maxage=0 and smaxage= to the ApiQueryArticleFeedback call and cache purge. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87735]: Revision status changed
User Catrope changed the status of MediaWiki.r87735. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87735#c0 Commit summary: Smaxage should be 0 when userrating=1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87686]: New comment added
User Kaldari posted a comment on MediaWiki.r87686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87686#c16714 Commit summary: Reverted r87521 for now. Couldn't find any documentation that elastic textareas are available in jQuery UI. Comment: Ah, I didn't realize that. Carry on then :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87734]: New comment added
User Nikerabbit posted a comment on MediaWiki.r87734. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87734#c16715 Commit summary: Added messaging for above/below high/low tables Comment: addWikiText ( wfMsg() ) - addWikiMsg() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87468]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87468. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87468. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87468#c16716 Commit summary: Move CleanUpTest, fixes in next commit Comment: This has broken UtfNormal's test suite: pre brion@stormcloud:~/pages/trunk/includes/normal$ make test php Utf8Test.php 1 Some correct UTF-8 text| 2 Boundary condition test cases | 3 Malformed sequences| 4 Overlong sequences | 5 Illegal code positions | UTF-8 DECODER TEST SUCCESS! make: *** No rule to make target `CleanUpTest.php', needed by `testclean'. Stop. /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85944]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r85944. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85944#c16717 Commit summary: Related to bug 28470 (Doxygen not updating) Move require_once( MWInit::compiledPath( 'includes/normal/UtfNormalDefines.php' ) ); to Setup.php Might want relocating in Setup.php though Comment: Note that r87748 restores the original version of the require_once line (without the MWInit::compiledPath call added in r85327 which caused it to simply break 100% on the generator, test, and benchmark code which does not depend on the rest of MediaWiki). This doesn't seem to have any problems with regular MediaWiki -- as the file is already now included from Setup.php -- but it might have some effect on HipHop builds, untested. Please double-check affected features. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85327]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r85327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c16718 Commit summary: The beginnings of HipHop compiled mode support. It works now for parser cache hits. * Work around HipHop issue 314 (volatile broken) and issue 308 (no compilation detection) by adding some large and ugly compilation detection code to WebStart.php and doMaintenance.php. * Provide an MW_COMPILED constant which can be used to detect compiled mode throughout the codebase. * Introduced wfIsHipHop(), which detects either compiled or interpreted mode. Used this to work around unusual eval() return value in eval.php. * Work around lack of ini_get() in Maintenance.php, by duplicating wfIsHipHop(). * In Maintenance::shouldExecute(), accept include as an inclusion function name, since all kinds of inclusion give this string in HipHop. * Introduced new class MWInit, which provides some static functions in the pre-autoloader environment. * Introduced MWInit::compiledPath(), which provides a relative path for invoking a compiled file, and MWInit::interpretedPath(), which provides an absolute path for interpreting a PHP file. Used these new functions in the appropriate places. * When we are running compiled code, don't include files which would generate duplicate class, function or constant definitions. Documented the new requirements on the contents of Defines.php and UtfNormalDefines.php. * In HipHop compiled mode, it's not possible to have executable code in the same file as a class definition. ** Moved MimeMagic initialisation to the constructor. ** Moved Namespace.php global variable initialisation to Setup.php. ** Moved MemcachedSessions.php initialisation to the caller in GlobalFunctions.php. ** Moved Sanitizer.php constants and global variables to static class members. Introduced an accessor function for the attribs regex, as a new place to put code formerly at file level. ** Moved Language.php initialisation of $wgLanguageNames to Language::getLanguageNames(). Removed the global variable, marked private since forever. * In two places: don't use error_log() with type=3 to append to a file, HipHop doesn't support it. Use file_put_contents() with FILE_APPEND instead. * Work around the terrible breakage of class_exists() by using MWInit::classExists() instead in various places. In WebInstaller::getPageByName(), the class_exists() was marked with a fixme comment already, so I replaced it with an autoloader solution. Comment: Note that r87748 restores the original version of the require_once line in UtfNormalUtil.php (without the MWInit::compiledPath call added here which caused it to simply break 100% on the generator, test, and benchmark code which does not depend on the rest of MediaWiki) -- the line had been moved to Setup.php in r85944 which still left all the UtfNormal scripts broken (bug 28864). This doesn't seem to have any problems with regular MediaWiki -- as the file is already now included from Setup.php -- but it might have some effect on the HipHop builds, untested. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87340]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r87340. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r87340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87340#c16719 Commit summary: Moved printfooter and debug HTML away from bodytext so that they can be easily modified by extensions with the SkinTemplateOutputPageBeforeExec hook; always moved generation of debug HTML just before executing the hook so that it includes more items Comment: printfooter in SkinLegacy.php is escaped in single quotes. Causes slashes to end up in the actual HTML: pre div class=\printfooter\Retrieved from a href=http: /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87340]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r87340. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r87340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87340#c16720 Commit summary: Moved printfooter and debug HTML away from bodytext so that they can be easily modified by extensions with the SkinTemplateOutputPageBeforeExec hook; always moved generation of debug HTML just before executing the hook so that it includes more items Comment: Fixed in r87749. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83309]: New comment added
User Krinkle posted a comment on MediaWiki.r83309. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83309#c16721 Commit summary: Fix bug in makeCollapsible. * The instantHide implementation (added in r82471) didn't cover the case where a table is collapsed by default, it needs to pass the toggle to the function so that the row it is in can be excluded. * The bug was found by user Helder.wiki, also reproducable on the demonstration page (I guess it was cached for everyone, since nobody noticed?) * Demonstration page has been refreshed and all tests are passed now. Comment: Thanks, I've done a better implementation in r87743. After the initial check $defaultToggle will be set to null or left as a valid jQuery instance. After that a simple if() statement will be sufficient. Thanks, prolly faster now too. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87745]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87745. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87745#c0 Commit summary: prevent animation buildup, use stop() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87747]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87747. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87747#c16722 Commit summary: error recovery on filename errors Comment: recoverFromError seems to be finding matching fields labels by finding a match on the 'name' attribute and the label's 'for' attribute; however a label's 'for' is matched up with the target element's 'id' not 'name'. Should be harmless as they match in these cases, but id is safer to use for matching. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] AJAX call avoiding CSS error
On 05/09/2011 12:25 PM, Krinkle wrote: Op 9 mei 2011, om 15:05 heeft Tod het volgende geschreven: I'd like to make a call to a service on another server and present the results in a mediawiki page. Does the current release of MW (1.16.5 I think) have a built in proxy to support this ? Thanks - Tod Using a serverside proxy should be a matter of last resort. There are many ways to make a cross-domain request without violating any browser origin policies. Do you have control of the other server ? Have you heard of JSONP / (eg. JSON objects with a callback) ? I have, but what about services that don't support it? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r86692]: New comment added
User Nikola Smolenski posted a comment on MediaWiki.r86692. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86692#c16723 Commit summary: CSS, per http://www.mediawiki.org/wiki/Extension:Interlanguage/WMF_Design_Pass Comment: Fixed in r87753. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86692]: New comment added
User Nikola Smolenski posted a comment on MediaWiki.r86692. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86692#c16724 Commit summary: CSS, per http://www.mediawiki.org/wiki/Extension:Interlanguage/WMF_Design_Pass Comment: Fixed in r87753. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82778]: New comment added
User Nikola Smolenski posted a comment on MediaWiki.r82778. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82778#c16725 Commit summary: Fix outstanding issues Comment: Done in r87753. Also removed caching. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87747]: New comment added
User NeilK posted a comment on MediaWiki.r87747. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87747#c16726 Commit summary: error recovery on filename errors Comment: fixed in r87760 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki Development IDE
Tod listac...@gmail.com writes: Is there an IDE that the MW developer community has settled on and can recommend? Since no one else has said it: emacs is my choice. I typically use flymake (http://www.emacswiki.org/emacs/FlyMake) while editing to catch obvious syntax errors. I've configured emacs so that MW coding conventions are followed: http://www.mediawiki.org/wiki/Manual:Coding_conventions#emacs_style Oh, and it works with mediawiki-mode, which I maintain. So I can edit code and edit wikis via the API using the same editor. Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87722. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16727 Commit summary: do not create console logging div unless configured to do so Comment: mw.log.makeConsole never seems to be set anywhere; is this something that's meant to be activated via debug console or user JS? If so it probably needs to be documented. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87724]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87724. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87724. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87724#c16728 Commit summary: fix spinner, previous version did not spin properly Comment: (previous version was not set to repeat -- spun once then stopped) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added
User Krinkle posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16729 Commit summary: do not create console logging div unless configured to do so Comment: Should probably use the core codemw.'''l'''og/code rather than this copy named codemw.'''L'''og/code. Was created because at the time mw.log wasn't in core IIRC. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki Development IDE
On Mon, May 9, 2011 at 12:31 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Since no one else has said it: emacs is my choice. I typically use flymake (http://www.emacswiki.org/emacs/FlyMake) while editing to catch obvious syntax errors. I've configured emacs so that MW coding conventions are followed: http://www.mediawiki.org/wiki/Manual:Coding_conventions#emacs_style Oh, and it works with mediawiki-mode, which I maintain. So I can edit code and edit wikis via the API using the same editor. Props, sir. Mad props. :) -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added
User Krinkle posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16730 Commit summary: do not create console logging div unless configured to do so Comment: I'd go bonkers and fix all doubling between UpWiz modules and core modules, however I'm not sure which compatibility rule is set and when. It's been deployed to 1.17wmf1 last week. Is it acceptable to require 1.18 now and perform any fixes in the wmf-branch directly ? Would probably make testing easier as well (wouldn't be the first time we referring to a method in the mw.-object that exists in trunk but not on the cluster). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87592]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87592. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87592#c0 Commit summary: this comment is cryptic and I have not idea what I meant by it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added
User NeilK posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16731 Commit summary: do not create console logging div unless configured to do so Comment: usually there are real reasons not to reconcile the libraries, or IMO the UW version is superior ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87751]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87751. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87751#c0 Commit summary: correct message string ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added
User NeilK posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16732 Commit summary: do not create console logging div unless configured to do so Comment: of course I want to fix all doubling. Also I've committed myself to talking about some of these libraries at Wikimania, precisely to force that :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87760]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87760. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87760#c0 Commit summary: followup to r87747 - look for labels for id, not name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added
User NeilK posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16733 Commit summary: do not create console logging div unless configured to do so Comment: correct, I am just making sure it doesn't get triggered. it causes super ugly divs to get created in IE otherwise the obvious thing could be to obtain some kind of log option from config, but, where do we get that? it's a big mess right now between mw.log and mw.Log :( ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87725]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87725. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87725. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87725#c16734 Commit summary: precheck commons blacklist (in a hacky way, sans API) Comment: The hardcoded regex sets definitely will need to be replaced with using an API call, but it looks functional for now. Adding todo tag. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16735 Commit summary: obtain URL from page title of alternate upload form Comment: Doesn't check for errors; mw.Title() constructor appears to throw an exception on some invalid input -- and also on what appears to be perfectly valid input such as 'Commonsx:Upload' (throws unrecognized namespace prefix, which it should not -- that should just come through as the local page titled 'Commonsx:Upload'). If given invalid input, should probably fall back to the standard link or at least rethrow the error with specificity, so the console error log shows that it was a problem with the altUploadForm setting for UploadWizard extension. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16736 Commit summary: obtain URL from page title of alternate upload form Comment: Looks like mw.Title is UploadWizard-specific, not part of MediaWiki core. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87746]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87746. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87746. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87746#c16737 Commit summary: misc linting issues, removed recoverable errors upon details submission (in hopes they will not recur) Comment: This rev looks ok, but there are still some outstanding issues with the form error recovery (think it's one of the other commits though) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87765]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87765. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87765. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87765#c16738 Commit summary: make the regexes more like prefixes not full filenames Comment: This rejects legit-sounding titles like PAL scanline layout and PD license issues diagram ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87766]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87766. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87766. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87766#c16739 Commit summary: error count messages, file extension errors Comment: Looks ok. The nice little reminder down towards the submit button is handy! Ext reminder is cute -- some power users might be confused that there's no visible extension though (knowing there needs to be one later). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r87722. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16740 Commit summary: do not create console logging div unless configured to do so Comment: @TODO, removing Fixme ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87747]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87747. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87747. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87747#c16741 Commit summary: error recovery on filename errors Comment: There seems to still be _something_ awry with some cases of multiple submission ([[User:Brion VIBBER/Upwiz mystery 1]]), but per IRC it's still better than the previous case where there was no recovery. Marking OK. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added
User NeilK posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16742 Commit summary: do not create console logging div unless configured to do so Comment: Marking this as ok but only for now -- it's a required hack for prod to stop undesirable behaviour in IE ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87722. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16743 Commit summary: do not create console logging div unless configured to do so Comment: Marking as OK with a todo for now, as noted above the basic functionality is fine and this gets the extra consoles out of the way when not debugging in console-less IE. Proper fix is to merge with the newer mw.log, but it doesn't block deployment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87765]: Revision status changed
User NeilK changed the status of MediaWiki.r87765. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87765#c0 Commit summary: make the regexes more like prefixes not full filenames ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87767]: New comment added
User NeilK posted a comment on MediaWiki.r87767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87767#c16745 Commit summary: reverting r87765, brion is right, this excludes too many filenames Comment: marking ok since this just restored an earlier version marked ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87767]: New comment added
User NeilK posted a comment on MediaWiki.r87767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87767#c16746 Commit summary: reverting r87765, brion is right, this excludes too many filenames Comment: except, I can't actually do that. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87764]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87764. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87764#c16747 Commit summary: count the errors and show them next to the submit button (this helps when the errors are scrolled off page) Comment: fyi -- should be able to do this in one lookup like: $( '#mwe-upwiz-stepdiv-details' ).find( 'input.mwe-error, textarea.mwe-error, input.mwe-validator-error, textarea.mwe-validator-error' ).length However... if one field has both .mwe-error and .mwe-validator-error on it, then this will also avoid duplicating them, counting the field only once instead of twice. If it should be counted twice, then leave as is -- if they're mutually exclusive than it doesn't matter, use whichever is more convenient. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87767]: Revision status changed
User ^demon changed the status of MediaWiki.r87767. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87767#c0 Commit summary: reverting r87765, brion is right, this excludes too many filenames ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87768]: Revision status changed
User Catrope changed the status of MediaWiki.r87768. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87768#c0 Commit summary: Fixing query to select highs/lows from db prior to caching results to return them in the correct order for stats population ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16748 Commit summary: obtain URL from page title of alternate upload form Comment: Whether this is ok for now depends on whether initial configuration could include an interwiki link or faux-namespace local link for this setting; eg 'Commons:Upload' will fail on a site other than Wikimedia Commons, as there's no local 'Commons' namespace. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added
User NeilK posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16749 Commit summary: obtain URL from page title of alternate upload form Comment: excellent catch. most people wouldn't go looking for exceptions. :) fixed in r87772 (I tested impossible pages like Spockial:Upload...) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87764]: New comment added
User NeilK posted a comment on MediaWiki.r87764. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87764#c16750 Commit summary: count the errors and show them next to the submit button (this helps when the errors are scrolled off page) Comment: fixed in r87771 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87752]: Revision status changed
User NeilK changed the status of MediaWiki.r87752. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87752#c0 Commit summary: Minor adjustments in UploadWizard/mw.Utilities * Removing window.mediaWiki mw alias (already in core) * Removing typeof check in front of a strict comparison (it's strict comparison) * Modified a few comments and variable names ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87772]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87772. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87772#c0 Commit summary: followup to r87410 -- trap errors for mw.Title properly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87410. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16751 Commit summary: obtain URL from page title of alternate upload form Comment: Whee! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87771]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87771. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87771#c0 Commit summary: followup to r87764; use simpler jquery selector ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87764]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87764. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87764#c0 Commit summary: count the errors and show them next to the submit button (this helps when the errors are scrolled off page) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87497]: New comment added, and revision status changed
User Mdale changed the status of MediaWiki.r87497.
Old Status: new
New Status: fixme
User Mdale also posted a comment on MediaWiki.r87497.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87497#c16752
Commit summary:
Per bug 28738 comment 4, pack ResourceLoader URLs by encoding
foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux
* Expand these URLs in ResourceLoaderContext
* Build and emit these URLs in OutputPage::makeResourceLoaderLink() and in
mw.loader
* Throw an exception in ResourceLoader::register() for module names that
contain pipe characters or commas. Commas need to be forbidden for this packing
feature to work. Pipes were already forbidden but weren't checked for
Comment:
I think combination of buildModulesString and expandModuleNames is broken in
the case of un-prefixed modules names. For example if you have a module name
foo not mw.foo.
in requesting foo|bar|cat, '''buildModulesString''' will give you: foo,bar|cat
And '''expandModuleNames''' will expand into
source lang=phpArray
(
[0] = .oo
[1] = .bar
[2] = cat
)
/source
Giving you {.oo:missing , .bar:missing } ... This was a little tricky
to track down, since it missing module names don't throw an exception and fails
silently in a loader script. ( maybe we should throw an exception when in debug
mode for missing classes? )
If non-prefixed class names are not allowed, then an exception should be thrown
if your module name is not prefixed by mw, jquery or ext prefix.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87497]: New comment added
User Catrope posted a comment on MediaWiki.r87497. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87497#c16753 Commit summary: Per bug 28738 comment 4, pack ResourceLoader URLs by encoding foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux * Expand these URLs in ResourceLoaderContext * Build and emit these URLs in OutputPage::makeResourceLoaderLink() and in mw.loader * Throw an exception in ResourceLoader::register() for module names that contain pipe characters or commas. Commas need to be forbidden for this packing feature to work. Pipes were already forbidden but weren't checked for Comment: Hmm, I thought I had my bases covered for prefix-less modules, guess not. Will look at this tomorrow. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86577]: New comment added
User Mdale posted a comment on MediaWiki.r86577. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86577#c16754 Commit summary: Added generic bucketing feature to the user object, which handles bucketing users, invalidating bucketing on version changes, tracking and and persistence. Comment: Could we consider putting this User class stuff into a user class file? Maybe something like mediawiki.User for example? The core should ideally be as thin as possible no? This way stand alone usage of resource loading is possible without so much extra stuff. ( also see bug 26799 ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki Development IDE
Bryan Tong Minh bryan.tongm...@gmail.com wrote in message news:BANLkTinddq+HJgTE=4dwc5ofbvnht7p...@mail.gmail.com... On Mon, May 9, 2011 at 3:08 PM, Tod listac...@gmail.com wrote: Is there an IDE that the MW developer community has settled on and can recommend? Sam has a license for phpStorm, iirc, available for all MediaWiki developers. Bryan I use phpStorm (got the license key from Sam), which is pretty good. I probably use less than 1% of all its features, but the little things it adds (like being able to click on a function call, hit a key and get a popup of its documentation, or jump to its definition with another keypress) are useful little timesavers. I started with Eclipse, but as Brion says it gets *very* grumpy when trying to load large projects, and seems to have quite a few memory leaks. Ultimately, the codebase is sufficiently large and esoteric that few-to-no IDEs are able to fully discharge the task of integrating development, testing and deployment (I have yet to hear many success stories of debugging/breakpointing/etc, for instance, and you'll probably waste as much time (and hair) getting it working as you'd save by using it); so basically, go for whatever will do the things you want with the minimum of extraneous features which will probably just end up consuming time, memory and sanity... --HM ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87779]: New comment added
User Awjrichards posted a comment on MediaWiki.r87779.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87779#c16755
Commit summary:
Fixing logic of stats gathering maintenance script to account for rating sets
(the group of ratings generated when the user hits submit) rather than blindly
calculating based off of individual ratings
Comment:
Oops -
pre
+ if ( count( array_keys( $rating_set_count[ $page_id ]
)) 5 ) {
/pre
Should be checking for 10, not 5
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87779]: Revision status changed
User Awjrichards changed the status of MediaWiki.r87779. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87779#c0 Commit summary: Fixing logic of stats gathering maintenance script to account for rating sets (the group of ratings generated when the user hits submit) rather than blindly calculating based off of individual ratings ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87779]: New comment added
User Awjrichards posted a comment on MediaWiki.r87779. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87779#c16756 Commit summary: Fixing logic of stats gathering maintenance script to account for rating sets (the group of ratings generated when the user hits submit) rather than blindly calculating based off of individual ratings Comment: Fixed, r87796 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
