Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tue, 3 Jun 2014 at 22:13:43 +0800, David Maciejak wrote:
> This patch is adding a checkbox option in the expert panel
> to be able to disable the Alt-Tab window switching panel from the pref GUI.
>
> Please test, i experienced some weird things with the inotify stuff,
> sometime a wmaker hot restart is needed to force reload the conf.
>
> + { N_("Disable Alt-Tab window switching panel."),
> + /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
Perhaps "Do not display Alt-Tab panel icons" would be better?
Otherwise I have the impression that people could misunderstand what
this option does by thinking that we are disabling the switch panel
altogether.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tuesday, June 3, 2014, Carlos R. Mafra wrote:
> On Tue, 3 Jun 2014 at 22:13:43 +0800, David Maciejak wrote:
> > This patch is adding a checkbox option in the expert panel
> > to be able to disable the Alt-Tab window switching panel from the pref
> GUI.
> >
> > Please test, i experienced some weird things with the inotify stuff,
> > sometime a wmaker hot restart is needed to force reload the conf.
>
> >
> > + { N_("Disable Alt-Tab window switching panel."),
> > + /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
>
> Perhaps "Do not display Alt-Tab panel icons" would be better?
>
> Otherwise I have the impression that people could misunderstand what
> this option does by thinking that we are disabling the switch panel
> altogether.
>
>
>
That option is effectively disabling *all* the switch panel, not only the
icons.
In fact it can be used either to disable the panel or to set panel bg image.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On 06/03/2014 05:33 PM, Carlos R. Mafra wrote: Perhaps "Do not display Alt-Tab panel icons" would be better? Otherwise I have the impression that people could misunderstand what this option does by thinking that we are disabling the switch panel altogether. Why not "Switch windows without (showing) switch panel" then? Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoting message written on Tuesday 2014-06-03 22:43:22 by David Maciejak: > That option is effectively disabling *all* the switch panel, not only > the icons. > In fact it can be used either to disable the panel or to set panel bg > image. That's true but I agree with Carlos that the current description might be misleading to users, especially to those that lack the knowledge of Windowmaker's internal functions and their naming. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tuesday, June 3, 2014, Josip Deanovic wrote: > Quoting message written on Tuesday 2014-06-03 22:43:22 by David Maciejak: > > That option is effectively disabling *all* the switch panel, not only > > the icons. > > In fact it can be used either to disable the panel or to set panel bg > > image. > > That's true but I agree with Carlos that the current description might > be misleading to users, especially to those that lack the knowledge of > Windowmaker's internal functions and their naming. > > I see no problem to change the description, please everybody share your ideas !
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tue, 3 Jun 2014 at 22:43:22 +0800, David Maciejak wrote:
> On Tuesday, June 3, 2014, Carlos R. Mafra wrote:
>
> > On Tue, 3 Jun 2014 at 22:13:43 +0800, David Maciejak wrote:
> > > This patch is adding a checkbox option in the expert panel
> > > to be able to disable the Alt-Tab window switching panel from the pref
> > GUI.
> > >
> > > Please test, i experienced some weird things with the inotify stuff,
> > > sometime a wmaker hot restart is needed to force reload the conf.
> >
> > >
> > > + { N_("Disable Alt-Tab window switching panel."),
> > > + /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
> >
> > Perhaps "Do not display Alt-Tab panel icons" would be better?
> >
> > Otherwise I have the impression that people could misunderstand what
> > this option does by thinking that we are disabling the switch panel
> > altogether.
> >
> >
> >
> That option is effectively disabling *all* the switch panel, not only the
> icons.
> In fact it can be used either to disable the panel or to set panel bg image.
Yes, but the point is that we should try to emphasize that the option
disables just the display (no icons, no background image), and that
the Alt-Tab shortcut will still have the effect of switching windows.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoting message written on Tuesday 2014-06-03 22:57:15 by David Maciejak: > On Tuesday, June 3, 2014, Josip Deanovic wrote: > > That's true but I agree with Carlos that the current description might > > be misleading to users, especially to those that lack the knowledge of > > Windowmaker's internal functions and their naming. > > I see no problem to change the description, please everybody share your > ideas ! Maybe something like: "Do not show Alt-Tab window switching panel" or "Do not display Alt-Tab window switching panel" BTW, thank you for adding that option to WPrefs. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tue, 3 Jun 2014 at 17:04:14 +0200, Josip Deanovic wrote: > or "Do not display Alt-Tab window switching panel" If nobody complains, I will use this suggestion. > BTW, thank you for adding that option to WPrefs. Indeed. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoth Carlos R. Mafra, On Tue, 3 Jun 2014 at 17:04:14 +0200, Josip Deanovic wrote: or "Do not display Alt-Tab window switching panel" If nobody complains, I will use this suggestion. My immediate reaction when reading through this thread was that we call the act of changing window focus "cycling" in the code and WPrefs labels, and the thing which pops up and shows icons representing windows the "switchpanel", so we should try to use those terms. Closer inspection of the code reveals that there's inconsistency in various places between how we refer to the switchpanel. Most of the time we call it the "switchpanel" although we occasionally refer to it as the "switch panel" and even to the "SwitchPanel" once. Run "git grep -i '\bswitch[[:blank:]]*panel\b'" to see what I mean. So I propose that we: * Decide whether to call it the "switchpanel" or the "switch panel" (I vote the former since it's most prevalent. * Change the occurrences of whichever option we don't choose. * Use the text "Show switch( )panel when cycling windows" (defaulting to on) for the patch under discussion. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Good to see you back, Iain. On Wed, 4 Jun 2014 at 11:22:24 +0100, Iain Patterson wrote: > Quoth Carlos R. Mafra, > > >On Tue, 3 Jun 2014 at 17:04:14 +0200, Josip Deanovic wrote: > >>or "Do not display Alt-Tab window switching panel" > > > >If nobody complains, I will use this suggestion. > > My immediate reaction when reading through this thread was that we > call the act of changing window focus "cycling" in the code and > WPrefs labels, and the thing which pops up and shows icons > representing windows the "switchpanel", so we should try to use > those terms. Good point. > Closer inspection of the code reveals that there's inconsistency > in various places between how we refer to the switchpanel. Most of > the time we call it the "switchpanel" although we occasionally refer > to it as the "switch panel" and even to the "SwitchPanel" once. Run > "git grep -i '\bswitch[[:blank:]]*panel\b'" to see what I mean. > > So I propose that we: > > * Decide whether to call it the "switchpanel" or the "switch > panel" (I vote the former since it's most prevalent. I prefer 'switchpanel' too. > * Use the text "Show switch( )panel when cycling windows" > (defaulting to on) for the patch under discussion. That's a _much_ better description. David, can you redo the patch? -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoting message written on Wednesday 2014-06-04 11:58:25 Carlos R. Mafra: > > * Use the text "Show switch( )panel when cycling windows" > > > > (defaulting to on) for the patch under discussion. > > That's a _much_ better description. David, can you redo the patch? Yes, it's better compared to previous suggestions and ALT+TAB doesn't necessary have to be used for cycling windows. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On 06/04/2014 01:22 PM, Iain Patterson wrote: * Use the text "Show switch( )panel when cycling windows" (defaulting to on) for the patch under discussion. "Cycling" is not so good. Using switchpanel you may switch to any of windows at once. Let's keep the "switch" verb with the switchpanel. Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoth Yury Tarasievich, "Cycling" is not so good. Using switchpanel you may switch to any of windows at once. That is true. You can indeed switch to an arbitrary window with the mouse - once the switchpanel is open. It is opened in the first instance only as a side-effect of pressing the FocusNextKey shortcut. The shortcut's purpose is to cycle windows and this new preference controls whether or not the above side-effect is active, so I would argue that the term is appropriate. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Wed, 4 Jun 2014, Iain Patterson wrote: * Decide whether to call it the "switchpanel" or the "switch panel" (I vote the former since it's most prevalent. I agree with your suggestions mostly but "switchpanel" is not really an English word and to me looks like a typo so I wonder if one of the other options would be better even if that needs changing at more places. Regards, BALATON Zoltan -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Alt-Tab is "cycling" only in one specific scenario (holding the Alt). It's back-and-fro'ing between windows (Alt-Tab with complete release) and calls up the "switch panel" (Zoltan is right about that space there) Anyway, the distinction isn't worth an additional verb, somewhat too informal at that. Cycling? Bicycling? Recycling? Yury On 06/04/2014 03:17 PM, Iain Patterson wrote: The shortcut's purpose is to cycle windows and this new preference controls whether or not the above side-effect is active, so I would argue that the term is appropriate. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Enclosed the patch with lain text proposal ""Show switch panel when cycling windows."" and with logic changed, to amend commit c994b65f14ad2ab872f5c1b91119d78885743cfc. On Thu, Jun 5, 2014 at 1:41 AM, Yury Tarasievich wrote: > Alt-Tab is "cycling" only in one specific scenario (holding the Alt). > It's back-and-fro'ing between windows (Alt-Tab with complete release) and > calls up the "switch panel" (Zoltan is right about that space there) > > Anyway, the distinction isn't worth an additional verb, somewhat too > informal at that. > Cycling? Bicycling? Recycling? > > Yury > > > On 06/04/2014 03:17 PM, Iain Patterson wrote: >> >>The shortcut's purpose is to cycle windows >> and this new preference controls whether or not >> the above side-effect is active, so I would >> argue that the term is appropriate. > > > > -- > To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org. 0001-PATCH-WPrefs-add-expert-option-to-disable-switch-pan.patch Description: Binary data
Re: [PATCH] WPrefs: add expert option to disable switch panel
Oh well. Still this isn't cycling, we find cycling alt-tab in other platforms GUIs, all right? Yury On 06/05/2014 07:37 AM, David Maciejak wrote: Enclosed the patch with lain text proposal ""Show switch panel when cycling windows."" and with logic changed, to amend commit c994b65f14ad2ab872f5c1b91119d78885743cfc. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoth Yury Tarasievich, Oh well. Still this isn't cycling, we find cycling alt-tab in other platforms GUIs, all right? I'm not dead set on the word "cycling" I just want us to be consistent about what we do use. Having said that I do think that "cycling" is fine because if you keep pressing FocusNextKey you keep on iterating through the window list but if you want to call that "switching" instead then I won't object as long as you can convince everyone else that it's worth changing. If we do change it we'll probably need different text for the new preference because "Show switch panel when switching windows" is a bit weird. Just "Show panel..." maybe? Either way, since I raised the point I'm happy to go through and replace all occurrences of the old terminology once we've decided. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On 06/05/2014 09:19 AM, Iain Patterson wrote: Quoth Yury Tarasievich, Oh well. Still this isn't cycling, we find cycling alt-tab in other platforms GUIs, all right? I'm not dead set on the word "cycling" I just want us to be consistent about what we do use. Consistency is a big problem in OSS as a class, anyway. Having said that I do think that "cycling" is fine because if you keep pressing FocusNextKey you keep on iterating through the window list To repeat myself, if you do one-off alt-tab, do you get cycling? In fact, you get the opposite, or, at least, not cycling through the initial set. When you work with switch panel activated, you get additional visual element, which doesn't change the base logic of the action, but provides additional controls. This just doesn't boil down to "cycle", this is broader than just "cycle", but then again, having had worked on l10n for a while, I just might have a somewhat different perspective on this... BTW, I still remember this little change of logic of alt-tab behaviour was quite a source of confusion to me in days of transition from os2/win guis. These days, I rely on this feature. :) but if you want to call that "switching" instead then I won't object as long as you can convince everyone else that it's worth changing. Well, I won't put any additional effort into this worthy task. It's sort of people problem, not argument problem: changes on the scale of this are disproportionally hard to negotiate. If we do change it we'll probably need different text for the new preference because "Show switch panel when switching windows" is a bit weird. Just "Show panel..." maybe? There are lots of panels, which one do you have in mind? :) Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Thu, 5 Jun 2014 at 10:17:10 +0300, Yury Tarasievich wrote: > > To repeat myself, if you do one-off alt-tab, do you get cycling? In > fact, you get the opposite, or, at least, not cycling through the > initial set. I don't think we should change the word 'cycling' in this context. wmaker uses it since forever and it's good enough. I would not worry too much about it now. I've just pushed David's patch incorporating Iain's suggestion to the repository. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoting message written on Thursday 2014-06-05 10:17:10 by Yury: > On 06/05/2014 09:19 AM, Iain Patterson wrote: > > Having said that I do think that "cycling" is > > fine because if you keep pressing FocusNextKey > > you keep on iterating through the window list > > To repeat myself, if you do one-off alt-tab, do > you get cycling? In fact, you get the opposite, > or, at least, not cycling through the initial set. Yes you do get window cycling, unless you are using option SwitchPanelOnlyOpen = YES; in your WindowMaker config file. > When you work with switch panel activated, you > get additional visual element, which doesn't > change the base logic of the action, but > provides additional controls. And by default you also get window cycling. I have just tested it without SwitchPanelOnlyOpen set. > This just doesn't boil down to "cycle", this is > broader than just "cycle", but then again, > having had worked on l10n for a while, I just > might have a somewhat different perspective on > this... > > BTW, I still remember this little change of > logic of alt-tab behaviour was quite a source of > confusion to me in days of transition from > os2/win guis. These days, I rely on this feature. :) Here is the what NEWS file for 0.95.5 says about switchpanel: ---BEGIN--- To maintain consistency with other popular operating systems, the switchpanel is now configured so that it no longer automatically closes when the shift key is pressed and released. To configure the switchpanel so that it does close on release of the shift key, which was the traditional Window Maker behavior, run the following command: $ wdwrite WindowMaker StrictWindozeCycling NO If you find yourself regularly opening the switchpanel just to visualize open windows, you can run the following command to force the first "FocusNextKey" or similar shortcut to open the panel without switching to a new window. $ wdwrite WindowMaker SwitchPanelOnlyOpen YES ---END--- > > different text for the new preference because > > "Show switch panel when switching windows" is a > > bit weird. Just "Show panel..." maybe? > > There are lots of panels, which one do you have > in mind? :) I agree in this one. :-) -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Well, if this verb is here since forever, the whole discussion is moot. Initially, I've got the impression it's some sort of better-fication. Yury On 06/05/2014 10:42 AM, Carlos R. Mafra wrote: I don't think we should change the word 'cycling' in this context. wmaker uses it since forever and it's good enough. I would not worry too much about it now. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoth Yury Tarasievich, There are lots of panels, which one do you have in mind? :) The one that shows up when you switch windows, hence "Show panel when switching windows" :) -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoting message written on Thursday 2014-06-05 09:58:13 Iain Patterson: > Quoth Yury Tarasievich, > > > There are lots of panels, which one do you have in mind? :) > >The one that shows up when you switch windows, hence "Show panel when > switching windows" :) you mean cycle windows? ;-) -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoth I, Either way, since I raised the point I'm happy to go through and replace all occurrences of the old terminology once we've decided. The attached patch does just that. >From b4bea1e6383cfbdde4e943f786cbf6f057fa9052 Mon Sep 17 00:00:00 2001 From: Iain Patterson Date: Sun, 15 Jun 2014 08:52:55 +0100 Subject: [PATCH] Consistent terms for switch panel cycling. The terms "switch panel" and "cycling" have been used in Window Maker since time immemorial but have not always been applied consistently. --- NEWS | 16 po/de.po | 4 ++-- po/es.po | 6 +++--- po/et.po | 4 ++-- po/hu.po | 4 ++-- po/hy.po | 2 +- po/it.po | 2 +- po/ja.po | 4 ++-- po/ko.po | 4 ++-- po/nl.po | 4 ++-- po/zh_TW.po | 2 +- src/WindowMaker.h | 4 ++-- src/cycling.c | 2 +- src/defaults.c| 2 +- src/switchpanel.c | 2 +- src/winspector.c | 2 +- 16 files changed, 32 insertions(+), 32 deletions(-) diff --git a/NEWS b/NEWS index fa55d18..bd81b35 100644 --- a/NEWS +++ b/NEWS @@ -67,14 +67,14 @@ You can customize how you want your drawers to auto-expand/collapse and auto-raise/lower, or you can also completely disable them. -Improved switchpanel functionality --- +Improved switch panel functionality +--- -The switchpanel can be used to switch between windows of the same WM_CLASS, -for example between all open xterms. If the switchpanel is opened as normal +The switch panel can be used to switch between windows of the same WM_CLASS, +for example between all open xterms. If the switch panel is opened as normal with either the "FocusNextKey" or "FocusPrevKey" shortcut, you can switch to the next (or previous) window of the same type as the focused window with the -"GroupNextKey" or "GroupPrevKey" shortcut. If the switchpanel is opened with +"GroupNextKey" or "GroupPrevKey" shortcut. If the switch panel is opened with the "GroupNextKey" or "GroupPrevKey" shortcut, it will show only windows of the same type as the window which was focused at the time the panel was opened, and no difference will be seen between the two types of window selection @@ -83,17 +83,17 @@ shortcut. The new shortcuts can be configured in WPrefs, where they are described as allowing switching between windows of the same group. -To maintain consistency with other popular operating systems, the switchpanel +To maintain consistency with other popular operating systems, the switch panel is now configured so that it no longer automatically closes when the shift key is pressed and released. -To configure the switchpanel so that it does close on release of the shift +To configure the switch panel so that it does close on release of the shift key, which was the traditional Window Maker behavior, run the following command: $ wdwrite WindowMaker StrictWindozeCycling NO -If you find yourself regularly opening the switchpanel just to visualize open +If you find yourself regularly opening the switch panel just to visualize open windows, you can run the following command to force the first "FocusNextKey" or similar shortcut to open the panel without switching to a new window. diff --git a/po/de.po b/po/de.po index ec5ed3d..669f661 100644 --- a/po/de.po +++ b/po/de.po @@ -316,8 +316,8 @@ msgid "Could not load image \"%s\" for option \"%s\"" msgstr "Bild \"%s\"aus Eigenschaft \"%s\" konnte nicht geladen werden" #: ../src/defaults.c:3142 -msgid "Invalid split sizes for SwitchPanel back image." -msgstr "Ungültige Unterteilungsangaben für SwitchPanel-Hintergrundbild." +msgid "Invalid split sizes for switch panel back image." +msgstr "Ungültige Unterteilungsangaben für switch panel-Hintergrundbild." #: ../src/defaults.c:3211 #, c-format diff --git a/po/es.po b/po/es.po index 88fabc1..7e087e2 100644 --- a/po/es.po +++ b/po/es.po @@ -313,8 +313,8 @@ msgid "Could not load image \"%s\" for option \"%s\"" msgstr "No pudo cargar imagen \"%s\" para la opción \"%s\"" #: ../src/defaults.c:2915 -msgid "Invalid split sizes for SwitchPanel back image." -msgstr "Tamaños de división no válidos para el fondo del SwitchPanel" +msgid "Invalid split sizes for switch panel back image." +msgstr "Tamaños de división no válidos para el fondo del switch panel" #: ../src/defaults.c:2984 #, c-format @@ -1646,7 +1646,7 @@ msgid "Do not show in the switch panel" msgstr "No mostrar en panel de cambio de ventanas" #: ../src/winspector.c:1373 -msgid "Do not include in switchpanel while alternating windows." +msgid "Do not include in switch panel while cycling windows." msgstr "No incluir en el panel de cambio de ventanas cuando las ventanas se alternen." #: ../src/winspector.c:1376 diff --git a/po/et.po b/po/et.po index 54857e3..0208f0e 100644 --- a/po/et.po +++ b/po/et.po @@ -312,7 +312,7 @@ msgid "Could not load image \"%s\" for opti
