Re: [apparmor] GSoC proposal text

2013-03-10 Thread Christian Boltz
e good but is not required Well, I'd guess understanding the existing perl code would be good. Or are aa-logprof and AppArmor.pm so bad that people better don't look at them? ;-) > Skill Level: Intermediate - Hard (depends on implementation route) > > Mentor: John Johans

Re: [apparmor] GSoC proposal text v2

2013-03-10 Thread Christian Boltz
Hello, Am Sonntag, 10. März 2013 schrieb John Johansen: > On 03/10/2013 07:54 AM, Christian Boltz wrote: > > Am Samstag, 9. März 2013 schrieb John Johansen: > >> The base part of the project will be to implement a library and > >> basic > >> tool using the lib

Re: [apparmor] [PATCH] audio and base abstraction updates

2013-04-09 Thread Christian Boltz
ommit_memory contains the 'virtual > memory accounting' mode. The update for the base abstraction gives > read access to this file. To make the collection complete: Acked-By: Christian Boltz Please also backport both patches to the 2.8 branch. As a side effect of the abstractions/base

Re: [apparmor] Firefox profile and ~/Downloads, ~/Public folders permission.

2013-04-28 Thread Christian Boltz
ofile expects. Please check with aa-status (while firefox is running) what is going on. If unsure, just paste the output into a mail ;-) Regards, Christian Boltz -- Der von Ihnen vielleicht erwartete Input wird zu dem eines verstimmten Mitarbeiters oder eines Crackers der Monate Zeit ha

Re: [apparmor] GSoC Project on new AppArmor profile development tool

2013-05-01 Thread Christian Boltz
effectiveness, but I'm a bit worried about the > idea of "stopping when the tests all pass". Well, I will be the final enemy^Wtestcase *eg* - I'm quite sure you know how hard that can be ;-) Regards, Christian Boltz PS: non-random sig ;-) -- > "Quite low"

Re: [apparmor] GSoC Project on new AppArmor profile development tool

2013-05-03 Thread Christian Boltz
Hello, Am Mittwoch, 1. Mai 2013 schrieb Seth Arnold: > On Wed, May 01, 2013 at 05:35:03PM +0200, Christian Boltz wrote: > > http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/kshitij8/1 > I've got a handful of concerns; I'm afraid to give them voice, beca

[apparmor] [patch] backport python3 compability patch to 2.8 branch

2013-05-06 Thread Christian Boltz
_repl(matchobj): regex = "@@(" + "|".join(aa_regex_map) + ")@@" -with file("apparmor.vim.in") as template: +with open("apparmor.vim.in") as template: for line in template: line = re.sub(regex, my_repl, line.rstrip()) -print

Re: [apparmor] [patch] backport python3 compability patch to 2.8 branch

2013-05-07 Thread Christian Boltz
Hello, Am Montag, 6. Mai 2013 schrieb Steve Beattie: > On Mon, May 06, 2013 at 11:54:58PM +0200, Christian Boltz wrote: > > I'd like to propose the python3 compability changes from trunk r2052 > > to the 2.8 branch. > > > > Most of trunk r2052 also app

Re: [apparmor] dbus/pair address rule encoding

2013-05-09 Thread Christian Boltz
ver is mentioned first. Could we just switch it to the way that is also used for send? I'd propose dbus name=sender.com -> name=receiver.com receive, Advantages are: - we can keep the arrow - same order for send and receive (s/receive,/send,/ and you have the rule for the sending

Re: [apparmor] dbus/pair address rule encoding

2013-05-09 Thread Christian Boltz
Hello, Am Donnerstag, 9. Mai 2013 schrieb John Johansen: > On 05/09/2013 07:16 AM, Christian Boltz wrote: > > Could we just switch it to the way that is also used for send? > > I'd propose > > > > dbus name=sender.com -> name=receiver.com receive, > &g

Re: [apparmor] [opensuse-project] Google Summer of Code'13 accepted student

2013-05-29 Thread Christian Boltz
Hello, Am Dienstag, 28. Mai 2013 schrieb Kshitij Gupta: > I'm Kshitij Gupta from Lucknow, India. I had applied for GSoC under > openSUSE and am glad to have been accepted as a student to work on > "Profile management tool for AppArmor" under the guidance of Christian

Re: [apparmor] [opensuse-project] Google Summer of Code'13 accepted student

2013-05-29 Thread Christian Boltz
profile additions in the local/* files instead of the main profile. Regards, Christian Boltz -- RAID: One more disk fails than can be recovered by the redundancy. -- Andreas Dau -- AppArmor mailing list AppArmor@lists.ubuntu.com Modify sett

Re: [apparmor] [opensuse-project] Google Summer of Code'13 accepted student

2013-05-30 Thread Christian Boltz
I noticed you created https://launchpad.net/~apparmor-profile-tools I assume you want to use that as development place, right? (and BTW, I changed the title from "dev" to "AppArmor profile tools" ;-) @John: is it easily possible to move the code including version history to t

Re: [apparmor] [PATCH] Move poppler cMap rule to fonts abstraction

2013-05-30 Thread Christian Boltz
ppler CMap tables > > > - /usr/share/poppler/cMap/** r, > > This is now committed to trunk, revision 2120. The patch looks also interesting for the 2.8 branch. Can you please commit it there, too? For the 2.8 branch: Acked-By: Christian Boltz (also valid for trunk of course, but sup

Re: [apparmor] [opensuse-project] Google Summer of Code'13 accepted student

2013-05-31 Thread Christian Boltz
rsity, so you'll be able to come up with a good code layout. In other words: "whatever makes sense" ;-) We'll of course provide feedback as early as possible. Regards, Christian Boltz -- > Und nun rate mal, warum ausgerechnet v.a. Vielschreiber mutt > verwenden. Sicher nic

Re: [apparmor] [opensuse-project] Google Summer of Code'13 accepted student

2013-06-03 Thread Christian Boltz
profile and re-install the apparmor-profiles package.) > Sometimes, the user generated profiles may > screw up. (I ended up messing up my Firefox profile while playing > with aa-genprof as a consequence to which my Firefox would never > start-up). ;-) Regards, Christian Boltz [1

Re: [apparmor] [opensuse-project] Google Summer of Code'13 accepted student

2013-06-04 Thread Christian Boltz
> but only to those who deserve it :P > [from lists.opensuse.org/opensuse-factory/2010-06/msg00228.html] Nice and quite typical for Seife ;-) but not (yet) in my collection - how could I overlook that? A small technical detail - please use "-- " (minus minus space - the space is imp

Re: [apparmor] [opensuse-project] Google Summer of Code'13 accepted student

2013-06-05 Thread Christian Boltz
ra space and I'm No problem ;-) > glad you liked my first sig. :-) I'll probably build myself a > collection of those too. If you are interested in the scripts I'm using: http://cboltz.de/en/linux/zufallssig/ Nothing magic, but it can save you from re-inventing the whe

[apparmor] [patch] fix libapparmor ruby bindings for ruby 2.0

2013-06-05 Thread Christian Boltz
other distributions etc., therefore I'm asking for an extra strict review (and some testing) ;-) Regards, Christian Boltz -- > Ich geh' jetzt erstmal Gummienten beim Wettschwimmen zugucken... Du Gluecklicher. Ich darf morgen "echten" eNTen beim Umfallen zuschaun.

Re: [apparmor] [opensuse-project] Google Summer of Code'13 accepted student

2013-06-06 Thread Christian Boltz
. > > > > @Christian please add your profile link with your name and maybe > > your IRC nick too. It's on my TODO list, but not one of the most urgent things ;-) > > @John , @Christian also you can fill out the schedule for weekly > > meetings. See below for a proposal.

Re: [apparmor] [patch] fix libapparmor ruby bindings for ruby 2.0

2013-06-12 Thread Christian Boltz
Hello, Am Mittwoch, 12. Juni 2013 schrieb John Johansen: > On 06/05/2013 01:23 PM, Christian Boltz wrote: > > you might have noticed the discussion about the libapparmor ruby > > bindings build failures on openSUSE Factory, which is the first > > version with ruby 2.0. >

[apparmor] GSoC week 1

2013-06-16 Thread Christian Boltz
e a tool to (mostly) automatically convert YCP to ruby, but there are also YaST python bindings which might be a better choice in our case because we want to use the python libraries you'll write. Anyway, I'd say we need a working base (python modules + commandline interface) first. When

Re: [apparmor] [Branch ~kgupta8592/apparmor-profile-tools/trunk] Rev 7: added severity.py with tested convert_regex and the old and new config

2013-06-18 Thread Christian Boltz
regex = regex.replace('SDPROF_INTERNAL_GLOB', '*') I might be paranoid, but - what happens if access to a file called /foo/barSDPROF_INTERNAL_GLOB is requested? ;-) This is highly theoretical for severity.db, but please keep it in mind if you use similar code for logprof/ge

Re: [apparmor] [Branch ~kgupta8592/apparmor-profile-tools/trunk] Rev 7: added severity.py with tested convert_regex and the old and new config

2013-06-18 Thread Christian Boltz
Hello, Am Dienstag, 18. Juni 2013 schrieb Kshitij Gupta: > On Tue, Jun 18, 2013 at 6:34 PM, Christian Boltz wrote: > > (with >34 °C outside, I decided to spend some hours in the office > > ;-) > > You seem to be having a pretty hot summer, apparently that works in my &

Re: [apparmor] DBus rule syntax for subject and peer components

2013-06-21 Thread Christian Boltz
ot;keyword (...)" style (am I correct?) so I'd prefer to use = BTW: I'd prefer to avoid multiline syntax - it might be "for free" in the parser, but for apparmor.vim it's more difficult ;-) Regards, Christian Boltz -- > ich hatte gestern Abend einen merkwürdigen

Re: [apparmor] DBus rule syntax for subject and peer components

2013-06-23 Thread Christian Boltz
> an alternation would one of send or receive It may be a silly question, but: what's the difference between the alternation "send or receive" and "send and receive at the same time"? Regards, Christian Boltz -- Warum deine Programme auf spanisch ausgeführt w

Re: [apparmor] Minimum versions of tools

2013-07-07 Thread Christian Boltz
inimum Python 2.7. Some utilities may require > +Python 3.3. Python 3.0, 3.1, 3.2 are largely untested. > + > +Most shell scripts are written for POSIX-compatible sh. aa-decode > expects +bash, probably version 3.2 and higher. The text looks good to me (even if I didn't check all vers

[apparmor] GSoC r13, r14, r15 review

2013-07-08 Thread Christian Boltz
541s FAILED (errors=1) I somehow doubt this is intentional - the test should catch this exception ;-) Also note that the last line contains \n\t - this should become a real line break and tab in the output... Regards, Christian Boltz -- [T-Shirt-Druck] Die meisten Leute haben bedauerlicherwe

Re: [apparmor] [PATCH 1/3] Add new fontconfig configuration snippets path to the fonts abstraction.

2013-07-08 Thread Christian Boltz
> /usr/share/fontconfig/. > > > > This was reported by Jakub Wilk on Debian bug > > #714843. > Acked-by: Seth Arnold Please also backport the abstractions/fonts patches to the 2.8 branch. (I will only write one (this) mail for all 3 patches ;-) Regards, Christian Boltz

Re: [apparmor] [Patch] Bug 888077 - aliases being partially applied

2013-07-08 Thread Christian Boltz
right that the patch is quite large. How big is the risk that your patch breaks something? Regards, Christian Boltz -- If I had a cent for everytime someone complained about single RPM installation failing with KPackageKit on 11.4, I'd buy Attachmate ;-) [Martin Schlander in opensuse-fa

Re: [apparmor] [Branch ~apparmor-dev/apparmor/master] Rev 2136: Kshitij Gupta found and fixed a problem with Glob and Glob w/ Ext behavior

2013-07-08 Thread Christian Boltz
> +if (not $newpath ~~ @options) { Note that in one case $options is used and @options in the other. I somehow doubt that both are correct ;-) Regards, Christian Boltz -- Verwandschaft, f. (pl) : Jemand, der auf dem Sofa sitzt und übelnimmt. [Ratti in f

[apparmor] GSoC r16 review

2013-07-09 Thread Christian Boltz
Hello, same as last time - see attached file ;-) Regards, Christian Boltz -- who needs facts if polemics are that much easier to get into. [Sven Burmeister in opensuse-factory] === modified file 'Testing/severity_test.py' --- Testing/severity_test.py 2013-07-06 13:27:06 + +

Re: [apparmor] Fwd: GSoC r13, r14, r15 review

2013-07-09 Thread Christian Boltz
py2013-07-03 23:34:04 + > > > +def cmd_pipe(command1, command2): > +'''Try to pipe command1 into command2.''' > +try: > +sp1 = subprocess.Popen(command1, stdout=subprocess.PIPE) > +sp2 = subprocess.Popen(command2,

Re: [apparmor] GSoC r13, r14, r15 review

2013-07-09 Thread Christian Boltz
t; > ERROR: No severity value present in file: severity_broken.db > [Line 14]: CAP_SYS_MODULE > What would you say? move to error() instead of raising > AppArmorException? Can error() be catched with try/except like an exception? For example, we'll need this to display a nice e

Re: [apparmor] apparmor policy versioning

2013-07-11 Thread Christian Boltz
, when both exist, use the one that is appropriate > for the kernel. Exactly this is the reason why I don't like to have a separate directory with a duplicated set of the profiles. I have more than enough experience with code duplication[2], and learned to avoid the "cp" comman

[apparmor] GSoC review r17..22

2013-07-18 Thread Christian Boltz
Hello, the attached files contain my review notes for r17..22. In case you miss the files for r19 and r20: that's intentional, those commits look so good that I don't need to comment on them ;-) Regards, Christian Boltz -- Jungs. Mit dem Argument kann ich kaputte Autos verkaufe

[apparmor] GSoC review r23

2013-07-20 Thread Christian Boltz
Hello, see the attachment for r23 review. The commit looks quite good, but I found some small issues nevertheless ;-) Regards, Christian Boltz -- > I don't really know how nor why, but if a spellchecker is > enabled on the wiki server, the edit wiki windows do > colorize the m

[apparmor] GSoC review r24

2013-07-23 Thread Christian Boltz
Hello, see the attachment for the r24 review. Regards, Christian Boltz -- There is always room for improvement to seek perfection is to drive yourself insane. except suseROCKs, he's already insane. [from #opensuse-project] === modified file 'apparmor/aa.py' --- apparmor/aa.p

Re: [apparmor] [parser patch] fix apparmor cache tempfile location to use passed arg

2013-07-23 Thread Christian Boltz
ck the return code of). Nice[tm]. That said - your patch looks like something that should be backported to the 2.8 branch (even if it isn't needed for openSUSE thanks to the symlink). Regards, Christian Boltz -- Aren't most of SUSE-employed community members part of the Research&D

Re: [apparmor] [PATCH 03/10] From a3f0ccf618c2016ce5fbaa0fe35d4f194fbefd2b Mon Sep 17 00:00:00 2001 From: John Johansen Date: Sat, 27 Oct 2012 04:49:23 -0700 Subject: [PA

2013-07-25 Thread Christian Boltz
rmor ? ;-) > +# Last Modified: Sun Apr 17 19:44:44 2005 > +# > +/does/not/exist { > + audit allow capability chown, > + audit allow capability dac_override, I somehow remember the parser enforced alphabetic order of keywords. Is this still valid? (If yes, it should be "a

[apparmor] GSoC review r26 and r27

2013-07-27 Thread Christian Boltz
ld logprof was buggy or the comment is wrong ;-) Regards, Christian Boltz -- [Grundrechte] Natürlich gibt's da auch das berühme Recht auf freie Entfaltung. Andererseits: setzt das nicht auch zwingend vorraus, daß man vorher auch gehörig zusammengefaltet wurde? ;-) [Gerard Jensen in suse

[apparmor] GSoC r28 and r29 review

2013-07-28 Thread Christian Boltz
Hello, the attached file contains the review of r28 and r29. Regards, Christian Boltz -- > Erg, I forgot about that. I think it might be best to fix logprof to > not create profile files with spaces in the names. Uh? If someone names their program with a space in it, that's a

[apparmor] GSoC meeting

2013-07-28 Thread Christian Boltz
Hello, this week, the GSoC IRC meeting will be a day earlier than usual because I'll be away on tuesday. This means the meeting is on monday (= tomorrow) at 19:00 UTC. Besides the usual topics, we'll also discuss the to-be-written mergeprof. Regards, Christian Boltz -- AV is home

[apparmor] GSoC review r30

2013-08-01 Thread Christian Boltz
Hello, the review for r30 is attached - it had lots of new code (and interesting[tm] regexes) - therefore I have several notes about it ;-) @John: The review contains some questions for you - can you please answer them? Regards, Christian Boltz -- > > My calendar shows May 12th t

Re: [apparmor] GSoC review r30

2013-08-02 Thread Christian Boltz
Hello, John Johansen wrote: > On 08/01/2013 02:59 PM, Christian Boltz wrote: > ### a check if the hat already exists might be useful to avoid duplicate > hat names (which might get merged on write, but I doubt that's intended > behaviour) > > ### interestingly, the par

[apparmor] GSoC r31 review

2013-08-04 Thread Christian Boltz
Hello, the GSoC review for r31 is attached. Regards, Christian Boltz -- > My 2 cents, tja, Stundenlohn wird nach Eignung, Leistung und Befähigung gezahlt [> Claus Reheis und Detlef Reichelt in opensuse-de] review-r31 Description: Binary data -- AppArmor mailing list Ap

[apparmor] GSoC review r33

2013-08-09 Thread Christian Boltz
Hello, the review for r33 is attached. The comments I initially had for r32 are included in r33 because you moved the convert_regexp function around ;-) Regards, Christian Boltz -- Zu meiner Entschuldigung: Ich konnte es nicht nochmal durchlesen, weil meine Kippenschachtel leer war und ich

[apparmor] GSoC review r34

2013-08-09 Thread Christian Boltz
Hello, one more (quite harmless) review ;-) Regards, Christian Boltz -- [Windows krepiert nach Update] > Habt Ihr eine Idee, was ich tun könnte? Vermutlich ein Computervirus. Besorg etwas Aciclovir aus der Apotheke, oeffne das Rechnergehaeuse und troepfle das Mittel auf alle roten o

[apparmor] GSoC review r35..39

2013-08-09 Thread Christian Boltz
Hallo, the reviews for r35..r39 are attached. I have no complaints about the revisions with even numbers ;-) Regards, Christian Boltz -- Aus der Beschreibung entnehme ich, daß deine Fonts nach Typ 3 konvertiert werden (Finger im Hals) und deine Bilder auf Screen- Qualität (Fuß zum Finger

Re: [apparmor] GSoC review r34

2013-08-10 Thread Christian Boltz
Hello, Am Samstag, 10. August 2013 schrieb Christian Boltz: > one more (quite harmless) review ;-) I noticed two additional small issues, see the [v2] in the updated review. Regards, Christian Boltz -- dU hAsT nAtUeRlIcH rEcHt. MaN mUsS sIcH bEiM lEsEn NuR dArAn GeWoEhNeN. mAcHt DaNn KeI

[apparmor] GSoC review r40

2013-08-10 Thread Christian Boltz
Hello, the review for r40 is attached. I also included the r34 [v2] comments, so you can skip the mail with the updated r34 review ;-) @John: it also includes a question for you (the same I asked on IRC, but you didn't respond yet ;-) Regards, Christian Boltz -- Sagt mal ehrlich: Ist

Re: [apparmor] GSoC review r35..39

2013-08-10 Thread Christian Boltz
ut > diff using a script and dont mind email spam ;) I even prefer tiny pushes, thanks for doing it this way! > convert_regex thing regarding [^}] was useful i stumbled on a testcase > which needed it to be used. :) ;-) Regards, Christian Boltz -- > Was ist das, "Nacht"?

Re: [apparmor] [PATCH] apparmor: add the ability to report a crypto hash of loaded policy

2013-08-10 Thread Christian Boltz
> { Was adding the second empty line intentional? Regards, Christian Boltz -- > Ich hab da nochma ne Frage! :o) Was is eigentlich en DAU? Ich mein ihr > sagt mir zwar die ganze Zeit das ich das bin, aber was das is wes ich > ni! *heul* Ich rate ganz einfach ma!;o) Die Allercoolste

Re: [apparmor] [RFC] handling XDG user directories

2013-08-10 Thread Christian Boltz
cales I have, for example ~/downloads translates to a directory name I have, and that should not be accessible ;-) The perfect solution would be to only allow the directory names in each user's language (so the profile would have /home/cb/Dokumente/ and /home/english/documents/ for example)

[apparmor] GSoC review r41..45

2013-08-11 Thread Christian Boltz
Hello, the review for r41..45 is attached (merged into one review). BTW: Following the moved code was quite interesting[tm], but still easier than completely reviewing the new aamode.py and logparser.py ;-) Regards, Christian Boltz -- >Seit einiger Zeit ist ftp://mirrors.mathematik.uni-b

Re: [apparmor] [RFC] handling XDG user directories

2013-08-12 Thread Christian Boltz
Hello, Am Montag, 12. August 2013 schrieb Jamie Strandboge: > On 08/10/2013 03:46 PM, Christian Boltz wrote: > >>> * apparmor-xdg-dirs.py: this takes the output of 'locale -a' and > > > > I'm afraid this will result in a bit too much ;-) > >

[apparmor] GSoC r46..47 review

2013-08-12 Thread Christian Boltz
Hello, see /dev/null for the r46 and r47 review. (In other words: looks good, I don't have anything to complain ;-) Regards, Christian Boltz -- > cat /inhalt/der/mail | mail -s "mein subject" [...] Ist der Useless Use of Cat Award diese Woche schon vergeben? ;-) [> And

[apparmor] GSoC - remaining parts of old reviews

2013-08-13 Thread Christian Boltz
e the number of files doesn't shock you too much - most of the files are quite small ;-) If you have questions or think some things need to be discussed, just ask ;-) Regards, Christian Boltz -- und *echte* Männer benutzen Linux -- wegen der langen Kommandozeilen ("Meine ist länge

[apparmor] GSoC review r48..51

2013-08-22 Thread Christian Boltz
og'): syslog = False I'm not sure if "audit.log exists" is the best way to choose the logfile but I have to admit that I don't have a better method ;-) Does someone have any better ideas? Or is the current way ok? Regards, Christian Boltz -- But you are probably a

Re: [apparmor] [PATCH] profiles: dnsmasq needs dbus abstraction

2013-08-22 Thread Christian Boltz
bin/dnsmasq { >#include > + #include >#include > >capability net_bind_service, I'd say this patch is a good candidate for the 2.8 tree ;-) (you can take this mail as an ACKed-by $from if you want ;-) Regards, Christian Boltz -- > > Wieso ich, ich habe

Re: [apparmor] GSoC review r48..51

2013-08-22 Thread Christian Boltz
Hello, Am Donnerstag, 22. August 2013 schrieb Christian Boltz: > the review for r48, 49, 50 and 51 is attached. ... or not :-/ Let me try a second time ;-) Regards, Christian Boltz -- # GO AWAY ! # YOU DO NOT WANT TO SEE THIS SCRIPT !!! [from /opt/kde3/share/apps/krpmview/setup_temp_sou

Re: [apparmor] Patch: Replace smartmatch operator in AppArmor.pm to fix experimental issue in Perl5.18

2013-08-23 Thread Christian Boltz
} > -if (not $newpath ~~ @options) { > +if (not grep { $newpath eq $_ } > @options) { push @options, $newpath; $defaultoption = $#options + 1; > } ACKed-by: Christian Boltz I'll commit it to trunk and the 2.8 branch. Regards, Chris

[apparmor] GSoC review r52 and r53

2013-08-26 Thread Christian Boltz
..) in the profile has the advantage that people are used to it, OTOH creating a symlink means we don't need to modify the profile. Opinions? (We'll have to contunue supporting both ways, the question is what aa-complain, aa-audit etc. should do.) Regards, Christian Boltz -- Der f

[apparmor] GSoC review r54

2013-09-05 Thread Christian Boltz
Hello, the review for r54 is attached. One interesting question about globbing: /**/ -> /**/ (hmm, or would /** be correct? good question...) Opinions? Regards, Christian Boltz -- Super-PC von IBM - der erste 486er im Test [Titelseite der Chip 8/1

[apparmor] GSoC review r55..57

2013-09-05 Thread Christian Boltz
Hello, the review for r55 is attached. I didn't notice any problems in r56 and r57 :-) Regards, Christian Boltz -- [...] sollte für einen Ortskundigen also kinderleicht zu finden sein. Wir sind die Leute, die den dicken weißgrünen Europcar Lastwagen so bescheuert mitten auf der S

[apparmor] GSoC - testcase results

2013-09-05 Thread Christian Boltz
last): File "minitools_test.py", line 62, in test_enforce subprocess.check_output('python ./../Tools/aa-enforce -d ./profiles -r ntpd', shell=True) File "/usr/lib64/python3.3/subprocess.py", line 586, in check_output raise CalledProcessError(retcode, proce

[apparmor] [patch] make __init__.py GSoC-ready

2013-09-12 Thread Christian Boltz
changes in utils/apparmor/common.py - Kshitij added several functions there. But that's another story and not too urgent. However we should do it before the 3.0 release. Regards, Christian Boltz [1] We'll need to re-add the .py suffix for the tools in the testing package, but that&#

Re: [apparmor] [patch] make __init__.py GSoC-ready

2013-09-12 Thread Christian Boltz
Hello, Am Donnerstag, 12. September 2013 schrieb Christian Boltz: > to make testing Kshitij's new tools easier, I propose to merge his > code in utils/apparmor/__init__.py - that's the only filename > conflict (at least in the 2.8 branch). If we do this, we can ship his >

[apparmor] [patch] utils/po/de.po update

2013-09-13 Thread Christian Boltz
hem, but need to think about better alternatives. The most interesting question is if "capability" should be translated to "Funktion" - I somehow doubt... See the attached patch for all changes. I propose this patch for trunk and the 2.8 tree. Regards, Christian Boltz P

[apparmor] GSoC review r58

2013-09-15 Thread Christian Boltz
Hello, the attached file contains the review for r58 and also some bugs I found while testing. Regards, Christian Boltz -- Stell dein cron auch deine Rechneruhr? Ja? Dann würde ich ihm nicht allzuviel mehr anvertrauen - er scheint leicht überlastet und strebt in Riesenschritten die Rente

[apparmor] [patch] ntpd needs read access to openssl.cnf

2013-09-16 Thread Christian Boltz
read openssl.cnf or starting of ntpd will fail silently(!) Patch v2 by Christian Boltz: use abstractions/openssl instead of allowing /etc/ssl/openssl.cnf directly === modified file 'profiles/apparmor.d/usr.sbin.ntpd' --- profiles/apparmor.d/usr.sbin.ntpd 2011-08-08 20:16:06 +00

Re: [apparmor] [patch] ntpd needs read access to openssl.cnf

2013-09-16 Thread Christian Boltz
Hello, Am Montag, 16. September 2013 schrieb Steve Beattie: > On Mon, Sep 16, 2013 at 10:39:13PM +0200, Christian Boltz wrote: > > I just received the following patch and propose it for 2.8 and > > trunk: > > > > Patch-Author: Stefan Seyfried > > > > Afte

Re: [apparmor] [PATCH 3/8] add optional allow prefix to the language v2

2013-09-17 Thread Christian Boltz
TION validate duplicate capability entries. > +#=EXRESULT PASS > +# vim:syntax=subdomain ... and here ... > Index: b/parser/tst/simple_tests/capability/bad_5.sd > ======= > --- /dev/null > +++ b/parser/tst/simple_tests/capability/bad_

[apparmor] Revert r1225 mistranslations (utils/po/*.po)

2013-09-17 Thread Christian Boltz
e of marking everything as fuzzy is that we'll get proofreading for all texts which might also catch mistranslations from other commits. Opinions? Objections? (if you want to see the patch for this proposal: bzr diff -r1224..1225, then swap + and -) Regards, Christian Boltz [1] except d

Re: [apparmor] [PATCH] Support pulseaudio 4.

2013-09-17 Thread Christian Boltz
, > - /usr/lib/pulse-2.[0-9]/modules/*.so mr, > + /usr/lib/pulse-[2-4].[0-9]/modules/*.so mr, >/usr/lib/pulseaudio/pulse/gconf-helper Cx, Can we make this future-proof, please? I'd propose to use /usr/lib/pulse-[2-9].[0-9]/modules/*.so mr, to cover pulseaudio up to 9.9 ;-) Regard

[apparmor] GSoC review r59..62

2013-09-17 Thread Christian Boltz
Hello, the reviews for r59 and r61 are attached. The code from r60 was moved to another file in r61, therefore I added all notes in the r61 review. r62 only deleted disabled code, which means nothing to complain about ;-) Regards, Christian Boltz -- > Das hatte ich (samt Kommentar aus

[apparmor] [patch] fix aa-unconfined to work in all languages

2013-09-19 Thread Christian Boltz
in/netstat -nlp |")) { +if (open(NETSTAT, "LANG=C /bin/netstat -nlp |")) { while () { chomp; push @pids, $5 Regards, Christian Boltz -- Auch wenn da nix sein KANN und Du lieber neue Parameter einbaust. Tust Du MIR bitte mal den Gefallen und li

[apparmor] [patch] utils/*.pod: fix broken URL

2013-09-19 Thread Christian Boltz
rof.conf.pod' --- utils/logprof.conf.pod 2011-02-07 23:39:54 + +++ utils/logprof.conf.pod 2013-09-19 18:46:39 + @@ -103,7 +103,7 @@ =head1 BUGS If you find any bugs, please report them at -L<http://https://bugs.launchpad.net/apparmor/+filebug>. +L<https://bugs.launchpad.n

Re: [apparmor] [patch] utils/*.pod: fix broken URL

2013-09-19 Thread Christian Boltz
Hello, Am Donnerstag, 19. September 2013 schrieb Steve Beattie: > On Thu, Sep 19, 2013 at 08:52:19PM +0200, Christian Boltz wrote: > > the following patch fixes broken URLs in various utils/*.pod files. > > (The broken URLs were introduced in r1582.) > > > > I propo

[apparmor] GSoC review r63 and r64

2013-09-19 Thread Christian Boltz
ir of eyes won't hurt ;-) Regards, Christian Boltz -- > I don't really know how nor why, but if a spellchecker is > enabled on the wiki server, the edit wiki windows do > colorize the mispelled words and this is very handy. I have mixed feelings about using a spill chicken.

[apparmor] GSoC review r65

2013-09-20 Thread Christian Boltz
Hello, the review for r65 is attached. I also found some \n fun in logprof and a broken genprof - see the review for details ;-) Regards, Christian Boltz -- Wie meinte doch neulich ein OS/2 oder CygWin-User: PATH=C:\backspace\return;E:\tab\newline;D:\home W:\pakete\mypaket\configure --prefix

[apparmor] GSoC review r66 and r67

2013-09-20 Thread Christian Boltz
Hello, the review for r67 is attached. It looks big, but mostly contains minor text changes ;-) r66 looks good - no need for a review file. Regards, Christian Boltz -- > [submit-request #65647 declined by saschpe:] > description is >400 lines, too long :-) Where is a limit d

[apparmor] GSoC review r68 and r69

2013-09-21 Thread Christian Boltz
ols that change profile flags.) Regards, Christian Boltz -- > which camera is this? Marcus, this is my bug :) [Marcus Meissner and Stephan Kulow in https://bugzilla.novell.com/show_bug.cgi?id=217731] revno: 68 committer: Kshitij Gu

[apparmor] GSoC - updated reviews

2013-09-21 Thread Christian Boltz
The attached review-r69 (I needed a filename ;-) contains another small bug - it's just a missing space, but causes invalid profiles ;-) Regards, Christian Boltz -- Look at Debian... its stable, works on a variety of platforms and development is racing along at the speed of a tur

[apparmor] GSoC review r70..72

2013-09-22 Thread Christian Boltz
Hello, the (quite small) reviews for r70 and r72 are attached. The r70 review also contains two bugs I noticed. For r71, I have no reason to complain ;-) Regards, Christian Boltz -- > Das Autofahrersyndrom: Prüft Euren Ton. *anschlag* *bonk* Stimmt, der Ton ist nicht sonderlich... [>

[apparmor] GSoC review r75

2013-09-22 Thread Christian Boltz
Hello, the review for r75 is attached, with two bugs and a To-Do note included. Regards, Christian Boltz -- you are spending too much time in web forums or with apache guys if you are using "+1" and "-1" :-) [Stefan Seyfried

[apparmor] GSoC review r76..79

2013-09-23 Thread Christian Boltz
Hello, the reviews for r76..79 are attached. (No complaints about r76 and r78.) Regards, Christian Boltz -- >> Microsoft-Compatible Spongiforme Encephalitis? > Setzt das nicht Hirn voraus? Irgendwo müssen doch all die Beschwörungsformeln hin, die man als MCSE auswendig lernen

[apparmor] GSoC review r80..84

2013-09-23 Thread Christian Boltz
Hello, the review for r80 is attached. Maybe I'll add some comments on the UI later after actually testing aa-mergeprof ;-) r81..84 look fine :-) Regards, Christian Boltz -- http://www1.giga.de/gigahelp/index_gigahelp/0,3597,,00.html | Leider scheint Euer Browser den Aufbau von Fram

[apparmor] force-complain symlinks break cache?

2013-09-25 Thread Christian Boltz
ting to systemctl reload apparmor real0m17.250s user0m0.000s sys 0m0.004s This is a server with openSUSE 13.1 beta with AppArmor 2.8.2. Regards, Christian Boltz -- Hier gibt es zB eine Adress-DB für einige Leute und allein schon die gleichzeitige Verwendung dieser DB ist

Re: [apparmor] [patch] [parser] allow the parser to process directories as a parameter

2013-09-29 Thread Christian Boltz
}, > + /* RPM packaging files have traditionally not been silently > + ignored */ > + { ".rpmnew", 7, 0 }, > + { ".rpmsave", 8, 0 }, > + /* Backup files should be mentioned */ > + { "~", 1, 0 }, > + { NULL, 0, 0 } > +}; Sh

[apparmor] [Patch] cleanup usr.sbin.ntpd profile

2013-09-30 Thread Christian Boltz
@{pid}/net/if_inet6 r, - @{PROC}/sys/kernel/ngroups_max r, # allow access for when chrooted /var/lib/ntp/@{PROC}/@{pid}/net/if_inet6 r, Regards, Christian Boltz -- [GUI vs. Command-Line] Einen ähnlichen Streit wird es in 20 Jahren auch geben, wenn die "2D-Screenfanatiker&qu

Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-10 Thread Christian Boltz
e nobody wants to have his terminal filled up with binary data, and I'm also sure nobody can read the binary dump without using tools. Instead, you should print both file sizes or just "file size differs". This is the only critical thing - everything else is "just"

Re: [apparmor] [patch 13/13] parser - update README information

2013-10-10 Thread Christian Boltz
Hello, Am Donnerstag, 10. Oktober 2013 schrieb Steve Beattie: > The README in the parser directory was woefully out of date; this > patch updates the information to contain the current mail list, wiki, > and bug tracking locations. That was an easy one to proofread ;-) Acked-by: Christ

Re: [apparmor] [patch 03/13] parser - add simple file deny rule tests

2013-10-11 Thread Christian Boltz
Hello, Am Donnerstag, 10. Oktober 2013 schrieb Steve Beattie: > Our simple language tests did not include any file deny rule tests. > This patch adds a few simple ones. Acked-by: Christian Boltz Regards, Christian Boltz -- Oder kannst du dir ein AUto vorstellen das erst mit

Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-11 Thread Christian Boltz
Hello, Am Donnerstag, 10. Oktober 2013 schrieb Steve Beattie: > On Fri, Oct 11, 2013 at 01:36:59AM +0200, Christian Boltz wrote: > > [sorry for the slightly broken quoting - KMail needs some > > improvement > > when quoting overlong lines ;-) ] > > No worries. I&

[apparmor] [patch] updated usr.sbin.smbd profile

2013-10-15 Thread Christian Boltz
2 15:02 wbc_sam.so* Regards, Christian Boltz -- TikiWiki ist eine sehr umfassende Sammlung von Sicherheitslücken, konzeptuellen Problemen und Performancekillern, die alles kann und nichts richtig. [Kristian Köhntopp auf http://blog.koehntopp.de/archives/2051-5-Jahre-Blogging.html] --

Re: [apparmor] [patch] updated usr.sbin.smbd profile

2013-10-15 Thread Christian Boltz
Hello, Am Dienstag, 15. Oktober 2013 schrieb Christian Boltz: > some samba *.dat files were moved, and a new library needs to be > loaded by smbd. It turns out more changes are needed for samba, also in the nmbd and winbindd profile. The reason is probably a major version update - op

Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-15 Thread Christian Boltz
Hello, Am Dienstag, 15. Oktober 2013 schrieb Steve Beattie: > On Fri, Oct 11, 2013 at 10:08:51PM +0200, Christian Boltz wrote: > > We'll see if you still like this in some months... > > While I reserve the right to flake out^W^W change my mind, I help ;-) > maintain and

Re: [apparmor] [patch] updated usr.sbin.smbd profile

2013-10-16 Thread Christian Boltz
Hello, looks like the patch needs one additional line (inserted below), see https://bugzilla.novell.com/show_bug.cgi?id=845867#c4 Am Dienstag, 15. Oktober 2013 schrieb Christian Boltz: > Am Dienstag, 15. Oktober 2013 schrieb Christian Boltz: > > some samba *.dat files were moved,

Re: [apparmor] [patch 1/8] parser caching tests - remove unused value

2013-10-24 Thread Christian Boltz
Hello, Am Mittwoch, 23. Oktober 2013 schrieb Steve Beattie: > Remove unused report value where it's not used. > > Signed-off-by: Steve Beattie > --- > parser/tst/caching.py | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) Acked-by: Chr

<    1   2   3   4   5   6   7   8   9   10   >