Re: [ath5k-devel] ACK timeout

2009-11-26 Thread Lukáš Turek
> Sounds like a plan --- but you should really ask/propose in > linux-wireless, as there are way more developers hanging out > there than here. I sent it today, in case you're not subscribed there: http://article.gmane.org/gmane.linux.kernel.wireless.general/43648 > Ah, and make the measure metric

Re: [ath5k-devel] ACK timeout

2009-11-23 Thread Luis R. Rodriguez
On Sun, Nov 22, 2009 at 11:45:27PM -0800, Holger Schurig wrote: > On Sunday 22 November 2009 01:36:43 Luis R. Rodriguez wrote: > > No, not all hardware can change this, we also don't want to > > clobber iw with hw specific knobs. > > I see it differently. Debugfs is for debugging, not for API. We

Re: [ath5k-devel] ACK timeout

2009-11-23 Thread Bob Copeland
On Mon, Nov 23, 2009 at 10:54 AM, Luis R. Rodriguez wrote: > Oh OK, thanks for clarifying that. > >> I know that at least Atheros, Broadcom and Ralink hw can set >> this, so I think we should have an API for nl80211 with iw support. > > Probably overkill for now still. Also nl80211 testmode hooks

Re: [ath5k-devel] ACK timeout

2009-11-23 Thread Luis R. Rodriguez
On Sun, Nov 22, 2009 at 11:10:41AM -0800, Felix Fietkau wrote: > Luis R. Rodriguez wrote: > > On Sat, Nov 21, 2009 at 2:14 PM, Lukáš Turek <8...@praha12.net> wrote: > >> Hi, > >> > >> it seems Ath5k is missing a Madwifi feature that is essential for our > >> long-distance links: setting ACK timeout

Re: [ath5k-devel] ACK timeout

2009-11-23 Thread Holger Schurig
> What about providing a higher abstraction, a "distance" > parameter instead of acktimeout, csttimeout and slottime? For > example 'iw phy0 set distance 3000'. Definitely at least ath9k > hardware supports this feature. Sounds like a plan --- but you should really ask/propose in linux-wireless,

Re: [ath5k-devel] ACK timeout

2009-11-23 Thread Holger Schurig
On Sunday 22 November 2009 01:36:43 Luis R. Rodriguez wrote: > No, not all hardware can change this, we also don't want to clobber iw > with hw specific knobs. I see it differently. Debugfs is for debugging, not for API. If you'd use debugfs for it, then you'd force every embedded developer to

Re: [ath5k-devel] ACK timeout

2009-11-23 Thread Lukáš Turek
On 23.11.2009 08:45 you wrote: > I see it differently. Debugfs is for debugging, not for API. If > you'd use debugfs for it, then you'd force every embedded > developer to compile debugfs into the kernel. Ugly. I agree, but at least it would be some solution for us. We can't afford to maintain pat

Re: [ath5k-devel] ACK timeout

2009-11-22 Thread Felix Fietkau
Luis R. Rodriguez wrote: > On Sat, Nov 21, 2009 at 2:14 PM, Lukáš Turek <8...@praha12.net> wrote: >> Hi, >> >> it seems Ath5k is missing a Madwifi feature that is essential for our >> long-distance links: setting ACK timeout value based on the link distance. >> >> I found a function ath5k_hw_set_ac

Re: [ath5k-devel] ACK timeout

2009-11-21 Thread Luis R. Rodriguez
On Sat, Nov 21, 2009 at 2:14 PM, Lukáš Turek <8...@praha12.net> wrote: > Hi, > > it seems Ath5k is missing a Madwifi feature that is essential for our > long-distance links: setting ACK timeout value based on the link distance. > > I found a function ath5k_hw_set_ack_timeout, but it't not called fr

[ath5k-devel] ACK timeout

2009-11-21 Thread Lukáš Turek
Hi, it seems Ath5k is missing a Madwifi feature that is essential for our long-distance links: setting ACK timeout value based on the link distance. I found a function ath5k_hw_set_ack_timeout, but it't not called from anywhere. So only the most low-level part is there, the rest and the whole