Re: comments in make variable definition

2011-01-04 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Dec 22, 2010 at 06:17:47PM CET: [stemming from discussion about automake bug#7657: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7657] On Tuesday 21 December 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Tue, Dec 21, 2010 at 01:55:39PM CET

Re: Dependency problem (with win32 resource file and generated header)

2011-01-04 Thread Ralf Wildenhues
Hello Jef, * Jef Driesen wrote on Tue, Jan 04, 2011 at 09:54:15PM CET: In a project of mine, I generate a header file which contains the GIT commit sha1. It's generated using these rules: This works very well, but I also have a windows resource file to include a version resource in the dll.

bug#7773: (lack of) config.h description in manual

2011-01-03 Thread Ralf Wildenhues
Hello Karl, Eric, * Eric Blake wrote on Tue, Jan 04, 2011 at 01:33:42AM CET: On 01/03/2011 05:00 PM, Karl Berry wrote: Thanks for the reference. Now that I know it, I suggest the Automake manual simply have a sentence with an xref to that node. Yes, I agree with that, and I am still going

Re: [PATCH] {master} Tests: normalize use of the 'errexit' shell flag.

2011-01-03 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Jan 03, 2011 at 03:04:05PM CET: * tests/maken3.test (check_targets): Remove redundant call to 'set -e'. * tests/maken4.test: Likewise. * tests/ansi5.test: Call 'set -e' just after './defs' has been sourced. * tests/ansi6.test: Likewise. *

Re: [PATCH] {maint} Improve, extend and tweak tests on Texinfo support.

2011-01-03 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jan 03, 2011 at 02:38:48PM CET: Subject: [PATCH] Improve, extend and tweak tests on Texinfo support. * tests/instdir-texi.test: Add a call to `ls -l' after that to `make', for debugging. When looking for required tools, do not redirect the output of $tool

Re: Any way to get rid of -MP parameter to gcc for dependency creation?

2011-01-03 Thread Ralf Wildenhues
Hello Xan, thanks for the report. * Xan Lopez wrote on Tue, Jan 04, 2011 at 02:57:07AM CET: I did a profile with sysprof but I really didn't know enough of GNU make internals to figure out what was going on in detail; I can send the output to the list if you think it could be useful. At least

bug#7773: (lack of) config.h description in manual

2011-01-02 Thread Ralf Wildenhues
Hi Karl, * Karl Berry wrote on Mon, Jan 03, 2011 at 01:17:00AM CET: Following up to my own mail, No. :-) This opened a new bug report. I'm closing it, for reasons explained below. it seems I have been missing something basic all these years, since it's never come up in my own packages: in

Re: [PATCH] docs: how to work around checks on invalid primary/directory couples

2011-01-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 02, 2011 at 12:23:48PM CET: On Sunday 02 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sat, Dec 25, 2010 at 10:57:57AM CET: Ok for maint? OK with nits addressed. Do we have testsuite coverage for this? Not yet, but once

Re: [PATCH 01/10] Add new tests on strictness and warnings precedence and overriding.

2011-01-02 Thread Ralf Wildenhues
Hi Stefano, I'm not sure if I'll get through the whole series today, but I gotta start somewhere, so here we go. Feel free to push the patch series (as far as OKed) on a new branch based off of maint, if that is helpful for you. Thanks. * stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010

Re: [PATCH 02/10] New test on silent-rules mode and portability warnings.

2011-01-02 Thread Ralf Wildenhues
* stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:38PM CET: * tests/silent-rules-nowarn.test: New test. * tests/Makefile.am (TESTS): Update. How about silent-nowarn.test for consistency with the other names? OK with or without that change. Thanks, Ralf

Re: [PATCH 03/10] Warnings win over strictness on command line.

2011-01-02 Thread Ralf Wildenhues
* stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:39PM CET: 2010-12-20 Stefano Lattarini stefano.lattar...@gmail.com + Warnings win over strictness on command line. Please add a line like For PR automake/547: on a line by itself here, as done in some (older)

Re: [PATCH 12/10] More checks on warnings/strictness in precedence (metawarnings).

2011-01-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 24, 2010 at 09:21:56PM CET: More checks on warnings/strictness in precedence (metawarnings). metawarnings is not a proper word, how about just eliding the part in parentheses? Yes, I know I'm probably too picky on language; if it starts bothering you, I'll

Re: [PATCH 08/10] Add more tests about AUTOMAKE_OPTIONS.

2011-01-02 Thread Ralf Wildenhues
* stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:44PM CET: In view of soon-to-follow refactorings (still in the pursuit of a fix for Automake bug#7669 a.k.a. PR/547), we add some more tests How about s/we // on AUTOMAKE_OPTIONS support, to prevent obvious regressions. *

Re: [PATCH 12/10] More checks on warnings/strictness in precedence (metawarnings).

2011-01-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 02, 2011 at 07:49:16PM CET: On Sunday 02 January 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Fri, Dec 24, 2010 at 09:21:56PM CET: I'm not sure it works to put AM_INIT_AUTOMAKE in an included macro. Apparently it does, at least when only

bug#7763: Remake rules botch up when 'foreign' and 'ignore-deps' are removed from AM_INIT_AUTOMAKE

2011-01-01 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Thu, Dec 30, 2010 at 11:38:45PM CET: Currently, the Automake-generated rebuild rules[1] invoke automake with some command-line options derived from arguments given to AM_INIT_AUTOMAKE. [1] For more info, see:

Happy New Year!

2011-01-01 Thread Ralf Wildenhues
... and apologies for my longer than predicted time off the net. All the best to you and GNU! Pushed to maint as below. Cheers, Ralf Bump copyright years. * aclocal.in (write_aclocal, version): Bump copyright years. * automake.in (gen_copyright, version): Likewise. *

Re: [PATCH v3] Work around a bug in Solaris make's file-inclusion mechanism.

2011-01-01 Thread Ralf Wildenhues
Hi Stefano, this has since been applied to maint: * Stefano Lattarini wrote on Fri, Dec 17, 2010 at 08:46:26PM CET: Subject: [PATCH] Work around a bug in file-inclusion mechanism of Solaris make. * automake.in (handle_single_transform): In the name of the dependency file: collapse

Re: [FYI] {master} Add some tests on 'cygnus' mode

2011-01-01 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Wed, Dec 22, 2010 at 11:55:04PM CET: Attached is what I pushed (to *master* only). From 7e7a8a6497cbc2473a3e25dd1067f2d44346325e Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Tue, 21 Dec 2010 22:59:19 +0100

Re: Different flags for static and shared build of a library

2010-12-23 Thread Ralf Wildenhues
* Zdenek Hutyra wrote on Tue, Dec 21, 2010 at 09:16:07AM CET: Is it possible to specify CFLAGS different for static and shared library in .am file? lib_LTLIBRARIES = libFOO.la libFOO_la_CFLAGS = ... Not directly. If this is only about preprocessor flags, -DPIC is set for the shared lib.

Re: [FYI] distlinksbrk.test: Work around botched make -k.

2010-12-21 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Dec 21, 2010 at 03:49:49PM CET: I've applied the patch below to a temporary bug-fixing branch, merged it to maint, merged maint to master, and pushed. The testcase still works with GNU make, FreeBSD make and Solaris make, but I couldn't test if it really

bug#7670: About make implementations that don't chain implicit rules

2010-12-19 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 17, 2010 at 11:52:17PM CET: Currently, automake is quite smart in catching and taking into account possible chaining of implicit rules. [...] And here comes the problem. While the above example works correctly for at least GNU make (tested with versions

bug#7657: TEXINFOS primary accepts too many prefixes.

2010-12-19 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 17, 2010 at 12:19:40PM CET: On Friday 17 December 2010, Ralf Wildenhues wrote: For example, I can easily imagine a package having normal texinfo manuals, but also a developer's manual that maybe should end up in an internal directory elsewhere (or only

bug#7669: option foreign after -Wall turns off and portability warnings.

2010-12-19 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 17, 2010 at 07:52:29PM CET: With automake = 1.10, foreign *after* -Wall in AM_INIT_AUTOMAKE turns off portability warnings. While the current behaviour is due to various historical and implementation reasons, IMHO it is counter-intuitive and somewhat

bug#7671: Presetting various *CLEANFILES variables

2010-12-19 Thread Ralf Wildenhues
Hello Behdad, and thanks for the bug report, * Behdad Esfahbod wrote on Sat, Dec 18, 2010 at 01:55:22AM CET: If instead automake was changed to always pre-initialize *CLEANFILES variables, all snippets could just append to do variables and my git.mk snippet would be more generic and much more

Re: support for a program that compile files (like yacc or lex support)

2010-12-19 Thread Ralf Wildenhues
Hello Vincent, * Vincent Torri wrote on Sat, Dec 18, 2010 at 08:52:59PM CET: I saw in the automake doc a support for yacc and lex. I looked in automake/am/ and saw 2 files, lex.am and yacc.am, which seem to allow that support. We have a program that tranforms .edc files into .edj files, and

Re: AM_COND_IF for earlier Automake

2010-12-19 Thread Ralf Wildenhues
Hi Dave, * Dave Hart wrote on Sat, Dec 18, 2010 at 07:57:13PM CET: I did not properly integrate Ralf's latest AM_COND_IF changes considering Stefano's feedback about _AM_COND_VALUE_foo on older Automake. 3rd time's charmed? m4_ifndef([AM_COND_IF], [AC_DEFUN([AM_COND_IF],

Re: AM_COND_IF for earlier Automake

2010-12-19 Thread Ralf Wildenhues
* Dave Hart wrote on Sat, Dec 18, 2010 at 05:59:17PM CET: My package _does_ simply require Automake 1.11, as it is needed to get correct results with our nested subpackages. See this unrequited message: http://lists.gnu.org/archive/html/automake/2010-11/msg00135.html Yeah, sorry, haven't

Re: [PATCH] Test `$(var:suf=rpl)' expansion in special automake variables.

2010-12-18 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Dec 18, 2010 at 10:35:43AM CET: On Saturday 18 December 2010, Ralf Wildenhues wrote: +# Try also with `:=', to ensure the parser is not unduly confused +# into thinking that it's an unportable assignement operator. This comment is bogus, right

Re: AM_COND_IF for earlier Automake

2010-12-18 Thread Ralf Wildenhues
Hello Dave, * Stefano Lattarini wrote on Sat, Dec 18, 2010 at 11:18:04AM CET: On Saturday 18 December 2010, Dave Hart wrote: I'd like a package I depend on to use AM_COND_IF, but it does not want to demand Automake 1.11 at this point. Does this seem like a reasonable solution? BTW, I

bug#7661: docs: typo in documentation about python extension modules?

2010-12-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 17, 2010 at 02:51:12PM CET: pyexec_LTLIBRARIES = quaternion.la quaternion_SOURCES = quaternion.c support.c support.h quaternion_la_LDFLAGS = -avoid-version -module Shouldn't `quaternion_la_SOURCES' be used instead of

Re: [PATCH] Test `$(var:suf=rpl)' expansion in special automake variables.

2010-12-17 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Thu, Dec 09, 2010 at 01:46:48PM CET: Test `$(var:suf=rpl)' expansion in special automake variables. * tests/posixsubst-data.test: New test. [...] * tests/posixsubst-scripts.test: Likewise. --- /dev/null +++ b/tests/posixsubst-scripts.test @@

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 17, 2010 at 03:33:32PM CET: On Friday 17 December 2010, Ralf Wildenhues wrote: The *current* tests are good enough for the current code. Yes, but not enough if we plan to modify that code You can add tests as you go modifying the code. Doing

bug#7655: conditional _TEXINFOS should be supported

2010-12-16 Thread Ralf Wildenhues
[ no need to keep bug-automake@ in Cc:; debbugs takes care of that ] Hello Jack, * Jack Kelly wrote on Thu, Dec 16, 2010 at 08:42:52PM CET: On Fri, Dec 17, 2010 at 6:41 AM, Jack Kelly wrote: On Fri, Dec 17, 2010 at 6:09 AM, Ralf Wildenhues wrote: if COND info_TEXINFOS = foo.texi

bug#7657: TEXINFOS primary accepts too many prefixes.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 10:52:10PM CET: Currently, the TEXINFOS primary accept *all* the standard automake builtin prefix dirs (from `lib' and `bin' to `pkglibexec' and `sysconf'). IMHO it should accept only the `info' prefix (maybe also `doc'? but I'd rather say

bug#7656: MANS primary accepts too many prefixes.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 10:51:15PM CET: Currently, the MANS primary accept *all* the standard automake builtin prefix dirs (from lib and bin to pkglibexec and sysconf). IMHO it should accept only man and man{1..9} (maybe doc? but I'd rather say no). This one is

Avoid false positive in sc_tests_plain_make maintainer-check.

2010-12-16 Thread Ralf Wildenhues
I'm seeing this in master now: ../automake/tests/remake11.test:makefiles_am_list=`find . -name Makefile.am | LC_ALL=C sort` ../automake/tests/remake11.test:makefiles_list=`echo $makefiles_am_list | sed 's/\.am$//'` Do not run make in the above tests. Use $MAKE instead. Makefile:1090: recipe

Re: [PATCH] Improvements and extend tests on canonicalization.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Dec 11, 2010 at 06:41:46PM CET: Ping on this? Reference: http://lists.gnu.org/archive/html/automake-patches/2010-09/msg00106.html The updated patch is attached. I will push it in 72 hours (by tuesday evening) unless there are objections. --- /dev/null

Re: [PATCH] Improvements and extend tests on canonicalization.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 08:16:25PM CET: On Thursday 16 December 2010, Ralf Wildenhues wrote: --- a/tests/canon7.test +++ b/tests/canon7.test @@ -43,7 +43,7 @@ dummy_dynamic_SOURCES = $(dummy_static_SOURCES) dummy_static_LDADD = $(noinst_LIBRARIES

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Dec 13, 2010 at 07:54:05PM CET: OK to apply to a temporary branch off of maint, and merge to master? The patch is ok with nits addressed. BTW, notice that I'm planning to further extend the Lex/Yacc tests and make them more semantic, but that should be better

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 10:10:29PM CET: On Thursday 16 December 2010, Ralf Wildenhues wrote: BTW, notice that I'm planning to further extend the Lex/Yacc tests and make them more semantic, but that should be better done in a follow-up patch IMVHO

Re: another perl coverage run

2010-12-16 Thread Ralf Wildenhues
FWIW, I've put up coverage data for one of the runs back then at http://www.gnu.org/software/automake/coverage/coverage.html. Only the /tmp/automake and /tmp/build parts are interesting really. The rest is from the 'libtool --help' part which was still broken back then. And yes, I guess a more

bug#7655: conditional _TEXINFOS should be supported

2010-12-16 Thread Ralf Wildenhues
Severity: wishlist Conditional _TEXINFOS files should be supported, i.e., if COND info_TEXINFOS = foo.texi foo_TEXINFOS = bar.texi nodist_info_TEXINFOS = generated.texi endif should work to generate and install foo.{info,pdf,...} only if COND, but distribute foo.texi and bar.texi always.

Re: [PATCH 2/2] Extended tests on AC_CONFIG_AUX_DIR.

2010-12-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Dec 15, 2010 at 09:49:55PM CET: On Tuesday 14 December 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sat, Dec 11, 2010 at 03:00:34PM CET: Can you update this patch to not require the previous 1/2? Yes, the updated patch is attached. I

Re: [PATCH] Extend checks on remake rules.

2010-12-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 01:27:10AM CET: On Wednesday 15 December 2010, Ralf Wildenhues wrote: [ magic strings ] Why all the variation in these? That makes the tests harder to read. I'd rather not change the use of magic strings on the other remake tests, unless

Re: [PATCH] Improve tests on generated portions of configure help screen. (was: Re: [PATCH] {master} More uses of AS_HELP_STRING in automake macros.)

2010-12-14 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Tue, Dec 14, 2010 at 10:41:17AM CET: OK, I've split the patch in two parts: the first part (for maint) improves the tests on automake-generated portions of configure help screens, the second part (for master) introduces more uses of `AS_HELP_STRING' in

Re: Fix testsuite failure of check12.test without DejaGNU.

2010-12-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Dec 13, 2010 at 08:37:35PM CET: On Monday 13 December 2010, Ralf Wildenhues wrote: Fix testsuite failure of check12.test without DejaGNU. * tests/check12.test: Require runtest. JFTR, notice that I tend to have available and installed as many

Re: configmake module and automake 1.9.6

2010-12-14 Thread Ralf Wildenhues
Hello, * Eric Blake wrote on Tue, Dec 14, 2010 at 10:14:11PM CET: + configmake: support more values with older automake + * modules/configmake (Makefile.am): Provide fallbacks for older + automake. FWIW this looks safer to me because it won't regress 2.60+ setups. Cheers, Ralf

bug#7635: AC_LIBSOURCE doesn't fail as it should if AC_OUTPUT is not used

2010-12-13 Thread Ralf Wildenhues
tags 7635 wontfix close 7635 thanks * Stefano Lattarini wrote on Mon, Dec 13, 2010 at 11:35:32PM CET: If configure.ac does not contain a call to AC_OUTPUT, Automake does not fail as expected when file(s) specified in calls to macros AC_LIBSOURCE and/or AC_LIBSOURCES do not exist. See the

Re: [PATCH] {master} More uses of AS_HELP_STRING in automake macros.

2010-12-13 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Sun, Dec 12, 2010 at 02:47:35PM CET: * m4/depend.m4 (AM_DEP_TRACK): Use `AS_HELP_STRING' to format the help message added to the generated configure. * m4/dmalloc.m4 (AM_WITH_DMALLOC): Likewise. * m4/lispdir.m4 (AM_PATH_LISPDIR): Likewise. *

Re: [PATCH] {tests-init} Tests defs: de-uglify code for requiring an XSI-capable shell.

2010-12-13 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Dec 12, 2010 at 10:06:58PM CET: This is just a cosmetic patch. I will push in 72 hours (Wednesday evening) if nobody objects. Please don't. It's a feature that the code is the same as the one tested in Libtool _LT_CHECK_SHELL_FEATURES: bug-tested and all. I

Fix testsuite failure of check12.test without DejaGNU.

2010-12-13 Thread Ralf Wildenhues
Merged to master. Cheers, Ralf Fix testsuite failure of check12.test without DejaGNU. * tests/check12.test: Require runtest. diff --git a/tests/check12.test b/tests/check12.test index caa8e0f..34c8409 100755 --- a/tests/check12.test +++ b/tests/check12.test @@ -17,6 +17,7 @@ #

Re: [PATCH 0/2] Tests initialization: put default definition of AC_CONFIG_AUX_DIR in the pre-populated configure.in.

2010-12-13 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Dec 13, 2010 at 09:42:08PM CET: On Monday 13 December 2010, Ralf Wildenhues wrote: I'm undecided on this one. On the one hand, the safety increase is a plus, but on the other hand, the tests become less readable, if only because it is less obvious what

Re: [PATCH] {master} Extend and improve tests on DejaGnu support.

2010-12-10 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Dec 10, 2010 at 06:06:53PM CET: On Thursday 09 December 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sun, Nov 14, 2010 at 02:29:33PM CET: + $MAKE distcheck Can't you either omit this distcheck, or the vpath = : case above

Re: Two TESTS from the same file

2010-12-10 Thread Ralf Wildenhues
Hello Pippijn, * Pippijn van Steenhoven wrote on Thu, Dec 09, 2010 at 06:01:41AM CET: TESTS += t1075b.rexp # compiled TESTS += t1075b.texp # interpreted TEST_EXTENSIONS = .rexp .texp REXP_LOG_COMPILER = $(srcdir)/runtest TEXP_LOG_COMPILER = $(srcdir)/runtest # in case the

Re: recursive make variables coming to POSIX

2010-12-07 Thread Ralf Wildenhues
* Bruce Korb wrote on Tue, Dec 07, 2010 at 08:36:16PM CET: On 12/07/10 01:54, Schwarz, Konrad wrote: $($...@_flags) is a very useful, as it allows target-specific flags. For all targets whose name conforms to make macro name requirements. Right. But since period is allowed, only hyphen

Re: [PATCH] Extend checks on remake rules.

2010-12-05 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Dec 05, 2010 at 06:06:00PM CET: I'll wait the customary 72 hours (until wednesday evening) before pushing. This patch should have proper testing on several systems, and seems ok when tested and with nitse below addressed. If you still don't have access, please

Re: recursive make variables coming to POSIX

2010-12-05 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Thu, Dec 02, 2010 at 08:21:13PM CET: On 12/02/2010 12:10 PM, Ralf Wildenhues wrote: I'm not sure if it was mentioned before in the discussion, but portability-wise, there is a difference between one level of recursion and arbitrary many. IIRC then IRIX make

Re: recursive make variables coming to POSIX

2010-12-05 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Dec 06, 2010 at 04:50:05AM CET: IRIX 6.5 make fails over each expansion in output lines 5, 6, and 7, That should have been '4, 5, and 6'. Sorry. e.g.: v1, v1, v v1, v11, v R UX:make: ERROR: Unmatched closing curly braces or parenthesis in line

Re: [PATCHES] {master} Optimize tests `instspc-*.test' for speed.

2010-12-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 02, 2010 at 06:17:49PM CET: Since Savannah is up again now, I'm pinging this patch. Thanks. I'll wait the customary 72 hours (until sunday evening) before pushing, if there are no objections. I think this patch deserves a proper review. Sorry for the

Re: recursive make variables coming to POSIX

2010-12-02 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Thu, Dec 02, 2010 at 06:14:28PM CET: Good news! Today's Austin Group meeting included a review of http://austingroupbugs.net/view.php?id=336, which is proposing that $(var$(V)) as a way of choosing between $(var0) and $(var1) based on the contents of $(V) be

savannah git repo updated again

2010-12-01 Thread Ralf Wildenhues
Hello Stefano, all, I pushed the commits that were missing from the rewound git repo upstream again, please check that the tree matches yours, then it should be good for pushing to again. Thanks, Ralf

Re: [PATCH] {master} Improve and extend tests on `:=' variable assignments.

2010-11-29 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 29, 2010 at 09:09:59PM CET: On Monday 29 November 2010, Ralf Wildenhues wrote: I approve the patch but ask you to keep that coverage in, now you update the patch with an unrelated new change whose applicability depends on completely different factors

bug#7434: When an incorrect option is used before --help/--version, automake behaviour is inconsistent with that of other GNU programs.

2010-11-28 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Nov 26, 2010 at 06:41:20PM CET: Besides, in the particular case of automake, how often do automake or aclocal get invoked directly? To my experience, they are almost always invoked by autoreconf, ./bootstrap, or some custom autogen.sh script. (aside:

Re: [FYI] {maint} Tests: fix spurious failures in silent*.test for $CC != gcc

2010-11-28 Thread Ralf Wildenhues
silent rules, we forced the use of gcc depmode to improve testsuite coverage; but this has unsurprisingly led to spurious failures when some non-GNU C compilers were used. So we are now careful to require GCC in tests that force gcc depmode. From reports by Ralf Wildenhues. * silent5

Re: [PATCH] {master} Improve and extend tests on `:=' variable assignments.

2010-11-28 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Nov 25, 2010 at 02:37:28PM CET: The attached patch is based off of maint, and intended for master. OK to apply? With nits addressed. Thanks, Ralf Improve and extend tests on `:=' variable assignments. * tests/colneq.test: Avoid useless use of wildcards

Re: [SIMPLE PATCH] {master} Remove long-deprecated options --Werror and --Wno-error.

2010-11-27 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Nov 26, 2010 at 04:11:54PM CET: It seems the automake options `--Werror' and `--Wno-error' (kept for backward-compatibility only and, according to the git/CVS history, deprecated since commit c037f202602bf50f4e82a7f63d4624c3256df7f7, git-describe

Re: [FYI] {maint} Fix many typos in ChangeLog

2010-11-27 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Thu, Nov 25, 2010 at 12:25:47PM CET: I applied the attached patch to maint as abvious, merged into master and branch-1.11, and pushed. Thanks, also for the other patch. From 2601fd8f5688a2e9cb4c723c1c42007d3c019fca Mon Sep 17 00:00:00 2001 From:

Re: Is that a way to modify tar.m4?

2010-11-27 Thread Ralf Wildenhues
Hello, reading the conversation, most things seem to already be cleared up. Just a couple of minor points: * xufeng zhang wrote on Fri, Nov 26, 2010 at 11:47:37AM CET: On 11/26/2010 06:37 PM, Stefano Lattarini wrote: [...] enough). As Dave pointed out in a previous mail, you should: 1.

Re: on Windows, BUILT_SOURCES does not append .exe

2010-11-25 Thread Ralf Wildenhues
* Vincent Torri wrote on Mon, Nov 22, 2010 at 10:44:31PM CET: On Mon, 22 Nov 2010, Ralf Wildenhues wrote: * Dave Hart wrote on Mon, Nov 22, 2010 at 12:34:47AM CET: In that case you may need to add cmap_tounicode.c to BUILT_SOURCES, leaving cmapdump out of same. That shouldn't be necessary

reword documentation about symbol stripping (was: default -g ??!?)

2010-11-21 Thread Ralf Wildenhues
-in-cheek? May we have a real name please to credit in the ChangeLog entry? Thanks, Ralf 2010-11-21 Ralf Wildenhues ralf.wildenh...@gmx.de * doc/make-stds.texi (Standard Targets): Reword recommendations about debug symbols and stripping executables. Suggested by MK

Re: on Windows, BUILT_SOURCES does not append .exe

2010-11-21 Thread Ralf Wildenhues
Hello Vincent, * Vincent Torri wrote on Sun, Nov 21, 2010 at 10:51:53PM CET: noinst_PROGRAMS = cmapdump fontdump BUILT_SOURCES = cmapdump fontdump With MSYS, noinst_PROGRAMS is set to cmapdump$(EXEEXT) fontdump$(EXEEXT) but BUILT_SOURCES is set to cmapdump fontdump Is it normal

Re: on Windows, BUILT_SOURCES does not append .exe

2010-11-21 Thread Ralf Wildenhues
* Vincent Torri wrote on Sun, Nov 21, 2010 at 11:14:23PM CET: noinst_PROGRAMS = cmapdump cmapdump_SOURCES = mupdf-0.7/mupdf/cmapdump.c noinst_LTLIBRARIES = libfitz.la libdraw.la libcmaps.la libfonts.la libmupdf.la cmap_tounicode_files = \ mupdf-0.7/cmaps/Adobe-CNS1-UCS2 \ [...]

Re: on Windows, BUILT_SOURCES does not append .exe

2010-11-21 Thread Ralf Wildenhues
* Dave Hart wrote on Mon, Nov 22, 2010 at 12:34:47AM CET: On Sun, Nov 21, 2010 at 22:44 UTC, Vincent Torri vto...@univ-evry.fr wrote: On Sun, 21 Nov 2010, Ralf Wildenhues wrote: * Vincent Torri wrote on Sun, Nov 21, 2010 at 11:14:23PM CET: If I don't use BUILT_SOURCES, cmapdump binary

bug#7403: Unused variable `$source' in the depcomp script?

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 01:03:04AM CET: $ grep '\source\' lib/depcomp source Source file read by `PROGRAMS ARGS'. if test -z $depmode || test -z $source || test -z $object; then echo depcomp: Variables source, object and depmode must be set 12 #

bug#7403: Unused variable `$source' in the depcomp script?

2010-11-20 Thread Ralf Wildenhues
tags 7403 wontfix close 7403 * Stefano Lattarini wrote on Sat, Nov 20, 2010 at 02:10:41PM CET: Makes sense. You can close the bug if you want (maybe with tag wontfix?) You can also do that yourself if you like. Just put control at debbugs in Bcc: for commands like above. Cheers, Ralf

Re: [RFC] Docs: document silent make rules in a new chapter

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Nov 18, 2010 at 09:22:48PM CET: On Thursday 18 November 2010, Nick Bowler wrote: On 2010-11-18 20:31 +0100, Stefano Lattarini wrote: +...@vindex @code{AM_V_GEN} +...@c FIXME: wouldn't $(AM_V_SILENT) be clearer? Should we deprecate +...@c $(AM_V_at)?

libtool --help: honor $AUTOCONF, $AUTOMAKE

2010-11-20 Thread Ralf Wildenhues
I came across an interesting bug: the perl coverage output for a full run of the Automake test suite was showing a single invocation of the installed automake program, rather than the uninstalled $builddir/tests/automake-1.11a which should have been run. Some tracking revealed that this

Re: [PATCH] {maint} Improve and extend tests on de-ansification support.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Nov 16, 2010 at 12:15:12AM CET: On Monday 15 November 2010, Ralf Wildenhues wrote: Well then we should adjust maintainer-check to not complain. Either way, maintainer-check results should not deteriorate. I'm not keen on meddling with the current

Re: [PATCH 4/5] Tests defs: avoid some useless subshells.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET: * tests/defs: In the loop on $required tools: avoid subshells where not neded. OK except for the last hunk: --- a/tests/defs +++ b/tests/defs @@ -297,12 +297,12 @@ do *) # Generic case: the tool must support

Re: [PATCH 5/5] Tests required tools: also try `-v' option for GNU compilers.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:27:43PM CET: * tests/defs.in: In the loop on $required tools, for gcc and g++, also run gcc -v (resp. g++ -v), to get more information, and for consistency with gcj. Did this help you for anything in any way? Patch is OK. Thanks, Ralf

Re: [PATCH 0/5] More patches for the tests-init branch

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:18:15PM CET: Tests defs: don't let useless variables leak in test scripts. Tests defs: new subroutine `skip' for test skipping. Tests defs: some cleanup and minor fixes. No ticking clock for this patches at the moment; the clock will

Re: [PATCH 4/5] Tests defs: avoid some useless subshells.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Nov 20, 2010 at 02:14:57PM CET: On Saturday 20 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET: # Generic case: the tool must support --version. echo $me: running $tool --version

Re: [RFC] Docs: document silent make rules in a new chapter

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Nov 18, 2010 at 09:22:48PM CET: On Thursday 18 November 2010, Nick Bowler wrote: On 2010-11-18 20:31 +0100, Stefano Lattarini wrote: +...@vindex @code{AM_V_GEN} +...@c FIXME: wouldn't $(AM_V_SILENT) be clearer? Should we deprecate +...@c $(AM_V_at)?

another perl coverage run

2010-11-20 Thread Ralf Wildenhues
Hello automake list readers, Stefano asked for coverage information about Automake recently, so I triggered another 'make check-coverage' on my system, held hands of Devel::Cover a bit, waited a looong time, then collected the results. They are in a set of HTML pages roughly 500K size, the

Re: another perl coverage run

2010-11-20 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, Nov 20, 2010 at 10:28:17AM CET: Stefano asked for coverage information about Automake recently, so I triggered another 'make check-coverage' on my system, held hands of Devel::Cover a bit, waited a looong time, then collected the results. They are in a set

Re: [RFC] Docs: document silent make rules in a new chapter

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Nov 20, 2010 at 01:00:05PM CET: ... I'm fine with this; I'll just rewrite the fixme comment to reference the thread above and to be more possibilist: @c FIXME: Could we find a better name than $(AM_V_at)? $(AM_V_SILENT) @c is nice, but also a bit too

Re: default -g ??!?

2010-11-20 Thread Ralf Wildenhues
Hello, * MK wrote on Fri, Nov 19, 2010 at 08:10:25PM CET: Since I could not find a way to prevent the project being built -g, and there is no need for this. ./configure CFLAGS=-O2 See 'info Autoconf C Compiler'. For C++ use CXXFLAGS etc. Cheers, Ralf

Re: default -g ??!?

2010-11-20 Thread Ralf Wildenhues
* Raphael 'kena' Poss wrote on Sat, Nov 20, 2010 at 04:47:00PM CET: Op 20 nov 2010, om 16:36 heeft MK het volgende geschreven: Maybe there is a way to do this via autoconf? Yes, you can place: CFLAGS= at the beginning of your configure.ac, after AM_INIT_AUTOMAKE but before

Re: another perl coverage run

2010-11-20 Thread Ralf Wildenhues
Updated summary including the 'libtool --help' fixes, shortened file names, and without listing the installed files from Autoconf. The Total percentages still include them however. filestmt bran cond subpodtime total

Re: default -g ??!?

2010-11-20 Thread Ralf Wildenhues
* MK wrote on Sat, Nov 20, 2010 at 09:55:51PM CET: Maybe so, and maybe not. But regardless: it makes more sense to have the default *appropriate for general use*, rather for a distro packager (who's work I do appreciate!). Otherwise, I have to put a note in the INSTALL: To accommodate the

bug#7441: 1.11.1: Emacs files in subdirs

2010-11-19 Thread Ralf Wildenhues
Hi Akim, * Akim Demaille wrote on Fri, Nov 19, 2010 at 10:14:31AM CET: When passing _LISP files with a path, Automake produces schizophrenic Makefiles that expects the elc files to have the same path too, but produces elc files in `.'. Yes. I asked the necessary questions a while ago:

Re: [PATCH] New test on repeated automake options.

2010-11-19 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Nov 19, 2010 at 12:26:18PM CET: * tests/repeated-options.test: New test, check that automake does not complain on repeated options, nor generate broken or incorrect makefiles. * tests/Makefile.am (TESTS): Updated. OK. Thanks, Ralf

Sync config-ml.in from GCC.

2010-11-19 Thread Ralf Wildenhues
I pushed this to maint in Ian's name, to sync the script from GCC. Cheers, Ralf 2010-11-19 Ian Lance Taylor i...@... Sync config-ml.in from GCC. * config-ml.in: Add Go support: treat GOC and GOCFLAGS like other compiler/flag environment variables. diff --git

Re: [PATCH] {master} release-stats: account for generated `instspc-*.test' tests.

2010-11-19 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Nov 19, 2010 at 09:18:33PM CET: I've realized that my patch on instspc.test split refactoring has broken the release-stats target, since now there are other generated tests besides the `*-p.test' tests. The attached patch fix this glitch in a quick dirty

bug#7434: When an incorrect option is used before --help/--version, automake behaviour is inconsistent with that of other GNU programs.

2010-11-18 Thread Ralf Wildenhues
Hello, * Stefano Lattarini wrote on Thu, Nov 18, 2010 at 05:28:30PM CET: On Thursday 18 November 2010, Eric Blake wrote: On 11/18/2010 08:22 AM, Stefano Lattarini wrote: Currently, automake and aclocal scan their command line looking for `--help' and `--version' even after an invalid

Re: [PATCHES] Fix spurious failures of some tests `silent*.test' with SunStudio Fortran

2010-11-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Nov 17, 2010 at 07:25:32PM CET: On Wednesday 17 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Wed, Nov 17, 2010 at 03:25:02PM CET: F77bar.o NOTICE: Invoking /opt/SunStudio/sunstudio12.1/prod/bin/f90 -f77 -ftrap=%none -g -c

Re: [PATCHES] Fix spurious Lex/Yacc-related failures in tests `silent*.test' w.r.t. Solaris XPG4 make.

2010-11-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Nov 17, 2010 at 09:10:08PM CET: I'm seeing this failure with Solaris XPG4 make: $ MAKE=/usr/xpg4/bin/make sh silentyacc.test silentyacc: running bison --version bison (GNU Bison) 2.4.1 Written by Robert Corbett and Richard Stallman. [...] A similar

Re: Testsuite failures on AIX 5.3

2010-11-16 Thread Ralf Wildenhues
by setting the `$(SHELL)' macro on the command line of make, but this is not supported by the AIX 5.3 make implementation. This bug has been lurking for a long time, and was activated by commit v1.11-125-gc1f6cdb Enable `errexit' shell flag in various tests. Report by Ralf Wildenhues. [...]

Re: [SIMPLE PATCH] {master} Be more consistent in copyright notices.

2010-11-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Nov 17, 2010 at 12:22:57AM CET: While modifying the test script `suffix13.test' recently, I noticed that it uses an obsolete form of copyright notice: # This file is part of GNU Automake. # # GNU Automake is free software; you can redistribute it and/or

Re: When aclocal causes an error message, sed: invalid option -- 'q'

2010-11-16 Thread Ralf Wildenhues
Hi Bruce, * Bruce Korb wrote on Tue, Nov 16, 2010 at 09:37:51PM CET: What is it really trying to say? I'm not a real perl expert.Thank you! $ autoreconf --force --install --verbose --symlink autoreconf: Entering directory `.' autoreconf: configure.ac: not using Gettext autoreconf:

<    1   2   3   4   5   6   7   8   9   10   >