Looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 12 October 2016 20:11
To: Ajit Ghaisas; Alexander Scherbatiy; awt-dev@openjdk.java.net
Subject: Re: [9] Fix for JDK-8166980 : JCK testing of
Window.setIconImage() leads to VM crash starting approx
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.10/
Updates: Updated launcher.properties as suggested.
Regards,
Rajeev Chamyal
From: Philip Race
Sent: 21 September 2016 02:41
To: Rajeev Chamyal
Cc: Alexander Scherbatiy; awt-dev
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.09/
Updates:
Updated documentation in
src/java.desktop/share/classes/java/awt/SplashScreen.java
Review comments from Kumar are also updated in launcher.properties.
Regards,
Rajeev Chamyal
Hello Kumar,
Thanks for the review.
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.09/
Updates:
1) Updated launcher properties.
2) Corrected indentation in splashscreen_impl.c
Regards,
Rajeev Chamyal
-Original Message-
From: Kumar Srinivasan
Hello Kumar,Phil,
Please review the update updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.08/
Updates in files :
src/java.base/share/classes/sun/launcher/resources/launcher.properties
src/java.desktop/share/classes/java/awt/SplashScreen.java
Regards,
Rajeev Chamyal
Hello Alexander,
Thanks for the review.I have updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8149371/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 05 September 2016 16:04
To: Rajeev Chamyal; Sergey Bylokhov; awt-dev@openjdk.java.net
SunToolkit:getScaledIconImage to extract
appropriate Multiresolution image and consider it in the existing algorithm for
finding best image.
Java doc for Window:setIconImages is also updated.
Regards,
Rajeev Chamyal
Hello Kumar,
I have further updated launcher.properties.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.07/
For documentation update I have already raise a bug.
https://bugs.openjdk.java.net/browse/JDK-8165009
Regards,
Rajeev Chamyal
-Original Message-
From: Kumar Srinivasan
Sent
Hello Kumar,
Can you please review the updated
src/java.base/share/classes/sun/launcher/resources/launcher.properties
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.06/
Regards,
Rajeev Chamyal
-Original Message-
From: Philip Race
Sent: 27 August 2016 03:10
To: Rajeev Chamyal
Cc
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.05/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 25 August 2016 22:07
To: Rajeev Chamyal; Philip Race
Cc: awt-dev@openjdk.java.net; Sergey Bylokhov
Hello Alexandr,
As per the mail link the procedure is applicable for JEPs and small
enhancements.
http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-June/004443.html
But the issue under review is a bug.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 25
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.04/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 22 August 2016 16:44
To: Philip Race
Cc: awt-dev@openjdk.java.net; Sergey Bylokhov; Alexander Scherbatiy
Subject
/native/libsplashscreen/splashscreen_config.h
Regards,
Rajeev Chamyal
-Original Message-
From: Phil Race
Sent: 20 August 2016 01:47
To: Rajeev Chamyal
Cc: awt-dev@openjdk.java.net; Sergey Bylokhov; Alexander Scherbatiy
Subject: Re: [9] Review Request JDK-8151787 Unify the
HiDPI splash
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.03/
Updated file
src/java.base/share/classes/sun/launcher/resources/launcher.properties
Added all other supported name extensions.
Regards,
Rajeev Chamyal
From: Philip Race
Sent: 19
Hello Phil,
Thanks for the review.
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.02/
Updated file
src/java.base/share/classes/sun/launcher/resources/launcher.properties
Regards,
Rajeev Chamyal
From: Phil Race
Sent: 16 August 2016 22:28
plash on screen on these.
i.e. if system resolution is 1920 X 1080(i.e. unscaled resolution) on windows
and linux we use this for centring the splash on screen. For mac scaled
resolution is used directly.
Regards,
Rajeev Chamyal
From: Alexander Scherbatiy
Sent: 11 August 2016 14:44
To:
component but for choice
it's called.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 28 July 2016 14:21
To: Rajeev Chamyal; Alexander Scherbatiy; awt-dev@openjdk.java.net
Subject: Re: [9] Review Request JDK-8144594 HiDPI: awt.Choice looks
improperly (Win 8)
Hello Sergey,
This issue is not there with AwtList.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 21 July 2016 14:48
To: Rajeev Chamyal; Alexander Scherbatiy; awt-dev@openjdk.java.net
Subject: Re: [9] Review Request JDK-8144594 HiDPI: awt.Choice looks
Looks good to me.
Regards,
Rajeev Chamyal
From: Prem Balakrishnan
Sent: 21 July 2016 16:03
To: Rajeev Chamyal; Alexander Scherbatiy; awt-dev@openjdk.java.net
Subject: RE: Review Request: JDK-8144709 [hidpi] [TestBug]
java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java,
java/awt
Hello Prem,
Frame should be disposed on exceptions.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 20 July 2016 17:36
To: Prem Balakrishnan; Rajeev Chamyal; awt-dev@openjdk.java.net
Subject: Re: Review Request: JDK-8144709 [hidpi] [TestBug]
java/awt/GridLayout
from the fonts. Scaled the font height to
fix the issue.
Regards,
Rajeev Chamyal
Looks fine to me.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 14 July 2016 20:45
To: Manajit Halder
Cc: awt-dev@openjdk.java.net; Avik Niyogi
Subject: Re: [9] Review request for JDK-8160266: [macosx]
NestedModalDialogTest.java and NestedModelessDialogTest.java tests does
Looks good to me.
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 23 June 2016 12:07
To: Ambarish Rapte; Prasanta Sadhukhan; Sergey Bylokhov; Alexander Scherbatiy;
awt-dev@openjdk.java.net
Subject: Re: Review request for 8151588: Press the button first two
times, the 'First
Looks fine.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 05 May 2016 16:01
To: Ambarish Rapte; Semyon Sadetsky; Prasanta Sadhukhan; Ajit Ghaisas;
awt-dev@openjdk.java.net
Subject: Re: Review fix for 8154328: [TEST_BUG]
java/awt/TrayIcon/ActionEventTest
Looks fine.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 04 May 2016 20:13
To: Ambarish Rapte; Semyon Sadetsky; Prasanta Sadhukhan; Rajeev Chamyal;
awt-dev@openjdk.java.net
Subject: Re: Review request for 8155742 : [Windows]
robot.keyPress
Updated Webrev link:
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.04/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 02 May 2016 14:24
To: Hendrik Schreiber
Cc: awt-dev@openjdk.java.net; Avik Niyogi
Subject: Re: [9] Review request for JDK-8151787 Unify
) is supported. So, scale
factor can be a floating point value e.g. for a screen with dpi value of 120
the scale factor would be 1.25.
Regards,
Rajeev Chamyal
-Original Message-
From: Hendrik Schreiber [mailto:h...@tagtraum.com]
Sent: 02 May 2016 13:55
To: Rajeev Chamyal
Cc: Ambarish
Hello All,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.03/
Added launcher.properties file to webrev.
Updated the command line description for -splash: option.
Regards,
Rajeev Chamyal
From: Ambarish Rapte
Sent: 02 May 2016 12:01
To
Looks good to me.
Regards,
Rajeev Chamyal
From: Ambarish Rapte
Sent: 28 April 2016 22:26
To: Prasanta Sadhukhan; awt-dev@openjdk.java.net
Subject: Re: Review request for 6384991: TrayIcon ActionListener
called at wrong time
Hi Prasanta,
Thanks for the review
I have updated the
and
other parameters to new method findScaledImageName are constants.
- Could you add the use case where both @2x and java-scale2x are provided and
@2x is chosen in the test?
I have updated the test as suggested.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 28 April
Hello Alexandr,
Please review the updated fix.
http://cr.openjdk.java.net/~rchamyal/8151787/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 26 April 2016 14:22
To: Rajeev Chamyal; awt-dev@openjdk.java.net; Sergey Bylokhov
Subject: Re: [9] Review request for
name : image.ext
Scaled image name : image.java-scale2x.ext
Naming convention on windows :
Image name : image.ext
Scaled image name : image.java-scale.ext
Regards,
Rajeev Chamyal
Hello Alexandr,
I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.06/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 22 March 2016 20:15
To: Rajeev Chamyal; Sergey Bylokhov; awt-dev@openjdk.java.net
.
Fix: Allocating a max scaled image name length buffer in java.c and passing it
to splashscreen_sys.c
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 15 March 2016 18:26
To: Alexander Scherbatiy; Sergey Bylokhov; awt-dev@openjdk.java.net;
build-...@openjdk.java.net
x was successful.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 14 March 2016 17:28
To: Rajeev Chamyal
Cc: Sergey Bylokhov; awt-dev@openjdk.java.net
Subject: Re: [9] Review request for JDK-8145173 HiDPI splash screen
support on Windows
On 3/14/2016 8:
Hello Sergey,
Could you please review the enhancement.
I have raised a new enhancement for unifying the splash screen image names
across platforms.
https://bugs.openjdk.java.net/browse/JDK-8151787
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 March 2016 18:46
To
Hello Alexandr,
Thanks for the review. Below is the updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.03/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 March 2016 11:39
To: Rajeev Chamyal; awt-dev@openjdk.java.net; Sergey
Hello Sergey,
Thanks for the review.
HiDpi is not supported for Solaris in jdk. I will raise a new CR for naming
convention shortly.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 10 March 2016 15:49
To: Alexandr Scherbatiy; Rajeev Chamyal; awt-dev
Hello All,
Please review the updated webrev.
Added a free call for duplicate file name in splashscreen_sys.c ::
SplashGetScaledImageName
http://cr.openjdk.java.net/~rchamyal/8145174/webrev.03/
Regards,
Rajeev Chamyal
From: Rajeev Chamyal
Sent: 01 March 2016 13:33
To: Alexander
Hello All,
Please review the updated webrev.
Added a free call for duplicate file name in splashscreen_sys.c ::
SplashGetScaledImageName
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.02/
Regards,
Rajeev Chamyal
From: Rajeev Chamyal
Sent: 01 March 2016 15:45
To: awt-dev
Hello All,
Gentle reminder.
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.01/
Regards,
Rajeev Chamyal
From: Rajeev Chamyal
Sent: 16 February 2016 16:01
To: awt-dev@openjdk.java.net; Sergey Bylokhov; Alexander Scherbatiy
Subject: [9] Review
Hello Alexandr,
Thanks for the review. I have updated code as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145174/webrev.02/
Regards,
Rajeev Chamyal
From: Alexander Scherbatiy
Sent: 29 February 2016 14:24
To: Rajeev Chamyal
Cc: awt-dev@openjdk.java.net; Sergey
one image.java-scale2x.ext file instead to have
HYPERLINK "mailto:im...@2x.ext"im...@2x.ext on Mac OS X and name.scale-200.ext
on Windows.
For windows we can have scale factor as float value so it would be
difficult to identify which image name to be displayed.
Regards,
Raje
naming convention followed for scaled image name is as follows:
Refer : https://msdn.microsoft.com/en-us/library/windows/apps/xaml/hh965325.aspx
Unscaled image name : image.ext
Scaled image name : image.scale-.ext
Regards,
Rajeev Chamyal
.
1) splashscreen_impl.c::SplashInit() was resetting the scaleFactor to 1.
2) SplashScreen.java:: getBounds fixed the typo.
Regards,
Rajeev Chamyal
Looks fine to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 30 December 2015 19:22
To: Ambarish Rapte; Rajeev Chamyal; Semyon Sadetsky; Prasanta Sadhukhan;
awt-dev@openjdk.java.net
Subject: Re: Review reuest for 8146168: [TEST_BUG] instability of
java/awt
jeev Chamyal
From: Ambarish Rapte
Sent: 29 December 2015 10:58
To: Semyon Sadetsky; Prasanta Sadhukhan; Rajeev Chamyal;
awt-dev@openjdk.java.net
Subject: Review reuest for 8146168: [TEST_BUG] instability of
java/awt/Frame/MaximizedToMaximized/MaximizedToMaximized.java
Hi All,
Please review
Fix looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Ambarish Rapte
Sent: 23 December 2015 01:32
To: Ambarish Rapte; Rajeev Chamyal; Sergey Bylokhov; Semyon Sadetsky; Prasanta
Sadhukhan; awt-dev@openjdk.java.net
Subject: RE: Review request for 8041928
Hello Ambarish,
The test instruction window is not getting closed after the test timeout on
pressing close button/Ctrl-C.
Regards,
Rajeev Chamyal
-Original Message-
From: Ambarish Rapte
Sent: 22 December 2015 14:08
To: Sergey Bylokhov; Semyon Sadetsky; Prasanta Sadhukhan;
awt-dev
Hello Avik,
As the test case is manual. Can you add some timeout for it.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 19 November 2015 16:36
To: Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net
Subject: Review request for 8019280: CFileDialog selection button on
Hello All,
I need one more review for this bug.
Can someone please review it.
http://cr.openjdk.java.net/~psadhukhan/rajeev/8037575/webrev.00/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 11 November 2015 19:57
To: Rajeev Chamyal
Cc: Sergey Bylokhov
51 matches
Mail list logo
