Re: RFR: Allow using a system installed libpng

2014-02-21 Thread Victor D'yakov
Added 2D Victor On 21.02.2014 16:00, Alan Bateman wrote: On 21/02/2014 11:43, Anthony Petrov wrote: Hi Andrew, "Client code" is basically anything in 2D, AWT, i18n, beans, a11y, ImageIO, Sound, or Swing. I.e., anything related to GUI/desktop. In this particular case Omair is changing the S

Re: RFR: Allow using a system installed libpng

2014-02-21 Thread Alan Bateman
On 21/02/2014 11:43, Anthony Petrov wrote: Hi Andrew, "Client code" is basically anything in 2D, AWT, i18n, beans, a11y, ImageIO, Sound, or Swing. I.e., anything related to GUI/desktop. In this particular case Omair is changing the SplashScreen code which belongs to AWT, hence the choice of

Re: RFR: Allow using a system installed libpng

2014-02-21 Thread Anthony Petrov
Hi Andrew, "Client code" is basically anything in 2D, AWT, i18n, beans, a11y, ImageIO, Sound, or Swing. I.e., anything related to GUI/desktop. In this particular case Omair is changing the SplashScreen code which belongs to AWT, hence the choice of the client repo for integration. -- best r

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Omair Majid
* Magnus Ihse Bursie [2014-02-20 05:35]: > From my point of view, you can go either way. The changes are mostly > in the build code, except for an include statement. But if the AWT > folks feel more confident that way, sure, you can go via client. Pushed: http://hg.openjdk.java.net/jdk9/client/re

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Andrew Hughes
- Original Message - > Hi Omair, > > > Should I be pushing this to jdk9/dev ? (Or to jdk9/client?) > > If you change client code, then the fix should go to the client repo to > avoid merge conflicts and allow for more manual testing prior to > integrating the changes into the master repo.

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Magnus Ihse Bursie
On 2014-02-20 09:47, Anthony Petrov wrote: Hi Omair, Should I be pushing this to jdk9/dev ? (Or to jdk9/client?) If you change client code, then the fix should go to the client repo to avoid merge conflicts and allow for more manual testing prior to integrating the changes into the master r

Re: RFR: Allow using a system installed libpng

2014-02-20 Thread Anthony Petrov
Hi Omair, Should I be pushing this to jdk9/dev ? (Or to jdk9/client?) If you change client code, then the fix should go to the client repo to avoid merge conflicts and allow for more manual testing prior to integrating the changes into the master repo. -- best regards, Anthony On 2/19/201

Re: RFR: Allow using a system installed libpng

2014-02-19 Thread Iris Clark
ponsor/ See the last sentence of step 3 and all of step 4. Thanks, iris -Original Message- From: Omair Majid [mailto:oma...@redhat.com] Sent: Wednesday, February 19, 2014 8:16 AM To: Magnus Ihse Bursie Cc: awt-dev; build-dev; Erik Joelsson Subject: Re: RFR: Allow using a system installed

Re: RFR: Allow using a system installed libpng

2014-02-19 Thread Omair Majid
* Magnus Ihse Bursie [2014-02-19 06:59]: > On 2014-02-17 10:16, Erik Joelsson wrote: > >At least to me this looks good, but better let Magnus and Andrew > >have their say too. > > Looks good to me! Thanks for the reviews, everyone! I have filed https://bugs.openjdk.java.net/browse/JDK-8035341 t

Re: RFR: Allow using a system installed libpng

2014-02-19 Thread Magnus Ihse Bursie
On 2014-02-17 10:16, Erik Joelsson wrote: At least to me this looks good, but better let Magnus and Andrew have their say too. Looks good to me! /Magnus

Re: RFR: Allow using a system installed libpng

2014-02-18 Thread Andrew Hughes
- Original Message - > * Erik Joelsson [2014-02-17 04:16]: > > At least to me this looks good, but better let Magnus and Andrew > > have their say too. > This looks fine. > Feedback from an AWT expert would be appreciated too! > I'm not sure why this is needed, given it doesn't really

Re: RFR: Allow using a system installed libpng

2014-02-18 Thread Omair Majid
* Sergey Bylokhov [2014-02-18 12:35]: > cc 2d alias also. > > The fix looks good. I am curious who will document all new options > in README-builds.html? One thing I have always loved about autotools is self documentation. With this patch, for example, ./configure --help gives me the new option

Re: RFR: Allow using a system installed libpng

2014-02-18 Thread Sergey Bylokhov
cc 2d alias also. The fix looks good. I am curious who will document all new options in README-builds.html? On 14.02.2014 21:27, Omair Majid wrote: * Andrew Hughes [2014-02-13 23:59]: As I said in the previous e-mail, the minimum I'd be happy with is if the current patch was updated so sett

Re: RFR: Allow using a system installed libpng

2014-02-18 Thread Omair Majid
* Erik Joelsson [2014-02-17 04:16]: > At least to me this looks good, but better let Magnus and Andrew > have their say too. Feedback from an AWT expert would be appreciated too! Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 664

Re: RFR: Allow using a system installed libpng

2014-02-17 Thread Erik Joelsson
At least to me this looks good, but better let Magnus and Andrew have their say too. /Erik On 2014-02-14 18:27, Omair Majid wrote: * Andrew Hughes [2014-02-13 23:59]: As I said in the previous e-mail, the minimum I'd be happy with is if the current patch was updated so settings weren't being

Re: RFR: Allow using a system installed libpng

2014-02-14 Thread Omair Majid
* Andrew Hughes [2014-02-13 23:59]: > As I said in the previous e-mail, the minimum I'd be happy with is if > the current patch was updated so settings weren't being hardcoded into > the makefiles. Passing them from configure would be sufficient for now, > then it can be replaced by PKG_CONFIG. H

Re: RFR: Allow using a system installed libpng

2014-02-13 Thread Andrew Hughes
- Original Message - > Hi, > > * Magnus Ihse Bursie [2014-02-12 17:49]: > > > > On 2014-02-12 18:47, Andrew Hughes wrote: > > >>To be extremely clear: Andrew, do you object to bringing Omairs patch, > > >>as it is, into OpenJDK? > > >> > > >Yes. > > > > Okay then. > > > > I'll put a

Re: RFR: Allow using a system installed libpng

2014-02-13 Thread Andrew Hughes
- Original Message - > > On 2014-02-12 18:47, Andrew Hughes wrote: > >> To be extremely clear: Andrew, do you object to bringing Omairs patch, > >> as it is, into OpenJDK? > >> > > Yes. > > Okay then. > > I'll put a mental note to revisit libpng when cleaning up libraries.m4. > Are we

Re: RFR: Allow using a system installed libpng

2014-02-12 Thread Omair Majid
Hi, * Magnus Ihse Bursie [2014-02-12 17:49]: > > On 2014-02-12 18:47, Andrew Hughes wrote: > >>To be extremely clear: Andrew, do you object to bringing Omairs patch, > >>as it is, into OpenJDK? > >> > >Yes. > > Okay then. > > I'll put a mental note to revisit libpng when cleaning up > librarie

Re: RFR: Allow using a system installed libpng

2014-02-12 Thread Magnus Ihse Bursie
On 2014-02-12 18:47, Andrew Hughes wrote: To be extremely clear: Andrew, do you object to bringing Omairs patch, as it is, into OpenJDK? Yes. Okay then. I'll put a mental note to revisit libpng when cleaning up libraries.m4. Are we in agreement that it should to the following: --with-libp

Re: RFR: Allow using a system installed libpng

2014-02-12 Thread Andrew Hughes
- Original Message - > On 2014-02-10 18:43, Andrew Hughes wrote: > > You're already using it: > > > > PKG_CHECK_MODULES([LIBFFI], [libffi]) > > > > Why that's in LIB_SETUP_STATIC_LINK_LIBSTDCPP, I have no idea. > Because libraries.m4 is in need of a long overdue cleanup. :-( > > > >> * Seco

Re: RFR: Allow using a system installed libpng

2014-02-11 Thread Magnus Ihse Bursie
On 2014-02-10 18:43, Andrew Hughes wrote: You're already using it: PKG_CHECK_MODULES([LIBFFI], [libffi]) Why that's in LIB_SETUP_STATIC_LINK_LIBSTDCPP, I have no idea. Because libraries.m4 is in need of a long overdue cleanup. :-( * Second, I believe the original intention was to allow for

Re: RFR: Allow using a system installed libpng

2014-02-10 Thread Andrew Hughes
- Original Message - > On 2014-02-05 16:15, Omair Majid wrote: > > * Andrew Hughes [2014-02-04 19:26]: > >>> On 2014-02-03 18:43, Omair Majid wrote: > The following webrevs modify the build system to allow building against > the system-installed copy of libpng as well as using

Re: RFR: Allow using a system installed libpng

2014-02-07 Thread Magnus Ihse Bursie
On 2014-02-05 16:15, Omair Majid wrote: * Andrew Hughes [2014-02-04 19:26]: On 2014-02-03 18:43, Omair Majid wrote: The following webrevs modify the build system to allow building against the system-installed copy of libpng as well as using the bundled copy of libpng ROOT: http://cr.openjdk.j

Re: RFR: Allow using a system installed libpng

2014-02-06 Thread Andrew Hughes
- Original Message - > * Andrew Hughes [2014-02-04 19:26]: > > > On 2014-02-03 18:43, Omair Majid wrote: > > > > The following webrevs modify the build system to allow building against > > > > the system-installed copy of libpng as well as using the bundled copy > > > > of > > > > libpng

Re: RFR: Allow using a system installed libpng

2014-02-05 Thread Omair Majid
* Andrew Hughes [2014-02-04 19:26]: > > On 2014-02-03 18:43, Omair Majid wrote: > > > The following webrevs modify the build system to allow building against > > > the system-installed copy of libpng as well as using the bundled copy of > > > libpng > > > > > > ROOT: http://cr.openjdk.java.net/~om

Re: RFR: Allow using a system installed libpng

2014-02-04 Thread Andrew Hughes
- Original Message - > > On 2014-02-03 18:43, Omair Majid wrote: > > Hi, > > > > The following webrevs modify the build system to allow building against > > the system-installed copy of libpng as well as using the bundled copy of > > libpng > > > > ROOT: http://cr.openjdk.java.net/~omaji

Re: RFR: Allow using a system installed libpng

2014-02-03 Thread David Holmes
On 4/02/2014 7:51 AM, Magnus Ihse Bursie wrote: On 2014-02-03 21:44, Omair Majid wrote: Whoops. Updated webrevs: root: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02/ jdk: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02-jdk/ Due to this, I'd like to ask you to please

Re: RFR: Allow using a system installed libpng

2014-02-03 Thread Magnus Ihse Bursie
On 2014-02-03 21:44, Omair Majid wrote: Whoops. Updated webrevs: root: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02/ jdk: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02-jdk/ Due to this, I'd like to ask you to please double check that --with-libpng=system | bundled

Re: RFR: Allow using a system installed libpng

2014-02-03 Thread Omair Majid
* Magnus Ihse Bursie [2014-02-03 14:42]: > > On 2014-02-03 18:43, Omair Majid wrote: > >Hi, > > > >The following webrevs modify the build system to allow building against > >the system-installed copy of libpng as well as using the bundled copy of > >libpng > > > >ROOT: http://cr.openjdk.java.net/

Re: RFR: Allow using a system installed libpng

2014-02-03 Thread Magnus Ihse Bursie
On 2014-02-03 18:43, Omair Majid wrote: Hi, The following webrevs modify the build system to allow building against the system-installed copy of libpng as well as using the bundled copy of libpng ROOT: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01/ JDK: http://cr.openjdk.java.net

RFR: Allow using a system installed libpng

2014-02-03 Thread Omair Majid
Hi, The following webrevs modify the build system to allow building against the system-installed copy of libpng as well as using the bundled copy of libpng ROOT: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01/ JDK: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01-jdk/ A n