Re: Multiple deployers in axis2.xml

2008-11-05 Thread Deepal jayasinghe
> > As I mentioned earlier this is about how people think about it. So I > think one way and > you think in another way :). > Therefore if more people think that the current way is good enough > lets keep it in that way. If more > people want a change then do it in that way. Since this is a commun

Re: Multiple deployers in axis2.xml

2008-11-04 Thread Amila Suriarachchi
On Tue, Nov 4, 2008 at 8:35 PM, Deepal jayasinghe <[EMAIL PROTECTED]> wrote: > Hi Amila , > > > > IMO we need to use different extensions for different type of > > services. transport should have something like > > http.tar. I think that is why we use .aar for service archives .mar > > for modules

Re: Multiple deployers in axis2.xml

2008-11-04 Thread Deepal jayasinghe
Hi Amila , > > IMO we need to use different extensions for different type of > services. transport should have something like > http.tar. I think that is why we use .aar for service archives .mar > for modules etc. Yes I agree. But if we can have multiple deployer for same extension then why not do

Re: Multiple deployers in axis2.xml

2008-11-04 Thread Amila Suriarachchi
On Tue, Nov 4, 2008 at 7:09 PM, Deepal jayasinghe <[EMAIL PROTECTED]> wrote: > > > > > > In my point of view always deployer should only map to an > extension. > > -1 , if you think the POJO deployer it can handle both .class > > files and > > .jar files , so are you saying thats a

Re: Multiple deployers in axis2.xml

2008-11-04 Thread Deepal jayasinghe
> > > In my point of view always deployer should only map to an extension. > -1 , if you think the POJO deployer it can handle both .class > files and > .jar files , so are you saying thats a problem. If we have the > flexibility and if we doing that for a long time without an

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Amila Suriarachchi
On Mon, Nov 3, 2008 at 6:55 PM, Deepal jayasinghe <[EMAIL PROTECTED]> wrote: > > > we can do some thing like that Jboss does. In Jboss if you want to > > deploy a web application either it should be put as .war file or under > > a directory of which name ends with .war . > > > > i.e in axis2 point

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Sanjiva Weerawarana
Deepal jayasinghe wrote: Nope I did not say I am against the improvement what I told was we should not remove some working features , specially POJO deployer scenario. +1. Yes of course and I am always +1 to make things more flexible , but without breaking what we have now. That's what ve

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Deepal jayasinghe
> Hey, > > I've been working on this problem and ran into some issues and would > like to get your comments before committing a fix. The > RepositoryListener.findServicesInDirectory() scans the "services" > directory and tries to deploy service modules (.jar or .aar files) > using ServiceDeployer.

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Deepal jayasinghe
> Deepal, proposing an improvement is not saying some idea that was > implemented some time ago was bad. That was the best we could do given > the information we had then, but this is about improving things going > forward. > Nope I did not say I am against the improvement what I told was we shoul

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Sanjiva Weerawarana
Amila Suriarachchi wrote: we can do some thing like that Jboss does. In Jboss if you want to deploy a web application either it should be put as .war file or under a directory of which name ends with .war . i.e in axis2 point of view either it should be bar.aar file or bar.aar directory.

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Sanjiva Weerawarana
Deepal, proposing an improvement is not saying some idea that was implemented some time ago was bad. That was the best we could do given the information we had then, but this is about improving things going forward. There's no need to be defensive about decisions we made many years ago .. no d

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Deepal jayasinghe
> we can do some thing like that Jboss does. In Jboss if you want to > deploy a web application either it should be put as .war file or under > a directory of which name ends with .war . > > i.e in axis2 point of view either it should be bar.aar file or bar.aar > directory. > > In my point of view

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Deepal jayasinghe
> Hi Jarek, > > Hmmm .. good question. I've actually been thinking for a while that > the idea of associating a folder to a specific extension was a mistake. Nope we are not , you can have all the extensions you want in a single folder too. for example inside the POJO directory you can have both .

Re: Multiple deployers in axis2.xml

2008-11-03 Thread Amila Suriarachchi
On Mon, Nov 3, 2008 at 8:53 AM, Sanjiva Weerawarana <[EMAIL PROTECTED]>wrote: > Hi Jarek, > > Hmmm .. good question. I've actually been thinking for a while that the > idea of associating a folder to a specific extension was a mistake. To me > that's very "static" thinking and its much more conven

Re: Multiple deployers in axis2.xml

2008-11-02 Thread Sanjiva Weerawarana
Hi Jarek, Hmmm .. good question. I've actually been thinking for a while that the idea of associating a folder to a specific extension was a mistake. To me that's very "static" thinking and its much more convenient to allow people to use whatever folder hierarchy they want and just put their s

Re: Multiple deployers in axis2.xml

2008-10-30 Thread Jarek Gawor
Hey, I've been working on this problem and ran into some issues and would like to get your comments before committing a fix. The RepositoryListener.findServicesInDirectory() scans the "services" directory and tries to deploy service modules (.jar or .aar files) using ServiceDeployer. But also, whe

Re: Multiple deployers in axis2.xml

2008-10-29 Thread Sanjiva Weerawarana
Glen Daniels wrote: Hi Jarek, Deepal: Jarek Gawor wrote: Deepal, I think you misunderstood. The code assumes there is one deploeyer per extension. See DeploymentEngine.getDeployerForExtension(). That should either be: Deployer getDeployerForExtension(String directory, String extension) or L

Re: Multiple deployers in axis2.xml

2008-10-28 Thread Glen Daniels
Hi Jarek, Deepal: Jarek Gawor wrote: Deepal, I think you misunderstood. The code assumes there is one deploeyer per extension. See DeploymentEngine.getDeployerForExtension(). That should either be: Deployer getDeployerForExtension(String directory, String extension) or List getDeployerForExt

Re: Multiple deployers in axis2.xml

2008-10-28 Thread Jarek Gawor
Deepal, I think you misunderstood. The code assumes there is one deploeyer per extension. See DeploymentEngine.getDeployerForExtension(). That should either be: Deployer getDeployerForExtension(String directory, String extension) or List getDeployerForExtension(String extension) Jarek On Tue,

Re: Multiple deployers in axis2.xml

2008-10-28 Thread Deepal jayasinghe
Done. Thank you! Deepal > Hi, > > Does anyone have comments on > https://issues.apache.org/jira/browse/AXIS2-4101? In general, I would > like to know if we should allow for multiple deployers to be > registered for the same file extension (for any directory). Right now, > only one is assumed and t

Multiple deployers in axis2.xml

2008-10-28 Thread Jarek Gawor
Hi, Does anyone have comments on https://issues.apache.org/jira/browse/AXIS2-4101? In general, I would like to know if we should allow for multiple deployers to be registered for the same file extension (for any directory). Right now, only one is assumed and that causes problems. Thanks, Jarek -