Re: Fix wrong expansion of rules in bbdb-auto-notes

2011-12-27 Thread Sam Steingold
* Leo fqy@tznvy.pbz [2011-12-28 08:15:28 +0800]: On 2011-05-09 02:59 +0800, Roland Winkler wrote: 2011-12-27 Sam Steingold s...@gnu.org * lisp/bbdb.el (bbdb-auto-notes-rules): Use :set keyword to reset `bbdb-auto-notes-rules-expanded' when `bbdb-auto-notes-rules' is set.

Re: Fix wrong expansion of rules in bbdb-auto-notes

2011-05-11 Thread Roland Winkler
On Tue May 10 2011 Leo wrote: On 2011-05-09 02:59 +0800, Roland Winkler wrote: In principle there is no ambiguityconcerning lists and strings. All bbdb fields except for names and individual note fields are lists (and different notes are again forming a list). For your issue, a cleaner

Re: Fix wrong expansion of rules in bbdb-auto-notes

2011-05-11 Thread Roland Winkler
On Wed May 11 2011 Roland Winkler wrote: So maybe it is better to put the extension we are thinking about into bbdb-merge-note: - If its arg LABEL is either affix, aka, organization, or mail, this function could add a new element to the list of values of the respective field. - IF

Re: Fix wrong expansion of rules in bbdb-auto-notes

2011-05-09 Thread Leo
On 2011-05-09 02:59 +0800, Roland Winkler wrote: In principle there is no ambiguityconcerning lists and strings. All bbdb fields except for names and individual note fields are lists (and different notes are again forming a list). For your issue, a cleaner solution might be an optional

Re: Fix wrong expansion of rules in bbdb-auto-notes

2011-05-08 Thread Leo
On 2011-05-08 12:06 +0800, Roland Winkler wrote: [elide 7 lines] I guess this might depend on various issues like number of patterns and number of messages to browse. -- I have no strong feelings here. Maybe the code for processing the patterns can be optimized such that the overhead for

Re: Fix wrong expansion of rules in bbdb-auto-notes

2011-05-08 Thread Roland Winkler
On Sun May 8 2011 Leo wrote: - Another annoyance is that FIELD could only name those in NOTES. For example: (setq bbdb-auto-notes-rules '((Organization (.* organization \\ does not update the organisation of the record. When I quickly looked through some

Re: Fix wrong expansion of rules in bbdb-auto-notes

2011-05-07 Thread Roland Winkler
Thanks for the bug report fix. - Expansion of bbdb-auto-notes-rules looks cheap operation to me so caching is unnecessary. Not worth the trouble of user having to remember changing bbdb-auto-notes-rules-expanded to nil whenever they change bbdb-auto-notes-rules. I guess this might